##// END OF EJS Templates
code layout clean up of test_visible_scope_for_anonymous_with_own_issues_visibility at test/unit/issue_test.rb...
Toshi MARUYAMA -
r7486:9f7690873a9e
parent child
Show More
@@ -1,1109 +1,1111
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :trackers, :projects_trackers,
23 23 :enabled_modules,
24 24 :versions,
25 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 26 :enumerations,
27 27 :issues,
28 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 29 :time_entries
30 30
31 31 def test_create
32 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
33 33 :status_id => 1, :priority => IssuePriority.all.first,
34 34 :subject => 'test_create',
35 35 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
36 36 assert issue.save
37 37 issue.reload
38 38 assert_equal 1.5, issue.estimated_hours
39 39 end
40 40
41 41 def test_create_minimal
42 42 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
43 43 :status_id => 1, :priority => IssuePriority.all.first,
44 44 :subject => 'test_create')
45 45 assert issue.save
46 46 assert issue.description.nil?
47 47 end
48 48
49 49 def test_create_with_required_custom_field
50 50 field = IssueCustomField.find_by_name('Database')
51 51 field.update_attribute(:is_required, true)
52 52
53 53 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
54 54 :status_id => 1, :subject => 'test_create',
55 55 :description => 'IssueTest#test_create_with_required_custom_field')
56 56 assert issue.available_custom_fields.include?(field)
57 57 # No value for the custom field
58 58 assert !issue.save
59 59 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
60 60 # Blank value
61 61 issue.custom_field_values = { field.id => '' }
62 62 assert !issue.save
63 63 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
64 64 # Invalid value
65 65 issue.custom_field_values = { field.id => 'SQLServer' }
66 66 assert !issue.save
67 67 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
68 68 # Valid value
69 69 issue.custom_field_values = { field.id => 'PostgreSQL' }
70 70 assert issue.save
71 71 issue.reload
72 72 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
73 73 end
74 74
75 75 def test_create_with_group_assignment
76 76 with_settings :issue_group_assignment => '1' do
77 77 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
78 78 :subject => 'Group assignment',
79 79 :assigned_to_id => 11).save
80 80 issue = Issue.first(:order => 'id DESC')
81 81 assert_kind_of Group, issue.assigned_to
82 82 assert_equal Group.find(11), issue.assigned_to
83 83 end
84 84 end
85 85
86 86 def assert_visibility_match(user, issues)
87 87 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
88 88 end
89 89
90 90 def test_visible_scope_for_anonymous
91 91 # Anonymous user should see issues of public projects only
92 92 issues = Issue.visible(User.anonymous).all
93 93 assert issues.any?
94 94 assert_nil issues.detect {|issue| !issue.project.is_public?}
95 95 assert_nil issues.detect {|issue| issue.is_private?}
96 96 assert_visibility_match User.anonymous, issues
97 97 end
98 98
99 99 def test_visible_scope_for_anonymous_with_own_issues_visibility
100 100 Role.anonymous.update_attribute :issues_visibility, 'own'
101 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
101 Issue.create!(:project_id => 1, :tracker_id => 1,
102 :author_id => User.anonymous.id,
103 :subject => 'Issue by anonymous')
102 104
103 105 issues = Issue.visible(User.anonymous).all
104 106 assert issues.any?
105 107 assert_nil issues.detect {|issue| issue.author != User.anonymous}
106 108 assert_visibility_match User.anonymous, issues
107 109 end
108 110
109 111 def test_visible_scope_for_anonymous_without_view_issues_permissions
110 112 # Anonymous user should not see issues without permission
111 113 Role.anonymous.remove_permission!(:view_issues)
112 114 issues = Issue.visible(User.anonymous).all
113 115 assert issues.empty?
114 116 assert_visibility_match User.anonymous, issues
115 117 end
116 118
117 119 def test_visible_scope_for_non_member
118 120 user = User.find(9)
119 121 assert user.projects.empty?
120 122 # Non member user should see issues of public projects only
121 123 issues = Issue.visible(user).all
122 124 assert issues.any?
123 125 assert_nil issues.detect {|issue| !issue.project.is_public?}
124 126 assert_nil issues.detect {|issue| issue.is_private?}
125 127 assert_visibility_match user, issues
126 128 end
127 129
128 130 def test_visible_scope_for_non_member_with_own_issues_visibility
129 131 Role.non_member.update_attribute :issues_visibility, 'own'
130 132 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
131 133 user = User.find(9)
132 134
133 135 issues = Issue.visible(user).all
134 136 assert issues.any?
135 137 assert_nil issues.detect {|issue| issue.author != user}
136 138 assert_visibility_match user, issues
137 139 end
138 140
139 141 def test_visible_scope_for_non_member_without_view_issues_permissions
140 142 # Non member user should not see issues without permission
141 143 Role.non_member.remove_permission!(:view_issues)
142 144 user = User.find(9)
143 145 assert user.projects.empty?
144 146 issues = Issue.visible(user).all
145 147 assert issues.empty?
146 148 assert_visibility_match user, issues
147 149 end
148 150
149 151 def test_visible_scope_for_member
150 152 user = User.find(9)
151 153 # User should see issues of projects for which he has view_issues permissions only
152 154 Role.non_member.remove_permission!(:view_issues)
153 155 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
154 156 issues = Issue.visible(user).all
155 157 assert issues.any?
156 158 assert_nil issues.detect {|issue| issue.project_id != 3}
157 159 assert_nil issues.detect {|issue| issue.is_private?}
158 160 assert_visibility_match user, issues
159 161 end
160 162
161 163 def test_visible_scope_for_admin
162 164 user = User.find(1)
163 165 user.members.each(&:destroy)
164 166 assert user.projects.empty?
165 167 issues = Issue.visible(user).all
166 168 assert issues.any?
167 169 # Admin should see issues on private projects that he does not belong to
168 170 assert issues.detect {|issue| !issue.project.is_public?}
169 171 # Admin should see private issues of other users
170 172 assert issues.detect {|issue| issue.is_private? && issue.author != user}
171 173 assert_visibility_match user, issues
172 174 end
173 175
174 176 def test_visible_scope_with_project
175 177 project = Project.find(1)
176 178 issues = Issue.visible(User.find(2), :project => project).all
177 179 projects = issues.collect(&:project).uniq
178 180 assert_equal 1, projects.size
179 181 assert_equal project, projects.first
180 182 end
181 183
182 184 def test_visible_scope_with_project_and_subprojects
183 185 project = Project.find(1)
184 186 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
185 187 projects = issues.collect(&:project).uniq
186 188 assert projects.size > 1
187 189 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
188 190 end
189 191
190 192 def test_visible_and_nested_set_scopes
191 193 assert_equal 0, Issue.find(1).descendants.visible.all.size
192 194 end
193 195
194 196 def test_errors_full_messages_should_include_custom_fields_errors
195 197 field = IssueCustomField.find_by_name('Database')
196 198
197 199 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
198 200 :status_id => 1, :subject => 'test_create',
199 201 :description => 'IssueTest#test_create_with_required_custom_field')
200 202 assert issue.available_custom_fields.include?(field)
201 203 # Invalid value
202 204 issue.custom_field_values = { field.id => 'SQLServer' }
203 205
204 206 assert !issue.valid?
205 207 assert_equal 1, issue.errors.full_messages.size
206 208 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
207 209 issue.errors.full_messages.first
208 210 end
209 211
210 212 def test_update_issue_with_required_custom_field
211 213 field = IssueCustomField.find_by_name('Database')
212 214 field.update_attribute(:is_required, true)
213 215
214 216 issue = Issue.find(1)
215 217 assert_nil issue.custom_value_for(field)
216 218 assert issue.available_custom_fields.include?(field)
217 219 # No change to custom values, issue can be saved
218 220 assert issue.save
219 221 # Blank value
220 222 issue.custom_field_values = { field.id => '' }
221 223 assert !issue.save
222 224 # Valid value
223 225 issue.custom_field_values = { field.id => 'PostgreSQL' }
224 226 assert issue.save
225 227 issue.reload
226 228 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
227 229 end
228 230
229 231 def test_should_not_update_attributes_if_custom_fields_validation_fails
230 232 issue = Issue.find(1)
231 233 field = IssueCustomField.find_by_name('Database')
232 234 assert issue.available_custom_fields.include?(field)
233 235
234 236 issue.custom_field_values = { field.id => 'Invalid' }
235 237 issue.subject = 'Should be not be saved'
236 238 assert !issue.save
237 239
238 240 issue.reload
239 241 assert_equal "Can't print recipes", issue.subject
240 242 end
241 243
242 244 def test_should_not_recreate_custom_values_objects_on_update
243 245 field = IssueCustomField.find_by_name('Database')
244 246
245 247 issue = Issue.find(1)
246 248 issue.custom_field_values = { field.id => 'PostgreSQL' }
247 249 assert issue.save
248 250 custom_value = issue.custom_value_for(field)
249 251 issue.reload
250 252 issue.custom_field_values = { field.id => 'MySQL' }
251 253 assert issue.save
252 254 issue.reload
253 255 assert_equal custom_value.id, issue.custom_value_for(field).id
254 256 end
255 257
256 258 def test_assigning_tracker_id_should_reload_custom_fields_values
257 259 issue = Issue.new(:project => Project.find(1))
258 260 assert issue.custom_field_values.empty?
259 261 issue.tracker_id = 1
260 262 assert issue.custom_field_values.any?
261 263 end
262 264
263 265 def test_assigning_attributes_should_assign_tracker_id_first
264 266 attributes = ActiveSupport::OrderedHash.new
265 267 attributes['custom_field_values'] = { '1' => 'MySQL' }
266 268 attributes['tracker_id'] = '1'
267 269 issue = Issue.new(:project => Project.find(1))
268 270 issue.attributes = attributes
269 271 assert_not_nil issue.custom_value_for(1)
270 272 assert_equal 'MySQL', issue.custom_value_for(1).value
271 273 end
272 274
273 275 def test_should_update_issue_with_disabled_tracker
274 276 p = Project.find(1)
275 277 issue = Issue.find(1)
276 278
277 279 p.trackers.delete(issue.tracker)
278 280 assert !p.trackers.include?(issue.tracker)
279 281
280 282 issue.reload
281 283 issue.subject = 'New subject'
282 284 assert issue.save
283 285 end
284 286
285 287 def test_should_not_set_a_disabled_tracker
286 288 p = Project.find(1)
287 289 p.trackers.delete(Tracker.find(2))
288 290
289 291 issue = Issue.find(1)
290 292 issue.tracker_id = 2
291 293 issue.subject = 'New subject'
292 294 assert !issue.save
293 295 assert_not_nil issue.errors[:tracker_id]
294 296 end
295 297
296 298 def test_category_based_assignment
297 299 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
298 300 :status_id => 1, :priority => IssuePriority.all.first,
299 301 :subject => 'Assignment test',
300 302 :description => 'Assignment test', :category_id => 1)
301 303 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
302 304 end
303 305
304 306 def test_new_statuses_allowed_to
305 307 Workflow.delete_all
306 308
307 309 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
308 310 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
309 311 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
310 312 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
311 313 status = IssueStatus.find(1)
312 314 role = Role.find(1)
313 315 tracker = Tracker.find(1)
314 316 user = User.find(2)
315 317
316 318 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
317 319 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
318 320
319 321 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
320 322 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
321 323
322 324 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
323 325 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
324 326
325 327 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
326 328 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
327 329 end
328 330
329 331 def test_copy
330 332 issue = Issue.new.copy_from(1)
331 333 assert issue.save
332 334 issue.reload
333 335 orig = Issue.find(1)
334 336 assert_equal orig.subject, issue.subject
335 337 assert_equal orig.tracker, issue.tracker
336 338 assert_equal "125", issue.custom_value_for(2).value
337 339 end
338 340
339 341 def test_copy_should_copy_status
340 342 orig = Issue.find(8)
341 343 assert orig.status != IssueStatus.default
342 344
343 345 issue = Issue.new.copy_from(orig)
344 346 assert issue.save
345 347 issue.reload
346 348 assert_equal orig.status, issue.status
347 349 end
348 350
349 351 def test_should_close_duplicates
350 352 # Create 3 issues
351 353 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
352 354 :status_id => 1, :priority => IssuePriority.all.first,
353 355 :subject => 'Duplicates test', :description => 'Duplicates test')
354 356 assert issue1.save
355 357 issue2 = issue1.clone
356 358 assert issue2.save
357 359 issue3 = issue1.clone
358 360 assert issue3.save
359 361
360 362 # 2 is a dupe of 1
361 363 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
362 364 # And 3 is a dupe of 2
363 365 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
364 366 # And 3 is a dupe of 1 (circular duplicates)
365 367 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
366 368
367 369 assert issue1.reload.duplicates.include?(issue2)
368 370
369 371 # Closing issue 1
370 372 issue1.init_journal(User.find(:first), "Closing issue1")
371 373 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
372 374 assert issue1.save
373 375 # 2 and 3 should be also closed
374 376 assert issue2.reload.closed?
375 377 assert issue3.reload.closed?
376 378 end
377 379
378 380 def test_should_not_close_duplicated_issue
379 381 # Create 3 issues
380 382 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
381 383 :status_id => 1, :priority => IssuePriority.all.first,
382 384 :subject => 'Duplicates test', :description => 'Duplicates test')
383 385 assert issue1.save
384 386 issue2 = issue1.clone
385 387 assert issue2.save
386 388
387 389 # 2 is a dupe of 1
388 390 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
389 391 # 2 is a dup of 1 but 1 is not a duplicate of 2
390 392 assert !issue2.reload.duplicates.include?(issue1)
391 393
392 394 # Closing issue 2
393 395 issue2.init_journal(User.find(:first), "Closing issue2")
394 396 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
395 397 assert issue2.save
396 398 # 1 should not be also closed
397 399 assert !issue1.reload.closed?
398 400 end
399 401
400 402 def test_assignable_versions
401 403 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
402 404 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
403 405 end
404 406
405 407 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
406 408 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
407 409 assert !issue.save
408 410 assert_not_nil issue.errors.on(:fixed_version_id)
409 411 end
410 412
411 413 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
412 414 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
413 415 assert !issue.save
414 416 assert_not_nil issue.errors.on(:fixed_version_id)
415 417 end
416 418
417 419 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
418 420 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
419 421 assert issue.save
420 422 end
421 423
422 424 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
423 425 issue = Issue.find(11)
424 426 assert_equal 'closed', issue.fixed_version.status
425 427 issue.subject = 'Subject changed'
426 428 assert issue.save
427 429 end
428 430
429 431 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
430 432 issue = Issue.find(11)
431 433 issue.status_id = 1
432 434 assert !issue.save
433 435 assert_not_nil issue.errors.on_base
434 436 end
435 437
436 438 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
437 439 issue = Issue.find(11)
438 440 issue.status_id = 1
439 441 issue.fixed_version_id = 3
440 442 assert issue.save
441 443 end
442 444
443 445 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
444 446 issue = Issue.find(12)
445 447 assert_equal 'locked', issue.fixed_version.status
446 448 issue.status_id = 1
447 449 assert issue.save
448 450 end
449 451
450 452 def test_move_to_another_project_with_same_category
451 453 issue = Issue.find(1)
452 454 assert issue.move_to_project(Project.find(2))
453 455 issue.reload
454 456 assert_equal 2, issue.project_id
455 457 # Category changes
456 458 assert_equal 4, issue.category_id
457 459 # Make sure time entries were move to the target project
458 460 assert_equal 2, issue.time_entries.first.project_id
459 461 end
460 462
461 463 def test_move_to_another_project_without_same_category
462 464 issue = Issue.find(2)
463 465 assert issue.move_to_project(Project.find(2))
464 466 issue.reload
465 467 assert_equal 2, issue.project_id
466 468 # Category cleared
467 469 assert_nil issue.category_id
468 470 end
469 471
470 472 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
471 473 issue = Issue.find(1)
472 474 issue.update_attribute(:fixed_version_id, 1)
473 475 assert issue.move_to_project(Project.find(2))
474 476 issue.reload
475 477 assert_equal 2, issue.project_id
476 478 # Cleared fixed_version
477 479 assert_equal nil, issue.fixed_version
478 480 end
479 481
480 482 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
481 483 issue = Issue.find(1)
482 484 issue.update_attribute(:fixed_version_id, 4)
483 485 assert issue.move_to_project(Project.find(5))
484 486 issue.reload
485 487 assert_equal 5, issue.project_id
486 488 # Keep fixed_version
487 489 assert_equal 4, issue.fixed_version_id
488 490 end
489 491
490 492 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
491 493 issue = Issue.find(1)
492 494 issue.update_attribute(:fixed_version_id, 1)
493 495 assert issue.move_to_project(Project.find(5))
494 496 issue.reload
495 497 assert_equal 5, issue.project_id
496 498 # Cleared fixed_version
497 499 assert_equal nil, issue.fixed_version
498 500 end
499 501
500 502 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
501 503 issue = Issue.find(1)
502 504 issue.update_attribute(:fixed_version_id, 7)
503 505 assert issue.move_to_project(Project.find(2))
504 506 issue.reload
505 507 assert_equal 2, issue.project_id
506 508 # Keep fixed_version
507 509 assert_equal 7, issue.fixed_version_id
508 510 end
509 511
510 512 def test_move_to_another_project_with_disabled_tracker
511 513 issue = Issue.find(1)
512 514 target = Project.find(2)
513 515 target.tracker_ids = [3]
514 516 target.save
515 517 assert_equal false, issue.move_to_project(target)
516 518 issue.reload
517 519 assert_equal 1, issue.project_id
518 520 end
519 521
520 522 def test_copy_to_the_same_project
521 523 issue = Issue.find(1)
522 524 copy = nil
523 525 assert_difference 'Issue.count' do
524 526 copy = issue.move_to_project(issue.project, nil, :copy => true)
525 527 end
526 528 assert_kind_of Issue, copy
527 529 assert_equal issue.project, copy.project
528 530 assert_equal "125", copy.custom_value_for(2).value
529 531 end
530 532
531 533 def test_copy_to_another_project_and_tracker
532 534 issue = Issue.find(1)
533 535 copy = nil
534 536 assert_difference 'Issue.count' do
535 537 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
536 538 end
537 539 copy.reload
538 540 assert_kind_of Issue, copy
539 541 assert_equal Project.find(3), copy.project
540 542 assert_equal Tracker.find(2), copy.tracker
541 543 # Custom field #2 is not associated with target tracker
542 544 assert_nil copy.custom_value_for(2)
543 545 end
544 546
545 547 context "#move_to_project" do
546 548 context "as a copy" do
547 549 setup do
548 550 @issue = Issue.find(1)
549 551 @copy = nil
550 552 end
551 553
552 554 should "not create a journal" do
553 555 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
554 556 assert_equal 0, @copy.reload.journals.size
555 557 end
556 558
557 559 should "allow assigned_to changes" do
558 560 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
559 561 assert_equal 3, @copy.assigned_to_id
560 562 end
561 563
562 564 should "allow status changes" do
563 565 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
564 566 assert_equal 2, @copy.status_id
565 567 end
566 568
567 569 should "allow start date changes" do
568 570 date = Date.today
569 571 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
570 572 assert_equal date, @copy.start_date
571 573 end
572 574
573 575 should "allow due date changes" do
574 576 date = Date.today
575 577 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
576 578
577 579 assert_equal date, @copy.due_date
578 580 end
579 581
580 582 should "set current user as author" do
581 583 User.current = User.find(9)
582 584 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
583 585
584 586 assert_equal User.current, @copy.author
585 587 end
586 588
587 589 should "keep journal notes" do
588 590 date = Date.today
589 591 notes = "Notes added when copying"
590 592 User.current = User.find(9)
591 593 @issue.init_journal(User.current, notes)
592 594 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
593 595
594 596 assert_equal 1, @copy.journals.size
595 597 journal = @copy.journals.first
596 598 assert_equal 0, journal.details.size
597 599 assert_equal notes, journal.notes
598 600 end
599 601 end
600 602 end
601 603
602 604 def test_recipients_should_not_include_users_that_cannot_view_the_issue
603 605 issue = Issue.find(12)
604 606 assert issue.recipients.include?(issue.author.mail)
605 607 # move the issue to a private project
606 608 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
607 609 # author is not a member of project anymore
608 610 assert !copy.recipients.include?(copy.author.mail)
609 611 end
610 612
611 613 def test_recipients_should_include_the_assigned_group_members
612 614 group_member = User.generate_with_protected!
613 615 group = Group.generate!
614 616 group.users << group_member
615 617
616 618 issue = Issue.find(12)
617 619 issue.assigned_to = group
618 620 assert issue.recipients.include?(group_member.mail)
619 621 end
620 622
621 623 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
622 624 user = User.find(3)
623 625 issue = Issue.find(9)
624 626 Watcher.create!(:user => user, :watchable => issue)
625 627 assert issue.watched_by?(user)
626 628 assert !issue.watcher_recipients.include?(user.mail)
627 629 end
628 630
629 631 def test_issue_destroy
630 632 Issue.find(1).destroy
631 633 assert_nil Issue.find_by_id(1)
632 634 assert_nil TimeEntry.find_by_issue_id(1)
633 635 end
634 636
635 637 def test_blocked
636 638 blocked_issue = Issue.find(9)
637 639 blocking_issue = Issue.find(10)
638 640
639 641 assert blocked_issue.blocked?
640 642 assert !blocking_issue.blocked?
641 643 end
642 644
643 645 def test_blocked_issues_dont_allow_closed_statuses
644 646 blocked_issue = Issue.find(9)
645 647
646 648 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
647 649 assert !allowed_statuses.empty?
648 650 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
649 651 assert closed_statuses.empty?
650 652 end
651 653
652 654 def test_unblocked_issues_allow_closed_statuses
653 655 blocking_issue = Issue.find(10)
654 656
655 657 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
656 658 assert !allowed_statuses.empty?
657 659 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
658 660 assert !closed_statuses.empty?
659 661 end
660 662
661 663 def test_rescheduling_an_issue_should_reschedule_following_issue
662 664 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
663 665 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
664 666 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
665 667 assert_equal issue1.due_date + 1, issue2.reload.start_date
666 668
667 669 issue1.due_date = Date.today + 5
668 670 issue1.save!
669 671 assert_equal issue1.due_date + 1, issue2.reload.start_date
670 672 end
671 673
672 674 def test_overdue
673 675 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
674 676 assert !Issue.new(:due_date => Date.today).overdue?
675 677 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
676 678 assert !Issue.new(:due_date => nil).overdue?
677 679 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
678 680 end
679 681
680 682 context "#behind_schedule?" do
681 683 should "be false if the issue has no start_date" do
682 684 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
683 685 end
684 686
685 687 should "be false if the issue has no end_date" do
686 688 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
687 689 end
688 690
689 691 should "be false if the issue has more done than it's calendar time" do
690 692 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
691 693 end
692 694
693 695 should "be true if the issue hasn't been started at all" do
694 696 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
695 697 end
696 698
697 699 should "be true if the issue has used more calendar time than it's done ratio" do
698 700 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
699 701 end
700 702 end
701 703
702 704 context "#assignable_users" do
703 705 should "be Users" do
704 706 assert_kind_of User, Issue.find(1).assignable_users.first
705 707 end
706 708
707 709 should "include the issue author" do
708 710 project = Project.find(1)
709 711 non_project_member = User.generate!
710 712 issue = Issue.generate_for_project!(project, :author => non_project_member)
711 713
712 714 assert issue.assignable_users.include?(non_project_member)
713 715 end
714 716
715 717 should "include the current assignee" do
716 718 project = Project.find(1)
717 719 user = User.generate!
718 720 issue = Issue.generate_for_project!(project, :assigned_to => user)
719 721 user.lock!
720 722
721 723 assert Issue.find(issue.id).assignable_users.include?(user)
722 724 end
723 725
724 726 should "not show the issue author twice" do
725 727 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
726 728 assert_equal 2, assignable_user_ids.length
727 729
728 730 assignable_user_ids.each do |user_id|
729 731 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
730 732 end
731 733 end
732 734
733 735 context "with issue_group_assignment" do
734 736 should "include groups" do
735 737 issue = Issue.new(:project => Project.find(2))
736 738
737 739 with_settings :issue_group_assignment => '1' do
738 740 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
739 741 assert issue.assignable_users.include?(Group.find(11))
740 742 end
741 743 end
742 744 end
743 745
744 746 context "without issue_group_assignment" do
745 747 should "not include groups" do
746 748 issue = Issue.new(:project => Project.find(2))
747 749
748 750 with_settings :issue_group_assignment => '0' do
749 751 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
750 752 assert !issue.assignable_users.include?(Group.find(11))
751 753 end
752 754 end
753 755 end
754 756 end
755 757
756 758 def test_create_should_send_email_notification
757 759 ActionMailer::Base.deliveries.clear
758 760 issue = Issue.new(:project_id => 1, :tracker_id => 1,
759 761 :author_id => 3, :status_id => 1,
760 762 :priority => IssuePriority.all.first,
761 763 :subject => 'test_create', :estimated_hours => '1:30')
762 764
763 765 assert issue.save
764 766 assert_equal 1, ActionMailer::Base.deliveries.size
765 767 end
766 768
767 769 def test_stale_issue_should_not_send_email_notification
768 770 ActionMailer::Base.deliveries.clear
769 771 issue = Issue.find(1)
770 772 stale = Issue.find(1)
771 773
772 774 issue.init_journal(User.find(1))
773 775 issue.subject = 'Subjet update'
774 776 assert issue.save
775 777 assert_equal 1, ActionMailer::Base.deliveries.size
776 778 ActionMailer::Base.deliveries.clear
777 779
778 780 stale.init_journal(User.find(1))
779 781 stale.subject = 'Another subjet update'
780 782 assert_raise ActiveRecord::StaleObjectError do
781 783 stale.save
782 784 end
783 785 assert ActionMailer::Base.deliveries.empty?
784 786 end
785 787
786 788 def test_journalized_description
787 789 IssueCustomField.delete_all
788 790
789 791 i = Issue.first
790 792 old_description = i.description
791 793 new_description = "This is the new description"
792 794
793 795 i.init_journal(User.find(2))
794 796 i.description = new_description
795 797 assert_difference 'Journal.count', 1 do
796 798 assert_difference 'JournalDetail.count', 1 do
797 799 i.save!
798 800 end
799 801 end
800 802
801 803 detail = JournalDetail.first(:order => 'id DESC')
802 804 assert_equal i, detail.journal.journalized
803 805 assert_equal 'attr', detail.property
804 806 assert_equal 'description', detail.prop_key
805 807 assert_equal old_description, detail.old_value
806 808 assert_equal new_description, detail.value
807 809 end
808 810
809 811 def test_blank_descriptions_should_not_be_journalized
810 812 IssueCustomField.delete_all
811 813 Issue.update_all("description = NULL", "id=1")
812 814
813 815 i = Issue.find(1)
814 816 i.init_journal(User.find(2))
815 817 i.subject = "blank description"
816 818 i.description = "\r\n"
817 819
818 820 assert_difference 'Journal.count', 1 do
819 821 assert_difference 'JournalDetail.count', 1 do
820 822 i.save!
821 823 end
822 824 end
823 825 end
824 826
825 827 def test_description_eol_should_be_normalized
826 828 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
827 829 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
828 830 end
829 831
830 832 def test_saving_twice_should_not_duplicate_journal_details
831 833 i = Issue.find(:first)
832 834 i.init_journal(User.find(2), 'Some notes')
833 835 # initial changes
834 836 i.subject = 'New subject'
835 837 i.done_ratio = i.done_ratio + 10
836 838 assert_difference 'Journal.count' do
837 839 assert i.save
838 840 end
839 841 # 1 more change
840 842 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
841 843 assert_no_difference 'Journal.count' do
842 844 assert_difference 'JournalDetail.count', 1 do
843 845 i.save
844 846 end
845 847 end
846 848 # no more change
847 849 assert_no_difference 'Journal.count' do
848 850 assert_no_difference 'JournalDetail.count' do
849 851 i.save
850 852 end
851 853 end
852 854 end
853 855
854 856 def test_all_dependent_issues
855 857 IssueRelation.delete_all
856 858 assert IssueRelation.create!(:issue_from => Issue.find(1),
857 859 :issue_to => Issue.find(2),
858 860 :relation_type => IssueRelation::TYPE_PRECEDES)
859 861 assert IssueRelation.create!(:issue_from => Issue.find(2),
860 862 :issue_to => Issue.find(3),
861 863 :relation_type => IssueRelation::TYPE_PRECEDES)
862 864 assert IssueRelation.create!(:issue_from => Issue.find(3),
863 865 :issue_to => Issue.find(8),
864 866 :relation_type => IssueRelation::TYPE_PRECEDES)
865 867
866 868 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
867 869 end
868 870
869 871 def test_all_dependent_issues_with_persistent_circular_dependency
870 872 IssueRelation.delete_all
871 873 assert IssueRelation.create!(:issue_from => Issue.find(1),
872 874 :issue_to => Issue.find(2),
873 875 :relation_type => IssueRelation::TYPE_PRECEDES)
874 876 assert IssueRelation.create!(:issue_from => Issue.find(2),
875 877 :issue_to => Issue.find(3),
876 878 :relation_type => IssueRelation::TYPE_PRECEDES)
877 879 # Validation skipping
878 880 assert IssueRelation.new(:issue_from => Issue.find(3),
879 881 :issue_to => Issue.find(1),
880 882 :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
881 883
882 884 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
883 885 end
884 886
885 887 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
886 888 IssueRelation.delete_all
887 889 assert IssueRelation.create!(:issue_from => Issue.find(1),
888 890 :issue_to => Issue.find(2),
889 891 :relation_type => IssueRelation::TYPE_RELATES)
890 892 assert IssueRelation.create!(:issue_from => Issue.find(2),
891 893 :issue_to => Issue.find(3),
892 894 :relation_type => IssueRelation::TYPE_RELATES)
893 895 assert IssueRelation.create!(:issue_from => Issue.find(3),
894 896 :issue_to => Issue.find(8),
895 897 :relation_type => IssueRelation::TYPE_RELATES)
896 898 # Validation skipping
897 899 assert IssueRelation.new(:issue_from => Issue.find(8),
898 900 :issue_to => Issue.find(2),
899 901 :relation_type => IssueRelation::TYPE_RELATES).save(false)
900 902 assert IssueRelation.new(:issue_from => Issue.find(3),
901 903 :issue_to => Issue.find(1),
902 904 :relation_type => IssueRelation::TYPE_RELATES).save(false)
903 905
904 906 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
905 907 end
906 908
907 909 context "#done_ratio" do
908 910 setup do
909 911 @issue = Issue.find(1)
910 912 @issue_status = IssueStatus.find(1)
911 913 @issue_status.update_attribute(:default_done_ratio, 50)
912 914 @issue2 = Issue.find(2)
913 915 @issue_status2 = IssueStatus.find(2)
914 916 @issue_status2.update_attribute(:default_done_ratio, 0)
915 917 end
916 918
917 919 context "with Setting.issue_done_ratio using the issue_field" do
918 920 setup do
919 921 Setting.issue_done_ratio = 'issue_field'
920 922 end
921 923
922 924 should "read the issue's field" do
923 925 assert_equal 0, @issue.done_ratio
924 926 assert_equal 30, @issue2.done_ratio
925 927 end
926 928 end
927 929
928 930 context "with Setting.issue_done_ratio using the issue_status" do
929 931 setup do
930 932 Setting.issue_done_ratio = 'issue_status'
931 933 end
932 934
933 935 should "read the Issue Status's default done ratio" do
934 936 assert_equal 50, @issue.done_ratio
935 937 assert_equal 0, @issue2.done_ratio
936 938 end
937 939 end
938 940 end
939 941
940 942 context "#update_done_ratio_from_issue_status" do
941 943 setup do
942 944 @issue = Issue.find(1)
943 945 @issue_status = IssueStatus.find(1)
944 946 @issue_status.update_attribute(:default_done_ratio, 50)
945 947 @issue2 = Issue.find(2)
946 948 @issue_status2 = IssueStatus.find(2)
947 949 @issue_status2.update_attribute(:default_done_ratio, 0)
948 950 end
949 951
950 952 context "with Setting.issue_done_ratio using the issue_field" do
951 953 setup do
952 954 Setting.issue_done_ratio = 'issue_field'
953 955 end
954 956
955 957 should "not change the issue" do
956 958 @issue.update_done_ratio_from_issue_status
957 959 @issue2.update_done_ratio_from_issue_status
958 960
959 961 assert_equal 0, @issue.read_attribute(:done_ratio)
960 962 assert_equal 30, @issue2.read_attribute(:done_ratio)
961 963 end
962 964 end
963 965
964 966 context "with Setting.issue_done_ratio using the issue_status" do
965 967 setup do
966 968 Setting.issue_done_ratio = 'issue_status'
967 969 end
968 970
969 971 should "change the issue's done ratio" do
970 972 @issue.update_done_ratio_from_issue_status
971 973 @issue2.update_done_ratio_from_issue_status
972 974
973 975 assert_equal 50, @issue.read_attribute(:done_ratio)
974 976 assert_equal 0, @issue2.read_attribute(:done_ratio)
975 977 end
976 978 end
977 979 end
978 980
979 981 test "#by_tracker" do
980 982 User.current = User.anonymous
981 983 groups = Issue.by_tracker(Project.find(1))
982 984 assert_equal 3, groups.size
983 985 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
984 986 end
985 987
986 988 test "#by_version" do
987 989 User.current = User.anonymous
988 990 groups = Issue.by_version(Project.find(1))
989 991 assert_equal 3, groups.size
990 992 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
991 993 end
992 994
993 995 test "#by_priority" do
994 996 User.current = User.anonymous
995 997 groups = Issue.by_priority(Project.find(1))
996 998 assert_equal 4, groups.size
997 999 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
998 1000 end
999 1001
1000 1002 test "#by_category" do
1001 1003 User.current = User.anonymous
1002 1004 groups = Issue.by_category(Project.find(1))
1003 1005 assert_equal 2, groups.size
1004 1006 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1005 1007 end
1006 1008
1007 1009 test "#by_assigned_to" do
1008 1010 User.current = User.anonymous
1009 1011 groups = Issue.by_assigned_to(Project.find(1))
1010 1012 assert_equal 2, groups.size
1011 1013 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1012 1014 end
1013 1015
1014 1016 test "#by_author" do
1015 1017 User.current = User.anonymous
1016 1018 groups = Issue.by_author(Project.find(1))
1017 1019 assert_equal 4, groups.size
1018 1020 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1019 1021 end
1020 1022
1021 1023 test "#by_subproject" do
1022 1024 User.current = User.anonymous
1023 1025 groups = Issue.by_subproject(Project.find(1))
1024 1026 # Private descendant not visible
1025 1027 assert_equal 1, groups.size
1026 1028 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1027 1029 end
1028 1030
1029 1031 context ".allowed_target_projects_on_move" do
1030 1032 should "return all active projects for admin users" do
1031 1033 User.current = User.find(1)
1032 1034 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1033 1035 end
1034 1036
1035 1037 should "return allowed projects for non admin users" do
1036 1038 User.current = User.find(2)
1037 1039 Role.non_member.remove_permission! :move_issues
1038 1040 assert_equal 3, Issue.allowed_target_projects_on_move.size
1039 1041
1040 1042 Role.non_member.add_permission! :move_issues
1041 1043 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1042 1044 end
1043 1045 end
1044 1046
1045 1047 def test_recently_updated_with_limit_scopes
1046 1048 #should return the last updated issue
1047 1049 assert_equal 1, Issue.recently_updated.with_limit(1).length
1048 1050 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1049 1051 end
1050 1052
1051 1053 def test_on_active_projects_scope
1052 1054 assert Project.find(2).archive
1053 1055
1054 1056 before = Issue.on_active_project.length
1055 1057 # test inclusion to results
1056 1058 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1057 1059 assert_equal before + 1, Issue.on_active_project.length
1058 1060
1059 1061 # Move to an archived project
1060 1062 issue.project = Project.find(2)
1061 1063 assert issue.save
1062 1064 assert_equal before, Issue.on_active_project.length
1063 1065 end
1064 1066
1065 1067 context "Issue#recipients" do
1066 1068 setup do
1067 1069 @project = Project.find(1)
1068 1070 @author = User.generate_with_protected!
1069 1071 @assignee = User.generate_with_protected!
1070 1072 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1071 1073 end
1072 1074
1073 1075 should "include project recipients" do
1074 1076 assert @project.recipients.present?
1075 1077 @project.recipients.each do |project_recipient|
1076 1078 assert @issue.recipients.include?(project_recipient)
1077 1079 end
1078 1080 end
1079 1081
1080 1082 should "include the author if the author is active" do
1081 1083 assert @issue.author, "No author set for Issue"
1082 1084 assert @issue.recipients.include?(@issue.author.mail)
1083 1085 end
1084 1086
1085 1087 should "include the assigned to user if the assigned to user is active" do
1086 1088 assert @issue.assigned_to, "No assigned_to set for Issue"
1087 1089 assert @issue.recipients.include?(@issue.assigned_to.mail)
1088 1090 end
1089 1091
1090 1092 should "not include users who opt out of all email" do
1091 1093 @author.update_attribute(:mail_notification, :none)
1092 1094
1093 1095 assert !@issue.recipients.include?(@issue.author.mail)
1094 1096 end
1095 1097
1096 1098 should "not include the issue author if they are only notified of assigned issues" do
1097 1099 @author.update_attribute(:mail_notification, :only_assigned)
1098 1100
1099 1101 assert !@issue.recipients.include?(@issue.author.mail)
1100 1102 end
1101 1103
1102 1104 should "not include the assigned user if they are only notified of owned issues" do
1103 1105 @assignee.update_attribute(:mail_notification, :only_owner)
1104 1106
1105 1107 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1106 1108 end
1107 1109
1108 1110 end
1109 1111 end
General Comments 0
You need to be logged in to leave comments. Login now