jro_apps/redmine Commit - r9436:9f396a6dfbb9

Fixed undefined method `<=>' for nil:NilClass when sorting repositories with nil identifiers (#10827)....

Jean-Philippe Lang -

r9436:9f396a6dfbb9

parent child

Context file:

r9436:9f396a6dfbb9

app/models/repository.rb +1 -1

                  elsif repository.is_default?
 
                  else
-                   identifier <=> repository.identifier
+                   identifier.to_s <=> repository.identifier.to_s
                  end
                end

test/unit/repository_test.rb +9 0

                  assert_equal "test_value_23",
                               repo.extra_info["test_2"]["test_23"]
                end
+               def test_sort_should_not_raise_an_error_with_nil_identifiers
+                 r1 = Repository.new
+                 r2 = Repository.new
+                 assert_nothing_raised do
+                   [r1, r2].sort
+                 end
+               end
              end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages