jro_apps/redmine Commit - r7849:9f15517095c4

Fixed: Angle brackets within 'pre' blocks are silently replaced by HTML entities during wiki section-edit (#9673)....

Jean-Philippe Lang -

r7849:9f15517095c4

parent child

Context file:

r7849:9f15517095c4

lib/redmine/wiki_formatting/textile/formatter.rb +1 -1

                     def extract_sections(index)
                       @pre_list = []
                       text = self.dup
-                      rip_offtags text
+                      rip_offtags text, false
                       before = ''
                       s = ''
                       after = ''

test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb +10 0

             h2. Inside pre
+            <tag> inside pre block
             Morbi facilisis accumsan orci non pharetra.
             </pre>",
               # 2
                 assert_section_with_hash STR_WITH_PRE[2], text, 3
               end
+              def test_update_section_should_not_escape_pre_content_outside_section
+                text = STR_WITH_PRE.join("\n\n")
+                replacement = "New text"
+                assert_equal [STR_WITH_PRE[0..1], "New text"].flatten.join("\n\n"),
+                  @formatter.new(text).update_section(3, replacement)
+              end
               private
               def assert_html_output(to_test, expect_paragraph = true)

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages