##// END OF EJS Templates
Versions that are not shared should not be assignable when selecting another project (#11506)....
Jean-Philippe Lang -
r9903:9eb041fbc799
parent child
Show More
@@ -1,1223 +1,1240
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20
21 21 belongs_to :project
22 22 belongs_to :tracker
23 23 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
24 24 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
25 25 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
26 26 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
27 27 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
28 28 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
29 29
30 30 has_many :journals, :as => :journalized, :dependent => :destroy
31 31 has_many :time_entries, :dependent => :delete_all
32 32 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
33 33
34 34 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
35 35 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
36 36
37 37 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
38 38 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
39 39 acts_as_customizable
40 40 acts_as_watchable
41 41 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
42 42 :include => [:project, :journals],
43 43 # sort by id so that limited eager loading doesn't break with postgresql
44 44 :order_column => "#{table_name}.id"
45 45 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
46 46 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
47 47 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
48 48
49 49 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
50 50 :author_key => :author_id
51 51
52 52 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
53 53
54 54 attr_reader :current_journal
55 55
56 56 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
57 57
58 58 validates_length_of :subject, :maximum => 255
59 59 validates_inclusion_of :done_ratio, :in => 0..100
60 60 validates_numericality_of :estimated_hours, :allow_nil => true
61 61 validate :validate_issue, :validate_required_fields
62 62
63 63 scope :visible,
64 64 lambda {|*args| { :include => :project,
65 65 :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
66 66
67 67 scope :open, lambda {|*args|
68 68 is_closed = args.size > 0 ? !args.first : false
69 69 {:conditions => ["#{IssueStatus.table_name}.is_closed = ?", is_closed], :include => :status}
70 70 }
71 71
72 72 scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
73 73 scope :with_limit, lambda { |limit| { :limit => limit} }
74 74 scope :on_active_project, :include => [:status, :project, :tracker],
75 75 :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
76 76
77 77 before_create :default_assign
78 78 before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change
79 79 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
80 80 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
81 81 after_destroy :update_parent_attributes
82 82
83 83 # Returns a SQL conditions string used to find all issues visible by the specified user
84 84 def self.visible_condition(user, options={})
85 85 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
86 86 case role.issues_visibility
87 87 when 'all'
88 88 nil
89 89 when 'default'
90 90 user_ids = [user.id] + user.groups.map(&:id)
91 91 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
92 92 when 'own'
93 93 user_ids = [user.id] + user.groups.map(&:id)
94 94 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
95 95 else
96 96 '1=0'
97 97 end
98 98 end
99 99 end
100 100
101 101 # Returns true if usr or current user is allowed to view the issue
102 102 def visible?(usr=nil)
103 103 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
104 104 case role.issues_visibility
105 105 when 'all'
106 106 true
107 107 when 'default'
108 108 !self.is_private? || self.author == user || user.is_or_belongs_to?(assigned_to)
109 109 when 'own'
110 110 self.author == user || user.is_or_belongs_to?(assigned_to)
111 111 else
112 112 false
113 113 end
114 114 end
115 115 end
116 116
117 117 def initialize(attributes=nil, *args)
118 118 super
119 119 if new_record?
120 120 # set default values for new records only
121 121 self.status ||= IssueStatus.default
122 122 self.priority ||= IssuePriority.default
123 123 self.watcher_user_ids = []
124 124 end
125 125 end
126 126
127 127 # AR#Persistence#destroy would raise and RecordNotFound exception
128 128 # if the issue was already deleted or updated (non matching lock_version).
129 129 # This is a problem when bulk deleting issues or deleting a project
130 130 # (because an issue may already be deleted if its parent was deleted
131 131 # first).
132 132 # The issue is reloaded by the nested_set before being deleted so
133 133 # the lock_version condition should not be an issue but we handle it.
134 134 def destroy
135 135 super
136 136 rescue ActiveRecord::RecordNotFound
137 137 # Stale or already deleted
138 138 begin
139 139 reload
140 140 rescue ActiveRecord::RecordNotFound
141 141 # The issue was actually already deleted
142 142 @destroyed = true
143 143 return freeze
144 144 end
145 145 # The issue was stale, retry to destroy
146 146 super
147 147 end
148 148
149 149 def reload(*args)
150 150 @workflow_rule_by_attribute = nil
151 @assignable_versions = nil
151 152 super
152 153 end
153 154
154 155 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
155 156 def available_custom_fields
156 157 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
157 158 end
158 159
159 160 # Copies attributes from another issue, arg can be an id or an Issue
160 161 def copy_from(arg, options={})
161 162 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
162 163 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
163 164 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
164 165 self.status = issue.status
165 166 self.author = User.current
166 167 unless options[:attachments] == false
167 168 self.attachments = issue.attachments.map do |attachement|
168 169 attachement.copy(:container => self)
169 170 end
170 171 end
171 172 @copied_from = issue
172 173 self
173 174 end
174 175
175 176 # Returns an unsaved copy of the issue
176 177 def copy(attributes=nil, copy_options={})
177 178 copy = self.class.new.copy_from(self, copy_options)
178 179 copy.attributes = attributes if attributes
179 180 copy
180 181 end
181 182
182 183 # Returns true if the issue is a copy
183 184 def copy?
184 185 @copied_from.present?
185 186 end
186 187
187 188 # Moves/copies an issue to a new project and tracker
188 189 # Returns the moved/copied issue on success, false on failure
189 190 def move_to_project(new_project, new_tracker=nil, options={})
190 191 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
191 192
192 193 if options[:copy]
193 194 issue = self.copy
194 195 else
195 196 issue = self
196 197 end
197 198
198 199 issue.init_journal(User.current, options[:notes])
199 200
200 201 # Preserve previous behaviour
201 202 # #move_to_project doesn't change tracker automatically
202 203 issue.send :project=, new_project, true
203 204 if new_tracker
204 205 issue.tracker = new_tracker
205 206 end
206 207 # Allow bulk setting of attributes on the issue
207 208 if options[:attributes]
208 209 issue.attributes = options[:attributes]
209 210 end
210 211
211 212 issue.save ? issue : false
212 213 end
213 214
214 215 def status_id=(sid)
215 216 self.status = nil
216 217 result = write_attribute(:status_id, sid)
217 218 @workflow_rule_by_attribute = nil
218 219 result
219 220 end
220 221
221 222 def priority_id=(pid)
222 223 self.priority = nil
223 224 write_attribute(:priority_id, pid)
224 225 end
225 226
226 227 def category_id=(cid)
227 228 self.category = nil
228 229 write_attribute(:category_id, cid)
229 230 end
230 231
231 232 def fixed_version_id=(vid)
232 233 self.fixed_version = nil
233 234 write_attribute(:fixed_version_id, vid)
234 235 end
235 236
236 237 def tracker_id=(tid)
237 238 self.tracker = nil
238 239 result = write_attribute(:tracker_id, tid)
239 240 @custom_field_values = nil
240 241 @workflow_rule_by_attribute = nil
241 242 result
242 243 end
243 244
244 245 def project_id=(project_id)
245 246 if project_id.to_s != self.project_id.to_s
246 247 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
247 248 end
248 249 end
249 250
250 251 def project=(project, keep_tracker=false)
251 252 project_was = self.project
252 253 write_attribute(:project_id, project ? project.id : nil)
253 254 association_instance_set('project', project)
254 255 if project_was && project && project_was != project
256 @assignable_versions = nil
257
255 258 unless keep_tracker || project.trackers.include?(tracker)
256 259 self.tracker = project.trackers.first
257 260 end
258 261 # Reassign to the category with same name if any
259 262 if category
260 263 self.category = project.issue_categories.find_by_name(category.name)
261 264 end
262 265 # Keep the fixed_version if it's still valid in the new_project
263 266 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
264 267 self.fixed_version = nil
265 268 end
266 269 if parent && parent.project_id != project_id
267 270 self.parent_issue_id = nil
268 271 end
269 272 @custom_field_values = nil
270 273 end
271 274 end
272 275
273 276 def description=(arg)
274 277 if arg.is_a?(String)
275 278 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
276 279 end
277 280 write_attribute(:description, arg)
278 281 end
279 282
280 283 # Overrides assign_attributes so that project and tracker get assigned first
281 284 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
282 285 return if new_attributes.nil?
283 286 attrs = new_attributes.dup
284 287 attrs.stringify_keys!
285 288
286 289 %w(project project_id tracker tracker_id).each do |attr|
287 290 if attrs.has_key?(attr)
288 291 send "#{attr}=", attrs.delete(attr)
289 292 end
290 293 end
291 294 send :assign_attributes_without_project_and_tracker_first, attrs, *args
292 295 end
293 296 # Do not redefine alias chain on reload (see #4838)
294 297 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
295 298
296 299 def estimated_hours=(h)
297 300 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
298 301 end
299 302
300 303 safe_attributes 'project_id',
301 304 :if => lambda {|issue, user|
302 305 if issue.new_record?
303 306 issue.copy?
304 307 elsif user.allowed_to?(:move_issues, issue.project)
305 308 projects = Issue.allowed_target_projects_on_move(user)
306 309 projects.include?(issue.project) && projects.size > 1
307 310 end
308 311 }
309 312
310 313 safe_attributes 'tracker_id',
311 314 'status_id',
312 315 'category_id',
313 316 'assigned_to_id',
314 317 'priority_id',
315 318 'fixed_version_id',
316 319 'subject',
317 320 'description',
318 321 'start_date',
319 322 'due_date',
320 323 'done_ratio',
321 324 'estimated_hours',
322 325 'custom_field_values',
323 326 'custom_fields',
324 327 'lock_version',
325 328 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
326 329
327 330 safe_attributes 'status_id',
328 331 'assigned_to_id',
329 332 'fixed_version_id',
330 333 'done_ratio',
331 334 'lock_version',
332 335 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
333 336
334 337 safe_attributes 'watcher_user_ids',
335 338 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
336 339
337 340 safe_attributes 'is_private',
338 341 :if => lambda {|issue, user|
339 342 user.allowed_to?(:set_issues_private, issue.project) ||
340 343 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
341 344 }
342 345
343 346 safe_attributes 'parent_issue_id',
344 347 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
345 348 user.allowed_to?(:manage_subtasks, issue.project)}
346 349
347 350 def safe_attribute_names(user=nil)
348 351 names = super
349 352 names -= disabled_core_fields
350 353 names -= read_only_attribute_names(user)
351 354 names
352 355 end
353 356
354 357 # Safely sets attributes
355 358 # Should be called from controllers instead of #attributes=
356 359 # attr_accessible is too rough because we still want things like
357 360 # Issue.new(:project => foo) to work
358 361 def safe_attributes=(attrs, user=User.current)
359 362 return unless attrs.is_a?(Hash)
360 363
361 364 attrs = attrs.dup
362 365
363 366 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
364 367 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
365 368 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
366 369 self.project_id = p
367 370 end
368 371 end
369 372
370 373 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
371 374 self.tracker_id = t
372 375 end
373 376
374 377 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
375 378 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
376 379 self.status_id = s
377 380 end
378 381 end
379 382
380 383 attrs = delete_unsafe_attributes(attrs, user)
381 384 return if attrs.empty?
382 385
383 386 unless leaf?
384 387 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
385 388 end
386 389
387 390 if attrs['parent_issue_id'].present?
388 391 attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
389 392 end
390 393
391 394 if attrs['custom_field_values'].present?
392 395 attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
393 396 end
394 397
395 398 if attrs['custom_fields'].present?
396 399 attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
397 400 end
398 401
399 402 # mass-assignment security bypass
400 403 assign_attributes attrs, :without_protection => true
401 404 end
402 405
403 406 def disabled_core_fields
404 407 tracker ? tracker.disabled_core_fields : []
405 408 end
406 409
407 410 # Returns the custom_field_values that can be edited by the given user
408 411 def editable_custom_field_values(user=nil)
409 412 custom_field_values.reject do |value|
410 413 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
411 414 end
412 415 end
413 416
414 417 # Returns the names of attributes that are read-only for user or the current user
415 418 # For users with multiple roles, the read-only fields are the intersection of
416 419 # read-only fields of each role
417 420 # The result is an array of strings where sustom fields are represented with their ids
418 421 #
419 422 # Examples:
420 423 # issue.read_only_attribute_names # => ['due_date', '2']
421 424 # issue.read_only_attribute_names(user) # => []
422 425 def read_only_attribute_names(user=nil)
423 426 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
424 427 end
425 428
426 429 # Returns the names of required attributes for user or the current user
427 430 # For users with multiple roles, the required fields are the intersection of
428 431 # required fields of each role
429 432 # The result is an array of strings where sustom fields are represented with their ids
430 433 #
431 434 # Examples:
432 435 # issue.required_attribute_names # => ['due_date', '2']
433 436 # issue.required_attribute_names(user) # => []
434 437 def required_attribute_names(user=nil)
435 438 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
436 439 end
437 440
438 441 # Returns true if the attribute is required for user
439 442 def required_attribute?(name, user=nil)
440 443 required_attribute_names(user).include?(name.to_s)
441 444 end
442 445
443 446 # Returns a hash of the workflow rule by attribute for the given user
444 447 #
445 448 # Examples:
446 449 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
447 450 def workflow_rule_by_attribute(user=nil)
448 451 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
449 452
450 453 user_real = user || User.current
451 454 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
452 455 return {} if roles.empty?
453 456
454 457 result = {}
455 458 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
456 459 if workflow_permissions.any?
457 460 workflow_rules = workflow_permissions.inject({}) do |h, wp|
458 461 h[wp.field_name] ||= []
459 462 h[wp.field_name] << wp.rule
460 463 h
461 464 end
462 465 workflow_rules.each do |attr, rules|
463 466 next if rules.size < roles.size
464 467 uniq_rules = rules.uniq
465 468 if uniq_rules.size == 1
466 469 result[attr] = uniq_rules.first
467 470 else
468 471 result[attr] = 'required'
469 472 end
470 473 end
471 474 end
472 475 @workflow_rule_by_attribute = result if user.nil?
473 476 result
474 477 end
475 478 private :workflow_rule_by_attribute
476 479
477 480 def done_ratio
478 481 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
479 482 status.default_done_ratio
480 483 else
481 484 read_attribute(:done_ratio)
482 485 end
483 486 end
484 487
485 488 def self.use_status_for_done_ratio?
486 489 Setting.issue_done_ratio == 'issue_status'
487 490 end
488 491
489 492 def self.use_field_for_done_ratio?
490 493 Setting.issue_done_ratio == 'issue_field'
491 494 end
492 495
493 496 def validate_issue
494 497 if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
495 498 errors.add :due_date, :not_a_date
496 499 end
497 500
498 501 if self.due_date and self.start_date and self.due_date < self.start_date
499 502 errors.add :due_date, :greater_than_start_date
500 503 end
501 504
502 505 if start_date && soonest_start && start_date < soonest_start
503 506 errors.add :start_date, :invalid
504 507 end
505 508
506 509 if fixed_version
507 510 if !assignable_versions.include?(fixed_version)
508 511 errors.add :fixed_version_id, :inclusion
509 512 elsif reopened? && fixed_version.closed?
510 513 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
511 514 end
512 515 end
513 516
514 517 # Checks that the issue can not be added/moved to a disabled tracker
515 518 if project && (tracker_id_changed? || project_id_changed?)
516 519 unless project.trackers.include?(tracker)
517 520 errors.add :tracker_id, :inclusion
518 521 end
519 522 end
520 523
521 524 # Checks parent issue assignment
522 525 if @parent_issue
523 526 if @parent_issue.project_id != project_id
524 527 errors.add :parent_issue_id, :not_same_project
525 528 elsif !new_record?
526 529 # moving an existing issue
527 530 if @parent_issue.root_id != root_id
528 531 # we can always move to another tree
529 532 elsif move_possible?(@parent_issue)
530 533 # move accepted inside tree
531 534 else
532 535 errors.add :parent_issue_id, :not_a_valid_parent
533 536 end
534 537 end
535 538 end
536 539 end
537 540
538 541 # Validates the issue against additional workflow requirements
539 542 def validate_required_fields
540 543 user = new_record? ? author : current_journal.try(:user)
541 544
542 545 required_attribute_names(user).each do |attribute|
543 546 if attribute =~ /^\d+$/
544 547 attribute = attribute.to_i
545 548 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
546 549 if v && v.value.blank?
547 550 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
548 551 end
549 552 else
550 553 if respond_to?(attribute) && send(attribute).blank?
551 554 errors.add attribute, :blank
552 555 end
553 556 end
554 557 end
555 558 end
556 559
557 560 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
558 561 # even if the user turns off the setting later
559 562 def update_done_ratio_from_issue_status
560 563 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
561 564 self.done_ratio = status.default_done_ratio
562 565 end
563 566 end
564 567
565 568 def init_journal(user, notes = "")
566 569 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
567 570 if new_record?
568 571 @current_journal.notify = false
569 572 else
570 573 @attributes_before_change = attributes.dup
571 574 @custom_values_before_change = {}
572 575 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
573 576 end
574 577 @current_journal
575 578 end
576 579
577 580 # Returns the id of the last journal or nil
578 581 def last_journal_id
579 582 if new_record?
580 583 nil
581 584 else
582 585 journals.first(:order => "#{Journal.table_name}.id DESC").try(:id)
583 586 end
584 587 end
585 588
586 589 # Return true if the issue is closed, otherwise false
587 590 def closed?
588 591 self.status.is_closed?
589 592 end
590 593
591 594 # Return true if the issue is being reopened
592 595 def reopened?
593 596 if !new_record? && status_id_changed?
594 597 status_was = IssueStatus.find_by_id(status_id_was)
595 598 status_new = IssueStatus.find_by_id(status_id)
596 599 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
597 600 return true
598 601 end
599 602 end
600 603 false
601 604 end
602 605
603 606 # Return true if the issue is being closed
604 607 def closing?
605 608 if !new_record? && status_id_changed?
606 609 status_was = IssueStatus.find_by_id(status_id_was)
607 610 status_new = IssueStatus.find_by_id(status_id)
608 611 if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
609 612 return true
610 613 end
611 614 end
612 615 false
613 616 end
614 617
615 618 # Returns true if the issue is overdue
616 619 def overdue?
617 620 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
618 621 end
619 622
620 623 # Is the amount of work done less than it should for the due date
621 624 def behind_schedule?
622 625 return false if start_date.nil? || due_date.nil?
623 626 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
624 627 return done_date <= Date.today
625 628 end
626 629
627 630 # Does this issue have children?
628 631 def children?
629 632 !leaf?
630 633 end
631 634
632 635 # Users the issue can be assigned to
633 636 def assignable_users
634 637 users = project.assignable_users
635 638 users << author if author
636 639 users << assigned_to if assigned_to
637 640 users.uniq.sort
638 641 end
639 642
640 643 # Versions that the issue can be assigned to
641 644 def assignable_versions
642 @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
645 return @assignable_versions if @assignable_versions
646
647 versions = project.shared_versions.open.all
648 if fixed_version
649 if fixed_version_id_changed?
650 # nothing to do
651 elsif project_id_changed?
652 if project.shared_versions.include?(fixed_version)
653 versions << fixed_version
654 end
655 else
656 versions << fixed_version
657 end
658 end
659 @assignable_versions = versions.uniq.sort
643 660 end
644 661
645 662 # Returns true if this issue is blocked by another issue that is still open
646 663 def blocked?
647 664 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
648 665 end
649 666
650 667 # Returns an array of statuses that user is able to apply
651 668 def new_statuses_allowed_to(user=User.current, include_default=false)
652 669 if new_record? && @copied_from
653 670 [IssueStatus.default, @copied_from.status].compact.uniq.sort
654 671 else
655 672 initial_status = nil
656 673 if new_record?
657 674 initial_status = IssueStatus.default
658 675 elsif status_id_was
659 676 initial_status = IssueStatus.find_by_id(status_id_was)
660 677 end
661 678 initial_status ||= status
662 679
663 680 statuses = initial_status.find_new_statuses_allowed_to(
664 681 user.admin ? Role.all : user.roles_for_project(project),
665 682 tracker,
666 683 author == user,
667 684 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
668 685 )
669 686 statuses << initial_status unless statuses.empty?
670 687 statuses << IssueStatus.default if include_default
671 688 statuses = statuses.compact.uniq.sort
672 689 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
673 690 end
674 691 end
675 692
676 693 def assigned_to_was
677 694 if assigned_to_id_changed? && assigned_to_id_was.present?
678 695 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
679 696 end
680 697 end
681 698
682 699 # Returns the mail adresses of users that should be notified
683 700 def recipients
684 701 notified = []
685 702 # Author and assignee are always notified unless they have been
686 703 # locked or don't want to be notified
687 704 notified << author if author
688 705 if assigned_to
689 706 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
690 707 end
691 708 if assigned_to_was
692 709 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
693 710 end
694 711 notified = notified.select {|u| u.active? && u.notify_about?(self)}
695 712
696 713 notified += project.notified_users
697 714 notified.uniq!
698 715 # Remove users that can not view the issue
699 716 notified.reject! {|user| !visible?(user)}
700 717 notified.collect(&:mail)
701 718 end
702 719
703 720 # Returns the number of hours spent on this issue
704 721 def spent_hours
705 722 @spent_hours ||= time_entries.sum(:hours) || 0
706 723 end
707 724
708 725 # Returns the total number of hours spent on this issue and its descendants
709 726 #
710 727 # Example:
711 728 # spent_hours => 0.0
712 729 # spent_hours => 50.2
713 730 def total_spent_hours
714 731 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
715 732 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
716 733 end
717 734
718 735 def relations
719 736 @relations ||= (relations_from + relations_to).sort
720 737 end
721 738
722 739 # Preloads relations for a collection of issues
723 740 def self.load_relations(issues)
724 741 if issues.any?
725 742 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
726 743 issues.each do |issue|
727 744 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
728 745 end
729 746 end
730 747 end
731 748
732 749 # Preloads visible spent time for a collection of issues
733 750 def self.load_visible_spent_hours(issues, user=User.current)
734 751 if issues.any?
735 752 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
736 753 issues.each do |issue|
737 754 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
738 755 end
739 756 end
740 757 end
741 758
742 759 # Finds an issue relation given its id.
743 760 def find_relation(relation_id)
744 761 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
745 762 end
746 763
747 764 def all_dependent_issues(except=[])
748 765 except << self
749 766 dependencies = []
750 767 relations_from.each do |relation|
751 768 if relation.issue_to && !except.include?(relation.issue_to)
752 769 dependencies << relation.issue_to
753 770 dependencies += relation.issue_to.all_dependent_issues(except)
754 771 end
755 772 end
756 773 dependencies
757 774 end
758 775
759 776 # Returns an array of issues that duplicate this one
760 777 def duplicates
761 778 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
762 779 end
763 780
764 781 # Returns the due date or the target due date if any
765 782 # Used on gantt chart
766 783 def due_before
767 784 due_date || (fixed_version ? fixed_version.effective_date : nil)
768 785 end
769 786
770 787 # Returns the time scheduled for this issue.
771 788 #
772 789 # Example:
773 790 # Start Date: 2/26/09, End Date: 3/04/09
774 791 # duration => 6
775 792 def duration
776 793 (start_date && due_date) ? due_date - start_date : 0
777 794 end
778 795
779 796 def soonest_start
780 797 @soonest_start ||= (
781 798 relations_to.collect{|relation| relation.successor_soonest_start} +
782 799 ancestors.collect(&:soonest_start)
783 800 ).compact.max
784 801 end
785 802
786 803 def reschedule_after(date)
787 804 return if date.nil?
788 805 if leaf?
789 806 if start_date.nil? || start_date < date
790 807 self.start_date, self.due_date = date, date + duration
791 808 begin
792 809 save
793 810 rescue ActiveRecord::StaleObjectError
794 811 reload
795 812 self.start_date, self.due_date = date, date + duration
796 813 save
797 814 end
798 815 end
799 816 else
800 817 leaves.each do |leaf|
801 818 leaf.reschedule_after(date)
802 819 end
803 820 end
804 821 end
805 822
806 823 def <=>(issue)
807 824 if issue.nil?
808 825 -1
809 826 elsif root_id != issue.root_id
810 827 (root_id || 0) <=> (issue.root_id || 0)
811 828 else
812 829 (lft || 0) <=> (issue.lft || 0)
813 830 end
814 831 end
815 832
816 833 def to_s
817 834 "#{tracker} ##{id}: #{subject}"
818 835 end
819 836
820 837 # Returns a string of css classes that apply to the issue
821 838 def css_classes
822 839 s = "issue status-#{status_id} priority-#{priority_id}"
823 840 s << ' closed' if closed?
824 841 s << ' overdue' if overdue?
825 842 s << ' child' if child?
826 843 s << ' parent' unless leaf?
827 844 s << ' private' if is_private?
828 845 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
829 846 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
830 847 s
831 848 end
832 849
833 850 # Saves an issue and a time_entry from the parameters
834 851 def save_issue_with_child_records(params, existing_time_entry=nil)
835 852 Issue.transaction do
836 853 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
837 854 @time_entry = existing_time_entry || TimeEntry.new
838 855 @time_entry.project = project
839 856 @time_entry.issue = self
840 857 @time_entry.user = User.current
841 858 @time_entry.spent_on = User.current.today
842 859 @time_entry.attributes = params[:time_entry]
843 860 self.time_entries << @time_entry
844 861 end
845 862
846 863 # TODO: Rename hook
847 864 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
848 865 if save
849 866 # TODO: Rename hook
850 867 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
851 868 else
852 869 raise ActiveRecord::Rollback
853 870 end
854 871 end
855 872 end
856 873
857 874 # Unassigns issues from +version+ if it's no longer shared with issue's project
858 875 def self.update_versions_from_sharing_change(version)
859 876 # Update issues assigned to the version
860 877 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
861 878 end
862 879
863 880 # Unassigns issues from versions that are no longer shared
864 881 # after +project+ was moved
865 882 def self.update_versions_from_hierarchy_change(project)
866 883 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
867 884 # Update issues of the moved projects and issues assigned to a version of a moved project
868 885 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
869 886 end
870 887
871 888 def parent_issue_id=(arg)
872 889 parent_issue_id = arg.blank? ? nil : arg.to_i
873 890 if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
874 891 @parent_issue.id
875 892 else
876 893 @parent_issue = nil
877 894 nil
878 895 end
879 896 end
880 897
881 898 def parent_issue_id
882 899 if instance_variable_defined? :@parent_issue
883 900 @parent_issue.nil? ? nil : @parent_issue.id
884 901 else
885 902 parent_id
886 903 end
887 904 end
888 905
889 906 # Extracted from the ReportsController.
890 907 def self.by_tracker(project)
891 908 count_and_group_by(:project => project,
892 909 :field => 'tracker_id',
893 910 :joins => Tracker.table_name)
894 911 end
895 912
896 913 def self.by_version(project)
897 914 count_and_group_by(:project => project,
898 915 :field => 'fixed_version_id',
899 916 :joins => Version.table_name)
900 917 end
901 918
902 919 def self.by_priority(project)
903 920 count_and_group_by(:project => project,
904 921 :field => 'priority_id',
905 922 :joins => IssuePriority.table_name)
906 923 end
907 924
908 925 def self.by_category(project)
909 926 count_and_group_by(:project => project,
910 927 :field => 'category_id',
911 928 :joins => IssueCategory.table_name)
912 929 end
913 930
914 931 def self.by_assigned_to(project)
915 932 count_and_group_by(:project => project,
916 933 :field => 'assigned_to_id',
917 934 :joins => User.table_name)
918 935 end
919 936
920 937 def self.by_author(project)
921 938 count_and_group_by(:project => project,
922 939 :field => 'author_id',
923 940 :joins => User.table_name)
924 941 end
925 942
926 943 def self.by_subproject(project)
927 944 ActiveRecord::Base.connection.select_all("select s.id as status_id,
928 945 s.is_closed as closed,
929 946 #{Issue.table_name}.project_id as project_id,
930 947 count(#{Issue.table_name}.id) as total
931 948 from
932 949 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
933 950 where
934 951 #{Issue.table_name}.status_id=s.id
935 952 and #{Issue.table_name}.project_id = #{Project.table_name}.id
936 953 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
937 954 and #{Issue.table_name}.project_id <> #{project.id}
938 955 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
939 956 end
940 957 # End ReportsController extraction
941 958
942 959 # Returns an array of projects that user can assign the issue to
943 960 def allowed_target_projects(user=User.current)
944 961 if new_record?
945 962 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
946 963 else
947 964 self.class.allowed_target_projects_on_move(user)
948 965 end
949 966 end
950 967
951 968 # Returns an array of projects that user can move issues to
952 969 def self.allowed_target_projects_on_move(user=User.current)
953 970 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
954 971 end
955 972
956 973 private
957 974
958 975 def after_project_change
959 976 # Update project_id on related time entries
960 977 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
961 978
962 979 # Delete issue relations
963 980 unless Setting.cross_project_issue_relations?
964 981 relations_from.clear
965 982 relations_to.clear
966 983 end
967 984
968 985 # Move subtasks
969 986 children.each do |child|
970 987 # Change project and keep project
971 988 child.send :project=, project, true
972 989 unless child.save
973 990 raise ActiveRecord::Rollback
974 991 end
975 992 end
976 993 end
977 994
978 995 def update_nested_set_attributes
979 996 if root_id.nil?
980 997 # issue was just created
981 998 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
982 999 set_default_left_and_right
983 1000 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
984 1001 if @parent_issue
985 1002 move_to_child_of(@parent_issue)
986 1003 end
987 1004 reload
988 1005 elsif parent_issue_id != parent_id
989 1006 former_parent_id = parent_id
990 1007 # moving an existing issue
991 1008 if @parent_issue && @parent_issue.root_id == root_id
992 1009 # inside the same tree
993 1010 move_to_child_of(@parent_issue)
994 1011 else
995 1012 # to another tree
996 1013 unless root?
997 1014 move_to_right_of(root)
998 1015 reload
999 1016 end
1000 1017 old_root_id = root_id
1001 1018 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
1002 1019 target_maxright = nested_set_scope.maximum(right_column_name) || 0
1003 1020 offset = target_maxright + 1 - lft
1004 1021 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
1005 1022 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
1006 1023 self[left_column_name] = lft + offset
1007 1024 self[right_column_name] = rgt + offset
1008 1025 if @parent_issue
1009 1026 move_to_child_of(@parent_issue)
1010 1027 end
1011 1028 end
1012 1029 reload
1013 1030 # delete invalid relations of all descendants
1014 1031 self_and_descendants.each do |issue|
1015 1032 issue.relations.each do |relation|
1016 1033 relation.destroy unless relation.valid?
1017 1034 end
1018 1035 end
1019 1036 # update former parent
1020 1037 recalculate_attributes_for(former_parent_id) if former_parent_id
1021 1038 end
1022 1039 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1023 1040 end
1024 1041
1025 1042 def update_parent_attributes
1026 1043 recalculate_attributes_for(parent_id) if parent_id
1027 1044 end
1028 1045
1029 1046 def recalculate_attributes_for(issue_id)
1030 1047 if issue_id && p = Issue.find_by_id(issue_id)
1031 1048 # priority = highest priority of children
1032 1049 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
1033 1050 p.priority = IssuePriority.find_by_position(priority_position)
1034 1051 end
1035 1052
1036 1053 # start/due dates = lowest/highest dates of children
1037 1054 p.start_date = p.children.minimum(:start_date)
1038 1055 p.due_date = p.children.maximum(:due_date)
1039 1056 if p.start_date && p.due_date && p.due_date < p.start_date
1040 1057 p.start_date, p.due_date = p.due_date, p.start_date
1041 1058 end
1042 1059
1043 1060 # done ratio = weighted average ratio of leaves
1044 1061 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1045 1062 leaves_count = p.leaves.count
1046 1063 if leaves_count > 0
1047 1064 average = p.leaves.average(:estimated_hours).to_f
1048 1065 if average == 0
1049 1066 average = 1
1050 1067 end
1051 1068 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
1052 1069 progress = done / (average * leaves_count)
1053 1070 p.done_ratio = progress.round
1054 1071 end
1055 1072 end
1056 1073
1057 1074 # estimate = sum of leaves estimates
1058 1075 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
1059 1076 p.estimated_hours = nil if p.estimated_hours == 0.0
1060 1077
1061 1078 # ancestors will be recursively updated
1062 1079 p.save(:validate => false)
1063 1080 end
1064 1081 end
1065 1082
1066 1083 # Update issues so their versions are not pointing to a
1067 1084 # fixed_version that is not shared with the issue's project
1068 1085 def self.update_versions(conditions=nil)
1069 1086 # Only need to update issues with a fixed_version from
1070 1087 # a different project and that is not systemwide shared
1071 1088 Issue.scoped(:conditions => conditions).all(
1072 1089 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1073 1090 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1074 1091 " AND #{Version.table_name}.sharing <> 'system'",
1075 1092 :include => [:project, :fixed_version]
1076 1093 ).each do |issue|
1077 1094 next if issue.project.nil? || issue.fixed_version.nil?
1078 1095 unless issue.project.shared_versions.include?(issue.fixed_version)
1079 1096 issue.init_journal(User.current)
1080 1097 issue.fixed_version = nil
1081 1098 issue.save
1082 1099 end
1083 1100 end
1084 1101 end
1085 1102
1086 1103 # Callback on attachment deletion
1087 1104 def attachment_added(obj)
1088 1105 if @current_journal && !obj.new_record?
1089 1106 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
1090 1107 end
1091 1108 end
1092 1109
1093 1110 # Callback on attachment deletion
1094 1111 def attachment_removed(obj)
1095 1112 if @current_journal && !obj.new_record?
1096 1113 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
1097 1114 @current_journal.save
1098 1115 end
1099 1116 end
1100 1117
1101 1118 # Default assignment based on category
1102 1119 def default_assign
1103 1120 if assigned_to.nil? && category && category.assigned_to
1104 1121 self.assigned_to = category.assigned_to
1105 1122 end
1106 1123 end
1107 1124
1108 1125 # Updates start/due dates of following issues
1109 1126 def reschedule_following_issues
1110 1127 if start_date_changed? || due_date_changed?
1111 1128 relations_from.each do |relation|
1112 1129 relation.set_issue_to_dates
1113 1130 end
1114 1131 end
1115 1132 end
1116 1133
1117 1134 # Closes duplicates if the issue is being closed
1118 1135 def close_duplicates
1119 1136 if closing?
1120 1137 duplicates.each do |duplicate|
1121 1138 # Reload is need in case the duplicate was updated by a previous duplicate
1122 1139 duplicate.reload
1123 1140 # Don't re-close it if it's already closed
1124 1141 next if duplicate.closed?
1125 1142 # Same user and notes
1126 1143 if @current_journal
1127 1144 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1128 1145 end
1129 1146 duplicate.update_attribute :status, self.status
1130 1147 end
1131 1148 end
1132 1149 end
1133 1150
1134 1151 # Make sure updated_on is updated when adding a note
1135 1152 def force_updated_on_change
1136 1153 if @current_journal
1137 1154 self.updated_on = current_time_from_proper_timezone
1138 1155 end
1139 1156 end
1140 1157
1141 1158 # Saves the changes in a Journal
1142 1159 # Called after_save
1143 1160 def create_journal
1144 1161 if @current_journal
1145 1162 # attributes changes
1146 1163 if @attributes_before_change
1147 1164 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
1148 1165 before = @attributes_before_change[c]
1149 1166 after = send(c)
1150 1167 next if before == after || (before.blank? && after.blank?)
1151 1168 @current_journal.details << JournalDetail.new(:property => 'attr',
1152 1169 :prop_key => c,
1153 1170 :old_value => before,
1154 1171 :value => after)
1155 1172 }
1156 1173 end
1157 1174 if @custom_values_before_change
1158 1175 # custom fields changes
1159 1176 custom_field_values.each {|c|
1160 1177 before = @custom_values_before_change[c.custom_field_id]
1161 1178 after = c.value
1162 1179 next if before == after || (before.blank? && after.blank?)
1163 1180
1164 1181 if before.is_a?(Array) || after.is_a?(Array)
1165 1182 before = [before] unless before.is_a?(Array)
1166 1183 after = [after] unless after.is_a?(Array)
1167 1184
1168 1185 # values removed
1169 1186 (before - after).reject(&:blank?).each do |value|
1170 1187 @current_journal.details << JournalDetail.new(:property => 'cf',
1171 1188 :prop_key => c.custom_field_id,
1172 1189 :old_value => value,
1173 1190 :value => nil)
1174 1191 end
1175 1192 # values added
1176 1193 (after - before).reject(&:blank?).each do |value|
1177 1194 @current_journal.details << JournalDetail.new(:property => 'cf',
1178 1195 :prop_key => c.custom_field_id,
1179 1196 :old_value => nil,
1180 1197 :value => value)
1181 1198 end
1182 1199 else
1183 1200 @current_journal.details << JournalDetail.new(:property => 'cf',
1184 1201 :prop_key => c.custom_field_id,
1185 1202 :old_value => before,
1186 1203 :value => after)
1187 1204 end
1188 1205 }
1189 1206 end
1190 1207 @current_journal.save
1191 1208 # reset current journal
1192 1209 init_journal @current_journal.user, @current_journal.notes
1193 1210 end
1194 1211 end
1195 1212
1196 1213 # Query generator for selecting groups of issue counts for a project
1197 1214 # based on specific criteria
1198 1215 #
1199 1216 # Options
1200 1217 # * project - Project to search in.
1201 1218 # * field - String. Issue field to key off of in the grouping.
1202 1219 # * joins - String. The table name to join against.
1203 1220 def self.count_and_group_by(options)
1204 1221 project = options.delete(:project)
1205 1222 select_field = options.delete(:field)
1206 1223 joins = options.delete(:joins)
1207 1224
1208 1225 where = "#{Issue.table_name}.#{select_field}=j.id"
1209 1226
1210 1227 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1211 1228 s.is_closed as closed,
1212 1229 j.id as #{select_field},
1213 1230 count(#{Issue.table_name}.id) as total
1214 1231 from
1215 1232 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1216 1233 where
1217 1234 #{Issue.table_name}.status_id=s.id
1218 1235 and #{where}
1219 1236 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1220 1237 and #{visible_condition(User.current, :project => project)}
1221 1238 group by s.id, s.is_closed, j.id")
1222 1239 end
1223 1240 end
@@ -1,1513 +1,1533
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :groups_users,
23 23 :trackers, :projects_trackers,
24 24 :enabled_modules,
25 25 :versions,
26 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 27 :enumerations,
28 28 :issues,
29 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 30 :time_entries
31 31
32 32 include Redmine::I18n
33 33
34 34 def teardown
35 35 User.current = nil
36 36 end
37 37
38 38 def test_create
39 39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
40 40 :status_id => 1, :priority => IssuePriority.all.first,
41 41 :subject => 'test_create',
42 42 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
43 43 assert issue.save
44 44 issue.reload
45 45 assert_equal 1.5, issue.estimated_hours
46 46 end
47 47
48 48 def test_create_minimal
49 49 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
50 50 :status_id => 1, :priority => IssuePriority.all.first,
51 51 :subject => 'test_create')
52 52 assert issue.save
53 53 assert issue.description.nil?
54 54 end
55 55
56 56 def test_create_with_required_custom_field
57 57 set_language_if_valid 'en'
58 58 field = IssueCustomField.find_by_name('Database')
59 59 field.update_attribute(:is_required, true)
60 60
61 61 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
62 62 :status_id => 1, :subject => 'test_create',
63 63 :description => 'IssueTest#test_create_with_required_custom_field')
64 64 assert issue.available_custom_fields.include?(field)
65 65 # No value for the custom field
66 66 assert !issue.save
67 67 assert_equal ["Database can't be blank"], issue.errors.full_messages
68 68 # Blank value
69 69 issue.custom_field_values = { field.id => '' }
70 70 assert !issue.save
71 71 assert_equal ["Database can't be blank"], issue.errors.full_messages
72 72 # Invalid value
73 73 issue.custom_field_values = { field.id => 'SQLServer' }
74 74 assert !issue.save
75 75 assert_equal ["Database is not included in the list"], issue.errors.full_messages
76 76 # Valid value
77 77 issue.custom_field_values = { field.id => 'PostgreSQL' }
78 78 assert issue.save
79 79 issue.reload
80 80 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
81 81 end
82 82
83 83 def test_create_with_group_assignment
84 84 with_settings :issue_group_assignment => '1' do
85 85 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
86 86 :subject => 'Group assignment',
87 87 :assigned_to_id => 11).save
88 88 issue = Issue.first(:order => 'id DESC')
89 89 assert_kind_of Group, issue.assigned_to
90 90 assert_equal Group.find(11), issue.assigned_to
91 91 end
92 92 end
93 93
94 94 def assert_visibility_match(user, issues)
95 95 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
96 96 end
97 97
98 98 def test_visible_scope_for_anonymous
99 99 # Anonymous user should see issues of public projects only
100 100 issues = Issue.visible(User.anonymous).all
101 101 assert issues.any?
102 102 assert_nil issues.detect {|issue| !issue.project.is_public?}
103 103 assert_nil issues.detect {|issue| issue.is_private?}
104 104 assert_visibility_match User.anonymous, issues
105 105 end
106 106
107 107 def test_visible_scope_for_anonymous_with_own_issues_visibility
108 108 Role.anonymous.update_attribute :issues_visibility, 'own'
109 109 Issue.create!(:project_id => 1, :tracker_id => 1,
110 110 :author_id => User.anonymous.id,
111 111 :subject => 'Issue by anonymous')
112 112
113 113 issues = Issue.visible(User.anonymous).all
114 114 assert issues.any?
115 115 assert_nil issues.detect {|issue| issue.author != User.anonymous}
116 116 assert_visibility_match User.anonymous, issues
117 117 end
118 118
119 119 def test_visible_scope_for_anonymous_without_view_issues_permissions
120 120 # Anonymous user should not see issues without permission
121 121 Role.anonymous.remove_permission!(:view_issues)
122 122 issues = Issue.visible(User.anonymous).all
123 123 assert issues.empty?
124 124 assert_visibility_match User.anonymous, issues
125 125 end
126 126
127 127 def test_visible_scope_for_non_member
128 128 user = User.find(9)
129 129 assert user.projects.empty?
130 130 # Non member user should see issues of public projects only
131 131 issues = Issue.visible(user).all
132 132 assert issues.any?
133 133 assert_nil issues.detect {|issue| !issue.project.is_public?}
134 134 assert_nil issues.detect {|issue| issue.is_private?}
135 135 assert_visibility_match user, issues
136 136 end
137 137
138 138 def test_visible_scope_for_non_member_with_own_issues_visibility
139 139 Role.non_member.update_attribute :issues_visibility, 'own'
140 140 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
141 141 user = User.find(9)
142 142
143 143 issues = Issue.visible(user).all
144 144 assert issues.any?
145 145 assert_nil issues.detect {|issue| issue.author != user}
146 146 assert_visibility_match user, issues
147 147 end
148 148
149 149 def test_visible_scope_for_non_member_without_view_issues_permissions
150 150 # Non member user should not see issues without permission
151 151 Role.non_member.remove_permission!(:view_issues)
152 152 user = User.find(9)
153 153 assert user.projects.empty?
154 154 issues = Issue.visible(user).all
155 155 assert issues.empty?
156 156 assert_visibility_match user, issues
157 157 end
158 158
159 159 def test_visible_scope_for_member
160 160 user = User.find(9)
161 161 # User should see issues of projects for which he has view_issues permissions only
162 162 Role.non_member.remove_permission!(:view_issues)
163 163 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
164 164 issues = Issue.visible(user).all
165 165 assert issues.any?
166 166 assert_nil issues.detect {|issue| issue.project_id != 3}
167 167 assert_nil issues.detect {|issue| issue.is_private?}
168 168 assert_visibility_match user, issues
169 169 end
170 170
171 171 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
172 172 user = User.find(8)
173 173 assert user.groups.any?
174 174 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
175 175 Role.non_member.remove_permission!(:view_issues)
176 176
177 177 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
178 178 :status_id => 1, :priority => IssuePriority.all.first,
179 179 :subject => 'Assignment test',
180 180 :assigned_to => user.groups.first,
181 181 :is_private => true)
182 182
183 183 Role.find(2).update_attribute :issues_visibility, 'default'
184 184 issues = Issue.visible(User.find(8)).all
185 185 assert issues.any?
186 186 assert issues.include?(issue)
187 187
188 188 Role.find(2).update_attribute :issues_visibility, 'own'
189 189 issues = Issue.visible(User.find(8)).all
190 190 assert issues.any?
191 191 assert issues.include?(issue)
192 192 end
193 193
194 194 def test_visible_scope_for_admin
195 195 user = User.find(1)
196 196 user.members.each(&:destroy)
197 197 assert user.projects.empty?
198 198 issues = Issue.visible(user).all
199 199 assert issues.any?
200 200 # Admin should see issues on private projects that he does not belong to
201 201 assert issues.detect {|issue| !issue.project.is_public?}
202 202 # Admin should see private issues of other users
203 203 assert issues.detect {|issue| issue.is_private? && issue.author != user}
204 204 assert_visibility_match user, issues
205 205 end
206 206
207 207 def test_visible_scope_with_project
208 208 project = Project.find(1)
209 209 issues = Issue.visible(User.find(2), :project => project).all
210 210 projects = issues.collect(&:project).uniq
211 211 assert_equal 1, projects.size
212 212 assert_equal project, projects.first
213 213 end
214 214
215 215 def test_visible_scope_with_project_and_subprojects
216 216 project = Project.find(1)
217 217 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
218 218 projects = issues.collect(&:project).uniq
219 219 assert projects.size > 1
220 220 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
221 221 end
222 222
223 223 def test_visible_and_nested_set_scopes
224 224 assert_equal 0, Issue.find(1).descendants.visible.all.size
225 225 end
226 226
227 227 def test_open_scope
228 228 issues = Issue.open.all
229 229 assert_nil issues.detect(&:closed?)
230 230 end
231 231
232 232 def test_open_scope_with_arg
233 233 issues = Issue.open(false).all
234 234 assert_equal issues, issues.select(&:closed?)
235 235 end
236 236
237 237 def test_errors_full_messages_should_include_custom_fields_errors
238 238 field = IssueCustomField.find_by_name('Database')
239 239
240 240 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
241 241 :status_id => 1, :subject => 'test_create',
242 242 :description => 'IssueTest#test_create_with_required_custom_field')
243 243 assert issue.available_custom_fields.include?(field)
244 244 # Invalid value
245 245 issue.custom_field_values = { field.id => 'SQLServer' }
246 246
247 247 assert !issue.valid?
248 248 assert_equal 1, issue.errors.full_messages.size
249 249 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
250 250 issue.errors.full_messages.first
251 251 end
252 252
253 253 def test_update_issue_with_required_custom_field
254 254 field = IssueCustomField.find_by_name('Database')
255 255 field.update_attribute(:is_required, true)
256 256
257 257 issue = Issue.find(1)
258 258 assert_nil issue.custom_value_for(field)
259 259 assert issue.available_custom_fields.include?(field)
260 260 # No change to custom values, issue can be saved
261 261 assert issue.save
262 262 # Blank value
263 263 issue.custom_field_values = { field.id => '' }
264 264 assert !issue.save
265 265 # Valid value
266 266 issue.custom_field_values = { field.id => 'PostgreSQL' }
267 267 assert issue.save
268 268 issue.reload
269 269 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
270 270 end
271 271
272 272 def test_should_not_update_attributes_if_custom_fields_validation_fails
273 273 issue = Issue.find(1)
274 274 field = IssueCustomField.find_by_name('Database')
275 275 assert issue.available_custom_fields.include?(field)
276 276
277 277 issue.custom_field_values = { field.id => 'Invalid' }
278 278 issue.subject = 'Should be not be saved'
279 279 assert !issue.save
280 280
281 281 issue.reload
282 282 assert_equal "Can't print recipes", issue.subject
283 283 end
284 284
285 285 def test_should_not_recreate_custom_values_objects_on_update
286 286 field = IssueCustomField.find_by_name('Database')
287 287
288 288 issue = Issue.find(1)
289 289 issue.custom_field_values = { field.id => 'PostgreSQL' }
290 290 assert issue.save
291 291 custom_value = issue.custom_value_for(field)
292 292 issue.reload
293 293 issue.custom_field_values = { field.id => 'MySQL' }
294 294 assert issue.save
295 295 issue.reload
296 296 assert_equal custom_value.id, issue.custom_value_for(field).id
297 297 end
298 298
299 299 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
300 300 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'Test', :custom_field_values => {'2' => 'Test'})
301 301 assert !Tracker.find(2).custom_field_ids.include?(2)
302 302
303 303 issue = Issue.find(issue.id)
304 304 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
305 305
306 306 issue = Issue.find(issue.id)
307 307 custom_value = issue.custom_value_for(2)
308 308 assert_not_nil custom_value
309 309 assert_equal 'Test', custom_value.value
310 310 end
311 311
312 312 def test_assigning_tracker_id_should_reload_custom_fields_values
313 313 issue = Issue.new(:project => Project.find(1))
314 314 assert issue.custom_field_values.empty?
315 315 issue.tracker_id = 1
316 316 assert issue.custom_field_values.any?
317 317 end
318 318
319 319 def test_assigning_attributes_should_assign_project_and_tracker_first
320 320 seq = sequence('seq')
321 321 issue = Issue.new
322 322 issue.expects(:project_id=).in_sequence(seq)
323 323 issue.expects(:tracker_id=).in_sequence(seq)
324 324 issue.expects(:subject=).in_sequence(seq)
325 325 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
326 326 end
327 327
328 328 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
329 329 attributes = ActiveSupport::OrderedHash.new
330 330 attributes['custom_field_values'] = { '1' => 'MySQL' }
331 331 attributes['tracker_id'] = '1'
332 332 issue = Issue.new(:project => Project.find(1))
333 333 issue.attributes = attributes
334 334 assert_equal 'MySQL', issue.custom_field_value(1)
335 335 end
336 336
337 337 def test_should_update_issue_with_disabled_tracker
338 338 p = Project.find(1)
339 339 issue = Issue.find(1)
340 340
341 341 p.trackers.delete(issue.tracker)
342 342 assert !p.trackers.include?(issue.tracker)
343 343
344 344 issue.reload
345 345 issue.subject = 'New subject'
346 346 assert issue.save
347 347 end
348 348
349 349 def test_should_not_set_a_disabled_tracker
350 350 p = Project.find(1)
351 351 p.trackers.delete(Tracker.find(2))
352 352
353 353 issue = Issue.find(1)
354 354 issue.tracker_id = 2
355 355 issue.subject = 'New subject'
356 356 assert !issue.save
357 357 assert_not_nil issue.errors[:tracker_id]
358 358 end
359 359
360 360 def test_category_based_assignment
361 361 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
362 362 :status_id => 1, :priority => IssuePriority.all.first,
363 363 :subject => 'Assignment test',
364 364 :description => 'Assignment test', :category_id => 1)
365 365 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
366 366 end
367 367
368 368 def test_new_statuses_allowed_to
369 369 WorkflowTransition.delete_all
370 370
371 371 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
372 372 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
373 373 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
374 374 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
375 375 status = IssueStatus.find(1)
376 376 role = Role.find(1)
377 377 tracker = Tracker.find(1)
378 378 user = User.find(2)
379 379
380 380 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author_id => 1)
381 381 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
382 382
383 383 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
384 384 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
385 385
386 386 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author_id => 1, :assigned_to => user)
387 387 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
388 388
389 389 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
390 390 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
391 391 end
392 392
393 393 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
394 394 admin = User.find(1)
395 395 issue = Issue.find(1)
396 396 assert !admin.member_of?(issue.project)
397 397 expected_statuses = [issue.status] + WorkflowTransition.find_all_by_old_status_id(issue.status_id).map(&:new_status).uniq.sort
398 398
399 399 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
400 400 end
401 401
402 402 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
403 403 issue = Issue.find(1).copy
404 404 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
405 405
406 406 issue = Issue.find(2).copy
407 407 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
408 408 end
409 409
410 410 def test_safe_attributes_names_should_not_include_disabled_field
411 411 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
412 412
413 413 issue = Issue.new(:tracker => tracker)
414 414 assert_include 'tracker_id', issue.safe_attribute_names
415 415 assert_include 'status_id', issue.safe_attribute_names
416 416 assert_include 'subject', issue.safe_attribute_names
417 417 assert_include 'description', issue.safe_attribute_names
418 418 assert_include 'custom_field_values', issue.safe_attribute_names
419 419 assert_include 'custom_fields', issue.safe_attribute_names
420 420 assert_include 'lock_version', issue.safe_attribute_names
421 421
422 422 tracker.core_fields.each do |field|
423 423 assert_include field, issue.safe_attribute_names
424 424 end
425 425
426 426 tracker.disabled_core_fields.each do |field|
427 427 assert_not_include field, issue.safe_attribute_names
428 428 end
429 429 end
430 430
431 431 def test_safe_attributes_should_ignore_disabled_fields
432 432 tracker = Tracker.find(1)
433 433 tracker.core_fields = %w(assigned_to_id due_date)
434 434 tracker.save!
435 435
436 436 issue = Issue.new(:tracker => tracker)
437 437 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
438 438 assert_nil issue.start_date
439 439 assert_equal Date.parse('2012-07-14'), issue.due_date
440 440 end
441 441
442 442 def test_safe_attributes_should_accept_target_tracker_enabled_fields
443 443 source = Tracker.find(1)
444 444 source.core_fields = []
445 445 source.save!
446 446 target = Tracker.find(2)
447 447 target.core_fields = %w(assigned_to_id due_date)
448 448 target.save!
449 449
450 450 issue = Issue.new(:tracker => source)
451 451 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
452 452 assert_equal target, issue.tracker
453 453 assert_equal Date.parse('2012-07-14'), issue.due_date
454 454 end
455 455
456 456 def test_safe_attributes_should_not_include_readonly_fields
457 457 WorkflowPermission.delete_all
458 458 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
459 459 user = User.find(2)
460 460
461 461 issue = Issue.new(:project_id => 1, :tracker_id => 1)
462 462 assert_equal %w(due_date), issue.read_only_attribute_names(user)
463 463 assert_not_include 'due_date', issue.safe_attribute_names(user)
464 464
465 465 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
466 466 assert_equal Date.parse('2012-07-14'), issue.start_date
467 467 assert_nil issue.due_date
468 468 end
469 469
470 470 def test_safe_attributes_should_not_include_readonly_custom_fields
471 471 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string', :is_for_all => true, :tracker_ids => [1])
472 472 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string', :is_for_all => true, :tracker_ids => [1])
473 473
474 474 WorkflowPermission.delete_all
475 475 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
476 476 user = User.find(2)
477 477
478 478 issue = Issue.new(:project_id => 1, :tracker_id => 1)
479 479 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
480 480 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
481 481
482 482 issue.send :safe_attributes=, {'custom_field_values' => {cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'}}, user
483 483 assert_equal 'value1', issue.custom_field_value(cf1)
484 484 assert_nil issue.custom_field_value(cf2)
485 485
486 486 issue.send :safe_attributes=, {'custom_fields' => [{'id' => cf1.id.to_s, 'value' => 'valuea'}, {'id' => cf2.id.to_s, 'value' => 'valueb'}]}, user
487 487 assert_equal 'valuea', issue.custom_field_value(cf1)
488 488 assert_nil issue.custom_field_value(cf2)
489 489 end
490 490
491 491 def test_editable_custom_field_values_should_return_non_readonly_custom_values
492 492 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
493 493 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
494 494
495 495 WorkflowPermission.delete_all
496 496 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
497 497 user = User.find(2)
498 498
499 499 issue = Issue.new(:project_id => 1, :tracker_id => 1)
500 500 values = issue.editable_custom_field_values(user)
501 501 assert values.detect {|value| value.custom_field == cf1}
502 502 assert_nil values.detect {|value| value.custom_field == cf2}
503 503
504 504 issue.tracker_id = 2
505 505 values = issue.editable_custom_field_values(user)
506 506 assert values.detect {|value| value.custom_field == cf1}
507 507 assert values.detect {|value| value.custom_field == cf2}
508 508 end
509 509
510 510 def test_safe_attributes_should_accept_target_tracker_writable_fields
511 511 WorkflowPermission.delete_all
512 512 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
513 513 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'start_date', :rule => 'readonly')
514 514 user = User.find(2)
515 515
516 516 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
517 517
518 518 issue.send :safe_attributes=, {'start_date' => '2012-07-12', 'due_date' => '2012-07-14'}, user
519 519 assert_equal Date.parse('2012-07-12'), issue.start_date
520 520 assert_nil issue.due_date
521 521
522 522 issue.send :safe_attributes=, {'start_date' => '2012-07-15', 'due_date' => '2012-07-16', 'tracker_id' => 2}, user
523 523 assert_equal Date.parse('2012-07-12'), issue.start_date
524 524 assert_equal Date.parse('2012-07-16'), issue.due_date
525 525 end
526 526
527 527 def test_safe_attributes_should_accept_target_status_writable_fields
528 528 WorkflowPermission.delete_all
529 529 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
530 530 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1, :role_id => 1, :field_name => 'start_date', :rule => 'readonly')
531 531 user = User.find(2)
532 532
533 533 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
534 534
535 535 issue.send :safe_attributes=, {'start_date' => '2012-07-12', 'due_date' => '2012-07-14'}, user
536 536 assert_equal Date.parse('2012-07-12'), issue.start_date
537 537 assert_nil issue.due_date
538 538
539 539 issue.send :safe_attributes=, {'start_date' => '2012-07-15', 'due_date' => '2012-07-16', 'status_id' => 2}, user
540 540 assert_equal Date.parse('2012-07-12'), issue.start_date
541 541 assert_equal Date.parse('2012-07-16'), issue.due_date
542 542 end
543 543
544 544 def test_required_attributes_should_be_validated
545 545 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
546 546
547 547 WorkflowPermission.delete_all
548 548 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
549 549 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'category_id', :rule => 'required')
550 550 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf.id.to_s, :rule => 'required')
551 551
552 552 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'start_date', :rule => 'required')
553 553 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf.id.to_s, :rule => 'required')
554 554 user = User.find(2)
555 555
556 556 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Required fields', :author => user)
557 557 assert_equal [cf.id.to_s, "category_id", "due_date"], issue.required_attribute_names(user).sort
558 558 assert !issue.save, "Issue was saved"
559 559 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"], issue.errors.full_messages.sort
560 560
561 561 issue.tracker_id = 2
562 562 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
563 563 assert !issue.save, "Issue was saved"
564 564 assert_equal ["Foo can't be blank", "Start date can't be blank"], issue.errors.full_messages.sort
565 565
566 566 issue.start_date = Date.today
567 567 issue.custom_field_values = {cf.id.to_s => 'bar'}
568 568 assert issue.save
569 569 end
570 570
571 571 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
572 572 WorkflowPermission.delete_all
573 573 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
574 574 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'start_date', :rule => 'required')
575 575 user = User.find(2)
576 576 member = Member.find(1)
577 577 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
578 578
579 579 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
580 580
581 581 member.role_ids = [1, 2]
582 582 member.save!
583 583 assert_equal [], issue.required_attribute_names(user.reload)
584 584
585 585 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 2, :field_name => 'due_date', :rule => 'required')
586 586 assert_equal %w(due_date), issue.required_attribute_names(user)
587 587
588 588 member.role_ids = [1, 2, 3]
589 589 member.save!
590 590 assert_equal [], issue.required_attribute_names(user.reload)
591 591
592 592 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 2, :field_name => 'due_date', :rule => 'readonly')
593 593 # required + readonly => required
594 594 assert_equal %w(due_date), issue.required_attribute_names(user)
595 595 end
596 596
597 597 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
598 598 WorkflowPermission.delete_all
599 599 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
600 600 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'start_date', :rule => 'readonly')
601 601 user = User.find(2)
602 602 member = Member.find(1)
603 603 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
604 604
605 605 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
606 606
607 607 member.role_ids = [1, 2]
608 608 member.save!
609 609 assert_equal [], issue.read_only_attribute_names(user.reload)
610 610
611 611 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 2, :field_name => 'due_date', :rule => 'readonly')
612 612 assert_equal %w(due_date), issue.read_only_attribute_names(user)
613 613 end
614 614
615 615 def test_copy
616 616 issue = Issue.new.copy_from(1)
617 617 assert issue.copy?
618 618 assert issue.save
619 619 issue.reload
620 620 orig = Issue.find(1)
621 621 assert_equal orig.subject, issue.subject
622 622 assert_equal orig.tracker, issue.tracker
623 623 assert_equal "125", issue.custom_value_for(2).value
624 624 end
625 625
626 626 def test_copy_should_copy_status
627 627 orig = Issue.find(8)
628 628 assert orig.status != IssueStatus.default
629 629
630 630 issue = Issue.new.copy_from(orig)
631 631 assert issue.save
632 632 issue.reload
633 633 assert_equal orig.status, issue.status
634 634 end
635 635
636 636 def test_should_not_call_after_project_change_on_creation
637 637 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Test', :author_id => 1)
638 638 issue.expects(:after_project_change).never
639 639 issue.save!
640 640 end
641 641
642 642 def test_should_not_call_after_project_change_on_update
643 643 issue = Issue.find(1)
644 644 issue.project = Project.find(1)
645 645 issue.subject = 'No project change'
646 646 issue.expects(:after_project_change).never
647 647 issue.save!
648 648 end
649 649
650 650 def test_should_call_after_project_change_on_project_change
651 651 issue = Issue.find(1)
652 652 issue.project = Project.find(2)
653 653 issue.expects(:after_project_change).once
654 654 issue.save!
655 655 end
656 656
657 657 def test_adding_journal_should_update_timestamp
658 658 issue = Issue.find(1)
659 659 updated_on_was = issue.updated_on
660 660
661 661 issue.init_journal(User.first, "Adding notes")
662 662 assert_difference 'Journal.count' do
663 663 assert issue.save
664 664 end
665 665 issue.reload
666 666
667 667 assert_not_equal updated_on_was, issue.updated_on
668 668 end
669 669
670 670 def test_should_close_duplicates
671 671 # Create 3 issues
672 672 project = Project.find(1)
673 673 issue1 = Issue.generate_for_project!(project)
674 674 issue2 = Issue.generate_for_project!(project)
675 675 issue3 = Issue.generate_for_project!(project)
676 676
677 677 # 2 is a dupe of 1
678 678 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
679 679 # And 3 is a dupe of 2
680 680 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
681 681 # And 3 is a dupe of 1 (circular duplicates)
682 682 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
683 683
684 684 assert issue1.reload.duplicates.include?(issue2)
685 685
686 686 # Closing issue 1
687 687 issue1.init_journal(User.find(:first), "Closing issue1")
688 688 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
689 689 assert issue1.save
690 690 # 2 and 3 should be also closed
691 691 assert issue2.reload.closed?
692 692 assert issue3.reload.closed?
693 693 end
694 694
695 695 def test_should_not_close_duplicated_issue
696 696 project = Project.find(1)
697 697 issue1 = Issue.generate_for_project!(project)
698 698 issue2 = Issue.generate_for_project!(project)
699 699
700 700 # 2 is a dupe of 1
701 701 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
702 702 # 2 is a dup of 1 but 1 is not a duplicate of 2
703 703 assert !issue2.reload.duplicates.include?(issue1)
704 704
705 705 # Closing issue 2
706 706 issue2.init_journal(User.find(:first), "Closing issue2")
707 707 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
708 708 assert issue2.save
709 709 # 1 should not be also closed
710 710 assert !issue1.reload.closed?
711 711 end
712 712
713 713 def test_assignable_versions
714 714 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
715 715 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
716 716 end
717 717
718 718 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
719 719 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
720 720 assert !issue.save
721 721 assert_not_nil issue.errors[:fixed_version_id]
722 722 end
723 723
724 724 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
725 725 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
726 726 assert !issue.save
727 727 assert_not_nil issue.errors[:fixed_version_id]
728 728 end
729 729
730 730 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
731 731 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
732 732 assert issue.save
733 733 end
734 734
735 735 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
736 736 issue = Issue.find(11)
737 737 assert_equal 'closed', issue.fixed_version.status
738 738 issue.subject = 'Subject changed'
739 739 assert issue.save
740 740 end
741 741
742 742 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
743 743 issue = Issue.find(11)
744 744 issue.status_id = 1
745 745 assert !issue.save
746 746 assert_not_nil issue.errors[:base]
747 747 end
748 748
749 749 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
750 750 issue = Issue.find(11)
751 751 issue.status_id = 1
752 752 issue.fixed_version_id = 3
753 753 assert issue.save
754 754 end
755 755
756 756 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
757 757 issue = Issue.find(12)
758 758 assert_equal 'locked', issue.fixed_version.status
759 759 issue.status_id = 1
760 760 assert issue.save
761 761 end
762 762
763 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
764 issue = Issue.find(2)
765 assert_equal 2, issue.fixed_version_id
766 issue.project_id = 3
767 assert_nil issue.fixed_version_id
768 issue.fixed_version_id = 2
769 assert !issue.save
770 assert_include 'Target version is not included in the list', issue.errors.full_messages
771 end
772
773 def test_should_keep_shared_version_when_changing_project
774 Version.find(2).update_attribute :sharing, 'tree'
775
776 issue = Issue.find(2)
777 assert_equal 2, issue.fixed_version_id
778 issue.project_id = 3
779 assert_equal 2, issue.fixed_version_id
780 assert issue.save
781 end
782
763 783 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
764 784 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
765 785 end
766 786
767 787 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
768 788 Project.find(2).disable_module! :issue_tracking
769 789 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
770 790 end
771 791
772 792 def test_move_to_another_project_with_same_category
773 793 issue = Issue.find(1)
774 794 issue.project = Project.find(2)
775 795 assert issue.save
776 796 issue.reload
777 797 assert_equal 2, issue.project_id
778 798 # Category changes
779 799 assert_equal 4, issue.category_id
780 800 # Make sure time entries were move to the target project
781 801 assert_equal 2, issue.time_entries.first.project_id
782 802 end
783 803
784 804 def test_move_to_another_project_without_same_category
785 805 issue = Issue.find(2)
786 806 issue.project = Project.find(2)
787 807 assert issue.save
788 808 issue.reload
789 809 assert_equal 2, issue.project_id
790 810 # Category cleared
791 811 assert_nil issue.category_id
792 812 end
793 813
794 814 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
795 815 issue = Issue.find(1)
796 816 issue.update_attribute(:fixed_version_id, 1)
797 817 issue.project = Project.find(2)
798 818 assert issue.save
799 819 issue.reload
800 820 assert_equal 2, issue.project_id
801 821 # Cleared fixed_version
802 822 assert_equal nil, issue.fixed_version
803 823 end
804 824
805 825 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
806 826 issue = Issue.find(1)
807 827 issue.update_attribute(:fixed_version_id, 4)
808 828 issue.project = Project.find(5)
809 829 assert issue.save
810 830 issue.reload
811 831 assert_equal 5, issue.project_id
812 832 # Keep fixed_version
813 833 assert_equal 4, issue.fixed_version_id
814 834 end
815 835
816 836 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
817 837 issue = Issue.find(1)
818 838 issue.update_attribute(:fixed_version_id, 1)
819 839 issue.project = Project.find(5)
820 840 assert issue.save
821 841 issue.reload
822 842 assert_equal 5, issue.project_id
823 843 # Cleared fixed_version
824 844 assert_equal nil, issue.fixed_version
825 845 end
826 846
827 847 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
828 848 issue = Issue.find(1)
829 849 issue.update_attribute(:fixed_version_id, 7)
830 850 issue.project = Project.find(2)
831 851 assert issue.save
832 852 issue.reload
833 853 assert_equal 2, issue.project_id
834 854 # Keep fixed_version
835 855 assert_equal 7, issue.fixed_version_id
836 856 end
837 857
838 858 def test_move_to_another_project_with_disabled_tracker
839 859 issue = Issue.find(1)
840 860 target = Project.find(2)
841 861 target.tracker_ids = [3]
842 862 target.save
843 863 issue.project = target
844 864 assert issue.save
845 865 issue.reload
846 866 assert_equal 2, issue.project_id
847 867 assert_equal 3, issue.tracker_id
848 868 end
849 869
850 870 def test_copy_to_the_same_project
851 871 issue = Issue.find(1)
852 872 copy = issue.copy
853 873 assert_difference 'Issue.count' do
854 874 copy.save!
855 875 end
856 876 assert_kind_of Issue, copy
857 877 assert_equal issue.project, copy.project
858 878 assert_equal "125", copy.custom_value_for(2).value
859 879 end
860 880
861 881 def test_copy_to_another_project_and_tracker
862 882 issue = Issue.find(1)
863 883 copy = issue.copy(:project_id => 3, :tracker_id => 2)
864 884 assert_difference 'Issue.count' do
865 885 copy.save!
866 886 end
867 887 copy.reload
868 888 assert_kind_of Issue, copy
869 889 assert_equal Project.find(3), copy.project
870 890 assert_equal Tracker.find(2), copy.tracker
871 891 # Custom field #2 is not associated with target tracker
872 892 assert_nil copy.custom_value_for(2)
873 893 end
874 894
875 895 context "#copy" do
876 896 setup do
877 897 @issue = Issue.find(1)
878 898 end
879 899
880 900 should "not create a journal" do
881 901 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
882 902 copy.save!
883 903 assert_equal 0, copy.reload.journals.size
884 904 end
885 905
886 906 should "allow assigned_to changes" do
887 907 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
888 908 assert_equal 3, copy.assigned_to_id
889 909 end
890 910
891 911 should "allow status changes" do
892 912 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
893 913 assert_equal 2, copy.status_id
894 914 end
895 915
896 916 should "allow start date changes" do
897 917 date = Date.today
898 918 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
899 919 assert_equal date, copy.start_date
900 920 end
901 921
902 922 should "allow due date changes" do
903 923 date = Date.today
904 924 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
905 925 assert_equal date, copy.due_date
906 926 end
907 927
908 928 should "set current user as author" do
909 929 User.current = User.find(9)
910 930 copy = @issue.copy(:project_id => 3, :tracker_id => 2)
911 931 assert_equal User.current, copy.author
912 932 end
913 933
914 934 should "create a journal with notes" do
915 935 date = Date.today
916 936 notes = "Notes added when copying"
917 937 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
918 938 copy.init_journal(User.current, notes)
919 939 copy.save!
920 940
921 941 assert_equal 1, copy.journals.size
922 942 journal = copy.journals.first
923 943 assert_equal 0, journal.details.size
924 944 assert_equal notes, journal.notes
925 945 end
926 946 end
927 947
928 948 def test_recipients_should_include_previous_assignee
929 949 user = User.find(3)
930 950 user.members.update_all ["mail_notification = ?", false]
931 951 user.update_attribute :mail_notification, 'only_assigned'
932 952
933 953 issue = Issue.find(2)
934 954 issue.assigned_to = nil
935 955 assert_include user.mail, issue.recipients
936 956 issue.save!
937 957 assert !issue.recipients.include?(user.mail)
938 958 end
939 959
940 960 def test_recipients_should_not_include_users_that_cannot_view_the_issue
941 961 issue = Issue.find(12)
942 962 assert issue.recipients.include?(issue.author.mail)
943 963 # copy the issue to a private project
944 964 copy = issue.copy(:project_id => 5, :tracker_id => 2)
945 965 # author is not a member of project anymore
946 966 assert !copy.recipients.include?(copy.author.mail)
947 967 end
948 968
949 969 def test_recipients_should_include_the_assigned_group_members
950 970 group_member = User.generate!
951 971 group = Group.generate!
952 972 group.users << group_member
953 973
954 974 issue = Issue.find(12)
955 975 issue.assigned_to = group
956 976 assert issue.recipients.include?(group_member.mail)
957 977 end
958 978
959 979 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
960 980 user = User.find(3)
961 981 issue = Issue.find(9)
962 982 Watcher.create!(:user => user, :watchable => issue)
963 983 assert issue.watched_by?(user)
964 984 assert !issue.watcher_recipients.include?(user.mail)
965 985 end
966 986
967 987 def test_issue_destroy
968 988 Issue.find(1).destroy
969 989 assert_nil Issue.find_by_id(1)
970 990 assert_nil TimeEntry.find_by_issue_id(1)
971 991 end
972 992
973 993 def test_destroying_a_deleted_issue_should_not_raise_an_error
974 994 issue = Issue.find(1)
975 995 Issue.find(1).destroy
976 996
977 997 assert_nothing_raised do
978 998 assert_no_difference 'Issue.count' do
979 999 issue.destroy
980 1000 end
981 1001 assert issue.destroyed?
982 1002 end
983 1003 end
984 1004
985 1005 def test_destroying_a_stale_issue_should_not_raise_an_error
986 1006 issue = Issue.find(1)
987 1007 Issue.find(1).update_attribute :subject, "Updated"
988 1008
989 1009 assert_nothing_raised do
990 1010 assert_difference 'Issue.count', -1 do
991 1011 issue.destroy
992 1012 end
993 1013 assert issue.destroyed?
994 1014 end
995 1015 end
996 1016
997 1017 def test_blocked
998 1018 blocked_issue = Issue.find(9)
999 1019 blocking_issue = Issue.find(10)
1000 1020
1001 1021 assert blocked_issue.blocked?
1002 1022 assert !blocking_issue.blocked?
1003 1023 end
1004 1024
1005 1025 def test_blocked_issues_dont_allow_closed_statuses
1006 1026 blocked_issue = Issue.find(9)
1007 1027
1008 1028 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1009 1029 assert !allowed_statuses.empty?
1010 1030 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1011 1031 assert closed_statuses.empty?
1012 1032 end
1013 1033
1014 1034 def test_unblocked_issues_allow_closed_statuses
1015 1035 blocking_issue = Issue.find(10)
1016 1036
1017 1037 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1018 1038 assert !allowed_statuses.empty?
1019 1039 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1020 1040 assert !closed_statuses.empty?
1021 1041 end
1022 1042
1023 1043 def test_rescheduling_an_issue_should_reschedule_following_issue
1024 1044 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
1025 1045 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
1026 1046 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1027 1047 assert_equal issue1.due_date + 1, issue2.reload.start_date
1028 1048
1029 1049 issue1.due_date = Date.today + 5
1030 1050 issue1.save!
1031 1051 assert_equal issue1.due_date + 1, issue2.reload.start_date
1032 1052 end
1033 1053
1034 1054 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1035 1055 stale = Issue.find(1)
1036 1056 issue = Issue.find(1)
1037 1057 issue.subject = "Updated"
1038 1058 issue.save!
1039 1059
1040 1060 date = 10.days.from_now.to_date
1041 1061 assert_nothing_raised do
1042 1062 stale.reschedule_after(date)
1043 1063 end
1044 1064 assert_equal date, stale.reload.start_date
1045 1065 end
1046 1066
1047 1067 def test_overdue
1048 1068 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1049 1069 assert !Issue.new(:due_date => Date.today).overdue?
1050 1070 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1051 1071 assert !Issue.new(:due_date => nil).overdue?
1052 1072 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
1053 1073 end
1054 1074
1055 1075 context "#behind_schedule?" do
1056 1076 should "be false if the issue has no start_date" do
1057 1077 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
1058 1078 end
1059 1079
1060 1080 should "be false if the issue has no end_date" do
1061 1081 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
1062 1082 end
1063 1083
1064 1084 should "be false if the issue has more done than it's calendar time" do
1065 1085 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
1066 1086 end
1067 1087
1068 1088 should "be true if the issue hasn't been started at all" do
1069 1089 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
1070 1090 end
1071 1091
1072 1092 should "be true if the issue has used more calendar time than it's done ratio" do
1073 1093 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
1074 1094 end
1075 1095 end
1076 1096
1077 1097 context "#assignable_users" do
1078 1098 should "be Users" do
1079 1099 assert_kind_of User, Issue.find(1).assignable_users.first
1080 1100 end
1081 1101
1082 1102 should "include the issue author" do
1083 1103 project = Project.find(1)
1084 1104 non_project_member = User.generate!
1085 1105 issue = Issue.generate_for_project!(project, :author => non_project_member)
1086 1106
1087 1107 assert issue.assignable_users.include?(non_project_member)
1088 1108 end
1089 1109
1090 1110 should "include the current assignee" do
1091 1111 project = Project.find(1)
1092 1112 user = User.generate!
1093 1113 issue = Issue.generate_for_project!(project, :assigned_to => user)
1094 1114 user.lock!
1095 1115
1096 1116 assert Issue.find(issue.id).assignable_users.include?(user)
1097 1117 end
1098 1118
1099 1119 should "not show the issue author twice" do
1100 1120 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1101 1121 assert_equal 2, assignable_user_ids.length
1102 1122
1103 1123 assignable_user_ids.each do |user_id|
1104 1124 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
1105 1125 end
1106 1126 end
1107 1127
1108 1128 context "with issue_group_assignment" do
1109 1129 should "include groups" do
1110 1130 issue = Issue.new(:project => Project.find(2))
1111 1131
1112 1132 with_settings :issue_group_assignment => '1' do
1113 1133 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1114 1134 assert issue.assignable_users.include?(Group.find(11))
1115 1135 end
1116 1136 end
1117 1137 end
1118 1138
1119 1139 context "without issue_group_assignment" do
1120 1140 should "not include groups" do
1121 1141 issue = Issue.new(:project => Project.find(2))
1122 1142
1123 1143 with_settings :issue_group_assignment => '0' do
1124 1144 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1125 1145 assert !issue.assignable_users.include?(Group.find(11))
1126 1146 end
1127 1147 end
1128 1148 end
1129 1149 end
1130 1150
1131 1151 def test_create_should_send_email_notification
1132 1152 ActionMailer::Base.deliveries.clear
1133 1153 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1134 1154 :author_id => 3, :status_id => 1,
1135 1155 :priority => IssuePriority.all.first,
1136 1156 :subject => 'test_create', :estimated_hours => '1:30')
1137 1157
1138 1158 assert issue.save
1139 1159 assert_equal 1, ActionMailer::Base.deliveries.size
1140 1160 end
1141 1161
1142 1162 def test_stale_issue_should_not_send_email_notification
1143 1163 ActionMailer::Base.deliveries.clear
1144 1164 issue = Issue.find(1)
1145 1165 stale = Issue.find(1)
1146 1166
1147 1167 issue.init_journal(User.find(1))
1148 1168 issue.subject = 'Subjet update'
1149 1169 assert issue.save
1150 1170 assert_equal 1, ActionMailer::Base.deliveries.size
1151 1171 ActionMailer::Base.deliveries.clear
1152 1172
1153 1173 stale.init_journal(User.find(1))
1154 1174 stale.subject = 'Another subjet update'
1155 1175 assert_raise ActiveRecord::StaleObjectError do
1156 1176 stale.save
1157 1177 end
1158 1178 assert ActionMailer::Base.deliveries.empty?
1159 1179 end
1160 1180
1161 1181 def test_journalized_description
1162 1182 IssueCustomField.delete_all
1163 1183
1164 1184 i = Issue.first
1165 1185 old_description = i.description
1166 1186 new_description = "This is the new description"
1167 1187
1168 1188 i.init_journal(User.find(2))
1169 1189 i.description = new_description
1170 1190 assert_difference 'Journal.count', 1 do
1171 1191 assert_difference 'JournalDetail.count', 1 do
1172 1192 i.save!
1173 1193 end
1174 1194 end
1175 1195
1176 1196 detail = JournalDetail.first(:order => 'id DESC')
1177 1197 assert_equal i, detail.journal.journalized
1178 1198 assert_equal 'attr', detail.property
1179 1199 assert_equal 'description', detail.prop_key
1180 1200 assert_equal old_description, detail.old_value
1181 1201 assert_equal new_description, detail.value
1182 1202 end
1183 1203
1184 1204 def test_blank_descriptions_should_not_be_journalized
1185 1205 IssueCustomField.delete_all
1186 1206 Issue.update_all("description = NULL", "id=1")
1187 1207
1188 1208 i = Issue.find(1)
1189 1209 i.init_journal(User.find(2))
1190 1210 i.subject = "blank description"
1191 1211 i.description = "\r\n"
1192 1212
1193 1213 assert_difference 'Journal.count', 1 do
1194 1214 assert_difference 'JournalDetail.count', 1 do
1195 1215 i.save!
1196 1216 end
1197 1217 end
1198 1218 end
1199 1219
1200 1220 def test_journalized_multi_custom_field
1201 1221 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list', :is_filter => true, :is_for_all => true,
1202 1222 :tracker_ids => [1], :possible_values => ['value1', 'value2', 'value3'], :multiple => true)
1203 1223
1204 1224 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'Test', :author_id => 1)
1205 1225
1206 1226 assert_difference 'Journal.count' do
1207 1227 assert_difference 'JournalDetail.count' do
1208 1228 issue.init_journal(User.first)
1209 1229 issue.custom_field_values = {field.id => ['value1']}
1210 1230 issue.save!
1211 1231 end
1212 1232 assert_difference 'JournalDetail.count' do
1213 1233 issue.init_journal(User.first)
1214 1234 issue.custom_field_values = {field.id => ['value1', 'value2']}
1215 1235 issue.save!
1216 1236 end
1217 1237 assert_difference 'JournalDetail.count', 2 do
1218 1238 issue.init_journal(User.first)
1219 1239 issue.custom_field_values = {field.id => ['value3', 'value2']}
1220 1240 issue.save!
1221 1241 end
1222 1242 assert_difference 'JournalDetail.count', 2 do
1223 1243 issue.init_journal(User.first)
1224 1244 issue.custom_field_values = {field.id => nil}
1225 1245 issue.save!
1226 1246 end
1227 1247 end
1228 1248 end
1229 1249
1230 1250 def test_description_eol_should_be_normalized
1231 1251 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1232 1252 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1233 1253 end
1234 1254
1235 1255 def test_saving_twice_should_not_duplicate_journal_details
1236 1256 i = Issue.find(:first)
1237 1257 i.init_journal(User.find(2), 'Some notes')
1238 1258 # initial changes
1239 1259 i.subject = 'New subject'
1240 1260 i.done_ratio = i.done_ratio + 10
1241 1261 assert_difference 'Journal.count' do
1242 1262 assert i.save
1243 1263 end
1244 1264 # 1 more change
1245 1265 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
1246 1266 assert_no_difference 'Journal.count' do
1247 1267 assert_difference 'JournalDetail.count', 1 do
1248 1268 i.save
1249 1269 end
1250 1270 end
1251 1271 # no more change
1252 1272 assert_no_difference 'Journal.count' do
1253 1273 assert_no_difference 'JournalDetail.count' do
1254 1274 i.save
1255 1275 end
1256 1276 end
1257 1277 end
1258 1278
1259 1279 def test_all_dependent_issues
1260 1280 IssueRelation.delete_all
1261 1281 assert IssueRelation.create!(:issue_from => Issue.find(1),
1262 1282 :issue_to => Issue.find(2),
1263 1283 :relation_type => IssueRelation::TYPE_PRECEDES)
1264 1284 assert IssueRelation.create!(:issue_from => Issue.find(2),
1265 1285 :issue_to => Issue.find(3),
1266 1286 :relation_type => IssueRelation::TYPE_PRECEDES)
1267 1287 assert IssueRelation.create!(:issue_from => Issue.find(3),
1268 1288 :issue_to => Issue.find(8),
1269 1289 :relation_type => IssueRelation::TYPE_PRECEDES)
1270 1290
1271 1291 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1272 1292 end
1273 1293
1274 1294 def test_all_dependent_issues_with_persistent_circular_dependency
1275 1295 IssueRelation.delete_all
1276 1296 assert IssueRelation.create!(:issue_from => Issue.find(1),
1277 1297 :issue_to => Issue.find(2),
1278 1298 :relation_type => IssueRelation::TYPE_PRECEDES)
1279 1299 assert IssueRelation.create!(:issue_from => Issue.find(2),
1280 1300 :issue_to => Issue.find(3),
1281 1301 :relation_type => IssueRelation::TYPE_PRECEDES)
1282 1302
1283 1303 r = IssueRelation.create!(:issue_from => Issue.find(3),
1284 1304 :issue_to => Issue.find(7),
1285 1305 :relation_type => IssueRelation::TYPE_PRECEDES)
1286 1306 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1287 1307
1288 1308 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1289 1309 end
1290 1310
1291 1311 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1292 1312 IssueRelation.delete_all
1293 1313 assert IssueRelation.create!(:issue_from => Issue.find(1),
1294 1314 :issue_to => Issue.find(2),
1295 1315 :relation_type => IssueRelation::TYPE_RELATES)
1296 1316 assert IssueRelation.create!(:issue_from => Issue.find(2),
1297 1317 :issue_to => Issue.find(3),
1298 1318 :relation_type => IssueRelation::TYPE_RELATES)
1299 1319 assert IssueRelation.create!(:issue_from => Issue.find(3),
1300 1320 :issue_to => Issue.find(8),
1301 1321 :relation_type => IssueRelation::TYPE_RELATES)
1302 1322
1303 1323 r = IssueRelation.create!(:issue_from => Issue.find(8),
1304 1324 :issue_to => Issue.find(7),
1305 1325 :relation_type => IssueRelation::TYPE_RELATES)
1306 1326 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1307 1327
1308 1328 r = IssueRelation.create!(:issue_from => Issue.find(3),
1309 1329 :issue_to => Issue.find(7),
1310 1330 :relation_type => IssueRelation::TYPE_RELATES)
1311 1331 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1312 1332
1313 1333 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1314 1334 end
1315 1335
1316 1336 context "#done_ratio" do
1317 1337 setup do
1318 1338 @issue = Issue.find(1)
1319 1339 @issue_status = IssueStatus.find(1)
1320 1340 @issue_status.update_attribute(:default_done_ratio, 50)
1321 1341 @issue2 = Issue.find(2)
1322 1342 @issue_status2 = IssueStatus.find(2)
1323 1343 @issue_status2.update_attribute(:default_done_ratio, 0)
1324 1344 end
1325 1345
1326 1346 teardown do
1327 1347 Setting.issue_done_ratio = 'issue_field'
1328 1348 end
1329 1349
1330 1350 context "with Setting.issue_done_ratio using the issue_field" do
1331 1351 setup do
1332 1352 Setting.issue_done_ratio = 'issue_field'
1333 1353 end
1334 1354
1335 1355 should "read the issue's field" do
1336 1356 assert_equal 0, @issue.done_ratio
1337 1357 assert_equal 30, @issue2.done_ratio
1338 1358 end
1339 1359 end
1340 1360
1341 1361 context "with Setting.issue_done_ratio using the issue_status" do
1342 1362 setup do
1343 1363 Setting.issue_done_ratio = 'issue_status'
1344 1364 end
1345 1365
1346 1366 should "read the Issue Status's default done ratio" do
1347 1367 assert_equal 50, @issue.done_ratio
1348 1368 assert_equal 0, @issue2.done_ratio
1349 1369 end
1350 1370 end
1351 1371 end
1352 1372
1353 1373 context "#update_done_ratio_from_issue_status" do
1354 1374 setup do
1355 1375 @issue = Issue.find(1)
1356 1376 @issue_status = IssueStatus.find(1)
1357 1377 @issue_status.update_attribute(:default_done_ratio, 50)
1358 1378 @issue2 = Issue.find(2)
1359 1379 @issue_status2 = IssueStatus.find(2)
1360 1380 @issue_status2.update_attribute(:default_done_ratio, 0)
1361 1381 end
1362 1382
1363 1383 context "with Setting.issue_done_ratio using the issue_field" do
1364 1384 setup do
1365 1385 Setting.issue_done_ratio = 'issue_field'
1366 1386 end
1367 1387
1368 1388 should "not change the issue" do
1369 1389 @issue.update_done_ratio_from_issue_status
1370 1390 @issue2.update_done_ratio_from_issue_status
1371 1391
1372 1392 assert_equal 0, @issue.read_attribute(:done_ratio)
1373 1393 assert_equal 30, @issue2.read_attribute(:done_ratio)
1374 1394 end
1375 1395 end
1376 1396
1377 1397 context "with Setting.issue_done_ratio using the issue_status" do
1378 1398 setup do
1379 1399 Setting.issue_done_ratio = 'issue_status'
1380 1400 end
1381 1401
1382 1402 should "change the issue's done ratio" do
1383 1403 @issue.update_done_ratio_from_issue_status
1384 1404 @issue2.update_done_ratio_from_issue_status
1385 1405
1386 1406 assert_equal 50, @issue.read_attribute(:done_ratio)
1387 1407 assert_equal 0, @issue2.read_attribute(:done_ratio)
1388 1408 end
1389 1409 end
1390 1410 end
1391 1411
1392 1412 test "#by_tracker" do
1393 1413 User.current = User.anonymous
1394 1414 groups = Issue.by_tracker(Project.find(1))
1395 1415 assert_equal 3, groups.size
1396 1416 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1397 1417 end
1398 1418
1399 1419 test "#by_version" do
1400 1420 User.current = User.anonymous
1401 1421 groups = Issue.by_version(Project.find(1))
1402 1422 assert_equal 3, groups.size
1403 1423 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1404 1424 end
1405 1425
1406 1426 test "#by_priority" do
1407 1427 User.current = User.anonymous
1408 1428 groups = Issue.by_priority(Project.find(1))
1409 1429 assert_equal 4, groups.size
1410 1430 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1411 1431 end
1412 1432
1413 1433 test "#by_category" do
1414 1434 User.current = User.anonymous
1415 1435 groups = Issue.by_category(Project.find(1))
1416 1436 assert_equal 2, groups.size
1417 1437 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1418 1438 end
1419 1439
1420 1440 test "#by_assigned_to" do
1421 1441 User.current = User.anonymous
1422 1442 groups = Issue.by_assigned_to(Project.find(1))
1423 1443 assert_equal 2, groups.size
1424 1444 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1425 1445 end
1426 1446
1427 1447 test "#by_author" do
1428 1448 User.current = User.anonymous
1429 1449 groups = Issue.by_author(Project.find(1))
1430 1450 assert_equal 4, groups.size
1431 1451 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1432 1452 end
1433 1453
1434 1454 test "#by_subproject" do
1435 1455 User.current = User.anonymous
1436 1456 groups = Issue.by_subproject(Project.find(1))
1437 1457 # Private descendant not visible
1438 1458 assert_equal 1, groups.size
1439 1459 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1440 1460 end
1441 1461
1442 1462 def test_recently_updated_with_limit_scopes
1443 1463 #should return the last updated issue
1444 1464 assert_equal 1, Issue.recently_updated.with_limit(1).length
1445 1465 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1446 1466 end
1447 1467
1448 1468 def test_on_active_projects_scope
1449 1469 assert Project.find(2).archive
1450 1470
1451 1471 before = Issue.on_active_project.length
1452 1472 # test inclusion to results
1453 1473 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1454 1474 assert_equal before + 1, Issue.on_active_project.length
1455 1475
1456 1476 # Move to an archived project
1457 1477 issue.project = Project.find(2)
1458 1478 assert issue.save
1459 1479 assert_equal before, Issue.on_active_project.length
1460 1480 end
1461 1481
1462 1482 context "Issue#recipients" do
1463 1483 setup do
1464 1484 @project = Project.find(1)
1465 1485 @author = User.generate!
1466 1486 @assignee = User.generate!
1467 1487 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1468 1488 end
1469 1489
1470 1490 should "include project recipients" do
1471 1491 assert @project.recipients.present?
1472 1492 @project.recipients.each do |project_recipient|
1473 1493 assert @issue.recipients.include?(project_recipient)
1474 1494 end
1475 1495 end
1476 1496
1477 1497 should "include the author if the author is active" do
1478 1498 assert @issue.author, "No author set for Issue"
1479 1499 assert @issue.recipients.include?(@issue.author.mail)
1480 1500 end
1481 1501
1482 1502 should "include the assigned to user if the assigned to user is active" do
1483 1503 assert @issue.assigned_to, "No assigned_to set for Issue"
1484 1504 assert @issue.recipients.include?(@issue.assigned_to.mail)
1485 1505 end
1486 1506
1487 1507 should "not include users who opt out of all email" do
1488 1508 @author.update_attribute(:mail_notification, :none)
1489 1509
1490 1510 assert !@issue.recipients.include?(@issue.author.mail)
1491 1511 end
1492 1512
1493 1513 should "not include the issue author if they are only notified of assigned issues" do
1494 1514 @author.update_attribute(:mail_notification, :only_assigned)
1495 1515
1496 1516 assert !@issue.recipients.include?(@issue.author.mail)
1497 1517 end
1498 1518
1499 1519 should "not include the assigned user if they are only notified of owned issues" do
1500 1520 @assignee.update_attribute(:mail_notification, :only_owner)
1501 1521
1502 1522 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1503 1523 end
1504 1524 end
1505 1525
1506 1526 def test_last_journal_id_with_journals_should_return_the_journal_id
1507 1527 assert_equal 2, Issue.find(1).last_journal_id
1508 1528 end
1509 1529
1510 1530 def test_last_journal_id_without_journals_should_return_nil
1511 1531 assert_nil Issue.find(3).last_journal_id
1512 1532 end
1513 1533 end
General Comments 0
You need to be logged in to leave comments. Login now