jro_apps/redmine Commit - r8588:9d372ce6f5b1

Allow underscores in project identifiers (#1363)....

Jean-Philippe Lang -

r8588:9d372ce6f5b1

parent child

Context file:

r8588:9d372ce6f5b1

app/models/project.rb +1 -1

               validates_length_of :homepage, :maximum => 255
               validates_length_of :identifier, :in => 1..IDENTIFIER_MAX_LENGTH
               # donwcase letters, digits, dashes but not digits only
-              validates_format_of :identifier, :with => /^(?!\d+$)[a-z0-9\-]*$/, :if => Proc.new { |p| p.identifier_changed? }
+              validates_format_of :identifier, :with => /^(?!\d+$)[a-z0-9\-_]*$/, :if => Proc.new { |p| p.identifier_changed? }
               # reserved words
               validates_exclusion_of :identifier, :in => %w( new )

config/locales/en-GB.yml +1 -1

               text_tip_issue_begin_day: task beginning this day
               text_tip_issue_end_day: task ending this day
               text_tip_issue_begin_end_day: task beginning and ending this day
-              text_project_identifier_info: 'Only lower case letters (a-z), numbers and dashes are allowed.<br />Once saved, the identifier cannot be changed.'
+              text_project_identifier_info: 'Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.'
               text_caracters_maximum: "%{count} characters maximum."
               text_caracters_minimum: "Must be at least %{count} characters long."
               text_length_between: "Length between %{min} and %{max} characters."

config/locales/en.yml +1 -1

               text_tip_issue_begin_day: issue beginning this day
               text_tip_issue_end_day: issue ending this day
               text_tip_issue_begin_end_day: issue beginning and ending this day
-              text_project_identifier_info: 'Only lower case letters (a-z), numbers and dashes are allowed.<br />Once saved, the identifier cannot be changed.'
+              text_project_identifier_info: 'Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.'
               text_caracters_maximum: "%{count} characters maximum."
               text_caracters_minimum: "Must be at least %{count} characters long."
               text_length_between: "Length between %{min} and %{max} characters."

config/locales/fr.yml +1 -1

               text_tip_issue_begin_day: tâche commençant ce jour
               text_tip_issue_end_day: tâche finissant ce jour
               text_tip_issue_begin_end_day: tâche commençant et finissant ce jour
-              text_project_identifier_info: 'Seuls les lettres minuscules (a-z), chiffres et tirets sont autorisés.<br />Un fois sauvegardé, l''identifiant ne pourra plus être modifié.'
+              text_project_identifier_info: 'Seuls les lettres minuscules (a-z), chiffres, tirets et underscore sont autorisés.<br />Un fois sauvegardé, l''identifiant ne pourra plus être modifié.'
               text_caracters_maximum: "%{count} caractères maximum."
               text_caracters_minimum: "%{count} caractères minimum."
               text_length_between: "Longueur comprise entre %{min} et %{max} caractères."

test/unit/project_test.rb +1 0

                 to_test = {"abc" => true,
                            "ab12" => true,
                            "ab-12" => true,
+                           "ab_12" => true,
                            "12" => false,
                            "new" => false}

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages