jro_apps/redmine Commit - r7981:9cc1cb52810a

Issue forms cleanup....

Jean-Philippe Lang -

r7981:9cc1cb52810a

parent child

Context file:

r7981:9cc1cb52810a

Collapse all files

app/views/issues/_edit.html.erb +1 -6

-            <% labelled_tabular_form_for :issue, @issue,
+            <% labelled_form_for @issue, :html => {:id => 'issue-form', :multipart => true} do |f| %>
-                                         :url => {:action => 'update', :id => @issue},
-                                         :html => {:id => 'issue-form',
-                                                   :class => nil,
-                                                   :method => :put,
-                                                   :multipart => true} do |f| %>
                 <%= error_messages_for 'issue', 'time_entry' %>
                 <div class="box">
                 <% if @edit_allowed || !@allowed_statuses.empty? %>
                     <fieldset class="tabular"><legend><%= l(:label_change_properties) %>
                     <% if !@issue.new_record? && !@issue.errors.any? && @edit_allowed %>
                     <small>(<%= link_to l(:label_more), {}, :onclick => 'Effect.toggle("issue_descr_fields", "appear", {duration:0.3}); return false;' %>)</small>
                     <% end %>
                     </legend>
                     <%= render :partial => (@edit_allowed ? 'form' : 'form_update'), :locals => {:f => f} %>
                     </fieldset>
                 <% end %>
                 <% if User.current.allowed_to?(:log_time, @project) %>
                     <fieldset class="tabular"><legend><%= l(:button_log_time) %></legend>
                     <% fields_for :time_entry, @time_entry, { :builder => TabularFormBuilder, :lang => current_language} do |time_entry| %>
                     <div class="splitcontentleft">
                     <p><%= time_entry.text_field :hours, :size => 6, :label => :label_spent_time %> <%= l(:field_hours) %></p>
                     </div>
                     <div class="splitcontentright">
                     <p><%= time_entry.select :activity_id, activity_collection_for_select_options %></p>
                     </div>
                     <p><%= time_entry.text_field :comments, :size => 60 %></p>
                     <% @time_entry.custom_field_values.each do |value| %>
                       <p><%= custom_field_tag_with_label :time_entry, value %></p>
                     <% end %>
                     <% end %>
                 </fieldset>
                 <% end %>
                 <fieldset><legend><%= l(:field_notes) %></legend>
                 <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %>
                 <%= wikitoolbar_for 'notes' %>
                 <%= call_hook(:view_issues_edit_notes_bottom, { :issue => @issue, :notes => @notes, :form => f }) %>
                 <p><%=l(:label_attachment_plural)%><br /><%= render :partial => 'attachments/form' %></p>
                 </fieldset>
                 </div>
                 <%= f.hidden_field :lock_version %>
                 <%= submit_tag l(:button_submit) %>
                 <%= link_to_remote l(:label_preview),
                                    { :url => preview_issue_path(:project_id => @project, :id => @issue),
                                      :method => 'post',
                                      :update => 'preview',
                                      :with => 'Form.serialize("issue-form")',
                                      :complete => "Element.scrollTo('preview')"
                                    }, :accesskey => accesskey(:preview) %>
             <% end %>
             <div id="preview" class="wiki"></div>

app/views/issues/new.html.erb +3 -3

             <h2><%=l(:label_issue_new)%></h2>
-            <% labelled_tabular_form_for :issue, @issue, :url => {:controller => 'issues', :action => 'create', :project_id => @project},
+            <% labelled_form_for @issue, :url => project_issues_path(@project),
-                                         :html => {:multipart => true, :id => 'issue-form', :class => 'tabular new-issue-form'} do |f| %>
+                                         :html => {:id => 'issue-form', :multipart => true} do |f| %>
                 <%= error_messages_for 'issue' %>
-                <div class="box">
+                <div class="box tabular">
                 <%= render :partial => 'issues/form', :locals => {:f => f} %>
                 </div>
                 <%= submit_tag l(:button_create) %>
                 <%= submit_tag l(:button_create_and_continue), :name => 'continue' %>
                 <%= link_to_remote l(:label_preview),
                                    { :url => preview_issue_path(:project_id => @project),
                                      :method => 'post',
                                      :update => 'preview',
                                      :with => "Form.serialize('issue-form')",
                                      :complete => "Element.scrollTo('preview')"
                                    }, :accesskey => accesskey(:preview) %>
                 <%= javascript_tag "Form.Element.focus('issue_subject');" %>
             <% end %>
             <div id="preview" class="wiki"></div>
             <% content_for :header_tags do %>
                 <%= stylesheet_link_tag 'scm' %>
                 <%= robot_exclusion_tag %>
             <% end %>

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages