##// END OF EJS Templates
Array#to_s behaviour changed in ruby 1.9....
Jean-Philippe Lang -
r8985:9bb056e54d1f
parent child
Show More
@@ -1,1262 +1,1262
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :groups_users,
23 23 :trackers, :projects_trackers,
24 24 :enabled_modules,
25 25 :versions,
26 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 27 :enumerations,
28 28 :issues,
29 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 30 :time_entries
31 31
32 32 include Redmine::I18n
33 33
34 34 def test_create
35 35 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
36 36 :status_id => 1, :priority => IssuePriority.all.first,
37 37 :subject => 'test_create',
38 38 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
39 39 assert issue.save
40 40 issue.reload
41 41 assert_equal 1.5, issue.estimated_hours
42 42 end
43 43
44 44 def test_create_minimal
45 45 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
46 46 :status_id => 1, :priority => IssuePriority.all.first,
47 47 :subject => 'test_create')
48 48 assert issue.save
49 49 assert issue.description.nil?
50 50 end
51 51
52 52 def test_create_with_required_custom_field
53 53 set_language_if_valid 'en'
54 54 field = IssueCustomField.find_by_name('Database')
55 55 field.update_attribute(:is_required, true)
56 56
57 57 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
58 58 :status_id => 1, :subject => 'test_create',
59 59 :description => 'IssueTest#test_create_with_required_custom_field')
60 60 assert issue.available_custom_fields.include?(field)
61 61 # No value for the custom field
62 62 assert !issue.save
63 assert_equal "Database can't be blank", issue.errors[:base].to_s
63 assert_equal ["Database can't be blank"], issue.errors.full_messages
64 64 # Blank value
65 65 issue.custom_field_values = { field.id => '' }
66 66 assert !issue.save
67 assert_equal "Database can't be blank", issue.errors[:base].to_s
67 assert_equal ["Database can't be blank"], issue.errors.full_messages
68 68 # Invalid value
69 69 issue.custom_field_values = { field.id => 'SQLServer' }
70 70 assert !issue.save
71 assert_equal "Database is not included in the list", issue.errors[:base].to_s
71 assert_equal ["Database is not included in the list"], issue.errors.full_messages
72 72 # Valid value
73 73 issue.custom_field_values = { field.id => 'PostgreSQL' }
74 74 assert issue.save
75 75 issue.reload
76 76 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
77 77 end
78 78
79 79 def test_create_with_group_assignment
80 80 with_settings :issue_group_assignment => '1' do
81 81 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
82 82 :subject => 'Group assignment',
83 83 :assigned_to_id => 11).save
84 84 issue = Issue.first(:order => 'id DESC')
85 85 assert_kind_of Group, issue.assigned_to
86 86 assert_equal Group.find(11), issue.assigned_to
87 87 end
88 88 end
89 89
90 90 def assert_visibility_match(user, issues)
91 91 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
92 92 end
93 93
94 94 def test_visible_scope_for_anonymous
95 95 # Anonymous user should see issues of public projects only
96 96 issues = Issue.visible(User.anonymous).all
97 97 assert issues.any?
98 98 assert_nil issues.detect {|issue| !issue.project.is_public?}
99 99 assert_nil issues.detect {|issue| issue.is_private?}
100 100 assert_visibility_match User.anonymous, issues
101 101 end
102 102
103 103 def test_visible_scope_for_anonymous_with_own_issues_visibility
104 104 Role.anonymous.update_attribute :issues_visibility, 'own'
105 105 Issue.create!(:project_id => 1, :tracker_id => 1,
106 106 :author_id => User.anonymous.id,
107 107 :subject => 'Issue by anonymous')
108 108
109 109 issues = Issue.visible(User.anonymous).all
110 110 assert issues.any?
111 111 assert_nil issues.detect {|issue| issue.author != User.anonymous}
112 112 assert_visibility_match User.anonymous, issues
113 113 end
114 114
115 115 def test_visible_scope_for_anonymous_without_view_issues_permissions
116 116 # Anonymous user should not see issues without permission
117 117 Role.anonymous.remove_permission!(:view_issues)
118 118 issues = Issue.visible(User.anonymous).all
119 119 assert issues.empty?
120 120 assert_visibility_match User.anonymous, issues
121 121 end
122 122
123 123 def test_visible_scope_for_non_member
124 124 user = User.find(9)
125 125 assert user.projects.empty?
126 126 # Non member user should see issues of public projects only
127 127 issues = Issue.visible(user).all
128 128 assert issues.any?
129 129 assert_nil issues.detect {|issue| !issue.project.is_public?}
130 130 assert_nil issues.detect {|issue| issue.is_private?}
131 131 assert_visibility_match user, issues
132 132 end
133 133
134 134 def test_visible_scope_for_non_member_with_own_issues_visibility
135 135 Role.non_member.update_attribute :issues_visibility, 'own'
136 136 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
137 137 user = User.find(9)
138 138
139 139 issues = Issue.visible(user).all
140 140 assert issues.any?
141 141 assert_nil issues.detect {|issue| issue.author != user}
142 142 assert_visibility_match user, issues
143 143 end
144 144
145 145 def test_visible_scope_for_non_member_without_view_issues_permissions
146 146 # Non member user should not see issues without permission
147 147 Role.non_member.remove_permission!(:view_issues)
148 148 user = User.find(9)
149 149 assert user.projects.empty?
150 150 issues = Issue.visible(user).all
151 151 assert issues.empty?
152 152 assert_visibility_match user, issues
153 153 end
154 154
155 155 def test_visible_scope_for_member
156 156 user = User.find(9)
157 157 # User should see issues of projects for which he has view_issues permissions only
158 158 Role.non_member.remove_permission!(:view_issues)
159 159 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
160 160 issues = Issue.visible(user).all
161 161 assert issues.any?
162 162 assert_nil issues.detect {|issue| issue.project_id != 3}
163 163 assert_nil issues.detect {|issue| issue.is_private?}
164 164 assert_visibility_match user, issues
165 165 end
166 166
167 167 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
168 168 user = User.find(8)
169 169 assert user.groups.any?
170 170 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
171 171 Role.non_member.remove_permission!(:view_issues)
172 172
173 173 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
174 174 :status_id => 1, :priority => IssuePriority.all.first,
175 175 :subject => 'Assignment test',
176 176 :assigned_to => user.groups.first,
177 177 :is_private => true)
178 178
179 179 Role.find(2).update_attribute :issues_visibility, 'default'
180 180 issues = Issue.visible(User.find(8)).all
181 181 assert issues.any?
182 182 assert issues.include?(issue)
183 183
184 184 Role.find(2).update_attribute :issues_visibility, 'own'
185 185 issues = Issue.visible(User.find(8)).all
186 186 assert issues.any?
187 187 assert issues.include?(issue)
188 188 end
189 189
190 190 def test_visible_scope_for_admin
191 191 user = User.find(1)
192 192 user.members.each(&:destroy)
193 193 assert user.projects.empty?
194 194 issues = Issue.visible(user).all
195 195 assert issues.any?
196 196 # Admin should see issues on private projects that he does not belong to
197 197 assert issues.detect {|issue| !issue.project.is_public?}
198 198 # Admin should see private issues of other users
199 199 assert issues.detect {|issue| issue.is_private? && issue.author != user}
200 200 assert_visibility_match user, issues
201 201 end
202 202
203 203 def test_visible_scope_with_project
204 204 project = Project.find(1)
205 205 issues = Issue.visible(User.find(2), :project => project).all
206 206 projects = issues.collect(&:project).uniq
207 207 assert_equal 1, projects.size
208 208 assert_equal project, projects.first
209 209 end
210 210
211 211 def test_visible_scope_with_project_and_subprojects
212 212 project = Project.find(1)
213 213 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
214 214 projects = issues.collect(&:project).uniq
215 215 assert projects.size > 1
216 216 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
217 217 end
218 218
219 219 def test_visible_and_nested_set_scopes
220 220 assert_equal 0, Issue.find(1).descendants.visible.all.size
221 221 end
222 222
223 223 def test_open_scope
224 224 issues = Issue.open.all
225 225 assert_nil issues.detect(&:closed?)
226 226 end
227 227
228 228 def test_open_scope_with_arg
229 229 issues = Issue.open(false).all
230 230 assert_equal issues, issues.select(&:closed?)
231 231 end
232 232
233 233 def test_errors_full_messages_should_include_custom_fields_errors
234 234 field = IssueCustomField.find_by_name('Database')
235 235
236 236 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
237 237 :status_id => 1, :subject => 'test_create',
238 238 :description => 'IssueTest#test_create_with_required_custom_field')
239 239 assert issue.available_custom_fields.include?(field)
240 240 # Invalid value
241 241 issue.custom_field_values = { field.id => 'SQLServer' }
242 242
243 243 assert !issue.valid?
244 244 assert_equal 1, issue.errors.full_messages.size
245 245 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
246 246 issue.errors.full_messages.first
247 247 end
248 248
249 249 def test_update_issue_with_required_custom_field
250 250 field = IssueCustomField.find_by_name('Database')
251 251 field.update_attribute(:is_required, true)
252 252
253 253 issue = Issue.find(1)
254 254 assert_nil issue.custom_value_for(field)
255 255 assert issue.available_custom_fields.include?(field)
256 256 # No change to custom values, issue can be saved
257 257 assert issue.save
258 258 # Blank value
259 259 issue.custom_field_values = { field.id => '' }
260 260 assert !issue.save
261 261 # Valid value
262 262 issue.custom_field_values = { field.id => 'PostgreSQL' }
263 263 assert issue.save
264 264 issue.reload
265 265 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
266 266 end
267 267
268 268 def test_should_not_update_attributes_if_custom_fields_validation_fails
269 269 issue = Issue.find(1)
270 270 field = IssueCustomField.find_by_name('Database')
271 271 assert issue.available_custom_fields.include?(field)
272 272
273 273 issue.custom_field_values = { field.id => 'Invalid' }
274 274 issue.subject = 'Should be not be saved'
275 275 assert !issue.save
276 276
277 277 issue.reload
278 278 assert_equal "Can't print recipes", issue.subject
279 279 end
280 280
281 281 def test_should_not_recreate_custom_values_objects_on_update
282 282 field = IssueCustomField.find_by_name('Database')
283 283
284 284 issue = Issue.find(1)
285 285 issue.custom_field_values = { field.id => 'PostgreSQL' }
286 286 assert issue.save
287 287 custom_value = issue.custom_value_for(field)
288 288 issue.reload
289 289 issue.custom_field_values = { field.id => 'MySQL' }
290 290 assert issue.save
291 291 issue.reload
292 292 assert_equal custom_value.id, issue.custom_value_for(field).id
293 293 end
294 294
295 295 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
296 296 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'Test', :custom_field_values => {'2' => 'Test'})
297 297 assert !Tracker.find(2).custom_field_ids.include?(2)
298 298
299 299 issue = Issue.find(issue.id)
300 300 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
301 301
302 302 issue = Issue.find(issue.id)
303 303 custom_value = issue.custom_value_for(2)
304 304 assert_not_nil custom_value
305 305 assert_equal 'Test', custom_value.value
306 306 end
307 307
308 308 def test_assigning_tracker_id_should_reload_custom_fields_values
309 309 issue = Issue.new(:project => Project.find(1))
310 310 assert issue.custom_field_values.empty?
311 311 issue.tracker_id = 1
312 312 assert issue.custom_field_values.any?
313 313 end
314 314
315 315 def test_assigning_attributes_should_assign_project_and_tracker_first
316 316 seq = sequence('seq')
317 317 issue = Issue.new
318 318 issue.expects(:project_id=).in_sequence(seq)
319 319 issue.expects(:tracker_id=).in_sequence(seq)
320 320 issue.expects(:subject=).in_sequence(seq)
321 321 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
322 322 end
323 323
324 324 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
325 325 attributes = ActiveSupport::OrderedHash.new
326 326 attributes['custom_field_values'] = { '1' => 'MySQL' }
327 327 attributes['tracker_id'] = '1'
328 328 issue = Issue.new(:project => Project.find(1))
329 329 issue.attributes = attributes
330 330 assert_equal 'MySQL', issue.custom_field_value(1)
331 331 end
332 332
333 333 def test_should_update_issue_with_disabled_tracker
334 334 p = Project.find(1)
335 335 issue = Issue.find(1)
336 336
337 337 p.trackers.delete(issue.tracker)
338 338 assert !p.trackers.include?(issue.tracker)
339 339
340 340 issue.reload
341 341 issue.subject = 'New subject'
342 342 assert issue.save
343 343 end
344 344
345 345 def test_should_not_set_a_disabled_tracker
346 346 p = Project.find(1)
347 347 p.trackers.delete(Tracker.find(2))
348 348
349 349 issue = Issue.find(1)
350 350 issue.tracker_id = 2
351 351 issue.subject = 'New subject'
352 352 assert !issue.save
353 353 assert_not_nil issue.errors[:tracker_id]
354 354 end
355 355
356 356 def test_category_based_assignment
357 357 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
358 358 :status_id => 1, :priority => IssuePriority.all.first,
359 359 :subject => 'Assignment test',
360 360 :description => 'Assignment test', :category_id => 1)
361 361 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
362 362 end
363 363
364 364 def test_new_statuses_allowed_to
365 365 Workflow.delete_all
366 366
367 367 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
368 368 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
369 369 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
370 370 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
371 371 status = IssueStatus.find(1)
372 372 role = Role.find(1)
373 373 tracker = Tracker.find(1)
374 374 user = User.find(2)
375 375
376 376 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
377 377 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
378 378
379 379 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
380 380 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
381 381
382 382 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
383 383 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
384 384
385 385 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
386 386 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
387 387 end
388 388
389 389 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
390 390 admin = User.find(1)
391 391 issue = Issue.find(1)
392 392 assert !admin.member_of?(issue.project)
393 393 expected_statuses = [issue.status] + Workflow.find_all_by_old_status_id(issue.status_id).map(&:new_status).uniq.sort
394 394
395 395 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
396 396 end
397 397
398 398 def test_copy
399 399 issue = Issue.new.copy_from(1)
400 400 assert issue.copy?
401 401 assert issue.save
402 402 issue.reload
403 403 orig = Issue.find(1)
404 404 assert_equal orig.subject, issue.subject
405 405 assert_equal orig.tracker, issue.tracker
406 406 assert_equal "125", issue.custom_value_for(2).value
407 407 end
408 408
409 409 def test_copy_should_copy_status
410 410 orig = Issue.find(8)
411 411 assert orig.status != IssueStatus.default
412 412
413 413 issue = Issue.new.copy_from(orig)
414 414 assert issue.save
415 415 issue.reload
416 416 assert_equal orig.status, issue.status
417 417 end
418 418
419 419 def test_should_not_call_after_project_change_on_creation
420 420 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Test', :author_id => 1)
421 421 issue.expects(:after_project_change).never
422 422 issue.save!
423 423 end
424 424
425 425 def test_should_not_call_after_project_change_on_update
426 426 issue = Issue.find(1)
427 427 issue.project = Project.find(1)
428 428 issue.subject = 'No project change'
429 429 issue.expects(:after_project_change).never
430 430 issue.save!
431 431 end
432 432
433 433 def test_should_call_after_project_change_on_project_change
434 434 issue = Issue.find(1)
435 435 issue.project = Project.find(2)
436 436 issue.expects(:after_project_change).once
437 437 issue.save!
438 438 end
439 439
440 440 def test_should_close_duplicates
441 441 # Create 3 issues
442 442 project = Project.find(1)
443 443 issue1 = Issue.generate_for_project!(project)
444 444 issue2 = Issue.generate_for_project!(project)
445 445 issue3 = Issue.generate_for_project!(project)
446 446
447 447 # 2 is a dupe of 1
448 448 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
449 449 # And 3 is a dupe of 2
450 450 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
451 451 # And 3 is a dupe of 1 (circular duplicates)
452 452 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
453 453
454 454 assert issue1.reload.duplicates.include?(issue2)
455 455
456 456 # Closing issue 1
457 457 issue1.init_journal(User.find(:first), "Closing issue1")
458 458 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
459 459 assert issue1.save
460 460 # 2 and 3 should be also closed
461 461 assert issue2.reload.closed?
462 462 assert issue3.reload.closed?
463 463 end
464 464
465 465 def test_should_not_close_duplicated_issue
466 466 project = Project.find(1)
467 467 issue1 = Issue.generate_for_project!(project)
468 468 issue2 = Issue.generate_for_project!(project)
469 469
470 470 # 2 is a dupe of 1
471 471 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
472 472 # 2 is a dup of 1 but 1 is not a duplicate of 2
473 473 assert !issue2.reload.duplicates.include?(issue1)
474 474
475 475 # Closing issue 2
476 476 issue2.init_journal(User.find(:first), "Closing issue2")
477 477 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
478 478 assert issue2.save
479 479 # 1 should not be also closed
480 480 assert !issue1.reload.closed?
481 481 end
482 482
483 483 def test_assignable_versions
484 484 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
485 485 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
486 486 end
487 487
488 488 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
489 489 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
490 490 assert !issue.save
491 491 assert_not_nil issue.errors[:fixed_version_id]
492 492 end
493 493
494 494 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
495 495 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
496 496 assert !issue.save
497 497 assert_not_nil issue.errors[:fixed_version_id]
498 498 end
499 499
500 500 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
501 501 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
502 502 assert issue.save
503 503 end
504 504
505 505 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
506 506 issue = Issue.find(11)
507 507 assert_equal 'closed', issue.fixed_version.status
508 508 issue.subject = 'Subject changed'
509 509 assert issue.save
510 510 end
511 511
512 512 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
513 513 issue = Issue.find(11)
514 514 issue.status_id = 1
515 515 assert !issue.save
516 516 assert_not_nil issue.errors[:base]
517 517 end
518 518
519 519 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
520 520 issue = Issue.find(11)
521 521 issue.status_id = 1
522 522 issue.fixed_version_id = 3
523 523 assert issue.save
524 524 end
525 525
526 526 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
527 527 issue = Issue.find(12)
528 528 assert_equal 'locked', issue.fixed_version.status
529 529 issue.status_id = 1
530 530 assert issue.save
531 531 end
532 532
533 533 def test_move_to_another_project_with_same_category
534 534 issue = Issue.find(1)
535 535 issue.project = Project.find(2)
536 536 assert issue.save
537 537 issue.reload
538 538 assert_equal 2, issue.project_id
539 539 # Category changes
540 540 assert_equal 4, issue.category_id
541 541 # Make sure time entries were move to the target project
542 542 assert_equal 2, issue.time_entries.first.project_id
543 543 end
544 544
545 545 def test_move_to_another_project_without_same_category
546 546 issue = Issue.find(2)
547 547 issue.project = Project.find(2)
548 548 assert issue.save
549 549 issue.reload
550 550 assert_equal 2, issue.project_id
551 551 # Category cleared
552 552 assert_nil issue.category_id
553 553 end
554 554
555 555 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
556 556 issue = Issue.find(1)
557 557 issue.update_attribute(:fixed_version_id, 1)
558 558 issue.project = Project.find(2)
559 559 assert issue.save
560 560 issue.reload
561 561 assert_equal 2, issue.project_id
562 562 # Cleared fixed_version
563 563 assert_equal nil, issue.fixed_version
564 564 end
565 565
566 566 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
567 567 issue = Issue.find(1)
568 568 issue.update_attribute(:fixed_version_id, 4)
569 569 issue.project = Project.find(5)
570 570 assert issue.save
571 571 issue.reload
572 572 assert_equal 5, issue.project_id
573 573 # Keep fixed_version
574 574 assert_equal 4, issue.fixed_version_id
575 575 end
576 576
577 577 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
578 578 issue = Issue.find(1)
579 579 issue.update_attribute(:fixed_version_id, 1)
580 580 issue.project = Project.find(5)
581 581 assert issue.save
582 582 issue.reload
583 583 assert_equal 5, issue.project_id
584 584 # Cleared fixed_version
585 585 assert_equal nil, issue.fixed_version
586 586 end
587 587
588 588 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
589 589 issue = Issue.find(1)
590 590 issue.update_attribute(:fixed_version_id, 7)
591 591 issue.project = Project.find(2)
592 592 assert issue.save
593 593 issue.reload
594 594 assert_equal 2, issue.project_id
595 595 # Keep fixed_version
596 596 assert_equal 7, issue.fixed_version_id
597 597 end
598 598
599 599 def test_move_to_another_project_with_disabled_tracker
600 600 issue = Issue.find(1)
601 601 target = Project.find(2)
602 602 target.tracker_ids = [3]
603 603 target.save
604 604 issue.project = target
605 605 assert issue.save
606 606 issue.reload
607 607 assert_equal 2, issue.project_id
608 608 assert_equal 3, issue.tracker_id
609 609 end
610 610
611 611 def test_copy_to_the_same_project
612 612 issue = Issue.find(1)
613 613 copy = issue.copy
614 614 assert_difference 'Issue.count' do
615 615 copy.save!
616 616 end
617 617 assert_kind_of Issue, copy
618 618 assert_equal issue.project, copy.project
619 619 assert_equal "125", copy.custom_value_for(2).value
620 620 end
621 621
622 622 def test_copy_to_another_project_and_tracker
623 623 issue = Issue.find(1)
624 624 copy = issue.copy(:project_id => 3, :tracker_id => 2)
625 625 assert_difference 'Issue.count' do
626 626 copy.save!
627 627 end
628 628 copy.reload
629 629 assert_kind_of Issue, copy
630 630 assert_equal Project.find(3), copy.project
631 631 assert_equal Tracker.find(2), copy.tracker
632 632 # Custom field #2 is not associated with target tracker
633 633 assert_nil copy.custom_value_for(2)
634 634 end
635 635
636 636 context "#copy" do
637 637 setup do
638 638 @issue = Issue.find(1)
639 639 end
640 640
641 641 should "not create a journal" do
642 642 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
643 643 copy.save!
644 644 assert_equal 0, copy.reload.journals.size
645 645 end
646 646
647 647 should "allow assigned_to changes" do
648 648 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
649 649 assert_equal 3, copy.assigned_to_id
650 650 end
651 651
652 652 should "allow status changes" do
653 653 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
654 654 assert_equal 2, copy.status_id
655 655 end
656 656
657 657 should "allow start date changes" do
658 658 date = Date.today
659 659 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
660 660 assert_equal date, copy.start_date
661 661 end
662 662
663 663 should "allow due date changes" do
664 664 date = Date.today
665 665 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
666 666 assert_equal date, copy.due_date
667 667 end
668 668
669 669 should "set current user as author" do
670 670 User.current = User.find(9)
671 671 copy = @issue.copy(:project_id => 3, :tracker_id => 2)
672 672 assert_equal User.current, copy.author
673 673 end
674 674
675 675 should "create a journal with notes" do
676 676 date = Date.today
677 677 notes = "Notes added when copying"
678 678 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
679 679 copy.init_journal(User.current, notes)
680 680 copy.save!
681 681
682 682 assert_equal 1, copy.journals.size
683 683 journal = copy.journals.first
684 684 assert_equal 0, journal.details.size
685 685 assert_equal notes, journal.notes
686 686 end
687 687 end
688 688
689 689 def test_recipients_should_include_previous_assignee
690 690 user = User.find(3)
691 691 user.members.update_all ["mail_notification = ?", false]
692 692 user.update_attribute :mail_notification, 'only_assigned'
693 693
694 694 issue = Issue.find(2)
695 695 issue.assigned_to = nil
696 696 assert_include user.mail, issue.recipients
697 697 issue.save!
698 698 assert !issue.recipients.include?(user.mail)
699 699 end
700 700
701 701 def test_recipients_should_not_include_users_that_cannot_view_the_issue
702 702 issue = Issue.find(12)
703 703 assert issue.recipients.include?(issue.author.mail)
704 704 # copy the issue to a private project
705 705 copy = issue.copy(:project_id => 5, :tracker_id => 2)
706 706 # author is not a member of project anymore
707 707 assert !copy.recipients.include?(copy.author.mail)
708 708 end
709 709
710 710 def test_recipients_should_include_the_assigned_group_members
711 711 group_member = User.generate_with_protected!
712 712 group = Group.generate!
713 713 group.users << group_member
714 714
715 715 issue = Issue.find(12)
716 716 issue.assigned_to = group
717 717 assert issue.recipients.include?(group_member.mail)
718 718 end
719 719
720 720 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
721 721 user = User.find(3)
722 722 issue = Issue.find(9)
723 723 Watcher.create!(:user => user, :watchable => issue)
724 724 assert issue.watched_by?(user)
725 725 assert !issue.watcher_recipients.include?(user.mail)
726 726 end
727 727
728 728 def test_issue_destroy
729 729 Issue.find(1).destroy
730 730 assert_nil Issue.find_by_id(1)
731 731 assert_nil TimeEntry.find_by_issue_id(1)
732 732 end
733 733
734 734 def test_blocked
735 735 blocked_issue = Issue.find(9)
736 736 blocking_issue = Issue.find(10)
737 737
738 738 assert blocked_issue.blocked?
739 739 assert !blocking_issue.blocked?
740 740 end
741 741
742 742 def test_blocked_issues_dont_allow_closed_statuses
743 743 blocked_issue = Issue.find(9)
744 744
745 745 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
746 746 assert !allowed_statuses.empty?
747 747 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
748 748 assert closed_statuses.empty?
749 749 end
750 750
751 751 def test_unblocked_issues_allow_closed_statuses
752 752 blocking_issue = Issue.find(10)
753 753
754 754 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
755 755 assert !allowed_statuses.empty?
756 756 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
757 757 assert !closed_statuses.empty?
758 758 end
759 759
760 760 def test_rescheduling_an_issue_should_reschedule_following_issue
761 761 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
762 762 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
763 763 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
764 764 assert_equal issue1.due_date + 1, issue2.reload.start_date
765 765
766 766 issue1.due_date = Date.today + 5
767 767 issue1.save!
768 768 assert_equal issue1.due_date + 1, issue2.reload.start_date
769 769 end
770 770
771 771 def test_rescheduling_a_stale_issue_should_not_raise_an_error
772 772 stale = Issue.find(1)
773 773 issue = Issue.find(1)
774 774 issue.subject = "Updated"
775 775 issue.save!
776 776
777 777 date = 10.days.from_now.to_date
778 778 assert_nothing_raised do
779 779 stale.reschedule_after(date)
780 780 end
781 781 assert_equal date, stale.reload.start_date
782 782 end
783 783
784 784 def test_overdue
785 785 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
786 786 assert !Issue.new(:due_date => Date.today).overdue?
787 787 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
788 788 assert !Issue.new(:due_date => nil).overdue?
789 789 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
790 790 end
791 791
792 792 context "#behind_schedule?" do
793 793 should "be false if the issue has no start_date" do
794 794 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
795 795 end
796 796
797 797 should "be false if the issue has no end_date" do
798 798 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
799 799 end
800 800
801 801 should "be false if the issue has more done than it's calendar time" do
802 802 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
803 803 end
804 804
805 805 should "be true if the issue hasn't been started at all" do
806 806 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
807 807 end
808 808
809 809 should "be true if the issue has used more calendar time than it's done ratio" do
810 810 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
811 811 end
812 812 end
813 813
814 814 context "#assignable_users" do
815 815 should "be Users" do
816 816 assert_kind_of User, Issue.find(1).assignable_users.first
817 817 end
818 818
819 819 should "include the issue author" do
820 820 project = Project.find(1)
821 821 non_project_member = User.generate!
822 822 issue = Issue.generate_for_project!(project, :author => non_project_member)
823 823
824 824 assert issue.assignable_users.include?(non_project_member)
825 825 end
826 826
827 827 should "include the current assignee" do
828 828 project = Project.find(1)
829 829 user = User.generate!
830 830 issue = Issue.generate_for_project!(project, :assigned_to => user)
831 831 user.lock!
832 832
833 833 assert Issue.find(issue.id).assignable_users.include?(user)
834 834 end
835 835
836 836 should "not show the issue author twice" do
837 837 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
838 838 assert_equal 2, assignable_user_ids.length
839 839
840 840 assignable_user_ids.each do |user_id|
841 841 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
842 842 end
843 843 end
844 844
845 845 context "with issue_group_assignment" do
846 846 should "include groups" do
847 847 issue = Issue.new(:project => Project.find(2))
848 848
849 849 with_settings :issue_group_assignment => '1' do
850 850 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
851 851 assert issue.assignable_users.include?(Group.find(11))
852 852 end
853 853 end
854 854 end
855 855
856 856 context "without issue_group_assignment" do
857 857 should "not include groups" do
858 858 issue = Issue.new(:project => Project.find(2))
859 859
860 860 with_settings :issue_group_assignment => '0' do
861 861 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
862 862 assert !issue.assignable_users.include?(Group.find(11))
863 863 end
864 864 end
865 865 end
866 866 end
867 867
868 868 def test_create_should_send_email_notification
869 869 ActionMailer::Base.deliveries.clear
870 870 issue = Issue.new(:project_id => 1, :tracker_id => 1,
871 871 :author_id => 3, :status_id => 1,
872 872 :priority => IssuePriority.all.first,
873 873 :subject => 'test_create', :estimated_hours => '1:30')
874 874
875 875 assert issue.save
876 876 assert_equal 1, ActionMailer::Base.deliveries.size
877 877 end
878 878
879 879 def test_stale_issue_should_not_send_email_notification
880 880 ActionMailer::Base.deliveries.clear
881 881 issue = Issue.find(1)
882 882 stale = Issue.find(1)
883 883
884 884 issue.init_journal(User.find(1))
885 885 issue.subject = 'Subjet update'
886 886 assert issue.save
887 887 assert_equal 1, ActionMailer::Base.deliveries.size
888 888 ActionMailer::Base.deliveries.clear
889 889
890 890 stale.init_journal(User.find(1))
891 891 stale.subject = 'Another subjet update'
892 892 assert_raise ActiveRecord::StaleObjectError do
893 893 stale.save
894 894 end
895 895 assert ActionMailer::Base.deliveries.empty?
896 896 end
897 897
898 898 def test_journalized_description
899 899 IssueCustomField.delete_all
900 900
901 901 i = Issue.first
902 902 old_description = i.description
903 903 new_description = "This is the new description"
904 904
905 905 i.init_journal(User.find(2))
906 906 i.description = new_description
907 907 assert_difference 'Journal.count', 1 do
908 908 assert_difference 'JournalDetail.count', 1 do
909 909 i.save!
910 910 end
911 911 end
912 912
913 913 detail = JournalDetail.first(:order => 'id DESC')
914 914 assert_equal i, detail.journal.journalized
915 915 assert_equal 'attr', detail.property
916 916 assert_equal 'description', detail.prop_key
917 917 assert_equal old_description, detail.old_value
918 918 assert_equal new_description, detail.value
919 919 end
920 920
921 921 def test_blank_descriptions_should_not_be_journalized
922 922 IssueCustomField.delete_all
923 923 Issue.update_all("description = NULL", "id=1")
924 924
925 925 i = Issue.find(1)
926 926 i.init_journal(User.find(2))
927 927 i.subject = "blank description"
928 928 i.description = "\r\n"
929 929
930 930 assert_difference 'Journal.count', 1 do
931 931 assert_difference 'JournalDetail.count', 1 do
932 932 i.save!
933 933 end
934 934 end
935 935 end
936 936
937 937 def test_journalized_multi_custom_field
938 938 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list', :is_filter => true, :is_for_all => true,
939 939 :tracker_ids => [1], :possible_values => ['value1', 'value2', 'value3'], :multiple => true)
940 940
941 941 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'Test', :author_id => 1)
942 942
943 943 assert_difference 'Journal.count' do
944 944 assert_difference 'JournalDetail.count' do
945 945 issue.init_journal(User.first)
946 946 issue.custom_field_values = {field.id => ['value1']}
947 947 issue.save!
948 948 end
949 949 assert_difference 'JournalDetail.count' do
950 950 issue.init_journal(User.first)
951 951 issue.custom_field_values = {field.id => ['value1', 'value2']}
952 952 issue.save!
953 953 end
954 954 assert_difference 'JournalDetail.count', 2 do
955 955 issue.init_journal(User.first)
956 956 issue.custom_field_values = {field.id => ['value3', 'value2']}
957 957 issue.save!
958 958 end
959 959 assert_difference 'JournalDetail.count', 2 do
960 960 issue.init_journal(User.first)
961 961 issue.custom_field_values = {field.id => nil}
962 962 issue.save!
963 963 end
964 964 end
965 965 end
966 966
967 967 def test_description_eol_should_be_normalized
968 968 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
969 969 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
970 970 end
971 971
972 972 def test_saving_twice_should_not_duplicate_journal_details
973 973 i = Issue.find(:first)
974 974 i.init_journal(User.find(2), 'Some notes')
975 975 # initial changes
976 976 i.subject = 'New subject'
977 977 i.done_ratio = i.done_ratio + 10
978 978 assert_difference 'Journal.count' do
979 979 assert i.save
980 980 end
981 981 # 1 more change
982 982 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
983 983 assert_no_difference 'Journal.count' do
984 984 assert_difference 'JournalDetail.count', 1 do
985 985 i.save
986 986 end
987 987 end
988 988 # no more change
989 989 assert_no_difference 'Journal.count' do
990 990 assert_no_difference 'JournalDetail.count' do
991 991 i.save
992 992 end
993 993 end
994 994 end
995 995
996 996 def test_all_dependent_issues
997 997 IssueRelation.delete_all
998 998 assert IssueRelation.create!(:issue_from => Issue.find(1),
999 999 :issue_to => Issue.find(2),
1000 1000 :relation_type => IssueRelation::TYPE_PRECEDES)
1001 1001 assert IssueRelation.create!(:issue_from => Issue.find(2),
1002 1002 :issue_to => Issue.find(3),
1003 1003 :relation_type => IssueRelation::TYPE_PRECEDES)
1004 1004 assert IssueRelation.create!(:issue_from => Issue.find(3),
1005 1005 :issue_to => Issue.find(8),
1006 1006 :relation_type => IssueRelation::TYPE_PRECEDES)
1007 1007
1008 1008 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1009 1009 end
1010 1010
1011 1011 def test_all_dependent_issues_with_persistent_circular_dependency
1012 1012 IssueRelation.delete_all
1013 1013 assert IssueRelation.create!(:issue_from => Issue.find(1),
1014 1014 :issue_to => Issue.find(2),
1015 1015 :relation_type => IssueRelation::TYPE_PRECEDES)
1016 1016 assert IssueRelation.create!(:issue_from => Issue.find(2),
1017 1017 :issue_to => Issue.find(3),
1018 1018 :relation_type => IssueRelation::TYPE_PRECEDES)
1019 1019 # Validation skipping
1020 1020 assert IssueRelation.new(:issue_from => Issue.find(3),
1021 1021 :issue_to => Issue.find(1),
1022 1022 :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
1023 1023
1024 1024 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1025 1025 end
1026 1026
1027 1027 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1028 1028 IssueRelation.delete_all
1029 1029 assert IssueRelation.create!(:issue_from => Issue.find(1),
1030 1030 :issue_to => Issue.find(2),
1031 1031 :relation_type => IssueRelation::TYPE_RELATES)
1032 1032 assert IssueRelation.create!(:issue_from => Issue.find(2),
1033 1033 :issue_to => Issue.find(3),
1034 1034 :relation_type => IssueRelation::TYPE_RELATES)
1035 1035 assert IssueRelation.create!(:issue_from => Issue.find(3),
1036 1036 :issue_to => Issue.find(8),
1037 1037 :relation_type => IssueRelation::TYPE_RELATES)
1038 1038 # Validation skipping
1039 1039 assert IssueRelation.new(:issue_from => Issue.find(8),
1040 1040 :issue_to => Issue.find(2),
1041 1041 :relation_type => IssueRelation::TYPE_RELATES).save(false)
1042 1042 assert IssueRelation.new(:issue_from => Issue.find(3),
1043 1043 :issue_to => Issue.find(1),
1044 1044 :relation_type => IssueRelation::TYPE_RELATES).save(false)
1045 1045
1046 1046 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1047 1047 end
1048 1048
1049 1049 context "#done_ratio" do
1050 1050 setup do
1051 1051 @issue = Issue.find(1)
1052 1052 @issue_status = IssueStatus.find(1)
1053 1053 @issue_status.update_attribute(:default_done_ratio, 50)
1054 1054 @issue2 = Issue.find(2)
1055 1055 @issue_status2 = IssueStatus.find(2)
1056 1056 @issue_status2.update_attribute(:default_done_ratio, 0)
1057 1057 end
1058 1058
1059 1059 teardown do
1060 1060 Setting.issue_done_ratio = 'issue_field'
1061 1061 end
1062 1062
1063 1063 context "with Setting.issue_done_ratio using the issue_field" do
1064 1064 setup do
1065 1065 Setting.issue_done_ratio = 'issue_field'
1066 1066 end
1067 1067
1068 1068 should "read the issue's field" do
1069 1069 assert_equal 0, @issue.done_ratio
1070 1070 assert_equal 30, @issue2.done_ratio
1071 1071 end
1072 1072 end
1073 1073
1074 1074 context "with Setting.issue_done_ratio using the issue_status" do
1075 1075 setup do
1076 1076 Setting.issue_done_ratio = 'issue_status'
1077 1077 end
1078 1078
1079 1079 should "read the Issue Status's default done ratio" do
1080 1080 assert_equal 50, @issue.done_ratio
1081 1081 assert_equal 0, @issue2.done_ratio
1082 1082 end
1083 1083 end
1084 1084 end
1085 1085
1086 1086 context "#update_done_ratio_from_issue_status" do
1087 1087 setup do
1088 1088 @issue = Issue.find(1)
1089 1089 @issue_status = IssueStatus.find(1)
1090 1090 @issue_status.update_attribute(:default_done_ratio, 50)
1091 1091 @issue2 = Issue.find(2)
1092 1092 @issue_status2 = IssueStatus.find(2)
1093 1093 @issue_status2.update_attribute(:default_done_ratio, 0)
1094 1094 end
1095 1095
1096 1096 context "with Setting.issue_done_ratio using the issue_field" do
1097 1097 setup do
1098 1098 Setting.issue_done_ratio = 'issue_field'
1099 1099 end
1100 1100
1101 1101 should "not change the issue" do
1102 1102 @issue.update_done_ratio_from_issue_status
1103 1103 @issue2.update_done_ratio_from_issue_status
1104 1104
1105 1105 assert_equal 0, @issue.read_attribute(:done_ratio)
1106 1106 assert_equal 30, @issue2.read_attribute(:done_ratio)
1107 1107 end
1108 1108 end
1109 1109
1110 1110 context "with Setting.issue_done_ratio using the issue_status" do
1111 1111 setup do
1112 1112 Setting.issue_done_ratio = 'issue_status'
1113 1113 end
1114 1114
1115 1115 should "change the issue's done ratio" do
1116 1116 @issue.update_done_ratio_from_issue_status
1117 1117 @issue2.update_done_ratio_from_issue_status
1118 1118
1119 1119 assert_equal 50, @issue.read_attribute(:done_ratio)
1120 1120 assert_equal 0, @issue2.read_attribute(:done_ratio)
1121 1121 end
1122 1122 end
1123 1123 end
1124 1124
1125 1125 test "#by_tracker" do
1126 1126 User.current = User.anonymous
1127 1127 groups = Issue.by_tracker(Project.find(1))
1128 1128 assert_equal 3, groups.size
1129 1129 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1130 1130 end
1131 1131
1132 1132 test "#by_version" do
1133 1133 User.current = User.anonymous
1134 1134 groups = Issue.by_version(Project.find(1))
1135 1135 assert_equal 3, groups.size
1136 1136 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1137 1137 end
1138 1138
1139 1139 test "#by_priority" do
1140 1140 User.current = User.anonymous
1141 1141 groups = Issue.by_priority(Project.find(1))
1142 1142 assert_equal 4, groups.size
1143 1143 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1144 1144 end
1145 1145
1146 1146 test "#by_category" do
1147 1147 User.current = User.anonymous
1148 1148 groups = Issue.by_category(Project.find(1))
1149 1149 assert_equal 2, groups.size
1150 1150 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1151 1151 end
1152 1152
1153 1153 test "#by_assigned_to" do
1154 1154 User.current = User.anonymous
1155 1155 groups = Issue.by_assigned_to(Project.find(1))
1156 1156 assert_equal 2, groups.size
1157 1157 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1158 1158 end
1159 1159
1160 1160 test "#by_author" do
1161 1161 User.current = User.anonymous
1162 1162 groups = Issue.by_author(Project.find(1))
1163 1163 assert_equal 4, groups.size
1164 1164 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1165 1165 end
1166 1166
1167 1167 test "#by_subproject" do
1168 1168 User.current = User.anonymous
1169 1169 groups = Issue.by_subproject(Project.find(1))
1170 1170 # Private descendant not visible
1171 1171 assert_equal 1, groups.size
1172 1172 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1173 1173 end
1174 1174
1175 1175 context ".allowed_target_projects_on_move" do
1176 1176 should "return all active projects for admin users" do
1177 1177 User.current = User.find(1)
1178 1178 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1179 1179 end
1180 1180
1181 1181 should "return allowed projects for non admin users" do
1182 1182 User.current = User.find(2)
1183 1183 Role.non_member.remove_permission! :move_issues
1184 1184 assert_equal 3, Issue.allowed_target_projects_on_move.size
1185 1185
1186 1186 Role.non_member.add_permission! :move_issues
1187 1187 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1188 1188 end
1189 1189 end
1190 1190
1191 1191 def test_recently_updated_with_limit_scopes
1192 1192 #should return the last updated issue
1193 1193 assert_equal 1, Issue.recently_updated.with_limit(1).length
1194 1194 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1195 1195 end
1196 1196
1197 1197 def test_on_active_projects_scope
1198 1198 assert Project.find(2).archive
1199 1199
1200 1200 before = Issue.on_active_project.length
1201 1201 # test inclusion to results
1202 1202 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1203 1203 assert_equal before + 1, Issue.on_active_project.length
1204 1204
1205 1205 # Move to an archived project
1206 1206 issue.project = Project.find(2)
1207 1207 assert issue.save
1208 1208 assert_equal before, Issue.on_active_project.length
1209 1209 end
1210 1210
1211 1211 context "Issue#recipients" do
1212 1212 setup do
1213 1213 @project = Project.find(1)
1214 1214 @author = User.generate_with_protected!
1215 1215 @assignee = User.generate_with_protected!
1216 1216 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1217 1217 end
1218 1218
1219 1219 should "include project recipients" do
1220 1220 assert @project.recipients.present?
1221 1221 @project.recipients.each do |project_recipient|
1222 1222 assert @issue.recipients.include?(project_recipient)
1223 1223 end
1224 1224 end
1225 1225
1226 1226 should "include the author if the author is active" do
1227 1227 assert @issue.author, "No author set for Issue"
1228 1228 assert @issue.recipients.include?(@issue.author.mail)
1229 1229 end
1230 1230
1231 1231 should "include the assigned to user if the assigned to user is active" do
1232 1232 assert @issue.assigned_to, "No assigned_to set for Issue"
1233 1233 assert @issue.recipients.include?(@issue.assigned_to.mail)
1234 1234 end
1235 1235
1236 1236 should "not include users who opt out of all email" do
1237 1237 @author.update_attribute(:mail_notification, :none)
1238 1238
1239 1239 assert !@issue.recipients.include?(@issue.author.mail)
1240 1240 end
1241 1241
1242 1242 should "not include the issue author if they are only notified of assigned issues" do
1243 1243 @author.update_attribute(:mail_notification, :only_assigned)
1244 1244
1245 1245 assert !@issue.recipients.include?(@issue.author.mail)
1246 1246 end
1247 1247
1248 1248 should "not include the assigned user if they are only notified of owned issues" do
1249 1249 @assignee.update_attribute(:mail_notification, :only_owner)
1250 1250
1251 1251 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1252 1252 end
1253 1253 end
1254 1254
1255 1255 def test_last_journal_id_with_journals_should_return_the_journal_id
1256 1256 assert_equal 2, Issue.find(1).last_journal_id
1257 1257 end
1258 1258
1259 1259 def test_last_journal_id_without_journals_should_return_nil
1260 1260 assert_nil Issue.find(3).last_journal_id
1261 1261 end
1262 1262 end
General Comments 0
You need to be logged in to leave comments. Login now