##// END OF EJS Templates
Merged r15196 (#22072)....
Jean-Philippe Lang -
r14826:9b8e29741966
parent child
Show More
@@ -1,1650 +1,1651
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 include Redmine::Utils::DateCalculation
21 21 include Redmine::I18n
22 22 before_save :set_parent_id
23 23 include Redmine::NestedSet::IssueNestedSet
24 24
25 25 belongs_to :project
26 26 belongs_to :tracker
27 27 belongs_to :status, :class_name => 'IssueStatus'
28 28 belongs_to :author, :class_name => 'User'
29 29 belongs_to :assigned_to, :class_name => 'Principal'
30 30 belongs_to :fixed_version, :class_name => 'Version'
31 31 belongs_to :priority, :class_name => 'IssuePriority'
32 32 belongs_to :category, :class_name => 'IssueCategory'
33 33
34 34 has_many :journals, :as => :journalized, :dependent => :destroy, :inverse_of => :journalized
35 35 has_many :visible_journals,
36 36 lambda {where(["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false])},
37 37 :class_name => 'Journal',
38 38 :as => :journalized
39 39
40 40 has_many :time_entries, :dependent => :destroy
41 41 has_and_belongs_to_many :changesets, lambda {order("#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC")}
42 42
43 43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45 45
46 46 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
47 47 acts_as_customizable
48 48 acts_as_watchable
49 49 acts_as_searchable :columns => ['subject', "#{table_name}.description"],
50 50 :preload => [:project, :status, :tracker],
51 51 :scope => lambda {|options| options[:open_issues] ? self.open : self.all}
52 52
53 53 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
54 54 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
55 55 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
56 56
57 57 acts_as_activity_provider :scope => preload(:project, :author, :tracker),
58 58 :author_key => :author_id
59 59
60 60 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
61 61
62 62 attr_reader :current_journal
63 63 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
64 64
65 65 validates_presence_of :subject, :project, :tracker
66 66 validates_presence_of :priority, :if => Proc.new {|issue| issue.new_record? || issue.priority_id_changed?}
67 67 validates_presence_of :status, :if => Proc.new {|issue| issue.new_record? || issue.status_id_changed?}
68 68 validates_presence_of :author, :if => Proc.new {|issue| issue.new_record? || issue.author_id_changed?}
69 69
70 70 validates_length_of :subject, :maximum => 255
71 71 validates_inclusion_of :done_ratio, :in => 0..100
72 72 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
73 73 validates :start_date, :date => true
74 74 validates :due_date, :date => true
75 75 validate :validate_issue, :validate_required_fields
76 76 attr_protected :id
77 77
78 78 scope :visible, lambda {|*args|
79 79 joins(:project).
80 80 where(Issue.visible_condition(args.shift || User.current, *args))
81 81 }
82 82
83 83 scope :open, lambda {|*args|
84 84 is_closed = args.size > 0 ? !args.first : false
85 85 joins(:status).
86 86 where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
87 87 }
88 88
89 89 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
90 90 scope :on_active_project, lambda {
91 91 joins(:project).
92 92 where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
93 93 }
94 94 scope :fixed_version, lambda {|versions|
95 95 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
96 96 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
97 97 }
98 98
99 99 before_validation :clear_disabled_fields
100 100 before_create :default_assign
101 101 before_save :close_duplicates, :update_done_ratio_from_issue_status,
102 102 :force_updated_on_change, :update_closed_on, :set_assigned_to_was
103 103 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
104 104 after_save :reschedule_following_issues, :update_nested_set_attributes,
105 105 :update_parent_attributes, :create_journal
106 106 # Should be after_create but would be called before previous after_save callbacks
107 107 after_save :after_create_from_copy
108 108 after_destroy :update_parent_attributes
109 109 after_create :send_notification
110 110 # Keep it at the end of after_save callbacks
111 111 after_save :clear_assigned_to_was
112 112
113 113 # Returns a SQL conditions string used to find all issues visible by the specified user
114 114 def self.visible_condition(user, options={})
115 115 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
116 116 if user.id && user.logged?
117 117 case role.issues_visibility
118 118 when 'all'
119 119 nil
120 120 when 'default'
121 121 user_ids = [user.id] + user.groups.map(&:id).compact
122 122 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
123 123 when 'own'
124 124 user_ids = [user.id] + user.groups.map(&:id).compact
125 125 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
126 126 else
127 127 '1=0'
128 128 end
129 129 else
130 130 "(#{table_name}.is_private = #{connection.quoted_false})"
131 131 end
132 132 end
133 133 end
134 134
135 135 # Returns true if usr or current user is allowed to view the issue
136 136 def visible?(usr=nil)
137 137 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
138 138 if user.logged?
139 139 case role.issues_visibility
140 140 when 'all'
141 141 true
142 142 when 'default'
143 143 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
144 144 when 'own'
145 145 self.author == user || user.is_or_belongs_to?(assigned_to)
146 146 else
147 147 false
148 148 end
149 149 else
150 150 !self.is_private?
151 151 end
152 152 end
153 153 end
154 154
155 155 # Returns true if user or current user is allowed to edit or add a note to the issue
156 156 def editable?(user=User.current)
157 157 attributes_editable?(user) || user.allowed_to?(:add_issue_notes, project)
158 158 end
159 159
160 160 # Returns true if user or current user is allowed to edit the issue
161 161 def attributes_editable?(user=User.current)
162 162 user.allowed_to?(:edit_issues, project)
163 163 end
164 164
165 165 def initialize(attributes=nil, *args)
166 166 super
167 167 if new_record?
168 168 # set default values for new records only
169 169 self.priority ||= IssuePriority.default
170 170 self.watcher_user_ids = []
171 171 end
172 172 end
173 173
174 174 def create_or_update
175 175 super
176 176 ensure
177 177 @status_was = nil
178 178 end
179 179 private :create_or_update
180 180
181 181 # AR#Persistence#destroy would raise and RecordNotFound exception
182 182 # if the issue was already deleted or updated (non matching lock_version).
183 183 # This is a problem when bulk deleting issues or deleting a project
184 184 # (because an issue may already be deleted if its parent was deleted
185 185 # first).
186 186 # The issue is reloaded by the nested_set before being deleted so
187 187 # the lock_version condition should not be an issue but we handle it.
188 188 def destroy
189 189 super
190 190 rescue ActiveRecord::StaleObjectError, ActiveRecord::RecordNotFound
191 191 # Stale or already deleted
192 192 begin
193 193 reload
194 194 rescue ActiveRecord::RecordNotFound
195 195 # The issue was actually already deleted
196 196 @destroyed = true
197 197 return freeze
198 198 end
199 199 # The issue was stale, retry to destroy
200 200 super
201 201 end
202 202
203 203 alias :base_reload :reload
204 204 def reload(*args)
205 205 @workflow_rule_by_attribute = nil
206 206 @assignable_versions = nil
207 207 @relations = nil
208 208 @spent_hours = nil
209 209 @total_spent_hours = nil
210 210 @total_estimated_hours = nil
211 211 base_reload(*args)
212 212 end
213 213
214 214 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
215 215 def available_custom_fields
216 216 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields) : []
217 217 end
218 218
219 219 def visible_custom_field_values(user=nil)
220 220 user_real = user || User.current
221 221 custom_field_values.select do |value|
222 222 value.custom_field.visible_by?(project, user_real)
223 223 end
224 224 end
225 225
226 226 # Copies attributes from another issue, arg can be an id or an Issue
227 227 def copy_from(arg, options={})
228 228 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
229 229 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
230 230 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
231 231 self.status = issue.status
232 232 self.author = User.current
233 233 unless options[:attachments] == false
234 234 self.attachments = issue.attachments.map do |attachement|
235 235 attachement.copy(:container => self)
236 236 end
237 237 end
238 238 @copied_from = issue
239 239 @copy_options = options
240 240 self
241 241 end
242 242
243 243 # Returns an unsaved copy of the issue
244 244 def copy(attributes=nil, copy_options={})
245 245 copy = self.class.new.copy_from(self, copy_options)
246 246 copy.attributes = attributes if attributes
247 247 copy
248 248 end
249 249
250 250 # Returns true if the issue is a copy
251 251 def copy?
252 252 @copied_from.present?
253 253 end
254 254
255 255 def status_id=(status_id)
256 256 if status_id.to_s != self.status_id.to_s
257 257 self.status = (status_id.present? ? IssueStatus.find_by_id(status_id) : nil)
258 258 end
259 259 self.status_id
260 260 end
261 261
262 262 # Sets the status.
263 263 def status=(status)
264 264 if status != self.status
265 265 @workflow_rule_by_attribute = nil
266 266 end
267 267 association(:status).writer(status)
268 268 end
269 269
270 270 def priority_id=(pid)
271 271 self.priority = nil
272 272 write_attribute(:priority_id, pid)
273 273 end
274 274
275 275 def category_id=(cid)
276 276 self.category = nil
277 277 write_attribute(:category_id, cid)
278 278 end
279 279
280 280 def fixed_version_id=(vid)
281 281 self.fixed_version = nil
282 282 write_attribute(:fixed_version_id, vid)
283 283 end
284 284
285 285 def tracker_id=(tracker_id)
286 286 if tracker_id.to_s != self.tracker_id.to_s
287 287 self.tracker = (tracker_id.present? ? Tracker.find_by_id(tracker_id) : nil)
288 288 end
289 289 self.tracker_id
290 290 end
291 291
292 292 # Sets the tracker.
293 293 # This will set the status to the default status of the new tracker if:
294 294 # * the status was the default for the previous tracker
295 295 # * or if the status was not part of the new tracker statuses
296 296 # * or the status was nil
297 297 def tracker=(tracker)
298 298 if tracker != self.tracker
299 299 if status == default_status
300 300 self.status = nil
301 301 elsif status && tracker && !tracker.issue_status_ids.include?(status.id)
302 302 self.status = nil
303 303 end
304 304 @custom_field_values = nil
305 305 @workflow_rule_by_attribute = nil
306 306 end
307 307 association(:tracker).writer(tracker)
308 308 self.status ||= default_status
309 309 self.tracker
310 310 end
311 311
312 312 def project_id=(project_id)
313 313 if project_id.to_s != self.project_id.to_s
314 314 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
315 315 end
316 316 self.project_id
317 317 end
318 318
319 319 # Sets the project.
320 320 # Unless keep_tracker argument is set to true, this will change the tracker
321 321 # to the first tracker of the new project if the previous tracker is not part
322 322 # of the new project trackers.
323 323 # This will clear the fixed_version is it's no longer valid for the new project.
324 324 # This will clear the parent issue if it's no longer valid for the new project.
325 325 # This will set the category to the category with the same name in the new
326 326 # project if it exists, or clear it if it doesn't.
327 327 def project=(project, keep_tracker=false)
328 328 project_was = self.project
329 329 association(:project).writer(project)
330 330 if project_was && project && project_was != project
331 331 @assignable_versions = nil
332 332
333 333 unless keep_tracker || project.trackers.include?(tracker)
334 334 self.tracker = project.trackers.first
335 335 end
336 336 # Reassign to the category with same name if any
337 337 if category
338 338 self.category = project.issue_categories.find_by_name(category.name)
339 339 end
340 340 # Keep the fixed_version if it's still valid in the new_project
341 341 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
342 342 self.fixed_version = nil
343 343 end
344 344 # Clear the parent task if it's no longer valid
345 345 unless valid_parent_project?
346 346 self.parent_issue_id = nil
347 347 end
348 348 @custom_field_values = nil
349 349 @workflow_rule_by_attribute = nil
350 350 end
351 351 self.project
352 352 end
353 353
354 354 def description=(arg)
355 355 if arg.is_a?(String)
356 356 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
357 357 end
358 358 write_attribute(:description, arg)
359 359 end
360 360
361 361 # Overrides assign_attributes so that project and tracker get assigned first
362 362 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
363 363 return if new_attributes.nil?
364 364 attrs = new_attributes.dup
365 365 attrs.stringify_keys!
366 366
367 367 %w(project project_id tracker tracker_id).each do |attr|
368 368 if attrs.has_key?(attr)
369 369 send "#{attr}=", attrs.delete(attr)
370 370 end
371 371 end
372 372 send :assign_attributes_without_project_and_tracker_first, attrs, *args
373 373 end
374 374 # Do not redefine alias chain on reload (see #4838)
375 375 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
376 376
377 377 def attributes=(new_attributes)
378 378 assign_attributes new_attributes
379 379 end
380 380
381 381 def estimated_hours=(h)
382 382 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
383 383 end
384 384
385 385 safe_attributes 'project_id',
386 386 'tracker_id',
387 387 'status_id',
388 388 'category_id',
389 389 'assigned_to_id',
390 390 'priority_id',
391 391 'fixed_version_id',
392 392 'subject',
393 393 'description',
394 394 'start_date',
395 395 'due_date',
396 396 'done_ratio',
397 397 'estimated_hours',
398 398 'custom_field_values',
399 399 'custom_fields',
400 400 'lock_version',
401 401 'notes',
402 402 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
403 403
404 404 safe_attributes 'notes',
405 405 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
406 406
407 407 safe_attributes 'private_notes',
408 408 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
409 409
410 410 safe_attributes 'watcher_user_ids',
411 411 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
412 412
413 413 safe_attributes 'is_private',
414 414 :if => lambda {|issue, user|
415 415 user.allowed_to?(:set_issues_private, issue.project) ||
416 416 (issue.author_id == user.id && user.allowed_to?(:set_own_issues_private, issue.project))
417 417 }
418 418
419 419 safe_attributes 'parent_issue_id',
420 420 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
421 421 user.allowed_to?(:manage_subtasks, issue.project)}
422 422
423 423 def safe_attribute_names(user=nil)
424 424 names = super
425 425 names -= disabled_core_fields
426 426 names -= read_only_attribute_names(user)
427 427 if new_record?
428 428 # Make sure that project_id can always be set for new issues
429 429 names |= %w(project_id)
430 430 end
431 431 if dates_derived?
432 432 names -= %w(start_date due_date)
433 433 end
434 434 if priority_derived?
435 435 names -= %w(priority_id)
436 436 end
437 437 if done_ratio_derived?
438 438 names -= %w(done_ratio)
439 439 end
440 440 names
441 441 end
442 442
443 443 # Safely sets attributes
444 444 # Should be called from controllers instead of #attributes=
445 445 # attr_accessible is too rough because we still want things like
446 446 # Issue.new(:project => foo) to work
447 447 def safe_attributes=(attrs, user=User.current)
448 448 return unless attrs.is_a?(Hash)
449 449
450 450 attrs = attrs.deep_dup
451 451
452 452 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
453 453 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
454 454 if allowed_target_projects(user).where(:id => p.to_i).exists?
455 455 self.project_id = p
456 456 end
457 457 end
458 458
459 459 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
460 460 self.tracker_id = t
461 461 end
462 462 if project
463 463 # Set the default tracker to accept custom field values
464 464 # even if tracker is not specified
465 465 self.tracker ||= project.trackers.first
466 466 end
467 467
468 468 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
469 469 if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
470 470 self.status_id = s
471 471 end
472 472 end
473 473
474 474 attrs = delete_unsafe_attributes(attrs, user)
475 475 return if attrs.empty?
476 476
477 477 if attrs['parent_issue_id'].present?
478 478 s = attrs['parent_issue_id'].to_s
479 479 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
480 480 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
481 481 end
482 482 end
483 483
484 484 if attrs['custom_field_values'].present?
485 485 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
486 486 attrs['custom_field_values'].select! {|k, v| editable_custom_field_ids.include?(k.to_s)}
487 487 end
488 488
489 489 if attrs['custom_fields'].present?
490 490 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
491 491 attrs['custom_fields'].select! {|c| editable_custom_field_ids.include?(c['id'].to_s)}
492 492 end
493 493
494 494 # mass-assignment security bypass
495 495 assign_attributes attrs, :without_protection => true
496 496 end
497 497
498 498 def disabled_core_fields
499 499 tracker ? tracker.disabled_core_fields : []
500 500 end
501 501
502 502 # Returns the custom_field_values that can be edited by the given user
503 503 def editable_custom_field_values(user=nil)
504 504 visible_custom_field_values(user).reject do |value|
505 505 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
506 506 end
507 507 end
508 508
509 509 # Returns the custom fields that can be edited by the given user
510 510 def editable_custom_fields(user=nil)
511 511 editable_custom_field_values(user).map(&:custom_field).uniq
512 512 end
513 513
514 514 # Returns the names of attributes that are read-only for user or the current user
515 515 # For users with multiple roles, the read-only fields are the intersection of
516 516 # read-only fields of each role
517 517 # The result is an array of strings where sustom fields are represented with their ids
518 518 #
519 519 # Examples:
520 520 # issue.read_only_attribute_names # => ['due_date', '2']
521 521 # issue.read_only_attribute_names(user) # => []
522 522 def read_only_attribute_names(user=nil)
523 523 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
524 524 end
525 525
526 526 # Returns the names of required attributes for user or the current user
527 527 # For users with multiple roles, the required fields are the intersection of
528 528 # required fields of each role
529 529 # The result is an array of strings where sustom fields are represented with their ids
530 530 #
531 531 # Examples:
532 532 # issue.required_attribute_names # => ['due_date', '2']
533 533 # issue.required_attribute_names(user) # => []
534 534 def required_attribute_names(user=nil)
535 535 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
536 536 end
537 537
538 538 # Returns true if the attribute is required for user
539 539 def required_attribute?(name, user=nil)
540 540 required_attribute_names(user).include?(name.to_s)
541 541 end
542 542
543 543 # Returns a hash of the workflow rule by attribute for the given user
544 544 #
545 545 # Examples:
546 546 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
547 547 def workflow_rule_by_attribute(user=nil)
548 548 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
549 549
550 550 user_real = user || User.current
551 551 roles = user_real.admin ? Role.all.to_a : user_real.roles_for_project(project)
552 552 roles = roles.select(&:consider_workflow?)
553 553 return {} if roles.empty?
554 554
555 555 result = {}
556 556 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).to_a
557 557 if workflow_permissions.any?
558 558 workflow_rules = workflow_permissions.inject({}) do |h, wp|
559 559 h[wp.field_name] ||= {}
560 560 h[wp.field_name][wp.role_id] = wp.rule
561 561 h
562 562 end
563 563 fields_with_roles = {}
564 564 IssueCustomField.where(:visible => false).joins(:roles).pluck(:id, "role_id").each do |field_id, role_id|
565 565 fields_with_roles[field_id] ||= []
566 566 fields_with_roles[field_id] << role_id
567 567 end
568 568 roles.each do |role|
569 569 fields_with_roles.each do |field_id, role_ids|
570 570 unless role_ids.include?(role.id)
571 571 field_name = field_id.to_s
572 572 workflow_rules[field_name] ||= {}
573 573 workflow_rules[field_name][role.id] = 'readonly'
574 574 end
575 575 end
576 576 end
577 577 workflow_rules.each do |attr, rules|
578 578 next if rules.size < roles.size
579 579 uniq_rules = rules.values.uniq
580 580 if uniq_rules.size == 1
581 581 result[attr] = uniq_rules.first
582 582 else
583 583 result[attr] = 'required'
584 584 end
585 585 end
586 586 end
587 587 @workflow_rule_by_attribute = result if user.nil?
588 588 result
589 589 end
590 590 private :workflow_rule_by_attribute
591 591
592 592 def done_ratio
593 593 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
594 594 status.default_done_ratio
595 595 else
596 596 read_attribute(:done_ratio)
597 597 end
598 598 end
599 599
600 600 def self.use_status_for_done_ratio?
601 601 Setting.issue_done_ratio == 'issue_status'
602 602 end
603 603
604 604 def self.use_field_for_done_ratio?
605 605 Setting.issue_done_ratio == 'issue_field'
606 606 end
607 607
608 608 def validate_issue
609 609 if due_date && start_date && (start_date_changed? || due_date_changed?) && due_date < start_date
610 610 errors.add :due_date, :greater_than_start_date
611 611 end
612 612
613 613 if start_date && start_date_changed? && soonest_start && start_date < soonest_start
614 614 errors.add :start_date, :earlier_than_minimum_start_date, :date => format_date(soonest_start)
615 615 end
616 616
617 617 if fixed_version
618 618 if !assignable_versions.include?(fixed_version)
619 619 errors.add :fixed_version_id, :inclusion
620 620 elsif reopening? && fixed_version.closed?
621 621 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
622 622 end
623 623 end
624 624
625 625 # Checks that the issue can not be added/moved to a disabled tracker
626 626 if project && (tracker_id_changed? || project_id_changed?)
627 627 unless project.trackers.include?(tracker)
628 628 errors.add :tracker_id, :inclusion
629 629 end
630 630 end
631 631
632 632 # Checks parent issue assignment
633 633 if @invalid_parent_issue_id.present?
634 634 errors.add :parent_issue_id, :invalid
635 635 elsif @parent_issue
636 636 if !valid_parent_project?(@parent_issue)
637 637 errors.add :parent_issue_id, :invalid
638 638 elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
639 639 errors.add :parent_issue_id, :invalid
640 640 elsif !new_record?
641 641 # moving an existing issue
642 642 if move_possible?(@parent_issue)
643 643 # move accepted
644 644 else
645 645 errors.add :parent_issue_id, :invalid
646 646 end
647 647 end
648 648 end
649 649 end
650 650
651 651 # Validates the issue against additional workflow requirements
652 652 def validate_required_fields
653 653 user = new_record? ? author : current_journal.try(:user)
654 654
655 655 required_attribute_names(user).each do |attribute|
656 656 if attribute =~ /^\d+$/
657 657 attribute = attribute.to_i
658 658 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
659 659 if v && Array(v.value).detect(&:present?).nil?
660 660 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
661 661 end
662 662 else
663 663 if respond_to?(attribute) && send(attribute).blank? && !disabled_core_fields.include?(attribute)
664 664 errors.add attribute, :blank
665 665 end
666 666 end
667 667 end
668 668 end
669 669
670 670 # Overrides Redmine::Acts::Customizable::InstanceMethods#validate_custom_field_values
671 671 # so that custom values that are not editable are not validated (eg. a custom field that
672 672 # is marked as required should not trigger a validation error if the user is not allowed
673 673 # to edit this field).
674 674 def validate_custom_field_values
675 675 user = new_record? ? author : current_journal.try(:user)
676 676 if new_record? || custom_field_values_changed?
677 677 editable_custom_field_values(user).each(&:validate_value)
678 678 end
679 679 end
680 680
681 681 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
682 682 # even if the user turns off the setting later
683 683 def update_done_ratio_from_issue_status
684 684 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
685 685 self.done_ratio = status.default_done_ratio
686 686 end
687 687 end
688 688
689 689 def init_journal(user, notes = "")
690 690 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
691 691 end
692 692
693 693 # Returns the current journal or nil if it's not initialized
694 694 def current_journal
695 695 @current_journal
696 696 end
697 697
698 698 # Returns the names of attributes that are journalized when updating the issue
699 699 def journalized_attribute_names
700 700 names = Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)
701 701 if tracker
702 702 names -= tracker.disabled_core_fields
703 703 end
704 704 names
705 705 end
706 706
707 707 # Returns the id of the last journal or nil
708 708 def last_journal_id
709 709 if new_record?
710 710 nil
711 711 else
712 712 journals.maximum(:id)
713 713 end
714 714 end
715 715
716 716 # Returns a scope for journals that have an id greater than journal_id
717 717 def journals_after(journal_id)
718 718 scope = journals.reorder("#{Journal.table_name}.id ASC")
719 719 if journal_id.present?
720 720 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
721 721 end
722 722 scope
723 723 end
724 724
725 725 # Returns the initial status of the issue
726 726 # Returns nil for a new issue
727 727 def status_was
728 728 if status_id_changed?
729 729 if status_id_was.to_i > 0
730 730 @status_was ||= IssueStatus.find_by_id(status_id_was)
731 731 end
732 732 else
733 733 @status_was ||= status
734 734 end
735 735 end
736 736
737 737 # Return true if the issue is closed, otherwise false
738 738 def closed?
739 739 status.present? && status.is_closed?
740 740 end
741 741
742 742 # Returns true if the issue was closed when loaded
743 743 def was_closed?
744 744 status_was.present? && status_was.is_closed?
745 745 end
746 746
747 747 # Return true if the issue is being reopened
748 748 def reopening?
749 749 if new_record?
750 750 false
751 751 else
752 752 status_id_changed? && !closed? && was_closed?
753 753 end
754 754 end
755 755 alias :reopened? :reopening?
756 756
757 757 # Return true if the issue is being closed
758 758 def closing?
759 759 if new_record?
760 760 closed?
761 761 else
762 762 status_id_changed? && closed? && !was_closed?
763 763 end
764 764 end
765 765
766 766 # Returns true if the issue is overdue
767 767 def overdue?
768 768 due_date.present? && (due_date < Date.today) && !closed?
769 769 end
770 770
771 771 # Is the amount of work done less than it should for the due date
772 772 def behind_schedule?
773 773 return false if start_date.nil? || due_date.nil?
774 774 done_date = start_date + ((due_date - start_date + 1) * done_ratio / 100).floor
775 775 return done_date <= Date.today
776 776 end
777 777
778 778 # Does this issue have children?
779 779 def children?
780 780 !leaf?
781 781 end
782 782
783 783 # Users the issue can be assigned to
784 784 def assignable_users
785 785 users = project.assignable_users.to_a
786 786 users << author if author && author.active?
787 787 users << assigned_to if assigned_to
788 788 users.uniq.sort
789 789 end
790 790
791 791 # Versions that the issue can be assigned to
792 792 def assignable_versions
793 793 return @assignable_versions if @assignable_versions
794 794
795 795 versions = project.shared_versions.open.to_a
796 796 if fixed_version
797 797 if fixed_version_id_changed?
798 798 # nothing to do
799 799 elsif project_id_changed?
800 800 if project.shared_versions.include?(fixed_version)
801 801 versions << fixed_version
802 802 end
803 803 else
804 804 versions << fixed_version
805 805 end
806 806 end
807 807 @assignable_versions = versions.uniq.sort
808 808 end
809 809
810 810 # Returns true if this issue is blocked by another issue that is still open
811 811 def blocked?
812 812 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
813 813 end
814 814
815 815 # Returns the default status of the issue based on its tracker
816 816 # Returns nil if tracker is nil
817 817 def default_status
818 818 tracker.try(:default_status)
819 819 end
820 820
821 821 # Returns an array of statuses that user is able to apply
822 822 def new_statuses_allowed_to(user=User.current, include_default=false)
823 823 if new_record? && @copied_from
824 824 [default_status, @copied_from.status].compact.uniq.sort
825 825 else
826 826 initial_status = nil
827 827 if new_record?
828 828 initial_status = default_status
829 829 elsif tracker_id_changed?
830 830 if Tracker.where(:id => tracker_id_was, :default_status_id => status_id_was).any?
831 831 initial_status = default_status
832 832 elsif tracker.issue_status_ids.include?(status_id_was)
833 833 initial_status = IssueStatus.find_by_id(status_id_was)
834 834 else
835 835 initial_status = default_status
836 836 end
837 837 else
838 838 initial_status = status_was
839 839 end
840 840
841 841 initial_assigned_to_id = assigned_to_id_changed? ? assigned_to_id_was : assigned_to_id
842 842 assignee_transitions_allowed = initial_assigned_to_id.present? &&
843 843 (user.id == initial_assigned_to_id || user.group_ids.include?(initial_assigned_to_id))
844 844
845 845 statuses = []
846 846 if initial_status
847 847 statuses += initial_status.find_new_statuses_allowed_to(
848 848 user.admin ? Role.all.to_a : user.roles_for_project(project),
849 849 tracker,
850 850 author == user,
851 851 assignee_transitions_allowed
852 852 )
853 853 end
854 854 statuses << initial_status unless statuses.empty?
855 855 statuses << default_status if include_default
856 856 statuses = statuses.compact.uniq.sort
857 857 if blocked?
858 858 statuses.reject!(&:is_closed?)
859 859 end
860 860 statuses
861 861 end
862 862 end
863 863
864 864 # Returns the previous assignee (user or group) if changed
865 865 def assigned_to_was
866 866 # assigned_to_id_was is reset before after_save callbacks
867 867 user_id = @previous_assigned_to_id || assigned_to_id_was
868 868 if user_id && user_id != assigned_to_id
869 869 @assigned_to_was ||= Principal.find_by_id(user_id)
870 870 end
871 871 end
872 872
873 873 # Returns the users that should be notified
874 874 def notified_users
875 875 notified = []
876 876 # Author and assignee are always notified unless they have been
877 877 # locked or don't want to be notified
878 878 notified << author if author
879 879 if assigned_to
880 880 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
881 881 end
882 882 if assigned_to_was
883 883 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
884 884 end
885 885 notified = notified.select {|u| u.active? && u.notify_about?(self)}
886 886
887 887 notified += project.notified_users
888 888 notified.uniq!
889 889 # Remove users that can not view the issue
890 890 notified.reject! {|user| !visible?(user)}
891 891 notified
892 892 end
893 893
894 894 # Returns the email addresses that should be notified
895 895 def recipients
896 896 notified_users.collect(&:mail)
897 897 end
898 898
899 899 def each_notification(users, &block)
900 900 if users.any?
901 901 if custom_field_values.detect {|value| !value.custom_field.visible?}
902 902 users_by_custom_field_visibility = users.group_by do |user|
903 903 visible_custom_field_values(user).map(&:custom_field_id).sort
904 904 end
905 905 users_by_custom_field_visibility.values.each do |users|
906 906 yield(users)
907 907 end
908 908 else
909 909 yield(users)
910 910 end
911 911 end
912 912 end
913 913
914 914 # Returns the number of hours spent on this issue
915 915 def spent_hours
916 916 @spent_hours ||= time_entries.sum(:hours) || 0
917 917 end
918 918
919 919 # Returns the total number of hours spent on this issue and its descendants
920 920 def total_spent_hours
921 921 @total_spent_hours ||= if leaf?
922 922 spent_hours
923 923 else
924 924 self_and_descendants.joins(:time_entries).sum("#{TimeEntry.table_name}.hours").to_f || 0.0
925 925 end
926 926 end
927 927
928 928 def total_estimated_hours
929 929 if leaf?
930 930 estimated_hours
931 931 else
932 932 @total_estimated_hours ||= self_and_descendants.sum(:estimated_hours)
933 933 end
934 934 end
935 935
936 936 def relations
937 937 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
938 938 end
939 939
940 940 # Preloads relations for a collection of issues
941 941 def self.load_relations(issues)
942 942 if issues.any?
943 943 relations = IssueRelation.where("issue_from_id IN (:ids) OR issue_to_id IN (:ids)", :ids => issues.map(&:id)).all
944 944 issues.each do |issue|
945 945 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
946 946 end
947 947 end
948 948 end
949 949
950 950 # Preloads visible spent time for a collection of issues
951 951 def self.load_visible_spent_hours(issues, user=User.current)
952 952 if issues.any?
953 953 hours_by_issue_id = TimeEntry.visible(user).where(:issue_id => issues.map(&:id)).group(:issue_id).sum(:hours)
954 954 issues.each do |issue|
955 955 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
956 956 end
957 957 end
958 958 end
959 959
960 960 # Preloads visible total spent time for a collection of issues
961 961 def self.load_visible_total_spent_hours(issues, user=User.current)
962 962 if issues.any?
963 963 hours_by_issue_id = TimeEntry.visible(user).joins(:issue).
964 964 joins("JOIN #{Issue.table_name} parent ON parent.root_id = #{Issue.table_name}.root_id" +
965 965 " AND parent.lft <= #{Issue.table_name}.lft AND parent.rgt >= #{Issue.table_name}.rgt").
966 966 where("parent.id IN (?)", issues.map(&:id)).group("parent.id").sum(:hours)
967 967 issues.each do |issue|
968 968 issue.instance_variable_set "@total_spent_hours", (hours_by_issue_id[issue.id] || 0)
969 969 end
970 970 end
971 971 end
972 972
973 973 # Preloads visible relations for a collection of issues
974 974 def self.load_visible_relations(issues, user=User.current)
975 975 if issues.any?
976 976 issue_ids = issues.map(&:id)
977 977 # Relations with issue_from in given issues and visible issue_to
978 978 relations_from = IssueRelation.joins(:issue_to => :project).
979 979 where(visible_condition(user)).where(:issue_from_id => issue_ids).to_a
980 980 # Relations with issue_to in given issues and visible issue_from
981 981 relations_to = IssueRelation.joins(:issue_from => :project).
982 982 where(visible_condition(user)).
983 983 where(:issue_to_id => issue_ids).to_a
984 984 issues.each do |issue|
985 985 relations =
986 986 relations_from.select {|relation| relation.issue_from_id == issue.id} +
987 987 relations_to.select {|relation| relation.issue_to_id == issue.id}
988 988
989 989 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
990 990 end
991 991 end
992 992 end
993 993
994 994 # Finds an issue relation given its id.
995 995 def find_relation(relation_id)
996 996 IssueRelation.where("issue_to_id = ? OR issue_from_id = ?", id, id).find(relation_id)
997 997 end
998 998
999 999 # Returns all the other issues that depend on the issue
1000 1000 # The algorithm is a modified breadth first search (bfs)
1001 1001 def all_dependent_issues(except=[])
1002 1002 # The found dependencies
1003 1003 dependencies = []
1004 1004
1005 1005 # The visited flag for every node (issue) used by the breadth first search
1006 1006 eNOT_DISCOVERED = 0 # The issue is "new" to the algorithm, it has not seen it before.
1007 1007
1008 1008 ePROCESS_ALL = 1 # The issue is added to the queue. Process both children and relations of
1009 1009 # the issue when it is processed.
1010 1010
1011 1011 ePROCESS_RELATIONS_ONLY = 2 # The issue was added to the queue and will be output as dependent issue,
1012 1012 # but its children will not be added to the queue when it is processed.
1013 1013
1014 1014 eRELATIONS_PROCESSED = 3 # The related issues, the parent issue and the issue itself have been added to
1015 1015 # the queue, but its children have not been added.
1016 1016
1017 1017 ePROCESS_CHILDREN_ONLY = 4 # The relations and the parent of the issue have been added to the queue, but
1018 1018 # the children still need to be processed.
1019 1019
1020 1020 eALL_PROCESSED = 5 # The issue and all its children, its parent and its related issues have been
1021 1021 # added as dependent issues. It needs no further processing.
1022 1022
1023 1023 issue_status = Hash.new(eNOT_DISCOVERED)
1024 1024
1025 1025 # The queue
1026 1026 queue = []
1027 1027
1028 1028 # Initialize the bfs, add start node (self) to the queue
1029 1029 queue << self
1030 1030 issue_status[self] = ePROCESS_ALL
1031 1031
1032 1032 while (!queue.empty?) do
1033 1033 current_issue = queue.shift
1034 1034 current_issue_status = issue_status[current_issue]
1035 1035 dependencies << current_issue
1036 1036
1037 1037 # Add parent to queue, if not already in it.
1038 1038 parent = current_issue.parent
1039 1039 parent_status = issue_status[parent]
1040 1040
1041 1041 if parent && (parent_status == eNOT_DISCOVERED) && !except.include?(parent)
1042 1042 queue << parent
1043 1043 issue_status[parent] = ePROCESS_RELATIONS_ONLY
1044 1044 end
1045 1045
1046 1046 # Add children to queue, but only if they are not already in it and
1047 1047 # the children of the current node need to be processed.
1048 1048 if (current_issue_status == ePROCESS_CHILDREN_ONLY || current_issue_status == ePROCESS_ALL)
1049 1049 current_issue.children.each do |child|
1050 1050 next if except.include?(child)
1051 1051
1052 1052 if (issue_status[child] == eNOT_DISCOVERED)
1053 1053 queue << child
1054 1054 issue_status[child] = ePROCESS_ALL
1055 1055 elsif (issue_status[child] == eRELATIONS_PROCESSED)
1056 1056 queue << child
1057 1057 issue_status[child] = ePROCESS_CHILDREN_ONLY
1058 1058 elsif (issue_status[child] == ePROCESS_RELATIONS_ONLY)
1059 1059 queue << child
1060 1060 issue_status[child] = ePROCESS_ALL
1061 1061 end
1062 1062 end
1063 1063 end
1064 1064
1065 1065 # Add related issues to the queue, if they are not already in it.
1066 1066 current_issue.relations_from.map(&:issue_to).each do |related_issue|
1067 1067 next if except.include?(related_issue)
1068 1068
1069 1069 if (issue_status[related_issue] == eNOT_DISCOVERED)
1070 1070 queue << related_issue
1071 1071 issue_status[related_issue] = ePROCESS_ALL
1072 1072 elsif (issue_status[related_issue] == eRELATIONS_PROCESSED)
1073 1073 queue << related_issue
1074 1074 issue_status[related_issue] = ePROCESS_CHILDREN_ONLY
1075 1075 elsif (issue_status[related_issue] == ePROCESS_RELATIONS_ONLY)
1076 1076 queue << related_issue
1077 1077 issue_status[related_issue] = ePROCESS_ALL
1078 1078 end
1079 1079 end
1080 1080
1081 1081 # Set new status for current issue
1082 1082 if (current_issue_status == ePROCESS_ALL) || (current_issue_status == ePROCESS_CHILDREN_ONLY)
1083 1083 issue_status[current_issue] = eALL_PROCESSED
1084 1084 elsif (current_issue_status == ePROCESS_RELATIONS_ONLY)
1085 1085 issue_status[current_issue] = eRELATIONS_PROCESSED
1086 1086 end
1087 1087 end # while
1088 1088
1089 1089 # Remove the issues from the "except" parameter from the result array
1090 1090 dependencies -= except
1091 1091 dependencies.delete(self)
1092 1092
1093 1093 dependencies
1094 1094 end
1095 1095
1096 1096 # Returns an array of issues that duplicate this one
1097 1097 def duplicates
1098 1098 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
1099 1099 end
1100 1100
1101 1101 # Returns the due date or the target due date if any
1102 1102 # Used on gantt chart
1103 1103 def due_before
1104 1104 due_date || (fixed_version ? fixed_version.effective_date : nil)
1105 1105 end
1106 1106
1107 1107 # Returns the time scheduled for this issue.
1108 1108 #
1109 1109 # Example:
1110 1110 # Start Date: 2/26/09, End Date: 3/04/09
1111 1111 # duration => 6
1112 1112 def duration
1113 1113 (start_date && due_date) ? due_date - start_date : 0
1114 1114 end
1115 1115
1116 1116 # Returns the duration in working days
1117 1117 def working_duration
1118 1118 (start_date && due_date) ? working_days(start_date, due_date) : 0
1119 1119 end
1120 1120
1121 1121 def soonest_start(reload=false)
1122 1122 if @soonest_start.nil? || reload
1123 1123 dates = relations_to(reload).collect{|relation| relation.successor_soonest_start}
1124 1124 p = @parent_issue || parent
1125 1125 if p && Setting.parent_issue_dates == 'derived'
1126 1126 dates << p.soonest_start
1127 1127 end
1128 1128 @soonest_start = dates.compact.max
1129 1129 end
1130 1130 @soonest_start
1131 1131 end
1132 1132
1133 1133 # Sets start_date on the given date or the next working day
1134 1134 # and changes due_date to keep the same working duration.
1135 1135 def reschedule_on(date)
1136 1136 wd = working_duration
1137 1137 date = next_working_date(date)
1138 1138 self.start_date = date
1139 1139 self.due_date = add_working_days(date, wd)
1140 1140 end
1141 1141
1142 1142 # Reschedules the issue on the given date or the next working day and saves the record.
1143 1143 # If the issue is a parent task, this is done by rescheduling its subtasks.
1144 1144 def reschedule_on!(date)
1145 1145 return if date.nil?
1146 1146 if leaf? || !dates_derived?
1147 1147 if start_date.nil? || start_date != date
1148 1148 if start_date && start_date > date
1149 1149 # Issue can not be moved earlier than its soonest start date
1150 1150 date = [soonest_start(true), date].compact.max
1151 1151 end
1152 1152 reschedule_on(date)
1153 1153 begin
1154 1154 save
1155 1155 rescue ActiveRecord::StaleObjectError
1156 1156 reload
1157 1157 reschedule_on(date)
1158 1158 save
1159 1159 end
1160 1160 end
1161 1161 else
1162 1162 leaves.each do |leaf|
1163 1163 if leaf.start_date
1164 1164 # Only move subtask if it starts at the same date as the parent
1165 1165 # or if it starts before the given date
1166 1166 if start_date == leaf.start_date || date > leaf.start_date
1167 1167 leaf.reschedule_on!(date)
1168 1168 end
1169 1169 else
1170 1170 leaf.reschedule_on!(date)
1171 1171 end
1172 1172 end
1173 1173 end
1174 1174 end
1175 1175
1176 1176 def dates_derived?
1177 1177 !leaf? && Setting.parent_issue_dates == 'derived'
1178 1178 end
1179 1179
1180 1180 def priority_derived?
1181 1181 !leaf? && Setting.parent_issue_priority == 'derived'
1182 1182 end
1183 1183
1184 1184 def done_ratio_derived?
1185 1185 !leaf? && Setting.parent_issue_done_ratio == 'derived'
1186 1186 end
1187 1187
1188 1188 def <=>(issue)
1189 1189 if issue.nil?
1190 1190 -1
1191 1191 elsif root_id != issue.root_id
1192 1192 (root_id || 0) <=> (issue.root_id || 0)
1193 1193 else
1194 1194 (lft || 0) <=> (issue.lft || 0)
1195 1195 end
1196 1196 end
1197 1197
1198 1198 def to_s
1199 1199 "#{tracker} ##{id}: #{subject}"
1200 1200 end
1201 1201
1202 1202 # Returns a string of css classes that apply to the issue
1203 1203 def css_classes(user=User.current)
1204 1204 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
1205 1205 s << ' closed' if closed?
1206 1206 s << ' overdue' if overdue?
1207 1207 s << ' child' if child?
1208 1208 s << ' parent' unless leaf?
1209 1209 s << ' private' if is_private?
1210 1210 if user.logged?
1211 1211 s << ' created-by-me' if author_id == user.id
1212 1212 s << ' assigned-to-me' if assigned_to_id == user.id
1213 1213 s << ' assigned-to-my-group' if user.groups.any? {|g| g.id == assigned_to_id}
1214 1214 end
1215 1215 s
1216 1216 end
1217 1217
1218 1218 # Unassigns issues from +version+ if it's no longer shared with issue's project
1219 1219 def self.update_versions_from_sharing_change(version)
1220 1220 # Update issues assigned to the version
1221 1221 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
1222 1222 end
1223 1223
1224 1224 # Unassigns issues from versions that are no longer shared
1225 1225 # after +project+ was moved
1226 1226 def self.update_versions_from_hierarchy_change(project)
1227 1227 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1228 1228 # Update issues of the moved projects and issues assigned to a version of a moved project
1229 1229 Issue.update_versions(
1230 1230 ["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)",
1231 1231 moved_project_ids, moved_project_ids]
1232 1232 )
1233 1233 end
1234 1234
1235 1235 def parent_issue_id=(arg)
1236 1236 s = arg.to_s.strip.presence
1237 1237 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1238 1238 @invalid_parent_issue_id = nil
1239 1239 elsif s.blank?
1240 1240 @parent_issue = nil
1241 1241 @invalid_parent_issue_id = nil
1242 1242 else
1243 1243 @parent_issue = nil
1244 1244 @invalid_parent_issue_id = arg
1245 1245 end
1246 1246 end
1247 1247
1248 1248 def parent_issue_id
1249 1249 if @invalid_parent_issue_id
1250 1250 @invalid_parent_issue_id
1251 1251 elsif instance_variable_defined? :@parent_issue
1252 1252 @parent_issue.nil? ? nil : @parent_issue.id
1253 1253 else
1254 1254 parent_id
1255 1255 end
1256 1256 end
1257 1257
1258 1258 def set_parent_id
1259 1259 self.parent_id = parent_issue_id
1260 1260 end
1261 1261
1262 1262 # Returns true if issue's project is a valid
1263 1263 # parent issue project
1264 1264 def valid_parent_project?(issue=parent)
1265 1265 return true if issue.nil? || issue.project_id == project_id
1266 1266
1267 1267 case Setting.cross_project_subtasks
1268 1268 when 'system'
1269 1269 true
1270 1270 when 'tree'
1271 1271 issue.project.root == project.root
1272 1272 when 'hierarchy'
1273 1273 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1274 1274 when 'descendants'
1275 1275 issue.project.is_or_is_ancestor_of?(project)
1276 1276 else
1277 1277 false
1278 1278 end
1279 1279 end
1280 1280
1281 1281 # Returns an issue scope based on project and scope
1282 1282 def self.cross_project_scope(project, scope=nil)
1283 1283 if project.nil?
1284 1284 return Issue
1285 1285 end
1286 1286 case scope
1287 1287 when 'all', 'system'
1288 1288 Issue
1289 1289 when 'tree'
1290 1290 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
1291 1291 :lft => project.root.lft, :rgt => project.root.rgt)
1292 1292 when 'hierarchy'
1293 1293 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt) OR (#{Project.table_name}.lft < :lft AND #{Project.table_name}.rgt > :rgt)",
1294 1294 :lft => project.lft, :rgt => project.rgt)
1295 1295 when 'descendants'
1296 1296 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
1297 1297 :lft => project.lft, :rgt => project.rgt)
1298 1298 else
1299 1299 Issue.where(:project_id => project.id)
1300 1300 end
1301 1301 end
1302 1302
1303 1303 def self.by_tracker(project)
1304 1304 count_and_group_by(:project => project, :association => :tracker)
1305 1305 end
1306 1306
1307 1307 def self.by_version(project)
1308 1308 count_and_group_by(:project => project, :association => :fixed_version)
1309 1309 end
1310 1310
1311 1311 def self.by_priority(project)
1312 1312 count_and_group_by(:project => project, :association => :priority)
1313 1313 end
1314 1314
1315 1315 def self.by_category(project)
1316 1316 count_and_group_by(:project => project, :association => :category)
1317 1317 end
1318 1318
1319 1319 def self.by_assigned_to(project)
1320 1320 count_and_group_by(:project => project, :association => :assigned_to)
1321 1321 end
1322 1322
1323 1323 def self.by_author(project)
1324 1324 count_and_group_by(:project => project, :association => :author)
1325 1325 end
1326 1326
1327 1327 def self.by_subproject(project)
1328 1328 r = count_and_group_by(:project => project, :with_subprojects => true, :association => :project)
1329 1329 r.reject {|r| r["project_id"] == project.id.to_s}
1330 1330 end
1331 1331
1332 1332 # Query generator for selecting groups of issue counts for a project
1333 1333 # based on specific criteria
1334 1334 #
1335 1335 # Options
1336 1336 # * project - Project to search in.
1337 1337 # * with_subprojects - Includes subprojects issues if set to true.
1338 1338 # * association - Symbol. Association for grouping.
1339 1339 def self.count_and_group_by(options)
1340 1340 assoc = reflect_on_association(options[:association])
1341 1341 select_field = assoc.foreign_key
1342 1342
1343 1343 Issue.
1344 1344 visible(User.current, :project => options[:project], :with_subprojects => options[:with_subprojects]).
1345 1345 joins(:status, assoc.name).
1346 1346 group(:status_id, :is_closed, select_field).
1347 1347 count.
1348 1348 map do |columns, total|
1349 1349 status_id, is_closed, field_value = columns
1350 1350 is_closed = ['t', 'true', '1'].include?(is_closed.to_s)
1351 1351 {
1352 1352 "status_id" => status_id.to_s,
1353 1353 "closed" => is_closed,
1354 1354 select_field => field_value.to_s,
1355 1355 "total" => total.to_s
1356 1356 }
1357 1357 end
1358 1358 end
1359 1359
1360 1360 # Returns a scope of projects that user can assign the issue to
1361 1361 def allowed_target_projects(user=User.current)
1362 1362 current_project = new_record? ? nil : project
1363 1363 self.class.allowed_target_projects(user, current_project)
1364 1364 end
1365 1365
1366 1366 # Returns a scope of projects that user can assign issues to
1367 1367 # If current_project is given, it will be included in the scope
1368 1368 def self.allowed_target_projects(user=User.current, current_project=nil)
1369 1369 condition = Project.allowed_to_condition(user, :add_issues)
1370 1370 if current_project
1371 1371 condition = ["(#{condition}) OR #{Project.table_name}.id = ?", current_project.id]
1372 1372 end
1373 1373 Project.where(condition)
1374 1374 end
1375 1375
1376 1376 private
1377 1377
1378 1378 def after_project_change
1379 1379 # Update project_id on related time entries
1380 1380 TimeEntry.where({:issue_id => id}).update_all(["project_id = ?", project_id])
1381 1381
1382 1382 # Delete issue relations
1383 1383 unless Setting.cross_project_issue_relations?
1384 1384 relations_from.clear
1385 1385 relations_to.clear
1386 1386 end
1387 1387
1388 1388 # Move subtasks that were in the same project
1389 1389 children.each do |child|
1390 1390 next unless child.project_id == project_id_was
1391 1391 # Change project and keep project
1392 1392 child.send :project=, project, true
1393 1393 unless child.save
1394 1394 raise ActiveRecord::Rollback
1395 1395 end
1396 1396 end
1397 1397 end
1398 1398
1399 1399 # Callback for after the creation of an issue by copy
1400 1400 # * adds a "copied to" relation with the copied issue
1401 1401 # * copies subtasks from the copied issue
1402 1402 def after_create_from_copy
1403 1403 return unless copy? && !@after_create_from_copy_handled
1404 1404
1405 1405 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1406 1406 if @current_journal
1407 1407 @copied_from.init_journal(@current_journal.user)
1408 1408 end
1409 1409 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1410 1410 unless relation.save
1411 1411 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1412 1412 end
1413 1413 end
1414 1414
1415 1415 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1416 1416 copy_options = (@copy_options || {}).merge(:subtasks => false)
1417 1417 copied_issue_ids = {@copied_from.id => self.id}
1418 1418 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1419 1419 # Do not copy self when copying an issue as a descendant of the copied issue
1420 1420 next if child == self
1421 1421 # Do not copy subtasks of issues that were not copied
1422 1422 next unless copied_issue_ids[child.parent_id]
1423 1423 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1424 1424 unless child.visible?
1425 1425 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1426 1426 next
1427 1427 end
1428 1428 copy = Issue.new.copy_from(child, copy_options)
1429 1429 if @current_journal
1430 1430 copy.init_journal(@current_journal.user)
1431 1431 end
1432 1432 copy.author = author
1433 1433 copy.project = project
1434 1434 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1435 1435 unless copy.save
1436 1436 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1437 1437 next
1438 1438 end
1439 1439 copied_issue_ids[child.id] = copy.id
1440 1440 end
1441 1441 end
1442 1442 @after_create_from_copy_handled = true
1443 1443 end
1444 1444
1445 1445 def update_nested_set_attributes
1446 1446 if parent_id_changed?
1447 1447 update_nested_set_attributes_on_parent_change
1448 1448 end
1449 1449 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1450 1450 end
1451 1451
1452 1452 # Updates the nested set for when an existing issue is moved
1453 1453 def update_nested_set_attributes_on_parent_change
1454 1454 former_parent_id = parent_id_was
1455 1455 # delete invalid relations of all descendants
1456 1456 self_and_descendants.each do |issue|
1457 1457 issue.relations.each do |relation|
1458 1458 relation.destroy unless relation.valid?
1459 1459 end
1460 1460 end
1461 1461 # update former parent
1462 1462 recalculate_attributes_for(former_parent_id) if former_parent_id
1463 1463 end
1464 1464
1465 1465 def update_parent_attributes
1466 1466 if parent_id
1467 1467 recalculate_attributes_for(parent_id)
1468 1468 association(:parent).reset
1469 1469 end
1470 1470 end
1471 1471
1472 1472 def recalculate_attributes_for(issue_id)
1473 1473 if issue_id && p = Issue.find_by_id(issue_id)
1474 1474 if p.priority_derived?
1475 1475 # priority = highest priority of children
1476 1476 if priority_position = p.children.joins(:priority).maximum("#{IssuePriority.table_name}.position")
1477 1477 p.priority = IssuePriority.find_by_position(priority_position)
1478 1478 end
1479 1479 end
1480 1480
1481 1481 if p.dates_derived?
1482 1482 # start/due dates = lowest/highest dates of children
1483 1483 p.start_date = p.children.minimum(:start_date)
1484 1484 p.due_date = p.children.maximum(:due_date)
1485 1485 if p.start_date && p.due_date && p.due_date < p.start_date
1486 1486 p.start_date, p.due_date = p.due_date, p.start_date
1487 1487 end
1488 1488 end
1489 1489
1490 1490 if p.done_ratio_derived?
1491 1491 # done ratio = weighted average ratio of leaves
1492 1492 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1493 1493 leaves_count = p.leaves.count
1494 1494 if leaves_count > 0
1495 1495 average = p.leaves.where("estimated_hours > 0").average(:estimated_hours).to_f
1496 1496 if average == 0
1497 1497 average = 1
1498 1498 end
1499 1499 done = p.leaves.joins(:status).
1500 1500 sum("COALESCE(CASE WHEN estimated_hours > 0 THEN estimated_hours ELSE NULL END, #{average}) " +
1501 1501 "* (CASE WHEN is_closed = #{self.class.connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)").to_f
1502 1502 progress = done / (average * leaves_count)
1503 1503 p.done_ratio = progress.round
1504 1504 end
1505 1505 end
1506 1506 end
1507 1507
1508 1508 # ancestors will be recursively updated
1509 1509 p.save(:validate => false)
1510 1510 end
1511 1511 end
1512 1512
1513 1513 # Update issues so their versions are not pointing to a
1514 1514 # fixed_version that is not shared with the issue's project
1515 1515 def self.update_versions(conditions=nil)
1516 1516 # Only need to update issues with a fixed_version from
1517 1517 # a different project and that is not systemwide shared
1518 1518 Issue.joins(:project, :fixed_version).
1519 1519 where("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1520 1520 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1521 1521 " AND #{Version.table_name}.sharing <> 'system'").
1522 1522 where(conditions).each do |issue|
1523 1523 next if issue.project.nil? || issue.fixed_version.nil?
1524 1524 unless issue.project.shared_versions.include?(issue.fixed_version)
1525 1525 issue.init_journal(User.current)
1526 1526 issue.fixed_version = nil
1527 1527 issue.save
1528 1528 end
1529 1529 end
1530 1530 end
1531 1531
1532 1532 # Callback on file attachment
1533 1533 def attachment_added(attachment)
1534 1534 if current_journal && !attachment.new_record?
1535 1535 current_journal.journalize_attachment(attachment, :added)
1536 1536 end
1537 1537 end
1538 1538
1539 1539 # Callback on attachment deletion
1540 1540 def attachment_removed(attachment)
1541 1541 if current_journal && !attachment.new_record?
1542 1542 current_journal.journalize_attachment(attachment, :removed)
1543 1543 current_journal.save
1544 1544 end
1545 1545 end
1546 1546
1547 1547 # Called after a relation is added
1548 1548 def relation_added(relation)
1549 1549 if current_journal
1550 1550 current_journal.journalize_relation(relation, :added)
1551 1551 current_journal.save
1552 1552 end
1553 1553 end
1554 1554
1555 1555 # Called after a relation is removed
1556 1556 def relation_removed(relation)
1557 1557 if current_journal
1558 1558 current_journal.journalize_relation(relation, :removed)
1559 1559 current_journal.save
1560 1560 end
1561 1561 end
1562 1562
1563 1563 # Default assignment based on category
1564 1564 def default_assign
1565 1565 if assigned_to.nil? && category && category.assigned_to
1566 1566 self.assigned_to = category.assigned_to
1567 1567 end
1568 1568 end
1569 1569
1570 1570 # Updates start/due dates of following issues
1571 1571 def reschedule_following_issues
1572 1572 if start_date_changed? || due_date_changed?
1573 1573 relations_from.each do |relation|
1574 1574 relation.set_issue_to_dates
1575 1575 end
1576 1576 end
1577 1577 end
1578 1578
1579 1579 # Closes duplicates if the issue is being closed
1580 1580 def close_duplicates
1581 1581 if closing?
1582 1582 duplicates.each do |duplicate|
1583 1583 # Reload is needed in case the duplicate was updated by a previous duplicate
1584 1584 duplicate.reload
1585 1585 # Don't re-close it if it's already closed
1586 1586 next if duplicate.closed?
1587 1587 # Same user and notes
1588 1588 if @current_journal
1589 1589 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1590 duplicate.private_notes = @current_journal.private_notes
1590 1591 end
1591 1592 duplicate.update_attribute :status, self.status
1592 1593 end
1593 1594 end
1594 1595 end
1595 1596
1596 1597 # Make sure updated_on is updated when adding a note and set updated_on now
1597 1598 # so we can set closed_on with the same value on closing
1598 1599 def force_updated_on_change
1599 1600 if @current_journal || changed?
1600 1601 self.updated_on = current_time_from_proper_timezone
1601 1602 if new_record?
1602 1603 self.created_on = updated_on
1603 1604 end
1604 1605 end
1605 1606 end
1606 1607
1607 1608 # Callback for setting closed_on when the issue is closed.
1608 1609 # The closed_on attribute stores the time of the last closing
1609 1610 # and is preserved when the issue is reopened.
1610 1611 def update_closed_on
1611 1612 if closing?
1612 1613 self.closed_on = updated_on
1613 1614 end
1614 1615 end
1615 1616
1616 1617 # Saves the changes in a Journal
1617 1618 # Called after_save
1618 1619 def create_journal
1619 1620 if current_journal
1620 1621 current_journal.save
1621 1622 end
1622 1623 end
1623 1624
1624 1625 def send_notification
1625 1626 if Setting.notified_events.include?('issue_added')
1626 1627 Mailer.deliver_issue_add(self)
1627 1628 end
1628 1629 end
1629 1630
1630 1631 # Stores the previous assignee so we can still have access
1631 1632 # to it during after_save callbacks (assigned_to_id_was is reset)
1632 1633 def set_assigned_to_was
1633 1634 @previous_assigned_to_id = assigned_to_id_was
1634 1635 end
1635 1636
1636 1637 # Clears the previous assignee at the end of after_save callbacks
1637 1638 def clear_assigned_to_was
1638 1639 @assigned_to_was = nil
1639 1640 @previous_assigned_to_id = nil
1640 1641 end
1641 1642
1642 1643 def clear_disabled_fields
1643 1644 if tracker
1644 1645 tracker.disabled_core_fields.each do |attribute|
1645 1646 send "#{attribute}=", nil
1646 1647 end
1647 1648 self.done_ratio ||= 0
1648 1649 end
1649 1650 end
1650 1651 end
@@ -1,2727 +1,2745
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :email_addresses, :members, :member_roles, :roles,
22 22 :groups_users,
23 23 :trackers, :projects_trackers,
24 24 :enabled_modules,
25 25 :versions,
26 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 27 :enumerations,
28 28 :issues, :journals, :journal_details,
29 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 30 :time_entries
31 31
32 32 include Redmine::I18n
33 33
34 34 def setup
35 35 set_language_if_valid 'en'
36 36 end
37 37
38 38 def teardown
39 39 User.current = nil
40 40 end
41 41
42 42 def test_initialize
43 43 issue = Issue.new
44 44
45 45 assert_nil issue.project_id
46 46 assert_nil issue.tracker_id
47 47 assert_nil issue.status_id
48 48 assert_nil issue.author_id
49 49 assert_nil issue.assigned_to_id
50 50 assert_nil issue.category_id
51 51
52 52 assert_equal IssuePriority.default, issue.priority
53 53 end
54 54
55 55 def test_create
56 56 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
57 57 :status_id => 1, :priority => IssuePriority.all.first,
58 58 :subject => 'test_create',
59 59 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
60 60 assert issue.save
61 61 issue.reload
62 62 assert_equal 1.5, issue.estimated_hours
63 63 end
64 64
65 65 def test_create_minimal
66 66 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
67 67 assert issue.save
68 68 assert_equal issue.tracker.default_status, issue.status
69 69 assert issue.description.nil?
70 70 assert_nil issue.estimated_hours
71 71 end
72 72
73 73 def test_create_with_all_fields_disabled
74 74 tracker = Tracker.find(1)
75 75 tracker.core_fields = []
76 76 tracker.save!
77 77
78 78 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create_with_all_fields_disabled')
79 79 assert_save issue
80 80 end
81 81
82 82 def test_start_date_format_should_be_validated
83 83 set_language_if_valid 'en'
84 84 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
85 85 issue = Issue.new(:start_date => invalid_date)
86 86 assert !issue.valid?
87 87 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
88 88 end
89 89 end
90 90
91 91 def test_due_date_format_should_be_validated
92 92 set_language_if_valid 'en'
93 93 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
94 94 issue = Issue.new(:due_date => invalid_date)
95 95 assert !issue.valid?
96 96 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
97 97 end
98 98 end
99 99
100 100 def test_due_date_lesser_than_start_date_should_not_validate
101 101 set_language_if_valid 'en'
102 102 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
103 103 assert !issue.valid?
104 104 assert_include 'Due date must be greater than start date', issue.errors.full_messages
105 105 end
106 106
107 107 def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
108 108 issue = Issue.generate(:start_date => '2013-06-04')
109 109 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
110 110 assert !issue.valid?
111 111 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
112 112 end
113 113
114 114 def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
115 115 issue = Issue.generate!(:start_date => '2013-06-04')
116 116 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
117 117 issue.start_date = '2013-06-07'
118 118 assert !issue.valid?
119 119 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
120 120 end
121 121
122 122 def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
123 123 issue = Issue.generate!(:start_date => '2013-06-04')
124 124 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
125 125 assert issue.valid?
126 126 end
127 127
128 128 def test_estimated_hours_should_be_validated
129 129 set_language_if_valid 'en'
130 130 ['-2'].each do |invalid|
131 131 issue = Issue.new(:estimated_hours => invalid)
132 132 assert !issue.valid?
133 133 assert_include 'Estimated time is invalid', issue.errors.full_messages
134 134 end
135 135 end
136 136
137 137 def test_create_with_required_custom_field
138 138 set_language_if_valid 'en'
139 139 field = IssueCustomField.find_by_name('Database')
140 140 field.update_attribute(:is_required, true)
141 141
142 142 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
143 143 :status_id => 1, :subject => 'test_create',
144 144 :description => 'IssueTest#test_create_with_required_custom_field')
145 145 assert issue.available_custom_fields.include?(field)
146 146 # No value for the custom field
147 147 assert !issue.save
148 148 assert_equal ["Database cannot be blank"], issue.errors.full_messages
149 149 # Blank value
150 150 issue.custom_field_values = { field.id => '' }
151 151 assert !issue.save
152 152 assert_equal ["Database cannot be blank"], issue.errors.full_messages
153 153 # Invalid value
154 154 issue.custom_field_values = { field.id => 'SQLServer' }
155 155 assert !issue.save
156 156 assert_equal ["Database is not included in the list"], issue.errors.full_messages
157 157 # Valid value
158 158 issue.custom_field_values = { field.id => 'PostgreSQL' }
159 159 assert issue.save
160 160 issue.reload
161 161 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
162 162 end
163 163
164 164 def test_create_with_group_assignment
165 165 with_settings :issue_group_assignment => '1' do
166 166 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
167 167 :subject => 'Group assignment',
168 168 :assigned_to_id => 11).save
169 169 issue = Issue.order('id DESC').first
170 170 assert_kind_of Group, issue.assigned_to
171 171 assert_equal Group.find(11), issue.assigned_to
172 172 end
173 173 end
174 174
175 175 def test_create_with_parent_issue_id
176 176 issue = Issue.new(:project_id => 1, :tracker_id => 1,
177 177 :author_id => 1, :subject => 'Group assignment',
178 178 :parent_issue_id => 1)
179 179 assert_save issue
180 180 assert_equal 1, issue.parent_issue_id
181 181 assert_equal Issue.find(1), issue.parent
182 182 end
183 183
184 184 def test_create_with_sharp_parent_issue_id
185 185 issue = Issue.new(:project_id => 1, :tracker_id => 1,
186 186 :author_id => 1, :subject => 'Group assignment',
187 187 :parent_issue_id => "#1")
188 188 assert_save issue
189 189 assert_equal 1, issue.parent_issue_id
190 190 assert_equal Issue.find(1), issue.parent
191 191 end
192 192
193 193 def test_create_with_invalid_parent_issue_id
194 194 set_language_if_valid 'en'
195 195 issue = Issue.new(:project_id => 1, :tracker_id => 1,
196 196 :author_id => 1, :subject => 'Group assignment',
197 197 :parent_issue_id => '01ABC')
198 198 assert !issue.save
199 199 assert_equal '01ABC', issue.parent_issue_id
200 200 assert_include 'Parent task is invalid', issue.errors.full_messages
201 201 end
202 202
203 203 def test_create_with_invalid_sharp_parent_issue_id
204 204 set_language_if_valid 'en'
205 205 issue = Issue.new(:project_id => 1, :tracker_id => 1,
206 206 :author_id => 1, :subject => 'Group assignment',
207 207 :parent_issue_id => '#01ABC')
208 208 assert !issue.save
209 209 assert_equal '#01ABC', issue.parent_issue_id
210 210 assert_include 'Parent task is invalid', issue.errors.full_messages
211 211 end
212 212
213 213 def assert_visibility_match(user, issues)
214 214 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
215 215 end
216 216
217 217 def test_visible_scope_for_anonymous
218 218 # Anonymous user should see issues of public projects only
219 219 issues = Issue.visible(User.anonymous).to_a
220 220 assert issues.any?
221 221 assert_nil issues.detect {|issue| !issue.project.is_public?}
222 222 assert_nil issues.detect {|issue| issue.is_private?}
223 223 assert_visibility_match User.anonymous, issues
224 224 end
225 225
226 226 def test_visible_scope_for_anonymous_without_view_issues_permissions
227 227 # Anonymous user should not see issues without permission
228 228 Role.anonymous.remove_permission!(:view_issues)
229 229 issues = Issue.visible(User.anonymous).to_a
230 230 assert issues.empty?
231 231 assert_visibility_match User.anonymous, issues
232 232 end
233 233
234 234 def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
235 235 Role.anonymous.remove_permission!(:view_issues)
236 236 Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])
237 237
238 238 issues = Issue.visible(User.anonymous).all
239 239 assert issues.any?
240 240 assert_equal [1], issues.map(&:project_id).uniq.sort
241 241 assert_visibility_match User.anonymous, issues
242 242 end
243 243
244 244 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
245 245 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
246 246 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
247 247 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
248 248 assert !issue.visible?(User.anonymous)
249 249 end
250 250
251 251 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
252 252 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
253 253 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
254 254 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
255 255 assert !issue.visible?(User.anonymous)
256 256 end
257 257
258 258 def test_visible_scope_for_non_member
259 259 user = User.find(9)
260 260 assert user.projects.empty?
261 261 # Non member user should see issues of public projects only
262 262 issues = Issue.visible(user).to_a
263 263 assert issues.any?
264 264 assert_nil issues.detect {|issue| !issue.project.is_public?}
265 265 assert_nil issues.detect {|issue| issue.is_private?}
266 266 assert_visibility_match user, issues
267 267 end
268 268
269 269 def test_visible_scope_for_non_member_with_own_issues_visibility
270 270 Role.non_member.update_attribute :issues_visibility, 'own'
271 271 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
272 272 user = User.find(9)
273 273
274 274 issues = Issue.visible(user).to_a
275 275 assert issues.any?
276 276 assert_nil issues.detect {|issue| issue.author != user}
277 277 assert_visibility_match user, issues
278 278 end
279 279
280 280 def test_visible_scope_for_non_member_without_view_issues_permissions
281 281 # Non member user should not see issues without permission
282 282 Role.non_member.remove_permission!(:view_issues)
283 283 user = User.find(9)
284 284 assert user.projects.empty?
285 285 issues = Issue.visible(user).to_a
286 286 assert issues.empty?
287 287 assert_visibility_match user, issues
288 288 end
289 289
290 290 def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
291 291 Role.non_member.remove_permission!(:view_issues)
292 292 Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
293 293 user = User.find(9)
294 294
295 295 issues = Issue.visible(user).all
296 296 assert issues.any?
297 297 assert_equal [1], issues.map(&:project_id).uniq.sort
298 298 assert_visibility_match user, issues
299 299 end
300 300
301 301 def test_visible_scope_for_member
302 302 user = User.find(9)
303 303 # User should see issues of projects for which user has view_issues permissions only
304 304 Role.non_member.remove_permission!(:view_issues)
305 305 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
306 306 issues = Issue.visible(user).to_a
307 307 assert issues.any?
308 308 assert_nil issues.detect {|issue| issue.project_id != 3}
309 309 assert_nil issues.detect {|issue| issue.is_private?}
310 310 assert_visibility_match user, issues
311 311 end
312 312
313 313 def test_visible_scope_for_member_without_view_issues_permission_and_non_member_role_having_the_permission
314 314 Role.non_member.add_permission!(:view_issues)
315 315 Role.find(1).remove_permission!(:view_issues)
316 316 user = User.find(2)
317 317
318 318 assert_equal 0, Issue.where(:project_id => 1).visible(user).count
319 319 assert_equal false, Issue.where(:project_id => 1).first.visible?(user)
320 320 end
321 321
322 322 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
323 323 user = User.find(8)
324 324 assert user.groups.any?
325 325 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
326 326 Role.non_member.remove_permission!(:view_issues)
327 327
328 328 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
329 329 :status_id => 1, :priority => IssuePriority.all.first,
330 330 :subject => 'Assignment test',
331 331 :assigned_to => user.groups.first,
332 332 :is_private => true)
333 333
334 334 Role.find(2).update_attribute :issues_visibility, 'default'
335 335 issues = Issue.visible(User.find(8)).to_a
336 336 assert issues.any?
337 337 assert issues.include?(issue)
338 338
339 339 Role.find(2).update_attribute :issues_visibility, 'own'
340 340 issues = Issue.visible(User.find(8)).to_a
341 341 assert issues.any?
342 342 assert_include issue, issues
343 343 end
344 344
345 345 def test_visible_scope_for_admin
346 346 user = User.find(1)
347 347 user.members.each(&:destroy)
348 348 assert user.projects.empty?
349 349 issues = Issue.visible(user).to_a
350 350 assert issues.any?
351 351 # Admin should see issues on private projects that admin does not belong to
352 352 assert issues.detect {|issue| !issue.project.is_public?}
353 353 # Admin should see private issues of other users
354 354 assert issues.detect {|issue| issue.is_private? && issue.author != user}
355 355 assert_visibility_match user, issues
356 356 end
357 357
358 358 def test_visible_scope_with_project
359 359 project = Project.find(1)
360 360 issues = Issue.visible(User.find(2), :project => project).to_a
361 361 projects = issues.collect(&:project).uniq
362 362 assert_equal 1, projects.size
363 363 assert_equal project, projects.first
364 364 end
365 365
366 366 def test_visible_scope_with_project_and_subprojects
367 367 project = Project.find(1)
368 368 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
369 369 projects = issues.collect(&:project).uniq
370 370 assert projects.size > 1
371 371 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
372 372 end
373 373
374 374 def test_visible_and_nested_set_scopes
375 375 user = User.generate!
376 376 parent = Issue.generate!(:assigned_to => user)
377 377 assert parent.visible?(user)
378 378 child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
379 379 child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
380 380 parent.reload
381 381 child1.reload
382 382 child2.reload
383 383 assert child1.visible?(user)
384 384 assert child2.visible?(user)
385 385 assert_equal 2, parent.descendants.count
386 386 assert_equal 2, parent.descendants.visible(user).count
387 387 # awesome_nested_set 2-1-stable branch has regression.
388 388 # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
389 389 # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
390 390 assert_equal 2, parent.descendants.collect{|i| i}.size
391 391 assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
392 392 end
393 393
394 394 def test_visible_scope_with_unsaved_user_should_not_raise_an_error
395 395 user = User.new
396 396 assert_nothing_raised do
397 397 Issue.visible(user).to_a
398 398 end
399 399 end
400 400
401 401 def test_open_scope
402 402 issues = Issue.open.to_a
403 403 assert_nil issues.detect(&:closed?)
404 404 end
405 405
406 406 def test_open_scope_with_arg
407 407 issues = Issue.open(false).to_a
408 408 assert_equal issues, issues.select(&:closed?)
409 409 end
410 410
411 411 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
412 412 version = Version.find(2)
413 413 assert version.fixed_issues.any?
414 414 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
415 415 end
416 416
417 417 def test_fixed_version_scope_with_empty_array_should_return_no_result
418 418 assert_equal 0, Issue.fixed_version([]).count
419 419 end
420 420
421 421 def test_errors_full_messages_should_include_custom_fields_errors
422 422 field = IssueCustomField.find_by_name('Database')
423 423
424 424 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
425 425 :status_id => 1, :subject => 'test_create',
426 426 :description => 'IssueTest#test_create_with_required_custom_field')
427 427 assert issue.available_custom_fields.include?(field)
428 428 # Invalid value
429 429 issue.custom_field_values = { field.id => 'SQLServer' }
430 430
431 431 assert !issue.valid?
432 432 assert_equal 1, issue.errors.full_messages.size
433 433 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
434 434 issue.errors.full_messages.first
435 435 end
436 436
437 437 def test_update_issue_with_required_custom_field
438 438 field = IssueCustomField.find_by_name('Database')
439 439 field.update_attribute(:is_required, true)
440 440
441 441 issue = Issue.find(1)
442 442 assert_nil issue.custom_value_for(field)
443 443 assert issue.available_custom_fields.include?(field)
444 444 # No change to custom values, issue can be saved
445 445 assert issue.save
446 446 # Blank value
447 447 issue.custom_field_values = { field.id => '' }
448 448 assert !issue.save
449 449 # Valid value
450 450 issue.custom_field_values = { field.id => 'PostgreSQL' }
451 451 assert issue.save
452 452 issue.reload
453 453 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
454 454 end
455 455
456 456 def test_should_not_update_attributes_if_custom_fields_validation_fails
457 457 issue = Issue.find(1)
458 458 field = IssueCustomField.find_by_name('Database')
459 459 assert issue.available_custom_fields.include?(field)
460 460
461 461 issue.custom_field_values = { field.id => 'Invalid' }
462 462 issue.subject = 'Should be not be saved'
463 463 assert !issue.save
464 464
465 465 issue.reload
466 466 assert_equal "Cannot print recipes", issue.subject
467 467 end
468 468
469 469 def test_should_not_recreate_custom_values_objects_on_update
470 470 field = IssueCustomField.find_by_name('Database')
471 471
472 472 issue = Issue.find(1)
473 473 issue.custom_field_values = { field.id => 'PostgreSQL' }
474 474 assert issue.save
475 475 custom_value = issue.custom_value_for(field)
476 476 issue.reload
477 477 issue.custom_field_values = { field.id => 'MySQL' }
478 478 assert issue.save
479 479 issue.reload
480 480 assert_equal custom_value.id, issue.custom_value_for(field).id
481 481 end
482 482
483 483 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
484 484 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
485 485 :status_id => 1, :subject => 'Test',
486 486 :custom_field_values => {'2' => 'Test'})
487 487 assert !Tracker.find(2).custom_field_ids.include?(2)
488 488
489 489 issue = Issue.find(issue.id)
490 490 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
491 491
492 492 issue = Issue.find(issue.id)
493 493 custom_value = issue.custom_value_for(2)
494 494 assert_not_nil custom_value
495 495 assert_equal 'Test', custom_value.value
496 496 end
497 497
498 498 def test_assigning_tracker_id_should_reload_custom_fields_values
499 499 issue = Issue.new(:project => Project.find(1))
500 500 assert issue.custom_field_values.empty?
501 501 issue.tracker_id = 1
502 502 assert issue.custom_field_values.any?
503 503 end
504 504
505 505 def test_assigning_attributes_should_assign_project_and_tracker_first
506 506 seq = sequence('seq')
507 507 issue = Issue.new
508 508 issue.expects(:project_id=).in_sequence(seq)
509 509 issue.expects(:tracker_id=).in_sequence(seq)
510 510 issue.expects(:subject=).in_sequence(seq)
511 511 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
512 512 end
513 513
514 514 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
515 515 attributes = ActiveSupport::OrderedHash.new
516 516 attributes['custom_field_values'] = { '1' => 'MySQL' }
517 517 attributes['tracker_id'] = '1'
518 518 issue = Issue.new(:project => Project.find(1))
519 519 issue.attributes = attributes
520 520 assert_equal 'MySQL', issue.custom_field_value(1)
521 521 end
522 522
523 523 def test_changing_tracker_should_clear_disabled_core_fields
524 524 tracker = Tracker.find(2)
525 525 tracker.core_fields = tracker.core_fields - %w(due_date)
526 526 tracker.save!
527 527
528 528 issue = Issue.generate!(:tracker_id => 1, :start_date => Date.today, :due_date => Date.today)
529 529 issue.save!
530 530
531 531 issue.tracker_id = 2
532 532 issue.save!
533 533 assert_not_nil issue.start_date
534 534 assert_nil issue.due_date
535 535 end
536 536
537 537 def test_changing_tracker_should_not_add_cleared_fields_to_journal
538 538 tracker = Tracker.find(2)
539 539 tracker.core_fields = tracker.core_fields - %w(due_date)
540 540 tracker.save!
541 541
542 542 issue = Issue.generate!(:tracker_id => 1, :due_date => Date.today)
543 543 issue.save!
544 544
545 545 assert_difference 'Journal.count' do
546 546 issue.init_journal User.find(1)
547 547 issue.tracker_id = 2
548 548 issue.save!
549 549 assert_nil issue.due_date
550 550 end
551 551 journal = Journal.order('id DESC').first
552 552 assert_equal 1, journal.details.count
553 553 end
554 554
555 555 def test_reload_should_reload_custom_field_values
556 556 issue = Issue.generate!
557 557 issue.custom_field_values = {'2' => 'Foo'}
558 558 issue.save!
559 559
560 560 issue = Issue.order('id desc').first
561 561 assert_equal 'Foo', issue.custom_field_value(2)
562 562
563 563 issue.custom_field_values = {'2' => 'Bar'}
564 564 assert_equal 'Bar', issue.custom_field_value(2)
565 565
566 566 issue.reload
567 567 assert_equal 'Foo', issue.custom_field_value(2)
568 568 end
569 569
570 570 def test_should_update_issue_with_disabled_tracker
571 571 p = Project.find(1)
572 572 issue = Issue.find(1)
573 573
574 574 p.trackers.delete(issue.tracker)
575 575 assert !p.trackers.include?(issue.tracker)
576 576
577 577 issue.reload
578 578 issue.subject = 'New subject'
579 579 assert issue.save
580 580 end
581 581
582 582 def test_should_not_set_a_disabled_tracker
583 583 p = Project.find(1)
584 584 p.trackers.delete(Tracker.find(2))
585 585
586 586 issue = Issue.find(1)
587 587 issue.tracker_id = 2
588 588 issue.subject = 'New subject'
589 589 assert !issue.save
590 590 assert_not_equal [], issue.errors[:tracker_id]
591 591 end
592 592
593 593 def test_category_based_assignment
594 594 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
595 595 :status_id => 1, :priority => IssuePriority.all.first,
596 596 :subject => 'Assignment test',
597 597 :description => 'Assignment test', :category_id => 1)
598 598 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
599 599 end
600 600
601 601 def test_new_statuses_allowed_to
602 602 WorkflowTransition.delete_all
603 603 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
604 604 :old_status_id => 1, :new_status_id => 2,
605 605 :author => false, :assignee => false)
606 606 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
607 607 :old_status_id => 1, :new_status_id => 3,
608 608 :author => true, :assignee => false)
609 609 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
610 610 :old_status_id => 1, :new_status_id => 4,
611 611 :author => false, :assignee => true)
612 612 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
613 613 :old_status_id => 1, :new_status_id => 5,
614 614 :author => true, :assignee => true)
615 615 status = IssueStatus.find(1)
616 616 role = Role.find(1)
617 617 tracker = Tracker.find(1)
618 618 user = User.find(2)
619 619
620 620 issue = Issue.generate!(:tracker => tracker, :status => status,
621 621 :project_id => 1, :author_id => 1)
622 622 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
623 623
624 624 issue = Issue.generate!(:tracker => tracker, :status => status,
625 625 :project_id => 1, :author => user)
626 626 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
627 627
628 628 issue = Issue.generate!(:tracker => tracker, :status => status,
629 629 :project_id => 1, :author_id => 1,
630 630 :assigned_to => user)
631 631 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
632 632
633 633 issue = Issue.generate!(:tracker => tracker, :status => status,
634 634 :project_id => 1, :author => user,
635 635 :assigned_to => user)
636 636 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
637 637
638 638 group = Group.generate!
639 639 group.users << user
640 640 issue = Issue.generate!(:tracker => tracker, :status => status,
641 641 :project_id => 1, :author => user,
642 642 :assigned_to => group)
643 643 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
644 644 end
645 645
646 646 def test_new_statuses_allowed_to_should_consider_group_assignment
647 647 WorkflowTransition.delete_all
648 648 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
649 649 :old_status_id => 1, :new_status_id => 4,
650 650 :author => false, :assignee => true)
651 651 user = User.find(2)
652 652 group = Group.generate!
653 653 group.users << user
654 654
655 655 issue = Issue.generate!(:author_id => 1, :assigned_to => group)
656 656 assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
657 657 end
658 658
659 659 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
660 660 admin = User.find(1)
661 661 issue = Issue.find(1)
662 662 assert !admin.member_of?(issue.project)
663 663 expected_statuses = [issue.status] +
664 664 WorkflowTransition.where(:old_status_id => issue.status_id).
665 665 map(&:new_status).uniq.sort
666 666 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
667 667 end
668 668
669 669 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
670 670 issue = Issue.find(1).copy
671 671 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
672 672
673 673 issue = Issue.find(2).copy
674 674 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
675 675 end
676 676
677 677 def test_safe_attributes_names_should_not_include_disabled_field
678 678 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
679 679
680 680 issue = Issue.new(:tracker => tracker)
681 681 assert_include 'tracker_id', issue.safe_attribute_names
682 682 assert_include 'status_id', issue.safe_attribute_names
683 683 assert_include 'subject', issue.safe_attribute_names
684 684 assert_include 'description', issue.safe_attribute_names
685 685 assert_include 'custom_field_values', issue.safe_attribute_names
686 686 assert_include 'custom_fields', issue.safe_attribute_names
687 687 assert_include 'lock_version', issue.safe_attribute_names
688 688
689 689 tracker.core_fields.each do |field|
690 690 assert_include field, issue.safe_attribute_names
691 691 end
692 692
693 693 tracker.disabled_core_fields.each do |field|
694 694 assert_not_include field, issue.safe_attribute_names
695 695 end
696 696 end
697 697
698 698 def test_safe_attributes_should_ignore_disabled_fields
699 699 tracker = Tracker.find(1)
700 700 tracker.core_fields = %w(assigned_to_id due_date)
701 701 tracker.save!
702 702
703 703 issue = Issue.new(:tracker => tracker)
704 704 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
705 705 assert_nil issue.start_date
706 706 assert_equal Date.parse('2012-07-14'), issue.due_date
707 707 end
708 708
709 709 def test_safe_attributes_should_accept_target_tracker_enabled_fields
710 710 source = Tracker.find(1)
711 711 source.core_fields = []
712 712 source.save!
713 713 target = Tracker.find(2)
714 714 target.core_fields = %w(assigned_to_id due_date)
715 715 target.save!
716 716
717 717 issue = Issue.new(:tracker => source)
718 718 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
719 719 assert_equal target, issue.tracker
720 720 assert_equal Date.parse('2012-07-14'), issue.due_date
721 721 end
722 722
723 723 def test_safe_attributes_should_not_include_readonly_fields
724 724 WorkflowPermission.delete_all
725 725 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
726 726 :role_id => 1, :field_name => 'due_date',
727 727 :rule => 'readonly')
728 728 user = User.find(2)
729 729
730 730 issue = Issue.new(:project_id => 1, :tracker_id => 1)
731 731 assert_equal %w(due_date), issue.read_only_attribute_names(user)
732 732 assert_not_include 'due_date', issue.safe_attribute_names(user)
733 733
734 734 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
735 735 assert_equal Date.parse('2012-07-14'), issue.start_date
736 736 assert_nil issue.due_date
737 737 end
738 738
739 739 def test_safe_attributes_should_not_include_readonly_custom_fields
740 740 cf1 = IssueCustomField.create!(:name => 'Writable field',
741 741 :field_format => 'string',
742 742 :is_for_all => true, :tracker_ids => [1])
743 743 cf2 = IssueCustomField.create!(:name => 'Readonly field',
744 744 :field_format => 'string',
745 745 :is_for_all => true, :tracker_ids => [1])
746 746 WorkflowPermission.delete_all
747 747 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
748 748 :role_id => 1, :field_name => cf2.id.to_s,
749 749 :rule => 'readonly')
750 750 user = User.find(2)
751 751 issue = Issue.new(:project_id => 1, :tracker_id => 1)
752 752 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
753 753 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
754 754
755 755 issue.send :safe_attributes=, {'custom_field_values' => {
756 756 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
757 757 }}, user
758 758 assert_equal 'value1', issue.custom_field_value(cf1)
759 759 assert_nil issue.custom_field_value(cf2)
760 760
761 761 issue.send :safe_attributes=, {'custom_fields' => [
762 762 {'id' => cf1.id.to_s, 'value' => 'valuea'},
763 763 {'id' => cf2.id.to_s, 'value' => 'valueb'}
764 764 ]}, user
765 765 assert_equal 'valuea', issue.custom_field_value(cf1)
766 766 assert_nil issue.custom_field_value(cf2)
767 767 end
768 768
769 769 def test_editable_custom_field_values_should_return_non_readonly_custom_values
770 770 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
771 771 :is_for_all => true, :tracker_ids => [1, 2])
772 772 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
773 773 :is_for_all => true, :tracker_ids => [1, 2])
774 774 WorkflowPermission.delete_all
775 775 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
776 776 :field_name => cf2.id.to_s, :rule => 'readonly')
777 777 user = User.find(2)
778 778
779 779 issue = Issue.new(:project_id => 1, :tracker_id => 1)
780 780 values = issue.editable_custom_field_values(user)
781 781 assert values.detect {|value| value.custom_field == cf1}
782 782 assert_nil values.detect {|value| value.custom_field == cf2}
783 783
784 784 issue.tracker_id = 2
785 785 values = issue.editable_custom_field_values(user)
786 786 assert values.detect {|value| value.custom_field == cf1}
787 787 assert values.detect {|value| value.custom_field == cf2}
788 788 end
789 789
790 790 def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
791 791 enabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [1,2])
792 792 disabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [2])
793 793 user = User.find(2)
794 794 issue = Issue.new(:project_id => 1, :tracker_id => 1)
795 795
796 796 assert_include enabled_cf, issue.editable_custom_fields(user)
797 797 assert_not_include disabled_cf, issue.editable_custom_fields(user)
798 798 end
799 799
800 800 def test_safe_attributes_should_accept_target_tracker_writable_fields
801 801 WorkflowPermission.delete_all
802 802 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
803 803 :role_id => 1, :field_name => 'due_date',
804 804 :rule => 'readonly')
805 805 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
806 806 :role_id => 1, :field_name => 'start_date',
807 807 :rule => 'readonly')
808 808 user = User.find(2)
809 809
810 810 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
811 811
812 812 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
813 813 'due_date' => '2012-07-14'}, user
814 814 assert_equal Date.parse('2012-07-12'), issue.start_date
815 815 assert_nil issue.due_date
816 816
817 817 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
818 818 'due_date' => '2012-07-16',
819 819 'tracker_id' => 2}, user
820 820 assert_equal Date.parse('2012-07-12'), issue.start_date
821 821 assert_equal Date.parse('2012-07-16'), issue.due_date
822 822 end
823 823
824 824 def test_safe_attributes_should_accept_target_status_writable_fields
825 825 WorkflowPermission.delete_all
826 826 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
827 827 :role_id => 1, :field_name => 'due_date',
828 828 :rule => 'readonly')
829 829 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
830 830 :role_id => 1, :field_name => 'start_date',
831 831 :rule => 'readonly')
832 832 user = User.find(2)
833 833
834 834 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
835 835
836 836 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
837 837 'due_date' => '2012-07-14'},
838 838 user
839 839 assert_equal Date.parse('2012-07-12'), issue.start_date
840 840 assert_nil issue.due_date
841 841
842 842 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
843 843 'due_date' => '2012-07-16',
844 844 'status_id' => 2},
845 845 user
846 846 assert_equal Date.parse('2012-07-12'), issue.start_date
847 847 assert_equal Date.parse('2012-07-16'), issue.due_date
848 848 end
849 849
850 850 def test_required_attributes_should_be_validated
851 851 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
852 852 :is_for_all => true, :tracker_ids => [1, 2])
853 853
854 854 WorkflowPermission.delete_all
855 855 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
856 856 :role_id => 1, :field_name => 'due_date',
857 857 :rule => 'required')
858 858 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
859 859 :role_id => 1, :field_name => 'category_id',
860 860 :rule => 'required')
861 861 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
862 862 :role_id => 1, :field_name => cf.id.to_s,
863 863 :rule => 'required')
864 864
865 865 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
866 866 :role_id => 1, :field_name => 'start_date',
867 867 :rule => 'required')
868 868 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
869 869 :role_id => 1, :field_name => cf.id.to_s,
870 870 :rule => 'required')
871 871 user = User.find(2)
872 872
873 873 issue = Issue.new(:project_id => 1, :tracker_id => 1,
874 874 :status_id => 1, :subject => 'Required fields',
875 875 :author => user)
876 876 assert_equal [cf.id.to_s, "category_id", "due_date"],
877 877 issue.required_attribute_names(user).sort
878 878 assert !issue.save, "Issue was saved"
879 879 assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
880 880 issue.errors.full_messages.sort
881 881
882 882 issue.tracker_id = 2
883 883 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
884 884 assert !issue.save, "Issue was saved"
885 885 assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
886 886 issue.errors.full_messages.sort
887 887
888 888 issue.start_date = Date.today
889 889 issue.custom_field_values = {cf.id.to_s => 'bar'}
890 890 assert issue.save
891 891 end
892 892
893 893 def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
894 894 WorkflowPermission.delete_all
895 895 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
896 896 :role_id => 1, :field_name => 'start_date',
897 897 :rule => 'required')
898 898 user = User.find(2)
899 899
900 900 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
901 901 :subject => 'Required fields', :author => user)
902 902 assert !issue.save
903 903 assert_include "Start date cannot be blank", issue.errors.full_messages
904 904
905 905 tracker = Tracker.find(1)
906 906 tracker.core_fields -= %w(start_date)
907 907 tracker.save!
908 908 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
909 909 :subject => 'Required fields', :author => user)
910 910 assert issue.save
911 911 end
912 912
913 913 def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
914 914 CustomField.delete_all
915 915 field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
916 916 user = User.generate!
917 917 User.add_to_project(user, Project.find(1), Role.find(2))
918 918
919 919 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
920 920 :subject => 'Required fields', :author => user)
921 921 assert_save issue
922 922 end
923 923
924 924 def test_required_custom_field_that_is_visible_for_the_user_should_be_required
925 925 CustomField.delete_all
926 926 field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
927 927 user = User.generate!
928 928 User.add_to_project(user, Project.find(1), Role.find(1))
929 929
930 930 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
931 931 :subject => 'Required fields', :author => user)
932 932 assert !issue.save
933 933 assert_include "#{field.name} cannot be blank", issue.errors.full_messages
934 934 end
935 935
936 936 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
937 937 WorkflowPermission.delete_all
938 938 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
939 939 :role_id => 1, :field_name => 'due_date',
940 940 :rule => 'required')
941 941 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
942 942 :role_id => 1, :field_name => 'start_date',
943 943 :rule => 'required')
944 944 user = User.find(2)
945 945 member = Member.find(1)
946 946 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
947 947
948 948 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
949 949
950 950 member.role_ids = [1, 2]
951 951 member.save!
952 952 assert_equal [], issue.required_attribute_names(user.reload)
953 953
954 954 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
955 955 :role_id => 2, :field_name => 'due_date',
956 956 :rule => 'required')
957 957 assert_equal %w(due_date), issue.required_attribute_names(user)
958 958
959 959 member.role_ids = [1, 2, 3]
960 960 member.save!
961 961 assert_equal [], issue.required_attribute_names(user.reload)
962 962
963 963 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
964 964 :role_id => 3, :field_name => 'due_date',
965 965 :rule => 'readonly')
966 966 # required + readonly => required
967 967 assert_equal %w(due_date), issue.required_attribute_names(user)
968 968 end
969 969
970 970 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
971 971 WorkflowPermission.delete_all
972 972 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
973 973 :role_id => 1, :field_name => 'due_date',
974 974 :rule => 'readonly')
975 975 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
976 976 :role_id => 1, :field_name => 'start_date',
977 977 :rule => 'readonly')
978 978 user = User.find(2)
979 979 member = Member.find(1)
980 980 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
981 981
982 982 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
983 983
984 984 member.role_ids = [1, 2]
985 985 member.save!
986 986 assert_equal [], issue.read_only_attribute_names(user.reload)
987 987
988 988 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
989 989 :role_id => 2, :field_name => 'due_date',
990 990 :rule => 'readonly')
991 991 assert_equal %w(due_date), issue.read_only_attribute_names(user)
992 992 end
993 993
994 994 # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
995 995 def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
996 996 field = IssueCustomField.generate!(
997 997 :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
998 998 )
999 999 WorkflowPermission.delete_all
1000 1000 WorkflowPermission.create!(
1001 1001 :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
1002 1002 )
1003 1003 user = User.generate!
1004 1004 project = Project.find(1)
1005 1005 User.add_to_project(user, project, Role.where(:id => [1, 2]))
1006 1006
1007 1007 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1008 1008 assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
1009 1009 end
1010 1010
1011 1011 def test_workflow_rules_should_ignore_roles_without_issue_permissions
1012 1012 role = Role.generate! :permissions => [:view_issues, :edit_issues]
1013 1013 ignored_role = Role.generate! :permissions => [:view_issues]
1014 1014
1015 1015 WorkflowPermission.delete_all
1016 1016 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1017 1017 :role => role, :field_name => 'due_date',
1018 1018 :rule => 'required')
1019 1019 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1020 1020 :role => role, :field_name => 'start_date',
1021 1021 :rule => 'readonly')
1022 1022 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1023 1023 :role => role, :field_name => 'done_ratio',
1024 1024 :rule => 'readonly')
1025 1025 user = User.generate!
1026 1026 User.add_to_project user, Project.find(1), [role, ignored_role]
1027 1027
1028 1028 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1029 1029
1030 1030 assert_equal %w(due_date), issue.required_attribute_names(user)
1031 1031 assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
1032 1032 end
1033 1033
1034 1034 def test_workflow_rules_should_work_for_member_with_duplicate_role
1035 1035 WorkflowPermission.delete_all
1036 1036 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1037 1037 :role_id => 1, :field_name => 'due_date',
1038 1038 :rule => 'required')
1039 1039 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1040 1040 :role_id => 1, :field_name => 'start_date',
1041 1041 :rule => 'readonly')
1042 1042
1043 1043 user = User.generate!
1044 1044 m = Member.new(:user_id => user.id, :project_id => 1)
1045 1045 m.member_roles.build(:role_id => 1)
1046 1046 m.member_roles.build(:role_id => 1)
1047 1047 m.save!
1048 1048
1049 1049 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1050 1050
1051 1051 assert_equal %w(due_date), issue.required_attribute_names(user)
1052 1052 assert_equal %w(start_date), issue.read_only_attribute_names(user)
1053 1053 end
1054 1054
1055 1055 def test_copy
1056 1056 issue = Issue.new.copy_from(1)
1057 1057 assert issue.copy?
1058 1058 assert issue.save
1059 1059 issue.reload
1060 1060 orig = Issue.find(1)
1061 1061 assert_equal orig.subject, issue.subject
1062 1062 assert_equal orig.tracker, issue.tracker
1063 1063 assert_equal "125", issue.custom_value_for(2).value
1064 1064 end
1065 1065
1066 1066 def test_copy_should_copy_status
1067 1067 orig = Issue.find(8)
1068 1068 assert orig.status != orig.default_status
1069 1069
1070 1070 issue = Issue.new.copy_from(orig)
1071 1071 assert issue.save
1072 1072 issue.reload
1073 1073 assert_equal orig.status, issue.status
1074 1074 end
1075 1075
1076 1076 def test_copy_should_add_relation_with_copied_issue
1077 1077 copied = Issue.find(1)
1078 1078 issue = Issue.new.copy_from(copied)
1079 1079 assert issue.save
1080 1080 issue.reload
1081 1081
1082 1082 assert_equal 1, issue.relations.size
1083 1083 relation = issue.relations.first
1084 1084 assert_equal 'copied_to', relation.relation_type
1085 1085 assert_equal copied, relation.issue_from
1086 1086 assert_equal issue, relation.issue_to
1087 1087 end
1088 1088
1089 1089 def test_copy_should_copy_subtasks
1090 1090 issue = Issue.generate_with_descendants!
1091 1091
1092 1092 copy = issue.reload.copy
1093 1093 copy.author = User.find(7)
1094 1094 assert_difference 'Issue.count', 1+issue.descendants.count do
1095 1095 assert copy.save
1096 1096 end
1097 1097 copy.reload
1098 1098 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
1099 1099 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
1100 1100 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
1101 1101 assert_equal copy.author, child_copy.author
1102 1102 end
1103 1103
1104 1104 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
1105 1105 parent = Issue.generate!
1106 1106 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
1107 1107 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
1108 1108
1109 1109 copy = parent.reload.copy
1110 1110 copy.parent_issue_id = parent.id
1111 1111 copy.author = User.find(7)
1112 1112 assert_difference 'Issue.count', 3 do
1113 1113 assert copy.save
1114 1114 end
1115 1115 parent.reload
1116 1116 copy.reload
1117 1117 assert_equal parent, copy.parent
1118 1118 assert_equal 3, parent.children.count
1119 1119 assert_equal 5, parent.descendants.count
1120 1120 assert_equal 2, copy.children.count
1121 1121 assert_equal 2, copy.descendants.count
1122 1122 end
1123 1123
1124 1124 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
1125 1125 parent = Issue.generate!
1126 1126 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
1127 1127 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
1128 1128
1129 1129 copy = parent.reload.copy
1130 1130 copy.parent_issue_id = child1.id
1131 1131 copy.author = User.find(7)
1132 1132 assert_difference 'Issue.count', 3 do
1133 1133 assert copy.save
1134 1134 end
1135 1135 parent.reload
1136 1136 child1.reload
1137 1137 copy.reload
1138 1138 assert_equal child1, copy.parent
1139 1139 assert_equal 2, parent.children.count
1140 1140 assert_equal 5, parent.descendants.count
1141 1141 assert_equal 1, child1.children.count
1142 1142 assert_equal 3, child1.descendants.count
1143 1143 assert_equal 2, copy.children.count
1144 1144 assert_equal 2, copy.descendants.count
1145 1145 end
1146 1146
1147 1147 def test_copy_should_copy_subtasks_to_target_project
1148 1148 issue = Issue.generate_with_descendants!
1149 1149
1150 1150 copy = issue.copy(:project_id => 3)
1151 1151 assert_difference 'Issue.count', 1+issue.descendants.count do
1152 1152 assert copy.save
1153 1153 end
1154 1154 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
1155 1155 end
1156 1156
1157 1157 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
1158 1158 issue = Issue.generate_with_descendants!
1159 1159
1160 1160 copy = issue.reload.copy
1161 1161 assert_difference 'Issue.count', 1+issue.descendants.count do
1162 1162 assert copy.save
1163 1163 assert copy.save
1164 1164 end
1165 1165 end
1166 1166
1167 1167 def test_should_not_call_after_project_change_on_creation
1168 1168 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1169 1169 :subject => 'Test', :author_id => 1)
1170 1170 issue.expects(:after_project_change).never
1171 1171 issue.save!
1172 1172 end
1173 1173
1174 1174 def test_should_not_call_after_project_change_on_update
1175 1175 issue = Issue.find(1)
1176 1176 issue.project = Project.find(1)
1177 1177 issue.subject = 'No project change'
1178 1178 issue.expects(:after_project_change).never
1179 1179 issue.save!
1180 1180 end
1181 1181
1182 1182 def test_should_call_after_project_change_on_project_change
1183 1183 issue = Issue.find(1)
1184 1184 issue.project = Project.find(2)
1185 1185 issue.expects(:after_project_change).once
1186 1186 issue.save!
1187 1187 end
1188 1188
1189 1189 def test_adding_journal_should_update_timestamp
1190 1190 issue = Issue.find(1)
1191 1191 updated_on_was = issue.updated_on
1192 1192
1193 1193 issue.init_journal(User.first, "Adding notes")
1194 1194 assert_difference 'Journal.count' do
1195 1195 assert issue.save
1196 1196 end
1197 1197 issue.reload
1198 1198
1199 1199 assert_not_equal updated_on_was, issue.updated_on
1200 1200 end
1201 1201
1202 1202 def test_should_close_duplicates
1203 1203 # Create 3 issues
1204 1204 issue1 = Issue.generate!
1205 1205 issue2 = Issue.generate!
1206 1206 issue3 = Issue.generate!
1207 1207
1208 1208 # 2 is a dupe of 1
1209 1209 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
1210 1210 :relation_type => IssueRelation::TYPE_DUPLICATES)
1211 1211 # And 3 is a dupe of 2
1212 1212 # IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1213 1213 # :relation_type => IssueRelation::TYPE_DUPLICATES)
1214 1214 # And 3 is a dupe of 1 (circular duplicates)
1215 1215 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
1216 1216 :relation_type => IssueRelation::TYPE_DUPLICATES)
1217 1217
1218 1218 assert issue1.reload.duplicates.include?(issue2)
1219 1219
1220 1220 # Closing issue 1
1221 1221 issue1.init_journal(User.first, "Closing issue1")
1222 1222 issue1.status = IssueStatus.where(:is_closed => true).first
1223 1223 assert issue1.save
1224 1224 # 2 and 3 should be also closed
1225 1225 assert issue2.reload.closed?
1226 1226 assert issue3.reload.closed?
1227 1227 end
1228 1228
1229 def test_should_close_duplicates_with_private_notes
1230 issue = Issue.generate!
1231 duplicate = Issue.generate!
1232 IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
1233 :relation_type => IssueRelation::TYPE_DUPLICATES)
1234 assert issue.reload.duplicates.include?(duplicate)
1235
1236 # Closing issue with private notes
1237 issue.init_journal(User.first, "Private notes")
1238 issue.private_notes = true
1239 issue.status = IssueStatus.where(:is_closed => true).first
1240 assert_save issue
1241
1242 duplicate.reload
1243 assert journal = duplicate.journals.detect {|journal| journal.notes == "Private notes"}
1244 assert_equal true, journal.private_notes
1245 end
1246
1229 1247 def test_should_not_close_duplicated_issue
1230 1248 issue1 = Issue.generate!
1231 1249 issue2 = Issue.generate!
1232 1250
1233 1251 # 2 is a dupe of 1
1234 1252 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
1235 1253 :relation_type => IssueRelation::TYPE_DUPLICATES)
1236 1254 # 2 is a dup of 1 but 1 is not a duplicate of 2
1237 1255 assert !issue2.reload.duplicates.include?(issue1)
1238 1256
1239 1257 # Closing issue 2
1240 1258 issue2.init_journal(User.first, "Closing issue2")
1241 1259 issue2.status = IssueStatus.where(:is_closed => true).first
1242 1260 assert issue2.save
1243 1261 # 1 should not be also closed
1244 1262 assert !issue1.reload.closed?
1245 1263 end
1246 1264
1247 1265 def test_assignable_versions
1248 1266 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1249 1267 :status_id => 1, :fixed_version_id => 1,
1250 1268 :subject => 'New issue')
1251 1269 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
1252 1270 end
1253 1271
1254 1272 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
1255 1273 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1256 1274 :status_id => 1, :fixed_version_id => 1,
1257 1275 :subject => 'New issue')
1258 1276 assert !issue.save
1259 1277 assert_not_equal [], issue.errors[:fixed_version_id]
1260 1278 end
1261 1279
1262 1280 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
1263 1281 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1264 1282 :status_id => 1, :fixed_version_id => 2,
1265 1283 :subject => 'New issue')
1266 1284 assert !issue.save
1267 1285 assert_not_equal [], issue.errors[:fixed_version_id]
1268 1286 end
1269 1287
1270 1288 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
1271 1289 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1272 1290 :status_id => 1, :fixed_version_id => 3,
1273 1291 :subject => 'New issue')
1274 1292 assert issue.save
1275 1293 end
1276 1294
1277 1295 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
1278 1296 issue = Issue.find(11)
1279 1297 assert_equal 'closed', issue.fixed_version.status
1280 1298 issue.subject = 'Subject changed'
1281 1299 assert issue.save
1282 1300 end
1283 1301
1284 1302 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
1285 1303 issue = Issue.find(11)
1286 1304 issue.status_id = 1
1287 1305 assert !issue.save
1288 1306 assert_not_equal [], issue.errors[:base]
1289 1307 end
1290 1308
1291 1309 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
1292 1310 issue = Issue.find(11)
1293 1311 issue.status_id = 1
1294 1312 issue.fixed_version_id = 3
1295 1313 assert issue.save
1296 1314 end
1297 1315
1298 1316 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
1299 1317 issue = Issue.find(12)
1300 1318 assert_equal 'locked', issue.fixed_version.status
1301 1319 issue.status_id = 1
1302 1320 assert issue.save
1303 1321 end
1304 1322
1305 1323 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
1306 1324 issue = Issue.find(2)
1307 1325 assert_equal 2, issue.fixed_version_id
1308 1326 issue.project_id = 3
1309 1327 assert_nil issue.fixed_version_id
1310 1328 issue.fixed_version_id = 2
1311 1329 assert !issue.save
1312 1330 assert_include 'Target version is not included in the list', issue.errors.full_messages
1313 1331 end
1314 1332
1315 1333 def test_should_keep_shared_version_when_changing_project
1316 1334 Version.find(2).update_attribute :sharing, 'tree'
1317 1335
1318 1336 issue = Issue.find(2)
1319 1337 assert_equal 2, issue.fixed_version_id
1320 1338 issue.project_id = 3
1321 1339 assert_equal 2, issue.fixed_version_id
1322 1340 assert issue.save
1323 1341 end
1324 1342
1325 1343 def test_allowed_target_projects_should_include_projects_with_issue_tracking_enabled
1326 1344 assert_include Project.find(2), Issue.allowed_target_projects(User.find(2))
1327 1345 end
1328 1346
1329 1347 def test_allowed_target_projects_should_not_include_projects_with_issue_tracking_disabled
1330 1348 Project.find(2).disable_module! :issue_tracking
1331 1349 assert_not_include Project.find(2), Issue.allowed_target_projects(User.find(2))
1332 1350 end
1333 1351
1334 1352 def test_move_to_another_project_with_same_category
1335 1353 issue = Issue.find(1)
1336 1354 issue.project = Project.find(2)
1337 1355 assert issue.save
1338 1356 issue.reload
1339 1357 assert_equal 2, issue.project_id
1340 1358 # Category changes
1341 1359 assert_equal 4, issue.category_id
1342 1360 # Make sure time entries were move to the target project
1343 1361 assert_equal 2, issue.time_entries.first.project_id
1344 1362 end
1345 1363
1346 1364 def test_move_to_another_project_without_same_category
1347 1365 issue = Issue.find(2)
1348 1366 issue.project = Project.find(2)
1349 1367 assert issue.save
1350 1368 issue.reload
1351 1369 assert_equal 2, issue.project_id
1352 1370 # Category cleared
1353 1371 assert_nil issue.category_id
1354 1372 end
1355 1373
1356 1374 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
1357 1375 issue = Issue.find(1)
1358 1376 issue.update_attribute(:fixed_version_id, 1)
1359 1377 issue.project = Project.find(2)
1360 1378 assert issue.save
1361 1379 issue.reload
1362 1380 assert_equal 2, issue.project_id
1363 1381 # Cleared fixed_version
1364 1382 assert_equal nil, issue.fixed_version
1365 1383 end
1366 1384
1367 1385 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
1368 1386 issue = Issue.find(1)
1369 1387 issue.update_attribute(:fixed_version_id, 4)
1370 1388 issue.project = Project.find(5)
1371 1389 assert issue.save
1372 1390 issue.reload
1373 1391 assert_equal 5, issue.project_id
1374 1392 # Keep fixed_version
1375 1393 assert_equal 4, issue.fixed_version_id
1376 1394 end
1377 1395
1378 1396 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1379 1397 issue = Issue.find(1)
1380 1398 issue.update_attribute(:fixed_version_id, 1)
1381 1399 issue.project = Project.find(5)
1382 1400 assert issue.save
1383 1401 issue.reload
1384 1402 assert_equal 5, issue.project_id
1385 1403 # Cleared fixed_version
1386 1404 assert_equal nil, issue.fixed_version
1387 1405 end
1388 1406
1389 1407 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1390 1408 issue = Issue.find(1)
1391 1409 issue.update_attribute(:fixed_version_id, 7)
1392 1410 issue.project = Project.find(2)
1393 1411 assert issue.save
1394 1412 issue.reload
1395 1413 assert_equal 2, issue.project_id
1396 1414 # Keep fixed_version
1397 1415 assert_equal 7, issue.fixed_version_id
1398 1416 end
1399 1417
1400 1418 def test_move_to_another_project_should_keep_parent_if_valid
1401 1419 issue = Issue.find(1)
1402 1420 issue.update_attribute(:parent_issue_id, 2)
1403 1421 issue.project = Project.find(3)
1404 1422 assert issue.save
1405 1423 issue.reload
1406 1424 assert_equal 2, issue.parent_id
1407 1425 end
1408 1426
1409 1427 def test_move_to_another_project_should_clear_parent_if_not_valid
1410 1428 issue = Issue.find(1)
1411 1429 issue.update_attribute(:parent_issue_id, 2)
1412 1430 issue.project = Project.find(2)
1413 1431 assert issue.save
1414 1432 issue.reload
1415 1433 assert_nil issue.parent_id
1416 1434 end
1417 1435
1418 1436 def test_move_to_another_project_with_disabled_tracker
1419 1437 issue = Issue.find(1)
1420 1438 target = Project.find(2)
1421 1439 target.tracker_ids = [3]
1422 1440 target.save
1423 1441 issue.project = target
1424 1442 assert issue.save
1425 1443 issue.reload
1426 1444 assert_equal 2, issue.project_id
1427 1445 assert_equal 3, issue.tracker_id
1428 1446 end
1429 1447
1430 1448 def test_copy_to_the_same_project
1431 1449 issue = Issue.find(1)
1432 1450 copy = issue.copy
1433 1451 assert_difference 'Issue.count' do
1434 1452 copy.save!
1435 1453 end
1436 1454 assert_kind_of Issue, copy
1437 1455 assert_equal issue.project, copy.project
1438 1456 assert_equal "125", copy.custom_value_for(2).value
1439 1457 end
1440 1458
1441 1459 def test_copy_to_another_project_and_tracker
1442 1460 issue = Issue.find(1)
1443 1461 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1444 1462 assert_difference 'Issue.count' do
1445 1463 copy.save!
1446 1464 end
1447 1465 copy.reload
1448 1466 assert_kind_of Issue, copy
1449 1467 assert_equal Project.find(3), copy.project
1450 1468 assert_equal Tracker.find(2), copy.tracker
1451 1469 # Custom field #2 is not associated with target tracker
1452 1470 assert_nil copy.custom_value_for(2)
1453 1471 end
1454 1472
1455 1473 test "#copy should not create a journal" do
1456 1474 copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :assigned_to_id => 3}, :link => false)
1457 1475 copy.save!
1458 1476 assert_equal 0, copy.reload.journals.size
1459 1477 end
1460 1478
1461 1479 test "#copy should allow assigned_to changes" do
1462 1480 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1463 1481 assert_equal 3, copy.assigned_to_id
1464 1482 end
1465 1483
1466 1484 test "#copy should allow status changes" do
1467 1485 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1468 1486 assert_equal 2, copy.status_id
1469 1487 end
1470 1488
1471 1489 test "#copy should allow start date changes" do
1472 1490 date = Date.today
1473 1491 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1474 1492 assert_equal date, copy.start_date
1475 1493 end
1476 1494
1477 1495 test "#copy should allow due date changes" do
1478 1496 date = Date.today
1479 1497 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1480 1498 assert_equal date, copy.due_date
1481 1499 end
1482 1500
1483 1501 test "#copy should set current user as author" do
1484 1502 User.current = User.find(9)
1485 1503 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
1486 1504 assert_equal User.current, copy.author
1487 1505 end
1488 1506
1489 1507 test "#copy should create a journal with notes" do
1490 1508 date = Date.today
1491 1509 notes = "Notes added when copying"
1492 1510 copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :start_date => date}, :link => false)
1493 1511 copy.init_journal(User.current, notes)
1494 1512 copy.save!
1495 1513
1496 1514 assert_equal 1, copy.journals.size
1497 1515 journal = copy.journals.first
1498 1516 assert_equal 0, journal.details.size
1499 1517 assert_equal notes, journal.notes
1500 1518 end
1501 1519
1502 1520 def test_valid_parent_project
1503 1521 issue = Issue.find(1)
1504 1522 issue_in_same_project = Issue.find(2)
1505 1523 issue_in_child_project = Issue.find(5)
1506 1524 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1507 1525 issue_in_other_child_project = Issue.find(6)
1508 1526 issue_in_different_tree = Issue.find(4)
1509 1527
1510 1528 with_settings :cross_project_subtasks => '' do
1511 1529 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1512 1530 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1513 1531 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1514 1532 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1515 1533 end
1516 1534
1517 1535 with_settings :cross_project_subtasks => 'system' do
1518 1536 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1519 1537 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1520 1538 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1521 1539 end
1522 1540
1523 1541 with_settings :cross_project_subtasks => 'tree' do
1524 1542 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1525 1543 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1526 1544 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1527 1545 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1528 1546
1529 1547 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1530 1548 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1531 1549 end
1532 1550
1533 1551 with_settings :cross_project_subtasks => 'descendants' do
1534 1552 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1535 1553 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1536 1554 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1537 1555 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1538 1556
1539 1557 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1540 1558 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1541 1559 end
1542 1560 end
1543 1561
1544 1562 def test_recipients_should_include_previous_assignee
1545 1563 user = User.find(3)
1546 1564 user.members.update_all ["mail_notification = ?", false]
1547 1565 user.update_attribute :mail_notification, 'only_assigned'
1548 1566
1549 1567 issue = Issue.find(2)
1550 1568 issue.assigned_to = nil
1551 1569 assert_include user.mail, issue.recipients
1552 1570 issue.save!
1553 1571 assert !issue.recipients.include?(user.mail)
1554 1572 end
1555 1573
1556 1574 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1557 1575 issue = Issue.find(12)
1558 1576 assert issue.recipients.include?(issue.author.mail)
1559 1577 # copy the issue to a private project
1560 1578 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1561 1579 # author is not a member of project anymore
1562 1580 assert !copy.recipients.include?(copy.author.mail)
1563 1581 end
1564 1582
1565 1583 def test_recipients_should_include_the_assigned_group_members
1566 1584 group_member = User.generate!
1567 1585 group = Group.generate!
1568 1586 group.users << group_member
1569 1587
1570 1588 issue = Issue.find(12)
1571 1589 issue.assigned_to = group
1572 1590 assert issue.recipients.include?(group_member.mail)
1573 1591 end
1574 1592
1575 1593 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1576 1594 user = User.find(3)
1577 1595 issue = Issue.find(9)
1578 1596 Watcher.create!(:user => user, :watchable => issue)
1579 1597 assert issue.watched_by?(user)
1580 1598 assert !issue.watcher_recipients.include?(user.mail)
1581 1599 end
1582 1600
1583 1601 def test_issue_destroy
1584 1602 Issue.find(1).destroy
1585 1603 assert_nil Issue.find_by_id(1)
1586 1604 assert_nil TimeEntry.find_by_issue_id(1)
1587 1605 end
1588 1606
1589 1607 def test_destroy_should_delete_time_entries_custom_values
1590 1608 issue = Issue.generate!
1591 1609 time_entry = TimeEntry.generate!(:issue => issue, :custom_field_values => {10 => '1'})
1592 1610
1593 1611 assert_difference 'CustomValue.where(:customized_type => "TimeEntry").count', -1 do
1594 1612 assert issue.destroy
1595 1613 end
1596 1614 end
1597 1615
1598 1616 def test_destroying_a_deleted_issue_should_not_raise_an_error
1599 1617 issue = Issue.find(1)
1600 1618 Issue.find(1).destroy
1601 1619
1602 1620 assert_nothing_raised do
1603 1621 assert_no_difference 'Issue.count' do
1604 1622 issue.destroy
1605 1623 end
1606 1624 assert issue.destroyed?
1607 1625 end
1608 1626 end
1609 1627
1610 1628 def test_destroying_a_stale_issue_should_not_raise_an_error
1611 1629 issue = Issue.find(1)
1612 1630 Issue.find(1).update_attribute :subject, "Updated"
1613 1631
1614 1632 assert_nothing_raised do
1615 1633 assert_difference 'Issue.count', -1 do
1616 1634 issue.destroy
1617 1635 end
1618 1636 assert issue.destroyed?
1619 1637 end
1620 1638 end
1621 1639
1622 1640 def test_blocked
1623 1641 blocked_issue = Issue.find(9)
1624 1642 blocking_issue = Issue.find(10)
1625 1643
1626 1644 assert blocked_issue.blocked?
1627 1645 assert !blocking_issue.blocked?
1628 1646 end
1629 1647
1630 1648 def test_blocked_issues_dont_allow_closed_statuses
1631 1649 blocked_issue = Issue.find(9)
1632 1650
1633 1651 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1634 1652 assert !allowed_statuses.empty?
1635 1653 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1636 1654 assert closed_statuses.empty?
1637 1655 end
1638 1656
1639 1657 def test_unblocked_issues_allow_closed_statuses
1640 1658 blocking_issue = Issue.find(10)
1641 1659
1642 1660 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1643 1661 assert !allowed_statuses.empty?
1644 1662 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1645 1663 assert !closed_statuses.empty?
1646 1664 end
1647 1665
1648 1666 def test_reschedule_an_issue_without_dates
1649 1667 with_settings :non_working_week_days => [] do
1650 1668 issue = Issue.new(:start_date => nil, :due_date => nil)
1651 1669 issue.reschedule_on '2012-10-09'.to_date
1652 1670 assert_equal '2012-10-09'.to_date, issue.start_date
1653 1671 assert_equal '2012-10-09'.to_date, issue.due_date
1654 1672 end
1655 1673
1656 1674 with_settings :non_working_week_days => %w(6 7) do
1657 1675 issue = Issue.new(:start_date => nil, :due_date => nil)
1658 1676 issue.reschedule_on '2012-10-09'.to_date
1659 1677 assert_equal '2012-10-09'.to_date, issue.start_date
1660 1678 assert_equal '2012-10-09'.to_date, issue.due_date
1661 1679
1662 1680 issue = Issue.new(:start_date => nil, :due_date => nil)
1663 1681 issue.reschedule_on '2012-10-13'.to_date
1664 1682 assert_equal '2012-10-15'.to_date, issue.start_date
1665 1683 assert_equal '2012-10-15'.to_date, issue.due_date
1666 1684 end
1667 1685 end
1668 1686
1669 1687 def test_reschedule_an_issue_with_start_date
1670 1688 with_settings :non_working_week_days => [] do
1671 1689 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1672 1690 issue.reschedule_on '2012-10-13'.to_date
1673 1691 assert_equal '2012-10-13'.to_date, issue.start_date
1674 1692 assert_equal '2012-10-13'.to_date, issue.due_date
1675 1693 end
1676 1694
1677 1695 with_settings :non_working_week_days => %w(6 7) do
1678 1696 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1679 1697 issue.reschedule_on '2012-10-11'.to_date
1680 1698 assert_equal '2012-10-11'.to_date, issue.start_date
1681 1699 assert_equal '2012-10-11'.to_date, issue.due_date
1682 1700
1683 1701 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1684 1702 issue.reschedule_on '2012-10-13'.to_date
1685 1703 assert_equal '2012-10-15'.to_date, issue.start_date
1686 1704 assert_equal '2012-10-15'.to_date, issue.due_date
1687 1705 end
1688 1706 end
1689 1707
1690 1708 def test_reschedule_an_issue_with_start_and_due_dates
1691 1709 with_settings :non_working_week_days => [] do
1692 1710 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
1693 1711 issue.reschedule_on '2012-10-13'.to_date
1694 1712 assert_equal '2012-10-13'.to_date, issue.start_date
1695 1713 assert_equal '2012-10-19'.to_date, issue.due_date
1696 1714 end
1697 1715
1698 1716 with_settings :non_working_week_days => %w(6 7) do
1699 1717 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
1700 1718 issue.reschedule_on '2012-10-11'.to_date
1701 1719 assert_equal '2012-10-11'.to_date, issue.start_date
1702 1720 assert_equal '2012-10-23'.to_date, issue.due_date
1703 1721
1704 1722 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
1705 1723 issue.reschedule_on '2012-10-13'.to_date
1706 1724 assert_equal '2012-10-15'.to_date, issue.start_date
1707 1725 assert_equal '2012-10-25'.to_date, issue.due_date
1708 1726 end
1709 1727 end
1710 1728
1711 1729 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
1712 1730 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1713 1731 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1714 1732 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1715 1733 :relation_type => IssueRelation::TYPE_PRECEDES)
1716 1734 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1717 1735
1718 1736 issue1.reload
1719 1737 issue1.due_date = '2012-10-23'
1720 1738 issue1.save!
1721 1739 issue2.reload
1722 1740 assert_equal Date.parse('2012-10-24'), issue2.start_date
1723 1741 assert_equal Date.parse('2012-10-26'), issue2.due_date
1724 1742 end
1725 1743
1726 1744 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
1727 1745 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1728 1746 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1729 1747 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1730 1748 :relation_type => IssueRelation::TYPE_PRECEDES)
1731 1749 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1732 1750
1733 1751 issue1.reload
1734 1752 issue1.start_date = '2012-09-17'
1735 1753 issue1.due_date = '2012-09-18'
1736 1754 issue1.save!
1737 1755 issue2.reload
1738 1756 assert_equal Date.parse('2012-09-19'), issue2.start_date
1739 1757 assert_equal Date.parse('2012-09-21'), issue2.due_date
1740 1758 end
1741 1759
1742 1760 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
1743 1761 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1744 1762 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1745 1763 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
1746 1764 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1747 1765 :relation_type => IssueRelation::TYPE_PRECEDES)
1748 1766 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1749 1767 :relation_type => IssueRelation::TYPE_PRECEDES)
1750 1768 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1751 1769
1752 1770 issue1.reload
1753 1771 issue1.start_date = '2012-09-17'
1754 1772 issue1.due_date = '2012-09-18'
1755 1773 issue1.save!
1756 1774 issue2.reload
1757 1775 # Issue 2 must start after Issue 3
1758 1776 assert_equal Date.parse('2012-10-03'), issue2.start_date
1759 1777 assert_equal Date.parse('2012-10-05'), issue2.due_date
1760 1778 end
1761 1779
1762 1780 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1763 1781 with_settings :non_working_week_days => [] do
1764 1782 stale = Issue.find(1)
1765 1783 issue = Issue.find(1)
1766 1784 issue.subject = "Updated"
1767 1785 issue.save!
1768 1786 date = 10.days.from_now.to_date
1769 1787 assert_nothing_raised do
1770 1788 stale.reschedule_on!(date)
1771 1789 end
1772 1790 assert_equal date, stale.reload.start_date
1773 1791 end
1774 1792 end
1775 1793
1776 1794 def test_child_issue_should_consider_parent_soonest_start_on_create
1777 1795 set_language_if_valid 'en'
1778 1796 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1779 1797 issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
1780 1798 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1781 1799 :relation_type => IssueRelation::TYPE_PRECEDES)
1782 1800 issue1.reload
1783 1801 issue2.reload
1784 1802 assert_equal Date.parse('2012-10-18'), issue2.start_date
1785 1803
1786 1804 with_settings :date_format => '%m/%d/%Y' do
1787 1805 child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
1788 1806 :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
1789 1807 assert !child.valid?
1790 1808 assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
1791 1809 assert_equal Date.parse('2012-10-18'), child.soonest_start
1792 1810 child.start_date = '2012-10-18'
1793 1811 assert child.save
1794 1812 end
1795 1813 end
1796 1814
1797 1815 def test_setting_parent_to_a_dependent_issue_should_not_validate
1798 1816 set_language_if_valid 'en'
1799 1817 issue1 = Issue.generate!
1800 1818 issue2 = Issue.generate!
1801 1819 issue3 = Issue.generate!
1802 1820 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1803 1821 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
1804 1822 issue3.reload
1805 1823 issue3.parent_issue_id = issue2.id
1806 1824 assert !issue3.valid?
1807 1825 assert_include 'Parent task is invalid', issue3.errors.full_messages
1808 1826 end
1809 1827
1810 1828 def test_setting_parent_should_not_allow_circular_dependency
1811 1829 set_language_if_valid 'en'
1812 1830 issue1 = Issue.generate!
1813 1831 issue2 = Issue.generate!
1814 1832 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1815 1833 issue3 = Issue.generate!
1816 1834 issue2.reload
1817 1835 issue2.parent_issue_id = issue3.id
1818 1836 issue2.save!
1819 1837 issue4 = Issue.generate!
1820 1838 IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
1821 1839 issue4.reload
1822 1840 issue4.parent_issue_id = issue1.id
1823 1841 assert !issue4.valid?
1824 1842 assert_include 'Parent task is invalid', issue4.errors.full_messages
1825 1843 end
1826 1844
1827 1845 def test_overdue
1828 1846 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1829 1847 assert !Issue.new(:due_date => Date.today).overdue?
1830 1848 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1831 1849 assert !Issue.new(:due_date => nil).overdue?
1832 1850 assert !Issue.new(:due_date => 1.day.ago.to_date,
1833 1851 :status => IssueStatus.where(:is_closed => true).first
1834 1852 ).overdue?
1835 1853 end
1836 1854
1837 1855 test "#behind_schedule? should be false if the issue has no start_date" do
1838 1856 assert !Issue.new(:start_date => nil,
1839 1857 :due_date => 1.day.from_now.to_date,
1840 1858 :done_ratio => 0).behind_schedule?
1841 1859 end
1842 1860
1843 1861 test "#behind_schedule? should be false if the issue has no end_date" do
1844 1862 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1845 1863 :due_date => nil,
1846 1864 :done_ratio => 0).behind_schedule?
1847 1865 end
1848 1866
1849 1867 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
1850 1868 assert !Issue.new(:start_date => 50.days.ago.to_date,
1851 1869 :due_date => 50.days.from_now.to_date,
1852 1870 :done_ratio => 90).behind_schedule?
1853 1871 end
1854 1872
1855 1873 test "#behind_schedule? should be true if the issue hasn't been started at all" do
1856 1874 assert Issue.new(:start_date => 1.day.ago.to_date,
1857 1875 :due_date => 1.day.from_now.to_date,
1858 1876 :done_ratio => 0).behind_schedule?
1859 1877 end
1860 1878
1861 1879 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
1862 1880 assert Issue.new(:start_date => 100.days.ago.to_date,
1863 1881 :due_date => Date.today,
1864 1882 :done_ratio => 90).behind_schedule?
1865 1883 end
1866 1884
1867 1885 test "#assignable_users should be Users" do
1868 1886 assert_kind_of User, Issue.find(1).assignable_users.first
1869 1887 end
1870 1888
1871 1889 test "#assignable_users should include the issue author" do
1872 1890 non_project_member = User.generate!
1873 1891 issue = Issue.generate!(:author => non_project_member)
1874 1892
1875 1893 assert issue.assignable_users.include?(non_project_member)
1876 1894 end
1877 1895
1878 1896 def test_assignable_users_should_not_include_anonymous_user
1879 1897 issue = Issue.generate!(:author => User.anonymous)
1880 1898
1881 1899 assert !issue.assignable_users.include?(User.anonymous)
1882 1900 end
1883 1901
1884 1902 def test_assignable_users_should_not_include_locked_user
1885 1903 user = User.generate!
1886 1904 issue = Issue.generate!(:author => user)
1887 1905 user.lock!
1888 1906
1889 1907 assert !issue.assignable_users.include?(user)
1890 1908 end
1891 1909
1892 1910 test "#assignable_users should include the current assignee" do
1893 1911 user = User.generate!
1894 1912 issue = Issue.generate!(:assigned_to => user)
1895 1913 user.lock!
1896 1914
1897 1915 assert Issue.find(issue.id).assignable_users.include?(user)
1898 1916 end
1899 1917
1900 1918 test "#assignable_users should not show the issue author twice" do
1901 1919 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1902 1920 assert_equal 2, assignable_user_ids.length
1903 1921
1904 1922 assignable_user_ids.each do |user_id|
1905 1923 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1906 1924 "User #{user_id} appears more or less than once"
1907 1925 end
1908 1926 end
1909 1927
1910 1928 test "#assignable_users with issue_group_assignment should include groups" do
1911 1929 issue = Issue.new(:project => Project.find(2))
1912 1930
1913 1931 with_settings :issue_group_assignment => '1' do
1914 1932 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1915 1933 assert issue.assignable_users.include?(Group.find(11))
1916 1934 end
1917 1935 end
1918 1936
1919 1937 test "#assignable_users without issue_group_assignment should not include groups" do
1920 1938 issue = Issue.new(:project => Project.find(2))
1921 1939
1922 1940 with_settings :issue_group_assignment => '0' do
1923 1941 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1924 1942 assert !issue.assignable_users.include?(Group.find(11))
1925 1943 end
1926 1944 end
1927 1945
1928 1946 def test_assignable_users_should_not_include_builtin_groups
1929 1947 Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [1])
1930 1948 Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [1])
1931 1949 issue = Issue.new(:project => Project.find(1))
1932 1950
1933 1951 with_settings :issue_group_assignment => '1' do
1934 1952 assert_nil issue.assignable_users.detect {|u| u.is_a?(GroupBuiltin)}
1935 1953 end
1936 1954 end
1937 1955
1938 1956 def test_create_should_send_email_notification
1939 1957 ActionMailer::Base.deliveries.clear
1940 1958 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1941 1959 :author_id => 3, :status_id => 1,
1942 1960 :priority => IssuePriority.all.first,
1943 1961 :subject => 'test_create', :estimated_hours => '1:30')
1944 1962 with_settings :notified_events => %w(issue_added) do
1945 1963 assert issue.save
1946 1964 assert_equal 1, ActionMailer::Base.deliveries.size
1947 1965 end
1948 1966 end
1949 1967
1950 1968 def test_create_should_send_one_email_notification_with_both_settings
1951 1969 ActionMailer::Base.deliveries.clear
1952 1970 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1953 1971 :author_id => 3, :status_id => 1,
1954 1972 :priority => IssuePriority.all.first,
1955 1973 :subject => 'test_create', :estimated_hours => '1:30')
1956 1974 with_settings :notified_events => %w(issue_added issue_updated) do
1957 1975 assert issue.save
1958 1976 assert_equal 1, ActionMailer::Base.deliveries.size
1959 1977 end
1960 1978 end
1961 1979
1962 1980 def test_create_should_not_send_email_notification_with_no_setting
1963 1981 ActionMailer::Base.deliveries.clear
1964 1982 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1965 1983 :author_id => 3, :status_id => 1,
1966 1984 :priority => IssuePriority.all.first,
1967 1985 :subject => 'test_create', :estimated_hours => '1:30')
1968 1986 with_settings :notified_events => [] do
1969 1987 assert issue.save
1970 1988 assert_equal 0, ActionMailer::Base.deliveries.size
1971 1989 end
1972 1990 end
1973 1991
1974 1992 def test_update_should_notify_previous_assignee
1975 1993 ActionMailer::Base.deliveries.clear
1976 1994 user = User.find(3)
1977 1995 user.members.update_all ["mail_notification = ?", false]
1978 1996 user.update_attribute :mail_notification, 'only_assigned'
1979 1997
1980 1998 with_settings :notified_events => %w(issue_updated) do
1981 1999 issue = Issue.find(2)
1982 2000 issue.init_journal User.find(1)
1983 2001 issue.assigned_to = nil
1984 2002 issue.save!
1985 2003 assert_include user.mail, ActionMailer::Base.deliveries.last.bcc
1986 2004 end
1987 2005 end
1988 2006
1989 2007 def test_stale_issue_should_not_send_email_notification
1990 2008 ActionMailer::Base.deliveries.clear
1991 2009 issue = Issue.find(1)
1992 2010 stale = Issue.find(1)
1993 2011
1994 2012 issue.init_journal(User.find(1))
1995 2013 issue.subject = 'Subjet update'
1996 2014 with_settings :notified_events => %w(issue_updated) do
1997 2015 assert issue.save
1998 2016 assert_equal 1, ActionMailer::Base.deliveries.size
1999 2017 ActionMailer::Base.deliveries.clear
2000 2018
2001 2019 stale.init_journal(User.find(1))
2002 2020 stale.subject = 'Another subjet update'
2003 2021 assert_raise ActiveRecord::StaleObjectError do
2004 2022 stale.save
2005 2023 end
2006 2024 assert ActionMailer::Base.deliveries.empty?
2007 2025 end
2008 2026 end
2009 2027
2010 2028 def test_journalized_description
2011 2029 IssueCustomField.delete_all
2012 2030
2013 2031 i = Issue.first
2014 2032 old_description = i.description
2015 2033 new_description = "This is the new description"
2016 2034
2017 2035 i.init_journal(User.find(2))
2018 2036 i.description = new_description
2019 2037 assert_difference 'Journal.count', 1 do
2020 2038 assert_difference 'JournalDetail.count', 1 do
2021 2039 i.save!
2022 2040 end
2023 2041 end
2024 2042
2025 2043 detail = JournalDetail.order('id DESC').first
2026 2044 assert_equal i, detail.journal.journalized
2027 2045 assert_equal 'attr', detail.property
2028 2046 assert_equal 'description', detail.prop_key
2029 2047 assert_equal old_description, detail.old_value
2030 2048 assert_equal new_description, detail.value
2031 2049 end
2032 2050
2033 2051 def test_blank_descriptions_should_not_be_journalized
2034 2052 IssueCustomField.delete_all
2035 2053 Issue.where(:id => 1).update_all("description = NULL")
2036 2054
2037 2055 i = Issue.find(1)
2038 2056 i.init_journal(User.find(2))
2039 2057 i.subject = "blank description"
2040 2058 i.description = "\r\n"
2041 2059
2042 2060 assert_difference 'Journal.count', 1 do
2043 2061 assert_difference 'JournalDetail.count', 1 do
2044 2062 i.save!
2045 2063 end
2046 2064 end
2047 2065 end
2048 2066
2049 2067 def test_journalized_multi_custom_field
2050 2068 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
2051 2069 :is_filter => true, :is_for_all => true,
2052 2070 :tracker_ids => [1],
2053 2071 :possible_values => ['value1', 'value2', 'value3'],
2054 2072 :multiple => true)
2055 2073
2056 2074 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
2057 2075 :subject => 'Test', :author_id => 1)
2058 2076
2059 2077 assert_difference 'Journal.count' do
2060 2078 assert_difference 'JournalDetail.count' do
2061 2079 issue.init_journal(User.first)
2062 2080 issue.custom_field_values = {field.id => ['value1']}
2063 2081 issue.save!
2064 2082 end
2065 2083 assert_difference 'JournalDetail.count' do
2066 2084 issue.init_journal(User.first)
2067 2085 issue.custom_field_values = {field.id => ['value1', 'value2']}
2068 2086 issue.save!
2069 2087 end
2070 2088 assert_difference 'JournalDetail.count', 2 do
2071 2089 issue.init_journal(User.first)
2072 2090 issue.custom_field_values = {field.id => ['value3', 'value2']}
2073 2091 issue.save!
2074 2092 end
2075 2093 assert_difference 'JournalDetail.count', 2 do
2076 2094 issue.init_journal(User.first)
2077 2095 issue.custom_field_values = {field.id => nil}
2078 2096 issue.save!
2079 2097 end
2080 2098 end
2081 2099 end
2082 2100
2083 2101 def test_description_eol_should_be_normalized
2084 2102 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
2085 2103 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
2086 2104 end
2087 2105
2088 2106 def test_saving_twice_should_not_duplicate_journal_details
2089 2107 i = Issue.first
2090 2108 i.init_journal(User.find(2), 'Some notes')
2091 2109 # initial changes
2092 2110 i.subject = 'New subject'
2093 2111 i.done_ratio = i.done_ratio + 10
2094 2112 assert_difference 'Journal.count' do
2095 2113 assert i.save
2096 2114 end
2097 2115 # 1 more change
2098 2116 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
2099 2117 assert_no_difference 'Journal.count' do
2100 2118 assert_difference 'JournalDetail.count', 1 do
2101 2119 i.save
2102 2120 end
2103 2121 end
2104 2122 # no more change
2105 2123 assert_no_difference 'Journal.count' do
2106 2124 assert_no_difference 'JournalDetail.count' do
2107 2125 i.save
2108 2126 end
2109 2127 end
2110 2128 end
2111 2129
2112 2130 def test_all_dependent_issues
2113 2131 IssueRelation.delete_all
2114 2132 assert IssueRelation.create!(:issue_from => Issue.find(1),
2115 2133 :issue_to => Issue.find(2),
2116 2134 :relation_type => IssueRelation::TYPE_PRECEDES)
2117 2135 assert IssueRelation.create!(:issue_from => Issue.find(2),
2118 2136 :issue_to => Issue.find(3),
2119 2137 :relation_type => IssueRelation::TYPE_PRECEDES)
2120 2138 assert IssueRelation.create!(:issue_from => Issue.find(3),
2121 2139 :issue_to => Issue.find(8),
2122 2140 :relation_type => IssueRelation::TYPE_PRECEDES)
2123 2141
2124 2142 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
2125 2143 end
2126 2144
2127 2145 def test_all_dependent_issues_with_subtask
2128 2146 IssueRelation.delete_all
2129 2147
2130 2148 project = Project.generate!(:name => "testproject")
2131 2149
2132 2150 parentIssue = Issue.generate!(:project => project)
2133 2151 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2134 2152 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2135 2153
2136 2154 assert_equal [childIssue1.id, childIssue2.id].sort, parentIssue.all_dependent_issues.collect(&:id).uniq.sort
2137 2155 end
2138 2156
2139 2157 def test_all_dependent_issues_does_not_include_self
2140 2158 IssueRelation.delete_all
2141 2159
2142 2160 project = Project.generate!(:name => "testproject")
2143 2161
2144 2162 parentIssue = Issue.generate!(:project => project)
2145 2163 childIssue = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2146 2164
2147 2165 assert_equal [childIssue.id], parentIssue.all_dependent_issues.collect(&:id)
2148 2166 end
2149 2167
2150 2168 def test_all_dependent_issues_with_parenttask_and_sibling
2151 2169 IssueRelation.delete_all
2152 2170
2153 2171 project = Project.generate!(:name => "testproject")
2154 2172
2155 2173 parentIssue = Issue.generate!(:project => project)
2156 2174 childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2157 2175 childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
2158 2176
2159 2177 assert_equal [parentIssue.id].sort, childIssue1.all_dependent_issues.collect(&:id)
2160 2178 end
2161 2179
2162 2180 def test_all_dependent_issues_with_relation_to_leaf_in_other_tree
2163 2181 IssueRelation.delete_all
2164 2182
2165 2183 project = Project.generate!(:name => "testproject")
2166 2184
2167 2185 parentIssue1 = Issue.generate!(:project => project)
2168 2186 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2169 2187 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2170 2188
2171 2189 parentIssue2 = Issue.generate!(:project => project)
2172 2190 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2173 2191 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2174 2192
2175 2193
2176 2194 assert IssueRelation.create(:issue_from => parentIssue1,
2177 2195 :issue_to => childIssue2_2,
2178 2196 :relation_type => IssueRelation::TYPE_BLOCKS)
2179 2197
2180 2198 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_2.id].sort,
2181 2199 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
2182 2200 end
2183 2201
2184 2202 def test_all_dependent_issues_with_relation_to_parent_in_other_tree
2185 2203 IssueRelation.delete_all
2186 2204
2187 2205 project = Project.generate!(:name => "testproject")
2188 2206
2189 2207 parentIssue1 = Issue.generate!(:project => project)
2190 2208 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2191 2209 childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2192 2210
2193 2211 parentIssue2 = Issue.generate!(:project => project)
2194 2212 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2195 2213 childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2196 2214
2197 2215
2198 2216 assert IssueRelation.create(:issue_from => parentIssue1,
2199 2217 :issue_to => parentIssue2,
2200 2218 :relation_type => IssueRelation::TYPE_BLOCKS)
2201 2219
2202 2220 assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_1.id, childIssue2_2.id].sort,
2203 2221 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
2204 2222 end
2205 2223
2206 2224 def test_all_dependent_issues_with_transitive_relation
2207 2225 IssueRelation.delete_all
2208 2226
2209 2227 project = Project.generate!(:name => "testproject")
2210 2228
2211 2229 parentIssue1 = Issue.generate!(:project => project)
2212 2230 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2213 2231
2214 2232 parentIssue2 = Issue.generate!(:project => project)
2215 2233 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2216 2234
2217 2235 independentIssue = Issue.generate!(:project => project)
2218 2236
2219 2237 assert IssueRelation.create(:issue_from => parentIssue1,
2220 2238 :issue_to => childIssue2_1,
2221 2239 :relation_type => IssueRelation::TYPE_RELATES)
2222 2240
2223 2241 assert IssueRelation.create(:issue_from => childIssue2_1,
2224 2242 :issue_to => independentIssue,
2225 2243 :relation_type => IssueRelation::TYPE_RELATES)
2226 2244
2227 2245 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
2228 2246 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
2229 2247 end
2230 2248
2231 2249 def test_all_dependent_issues_with_transitive_relation2
2232 2250 IssueRelation.delete_all
2233 2251
2234 2252 project = Project.generate!(:name => "testproject")
2235 2253
2236 2254 parentIssue1 = Issue.generate!(:project => project)
2237 2255 childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
2238 2256
2239 2257 parentIssue2 = Issue.generate!(:project => project)
2240 2258 childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
2241 2259
2242 2260 independentIssue = Issue.generate!(:project => project)
2243 2261
2244 2262 assert IssueRelation.create(:issue_from => parentIssue1,
2245 2263 :issue_to => independentIssue,
2246 2264 :relation_type => IssueRelation::TYPE_RELATES)
2247 2265
2248 2266 assert IssueRelation.create(:issue_from => independentIssue,
2249 2267 :issue_to => childIssue2_1,
2250 2268 :relation_type => IssueRelation::TYPE_RELATES)
2251 2269
2252 2270 assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
2253 2271 parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
2254 2272
2255 2273 end
2256 2274
2257 2275 def test_all_dependent_issues_with_persistent_circular_dependency
2258 2276 IssueRelation.delete_all
2259 2277 assert IssueRelation.create!(:issue_from => Issue.find(1),
2260 2278 :issue_to => Issue.find(2),
2261 2279 :relation_type => IssueRelation::TYPE_PRECEDES)
2262 2280 assert IssueRelation.create!(:issue_from => Issue.find(2),
2263 2281 :issue_to => Issue.find(3),
2264 2282 :relation_type => IssueRelation::TYPE_PRECEDES)
2265 2283
2266 2284 r = IssueRelation.create!(:issue_from => Issue.find(3),
2267 2285 :issue_to => Issue.find(7),
2268 2286 :relation_type => IssueRelation::TYPE_PRECEDES)
2269 2287 IssueRelation.where(["id = ?", r.id]).update_all("issue_to_id = 1")
2270 2288
2271 2289 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
2272 2290 end
2273 2291
2274 2292 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
2275 2293 IssueRelation.delete_all
2276 2294 assert IssueRelation.create!(:issue_from => Issue.find(1),
2277 2295 :issue_to => Issue.find(2),
2278 2296 :relation_type => IssueRelation::TYPE_RELATES)
2279 2297 assert IssueRelation.create!(:issue_from => Issue.find(2),
2280 2298 :issue_to => Issue.find(3),
2281 2299 :relation_type => IssueRelation::TYPE_RELATES)
2282 2300 assert IssueRelation.create!(:issue_from => Issue.find(3),
2283 2301 :issue_to => Issue.find(8),
2284 2302 :relation_type => IssueRelation::TYPE_RELATES)
2285 2303
2286 2304 r = IssueRelation.create!(:issue_from => Issue.find(8),
2287 2305 :issue_to => Issue.find(7),
2288 2306 :relation_type => IssueRelation::TYPE_RELATES)
2289 2307 IssueRelation.where(["id = ?", r.id]).update_all("issue_to_id = 2")
2290 2308
2291 2309 r = IssueRelation.create!(:issue_from => Issue.find(3),
2292 2310 :issue_to => Issue.find(7),
2293 2311 :relation_type => IssueRelation::TYPE_RELATES)
2294 2312 IssueRelation.where(["id = ?", r.id]).update_all("issue_to_id = 1")
2295 2313
2296 2314 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
2297 2315 end
2298 2316
2299 2317 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
2300 2318 @issue = Issue.find(1)
2301 2319 @issue_status = IssueStatus.find(1)
2302 2320 @issue_status.update_attribute(:default_done_ratio, 50)
2303 2321 @issue2 = Issue.find(2)
2304 2322 @issue_status2 = IssueStatus.find(2)
2305 2323 @issue_status2.update_attribute(:default_done_ratio, 0)
2306 2324
2307 2325 with_settings :issue_done_ratio => 'issue_field' do
2308 2326 assert_equal 0, @issue.done_ratio
2309 2327 assert_equal 30, @issue2.done_ratio
2310 2328 end
2311 2329
2312 2330 with_settings :issue_done_ratio => 'issue_status' do
2313 2331 assert_equal 50, @issue.done_ratio
2314 2332 assert_equal 0, @issue2.done_ratio
2315 2333 end
2316 2334 end
2317 2335
2318 2336 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
2319 2337 @issue = Issue.find(1)
2320 2338 @issue_status = IssueStatus.find(1)
2321 2339 @issue_status.update_attribute(:default_done_ratio, 50)
2322 2340 @issue2 = Issue.find(2)
2323 2341 @issue_status2 = IssueStatus.find(2)
2324 2342 @issue_status2.update_attribute(:default_done_ratio, 0)
2325 2343
2326 2344 with_settings :issue_done_ratio => 'issue_field' do
2327 2345 @issue.update_done_ratio_from_issue_status
2328 2346 @issue2.update_done_ratio_from_issue_status
2329 2347
2330 2348 assert_equal 0, @issue.read_attribute(:done_ratio)
2331 2349 assert_equal 30, @issue2.read_attribute(:done_ratio)
2332 2350 end
2333 2351
2334 2352 with_settings :issue_done_ratio => 'issue_status' do
2335 2353 @issue.update_done_ratio_from_issue_status
2336 2354 @issue2.update_done_ratio_from_issue_status
2337 2355
2338 2356 assert_equal 50, @issue.read_attribute(:done_ratio)
2339 2357 assert_equal 0, @issue2.read_attribute(:done_ratio)
2340 2358 end
2341 2359 end
2342 2360
2343 2361 test "#by_tracker" do
2344 2362 User.current = User.anonymous
2345 2363 groups = Issue.by_tracker(Project.find(1))
2346 2364 assert_equal 3, groups.count
2347 2365 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2348 2366 end
2349 2367
2350 2368 test "#by_version" do
2351 2369 User.current = User.anonymous
2352 2370 groups = Issue.by_version(Project.find(1))
2353 2371 assert_equal 3, groups.count
2354 2372 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2355 2373 end
2356 2374
2357 2375 test "#by_priority" do
2358 2376 User.current = User.anonymous
2359 2377 groups = Issue.by_priority(Project.find(1))
2360 2378 assert_equal 4, groups.count
2361 2379 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2362 2380 end
2363 2381
2364 2382 test "#by_category" do
2365 2383 User.current = User.anonymous
2366 2384 groups = Issue.by_category(Project.find(1))
2367 2385 assert_equal 2, groups.count
2368 2386 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2369 2387 end
2370 2388
2371 2389 test "#by_assigned_to" do
2372 2390 User.current = User.anonymous
2373 2391 groups = Issue.by_assigned_to(Project.find(1))
2374 2392 assert_equal 2, groups.count
2375 2393 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2376 2394 end
2377 2395
2378 2396 test "#by_author" do
2379 2397 User.current = User.anonymous
2380 2398 groups = Issue.by_author(Project.find(1))
2381 2399 assert_equal 4, groups.count
2382 2400 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2383 2401 end
2384 2402
2385 2403 test "#by_subproject" do
2386 2404 User.current = User.anonymous
2387 2405 groups = Issue.by_subproject(Project.find(1))
2388 2406 # Private descendant not visible
2389 2407 assert_equal 1, groups.count
2390 2408 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2391 2409 end
2392 2410
2393 2411 def test_recently_updated_scope
2394 2412 #should return the last updated issue
2395 2413 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
2396 2414 end
2397 2415
2398 2416 def test_on_active_projects_scope
2399 2417 assert Project.find(2).archive
2400 2418
2401 2419 before = Issue.on_active_project.length
2402 2420 # test inclusion to results
2403 2421 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
2404 2422 assert_equal before + 1, Issue.on_active_project.length
2405 2423
2406 2424 # Move to an archived project
2407 2425 issue.project = Project.find(2)
2408 2426 assert issue.save
2409 2427 assert_equal before, Issue.on_active_project.length
2410 2428 end
2411 2429
2412 2430 test "Issue#recipients should include project recipients" do
2413 2431 issue = Issue.generate!
2414 2432 assert issue.project.recipients.present?
2415 2433 issue.project.recipients.each do |project_recipient|
2416 2434 assert issue.recipients.include?(project_recipient)
2417 2435 end
2418 2436 end
2419 2437
2420 2438 test "Issue#recipients should include the author if the author is active" do
2421 2439 issue = Issue.generate!(:author => User.generate!)
2422 2440 assert issue.author, "No author set for Issue"
2423 2441 assert issue.recipients.include?(issue.author.mail)
2424 2442 end
2425 2443
2426 2444 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
2427 2445 issue = Issue.generate!(:assigned_to => User.generate!)
2428 2446 assert issue.assigned_to, "No assigned_to set for Issue"
2429 2447 assert issue.recipients.include?(issue.assigned_to.mail)
2430 2448 end
2431 2449
2432 2450 test "Issue#recipients should not include users who opt out of all email" do
2433 2451 issue = Issue.generate!(:author => User.generate!)
2434 2452 issue.author.update_attribute(:mail_notification, :none)
2435 2453 assert !issue.recipients.include?(issue.author.mail)
2436 2454 end
2437 2455
2438 2456 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
2439 2457 issue = Issue.generate!(:author => User.generate!)
2440 2458 issue.author.update_attribute(:mail_notification, :only_assigned)
2441 2459 assert !issue.recipients.include?(issue.author.mail)
2442 2460 end
2443 2461
2444 2462 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
2445 2463 issue = Issue.generate!(:assigned_to => User.generate!)
2446 2464 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
2447 2465 assert !issue.recipients.include?(issue.assigned_to.mail)
2448 2466 end
2449 2467
2450 2468 def test_last_journal_id_with_journals_should_return_the_journal_id
2451 2469 assert_equal 2, Issue.find(1).last_journal_id
2452 2470 end
2453 2471
2454 2472 def test_last_journal_id_without_journals_should_return_nil
2455 2473 assert_nil Issue.find(3).last_journal_id
2456 2474 end
2457 2475
2458 2476 def test_journals_after_should_return_journals_with_greater_id
2459 2477 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
2460 2478 assert_equal [], Issue.find(1).journals_after('2')
2461 2479 end
2462 2480
2463 2481 def test_journals_after_with_blank_arg_should_return_all_journals
2464 2482 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
2465 2483 end
2466 2484
2467 2485 def test_css_classes_should_include_tracker
2468 2486 issue = Issue.new(:tracker => Tracker.find(2))
2469 2487 classes = issue.css_classes.split(' ')
2470 2488 assert_include 'tracker-2', classes
2471 2489 end
2472 2490
2473 2491 def test_css_classes_should_include_priority
2474 2492 issue = Issue.new(:priority => IssuePriority.find(8))
2475 2493 classes = issue.css_classes.split(' ')
2476 2494 assert_include 'priority-8', classes
2477 2495 assert_include 'priority-highest', classes
2478 2496 end
2479 2497
2480 2498 def test_css_classes_should_include_user_and_group_assignment
2481 2499 project = Project.first
2482 2500 user = User.generate!
2483 2501 group = Group.generate!
2484 2502 Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
2485 2503 group.users << user
2486 2504 assert user.member_of?(project)
2487 2505 issue1 = Issue.generate(:assigned_to_id => group.id)
2488 2506 assert_include 'assigned-to-my-group', issue1.css_classes(user)
2489 2507 assert_not_include 'assigned-to-me', issue1.css_classes(user)
2490 2508 issue2 = Issue.generate(:assigned_to_id => user.id)
2491 2509 assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
2492 2510 assert_include 'assigned-to-me', issue2.css_classes(user)
2493 2511 end
2494 2512
2495 2513 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
2496 2514 set_tmp_attachments_directory
2497 2515 issue = Issue.generate!
2498 2516 issue.save_attachments({
2499 2517 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
2500 2518 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
2501 2519 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
2502 2520 })
2503 2521 issue.attach_saved_attachments
2504 2522
2505 2523 assert_equal 3, issue.reload.attachments.count
2506 2524 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
2507 2525 end
2508 2526
2509 2527 def test_closed_on_should_be_nil_when_creating_an_open_issue
2510 2528 issue = Issue.generate!(:status_id => 1).reload
2511 2529 assert !issue.closed?
2512 2530 assert_nil issue.closed_on
2513 2531 end
2514 2532
2515 2533 def test_closed_on_should_be_set_when_creating_a_closed_issue
2516 2534 issue = Issue.generate!(:status_id => 5).reload
2517 2535 assert issue.closed?
2518 2536 assert_not_nil issue.closed_on
2519 2537 assert_equal issue.updated_on, issue.closed_on
2520 2538 assert_equal issue.created_on, issue.closed_on
2521 2539 end
2522 2540
2523 2541 def test_closed_on_should_be_nil_when_updating_an_open_issue
2524 2542 issue = Issue.find(1)
2525 2543 issue.subject = 'Not closed yet'
2526 2544 issue.save!
2527 2545 issue.reload
2528 2546 assert_nil issue.closed_on
2529 2547 end
2530 2548
2531 2549 def test_closed_on_should_be_set_when_closing_an_open_issue
2532 2550 issue = Issue.find(1)
2533 2551 issue.subject = 'Now closed'
2534 2552 issue.status_id = 5
2535 2553 issue.save!
2536 2554 issue.reload
2537 2555 assert_not_nil issue.closed_on
2538 2556 assert_equal issue.updated_on, issue.closed_on
2539 2557 end
2540 2558
2541 2559 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
2542 2560 issue = Issue.open(false).first
2543 2561 was_closed_on = issue.closed_on
2544 2562 assert_not_nil was_closed_on
2545 2563 issue.subject = 'Updating a closed issue'
2546 2564 issue.save!
2547 2565 issue.reload
2548 2566 assert_equal was_closed_on, issue.closed_on
2549 2567 end
2550 2568
2551 2569 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
2552 2570 issue = Issue.open(false).first
2553 2571 was_closed_on = issue.closed_on
2554 2572 assert_not_nil was_closed_on
2555 2573 issue.subject = 'Reopening a closed issue'
2556 2574 issue.status_id = 1
2557 2575 issue.save!
2558 2576 issue.reload
2559 2577 assert !issue.closed?
2560 2578 assert_equal was_closed_on, issue.closed_on
2561 2579 end
2562 2580
2563 2581 def test_status_was_should_return_nil_for_new_issue
2564 2582 issue = Issue.new
2565 2583 assert_nil issue.status_was
2566 2584 end
2567 2585
2568 2586 def test_status_was_should_return_status_before_change
2569 2587 issue = Issue.find(1)
2570 2588 issue.status = IssueStatus.find(2)
2571 2589 assert_equal IssueStatus.find(1), issue.status_was
2572 2590 end
2573 2591
2574 2592 def test_status_was_should_return_status_before_change_with_status_id
2575 2593 issue = Issue.find(1)
2576 2594 assert_equal IssueStatus.find(1), issue.status
2577 2595 issue.status_id = 2
2578 2596 assert_equal IssueStatus.find(1), issue.status_was
2579 2597 end
2580 2598
2581 2599 def test_status_was_should_be_reset_on_save
2582 2600 issue = Issue.find(1)
2583 2601 issue.status = IssueStatus.find(2)
2584 2602 assert_equal IssueStatus.find(1), issue.status_was
2585 2603 assert issue.save!
2586 2604 assert_equal IssueStatus.find(2), issue.status_was
2587 2605 end
2588 2606
2589 2607 def test_closing_should_return_true_when_closing_an_issue
2590 2608 issue = Issue.find(1)
2591 2609 issue.status = IssueStatus.find(2)
2592 2610 assert_equal false, issue.closing?
2593 2611 issue.status = IssueStatus.find(5)
2594 2612 assert_equal true, issue.closing?
2595 2613 end
2596 2614
2597 2615 def test_closing_should_return_true_when_closing_an_issue_with_status_id
2598 2616 issue = Issue.find(1)
2599 2617 issue.status_id = 2
2600 2618 assert_equal false, issue.closing?
2601 2619 issue.status_id = 5
2602 2620 assert_equal true, issue.closing?
2603 2621 end
2604 2622
2605 2623 def test_closing_should_return_true_for_new_closed_issue
2606 2624 issue = Issue.new
2607 2625 assert_equal false, issue.closing?
2608 2626 issue.status = IssueStatus.find(5)
2609 2627 assert_equal true, issue.closing?
2610 2628 end
2611 2629
2612 2630 def test_closing_should_return_true_for_new_closed_issue_with_status_id
2613 2631 issue = Issue.new
2614 2632 assert_equal false, issue.closing?
2615 2633 issue.status_id = 5
2616 2634 assert_equal true, issue.closing?
2617 2635 end
2618 2636
2619 2637 def test_closing_should_be_reset_after_save
2620 2638 issue = Issue.find(1)
2621 2639 issue.status_id = 5
2622 2640 assert_equal true, issue.closing?
2623 2641 issue.save!
2624 2642 assert_equal false, issue.closing?
2625 2643 end
2626 2644
2627 2645 def test_reopening_should_return_true_when_reopening_an_issue
2628 2646 issue = Issue.find(8)
2629 2647 issue.status = IssueStatus.find(6)
2630 2648 assert_equal false, issue.reopening?
2631 2649 issue.status = IssueStatus.find(2)
2632 2650 assert_equal true, issue.reopening?
2633 2651 end
2634 2652
2635 2653 def test_reopening_should_return_true_when_reopening_an_issue_with_status_id
2636 2654 issue = Issue.find(8)
2637 2655 issue.status_id = 6
2638 2656 assert_equal false, issue.reopening?
2639 2657 issue.status_id = 2
2640 2658 assert_equal true, issue.reopening?
2641 2659 end
2642 2660
2643 2661 def test_reopening_should_return_false_for_new_open_issue
2644 2662 issue = Issue.new
2645 2663 issue.status = IssueStatus.find(1)
2646 2664 assert_equal false, issue.reopening?
2647 2665 end
2648 2666
2649 2667 def test_reopening_should_be_reset_after_save
2650 2668 issue = Issue.find(8)
2651 2669 issue.status_id = 2
2652 2670 assert_equal true, issue.reopening?
2653 2671 issue.save!
2654 2672 assert_equal false, issue.reopening?
2655 2673 end
2656 2674
2657 2675 def test_default_status_without_tracker_should_be_nil
2658 2676 issue = Issue.new
2659 2677 assert_nil issue.tracker
2660 2678 assert_nil issue.default_status
2661 2679 end
2662 2680
2663 2681 def test_default_status_should_be_tracker_default_status
2664 2682 issue = Issue.new(:tracker_id => 1)
2665 2683 assert_not_nil issue.status
2666 2684 assert_equal issue.tracker.default_status, issue.default_status
2667 2685 end
2668 2686
2669 2687 def test_initializing_with_tracker_should_set_default_status
2670 2688 issue = Issue.new(:tracker => Tracker.find(1))
2671 2689 assert_not_nil issue.status
2672 2690 assert_equal issue.default_status, issue.status
2673 2691 end
2674 2692
2675 2693 def test_initializing_with_tracker_id_should_set_default_status
2676 2694 issue = Issue.new(:tracker_id => 1)
2677 2695 assert_not_nil issue.status
2678 2696 assert_equal issue.default_status, issue.status
2679 2697 end
2680 2698
2681 2699 def test_setting_tracker_should_set_default_status
2682 2700 issue = Issue.new
2683 2701 issue.tracker = Tracker.find(1)
2684 2702 assert_not_nil issue.status
2685 2703 assert_equal issue.default_status, issue.status
2686 2704 end
2687 2705
2688 2706 def test_changing_tracker_should_set_default_status_if_status_was_default
2689 2707 WorkflowTransition.delete_all
2690 2708 WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1
2691 2709 Tracker.find(2).update! :default_status_id => 2
2692 2710
2693 2711 issue = Issue.new(:tracker_id => 1, :status_id => 1)
2694 2712 assert_equal IssueStatus.find(1), issue.status
2695 2713 issue.tracker = Tracker.find(2)
2696 2714 assert_equal IssueStatus.find(2), issue.status
2697 2715 end
2698 2716
2699 2717 def test_changing_tracker_should_set_default_status_if_status_is_not_used_by_tracker
2700 2718 WorkflowTransition.delete_all
2701 2719 Tracker.find(2).update! :default_status_id => 2
2702 2720
2703 2721 issue = Issue.new(:tracker_id => 1, :status_id => 3)
2704 2722 assert_equal IssueStatus.find(3), issue.status
2705 2723 issue.tracker = Tracker.find(2)
2706 2724 assert_equal IssueStatus.find(2), issue.status
2707 2725 end
2708 2726
2709 2727 def test_changing_tracker_should_keep_status_if_status_was_not_default_and_is_used_by_tracker
2710 2728 WorkflowTransition.delete_all
2711 2729 WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3
2712 2730 Tracker.find(2).update! :default_status_id => 2
2713 2731
2714 2732 issue = Issue.new(:tracker_id => 1, :status_id => 3)
2715 2733 assert_equal IssueStatus.find(3), issue.status
2716 2734 issue.tracker = Tracker.find(2)
2717 2735 assert_equal IssueStatus.find(3), issue.status
2718 2736 end
2719 2737
2720 2738 def test_assigned_to_was_with_a_group
2721 2739 group = Group.find(10)
2722 2740
2723 2741 issue = Issue.generate!(:assigned_to => group)
2724 2742 issue.reload.assigned_to = nil
2725 2743 assert_equal group, issue.assigned_to_was
2726 2744 end
2727 2745 end
General Comments 0
You need to be logged in to leave comments. Login now