##// END OF EJS Templates
Fix handling multiple text parts in email (#13646)....
Jean-Philippe Lang -
r11604:9b7d312a0e66
parent child
Show More
@@ -0,0 +1,55
1 From JSmith@somenet.foo Fri Mar 22 08:30:28 2013
2 From: John Smith <JSmith@somenet.foo>
3 Content-Type: multipart/mixed; boundary="Apple-Mail=_33C8180A-B097-4B87-A925-441300BDB9C9"
4 Message-Id: <BB533668-3CC8-41CA-A951-0A5D8EA37FB0@somenet.foo>
5 Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\))
6 Subject: Test with multiple text parts
7 Date: Fri, 22 Mar 2013 17:30:20 +0200
8 To: redmine@somenet.foo
9 X-Mailer: Apple Mail (2.1503)
10
11
12
13 --Apple-Mail=_33C8180A-B097-4B87-A925-441300BDB9C9
14 Content-Transfer-Encoding: quoted-printable
15 Content-Type: text/plain;
16 charset=us-ascii
17
18 The first text part.
19
20 --Apple-Mail=_33C8180A-B097-4B87-A925-441300BDB9C9
21 Content-Disposition: inline;
22 filename=1st.pdf
23 Content-Type: application/pdf;
24 x-unix-mode=0644;
25 name="1st.pdf"
26 Content-Transfer-Encoding: base64
27
28 JVBERi0xLjMKJcTl8uXrp/Og0MTGCjQgMCBvYmoKPDwgL0xlbmd0aCA1IDAgUiAvRmlsdGVyIC9G
29
30 --Apple-Mail=_33C8180A-B097-4B87-A925-441300BDB9C9
31 Content-Transfer-Encoding: quoted-printable
32 Content-Type: text/plain;
33 charset=us-ascii
34
35 The second text part.
36
37 --Apple-Mail=_33C8180A-B097-4B87-A925-441300BDB9C9
38 Content-Disposition: inline;
39 filename=2nd.pdf
40 Content-Type: application/pdf;
41 x-unix-mode=0644;
42 name="2nd.pdf"
43 Content-Transfer-Encoding: base64
44
45 JVBERi0xLjMKJcTl8uXrp/Og0MTGCjQgMCBvYmoKPDwgL0xlbmd0aCA1IDAgUiAvRmlsdGVyIC9G
46
47
48 --Apple-Mail=_33C8180A-B097-4B87-A925-441300BDB9C9
49 Content-Transfer-Encoding: quoted-printable
50 Content-Type: text/plain;
51 charset=us-ascii
52
53 The third one.
54
55 --Apple-Mail=_33C8180A-B097-4B87-A925-441300BDB9C9--
@@ -1,501 +1,510
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class MailHandler < ActionMailer::Base
18 class MailHandler < ActionMailer::Base
19 include ActionView::Helpers::SanitizeHelper
19 include ActionView::Helpers::SanitizeHelper
20 include Redmine::I18n
20 include Redmine::I18n
21
21
22 class UnauthorizedAction < StandardError; end
22 class UnauthorizedAction < StandardError; end
23 class MissingInformation < StandardError; end
23 class MissingInformation < StandardError; end
24
24
25 attr_reader :email, :user
25 attr_reader :email, :user
26
26
27 def self.receive(email, options={})
27 def self.receive(email, options={})
28 @@handler_options = options.dup
28 @@handler_options = options.dup
29
29
30 @@handler_options[:issue] ||= {}
30 @@handler_options[:issue] ||= {}
31
31
32 if @@handler_options[:allow_override].is_a?(String)
32 if @@handler_options[:allow_override].is_a?(String)
33 @@handler_options[:allow_override] = @@handler_options[:allow_override].split(',').collect(&:strip)
33 @@handler_options[:allow_override] = @@handler_options[:allow_override].split(',').collect(&:strip)
34 end
34 end
35 @@handler_options[:allow_override] ||= []
35 @@handler_options[:allow_override] ||= []
36 # Project needs to be overridable if not specified
36 # Project needs to be overridable if not specified
37 @@handler_options[:allow_override] << 'project' unless @@handler_options[:issue].has_key?(:project)
37 @@handler_options[:allow_override] << 'project' unless @@handler_options[:issue].has_key?(:project)
38 # Status overridable by default
38 # Status overridable by default
39 @@handler_options[:allow_override] << 'status' unless @@handler_options[:issue].has_key?(:status)
39 @@handler_options[:allow_override] << 'status' unless @@handler_options[:issue].has_key?(:status)
40
40
41 @@handler_options[:no_account_notice] = (@@handler_options[:no_account_notice].to_s == '1')
41 @@handler_options[:no_account_notice] = (@@handler_options[:no_account_notice].to_s == '1')
42 @@handler_options[:no_notification] = (@@handler_options[:no_notification].to_s == '1')
42 @@handler_options[:no_notification] = (@@handler_options[:no_notification].to_s == '1')
43 @@handler_options[:no_permission_check] = (@@handler_options[:no_permission_check].to_s == '1')
43 @@handler_options[:no_permission_check] = (@@handler_options[:no_permission_check].to_s == '1')
44
44
45 email.force_encoding('ASCII-8BIT') if email.respond_to?(:force_encoding)
45 email.force_encoding('ASCII-8BIT') if email.respond_to?(:force_encoding)
46 super(email)
46 super(email)
47 end
47 end
48
48
49 # Extracts MailHandler options from environment variables
49 # Extracts MailHandler options from environment variables
50 # Use when receiving emails with rake tasks
50 # Use when receiving emails with rake tasks
51 def self.extract_options_from_env(env)
51 def self.extract_options_from_env(env)
52 options = {:issue => {}}
52 options = {:issue => {}}
53 %w(project status tracker category priority).each do |option|
53 %w(project status tracker category priority).each do |option|
54 options[:issue][option.to_sym] = env[option] if env[option]
54 options[:issue][option.to_sym] = env[option] if env[option]
55 end
55 end
56 %w(allow_override unknown_user no_permission_check no_account_notice default_group).each do |option|
56 %w(allow_override unknown_user no_permission_check no_account_notice default_group).each do |option|
57 options[option.to_sym] = env[option] if env[option]
57 options[option.to_sym] = env[option] if env[option]
58 end
58 end
59 options
59 options
60 end
60 end
61
61
62 def logger
62 def logger
63 Rails.logger
63 Rails.logger
64 end
64 end
65
65
66 cattr_accessor :ignored_emails_headers
66 cattr_accessor :ignored_emails_headers
67 @@ignored_emails_headers = {
67 @@ignored_emails_headers = {
68 'X-Auto-Response-Suppress' => 'oof',
68 'X-Auto-Response-Suppress' => 'oof',
69 'Auto-Submitted' => /^auto-/
69 'Auto-Submitted' => /^auto-/
70 }
70 }
71
71
72 # Processes incoming emails
72 # Processes incoming emails
73 # Returns the created object (eg. an issue, a message) or false
73 # Returns the created object (eg. an issue, a message) or false
74 def receive(email)
74 def receive(email)
75 @email = email
75 @email = email
76 sender_email = email.from.to_a.first.to_s.strip
76 sender_email = email.from.to_a.first.to_s.strip
77 # Ignore emails received from the application emission address to avoid hell cycles
77 # Ignore emails received from the application emission address to avoid hell cycles
78 if sender_email.downcase == Setting.mail_from.to_s.strip.downcase
78 if sender_email.downcase == Setting.mail_from.to_s.strip.downcase
79 if logger && logger.info
79 if logger && logger.info
80 logger.info "MailHandler: ignoring email from Redmine emission address [#{sender_email}]"
80 logger.info "MailHandler: ignoring email from Redmine emission address [#{sender_email}]"
81 end
81 end
82 return false
82 return false
83 end
83 end
84 # Ignore auto generated emails
84 # Ignore auto generated emails
85 self.class.ignored_emails_headers.each do |key, ignored_value|
85 self.class.ignored_emails_headers.each do |key, ignored_value|
86 value = email.header[key]
86 value = email.header[key]
87 if value
87 if value
88 value = value.to_s.downcase
88 value = value.to_s.downcase
89 if (ignored_value.is_a?(Regexp) && value.match(ignored_value)) || value == ignored_value
89 if (ignored_value.is_a?(Regexp) && value.match(ignored_value)) || value == ignored_value
90 if logger && logger.info
90 if logger && logger.info
91 logger.info "MailHandler: ignoring email with #{key}:#{value} header"
91 logger.info "MailHandler: ignoring email with #{key}:#{value} header"
92 end
92 end
93 return false
93 return false
94 end
94 end
95 end
95 end
96 end
96 end
97 @user = User.find_by_mail(sender_email) if sender_email.present?
97 @user = User.find_by_mail(sender_email) if sender_email.present?
98 if @user && !@user.active?
98 if @user && !@user.active?
99 if logger && logger.info
99 if logger && logger.info
100 logger.info "MailHandler: ignoring email from non-active user [#{@user.login}]"
100 logger.info "MailHandler: ignoring email from non-active user [#{@user.login}]"
101 end
101 end
102 return false
102 return false
103 end
103 end
104 if @user.nil?
104 if @user.nil?
105 # Email was submitted by an unknown user
105 # Email was submitted by an unknown user
106 case @@handler_options[:unknown_user]
106 case @@handler_options[:unknown_user]
107 when 'accept'
107 when 'accept'
108 @user = User.anonymous
108 @user = User.anonymous
109 when 'create'
109 when 'create'
110 @user = create_user_from_email
110 @user = create_user_from_email
111 if @user
111 if @user
112 if logger && logger.info
112 if logger && logger.info
113 logger.info "MailHandler: [#{@user.login}] account created"
113 logger.info "MailHandler: [#{@user.login}] account created"
114 end
114 end
115 add_user_to_group(@@handler_options[:default_group])
115 add_user_to_group(@@handler_options[:default_group])
116 unless @@handler_options[:no_account_notice]
116 unless @@handler_options[:no_account_notice]
117 Mailer.account_information(@user, @user.password).deliver
117 Mailer.account_information(@user, @user.password).deliver
118 end
118 end
119 else
119 else
120 if logger && logger.error
120 if logger && logger.error
121 logger.error "MailHandler: could not create account for [#{sender_email}]"
121 logger.error "MailHandler: could not create account for [#{sender_email}]"
122 end
122 end
123 return false
123 return false
124 end
124 end
125 else
125 else
126 # Default behaviour, emails from unknown users are ignored
126 # Default behaviour, emails from unknown users are ignored
127 if logger && logger.info
127 if logger && logger.info
128 logger.info "MailHandler: ignoring email from unknown user [#{sender_email}]"
128 logger.info "MailHandler: ignoring email from unknown user [#{sender_email}]"
129 end
129 end
130 return false
130 return false
131 end
131 end
132 end
132 end
133 User.current = @user
133 User.current = @user
134 dispatch
134 dispatch
135 end
135 end
136
136
137 private
137 private
138
138
139 MESSAGE_ID_RE = %r{^<?redmine\.([a-z0-9_]+)\-(\d+)\.\d+@}
139 MESSAGE_ID_RE = %r{^<?redmine\.([a-z0-9_]+)\-(\d+)\.\d+@}
140 ISSUE_REPLY_SUBJECT_RE = %r{\[[^\]]*#(\d+)\]}
140 ISSUE_REPLY_SUBJECT_RE = %r{\[[^\]]*#(\d+)\]}
141 MESSAGE_REPLY_SUBJECT_RE = %r{\[[^\]]*msg(\d+)\]}
141 MESSAGE_REPLY_SUBJECT_RE = %r{\[[^\]]*msg(\d+)\]}
142
142
143 def dispatch
143 def dispatch
144 headers = [email.in_reply_to, email.references].flatten.compact
144 headers = [email.in_reply_to, email.references].flatten.compact
145 subject = email.subject.to_s
145 subject = email.subject.to_s
146 if headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
146 if headers.detect {|h| h.to_s =~ MESSAGE_ID_RE}
147 klass, object_id = $1, $2.to_i
147 klass, object_id = $1, $2.to_i
148 method_name = "receive_#{klass}_reply"
148 method_name = "receive_#{klass}_reply"
149 if self.class.private_instance_methods.collect(&:to_s).include?(method_name)
149 if self.class.private_instance_methods.collect(&:to_s).include?(method_name)
150 send method_name, object_id
150 send method_name, object_id
151 else
151 else
152 # ignoring it
152 # ignoring it
153 end
153 end
154 elsif m = subject.match(ISSUE_REPLY_SUBJECT_RE)
154 elsif m = subject.match(ISSUE_REPLY_SUBJECT_RE)
155 receive_issue_reply(m[1].to_i)
155 receive_issue_reply(m[1].to_i)
156 elsif m = subject.match(MESSAGE_REPLY_SUBJECT_RE)
156 elsif m = subject.match(MESSAGE_REPLY_SUBJECT_RE)
157 receive_message_reply(m[1].to_i)
157 receive_message_reply(m[1].to_i)
158 else
158 else
159 dispatch_to_default
159 dispatch_to_default
160 end
160 end
161 rescue ActiveRecord::RecordInvalid => e
161 rescue ActiveRecord::RecordInvalid => e
162 # TODO: send a email to the user
162 # TODO: send a email to the user
163 logger.error e.message if logger
163 logger.error e.message if logger
164 false
164 false
165 rescue MissingInformation => e
165 rescue MissingInformation => e
166 logger.error "MailHandler: missing information from #{user}: #{e.message}" if logger
166 logger.error "MailHandler: missing information from #{user}: #{e.message}" if logger
167 false
167 false
168 rescue UnauthorizedAction => e
168 rescue UnauthorizedAction => e
169 logger.error "MailHandler: unauthorized attempt from #{user}" if logger
169 logger.error "MailHandler: unauthorized attempt from #{user}" if logger
170 false
170 false
171 end
171 end
172
172
173 def dispatch_to_default
173 def dispatch_to_default
174 receive_issue
174 receive_issue
175 end
175 end
176
176
177 # Creates a new issue
177 # Creates a new issue
178 def receive_issue
178 def receive_issue
179 project = target_project
179 project = target_project
180 # check permission
180 # check permission
181 unless @@handler_options[:no_permission_check]
181 unless @@handler_options[:no_permission_check]
182 raise UnauthorizedAction unless user.allowed_to?(:add_issues, project)
182 raise UnauthorizedAction unless user.allowed_to?(:add_issues, project)
183 end
183 end
184
184
185 issue = Issue.new(:author => user, :project => project)
185 issue = Issue.new(:author => user, :project => project)
186 issue.safe_attributes = issue_attributes_from_keywords(issue)
186 issue.safe_attributes = issue_attributes_from_keywords(issue)
187 issue.safe_attributes = {'custom_field_values' => custom_field_values_from_keywords(issue)}
187 issue.safe_attributes = {'custom_field_values' => custom_field_values_from_keywords(issue)}
188 issue.subject = cleaned_up_subject
188 issue.subject = cleaned_up_subject
189 if issue.subject.blank?
189 if issue.subject.blank?
190 issue.subject = '(no subject)'
190 issue.subject = '(no subject)'
191 end
191 end
192 issue.description = cleaned_up_text_body
192 issue.description = cleaned_up_text_body
193
193
194 # add To and Cc as watchers before saving so the watchers can reply to Redmine
194 # add To and Cc as watchers before saving so the watchers can reply to Redmine
195 add_watchers(issue)
195 add_watchers(issue)
196 issue.save!
196 issue.save!
197 add_attachments(issue)
197 add_attachments(issue)
198 logger.info "MailHandler: issue ##{issue.id} created by #{user}" if logger && logger.info
198 logger.info "MailHandler: issue ##{issue.id} created by #{user}" if logger && logger.info
199 issue
199 issue
200 end
200 end
201
201
202 # Adds a note to an existing issue
202 # Adds a note to an existing issue
203 def receive_issue_reply(issue_id, from_journal=nil)
203 def receive_issue_reply(issue_id, from_journal=nil)
204 issue = Issue.find_by_id(issue_id)
204 issue = Issue.find_by_id(issue_id)
205 return unless issue
205 return unless issue
206 # check permission
206 # check permission
207 unless @@handler_options[:no_permission_check]
207 unless @@handler_options[:no_permission_check]
208 unless user.allowed_to?(:add_issue_notes, issue.project) ||
208 unless user.allowed_to?(:add_issue_notes, issue.project) ||
209 user.allowed_to?(:edit_issues, issue.project)
209 user.allowed_to?(:edit_issues, issue.project)
210 raise UnauthorizedAction
210 raise UnauthorizedAction
211 end
211 end
212 end
212 end
213
213
214 # ignore CLI-supplied defaults for new issues
214 # ignore CLI-supplied defaults for new issues
215 @@handler_options[:issue].clear
215 @@handler_options[:issue].clear
216
216
217 journal = issue.init_journal(user)
217 journal = issue.init_journal(user)
218 if from_journal && from_journal.private_notes?
218 if from_journal && from_journal.private_notes?
219 # If the received email was a reply to a private note, make the added note private
219 # If the received email was a reply to a private note, make the added note private
220 issue.private_notes = true
220 issue.private_notes = true
221 end
221 end
222 issue.safe_attributes = issue_attributes_from_keywords(issue)
222 issue.safe_attributes = issue_attributes_from_keywords(issue)
223 issue.safe_attributes = {'custom_field_values' => custom_field_values_from_keywords(issue)}
223 issue.safe_attributes = {'custom_field_values' => custom_field_values_from_keywords(issue)}
224 journal.notes = cleaned_up_text_body
224 journal.notes = cleaned_up_text_body
225 add_attachments(issue)
225 add_attachments(issue)
226 issue.save!
226 issue.save!
227 if logger && logger.info
227 if logger && logger.info
228 logger.info "MailHandler: issue ##{issue.id} updated by #{user}"
228 logger.info "MailHandler: issue ##{issue.id} updated by #{user}"
229 end
229 end
230 journal
230 journal
231 end
231 end
232
232
233 # Reply will be added to the issue
233 # Reply will be added to the issue
234 def receive_journal_reply(journal_id)
234 def receive_journal_reply(journal_id)
235 journal = Journal.find_by_id(journal_id)
235 journal = Journal.find_by_id(journal_id)
236 if journal && journal.journalized_type == 'Issue'
236 if journal && journal.journalized_type == 'Issue'
237 receive_issue_reply(journal.journalized_id, journal)
237 receive_issue_reply(journal.journalized_id, journal)
238 end
238 end
239 end
239 end
240
240
241 # Receives a reply to a forum message
241 # Receives a reply to a forum message
242 def receive_message_reply(message_id)
242 def receive_message_reply(message_id)
243 message = Message.find_by_id(message_id)
243 message = Message.find_by_id(message_id)
244 if message
244 if message
245 message = message.root
245 message = message.root
246
246
247 unless @@handler_options[:no_permission_check]
247 unless @@handler_options[:no_permission_check]
248 raise UnauthorizedAction unless user.allowed_to?(:add_messages, message.project)
248 raise UnauthorizedAction unless user.allowed_to?(:add_messages, message.project)
249 end
249 end
250
250
251 if !message.locked?
251 if !message.locked?
252 reply = Message.new(:subject => cleaned_up_subject.gsub(%r{^.*msg\d+\]}, '').strip,
252 reply = Message.new(:subject => cleaned_up_subject.gsub(%r{^.*msg\d+\]}, '').strip,
253 :content => cleaned_up_text_body)
253 :content => cleaned_up_text_body)
254 reply.author = user
254 reply.author = user
255 reply.board = message.board
255 reply.board = message.board
256 message.children << reply
256 message.children << reply
257 add_attachments(reply)
257 add_attachments(reply)
258 reply
258 reply
259 else
259 else
260 if logger && logger.info
260 if logger && logger.info
261 logger.info "MailHandler: ignoring reply from [#{sender_email}] to a locked topic"
261 logger.info "MailHandler: ignoring reply from [#{sender_email}] to a locked topic"
262 end
262 end
263 end
263 end
264 end
264 end
265 end
265 end
266
266
267 def add_attachments(obj)
267 def add_attachments(obj)
268 if email.attachments && email.attachments.any?
268 if email.attachments && email.attachments.any?
269 email.attachments.each do |attachment|
269 email.attachments.each do |attachment|
270 obj.attachments << Attachment.create(:container => obj,
270 obj.attachments << Attachment.create(:container => obj,
271 :file => attachment.decoded,
271 :file => attachment.decoded,
272 :filename => attachment.filename,
272 :filename => attachment.filename,
273 :author => user,
273 :author => user,
274 :content_type => attachment.mime_type)
274 :content_type => attachment.mime_type)
275 end
275 end
276 end
276 end
277 end
277 end
278
278
279 # Adds To and Cc as watchers of the given object if the sender has the
279 # Adds To and Cc as watchers of the given object if the sender has the
280 # appropriate permission
280 # appropriate permission
281 def add_watchers(obj)
281 def add_watchers(obj)
282 if user.allowed_to?("add_#{obj.class.name.underscore}_watchers".to_sym, obj.project)
282 if user.allowed_to?("add_#{obj.class.name.underscore}_watchers".to_sym, obj.project)
283 addresses = [email.to, email.cc].flatten.compact.uniq.collect {|a| a.strip.downcase}
283 addresses = [email.to, email.cc].flatten.compact.uniq.collect {|a| a.strip.downcase}
284 unless addresses.empty?
284 unless addresses.empty?
285 watchers = User.active.where('LOWER(mail) IN (?)', addresses).all
285 watchers = User.active.where('LOWER(mail) IN (?)', addresses).all
286 watchers.each {|w| obj.add_watcher(w)}
286 watchers.each {|w| obj.add_watcher(w)}
287 end
287 end
288 end
288 end
289 end
289 end
290
290
291 def get_keyword(attr, options={})
291 def get_keyword(attr, options={})
292 @keywords ||= {}
292 @keywords ||= {}
293 if @keywords.has_key?(attr)
293 if @keywords.has_key?(attr)
294 @keywords[attr]
294 @keywords[attr]
295 else
295 else
296 @keywords[attr] = begin
296 @keywords[attr] = begin
297 if (options[:override] || @@handler_options[:allow_override].include?(attr.to_s)) &&
297 if (options[:override] || @@handler_options[:allow_override].include?(attr.to_s)) &&
298 (v = extract_keyword!(plain_text_body, attr, options[:format]))
298 (v = extract_keyword!(plain_text_body, attr, options[:format]))
299 v
299 v
300 elsif !@@handler_options[:issue][attr].blank?
300 elsif !@@handler_options[:issue][attr].blank?
301 @@handler_options[:issue][attr]
301 @@handler_options[:issue][attr]
302 end
302 end
303 end
303 end
304 end
304 end
305 end
305 end
306
306
307 # Destructively extracts the value for +attr+ in +text+
307 # Destructively extracts the value for +attr+ in +text+
308 # Returns nil if no matching keyword found
308 # Returns nil if no matching keyword found
309 def extract_keyword!(text, attr, format=nil)
309 def extract_keyword!(text, attr, format=nil)
310 keys = [attr.to_s.humanize]
310 keys = [attr.to_s.humanize]
311 if attr.is_a?(Symbol)
311 if attr.is_a?(Symbol)
312 if user && user.language.present?
312 if user && user.language.present?
313 keys << l("field_#{attr}", :default => '', :locale => user.language)
313 keys << l("field_#{attr}", :default => '', :locale => user.language)
314 end
314 end
315 if Setting.default_language.present?
315 if Setting.default_language.present?
316 keys << l("field_#{attr}", :default => '', :locale => Setting.default_language)
316 keys << l("field_#{attr}", :default => '', :locale => Setting.default_language)
317 end
317 end
318 end
318 end
319 keys.reject! {|k| k.blank?}
319 keys.reject! {|k| k.blank?}
320 keys.collect! {|k| Regexp.escape(k)}
320 keys.collect! {|k| Regexp.escape(k)}
321 format ||= '.+'
321 format ||= '.+'
322 keyword = nil
322 keyword = nil
323 regexp = /^(#{keys.join('|')})[ \t]*:[ \t]*(#{format})\s*$/i
323 regexp = /^(#{keys.join('|')})[ \t]*:[ \t]*(#{format})\s*$/i
324 if m = text.match(regexp)
324 if m = text.match(regexp)
325 keyword = m[2].strip
325 keyword = m[2].strip
326 text.gsub!(regexp, '')
326 text.gsub!(regexp, '')
327 end
327 end
328 keyword
328 keyword
329 end
329 end
330
330
331 def target_project
331 def target_project
332 # TODO: other ways to specify project:
332 # TODO: other ways to specify project:
333 # * parse the email To field
333 # * parse the email To field
334 # * specific project (eg. Setting.mail_handler_target_project)
334 # * specific project (eg. Setting.mail_handler_target_project)
335 target = Project.find_by_identifier(get_keyword(:project))
335 target = Project.find_by_identifier(get_keyword(:project))
336 raise MissingInformation.new('Unable to determine target project') if target.nil?
336 raise MissingInformation.new('Unable to determine target project') if target.nil?
337 target
337 target
338 end
338 end
339
339
340 # Returns a Hash of issue attributes extracted from keywords in the email body
340 # Returns a Hash of issue attributes extracted from keywords in the email body
341 def issue_attributes_from_keywords(issue)
341 def issue_attributes_from_keywords(issue)
342 assigned_to = (k = get_keyword(:assigned_to, :override => true)) && find_assignee_from_keyword(k, issue)
342 assigned_to = (k = get_keyword(:assigned_to, :override => true)) && find_assignee_from_keyword(k, issue)
343
343
344 attrs = {
344 attrs = {
345 'tracker_id' => (k = get_keyword(:tracker)) && issue.project.trackers.named(k).first.try(:id),
345 'tracker_id' => (k = get_keyword(:tracker)) && issue.project.trackers.named(k).first.try(:id),
346 'status_id' => (k = get_keyword(:status)) && IssueStatus.named(k).first.try(:id),
346 'status_id' => (k = get_keyword(:status)) && IssueStatus.named(k).first.try(:id),
347 'priority_id' => (k = get_keyword(:priority)) && IssuePriority.named(k).first.try(:id),
347 'priority_id' => (k = get_keyword(:priority)) && IssuePriority.named(k).first.try(:id),
348 'category_id' => (k = get_keyword(:category)) && issue.project.issue_categories.named(k).first.try(:id),
348 'category_id' => (k = get_keyword(:category)) && issue.project.issue_categories.named(k).first.try(:id),
349 'assigned_to_id' => assigned_to.try(:id),
349 'assigned_to_id' => assigned_to.try(:id),
350 'fixed_version_id' => (k = get_keyword(:fixed_version, :override => true)) &&
350 'fixed_version_id' => (k = get_keyword(:fixed_version, :override => true)) &&
351 issue.project.shared_versions.named(k).first.try(:id),
351 issue.project.shared_versions.named(k).first.try(:id),
352 'start_date' => get_keyword(:start_date, :override => true, :format => '\d{4}-\d{2}-\d{2}'),
352 'start_date' => get_keyword(:start_date, :override => true, :format => '\d{4}-\d{2}-\d{2}'),
353 'due_date' => get_keyword(:due_date, :override => true, :format => '\d{4}-\d{2}-\d{2}'),
353 'due_date' => get_keyword(:due_date, :override => true, :format => '\d{4}-\d{2}-\d{2}'),
354 'estimated_hours' => get_keyword(:estimated_hours, :override => true),
354 'estimated_hours' => get_keyword(:estimated_hours, :override => true),
355 'done_ratio' => get_keyword(:done_ratio, :override => true, :format => '(\d|10)?0')
355 'done_ratio' => get_keyword(:done_ratio, :override => true, :format => '(\d|10)?0')
356 }.delete_if {|k, v| v.blank? }
356 }.delete_if {|k, v| v.blank? }
357
357
358 if issue.new_record? && attrs['tracker_id'].nil?
358 if issue.new_record? && attrs['tracker_id'].nil?
359 attrs['tracker_id'] = issue.project.trackers.first.try(:id)
359 attrs['tracker_id'] = issue.project.trackers.first.try(:id)
360 end
360 end
361
361
362 attrs
362 attrs
363 end
363 end
364
364
365 # Returns a Hash of issue custom field values extracted from keywords in the email body
365 # Returns a Hash of issue custom field values extracted from keywords in the email body
366 def custom_field_values_from_keywords(customized)
366 def custom_field_values_from_keywords(customized)
367 customized.custom_field_values.inject({}) do |h, v|
367 customized.custom_field_values.inject({}) do |h, v|
368 if keyword = get_keyword(v.custom_field.name, :override => true)
368 if keyword = get_keyword(v.custom_field.name, :override => true)
369 h[v.custom_field.id.to_s] = v.custom_field.value_from_keyword(keyword, customized)
369 h[v.custom_field.id.to_s] = v.custom_field.value_from_keyword(keyword, customized)
370 end
370 end
371 h
371 h
372 end
372 end
373 end
373 end
374
374
375 # Returns the text/plain part of the email
375 # Returns the text/plain part of the email
376 # If not found (eg. HTML-only email), returns the body with tags removed
376 # If not found (eg. HTML-only email), returns the body with tags removed
377 def plain_text_body
377 def plain_text_body
378 return @plain_text_body unless @plain_text_body.nil?
378 return @plain_text_body unless @plain_text_body.nil?
379
379
380 part = email.text_part || email.html_part || email
380 parts = if (text_parts = email.all_parts.select {|p| p.mime_type == 'text/plain'}).present?
381 @plain_text_body = Redmine::CodesetUtil.to_utf8(part.body.decoded, part.charset)
381 text_parts
382 elsif (html_parts = email.all_parts.select {|p| p.mime_type == 'text/html'}).present?
383 html_parts
384 else
385 [email]
386 end
387 @plain_text_body = parts.map {|p| Redmine::CodesetUtil.to_utf8(p.body.decoded, p.charset)}.join("\r\n")
382
388
383 # strip html tags and remove doctype directive
389 # strip html tags and remove doctype directive
384 @plain_text_body = strip_tags(@plain_text_body.strip)
390 if parts.any? {|p| p.mime_type == 'text/html'}
385 @plain_text_body.sub! %r{^<!DOCTYPE .*$}, ''
391 @plain_text_body = strip_tags(@plain_text_body.strip)
392 @plain_text_body.sub! %r{^<!DOCTYPE .*$}, ''
393 end
394
386 @plain_text_body
395 @plain_text_body
387 end
396 end
388
397
389 def cleaned_up_text_body
398 def cleaned_up_text_body
390 cleanup_body(plain_text_body)
399 cleanup_body(plain_text_body)
391 end
400 end
392
401
393 def cleaned_up_subject
402 def cleaned_up_subject
394 subject = email.subject.to_s
403 subject = email.subject.to_s
395 subject.strip[0,255]
404 subject.strip[0,255]
396 end
405 end
397
406
398 def self.full_sanitizer
407 def self.full_sanitizer
399 @full_sanitizer ||= HTML::FullSanitizer.new
408 @full_sanitizer ||= HTML::FullSanitizer.new
400 end
409 end
401
410
402 def self.assign_string_attribute_with_limit(object, attribute, value, limit=nil)
411 def self.assign_string_attribute_with_limit(object, attribute, value, limit=nil)
403 limit ||= object.class.columns_hash[attribute.to_s].limit || 255
412 limit ||= object.class.columns_hash[attribute.to_s].limit || 255
404 value = value.to_s.slice(0, limit)
413 value = value.to_s.slice(0, limit)
405 object.send("#{attribute}=", value)
414 object.send("#{attribute}=", value)
406 end
415 end
407
416
408 # Returns a User from an email address and a full name
417 # Returns a User from an email address and a full name
409 def self.new_user_from_attributes(email_address, fullname=nil)
418 def self.new_user_from_attributes(email_address, fullname=nil)
410 user = User.new
419 user = User.new
411
420
412 # Truncating the email address would result in an invalid format
421 # Truncating the email address would result in an invalid format
413 user.mail = email_address
422 user.mail = email_address
414 assign_string_attribute_with_limit(user, 'login', email_address, User::LOGIN_LENGTH_LIMIT)
423 assign_string_attribute_with_limit(user, 'login', email_address, User::LOGIN_LENGTH_LIMIT)
415
424
416 names = fullname.blank? ? email_address.gsub(/@.*$/, '').split('.') : fullname.split
425 names = fullname.blank? ? email_address.gsub(/@.*$/, '').split('.') : fullname.split
417 assign_string_attribute_with_limit(user, 'firstname', names.shift, 30)
426 assign_string_attribute_with_limit(user, 'firstname', names.shift, 30)
418 assign_string_attribute_with_limit(user, 'lastname', names.join(' '), 30)
427 assign_string_attribute_with_limit(user, 'lastname', names.join(' '), 30)
419 user.lastname = '-' if user.lastname.blank?
428 user.lastname = '-' if user.lastname.blank?
420 user.language = Setting.default_language
429 user.language = Setting.default_language
421 user.generate_password = true
430 user.generate_password = true
422 user.mail_notification = 'only_my_events'
431 user.mail_notification = 'only_my_events'
423
432
424 unless user.valid?
433 unless user.valid?
425 user.login = "user#{Redmine::Utils.random_hex(6)}" unless user.errors[:login].blank?
434 user.login = "user#{Redmine::Utils.random_hex(6)}" unless user.errors[:login].blank?
426 user.firstname = "-" unless user.errors[:firstname].blank?
435 user.firstname = "-" unless user.errors[:firstname].blank?
427 (puts user.errors[:lastname];user.lastname = "-") unless user.errors[:lastname].blank?
436 (puts user.errors[:lastname];user.lastname = "-") unless user.errors[:lastname].blank?
428 end
437 end
429
438
430 user
439 user
431 end
440 end
432
441
433 # Creates a User for the +email+ sender
442 # Creates a User for the +email+ sender
434 # Returns the user or nil if it could not be created
443 # Returns the user or nil if it could not be created
435 def create_user_from_email
444 def create_user_from_email
436 from = email.header['from'].to_s
445 from = email.header['from'].to_s
437 addr, name = from, nil
446 addr, name = from, nil
438 if m = from.match(/^"?(.+?)"?\s+<(.+@.+)>$/)
447 if m = from.match(/^"?(.+?)"?\s+<(.+@.+)>$/)
439 addr, name = m[2], m[1]
448 addr, name = m[2], m[1]
440 end
449 end
441 if addr.present?
450 if addr.present?
442 user = self.class.new_user_from_attributes(addr, name)
451 user = self.class.new_user_from_attributes(addr, name)
443 if @@handler_options[:no_notification]
452 if @@handler_options[:no_notification]
444 user.mail_notification = 'none'
453 user.mail_notification = 'none'
445 end
454 end
446 if user.save
455 if user.save
447 user
456 user
448 else
457 else
449 logger.error "MailHandler: failed to create User: #{user.errors.full_messages}" if logger
458 logger.error "MailHandler: failed to create User: #{user.errors.full_messages}" if logger
450 nil
459 nil
451 end
460 end
452 else
461 else
453 logger.error "MailHandler: failed to create User: no FROM address found" if logger
462 logger.error "MailHandler: failed to create User: no FROM address found" if logger
454 nil
463 nil
455 end
464 end
456 end
465 end
457
466
458 # Adds the newly created user to default group
467 # Adds the newly created user to default group
459 def add_user_to_group(default_group)
468 def add_user_to_group(default_group)
460 if default_group.present?
469 if default_group.present?
461 default_group.split(',').each do |group_name|
470 default_group.split(',').each do |group_name|
462 if group = Group.named(group_name).first
471 if group = Group.named(group_name).first
463 group.users << @user
472 group.users << @user
464 elsif logger
473 elsif logger
465 logger.warn "MailHandler: could not add user to [#{group_name}], group not found"
474 logger.warn "MailHandler: could not add user to [#{group_name}], group not found"
466 end
475 end
467 end
476 end
468 end
477 end
469 end
478 end
470
479
471 # Removes the email body of text after the truncation configurations.
480 # Removes the email body of text after the truncation configurations.
472 def cleanup_body(body)
481 def cleanup_body(body)
473 delimiters = Setting.mail_handler_body_delimiters.to_s.split(/[\r\n]+/).reject(&:blank?).map {|s| Regexp.escape(s)}
482 delimiters = Setting.mail_handler_body_delimiters.to_s.split(/[\r\n]+/).reject(&:blank?).map {|s| Regexp.escape(s)}
474 unless delimiters.empty?
483 unless delimiters.empty?
475 regex = Regexp.new("^[> ]*(#{ delimiters.join('|') })\s*[\r\n].*", Regexp::MULTILINE)
484 regex = Regexp.new("^[> ]*(#{ delimiters.join('|') })\s*[\r\n].*", Regexp::MULTILINE)
476 body = body.gsub(regex, '')
485 body = body.gsub(regex, '')
477 end
486 end
478 body.strip
487 body.strip
479 end
488 end
480
489
481 def find_assignee_from_keyword(keyword, issue)
490 def find_assignee_from_keyword(keyword, issue)
482 keyword = keyword.to_s.downcase
491 keyword = keyword.to_s.downcase
483 assignable = issue.assignable_users
492 assignable = issue.assignable_users
484 assignee = nil
493 assignee = nil
485 assignee ||= assignable.detect {|a|
494 assignee ||= assignable.detect {|a|
486 a.mail.to_s.downcase == keyword ||
495 a.mail.to_s.downcase == keyword ||
487 a.login.to_s.downcase == keyword
496 a.login.to_s.downcase == keyword
488 }
497 }
489 if assignee.nil? && keyword.match(/ /)
498 if assignee.nil? && keyword.match(/ /)
490 firstname, lastname = *(keyword.split) # "First Last Throwaway"
499 firstname, lastname = *(keyword.split) # "First Last Throwaway"
491 assignee ||= assignable.detect {|a|
500 assignee ||= assignable.detect {|a|
492 a.is_a?(User) && a.firstname.to_s.downcase == firstname &&
501 a.is_a?(User) && a.firstname.to_s.downcase == firstname &&
493 a.lastname.to_s.downcase == lastname
502 a.lastname.to_s.downcase == lastname
494 }
503 }
495 end
504 end
496 if assignee.nil?
505 if assignee.nil?
497 assignee ||= assignable.detect {|a| a.name.downcase == keyword}
506 assignee ||= assignable.detect {|a| a.name.downcase == keyword}
498 end
507 end
499 assignee
508 assignee
500 end
509 end
501 end
510 end
@@ -1,827 +1,834
1 # encoding: utf-8
1 # encoding: utf-8
2 #
2 #
3 # Redmine - project management software
3 # Redmine - project management software
4 # Copyright (C) 2006-2013 Jean-Philippe Lang
4 # Copyright (C) 2006-2013 Jean-Philippe Lang
5 #
5 #
6 # This program is free software; you can redistribute it and/or
6 # This program is free software; you can redistribute it and/or
7 # modify it under the terms of the GNU General Public License
7 # modify it under the terms of the GNU General Public License
8 # as published by the Free Software Foundation; either version 2
8 # as published by the Free Software Foundation; either version 2
9 # of the License, or (at your option) any later version.
9 # of the License, or (at your option) any later version.
10 #
10 #
11 # This program is distributed in the hope that it will be useful,
11 # This program is distributed in the hope that it will be useful,
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 # GNU General Public License for more details.
14 # GNU General Public License for more details.
15 #
15 #
16 # You should have received a copy of the GNU General Public License
16 # You should have received a copy of the GNU General Public License
17 # along with this program; if not, write to the Free Software
17 # along with this program; if not, write to the Free Software
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19
19
20 require File.expand_path('../../test_helper', __FILE__)
20 require File.expand_path('../../test_helper', __FILE__)
21
21
22 class MailHandlerTest < ActiveSupport::TestCase
22 class MailHandlerTest < ActiveSupport::TestCase
23 fixtures :users, :projects, :enabled_modules, :roles,
23 fixtures :users, :projects, :enabled_modules, :roles,
24 :members, :member_roles, :users,
24 :members, :member_roles, :users,
25 :issues, :issue_statuses,
25 :issues, :issue_statuses,
26 :workflows, :trackers, :projects_trackers,
26 :workflows, :trackers, :projects_trackers,
27 :versions, :enumerations, :issue_categories,
27 :versions, :enumerations, :issue_categories,
28 :custom_fields, :custom_fields_trackers, :custom_fields_projects,
28 :custom_fields, :custom_fields_trackers, :custom_fields_projects,
29 :boards, :messages
29 :boards, :messages
30
30
31 FIXTURES_PATH = File.dirname(__FILE__) + '/../fixtures/mail_handler'
31 FIXTURES_PATH = File.dirname(__FILE__) + '/../fixtures/mail_handler'
32
32
33 def setup
33 def setup
34 ActionMailer::Base.deliveries.clear
34 ActionMailer::Base.deliveries.clear
35 Setting.notified_events = Redmine::Notifiable.all.collect(&:name)
35 Setting.notified_events = Redmine::Notifiable.all.collect(&:name)
36 end
36 end
37
37
38 def teardown
38 def teardown
39 Setting.clear_cache
39 Setting.clear_cache
40 end
40 end
41
41
42 def test_add_issue
42 def test_add_issue
43 ActionMailer::Base.deliveries.clear
43 ActionMailer::Base.deliveries.clear
44 # This email contains: 'Project: onlinestore'
44 # This email contains: 'Project: onlinestore'
45 issue = submit_email('ticket_on_given_project.eml')
45 issue = submit_email('ticket_on_given_project.eml')
46 assert issue.is_a?(Issue)
46 assert issue.is_a?(Issue)
47 assert !issue.new_record?
47 assert !issue.new_record?
48 issue.reload
48 issue.reload
49 assert_equal Project.find(2), issue.project
49 assert_equal Project.find(2), issue.project
50 assert_equal issue.project.trackers.first, issue.tracker
50 assert_equal issue.project.trackers.first, issue.tracker
51 assert_equal 'New ticket on a given project', issue.subject
51 assert_equal 'New ticket on a given project', issue.subject
52 assert_equal User.find_by_login('jsmith'), issue.author
52 assert_equal User.find_by_login('jsmith'), issue.author
53 assert_equal IssueStatus.find_by_name('Resolved'), issue.status
53 assert_equal IssueStatus.find_by_name('Resolved'), issue.status
54 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
54 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
55 assert_equal '2010-01-01', issue.start_date.to_s
55 assert_equal '2010-01-01', issue.start_date.to_s
56 assert_equal '2010-12-31', issue.due_date.to_s
56 assert_equal '2010-12-31', issue.due_date.to_s
57 assert_equal User.find_by_login('jsmith'), issue.assigned_to
57 assert_equal User.find_by_login('jsmith'), issue.assigned_to
58 assert_equal Version.find_by_name('Alpha'), issue.fixed_version
58 assert_equal Version.find_by_name('Alpha'), issue.fixed_version
59 assert_equal 2.5, issue.estimated_hours
59 assert_equal 2.5, issue.estimated_hours
60 assert_equal 30, issue.done_ratio
60 assert_equal 30, issue.done_ratio
61 assert_equal [issue.id, 1, 2], [issue.root_id, issue.lft, issue.rgt]
61 assert_equal [issue.id, 1, 2], [issue.root_id, issue.lft, issue.rgt]
62 # keywords should be removed from the email body
62 # keywords should be removed from the email body
63 assert !issue.description.match(/^Project:/i)
63 assert !issue.description.match(/^Project:/i)
64 assert !issue.description.match(/^Status:/i)
64 assert !issue.description.match(/^Status:/i)
65 assert !issue.description.match(/^Start Date:/i)
65 assert !issue.description.match(/^Start Date:/i)
66 # Email notification should be sent
66 # Email notification should be sent
67 mail = ActionMailer::Base.deliveries.last
67 mail = ActionMailer::Base.deliveries.last
68 assert_not_nil mail
68 assert_not_nil mail
69 assert mail.subject.include?('New ticket on a given project')
69 assert mail.subject.include?('New ticket on a given project')
70 end
70 end
71
71
72 def test_add_issue_with_default_tracker
72 def test_add_issue_with_default_tracker
73 # This email contains: 'Project: onlinestore'
73 # This email contains: 'Project: onlinestore'
74 issue = submit_email(
74 issue = submit_email(
75 'ticket_on_given_project.eml',
75 'ticket_on_given_project.eml',
76 :issue => {:tracker => 'Support request'}
76 :issue => {:tracker => 'Support request'}
77 )
77 )
78 assert issue.is_a?(Issue)
78 assert issue.is_a?(Issue)
79 assert !issue.new_record?
79 assert !issue.new_record?
80 issue.reload
80 issue.reload
81 assert_equal 'Support request', issue.tracker.name
81 assert_equal 'Support request', issue.tracker.name
82 end
82 end
83
83
84 def test_add_issue_with_status
84 def test_add_issue_with_status
85 # This email contains: 'Project: onlinestore' and 'Status: Resolved'
85 # This email contains: 'Project: onlinestore' and 'Status: Resolved'
86 issue = submit_email('ticket_on_given_project.eml')
86 issue = submit_email('ticket_on_given_project.eml')
87 assert issue.is_a?(Issue)
87 assert issue.is_a?(Issue)
88 assert !issue.new_record?
88 assert !issue.new_record?
89 issue.reload
89 issue.reload
90 assert_equal Project.find(2), issue.project
90 assert_equal Project.find(2), issue.project
91 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
91 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
92 end
92 end
93
93
94 def test_add_issue_with_attributes_override
94 def test_add_issue_with_attributes_override
95 issue = submit_email(
95 issue = submit_email(
96 'ticket_with_attributes.eml',
96 'ticket_with_attributes.eml',
97 :allow_override => 'tracker,category,priority'
97 :allow_override => 'tracker,category,priority'
98 )
98 )
99 assert issue.is_a?(Issue)
99 assert issue.is_a?(Issue)
100 assert !issue.new_record?
100 assert !issue.new_record?
101 issue.reload
101 issue.reload
102 assert_equal 'New ticket on a given project', issue.subject
102 assert_equal 'New ticket on a given project', issue.subject
103 assert_equal User.find_by_login('jsmith'), issue.author
103 assert_equal User.find_by_login('jsmith'), issue.author
104 assert_equal Project.find(2), issue.project
104 assert_equal Project.find(2), issue.project
105 assert_equal 'Feature request', issue.tracker.to_s
105 assert_equal 'Feature request', issue.tracker.to_s
106 assert_equal 'Stock management', issue.category.to_s
106 assert_equal 'Stock management', issue.category.to_s
107 assert_equal 'Urgent', issue.priority.to_s
107 assert_equal 'Urgent', issue.priority.to_s
108 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
108 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
109 end
109 end
110
110
111 def test_add_issue_with_group_assignment
111 def test_add_issue_with_group_assignment
112 with_settings :issue_group_assignment => '1' do
112 with_settings :issue_group_assignment => '1' do
113 issue = submit_email('ticket_on_given_project.eml') do |email|
113 issue = submit_email('ticket_on_given_project.eml') do |email|
114 email.gsub!('Assigned to: John Smith', 'Assigned to: B Team')
114 email.gsub!('Assigned to: John Smith', 'Assigned to: B Team')
115 end
115 end
116 assert issue.is_a?(Issue)
116 assert issue.is_a?(Issue)
117 assert !issue.new_record?
117 assert !issue.new_record?
118 issue.reload
118 issue.reload
119 assert_equal Group.find(11), issue.assigned_to
119 assert_equal Group.find(11), issue.assigned_to
120 end
120 end
121 end
121 end
122
122
123 def test_add_issue_with_partial_attributes_override
123 def test_add_issue_with_partial_attributes_override
124 issue = submit_email(
124 issue = submit_email(
125 'ticket_with_attributes.eml',
125 'ticket_with_attributes.eml',
126 :issue => {:priority => 'High'},
126 :issue => {:priority => 'High'},
127 :allow_override => ['tracker']
127 :allow_override => ['tracker']
128 )
128 )
129 assert issue.is_a?(Issue)
129 assert issue.is_a?(Issue)
130 assert !issue.new_record?
130 assert !issue.new_record?
131 issue.reload
131 issue.reload
132 assert_equal 'New ticket on a given project', issue.subject
132 assert_equal 'New ticket on a given project', issue.subject
133 assert_equal User.find_by_login('jsmith'), issue.author
133 assert_equal User.find_by_login('jsmith'), issue.author
134 assert_equal Project.find(2), issue.project
134 assert_equal Project.find(2), issue.project
135 assert_equal 'Feature request', issue.tracker.to_s
135 assert_equal 'Feature request', issue.tracker.to_s
136 assert_nil issue.category
136 assert_nil issue.category
137 assert_equal 'High', issue.priority.to_s
137 assert_equal 'High', issue.priority.to_s
138 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
138 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
139 end
139 end
140
140
141 def test_add_issue_with_spaces_between_attribute_and_separator
141 def test_add_issue_with_spaces_between_attribute_and_separator
142 issue = submit_email(
142 issue = submit_email(
143 'ticket_with_spaces_between_attribute_and_separator.eml',
143 'ticket_with_spaces_between_attribute_and_separator.eml',
144 :allow_override => 'tracker,category,priority'
144 :allow_override => 'tracker,category,priority'
145 )
145 )
146 assert issue.is_a?(Issue)
146 assert issue.is_a?(Issue)
147 assert !issue.new_record?
147 assert !issue.new_record?
148 issue.reload
148 issue.reload
149 assert_equal 'New ticket on a given project', issue.subject
149 assert_equal 'New ticket on a given project', issue.subject
150 assert_equal User.find_by_login('jsmith'), issue.author
150 assert_equal User.find_by_login('jsmith'), issue.author
151 assert_equal Project.find(2), issue.project
151 assert_equal Project.find(2), issue.project
152 assert_equal 'Feature request', issue.tracker.to_s
152 assert_equal 'Feature request', issue.tracker.to_s
153 assert_equal 'Stock management', issue.category.to_s
153 assert_equal 'Stock management', issue.category.to_s
154 assert_equal 'Urgent', issue.priority.to_s
154 assert_equal 'Urgent', issue.priority.to_s
155 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
155 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
156 end
156 end
157
157
158 def test_add_issue_with_attachment_to_specific_project
158 def test_add_issue_with_attachment_to_specific_project
159 issue = submit_email('ticket_with_attachment.eml', :issue => {:project => 'onlinestore'})
159 issue = submit_email('ticket_with_attachment.eml', :issue => {:project => 'onlinestore'})
160 assert issue.is_a?(Issue)
160 assert issue.is_a?(Issue)
161 assert !issue.new_record?
161 assert !issue.new_record?
162 issue.reload
162 issue.reload
163 assert_equal 'Ticket created by email with attachment', issue.subject
163 assert_equal 'Ticket created by email with attachment', issue.subject
164 assert_equal User.find_by_login('jsmith'), issue.author
164 assert_equal User.find_by_login('jsmith'), issue.author
165 assert_equal Project.find(2), issue.project
165 assert_equal Project.find(2), issue.project
166 assert_equal 'This is a new ticket with attachments', issue.description
166 assert_equal 'This is a new ticket with attachments', issue.description
167 # Attachment properties
167 # Attachment properties
168 assert_equal 1, issue.attachments.size
168 assert_equal 1, issue.attachments.size
169 assert_equal 'Paella.jpg', issue.attachments.first.filename
169 assert_equal 'Paella.jpg', issue.attachments.first.filename
170 assert_equal 'image/jpeg', issue.attachments.first.content_type
170 assert_equal 'image/jpeg', issue.attachments.first.content_type
171 assert_equal 10790, issue.attachments.first.filesize
171 assert_equal 10790, issue.attachments.first.filesize
172 end
172 end
173
173
174 def test_add_issue_with_custom_fields
174 def test_add_issue_with_custom_fields
175 issue = submit_email('ticket_with_custom_fields.eml', :issue => {:project => 'onlinestore'})
175 issue = submit_email('ticket_with_custom_fields.eml', :issue => {:project => 'onlinestore'})
176 assert issue.is_a?(Issue)
176 assert issue.is_a?(Issue)
177 assert !issue.new_record?
177 assert !issue.new_record?
178 issue.reload
178 issue.reload
179 assert_equal 'New ticket with custom field values', issue.subject
179 assert_equal 'New ticket with custom field values', issue.subject
180 assert_equal 'PostgreSQL', issue.custom_field_value(1)
180 assert_equal 'PostgreSQL', issue.custom_field_value(1)
181 assert_equal 'Value for a custom field', issue.custom_field_value(2)
181 assert_equal 'Value for a custom field', issue.custom_field_value(2)
182 assert !issue.description.match(/^searchable field:/i)
182 assert !issue.description.match(/^searchable field:/i)
183 end
183 end
184
184
185 def test_add_issue_with_version_custom_fields
185 def test_add_issue_with_version_custom_fields
186 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true, :tracker_ids => [1,2,3])
186 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true, :tracker_ids => [1,2,3])
187
187
188 issue = submit_email('ticket_with_custom_fields.eml', :issue => {:project => 'ecookbook'}) do |email|
188 issue = submit_email('ticket_with_custom_fields.eml', :issue => {:project => 'ecookbook'}) do |email|
189 email << "Affected version: 1.0\n"
189 email << "Affected version: 1.0\n"
190 end
190 end
191 assert issue.is_a?(Issue)
191 assert issue.is_a?(Issue)
192 assert !issue.new_record?
192 assert !issue.new_record?
193 issue.reload
193 issue.reload
194 assert_equal '2', issue.custom_field_value(field)
194 assert_equal '2', issue.custom_field_value(field)
195 end
195 end
196
196
197 def test_add_issue_should_match_assignee_on_display_name
197 def test_add_issue_should_match_assignee_on_display_name
198 user = User.generate!(:firstname => 'Foo Bar', :lastname => 'Foo Baz')
198 user = User.generate!(:firstname => 'Foo Bar', :lastname => 'Foo Baz')
199 User.add_to_project(user, Project.find(2))
199 User.add_to_project(user, Project.find(2))
200 issue = submit_email('ticket_on_given_project.eml') do |email|
200 issue = submit_email('ticket_on_given_project.eml') do |email|
201 email.sub!(/^Assigned to.*$/, 'Assigned to: Foo Bar Foo baz')
201 email.sub!(/^Assigned to.*$/, 'Assigned to: Foo Bar Foo baz')
202 end
202 end
203 assert issue.is_a?(Issue)
203 assert issue.is_a?(Issue)
204 assert_equal user, issue.assigned_to
204 assert_equal user, issue.assigned_to
205 end
205 end
206
206
207 def test_add_issue_with_cc
207 def test_add_issue_with_cc
208 issue = submit_email('ticket_with_cc.eml', :issue => {:project => 'ecookbook'})
208 issue = submit_email('ticket_with_cc.eml', :issue => {:project => 'ecookbook'})
209 assert issue.is_a?(Issue)
209 assert issue.is_a?(Issue)
210 assert !issue.new_record?
210 assert !issue.new_record?
211 issue.reload
211 issue.reload
212 assert issue.watched_by?(User.find_by_mail('dlopper@somenet.foo'))
212 assert issue.watched_by?(User.find_by_mail('dlopper@somenet.foo'))
213 assert_equal 1, issue.watcher_user_ids.size
213 assert_equal 1, issue.watcher_user_ids.size
214 end
214 end
215
215
216 def test_add_issue_by_unknown_user
216 def test_add_issue_by_unknown_user
217 assert_no_difference 'User.count' do
217 assert_no_difference 'User.count' do
218 assert_equal false,
218 assert_equal false,
219 submit_email(
219 submit_email(
220 'ticket_by_unknown_user.eml',
220 'ticket_by_unknown_user.eml',
221 :issue => {:project => 'ecookbook'}
221 :issue => {:project => 'ecookbook'}
222 )
222 )
223 end
223 end
224 end
224 end
225
225
226 def test_add_issue_by_anonymous_user
226 def test_add_issue_by_anonymous_user
227 Role.anonymous.add_permission!(:add_issues)
227 Role.anonymous.add_permission!(:add_issues)
228 assert_no_difference 'User.count' do
228 assert_no_difference 'User.count' do
229 issue = submit_email(
229 issue = submit_email(
230 'ticket_by_unknown_user.eml',
230 'ticket_by_unknown_user.eml',
231 :issue => {:project => 'ecookbook'},
231 :issue => {:project => 'ecookbook'},
232 :unknown_user => 'accept'
232 :unknown_user => 'accept'
233 )
233 )
234 assert issue.is_a?(Issue)
234 assert issue.is_a?(Issue)
235 assert issue.author.anonymous?
235 assert issue.author.anonymous?
236 end
236 end
237 end
237 end
238
238
239 def test_add_issue_by_anonymous_user_with_no_from_address
239 def test_add_issue_by_anonymous_user_with_no_from_address
240 Role.anonymous.add_permission!(:add_issues)
240 Role.anonymous.add_permission!(:add_issues)
241 assert_no_difference 'User.count' do
241 assert_no_difference 'User.count' do
242 issue = submit_email(
242 issue = submit_email(
243 'ticket_by_empty_user.eml',
243 'ticket_by_empty_user.eml',
244 :issue => {:project => 'ecookbook'},
244 :issue => {:project => 'ecookbook'},
245 :unknown_user => 'accept'
245 :unknown_user => 'accept'
246 )
246 )
247 assert issue.is_a?(Issue)
247 assert issue.is_a?(Issue)
248 assert issue.author.anonymous?
248 assert issue.author.anonymous?
249 end
249 end
250 end
250 end
251
251
252 def test_add_issue_by_anonymous_user_on_private_project
252 def test_add_issue_by_anonymous_user_on_private_project
253 Role.anonymous.add_permission!(:add_issues)
253 Role.anonymous.add_permission!(:add_issues)
254 assert_no_difference 'User.count' do
254 assert_no_difference 'User.count' do
255 assert_no_difference 'Issue.count' do
255 assert_no_difference 'Issue.count' do
256 assert_equal false,
256 assert_equal false,
257 submit_email(
257 submit_email(
258 'ticket_by_unknown_user.eml',
258 'ticket_by_unknown_user.eml',
259 :issue => {:project => 'onlinestore'},
259 :issue => {:project => 'onlinestore'},
260 :unknown_user => 'accept'
260 :unknown_user => 'accept'
261 )
261 )
262 end
262 end
263 end
263 end
264 end
264 end
265
265
266 def test_add_issue_by_anonymous_user_on_private_project_without_permission_check
266 def test_add_issue_by_anonymous_user_on_private_project_without_permission_check
267 assert_no_difference 'User.count' do
267 assert_no_difference 'User.count' do
268 assert_difference 'Issue.count' do
268 assert_difference 'Issue.count' do
269 issue = submit_email(
269 issue = submit_email(
270 'ticket_by_unknown_user.eml',
270 'ticket_by_unknown_user.eml',
271 :issue => {:project => 'onlinestore'},
271 :issue => {:project => 'onlinestore'},
272 :no_permission_check => '1',
272 :no_permission_check => '1',
273 :unknown_user => 'accept'
273 :unknown_user => 'accept'
274 )
274 )
275 assert issue.is_a?(Issue)
275 assert issue.is_a?(Issue)
276 assert issue.author.anonymous?
276 assert issue.author.anonymous?
277 assert !issue.project.is_public?
277 assert !issue.project.is_public?
278 assert_equal [issue.id, 1, 2], [issue.root_id, issue.lft, issue.rgt]
278 assert_equal [issue.id, 1, 2], [issue.root_id, issue.lft, issue.rgt]
279 end
279 end
280 end
280 end
281 end
281 end
282
282
283 def test_add_issue_by_created_user
283 def test_add_issue_by_created_user
284 Setting.default_language = 'en'
284 Setting.default_language = 'en'
285 assert_difference 'User.count' do
285 assert_difference 'User.count' do
286 issue = submit_email(
286 issue = submit_email(
287 'ticket_by_unknown_user.eml',
287 'ticket_by_unknown_user.eml',
288 :issue => {:project => 'ecookbook'},
288 :issue => {:project => 'ecookbook'},
289 :unknown_user => 'create'
289 :unknown_user => 'create'
290 )
290 )
291 assert issue.is_a?(Issue)
291 assert issue.is_a?(Issue)
292 assert issue.author.active?
292 assert issue.author.active?
293 assert_equal 'john.doe@somenet.foo', issue.author.mail
293 assert_equal 'john.doe@somenet.foo', issue.author.mail
294 assert_equal 'John', issue.author.firstname
294 assert_equal 'John', issue.author.firstname
295 assert_equal 'Doe', issue.author.lastname
295 assert_equal 'Doe', issue.author.lastname
296
296
297 # account information
297 # account information
298 email = ActionMailer::Base.deliveries.first
298 email = ActionMailer::Base.deliveries.first
299 assert_not_nil email
299 assert_not_nil email
300 assert email.subject.include?('account activation')
300 assert email.subject.include?('account activation')
301 login = mail_body(email).match(/\* Login: (.*)$/)[1].strip
301 login = mail_body(email).match(/\* Login: (.*)$/)[1].strip
302 password = mail_body(email).match(/\* Password: (.*)$/)[1].strip
302 password = mail_body(email).match(/\* Password: (.*)$/)[1].strip
303 assert_equal issue.author, User.try_to_login(login, password)
303 assert_equal issue.author, User.try_to_login(login, password)
304 end
304 end
305 end
305 end
306
306
307 def test_created_user_should_be_added_to_groups
307 def test_created_user_should_be_added_to_groups
308 group1 = Group.generate!
308 group1 = Group.generate!
309 group2 = Group.generate!
309 group2 = Group.generate!
310
310
311 assert_difference 'User.count' do
311 assert_difference 'User.count' do
312 submit_email(
312 submit_email(
313 'ticket_by_unknown_user.eml',
313 'ticket_by_unknown_user.eml',
314 :issue => {:project => 'ecookbook'},
314 :issue => {:project => 'ecookbook'},
315 :unknown_user => 'create',
315 :unknown_user => 'create',
316 :default_group => "#{group1.name},#{group2.name}"
316 :default_group => "#{group1.name},#{group2.name}"
317 )
317 )
318 end
318 end
319 user = User.order('id DESC').first
319 user = User.order('id DESC').first
320 assert_same_elements [group1, group2], user.groups
320 assert_same_elements [group1, group2], user.groups
321 end
321 end
322
322
323 def test_created_user_should_not_receive_account_information_with_no_account_info_option
323 def test_created_user_should_not_receive_account_information_with_no_account_info_option
324 assert_difference 'User.count' do
324 assert_difference 'User.count' do
325 submit_email(
325 submit_email(
326 'ticket_by_unknown_user.eml',
326 'ticket_by_unknown_user.eml',
327 :issue => {:project => 'ecookbook'},
327 :issue => {:project => 'ecookbook'},
328 :unknown_user => 'create',
328 :unknown_user => 'create',
329 :no_account_notice => '1'
329 :no_account_notice => '1'
330 )
330 )
331 end
331 end
332
332
333 # only 1 email for the new issue notification
333 # only 1 email for the new issue notification
334 assert_equal 1, ActionMailer::Base.deliveries.size
334 assert_equal 1, ActionMailer::Base.deliveries.size
335 email = ActionMailer::Base.deliveries.first
335 email = ActionMailer::Base.deliveries.first
336 assert_include 'Ticket by unknown user', email.subject
336 assert_include 'Ticket by unknown user', email.subject
337 end
337 end
338
338
339 def test_created_user_should_have_mail_notification_to_none_with_no_notification_option
339 def test_created_user_should_have_mail_notification_to_none_with_no_notification_option
340 assert_difference 'User.count' do
340 assert_difference 'User.count' do
341 submit_email(
341 submit_email(
342 'ticket_by_unknown_user.eml',
342 'ticket_by_unknown_user.eml',
343 :issue => {:project => 'ecookbook'},
343 :issue => {:project => 'ecookbook'},
344 :unknown_user => 'create',
344 :unknown_user => 'create',
345 :no_notification => '1'
345 :no_notification => '1'
346 )
346 )
347 end
347 end
348 user = User.order('id DESC').first
348 user = User.order('id DESC').first
349 assert_equal 'none', user.mail_notification
349 assert_equal 'none', user.mail_notification
350 end
350 end
351
351
352 def test_add_issue_without_from_header
352 def test_add_issue_without_from_header
353 Role.anonymous.add_permission!(:add_issues)
353 Role.anonymous.add_permission!(:add_issues)
354 assert_equal false, submit_email('ticket_without_from_header.eml')
354 assert_equal false, submit_email('ticket_without_from_header.eml')
355 end
355 end
356
356
357 def test_add_issue_with_invalid_attributes
357 def test_add_issue_with_invalid_attributes
358 issue = submit_email(
358 issue = submit_email(
359 'ticket_with_invalid_attributes.eml',
359 'ticket_with_invalid_attributes.eml',
360 :allow_override => 'tracker,category,priority'
360 :allow_override => 'tracker,category,priority'
361 )
361 )
362 assert issue.is_a?(Issue)
362 assert issue.is_a?(Issue)
363 assert !issue.new_record?
363 assert !issue.new_record?
364 issue.reload
364 issue.reload
365 assert_nil issue.assigned_to
365 assert_nil issue.assigned_to
366 assert_nil issue.start_date
366 assert_nil issue.start_date
367 assert_nil issue.due_date
367 assert_nil issue.due_date
368 assert_equal 0, issue.done_ratio
368 assert_equal 0, issue.done_ratio
369 assert_equal 'Normal', issue.priority.to_s
369 assert_equal 'Normal', issue.priority.to_s
370 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
370 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
371 end
371 end
372
372
373 def test_add_issue_with_localized_attributes
373 def test_add_issue_with_localized_attributes
374 User.find_by_mail('jsmith@somenet.foo').update_attribute 'language', 'fr'
374 User.find_by_mail('jsmith@somenet.foo').update_attribute 'language', 'fr'
375 issue = submit_email(
375 issue = submit_email(
376 'ticket_with_localized_attributes.eml',
376 'ticket_with_localized_attributes.eml',
377 :allow_override => 'tracker,category,priority'
377 :allow_override => 'tracker,category,priority'
378 )
378 )
379 assert issue.is_a?(Issue)
379 assert issue.is_a?(Issue)
380 assert !issue.new_record?
380 assert !issue.new_record?
381 issue.reload
381 issue.reload
382 assert_equal 'New ticket on a given project', issue.subject
382 assert_equal 'New ticket on a given project', issue.subject
383 assert_equal User.find_by_login('jsmith'), issue.author
383 assert_equal User.find_by_login('jsmith'), issue.author
384 assert_equal Project.find(2), issue.project
384 assert_equal Project.find(2), issue.project
385 assert_equal 'Feature request', issue.tracker.to_s
385 assert_equal 'Feature request', issue.tracker.to_s
386 assert_equal 'Stock management', issue.category.to_s
386 assert_equal 'Stock management', issue.category.to_s
387 assert_equal 'Urgent', issue.priority.to_s
387 assert_equal 'Urgent', issue.priority.to_s
388 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
388 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
389 end
389 end
390
390
391 def test_add_issue_with_japanese_keywords
391 def test_add_issue_with_japanese_keywords
392 ja_dev = "\xe9\x96\x8b\xe7\x99\xba"
392 ja_dev = "\xe9\x96\x8b\xe7\x99\xba"
393 ja_dev.force_encoding('UTF-8') if ja_dev.respond_to?(:force_encoding)
393 ja_dev.force_encoding('UTF-8') if ja_dev.respond_to?(:force_encoding)
394 tracker = Tracker.create!(:name => ja_dev)
394 tracker = Tracker.create!(:name => ja_dev)
395 Project.find(1).trackers << tracker
395 Project.find(1).trackers << tracker
396 issue = submit_email(
396 issue = submit_email(
397 'japanese_keywords_iso_2022_jp.eml',
397 'japanese_keywords_iso_2022_jp.eml',
398 :issue => {:project => 'ecookbook'},
398 :issue => {:project => 'ecookbook'},
399 :allow_override => 'tracker'
399 :allow_override => 'tracker'
400 )
400 )
401 assert_kind_of Issue, issue
401 assert_kind_of Issue, issue
402 assert_equal tracker, issue.tracker
402 assert_equal tracker, issue.tracker
403 end
403 end
404
404
405 def test_add_issue_from_apple_mail
405 def test_add_issue_from_apple_mail
406 issue = submit_email(
406 issue = submit_email(
407 'apple_mail_with_attachment.eml',
407 'apple_mail_with_attachment.eml',
408 :issue => {:project => 'ecookbook'}
408 :issue => {:project => 'ecookbook'}
409 )
409 )
410 assert_kind_of Issue, issue
410 assert_kind_of Issue, issue
411 assert_equal 1, issue.attachments.size
411 assert_equal 1, issue.attachments.size
412
412
413 attachment = issue.attachments.first
413 attachment = issue.attachments.first
414 assert_equal 'paella.jpg', attachment.filename
414 assert_equal 'paella.jpg', attachment.filename
415 assert_equal 10790, attachment.filesize
415 assert_equal 10790, attachment.filesize
416 assert File.exist?(attachment.diskfile)
416 assert File.exist?(attachment.diskfile)
417 assert_equal 10790, File.size(attachment.diskfile)
417 assert_equal 10790, File.size(attachment.diskfile)
418 assert_equal 'caaf384198bcbc9563ab5c058acd73cd', attachment.digest
418 assert_equal 'caaf384198bcbc9563ab5c058acd73cd', attachment.digest
419 end
419 end
420
420
421 def test_thunderbird_with_attachment_ja
421 def test_thunderbird_with_attachment_ja
422 issue = submit_email(
422 issue = submit_email(
423 'thunderbird_with_attachment_ja.eml',
423 'thunderbird_with_attachment_ja.eml',
424 :issue => {:project => 'ecookbook'}
424 :issue => {:project => 'ecookbook'}
425 )
425 )
426 assert_kind_of Issue, issue
426 assert_kind_of Issue, issue
427 assert_equal 1, issue.attachments.size
427 assert_equal 1, issue.attachments.size
428 ja = "\xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88.txt"
428 ja = "\xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88.txt"
429 ja.force_encoding('UTF-8') if ja.respond_to?(:force_encoding)
429 ja.force_encoding('UTF-8') if ja.respond_to?(:force_encoding)
430 attachment = issue.attachments.first
430 attachment = issue.attachments.first
431 assert_equal ja, attachment.filename
431 assert_equal ja, attachment.filename
432 assert_equal 5, attachment.filesize
432 assert_equal 5, attachment.filesize
433 assert File.exist?(attachment.diskfile)
433 assert File.exist?(attachment.diskfile)
434 assert_equal 5, File.size(attachment.diskfile)
434 assert_equal 5, File.size(attachment.diskfile)
435 assert_equal 'd8e8fca2dc0f896fd7cb4cb0031ba249', attachment.digest
435 assert_equal 'd8e8fca2dc0f896fd7cb4cb0031ba249', attachment.digest
436 end
436 end
437
437
438 def test_gmail_with_attachment_ja
438 def test_gmail_with_attachment_ja
439 issue = submit_email(
439 issue = submit_email(
440 'gmail_with_attachment_ja.eml',
440 'gmail_with_attachment_ja.eml',
441 :issue => {:project => 'ecookbook'}
441 :issue => {:project => 'ecookbook'}
442 )
442 )
443 assert_kind_of Issue, issue
443 assert_kind_of Issue, issue
444 assert_equal 1, issue.attachments.size
444 assert_equal 1, issue.attachments.size
445 ja = "\xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88.txt"
445 ja = "\xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88.txt"
446 ja.force_encoding('UTF-8') if ja.respond_to?(:force_encoding)
446 ja.force_encoding('UTF-8') if ja.respond_to?(:force_encoding)
447 attachment = issue.attachments.first
447 attachment = issue.attachments.first
448 assert_equal ja, attachment.filename
448 assert_equal ja, attachment.filename
449 assert_equal 5, attachment.filesize
449 assert_equal 5, attachment.filesize
450 assert File.exist?(attachment.diskfile)
450 assert File.exist?(attachment.diskfile)
451 assert_equal 5, File.size(attachment.diskfile)
451 assert_equal 5, File.size(attachment.diskfile)
452 assert_equal 'd8e8fca2dc0f896fd7cb4cb0031ba249', attachment.digest
452 assert_equal 'd8e8fca2dc0f896fd7cb4cb0031ba249', attachment.digest
453 end
453 end
454
454
455 def test_thunderbird_with_attachment_latin1
455 def test_thunderbird_with_attachment_latin1
456 issue = submit_email(
456 issue = submit_email(
457 'thunderbird_with_attachment_iso-8859-1.eml',
457 'thunderbird_with_attachment_iso-8859-1.eml',
458 :issue => {:project => 'ecookbook'}
458 :issue => {:project => 'ecookbook'}
459 )
459 )
460 assert_kind_of Issue, issue
460 assert_kind_of Issue, issue
461 assert_equal 1, issue.attachments.size
461 assert_equal 1, issue.attachments.size
462 u = ""
462 u = ""
463 u.force_encoding('UTF-8') if u.respond_to?(:force_encoding)
463 u.force_encoding('UTF-8') if u.respond_to?(:force_encoding)
464 u1 = "\xc3\x84\xc3\xa4\xc3\x96\xc3\xb6\xc3\x9c\xc3\xbc"
464 u1 = "\xc3\x84\xc3\xa4\xc3\x96\xc3\xb6\xc3\x9c\xc3\xbc"
465 u1.force_encoding('UTF-8') if u1.respond_to?(:force_encoding)
465 u1.force_encoding('UTF-8') if u1.respond_to?(:force_encoding)
466 11.times { u << u1 }
466 11.times { u << u1 }
467 attachment = issue.attachments.first
467 attachment = issue.attachments.first
468 assert_equal "#{u}.png", attachment.filename
468 assert_equal "#{u}.png", attachment.filename
469 assert_equal 130, attachment.filesize
469 assert_equal 130, attachment.filesize
470 assert File.exist?(attachment.diskfile)
470 assert File.exist?(attachment.diskfile)
471 assert_equal 130, File.size(attachment.diskfile)
471 assert_equal 130, File.size(attachment.diskfile)
472 assert_equal '4d80e667ac37dddfe05502530f152abb', attachment.digest
472 assert_equal '4d80e667ac37dddfe05502530f152abb', attachment.digest
473 end
473 end
474
474
475 def test_gmail_with_attachment_latin1
475 def test_gmail_with_attachment_latin1
476 issue = submit_email(
476 issue = submit_email(
477 'gmail_with_attachment_iso-8859-1.eml',
477 'gmail_with_attachment_iso-8859-1.eml',
478 :issue => {:project => 'ecookbook'}
478 :issue => {:project => 'ecookbook'}
479 )
479 )
480 assert_kind_of Issue, issue
480 assert_kind_of Issue, issue
481 assert_equal 1, issue.attachments.size
481 assert_equal 1, issue.attachments.size
482 u = ""
482 u = ""
483 u.force_encoding('UTF-8') if u.respond_to?(:force_encoding)
483 u.force_encoding('UTF-8') if u.respond_to?(:force_encoding)
484 u1 = "\xc3\x84\xc3\xa4\xc3\x96\xc3\xb6\xc3\x9c\xc3\xbc"
484 u1 = "\xc3\x84\xc3\xa4\xc3\x96\xc3\xb6\xc3\x9c\xc3\xbc"
485 u1.force_encoding('UTF-8') if u1.respond_to?(:force_encoding)
485 u1.force_encoding('UTF-8') if u1.respond_to?(:force_encoding)
486 11.times { u << u1 }
486 11.times { u << u1 }
487 attachment = issue.attachments.first
487 attachment = issue.attachments.first
488 assert_equal "#{u}.txt", attachment.filename
488 assert_equal "#{u}.txt", attachment.filename
489 assert_equal 5, attachment.filesize
489 assert_equal 5, attachment.filesize
490 assert File.exist?(attachment.diskfile)
490 assert File.exist?(attachment.diskfile)
491 assert_equal 5, File.size(attachment.diskfile)
491 assert_equal 5, File.size(attachment.diskfile)
492 assert_equal 'd8e8fca2dc0f896fd7cb4cb0031ba249', attachment.digest
492 assert_equal 'd8e8fca2dc0f896fd7cb4cb0031ba249', attachment.digest
493 end
493 end
494
494
495 def test_multiple_text_parts
496 issue = submit_email('multiple_text_parts.eml', :issue => {:project => 'ecookbook'})
497 assert_include 'first', issue.description
498 assert_include 'second', issue.description
499 assert_include 'third', issue.description
500 end
501
495 def test_add_issue_with_iso_8859_1_subject
502 def test_add_issue_with_iso_8859_1_subject
496 issue = submit_email(
503 issue = submit_email(
497 'subject_as_iso-8859-1.eml',
504 'subject_as_iso-8859-1.eml',
498 :issue => {:project => 'ecookbook'}
505 :issue => {:project => 'ecookbook'}
499 )
506 )
500 str = "Testmail from Webmail: \xc3\xa4 \xc3\xb6 \xc3\xbc..."
507 str = "Testmail from Webmail: \xc3\xa4 \xc3\xb6 \xc3\xbc..."
501 str.force_encoding('UTF-8') if str.respond_to?(:force_encoding)
508 str.force_encoding('UTF-8') if str.respond_to?(:force_encoding)
502 assert_kind_of Issue, issue
509 assert_kind_of Issue, issue
503 assert_equal str, issue.subject
510 assert_equal str, issue.subject
504 end
511 end
505
512
506 def test_add_issue_with_japanese_subject
513 def test_add_issue_with_japanese_subject
507 issue = submit_email(
514 issue = submit_email(
508 'subject_japanese_1.eml',
515 'subject_japanese_1.eml',
509 :issue => {:project => 'ecookbook'}
516 :issue => {:project => 'ecookbook'}
510 )
517 )
511 assert_kind_of Issue, issue
518 assert_kind_of Issue, issue
512 ja = "\xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88"
519 ja = "\xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88"
513 ja.force_encoding('UTF-8') if ja.respond_to?(:force_encoding)
520 ja.force_encoding('UTF-8') if ja.respond_to?(:force_encoding)
514 assert_equal ja, issue.subject
521 assert_equal ja, issue.subject
515 end
522 end
516
523
517 def test_add_issue_with_no_subject_header
524 def test_add_issue_with_no_subject_header
518 issue = submit_email(
525 issue = submit_email(
519 'no_subject_header.eml',
526 'no_subject_header.eml',
520 :issue => {:project => 'ecookbook'}
527 :issue => {:project => 'ecookbook'}
521 )
528 )
522 assert_kind_of Issue, issue
529 assert_kind_of Issue, issue
523 assert_equal '(no subject)', issue.subject
530 assert_equal '(no subject)', issue.subject
524 end
531 end
525
532
526 def test_add_issue_with_mixed_japanese_subject
533 def test_add_issue_with_mixed_japanese_subject
527 issue = submit_email(
534 issue = submit_email(
528 'subject_japanese_2.eml',
535 'subject_japanese_2.eml',
529 :issue => {:project => 'ecookbook'}
536 :issue => {:project => 'ecookbook'}
530 )
537 )
531 assert_kind_of Issue, issue
538 assert_kind_of Issue, issue
532 ja = "Re: \xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88"
539 ja = "Re: \xe3\x83\x86\xe3\x82\xb9\xe3\x83\x88"
533 ja.force_encoding('UTF-8') if ja.respond_to?(:force_encoding)
540 ja.force_encoding('UTF-8') if ja.respond_to?(:force_encoding)
534 assert_equal ja, issue.subject
541 assert_equal ja, issue.subject
535 end
542 end
536
543
537 def test_should_ignore_emails_from_locked_users
544 def test_should_ignore_emails_from_locked_users
538 User.find(2).lock!
545 User.find(2).lock!
539
546
540 MailHandler.any_instance.expects(:dispatch).never
547 MailHandler.any_instance.expects(:dispatch).never
541 assert_no_difference 'Issue.count' do
548 assert_no_difference 'Issue.count' do
542 assert_equal false, submit_email('ticket_on_given_project.eml')
549 assert_equal false, submit_email('ticket_on_given_project.eml')
543 end
550 end
544 end
551 end
545
552
546 def test_should_ignore_emails_from_emission_address
553 def test_should_ignore_emails_from_emission_address
547 Role.anonymous.add_permission!(:add_issues)
554 Role.anonymous.add_permission!(:add_issues)
548 assert_no_difference 'User.count' do
555 assert_no_difference 'User.count' do
549 assert_equal false,
556 assert_equal false,
550 submit_email(
557 submit_email(
551 'ticket_from_emission_address.eml',
558 'ticket_from_emission_address.eml',
552 :issue => {:project => 'ecookbook'},
559 :issue => {:project => 'ecookbook'},
553 :unknown_user => 'create'
560 :unknown_user => 'create'
554 )
561 )
555 end
562 end
556 end
563 end
557
564
558 def test_should_ignore_auto_replied_emails
565 def test_should_ignore_auto_replied_emails
559 MailHandler.any_instance.expects(:dispatch).never
566 MailHandler.any_instance.expects(:dispatch).never
560 [
567 [
561 "X-Auto-Response-Suppress: OOF",
568 "X-Auto-Response-Suppress: OOF",
562 "Auto-Submitted: auto-replied",
569 "Auto-Submitted: auto-replied",
563 "Auto-Submitted: Auto-Replied",
570 "Auto-Submitted: Auto-Replied",
564 "Auto-Submitted: auto-generated"
571 "Auto-Submitted: auto-generated"
565 ].each do |header|
572 ].each do |header|
566 raw = IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
573 raw = IO.read(File.join(FIXTURES_PATH, 'ticket_on_given_project.eml'))
567 raw = header + "\n" + raw
574 raw = header + "\n" + raw
568
575
569 assert_no_difference 'Issue.count' do
576 assert_no_difference 'Issue.count' do
570 assert_equal false, MailHandler.receive(raw), "email with #{header} header was not ignored"
577 assert_equal false, MailHandler.receive(raw), "email with #{header} header was not ignored"
571 end
578 end
572 end
579 end
573 end
580 end
574
581
575 def test_add_issue_should_send_email_notification
582 def test_add_issue_should_send_email_notification
576 Setting.notified_events = ['issue_added']
583 Setting.notified_events = ['issue_added']
577 ActionMailer::Base.deliveries.clear
584 ActionMailer::Base.deliveries.clear
578 # This email contains: 'Project: onlinestore'
585 # This email contains: 'Project: onlinestore'
579 issue = submit_email('ticket_on_given_project.eml')
586 issue = submit_email('ticket_on_given_project.eml')
580 assert issue.is_a?(Issue)
587 assert issue.is_a?(Issue)
581 assert_equal 1, ActionMailer::Base.deliveries.size
588 assert_equal 1, ActionMailer::Base.deliveries.size
582 end
589 end
583
590
584 def test_update_issue
591 def test_update_issue
585 journal = submit_email('ticket_reply.eml')
592 journal = submit_email('ticket_reply.eml')
586 assert journal.is_a?(Journal)
593 assert journal.is_a?(Journal)
587 assert_equal User.find_by_login('jsmith'), journal.user
594 assert_equal User.find_by_login('jsmith'), journal.user
588 assert_equal Issue.find(2), journal.journalized
595 assert_equal Issue.find(2), journal.journalized
589 assert_match /This is reply/, journal.notes
596 assert_match /This is reply/, journal.notes
590 assert_equal false, journal.private_notes
597 assert_equal false, journal.private_notes
591 assert_equal 'Feature request', journal.issue.tracker.name
598 assert_equal 'Feature request', journal.issue.tracker.name
592 end
599 end
593
600
594 def test_update_issue_with_attribute_changes
601 def test_update_issue_with_attribute_changes
595 # This email contains: 'Status: Resolved'
602 # This email contains: 'Status: Resolved'
596 journal = submit_email('ticket_reply_with_status.eml')
603 journal = submit_email('ticket_reply_with_status.eml')
597 assert journal.is_a?(Journal)
604 assert journal.is_a?(Journal)
598 issue = Issue.find(journal.issue.id)
605 issue = Issue.find(journal.issue.id)
599 assert_equal User.find_by_login('jsmith'), journal.user
606 assert_equal User.find_by_login('jsmith'), journal.user
600 assert_equal Issue.find(2), journal.journalized
607 assert_equal Issue.find(2), journal.journalized
601 assert_match /This is reply/, journal.notes
608 assert_match /This is reply/, journal.notes
602 assert_equal 'Feature request', journal.issue.tracker.name
609 assert_equal 'Feature request', journal.issue.tracker.name
603 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
610 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
604 assert_equal '2010-01-01', issue.start_date.to_s
611 assert_equal '2010-01-01', issue.start_date.to_s
605 assert_equal '2010-12-31', issue.due_date.to_s
612 assert_equal '2010-12-31', issue.due_date.to_s
606 assert_equal User.find_by_login('jsmith'), issue.assigned_to
613 assert_equal User.find_by_login('jsmith'), issue.assigned_to
607 assert_equal "52.6", issue.custom_value_for(CustomField.find_by_name('Float field')).value
614 assert_equal "52.6", issue.custom_value_for(CustomField.find_by_name('Float field')).value
608 # keywords should be removed from the email body
615 # keywords should be removed from the email body
609 assert !journal.notes.match(/^Status:/i)
616 assert !journal.notes.match(/^Status:/i)
610 assert !journal.notes.match(/^Start Date:/i)
617 assert !journal.notes.match(/^Start Date:/i)
611 end
618 end
612
619
613 def test_update_issue_with_attachment
620 def test_update_issue_with_attachment
614 assert_difference 'Journal.count' do
621 assert_difference 'Journal.count' do
615 assert_difference 'JournalDetail.count' do
622 assert_difference 'JournalDetail.count' do
616 assert_difference 'Attachment.count' do
623 assert_difference 'Attachment.count' do
617 assert_no_difference 'Issue.count' do
624 assert_no_difference 'Issue.count' do
618 journal = submit_email('ticket_with_attachment.eml') do |raw|
625 journal = submit_email('ticket_with_attachment.eml') do |raw|
619 raw.gsub! /^Subject: .*$/, 'Subject: Re: [Cookbook - Feature #2] (New) Add ingredients categories'
626 raw.gsub! /^Subject: .*$/, 'Subject: Re: [Cookbook - Feature #2] (New) Add ingredients categories'
620 end
627 end
621 end
628 end
622 end
629 end
623 end
630 end
624 end
631 end
625 journal = Journal.first(:order => 'id DESC')
632 journal = Journal.first(:order => 'id DESC')
626 assert_equal Issue.find(2), journal.journalized
633 assert_equal Issue.find(2), journal.journalized
627 assert_equal 1, journal.details.size
634 assert_equal 1, journal.details.size
628
635
629 detail = journal.details.first
636 detail = journal.details.first
630 assert_equal 'attachment', detail.property
637 assert_equal 'attachment', detail.property
631 assert_equal 'Paella.jpg', detail.value
638 assert_equal 'Paella.jpg', detail.value
632 end
639 end
633
640
634 def test_update_issue_should_send_email_notification
641 def test_update_issue_should_send_email_notification
635 ActionMailer::Base.deliveries.clear
642 ActionMailer::Base.deliveries.clear
636 journal = submit_email('ticket_reply.eml')
643 journal = submit_email('ticket_reply.eml')
637 assert journal.is_a?(Journal)
644 assert journal.is_a?(Journal)
638 assert_equal 1, ActionMailer::Base.deliveries.size
645 assert_equal 1, ActionMailer::Base.deliveries.size
639 end
646 end
640
647
641 def test_update_issue_should_not_set_defaults
648 def test_update_issue_should_not_set_defaults
642 journal = submit_email(
649 journal = submit_email(
643 'ticket_reply.eml',
650 'ticket_reply.eml',
644 :issue => {:tracker => 'Support request', :priority => 'High'}
651 :issue => {:tracker => 'Support request', :priority => 'High'}
645 )
652 )
646 assert journal.is_a?(Journal)
653 assert journal.is_a?(Journal)
647 assert_match /This is reply/, journal.notes
654 assert_match /This is reply/, journal.notes
648 assert_equal 'Feature request', journal.issue.tracker.name
655 assert_equal 'Feature request', journal.issue.tracker.name
649 assert_equal 'Normal', journal.issue.priority.name
656 assert_equal 'Normal', journal.issue.priority.name
650 end
657 end
651
658
652 def test_replying_to_a_private_note_should_add_reply_as_private
659 def test_replying_to_a_private_note_should_add_reply_as_private
653 private_journal = Journal.create!(:notes => 'Private notes', :journalized => Issue.find(1), :private_notes => true, :user_id => 2)
660 private_journal = Journal.create!(:notes => 'Private notes', :journalized => Issue.find(1), :private_notes => true, :user_id => 2)
654
661
655 assert_difference 'Journal.count' do
662 assert_difference 'Journal.count' do
656 journal = submit_email('ticket_reply.eml') do |email|
663 journal = submit_email('ticket_reply.eml') do |email|
657 email.sub! %r{^In-Reply-To:.*$}, "In-Reply-To: <redmine.journal-#{private_journal.id}.20060719210421@osiris>"
664 email.sub! %r{^In-Reply-To:.*$}, "In-Reply-To: <redmine.journal-#{private_journal.id}.20060719210421@osiris>"
658 end
665 end
659
666
660 assert_kind_of Journal, journal
667 assert_kind_of Journal, journal
661 assert_match /This is reply/, journal.notes
668 assert_match /This is reply/, journal.notes
662 assert_equal true, journal.private_notes
669 assert_equal true, journal.private_notes
663 end
670 end
664 end
671 end
665
672
666 def test_reply_to_a_message
673 def test_reply_to_a_message
667 m = submit_email('message_reply.eml')
674 m = submit_email('message_reply.eml')
668 assert m.is_a?(Message)
675 assert m.is_a?(Message)
669 assert !m.new_record?
676 assert !m.new_record?
670 m.reload
677 m.reload
671 assert_equal 'Reply via email', m.subject
678 assert_equal 'Reply via email', m.subject
672 # The email replies to message #2 which is part of the thread of message #1
679 # The email replies to message #2 which is part of the thread of message #1
673 assert_equal Message.find(1), m.parent
680 assert_equal Message.find(1), m.parent
674 end
681 end
675
682
676 def test_reply_to_a_message_by_subject
683 def test_reply_to_a_message_by_subject
677 m = submit_email('message_reply_by_subject.eml')
684 m = submit_email('message_reply_by_subject.eml')
678 assert m.is_a?(Message)
685 assert m.is_a?(Message)
679 assert !m.new_record?
686 assert !m.new_record?
680 m.reload
687 m.reload
681 assert_equal 'Reply to the first post', m.subject
688 assert_equal 'Reply to the first post', m.subject
682 assert_equal Message.find(1), m.parent
689 assert_equal Message.find(1), m.parent
683 end
690 end
684
691
685 def test_should_strip_tags_of_html_only_emails
692 def test_should_strip_tags_of_html_only_emails
686 issue = submit_email('ticket_html_only.eml', :issue => {:project => 'ecookbook'})
693 issue = submit_email('ticket_html_only.eml', :issue => {:project => 'ecookbook'})
687 assert issue.is_a?(Issue)
694 assert issue.is_a?(Issue)
688 assert !issue.new_record?
695 assert !issue.new_record?
689 issue.reload
696 issue.reload
690 assert_equal 'HTML email', issue.subject
697 assert_equal 'HTML email', issue.subject
691 assert_equal 'This is a html-only email.', issue.description
698 assert_equal 'This is a html-only email.', issue.description
692 end
699 end
693
700
694 test "truncate emails with no setting should add the entire email into the issue" do
701 test "truncate emails with no setting should add the entire email into the issue" do
695 with_settings :mail_handler_body_delimiters => '' do
702 with_settings :mail_handler_body_delimiters => '' do
696 issue = submit_email('ticket_on_given_project.eml')
703 issue = submit_email('ticket_on_given_project.eml')
697 assert_issue_created(issue)
704 assert_issue_created(issue)
698 assert issue.description.include?('---')
705 assert issue.description.include?('---')
699 assert issue.description.include?('This paragraph is after the delimiter')
706 assert issue.description.include?('This paragraph is after the delimiter')
700 end
707 end
701 end
708 end
702
709
703 test "truncate emails with a single string should truncate the email at the delimiter for the issue" do
710 test "truncate emails with a single string should truncate the email at the delimiter for the issue" do
704 with_settings :mail_handler_body_delimiters => '---' do
711 with_settings :mail_handler_body_delimiters => '---' do
705 issue = submit_email('ticket_on_given_project.eml')
712 issue = submit_email('ticket_on_given_project.eml')
706 assert_issue_created(issue)
713 assert_issue_created(issue)
707 assert issue.description.include?('This paragraph is before delimiters')
714 assert issue.description.include?('This paragraph is before delimiters')
708 assert issue.description.include?('--- This line starts with a delimiter')
715 assert issue.description.include?('--- This line starts with a delimiter')
709 assert !issue.description.match(/^---$/)
716 assert !issue.description.match(/^---$/)
710 assert !issue.description.include?('This paragraph is after the delimiter')
717 assert !issue.description.include?('This paragraph is after the delimiter')
711 end
718 end
712 end
719 end
713
720
714 test "truncate emails with a single quoted reply should truncate the email at the delimiter with the quoted reply symbols (>)" do
721 test "truncate emails with a single quoted reply should truncate the email at the delimiter with the quoted reply symbols (>)" do
715 with_settings :mail_handler_body_delimiters => '--- Reply above. Do not remove this line. ---' do
722 with_settings :mail_handler_body_delimiters => '--- Reply above. Do not remove this line. ---' do
716 journal = submit_email('issue_update_with_quoted_reply_above.eml')
723 journal = submit_email('issue_update_with_quoted_reply_above.eml')
717 assert journal.is_a?(Journal)
724 assert journal.is_a?(Journal)
718 assert journal.notes.include?('An update to the issue by the sender.')
725 assert journal.notes.include?('An update to the issue by the sender.')
719 assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
726 assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
720 assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
727 assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
721 end
728 end
722 end
729 end
723
730
724 test "truncate emails with multiple quoted replies should truncate the email at the delimiter with the quoted reply symbols (>)" do
731 test "truncate emails with multiple quoted replies should truncate the email at the delimiter with the quoted reply symbols (>)" do
725 with_settings :mail_handler_body_delimiters => '--- Reply above. Do not remove this line. ---' do
732 with_settings :mail_handler_body_delimiters => '--- Reply above. Do not remove this line. ---' do
726 journal = submit_email('issue_update_with_multiple_quoted_reply_above.eml')
733 journal = submit_email('issue_update_with_multiple_quoted_reply_above.eml')
727 assert journal.is_a?(Journal)
734 assert journal.is_a?(Journal)
728 assert journal.notes.include?('An update to the issue by the sender.')
735 assert journal.notes.include?('An update to the issue by the sender.')
729 assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
736 assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
730 assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
737 assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
731 end
738 end
732 end
739 end
733
740
734 test "truncate emails with multiple strings should truncate the email at the first delimiter found (BREAK)" do
741 test "truncate emails with multiple strings should truncate the email at the first delimiter found (BREAK)" do
735 with_settings :mail_handler_body_delimiters => "---\nBREAK" do
742 with_settings :mail_handler_body_delimiters => "---\nBREAK" do
736 issue = submit_email('ticket_on_given_project.eml')
743 issue = submit_email('ticket_on_given_project.eml')
737 assert_issue_created(issue)
744 assert_issue_created(issue)
738 assert issue.description.include?('This paragraph is before delimiters')
745 assert issue.description.include?('This paragraph is before delimiters')
739 assert !issue.description.include?('BREAK')
746 assert !issue.description.include?('BREAK')
740 assert !issue.description.include?('This paragraph is between delimiters')
747 assert !issue.description.include?('This paragraph is between delimiters')
741 assert !issue.description.match(/^---$/)
748 assert !issue.description.match(/^---$/)
742 assert !issue.description.include?('This paragraph is after the delimiter')
749 assert !issue.description.include?('This paragraph is after the delimiter')
743 end
750 end
744 end
751 end
745
752
746 def test_email_with_long_subject_line
753 def test_email_with_long_subject_line
747 issue = submit_email('ticket_with_long_subject.eml')
754 issue = submit_email('ticket_with_long_subject.eml')
748 assert issue.is_a?(Issue)
755 assert issue.is_a?(Issue)
749 assert_equal issue.subject, 'New ticket on a given project with a very long subject line which exceeds 255 chars and should not be ignored but chopped off. And if the subject line is still not long enough, we just add more text. And more text. Wow, this is really annoying. Especially, if you have nothing to say...'[0,255]
756 assert_equal issue.subject, 'New ticket on a given project with a very long subject line which exceeds 255 chars and should not be ignored but chopped off. And if the subject line is still not long enough, we just add more text. And more text. Wow, this is really annoying. Especially, if you have nothing to say...'[0,255]
750 end
757 end
751
758
752 def test_new_user_from_attributes_should_return_valid_user
759 def test_new_user_from_attributes_should_return_valid_user
753 to_test = {
760 to_test = {
754 # [address, name] => [login, firstname, lastname]
761 # [address, name] => [login, firstname, lastname]
755 ['jsmith@example.net', nil] => ['jsmith@example.net', 'jsmith', '-'],
762 ['jsmith@example.net', nil] => ['jsmith@example.net', 'jsmith', '-'],
756 ['jsmith@example.net', 'John'] => ['jsmith@example.net', 'John', '-'],
763 ['jsmith@example.net', 'John'] => ['jsmith@example.net', 'John', '-'],
757 ['jsmith@example.net', 'John Smith'] => ['jsmith@example.net', 'John', 'Smith'],
764 ['jsmith@example.net', 'John Smith'] => ['jsmith@example.net', 'John', 'Smith'],
758 ['jsmith@example.net', 'John Paul Smith'] => ['jsmith@example.net', 'John', 'Paul Smith'],
765 ['jsmith@example.net', 'John Paul Smith'] => ['jsmith@example.net', 'John', 'Paul Smith'],
759 ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsTheMaximumLength Smith'] => ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsT', 'Smith'],
766 ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsTheMaximumLength Smith'] => ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsT', 'Smith'],
760 ['jsmith@example.net', 'John AVeryLongLastnameThatExceedsTheMaximumLength'] => ['jsmith@example.net', 'John', 'AVeryLongLastnameThatExceedsTh']
767 ['jsmith@example.net', 'John AVeryLongLastnameThatExceedsTheMaximumLength'] => ['jsmith@example.net', 'John', 'AVeryLongLastnameThatExceedsTh']
761 }
768 }
762
769
763 to_test.each do |attrs, expected|
770 to_test.each do |attrs, expected|
764 user = MailHandler.new_user_from_attributes(attrs.first, attrs.last)
771 user = MailHandler.new_user_from_attributes(attrs.first, attrs.last)
765
772
766 assert user.valid?, user.errors.full_messages.to_s
773 assert user.valid?, user.errors.full_messages.to_s
767 assert_equal attrs.first, user.mail
774 assert_equal attrs.first, user.mail
768 assert_equal expected[0], user.login
775 assert_equal expected[0], user.login
769 assert_equal expected[1], user.firstname
776 assert_equal expected[1], user.firstname
770 assert_equal expected[2], user.lastname
777 assert_equal expected[2], user.lastname
771 assert_equal 'only_my_events', user.mail_notification
778 assert_equal 'only_my_events', user.mail_notification
772 end
779 end
773 end
780 end
774
781
775 def test_new_user_from_attributes_should_use_default_login_if_invalid
782 def test_new_user_from_attributes_should_use_default_login_if_invalid
776 user = MailHandler.new_user_from_attributes('foo+bar@example.net')
783 user = MailHandler.new_user_from_attributes('foo+bar@example.net')
777 assert user.valid?
784 assert user.valid?
778 assert user.login =~ /^user[a-f0-9]+$/
785 assert user.login =~ /^user[a-f0-9]+$/
779 assert_equal 'foo+bar@example.net', user.mail
786 assert_equal 'foo+bar@example.net', user.mail
780 end
787 end
781
788
782 def test_new_user_with_utf8_encoded_fullname_should_be_decoded
789 def test_new_user_with_utf8_encoded_fullname_should_be_decoded
783 assert_difference 'User.count' do
790 assert_difference 'User.count' do
784 issue = submit_email(
791 issue = submit_email(
785 'fullname_of_sender_as_utf8_encoded.eml',
792 'fullname_of_sender_as_utf8_encoded.eml',
786 :issue => {:project => 'ecookbook'},
793 :issue => {:project => 'ecookbook'},
787 :unknown_user => 'create'
794 :unknown_user => 'create'
788 )
795 )
789 end
796 end
790
797
791 user = User.first(:order => 'id DESC')
798 user = User.first(:order => 'id DESC')
792 assert_equal "foo@example.org", user.mail
799 assert_equal "foo@example.org", user.mail
793 str1 = "\xc3\x84\xc3\xa4"
800 str1 = "\xc3\x84\xc3\xa4"
794 str2 = "\xc3\x96\xc3\xb6"
801 str2 = "\xc3\x96\xc3\xb6"
795 str1.force_encoding('UTF-8') if str1.respond_to?(:force_encoding)
802 str1.force_encoding('UTF-8') if str1.respond_to?(:force_encoding)
796 str2.force_encoding('UTF-8') if str2.respond_to?(:force_encoding)
803 str2.force_encoding('UTF-8') if str2.respond_to?(:force_encoding)
797 assert_equal str1, user.firstname
804 assert_equal str1, user.firstname
798 assert_equal str2, user.lastname
805 assert_equal str2, user.lastname
799 end
806 end
800
807
801 def test_extract_options_from_env_should_return_options
808 def test_extract_options_from_env_should_return_options
802 options = MailHandler.extract_options_from_env({
809 options = MailHandler.extract_options_from_env({
803 'tracker' => 'defect',
810 'tracker' => 'defect',
804 'project' => 'foo',
811 'project' => 'foo',
805 'unknown_user' => 'create'
812 'unknown_user' => 'create'
806 })
813 })
807
814
808 assert_equal({
815 assert_equal({
809 :issue => {:tracker => 'defect', :project => 'foo'},
816 :issue => {:tracker => 'defect', :project => 'foo'},
810 :unknown_user => 'create'
817 :unknown_user => 'create'
811 }, options)
818 }, options)
812 end
819 end
813
820
814 private
821 private
815
822
816 def submit_email(filename, options={})
823 def submit_email(filename, options={})
817 raw = IO.read(File.join(FIXTURES_PATH, filename))
824 raw = IO.read(File.join(FIXTURES_PATH, filename))
818 yield raw if block_given?
825 yield raw if block_given?
819 MailHandler.receive(raw, options)
826 MailHandler.receive(raw, options)
820 end
827 end
821
828
822 def assert_issue_created(issue)
829 def assert_issue_created(issue)
823 assert issue.is_a?(Issue)
830 assert issue.is_a?(Issue)
824 assert !issue.new_record?
831 assert !issue.new_record?
825 issue.reload
832 issue.reload
826 end
833 end
827 end
834 end
General Comments 0
You need to be logged in to leave comments. Login now