##// END OF EJS Templates
jro_apps » redmine
RSS
Make sure that dates are stored as YYYY-MM-DD in journal details (#12713)....
Jean-Philippe Lang -
r10887:9adb0c61a903
parent child
Show More
Side by Side Unified
Context file:
r10887:9adb0c61a903 Loading diff...:
Show file before | Show file after | Hide comments
@@ -27,10 +27,13 class JournalDetail < ActiveRecord::Base
27 end
27 end
28
28
29 def normalize(v)
29 def normalize(v)
30 if v == true
30 case v
31 when true
31 "1"
32 "1"
32 elsif v == false
33 when false
33 "0"
34 "0"
35 when Date
36 v.strftime("%Y-%m-%d")
34 else
37 else
35 v
38 v
36 end
39 end
Show file before | Show file after | Hide comments
@@ -154,4 +154,25 class JournalTest < ActiveSupport::TestCase
154 # Admin should see issues on private projects that he does not belong to
154 # Admin should see issues on private projects that he does not belong to
155 assert journals.detect {|journal| !journal.issue.project.is_public?}
155 assert journals.detect {|journal| !journal.issue.project.is_public?}
156 end
156 end
157
158 def test_details_should_normalize_dates
159 j = JournalDetail.create!(:old_value => Date.parse('2012-11-03'), :value => Date.parse('2013-01-02'))
160 j.reload
161 assert_equal '2012-11-03', j.old_value
162 assert_equal '2013-01-02', j.value
163 end
164
165 def test_details_should_normalize_true_values
166 j = JournalDetail.create!(:old_value => true, :value => true)
167 j.reload
168 assert_equal '1', j.old_value
169 assert_equal '1', j.value
170 end
171
172 def test_details_should_normalize_false_values
173 j = JournalDetail.create!(:old_value => false, :value => false)
174 j.reload
175 assert_equal '0', j.old_value
176 assert_equal '0', j.value
177 end
157 end
178 end
General Comments 0
You need to be logged in to leave comments. Login now