jro_apps/redmine Commit - r7659:981a6223e40e

Custom date field accepts invalid dates (#9394)....

Jean-Philippe Lang -

r7659:981a6223e40e

parent child

Context file:

r7659:981a6223e40e

app/models/custom_value.rb +1 -1

                    when 'float'
                      begin; Kernel.Float(value); rescue; errors.add(:value, :invalid) end
                    when 'date'
-                     errors.add(:value, :not_a_date) unless value =~ /^\d{4}-\d{2}-\d{2}$/
+                     errors.add(:value, :not_a_date) unless value =~ /^\d{4}-\d{2}-\d{2}$/ && begin; value.to_date; rescue; false end
                    when 'list'
                      errors.add(:value, :inclusion) unless custom_field.possible_values.include?(value)
                    end

test/unit/custom_value_test.rb +2 0

                  assert v.valid?
                  v.value = 'abc'
                  assert !v.valid?
+                 v.value = '1975-07-33'
+                 assert !v.valid?
                  v.value = '1975-07-14'
                  assert v.valid?
                end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages