jro_apps/redmine Commit - r10689:96fca0b08f6d

Replaces find(:all) calls....

Jean-Philippe Lang -

r10689:96fca0b08f6d

parent child

Context file:

r10689:96fca0b08f6d

Collapse all files

app/controllers/projects_controller.rb +4 -4

               end
               def new
-                @issue_custom_fields = IssueCustomField.find(:all, :order => "#{CustomField.table_name}.position")
+                @issue_custom_fields = IssueCustomField.sorted.all
                 @trackers = Tracker.sorted.all
                 @project = Project.new
                 @project.safe_attributes = params[:project]
               end
               def create
-                @issue_custom_fields = IssueCustomField.find(:all, :order => "#{CustomField.table_name}.position")
+                @issue_custom_fields = IssueCustomField.sorted.all
                 @trackers = Tracker.sorted.all
                 @project = Project.new
                 @project.safe_attributes = params[:project]
               end
               def copy
-                @issue_custom_fields = IssueCustomField.find(:all, :order => "#{CustomField.table_name}.position")
+                @issue_custom_fields = IssueCustomField.sorted.all
                 @trackers = Tracker.sorted.all
                 @source_project = Project.find(params[:id])
                 if request.get?
               end
               def settings
-                @issue_custom_fields = IssueCustomField.find(:all, :order => "#{CustomField.table_name}.position")
+                @issue_custom_fields = IssueCustomField.sorted.all
                 @issue_category ||= IssueCategory.new
                 @member ||= @project.members.new
                 @trackers = Tracker.sorted.all

app/helpers/repositories_helper.rb +1 -1

               end
               def render_changeset_changes
-                changes = @changeset.filechanges.find(:all, :limit => 1000, :order => 'path').collect do |change|
+                changes = @changeset.filechanges.limit(1000).reorder('path').all.collect do |change|
                   case change.action
                   when 'A'
                     # Detects moved/copied files

app/helpers/timelog_helper.rb +1 -1

               def entries_to_csv(entries)
                 decimal_separator = l(:general_csv_decimal_separator)
-                custom_fields = TimeEntryCustomField.find(:all)
+                custom_fields = TimeEntryCustomField.all
                 export = FCSV.generate(:col_sep => l(:general_csv_separator)) do |csv|
                   # csv header fields
                   headers = [l(:field_spent_on),

app/models/custom_field.rb +2 0

               validate :validate_custom_field
               before_validation :set_searchable
+              scope :sorted, order("#{table_name}.position ASC")
               CUSTOM_FIELDS_TABS = [
                 {:name => 'IssueCustomField', :partial => 'custom_fields/index',
                  :label => :label_issue_plural},

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages