##// END OF EJS Templates
jro_apps » redmine
RSS
code layout clean up of test_should_not_close_duplicated_issue at test/unit/issue_test.rb...
Toshi MARUYAMA -
r7360:96e56f52ad70
parent child
Show More
Side by Side Unified
Context file:
r7360:96e56f52ad70 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1104 +1,1106
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :trackers, :projects_trackers,
23 23 :enabled_modules,
24 24 :versions,
25 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 26 :enumerations,
27 27 :issues,
28 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 29 :time_entries
30 30
31 31 def test_create
32 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
33 33 :status_id => 1, :priority => IssuePriority.all.first,
34 34 :subject => 'test_create',
35 35 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
36 36 assert issue.save
37 37 issue.reload
38 38 assert_equal 1.5, issue.estimated_hours
39 39 end
40 40
41 41 def test_create_minimal
42 42 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
43 43 :status_id => 1, :priority => IssuePriority.all.first,
44 44 :subject => 'test_create')
45 45 assert issue.save
46 46 assert issue.description.nil?
47 47 end
48 48
49 49 def test_create_with_required_custom_field
50 50 field = IssueCustomField.find_by_name('Database')
51 51 field.update_attribute(:is_required, true)
52 52
53 53 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
54 54 :status_id => 1, :subject => 'test_create',
55 55 :description => 'IssueTest#test_create_with_required_custom_field')
56 56 assert issue.available_custom_fields.include?(field)
57 57 # No value for the custom field
58 58 assert !issue.save
59 59 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
60 60 # Blank value
61 61 issue.custom_field_values = { field.id => '' }
62 62 assert !issue.save
63 63 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
64 64 # Invalid value
65 65 issue.custom_field_values = { field.id => 'SQLServer' }
66 66 assert !issue.save
67 67 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
68 68 # Valid value
69 69 issue.custom_field_values = { field.id => 'PostgreSQL' }
70 70 assert issue.save
71 71 issue.reload
72 72 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
73 73 end
74 74
75 75 def test_create_with_group_assignment
76 76 with_settings :issue_group_assignment => '1' do
77 77 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
78 78 :subject => 'Group assignment',
79 79 :assigned_to_id => 11).save
80 80 issue = Issue.first(:order => 'id DESC')
81 81 assert_kind_of Group, issue.assigned_to
82 82 assert_equal Group.find(11), issue.assigned_to
83 83 end
84 84 end
85 85
86 86 def assert_visibility_match(user, issues)
87 87 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
88 88 end
89 89
90 90 def test_visible_scope_for_anonymous
91 91 # Anonymous user should see issues of public projects only
92 92 issues = Issue.visible(User.anonymous).all
93 93 assert issues.any?
94 94 assert_nil issues.detect {|issue| !issue.project.is_public?}
95 95 assert_nil issues.detect {|issue| issue.is_private?}
96 96 assert_visibility_match User.anonymous, issues
97 97 end
98 98
99 99 def test_visible_scope_for_anonymous_with_own_issues_visibility
100 100 Role.anonymous.update_attribute :issues_visibility, 'own'
101 101 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
102 102
103 103 issues = Issue.visible(User.anonymous).all
104 104 assert issues.any?
105 105 assert_nil issues.detect {|issue| issue.author != User.anonymous}
106 106 assert_visibility_match User.anonymous, issues
107 107 end
108 108
109 109 def test_visible_scope_for_anonymous_without_view_issues_permissions
110 110 # Anonymous user should not see issues without permission
111 111 Role.anonymous.remove_permission!(:view_issues)
112 112 issues = Issue.visible(User.anonymous).all
113 113 assert issues.empty?
114 114 assert_visibility_match User.anonymous, issues
115 115 end
116 116
117 117 def test_visible_scope_for_non_member
118 118 user = User.find(9)
119 119 assert user.projects.empty?
120 120 # Non member user should see issues of public projects only
121 121 issues = Issue.visible(user).all
122 122 assert issues.any?
123 123 assert_nil issues.detect {|issue| !issue.project.is_public?}
124 124 assert_nil issues.detect {|issue| issue.is_private?}
125 125 assert_visibility_match user, issues
126 126 end
127 127
128 128 def test_visible_scope_for_non_member_with_own_issues_visibility
129 129 Role.non_member.update_attribute :issues_visibility, 'own'
130 130 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
131 131 user = User.find(9)
132 132
133 133 issues = Issue.visible(user).all
134 134 assert issues.any?
135 135 assert_nil issues.detect {|issue| issue.author != user}
136 136 assert_visibility_match user, issues
137 137 end
138 138
139 139 def test_visible_scope_for_non_member_without_view_issues_permissions
140 140 # Non member user should not see issues without permission
141 141 Role.non_member.remove_permission!(:view_issues)
142 142 user = User.find(9)
143 143 assert user.projects.empty?
144 144 issues = Issue.visible(user).all
145 145 assert issues.empty?
146 146 assert_visibility_match user, issues
147 147 end
148 148
149 149 def test_visible_scope_for_member
150 150 user = User.find(9)
151 151 # User should see issues of projects for which he has view_issues permissions only
152 152 Role.non_member.remove_permission!(:view_issues)
153 153 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
154 154 issues = Issue.visible(user).all
155 155 assert issues.any?
156 156 assert_nil issues.detect {|issue| issue.project_id != 3}
157 157 assert_nil issues.detect {|issue| issue.is_private?}
158 158 assert_visibility_match user, issues
159 159 end
160 160
161 161 def test_visible_scope_for_admin
162 162 user = User.find(1)
163 163 user.members.each(&:destroy)
164 164 assert user.projects.empty?
165 165 issues = Issue.visible(user).all
166 166 assert issues.any?
167 167 # Admin should see issues on private projects that he does not belong to
168 168 assert issues.detect {|issue| !issue.project.is_public?}
169 169 # Admin should see private issues of other users
170 170 assert issues.detect {|issue| issue.is_private? && issue.author != user}
171 171 assert_visibility_match user, issues
172 172 end
173 173
174 174 def test_visible_scope_with_project
175 175 project = Project.find(1)
176 176 issues = Issue.visible(User.find(2), :project => project).all
177 177 projects = issues.collect(&:project).uniq
178 178 assert_equal 1, projects.size
179 179 assert_equal project, projects.first
180 180 end
181 181
182 182 def test_visible_scope_with_project_and_subprojects
183 183 project = Project.find(1)
184 184 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
185 185 projects = issues.collect(&:project).uniq
186 186 assert projects.size > 1
187 187 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
188 188 end
189 189
190 190 def test_visible_and_nested_set_scopes
191 191 assert_equal 0, Issue.find(1).descendants.visible.all.size
192 192 end
193 193
194 194 def test_errors_full_messages_should_include_custom_fields_errors
195 195 field = IssueCustomField.find_by_name('Database')
196 196
197 197 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
198 198 :status_id => 1, :subject => 'test_create',
199 199 :description => 'IssueTest#test_create_with_required_custom_field')
200 200 assert issue.available_custom_fields.include?(field)
201 201 # Invalid value
202 202 issue.custom_field_values = { field.id => 'SQLServer' }
203 203
204 204 assert !issue.valid?
205 205 assert_equal 1, issue.errors.full_messages.size
206 206 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
207 207 end
208 208
209 209 def test_update_issue_with_required_custom_field
210 210 field = IssueCustomField.find_by_name('Database')
211 211 field.update_attribute(:is_required, true)
212 212
213 213 issue = Issue.find(1)
214 214 assert_nil issue.custom_value_for(field)
215 215 assert issue.available_custom_fields.include?(field)
216 216 # No change to custom values, issue can be saved
217 217 assert issue.save
218 218 # Blank value
219 219 issue.custom_field_values = { field.id => '' }
220 220 assert !issue.save
221 221 # Valid value
222 222 issue.custom_field_values = { field.id => 'PostgreSQL' }
223 223 assert issue.save
224 224 issue.reload
225 225 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
226 226 end
227 227
228 228 def test_should_not_update_attributes_if_custom_fields_validation_fails
229 229 issue = Issue.find(1)
230 230 field = IssueCustomField.find_by_name('Database')
231 231 assert issue.available_custom_fields.include?(field)
232 232
233 233 issue.custom_field_values = { field.id => 'Invalid' }
234 234 issue.subject = 'Should be not be saved'
235 235 assert !issue.save
236 236
237 237 issue.reload
238 238 assert_equal "Can't print recipes", issue.subject
239 239 end
240 240
241 241 def test_should_not_recreate_custom_values_objects_on_update
242 242 field = IssueCustomField.find_by_name('Database')
243 243
244 244 issue = Issue.find(1)
245 245 issue.custom_field_values = { field.id => 'PostgreSQL' }
246 246 assert issue.save
247 247 custom_value = issue.custom_value_for(field)
248 248 issue.reload
249 249 issue.custom_field_values = { field.id => 'MySQL' }
250 250 assert issue.save
251 251 issue.reload
252 252 assert_equal custom_value.id, issue.custom_value_for(field).id
253 253 end
254 254
255 255 def test_assigning_tracker_id_should_reload_custom_fields_values
256 256 issue = Issue.new(:project => Project.find(1))
257 257 assert issue.custom_field_values.empty?
258 258 issue.tracker_id = 1
259 259 assert issue.custom_field_values.any?
260 260 end
261 261
262 262 def test_assigning_attributes_should_assign_tracker_id_first
263 263 attributes = ActiveSupport::OrderedHash.new
264 264 attributes['custom_field_values'] = { '1' => 'MySQL' }
265 265 attributes['tracker_id'] = '1'
266 266 issue = Issue.new(:project => Project.find(1))
267 267 issue.attributes = attributes
268 268 assert_not_nil issue.custom_value_for(1)
269 269 assert_equal 'MySQL', issue.custom_value_for(1).value
270 270 end
271 271
272 272 def test_should_update_issue_with_disabled_tracker
273 273 p = Project.find(1)
274 274 issue = Issue.find(1)
275 275
276 276 p.trackers.delete(issue.tracker)
277 277 assert !p.trackers.include?(issue.tracker)
278 278
279 279 issue.reload
280 280 issue.subject = 'New subject'
281 281 assert issue.save
282 282 end
283 283
284 284 def test_should_not_set_a_disabled_tracker
285 285 p = Project.find(1)
286 286 p.trackers.delete(Tracker.find(2))
287 287
288 288 issue = Issue.find(1)
289 289 issue.tracker_id = 2
290 290 issue.subject = 'New subject'
291 291 assert !issue.save
292 292 assert_not_nil issue.errors.on(:tracker_id)
293 293 end
294 294
295 295 def test_category_based_assignment
296 296 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
297 297 :status_id => 1, :priority => IssuePriority.all.first,
298 298 :subject => 'Assignment test',
299 299 :description => 'Assignment test', :category_id => 1)
300 300 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
301 301 end
302 302
303 303 def test_new_statuses_allowed_to
304 304 Workflow.delete_all
305 305
306 306 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
307 307 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
308 308 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
309 309 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
310 310 status = IssueStatus.find(1)
311 311 role = Role.find(1)
312 312 tracker = Tracker.find(1)
313 313 user = User.find(2)
314 314
315 315 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
316 316 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
317 317
318 318 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
319 319 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
320 320
321 321 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
322 322 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
323 323
324 324 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
325 325 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
326 326 end
327 327
328 328 def test_copy
329 329 issue = Issue.new.copy_from(1)
330 330 assert issue.save
331 331 issue.reload
332 332 orig = Issue.find(1)
333 333 assert_equal orig.subject, issue.subject
334 334 assert_equal orig.tracker, issue.tracker
335 335 assert_equal "125", issue.custom_value_for(2).value
336 336 end
337 337
338 338 def test_copy_should_copy_status
339 339 orig = Issue.find(8)
340 340 assert orig.status != IssueStatus.default
341 341
342 342 issue = Issue.new.copy_from(orig)
343 343 assert issue.save
344 344 issue.reload
345 345 assert_equal orig.status, issue.status
346 346 end
347 347
348 348 def test_should_close_duplicates
349 349 # Create 3 issues
350 350 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
351 351 assert issue1.save
352 352 issue2 = issue1.clone
353 353 assert issue2.save
354 354 issue3 = issue1.clone
355 355 assert issue3.save
356 356
357 357 # 2 is a dupe of 1
358 358 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
359 359 # And 3 is a dupe of 2
360 360 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
361 361 # And 3 is a dupe of 1 (circular duplicates)
362 362 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
363 363
364 364 assert issue1.reload.duplicates.include?(issue2)
365 365
366 366 # Closing issue 1
367 367 issue1.init_journal(User.find(:first), "Closing issue1")
368 368 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
369 369 assert issue1.save
370 370 # 2 and 3 should be also closed
371 371 assert issue2.reload.closed?
372 372 assert issue3.reload.closed?
373 373 end
374 374
375 375 def test_should_not_close_duplicated_issue
376 376 # Create 3 issues
377 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
377 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
378 :status_id => 1, :priority => IssuePriority.all.first,
379 :subject => 'Duplicates test', :description => 'Duplicates test')
378 380 assert issue1.save
379 381 issue2 = issue1.clone
380 382 assert issue2.save
381 383
382 384 # 2 is a dupe of 1
383 385 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
384 386 # 2 is a dup of 1 but 1 is not a duplicate of 2
385 387 assert !issue2.reload.duplicates.include?(issue1)
386 388
387 389 # Closing issue 2
388 390 issue2.init_journal(User.find(:first), "Closing issue2")
389 391 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
390 392 assert issue2.save
391 393 # 1 should not be also closed
392 394 assert !issue1.reload.closed?
393 395 end
394 396
395 397 def test_assignable_versions
396 398 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
397 399 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
398 400 end
399 401
400 402 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
401 403 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
402 404 assert !issue.save
403 405 assert_not_nil issue.errors.on(:fixed_version_id)
404 406 end
405 407
406 408 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
407 409 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
408 410 assert !issue.save
409 411 assert_not_nil issue.errors.on(:fixed_version_id)
410 412 end
411 413
412 414 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
413 415 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
414 416 assert issue.save
415 417 end
416 418
417 419 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
418 420 issue = Issue.find(11)
419 421 assert_equal 'closed', issue.fixed_version.status
420 422 issue.subject = 'Subject changed'
421 423 assert issue.save
422 424 end
423 425
424 426 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
425 427 issue = Issue.find(11)
426 428 issue.status_id = 1
427 429 assert !issue.save
428 430 assert_not_nil issue.errors.on_base
429 431 end
430 432
431 433 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
432 434 issue = Issue.find(11)
433 435 issue.status_id = 1
434 436 issue.fixed_version_id = 3
435 437 assert issue.save
436 438 end
437 439
438 440 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
439 441 issue = Issue.find(12)
440 442 assert_equal 'locked', issue.fixed_version.status
441 443 issue.status_id = 1
442 444 assert issue.save
443 445 end
444 446
445 447 def test_move_to_another_project_with_same_category
446 448 issue = Issue.find(1)
447 449 assert issue.move_to_project(Project.find(2))
448 450 issue.reload
449 451 assert_equal 2, issue.project_id
450 452 # Category changes
451 453 assert_equal 4, issue.category_id
452 454 # Make sure time entries were move to the target project
453 455 assert_equal 2, issue.time_entries.first.project_id
454 456 end
455 457
456 458 def test_move_to_another_project_without_same_category
457 459 issue = Issue.find(2)
458 460 assert issue.move_to_project(Project.find(2))
459 461 issue.reload
460 462 assert_equal 2, issue.project_id
461 463 # Category cleared
462 464 assert_nil issue.category_id
463 465 end
464 466
465 467 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
466 468 issue = Issue.find(1)
467 469 issue.update_attribute(:fixed_version_id, 1)
468 470 assert issue.move_to_project(Project.find(2))
469 471 issue.reload
470 472 assert_equal 2, issue.project_id
471 473 # Cleared fixed_version
472 474 assert_equal nil, issue.fixed_version
473 475 end
474 476
475 477 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
476 478 issue = Issue.find(1)
477 479 issue.update_attribute(:fixed_version_id, 4)
478 480 assert issue.move_to_project(Project.find(5))
479 481 issue.reload
480 482 assert_equal 5, issue.project_id
481 483 # Keep fixed_version
482 484 assert_equal 4, issue.fixed_version_id
483 485 end
484 486
485 487 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
486 488 issue = Issue.find(1)
487 489 issue.update_attribute(:fixed_version_id, 1)
488 490 assert issue.move_to_project(Project.find(5))
489 491 issue.reload
490 492 assert_equal 5, issue.project_id
491 493 # Cleared fixed_version
492 494 assert_equal nil, issue.fixed_version
493 495 end
494 496
495 497 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
496 498 issue = Issue.find(1)
497 499 issue.update_attribute(:fixed_version_id, 7)
498 500 assert issue.move_to_project(Project.find(2))
499 501 issue.reload
500 502 assert_equal 2, issue.project_id
501 503 # Keep fixed_version
502 504 assert_equal 7, issue.fixed_version_id
503 505 end
504 506
505 507 def test_move_to_another_project_with_disabled_tracker
506 508 issue = Issue.find(1)
507 509 target = Project.find(2)
508 510 target.tracker_ids = [3]
509 511 target.save
510 512 assert_equal false, issue.move_to_project(target)
511 513 issue.reload
512 514 assert_equal 1, issue.project_id
513 515 end
514 516
515 517 def test_copy_to_the_same_project
516 518 issue = Issue.find(1)
517 519 copy = nil
518 520 assert_difference 'Issue.count' do
519 521 copy = issue.move_to_project(issue.project, nil, :copy => true)
520 522 end
521 523 assert_kind_of Issue, copy
522 524 assert_equal issue.project, copy.project
523 525 assert_equal "125", copy.custom_value_for(2).value
524 526 end
525 527
526 528 def test_copy_to_another_project_and_tracker
527 529 issue = Issue.find(1)
528 530 copy = nil
529 531 assert_difference 'Issue.count' do
530 532 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
531 533 end
532 534 copy.reload
533 535 assert_kind_of Issue, copy
534 536 assert_equal Project.find(3), copy.project
535 537 assert_equal Tracker.find(2), copy.tracker
536 538 # Custom field #2 is not associated with target tracker
537 539 assert_nil copy.custom_value_for(2)
538 540 end
539 541
540 542 context "#move_to_project" do
541 543 context "as a copy" do
542 544 setup do
543 545 @issue = Issue.find(1)
544 546 @copy = nil
545 547 end
546 548
547 549 should "not create a journal" do
548 550 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
549 551 assert_equal 0, @copy.reload.journals.size
550 552 end
551 553
552 554 should "allow assigned_to changes" do
553 555 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
554 556 assert_equal 3, @copy.assigned_to_id
555 557 end
556 558
557 559 should "allow status changes" do
558 560 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
559 561 assert_equal 2, @copy.status_id
560 562 end
561 563
562 564 should "allow start date changes" do
563 565 date = Date.today
564 566 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
565 567 assert_equal date, @copy.start_date
566 568 end
567 569
568 570 should "allow due date changes" do
569 571 date = Date.today
570 572 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
571 573
572 574 assert_equal date, @copy.due_date
573 575 end
574 576
575 577 should "set current user as author" do
576 578 User.current = User.find(9)
577 579 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
578 580
579 581 assert_equal User.current, @copy.author
580 582 end
581 583
582 584 should "keep journal notes" do
583 585 date = Date.today
584 586 notes = "Notes added when copying"
585 587 User.current = User.find(9)
586 588 @issue.init_journal(User.current, notes)
587 589 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
588 590
589 591 assert_equal 1, @copy.journals.size
590 592 journal = @copy.journals.first
591 593 assert_equal 0, journal.details.size
592 594 assert_equal notes, journal.notes
593 595 end
594 596 end
595 597 end
596 598
597 599 def test_recipients_should_not_include_users_that_cannot_view_the_issue
598 600 issue = Issue.find(12)
599 601 assert issue.recipients.include?(issue.author.mail)
600 602 # move the issue to a private project
601 603 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
602 604 # author is not a member of project anymore
603 605 assert !copy.recipients.include?(copy.author.mail)
604 606 end
605 607
606 608 def test_recipients_should_include_the_assigned_group_members
607 609 group_member = User.generate_with_protected!
608 610 group = Group.generate!
609 611 group.users << group_member
610 612
611 613 issue = Issue.find(12)
612 614 issue.assigned_to = group
613 615 assert issue.recipients.include?(group_member.mail)
614 616 end
615 617
616 618 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
617 619 user = User.find(3)
618 620 issue = Issue.find(9)
619 621 Watcher.create!(:user => user, :watchable => issue)
620 622 assert issue.watched_by?(user)
621 623 assert !issue.watcher_recipients.include?(user.mail)
622 624 end
623 625
624 626 def test_issue_destroy
625 627 Issue.find(1).destroy
626 628 assert_nil Issue.find_by_id(1)
627 629 assert_nil TimeEntry.find_by_issue_id(1)
628 630 end
629 631
630 632 def test_blocked
631 633 blocked_issue = Issue.find(9)
632 634 blocking_issue = Issue.find(10)
633 635
634 636 assert blocked_issue.blocked?
635 637 assert !blocking_issue.blocked?
636 638 end
637 639
638 640 def test_blocked_issues_dont_allow_closed_statuses
639 641 blocked_issue = Issue.find(9)
640 642
641 643 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
642 644 assert !allowed_statuses.empty?
643 645 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
644 646 assert closed_statuses.empty?
645 647 end
646 648
647 649 def test_unblocked_issues_allow_closed_statuses
648 650 blocking_issue = Issue.find(10)
649 651
650 652 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
651 653 assert !allowed_statuses.empty?
652 654 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
653 655 assert !closed_statuses.empty?
654 656 end
655 657
656 658 def test_rescheduling_an_issue_should_reschedule_following_issue
657 659 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
658 660 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
659 661 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
660 662 assert_equal issue1.due_date + 1, issue2.reload.start_date
661 663
662 664 issue1.due_date = Date.today + 5
663 665 issue1.save!
664 666 assert_equal issue1.due_date + 1, issue2.reload.start_date
665 667 end
666 668
667 669 def test_overdue
668 670 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
669 671 assert !Issue.new(:due_date => Date.today).overdue?
670 672 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
671 673 assert !Issue.new(:due_date => nil).overdue?
672 674 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
673 675 end
674 676
675 677 context "#behind_schedule?" do
676 678 should "be false if the issue has no start_date" do
677 679 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
678 680 end
679 681
680 682 should "be false if the issue has no end_date" do
681 683 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
682 684 end
683 685
684 686 should "be false if the issue has more done than it's calendar time" do
685 687 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
686 688 end
687 689
688 690 should "be true if the issue hasn't been started at all" do
689 691 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
690 692 end
691 693
692 694 should "be true if the issue has used more calendar time than it's done ratio" do
693 695 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
694 696 end
695 697 end
696 698
697 699 context "#assignable_users" do
698 700 should "be Users" do
699 701 assert_kind_of User, Issue.find(1).assignable_users.first
700 702 end
701 703
702 704 should "include the issue author" do
703 705 project = Project.find(1)
704 706 non_project_member = User.generate!
705 707 issue = Issue.generate_for_project!(project, :author => non_project_member)
706 708
707 709 assert issue.assignable_users.include?(non_project_member)
708 710 end
709 711
710 712 should "include the current assignee" do
711 713 project = Project.find(1)
712 714 user = User.generate!
713 715 issue = Issue.generate_for_project!(project, :assigned_to => user)
714 716 user.lock!
715 717
716 718 assert Issue.find(issue.id).assignable_users.include?(user)
717 719 end
718 720
719 721 should "not show the issue author twice" do
720 722 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
721 723 assert_equal 2, assignable_user_ids.length
722 724
723 725 assignable_user_ids.each do |user_id|
724 726 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
725 727 end
726 728 end
727 729
728 730 context "with issue_group_assignment" do
729 731 should "include groups" do
730 732 issue = Issue.new(:project => Project.find(2))
731 733
732 734 with_settings :issue_group_assignment => '1' do
733 735 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
734 736 assert issue.assignable_users.include?(Group.find(11))
735 737 end
736 738 end
737 739 end
738 740
739 741 context "without issue_group_assignment" do
740 742 should "not include groups" do
741 743 issue = Issue.new(:project => Project.find(2))
742 744
743 745 with_settings :issue_group_assignment => '0' do
744 746 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
745 747 assert !issue.assignable_users.include?(Group.find(11))
746 748 end
747 749 end
748 750 end
749 751 end
750 752
751 753 def test_create_should_send_email_notification
752 754 ActionMailer::Base.deliveries.clear
753 755 issue = Issue.new(:project_id => 1, :tracker_id => 1,
754 756 :author_id => 3, :status_id => 1,
755 757 :priority => IssuePriority.all.first,
756 758 :subject => 'test_create', :estimated_hours => '1:30')
757 759
758 760 assert issue.save
759 761 assert_equal 1, ActionMailer::Base.deliveries.size
760 762 end
761 763
762 764 def test_stale_issue_should_not_send_email_notification
763 765 ActionMailer::Base.deliveries.clear
764 766 issue = Issue.find(1)
765 767 stale = Issue.find(1)
766 768
767 769 issue.init_journal(User.find(1))
768 770 issue.subject = 'Subjet update'
769 771 assert issue.save
770 772 assert_equal 1, ActionMailer::Base.deliveries.size
771 773 ActionMailer::Base.deliveries.clear
772 774
773 775 stale.init_journal(User.find(1))
774 776 stale.subject = 'Another subjet update'
775 777 assert_raise ActiveRecord::StaleObjectError do
776 778 stale.save
777 779 end
778 780 assert ActionMailer::Base.deliveries.empty?
779 781 end
780 782
781 783 def test_journalized_description
782 784 IssueCustomField.delete_all
783 785
784 786 i = Issue.first
785 787 old_description = i.description
786 788 new_description = "This is the new description"
787 789
788 790 i.init_journal(User.find(2))
789 791 i.description = new_description
790 792 assert_difference 'Journal.count', 1 do
791 793 assert_difference 'JournalDetail.count', 1 do
792 794 i.save!
793 795 end
794 796 end
795 797
796 798 detail = JournalDetail.first(:order => 'id DESC')
797 799 assert_equal i, detail.journal.journalized
798 800 assert_equal 'attr', detail.property
799 801 assert_equal 'description', detail.prop_key
800 802 assert_equal old_description, detail.old_value
801 803 assert_equal new_description, detail.value
802 804 end
803 805
804 806 def test_blank_descriptions_should_not_be_journalized
805 807 IssueCustomField.delete_all
806 808 Issue.update_all("description = NULL", "id=1")
807 809
808 810 i = Issue.find(1)
809 811 i.init_journal(User.find(2))
810 812 i.subject = "blank description"
811 813 i.description = "\r\n"
812 814
813 815 assert_difference 'Journal.count', 1 do
814 816 assert_difference 'JournalDetail.count', 1 do
815 817 i.save!
816 818 end
817 819 end
818 820 end
819 821
820 822 def test_description_eol_should_be_normalized
821 823 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
822 824 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
823 825 end
824 826
825 827 def test_saving_twice_should_not_duplicate_journal_details
826 828 i = Issue.find(:first)
827 829 i.init_journal(User.find(2), 'Some notes')
828 830 # initial changes
829 831 i.subject = 'New subject'
830 832 i.done_ratio = i.done_ratio + 10
831 833 assert_difference 'Journal.count' do
832 834 assert i.save
833 835 end
834 836 # 1 more change
835 837 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
836 838 assert_no_difference 'Journal.count' do
837 839 assert_difference 'JournalDetail.count', 1 do
838 840 i.save
839 841 end
840 842 end
841 843 # no more change
842 844 assert_no_difference 'Journal.count' do
843 845 assert_no_difference 'JournalDetail.count' do
844 846 i.save
845 847 end
846 848 end
847 849 end
848 850
849 851 def test_all_dependent_issues
850 852 IssueRelation.delete_all
851 853 assert IssueRelation.create!(:issue_from => Issue.find(1),
852 854 :issue_to => Issue.find(2),
853 855 :relation_type => IssueRelation::TYPE_PRECEDES)
854 856 assert IssueRelation.create!(:issue_from => Issue.find(2),
855 857 :issue_to => Issue.find(3),
856 858 :relation_type => IssueRelation::TYPE_PRECEDES)
857 859 assert IssueRelation.create!(:issue_from => Issue.find(3),
858 860 :issue_to => Issue.find(8),
859 861 :relation_type => IssueRelation::TYPE_PRECEDES)
860 862
861 863 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
862 864 end
863 865
864 866 def test_all_dependent_issues_with_persistent_circular_dependency
865 867 IssueRelation.delete_all
866 868 assert IssueRelation.create!(:issue_from => Issue.find(1),
867 869 :issue_to => Issue.find(2),
868 870 :relation_type => IssueRelation::TYPE_PRECEDES)
869 871 assert IssueRelation.create!(:issue_from => Issue.find(2),
870 872 :issue_to => Issue.find(3),
871 873 :relation_type => IssueRelation::TYPE_PRECEDES)
872 874 # Validation skipping
873 875 assert IssueRelation.new(:issue_from => Issue.find(3),
874 876 :issue_to => Issue.find(1),
875 877 :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
876 878
877 879 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
878 880 end
879 881
880 882 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
881 883 IssueRelation.delete_all
882 884 assert IssueRelation.create!(:issue_from => Issue.find(1),
883 885 :issue_to => Issue.find(2),
884 886 :relation_type => IssueRelation::TYPE_RELATES)
885 887 assert IssueRelation.create!(:issue_from => Issue.find(2),
886 888 :issue_to => Issue.find(3),
887 889 :relation_type => IssueRelation::TYPE_RELATES)
888 890 assert IssueRelation.create!(:issue_from => Issue.find(3),
889 891 :issue_to => Issue.find(8),
890 892 :relation_type => IssueRelation::TYPE_RELATES)
891 893 # Validation skipping
892 894 assert IssueRelation.new(:issue_from => Issue.find(8),
893 895 :issue_to => Issue.find(2),
894 896 :relation_type => IssueRelation::TYPE_RELATES).save(false)
895 897 assert IssueRelation.new(:issue_from => Issue.find(3),
896 898 :issue_to => Issue.find(1),
897 899 :relation_type => IssueRelation::TYPE_RELATES).save(false)
898 900
899 901 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
900 902 end
901 903
902 904 context "#done_ratio" do
903 905 setup do
904 906 @issue = Issue.find(1)
905 907 @issue_status = IssueStatus.find(1)
906 908 @issue_status.update_attribute(:default_done_ratio, 50)
907 909 @issue2 = Issue.find(2)
908 910 @issue_status2 = IssueStatus.find(2)
909 911 @issue_status2.update_attribute(:default_done_ratio, 0)
910 912 end
911 913
912 914 context "with Setting.issue_done_ratio using the issue_field" do
913 915 setup do
914 916 Setting.issue_done_ratio = 'issue_field'
915 917 end
916 918
917 919 should "read the issue's field" do
918 920 assert_equal 0, @issue.done_ratio
919 921 assert_equal 30, @issue2.done_ratio
920 922 end
921 923 end
922 924
923 925 context "with Setting.issue_done_ratio using the issue_status" do
924 926 setup do
925 927 Setting.issue_done_ratio = 'issue_status'
926 928 end
927 929
928 930 should "read the Issue Status's default done ratio" do
929 931 assert_equal 50, @issue.done_ratio
930 932 assert_equal 0, @issue2.done_ratio
931 933 end
932 934 end
933 935 end
934 936
935 937 context "#update_done_ratio_from_issue_status" do
936 938 setup do
937 939 @issue = Issue.find(1)
938 940 @issue_status = IssueStatus.find(1)
939 941 @issue_status.update_attribute(:default_done_ratio, 50)
940 942 @issue2 = Issue.find(2)
941 943 @issue_status2 = IssueStatus.find(2)
942 944 @issue_status2.update_attribute(:default_done_ratio, 0)
943 945 end
944 946
945 947 context "with Setting.issue_done_ratio using the issue_field" do
946 948 setup do
947 949 Setting.issue_done_ratio = 'issue_field'
948 950 end
949 951
950 952 should "not change the issue" do
951 953 @issue.update_done_ratio_from_issue_status
952 954 @issue2.update_done_ratio_from_issue_status
953 955
954 956 assert_equal 0, @issue.read_attribute(:done_ratio)
955 957 assert_equal 30, @issue2.read_attribute(:done_ratio)
956 958 end
957 959 end
958 960
959 961 context "with Setting.issue_done_ratio using the issue_status" do
960 962 setup do
961 963 Setting.issue_done_ratio = 'issue_status'
962 964 end
963 965
964 966 should "change the issue's done ratio" do
965 967 @issue.update_done_ratio_from_issue_status
966 968 @issue2.update_done_ratio_from_issue_status
967 969
968 970 assert_equal 50, @issue.read_attribute(:done_ratio)
969 971 assert_equal 0, @issue2.read_attribute(:done_ratio)
970 972 end
971 973 end
972 974 end
973 975
974 976 test "#by_tracker" do
975 977 User.current = User.anonymous
976 978 groups = Issue.by_tracker(Project.find(1))
977 979 assert_equal 3, groups.size
978 980 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
979 981 end
980 982
981 983 test "#by_version" do
982 984 User.current = User.anonymous
983 985 groups = Issue.by_version(Project.find(1))
984 986 assert_equal 3, groups.size
985 987 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
986 988 end
987 989
988 990 test "#by_priority" do
989 991 User.current = User.anonymous
990 992 groups = Issue.by_priority(Project.find(1))
991 993 assert_equal 4, groups.size
992 994 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
993 995 end
994 996
995 997 test "#by_category" do
996 998 User.current = User.anonymous
997 999 groups = Issue.by_category(Project.find(1))
998 1000 assert_equal 2, groups.size
999 1001 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1000 1002 end
1001 1003
1002 1004 test "#by_assigned_to" do
1003 1005 User.current = User.anonymous
1004 1006 groups = Issue.by_assigned_to(Project.find(1))
1005 1007 assert_equal 2, groups.size
1006 1008 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1007 1009 end
1008 1010
1009 1011 test "#by_author" do
1010 1012 User.current = User.anonymous
1011 1013 groups = Issue.by_author(Project.find(1))
1012 1014 assert_equal 4, groups.size
1013 1015 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1014 1016 end
1015 1017
1016 1018 test "#by_subproject" do
1017 1019 User.current = User.anonymous
1018 1020 groups = Issue.by_subproject(Project.find(1))
1019 1021 # Private descendant not visible
1020 1022 assert_equal 1, groups.size
1021 1023 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1022 1024 end
1023 1025
1024 1026 context ".allowed_target_projects_on_move" do
1025 1027 should "return all active projects for admin users" do
1026 1028 User.current = User.find(1)
1027 1029 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1028 1030 end
1029 1031
1030 1032 should "return allowed projects for non admin users" do
1031 1033 User.current = User.find(2)
1032 1034 Role.non_member.remove_permission! :move_issues
1033 1035 assert_equal 3, Issue.allowed_target_projects_on_move.size
1034 1036
1035 1037 Role.non_member.add_permission! :move_issues
1036 1038 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
1037 1039 end
1038 1040 end
1039 1041
1040 1042 def test_recently_updated_with_limit_scopes
1041 1043 #should return the last updated issue
1042 1044 assert_equal 1, Issue.recently_updated.with_limit(1).length
1043 1045 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1044 1046 end
1045 1047
1046 1048 def test_on_active_projects_scope
1047 1049 assert Project.find(2).archive
1048 1050
1049 1051 before = Issue.on_active_project.length
1050 1052 # test inclusion to results
1051 1053 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1052 1054 assert_equal before + 1, Issue.on_active_project.length
1053 1055
1054 1056 # Move to an archived project
1055 1057 issue.project = Project.find(2)
1056 1058 assert issue.save
1057 1059 assert_equal before, Issue.on_active_project.length
1058 1060 end
1059 1061
1060 1062 context "Issue#recipients" do
1061 1063 setup do
1062 1064 @project = Project.find(1)
1063 1065 @author = User.generate_with_protected!
1064 1066 @assignee = User.generate_with_protected!
1065 1067 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1066 1068 end
1067 1069
1068 1070 should "include project recipients" do
1069 1071 assert @project.recipients.present?
1070 1072 @project.recipients.each do |project_recipient|
1071 1073 assert @issue.recipients.include?(project_recipient)
1072 1074 end
1073 1075 end
1074 1076
1075 1077 should "include the author if the author is active" do
1076 1078 assert @issue.author, "No author set for Issue"
1077 1079 assert @issue.recipients.include?(@issue.author.mail)
1078 1080 end
1079 1081
1080 1082 should "include the assigned to user if the assigned to user is active" do
1081 1083 assert @issue.assigned_to, "No assigned_to set for Issue"
1082 1084 assert @issue.recipients.include?(@issue.assigned_to.mail)
1083 1085 end
1084 1086
1085 1087 should "not include users who opt out of all email" do
1086 1088 @author.update_attribute(:mail_notification, :none)
1087 1089
1088 1090 assert !@issue.recipients.include?(@issue.author.mail)
1089 1091 end
1090 1092
1091 1093 should "not include the issue author if they are only notified of assigned issues" do
1092 1094 @author.update_attribute(:mail_notification, :only_assigned)
1093 1095
1094 1096 assert !@issue.recipients.include?(@issue.author.mail)
1095 1097 end
1096 1098
1097 1099 should "not include the assigned user if they are only notified of owned issues" do
1098 1100 @assignee.update_attribute(:mail_notification, :only_owner)
1099 1101
1100 1102 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1101 1103 end
1102 1104
1103 1105 end
1104 1106 end
General Comments 0
You need to be logged in to leave comments. Login now