jro_apps/redmine Commit - r13351:95810125bf1d

Don't create a journal when creating an issue with attachments....

Jean-Philippe Lang -

r13351:95810125bf1d

parent child

Context file:

r13351:95810125bf1d

app/controllers/issues_controller.rb +1 -1

               def build_new_issue_from_params
                 if params[:id].blank?
                   @issue = Issue.new
-                  @issue.init_journal(User.current)
                   if params[:copy_from]
                     begin
+                      @issue.init_journal(User.current)
                       @copy_from = Issue.visible.find(params[:copy_from])
                       @link_copy = link_copy?(params[:link_copy]) || request.get?
                       @copy_attachments = params[:copy_attachments].present? || request.get?

test/functional/issues_controller_test.rb +5 -3

                 assert_difference 'Issue.count' do
                   assert_difference 'Attachment.count' do
-                    post :create, :project_id => 1,
+                    assert_no_difference 'Journal.count' do
-                      :issue => { :tracker_id => '1', :subject => 'With attachment' },
+                      post :create, :project_id => 1,
-                      :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
+                        :issue => { :tracker_id => '1', :subject => 'With attachment' },
+                        :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
+                    end
                   end
                 end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages