##// END OF EJS Templates
Verify assigned_to_id when assigning safe_attributes (#22127)....
Jean-Philippe Lang -
r14841:9473a373a50d
parent child
Show More
@@ -1,1632 +1,1643
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class Issue < ActiveRecord::Base
19 19 include Redmine::SafeAttributes
20 20 include Redmine::Utils::DateCalculation
21 21 include Redmine::I18n
22 22 before_save :set_parent_id
23 23 include Redmine::NestedSet::IssueNestedSet
24 24
25 25 belongs_to :project
26 26 belongs_to :tracker
27 27 belongs_to :status, :class_name => 'IssueStatus'
28 28 belongs_to :author, :class_name => 'User'
29 29 belongs_to :assigned_to, :class_name => 'Principal'
30 30 belongs_to :fixed_version, :class_name => 'Version'
31 31 belongs_to :priority, :class_name => 'IssuePriority'
32 32 belongs_to :category, :class_name => 'IssueCategory'
33 33
34 34 has_many :journals, :as => :journalized, :dependent => :destroy, :inverse_of => :journalized
35 35 has_many :visible_journals,
36 36 lambda {where(["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false])},
37 37 :class_name => 'Journal',
38 38 :as => :journalized
39 39
40 40 has_many :time_entries, :dependent => :destroy
41 41 has_and_belongs_to_many :changesets, lambda {order("#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC")}
42 42
43 43 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
44 44 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
45 45
46 46 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
47 47 acts_as_customizable
48 48 acts_as_watchable
49 49 acts_as_searchable :columns => ['subject', "#{table_name}.description"],
50 50 :preload => [:project, :status, :tracker],
51 51 :scope => lambda {|options| options[:open_issues] ? self.open : self.all}
52 52
53 53 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
54 54 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
55 55 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
56 56
57 57 acts_as_activity_provider :scope => preload(:project, :author, :tracker),
58 58 :author_key => :author_id
59 59
60 60 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
61 61
62 62 attr_reader :current_journal
63 63 delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
64 64
65 65 validates_presence_of :subject, :project, :tracker
66 66 validates_presence_of :priority, :if => Proc.new {|issue| issue.new_record? || issue.priority_id_changed?}
67 67 validates_presence_of :status, :if => Proc.new {|issue| issue.new_record? || issue.status_id_changed?}
68 68 validates_presence_of :author, :if => Proc.new {|issue| issue.new_record? || issue.author_id_changed?}
69 69
70 70 validates_length_of :subject, :maximum => 255
71 71 validates_inclusion_of :done_ratio, :in => 0..100
72 72 validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
73 73 validates :start_date, :date => true
74 74 validates :due_date, :date => true
75 75 validate :validate_issue, :validate_required_fields
76 76 attr_protected :id
77 77
78 78 scope :visible, lambda {|*args|
79 79 joins(:project).
80 80 where(Issue.visible_condition(args.shift || User.current, *args))
81 81 }
82 82
83 83 scope :open, lambda {|*args|
84 84 is_closed = args.size > 0 ? !args.first : false
85 85 joins(:status).
86 86 where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
87 87 }
88 88
89 89 scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
90 90 scope :on_active_project, lambda {
91 91 joins(:project).
92 92 where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
93 93 }
94 94 scope :fixed_version, lambda {|versions|
95 95 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
96 96 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
97 97 }
98 98 scope :assigned_to, lambda {|arg|
99 99 arg = Array(arg).uniq
100 100 ids = arg.map {|p| p.is_a?(Principal) ? p.id : p}
101 101 ids += arg.select {|p| p.is_a?(User)}.map(&:group_ids).flatten.uniq
102 102 ids.compact!
103 103 ids.any? ? where(:assigned_to_id => ids) : none
104 104 }
105 105
106 106 before_validation :clear_disabled_fields
107 107 before_create :default_assign
108 108 before_save :close_duplicates, :update_done_ratio_from_issue_status,
109 109 :force_updated_on_change, :update_closed_on, :set_assigned_to_was
110 110 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
111 111 after_save :reschedule_following_issues, :update_nested_set_attributes,
112 112 :update_parent_attributes, :create_journal
113 113 # Should be after_create but would be called before previous after_save callbacks
114 114 after_save :after_create_from_copy
115 115 after_destroy :update_parent_attributes
116 116 after_create :send_notification
117 117 # Keep it at the end of after_save callbacks
118 118 after_save :clear_assigned_to_was
119 119
120 120 # Returns a SQL conditions string used to find all issues visible by the specified user
121 121 def self.visible_condition(user, options={})
122 122 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
123 123 if user.id && user.logged?
124 124 case role.issues_visibility
125 125 when 'all'
126 126 nil
127 127 when 'default'
128 128 user_ids = [user.id] + user.groups.map(&:id).compact
129 129 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
130 130 when 'own'
131 131 user_ids = [user.id] + user.groups.map(&:id).compact
132 132 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
133 133 else
134 134 '1=0'
135 135 end
136 136 else
137 137 "(#{table_name}.is_private = #{connection.quoted_false})"
138 138 end
139 139 end
140 140 end
141 141
142 142 # Returns true if usr or current user is allowed to view the issue
143 143 def visible?(usr=nil)
144 144 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
145 145 if user.logged?
146 146 case role.issues_visibility
147 147 when 'all'
148 148 true
149 149 when 'default'
150 150 !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
151 151 when 'own'
152 152 self.author == user || user.is_or_belongs_to?(assigned_to)
153 153 else
154 154 false
155 155 end
156 156 else
157 157 !self.is_private?
158 158 end
159 159 end
160 160 end
161 161
162 162 # Returns true if user or current user is allowed to edit or add a note to the issue
163 163 def editable?(user=User.current)
164 164 attributes_editable?(user) || user.allowed_to?(:add_issue_notes, project)
165 165 end
166 166
167 167 # Returns true if user or current user is allowed to edit the issue
168 168 def attributes_editable?(user=User.current)
169 169 user.allowed_to?(:edit_issues, project)
170 170 end
171 171
172 172 def initialize(attributes=nil, *args)
173 173 super
174 174 if new_record?
175 175 # set default values for new records only
176 176 self.priority ||= IssuePriority.default
177 177 self.watcher_user_ids = []
178 178 end
179 179 end
180 180
181 181 def create_or_update
182 182 super
183 183 ensure
184 184 @status_was = nil
185 185 end
186 186 private :create_or_update
187 187
188 188 # AR#Persistence#destroy would raise and RecordNotFound exception
189 189 # if the issue was already deleted or updated (non matching lock_version).
190 190 # This is a problem when bulk deleting issues or deleting a project
191 191 # (because an issue may already be deleted if its parent was deleted
192 192 # first).
193 193 # The issue is reloaded by the nested_set before being deleted so
194 194 # the lock_version condition should not be an issue but we handle it.
195 195 def destroy
196 196 super
197 197 rescue ActiveRecord::StaleObjectError, ActiveRecord::RecordNotFound
198 198 # Stale or already deleted
199 199 begin
200 200 reload
201 201 rescue ActiveRecord::RecordNotFound
202 202 # The issue was actually already deleted
203 203 @destroyed = true
204 204 return freeze
205 205 end
206 206 # The issue was stale, retry to destroy
207 207 super
208 208 end
209 209
210 210 alias :base_reload :reload
211 211 def reload(*args)
212 212 @workflow_rule_by_attribute = nil
213 213 @assignable_versions = nil
214 214 @relations = nil
215 215 @spent_hours = nil
216 216 @total_spent_hours = nil
217 217 @total_estimated_hours = nil
218 218 base_reload(*args)
219 219 end
220 220
221 221 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
222 222 def available_custom_fields
223 223 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields) : []
224 224 end
225 225
226 226 def visible_custom_field_values(user=nil)
227 227 user_real = user || User.current
228 228 custom_field_values.select do |value|
229 229 value.custom_field.visible_by?(project, user_real)
230 230 end
231 231 end
232 232
233 233 # Copies attributes from another issue, arg can be an id or an Issue
234 234 def copy_from(arg, options={})
235 235 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
236 236 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
237 237 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
238 238 self.status = issue.status
239 239 self.author = User.current
240 240 unless options[:attachments] == false
241 241 self.attachments = issue.attachments.map do |attachement|
242 242 attachement.copy(:container => self)
243 243 end
244 244 end
245 245 @copied_from = issue
246 246 @copy_options = options
247 247 self
248 248 end
249 249
250 250 # Returns an unsaved copy of the issue
251 251 def copy(attributes=nil, copy_options={})
252 252 copy = self.class.new.copy_from(self, copy_options)
253 253 copy.attributes = attributes if attributes
254 254 copy
255 255 end
256 256
257 257 # Returns true if the issue is a copy
258 258 def copy?
259 259 @copied_from.present?
260 260 end
261 261
262 262 def status_id=(status_id)
263 263 if status_id.to_s != self.status_id.to_s
264 264 self.status = (status_id.present? ? IssueStatus.find_by_id(status_id) : nil)
265 265 end
266 266 self.status_id
267 267 end
268 268
269 269 # Sets the status.
270 270 def status=(status)
271 271 if status != self.status
272 272 @workflow_rule_by_attribute = nil
273 273 end
274 274 association(:status).writer(status)
275 275 end
276 276
277 277 def priority_id=(pid)
278 278 self.priority = nil
279 279 write_attribute(:priority_id, pid)
280 280 end
281 281
282 282 def category_id=(cid)
283 283 self.category = nil
284 284 write_attribute(:category_id, cid)
285 285 end
286 286
287 287 def fixed_version_id=(vid)
288 288 self.fixed_version = nil
289 289 write_attribute(:fixed_version_id, vid)
290 290 end
291 291
292 292 def tracker_id=(tracker_id)
293 293 if tracker_id.to_s != self.tracker_id.to_s
294 294 self.tracker = (tracker_id.present? ? Tracker.find_by_id(tracker_id) : nil)
295 295 end
296 296 self.tracker_id
297 297 end
298 298
299 299 # Sets the tracker.
300 300 # This will set the status to the default status of the new tracker if:
301 301 # * the status was the default for the previous tracker
302 302 # * or if the status was not part of the new tracker statuses
303 303 # * or the status was nil
304 304 def tracker=(tracker)
305 305 if tracker != self.tracker
306 306 if status == default_status
307 307 self.status = nil
308 308 elsif status && tracker && !tracker.issue_status_ids.include?(status.id)
309 309 self.status = nil
310 310 end
311 311 @custom_field_values = nil
312 312 @workflow_rule_by_attribute = nil
313 313 end
314 314 association(:tracker).writer(tracker)
315 315 self.status ||= default_status
316 316 self.tracker
317 317 end
318 318
319 319 def project_id=(project_id)
320 320 if project_id.to_s != self.project_id.to_s
321 321 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
322 322 end
323 323 self.project_id
324 324 end
325 325
326 326 # Sets the project.
327 327 # Unless keep_tracker argument is set to true, this will change the tracker
328 328 # to the first tracker of the new project if the previous tracker is not part
329 329 # of the new project trackers.
330 330 # This will:
331 331 # * clear the fixed_version is it's no longer valid for the new project.
332 332 # * clear the parent issue if it's no longer valid for the new project.
333 333 # * set the category to the category with the same name in the new
334 334 # project if it exists, or clear it if it doesn't.
335 335 # * for new issue, set the fixed_version to the project default version
336 336 # if it's a valid fixed_version.
337 337 def project=(project, keep_tracker=false)
338 338 project_was = self.project
339 339 association(:project).writer(project)
340 340 if project_was && project && project_was != project
341 341 @assignable_versions = nil
342 342
343 343 unless keep_tracker || project.trackers.include?(tracker)
344 344 self.tracker = project.trackers.first
345 345 end
346 346 # Reassign to the category with same name if any
347 347 if category
348 348 self.category = project.issue_categories.find_by_name(category.name)
349 349 end
350 350 # Keep the fixed_version if it's still valid in the new_project
351 351 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
352 352 self.fixed_version = nil
353 353 end
354 354 # Clear the parent task if it's no longer valid
355 355 unless valid_parent_project?
356 356 self.parent_issue_id = nil
357 357 end
358 358 @custom_field_values = nil
359 359 @workflow_rule_by_attribute = nil
360 360 end
361 361 # Set fixed_version to the project default version if it's valid
362 362 if new_record? && fixed_version.nil? && project && project.default_version_id?
363 363 if project.shared_versions.open.exists?(project.default_version_id)
364 364 self.fixed_version_id = project.default_version_id
365 365 end
366 366 end
367 367 self.project
368 368 end
369 369
370 370 def description=(arg)
371 371 if arg.is_a?(String)
372 372 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
373 373 end
374 374 write_attribute(:description, arg)
375 375 end
376 376
377 377 # Overrides assign_attributes so that project and tracker get assigned first
378 378 def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
379 379 return if new_attributes.nil?
380 380 attrs = new_attributes.dup
381 381 attrs.stringify_keys!
382 382
383 383 %w(project project_id tracker tracker_id).each do |attr|
384 384 if attrs.has_key?(attr)
385 385 send "#{attr}=", attrs.delete(attr)
386 386 end
387 387 end
388 388 send :assign_attributes_without_project_and_tracker_first, attrs, *args
389 389 end
390 390 # Do not redefine alias chain on reload (see #4838)
391 391 alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
392 392
393 393 def attributes=(new_attributes)
394 394 assign_attributes new_attributes
395 395 end
396 396
397 397 def estimated_hours=(h)
398 398 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
399 399 end
400 400
401 401 safe_attributes 'project_id',
402 402 'tracker_id',
403 403 'status_id',
404 404 'category_id',
405 405 'assigned_to_id',
406 406 'priority_id',
407 407 'fixed_version_id',
408 408 'subject',
409 409 'description',
410 410 'start_date',
411 411 'due_date',
412 412 'done_ratio',
413 413 'estimated_hours',
414 414 'custom_field_values',
415 415 'custom_fields',
416 416 'lock_version',
417 417 'notes',
418 418 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
419 419
420 420 safe_attributes 'notes',
421 421 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
422 422
423 423 safe_attributes 'private_notes',
424 424 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
425 425
426 426 safe_attributes 'watcher_user_ids',
427 427 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
428 428
429 429 safe_attributes 'is_private',
430 430 :if => lambda {|issue, user|
431 431 user.allowed_to?(:set_issues_private, issue.project) ||
432 432 (issue.author_id == user.id && user.allowed_to?(:set_own_issues_private, issue.project))
433 433 }
434 434
435 435 safe_attributes 'parent_issue_id',
436 436 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
437 437 user.allowed_to?(:manage_subtasks, issue.project)}
438 438
439 439 def safe_attribute_names(user=nil)
440 440 names = super
441 441 names -= disabled_core_fields
442 442 names -= read_only_attribute_names(user)
443 443 if new_record?
444 444 # Make sure that project_id can always be set for new issues
445 445 names |= %w(project_id)
446 446 end
447 447 if dates_derived?
448 448 names -= %w(start_date due_date)
449 449 end
450 450 if priority_derived?
451 451 names -= %w(priority_id)
452 452 end
453 453 if done_ratio_derived?
454 454 names -= %w(done_ratio)
455 455 end
456 456 names
457 457 end
458 458
459 459 # Safely sets attributes
460 460 # Should be called from controllers instead of #attributes=
461 461 # attr_accessible is too rough because we still want things like
462 462 # Issue.new(:project => foo) to work
463 463 def safe_attributes=(attrs, user=User.current)
464 464 return unless attrs.is_a?(Hash)
465 465
466 466 attrs = attrs.deep_dup
467 467
468 468 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
469 469 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
470 470 if allowed_target_projects(user).where(:id => p.to_i).exists?
471 471 self.project_id = p
472 472 end
473 473
474 474 if project_id_changed? && attrs['category_id'].to_s == category_id_was.to_s
475 475 # Discard submitted category on previous project
476 476 attrs.delete('category_id')
477 477 end
478 478 end
479 479
480 480 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
481 481 self.tracker_id = t
482 482 end
483 483 if project
484 484 # Set the default tracker to accept custom field values
485 485 # even if tracker is not specified
486 486 self.tracker ||= project.trackers.first
487 487 end
488 488
489 489 statuses_allowed = new_statuses_allowed_to(user)
490 490 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
491 491 if statuses_allowed.collect(&:id).include?(s.to_i)
492 492 self.status_id = s
493 493 end
494 494 end
495 495 if new_record? && !statuses_allowed.include?(status)
496 496 self.status = statuses_allowed.first || default_status
497 497 end
498 if (u = attrs.delete('assigned_to_id')) && safe_attribute?('assigned_to_id')
499 if u.blank?
500 self.assigned_to_id = nil
501 else
502 u = u.to_i
503 if assignable_users.any?{|assignable_user| assignable_user.id == u}
504 self.assigned_to_id = u
505 end
506 end
507 end
508
498 509
499 510 attrs = delete_unsafe_attributes(attrs, user)
500 511 return if attrs.empty?
501 512
502 513 if attrs['parent_issue_id'].present?
503 514 s = attrs['parent_issue_id'].to_s
504 515 unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
505 516 @invalid_parent_issue_id = attrs.delete('parent_issue_id')
506 517 end
507 518 end
508 519
509 520 if attrs['custom_field_values'].present?
510 521 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
511 522 attrs['custom_field_values'].select! {|k, v| editable_custom_field_ids.include?(k.to_s)}
512 523 end
513 524
514 525 if attrs['custom_fields'].present?
515 526 editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
516 527 attrs['custom_fields'].select! {|c| editable_custom_field_ids.include?(c['id'].to_s)}
517 528 end
518 529
519 530 # mass-assignment security bypass
520 531 assign_attributes attrs, :without_protection => true
521 532 end
522 533
523 534 def disabled_core_fields
524 535 tracker ? tracker.disabled_core_fields : []
525 536 end
526 537
527 538 # Returns the custom_field_values that can be edited by the given user
528 539 def editable_custom_field_values(user=nil)
529 540 visible_custom_field_values(user).reject do |value|
530 541 read_only_attribute_names(user).include?(value.custom_field_id.to_s)
531 542 end
532 543 end
533 544
534 545 # Returns the custom fields that can be edited by the given user
535 546 def editable_custom_fields(user=nil)
536 547 editable_custom_field_values(user).map(&:custom_field).uniq
537 548 end
538 549
539 550 # Returns the names of attributes that are read-only for user or the current user
540 551 # For users with multiple roles, the read-only fields are the intersection of
541 552 # read-only fields of each role
542 553 # The result is an array of strings where sustom fields are represented with their ids
543 554 #
544 555 # Examples:
545 556 # issue.read_only_attribute_names # => ['due_date', '2']
546 557 # issue.read_only_attribute_names(user) # => []
547 558 def read_only_attribute_names(user=nil)
548 559 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
549 560 end
550 561
551 562 # Returns the names of required attributes for user or the current user
552 563 # For users with multiple roles, the required fields are the intersection of
553 564 # required fields of each role
554 565 # The result is an array of strings where sustom fields are represented with their ids
555 566 #
556 567 # Examples:
557 568 # issue.required_attribute_names # => ['due_date', '2']
558 569 # issue.required_attribute_names(user) # => []
559 570 def required_attribute_names(user=nil)
560 571 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
561 572 end
562 573
563 574 # Returns true if the attribute is required for user
564 575 def required_attribute?(name, user=nil)
565 576 required_attribute_names(user).include?(name.to_s)
566 577 end
567 578
568 579 # Returns a hash of the workflow rule by attribute for the given user
569 580 #
570 581 # Examples:
571 582 # issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
572 583 def workflow_rule_by_attribute(user=nil)
573 584 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
574 585
575 586 user_real = user || User.current
576 587 roles = user_real.admin ? Role.all.to_a : user_real.roles_for_project(project)
577 588 roles = roles.select(&:consider_workflow?)
578 589 return {} if roles.empty?
579 590
580 591 result = {}
581 592 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).to_a
582 593 if workflow_permissions.any?
583 594 workflow_rules = workflow_permissions.inject({}) do |h, wp|
584 595 h[wp.field_name] ||= {}
585 596 h[wp.field_name][wp.role_id] = wp.rule
586 597 h
587 598 end
588 599 fields_with_roles = {}
589 600 IssueCustomField.where(:visible => false).joins(:roles).pluck(:id, "role_id").each do |field_id, role_id|
590 601 fields_with_roles[field_id] ||= []
591 602 fields_with_roles[field_id] << role_id
592 603 end
593 604 roles.each do |role|
594 605 fields_with_roles.each do |field_id, role_ids|
595 606 unless role_ids.include?(role.id)
596 607 field_name = field_id.to_s
597 608 workflow_rules[field_name] ||= {}
598 609 workflow_rules[field_name][role.id] = 'readonly'
599 610 end
600 611 end
601 612 end
602 613 workflow_rules.each do |attr, rules|
603 614 next if rules.size < roles.size
604 615 uniq_rules = rules.values.uniq
605 616 if uniq_rules.size == 1
606 617 result[attr] = uniq_rules.first
607 618 else
608 619 result[attr] = 'required'
609 620 end
610 621 end
611 622 end
612 623 @workflow_rule_by_attribute = result if user.nil?
613 624 result
614 625 end
615 626 private :workflow_rule_by_attribute
616 627
617 628 def done_ratio
618 629 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
619 630 status.default_done_ratio
620 631 else
621 632 read_attribute(:done_ratio)
622 633 end
623 634 end
624 635
625 636 def self.use_status_for_done_ratio?
626 637 Setting.issue_done_ratio == 'issue_status'
627 638 end
628 639
629 640 def self.use_field_for_done_ratio?
630 641 Setting.issue_done_ratio == 'issue_field'
631 642 end
632 643
633 644 def validate_issue
634 645 if due_date && start_date && (start_date_changed? || due_date_changed?) && due_date < start_date
635 646 errors.add :due_date, :greater_than_start_date
636 647 end
637 648
638 649 if start_date && start_date_changed? && soonest_start && start_date < soonest_start
639 650 errors.add :start_date, :earlier_than_minimum_start_date, :date => format_date(soonest_start)
640 651 end
641 652
642 653 if fixed_version
643 654 if !assignable_versions.include?(fixed_version)
644 655 errors.add :fixed_version_id, :inclusion
645 656 elsif reopening? && fixed_version.closed?
646 657 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
647 658 end
648 659 end
649 660
650 661 # Checks that the issue can not be added/moved to a disabled tracker
651 662 if project && (tracker_id_changed? || project_id_changed?)
652 663 unless project.trackers.include?(tracker)
653 664 errors.add :tracker_id, :inclusion
654 665 end
655 666 end
656 667
657 668 # Checks parent issue assignment
658 669 if @invalid_parent_issue_id.present?
659 670 errors.add :parent_issue_id, :invalid
660 671 elsif @parent_issue
661 672 if !valid_parent_project?(@parent_issue)
662 673 errors.add :parent_issue_id, :invalid
663 674 elsif (@parent_issue != parent) && (
664 675 self.would_reschedule?(@parent_issue) ||
665 676 @parent_issue.self_and_ancestors.any? {|a| a.relations_from.any? {|r| r.relation_type == IssueRelation::TYPE_PRECEDES && r.issue_to.would_reschedule?(self)}}
666 677 )
667 678 errors.add :parent_issue_id, :invalid
668 679 elsif !new_record?
669 680 # moving an existing issue
670 681 if move_possible?(@parent_issue)
671 682 # move accepted
672 683 else
673 684 errors.add :parent_issue_id, :invalid
674 685 end
675 686 end
676 687 end
677 688 end
678 689
679 690 # Validates the issue against additional workflow requirements
680 691 def validate_required_fields
681 692 user = new_record? ? author : current_journal.try(:user)
682 693
683 694 required_attribute_names(user).each do |attribute|
684 695 if attribute =~ /^\d+$/
685 696 attribute = attribute.to_i
686 697 v = custom_field_values.detect {|v| v.custom_field_id == attribute }
687 698 if v && Array(v.value).detect(&:present?).nil?
688 699 errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
689 700 end
690 701 else
691 702 if respond_to?(attribute) && send(attribute).blank? && !disabled_core_fields.include?(attribute)
692 703 next if attribute == 'category_id' && project.try(:issue_categories).blank?
693 704 next if attribute == 'fixed_version_id' && assignable_versions.blank?
694 705 errors.add attribute, :blank
695 706 end
696 707 end
697 708 end
698 709 end
699 710
700 711 # Overrides Redmine::Acts::Customizable::InstanceMethods#validate_custom_field_values
701 712 # so that custom values that are not editable are not validated (eg. a custom field that
702 713 # is marked as required should not trigger a validation error if the user is not allowed
703 714 # to edit this field).
704 715 def validate_custom_field_values
705 716 user = new_record? ? author : current_journal.try(:user)
706 717 if new_record? || custom_field_values_changed?
707 718 editable_custom_field_values(user).each(&:validate_value)
708 719 end
709 720 end
710 721
711 722 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
712 723 # even if the user turns off the setting later
713 724 def update_done_ratio_from_issue_status
714 725 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
715 726 self.done_ratio = status.default_done_ratio
716 727 end
717 728 end
718 729
719 730 def init_journal(user, notes = "")
720 731 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
721 732 end
722 733
723 734 # Returns the current journal or nil if it's not initialized
724 735 def current_journal
725 736 @current_journal
726 737 end
727 738
728 739 # Returns the names of attributes that are journalized when updating the issue
729 740 def journalized_attribute_names
730 741 names = Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)
731 742 if tracker
732 743 names -= tracker.disabled_core_fields
733 744 end
734 745 names
735 746 end
736 747
737 748 # Returns the id of the last journal or nil
738 749 def last_journal_id
739 750 if new_record?
740 751 nil
741 752 else
742 753 journals.maximum(:id)
743 754 end
744 755 end
745 756
746 757 # Returns a scope for journals that have an id greater than journal_id
747 758 def journals_after(journal_id)
748 759 scope = journals.reorder("#{Journal.table_name}.id ASC")
749 760 if journal_id.present?
750 761 scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
751 762 end
752 763 scope
753 764 end
754 765
755 766 # Returns the initial status of the issue
756 767 # Returns nil for a new issue
757 768 def status_was
758 769 if status_id_changed?
759 770 if status_id_was.to_i > 0
760 771 @status_was ||= IssueStatus.find_by_id(status_id_was)
761 772 end
762 773 else
763 774 @status_was ||= status
764 775 end
765 776 end
766 777
767 778 # Return true if the issue is closed, otherwise false
768 779 def closed?
769 780 status.present? && status.is_closed?
770 781 end
771 782
772 783 # Returns true if the issue was closed when loaded
773 784 def was_closed?
774 785 status_was.present? && status_was.is_closed?
775 786 end
776 787
777 788 # Return true if the issue is being reopened
778 789 def reopening?
779 790 if new_record?
780 791 false
781 792 else
782 793 status_id_changed? && !closed? && was_closed?
783 794 end
784 795 end
785 796 alias :reopened? :reopening?
786 797
787 798 # Return true if the issue is being closed
788 799 def closing?
789 800 if new_record?
790 801 closed?
791 802 else
792 803 status_id_changed? && closed? && !was_closed?
793 804 end
794 805 end
795 806
796 807 # Returns true if the issue is overdue
797 808 def overdue?
798 809 due_date.present? && (due_date < Date.today) && !closed?
799 810 end
800 811
801 812 # Is the amount of work done less than it should for the due date
802 813 def behind_schedule?
803 814 return false if start_date.nil? || due_date.nil?
804 815 done_date = start_date + ((due_date - start_date + 1) * done_ratio / 100).floor
805 816 return done_date <= Date.today
806 817 end
807 818
808 819 # Does this issue have children?
809 820 def children?
810 821 !leaf?
811 822 end
812 823
813 824 # Users the issue can be assigned to
814 825 def assignable_users
815 826 users = project.assignable_users.to_a
816 827 users << author if author && author.active?
817 828 users << assigned_to if assigned_to
818 829 users.uniq.sort
819 830 end
820 831
821 832 # Versions that the issue can be assigned to
822 833 def assignable_versions
823 834 return @assignable_versions if @assignable_versions
824 835
825 836 versions = project.shared_versions.open.to_a
826 837 if fixed_version
827 838 if fixed_version_id_changed?
828 839 # nothing to do
829 840 elsif project_id_changed?
830 841 if project.shared_versions.include?(fixed_version)
831 842 versions << fixed_version
832 843 end
833 844 else
834 845 versions << fixed_version
835 846 end
836 847 end
837 848 @assignable_versions = versions.uniq.sort
838 849 end
839 850
840 851 # Returns true if this issue is blocked by another issue that is still open
841 852 def blocked?
842 853 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
843 854 end
844 855
845 856 # Returns the default status of the issue based on its tracker
846 857 # Returns nil if tracker is nil
847 858 def default_status
848 859 tracker.try(:default_status)
849 860 end
850 861
851 862 # Returns an array of statuses that user is able to apply
852 863 def new_statuses_allowed_to(user=User.current, include_default=false)
853 864 if new_record? && @copied_from
854 865 [default_status, @copied_from.status].compact.uniq.sort
855 866 else
856 867 initial_status = nil
857 868 if new_record?
858 869 # nop
859 870 elsif tracker_id_changed?
860 871 if Tracker.where(:id => tracker_id_was, :default_status_id => status_id_was).any?
861 872 initial_status = default_status
862 873 elsif tracker.issue_status_ids.include?(status_id_was)
863 874 initial_status = IssueStatus.find_by_id(status_id_was)
864 875 else
865 876 initial_status = default_status
866 877 end
867 878 else
868 879 initial_status = status_was
869 880 end
870 881
871 882 initial_assigned_to_id = assigned_to_id_changed? ? assigned_to_id_was : assigned_to_id
872 883 assignee_transitions_allowed = initial_assigned_to_id.present? &&
873 884 (user.id == initial_assigned_to_id || user.group_ids.include?(initial_assigned_to_id))
874 885
875 886 statuses = []
876 887 statuses += IssueStatus.new_statuses_allowed(
877 888 initial_status,
878 889 user.admin ? Role.all.to_a : user.roles_for_project(project),
879 890 tracker,
880 891 author == user,
881 892 assignee_transitions_allowed
882 893 )
883 894 statuses << initial_status unless statuses.empty?
884 895 statuses << default_status if include_default || (new_record? && statuses.empty?)
885 896 statuses = statuses.compact.uniq.sort
886 897 if blocked?
887 898 statuses.reject!(&:is_closed?)
888 899 end
889 900 statuses
890 901 end
891 902 end
892 903
893 904 # Returns the previous assignee (user or group) if changed
894 905 def assigned_to_was
895 906 # assigned_to_id_was is reset before after_save callbacks
896 907 user_id = @previous_assigned_to_id || assigned_to_id_was
897 908 if user_id && user_id != assigned_to_id
898 909 @assigned_to_was ||= Principal.find_by_id(user_id)
899 910 end
900 911 end
901 912
902 913 # Returns the original tracker
903 914 def tracker_was
904 915 Tracker.find_by_id(tracker_id_was)
905 916 end
906 917
907 918 # Returns the users that should be notified
908 919 def notified_users
909 920 notified = []
910 921 # Author and assignee are always notified unless they have been
911 922 # locked or don't want to be notified
912 923 notified << author if author
913 924 if assigned_to
914 925 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
915 926 end
916 927 if assigned_to_was
917 928 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
918 929 end
919 930 notified = notified.select {|u| u.active? && u.notify_about?(self)}
920 931
921 932 notified += project.notified_users
922 933 notified.uniq!
923 934 # Remove users that can not view the issue
924 935 notified.reject! {|user| !visible?(user)}
925 936 notified
926 937 end
927 938
928 939 # Returns the email addresses that should be notified
929 940 def recipients
930 941 notified_users.collect(&:mail)
931 942 end
932 943
933 944 def each_notification(users, &block)
934 945 if users.any?
935 946 if custom_field_values.detect {|value| !value.custom_field.visible?}
936 947 users_by_custom_field_visibility = users.group_by do |user|
937 948 visible_custom_field_values(user).map(&:custom_field_id).sort
938 949 end
939 950 users_by_custom_field_visibility.values.each do |users|
940 951 yield(users)
941 952 end
942 953 else
943 954 yield(users)
944 955 end
945 956 end
946 957 end
947 958
948 959 def notify?
949 960 @notify != false
950 961 end
951 962
952 963 def notify=(arg)
953 964 @notify = arg
954 965 end
955 966
956 967 # Returns the number of hours spent on this issue
957 968 def spent_hours
958 969 @spent_hours ||= time_entries.sum(:hours) || 0
959 970 end
960 971
961 972 # Returns the total number of hours spent on this issue and its descendants
962 973 def total_spent_hours
963 974 @total_spent_hours ||= if leaf?
964 975 spent_hours
965 976 else
966 977 self_and_descendants.joins(:time_entries).sum("#{TimeEntry.table_name}.hours").to_f || 0.0
967 978 end
968 979 end
969 980
970 981 def total_estimated_hours
971 982 if leaf?
972 983 estimated_hours
973 984 else
974 985 @total_estimated_hours ||= self_and_descendants.sum(:estimated_hours)
975 986 end
976 987 end
977 988
978 989 def relations
979 990 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
980 991 end
981 992
982 993 # Preloads relations for a collection of issues
983 994 def self.load_relations(issues)
984 995 if issues.any?
985 996 relations = IssueRelation.where("issue_from_id IN (:ids) OR issue_to_id IN (:ids)", :ids => issues.map(&:id)).all
986 997 issues.each do |issue|
987 998 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
988 999 end
989 1000 end
990 1001 end
991 1002
992 1003 # Preloads visible spent time for a collection of issues
993 1004 def self.load_visible_spent_hours(issues, user=User.current)
994 1005 if issues.any?
995 1006 hours_by_issue_id = TimeEntry.visible(user).where(:issue_id => issues.map(&:id)).group(:issue_id).sum(:hours)
996 1007 issues.each do |issue|
997 1008 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
998 1009 end
999 1010 end
1000 1011 end
1001 1012
1002 1013 # Preloads visible total spent time for a collection of issues
1003 1014 def self.load_visible_total_spent_hours(issues, user=User.current)
1004 1015 if issues.any?
1005 1016 hours_by_issue_id = TimeEntry.visible(user).joins(:issue).
1006 1017 joins("JOIN #{Issue.table_name} parent ON parent.root_id = #{Issue.table_name}.root_id" +
1007 1018 " AND parent.lft <= #{Issue.table_name}.lft AND parent.rgt >= #{Issue.table_name}.rgt").
1008 1019 where("parent.id IN (?)", issues.map(&:id)).group("parent.id").sum(:hours)
1009 1020 issues.each do |issue|
1010 1021 issue.instance_variable_set "@total_spent_hours", (hours_by_issue_id[issue.id] || 0)
1011 1022 end
1012 1023 end
1013 1024 end
1014 1025
1015 1026 # Preloads visible relations for a collection of issues
1016 1027 def self.load_visible_relations(issues, user=User.current)
1017 1028 if issues.any?
1018 1029 issue_ids = issues.map(&:id)
1019 1030 # Relations with issue_from in given issues and visible issue_to
1020 1031 relations_from = IssueRelation.joins(:issue_to => :project).
1021 1032 where(visible_condition(user)).where(:issue_from_id => issue_ids).to_a
1022 1033 # Relations with issue_to in given issues and visible issue_from
1023 1034 relations_to = IssueRelation.joins(:issue_from => :project).
1024 1035 where(visible_condition(user)).
1025 1036 where(:issue_to_id => issue_ids).to_a
1026 1037 issues.each do |issue|
1027 1038 relations =
1028 1039 relations_from.select {|relation| relation.issue_from_id == issue.id} +
1029 1040 relations_to.select {|relation| relation.issue_to_id == issue.id}
1030 1041
1031 1042 issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
1032 1043 end
1033 1044 end
1034 1045 end
1035 1046
1036 1047 # Finds an issue relation given its id.
1037 1048 def find_relation(relation_id)
1038 1049 IssueRelation.where("issue_to_id = ? OR issue_from_id = ?", id, id).find(relation_id)
1039 1050 end
1040 1051
1041 1052 # Returns true if this issue blocks the other issue, otherwise returns false
1042 1053 def blocks?(other)
1043 1054 all = [self]
1044 1055 last = [self]
1045 1056 while last.any?
1046 1057 current = last.map {|i| i.relations_from.where(:relation_type => IssueRelation::TYPE_BLOCKS).map(&:issue_to)}.flatten.uniq
1047 1058 current -= last
1048 1059 current -= all
1049 1060 return true if current.include?(other)
1050 1061 last = current
1051 1062 all += last
1052 1063 end
1053 1064 false
1054 1065 end
1055 1066
1056 1067 # Returns true if the other issue might be rescheduled if the start/due dates of this issue change
1057 1068 def would_reschedule?(other)
1058 1069 all = [self]
1059 1070 last = [self]
1060 1071 while last.any?
1061 1072 current = last.map {|i|
1062 1073 i.relations_from.where(:relation_type => IssueRelation::TYPE_PRECEDES).map(&:issue_to) +
1063 1074 i.leaves.to_a +
1064 1075 i.ancestors.map {|a| a.relations_from.where(:relation_type => IssueRelation::TYPE_PRECEDES).map(&:issue_to)}
1065 1076 }.flatten.uniq
1066 1077 current -= last
1067 1078 current -= all
1068 1079 return true if current.include?(other)
1069 1080 last = current
1070 1081 all += last
1071 1082 end
1072 1083 false
1073 1084 end
1074 1085
1075 1086 # Returns an array of issues that duplicate this one
1076 1087 def duplicates
1077 1088 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
1078 1089 end
1079 1090
1080 1091 # Returns the due date or the target due date if any
1081 1092 # Used on gantt chart
1082 1093 def due_before
1083 1094 due_date || (fixed_version ? fixed_version.effective_date : nil)
1084 1095 end
1085 1096
1086 1097 # Returns the time scheduled for this issue.
1087 1098 #
1088 1099 # Example:
1089 1100 # Start Date: 2/26/09, End Date: 3/04/09
1090 1101 # duration => 6
1091 1102 def duration
1092 1103 (start_date && due_date) ? due_date - start_date : 0
1093 1104 end
1094 1105
1095 1106 # Returns the duration in working days
1096 1107 def working_duration
1097 1108 (start_date && due_date) ? working_days(start_date, due_date) : 0
1098 1109 end
1099 1110
1100 1111 def soonest_start(reload=false)
1101 1112 if @soonest_start.nil? || reload
1102 1113 dates = relations_to(reload).collect{|relation| relation.successor_soonest_start}
1103 1114 p = @parent_issue || parent
1104 1115 if p && Setting.parent_issue_dates == 'derived'
1105 1116 dates << p.soonest_start
1106 1117 end
1107 1118 @soonest_start = dates.compact.max
1108 1119 end
1109 1120 @soonest_start
1110 1121 end
1111 1122
1112 1123 # Sets start_date on the given date or the next working day
1113 1124 # and changes due_date to keep the same working duration.
1114 1125 def reschedule_on(date)
1115 1126 wd = working_duration
1116 1127 date = next_working_date(date)
1117 1128 self.start_date = date
1118 1129 self.due_date = add_working_days(date, wd)
1119 1130 end
1120 1131
1121 1132 # Reschedules the issue on the given date or the next working day and saves the record.
1122 1133 # If the issue is a parent task, this is done by rescheduling its subtasks.
1123 1134 def reschedule_on!(date)
1124 1135 return if date.nil?
1125 1136 if leaf? || !dates_derived?
1126 1137 if start_date.nil? || start_date != date
1127 1138 if start_date && start_date > date
1128 1139 # Issue can not be moved earlier than its soonest start date
1129 1140 date = [soonest_start(true), date].compact.max
1130 1141 end
1131 1142 reschedule_on(date)
1132 1143 begin
1133 1144 save
1134 1145 rescue ActiveRecord::StaleObjectError
1135 1146 reload
1136 1147 reschedule_on(date)
1137 1148 save
1138 1149 end
1139 1150 end
1140 1151 else
1141 1152 leaves.each do |leaf|
1142 1153 if leaf.start_date
1143 1154 # Only move subtask if it starts at the same date as the parent
1144 1155 # or if it starts before the given date
1145 1156 if start_date == leaf.start_date || date > leaf.start_date
1146 1157 leaf.reschedule_on!(date)
1147 1158 end
1148 1159 else
1149 1160 leaf.reschedule_on!(date)
1150 1161 end
1151 1162 end
1152 1163 end
1153 1164 end
1154 1165
1155 1166 def dates_derived?
1156 1167 !leaf? && Setting.parent_issue_dates == 'derived'
1157 1168 end
1158 1169
1159 1170 def priority_derived?
1160 1171 !leaf? && Setting.parent_issue_priority == 'derived'
1161 1172 end
1162 1173
1163 1174 def done_ratio_derived?
1164 1175 !leaf? && Setting.parent_issue_done_ratio == 'derived'
1165 1176 end
1166 1177
1167 1178 def <=>(issue)
1168 1179 if issue.nil?
1169 1180 -1
1170 1181 elsif root_id != issue.root_id
1171 1182 (root_id || 0) <=> (issue.root_id || 0)
1172 1183 else
1173 1184 (lft || 0) <=> (issue.lft || 0)
1174 1185 end
1175 1186 end
1176 1187
1177 1188 def to_s
1178 1189 "#{tracker} ##{id}: #{subject}"
1179 1190 end
1180 1191
1181 1192 # Returns a string of css classes that apply to the issue
1182 1193 def css_classes(user=User.current)
1183 1194 s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
1184 1195 s << ' closed' if closed?
1185 1196 s << ' overdue' if overdue?
1186 1197 s << ' child' if child?
1187 1198 s << ' parent' unless leaf?
1188 1199 s << ' private' if is_private?
1189 1200 if user.logged?
1190 1201 s << ' created-by-me' if author_id == user.id
1191 1202 s << ' assigned-to-me' if assigned_to_id == user.id
1192 1203 s << ' assigned-to-my-group' if user.groups.any? {|g| g.id == assigned_to_id}
1193 1204 end
1194 1205 s
1195 1206 end
1196 1207
1197 1208 # Unassigns issues from +version+ if it's no longer shared with issue's project
1198 1209 def self.update_versions_from_sharing_change(version)
1199 1210 # Update issues assigned to the version
1200 1211 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
1201 1212 end
1202 1213
1203 1214 # Unassigns issues from versions that are no longer shared
1204 1215 # after +project+ was moved
1205 1216 def self.update_versions_from_hierarchy_change(project)
1206 1217 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
1207 1218 # Update issues of the moved projects and issues assigned to a version of a moved project
1208 1219 Issue.update_versions(
1209 1220 ["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)",
1210 1221 moved_project_ids, moved_project_ids]
1211 1222 )
1212 1223 end
1213 1224
1214 1225 def parent_issue_id=(arg)
1215 1226 s = arg.to_s.strip.presence
1216 1227 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
1217 1228 @invalid_parent_issue_id = nil
1218 1229 elsif s.blank?
1219 1230 @parent_issue = nil
1220 1231 @invalid_parent_issue_id = nil
1221 1232 else
1222 1233 @parent_issue = nil
1223 1234 @invalid_parent_issue_id = arg
1224 1235 end
1225 1236 end
1226 1237
1227 1238 def parent_issue_id
1228 1239 if @invalid_parent_issue_id
1229 1240 @invalid_parent_issue_id
1230 1241 elsif instance_variable_defined? :@parent_issue
1231 1242 @parent_issue.nil? ? nil : @parent_issue.id
1232 1243 else
1233 1244 parent_id
1234 1245 end
1235 1246 end
1236 1247
1237 1248 def set_parent_id
1238 1249 self.parent_id = parent_issue_id
1239 1250 end
1240 1251
1241 1252 # Returns true if issue's project is a valid
1242 1253 # parent issue project
1243 1254 def valid_parent_project?(issue=parent)
1244 1255 return true if issue.nil? || issue.project_id == project_id
1245 1256
1246 1257 case Setting.cross_project_subtasks
1247 1258 when 'system'
1248 1259 true
1249 1260 when 'tree'
1250 1261 issue.project.root == project.root
1251 1262 when 'hierarchy'
1252 1263 issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
1253 1264 when 'descendants'
1254 1265 issue.project.is_or_is_ancestor_of?(project)
1255 1266 else
1256 1267 false
1257 1268 end
1258 1269 end
1259 1270
1260 1271 # Returns an issue scope based on project and scope
1261 1272 def self.cross_project_scope(project, scope=nil)
1262 1273 if project.nil?
1263 1274 return Issue
1264 1275 end
1265 1276 case scope
1266 1277 when 'all', 'system'
1267 1278 Issue
1268 1279 when 'tree'
1269 1280 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
1270 1281 :lft => project.root.lft, :rgt => project.root.rgt)
1271 1282 when 'hierarchy'
1272 1283 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt) OR (#{Project.table_name}.lft < :lft AND #{Project.table_name}.rgt > :rgt)",
1273 1284 :lft => project.lft, :rgt => project.rgt)
1274 1285 when 'descendants'
1275 1286 Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
1276 1287 :lft => project.lft, :rgt => project.rgt)
1277 1288 else
1278 1289 Issue.where(:project_id => project.id)
1279 1290 end
1280 1291 end
1281 1292
1282 1293 def self.by_tracker(project)
1283 1294 count_and_group_by(:project => project, :association => :tracker)
1284 1295 end
1285 1296
1286 1297 def self.by_version(project)
1287 1298 count_and_group_by(:project => project, :association => :fixed_version)
1288 1299 end
1289 1300
1290 1301 def self.by_priority(project)
1291 1302 count_and_group_by(:project => project, :association => :priority)
1292 1303 end
1293 1304
1294 1305 def self.by_category(project)
1295 1306 count_and_group_by(:project => project, :association => :category)
1296 1307 end
1297 1308
1298 1309 def self.by_assigned_to(project)
1299 1310 count_and_group_by(:project => project, :association => :assigned_to)
1300 1311 end
1301 1312
1302 1313 def self.by_author(project)
1303 1314 count_and_group_by(:project => project, :association => :author)
1304 1315 end
1305 1316
1306 1317 def self.by_subproject(project)
1307 1318 r = count_and_group_by(:project => project, :with_subprojects => true, :association => :project)
1308 1319 r.reject {|r| r["project_id"] == project.id.to_s}
1309 1320 end
1310 1321
1311 1322 # Query generator for selecting groups of issue counts for a project
1312 1323 # based on specific criteria
1313 1324 #
1314 1325 # Options
1315 1326 # * project - Project to search in.
1316 1327 # * with_subprojects - Includes subprojects issues if set to true.
1317 1328 # * association - Symbol. Association for grouping.
1318 1329 def self.count_and_group_by(options)
1319 1330 assoc = reflect_on_association(options[:association])
1320 1331 select_field = assoc.foreign_key
1321 1332
1322 1333 Issue.
1323 1334 visible(User.current, :project => options[:project], :with_subprojects => options[:with_subprojects]).
1324 1335 joins(:status, assoc.name).
1325 1336 group(:status_id, :is_closed, select_field).
1326 1337 count.
1327 1338 map do |columns, total|
1328 1339 status_id, is_closed, field_value = columns
1329 1340 is_closed = ['t', 'true', '1'].include?(is_closed.to_s)
1330 1341 {
1331 1342 "status_id" => status_id.to_s,
1332 1343 "closed" => is_closed,
1333 1344 select_field => field_value.to_s,
1334 1345 "total" => total.to_s
1335 1346 }
1336 1347 end
1337 1348 end
1338 1349
1339 1350 # Returns a scope of projects that user can assign the issue to
1340 1351 def allowed_target_projects(user=User.current)
1341 1352 current_project = new_record? ? nil : project
1342 1353 self.class.allowed_target_projects(user, current_project)
1343 1354 end
1344 1355
1345 1356 # Returns a scope of projects that user can assign issues to
1346 1357 # If current_project is given, it will be included in the scope
1347 1358 def self.allowed_target_projects(user=User.current, current_project=nil)
1348 1359 condition = Project.allowed_to_condition(user, :add_issues)
1349 1360 if current_project
1350 1361 condition = ["(#{condition}) OR #{Project.table_name}.id = ?", current_project.id]
1351 1362 end
1352 1363 Project.where(condition).having_trackers
1353 1364 end
1354 1365
1355 1366 private
1356 1367
1357 1368 def after_project_change
1358 1369 # Update project_id on related time entries
1359 1370 TimeEntry.where({:issue_id => id}).update_all(["project_id = ?", project_id])
1360 1371
1361 1372 # Delete issue relations
1362 1373 unless Setting.cross_project_issue_relations?
1363 1374 relations_from.clear
1364 1375 relations_to.clear
1365 1376 end
1366 1377
1367 1378 # Move subtasks that were in the same project
1368 1379 children.each do |child|
1369 1380 next unless child.project_id == project_id_was
1370 1381 # Change project and keep project
1371 1382 child.send :project=, project, true
1372 1383 unless child.save
1373 1384 raise ActiveRecord::Rollback
1374 1385 end
1375 1386 end
1376 1387 end
1377 1388
1378 1389 # Callback for after the creation of an issue by copy
1379 1390 # * adds a "copied to" relation with the copied issue
1380 1391 # * copies subtasks from the copied issue
1381 1392 def after_create_from_copy
1382 1393 return unless copy? && !@after_create_from_copy_handled
1383 1394
1384 1395 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
1385 1396 if @current_journal
1386 1397 @copied_from.init_journal(@current_journal.user)
1387 1398 end
1388 1399 relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
1389 1400 unless relation.save
1390 1401 logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
1391 1402 end
1392 1403 end
1393 1404
1394 1405 unless @copied_from.leaf? || @copy_options[:subtasks] == false
1395 1406 copy_options = (@copy_options || {}).merge(:subtasks => false)
1396 1407 copied_issue_ids = {@copied_from.id => self.id}
1397 1408 @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
1398 1409 # Do not copy self when copying an issue as a descendant of the copied issue
1399 1410 next if child == self
1400 1411 # Do not copy subtasks of issues that were not copied
1401 1412 next unless copied_issue_ids[child.parent_id]
1402 1413 # Do not copy subtasks that are not visible to avoid potential disclosure of private data
1403 1414 unless child.visible?
1404 1415 logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
1405 1416 next
1406 1417 end
1407 1418 copy = Issue.new.copy_from(child, copy_options)
1408 1419 if @current_journal
1409 1420 copy.init_journal(@current_journal.user)
1410 1421 end
1411 1422 copy.author = author
1412 1423 copy.project = project
1413 1424 copy.parent_issue_id = copied_issue_ids[child.parent_id]
1414 1425 unless copy.save
1415 1426 logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
1416 1427 next
1417 1428 end
1418 1429 copied_issue_ids[child.id] = copy.id
1419 1430 end
1420 1431 end
1421 1432 @after_create_from_copy_handled = true
1422 1433 end
1423 1434
1424 1435 def update_nested_set_attributes
1425 1436 if parent_id_changed?
1426 1437 update_nested_set_attributes_on_parent_change
1427 1438 end
1428 1439 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
1429 1440 end
1430 1441
1431 1442 # Updates the nested set for when an existing issue is moved
1432 1443 def update_nested_set_attributes_on_parent_change
1433 1444 former_parent_id = parent_id_was
1434 1445 # delete invalid relations of all descendants
1435 1446 self_and_descendants.each do |issue|
1436 1447 issue.relations.each do |relation|
1437 1448 relation.destroy unless relation.valid?
1438 1449 end
1439 1450 end
1440 1451 # update former parent
1441 1452 recalculate_attributes_for(former_parent_id) if former_parent_id
1442 1453 end
1443 1454
1444 1455 def update_parent_attributes
1445 1456 if parent_id
1446 1457 recalculate_attributes_for(parent_id)
1447 1458 association(:parent).reset
1448 1459 end
1449 1460 end
1450 1461
1451 1462 def recalculate_attributes_for(issue_id)
1452 1463 if issue_id && p = Issue.find_by_id(issue_id)
1453 1464 if p.priority_derived?
1454 1465 # priority = highest priority of open children
1455 1466 if priority_position = p.children.open.joins(:priority).maximum("#{IssuePriority.table_name}.position")
1456 1467 p.priority = IssuePriority.find_by_position(priority_position)
1457 1468 else
1458 1469 p.priority = IssuePriority.default
1459 1470 end
1460 1471 end
1461 1472
1462 1473 if p.dates_derived?
1463 1474 # start/due dates = lowest/highest dates of children
1464 1475 p.start_date = p.children.minimum(:start_date)
1465 1476 p.due_date = p.children.maximum(:due_date)
1466 1477 if p.start_date && p.due_date && p.due_date < p.start_date
1467 1478 p.start_date, p.due_date = p.due_date, p.start_date
1468 1479 end
1469 1480 end
1470 1481
1471 1482 if p.done_ratio_derived?
1472 1483 # done ratio = weighted average ratio of leaves
1473 1484 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
1474 1485 child_count = p.children.count
1475 1486 if child_count > 0
1476 1487 average = p.children.where("estimated_hours > 0").average(:estimated_hours).to_f
1477 1488 if average == 0
1478 1489 average = 1
1479 1490 end
1480 1491 done = p.children.joins(:status).
1481 1492 sum("COALESCE(CASE WHEN estimated_hours > 0 THEN estimated_hours ELSE NULL END, #{average}) " +
1482 1493 "* (CASE WHEN is_closed = #{self.class.connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)").to_f
1483 1494 progress = done / (average * child_count)
1484 1495 p.done_ratio = progress.round
1485 1496 end
1486 1497 end
1487 1498 end
1488 1499
1489 1500 # ancestors will be recursively updated
1490 1501 p.save(:validate => false)
1491 1502 end
1492 1503 end
1493 1504
1494 1505 # Update issues so their versions are not pointing to a
1495 1506 # fixed_version that is not shared with the issue's project
1496 1507 def self.update_versions(conditions=nil)
1497 1508 # Only need to update issues with a fixed_version from
1498 1509 # a different project and that is not systemwide shared
1499 1510 Issue.joins(:project, :fixed_version).
1500 1511 where("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
1501 1512 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
1502 1513 " AND #{Version.table_name}.sharing <> 'system'").
1503 1514 where(conditions).each do |issue|
1504 1515 next if issue.project.nil? || issue.fixed_version.nil?
1505 1516 unless issue.project.shared_versions.include?(issue.fixed_version)
1506 1517 issue.init_journal(User.current)
1507 1518 issue.fixed_version = nil
1508 1519 issue.save
1509 1520 end
1510 1521 end
1511 1522 end
1512 1523
1513 1524 # Callback on file attachment
1514 1525 def attachment_added(attachment)
1515 1526 if current_journal && !attachment.new_record?
1516 1527 current_journal.journalize_attachment(attachment, :added)
1517 1528 end
1518 1529 end
1519 1530
1520 1531 # Callback on attachment deletion
1521 1532 def attachment_removed(attachment)
1522 1533 if current_journal && !attachment.new_record?
1523 1534 current_journal.journalize_attachment(attachment, :removed)
1524 1535 current_journal.save
1525 1536 end
1526 1537 end
1527 1538
1528 1539 # Called after a relation is added
1529 1540 def relation_added(relation)
1530 1541 if current_journal
1531 1542 current_journal.journalize_relation(relation, :added)
1532 1543 current_journal.save
1533 1544 end
1534 1545 end
1535 1546
1536 1547 # Called after a relation is removed
1537 1548 def relation_removed(relation)
1538 1549 if current_journal
1539 1550 current_journal.journalize_relation(relation, :removed)
1540 1551 current_journal.save
1541 1552 end
1542 1553 end
1543 1554
1544 1555 # Default assignment based on category
1545 1556 def default_assign
1546 1557 if assigned_to.nil? && category && category.assigned_to
1547 1558 self.assigned_to = category.assigned_to
1548 1559 end
1549 1560 end
1550 1561
1551 1562 # Updates start/due dates of following issues
1552 1563 def reschedule_following_issues
1553 1564 if start_date_changed? || due_date_changed?
1554 1565 relations_from.each do |relation|
1555 1566 relation.set_issue_to_dates
1556 1567 end
1557 1568 end
1558 1569 end
1559 1570
1560 1571 # Closes duplicates if the issue is being closed
1561 1572 def close_duplicates
1562 1573 if closing?
1563 1574 duplicates.each do |duplicate|
1564 1575 # Reload is needed in case the duplicate was updated by a previous duplicate
1565 1576 duplicate.reload
1566 1577 # Don't re-close it if it's already closed
1567 1578 next if duplicate.closed?
1568 1579 # Same user and notes
1569 1580 if @current_journal
1570 1581 duplicate.init_journal(@current_journal.user, @current_journal.notes)
1571 1582 duplicate.private_notes = @current_journal.private_notes
1572 1583 end
1573 1584 duplicate.update_attribute :status, self.status
1574 1585 end
1575 1586 end
1576 1587 end
1577 1588
1578 1589 # Make sure updated_on is updated when adding a note and set updated_on now
1579 1590 # so we can set closed_on with the same value on closing
1580 1591 def force_updated_on_change
1581 1592 if @current_journal || changed?
1582 1593 self.updated_on = current_time_from_proper_timezone
1583 1594 if new_record?
1584 1595 self.created_on = updated_on
1585 1596 end
1586 1597 end
1587 1598 end
1588 1599
1589 1600 # Callback for setting closed_on when the issue is closed.
1590 1601 # The closed_on attribute stores the time of the last closing
1591 1602 # and is preserved when the issue is reopened.
1592 1603 def update_closed_on
1593 1604 if closing?
1594 1605 self.closed_on = updated_on
1595 1606 end
1596 1607 end
1597 1608
1598 1609 # Saves the changes in a Journal
1599 1610 # Called after_save
1600 1611 def create_journal
1601 1612 if current_journal
1602 1613 current_journal.save
1603 1614 end
1604 1615 end
1605 1616
1606 1617 def send_notification
1607 1618 if notify? && Setting.notified_events.include?('issue_added')
1608 1619 Mailer.deliver_issue_add(self)
1609 1620 end
1610 1621 end
1611 1622
1612 1623 # Stores the previous assignee so we can still have access
1613 1624 # to it during after_save callbacks (assigned_to_id_was is reset)
1614 1625 def set_assigned_to_was
1615 1626 @previous_assigned_to_id = assigned_to_id_was
1616 1627 end
1617 1628
1618 1629 # Clears the previous assignee at the end of after_save callbacks
1619 1630 def clear_assigned_to_was
1620 1631 @assigned_to_was = nil
1621 1632 @previous_assigned_to_id = nil
1622 1633 end
1623 1634
1624 1635 def clear_disabled_fields
1625 1636 if tracker
1626 1637 tracker.disabled_core_fields.each do |attribute|
1627 1638 send "#{attribute}=", nil
1628 1639 end
1629 1640 self.done_ratio ||= 0
1630 1641 end
1631 1642 end
1632 1643 end
@@ -1,2714 +1,2748
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :email_addresses, :members, :member_roles, :roles,
22 22 :groups_users,
23 23 :trackers, :projects_trackers,
24 24 :enabled_modules,
25 25 :versions,
26 26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 27 :enumerations,
28 28 :issues, :journals, :journal_details,
29 29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 30 :time_entries
31 31
32 32 include Redmine::I18n
33 33
34 34 def setup
35 35 set_language_if_valid 'en'
36 36 end
37 37
38 38 def teardown
39 39 User.current = nil
40 40 end
41 41
42 42 def test_initialize
43 43 issue = Issue.new
44 44
45 45 assert_nil issue.project_id
46 46 assert_nil issue.tracker_id
47 47 assert_nil issue.status_id
48 48 assert_nil issue.author_id
49 49 assert_nil issue.assigned_to_id
50 50 assert_nil issue.category_id
51 51
52 52 assert_equal IssuePriority.default, issue.priority
53 53 end
54 54
55 55 def test_create
56 56 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
57 57 :status_id => 1, :priority => IssuePriority.all.first,
58 58 :subject => 'test_create',
59 59 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
60 60 assert issue.save
61 61 issue.reload
62 62 assert_equal 1.5, issue.estimated_hours
63 63 end
64 64
65 65 def test_create_minimal
66 66 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
67 67 assert issue.save
68 68 assert_equal issue.tracker.default_status, issue.status
69 69 assert issue.description.nil?
70 70 assert_nil issue.estimated_hours
71 71 end
72 72
73 73 def test_create_with_all_fields_disabled
74 74 tracker = Tracker.find(1)
75 75 tracker.core_fields = []
76 76 tracker.save!
77 77
78 78 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create_with_all_fields_disabled')
79 79 assert_save issue
80 80 end
81 81
82 82 def test_start_date_format_should_be_validated
83 83 set_language_if_valid 'en'
84 84 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
85 85 issue = Issue.new(:start_date => invalid_date)
86 86 assert !issue.valid?
87 87 assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
88 88 end
89 89 end
90 90
91 91 def test_due_date_format_should_be_validated
92 92 set_language_if_valid 'en'
93 93 ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
94 94 issue = Issue.new(:due_date => invalid_date)
95 95 assert !issue.valid?
96 96 assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
97 97 end
98 98 end
99 99
100 100 def test_due_date_lesser_than_start_date_should_not_validate
101 101 set_language_if_valid 'en'
102 102 issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
103 103 assert !issue.valid?
104 104 assert_include 'Due date must be greater than start date', issue.errors.full_messages
105 105 end
106 106
107 107 def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
108 108 issue = Issue.generate(:start_date => '2013-06-04')
109 109 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
110 110 assert !issue.valid?
111 111 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
112 112 end
113 113
114 114 def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
115 115 issue = Issue.generate!(:start_date => '2013-06-04')
116 116 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
117 117 issue.start_date = '2013-06-07'
118 118 assert !issue.valid?
119 119 assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
120 120 end
121 121
122 122 def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
123 123 issue = Issue.generate!(:start_date => '2013-06-04')
124 124 issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
125 125 assert issue.valid?
126 126 end
127 127
128 128 def test_estimated_hours_should_be_validated
129 129 set_language_if_valid 'en'
130 130 ['-2'].each do |invalid|
131 131 issue = Issue.new(:estimated_hours => invalid)
132 132 assert !issue.valid?
133 133 assert_include 'Estimated time is invalid', issue.errors.full_messages
134 134 end
135 135 end
136 136
137 137 def test_create_with_required_custom_field
138 138 set_language_if_valid 'en'
139 139 field = IssueCustomField.find_by_name('Database')
140 140 field.update_attribute(:is_required, true)
141 141
142 142 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
143 143 :status_id => 1, :subject => 'test_create',
144 144 :description => 'IssueTest#test_create_with_required_custom_field')
145 145 assert issue.available_custom_fields.include?(field)
146 146 # No value for the custom field
147 147 assert !issue.save
148 148 assert_equal ["Database cannot be blank"], issue.errors.full_messages
149 149 # Blank value
150 150 issue.custom_field_values = { field.id => '' }
151 151 assert !issue.save
152 152 assert_equal ["Database cannot be blank"], issue.errors.full_messages
153 153 # Invalid value
154 154 issue.custom_field_values = { field.id => 'SQLServer' }
155 155 assert !issue.save
156 156 assert_equal ["Database is not included in the list"], issue.errors.full_messages
157 157 # Valid value
158 158 issue.custom_field_values = { field.id => 'PostgreSQL' }
159 159 assert issue.save
160 160 issue.reload
161 161 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
162 162 end
163 163
164 164 def test_create_with_group_assignment
165 165 with_settings :issue_group_assignment => '1' do
166 166 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
167 167 :subject => 'Group assignment',
168 168 :assigned_to_id => 11).save
169 169 issue = Issue.order('id DESC').first
170 170 assert_kind_of Group, issue.assigned_to
171 171 assert_equal Group.find(11), issue.assigned_to
172 172 end
173 173 end
174 174
175 175 def test_create_with_parent_issue_id
176 176 issue = Issue.new(:project_id => 1, :tracker_id => 1,
177 177 :author_id => 1, :subject => 'Group assignment',
178 178 :parent_issue_id => 1)
179 179 assert_save issue
180 180 assert_equal 1, issue.parent_issue_id
181 181 assert_equal Issue.find(1), issue.parent
182 182 end
183 183
184 184 def test_create_with_sharp_parent_issue_id
185 185 issue = Issue.new(:project_id => 1, :tracker_id => 1,
186 186 :author_id => 1, :subject => 'Group assignment',
187 187 :parent_issue_id => "#1")
188 188 assert_save issue
189 189 assert_equal 1, issue.parent_issue_id
190 190 assert_equal Issue.find(1), issue.parent
191 191 end
192 192
193 193 def test_create_with_invalid_parent_issue_id
194 194 set_language_if_valid 'en'
195 195 issue = Issue.new(:project_id => 1, :tracker_id => 1,
196 196 :author_id => 1, :subject => 'Group assignment',
197 197 :parent_issue_id => '01ABC')
198 198 assert !issue.save
199 199 assert_equal '01ABC', issue.parent_issue_id
200 200 assert_include 'Parent task is invalid', issue.errors.full_messages
201 201 end
202 202
203 203 def test_create_with_invalid_sharp_parent_issue_id
204 204 set_language_if_valid 'en'
205 205 issue = Issue.new(:project_id => 1, :tracker_id => 1,
206 206 :author_id => 1, :subject => 'Group assignment',
207 207 :parent_issue_id => '#01ABC')
208 208 assert !issue.save
209 209 assert_equal '#01ABC', issue.parent_issue_id
210 210 assert_include 'Parent task is invalid', issue.errors.full_messages
211 211 end
212 212
213 213 def assert_visibility_match(user, issues)
214 214 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
215 215 end
216 216
217 217 def test_visible_scope_for_anonymous
218 218 # Anonymous user should see issues of public projects only
219 219 issues = Issue.visible(User.anonymous).to_a
220 220 assert issues.any?
221 221 assert_nil issues.detect {|issue| !issue.project.is_public?}
222 222 assert_nil issues.detect {|issue| issue.is_private?}
223 223 assert_visibility_match User.anonymous, issues
224 224 end
225 225
226 226 def test_visible_scope_for_anonymous_without_view_issues_permissions
227 227 # Anonymous user should not see issues without permission
228 228 Role.anonymous.remove_permission!(:view_issues)
229 229 issues = Issue.visible(User.anonymous).to_a
230 230 assert issues.empty?
231 231 assert_visibility_match User.anonymous, issues
232 232 end
233 233
234 234 def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
235 235 Role.anonymous.remove_permission!(:view_issues)
236 236 Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])
237 237
238 238 issues = Issue.visible(User.anonymous).all
239 239 assert issues.any?
240 240 assert_equal [1], issues.map(&:project_id).uniq.sort
241 241 assert_visibility_match User.anonymous, issues
242 242 end
243 243
244 244 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
245 245 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
246 246 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
247 247 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
248 248 assert !issue.visible?(User.anonymous)
249 249 end
250 250
251 251 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
252 252 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
253 253 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
254 254 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
255 255 assert !issue.visible?(User.anonymous)
256 256 end
257 257
258 258 def test_visible_scope_for_non_member
259 259 user = User.find(9)
260 260 assert user.projects.empty?
261 261 # Non member user should see issues of public projects only
262 262 issues = Issue.visible(user).to_a
263 263 assert issues.any?
264 264 assert_nil issues.detect {|issue| !issue.project.is_public?}
265 265 assert_nil issues.detect {|issue| issue.is_private?}
266 266 assert_visibility_match user, issues
267 267 end
268 268
269 269 def test_visible_scope_for_non_member_with_own_issues_visibility
270 270 Role.non_member.update_attribute :issues_visibility, 'own'
271 271 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
272 272 user = User.find(9)
273 273
274 274 issues = Issue.visible(user).to_a
275 275 assert issues.any?
276 276 assert_nil issues.detect {|issue| issue.author != user}
277 277 assert_visibility_match user, issues
278 278 end
279 279
280 280 def test_visible_scope_for_non_member_without_view_issues_permissions
281 281 # Non member user should not see issues without permission
282 282 Role.non_member.remove_permission!(:view_issues)
283 283 user = User.find(9)
284 284 assert user.projects.empty?
285 285 issues = Issue.visible(user).to_a
286 286 assert issues.empty?
287 287 assert_visibility_match user, issues
288 288 end
289 289
290 290 def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
291 291 Role.non_member.remove_permission!(:view_issues)
292 292 Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
293 293 user = User.find(9)
294 294
295 295 issues = Issue.visible(user).all
296 296 assert issues.any?
297 297 assert_equal [1], issues.map(&:project_id).uniq.sort
298 298 assert_visibility_match user, issues
299 299 end
300 300
301 301 def test_visible_scope_for_member
302 302 user = User.find(9)
303 303 # User should see issues of projects for which user has view_issues permissions only
304 304 Role.non_member.remove_permission!(:view_issues)
305 305 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
306 306 issues = Issue.visible(user).to_a
307 307 assert issues.any?
308 308 assert_nil issues.detect {|issue| issue.project_id != 3}
309 309 assert_nil issues.detect {|issue| issue.is_private?}
310 310 assert_visibility_match user, issues
311 311 end
312 312
313 313 def test_visible_scope_for_member_without_view_issues_permission_and_non_member_role_having_the_permission
314 314 Role.non_member.add_permission!(:view_issues)
315 315 Role.find(1).remove_permission!(:view_issues)
316 316 user = User.find(2)
317 317
318 318 assert_equal 0, Issue.where(:project_id => 1).visible(user).count
319 319 assert_equal false, Issue.where(:project_id => 1).first.visible?(user)
320 320 end
321 321
322 322 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
323 323 user = User.find(8)
324 324 assert user.groups.any?
325 325 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
326 326 Role.non_member.remove_permission!(:view_issues)
327 327
328 328 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
329 329 :status_id => 1, :priority => IssuePriority.all.first,
330 330 :subject => 'Assignment test',
331 331 :assigned_to => user.groups.first,
332 332 :is_private => true)
333 333
334 334 Role.find(2).update_attribute :issues_visibility, 'default'
335 335 issues = Issue.visible(User.find(8)).to_a
336 336 assert issues.any?
337 337 assert issues.include?(issue)
338 338
339 339 Role.find(2).update_attribute :issues_visibility, 'own'
340 340 issues = Issue.visible(User.find(8)).to_a
341 341 assert issues.any?
342 342 assert_include issue, issues
343 343 end
344 344
345 345 def test_visible_scope_for_admin
346 346 user = User.find(1)
347 347 user.members.each(&:destroy)
348 348 assert user.projects.empty?
349 349 issues = Issue.visible(user).to_a
350 350 assert issues.any?
351 351 # Admin should see issues on private projects that admin does not belong to
352 352 assert issues.detect {|issue| !issue.project.is_public?}
353 353 # Admin should see private issues of other users
354 354 assert issues.detect {|issue| issue.is_private? && issue.author != user}
355 355 assert_visibility_match user, issues
356 356 end
357 357
358 358 def test_visible_scope_with_project
359 359 project = Project.find(1)
360 360 issues = Issue.visible(User.find(2), :project => project).to_a
361 361 projects = issues.collect(&:project).uniq
362 362 assert_equal 1, projects.size
363 363 assert_equal project, projects.first
364 364 end
365 365
366 366 def test_visible_scope_with_project_and_subprojects
367 367 project = Project.find(1)
368 368 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
369 369 projects = issues.collect(&:project).uniq
370 370 assert projects.size > 1
371 371 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
372 372 end
373 373
374 374 def test_visible_and_nested_set_scopes
375 375 user = User.generate!
376 376 parent = Issue.generate!(:assigned_to => user)
377 377 assert parent.visible?(user)
378 378 child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
379 379 child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
380 380 parent.reload
381 381 child1.reload
382 382 child2.reload
383 383 assert child1.visible?(user)
384 384 assert child2.visible?(user)
385 385 assert_equal 2, parent.descendants.count
386 386 assert_equal 2, parent.descendants.visible(user).count
387 387 # awesome_nested_set 2-1-stable branch has regression.
388 388 # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
389 389 # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
390 390 assert_equal 2, parent.descendants.collect{|i| i}.size
391 391 assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
392 392 end
393 393
394 394 def test_visible_scope_with_unsaved_user_should_not_raise_an_error
395 395 user = User.new
396 396 assert_nothing_raised do
397 397 Issue.visible(user).to_a
398 398 end
399 399 end
400 400
401 401 def test_open_scope
402 402 issues = Issue.open.to_a
403 403 assert_nil issues.detect(&:closed?)
404 404 end
405 405
406 406 def test_open_scope_with_arg
407 407 issues = Issue.open(false).to_a
408 408 assert_equal issues, issues.select(&:closed?)
409 409 end
410 410
411 411 def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
412 412 version = Version.find(2)
413 413 assert version.fixed_issues.any?
414 414 assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
415 415 end
416 416
417 417 def test_fixed_version_scope_with_empty_array_should_return_no_result
418 418 assert_equal 0, Issue.fixed_version([]).count
419 419 end
420 420
421 421 def test_assigned_to_scope_should_return_issues_assigned_to_the_user
422 422 user = User.generate!
423 423 issue = Issue.generate!
424 424 Issue.where(:id => issue.id).update_all :assigned_to_id => user.id
425 425 assert_equal [issue], Issue.assigned_to(user).to_a
426 426 end
427 427
428 428 def test_assigned_to_scope_should_return_issues_assigned_to_the_user_groups
429 429 group = Group.generate!
430 430 user = User.generate!
431 431 group.users << user
432 432 issue = Issue.generate!
433 433 Issue.where(:id => issue.id).update_all :assigned_to_id => group.id
434 434 assert_equal [issue], Issue.assigned_to(user).to_a
435 435 end
436 436
437 437 def test_errors_full_messages_should_include_custom_fields_errors
438 438 field = IssueCustomField.find_by_name('Database')
439 439
440 440 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
441 441 :status_id => 1, :subject => 'test_create',
442 442 :description => 'IssueTest#test_create_with_required_custom_field')
443 443 assert issue.available_custom_fields.include?(field)
444 444 # Invalid value
445 445 issue.custom_field_values = { field.id => 'SQLServer' }
446 446
447 447 assert !issue.valid?
448 448 assert_equal 1, issue.errors.full_messages.size
449 449 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
450 450 issue.errors.full_messages.first
451 451 end
452 452
453 453 def test_update_issue_with_required_custom_field
454 454 field = IssueCustomField.find_by_name('Database')
455 455 field.update_attribute(:is_required, true)
456 456
457 457 issue = Issue.find(1)
458 458 assert_nil issue.custom_value_for(field)
459 459 assert issue.available_custom_fields.include?(field)
460 460 # No change to custom values, issue can be saved
461 461 assert issue.save
462 462 # Blank value
463 463 issue.custom_field_values = { field.id => '' }
464 464 assert !issue.save
465 465 # Valid value
466 466 issue.custom_field_values = { field.id => 'PostgreSQL' }
467 467 assert issue.save
468 468 issue.reload
469 469 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
470 470 end
471 471
472 472 def test_should_not_update_attributes_if_custom_fields_validation_fails
473 473 issue = Issue.find(1)
474 474 field = IssueCustomField.find_by_name('Database')
475 475 assert issue.available_custom_fields.include?(field)
476 476
477 477 issue.custom_field_values = { field.id => 'Invalid' }
478 478 issue.subject = 'Should be not be saved'
479 479 assert !issue.save
480 480
481 481 issue.reload
482 482 assert_equal "Cannot print recipes", issue.subject
483 483 end
484 484
485 485 def test_should_not_recreate_custom_values_objects_on_update
486 486 field = IssueCustomField.find_by_name('Database')
487 487
488 488 issue = Issue.find(1)
489 489 issue.custom_field_values = { field.id => 'PostgreSQL' }
490 490 assert issue.save
491 491 custom_value = issue.custom_value_for(field)
492 492 issue.reload
493 493 issue.custom_field_values = { field.id => 'MySQL' }
494 494 assert issue.save
495 495 issue.reload
496 496 assert_equal custom_value.id, issue.custom_value_for(field).id
497 497 end
498 498
499 499 def test_setting_project_should_set_version_to_default_version
500 500 version = Version.generate!(:project_id => 1)
501 501 Project.find(1).update_attribute(:default_version_id, version.id)
502 502
503 503 issue = Issue.new(:project_id => 1)
504 504 assert_equal version, issue.fixed_version
505 505 end
506 506
507 507 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
508 508 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
509 509 :status_id => 1, :subject => 'Test',
510 510 :custom_field_values => {'2' => 'Test'})
511 511 assert !Tracker.find(2).custom_field_ids.include?(2)
512 512
513 513 issue = Issue.find(issue.id)
514 514 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
515 515
516 516 issue = Issue.find(issue.id)
517 517 custom_value = issue.custom_value_for(2)
518 518 assert_not_nil custom_value
519 519 assert_equal 'Test', custom_value.value
520 520 end
521 521
522 522 def test_assigning_tracker_id_should_reload_custom_fields_values
523 523 issue = Issue.new(:project => Project.find(1))
524 524 assert issue.custom_field_values.empty?
525 525 issue.tracker_id = 1
526 526 assert issue.custom_field_values.any?
527 527 end
528 528
529 529 def test_assigning_attributes_should_assign_project_and_tracker_first
530 530 seq = sequence('seq')
531 531 issue = Issue.new
532 532 issue.expects(:project_id=).in_sequence(seq)
533 533 issue.expects(:tracker_id=).in_sequence(seq)
534 534 issue.expects(:subject=).in_sequence(seq)
535 535 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
536 536 end
537 537
538 538 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
539 539 attributes = ActiveSupport::OrderedHash.new
540 540 attributes['custom_field_values'] = { '1' => 'MySQL' }
541 541 attributes['tracker_id'] = '1'
542 542 issue = Issue.new(:project => Project.find(1))
543 543 issue.attributes = attributes
544 544 assert_equal 'MySQL', issue.custom_field_value(1)
545 545 end
546 546
547 547 def test_changing_tracker_should_clear_disabled_core_fields
548 548 tracker = Tracker.find(2)
549 549 tracker.core_fields = tracker.core_fields - %w(due_date)
550 550 tracker.save!
551 551
552 552 issue = Issue.generate!(:tracker_id => 1, :start_date => Date.today, :due_date => Date.today)
553 553 issue.save!
554 554
555 555 issue.tracker_id = 2
556 556 issue.save!
557 557 assert_not_nil issue.start_date
558 558 assert_nil issue.due_date
559 559 end
560 560
561 561 def test_changing_tracker_should_not_add_cleared_fields_to_journal
562 562 tracker = Tracker.find(2)
563 563 tracker.core_fields = tracker.core_fields - %w(due_date)
564 564 tracker.save!
565 565
566 566 issue = Issue.generate!(:tracker_id => 1, :due_date => Date.today)
567 567 issue.save!
568 568
569 569 assert_difference 'Journal.count' do
570 570 issue.init_journal User.find(1)
571 571 issue.tracker_id = 2
572 572 issue.save!
573 573 assert_nil issue.due_date
574 574 end
575 575 journal = Journal.order('id DESC').first
576 576 assert_equal 1, journal.details.count
577 577 end
578 578
579 579 def test_reload_should_reload_custom_field_values
580 580 issue = Issue.generate!
581 581 issue.custom_field_values = {'2' => 'Foo'}
582 582 issue.save!
583 583
584 584 issue = Issue.order('id desc').first
585 585 assert_equal 'Foo', issue.custom_field_value(2)
586 586
587 587 issue.custom_field_values = {'2' => 'Bar'}
588 588 assert_equal 'Bar', issue.custom_field_value(2)
589 589
590 590 issue.reload
591 591 assert_equal 'Foo', issue.custom_field_value(2)
592 592 end
593 593
594 594 def test_should_update_issue_with_disabled_tracker
595 595 p = Project.find(1)
596 596 issue = Issue.find(1)
597 597
598 598 p.trackers.delete(issue.tracker)
599 599 assert !p.trackers.include?(issue.tracker)
600 600
601 601 issue.reload
602 602 issue.subject = 'New subject'
603 603 assert issue.save
604 604 end
605 605
606 606 def test_should_not_set_a_disabled_tracker
607 607 p = Project.find(1)
608 608 p.trackers.delete(Tracker.find(2))
609 609
610 610 issue = Issue.find(1)
611 611 issue.tracker_id = 2
612 612 issue.subject = 'New subject'
613 613 assert !issue.save
614 614 assert_not_equal [], issue.errors[:tracker_id]
615 615 end
616 616
617 617 def test_category_based_assignment
618 618 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
619 619 :status_id => 1, :priority => IssuePriority.all.first,
620 620 :subject => 'Assignment test',
621 621 :description => 'Assignment test', :category_id => 1)
622 622 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
623 623 end
624 624
625 625 def test_new_statuses_allowed_to
626 626 WorkflowTransition.delete_all
627 627 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
628 628 :old_status_id => 1, :new_status_id => 2,
629 629 :author => false, :assignee => false)
630 630 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
631 631 :old_status_id => 1, :new_status_id => 3,
632 632 :author => true, :assignee => false)
633 633 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
634 634 :old_status_id => 1, :new_status_id => 4,
635 635 :author => false, :assignee => true)
636 636 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
637 637 :old_status_id => 1, :new_status_id => 5,
638 638 :author => true, :assignee => true)
639 639 status = IssueStatus.find(1)
640 640 role = Role.find(1)
641 641 tracker = Tracker.find(1)
642 642 user = User.find(2)
643 643
644 644 issue = Issue.generate!(:tracker => tracker, :status => status,
645 645 :project_id => 1, :author_id => 1)
646 646 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
647 647
648 648 issue = Issue.generate!(:tracker => tracker, :status => status,
649 649 :project_id => 1, :author => user)
650 650 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
651 651
652 652 issue = Issue.generate!(:tracker => tracker, :status => status,
653 653 :project_id => 1, :author_id => 1,
654 654 :assigned_to => user)
655 655 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
656 656
657 657 issue = Issue.generate!(:tracker => tracker, :status => status,
658 658 :project_id => 1, :author => user,
659 659 :assigned_to => user)
660 660 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
661 661
662 662 group = Group.generate!
663 663 group.users << user
664 664 issue = Issue.generate!(:tracker => tracker, :status => status,
665 665 :project_id => 1, :author => user,
666 666 :assigned_to => group)
667 667 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
668 668 end
669 669
670 670 def test_new_statuses_allowed_to_should_consider_group_assignment
671 671 WorkflowTransition.delete_all
672 672 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
673 673 :old_status_id => 1, :new_status_id => 4,
674 674 :author => false, :assignee => true)
675 675 user = User.find(2)
676 676 group = Group.generate!
677 677 group.users << user
678 678
679 679 issue = Issue.generate!(:author_id => 1, :assigned_to => group)
680 680 assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
681 681 end
682 682
683 683 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
684 684 admin = User.find(1)
685 685 issue = Issue.find(1)
686 686 assert !admin.member_of?(issue.project)
687 687 expected_statuses = [issue.status] +
688 688 WorkflowTransition.where(:old_status_id => issue.status_id).
689 689 map(&:new_status).uniq.sort
690 690 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
691 691 end
692 692
693 693 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
694 694 issue = Issue.find(1).copy
695 695 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
696 696
697 697 issue = Issue.find(2).copy
698 698 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
699 699 end
700 700
701 701 def test_safe_attributes_names_should_not_include_disabled_field
702 702 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
703 703
704 704 issue = Issue.new(:tracker => tracker)
705 705 assert_include 'tracker_id', issue.safe_attribute_names
706 706 assert_include 'status_id', issue.safe_attribute_names
707 707 assert_include 'subject', issue.safe_attribute_names
708 708 assert_include 'description', issue.safe_attribute_names
709 709 assert_include 'custom_field_values', issue.safe_attribute_names
710 710 assert_include 'custom_fields', issue.safe_attribute_names
711 711 assert_include 'lock_version', issue.safe_attribute_names
712 712
713 713 tracker.core_fields.each do |field|
714 714 assert_include field, issue.safe_attribute_names
715 715 end
716 716
717 717 tracker.disabled_core_fields.each do |field|
718 718 assert_not_include field, issue.safe_attribute_names
719 719 end
720 720 end
721 721
722 722 def test_safe_attributes_should_ignore_disabled_fields
723 723 tracker = Tracker.find(1)
724 724 tracker.core_fields = %w(assigned_to_id due_date)
725 725 tracker.save!
726 726
727 727 issue = Issue.new(:tracker => tracker)
728 728 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
729 729 assert_nil issue.start_date
730 730 assert_equal Date.parse('2012-07-14'), issue.due_date
731 731 end
732 732
733 733 def test_safe_attributes_should_accept_target_tracker_enabled_fields
734 734 source = Tracker.find(1)
735 735 source.core_fields = []
736 736 source.save!
737 737 target = Tracker.find(2)
738 738 target.core_fields = %w(assigned_to_id due_date)
739 739 target.save!
740 740
741 741 issue = Issue.new(:tracker => source)
742 742 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
743 743 assert_equal target, issue.tracker
744 744 assert_equal Date.parse('2012-07-14'), issue.due_date
745 745 end
746 746
747 747 def test_safe_attributes_should_not_include_readonly_fields
748 748 WorkflowPermission.delete_all
749 749 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
750 750 :role_id => 1, :field_name => 'due_date',
751 751 :rule => 'readonly')
752 752 user = User.find(2)
753 753
754 754 issue = Issue.new(:project_id => 1, :tracker_id => 1)
755 755 assert_equal %w(due_date), issue.read_only_attribute_names(user)
756 756 assert_not_include 'due_date', issue.safe_attribute_names(user)
757 757
758 758 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
759 759 assert_equal Date.parse('2012-07-14'), issue.start_date
760 760 assert_nil issue.due_date
761 761 end
762 762
763 763 def test_safe_attributes_should_not_include_readonly_custom_fields
764 764 cf1 = IssueCustomField.create!(:name => 'Writable field',
765 765 :field_format => 'string',
766 766 :is_for_all => true, :tracker_ids => [1])
767 767 cf2 = IssueCustomField.create!(:name => 'Readonly field',
768 768 :field_format => 'string',
769 769 :is_for_all => true, :tracker_ids => [1])
770 770 WorkflowPermission.delete_all
771 771 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
772 772 :role_id => 1, :field_name => cf2.id.to_s,
773 773 :rule => 'readonly')
774 774 user = User.find(2)
775 775 issue = Issue.new(:project_id => 1, :tracker_id => 1)
776 776 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
777 777 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
778 778
779 779 issue.send :safe_attributes=, {'custom_field_values' => {
780 780 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
781 781 }}, user
782 782 assert_equal 'value1', issue.custom_field_value(cf1)
783 783 assert_nil issue.custom_field_value(cf2)
784 784
785 785 issue.send :safe_attributes=, {'custom_fields' => [
786 786 {'id' => cf1.id.to_s, 'value' => 'valuea'},
787 787 {'id' => cf2.id.to_s, 'value' => 'valueb'}
788 788 ]}, user
789 789 assert_equal 'valuea', issue.custom_field_value(cf1)
790 790 assert_nil issue.custom_field_value(cf2)
791 791 end
792 792
793 def test_safe_attributes_should_ignore_unassignable_assignee
794 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
795 :status_id => 1, :priority => IssuePriority.all.first,
796 :subject => 'test_create')
797 assert issue.valid?
798
799 # locked user, not allowed
800 issue.safe_attributes=({'assigned_to_id' => '5'})
801 assert_nil issue.assigned_to_id
802 # no member
803 issue.safe_attributes=({'assigned_to_id' => '1'})
804 assert_nil issue.assigned_to_id
805 # user 2 is ok
806 issue.safe_attributes=({'assigned_to_id' => '2'})
807 assert_equal 2, issue.assigned_to_id
808 assert issue.save
809
810 issue.reload
811 assert_equal 2, issue.assigned_to_id
812 issue.safe_attributes=({'assigned_to_id' => '5'})
813 assert_equal 2, issue.assigned_to_id
814 issue.safe_attributes=({'assigned_to_id' => '1'})
815 assert_equal 2, issue.assigned_to_id
816 # user 3 is also ok
817 issue.safe_attributes=({'assigned_to_id' => '3'})
818 assert_equal 3, issue.assigned_to_id
819 assert issue.save
820
821 # removal of assignee
822 issue.safe_attributes=({'assigned_to_id' => ''})
823 assert_nil issue.assigned_to_id
824 assert issue.save
825 end
826
793 827 def test_editable_custom_field_values_should_return_non_readonly_custom_values
794 828 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
795 829 :is_for_all => true, :tracker_ids => [1, 2])
796 830 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
797 831 :is_for_all => true, :tracker_ids => [1, 2])
798 832 WorkflowPermission.delete_all
799 833 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
800 834 :field_name => cf2.id.to_s, :rule => 'readonly')
801 835 user = User.find(2)
802 836
803 837 issue = Issue.new(:project_id => 1, :tracker_id => 1)
804 838 values = issue.editable_custom_field_values(user)
805 839 assert values.detect {|value| value.custom_field == cf1}
806 840 assert_nil values.detect {|value| value.custom_field == cf2}
807 841
808 842 issue.tracker_id = 2
809 843 values = issue.editable_custom_field_values(user)
810 844 assert values.detect {|value| value.custom_field == cf1}
811 845 assert values.detect {|value| value.custom_field == cf2}
812 846 end
813 847
814 848 def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
815 849 enabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [1,2])
816 850 disabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [2])
817 851 user = User.find(2)
818 852 issue = Issue.new(:project_id => 1, :tracker_id => 1)
819 853
820 854 assert_include enabled_cf, issue.editable_custom_fields(user)
821 855 assert_not_include disabled_cf, issue.editable_custom_fields(user)
822 856 end
823 857
824 858 def test_safe_attributes_should_accept_target_tracker_writable_fields
825 859 WorkflowPermission.delete_all
826 860 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
827 861 :role_id => 1, :field_name => 'due_date',
828 862 :rule => 'readonly')
829 863 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
830 864 :role_id => 1, :field_name => 'start_date',
831 865 :rule => 'readonly')
832 866 user = User.find(2)
833 867
834 868 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
835 869
836 870 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
837 871 'due_date' => '2012-07-14'}, user
838 872 assert_equal Date.parse('2012-07-12'), issue.start_date
839 873 assert_nil issue.due_date
840 874
841 875 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
842 876 'due_date' => '2012-07-16',
843 877 'tracker_id' => 2}, user
844 878 assert_equal Date.parse('2012-07-12'), issue.start_date
845 879 assert_equal Date.parse('2012-07-16'), issue.due_date
846 880 end
847 881
848 882 def test_safe_attributes_should_accept_target_status_writable_fields
849 883 WorkflowPermission.delete_all
850 884 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
851 885 :role_id => 1, :field_name => 'due_date',
852 886 :rule => 'readonly')
853 887 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
854 888 :role_id => 1, :field_name => 'start_date',
855 889 :rule => 'readonly')
856 890 user = User.find(2)
857 891
858 892 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
859 893
860 894 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
861 895 'due_date' => '2012-07-14'},
862 896 user
863 897 assert_equal Date.parse('2012-07-12'), issue.start_date
864 898 assert_nil issue.due_date
865 899
866 900 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
867 901 'due_date' => '2012-07-16',
868 902 'status_id' => 2},
869 903 user
870 904 assert_equal Date.parse('2012-07-12'), issue.start_date
871 905 assert_equal Date.parse('2012-07-16'), issue.due_date
872 906 end
873 907
874 908 def test_required_attributes_should_be_validated
875 909 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
876 910 :is_for_all => true, :tracker_ids => [1, 2])
877 911
878 912 WorkflowPermission.delete_all
879 913 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
880 914 :role_id => 1, :field_name => 'due_date',
881 915 :rule => 'required')
882 916 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
883 917 :role_id => 1, :field_name => 'category_id',
884 918 :rule => 'required')
885 919 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
886 920 :role_id => 1, :field_name => cf.id.to_s,
887 921 :rule => 'required')
888 922
889 923 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
890 924 :role_id => 1, :field_name => 'start_date',
891 925 :rule => 'required')
892 926 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
893 927 :role_id => 1, :field_name => cf.id.to_s,
894 928 :rule => 'required')
895 929 user = User.find(2)
896 930
897 931 issue = Issue.new(:project_id => 1, :tracker_id => 1,
898 932 :status_id => 1, :subject => 'Required fields',
899 933 :author => user)
900 934 assert_equal [cf.id.to_s, "category_id", "due_date"],
901 935 issue.required_attribute_names(user).sort
902 936 assert !issue.save, "Issue was saved"
903 937 assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
904 938 issue.errors.full_messages.sort
905 939
906 940 issue.tracker_id = 2
907 941 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
908 942 assert !issue.save, "Issue was saved"
909 943 assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
910 944 issue.errors.full_messages.sort
911 945
912 946 issue.start_date = Date.today
913 947 issue.custom_field_values = {cf.id.to_s => 'bar'}
914 948 assert issue.save
915 949 end
916 950
917 951 def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
918 952 WorkflowPermission.delete_all
919 953 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
920 954 :role_id => 1, :field_name => 'start_date',
921 955 :rule => 'required')
922 956 user = User.find(2)
923 957
924 958 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
925 959 :subject => 'Required fields', :author => user)
926 960 assert !issue.save
927 961 assert_include "Start date cannot be blank", issue.errors.full_messages
928 962
929 963 tracker = Tracker.find(1)
930 964 tracker.core_fields -= %w(start_date)
931 965 tracker.save!
932 966 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
933 967 :subject => 'Required fields', :author => user)
934 968 assert issue.save
935 969 end
936 970
937 971 def test_category_should_not_be_required_if_project_has_no_categories
938 972 Project.find(1).issue_categories.delete_all
939 973 WorkflowPermission.delete_all
940 974 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
941 975 :role_id => 1, :field_name => 'category_id',:rule => 'required')
942 976 user = User.find(2)
943 977
944 978 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
945 979 :subject => 'Required fields', :author => user)
946 980 assert_save issue
947 981 end
948 982
949 983 def test_fixed_version_should_not_be_required_no_assignable_versions
950 984 Version.delete_all
951 985 WorkflowPermission.delete_all
952 986 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
953 987 :role_id => 1, :field_name => 'fixed_version_id',:rule => 'required')
954 988 user = User.find(2)
955 989
956 990 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
957 991 :subject => 'Required fields', :author => user)
958 992 assert_save issue
959 993 end
960 994
961 995 def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
962 996 CustomField.delete_all
963 997 field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
964 998 user = User.generate!
965 999 User.add_to_project(user, Project.find(1), Role.find(2))
966 1000
967 1001 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
968 1002 :subject => 'Required fields', :author => user)
969 1003 assert_save issue
970 1004 end
971 1005
972 1006 def test_required_custom_field_that_is_visible_for_the_user_should_be_required
973 1007 CustomField.delete_all
974 1008 field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
975 1009 user = User.generate!
976 1010 User.add_to_project(user, Project.find(1), Role.find(1))
977 1011
978 1012 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
979 1013 :subject => 'Required fields', :author => user)
980 1014 assert !issue.save
981 1015 assert_include "#{field.name} cannot be blank", issue.errors.full_messages
982 1016 end
983 1017
984 1018 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
985 1019 WorkflowPermission.delete_all
986 1020 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
987 1021 :role_id => 1, :field_name => 'due_date',
988 1022 :rule => 'required')
989 1023 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
990 1024 :role_id => 1, :field_name => 'start_date',
991 1025 :rule => 'required')
992 1026 user = User.find(2)
993 1027 member = Member.find(1)
994 1028 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
995 1029
996 1030 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
997 1031
998 1032 member.role_ids = [1, 2]
999 1033 member.save!
1000 1034 assert_equal [], issue.required_attribute_names(user.reload)
1001 1035
1002 1036 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1003 1037 :role_id => 2, :field_name => 'due_date',
1004 1038 :rule => 'required')
1005 1039 assert_equal %w(due_date), issue.required_attribute_names(user)
1006 1040
1007 1041 member.role_ids = [1, 2, 3]
1008 1042 member.save!
1009 1043 assert_equal [], issue.required_attribute_names(user.reload)
1010 1044
1011 1045 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1012 1046 :role_id => 3, :field_name => 'due_date',
1013 1047 :rule => 'readonly')
1014 1048 # required + readonly => required
1015 1049 assert_equal %w(due_date), issue.required_attribute_names(user)
1016 1050 end
1017 1051
1018 1052 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
1019 1053 WorkflowPermission.delete_all
1020 1054 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1021 1055 :role_id => 1, :field_name => 'due_date',
1022 1056 :rule => 'readonly')
1023 1057 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1024 1058 :role_id => 1, :field_name => 'start_date',
1025 1059 :rule => 'readonly')
1026 1060 user = User.find(2)
1027 1061 member = Member.find(1)
1028 1062 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1029 1063
1030 1064 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
1031 1065
1032 1066 member.role_ids = [1, 2]
1033 1067 member.save!
1034 1068 assert_equal [], issue.read_only_attribute_names(user.reload)
1035 1069
1036 1070 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1037 1071 :role_id => 2, :field_name => 'due_date',
1038 1072 :rule => 'readonly')
1039 1073 assert_equal %w(due_date), issue.read_only_attribute_names(user)
1040 1074 end
1041 1075
1042 1076 # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
1043 1077 def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
1044 1078 field = IssueCustomField.generate!(
1045 1079 :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
1046 1080 )
1047 1081 WorkflowPermission.delete_all
1048 1082 WorkflowPermission.create!(
1049 1083 :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
1050 1084 )
1051 1085 user = User.generate!
1052 1086 project = Project.find(1)
1053 1087 User.add_to_project(user, project, Role.where(:id => [1, 2]))
1054 1088
1055 1089 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1056 1090 assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
1057 1091 end
1058 1092
1059 1093 def test_workflow_rules_should_ignore_roles_without_issue_permissions
1060 1094 role = Role.generate! :permissions => [:view_issues, :edit_issues]
1061 1095 ignored_role = Role.generate! :permissions => [:view_issues]
1062 1096
1063 1097 WorkflowPermission.delete_all
1064 1098 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1065 1099 :role => role, :field_name => 'due_date',
1066 1100 :rule => 'required')
1067 1101 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1068 1102 :role => role, :field_name => 'start_date',
1069 1103 :rule => 'readonly')
1070 1104 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1071 1105 :role => role, :field_name => 'done_ratio',
1072 1106 :rule => 'readonly')
1073 1107 user = User.generate!
1074 1108 User.add_to_project user, Project.find(1), [role, ignored_role]
1075 1109
1076 1110 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1077 1111
1078 1112 assert_equal %w(due_date), issue.required_attribute_names(user)
1079 1113 assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
1080 1114 end
1081 1115
1082 1116 def test_workflow_rules_should_work_for_member_with_duplicate_role
1083 1117 WorkflowPermission.delete_all
1084 1118 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1085 1119 :role_id => 1, :field_name => 'due_date',
1086 1120 :rule => 'required')
1087 1121 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
1088 1122 :role_id => 1, :field_name => 'start_date',
1089 1123 :rule => 'readonly')
1090 1124
1091 1125 user = User.generate!
1092 1126 m = Member.new(:user_id => user.id, :project_id => 1)
1093 1127 m.member_roles.build(:role_id => 1)
1094 1128 m.member_roles.build(:role_id => 1)
1095 1129 m.save!
1096 1130
1097 1131 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
1098 1132
1099 1133 assert_equal %w(due_date), issue.required_attribute_names(user)
1100 1134 assert_equal %w(start_date), issue.read_only_attribute_names(user)
1101 1135 end
1102 1136
1103 1137 def test_copy
1104 1138 issue = Issue.new.copy_from(1)
1105 1139 assert issue.copy?
1106 1140 assert issue.save
1107 1141 issue.reload
1108 1142 orig = Issue.find(1)
1109 1143 assert_equal orig.subject, issue.subject
1110 1144 assert_equal orig.tracker, issue.tracker
1111 1145 assert_equal "125", issue.custom_value_for(2).value
1112 1146 end
1113 1147
1114 1148 def test_copy_should_copy_status
1115 1149 orig = Issue.find(8)
1116 1150 assert orig.status != orig.default_status
1117 1151
1118 1152 issue = Issue.new.copy_from(orig)
1119 1153 assert issue.save
1120 1154 issue.reload
1121 1155 assert_equal orig.status, issue.status
1122 1156 end
1123 1157
1124 1158 def test_copy_should_add_relation_with_copied_issue
1125 1159 copied = Issue.find(1)
1126 1160 issue = Issue.new.copy_from(copied)
1127 1161 assert issue.save
1128 1162 issue.reload
1129 1163
1130 1164 assert_equal 1, issue.relations.size
1131 1165 relation = issue.relations.first
1132 1166 assert_equal 'copied_to', relation.relation_type
1133 1167 assert_equal copied, relation.issue_from
1134 1168 assert_equal issue, relation.issue_to
1135 1169 end
1136 1170
1137 1171 def test_copy_should_copy_subtasks
1138 1172 issue = Issue.generate_with_descendants!
1139 1173
1140 1174 copy = issue.reload.copy
1141 1175 copy.author = User.find(7)
1142 1176 assert_difference 'Issue.count', 1+issue.descendants.count do
1143 1177 assert copy.save
1144 1178 end
1145 1179 copy.reload
1146 1180 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
1147 1181 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
1148 1182 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
1149 1183 assert_equal copy.author, child_copy.author
1150 1184 end
1151 1185
1152 1186 def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
1153 1187 parent = Issue.generate!
1154 1188 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
1155 1189 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
1156 1190
1157 1191 copy = parent.reload.copy
1158 1192 copy.parent_issue_id = parent.id
1159 1193 copy.author = User.find(7)
1160 1194 assert_difference 'Issue.count', 3 do
1161 1195 assert copy.save
1162 1196 end
1163 1197 parent.reload
1164 1198 copy.reload
1165 1199 assert_equal parent, copy.parent
1166 1200 assert_equal 3, parent.children.count
1167 1201 assert_equal 5, parent.descendants.count
1168 1202 assert_equal 2, copy.children.count
1169 1203 assert_equal 2, copy.descendants.count
1170 1204 end
1171 1205
1172 1206 def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
1173 1207 parent = Issue.generate!
1174 1208 child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
1175 1209 child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
1176 1210
1177 1211 copy = parent.reload.copy
1178 1212 copy.parent_issue_id = child1.id
1179 1213 copy.author = User.find(7)
1180 1214 assert_difference 'Issue.count', 3 do
1181 1215 assert copy.save
1182 1216 end
1183 1217 parent.reload
1184 1218 child1.reload
1185 1219 copy.reload
1186 1220 assert_equal child1, copy.parent
1187 1221 assert_equal 2, parent.children.count
1188 1222 assert_equal 5, parent.descendants.count
1189 1223 assert_equal 1, child1.children.count
1190 1224 assert_equal 3, child1.descendants.count
1191 1225 assert_equal 2, copy.children.count
1192 1226 assert_equal 2, copy.descendants.count
1193 1227 end
1194 1228
1195 1229 def test_copy_should_copy_subtasks_to_target_project
1196 1230 issue = Issue.generate_with_descendants!
1197 1231
1198 1232 copy = issue.copy(:project_id => 3)
1199 1233 assert_difference 'Issue.count', 1+issue.descendants.count do
1200 1234 assert copy.save
1201 1235 end
1202 1236 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
1203 1237 end
1204 1238
1205 1239 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
1206 1240 issue = Issue.generate_with_descendants!
1207 1241
1208 1242 copy = issue.reload.copy
1209 1243 assert_difference 'Issue.count', 1+issue.descendants.count do
1210 1244 assert copy.save
1211 1245 assert copy.save
1212 1246 end
1213 1247 end
1214 1248
1215 1249 def test_should_not_call_after_project_change_on_creation
1216 1250 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
1217 1251 :subject => 'Test', :author_id => 1)
1218 1252 issue.expects(:after_project_change).never
1219 1253 issue.save!
1220 1254 end
1221 1255
1222 1256 def test_should_not_call_after_project_change_on_update
1223 1257 issue = Issue.find(1)
1224 1258 issue.project = Project.find(1)
1225 1259 issue.subject = 'No project change'
1226 1260 issue.expects(:after_project_change).never
1227 1261 issue.save!
1228 1262 end
1229 1263
1230 1264 def test_should_call_after_project_change_on_project_change
1231 1265 issue = Issue.find(1)
1232 1266 issue.project = Project.find(2)
1233 1267 issue.expects(:after_project_change).once
1234 1268 issue.save!
1235 1269 end
1236 1270
1237 1271 def test_adding_journal_should_update_timestamp
1238 1272 issue = Issue.find(1)
1239 1273 updated_on_was = issue.updated_on
1240 1274
1241 1275 issue.init_journal(User.first, "Adding notes")
1242 1276 assert_difference 'Journal.count' do
1243 1277 assert issue.save
1244 1278 end
1245 1279 issue.reload
1246 1280
1247 1281 assert_not_equal updated_on_was, issue.updated_on
1248 1282 end
1249 1283
1250 1284 def test_should_close_duplicates
1251 1285 # Create 3 issues
1252 1286 issue1 = Issue.generate!
1253 1287 issue2 = Issue.generate!
1254 1288 issue3 = Issue.generate!
1255 1289
1256 1290 # 2 is a dupe of 1
1257 1291 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
1258 1292 :relation_type => IssueRelation::TYPE_DUPLICATES)
1259 1293 # And 3 is a dupe of 2
1260 1294 # IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1261 1295 # :relation_type => IssueRelation::TYPE_DUPLICATES)
1262 1296 # And 3 is a dupe of 1 (circular duplicates)
1263 1297 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
1264 1298 :relation_type => IssueRelation::TYPE_DUPLICATES)
1265 1299
1266 1300 assert issue1.reload.duplicates.include?(issue2)
1267 1301
1268 1302 # Closing issue 1
1269 1303 issue1.init_journal(User.first, "Closing issue1")
1270 1304 issue1.status = IssueStatus.where(:is_closed => true).first
1271 1305 assert issue1.save
1272 1306 # 2 and 3 should be also closed
1273 1307 assert issue2.reload.closed?
1274 1308 assert issue3.reload.closed?
1275 1309 end
1276 1310
1277 1311 def test_should_close_duplicates_with_private_notes
1278 1312 issue = Issue.generate!
1279 1313 duplicate = Issue.generate!
1280 1314 IssueRelation.create!(:issue_from => duplicate, :issue_to => issue,
1281 1315 :relation_type => IssueRelation::TYPE_DUPLICATES)
1282 1316 assert issue.reload.duplicates.include?(duplicate)
1283 1317
1284 1318 # Closing issue with private notes
1285 1319 issue.init_journal(User.first, "Private notes")
1286 1320 issue.private_notes = true
1287 1321 issue.status = IssueStatus.where(:is_closed => true).first
1288 1322 assert_save issue
1289 1323
1290 1324 duplicate.reload
1291 1325 assert journal = duplicate.journals.detect {|journal| journal.notes == "Private notes"}
1292 1326 assert_equal true, journal.private_notes
1293 1327 end
1294 1328
1295 1329 def test_should_not_close_duplicated_issue
1296 1330 issue1 = Issue.generate!
1297 1331 issue2 = Issue.generate!
1298 1332
1299 1333 # 2 is a dupe of 1
1300 1334 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
1301 1335 :relation_type => IssueRelation::TYPE_DUPLICATES)
1302 1336 # 2 is a dup of 1 but 1 is not a duplicate of 2
1303 1337 assert !issue2.reload.duplicates.include?(issue1)
1304 1338
1305 1339 # Closing issue 2
1306 1340 issue2.init_journal(User.first, "Closing issue2")
1307 1341 issue2.status = IssueStatus.where(:is_closed => true).first
1308 1342 assert issue2.save
1309 1343 # 1 should not be also closed
1310 1344 assert !issue1.reload.closed?
1311 1345 end
1312 1346
1313 1347 def test_assignable_versions
1314 1348 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1315 1349 :status_id => 1, :fixed_version_id => 1,
1316 1350 :subject => 'New issue')
1317 1351 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
1318 1352 end
1319 1353
1320 1354 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
1321 1355 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1322 1356 :status_id => 1, :fixed_version_id => 1,
1323 1357 :subject => 'New issue')
1324 1358 assert !issue.save
1325 1359 assert_not_equal [], issue.errors[:fixed_version_id]
1326 1360 end
1327 1361
1328 1362 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
1329 1363 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1330 1364 :status_id => 1, :fixed_version_id => 2,
1331 1365 :subject => 'New issue')
1332 1366 assert !issue.save
1333 1367 assert_not_equal [], issue.errors[:fixed_version_id]
1334 1368 end
1335 1369
1336 1370 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
1337 1371 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
1338 1372 :status_id => 1, :fixed_version_id => 3,
1339 1373 :subject => 'New issue')
1340 1374 assert issue.save
1341 1375 end
1342 1376
1343 1377 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
1344 1378 issue = Issue.find(11)
1345 1379 assert_equal 'closed', issue.fixed_version.status
1346 1380 issue.subject = 'Subject changed'
1347 1381 assert issue.save
1348 1382 end
1349 1383
1350 1384 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
1351 1385 issue = Issue.find(11)
1352 1386 issue.status_id = 1
1353 1387 assert !issue.save
1354 1388 assert_not_equal [], issue.errors[:base]
1355 1389 end
1356 1390
1357 1391 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
1358 1392 issue = Issue.find(11)
1359 1393 issue.status_id = 1
1360 1394 issue.fixed_version_id = 3
1361 1395 assert issue.save
1362 1396 end
1363 1397
1364 1398 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
1365 1399 issue = Issue.find(12)
1366 1400 assert_equal 'locked', issue.fixed_version.status
1367 1401 issue.status_id = 1
1368 1402 assert issue.save
1369 1403 end
1370 1404
1371 1405 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
1372 1406 issue = Issue.find(2)
1373 1407 assert_equal 2, issue.fixed_version_id
1374 1408 issue.project_id = 3
1375 1409 assert_nil issue.fixed_version_id
1376 1410 issue.fixed_version_id = 2
1377 1411 assert !issue.save
1378 1412 assert_include 'Target version is not included in the list', issue.errors.full_messages
1379 1413 end
1380 1414
1381 1415 def test_should_keep_shared_version_when_changing_project
1382 1416 Version.find(2).update_attribute :sharing, 'tree'
1383 1417
1384 1418 issue = Issue.find(2)
1385 1419 assert_equal 2, issue.fixed_version_id
1386 1420 issue.project_id = 3
1387 1421 assert_equal 2, issue.fixed_version_id
1388 1422 assert issue.save
1389 1423 end
1390 1424
1391 1425 def test_allowed_target_projects_should_include_projects_with_issue_tracking_enabled
1392 1426 assert_include Project.find(2), Issue.allowed_target_projects(User.find(2))
1393 1427 end
1394 1428
1395 1429 def test_allowed_target_projects_should_not_include_projects_with_issue_tracking_disabled
1396 1430 Project.find(2).disable_module! :issue_tracking
1397 1431 assert_not_include Project.find(2), Issue.allowed_target_projects(User.find(2))
1398 1432 end
1399 1433
1400 1434 def test_allowed_target_projects_should_not_include_projects_without_trackers
1401 1435 project = Project.generate!(:tracker_ids => [])
1402 1436 assert project.trackers.empty?
1403 1437 assert_not_include project, Issue.allowed_target_projects(User.find(1))
1404 1438 end
1405 1439
1406 1440 def test_move_to_another_project_with_same_category
1407 1441 issue = Issue.find(1)
1408 1442 issue.project = Project.find(2)
1409 1443 assert issue.save
1410 1444 issue.reload
1411 1445 assert_equal 2, issue.project_id
1412 1446 # Category changes
1413 1447 assert_equal 4, issue.category_id
1414 1448 # Make sure time entries were move to the target project
1415 1449 assert_equal 2, issue.time_entries.first.project_id
1416 1450 end
1417 1451
1418 1452 def test_move_to_another_project_without_same_category
1419 1453 issue = Issue.find(2)
1420 1454 issue.project = Project.find(2)
1421 1455 assert issue.save
1422 1456 issue.reload
1423 1457 assert_equal 2, issue.project_id
1424 1458 # Category cleared
1425 1459 assert_nil issue.category_id
1426 1460 end
1427 1461
1428 1462 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
1429 1463 issue = Issue.find(1)
1430 1464 issue.update_attribute(:fixed_version_id, 1)
1431 1465 issue.project = Project.find(2)
1432 1466 assert issue.save
1433 1467 issue.reload
1434 1468 assert_equal 2, issue.project_id
1435 1469 # Cleared fixed_version
1436 1470 assert_equal nil, issue.fixed_version
1437 1471 end
1438 1472
1439 1473 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
1440 1474 issue = Issue.find(1)
1441 1475 issue.update_attribute(:fixed_version_id, 4)
1442 1476 issue.project = Project.find(5)
1443 1477 assert issue.save
1444 1478 issue.reload
1445 1479 assert_equal 5, issue.project_id
1446 1480 # Keep fixed_version
1447 1481 assert_equal 4, issue.fixed_version_id
1448 1482 end
1449 1483
1450 1484 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1451 1485 issue = Issue.find(1)
1452 1486 issue.update_attribute(:fixed_version_id, 1)
1453 1487 issue.project = Project.find(5)
1454 1488 assert issue.save
1455 1489 issue.reload
1456 1490 assert_equal 5, issue.project_id
1457 1491 # Cleared fixed_version
1458 1492 assert_equal nil, issue.fixed_version
1459 1493 end
1460 1494
1461 1495 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1462 1496 issue = Issue.find(1)
1463 1497 issue.update_attribute(:fixed_version_id, 7)
1464 1498 issue.project = Project.find(2)
1465 1499 assert issue.save
1466 1500 issue.reload
1467 1501 assert_equal 2, issue.project_id
1468 1502 # Keep fixed_version
1469 1503 assert_equal 7, issue.fixed_version_id
1470 1504 end
1471 1505
1472 1506 def test_move_to_another_project_should_keep_parent_if_valid
1473 1507 issue = Issue.find(1)
1474 1508 issue.update_attribute(:parent_issue_id, 2)
1475 1509 issue.project = Project.find(3)
1476 1510 assert issue.save
1477 1511 issue.reload
1478 1512 assert_equal 2, issue.parent_id
1479 1513 end
1480 1514
1481 1515 def test_move_to_another_project_should_clear_parent_if_not_valid
1482 1516 issue = Issue.find(1)
1483 1517 issue.update_attribute(:parent_issue_id, 2)
1484 1518 issue.project = Project.find(2)
1485 1519 assert issue.save
1486 1520 issue.reload
1487 1521 assert_nil issue.parent_id
1488 1522 end
1489 1523
1490 1524 def test_move_to_another_project_with_disabled_tracker
1491 1525 issue = Issue.find(1)
1492 1526 target = Project.find(2)
1493 1527 target.tracker_ids = [3]
1494 1528 target.save
1495 1529 issue.project = target
1496 1530 assert issue.save
1497 1531 issue.reload
1498 1532 assert_equal 2, issue.project_id
1499 1533 assert_equal 3, issue.tracker_id
1500 1534 end
1501 1535
1502 1536 def test_copy_to_the_same_project
1503 1537 issue = Issue.find(1)
1504 1538 copy = issue.copy
1505 1539 assert_difference 'Issue.count' do
1506 1540 copy.save!
1507 1541 end
1508 1542 assert_kind_of Issue, copy
1509 1543 assert_equal issue.project, copy.project
1510 1544 assert_equal "125", copy.custom_value_for(2).value
1511 1545 end
1512 1546
1513 1547 def test_copy_to_another_project_and_tracker
1514 1548 issue = Issue.find(1)
1515 1549 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1516 1550 assert_difference 'Issue.count' do
1517 1551 copy.save!
1518 1552 end
1519 1553 copy.reload
1520 1554 assert_kind_of Issue, copy
1521 1555 assert_equal Project.find(3), copy.project
1522 1556 assert_equal Tracker.find(2), copy.tracker
1523 1557 # Custom field #2 is not associated with target tracker
1524 1558 assert_nil copy.custom_value_for(2)
1525 1559 end
1526 1560
1527 1561 test "#copy should not create a journal" do
1528 1562 copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :assigned_to_id => 3}, :link => false)
1529 1563 copy.save!
1530 1564 assert_equal 0, copy.reload.journals.size
1531 1565 end
1532 1566
1533 1567 test "#copy should allow assigned_to changes" do
1534 1568 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1535 1569 assert_equal 3, copy.assigned_to_id
1536 1570 end
1537 1571
1538 1572 test "#copy should allow status changes" do
1539 1573 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1540 1574 assert_equal 2, copy.status_id
1541 1575 end
1542 1576
1543 1577 test "#copy should allow start date changes" do
1544 1578 date = Date.today
1545 1579 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1546 1580 assert_equal date, copy.start_date
1547 1581 end
1548 1582
1549 1583 test "#copy should allow due date changes" do
1550 1584 date = Date.today
1551 1585 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1552 1586 assert_equal date, copy.due_date
1553 1587 end
1554 1588
1555 1589 test "#copy should set current user as author" do
1556 1590 User.current = User.find(9)
1557 1591 copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
1558 1592 assert_equal User.current, copy.author
1559 1593 end
1560 1594
1561 1595 test "#copy should create a journal with notes" do
1562 1596 date = Date.today
1563 1597 notes = "Notes added when copying"
1564 1598 copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :start_date => date}, :link => false)
1565 1599 copy.init_journal(User.current, notes)
1566 1600 copy.save!
1567 1601
1568 1602 assert_equal 1, copy.journals.size
1569 1603 journal = copy.journals.first
1570 1604 assert_equal 0, journal.details.size
1571 1605 assert_equal notes, journal.notes
1572 1606 end
1573 1607
1574 1608 def test_valid_parent_project
1575 1609 issue = Issue.find(1)
1576 1610 issue_in_same_project = Issue.find(2)
1577 1611 issue_in_child_project = Issue.find(5)
1578 1612 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1579 1613 issue_in_other_child_project = Issue.find(6)
1580 1614 issue_in_different_tree = Issue.find(4)
1581 1615
1582 1616 with_settings :cross_project_subtasks => '' do
1583 1617 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1584 1618 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1585 1619 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1586 1620 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1587 1621 end
1588 1622
1589 1623 with_settings :cross_project_subtasks => 'system' do
1590 1624 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1591 1625 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1592 1626 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1593 1627 end
1594 1628
1595 1629 with_settings :cross_project_subtasks => 'tree' do
1596 1630 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1597 1631 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1598 1632 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1599 1633 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1600 1634
1601 1635 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1602 1636 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1603 1637 end
1604 1638
1605 1639 with_settings :cross_project_subtasks => 'descendants' do
1606 1640 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1607 1641 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1608 1642 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1609 1643 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1610 1644
1611 1645 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1612 1646 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1613 1647 end
1614 1648 end
1615 1649
1616 1650 def test_recipients_should_include_previous_assignee
1617 1651 user = User.find(3)
1618 1652 user.members.update_all ["mail_notification = ?", false]
1619 1653 user.update_attribute :mail_notification, 'only_assigned'
1620 1654
1621 1655 issue = Issue.find(2)
1622 1656 issue.assigned_to = nil
1623 1657 assert_include user.mail, issue.recipients
1624 1658 issue.save!
1625 1659 assert !issue.recipients.include?(user.mail)
1626 1660 end
1627 1661
1628 1662 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1629 1663 issue = Issue.find(12)
1630 1664 assert issue.recipients.include?(issue.author.mail)
1631 1665 # copy the issue to a private project
1632 1666 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1633 1667 # author is not a member of project anymore
1634 1668 assert !copy.recipients.include?(copy.author.mail)
1635 1669 end
1636 1670
1637 1671 def test_recipients_should_include_the_assigned_group_members
1638 1672 group_member = User.generate!
1639 1673 group = Group.generate!
1640 1674 group.users << group_member
1641 1675
1642 1676 issue = Issue.find(12)
1643 1677 issue.assigned_to = group
1644 1678 assert issue.recipients.include?(group_member.mail)
1645 1679 end
1646 1680
1647 1681 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1648 1682 user = User.find(3)
1649 1683 issue = Issue.find(9)
1650 1684 Watcher.create!(:user => user, :watchable => issue)
1651 1685 assert issue.watched_by?(user)
1652 1686 assert !issue.watcher_recipients.include?(user.mail)
1653 1687 end
1654 1688
1655 1689 def test_issue_destroy
1656 1690 Issue.find(1).destroy
1657 1691 assert_nil Issue.find_by_id(1)
1658 1692 assert_nil TimeEntry.find_by_issue_id(1)
1659 1693 end
1660 1694
1661 1695 def test_destroy_should_delete_time_entries_custom_values
1662 1696 issue = Issue.generate!
1663 1697 time_entry = TimeEntry.generate!(:issue => issue, :custom_field_values => {10 => '1'})
1664 1698
1665 1699 assert_difference 'CustomValue.where(:customized_type => "TimeEntry").count', -1 do
1666 1700 assert issue.destroy
1667 1701 end
1668 1702 end
1669 1703
1670 1704 def test_destroying_a_deleted_issue_should_not_raise_an_error
1671 1705 issue = Issue.find(1)
1672 1706 Issue.find(1).destroy
1673 1707
1674 1708 assert_nothing_raised do
1675 1709 assert_no_difference 'Issue.count' do
1676 1710 issue.destroy
1677 1711 end
1678 1712 assert issue.destroyed?
1679 1713 end
1680 1714 end
1681 1715
1682 1716 def test_destroying_a_stale_issue_should_not_raise_an_error
1683 1717 issue = Issue.find(1)
1684 1718 Issue.find(1).update_attribute :subject, "Updated"
1685 1719
1686 1720 assert_nothing_raised do
1687 1721 assert_difference 'Issue.count', -1 do
1688 1722 issue.destroy
1689 1723 end
1690 1724 assert issue.destroyed?
1691 1725 end
1692 1726 end
1693 1727
1694 1728 def test_blocked
1695 1729 blocked_issue = Issue.find(9)
1696 1730 blocking_issue = Issue.find(10)
1697 1731
1698 1732 assert blocked_issue.blocked?
1699 1733 assert !blocking_issue.blocked?
1700 1734 end
1701 1735
1702 1736 def test_blocked_issues_dont_allow_closed_statuses
1703 1737 blocked_issue = Issue.find(9)
1704 1738
1705 1739 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1706 1740 assert !allowed_statuses.empty?
1707 1741 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1708 1742 assert closed_statuses.empty?
1709 1743 end
1710 1744
1711 1745 def test_unblocked_issues_allow_closed_statuses
1712 1746 blocking_issue = Issue.find(10)
1713 1747
1714 1748 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1715 1749 assert !allowed_statuses.empty?
1716 1750 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1717 1751 assert !closed_statuses.empty?
1718 1752 end
1719 1753
1720 1754 def test_reschedule_an_issue_without_dates
1721 1755 with_settings :non_working_week_days => [] do
1722 1756 issue = Issue.new(:start_date => nil, :due_date => nil)
1723 1757 issue.reschedule_on '2012-10-09'.to_date
1724 1758 assert_equal '2012-10-09'.to_date, issue.start_date
1725 1759 assert_equal '2012-10-09'.to_date, issue.due_date
1726 1760 end
1727 1761
1728 1762 with_settings :non_working_week_days => %w(6 7) do
1729 1763 issue = Issue.new(:start_date => nil, :due_date => nil)
1730 1764 issue.reschedule_on '2012-10-09'.to_date
1731 1765 assert_equal '2012-10-09'.to_date, issue.start_date
1732 1766 assert_equal '2012-10-09'.to_date, issue.due_date
1733 1767
1734 1768 issue = Issue.new(:start_date => nil, :due_date => nil)
1735 1769 issue.reschedule_on '2012-10-13'.to_date
1736 1770 assert_equal '2012-10-15'.to_date, issue.start_date
1737 1771 assert_equal '2012-10-15'.to_date, issue.due_date
1738 1772 end
1739 1773 end
1740 1774
1741 1775 def test_reschedule_an_issue_with_start_date
1742 1776 with_settings :non_working_week_days => [] do
1743 1777 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1744 1778 issue.reschedule_on '2012-10-13'.to_date
1745 1779 assert_equal '2012-10-13'.to_date, issue.start_date
1746 1780 assert_equal '2012-10-13'.to_date, issue.due_date
1747 1781 end
1748 1782
1749 1783 with_settings :non_working_week_days => %w(6 7) do
1750 1784 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1751 1785 issue.reschedule_on '2012-10-11'.to_date
1752 1786 assert_equal '2012-10-11'.to_date, issue.start_date
1753 1787 assert_equal '2012-10-11'.to_date, issue.due_date
1754 1788
1755 1789 issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
1756 1790 issue.reschedule_on '2012-10-13'.to_date
1757 1791 assert_equal '2012-10-15'.to_date, issue.start_date
1758 1792 assert_equal '2012-10-15'.to_date, issue.due_date
1759 1793 end
1760 1794 end
1761 1795
1762 1796 def test_reschedule_an_issue_with_start_and_due_dates
1763 1797 with_settings :non_working_week_days => [] do
1764 1798 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
1765 1799 issue.reschedule_on '2012-10-13'.to_date
1766 1800 assert_equal '2012-10-13'.to_date, issue.start_date
1767 1801 assert_equal '2012-10-19'.to_date, issue.due_date
1768 1802 end
1769 1803
1770 1804 with_settings :non_working_week_days => %w(6 7) do
1771 1805 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
1772 1806 issue.reschedule_on '2012-10-11'.to_date
1773 1807 assert_equal '2012-10-11'.to_date, issue.start_date
1774 1808 assert_equal '2012-10-23'.to_date, issue.due_date
1775 1809
1776 1810 issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
1777 1811 issue.reschedule_on '2012-10-13'.to_date
1778 1812 assert_equal '2012-10-15'.to_date, issue.start_date
1779 1813 assert_equal '2012-10-25'.to_date, issue.due_date
1780 1814 end
1781 1815 end
1782 1816
1783 1817 def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
1784 1818 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1785 1819 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1786 1820 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1787 1821 :relation_type => IssueRelation::TYPE_PRECEDES)
1788 1822 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1789 1823
1790 1824 issue1.reload
1791 1825 issue1.due_date = '2012-10-23'
1792 1826 issue1.save!
1793 1827 issue2.reload
1794 1828 assert_equal Date.parse('2012-10-24'), issue2.start_date
1795 1829 assert_equal Date.parse('2012-10-26'), issue2.due_date
1796 1830 end
1797 1831
1798 1832 def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
1799 1833 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1800 1834 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1801 1835 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1802 1836 :relation_type => IssueRelation::TYPE_PRECEDES)
1803 1837 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1804 1838
1805 1839 issue1.reload
1806 1840 issue1.start_date = '2012-09-17'
1807 1841 issue1.due_date = '2012-09-18'
1808 1842 issue1.save!
1809 1843 issue2.reload
1810 1844 assert_equal Date.parse('2012-09-19'), issue2.start_date
1811 1845 assert_equal Date.parse('2012-09-21'), issue2.due_date
1812 1846 end
1813 1847
1814 1848 def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
1815 1849 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1816 1850 issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1817 1851 issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
1818 1852 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1819 1853 :relation_type => IssueRelation::TYPE_PRECEDES)
1820 1854 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
1821 1855 :relation_type => IssueRelation::TYPE_PRECEDES)
1822 1856 assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
1823 1857
1824 1858 issue1.reload
1825 1859 issue1.start_date = '2012-09-17'
1826 1860 issue1.due_date = '2012-09-18'
1827 1861 issue1.save!
1828 1862 issue2.reload
1829 1863 # Issue 2 must start after Issue 3
1830 1864 assert_equal Date.parse('2012-10-03'), issue2.start_date
1831 1865 assert_equal Date.parse('2012-10-05'), issue2.due_date
1832 1866 end
1833 1867
1834 1868 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1835 1869 with_settings :non_working_week_days => [] do
1836 1870 stale = Issue.find(1)
1837 1871 issue = Issue.find(1)
1838 1872 issue.subject = "Updated"
1839 1873 issue.save!
1840 1874 date = 10.days.from_now.to_date
1841 1875 assert_nothing_raised do
1842 1876 stale.reschedule_on!(date)
1843 1877 end
1844 1878 assert_equal date, stale.reload.start_date
1845 1879 end
1846 1880 end
1847 1881
1848 1882 def test_child_issue_should_consider_parent_soonest_start_on_create
1849 1883 set_language_if_valid 'en'
1850 1884 issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
1851 1885 issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
1852 1886 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1853 1887 :relation_type => IssueRelation::TYPE_PRECEDES)
1854 1888 issue1.reload
1855 1889 issue2.reload
1856 1890 assert_equal Date.parse('2012-10-18'), issue2.start_date
1857 1891
1858 1892 with_settings :date_format => '%m/%d/%Y' do
1859 1893 child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
1860 1894 :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
1861 1895 assert !child.valid?
1862 1896 assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
1863 1897 assert_equal Date.parse('2012-10-18'), child.soonest_start
1864 1898 child.start_date = '2012-10-18'
1865 1899 assert child.save
1866 1900 end
1867 1901 end
1868 1902
1869 1903 def test_setting_parent_to_a_an_issue_that_precedes_should_not_validate
1870 1904 # tests that 3 cannot have 1 as parent:
1871 1905 #
1872 1906 # 1 -> 2 -> 3
1873 1907 #
1874 1908 set_language_if_valid 'en'
1875 1909 issue1 = Issue.generate!
1876 1910 issue2 = Issue.generate!
1877 1911 issue3 = Issue.generate!
1878 1912 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1879 1913 IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
1880 1914 issue3.reload
1881 1915 issue3.parent_issue_id = issue1.id
1882 1916 assert !issue3.valid?
1883 1917 assert_include 'Parent task is invalid', issue3.errors.full_messages
1884 1918 end
1885 1919
1886 1920 def test_setting_parent_to_a_an_issue_that_follows_should_not_validate
1887 1921 # tests that 1 cannot have 3 as parent:
1888 1922 #
1889 1923 # 1 -> 2 -> 3
1890 1924 #
1891 1925 set_language_if_valid 'en'
1892 1926 issue1 = Issue.generate!
1893 1927 issue2 = Issue.generate!
1894 1928 issue3 = Issue.generate!
1895 1929 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1896 1930 IssueRelation.create!(:issue_from => issue2, :issue_to => issue3, :relation_type => IssueRelation::TYPE_PRECEDES)
1897 1931 issue1.reload
1898 1932 issue1.parent_issue_id = issue3.id
1899 1933 assert !issue1.valid?
1900 1934 assert_include 'Parent task is invalid', issue1.errors.full_messages
1901 1935 end
1902 1936
1903 1937 def test_setting_parent_to_a_an_issue_that_precedes_through_hierarchy_should_not_validate
1904 1938 # tests that 4 cannot have 1 as parent:
1905 1939 # changing the due date of 4 would update the end date of 1 which would reschedule 2
1906 1940 # which would change the end date of 3 which would reschedule 4 and so on...
1907 1941 #
1908 1942 # 3 -> 4
1909 1943 # ^
1910 1944 # 1 -> 2
1911 1945 #
1912 1946 set_language_if_valid 'en'
1913 1947 issue1 = Issue.generate!
1914 1948 issue2 = Issue.generate!
1915 1949 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
1916 1950 issue3 = Issue.generate!
1917 1951 issue2.reload
1918 1952 issue2.parent_issue_id = issue3.id
1919 1953 issue2.save!
1920 1954 issue4 = Issue.generate!
1921 1955 IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
1922 1956 issue4.reload
1923 1957 issue4.parent_issue_id = issue1.id
1924 1958 assert !issue4.valid?
1925 1959 assert_include 'Parent task is invalid', issue4.errors.full_messages
1926 1960 end
1927 1961
1928 1962 def test_issue_and_following_issue_should_be_able_to_be_moved_to_the_same_parent
1929 1963 set_language_if_valid 'en'
1930 1964 issue1 = Issue.generate!
1931 1965 issue2 = Issue.generate!
1932 1966 relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_FOLLOWS)
1933 1967 parent = Issue.generate!
1934 1968 issue1.reload.parent_issue_id = parent.id
1935 1969 assert_save issue1
1936 1970 parent.reload
1937 1971 issue2.reload.parent_issue_id = parent.id
1938 1972 assert_save issue2
1939 1973 assert IssueRelation.exists?(relation.id)
1940 1974 end
1941 1975
1942 1976 def test_issue_and_preceding_issue_should_be_able_to_be_moved_to_the_same_parent
1943 1977 set_language_if_valid 'en'
1944 1978 issue1 = Issue.generate!
1945 1979 issue2 = Issue.generate!
1946 1980 relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
1947 1981 parent = Issue.generate!
1948 1982 issue1.reload.parent_issue_id = parent.id
1949 1983 assert_save issue1
1950 1984 parent.reload
1951 1985 issue2.reload.parent_issue_id = parent.id
1952 1986 assert_save issue2
1953 1987 assert IssueRelation.exists?(relation.id)
1954 1988 end
1955 1989
1956 1990 def test_issue_and_blocked_issue_should_be_able_to_be_moved_to_the_same_parent
1957 1991 set_language_if_valid 'en'
1958 1992 issue1 = Issue.generate!
1959 1993 issue2 = Issue.generate!
1960 1994 relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKED)
1961 1995 parent = Issue.generate!
1962 1996 issue1.reload.parent_issue_id = parent.id
1963 1997 assert_save issue1
1964 1998 parent.reload
1965 1999 issue2.reload.parent_issue_id = parent.id
1966 2000 assert_save issue2
1967 2001 assert IssueRelation.exists?(relation.id)
1968 2002 end
1969 2003
1970 2004 def test_issue_and_blocking_issue_should_be_able_to_be_moved_to_the_same_parent
1971 2005 set_language_if_valid 'en'
1972 2006 issue1 = Issue.generate!
1973 2007 issue2 = Issue.generate!
1974 2008 relation = IssueRelation.create!(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_BLOCKS)
1975 2009 parent = Issue.generate!
1976 2010 issue1.reload.parent_issue_id = parent.id
1977 2011 assert_save issue1
1978 2012 parent.reload
1979 2013 issue2.reload.parent_issue_id = parent.id
1980 2014 assert_save issue2
1981 2015 assert IssueRelation.exists?(relation.id)
1982 2016 end
1983 2017
1984 2018 def test_issue_copy_should_be_able_to_be_moved_to_the_same_parent_as_copied_issue
1985 2019 issue = Issue.generate!
1986 2020 parent = Issue.generate!
1987 2021 issue.parent_issue_id = parent.id
1988 2022 issue.save!
1989 2023 issue.reload
1990 2024
1991 2025 copy = Issue.new.copy_from(issue, :link => true)
1992 2026 relation = new_record(IssueRelation) do
1993 2027 copy.save!
1994 2028 end
1995 2029
1996 2030 copy.parent_issue_id = parent.id
1997 2031 assert_save copy
1998 2032 assert IssueRelation.exists?(relation.id)
1999 2033 end
2000 2034
2001 2035 def test_overdue
2002 2036 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
2003 2037 assert !Issue.new(:due_date => Date.today).overdue?
2004 2038 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
2005 2039 assert !Issue.new(:due_date => nil).overdue?
2006 2040 assert !Issue.new(:due_date => 1.day.ago.to_date,
2007 2041 :status => IssueStatus.where(:is_closed => true).first
2008 2042 ).overdue?
2009 2043 end
2010 2044
2011 2045 test "#behind_schedule? should be false if the issue has no start_date" do
2012 2046 assert !Issue.new(:start_date => nil,
2013 2047 :due_date => 1.day.from_now.to_date,
2014 2048 :done_ratio => 0).behind_schedule?
2015 2049 end
2016 2050
2017 2051 test "#behind_schedule? should be false if the issue has no end_date" do
2018 2052 assert !Issue.new(:start_date => 1.day.from_now.to_date,
2019 2053 :due_date => nil,
2020 2054 :done_ratio => 0).behind_schedule?
2021 2055 end
2022 2056
2023 2057 test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
2024 2058 assert !Issue.new(:start_date => 50.days.ago.to_date,
2025 2059 :due_date => 50.days.from_now.to_date,
2026 2060 :done_ratio => 90).behind_schedule?
2027 2061 end
2028 2062
2029 2063 test "#behind_schedule? should be true if the issue hasn't been started at all" do
2030 2064 assert Issue.new(:start_date => 1.day.ago.to_date,
2031 2065 :due_date => 1.day.from_now.to_date,
2032 2066 :done_ratio => 0).behind_schedule?
2033 2067 end
2034 2068
2035 2069 test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
2036 2070 assert Issue.new(:start_date => 100.days.ago.to_date,
2037 2071 :due_date => Date.today,
2038 2072 :done_ratio => 90).behind_schedule?
2039 2073 end
2040 2074
2041 2075 test "#assignable_users should be Users" do
2042 2076 assert_kind_of User, Issue.find(1).assignable_users.first
2043 2077 end
2044 2078
2045 2079 test "#assignable_users should include the issue author" do
2046 2080 non_project_member = User.generate!
2047 2081 issue = Issue.generate!(:author => non_project_member)
2048 2082
2049 2083 assert issue.assignable_users.include?(non_project_member)
2050 2084 end
2051 2085
2052 2086 def test_assignable_users_should_not_include_anonymous_user
2053 2087 issue = Issue.generate!(:author => User.anonymous)
2054 2088
2055 2089 assert !issue.assignable_users.include?(User.anonymous)
2056 2090 end
2057 2091
2058 2092 def test_assignable_users_should_not_include_locked_user
2059 2093 user = User.generate!
2060 2094 issue = Issue.generate!(:author => user)
2061 2095 user.lock!
2062 2096
2063 2097 assert !issue.assignable_users.include?(user)
2064 2098 end
2065 2099
2066 2100 test "#assignable_users should include the current assignee" do
2067 2101 user = User.generate!
2068 2102 issue = Issue.generate!(:assigned_to => user)
2069 2103 user.lock!
2070 2104
2071 2105 assert Issue.find(issue.id).assignable_users.include?(user)
2072 2106 end
2073 2107
2074 2108 test "#assignable_users should not show the issue author twice" do
2075 2109 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
2076 2110 assert_equal 2, assignable_user_ids.length
2077 2111
2078 2112 assignable_user_ids.each do |user_id|
2079 2113 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
2080 2114 "User #{user_id} appears more or less than once"
2081 2115 end
2082 2116 end
2083 2117
2084 2118 test "#assignable_users with issue_group_assignment should include groups" do
2085 2119 issue = Issue.new(:project => Project.find(2))
2086 2120
2087 2121 with_settings :issue_group_assignment => '1' do
2088 2122 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
2089 2123 assert issue.assignable_users.include?(Group.find(11))
2090 2124 end
2091 2125 end
2092 2126
2093 2127 test "#assignable_users without issue_group_assignment should not include groups" do
2094 2128 issue = Issue.new(:project => Project.find(2))
2095 2129
2096 2130 with_settings :issue_group_assignment => '0' do
2097 2131 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
2098 2132 assert !issue.assignable_users.include?(Group.find(11))
2099 2133 end
2100 2134 end
2101 2135
2102 2136 def test_assignable_users_should_not_include_builtin_groups
2103 2137 Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [1])
2104 2138 Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [1])
2105 2139 issue = Issue.new(:project => Project.find(1))
2106 2140
2107 2141 with_settings :issue_group_assignment => '1' do
2108 2142 assert_nil issue.assignable_users.detect {|u| u.is_a?(GroupBuiltin)}
2109 2143 end
2110 2144 end
2111 2145
2112 2146 def test_create_should_send_email_notification
2113 2147 ActionMailer::Base.deliveries.clear
2114 2148 issue = Issue.new(:project_id => 1, :tracker_id => 1,
2115 2149 :author_id => 3, :status_id => 1,
2116 2150 :priority => IssuePriority.all.first,
2117 2151 :subject => 'test_create', :estimated_hours => '1:30')
2118 2152 with_settings :notified_events => %w(issue_added) do
2119 2153 assert issue.save
2120 2154 assert_equal 1, ActionMailer::Base.deliveries.size
2121 2155 end
2122 2156 end
2123 2157
2124 2158 def test_create_should_send_one_email_notification_with_both_settings
2125 2159 ActionMailer::Base.deliveries.clear
2126 2160 issue = Issue.new(:project_id => 1, :tracker_id => 1,
2127 2161 :author_id => 3, :status_id => 1,
2128 2162 :priority => IssuePriority.all.first,
2129 2163 :subject => 'test_create', :estimated_hours => '1:30')
2130 2164 with_settings :notified_events => %w(issue_added issue_updated) do
2131 2165 assert issue.save
2132 2166 assert_equal 1, ActionMailer::Base.deliveries.size
2133 2167 end
2134 2168 end
2135 2169
2136 2170 def test_create_should_not_send_email_notification_with_no_setting
2137 2171 ActionMailer::Base.deliveries.clear
2138 2172 issue = Issue.new(:project_id => 1, :tracker_id => 1,
2139 2173 :author_id => 3, :status_id => 1,
2140 2174 :priority => IssuePriority.all.first,
2141 2175 :subject => 'test_create', :estimated_hours => '1:30')
2142 2176 with_settings :notified_events => [] do
2143 2177 assert issue.save
2144 2178 assert_equal 0, ActionMailer::Base.deliveries.size
2145 2179 end
2146 2180 end
2147 2181
2148 2182 def test_update_should_notify_previous_assignee
2149 2183 ActionMailer::Base.deliveries.clear
2150 2184 user = User.find(3)
2151 2185 user.members.update_all ["mail_notification = ?", false]
2152 2186 user.update_attribute :mail_notification, 'only_assigned'
2153 2187
2154 2188 with_settings :notified_events => %w(issue_updated) do
2155 2189 issue = Issue.find(2)
2156 2190 issue.init_journal User.find(1)
2157 2191 issue.assigned_to = nil
2158 2192 issue.save!
2159 2193 assert_include user.mail, ActionMailer::Base.deliveries.last.bcc
2160 2194 end
2161 2195 end
2162 2196
2163 2197 def test_stale_issue_should_not_send_email_notification
2164 2198 ActionMailer::Base.deliveries.clear
2165 2199 issue = Issue.find(1)
2166 2200 stale = Issue.find(1)
2167 2201
2168 2202 issue.init_journal(User.find(1))
2169 2203 issue.subject = 'Subjet update'
2170 2204 with_settings :notified_events => %w(issue_updated) do
2171 2205 assert issue.save
2172 2206 assert_equal 1, ActionMailer::Base.deliveries.size
2173 2207 ActionMailer::Base.deliveries.clear
2174 2208
2175 2209 stale.init_journal(User.find(1))
2176 2210 stale.subject = 'Another subjet update'
2177 2211 assert_raise ActiveRecord::StaleObjectError do
2178 2212 stale.save
2179 2213 end
2180 2214 assert ActionMailer::Base.deliveries.empty?
2181 2215 end
2182 2216 end
2183 2217
2184 2218 def test_journalized_description
2185 2219 IssueCustomField.delete_all
2186 2220
2187 2221 i = Issue.first
2188 2222 old_description = i.description
2189 2223 new_description = "This is the new description"
2190 2224
2191 2225 i.init_journal(User.find(2))
2192 2226 i.description = new_description
2193 2227 assert_difference 'Journal.count', 1 do
2194 2228 assert_difference 'JournalDetail.count', 1 do
2195 2229 i.save!
2196 2230 end
2197 2231 end
2198 2232
2199 2233 detail = JournalDetail.order('id DESC').first
2200 2234 assert_equal i, detail.journal.journalized
2201 2235 assert_equal 'attr', detail.property
2202 2236 assert_equal 'description', detail.prop_key
2203 2237 assert_equal old_description, detail.old_value
2204 2238 assert_equal new_description, detail.value
2205 2239 end
2206 2240
2207 2241 def test_blank_descriptions_should_not_be_journalized
2208 2242 IssueCustomField.delete_all
2209 2243 Issue.where(:id => 1).update_all("description = NULL")
2210 2244
2211 2245 i = Issue.find(1)
2212 2246 i.init_journal(User.find(2))
2213 2247 i.subject = "blank description"
2214 2248 i.description = "\r\n"
2215 2249
2216 2250 assert_difference 'Journal.count', 1 do
2217 2251 assert_difference 'JournalDetail.count', 1 do
2218 2252 i.save!
2219 2253 end
2220 2254 end
2221 2255 end
2222 2256
2223 2257 def test_journalized_multi_custom_field
2224 2258 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
2225 2259 :is_filter => true, :is_for_all => true,
2226 2260 :tracker_ids => [1],
2227 2261 :possible_values => ['value1', 'value2', 'value3'],
2228 2262 :multiple => true)
2229 2263
2230 2264 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
2231 2265 :subject => 'Test', :author_id => 1)
2232 2266
2233 2267 assert_difference 'Journal.count' do
2234 2268 assert_difference 'JournalDetail.count' do
2235 2269 issue.init_journal(User.first)
2236 2270 issue.custom_field_values = {field.id => ['value1']}
2237 2271 issue.save!
2238 2272 end
2239 2273 assert_difference 'JournalDetail.count' do
2240 2274 issue.init_journal(User.first)
2241 2275 issue.custom_field_values = {field.id => ['value1', 'value2']}
2242 2276 issue.save!
2243 2277 end
2244 2278 assert_difference 'JournalDetail.count', 2 do
2245 2279 issue.init_journal(User.first)
2246 2280 issue.custom_field_values = {field.id => ['value3', 'value2']}
2247 2281 issue.save!
2248 2282 end
2249 2283 assert_difference 'JournalDetail.count', 2 do
2250 2284 issue.init_journal(User.first)
2251 2285 issue.custom_field_values = {field.id => nil}
2252 2286 issue.save!
2253 2287 end
2254 2288 end
2255 2289 end
2256 2290
2257 2291 def test_description_eol_should_be_normalized
2258 2292 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
2259 2293 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
2260 2294 end
2261 2295
2262 2296 def test_saving_twice_should_not_duplicate_journal_details
2263 2297 i = Issue.first
2264 2298 i.init_journal(User.find(2), 'Some notes')
2265 2299 # initial changes
2266 2300 i.subject = 'New subject'
2267 2301 i.done_ratio = i.done_ratio + 10
2268 2302 assert_difference 'Journal.count' do
2269 2303 assert i.save
2270 2304 end
2271 2305 # 1 more change
2272 2306 i.priority = IssuePriority.where("id <> ?", i.priority_id).first
2273 2307 assert_no_difference 'Journal.count' do
2274 2308 assert_difference 'JournalDetail.count', 1 do
2275 2309 i.save
2276 2310 end
2277 2311 end
2278 2312 # no more change
2279 2313 assert_no_difference 'Journal.count' do
2280 2314 assert_no_difference 'JournalDetail.count' do
2281 2315 i.save
2282 2316 end
2283 2317 end
2284 2318 end
2285 2319
2286 2320 test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
2287 2321 @issue = Issue.find(1)
2288 2322 @issue_status = IssueStatus.find(1)
2289 2323 @issue_status.update_attribute(:default_done_ratio, 50)
2290 2324 @issue2 = Issue.find(2)
2291 2325 @issue_status2 = IssueStatus.find(2)
2292 2326 @issue_status2.update_attribute(:default_done_ratio, 0)
2293 2327
2294 2328 with_settings :issue_done_ratio => 'issue_field' do
2295 2329 assert_equal 0, @issue.done_ratio
2296 2330 assert_equal 30, @issue2.done_ratio
2297 2331 end
2298 2332
2299 2333 with_settings :issue_done_ratio => 'issue_status' do
2300 2334 assert_equal 50, @issue.done_ratio
2301 2335 assert_equal 0, @issue2.done_ratio
2302 2336 end
2303 2337 end
2304 2338
2305 2339 test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
2306 2340 @issue = Issue.find(1)
2307 2341 @issue_status = IssueStatus.find(1)
2308 2342 @issue_status.update_attribute(:default_done_ratio, 50)
2309 2343 @issue2 = Issue.find(2)
2310 2344 @issue_status2 = IssueStatus.find(2)
2311 2345 @issue_status2.update_attribute(:default_done_ratio, 0)
2312 2346
2313 2347 with_settings :issue_done_ratio => 'issue_field' do
2314 2348 @issue.update_done_ratio_from_issue_status
2315 2349 @issue2.update_done_ratio_from_issue_status
2316 2350
2317 2351 assert_equal 0, @issue.read_attribute(:done_ratio)
2318 2352 assert_equal 30, @issue2.read_attribute(:done_ratio)
2319 2353 end
2320 2354
2321 2355 with_settings :issue_done_ratio => 'issue_status' do
2322 2356 @issue.update_done_ratio_from_issue_status
2323 2357 @issue2.update_done_ratio_from_issue_status
2324 2358
2325 2359 assert_equal 50, @issue.read_attribute(:done_ratio)
2326 2360 assert_equal 0, @issue2.read_attribute(:done_ratio)
2327 2361 end
2328 2362 end
2329 2363
2330 2364 test "#by_tracker" do
2331 2365 User.current = User.anonymous
2332 2366 groups = Issue.by_tracker(Project.find(1))
2333 2367 assert_equal 3, groups.count
2334 2368 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2335 2369 end
2336 2370
2337 2371 test "#by_version" do
2338 2372 User.current = User.anonymous
2339 2373 groups = Issue.by_version(Project.find(1))
2340 2374 assert_equal 3, groups.count
2341 2375 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2342 2376 end
2343 2377
2344 2378 test "#by_priority" do
2345 2379 User.current = User.anonymous
2346 2380 groups = Issue.by_priority(Project.find(1))
2347 2381 assert_equal 4, groups.count
2348 2382 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2349 2383 end
2350 2384
2351 2385 test "#by_category" do
2352 2386 User.current = User.anonymous
2353 2387 groups = Issue.by_category(Project.find(1))
2354 2388 assert_equal 2, groups.count
2355 2389 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2356 2390 end
2357 2391
2358 2392 test "#by_assigned_to" do
2359 2393 User.current = User.anonymous
2360 2394 groups = Issue.by_assigned_to(Project.find(1))
2361 2395 assert_equal 2, groups.count
2362 2396 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2363 2397 end
2364 2398
2365 2399 test "#by_author" do
2366 2400 User.current = User.anonymous
2367 2401 groups = Issue.by_author(Project.find(1))
2368 2402 assert_equal 4, groups.count
2369 2403 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2370 2404 end
2371 2405
2372 2406 test "#by_subproject" do
2373 2407 User.current = User.anonymous
2374 2408 groups = Issue.by_subproject(Project.find(1))
2375 2409 # Private descendant not visible
2376 2410 assert_equal 1, groups.count
2377 2411 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
2378 2412 end
2379 2413
2380 2414 def test_recently_updated_scope
2381 2415 #should return the last updated issue
2382 2416 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
2383 2417 end
2384 2418
2385 2419 def test_on_active_projects_scope
2386 2420 assert Project.find(2).archive
2387 2421
2388 2422 before = Issue.on_active_project.length
2389 2423 # test inclusion to results
2390 2424 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
2391 2425 assert_equal before + 1, Issue.on_active_project.length
2392 2426
2393 2427 # Move to an archived project
2394 2428 issue.project = Project.find(2)
2395 2429 assert issue.save
2396 2430 assert_equal before, Issue.on_active_project.length
2397 2431 end
2398 2432
2399 2433 test "Issue#recipients should include project recipients" do
2400 2434 issue = Issue.generate!
2401 2435 assert issue.project.recipients.present?
2402 2436 issue.project.recipients.each do |project_recipient|
2403 2437 assert issue.recipients.include?(project_recipient)
2404 2438 end
2405 2439 end
2406 2440
2407 2441 test "Issue#recipients should include the author if the author is active" do
2408 2442 issue = Issue.generate!(:author => User.generate!)
2409 2443 assert issue.author, "No author set for Issue"
2410 2444 assert issue.recipients.include?(issue.author.mail)
2411 2445 end
2412 2446
2413 2447 test "Issue#recipients should include the assigned to user if the assigned to user is active" do
2414 2448 issue = Issue.generate!(:assigned_to => User.generate!)
2415 2449 assert issue.assigned_to, "No assigned_to set for Issue"
2416 2450 assert issue.recipients.include?(issue.assigned_to.mail)
2417 2451 end
2418 2452
2419 2453 test "Issue#recipients should not include users who opt out of all email" do
2420 2454 issue = Issue.generate!(:author => User.generate!)
2421 2455 issue.author.update_attribute(:mail_notification, :none)
2422 2456 assert !issue.recipients.include?(issue.author.mail)
2423 2457 end
2424 2458
2425 2459 test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
2426 2460 issue = Issue.generate!(:author => User.generate!)
2427 2461 issue.author.update_attribute(:mail_notification, :only_assigned)
2428 2462 assert !issue.recipients.include?(issue.author.mail)
2429 2463 end
2430 2464
2431 2465 test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
2432 2466 issue = Issue.generate!(:assigned_to => User.generate!)
2433 2467 issue.assigned_to.update_attribute(:mail_notification, :only_owner)
2434 2468 assert !issue.recipients.include?(issue.assigned_to.mail)
2435 2469 end
2436 2470
2437 2471 def test_last_journal_id_with_journals_should_return_the_journal_id
2438 2472 assert_equal 2, Issue.find(1).last_journal_id
2439 2473 end
2440 2474
2441 2475 def test_last_journal_id_without_journals_should_return_nil
2442 2476 assert_nil Issue.find(3).last_journal_id
2443 2477 end
2444 2478
2445 2479 def test_journals_after_should_return_journals_with_greater_id
2446 2480 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
2447 2481 assert_equal [], Issue.find(1).journals_after('2')
2448 2482 end
2449 2483
2450 2484 def test_journals_after_with_blank_arg_should_return_all_journals
2451 2485 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
2452 2486 end
2453 2487
2454 2488 def test_css_classes_should_include_tracker
2455 2489 issue = Issue.new(:tracker => Tracker.find(2))
2456 2490 classes = issue.css_classes.split(' ')
2457 2491 assert_include 'tracker-2', classes
2458 2492 end
2459 2493
2460 2494 def test_css_classes_should_include_priority
2461 2495 issue = Issue.new(:priority => IssuePriority.find(8))
2462 2496 classes = issue.css_classes.split(' ')
2463 2497 assert_include 'priority-8', classes
2464 2498 assert_include 'priority-highest', classes
2465 2499 end
2466 2500
2467 2501 def test_css_classes_should_include_user_and_group_assignment
2468 2502 project = Project.first
2469 2503 user = User.generate!
2470 2504 group = Group.generate!
2471 2505 Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
2472 2506 group.users << user
2473 2507 assert user.member_of?(project)
2474 2508 issue1 = Issue.generate(:assigned_to_id => group.id)
2475 2509 assert_include 'assigned-to-my-group', issue1.css_classes(user)
2476 2510 assert_not_include 'assigned-to-me', issue1.css_classes(user)
2477 2511 issue2 = Issue.generate(:assigned_to_id => user.id)
2478 2512 assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
2479 2513 assert_include 'assigned-to-me', issue2.css_classes(user)
2480 2514 end
2481 2515
2482 2516 def test_save_attachments_with_hash_should_save_attachments_in_keys_order
2483 2517 set_tmp_attachments_directory
2484 2518 issue = Issue.generate!
2485 2519 issue.save_attachments({
2486 2520 'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
2487 2521 '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
2488 2522 '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
2489 2523 })
2490 2524 issue.attach_saved_attachments
2491 2525
2492 2526 assert_equal 3, issue.reload.attachments.count
2493 2527 assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
2494 2528 end
2495 2529
2496 2530 def test_closed_on_should_be_nil_when_creating_an_open_issue
2497 2531 issue = Issue.generate!(:status_id => 1).reload
2498 2532 assert !issue.closed?
2499 2533 assert_nil issue.closed_on
2500 2534 end
2501 2535
2502 2536 def test_closed_on_should_be_set_when_creating_a_closed_issue
2503 2537 issue = Issue.generate!(:status_id => 5).reload
2504 2538 assert issue.closed?
2505 2539 assert_not_nil issue.closed_on
2506 2540 assert_equal issue.updated_on, issue.closed_on
2507 2541 assert_equal issue.created_on, issue.closed_on
2508 2542 end
2509 2543
2510 2544 def test_closed_on_should_be_nil_when_updating_an_open_issue
2511 2545 issue = Issue.find(1)
2512 2546 issue.subject = 'Not closed yet'
2513 2547 issue.save!
2514 2548 issue.reload
2515 2549 assert_nil issue.closed_on
2516 2550 end
2517 2551
2518 2552 def test_closed_on_should_be_set_when_closing_an_open_issue
2519 2553 issue = Issue.find(1)
2520 2554 issue.subject = 'Now closed'
2521 2555 issue.status_id = 5
2522 2556 issue.save!
2523 2557 issue.reload
2524 2558 assert_not_nil issue.closed_on
2525 2559 assert_equal issue.updated_on, issue.closed_on
2526 2560 end
2527 2561
2528 2562 def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
2529 2563 issue = Issue.open(false).first
2530 2564 was_closed_on = issue.closed_on
2531 2565 assert_not_nil was_closed_on
2532 2566 issue.subject = 'Updating a closed issue'
2533 2567 issue.save!
2534 2568 issue.reload
2535 2569 assert_equal was_closed_on, issue.closed_on
2536 2570 end
2537 2571
2538 2572 def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
2539 2573 issue = Issue.open(false).first
2540 2574 was_closed_on = issue.closed_on
2541 2575 assert_not_nil was_closed_on
2542 2576 issue.subject = 'Reopening a closed issue'
2543 2577 issue.status_id = 1
2544 2578 issue.save!
2545 2579 issue.reload
2546 2580 assert !issue.closed?
2547 2581 assert_equal was_closed_on, issue.closed_on
2548 2582 end
2549 2583
2550 2584 def test_status_was_should_return_nil_for_new_issue
2551 2585 issue = Issue.new
2552 2586 assert_nil issue.status_was
2553 2587 end
2554 2588
2555 2589 def test_status_was_should_return_status_before_change
2556 2590 issue = Issue.find(1)
2557 2591 issue.status = IssueStatus.find(2)
2558 2592 assert_equal IssueStatus.find(1), issue.status_was
2559 2593 end
2560 2594
2561 2595 def test_status_was_should_return_status_before_change_with_status_id
2562 2596 issue = Issue.find(1)
2563 2597 assert_equal IssueStatus.find(1), issue.status
2564 2598 issue.status_id = 2
2565 2599 assert_equal IssueStatus.find(1), issue.status_was
2566 2600 end
2567 2601
2568 2602 def test_status_was_should_be_reset_on_save
2569 2603 issue = Issue.find(1)
2570 2604 issue.status = IssueStatus.find(2)
2571 2605 assert_equal IssueStatus.find(1), issue.status_was
2572 2606 assert issue.save!
2573 2607 assert_equal IssueStatus.find(2), issue.status_was
2574 2608 end
2575 2609
2576 2610 def test_closing_should_return_true_when_closing_an_issue
2577 2611 issue = Issue.find(1)
2578 2612 issue.status = IssueStatus.find(2)
2579 2613 assert_equal false, issue.closing?
2580 2614 issue.status = IssueStatus.find(5)
2581 2615 assert_equal true, issue.closing?
2582 2616 end
2583 2617
2584 2618 def test_closing_should_return_true_when_closing_an_issue_with_status_id
2585 2619 issue = Issue.find(1)
2586 2620 issue.status_id = 2
2587 2621 assert_equal false, issue.closing?
2588 2622 issue.status_id = 5
2589 2623 assert_equal true, issue.closing?
2590 2624 end
2591 2625
2592 2626 def test_closing_should_return_true_for_new_closed_issue
2593 2627 issue = Issue.new
2594 2628 assert_equal false, issue.closing?
2595 2629 issue.status = IssueStatus.find(5)
2596 2630 assert_equal true, issue.closing?
2597 2631 end
2598 2632
2599 2633 def test_closing_should_return_true_for_new_closed_issue_with_status_id
2600 2634 issue = Issue.new
2601 2635 assert_equal false, issue.closing?
2602 2636 issue.status_id = 5
2603 2637 assert_equal true, issue.closing?
2604 2638 end
2605 2639
2606 2640 def test_closing_should_be_reset_after_save
2607 2641 issue = Issue.find(1)
2608 2642 issue.status_id = 5
2609 2643 assert_equal true, issue.closing?
2610 2644 issue.save!
2611 2645 assert_equal false, issue.closing?
2612 2646 end
2613 2647
2614 2648 def test_reopening_should_return_true_when_reopening_an_issue
2615 2649 issue = Issue.find(8)
2616 2650 issue.status = IssueStatus.find(6)
2617 2651 assert_equal false, issue.reopening?
2618 2652 issue.status = IssueStatus.find(2)
2619 2653 assert_equal true, issue.reopening?
2620 2654 end
2621 2655
2622 2656 def test_reopening_should_return_true_when_reopening_an_issue_with_status_id
2623 2657 issue = Issue.find(8)
2624 2658 issue.status_id = 6
2625 2659 assert_equal false, issue.reopening?
2626 2660 issue.status_id = 2
2627 2661 assert_equal true, issue.reopening?
2628 2662 end
2629 2663
2630 2664 def test_reopening_should_return_false_for_new_open_issue
2631 2665 issue = Issue.new
2632 2666 issue.status = IssueStatus.find(1)
2633 2667 assert_equal false, issue.reopening?
2634 2668 end
2635 2669
2636 2670 def test_reopening_should_be_reset_after_save
2637 2671 issue = Issue.find(8)
2638 2672 issue.status_id = 2
2639 2673 assert_equal true, issue.reopening?
2640 2674 issue.save!
2641 2675 assert_equal false, issue.reopening?
2642 2676 end
2643 2677
2644 2678 def test_default_status_without_tracker_should_be_nil
2645 2679 issue = Issue.new
2646 2680 assert_nil issue.tracker
2647 2681 assert_nil issue.default_status
2648 2682 end
2649 2683
2650 2684 def test_default_status_should_be_tracker_default_status
2651 2685 issue = Issue.new(:tracker_id => 1)
2652 2686 assert_not_nil issue.status
2653 2687 assert_equal issue.tracker.default_status, issue.default_status
2654 2688 end
2655 2689
2656 2690 def test_initializing_with_tracker_should_set_default_status
2657 2691 issue = Issue.new(:tracker => Tracker.find(1))
2658 2692 assert_not_nil issue.status
2659 2693 assert_equal issue.default_status, issue.status
2660 2694 end
2661 2695
2662 2696 def test_initializing_with_tracker_id_should_set_default_status
2663 2697 issue = Issue.new(:tracker_id => 1)
2664 2698 assert_not_nil issue.status
2665 2699 assert_equal issue.default_status, issue.status
2666 2700 end
2667 2701
2668 2702 def test_setting_tracker_should_set_default_status
2669 2703 issue = Issue.new
2670 2704 issue.tracker = Tracker.find(1)
2671 2705 assert_not_nil issue.status
2672 2706 assert_equal issue.default_status, issue.status
2673 2707 end
2674 2708
2675 2709 def test_changing_tracker_should_set_default_status_if_status_was_default
2676 2710 WorkflowTransition.delete_all
2677 2711 WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1
2678 2712 Tracker.find(2).update! :default_status_id => 2
2679 2713
2680 2714 issue = Issue.new(:tracker_id => 1, :status_id => 1)
2681 2715 assert_equal IssueStatus.find(1), issue.status
2682 2716 issue.tracker = Tracker.find(2)
2683 2717 assert_equal IssueStatus.find(2), issue.status
2684 2718 end
2685 2719
2686 2720 def test_changing_tracker_should_set_default_status_if_status_is_not_used_by_tracker
2687 2721 WorkflowTransition.delete_all
2688 2722 Tracker.find(2).update! :default_status_id => 2
2689 2723
2690 2724 issue = Issue.new(:tracker_id => 1, :status_id => 3)
2691 2725 assert_equal IssueStatus.find(3), issue.status
2692 2726 issue.tracker = Tracker.find(2)
2693 2727 assert_equal IssueStatus.find(2), issue.status
2694 2728 end
2695 2729
2696 2730 def test_changing_tracker_should_keep_status_if_status_was_not_default_and_is_used_by_tracker
2697 2731 WorkflowTransition.delete_all
2698 2732 WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3
2699 2733 Tracker.find(2).update! :default_status_id => 2
2700 2734
2701 2735 issue = Issue.new(:tracker_id => 1, :status_id => 3)
2702 2736 assert_equal IssueStatus.find(3), issue.status
2703 2737 issue.tracker = Tracker.find(2)
2704 2738 assert_equal IssueStatus.find(3), issue.status
2705 2739 end
2706 2740
2707 2741 def test_assigned_to_was_with_a_group
2708 2742 group = Group.find(10)
2709 2743
2710 2744 issue = Issue.generate!(:assigned_to => group)
2711 2745 issue.reload.assigned_to = nil
2712 2746 assert_equal group, issue.assigned_to_was
2713 2747 end
2714 2748 end
General Comments 0
You need to be logged in to leave comments. Login now