jro_apps/redmine Commit - r2768:94488269d1c3

Merged r2768, r2773, r2774, r2775, r2796 from trunk....

Jean-Philippe Lang -

r2768:94488269d1c3

parent child

Context file:

r2768:94488269d1c3

Collapse all files

app/controllers/messages_controller.rb +2 0

             # redMine - project management software
             # Copyright (C) 2006-2007  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class MessagesController < ApplicationController
               menu_item :boards
               before_filter :find_board, :only => [:new, :preview]
               before_filter :find_message, :except => [:new, :preview]
               before_filter :authorize, :except => [:preview, :edit, :destroy]
               verify :method => :post, :only => [ :reply, :destroy ], :redirect_to => { :action => :show }
               verify :xhr => true, :only => :quote
               helper :watchers
               helper :attachments
               include AttachmentsHelper
               # Show a topic and its replies
               def show
                 @replies = @topic.children.find(:all, :include => [:author, :attachments, {:board => :project}])
                 @replies.reverse! if User.current.wants_comments_in_reverse_order?
                 @reply = Message.new(:subject => "RE: #{@message.subject}")
                 render :action => "show", :layout => false if request.xhr?
               end
               # Create a new topic
               def new
                 @message = Message.new(params[:message])
                 @message.author = User.current
                 @message.board = @board
                 if params[:message] && User.current.allowed_to?(:edit_messages, @project)
                   @message.locked = params[:message]['locked']
                   @message.sticky = params[:message]['sticky']
                 end
                 if request.post? && @message.save
+                  call_hook(:controller_messages_new_after_save, { :params => params, :message => @message})
                   attach_files(@message, params[:attachments])
                   redirect_to :action => 'show', :id => @message
                 end
               end
               # Reply to a topic
               def reply
                 @reply = Message.new(params[:reply])
                 @reply.author = User.current
                 @reply.board = @board
                 @topic.children << @reply
                 if !@reply.new_record?
+                  call_hook(:controller_messages_reply_after_save, { :params => params, :message => @reply})
                   attach_files(@reply, params[:attachments])
                 end
                 redirect_to :action => 'show', :id => @topic
               end
               # Edit a message
               def edit
                 render_403 and return false unless @message.editable_by?(User.current)
                 if params[:message]
                   @message.locked = params[:message]['locked']
                   @message.sticky = params[:message]['sticky']
                 end
                 if request.post? && @message.update_attributes(params[:message])
                   attach_files(@message, params[:attachments])
                   flash[:notice] = l(:notice_successful_update)
                   redirect_to :action => 'show', :id => @topic
                 end
               end
               # Delete a messages
               def destroy
                 render_403 and return false unless @message.destroyable_by?(User.current)
                 @message.destroy
                 redirect_to @message.parent.nil? ?
                   { :controller => 'boards', :action => 'show', :project_id => @project, :id => @board } :
                   { :action => 'show', :id => @message.parent }
               end
               def quote
                 user = @message.author
                 text = @message.content
                 content = "#{ll(Setting.default_language, :text_user_wrote, user)}\\n> "
                 content << text.to_s.strip.gsub(%r{<pre>((.|\s)*?)</pre>}m, '[...]').gsub('"', '\"').gsub(/(\r?\n|\r\n?)/, "\\n> ") + "\\n\\n"
                 render(:update) { |page|
                   page.<< "$('message_content').value = \"#{content}\";"
                   page.show 'reply'
                   page << "Form.Element.focus('message_content');"
                   page << "Element.scrollTo('reply');"
                   page << "$('message_content').scrollTop = $('message_content').scrollHeight - $('message_content').clientHeight;"
                 }
               end
               def preview
                 message = @board.messages.find_by_id(params[:id])
                 @attachements = message.attachments if message
                 @text = (params[:message] || params[:reply])[:content]
                 render :partial => 'common/preview'
               end
             private
               def find_message
                 find_board
                 @message = @board.messages.find(params[:id], :include => :parent)
                 @topic = @message.root
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_board
                 @board = Board.find(params[:board_id], :include => :project)
                 @project = @board.project
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
             end

app/controllers/timelog_controller.rb +3 0

             # redMine - project management software
             # Copyright (C) 2006-2007  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class TimelogController < ApplicationController
               menu_item :issues
               before_filter :find_project, :authorize, :only => [:edit, :destroy]
               before_filter :find_optional_project, :only => [:report, :details]
               verify :method => :post, :only => :destroy, :redirect_to => { :action => :details }
               helper :sort
               include SortHelper
               helper :issues
               include TimelogHelper
               helper :custom_fields
               include CustomFieldsHelper
               def report
                 @available_criterias = { 'project' => {:sql => "#{TimeEntry.table_name}.project_id",
                                                       :klass => Project,
                                                       :label => :label_project},
                                          'version' => {:sql => "#{Issue.table_name}.fixed_version_id",
                                                       :klass => Version,
                                                       :label => :label_version},
                                          'category' => {:sql => "#{Issue.table_name}.category_id",
                                                         :klass => IssueCategory,
                                                         :label => :field_category},
                                          'member' => {:sql => "#{TimeEntry.table_name}.user_id",
                                                      :klass => User,
                                                      :label => :label_member},
                                          'tracker' => {:sql => "#{Issue.table_name}.tracker_id",
                                                       :klass => Tracker,
                                                       :label => :label_tracker},
                                          'activity' => {:sql => "#{TimeEntry.table_name}.activity_id",
                                                        :klass => Enumeration,
                                                        :label => :label_activity},
                                          'issue' => {:sql => "#{TimeEntry.table_name}.issue_id",
                                                      :klass => Issue,
                                                      :label => :label_issue}
                                        }
                 # Add list and boolean custom fields as available criterias
                 custom_fields = (@project.nil? ? IssueCustomField.for_all : @project.all_issue_custom_fields)
                 custom_fields.select {|cf| %w(list bool).include? cf.field_format }.each do |cf|
                   @available_criterias["cf_#{cf.id}"] = {:sql => "(SELECT c.value FROM #{CustomValue.table_name} c WHERE c.custom_field_id = #{cf.id} AND c.customized_type = 'Issue' AND c.customized_id = #{Issue.table_name}.id)",
                                                          :format => cf.field_format,
                                                          :label => cf.name}
                 end if @project
                 # Add list and boolean time entry custom fields
                 TimeEntryCustomField.find(:all).select {|cf| %w(list bool).include? cf.field_format }.each do |cf|
                   @available_criterias["cf_#{cf.id}"] = {:sql => "(SELECT c.value FROM #{CustomValue.table_name} c WHERE c.custom_field_id = #{cf.id} AND c.customized_type = 'TimeEntry' AND c.customized_id = #{TimeEntry.table_name}.id)",
                                                          :format => cf.field_format,
                                                          :label => cf.name}
                 end
                 @criterias = params[:criterias] || []
                 @criterias = @criterias.select{|criteria| @available_criterias.has_key? criteria}
                 @criterias.uniq!
                 @criterias = @criterias[0,3]
                 @columns = (params[:columns] && %w(year month week day).include?(params[:columns])) ? params[:columns] : 'month'
                 retrieve_date_range
                 unless @criterias.empty?
                   sql_select = @criterias.collect{|criteria| @available_criterias[criteria][:sql] + " AS " + criteria}.join(', ')
                   sql_group_by = @criterias.collect{|criteria| @available_criterias[criteria][:sql]}.join(', ')
                   sql = "SELECT #{sql_select}, tyear, tmonth, tweek, spent_on, SUM(hours) AS hours"
                   sql << " FROM #{TimeEntry.table_name}"
                   sql << " LEFT JOIN #{Issue.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id"
                   sql << " LEFT JOIN #{Project.table_name} ON #{TimeEntry.table_name}.project_id = #{Project.table_name}.id"
                   sql << " WHERE"
                   sql << " (%s) AND" % @project.project_condition(Setting.display_subprojects_issues?) if @project
                   sql << " (%s) AND" % Project.allowed_to_condition(User.current, :view_time_entries)
                   sql << " (spent_on BETWEEN '%s' AND '%s')" % [ActiveRecord::Base.connection.quoted_date(@from.to_time), ActiveRecord::Base.connection.quoted_date(@to.to_time)]
                   sql << " GROUP BY #{sql_group_by}, tyear, tmonth, tweek, spent_on"
                   @hours = ActiveRecord::Base.connection.select_all(sql)
                   @hours.each do |row|
                     case @columns
                     when 'year'
                       row['year'] = row['tyear']
                     when 'month'
                       row['month'] = "#{row['tyear']}-#{row['tmonth']}"
                     when 'week'
                       row['week'] = "#{row['tyear']}-#{row['tweek']}"
                     when 'day'
                       row['day'] = "#{row['spent_on']}"
                     end
                   end
                   @total_hours = @hours.inject(0) {|s,k| s = s + k['hours'].to_f}
                   @periods = []
                   # Date#at_beginning_of_ not supported in Rails 1.2.x
                   date_from = @from.to_time
                   # 100 columns max
                   while date_from <= @to.to_time && @periods.length < 100
                     case @columns
                     when 'year'
                       @periods << "#{date_from.year}"
                       date_from = (date_from + 1.year).at_beginning_of_year
                     when 'month'
                       @periods << "#{date_from.year}-#{date_from.month}"
                       date_from = (date_from + 1.month).at_beginning_of_month
                     when 'week'
                       @periods << "#{date_from.year}-#{date_from.to_date.cweek}"
                       date_from = (date_from + 7.day).at_beginning_of_week
                     when 'day'
                       @periods << "#{date_from.to_date}"
                       date_from = date_from + 1.day
                     end
                   end
                 end
                 respond_to do |format|
                   format.html { render :layout => !request.xhr? }
                   format.csv  { send_data(report_to_csv(@criterias, @periods, @hours).read, :type => 'text/csv; header=present', :filename => 'timelog.csv') }
                 end
               end
               def details
                 sort_init 'spent_on', 'desc'
                 sort_update 'spent_on' => 'spent_on',
                             'user' => 'user_id',
                             'activity' => 'activity_id',
                             'project' => "#{Project.table_name}.name",
                             'issue' => 'issue_id',
                             'hours' => 'hours'
                 cond = ARCondition.new
                 if @project.nil?
                   cond << Project.allowed_to_condition(User.current, :view_time_entries)
                 elsif @issue.nil?
                   cond << @project.project_condition(Setting.display_subprojects_issues?)
                 else
                   cond << ["#{TimeEntry.table_name}.issue_id = ?", @issue.id]
                 end
                 retrieve_date_range
                 cond << ['spent_on BETWEEN ? AND ?', @from, @to]
                 TimeEntry.visible_by(User.current) do
                   respond_to do |format|
                     format.html {
                       # Paginate results
                       @entry_count = TimeEntry.count(:include => :project, :conditions => cond.conditions)
                       @entry_pages = Paginator.new self, @entry_count, per_page_option, params['page']
                       @entries = TimeEntry.find(:all,
                                                 :include => [:project, :activity, :user, {:issue => :tracker}],
                                                 :conditions => cond.conditions,
                                                 :order => sort_clause,
                                                 :limit  =>  @entry_pages.items_per_page,
                                                 :offset =>  @entry_pages.current.offset)
                       @total_hours = TimeEntry.sum(:hours, :include => :project, :conditions => cond.conditions).to_f
                       render :layout => !request.xhr?
                     }
                     format.atom {
                       entries = TimeEntry.find(:all,
                                                :include => [:project, :activity, :user, {:issue => :tracker}],
                                                :conditions => cond.conditions,
                                                :order => "#{TimeEntry.table_name}.created_on DESC",
                                                :limit => Setting.feeds_limit.to_i)
                       render_feed(entries, :title => l(:label_spent_time))
                     }
                     format.csv {
                       # Export all entries
                       @entries = TimeEntry.find(:all,
                                                 :include => [:project, :activity, :user, {:issue => [:tracker, :assigned_to, :priority]}],
                                                 :conditions => cond.conditions,
                                                 :order => sort_clause)
                       send_data(entries_to_csv(@entries).read, :type => 'text/csv; header=present', :filename => 'timelog.csv')
                     }
                   end
                 end
               end
               def edit
                 render_403 and return if @time_entry && !@time_entry.editable_by?(User.current)
                 @time_entry ||= TimeEntry.new(:project => @project, :issue => @issue, :user => User.current, :spent_on => Date.today)
                 @time_entry.attributes = params[:time_entry]
+                call_hook(:controller_timelog_edit_before_save, { :params => params, :time_entry => @time_entry })
                 if request.post? and @time_entry.save
                   flash[:notice] = l(:notice_successful_update)
                   redirect_back_or_default :action => 'details', :project_id => @time_entry.project
                   return
                 end
               end
               def destroy
                 render_404 and return unless @time_entry
                 render_403 and return unless @time_entry.editable_by?(User.current)
                 @time_entry.destroy
                 flash[:notice] = l(:notice_successful_delete)
                 redirect_to :back
               rescue ::ActionController::RedirectBackError
                 redirect_to :action => 'details', :project_id => @time_entry.project
               end
             private
               def find_project
                 if params[:id]
                   @time_entry = TimeEntry.find(params[:id])
                   @project = @time_entry.project
                 elsif params[:issue_id]
                   @issue = Issue.find(params[:issue_id])
                   @project = @issue.project
                 elsif params[:project_id]
                   @project = Project.find(params[:project_id])
                 else
                   render_404
                   return false
                 end
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_optional_project
                 if !params[:issue_id].blank?
                   @issue = Issue.find(params[:issue_id])
                   @project = @issue.project
                 elsif !params[:project_id].blank?
                   @project = Project.find(params[:project_id])
                 end
                 deny_access unless User.current.allowed_to?(:view_time_entries, @project, :global => true)
               end
               # Retrieves the date range based on predefined ranges or specific from/to param dates
               def retrieve_date_range
                 @free_period = false
                 @from, @to = nil, nil
                 if params[:period_type] == '1' || (params[:period_type].nil? && !params[:period].nil?)
                   case params[:period].to_s
                   when 'today'
                     @from = @to = Date.today
                   when 'yesterday'
                     @from = @to = Date.today - 1
                   when 'current_week'
                     @from = Date.today - (Date.today.cwday - 1)%7
                     @to = @from + 6
                   when 'last_week'
                     @from = Date.today - 7 - (Date.today.cwday - 1)%7
                     @to = @from + 6
                   when '7_days'
                     @from = Date.today - 7
                     @to = Date.today
                   when 'current_month'
                     @from = Date.civil(Date.today.year, Date.today.month, 1)
                     @to = (@from >> 1) - 1
                   when 'last_month'
                     @from = Date.civil(Date.today.year, Date.today.month, 1) << 1
                     @to = (@from >> 1) - 1
                   when '30_days'
                     @from = Date.today - 30
                     @to = Date.today
                   when 'current_year'
                     @from = Date.civil(Date.today.year, 1, 1)
                     @to = Date.civil(Date.today.year, 12, 31)
                   end
                 elsif params[:period_type] == '2' || (params[:period_type].nil? && (!params[:from].nil? || !params[:to].nil?))
                   begin; @from = params[:from].to_s.to_date unless params[:from].blank?; rescue; end
                   begin; @to = params[:to].to_s.to_date unless params[:to].blank?; rescue; end
                   @free_period = true
                 else
                   # default
                 end
                 @from, @to = @to, @from if @from && @to && @from > @to
                 @from ||= (TimeEntry.minimum(:spent_on, :include => :project, :conditions => Project.allowed_to_condition(User.current, :view_time_entries)) || Date.today) - 1
                 @to   ||= (TimeEntry.maximum(:spent_on, :include => :project, :conditions => Project.allowed_to_condition(User.current, :view_time_entries)) || Date.today)
               end
             end

app/controllers/wiki_controller.rb +1 0

             # redMine - project management software
             # Copyright (C) 2006-2007  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require 'diff'
             class WikiController < ApplicationController
               before_filter :find_wiki, :authorize
               before_filter :find_existing_page, :only => [:rename, :protect, :history, :diff, :annotate, :add_attachment, :destroy]
               verify :method => :post, :only => [:destroy, :protect], :redirect_to => { :action => :index }
               helper :attachments
               include AttachmentsHelper
               # display a page (in editing mode if it doesn't exist)
               def index
                 page_title = params[:page]
                 @page = @wiki.find_or_new_page(page_title)
                 if @page.new_record?
                   if User.current.allowed_to?(:edit_wiki_pages, @project)
                     edit
                     render :action => 'edit'
                   else
                     render_404
                   end
                   return
                 end
                 if params[:version] && !User.current.allowed_to?(:view_wiki_edits, @project)
                   # Redirects user to the current version if he's not allowed to view previous versions
                   redirect_to :version => nil
                   return
                 end
                 @content = @page.content_for_version(params[:version])
                 if params[:export] == 'html'
                   export = render_to_string :action => 'export', :layout => false
                   send_data(export, :type => 'text/html', :filename => "#{@page.title}.html")
                   return
                 elsif params[:export] == 'txt'
                   send_data(@content.text, :type => 'text/plain', :filename => "#{@page.title}.txt")
                   return
                 end
             	@editable = editable?
                 render :action => 'show'
               end
               # edit an existing page or a new one
               def edit
                 @page = @wiki.find_or_new_page(params[:page])
                 return render_403 unless editable?
                 @page.content = WikiContent.new(:page => @page) if @page.new_record?
                 @content = @page.content_for_version(params[:version])
                 @content.text = initial_page_content(@page) if @content.text.blank?
                 # don't keep previous comment
                 @content.comments = nil
                 if request.get?
                   # To prevent StaleObjectError exception when reverting to a previous version
                   @content.version = @page.content.version
                 else
                   if !@page.new_record? && @content.text == params[:content][:text]
                     # don't save if text wasn't changed
                     redirect_to :action => 'index', :id => @project, :page => @page.title
                     return
                   end
                   #@content.text = params[:content][:text]
                   #@content.comments = params[:content][:comments]
                   @content.attributes = params[:content]
                   @content.author = User.current
                   # if page is new @page.save will also save content, but not if page isn't a new record
                   if (@page.new_record? ? @page.save : @content.save)
+                    call_hook(:controller_wiki_edit_after_save, { :params => params, :page => @page})
                     redirect_to :action => 'index', :id => @project, :page => @page.title
                   end
                 end
               rescue ActiveRecord::StaleObjectError
                 # Optimistic locking exception
                 flash[:error] = l(:notice_locking_conflict)
               end
               # rename a page
               def rename
                 return render_403 unless editable?
                 @page.redirect_existing_links = true
                 # used to display the *original* title if some AR validation errors occur
                 @original_title = @page.pretty_title
                 if request.post? && @page.update_attributes(params[:wiki_page])
                   flash[:notice] = l(:notice_successful_update)
                   redirect_to :action => 'index', :id => @project, :page => @page.title
                 end
               end
               def protect
                 @page.update_attribute :protected, params[:protected]
                 redirect_to :action => 'index', :id => @project, :page => @page.title
               end
               # show page history
               def history
                 @version_count = @page.content.versions.count
                 @version_pages = Paginator.new self, @version_count, per_page_option, params['p']
                 # don't load text
                 @versions = @page.content.versions.find :all,
                                                         :select => "id, author_id, comments, updated_on, version",
                                                         :order => 'version DESC',
                                                         :limit  =>  @version_pages.items_per_page + 1,
                                                         :offset =>  @version_pages.current.offset
                 render :layout => false if request.xhr?
               end
               def diff
                 @diff = @page.diff(params[:version], params[:version_from])
                 render_404 unless @diff
               end
               def annotate
                 @annotate = @page.annotate(params[:version])
                 render_404 unless @annotate
               end
               # remove a wiki page and its history
               def destroy
                 return render_403 unless editable?
                 @page.destroy
                 redirect_to :action => 'special', :id => @project, :page => 'Page_index'
               end
               # display special pages
               def special
                 page_title = params[:page].downcase
                 case page_title
                 # show pages index, sorted by title
                 when 'page_index', 'date_index'
                   # eager load information about last updates, without loading text
                   @pages = @wiki.pages.find :all, :select => "#{WikiPage.table_name}.*, #{WikiContent.table_name}.updated_on",
                                                   :joins => "LEFT JOIN #{WikiContent.table_name} ON #{WikiContent.table_name}.page_id = #{WikiPage.table_name}.id",
                                                   :order => 'title'
                   @pages_by_date = @pages.group_by {|p| p.updated_on.to_date}
                   @pages_by_parent_id = @pages.group_by(&:parent_id)
                 # export wiki to a single html file
                 when 'export'
                   @pages = @wiki.pages.find :all, :order => 'title'
                   export = render_to_string :action => 'export_multiple', :layout => false
                   send_data(export, :type => 'text/html', :filename => "wiki.html")
                   return
                 else
                   # requested special page doesn't exist, redirect to default page
                   redirect_to :action => 'index', :id => @project, :page => nil and return
                 end
                 render :action => "special_#{page_title}"
               end
               def preview
                 page = @wiki.find_page(params[:page])
                 # page is nil when previewing a new page
                 return render_403 unless page.nil? || editable?(page)
                 if page
                   @attachements = page.attachments
                   @previewed = page.content
                 end
                 @text = params[:content][:text]
                 render :partial => 'common/preview'
               end
               def add_attachment
                 return render_403 unless editable?
                 attach_files(@page, params[:attachments])
                 redirect_to :action => 'index', :page => @page.title
               end
             private
               def find_wiki
                 @project = Project.find(params[:id])
                 @wiki = @project.wiki
                 render_404 unless @wiki
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               # Finds the requested page and returns a 404 error if it doesn't exist
               def find_existing_page
                 @page = @wiki.find_page(params[:page])
                 render_404 if @page.nil?
               end
               # Returns true if the current user is allowed to edit the page, otherwise false
               def editable?(page = @page)
                 page.editable_by?(User.current)
               end
               # Returns the default content of a new wiki page
               def initial_page_content(page)
                 helper = Redmine::WikiFormatting.helper_for(Setting.text_formatting)
                 extend helper unless self.instance_of?(helper)
                 helper.instance_method(:initial_page_content).bind(self).call(page)
               end
             end

app/models/changeset.rb +2 0

             # Redmine - project management software
             # Copyright (C) 2006-2008  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require 'iconv'
             class Changeset < ActiveRecord::Base
               belongs_to :repository
               belongs_to :user
               has_many :changes, :dependent => :delete_all
               has_and_belongs_to_many :issues
               acts_as_event :title => Proc.new {|o| "#{l(:label_revision)} #{o.revision}" + (o.comments.blank? ? '' : (': ' + o.comments))},
                             :description => :comments,
                             :datetime => :committed_on,
                             :url => Proc.new {|o| {:controller => 'repositories', :action => 'revision', :id => o.repository.project_id, :rev => o.revision}}
               acts_as_searchable :columns => 'comments',
                                  :include => {:repository => :project},
                                  :project_key => "#{Repository.table_name}.project_id",
                                  :date_column => 'committed_on'
               acts_as_activity_provider :timestamp => "#{table_name}.committed_on",
                                         :author_key => :user_id,
                                         :find_options => {:include => {:repository => :project}}
               validates_presence_of :repository_id, :revision, :committed_on, :commit_date
               validates_uniqueness_of :revision, :scope => :repository_id
               validates_uniqueness_of :scmid, :scope => :repository_id, :allow_nil => true
               def revision=(r)
                 write_attribute :revision, (r.nil? ? nil : r.to_s)
               end
               def comments=(comment)
                 write_attribute(:comments, Changeset.normalize_comments(comment))
               end
               def committed_on=(date)
                 self.commit_date = date
                 super
               end
               def project
                 repository.project
               end
               def author
                 user || committer.to_s.split('<').first
               end
               def before_create
                 self.user = repository.find_committer_user(committer)
               end
               def after_create
                 scan_comment_for_issue_ids
               end
               require 'pp'
               def scan_comment_for_issue_ids
                 return if comments.blank?
                 # keywords used to reference issues
                 ref_keywords = Setting.commit_ref_keywords.downcase.split(",").collect(&:strip)
                 # keywords used to fix issues
                 fix_keywords = Setting.commit_fix_keywords.downcase.split(",").collect(&:strip)
                 # status and optional done ratio applied
                 fix_status = IssueStatus.find_by_id(Setting.commit_fix_status_id)
                 done_ratio = Setting.commit_fix_done_ratio.blank? ? nil : Setting.commit_fix_done_ratio.to_i
                 kw_regexp = (ref_keywords + fix_keywords).collect{|kw| Regexp.escape(kw)}.join("|")
                 return if kw_regexp.blank?
                 referenced_issues = []
                 if ref_keywords.delete('*')
                   # find any issue ID in the comments
                   target_issue_ids = []
                   comments.scan(%r{([\s\(,-]|^)#(\d+)(?=[[:punct:]]|\s|<|$)}).each { |m| target_issue_ids << m[1] }
                   referenced_issues += repository.project.issues.find_all_by_id(target_issue_ids)
                 end
                 comments.scan(Regexp.new("(#{kw_regexp})[\s:]+(([\s,;&]*#?\\d+)+)", Regexp::IGNORECASE)).each do |match|
                   action = match[0]
                   target_issue_ids = match[1].scan(/\d+/)
                   target_issues = repository.project.issues.find_all_by_id(target_issue_ids)
                   if fix_status && fix_keywords.include?(action.downcase)
                     # update status of issues
                     logger.debug "Issues fixed by changeset #{self.revision}: #{issue_ids.join(', ')}." if logger && logger.debug?
                     target_issues.each do |issue|
                       # the issue may have been updated by the closure of another one (eg. duplicate)
                       issue.reload
                       # don't change the status is the issue is closed
                       next if issue.status.is_closed?
                       csettext = "r#{self.revision}"
                       if self.scmid && (! (csettext =~ /^r[0-9]+$/))
                         csettext = "commit:\"#{self.scmid}\""
                       end
                       journal = issue.init_journal(user || User.anonymous, l(:text_status_changed_by_changeset, csettext))
                       issue.status = fix_status
                       issue.done_ratio = done_ratio if done_ratio
+                      Redmine::Hook.call_hook(:model_changeset_scan_commit_for_issue_ids_pre_issue_update,
+                                              { :changeset => self, :issue => issue })
                       issue.save
                       Mailer.deliver_issue_edit(journal) if Setting.notified_events.include?('issue_updated')
                     end
                   end
                   referenced_issues += target_issues
                 end
                 self.issues = referenced_issues.uniq
               end
               # Returns the previous changeset
               def previous
                 @previous ||= Changeset.find(:first, :conditions => ['id < ? AND repository_id = ?', self.id, self.repository_id], :order => 'id DESC')
               end
               # Returns the next changeset
               def next
                 @next ||= Changeset.find(:first, :conditions => ['id > ? AND repository_id = ?', self.id, self.repository_id], :order => 'id ASC')
               end
               # Strips and reencodes a commit log before insertion into the database
               def self.normalize_comments(str)
                 to_utf8(str.to_s.strip)
               end
               private
               def self.to_utf8(str)
                 return str if /\A[\r\n\t\x20-\x7e]*\Z/n.match(str) # for us-ascii
                 encoding = Setting.commit_logs_encoding.to_s.strip
                 unless encoding.blank? || encoding == 'UTF-8'
                   begin
                     return Iconv.conv('UTF-8', encoding, str)
                   rescue Iconv::Failure
                     # do nothing here
                   end
                 end
                 str
               end
             end

app/models/query.rb +2 -2

             # Redmine - project management software
             # Copyright (C) 2006-2008  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class QueryColumn
               attr_accessor :name, :sortable, :default_order
               include GLoc
               def initialize(name, options={})
                 self.name = name
                 self.sortable = options[:sortable]
                 self.default_order = options[:default_order]
               end
               def caption
                 set_language_if_valid(User.current.language)
                 l("field_#{name}")
               end
             end
             class QueryCustomFieldColumn < QueryColumn
               def initialize(custom_field)
                 self.name = "cf_#{custom_field.id}".to_sym
                 self.sortable = false
                 @cf = custom_field
               end
               def caption
                 @cf.name
               end
               def custom_field
                 @cf
               end
             end
             class Query < ActiveRecord::Base
               belongs_to :project
               belongs_to :user
               serialize :filters
               serialize :column_names
               attr_protected :project_id, :user_id
               validates_presence_of :name, :on => :save
               validates_length_of :name, :maximum => 255
               @@operators = { "="   => :label_equals,
                               "!"   => :label_not_equals,
                               "o"   => :label_open_issues,
                               "c"   => :label_closed_issues,
                               "!*"  => :label_none,
                               "*"   => :label_all,
                               ">="   => '>=',
                               "<="   => '<=',
                               "<t+" => :label_in_less_than,
                               ">t+" => :label_in_more_than,
                               "t+"  => :label_in,
                               "t"   => :label_today,
                               "w"   => :label_this_week,
                               ">t-" => :label_less_than_ago,
                               "<t-" => :label_more_than_ago,
                               "t-"  => :label_ago,
                               "~"   => :label_contains,
                               "!~"  => :label_not_contains }
               cattr_reader :operators
               @@operators_by_filter_type = { :list => [ "=", "!" ],
                                              :list_status => [ "o", "=", "!", "c", "*" ],
                                              :list_optional => [ "=", "!", "!*", "*" ],
                                              :list_subprojects => [ "*", "!*", "=" ],
                                              :date => [ "<t+", ">t+", "t+", "t", "w", ">t-", "<t-", "t-" ],
                                              :date_past => [ ">t-", "<t-", "t-", "t", "w" ],
                                              :string => [ "=", "~", "!", "!~" ],
                                              :text => [  "~", "!~" ],
                                              :integer => [ "=", ">=", "<=", "!*", "*" ] }
               cattr_reader :operators_by_filter_type
               @@available_columns = [
                 QueryColumn.new(:project, :sortable => "#{Project.table_name}.name"),
                 QueryColumn.new(:tracker, :sortable => "#{Tracker.table_name}.position"),
                 QueryColumn.new(:status, :sortable => "#{IssueStatus.table_name}.position"),
                 QueryColumn.new(:priority, :sortable => "#{Enumeration.table_name}.position", :default_order => 'desc'),
                 QueryColumn.new(:subject, :sortable => "#{Issue.table_name}.subject"),
                 QueryColumn.new(:author),
                 QueryColumn.new(:assigned_to, :sortable => "#{User.table_name}.lastname"),
                 QueryColumn.new(:updated_on, :sortable => "#{Issue.table_name}.updated_on", :default_order => 'desc'),
                 QueryColumn.new(:category, :sortable => "#{IssueCategory.table_name}.name"),
                 QueryColumn.new(:fixed_version, :sortable => "#{Version.table_name}.effective_date", :default_order => 'desc'),
                 QueryColumn.new(:start_date, :sortable => "#{Issue.table_name}.start_date"),
                 QueryColumn.new(:due_date, :sortable => "#{Issue.table_name}.due_date"),
                 QueryColumn.new(:estimated_hours, :sortable => "#{Issue.table_name}.estimated_hours"),
                 QueryColumn.new(:done_ratio, :sortable => "#{Issue.table_name}.done_ratio"),
                 QueryColumn.new(:created_on, :sortable => "#{Issue.table_name}.created_on", :default_order => 'desc'),
               ]
               cattr_reader :available_columns
               def initialize(attributes = nil)
                 super attributes
                 self.filters ||= { 'status_id' => {:operator => "o", :values => [""]} }
                 set_language_if_valid(User.current.language)
               end
               def after_initialize
                 # Store the fact that project is nil (used in #editable_by?)
                 @is_for_all = project.nil?
               end
               def validate
                 filters.each_key do |field|
                   errors.add label_for(field), :activerecord_error_blank unless
                       # filter requires one or more values
                       (values_for(field) and !values_for(field).first.blank?) or
                       # filter doesn't require any value
                       ["o", "c", "!*", "*", "t", "w"].include? operator_for(field)
                 end if filters
               end
               def editable_by?(user)
                 return false unless user
                 # Admin can edit them all and regular users can edit their private queries
                 return true if user.admin? || (!is_public && self.user_id == user.id)
                 # Members can not edit public queries that are for all project (only admin is allowed to)
                 is_public && !@is_for_all && user.allowed_to?(:manage_public_queries, project)
               end
               def available_filters
                 return @available_filters if @available_filters
                 trackers = project.nil? ? Tracker.find(:all, :order => 'position') : project.rolled_up_trackers
                 @available_filters = { "status_id" => { :type => :list_status, :order => 1, :values => IssueStatus.find(:all, :order => 'position').collect{|s| [s.name, s.id.to_s] } },
                                        "tracker_id" => { :type => :list, :order => 2, :values => trackers.collect{|s| [s.name, s.id.to_s] } },
                                        "priority_id" => { :type => :list, :order => 3, :values => Enumeration.find(:all, :conditions => ['opt=?','IPRI'], :order => 'position').collect{|s| [s.name, s.id.to_s] } },
                                        "subject" => { :type => :text, :order => 8 },
                                        "created_on" => { :type => :date_past, :order => 9 },
                                        "updated_on" => { :type => :date_past, :order => 10 },
                                        "start_date" => { :type => :date, :order => 11 },
                                        "due_date" => { :type => :date, :order => 12 },
                                        "estimated_hours" => { :type => :integer, :order => 13 },
                                        "done_ratio" =>  { :type => :integer, :order => 14 }}
                 user_values = []
                 user_values << ["<< #{l(:label_me)} >>", "me"] if User.current.logged?
                 if project
                   user_values += project.users.sort.collect{|s| [s.name, s.id.to_s] }
                 else
                   # members of the user's projects
                   user_values += User.current.projects.collect(&:users).flatten.uniq.sort.collect{|s| [s.name, s.id.to_s] }
                 end
                 @available_filters["assigned_to_id"] = { :type => :list_optional, :order => 4, :values => user_values } unless user_values.empty?
                 @available_filters["author_id"] = { :type => :list, :order => 5, :values => user_values } unless user_values.empty?
                 if project
                   # project specific filters
                   unless @project.issue_categories.empty?
                     @available_filters["category_id"] = { :type => :list_optional, :order => 6, :values => @project.issue_categories.collect{|s| [s.name, s.id.to_s] } }
                   end
                   unless @project.versions.empty?
                     @available_filters["fixed_version_id"] = { :type => :list_optional, :order => 7, :values => @project.versions.sort.collect{|s| [s.name, s.id.to_s] } }
                   end
                   unless @project.active_children.empty?
                     @available_filters["subproject_id"] = { :type => :list_subprojects, :order => 13, :values => @project.active_children.collect{|s| [s.name, s.id.to_s] } }
                   end
                   add_custom_fields_filters(@project.all_issue_custom_fields)
                 else
                   # global filters for cross project issue list
                   add_custom_fields_filters(IssueCustomField.find(:all, :conditions => {:is_filter => true, :is_for_all => true}))
                 end
                 @available_filters
               end
               def add_filter(field, operator, values)
                 # values must be an array
                 return unless values and values.is_a? Array # and !values.first.empty?
                 # check if field is defined as an available filter
                 if available_filters.has_key? field
                   filter_options = available_filters[field]
                   # check if operator is allowed for that filter
                   #if @@operators_by_filter_type[filter_options[:type]].include? operator
                   #  allowed_values = values & ([""] + (filter_options[:values] || []).collect {|val| val[1]})
                   #  filters[field] = {:operator => operator, :values => allowed_values } if (allowed_values.first and !allowed_values.first.empty?) or ["o", "c", "!*", "*", "t"].include? operator
                   #end
                   filters[field] = {:operator => operator, :values => values }
                 end
               end
               def add_short_filter(field, expression)
                 return unless expression
                 parms = expression.scan(/^(o|c|\!|\*)?(.*)$/).first
                 add_filter field, (parms[0] || "="), [parms[1] || ""]
               end
               def has_filter?(field)
                 filters and filters[field]
               end
               def operator_for(field)
                 has_filter?(field) ? filters[field][:operator] : nil
               end
               def values_for(field)
                 has_filter?(field) ? filters[field][:values] : nil
               end
               def label_for(field)
                 label = available_filters[field][:name] if available_filters.has_key?(field)
                 label ||= field.gsub(/\_id$/, "")
               end
               def available_columns
                 return @available_columns if @available_columns
                 @available_columns = Query.available_columns
                 @available_columns += (project ?
                                         project.all_issue_custom_fields :
                                         IssueCustomField.find(:all, :conditions => {:is_for_all => true})
                                        ).collect {|cf| QueryCustomFieldColumn.new(cf) }
               end
               def columns
                 if has_default_columns?
                   available_columns.select do |c|
                     # Adds the project column by default for cross-project lists
                     Setting.issue_list_default_columns.include?(c.name.to_s) || (c.name == :project && project.nil?)
                   end
                 else
                   # preserve the column_names order
                   column_names.collect {|name| available_columns.find {|col| col.name == name}}.compact
                 end
               end
               def column_names=(names)
                 names = names.select {|n| n.is_a?(Symbol) || !n.blank? } if names
                 names = names.collect {|n| n.is_a?(Symbol) ? n : n.to_sym } if names
                 write_attribute(:column_names, names)
               end
               def has_column?(column)
                 column_names && column_names.include?(column.name)
               end
               def has_default_columns?
                 column_names.nil? || column_names.empty?
               end
               def project_statement
                 project_clauses = []
                 if project && !@project.active_children.empty?
                   ids = [project.id]
                   if has_filter?("subproject_id")
                     case operator_for("subproject_id")
                     when '='
                       # include the selected subprojects
                       ids += values_for("subproject_id").each(&:to_i)
                     when '!*'
                       # main project only
                     else
                       # all subprojects
                       ids += project.child_ids
                     end
                   elsif Setting.display_subprojects_issues?
                     ids += project.child_ids
                   end
                   project_clauses << "#{Project.table_name}.id IN (%s)" % ids.join(',')
                 elsif project
                   project_clauses << "#{Project.table_name}.id = %d" % project.id
                 end
                 project_clauses <<  Project.allowed_to_condition(User.current, :view_issues)
                 project_clauses.join(' AND ')
               end
               def statement
                 # filters clauses
                 filters_clauses = []
                 filters.each_key do |field|
                   next if field == "subproject_id"
                   v = values_for(field).clone
                   next unless v and !v.empty?
                   sql = ''
                   is_custom_filter = false
                   if field =~ /^cf_(\d+)$/
                     # custom field
                     db_table = CustomValue.table_name
                     db_field = 'value'
                     is_custom_filter = true
                     sql << "#{Issue.table_name}.id IN (SELECT #{Issue.table_name}.id FROM #{Issue.table_name} LEFT OUTER JOIN #{db_table} ON #{db_table}.customized_type='Issue' AND #{db_table}.customized_id=#{Issue.table_name}.id AND #{db_table}.custom_field_id=#{$1} WHERE "
                   else
                     # regular field
                     db_table = Issue.table_name
                     db_field = field
                     sql << '('
                   end
                   # "me" value subsitution
                   if %w(assigned_to_id author_id).include?(field)
                     v.push(User.current.logged? ? User.current.id.to_s : "0") if v.delete("me")
                   end
                   sql = sql + sql_for_field(field, v, db_table, db_field, is_custom_filter)
                   sql << ')'
                   filters_clauses << sql
                 end if filters and valid?
                 (filters_clauses << project_statement).join(' AND ')
               end
               private
               # Helper method to generate the WHERE sql for a +field+ with a +value+
               def sql_for_field(field, value, db_table, db_field, is_custom_filter)
                 sql = ''
                 case operator_for field
                 when "="
                   sql = "#{db_table}.#{db_field} IN (" + value.collect{|val| "'#{connection.quote_string(val)}'"}.join(",") + ")"
                 when "!"
                   sql = "(#{db_table}.#{db_field} IS NULL OR #{db_table}.#{db_field} NOT IN (" + value.collect{|val| "'#{connection.quote_string(val)}'"}.join(",") + "))"
                 when "!*"
                   sql = "#{db_table}.#{db_field} IS NULL"
                   sql << " OR #{db_table}.#{db_field} = ''" if is_custom_filter
                 when "*"
                   sql = "#{db_table}.#{db_field} IS NOT NULL"
                   sql << " AND #{db_table}.#{db_field} <> ''" if is_custom_filter
                 when ">="
                   sql = "#{db_table}.#{db_field} >= #{value.first.to_i}"
                 when "<="
                   sql = "#{db_table}.#{db_field} <= #{value.first.to_i}"
                 when "o"
                   sql = "#{IssueStatus.table_name}.is_closed=#{connection.quoted_false}" if field == "status_id"
                 when "c"
                   sql = "#{IssueStatus.table_name}.is_closed=#{connection.quoted_true}" if field == "status_id"
                 when ">t-"
                   sql = date_range_clause(db_table, db_field, - value.first.to_i, 0)
                 when "<t-"
                   sql = date_range_clause(db_table, db_field, nil, - value.first.to_i)
                 when "t-"
                   sql = date_range_clause(db_table, db_field, - value.first.to_i, - value.first.to_i)
                 when ">t+"
                   sql = date_range_clause(db_table, db_field, value.first.to_i, nil)
                 when "<t+"
                   sql = date_range_clause(db_table, db_field, 0, value.first.to_i)
                 when "t+"
                   sql = date_range_clause(db_table, db_field, value.first.to_i, value.first.to_i)
                 when "t"
                   sql = date_range_clause(db_table, db_field, 0, 0)
                 when "w"
                   from = l(:general_first_day_of_week) == '7' ?
                   # week starts on sunday
                   ((Date.today.cwday == 7) ? Time.now.at_beginning_of_day : Time.now.at_beginning_of_week - 1.day) :
                     # week starts on monday (Rails default)
                     Time.now.at_beginning_of_week
                   sql = "#{db_table}.#{db_field} BETWEEN '%s' AND '%s'" % [connection.quoted_date(from), connection.quoted_date(from + 7.days)]
                 when "~"
-                  sql = "#{db_table}.#{db_field} LIKE '%#{connection.quote_string(value.first)}%'"
+                  sql = "LOWER(#{db_table}.#{db_field}) LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
                 when "!~"
-                  sql = "#{db_table}.#{db_field} NOT LIKE '%#{connection.quote_string(value.first)}%'"
+                  sql = "LOWER(#{db_table}.#{db_field}) NOT LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
                 end
                 return sql
               end
               def add_custom_fields_filters(custom_fields)
                 @available_filters ||= {}
                 custom_fields.select(&:is_filter?).each do |field|
                   case field.field_format
                   when "text"
                     options = { :type => :text, :order => 20 }
                   when "list"
                     options = { :type => :list_optional, :values => field.possible_values, :order => 20}
                   when "date"
                     options = { :type => :date, :order => 20 }
                   when "bool"
                     options = { :type => :list, :values => [[l(:general_text_yes), "1"], [l(:general_text_no), "0"]], :order => 20 }
                   else
                     options = { :type => :string, :order => 20 }
                   end
                   @available_filters["cf_#{field.id}"] = options.merge({ :name => field.name })
                 end
               end
               # Returns a SQL clause for a date or datetime field.
               def date_range_clause(table, field, from, to)
                 s = []
                 if from
                   s << ("#{table}.#{field} > '%s'" % [connection.quoted_date((Date.yesterday + from).to_time.end_of_day)])
                 end
                 if to
                   s << ("#{table}.#{field} <= '%s'" % [connection.quoted_date((Date.today + to).to_time.end_of_day)])
                 end
                 s.join(' AND ')
               end
             end

app/views/common/feed.atom.rxml +1 -1

             xml.instruct!
             xml.feed "xmlns" => "http://www.w3.org/2005/Atom" do
               xml.title   truncate_single_line(@title, 100)
               xml.link    "rel" => "self", "href" => url_for(params.merge(:only_path => false))
               xml.link    "rel" => "alternate", "href" => url_for(params.merge(:only_path => false, :format => nil, :key => nil))
               xml.id      url_for(:controller => 'welcome', :only_path => false)
               xml.updated((@items.first ? @items.first.event_datetime : Time.now).xmlschema)
               xml.author  { xml.name "#{Setting.app_title}" }
               xml.generator(:uri => Redmine::Info.url) { xml.text! Redmine::Info.app_name; }
               @items.each do |item|
                 xml.entry do
                   url = url_for(item.event_url(:only_path => false))
                   if @project
                     xml.title truncate_single_line(item.event_title, 100)
                   else
                     xml.title truncate_single_line("#{item.project} - #{item.event_title}", 100)
                   end
                   xml.link "rel" => "alternate", "href" => url
                   xml.id url
                   xml.updated item.event_datetime.xmlschema
                   author = item.event_author if item.respond_to?(:event_author)
                   xml.author do
                     xml.name(author)
                     xml.email(author.mail) if author.is_a?(User) && !author.mail.blank? && !author.pref.hide_mail
                   end if author
                   xml.content "type" => "html" do
-                    xml.text! textilizable(item.event_description)
+                    xml.text! textilizable(item, :event_description, :only_path => false)
                   end
                 end
               end
             end

app/views/issues/changes.rxml +1 -1

             xml.instruct!
             xml.feed "xmlns" => "http://www.w3.org/2005/Atom" do
               xml.title   @title
               xml.link    "rel" => "self", "href" => url_for(:format => 'atom', :key => User.current.rss_key, :only_path => false)
               xml.link    "rel" => "alternate", "href" => home_url(:only_path => false)
               xml.id      url_for(:controller => 'welcome', :only_path => false)
               xml.updated((@journals.first ? @journals.first.event_datetime : Time.now).xmlschema)
               xml.author  { xml.name "#{Setting.app_title}" }
               @journals.each do |change|
                 issue = change.issue
                 xml.entry do
                   xml.title   "#{issue.project.name} - #{issue.tracker.name} ##{issue.id}: #{issue.subject}"
                   xml.link    "rel" => "alternate", "href" => url_for(:controller => 'issues' , :action => 'show', :id => issue, :only_path => false)
                   xml.id      url_for(:controller => 'issues' , :action => 'show', :id => issue, :journal_id => change, :only_path => false)
                   xml.updated change.created_on.xmlschema
                   xml.author do
                     xml.name change.user.name
                     xml.email(change.user.mail) if change.user.is_a?(User) && !change.user.mail.blank? && !change.user.pref.hide_mail
                   end
                   xml.content "type" => "html" do
                     xml.text! '<ul>'
                     change.details.each do |detail|
                       xml.text! '<li>' + show_detail(detail, false) + '</li>'
                     end
                     xml.text! '</ul>'
-                    xml.text! textilizable(change.notes) unless change.notes.blank?
+                    xml.text! textilizable(change, :notes, :only_path => false) unless change.notes.blank?
                   end
                 end
               end
             end

doc/CHANGELOG +3 -1

             == Redmine changelog
             Redmine - project management software
             Copyright (C) 2006-2009  Jean-Philippe Lang
             http://www.redmine.org/
             == 2009-xx-xx v0.8.5
             * Incoming mail handler : Allow spaces between keywords and colon
             * Do not require a non-word character after a comma in Redmine links
             * Include issue hyperlinks in reminder emails
             * Fixed: 500 Internal Server Error is raised if add an empty comment to the news
-            * Fixes: Atom links for wiki pages are not correct
+            * Fixed: Atom links for wiki pages are not correct
             * Fixed: Atom feeds leak email address
+            * Fixed: Case sensitivity in Issue filtering
+            * Fixed: When reading RSS feed, the inline-embedded images are not properly shown
             == 2009-05-17 v0.8.4
             * Allow textile mailto links
             * Fixed: memory consumption when uploading file
             * Fixed: Mercurial integration doesn't work if Redmine is installed in folder path containing space
             * Fixed: an error is raised when no tab is available on project settings
             * Fixed: insert image macro corrupts urls with excalamation marks
             * Fixed: error on cross-project gantt PNG export
             * Fixed: self and alternate links in atom feeds do not respect Atom specs
             * Fixed: accept any svn tunnel scheme in repository URL
             * Fixed: issues/show should accept user's rss key
             * Fixed: consistency of custom fields display on the issue detail view
             * Fixed: wiki comments length validation is missing
             * Fixed: weak autologin token generation algorithm causes duplicate tokens
             == 2009-04-05 v0.8.3
             * Separate project field and subject in cross-project issue view
             * Ability to set language for redmine:load_default_data task using REDMINE_LANG environment variable
             * Rescue Redmine::DefaultData::DataAlreadyLoaded in redmine:load_default_data task
             * CSS classes to highlight own and assigned issues
             * Hide "New file" link on wiki pages from printing
             * Flush buffer when asking for language in redmine:load_default_data task
             * Minimum project identifier length set to 1
             * Include headers so that emails don't trigger vacation auto-responders
             * Fixed: Time entries csv export links for all projects are malformed
             * Fixed: Files without Version aren't visible in the Activity page
             * Fixed: Commit logs are centered in the repo browser
             * Fixed: News summary field content is not searchable
             * Fixed: Journal#save has a wrong signature
             * Fixed: Email footer signature convention
             * Fixed: Timelog report do not show time for non-versioned issues
             == 2009-03-07 v0.8.2
             * Send an email to the user when an administrator activates a registered user
             * Strip keywords from received email body
             * Footer updated to 2009
             * Show RSS-link even when no issues is found
             * One click filter action in activity view
             * Clickable/linkable line #'s while browsing the repo or viewing a file
             * Links to versions on files list
             * Added request and controller objects to the hooks by default
             * Fixed: exporting an issue with attachments to PDF raises an error
             * Fixed: "too few arguments" error may occur on activerecord error translation
             * Fixed: "Default columns Displayed on the Issues list" setting is not easy to read
             * Fixed: visited links to closed tickets are not striked through with IE6
             * Fixed: MailHandler#plain_text_body returns nil if there was nothing to strip
             * Fixed: MailHandler raises an error when processing an email without From header
             == 2009-02-15 v0.8.1
             * Select watchers on new issue form
             * Issue description is no longer a required field
             * Files module: ability to add files without version
             * Jump to the current tab when using the project quick-jump combo
             * Display a warning if some attachments were not saved
             * Import custom fields values from emails on issue creation
             * Show view/annotate/download links on entry and annotate views
             * Admin Info Screen: Display if plugin assets directory is writable
             * Adds a 'Create and continue' button on the new issue form
             * IMAP: add options to move received emails
             * Do not show Category field when categories are not defined
             * Lower the project identifier limit to a minimum of two characters
             * Add "closed" html class to closed entries in issue list
             * Fixed: broken redirect URL on login failure
             * Fixed: Deleted files are shown when using Darcs
             * Fixed: Darcs adapter works on Win32 only
             * Fixed: syntax highlight doesn't appear in new ticket preview
             * Fixed: email notification for changes I make still occurs when running Repository.fetch_changesets
             * Fixed: no error is raised when entering invalid hours on the issue update form
             * Fixed: Details time log report CSV export doesn't honour date format from settings
             * Fixed: invalid css classes on issue details
             * Fixed: Trac importer creates duplicate custom values
             * Fixed: inline attached image should not match partial filename
             == 2008-12-30 v0.8.0
             * Setting added in order to limit the number of diff lines that should be displayed
             * Makes logged-in username in topbar linking to
             * Mail handler: strip tags when receiving a html-only email
             * Mail handler: add watchers before sending notification
             * Adds a css class (overdue) to overdue issues on issue lists and detail views
             * Fixed: project activity truncated after viewing user's activity
             * Fixed: email address entered for password recovery shouldn't be case-sensitive
             * Fixed: default flag removed when editing a default enumeration
             * Fixed: default category ignored when adding a document
             * Fixed: error on repository user mapping when a repository username is blank
             * Fixed: Firefox cuts off large diffs
             * Fixed: CVS browser should not show dead revisions (deleted files)
             * Fixed: escape double-quotes in image titles
             * Fixed: escape textarea content when editing a issue note
             * Fixed: JS error on context menu with IE
             * Fixed: bold syntax around single character in series doesn't work
             * Fixed several XSS vulnerabilities
             * Fixed a SQL injection vulnerability
             == 2008-12-07 v0.8.0-rc1
             * Wiki page protection
             * Wiki page hierarchy. Parent page can be assigned on the Rename screen
             * Adds support for issue creation via email
             * Adds support for free ticket filtering and custom queries on Gantt chart and calendar
             * Cross-project search
             * Ability to search a project and its subprojects
             * Ability to search the projects the user belongs to
             * Adds custom fields on time entries
             * Adds boolean and list custom fields for time entries as criteria on time report
             * Cross-project time reports
             * Display latest user's activity on account/show view
             * Show last connexion time on user's page
             * Obfuscates email address on user's account page using javascript
             * wiki TOC rendered as an unordered list
             * Adds the ability to search for a user on the administration users list
             * Adds the ability to search for a project name or identifier on the administration projects list
             * Redirect user to the previous page after logging in
             * Adds a permission 'view wiki edits' so that wiki history can be hidden to certain users
             * Adds permissions for viewing the watcher list and adding new watchers on the issue detail view
             * Adds permissions to let users edit and/or delete their messages
             * Link to activity view when displaying dates
             * Hide Redmine version in atom feeds and pdf properties
             * Maps repository users to Redmine users. Users with same username or email are automatically mapped. Mapping can be manually adjusted in repository settings. Multiple usernames can be mapped to the same Redmine user.
             * Sort users by their display names so that user dropdown lists are sorted alphabetically
             * Adds estimated hours to issue filters
             * Switch order of current and previous revisions in side-by-side diff
             * Render the commit changes list as a tree
             * Adds watch/unwatch functionality at forum topic level
             * When moving an issue to another project, reassign it to the category with same name if any
             * Adds child_pages macro for wiki pages
             * Use GET instead of POST on roadmap (#718), gantt and calendar forms
             * Search engine: display total results count and count by result type
             * Email delivery configuration moved to an unversioned YAML file (config/email.yml, see the sample file)
             * Adds icons on search results
             * Adds 'Edit' link on account/show for admin users
             * Adds Lock/Unlock/Activate link on user edit screen
             * Adds user count in status drop down on admin user list
             * Adds multi-levels blockquotes support by using > at the beginning of lines
             * Adds a Reply link to each issue note
             * Adds plain text only option for mail notifications
             * Gravatar support for issue detail, user grid, and activity stream (disabled by default)
             * Adds 'Delete wiki pages attachments' permission
             * Show the most recent file when displaying an inline image
             * Makes permission screens localized
             * AuthSource list: display associated users count and disable 'Delete' buton if any
             * Make the 'duplicates of' relation asymmetric
             * Adds username to the password reminder email
             * Adds links to forum messages using message#id syntax
             * Allow same name for custom fields on different object types
             * One-click bulk edition using the issue list context menu within the same project
             * Adds support for commit logs reencoding to UTF-8 before insertion in the database. Source encoding of commit logs can be selected in Application settings -> Repositories.
             * Adds checkboxes toggle links on permissions report
             * Adds Trac-Like anchors on wiki headings
             * Adds support for wiki links with anchor
             * Adds category to the issue context menu
             * Adds a workflow overview screen
             * Appends the filename to the attachment url so that clients that ignore content-disposition http header get the real filename
             * Dots allowed in custom field name
             * Adds posts quoting functionality
             * Adds an option to generate sequential project identifiers
             * Adds mailto link on the user administration list
             * Ability to remove enumerations (activities, priorities, document categories) that are in use. Associated objects can be reassigned to another value
             * Gantt chart: display issues that don't have a due date if they are assigned to a version with a date
             * Change projects homepage limit to 255 chars
             * Improved on-the-fly account creation. If some attributes are missing (eg. not present in the LDAP) or are invalid, the registration form is displayed so that the user is able to fill or fix these attributes
             * Adds "please select" to activity select box if no activity is set as default
             * Do not silently ignore timelog validation failure on issue edit
             * Adds a rake task to send reminder emails
             * Allow empty cells in wiki tables
             * Makes wiki text formatter pluggable
             * Adds back textile acronyms support
             * Remove pre tag attributes
             * Plugin hooks
             * Pluggable admin menu
             * Plugins can provide activity content
             * Moves plugin list to its own administration menu item
             * Adds url and author_url plugin attributes
             * Adds Plugin#requires_redmine method so that plugin compatibility can be checked against current Redmine version
             * Adds atom feed on time entries details
             * Adds project name to issues feed title
             * Adds a css class on menu items in order to apply item specific styles (eg. icons)
             * Adds a Redmine plugin generators
             * Adds timelog link to the issue context menu
             * Adds links to the user page on various views
             * Turkish translation by Ismail Sezen
             * Catalan translation
             * Vietnamese translation
             * Slovak translation
             * Better naming of activity feed if only one kind of event is displayed
             * Enable syntax highlight on issues, messages and news
             * Add target version to the issue list context menu
             * Hide 'Target version' filter if no version is defined
             * Add filters on cross-project issue list for custom fields marked as 'For all projects'
             * Turn ftp urls into links
             * Hiding the View Differences button when a wiki page's history only has one version
             * Messages on a Board can now be sorted by the number of replies
             * Adds a class ('me') to events of the activity view created by current user
             * Strip pre/code tags content from activity view events
             * Display issue notes in the activity view
             * Adds links to changesets atom feed on repository browser
             * Track project and tracker changes in issue history
             * Adds anchor to atom feed messages links
             * Adds a key in lang files to set the decimal separator (point or comma) in csv exports
             * Makes importer work with Trac 0.8.x
             * Upgraded to Prototype 1.6.0.1
             * File viewer for attached text files
             * Menu mapper: add support for :before, :after and :last options to #push method and add #delete method
             * Removed inconsistent revision numbers on diff view
             * CVS: add support for modules names with spaces
             * Log the user in after registration if account activation is not needed
             * Mercurial adapter improvements
             * Trac importer: read session_attribute table to find user's email and real name
             * Ability to disable unused SCM adapters in application settings
             * Adds Filesystem adapter
             * Clear changesets and changes with raw sql when deleting a repository for performance
             * Redmine.pm now uses the 'commit access' permission defined in Redmine
             * Reposman can create any type of scm (--scm option)
             * Reposman creates a repository if the 'repository' module is enabled at project level only
             * Display svn properties in the browser, svn >= 1.5.0 only
             * Reduces memory usage when importing large git repositories
             * Wider SVG graphs in repository stats
             * SubversionAdapter#entries performance improvement
             * SCM browser: ability to download raw unified diffs
             * More detailed error message in log when scm command fails
             * Adds support for file viewing with Darcs 2.0+
             * Check that git changeset is not in the database before creating it
             * Unified diff viewer for attached files with .patch or .diff extension
             * File size display with Bazaar repositories
             * Git adapter: use commit time instead of author time
             * Prettier url for changesets
             * Makes changes link to entries on the revision view
             * Adds a field on the repository view to browse at specific revision
             * Adds new projects atom feed
             * Added rake tasks to generate rcov code coverage reports
             * Add Redcloth's :block_markdown_rule to allow horizontal rules in wiki
             * Show the project hierarchy in the drop down list for new membership on user administration screen
             * Split user edit screen into tabs
             * Renames bundled RedCloth to RedCloth3 to avoid RedCloth 4 to be loaded instead
             * Fixed: Roadmap crashes when a version has a due date > 2037
             * Fixed: invalid effective date (eg. 99999-01-01) causes an error on version edition screen
             * Fixed: login filter providing incorrect back_url for Redmine installed in sub-directory
             * Fixed: logtime entry duplicated when edited from parent project
             * Fixed: wrong digest for text files under Windows
             * Fixed: associated revisions are displayed in wrong order on issue view
             * Fixed: Git Adapter date parsing ignores timezone
             * Fixed: Printing long roadmap doesn't split across pages
             * Fixes custom fields display order at several places
             * Fixed: urls containing @ are parsed as email adress by the wiki formatter
             * Fixed date filters accuracy with SQLite
             * Fixed: tokens not escaped in highlight_tokens regexp
             * Fixed Bazaar shared repository browsing
             * Fixes platform determination under JRuby
             * Fixed: Estimated time in issue's journal should be rounded to two decimals
             * Fixed: 'search titles only' box ignored after one search is done on titles only
             * Fixed: non-ASCII subversion path can't be displayed
             * Fixed: Inline images don't work if file name has upper case letters or if image is in BMP format
             * Fixed: document listing shows on "my page" when viewing documents is disabled for the role
             * Fixed: Latest news appear on the homepage for projects with the News module disabled
             * Fixed: cross-project issue list should not show issues of projects for which the issue tracking module was disabled
             * Fixed: the default status is lost when reordering issue statuses
             * Fixes error with Postgresql and non-UTF8 commit logs
             * Fixed: textile footnotes no longer work
             * Fixed: http links containing parentheses fail to reder correctly
             * Fixed: GitAdapter#get_rev should use current branch instead of hardwiring master
             == 2008-07-06 v0.7.3
             * Allow dot in firstnames and lastnames
             * Add project name to cross-project Atom feeds
             * Encoding set to utf8 in example database.yml
             * HTML titles on forums related views
             * Fixed: various XSS vulnerabilities
             * Fixed: Entourage (and some old client) fails to correctly render notification styles
             * Fixed: Fixed: timelog redirects inappropriately when :back_url is blank
             * Fixed: wrong relative paths to images in wiki_syntax.html
             == 2008-06-15 v0.7.2
             * "New Project" link on Projects page
             * Links to repository directories on the repo browser
             * Move status to front in Activity View
             * Remove edit step from Status context menu
             * Fixed: No way to do textile horizontal rule
             * Fixed: Repository: View differences doesn't work
             * Fixed: attachement's name maybe invalid.
             * Fixed: Error when creating a new issue
             * Fixed: NoMethodError on @available_filters.has_key?
             * Fixed: Check All / Uncheck All in Email Settings
             * Fixed: "View differences" of one file at /repositories/revision/ fails
             * Fixed: Column width in "my page"
             * Fixed: private subprojects are listed on Issues view
             * Fixed: Textile: bold, italics, underline, etc... not working after parentheses
             * Fixed: Update issue form: comment field from log time end out of screen
             * Fixed: Editing role: "issue can be assigned to this role" out of box
             * Fixed: Unable use angular braces after include word
             * Fixed: Using '*' as keyword for repository referencing keywords doesn't work
             * Fixed: Subversion repository "View differences" on each file rise ERROR
             * Fixed: View differences for individual file of a changeset fails if the repository URL doesn't point to the repository root
             * Fixed: It is possible to lock out the last admin account
             * Fixed: Wikis are viewable for anonymous users on public projects, despite not granting access
             * Fixed: Issue number display clipped on 'my issues'
             * Fixed: Roadmap version list links not carrying state
             * Fixed: Log Time fieldset in IssueController#edit doesn't set default Activity as default
             * Fixed: git's "get_rev" API should use repo's current branch instead of hardwiring "master"
             * Fixed: browser's language subcodes ignored
             * Fixed: Error on project selection with numeric (only) identifier.
             * Fixed: Link to PDF doesn't work after creating new issue
             * Fixed: "Replies" should not be shown on forum threads that are locked
             * Fixed: SVN errors lead to svn username/password being displayed to end users (security issue)
             * Fixed: http links containing hashes don't display correct
             * Fixed: Allow ampersands in Enumeration names
             * Fixed: Atom link on saved query does not include query_id
             * Fixed: Logtime info lost when there's an error updating an issue
             * Fixed: TOC does not parse colorization markups
             * Fixed: CVS: add support for modules names with spaces
             * Fixed: Bad rendering on projects/add
             * Fixed: exception when viewing differences on cvs
             * Fixed: export issue to pdf will messup when use Chinese language
             * Fixed: Redmine::Scm::Adapters::GitAdapter#get_rev ignored GIT_BIN constant
             * Fixed: Adding non-ASCII new issue type in the New Issue page have encoding error using IE
             * Fixed: Importing from trac : some wiki links are messed
             * Fixed: Incorrect weekend definition in Hebrew calendar locale
             * Fixed: Atom feeds don't provide author section for repository revisions
             * Fixed: In Activity views, changesets titles can be multiline while they should not
             * Fixed: Ignore unreadable subversion directories (read disabled using authz)
             * Fixed: lib/SVG/Graph/Graph.rb can't externalize stylesheets
             * Fixed: Close statement handler in Redmine.pm
             == 2008-05-04 v0.7.1
             * Thai translation added (Gampol Thitinilnithi)
             * Translations updates
             * Escape HTML comment tags
             * Prevent "can't convert nil into String" error when :sort_order param is not present
             * Fixed: Updating tickets add a time log with zero hours
             * Fixed: private subprojects names are revealed on the project overview
             * Fixed: Search for target version of "none" fails with postgres 8.3
             * Fixed: Home, Logout, Login links shouldn't be absolute links
             * Fixed: 'Latest projects' box on the welcome screen should be hidden if there are no projects
             * Fixed: error when using upcase language name in coderay
             * Fixed: error on Trac import when :due attribute is nil
             == 2008-04-28 v0.7.0
             * Forces Redmine to use rails 2.0.2 gem when vendor/rails is not present
             * Queries can be marked as 'For all projects'. Such queries will be available on all projects and on the global issue list.
             * Add predefined date ranges to the time report
             * Time report can be done at issue level
             * Various timelog report enhancements
             * Accept the following formats for "hours" field: 1h, 1 h, 1 hour, 2 hours, 30m, 30min, 1h30, 1h30m, 1:30
             * Display the context menu above and/or to the left of the click if needed
             * Make the admin project files list sortable
             * Mercurial: display working directory files sizes unless browsing a specific revision
             * Preserve status filter and page number when using lock/unlock/activate links on the users list
             * Redmine.pm support for LDAP authentication
             * Better error message and AR errors in log for failed LDAP on-the-fly user creation
             * Redirected user to where he is coming from after logging hours
             * Warn user that subprojects are also deleted when deleting a project
             * Include subprojects versions on calendar and gantt
             * Notify project members when a message is posted if they want to receive notifications
             * Fixed: Feed content limit setting has no effect
             * Fixed: Priorities not ordered when displayed as a filter in issue list
             * Fixed: can not display attached images inline in message replies
             * Fixed: Boards are not deleted when project is deleted
             * Fixed: trying to preview a new issue raises an exception with postgresql
             * Fixed: single file 'View difference' links do not work because of duplicate slashes in url
             * Fixed: inline image not displayed when including a wiki page
             * Fixed: CVS duplicate key violation
             * Fixed: ActiveRecord::StaleObjectError exception on closing a set of circular duplicate issues
             * Fixed: custom field filters behaviour
             * Fixed: Postgresql 8.3 compatibility
             * Fixed: Links to repository directories don't work
             == 2008-03-29 v0.7.0-rc1
             * Overall activity view and feed added, link is available on the project list
             * Git VCS support
             * Rails 2.0 sessions cookie store compatibility
             * Use project identifiers in urls instead of ids
             * Default configuration data can now be loaded from the administration screen
             * Administration settings screen split to tabs (email notifications options moved to 'Settings')
             * Project description is now unlimited and optional
             * Wiki annotate view
             * Escape HTML tag in textile content
             * Add Redmine links to documents, versions, attachments and repository files
             * New setting to specify how many objects should be displayed on paginated lists. There are 2 ways to select a set of issues on the issue list:
                 * by using checkbox and/or the little pencil that will select/unselect all issues
                 * by clicking on the rows (but not on the links), Ctrl and Shift keys can be used to select multiple issues
             * Context menu disabled on links so that the default context menu of the browser is displayed when right-clicking on a link (click anywhere else on the row to display the context menu)
             * User display format is now configurable in administration settings
             * Issue list now supports bulk edit/move/delete (for a set of issues that belong to the same project)
             * Merged 'change status', 'edit issue' and 'add note' actions:
                 * Users with 'edit issues' permission can now update any property including custom fields when adding a note or changing the status
                 * 'Change issue status' permission removed. To change an issue status, a user just needs to have either 'Edit' or 'Add note' permissions and some workflow transitions allowed
             * Details by assignees on issue summary view
             * 'New issue' link in the main menu (accesskey 7). The drop-down lists to add an issue on the project overview and the issue list are removed
             * Change status select box default to current status
             * Preview for issue notes, news and messages
             * Optional description for attachments
             * 'Fixed version' label changed to 'Target version'
             * Let the user choose when deleting issues with reported hours to:
                 * delete the hours
                 * assign the hours to the project
                 * reassign the hours to another issue
             * Date range filter and pagination on time entries detail view
             * Propagate time tracking to the parent project
             * Switch added on the project activity view to include subprojects
             * Display total estimated and spent hours on the version detail view
             * Weekly time tracking block for 'My page'
             * Permissions to edit time entries
             * Include subprojects on the issue list, calendar, gantt and timelog by default (can be turned off is administration settings)
             * Roadmap enhancements (separate related issues from wiki contents, leading h1 in version wiki pages is hidden, smaller wiki headings)
             * Make versions with same date sorted by name
             * Allow issue list to be sorted by target version
             * Related changesets messages displayed on the issue details view
             * Create a journal and send an email when an issue is closed by commit
             * Add 'Author' to the available columns for the issue list
             * More appropriate default sort order on sortable columns
             * Add issue subject to the time entries view and issue subject, description and tracker to the csv export
             * Permissions to edit issue notes
             * Display date/time instead of date on files list
             * Do not show Roadmap menu item if the project doesn't define any versions
             * Allow longer version names (60 chars)
             * Ability to copy an existing workflow when creating a new role
             * Display custom fields in two columns on the issue form
             * Added 'estimated time' in the csv export of the issue list
             * Display the last 30 days on the activity view rather than the current month (number of days can be configured in the application settings)
             * Setting for whether new projects should be public by default
             * User preference to choose how comments/replies are displayed: in chronological or reverse chronological order
             * Added default value for custom fields
             * Added tabindex property on wiki toolbar buttons (to easily move from field to field using the tab key)
             * Redirect to issue page after creating a new issue
             * Wiki toolbar improvements (mainly for Firefox)
             * Display wiki syntax quick ref link on all wiki textareas
             * Display links to Atom feeds
             * Breadcrumb nav for the forums
             * Show replies when choosing to display messages in the activity
             * Added 'include' macro to include another wiki page
             * RedmineWikiFormatting page available as a static HTML file locally
             * Wrap diff content
             * Strip out email address from authors in repository screens
             * Highlight the current item of the main menu
             * Added simple syntax highlighters for php and java languages
             * Do not show empty diffs
             * Show explicit error message when the scm command failed (eg. when svn binary is not available)
             * Lithuanian translation added (Sergej Jegorov)
             * Ukrainan translation added (Natalia Konovka & Mykhaylo Sorochan)
             * Danish translation added (Mads Vestergaard)
             * Added i18n support to the jstoolbar and various settings screen
             * RedCloth's glyphs no longer user
             * New icons for the wiki toolbar (from http://www.famfamfam.com/lab/icons/silk/)
             * The following menus can now be extended by plugins: top_menu, account_menu, application_menu
             * Added a simple rake task to fetch changesets from the repositories: rake redmine:fetch_changesets
             * Remove hardcoded "Redmine" strings in account related emails and use application title instead
             * Mantis importer preserve bug ids
             * Trac importer: Trac guide wiki pages skipped
             * Trac importer: wiki attachments migration added
             * Trac importer: support database schema for Trac migration
             * Trac importer: support CamelCase links
             * Removes the Redmine version from the footer (can be viewed on admin -> info)
             * Rescue and display an error message when trying to delete a role that is in use
             * Add various 'X-Redmine' headers to email notifications: X-Redmine-Host, X-Redmine-Site, X-Redmine-Project, X-Redmine-Issue-Id, -Author, -Assignee, X-Redmine-Topic-Id
             * Add "--encoding utf8" option to the Mercurial "hg log" command in order to get utf8 encoded commit logs
             * Fixed: Gantt and calendar not properly refreshed (fragment caching removed)
             * Fixed: Textile image with style attribute cause internal server error
             * Fixed: wiki TOC not rendered properly when used in an issue or document description
             * Fixed: 'has already been taken' error message on username and email fields if left empty
             * Fixed: non-ascii attachement filename with IE
             * Fixed: wrong url for wiki syntax pop-up when Redmine urls are prefixed
             * Fixed: search for all words doesn't work
             * Fixed: Do not show sticky and locked checkboxes when replying to a message
             * Fixed: Mantis importer: do not duplicate Mantis username in firstname and lastname if realname is blank
             * Fixed: Date custom fields not displayed as specified in application settings
             * Fixed: titles not escaped in the activity view
             * Fixed: issue queries can not use custom fields marked as 'for all projects' in a project context
             * Fixed: on calendar, gantt and in the tracker filter on the issue list, only active trackers of the project (and its sub projects) should be available
             * Fixed: locked users should not receive email notifications
             * Fixed: custom field selection is not saved when unchecking them all on project settings
             * Fixed: can not lock a topic when creating it
             * Fixed: Incorrect filtering for unset values when using 'is not' filter
             * Fixed: PostgreSQL issues_seq_id not updated when using Trac importer
             * Fixed: ajax pagination does not scroll up
             * Fixed: error when uploading a file with no content-type specified by the browser
             * Fixed: wiki and changeset links not displayed when previewing issue description or notes
             * Fixed: 'LdapError: no bind result' error when authenticating
             * Fixed: 'LdapError: invalid binding information' when no username/password are set on the LDAP account
             * Fixed: CVS repository doesn't work if port is used in the url
             * Fixed: Email notifications: host name is missing in generated links
             * Fixed: Email notifications: referenced changesets, wiki pages, attachments... are not turned into links
             * Fixed: Do not clear issue relations when moving an issue to another project if cross-project issue relations are allowed
             * Fixed: "undefined method 'textilizable'" error on email notification when running Repository#fetch_changesets from the console
             * Fixed: Do not send an email with no recipient, cc or bcc
             * Fixed: fetch_changesets fails on commit comments that close 2 duplicates issues.
             * Fixed: Mercurial browsing under unix-like os and for directory depth > 2
             * Fixed: Wiki links with pipe can not be used in wiki tables
             * Fixed: migrate_from_trac doesn't import timestamps of wiki and tickets
             * Fixed: when bulk editing, setting "Assigned to" to "nobody" causes an sql error with Postgresql
             == 2008-03-12 v0.6.4
             * Fixed: private projects name are displayed on account/show even if the current user doesn't have access to these private projects
             * Fixed: potential LDAP authentication security flaw
             * Fixed: context submenus on the issue list don't show up with IE6.
             * Fixed: Themes are not applied with Rails 2.0
             * Fixed: crash when fetching Mercurial changesets if changeset[:files] is nil
             * Fixed: Mercurial repository browsing
             * Fixed: undefined local variable or method 'log' in CvsAdapter when a cvs command fails
             * Fixed: not null constraints not removed with Postgresql
             * Doctype set to transitional
             == 2007-12-18 v0.6.3
             * Fixed: upload doesn't work in 'Files' section
             == 2007-12-16 v0.6.2
             * Search engine: issue custom fields can now be searched
             * News comments are now textilized
             * Updated Japanese translation (Satoru Kurashiki)
             * Updated Chinese translation (Shortie Lo)
             * Fixed Rails 2.0 compatibility bugs:
               * Unable to create a wiki
               * Gantt and calendar error
               * Trac importer error (readonly? is defined by ActiveRecord)
             * Fixed: 'assigned to me' filter broken
             * Fixed: crash when validation fails on issue edition with no custom fields
             * Fixed: reposman "can't find group" error
             * Fixed: 'LDAP account password is too long' error when leaving the field empty on creation
             * Fixed: empty lines when displaying repository files with Windows style eol
             * Fixed: missing body closing tag in repository annotate and entry views
             == 2007-12-10 v0.6.1
             * Rails 2.0 compatibility
             * Custom fields can now be displayed as columns on the issue list
             * Added version details view (accessible from the roadmap)
             * Roadmap: more accurate completion percentage calculation (done ratio of open issues is now taken into account)
             * Added per-project tracker selection. Trackers can be selected on project settings
             * Anonymous users can now be allowed to create, edit, comment issues, comment news and post messages in the forums
             * Forums: messages can now be edited/deleted (explicit permissions need to be given)
             * Forums: topics can be locked so that no reply can be added
             * Forums: topics can be marked as sticky so that they always appear at the top of the list
             * Forums: attachments can now be added to replies
             * Added time zone support
             * Added a setting to choose the account activation strategy (available in application settings)
             * Added 'Classic' theme (inspired from the v0.51 design)
             * Added an alternate theme which provides issue list colorization based on issues priority
             * Added Bazaar SCM adapter
             * Added Annotate/Blame view in the repository browser (except for Darcs SCM)
             * Diff style (inline or side by side) automatically saved as a user preference
             * Added issues status changes on the activity view (by Cyril Mougel)
             * Added forums topics on the activity view (disabled by default)
             * Added an option on 'My account' for users who don't want to be notified of changes that they make
             * Trac importer now supports mysql and postgresql databases
             * Trac importer improvements (by Mat Trudel)
             * 'fixed version' field can now be displayed on the issue list
             * Added a couple of new formats for the 'date format' setting
             * Added Traditional Chinese translation (by Shortie Lo)
             * Added Russian translation (iGor kMeta)
             * Project name format limitation removed (name can now contain any character)
             * Project identifier maximum length changed from 12 to 20
             * Changed the maximum length of LDAP account to 255 characters
             * Removed the 12 characters limit on passwords
             * Added wiki macros support
             * Performance improvement on workflow setup screen
             * More detailed html title on several views
             * Custom fields can now be reordered
             * Search engine: search can be restricted to an exact phrase by using quotation marks
             * Added custom fields marked as 'For all projects' to the csv export of the cross project issue list
             * Email notifications are now sent as Blind carbon copy by default
             * Fixed: all members (including non active) should be deleted when deleting a project
             * Fixed: Error on wiki syntax link (accessible from wiki/edit)
             * Fixed: 'quick jump to a revision' form on the revisions list
             * Fixed: error on admin/info if there's more than 1 plugin installed
             * Fixed: svn or ldap password can be found in clear text in the html source in editing mode
             * Fixed: 'Assigned to' drop down list is not sorted
             * Fixed: 'View all issues' link doesn't work on issues/show
             * Fixed: error on account/register when validation fails
             * Fixed: Error when displaying the issue list if a float custom field is marked as 'used as filter'
             * Fixed: Mercurial adapter breaks on missing :files entry in changeset hash (James Britt)
             * Fixed: Wrong feed URLs on the home page
             * Fixed: Update of time entry fails when the issue has been moved to an other project
             * Fixed: Error when moving an issue without changing its tracker (Postgresql)
             * Fixed: Changes not recorded when using :pserver string (CVS adapter)
             * Fixed: admin should be able to move issues to any project
             * Fixed: adding an attachment is not possible when changing the status of an issue
             * Fixed: No mime-types in documents/files downloading
             * Fixed: error when sorting the messages if there's only one board for the project
             * Fixed: 'me' doesn't appear in the drop down filters on a project issue list.
             == 2007-11-04 v0.6.0
             * Permission model refactoring.
             * Permissions: there are now 2 builtin roles that can be used to specify permissions given to other users than members of projects
             * Permissions: some permissions (eg. browse the repository) can be removed for certain roles
             * Permissions: modules (eg. issue tracking, news, documents...) can be enabled/disabled at project level
             * Added Mantis and Trac importers
             * New application layout
             * Added "Bulk edit" functionality on the issue list
             * More flexible mail notifications settings at user level
             * Added AJAX based context menu on the project issue list that provide shortcuts for editing, re-assigning, changing the status or the priority, moving or deleting an issue
             * Added the hability to copy an issue. It can be done from the "issue/show" view or from the context menu on the issue list
             * Added the ability to customize issue list columns (at application level or for each saved query)
             * Overdue versions (date reached and open issues > 0) are now always displayed on the roadmap
             * Added the ability to rename wiki pages (specific permission required)
             * Search engines now supports pagination. Results are sorted in reverse chronological order
             * Added "Estimated hours" attribute on issues
             * A category with assigned issue can now be deleted. 2 options are proposed: remove assignments or reassign issues to another category
             * Forum notifications are now also sent to the authors of the thread, even if they don�t watch the board
             * Added an application setting to specify the application protocol (http or https) used to generate urls in emails
             * Gantt chart: now starts at the current month by default
             * Gantt chart: month count and zoom factor are automatically saved as user preferences
             * Wiki links can now refer to other project wikis
             * Added wiki index by date
             * Added preview on add/edit issue form
             * Emails footer can now be customized from the admin interface (Admin -> Email notifications)
             * Default encodings for repository files can now be set in application settings (used to convert files content and diff to UTF-8 so that they�re properly displayed)
             * Calendar: first day of week can now be set in lang files
             * Automatic closing of duplicate issues
             * Added a cross-project issue list
             * AJAXified the SCM browser (tree view)
             * Pretty URL for the repository browser (Cyril Mougel)
             * Search engine: added a checkbox to search titles only
             * Added "% done" in the filter list
             * Enumerations: values can now be reordered and a default value can be specified (eg. default issue priority)
             * Added some accesskeys
             * Added "Float" as a custom field format
             * Added basic Theme support
             * Added the ability to set the �done ratio� of issues fixed by commit (Nikolay Solakov)
             * Added custom fields in issue related mail notifications
             * Email notifications are now sent in plain text and html
             * Gantt chart can now be exported to a graphic file (png). This functionality is only available if RMagick is installed.
             * Added syntax highlightment for repository files and wiki
             * Improved automatic Redmine links
             * Added automatic table of content support on wiki pages
             * Added radio buttons on the documents list to sort documents by category, date, title or author
             * Added basic plugin support, with a sample plugin
             * Added a link to add a new category when creating or editing an issue
             * Added a "Assignable" boolean on the Role model. If unchecked, issues can not be assigned to users having this role.
             * Added an option to be able to relate issues in different projects
             * Added the ability to move issues (to another project) without changing their trackers.
             * Atom feeds added on project activity, news and changesets
             * Added the ability to reset its own RSS access key
             * Main project list now displays root projects with their subprojects
             * Added anchor links to issue notes
             * Added reposman Ruby version. This script can now register created repositories in Redmine (Nicolas Chuche)
             * Issue notes are now included in search
             * Added email sending test functionality
             * Added LDAPS support for LDAP authentication
             * Removed hard-coded URLs in mail templates
             * Subprojects are now grouped by projects in the navigation drop-down menu
             * Added a new value for date filters: this week
             * Added cache for application settings
             * Added Polish translation (Tomasz Gawryl)
             * Added Czech translation (Jan Kadlecek)
             * Added Romanian translation (Csongor Bartus)
             * Added Hebrew translation (Bob Builder)
             * Added Serbian translation (Dragan Matic)
             * Added Korean translation (Choi Jong Yoon)
             * Fixed: the link to delete issue relations is displayed even if the user is not authorized to delete relations
             * Performance improvement on calendar and gantt
             * Fixed: wiki preview doesn�t work on long entries
             * Fixed: queries with multiple custom fields return no result
             * Fixed: Can not authenticate user against LDAP if its DN contains non-ascii characters
             * Fixed: URL with ~ broken in wiki formatting
             * Fixed: some quotation marks are rendered as strange characters in pdf
             == 2007-07-15 v0.5.1
             * per project forums added
             * added the ability to archive projects
             * added �Watch� functionality on issues. It allows users to receive notifications about issue changes
             * custom fields for issues can now be used as filters on issue list
             * added per user custom queries
             * commit messages are now scanned for referenced or fixed issue IDs (keywords defined in Admin -> Settings)
             * projects list now shows the list of public projects and private projects for which the user is a member
             * versions can now be created with no date
             * added issue count details for versions on Reports view
             * added time report, by member/activity/tracker/version and year/month/week for the selected period
             * each category can now be associated to a user, so that new issues in that category are automatically assigned to that user
             * added autologin feature (disabled by default)
             * optimistic locking added for wiki edits
             * added wiki diff
             * added the ability to destroy wiki pages (requires permission)
             * a wiki page can now be attached to each version, and displayed on the roadmap
             * attachments can now be added to wiki pages (original patch by Pavol Murin) and displayed online
             * added an option to see all versions in the roadmap view (including completed ones)
             * added basic issue relations
             * added the ability to log time when changing an issue status
             * account information can now be sent to the user when creating an account
             * author and assignee of an issue always receive notifications (even if they turned of mail notifications)
             * added a quick search form in page header
             * added 'me' value for 'assigned to' and 'author' query filters
             * added a link on revision screen to see the entire diff for the revision
             * added last commit message for each entry in repository browser
             * added the ability to view a file diff with free to/from revision selection.
             * text files can now be viewed online when browsing the repository
             * added basic support for other SCM: CVS (Ralph Vater), Mercurial and Darcs
             * added fragment caching for svn diffs
             * added fragment caching for calendar and gantt views
             * login field automatically focused on login form
             * subproject name displayed on issue list, calendar and gantt
             * added an option to choose the date format: language based or ISO 8601
             * added a simple mail handler. It lets users add notes to an existing issue by replying to the initial notification email.
             * a 403 error page is now displayed (instead of a blank page) when trying to access a protected page
             * added portuguese translation (Joao Carlos Clementoni)
             * added partial online help japanese translation (Ken Date)
             * added bulgarian translation (Nikolay Solakov)
             * added dutch translation (Linda van den Brink)
             * added swedish translation (Thomas Habets)
             * italian translation update (Alessio Spadaro)
             * japanese translation update (Satoru Kurashiki)
             * fixed: error on history atom feed when there�s no notes on an issue change
             * fixed: error in journalizing an issue with longtext custom fields (Postgresql)
             * fixed: creation of Oracle schema
             * fixed: last day of the month not included in project activity
             * fixed: files with an apostrophe in their names can't be accessed in SVN repository
             * fixed: performance issue on RepositoriesController#revisions when a changeset has a great number of changes (eg. 100,000)
             * fixed: open/closed issue counts are always 0 on reports view (postgresql)
             * fixed: date query filters (wrong results and sql error with postgresql)
             * fixed: confidentiality issue on account/show (private project names displayed to anyone)
             * fixed: Long text custom fields displayed without line breaks
             * fixed: Error when editing the wokflow after deleting a status
             * fixed: SVN commit dates are now stored as local time
             == 2007-04-11 v0.5.0
             * added per project Wiki
             * added rss/atom feeds at project level (custom queries can be used as feeds)
             * added search engine (search in issues, news, commits, wiki pages, documents)
             * simple time tracking functionality added
             * added version due dates on calendar and gantt
             * added subprojects issue count on project Reports page
             * added the ability to copy an existing workflow when creating a new tracker
             * added the ability to include subprojects on calendar and gantt
             * added the ability to select trackers to display on calendar and gantt (Jeffrey Jones)
             * added side by side svn diff view (Cyril Mougel)
             * added back subproject filter on issue list
             * added permissions report in admin area
             * added a status filter on users list
             * support for password-protected SVN repositories
             * SVN commits are now stored in the database
             * added simple svn statistics SVG graphs
             * progress bars for roadmap versions (Nick Read)
             * issue history now shows file uploads and deletions
             * #id patterns are turned into links to issues in descriptions and commit messages
             * japanese translation added (Satoru Kurashiki)
             * chinese simplified translation added (Andy Wu)
             * italian translation added (Alessio Spadaro)
             * added scripts to manage SVN repositories creation and user access control using ssh+svn (Nicolas Chuche)
             * better calendar rendering time
             * fixed migration scripts to work with mysql 5 running in strict mode
             * fixed: error when clicking "add" with no block selected on my/page_layout
             * fixed: hard coded links in navigation bar
             * fixed: table_name pre/suffix support
             == 2007-02-18 v0.4.2
             * Rails 1.2 is now required
             * settings are now stored in the database and editable through the application in: Admin -> Settings (config_custom.rb is no longer used)
             * added project roadmap view
             * mail notifications added when a document, a file or an attachment is added
             * tooltips added on Gantt chart and calender to view the details of the issues
             * ability to set the sort order for roles, trackers, issue statuses
             * added missing fields to csv export: priority, start date, due date, done ratio
             * added total number of issues per tracker on project overview
             * all icons replaced (new icons are based on GPL icon set: "KDE Crystal Diamond 2.5" -by paolino- and "kNeu! Alpha v0.1" -by Pablo Fabregat-)
             * added back "fixed version" field on issue screen and in filters
             * project settings screen split in 4 tabs
             * custom fields screen split in 3 tabs (one for each kind of custom field)
             * multiple issues pdf export now rendered as a table
             * added a button on users/list to manually activate an account
             * added a setting option to disable "password lost" functionality
             * added a setting option to set max number of issues in csv/pdf exports
             * fixed: subprojects count is always 0 on projects list
             * fixed: locked users are proposed when adding a member to a project
             * fixed: setting an issue status as default status leads to an sql error with SQLite
             * fixed: unable to delete an issue status even if it's not used yet
             * fixed: filters ignored when exporting a predefined query to csv/pdf
             * fixed: crash when french "issue_edit" email notification is sent
             * fixed: hide mail preference not saved (my/account)
             * fixed: crash when a new user try to edit its "my page" layout
             == 2007-01-03 v0.4.1
             * fixed: emails have no recipient when one of the project members has notifications disabled
             == 2007-01-02 v0.4.0
             * simple SVN browser added (just needs svn binaries in PATH)
             * comments can now be added on news
             * "my page" is now customizable
             * more powerfull and savable filters for issues lists
             * improved issues change history
             * new functionality: move an issue to another project or tracker
             * new functionality: add a note to an issue
             * new report: project activity
             * "start date" and "% done" fields added on issues
             * project calendar added
             * gantt chart added (exportable to pdf)
             * single/multiple issues pdf export added
             * issues reports improvements
             * multiple file upload for issues, documents and files
             * option to set maximum size of uploaded files
             * textile formating of issue and news descritions (RedCloth required)
             * integration of DotClear jstoolbar for textile formatting
             * calendar date picker for date fields (LGPL DHTML Calendar http://sourceforge.net/projects/jscalendar)
             * new filter in issues list: Author
             * ajaxified paginators
             * news rss feed added
             * option to set number of results per page on issues list
             * localized csv separator (comma/semicolon)
             * csv output encoded to ISO-8859-1
             * user custom field displayed on account/show
             * default configuration improved (default roles, trackers, status, permissions and workflows)
             * language for default configuration data can now be chosen when running 'load_default_data' task
             * javascript added on custom field form to show/hide fields according to the format of custom field
             * fixed: custom fields not in csv exports
             * fixed: project settings now displayed according to user's permissions
             * fixed: application error when no version is selected on projects/add_file
             * fixed: public actions not authorized for members of non public projects
             * fixed: non public projects were shown on welcome screen even if current user is not a member
             == 2006-10-08 v0.3.0
             * user authentication against multiple LDAP (optional)
             * token based "lost password" functionality
             * user self-registration functionality (optional)
             * custom fields now available for issues, users and projects
             * new custom field format "text" (displayed as a textarea field)
             * project & administration drop down menus in navigation bar for quicker access
             * text formatting is preserved for long text fields (issues, projects and news descriptions)
             * urls and emails are turned into clickable links in long text fields
             * "due date" field added on issues
             * tracker selection filter added on change log
             * Localization plugin replaced with GLoc 1.1.0 (iconv required)
             * error messages internationalization
             * german translation added (thanks to Karim Trott)
             * data locking for issues to prevent update conflicts (using ActiveRecord builtin optimistic locking)
             * new filter in issues list: "Fixed version"
             * active filters are displayed with colored background on issues list
             * custom configuration is now defined in config/config_custom.rb
             * user object no more stored in session (only user_id)
             * news summary field is no longer required
             * tables and forms redesign
             * Fixed: boolean custom field not working
             * Fixed: error messages for custom fields are not displayed
             * Fixed: invalid custom fields should have a red border
             * Fixed: custom fields values are not validated on issue update
             * Fixed: unable to choose an empty value for 'List' custom fields
             * Fixed: no issue categories sorting
             * Fixed: incorrect versions sorting
             == 2006-07-12 - v0.2.2
             * Fixed: bug in "issues list"
             == 2006-07-09 - v0.2.1
             * new databases supported: Oracle, PostgreSQL, SQL Server
             * projects/subprojects hierarchy (1 level of subprojects only)
             * environment information display in admin/info
             * more filter options in issues list (rev6)
             * default language based on browser settings (Accept-Language HTTP header)
             * issues list exportable to CSV (rev6)
             * simple_format and auto_link on long text fields
             * more data validations
             * Fixed: error when all mail notifications are unchecked in admin/mail_options
             * Fixed: all project news are displayed on project summary
             * Fixed: Can't change user password in users/edit
             * Fixed: Error on tables creation with PostgreSQL (rev5)
             * Fixed: SQL error in "issue reports" view with PostgreSQL (rev5)
             == 2006-06-25 - v0.1.0
             * multiple users/multiple projects
             * role based access control
             * issue tracking system
             * fully customizable workflow
             * documents/files repository
             * email notifications on issue creation and update
             * multilanguage support (except for error messages):english, french, spanish
             * online manual in french (unfinished)

test/fixtures/attachments.yml +12 0

             ---
             attachments_001:
               created_on: 2006-07-19 21:07:27 +02:00
               downloads: 0
               content_type: text/plain
               disk_filename: 060719210727_error281.txt
               container_id: 3
               digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
               id: 1
               container_type: Issue
               filesize: 28
               filename: error281.txt
               author_id: 2
             attachments_002:
               created_on: 2006-07-19 21:07:27 +02:00
               downloads: 0
               content_type: text/plain
               disk_filename: 060719210727_document.txt
               container_id: 1
               digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
               id: 2
               container_type: Document
               filesize: 28
               filename: document.txt
               author_id: 2
             attachments_003:
               created_on: 2006-07-19 21:07:27 +02:00
               downloads: 0
               content_type: image/gif
               disk_filename: 060719210727_logo.gif
               container_id: 4
               digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
               id: 3
               container_type: WikiPage
               filesize: 280
               filename: logo.gif
               description: This is a logo
               author_id: 2
             attachments_004:
               created_on: 2006-07-19 21:07:27 +02:00
               container_type: Issue
               container_id: 3
               downloads: 0
               disk_filename: 060719210727_source.rb
               digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
               id: 4
               filesize: 153
               filename: source.rb
               author_id: 2
               description: This is a Ruby source file
               content_type: application/x-ruby
             attachments_005:
               created_on: 2006-07-19 21:07:27 +02:00
               container_type: Issue
               container_id: 3
               downloads: 0
               disk_filename: 060719210727_changeset.diff
               digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
               id: 5
               filesize: 687
               filename: changeset.diff
               author_id: 2
               content_type: text/x-diff
             attachments_006:
               created_on: 2006-07-19 21:07:27 +02:00
               container_type: Issue
               container_id: 3
               downloads: 0
               disk_filename: 060719210727_archive.zip
               digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
               id: 6
               filesize: 157
               filename: archive.zip
               author_id: 2
               content_type: application/octet-stream
             attachments_007:
               created_on: 2006-07-19 21:07:27 +02:00
               container_type: Issue
               container_id: 4
               downloads: 0
               disk_filename: 060719210727_archive.zip
               digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
               id: 7
               filesize: 157
               filename: archive.zip
               author_id: 1
               content_type: application/octet-stream
             attachments_008:
               created_on: 2006-07-19 21:07:27 +02:00
               container_type: Project
               container_id: 1
               downloads: 0
               disk_filename: 060719210727_project_file.zip
               digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
               id: 8
               filesize: 320
               filename: project_file.zip
               author_id: 2
               content_type: application/octet-stream
             attachments_009:
               created_on: 2006-07-19 21:07:27 +02:00
               container_type: Version
               container_id: 1
               downloads: 0
               disk_filename: 060719210727_version_file.zip
               digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
               id: 9
               filesize: 452
               filename: version_file.zip
               author_id: 2
               content_type: application/octet-stream
+            attachments_010:
+              created_on: 2006-07-19 21:07:27 +02:00
+              container_type: Issue
+              container_id: 2
+              downloads: 0
+              disk_filename: 060719210727_picture.jpg
+              digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
+              id: 10
+              filesize: 452
+              filename: picture.jpg
+              author_id: 2
+              content_type: image/jpeg
   No newline at end of file

test/fixtures/journals.yml +7 0

             ---
             journals_001:
               created_on: <%= 2.days.ago.to_date.to_s(:db) %>
               notes: "Journal notes"
               id: 1
               journalized_type: Issue
               user_id: 1
               journalized_id: 1
             journals_002:
               created_on: <%= 1.days.ago.to_date.to_s(:db) %>
               notes: "Some notes with Redmine links: #2, r2."
               id: 2
               journalized_type: Issue
               user_id: 2
               journalized_id: 1
+            journals_003:
+              created_on: <%= 1.days.ago.to_date.to_s(:db) %>
+              notes: "A comment with inline image: !picture.jpg!"
+              id: 3
+              journalized_type: Issue
+              user_id: 2
+              journalized_id: 2
   No newline at end of file

test/functional/issues_controller_test.rb +8 0

             # Redmine - project management software
             # Copyright (C) 2006-2008  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.dirname(__FILE__) + '/../test_helper'
             require 'issues_controller'
             # Re-raise errors caught by the controller.
             class IssuesController; def rescue_action(e) raise e end; end
             class IssuesControllerTest < Test::Unit::TestCase
               fixtures :projects,
                        :users,
                        :roles,
                        :members,
                        :issues,
                        :issue_statuses,
                        :versions,
                        :trackers,
                        :projects_trackers,
                        :issue_categories,
                        :enabled_modules,
                        :enumerations,
                        :attachments,
                        :workflows,
                        :custom_fields,
                        :custom_values,
                        :custom_fields_trackers,
                        :time_entries,
                        :journals,
                        :journal_details
               def setup
                 @controller = IssuesController.new
                 @request    = ActionController::TestRequest.new
                 @response   = ActionController::TestResponse.new
                 User.current = nil
               end
               def test_index
                 Setting.default_language = 'en'
                 get :index
                 assert_response :success
                 assert_template 'index.rhtml'
                 assert_not_nil assigns(:issues)
                 assert_nil assigns(:project)
                 assert_tag :tag => 'a', :content => /Can't print recipes/
                 assert_tag :tag => 'a', :content => /Subproject issue/
                 # private projects hidden
                 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
                 assert_no_tag :tag => 'a', :content => /Issue on project 2/
                 # project column
                 assert_tag :tag => 'th', :content => /Project/
               end
               def test_index_should_not_list_issues_when_module_disabled
                 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
                 get :index
                 assert_response :success
                 assert_template 'index.rhtml'
                 assert_not_nil assigns(:issues)
                 assert_nil assigns(:project)
                 assert_no_tag :tag => 'a', :content => /Can't print recipes/
                 assert_tag :tag => 'a', :content => /Subproject issue/
               end
               def test_index_with_project
                 Setting.display_subprojects_issues = 0
                 get :index, :project_id => 1
                 assert_response :success
                 assert_template 'index.rhtml'
                 assert_not_nil assigns(:issues)
                 assert_tag :tag => 'a', :content => /Can't print recipes/
                 assert_no_tag :tag => 'a', :content => /Subproject issue/
               end
               def test_index_with_project_and_subprojects
                 Setting.display_subprojects_issues = 1
                 get :index, :project_id => 1
                 assert_response :success
                 assert_template 'index.rhtml'
                 assert_not_nil assigns(:issues)
                 assert_tag :tag => 'a', :content => /Can't print recipes/
                 assert_tag :tag => 'a', :content => /Subproject issue/
                 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
               end
               def test_index_with_project_and_subprojects_should_show_private_subprojects
                 @request.session[:user_id] = 2
                 Setting.display_subprojects_issues = 1
                 get :index, :project_id => 1
                 assert_response :success
                 assert_template 'index.rhtml'
                 assert_not_nil assigns(:issues)
                 assert_tag :tag => 'a', :content => /Can't print recipes/
                 assert_tag :tag => 'a', :content => /Subproject issue/
                 assert_tag :tag => 'a', :content => /Issue of a private subproject/
               end
               def test_index_with_project_and_filter
                 get :index, :project_id => 1, :set_filter => 1
                 assert_response :success
                 assert_template 'index.rhtml'
                 assert_not_nil assigns(:issues)
               end
               def test_index_csv_with_project
                 get :index, :format => 'csv'
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_equal 'text/csv', @response.content_type
                 get :index, :project_id => 1, :format => 'csv'
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_equal 'text/csv', @response.content_type
               end
               def test_index_pdf
                 get :index, :format => 'pdf'
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_equal 'application/pdf', @response.content_type
                 get :index, :project_id => 1, :format => 'pdf'
                 assert_response :success
                 assert_not_nil assigns(:issues)
                 assert_equal 'application/pdf', @response.content_type
               end
               def test_index_sort
                 get :index, :sort_key => 'tracker'
                 assert_response :success
                 sort_params = @request.session['issuesindex_sort']
                 assert sort_params.is_a?(Hash)
                 assert_equal 'tracker', sort_params[:key]
                 assert_equal 'ASC', sort_params[:order]
               end
               def test_gantt
                 get :gantt, :project_id => 1
                 assert_response :success
                 assert_template 'gantt.rhtml'
                 assert_not_nil assigns(:gantt)
                 events = assigns(:gantt).events
                 assert_not_nil events
                 # Issue with start and due dates
                 i = Issue.find(1)
                 assert_not_nil i.due_date
                 assert events.include?(Issue.find(1))
                 # Issue with without due date but targeted to a version with date
                 i = Issue.find(2)
                 assert_nil i.due_date
                 assert events.include?(i)
               end
               def test_cross_project_gantt
                 get :gantt
                 assert_response :success
                 assert_template 'gantt.rhtml'
                 assert_not_nil assigns(:gantt)
                 events = assigns(:gantt).events
                 assert_not_nil events
               end
               def test_gantt_export_to_pdf
                 get :gantt, :project_id => 1, :format => 'pdf'
                 assert_response :success
                 assert_equal 'application/pdf', @response.content_type
                 assert @response.body.starts_with?('%PDF')
                 assert_not_nil assigns(:gantt)
               end
               def test_cross_project_gantt_export_to_pdf
                 get :gantt, :format => 'pdf'
                 assert_response :success
                 assert_equal 'application/pdf', @response.content_type
                 assert @response.body.starts_with?('%PDF')
                 assert_not_nil assigns(:gantt)
               end
               if Object.const_defined?(:Magick)
                 def test_gantt_image
                   get :gantt, :project_id => 1, :format => 'png'
                   assert_response :success
                   assert_equal 'image/png', @response.content_type
                 end
               else
                 puts "RMagick not installed. Skipping tests !!!"
               end
               def test_calendar
                 get :calendar, :project_id => 1
                 assert_response :success
                 assert_template 'calendar'
                 assert_not_nil assigns(:calendar)
               end
               def test_cross_project_calendar
                 get :calendar
                 assert_response :success
                 assert_template 'calendar'
                 assert_not_nil assigns(:calendar)
               end
               def test_changes
                 get :changes, :project_id => 1
                 assert_response :success
                 assert_not_nil assigns(:journals)
                 assert_equal 'application/atom+xml', @response.content_type
               end
               def test_show_by_anonymous
                 get :show, :id => 1
                 assert_response :success
                 assert_template 'show.rhtml'
                 assert_not_nil assigns(:issue)
                 assert_equal Issue.find(1), assigns(:issue)
                 # anonymous role is allowed to add a note
                 assert_tag :tag => 'form',
                            :descendant => { :tag => 'fieldset',
                                             :child => { :tag => 'legend',
                                                         :content => /Notes/ } }
               end
               def test_show_by_manager
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_response :success
                 assert_tag :tag => 'form',
                            :descendant => { :tag => 'fieldset',
                                             :child => { :tag => 'legend',
                                                         :content => /Change properties/ } },
                            :descendant => { :tag => 'fieldset',
                                             :child => { :tag => 'legend',
                                                         :content => /Log time/ } },
                            :descendant => { :tag => 'fieldset',
                                             :child => { :tag => 'legend',
                                                         :content => /Notes/ } }
               end
+              def test_show_atom
+                get :show, :id => 2, :format => 'atom'
+                assert_response :success
+                assert_template 'changes'
+                # Inline image
+                assert @response.body.include?("&lt;img src=\"http://test.host/attachments/download/10\" alt=\"\" /&gt;")
+              end
               def test_show_export_to_pdf
                 get :show, :id => 3, :format => 'pdf'
                 assert_response :success
                 assert_equal 'application/pdf', @response.content_type
                 assert @response.body.starts_with?('%PDF')
                 assert_not_nil assigns(:issue)
               end
               def test_get_new
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :tracker_id => 1
                 assert_response :success
                 assert_template 'new'
                 assert_tag :tag => 'input', :attributes => { :name => 'issue[custom_field_values][2]',
                                                              :value => 'Default string' }
               end
               def test_get_new_without_tracker_id
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1
                 assert_response :success
                 assert_template 'new'
                 issue = assigns(:issue)
                 assert_not_nil issue
                 assert_equal Project.find(1).trackers.first, issue.tracker
               end
               def test_update_new_form
                 @request.session[:user_id] = 2
                 xhr :post, :new, :project_id => 1,
                                  :issue => {:tracker_id => 2,
                                             :subject => 'This is the test_new issue',
                                             :description => 'This is the description',
                                             :priority_id => 5}
                 assert_response :success
                 assert_template 'new'
               end
               def test_post_new
                 @request.session[:user_id] = 2
                 post :new, :project_id => 1,
                            :issue => {:tracker_id => 3,
                                       :subject => 'This is the test_new issue',
                                       :description => 'This is the description',
                                       :priority_id => 5,
                                       :estimated_hours => '',
                                       :custom_field_values => {'2' => 'Value for field 2'}}
                 assert_redirected_to 'issues/show'
                 issue = Issue.find_by_subject('This is the test_new issue')
                 assert_not_nil issue
                 assert_equal 2, issue.author_id
                 assert_equal 3, issue.tracker_id
                 assert_nil issue.estimated_hours
                 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
                 assert_not_nil v
                 assert_equal 'Value for field 2', v.value
               end
               def test_post_new_and_continue
                 @request.session[:user_id] = 2
                 post :new, :project_id => 1,
                            :issue => {:tracker_id => 3,
                                       :subject => 'This is first issue',
                                       :priority_id => 5},
                            :continue => ''
                 assert_redirected_to :controller => 'issues', :action => 'new', :tracker_id => 3
               end
               def test_post_new_without_custom_fields_param
                 @request.session[:user_id] = 2
                 post :new, :project_id => 1,
                            :issue => {:tracker_id => 1,
                                       :subject => 'This is the test_new issue',
                                       :description => 'This is the description',
                                       :priority_id => 5}
                 assert_redirected_to 'issues/show'
               end
               def test_post_new_with_required_custom_field_and_without_custom_fields_param
                 field = IssueCustomField.find_by_name('Database')
                 field.update_attribute(:is_required, true)
                 @request.session[:user_id] = 2
                 post :new, :project_id => 1,
                            :issue => {:tracker_id => 1,
                                       :subject => 'This is the test_new issue',
                                       :description => 'This is the description',
                                       :priority_id => 5}
                 assert_response :success
                 assert_template 'new'
                 issue = assigns(:issue)
                 assert_not_nil issue
                 assert_equal 'activerecord_error_invalid', issue.errors.on(:custom_values)
               end
               def test_post_new_with_watchers
                 @request.session[:user_id] = 2
                 ActionMailer::Base.deliveries.clear
                 assert_difference 'Watcher.count', 2 do
                   post :new, :project_id => 1,
                              :issue => {:tracker_id => 1,
                                         :subject => 'This is a new issue with watchers',
                                         :description => 'This is the description',
                                         :priority_id => 5,
                                         :watcher_user_ids => ['2', '3']}
                 end
                 assert_redirected_to 'issues/show'
                 issue = Issue.find_by_subject('This is a new issue with watchers')
                 # Watchers added
                 assert_equal [2, 3], issue.watcher_user_ids.sort
                 assert issue.watched_by?(User.find(3))
                 # Watchers notified
                 mail = ActionMailer::Base.deliveries.last
                 assert_kind_of TMail::Mail, mail
                 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
               end
               def test_post_should_preserve_fields_values_on_validation_failure
                 @request.session[:user_id] = 2
                 post :new, :project_id => 1,
                            :issue => {:tracker_id => 1,
                                       # empty subject
                                       :subject => '',
                                       :description => 'This is a description',
                                       :priority_id => 6,
                                       :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
                 assert_response :success
                 assert_template 'new'
                 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
                                       :content => 'This is a description'
                 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                                     :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                                    :value => '6' },
                                                                   :content => 'High' }
                 # Custom fields
                 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
                                     :child => { :tag => 'option', :attributes => { :selected => 'selected',
                                                                                    :value => 'Oracle' },
                                                                   :content => 'Oracle' }
                 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
                                                     :value => 'Value for field 2'}
               end
               def test_copy_issue
                 @request.session[:user_id] = 2
                 get :new, :project_id => 1, :copy_from => 1
                 assert_template 'new'
                 assert_not_nil assigns(:issue)
                 orig = Issue.find(1)
                 assert_equal orig.subject, assigns(:issue).subject
               end
               def test_get_edit
                 @request.session[:user_id] = 2
                 get :edit, :id => 1
                 assert_response :success
                 assert_template 'edit'
                 assert_not_nil assigns(:issue)
                 assert_equal Issue.find(1), assigns(:issue)
               end
               def test_get_edit_with_params
                 @request.session[:user_id] = 2
                 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 }
                 assert_response :success
                 assert_template 'edit'
                 issue = assigns(:issue)
                 assert_not_nil issue
                 assert_equal 5, issue.status_id
                 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
                                     :child => { :tag => 'option',
                                                 :content => 'Closed',
                                                 :attributes => { :selected => 'selected' } }
                 assert_equal 7, issue.priority_id
                 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
                                     :child => { :tag => 'option',
                                                 :content => 'Urgent',
                                                 :attributes => { :selected => 'selected' } }
               end
               def test_reply_to_issue
                 @request.session[:user_id] = 2
                 get :reply, :id => 1
                 assert_response :success
                 assert_select_rjs :show, "update"
               end
               def test_reply_to_note
                 @request.session[:user_id] = 2
                 get :reply, :id => 1, :journal_id => 2
                 assert_response :success
                 assert_select_rjs :show, "update"
               end
               def test_post_edit_without_custom_fields_param
                 @request.session[:user_id] = 2
                 ActionMailer::Base.deliveries.clear
                 issue = Issue.find(1)
                 assert_equal '125', issue.custom_value_for(2).value
                 old_subject = issue.subject
                 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
                 assert_difference('Journal.count') do
                   assert_difference('JournalDetail.count', 2) do
                     post :edit, :id => 1, :issue => {:subject => new_subject,
                                                      :priority_id => '6',
                                                      :category_id => '1' # no change
                                                     }
                   end
                 end
                 assert_redirected_to 'issues/show/1'
                 issue.reload
                 assert_equal new_subject, issue.subject
                 # Make sure custom fields were not cleared
                 assert_equal '125', issue.custom_value_for(2).value
                 mail = ActionMailer::Base.deliveries.last
                 assert_kind_of TMail::Mail, mail
                 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
                 assert mail.body.include?("Subject changed from #{old_subject} to #{new_subject}")
               end
               def test_post_edit_with_custom_field_change
                 @request.session[:user_id] = 2
                 issue = Issue.find(1)
                 assert_equal '125', issue.custom_value_for(2).value
                 assert_difference('Journal.count') do
                   assert_difference('JournalDetail.count', 3) do
                     post :edit, :id => 1, :issue => {:subject => 'Custom field change',
                                                      :priority_id => '6',
                                                      :category_id => '1', # no change
                                                      :custom_field_values => { '2' => 'New custom value' }
                                                     }
                   end
                 end
                 assert_redirected_to 'issues/show/1'
                 issue.reload
                 assert_equal 'New custom value', issue.custom_value_for(2).value
                 mail = ActionMailer::Base.deliveries.last
                 assert_kind_of TMail::Mail, mail
                 assert mail.body.include?("Searchable field changed from 125 to New custom value")
               end
               def test_post_edit_with_status_and_assignee_change
                 issue = Issue.find(1)
                 assert_equal 1, issue.status_id
                 @request.session[:user_id] = 2
                 assert_difference('TimeEntry.count', 0) do
                   post :edit,
                        :id => 1,
                        :issue => { :status_id => 2, :assigned_to_id => 3 },
                        :notes => 'Assigned to dlopper',
                        :time_entry => { :hours => '', :comments => '', :activity_id => Enumeration.get_values('ACTI').first }
                 end
                 assert_redirected_to 'issues/show/1'
                 issue.reload
                 assert_equal 2, issue.status_id
                 j = issue.journals.find(:first, :order => 'id DESC')
                 assert_equal 'Assigned to dlopper', j.notes
                 assert_equal 2, j.details.size
                 mail = ActionMailer::Base.deliveries.last
                 assert mail.body.include?("Status changed from New to Assigned")
               end
               def test_post_edit_with_note_only
                 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
                 # anonymous user
                 post :edit,
                      :id => 1,
                      :notes => notes
                 assert_redirected_to 'issues/show/1'
                 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
                 assert_equal notes, j.notes
                 assert_equal 0, j.details.size
                 assert_equal User.anonymous, j.user
                 mail = ActionMailer::Base.deliveries.last
                 assert mail.body.include?(notes)
               end
               def test_post_edit_with_note_and_spent_time
                 @request.session[:user_id] = 2
                 spent_hours_before = Issue.find(1).spent_hours
                 assert_difference('TimeEntry.count') do
                   post :edit,
                        :id => 1,
                        :notes => '2.5 hours added',
                        :time_entry => { :hours => '2.5', :comments => '', :activity_id => Enumeration.get_values('ACTI').first }
                 end
                 assert_redirected_to 'issues/show/1'
                 issue = Issue.find(1)
                 j = issue.journals.find(:first, :order => 'id DESC')
                 assert_equal '2.5 hours added', j.notes
                 assert_equal 0, j.details.size
                 t = issue.time_entries.find(:first, :order => 'id DESC')
                 assert_not_nil t
                 assert_equal 2.5, t.hours
                 assert_equal spent_hours_before + 2.5, issue.spent_hours
               end
               def test_post_edit_with_attachment_only
                 set_tmp_attachments_directory
                 # Delete all fixtured journals, a race condition can occur causing the wrong
                 # journal to get fetched in the next find.
                 Journal.delete_all
                 # anonymous user
                 post :edit,
                      :id => 1,
                      :notes => '',
                      :attachments => {'1' => {'file' => test_uploaded_file('testfile.txt', 'text/plain')}}
                 assert_redirected_to 'issues/show/1'
                 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
                 assert j.notes.blank?
                 assert_equal 1, j.details.size
                 assert_equal 'testfile.txt', j.details.first.value
                 assert_equal User.anonymous, j.user
                 mail = ActionMailer::Base.deliveries.last
                 assert mail.body.include?('testfile.txt')
               end
               def test_post_edit_with_no_change
                 issue = Issue.find(1)
                 issue.journals.clear
                 ActionMailer::Base.deliveries.clear
                 post :edit,
                      :id => 1,
                      :notes => ''
                 assert_redirected_to 'issues/show/1'
                 issue.reload
                 assert issue.journals.empty?
                 # No email should be sent
                 assert ActionMailer::Base.deliveries.empty?
               end
               def test_post_edit_with_invalid_spent_time
                 @request.session[:user_id] = 2
                 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
                 assert_no_difference('Journal.count') do
                   post :edit,
                        :id => 1,
                        :notes => notes,
                        :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
                 end
                 assert_response :success
                 assert_template 'edit'
                 assert_tag :textarea, :attributes => { :name => 'notes' },
                                       :content => notes
                 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
               end
               def test_bulk_edit
                 @request.session[:user_id] = 2
                 # update issues priority
                 post :bulk_edit, :ids => [1, 2], :priority_id => 7, :notes => 'Bulk editing', :assigned_to_id => ''
                 assert_response 302
                 # check that the issues were updated
                 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
                 assert_equal 'Bulk editing', Issue.find(1).journals.find(:first, :order => 'created_on DESC').notes
               end
               def test_bulk_unassign
                 assert_not_nil Issue.find(2).assigned_to
                 @request.session[:user_id] = 2
                 # unassign issues
                 post :bulk_edit, :ids => [1, 2], :notes => 'Bulk unassigning', :assigned_to_id => 'none'
                 assert_response 302
                 # check that the issues were updated
                 assert_nil Issue.find(2).assigned_to
               end
               def test_move_one_issue_to_another_project
                 @request.session[:user_id] = 1
                 post :move, :id => 1, :new_project_id => 2
                 assert_redirected_to 'projects/ecookbook/issues'
                 assert_equal 2, Issue.find(1).project_id
               end
               def test_bulk_move_to_another_project
                 @request.session[:user_id] = 1
                 post :move, :ids => [1, 2], :new_project_id => 2
                 assert_redirected_to 'projects/ecookbook/issues'
                 # Issues moved to project 2
                 assert_equal 2, Issue.find(1).project_id
                 assert_equal 2, Issue.find(2).project_id
                 # No tracker change
                 assert_equal 1, Issue.find(1).tracker_id
                 assert_equal 2, Issue.find(2).tracker_id
               end
               def test_bulk_move_to_another_tracker
                 @request.session[:user_id] = 1
                 post :move, :ids => [1, 2], :new_tracker_id => 2
                 assert_redirected_to 'projects/ecookbook/issues'
                 assert_equal 2, Issue.find(1).tracker_id
                 assert_equal 2, Issue.find(2).tracker_id
               end
               def test_context_menu_one_issue
                 @request.session[:user_id] = 2
                 get :context_menu, :ids => [1]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_tag :tag => 'a', :content => 'Edit',
                                         :attributes => { :href => '/issues/edit/1',
                                                          :class => 'icon-edit' }
                 assert_tag :tag => 'a', :content => 'Closed',
                                         :attributes => { :href => '/issues/edit/1?issue%5Bstatus_id%5D=5',
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Immediate',
                                         :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;priority_id=8',
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Dave Lopper',
                                         :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&amp;ids%5B%5D=1',
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Copy',
                                         :attributes => { :href => '/projects/ecookbook/issues/new?copy_from=1',
                                                          :class => 'icon-copy' }
                 assert_tag :tag => 'a', :content => 'Move',
                                         :attributes => { :href => '/issues/move?ids%5B%5D=1',
                                                          :class => 'icon-move' }
                 assert_tag :tag => 'a', :content => 'Delete',
                                         :attributes => { :href => '/issues/destroy?ids%5B%5D=1',
                                                          :class => 'icon-del' }
               end
               def test_context_menu_one_issue_by_anonymous
                 get :context_menu, :ids => [1]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_tag :tag => 'a', :content => 'Delete',
                                         :attributes => { :href => '#',
                                                          :class => 'icon-del disabled' }
               end
               def test_context_menu_multiple_issues_of_same_project
                 @request.session[:user_id] = 2
                 get :context_menu, :ids => [1, 2]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_tag :tag => 'a', :content => 'Edit',
                                         :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;ids%5B%5D=2',
                                                          :class => 'icon-edit' }
                 assert_tag :tag => 'a', :content => 'Immediate',
                                         :attributes => { :href => '/issues/bulk_edit?ids%5B%5D=1&amp;ids%5B%5D=2&amp;priority_id=8',
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Dave Lopper',
                                         :attributes => { :href => '/issues/bulk_edit?assigned_to_id=3&amp;ids%5B%5D=1&amp;ids%5B%5D=2',
                                                          :class => '' }
                 assert_tag :tag => 'a', :content => 'Move',
                                         :attributes => { :href => '/issues/move?ids%5B%5D=1&amp;ids%5B%5D=2',
                                                          :class => 'icon-move' }
                 assert_tag :tag => 'a', :content => 'Delete',
                                         :attributes => { :href => '/issues/destroy?ids%5B%5D=1&amp;ids%5B%5D=2',
                                                          :class => 'icon-del' }
               end
               def test_context_menu_multiple_issues_of_different_project
                 @request.session[:user_id] = 2
                 get :context_menu, :ids => [1, 2, 4]
                 assert_response :success
                 assert_template 'context_menu'
                 assert_tag :tag => 'a', :content => 'Delete',
                                         :attributes => { :href => '#',
                                                          :class => 'icon-del disabled' }
               end
               def test_destroy_issue_with_no_time_entries
                 assert_nil TimeEntry.find_by_issue_id(2)
                 @request.session[:user_id] = 2
                 post :destroy, :id => 2
                 assert_redirected_to 'projects/ecookbook/issues'
                 assert_nil Issue.find_by_id(2)
               end
               def test_destroy_issues_with_time_entries
                 @request.session[:user_id] = 2
                 post :destroy, :ids => [1, 3]
                 assert_response :success
                 assert_template 'destroy'
                 assert_not_nil assigns(:hours)
                 assert Issue.find_by_id(1) && Issue.find_by_id(3)
               end
               def test_destroy_issues_and_destroy_time_entries
                 @request.session[:user_id] = 2
                 post :destroy, :ids => [1, 3], :todo => 'destroy'
                 assert_redirected_to 'projects/ecookbook/issues'
                 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                 assert_nil TimeEntry.find_by_id([1, 2])
               end
               def test_destroy_issues_and_assign_time_entries_to_project
                 @request.session[:user_id] = 2
                 post :destroy, :ids => [1, 3], :todo => 'nullify'
                 assert_redirected_to 'projects/ecookbook/issues'
                 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                 assert_nil TimeEntry.find(1).issue_id
                 assert_nil TimeEntry.find(2).issue_id
               end
               def test_destroy_issues_and_reassign_time_entries_to_another_issue
                 @request.session[:user_id] = 2
                 post :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
                 assert_redirected_to 'projects/ecookbook/issues'
                 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
                 assert_equal 2, TimeEntry.find(1).issue_id
                 assert_equal 2, TimeEntry.find(2).issue_id
               end
             end

test/unit/query_test.rb +7 -5

             # redMine - project management software
             # Copyright (C) 2006-2008  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.dirname(__FILE__) + '/../test_helper'
             class QueryTest < Test::Unit::TestCase
               fixtures :projects, :enabled_modules, :users, :members, :roles, :trackers, :issue_statuses, :issue_categories, :enumerations, :issues, :custom_fields, :custom_values, :versions, :queries
               def test_custom_fields_for_all_projects_should_be_available_in_global_queries
                 query = Query.new(:project => nil, :name => '_')
                 assert query.available_filters.has_key?('cf_1')
                 assert !query.available_filters.has_key?('cf_3')
               end
               def find_issues_with_query(query)
                 Issue.find :all,
                   :include => [ :assigned_to, :status, :tracker, :project, :priority ],
                   :conditions => query.statement
               end
               def test_query_with_multiple_custom_fields
                 query = Query.find(1)
                 assert query.valid?
                 assert query.statement.include?("#{CustomValue.table_name}.value IN ('MySQL')")
                 issues = find_issues_with_query(query)
                 assert_equal 1, issues.length
                 assert_equal Issue.find(3), issues.first
               end
               def test_operator_none
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('fixed_version_id', '!*', [''])
                 query.add_filter('cf_1', '!*', [''])
                 assert query.statement.include?("#{Issue.table_name}.fixed_version_id IS NULL")
                 assert query.statement.include?("#{CustomValue.table_name}.value IS NULL OR #{CustomValue.table_name}.value = ''")
                 find_issues_with_query(query)
               end
               def test_operator_none_for_integer
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('estimated_hours', '!*', [''])
                 issues = find_issues_with_query(query)
                 assert !issues.empty?
                 assert issues.all? {|i| !i.estimated_hours}
               end
               def test_operator_all
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('fixed_version_id', '*', [''])
                 query.add_filter('cf_1', '*', [''])
                 assert query.statement.include?("#{Issue.table_name}.fixed_version_id IS NOT NULL")
                 assert query.statement.include?("#{CustomValue.table_name}.value IS NOT NULL AND #{CustomValue.table_name}.value <> ''")
                 find_issues_with_query(query)
               end
               def test_operator_greater_than
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('done_ratio', '>=', ['40'])
                 assert query.statement.include?("#{Issue.table_name}.done_ratio >= 40")
                 find_issues_with_query(query)
               end
               def test_operator_in_more_than
                 Issue.find(7).update_attribute(:due_date, (Date.today + 15))
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('due_date', '>t+', ['15'])
                 issues = find_issues_with_query(query)
                 assert !issues.empty?
                 issues.each {|issue| assert(issue.due_date >= (Date.today + 15))}
               end
               def test_operator_in_less_than
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('due_date', '<t+', ['15'])
                 issues = find_issues_with_query(query)
                 assert !issues.empty?
                 issues.each {|issue| assert(issue.due_date >= Date.today && issue.due_date <= (Date.today + 15))}
               end
               def test_operator_less_than_ago
                 Issue.find(7).update_attribute(:due_date, (Date.today - 3))
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('due_date', '>t-', ['3'])
                 issues = find_issues_with_query(query)
                 assert !issues.empty?
                 issues.each {|issue| assert(issue.due_date >= (Date.today - 3) && issue.due_date <= Date.today)}
               end
               def test_operator_more_than_ago
                 Issue.find(7).update_attribute(:due_date, (Date.today - 10))
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('due_date', '<t-', ['10'])
                 assert query.statement.include?("#{Issue.table_name}.due_date <=")
                 issues = find_issues_with_query(query)
                 assert !issues.empty?
                 issues.each {|issue| assert(issue.due_date <= (Date.today - 10))}
               end
               def test_operator_in
                 Issue.find(7).update_attribute(:due_date, (Date.today + 2))
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('due_date', 't+', ['2'])
                 issues = find_issues_with_query(query)
                 assert !issues.empty?
                 issues.each {|issue| assert_equal((Date.today + 2), issue.due_date)}
               end
               def test_operator_ago
                 Issue.find(7).update_attribute(:due_date, (Date.today - 3))
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('due_date', 't-', ['3'])
                 issues = find_issues_with_query(query)
                 assert !issues.empty?
                 issues.each {|issue| assert_equal((Date.today - 3), issue.due_date)}
               end
               def test_operator_today
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('due_date', 't', [''])
                 issues = find_issues_with_query(query)
                 assert !issues.empty?
                 issues.each {|issue| assert_equal Date.today, issue.due_date}
               end
               def test_operator_this_week_on_date
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('due_date', 'w', [''])
                 find_issues_with_query(query)
               end
               def test_operator_this_week_on_datetime
                 query = Query.new(:project => Project.find(1), :name => '_')
                 query.add_filter('created_on', 'w', [''])
                 find_issues_with_query(query)
               end
               def test_operator_contains
                 query = Query.new(:project => Project.find(1), :name => '_')
-                query.add_filter('subject', '~', ['string'])
+                query.add_filter('subject', '~', ['uNable'])
-                assert query.statement.include?("#{Issue.table_name}.subject LIKE '%string%'")
+                assert query.statement.include?("LOWER(#{Issue.table_name}.subject) LIKE '%unable%'")
-                find_issues_with_query(query)
+                result = find_issues_with_query(query)
+                assert result.empty?
+                result.each {|issue| assert issue.subject.downcase.include?('unable') }
               end
               def test_operator_does_not_contains
                 query = Query.new(:project => Project.find(1), :name => '_')
-                query.add_filter('subject', '!~', ['string'])
+                query.add_filter('subject', '!~', ['uNable'])
-                assert query.statement.include?("#{Issue.table_name}.subject NOT LIKE '%string%'")
+                assert query.statement.include?("LOWER(#{Issue.table_name}.subject) NOT LIKE '%unable%'")
                 find_issues_with_query(query)
               end
               def test_default_columns
                 q = Query.new
                 assert !q.columns.empty?
               end
               def test_set_column_names
                 q = Query.new
                 q.column_names = ['tracker', :subject, '', 'unknonw_column']
                 assert_equal [:tracker, :subject], q.columns.collect {|c| c.name}
                 c = q.columns.first
                 assert q.has_column?(c)
               end
               def test_label_for
                 q = Query.new
                 assert_equal 'assigned_to', q.label_for('assigned_to_id')
               end
               def test_editable_by
                 admin = User.find(1)
                 manager = User.find(2)
                 developer = User.find(3)
                 # Public query on project 1
                 q = Query.find(1)
                 assert q.editable_by?(admin)
                 assert q.editable_by?(manager)
                 assert !q.editable_by?(developer)
                 # Private query on project 1
                 q = Query.find(2)
                 assert q.editable_by?(admin)
                 assert !q.editable_by?(manager)
                 assert q.editable_by?(developer)
                 # Private query for all projects
                 q = Query.find(3)
                 assert q.editable_by?(admin)
                 assert !q.editable_by?(manager)
                 assert q.editable_by?(developer)
                 # Public query for all projects
                 q = Query.find(4)
                 assert q.editable_by?(admin)
                 assert !q.editable_by?(manager)
                 assert !q.editable_by?(developer)
               end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages