jro_apps/redmine Commit - r2768:94488269d1c3

0

app/controllers/messages_controller.rb +2 0

                   @message.sticky = params[:message]['sticky']
                 end
                 if request.post? && @message.save
+                  call_hook(:controller_messages_new_after_save, { :params => params, :message => @message})
                   attach_files(@message, params[:attachments])
                   redirect_to :action => 'show', :id => @message
                 end
                 @reply.board = @board
                 @topic.children << @reply
                 if !@reply.new_record?
+                  call_hook(:controller_messages_reply_after_save, { :params => params, :message => @reply})
                   attach_files(@reply, params[:attachments])
                 end
                 redirect_to :action => 'show', :id => @topic

0

app/controllers/timelog_controller.rb +3 0

                 render_403 and return if @time_entry && !@time_entry.editable_by?(User.current)
                 @time_entry ||= TimeEntry.new(:project => @project, :issue => @issue, :user => User.current, :spent_on => Date.today)
                 @time_entry.attributes = params[:time_entry]
+                call_hook(:controller_timelog_edit_before_save, { :params => params, :time_entry => @time_entry })
                 if request.post? and @time_entry.save
                   flash[:notice] = l(:notice_successful_update)
                   redirect_back_or_default :action => 'details', :project_id => @time_entry.project

0

app/controllers/wiki_controller.rb +1 0

                   @content.author = User.current
                   # if page is new @page.save will also save content, but not if page isn't a new record
                   if (@page.new_record? ? @page.save : @content.save)
+                    call_hook(:controller_wiki_edit_after_save, { :params => params, :page => @page})
                     redirect_to :action => 'index', :id => @project, :page => @page.title
                   end
                 end

0

app/models/changeset.rb +2 0

                       journal = issue.init_journal(user || User.anonymous, l(:text_status_changed_by_changeset, csettext))
                       issue.status = fix_status
                       issue.done_ratio = done_ratio if done_ratio
+                      Redmine::Hook.call_hook(:model_changeset_scan_commit_for_issue_ids_pre_issue_update,
+                                              { :changeset => self, :issue => issue })
                       issue.save
                       Mailer.deliver_issue_edit(journal) if Setting.notified_events.include?('issue_updated')
                     end

0

app/models/query.rb +2 -2

                     Time.now.at_beginning_of_week
                   sql = "#{db_table}.#{db_field} BETWEEN '%s' AND '%s'" % [connection.quoted_date(from), connection.quoted_date(from + 7.days)]
                 when "~"
-                  sql = "#{db_table}.#{db_field} LIKE '%#{connection.quote_string(value.first)}%'"
+                  sql = "LOWER(#{db_table}.#{db_field}) LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
                 when "!~"
-                  sql = "#{db_table}.#{db_field} NOT LIKE '%#{connection.quote_string(value.first)}%'"
+                  sql = "LOWER(#{db_table}.#{db_field}) NOT LIKE '%#{connection.quote_string(value.first.to_s.downcase)}%'"
                 end
                 return sql

0

app/views/common/feed.atom.rxml +1 -1

                     xml.email(author.mail) if author.is_a?(User) && !author.mail.blank? && !author.pref.hide_mail
                   end if author
                   xml.content "type" => "html" do
-                    xml.text! textilizable(item.event_description)
+                    xml.text! textilizable(item, :event_description, :only_path => false)
                   end
                 end
               end

0

app/views/issues/changes.rxml +1 -1

                       xml.text! '<li>' + show_detail(detail, false) + '</li>'
                     end
                     xml.text! '</ul>'
-                    xml.text! textilizable(change.notes) unless change.notes.blank?
+                    xml.text! textilizable(change, :notes, :only_path => false) unless change.notes.blank?
                   end
                 end
               end

0

doc/CHANGELOG +3 -1

             * Do not require a non-word character after a comma in Redmine links
             * Include issue hyperlinks in reminder emails
             * Fixed: 500 Internal Server Error is raised if add an empty comment to the news
-            * Fixes: Atom links for wiki pages are not correct
+            * Fixed: Atom links for wiki pages are not correct
             * Fixed: Atom feeds leak email address
+            * Fixed: Case sensitivity in Issue filtering
+            * Fixed: When reading RSS feed, the inline-embedded images are not properly shown
             == 2009-05-17 v0.8.4

0

test/fixtures/attachments.yml +12 0

@@ -109,4 +109,16 attachments_009:
109	filename: version_file.zip	109	filename: version_file.zip
110	author_id: 2	110	author_id: 2
111	content_type: application/octet-stream	111	content_type: application/octet-stream
		112	attachments_010:
		113	created_on: 2006-07-19 21:07:27 +02:00
		114	container_type: Issue
		115	container_id: 2
		116	downloads: 0
		117	disk_filename: 060719210727_picture.jpg
		118	digest: b91e08d0cf966d5c6ff411bd8c4cc3a2
		119	id: 10
		120	filesize: 452
		121	filename: picture.jpg
		122	author_id: 2
		123	content_type: image/jpeg
112	No newline at end of file	124

0

test/fixtures/journals.yml +7 0

@@ -13,4 +13,11 journals_002:
13	journalized_type: Issue	13	journalized_type: Issue
14	user_id: 2	14	user_id: 2
15	journalized_id: 1	15	journalized_id: 1
		16	journals_003:
		17	created_on: <%= 1.days.ago.to_date.to_s(:db) %>
		18	notes: "A comment with inline image: !picture.jpg!"
		19	id: 3
		20	journalized_type: Issue
		21	user_id: 2
		22	journalized_id: 2
16	No newline at end of file	23

0

test/functional/issues_controller_test.rb +8 0

                                             :child => { :tag => 'legend',
                                                         :content => /Notes/ } }
               end
+              def test_show_atom
+                get :show, :id => 2, :format => 'atom'
+                assert_response :success
+                assert_template 'changes'
+                # Inline image
+                assert @response.body.include?("&lt;img src=\"http://test.host/attachments/download/10\" alt=\"\" /&gt;")
+              end
               def test_show_export_to_pdf
                 get :show, :id => 3, :format => 'pdf'

0

test/unit/query_test.rb +7 -5

               def test_operator_contains
                 query = Query.new(:project => Project.find(1), :name => '_')
-                query.add_filter('subject', '~', ['string'])
+                query.add_filter('subject', '~', ['uNable'])
-                assert query.statement.include?("#{Issue.table_name}.subject LIKE '%string%'")
+                assert query.statement.include?("LOWER(#{Issue.table_name}.subject) LIKE '%unable%'")
-                find_issues_with_query(query)
+                result = find_issues_with_query(query)
+                assert result.empty?
+                result.each {|issue| assert issue.subject.downcase.include?('unable') }
               end
               def test_operator_does_not_contains
                 query = Query.new(:project => Project.find(1), :name => '_')
-                query.add_filter('subject', '!~', ['string'])
+                query.add_filter('subject', '!~', ['uNable'])
-                assert query.statement.include?("#{Issue.table_name}.subject NOT LIKE '%string%'")
+                assert query.statement.include?("LOWER(#{Issue.table_name}.subject) NOT LIKE '%unable%'")
                 find_issues_with_query(query)
               end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages