jro_apps/redmine Commit - r10966:93e0885b64d8

Link to attachment should return latest attachment (#7510)....

Jean-Philippe Lang -

r10966:93e0885b64d8

parent child

Context file:

r10966:93e0885b64d8

app/helpers/application_helper.rb +1 -1

                          end
                        when 'attachment'
                          attachments = options[:attachments] || (obj && obj.respond_to?(:attachments) ? obj.attachments : nil)
-                         if attachments && attachment = attachments.detect {|a| a.filename == name }
+                         if attachments && attachment = Attachment.latest_attach(attachments, name)
                            link = link_to_attachment(attachment, :only_path => only_path, :download => true, :class => 'attachment')
                          end
                        when 'project'

test/object_helpers.rb +12 0

                  board.save!
                  board
                end
+               def Attachment.generate!(attributes={})
+                 @generated_filename ||= 'testfile0'
+                 @generated_filename.succ!
+                 attributes = attributes.dup
+                 attachment = Attachment.new(attributes)
+                 attachment.container ||= Issue.find(1)
+                 attachment.author ||= User.find(2)
+                 attachment.filename = @generated_filename if attachment.filename.blank?
+                 attachment.save!
+                 attachment
+               end
              end

test/unit/helpers/application_helper_test.rb +9 0

                  to_test.each { |text, result| assert_equal "<p>#{result}</p>", textilizable(text, :attachments => Issue.find(3).attachments), "#{text} failed" }
                end
+               def test_attachment_link_should_link_to_latest_attachment
+                 set_tmp_attachments_directory
+                 a1 = Attachment.generate!(:filename => "test.txt", :created_on => 1.hour.ago)
+                 a2 = Attachment.generate!(:filename => "test.txt")
+                 assert_equal %(<p><a href="/attachments/download/#{a2.id}/test.txt" class="attachment">test.txt</a></p>),
+                   textilizable('attachment:test.txt', :attachments => [a1, a2])
+               end
                def test_wiki_links
                  to_test = {
                    '[[CookBook documentation]]' => '<a href="/projects/ecookbook/wiki/CookBook_documentation" class="wiki-page">CookBook documentation</a>',

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages