##// END OF EJS Templates
Adds a title to the issue link in the flash message....
Jean-Philippe Lang -
r10015:91c875437d5d
parent child
Show More
@@ -1,426 +1,426
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
24 24 before_filter :find_project, :only => [:new, :create]
25 25 before_filter :authorize, :except => [:index]
26 26 before_filter :find_optional_project, :only => [:index]
27 27 before_filter :check_for_default_issue_status, :only => [:new, :create]
28 28 before_filter :build_new_issue_from_params, :only => [:new, :create]
29 29 accept_rss_auth :index, :show
30 30 accept_api_auth :index, :show, :create, :update, :destroy
31 31
32 32 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
33 33
34 34 helper :journals
35 35 helper :projects
36 36 include ProjectsHelper
37 37 helper :custom_fields
38 38 include CustomFieldsHelper
39 39 helper :issue_relations
40 40 include IssueRelationsHelper
41 41 helper :watchers
42 42 include WatchersHelper
43 43 helper :attachments
44 44 include AttachmentsHelper
45 45 helper :queries
46 46 include QueriesHelper
47 47 helper :repositories
48 48 include RepositoriesHelper
49 49 helper :sort
50 50 include SortHelper
51 51 include IssuesHelper
52 52 helper :timelog
53 53 include Redmine::Export::PDF
54 54
55 55 def index
56 56 retrieve_query
57 57 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
58 58 sort_update(@query.sortable_columns)
59 59
60 60 if @query.valid?
61 61 case params[:format]
62 62 when 'csv', 'pdf'
63 63 @limit = Setting.issues_export_limit.to_i
64 64 when 'atom'
65 65 @limit = Setting.feeds_limit.to_i
66 66 when 'xml', 'json'
67 67 @offset, @limit = api_offset_and_limit
68 68 else
69 69 @limit = per_page_option
70 70 end
71 71
72 72 @issue_count = @query.issue_count
73 73 @issue_pages = Paginator.new self, @issue_count, @limit, params['page']
74 74 @offset ||= @issue_pages.current.offset
75 75 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
76 76 :order => sort_clause,
77 77 :offset => @offset,
78 78 :limit => @limit)
79 79 @issue_count_by_group = @query.issue_count_by_group
80 80
81 81 respond_to do |format|
82 82 format.html { render :template => 'issues/index', :layout => !request.xhr? }
83 83 format.api {
84 84 Issue.load_relations(@issues) if include_in_api_response?('relations')
85 85 }
86 86 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
87 87 format.csv { send_data(issues_to_csv(@issues, @project, @query, params), :type => 'text/csv; header=present', :filename => 'export.csv') }
88 88 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
89 89 end
90 90 else
91 91 respond_to do |format|
92 92 format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
93 93 format.any(:atom, :csv, :pdf) { render(:nothing => true) }
94 94 format.api { render_validation_errors(@query) }
95 95 end
96 96 end
97 97 rescue ActiveRecord::RecordNotFound
98 98 render_404
99 99 end
100 100
101 101 def show
102 102 @journals = @issue.journals.find(:all, :include => [:user, :details], :order => "#{Journal.table_name}.created_on ASC")
103 103 @journals.each_with_index {|j,i| j.indice = i+1}
104 104 @journals.reverse! if User.current.wants_comments_in_reverse_order?
105 105
106 106 @changesets = @issue.changesets.visible.all
107 107 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
108 108
109 109 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
110 110 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
111 111 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
112 112 @priorities = IssuePriority.active
113 113 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
114 114 respond_to do |format|
115 115 format.html {
116 116 retrieve_previous_and_next_issue_ids
117 117 render :template => 'issues/show'
118 118 }
119 119 format.api
120 120 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
121 121 format.pdf { send_data(issue_to_pdf(@issue), :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf") }
122 122 end
123 123 end
124 124
125 125 # Add a new issue
126 126 # The new issue will be created from an existing one if copy_from parameter is given
127 127 def new
128 128 respond_to do |format|
129 129 format.html { render :action => 'new', :layout => !request.xhr? }
130 130 format.js { render :partial => 'update_form' }
131 131 end
132 132 end
133 133
134 134 def create
135 135 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
136 136 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
137 137 if @issue.save
138 138 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
139 139 respond_to do |format|
140 140 format.html {
141 141 render_attachment_warning_if_needed(@issue)
142 flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue)))
142 flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
143 143 redirect_to(params[:continue] ? { :action => 'new', :project_id => @issue.project, :issue => {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?} } :
144 144 { :action => 'show', :id => @issue })
145 145 }
146 146 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
147 147 end
148 148 return
149 149 else
150 150 respond_to do |format|
151 151 format.html { render :action => 'new' }
152 152 format.api { render_validation_errors(@issue) }
153 153 end
154 154 end
155 155 end
156 156
157 157 def edit
158 158 return unless update_issue_from_params
159 159
160 160 respond_to do |format|
161 161 format.html { }
162 162 format.xml { }
163 163 end
164 164 end
165 165
166 166 def update
167 167 return unless update_issue_from_params
168 168 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
169 169 saved = false
170 170 begin
171 171 saved = @issue.save_issue_with_child_records(params, @time_entry)
172 172 rescue ActiveRecord::StaleObjectError
173 173 @conflict = true
174 174 if params[:last_journal_id]
175 175 @conflict_journals = @issue.journals_after(params[:last_journal_id]).all
176 176 end
177 177 end
178 178
179 179 if saved
180 180 render_attachment_warning_if_needed(@issue)
181 181 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
182 182
183 183 respond_to do |format|
184 184 format.html { redirect_back_or_default({:action => 'show', :id => @issue}) }
185 185 format.api { render_api_ok }
186 186 end
187 187 else
188 188 respond_to do |format|
189 189 format.html { render :action => 'edit' }
190 190 format.api { render_validation_errors(@issue) }
191 191 end
192 192 end
193 193 end
194 194
195 195 # Bulk edit/copy a set of issues
196 196 def bulk_edit
197 197 @issues.sort!
198 198 @copy = params[:copy].present?
199 199 @notes = params[:notes]
200 200
201 201 if User.current.allowed_to?(:move_issues, @projects)
202 202 @allowed_projects = Issue.allowed_target_projects_on_move
203 203 if params[:issue]
204 204 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
205 205 if @target_project
206 206 target_projects = [@target_project]
207 207 end
208 208 end
209 209 end
210 210 target_projects ||= @projects
211 211
212 212 if @copy
213 213 @available_statuses = [IssueStatus.default]
214 214 else
215 215 @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
216 216 end
217 217 @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.reduce(:&)
218 218 @assignables = target_projects.map(&:assignable_users).reduce(:&)
219 219 @trackers = target_projects.map(&:trackers).reduce(:&)
220 220 @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
221 221 @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
222 222 if @copy
223 223 @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
224 224 end
225 225
226 226 @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
227 227 render :layout => false if request.xhr?
228 228 end
229 229
230 230 def bulk_update
231 231 @issues.sort!
232 232 @copy = params[:copy].present?
233 233 attributes = parse_params_for_bulk_issue_attributes(params)
234 234
235 235 unsaved_issue_ids = []
236 236 moved_issues = []
237 237 @issues.each do |issue|
238 238 issue.reload
239 239 if @copy
240 240 issue = issue.copy({}, :attachments => params[:copy_attachments].present?)
241 241 end
242 242 journal = issue.init_journal(User.current, params[:notes])
243 243 issue.safe_attributes = attributes
244 244 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
245 245 if issue.save
246 246 moved_issues << issue
247 247 else
248 248 # Keep unsaved issue ids to display them in flash error
249 249 unsaved_issue_ids << issue.id
250 250 end
251 251 end
252 252 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
253 253
254 254 if params[:follow]
255 255 if @issues.size == 1 && moved_issues.size == 1
256 256 redirect_to :controller => 'issues', :action => 'show', :id => moved_issues.first
257 257 elsif moved_issues.map(&:project).uniq.size == 1
258 258 redirect_to :controller => 'issues', :action => 'index', :project_id => moved_issues.map(&:project).first
259 259 end
260 260 else
261 261 redirect_back_or_default({:controller => 'issues', :action => 'index', :project_id => @project})
262 262 end
263 263 end
264 264
265 265 def destroy
266 266 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
267 267 if @hours > 0
268 268 case params[:todo]
269 269 when 'destroy'
270 270 # nothing to do
271 271 when 'nullify'
272 272 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
273 273 when 'reassign'
274 274 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
275 275 if reassign_to.nil?
276 276 flash.now[:error] = l(:error_issue_not_found_in_project)
277 277 return
278 278 else
279 279 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
280 280 end
281 281 else
282 282 # display the destroy form if it's a user request
283 283 return unless api_request?
284 284 end
285 285 end
286 286 @issues.each do |issue|
287 287 begin
288 288 issue.reload.destroy
289 289 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
290 290 # nothing to do, issue was already deleted (eg. by a parent)
291 291 end
292 292 end
293 293 respond_to do |format|
294 294 format.html { redirect_back_or_default(:action => 'index', :project_id => @project) }
295 295 format.api { render_api_ok }
296 296 end
297 297 end
298 298
299 299 private
300 300 def find_issue
301 301 # Issue.visible.find(...) can not be used to redirect user to the login form
302 302 # if the issue actually exists but requires authentication
303 303 @issue = Issue.find(params[:id], :include => [:project, :tracker, :status, :author, :priority, :category])
304 304 unless @issue.visible?
305 305 deny_access
306 306 return
307 307 end
308 308 @project = @issue.project
309 309 rescue ActiveRecord::RecordNotFound
310 310 render_404
311 311 end
312 312
313 313 def find_project
314 314 project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
315 315 @project = Project.find(project_id)
316 316 rescue ActiveRecord::RecordNotFound
317 317 render_404
318 318 end
319 319
320 320 def retrieve_previous_and_next_issue_ids
321 321 retrieve_query_from_session
322 322 if @query
323 323 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
324 324 sort_update(@query.sortable_columns, 'issues_index_sort')
325 325 limit = 500
326 326 issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
327 327 if (idx = issue_ids.index(@issue.id)) && idx < limit
328 328 if issue_ids.size < 500
329 329 @issue_position = idx + 1
330 330 @issue_count = issue_ids.size
331 331 end
332 332 @prev_issue_id = issue_ids[idx - 1] if idx > 0
333 333 @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
334 334 end
335 335 end
336 336 end
337 337
338 338 # Used by #edit and #update to set some common instance variables
339 339 # from the params
340 340 # TODO: Refactor, not everything in here is needed by #edit
341 341 def update_issue_from_params
342 342 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
343 343 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
344 344 @time_entry.attributes = params[:time_entry]
345 345
346 346 @notes = params[:notes] || (params[:issue].present? ? params[:issue][:notes] : nil)
347 347 @issue.init_journal(User.current, @notes)
348 348
349 349 issue_attributes = params[:issue]
350 350 if issue_attributes && params[:conflict_resolution]
351 351 case params[:conflict_resolution]
352 352 when 'overwrite'
353 353 issue_attributes = issue_attributes.dup
354 354 issue_attributes.delete(:lock_version)
355 355 when 'add_notes'
356 356 issue_attributes = {}
357 357 when 'cancel'
358 358 redirect_to issue_path(@issue)
359 359 return false
360 360 end
361 361 end
362 362 @issue.safe_attributes = issue_attributes
363 363 @priorities = IssuePriority.active
364 364 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
365 365 true
366 366 end
367 367
368 368 # TODO: Refactor, lots of extra code in here
369 369 # TODO: Changing tracker on an existing issue should not trigger this
370 370 def build_new_issue_from_params
371 371 if params[:id].blank?
372 372 @issue = Issue.new
373 373 if params[:copy_from]
374 374 begin
375 375 @copy_from = Issue.visible.find(params[:copy_from])
376 376 @copy_attachments = params[:copy_attachments].present? || request.get?
377 377 @issue.copy_from(@copy_from, :attachments => @copy_attachments)
378 378 rescue ActiveRecord::RecordNotFound
379 379 render_404
380 380 return
381 381 end
382 382 end
383 383 @issue.project = @project
384 384 else
385 385 @issue = @project.issues.visible.find(params[:id])
386 386 end
387 387
388 388 @issue.project = @project
389 389 @issue.author = User.current
390 390 # Tracker must be set before custom field values
391 391 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
392 392 if @issue.tracker.nil?
393 393 render_error l(:error_no_tracker_in_project)
394 394 return false
395 395 end
396 396 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
397 397 @issue.safe_attributes = params[:issue]
398 398
399 399 @priorities = IssuePriority.active
400 400 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
401 401 @available_watchers = (@issue.project.users.sort + @issue.watcher_users).uniq
402 402 end
403 403
404 404 def check_for_default_issue_status
405 405 if IssueStatus.default.nil?
406 406 render_error l(:error_no_default_issue_status)
407 407 return false
408 408 end
409 409 end
410 410
411 411 def parse_params_for_bulk_issue_attributes(params)
412 412 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
413 413 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
414 414 if custom = attributes[:custom_field_values]
415 415 custom.reject! {|k,v| v.blank?}
416 416 custom.keys.each do |k|
417 417 if custom[k].is_a?(Array)
418 418 custom[k] << '' if custom[k].delete('__none__')
419 419 else
420 420 custom[k] = '' if custom[k] == '__none__'
421 421 end
422 422 end
423 423 end
424 424 attributes
425 425 end
426 426 end
@@ -1,3577 +1,3577
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19 require 'issues_controller'
20 20
21 21 class IssuesControllerTest < ActionController::TestCase
22 22 fixtures :projects,
23 23 :users,
24 24 :roles,
25 25 :members,
26 26 :member_roles,
27 27 :issues,
28 28 :issue_statuses,
29 29 :versions,
30 30 :trackers,
31 31 :projects_trackers,
32 32 :issue_categories,
33 33 :enabled_modules,
34 34 :enumerations,
35 35 :attachments,
36 36 :workflows,
37 37 :custom_fields,
38 38 :custom_values,
39 39 :custom_fields_projects,
40 40 :custom_fields_trackers,
41 41 :time_entries,
42 42 :journals,
43 43 :journal_details,
44 44 :queries,
45 45 :repositories,
46 46 :changesets
47 47
48 48 include Redmine::I18n
49 49
50 50 def setup
51 51 @controller = IssuesController.new
52 52 @request = ActionController::TestRequest.new
53 53 @response = ActionController::TestResponse.new
54 54 User.current = nil
55 55 end
56 56
57 57 def test_index
58 58 with_settings :default_language => "en" do
59 59 get :index
60 60 assert_response :success
61 61 assert_template 'index'
62 62 assert_not_nil assigns(:issues)
63 63 assert_nil assigns(:project)
64 64 assert_tag :tag => 'a', :content => /Can't print recipes/
65 65 assert_tag :tag => 'a', :content => /Subproject issue/
66 66 # private projects hidden
67 67 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
68 68 assert_no_tag :tag => 'a', :content => /Issue on project 2/
69 69 # project column
70 70 assert_tag :tag => 'th', :content => /Project/
71 71 end
72 72 end
73 73
74 74 def test_index_should_not_list_issues_when_module_disabled
75 75 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
76 76 get :index
77 77 assert_response :success
78 78 assert_template 'index'
79 79 assert_not_nil assigns(:issues)
80 80 assert_nil assigns(:project)
81 81 assert_no_tag :tag => 'a', :content => /Can't print recipes/
82 82 assert_tag :tag => 'a', :content => /Subproject issue/
83 83 end
84 84
85 85 def test_index_should_list_visible_issues_only
86 86 get :index, :per_page => 100
87 87 assert_response :success
88 88 assert_not_nil assigns(:issues)
89 89 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
90 90 end
91 91
92 92 def test_index_with_project
93 93 Setting.display_subprojects_issues = 0
94 94 get :index, :project_id => 1
95 95 assert_response :success
96 96 assert_template 'index'
97 97 assert_not_nil assigns(:issues)
98 98 assert_tag :tag => 'a', :content => /Can't print recipes/
99 99 assert_no_tag :tag => 'a', :content => /Subproject issue/
100 100 end
101 101
102 102 def test_index_with_project_and_subprojects
103 103 Setting.display_subprojects_issues = 1
104 104 get :index, :project_id => 1
105 105 assert_response :success
106 106 assert_template 'index'
107 107 assert_not_nil assigns(:issues)
108 108 assert_tag :tag => 'a', :content => /Can't print recipes/
109 109 assert_tag :tag => 'a', :content => /Subproject issue/
110 110 assert_no_tag :tag => 'a', :content => /Issue of a private subproject/
111 111 end
112 112
113 113 def test_index_with_project_and_subprojects_should_show_private_subprojects
114 114 @request.session[:user_id] = 2
115 115 Setting.display_subprojects_issues = 1
116 116 get :index, :project_id => 1
117 117 assert_response :success
118 118 assert_template 'index'
119 119 assert_not_nil assigns(:issues)
120 120 assert_tag :tag => 'a', :content => /Can't print recipes/
121 121 assert_tag :tag => 'a', :content => /Subproject issue/
122 122 assert_tag :tag => 'a', :content => /Issue of a private subproject/
123 123 end
124 124
125 125 def test_index_with_project_and_default_filter
126 126 get :index, :project_id => 1, :set_filter => 1
127 127 assert_response :success
128 128 assert_template 'index'
129 129 assert_not_nil assigns(:issues)
130 130
131 131 query = assigns(:query)
132 132 assert_not_nil query
133 133 # default filter
134 134 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
135 135 end
136 136
137 137 def test_index_with_project_and_filter
138 138 get :index, :project_id => 1, :set_filter => 1,
139 139 :f => ['tracker_id'],
140 140 :op => {'tracker_id' => '='},
141 141 :v => {'tracker_id' => ['1']}
142 142 assert_response :success
143 143 assert_template 'index'
144 144 assert_not_nil assigns(:issues)
145 145
146 146 query = assigns(:query)
147 147 assert_not_nil query
148 148 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
149 149 end
150 150
151 151 def test_index_with_short_filters
152 152 to_test = {
153 153 'status_id' => {
154 154 'o' => { :op => 'o', :values => [''] },
155 155 'c' => { :op => 'c', :values => [''] },
156 156 '7' => { :op => '=', :values => ['7'] },
157 157 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
158 158 '=7' => { :op => '=', :values => ['7'] },
159 159 '!3' => { :op => '!', :values => ['3'] },
160 160 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
161 161 'subject' => {
162 162 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
163 163 'o' => { :op => '=', :values => ['o'] },
164 164 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
165 165 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
166 166 'tracker_id' => {
167 167 '3' => { :op => '=', :values => ['3'] },
168 168 '=3' => { :op => '=', :values => ['3'] }},
169 169 'start_date' => {
170 170 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
171 171 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
172 172 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
173 173 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
174 174 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
175 175 '<t+2' => { :op => '<t+', :values => ['2'] },
176 176 '>t+2' => { :op => '>t+', :values => ['2'] },
177 177 't+2' => { :op => 't+', :values => ['2'] },
178 178 't' => { :op => 't', :values => [''] },
179 179 'w' => { :op => 'w', :values => [''] },
180 180 '>t-2' => { :op => '>t-', :values => ['2'] },
181 181 '<t-2' => { :op => '<t-', :values => ['2'] },
182 182 't-2' => { :op => 't-', :values => ['2'] }},
183 183 'created_on' => {
184 184 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
185 185 '<t-2' => { :op => '<t-', :values => ['2'] },
186 186 '>t-2' => { :op => '>t-', :values => ['2'] },
187 187 't-2' => { :op => 't-', :values => ['2'] }},
188 188 'cf_1' => {
189 189 'c' => { :op => '=', :values => ['c'] },
190 190 '!c' => { :op => '!', :values => ['c'] },
191 191 '!*' => { :op => '!*', :values => [''] },
192 192 '*' => { :op => '*', :values => [''] }},
193 193 'estimated_hours' => {
194 194 '=13.4' => { :op => '=', :values => ['13.4'] },
195 195 '>=45' => { :op => '>=', :values => ['45'] },
196 196 '<=125' => { :op => '<=', :values => ['125'] },
197 197 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
198 198 '!*' => { :op => '!*', :values => [''] },
199 199 '*' => { :op => '*', :values => [''] }}
200 200 }
201 201
202 202 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
203 203
204 204 to_test.each do |field, expression_and_expected|
205 205 expression_and_expected.each do |filter_expression, expected|
206 206
207 207 get :index, :set_filter => 1, field => filter_expression
208 208
209 209 assert_response :success
210 210 assert_template 'index'
211 211 assert_not_nil assigns(:issues)
212 212
213 213 query = assigns(:query)
214 214 assert_not_nil query
215 215 assert query.has_filter?(field)
216 216 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
217 217 end
218 218 end
219 219 end
220 220
221 221 def test_index_with_project_and_empty_filters
222 222 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
223 223 assert_response :success
224 224 assert_template 'index'
225 225 assert_not_nil assigns(:issues)
226 226
227 227 query = assigns(:query)
228 228 assert_not_nil query
229 229 # no filter
230 230 assert_equal({}, query.filters)
231 231 end
232 232
233 233 def test_index_with_project_custom_field_filter
234 234 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
235 235 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
236 236 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
237 237 filter_name = "project.cf_#{field.id}"
238 238 @request.session[:user_id] = 1
239 239
240 240 get :index, :set_filter => 1,
241 241 :f => [filter_name],
242 242 :op => {filter_name => '='},
243 243 :v => {filter_name => ['Foo']}
244 244 assert_response :success
245 245 assert_template 'index'
246 246 assert_equal [3, 5], assigns(:issues).map(&:project_id).uniq.sort
247 247 end
248 248
249 249 def test_index_with_query
250 250 get :index, :project_id => 1, :query_id => 5
251 251 assert_response :success
252 252 assert_template 'index'
253 253 assert_not_nil assigns(:issues)
254 254 assert_nil assigns(:issue_count_by_group)
255 255 end
256 256
257 257 def test_index_with_query_grouped_by_tracker
258 258 get :index, :project_id => 1, :query_id => 6
259 259 assert_response :success
260 260 assert_template 'index'
261 261 assert_not_nil assigns(:issues)
262 262 assert_not_nil assigns(:issue_count_by_group)
263 263 end
264 264
265 265 def test_index_with_query_grouped_by_list_custom_field
266 266 get :index, :project_id => 1, :query_id => 9
267 267 assert_response :success
268 268 assert_template 'index'
269 269 assert_not_nil assigns(:issues)
270 270 assert_not_nil assigns(:issue_count_by_group)
271 271 end
272 272
273 273 def test_index_with_query_grouped_by_user_custom_field
274 274 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
275 275 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
276 276 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
277 277 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
278 278 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
279 279
280 280 get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
281 281 assert_response :success
282 282
283 283 assert_select 'tr.group', 3
284 284 assert_select 'tr.group' do
285 285 assert_select 'a', :text => 'John Smith'
286 286 assert_select 'span.count', :text => '(1)'
287 287 end
288 288 assert_select 'tr.group' do
289 289 assert_select 'a', :text => 'Dave Lopper'
290 290 assert_select 'span.count', :text => '(2)'
291 291 end
292 292 end
293 293
294 294 def test_index_with_query_id_and_project_id_should_set_session_query
295 295 get :index, :project_id => 1, :query_id => 4
296 296 assert_response :success
297 297 assert_kind_of Hash, session[:query]
298 298 assert_equal 4, session[:query][:id]
299 299 assert_equal 1, session[:query][:project_id]
300 300 end
301 301
302 302 def test_index_with_invalid_query_id_should_respond_404
303 303 get :index, :project_id => 1, :query_id => 999
304 304 assert_response 404
305 305 end
306 306
307 307 def test_index_with_cross_project_query_in_session_should_show_project_issues
308 308 q = Query.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
309 309 @request.session[:query] = {:id => q.id, :project_id => 1}
310 310
311 311 with_settings :display_subprojects_issues => '0' do
312 312 get :index, :project_id => 1
313 313 end
314 314 assert_response :success
315 315 assert_not_nil assigns(:query)
316 316 assert_equal q.id, assigns(:query).id
317 317 assert_equal 1, assigns(:query).project_id
318 318 assert_equal [1], assigns(:issues).map(&:project_id).uniq
319 319 end
320 320
321 321 def test_private_query_should_not_be_available_to_other_users
322 322 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
323 323 @request.session[:user_id] = 3
324 324
325 325 get :index, :query_id => q.id
326 326 assert_response 403
327 327 end
328 328
329 329 def test_private_query_should_be_available_to_its_user
330 330 q = Query.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
331 331 @request.session[:user_id] = 2
332 332
333 333 get :index, :query_id => q.id
334 334 assert_response :success
335 335 end
336 336
337 337 def test_public_query_should_be_available_to_other_users
338 338 q = Query.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
339 339 @request.session[:user_id] = 3
340 340
341 341 get :index, :query_id => q.id
342 342 assert_response :success
343 343 end
344 344
345 345 def test_index_should_omit_page_param_in_export_links
346 346 get :index, :page => 2
347 347 assert_response :success
348 348 assert_select 'a.atom[href=/issues.atom]'
349 349 assert_select 'a.csv[href=/issues.csv]'
350 350 assert_select 'a.pdf[href=/issues.pdf]'
351 351 assert_select 'form#csv-export-form[action=/issues.csv]'
352 352 end
353 353
354 354 def test_index_csv
355 355 get :index, :format => 'csv'
356 356 assert_response :success
357 357 assert_not_nil assigns(:issues)
358 358 assert_equal 'text/csv; header=present', @response.content_type
359 359 assert @response.body.starts_with?("#,")
360 360 lines = @response.body.chomp.split("\n")
361 361 assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
362 362 end
363 363
364 364 def test_index_csv_with_project
365 365 get :index, :project_id => 1, :format => 'csv'
366 366 assert_response :success
367 367 assert_not_nil assigns(:issues)
368 368 assert_equal 'text/csv; header=present', @response.content_type
369 369 end
370 370
371 371 def test_index_csv_with_description
372 372 get :index, :format => 'csv', :description => '1'
373 373 assert_response :success
374 374 assert_not_nil assigns(:issues)
375 375 assert_equal 'text/csv; header=present', @response.content_type
376 376 assert @response.body.starts_with?("#,")
377 377 lines = @response.body.chomp.split("\n")
378 378 assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
379 379 end
380 380
381 381 def test_index_csv_with_spent_time_column
382 382 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column', :author_id => 2)
383 383 TimeEntry.create!(:project => issue.project, :issue => issue, :hours => 7.33, :user => User.find(2), :spent_on => Date.today)
384 384
385 385 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
386 386 assert_response :success
387 387 assert_equal 'text/csv; header=present', @response.content_type
388 388 lines = @response.body.chomp.split("\n")
389 389 assert_include "#{issue.id},#{issue.subject},7.33", lines
390 390 end
391 391
392 392 def test_index_csv_with_all_columns
393 393 get :index, :format => 'csv', :columns => 'all'
394 394 assert_response :success
395 395 assert_not_nil assigns(:issues)
396 396 assert_equal 'text/csv; header=present', @response.content_type
397 397 assert @response.body.starts_with?("#,")
398 398 lines = @response.body.chomp.split("\n")
399 399 assert_equal assigns(:query).available_columns.size + 1, lines[0].split(',').size
400 400 end
401 401
402 402 def test_index_csv_with_multi_column_field
403 403 CustomField.find(1).update_attribute :multiple, true
404 404 issue = Issue.find(1)
405 405 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
406 406 issue.save!
407 407
408 408 get :index, :format => 'csv', :columns => 'all'
409 409 assert_response :success
410 410 lines = @response.body.chomp.split("\n")
411 411 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
412 412 end
413 413
414 414 def test_index_csv_big_5
415 415 with_settings :default_language => "zh-TW" do
416 416 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
417 417 str_big5 = "\xa4@\xa4\xeb"
418 418 if str_utf8.respond_to?(:force_encoding)
419 419 str_utf8.force_encoding('UTF-8')
420 420 str_big5.force_encoding('Big5')
421 421 end
422 422 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
423 423 :status_id => 1, :priority => IssuePriority.all.first,
424 424 :subject => str_utf8)
425 425 assert issue.save
426 426
427 427 get :index, :project_id => 1,
428 428 :f => ['subject'],
429 429 :op => '=', :values => [str_utf8],
430 430 :format => 'csv'
431 431 assert_equal 'text/csv; header=present', @response.content_type
432 432 lines = @response.body.chomp.split("\n")
433 433 s1 = "\xaa\xac\xbaA"
434 434 if str_utf8.respond_to?(:force_encoding)
435 435 s1.force_encoding('Big5')
436 436 end
437 437 assert lines[0].include?(s1)
438 438 assert lines[1].include?(str_big5)
439 439 end
440 440 end
441 441
442 442 def test_index_csv_cannot_convert_should_be_replaced_big_5
443 443 with_settings :default_language => "zh-TW" do
444 444 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
445 445 if str_utf8.respond_to?(:force_encoding)
446 446 str_utf8.force_encoding('UTF-8')
447 447 end
448 448 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
449 449 :status_id => 1, :priority => IssuePriority.all.first,
450 450 :subject => str_utf8)
451 451 assert issue.save
452 452
453 453 get :index, :project_id => 1,
454 454 :f => ['subject'],
455 455 :op => '=', :values => [str_utf8],
456 456 :c => ['status', 'subject'],
457 457 :format => 'csv',
458 458 :set_filter => 1
459 459 assert_equal 'text/csv; header=present', @response.content_type
460 460 lines = @response.body.chomp.split("\n")
461 461 s1 = "\xaa\xac\xbaA" # status
462 462 if str_utf8.respond_to?(:force_encoding)
463 463 s1.force_encoding('Big5')
464 464 end
465 465 assert lines[0].include?(s1)
466 466 s2 = lines[1].split(",")[2]
467 467 if s1.respond_to?(:force_encoding)
468 468 s3 = "\xa5H?" # subject
469 469 s3.force_encoding('Big5')
470 470 assert_equal s3, s2
471 471 elsif RUBY_PLATFORM == 'java'
472 472 assert_equal "??", s2
473 473 else
474 474 assert_equal "\xa5H???", s2
475 475 end
476 476 end
477 477 end
478 478
479 479 def test_index_csv_tw
480 480 with_settings :default_language => "zh-TW" do
481 481 str1 = "test_index_csv_tw"
482 482 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
483 483 :status_id => 1, :priority => IssuePriority.all.first,
484 484 :subject => str1, :estimated_hours => '1234.5')
485 485 assert issue.save
486 486 assert_equal 1234.5, issue.estimated_hours
487 487
488 488 get :index, :project_id => 1,
489 489 :f => ['subject'],
490 490 :op => '=', :values => [str1],
491 491 :c => ['estimated_hours', 'subject'],
492 492 :format => 'csv',
493 493 :set_filter => 1
494 494 assert_equal 'text/csv; header=present', @response.content_type
495 495 lines = @response.body.chomp.split("\n")
496 496 assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
497 497
498 498 str_tw = "Traditional Chinese (\xe7\xb9\x81\xe9\xab\x94\xe4\xb8\xad\xe6\x96\x87)"
499 499 if str_tw.respond_to?(:force_encoding)
500 500 str_tw.force_encoding('UTF-8')
501 501 end
502 502 assert_equal str_tw, l(:general_lang_name)
503 503 assert_equal ',', l(:general_csv_separator)
504 504 assert_equal '.', l(:general_csv_decimal_separator)
505 505 end
506 506 end
507 507
508 508 def test_index_csv_fr
509 509 with_settings :default_language => "fr" do
510 510 str1 = "test_index_csv_fr"
511 511 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
512 512 :status_id => 1, :priority => IssuePriority.all.first,
513 513 :subject => str1, :estimated_hours => '1234.5')
514 514 assert issue.save
515 515 assert_equal 1234.5, issue.estimated_hours
516 516
517 517 get :index, :project_id => 1,
518 518 :f => ['subject'],
519 519 :op => '=', :values => [str1],
520 520 :c => ['estimated_hours', 'subject'],
521 521 :format => 'csv',
522 522 :set_filter => 1
523 523 assert_equal 'text/csv; header=present', @response.content_type
524 524 lines = @response.body.chomp.split("\n")
525 525 assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
526 526
527 527 str_fr = "Fran\xc3\xa7ais"
528 528 if str_fr.respond_to?(:force_encoding)
529 529 str_fr.force_encoding('UTF-8')
530 530 end
531 531 assert_equal str_fr, l(:general_lang_name)
532 532 assert_equal ';', l(:general_csv_separator)
533 533 assert_equal ',', l(:general_csv_decimal_separator)
534 534 end
535 535 end
536 536
537 537 def test_index_pdf
538 538 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
539 539 with_settings :default_language => lang do
540 540
541 541 get :index
542 542 assert_response :success
543 543 assert_template 'index'
544 544
545 545 if lang == "ja"
546 546 if RUBY_PLATFORM != 'java'
547 547 assert_equal "CP932", l(:general_pdf_encoding)
548 548 end
549 549 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
550 550 next
551 551 end
552 552 end
553 553
554 554 get :index, :format => 'pdf'
555 555 assert_response :success
556 556 assert_not_nil assigns(:issues)
557 557 assert_equal 'application/pdf', @response.content_type
558 558
559 559 get :index, :project_id => 1, :format => 'pdf'
560 560 assert_response :success
561 561 assert_not_nil assigns(:issues)
562 562 assert_equal 'application/pdf', @response.content_type
563 563
564 564 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
565 565 assert_response :success
566 566 assert_not_nil assigns(:issues)
567 567 assert_equal 'application/pdf', @response.content_type
568 568 end
569 569 end
570 570 end
571 571
572 572 def test_index_pdf_with_query_grouped_by_list_custom_field
573 573 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
574 574 assert_response :success
575 575 assert_not_nil assigns(:issues)
576 576 assert_not_nil assigns(:issue_count_by_group)
577 577 assert_equal 'application/pdf', @response.content_type
578 578 end
579 579
580 580 def test_index_atom
581 581 get :index, :project_id => 'ecookbook', :format => 'atom'
582 582 assert_response :success
583 583 assert_template 'common/feed'
584 584
585 585 assert_tag :tag => 'link', :parent => {:tag => 'feed', :parent => nil },
586 586 :attributes => {:rel => 'self', :href => 'http://test.host/projects/ecookbook/issues.atom'}
587 587 assert_tag :tag => 'link', :parent => {:tag => 'feed', :parent => nil },
588 588 :attributes => {:rel => 'alternate', :href => 'http://test.host/projects/ecookbook/issues'}
589 589
590 590 assert_tag :tag => 'entry', :child => {
591 591 :tag => 'link',
592 592 :attributes => {:href => 'http://test.host/issues/1'}}
593 593 end
594 594
595 595 def test_index_sort
596 596 get :index, :sort => 'tracker,id:desc'
597 597 assert_response :success
598 598
599 599 sort_params = @request.session['issues_index_sort']
600 600 assert sort_params.is_a?(String)
601 601 assert_equal 'tracker,id:desc', sort_params
602 602
603 603 issues = assigns(:issues)
604 604 assert_not_nil issues
605 605 assert !issues.empty?
606 606 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
607 607 end
608 608
609 609 def test_index_sort_by_field_not_included_in_columns
610 610 Setting.issue_list_default_columns = %w(subject author)
611 611 get :index, :sort => 'tracker'
612 612 end
613 613
614 614 def test_index_sort_by_assigned_to
615 615 get :index, :sort => 'assigned_to'
616 616 assert_response :success
617 617 assignees = assigns(:issues).collect(&:assigned_to).compact
618 618 assert_equal assignees.sort, assignees
619 619 end
620 620
621 621 def test_index_sort_by_assigned_to_desc
622 622 get :index, :sort => 'assigned_to:desc'
623 623 assert_response :success
624 624 assignees = assigns(:issues).collect(&:assigned_to).compact
625 625 assert_equal assignees.sort.reverse, assignees
626 626 end
627 627
628 628 def test_index_group_by_assigned_to
629 629 get :index, :group_by => 'assigned_to', :sort => 'priority'
630 630 assert_response :success
631 631 end
632 632
633 633 def test_index_sort_by_author
634 634 get :index, :sort => 'author'
635 635 assert_response :success
636 636 authors = assigns(:issues).collect(&:author)
637 637 assert_equal authors.sort, authors
638 638 end
639 639
640 640 def test_index_sort_by_author_desc
641 641 get :index, :sort => 'author:desc'
642 642 assert_response :success
643 643 authors = assigns(:issues).collect(&:author)
644 644 assert_equal authors.sort.reverse, authors
645 645 end
646 646
647 647 def test_index_group_by_author
648 648 get :index, :group_by => 'author', :sort => 'priority'
649 649 assert_response :success
650 650 end
651 651
652 652 def test_index_sort_by_spent_hours
653 653 get :index, :sort => 'spent_hours:desc'
654 654 assert_response :success
655 655 hours = assigns(:issues).collect(&:spent_hours)
656 656 assert_equal hours.sort.reverse, hours
657 657 end
658 658
659 659 def test_index_sort_by_user_custom_field
660 660 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
661 661 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
662 662 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
663 663 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
664 664 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
665 665
666 666 get :index, :project_id => 1, :set_filter => 1, :sort => "cf_#{cf.id},id"
667 667 assert_response :success
668 668
669 669 assert_equal [2, 3, 1], assigns(:issues).select {|issue| issue.custom_field_value(cf).present?}.map(&:id)
670 670 end
671 671
672 672 def test_index_with_columns
673 673 columns = ['tracker', 'subject', 'assigned_to']
674 674 get :index, :set_filter => 1, :c => columns
675 675 assert_response :success
676 676
677 677 # query should use specified columns
678 678 query = assigns(:query)
679 679 assert_kind_of Query, query
680 680 assert_equal columns, query.column_names.map(&:to_s)
681 681
682 682 # columns should be stored in session
683 683 assert_kind_of Hash, session[:query]
684 684 assert_kind_of Array, session[:query][:column_names]
685 685 assert_equal columns, session[:query][:column_names].map(&:to_s)
686 686
687 687 # ensure only these columns are kept in the selected columns list
688 688 assert_tag :tag => 'select', :attributes => { :id => 'selected_columns' },
689 689 :children => { :count => 3 }
690 690 assert_no_tag :tag => 'option', :attributes => { :value => 'project' },
691 691 :parent => { :tag => 'select', :attributes => { :id => "selected_columns" } }
692 692 end
693 693
694 694 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
695 695 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
696 696 get :index, :set_filter => 1
697 697
698 698 # query should use specified columns
699 699 query = assigns(:query)
700 700 assert_kind_of Query, query
701 701 assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
702 702 end
703 703
704 704 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
705 705 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
706 706 columns = ['tracker', 'subject', 'assigned_to']
707 707 get :index, :set_filter => 1, :c => columns
708 708
709 709 # query should use specified columns
710 710 query = assigns(:query)
711 711 assert_kind_of Query, query
712 712 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
713 713 end
714 714
715 715 def test_index_with_custom_field_column
716 716 columns = %w(tracker subject cf_2)
717 717 get :index, :set_filter => 1, :c => columns
718 718 assert_response :success
719 719
720 720 # query should use specified columns
721 721 query = assigns(:query)
722 722 assert_kind_of Query, query
723 723 assert_equal columns, query.column_names.map(&:to_s)
724 724
725 725 assert_tag :td,
726 726 :attributes => {:class => 'cf_2 string'},
727 727 :ancestor => {:tag => 'table', :attributes => {:class => /issues/}}
728 728 end
729 729
730 730 def test_index_with_multi_custom_field_column
731 731 field = CustomField.find(1)
732 732 field.update_attribute :multiple, true
733 733 issue = Issue.find(1)
734 734 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
735 735 issue.save!
736 736
737 737 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
738 738 assert_response :success
739 739
740 740 assert_tag :td,
741 741 :attributes => {:class => /cf_1/},
742 742 :content => 'MySQL, Oracle'
743 743 end
744 744
745 745 def test_index_with_multi_user_custom_field_column
746 746 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
747 747 :tracker_ids => [1], :is_for_all => true)
748 748 issue = Issue.find(1)
749 749 issue.custom_field_values = {field.id => ['2', '3']}
750 750 issue.save!
751 751
752 752 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
753 753 assert_response :success
754 754
755 755 assert_tag :td,
756 756 :attributes => {:class => /cf_#{field.id}/},
757 757 :child => {:tag => 'a', :content => 'John Smith'}
758 758 end
759 759
760 760 def test_index_with_date_column
761 761 Issue.find(1).update_attribute :start_date, '1987-08-24'
762 762
763 763 with_settings :date_format => '%d/%m/%Y' do
764 764 get :index, :set_filter => 1, :c => %w(start_date)
765 765 assert_tag 'td', :attributes => {:class => /start_date/}, :content => '24/08/1987'
766 766 end
767 767 end
768 768
769 769 def test_index_with_done_ratio
770 770 Issue.find(1).update_attribute :done_ratio, 40
771 771
772 772 get :index, :set_filter => 1, :c => %w(done_ratio)
773 773 assert_tag 'td', :attributes => {:class => /done_ratio/},
774 774 :child => {:tag => 'table', :attributes => {:class => 'progress'},
775 775 :descendant => {:tag => 'td', :attributes => {:class => 'closed', :style => 'width: 40%;'}}
776 776 }
777 777 end
778 778
779 779 def test_index_with_spent_hours_column
780 780 get :index, :set_filter => 1, :c => %w(subject spent_hours)
781 781
782 782 assert_tag 'tr', :attributes => {:id => 'issue-3'},
783 783 :child => {
784 784 :tag => 'td', :attributes => {:class => /spent_hours/}, :content => '1.00'
785 785 }
786 786 end
787 787
788 788 def test_index_should_not_show_spent_hours_column_without_permission
789 789 Role.anonymous.remove_permission! :view_time_entries
790 790 get :index, :set_filter => 1, :c => %w(subject spent_hours)
791 791
792 792 assert_no_tag 'td', :attributes => {:class => /spent_hours/}
793 793 end
794 794
795 795 def test_index_with_fixed_version
796 796 get :index, :set_filter => 1, :c => %w(fixed_version)
797 797 assert_tag 'td', :attributes => {:class => /fixed_version/},
798 798 :child => {:tag => 'a', :content => '1.0', :attributes => {:href => '/versions/2'}}
799 799 end
800 800
801 801 def test_index_send_html_if_query_is_invalid
802 802 get :index, :f => ['start_date'], :op => {:start_date => '='}
803 803 assert_equal 'text/html', @response.content_type
804 804 assert_template 'index'
805 805 end
806 806
807 807 def test_index_send_nothing_if_query_is_invalid
808 808 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
809 809 assert_equal 'text/csv', @response.content_type
810 810 assert @response.body.blank?
811 811 end
812 812
813 813 def test_show_by_anonymous
814 814 get :show, :id => 1
815 815 assert_response :success
816 816 assert_template 'show'
817 817 assert_not_nil assigns(:issue)
818 818 assert_equal Issue.find(1), assigns(:issue)
819 819
820 820 # anonymous role is allowed to add a note
821 821 assert_tag :tag => 'form',
822 822 :descendant => { :tag => 'fieldset',
823 823 :child => { :tag => 'legend',
824 824 :content => /Notes/ } }
825 825 assert_tag :tag => 'title',
826 826 :content => "Bug #1: Can't print recipes - eCookbook - Redmine"
827 827 end
828 828
829 829 def test_show_by_manager
830 830 @request.session[:user_id] = 2
831 831 get :show, :id => 1
832 832 assert_response :success
833 833
834 834 assert_tag :tag => 'a',
835 835 :content => /Quote/
836 836
837 837 assert_tag :tag => 'form',
838 838 :descendant => { :tag => 'fieldset',
839 839 :child => { :tag => 'legend',
840 840 :content => /Change properties/ } },
841 841 :descendant => { :tag => 'fieldset',
842 842 :child => { :tag => 'legend',
843 843 :content => /Log time/ } },
844 844 :descendant => { :tag => 'fieldset',
845 845 :child => { :tag => 'legend',
846 846 :content => /Notes/ } }
847 847 end
848 848
849 849 def test_show_should_display_update_form
850 850 @request.session[:user_id] = 2
851 851 get :show, :id => 1
852 852 assert_response :success
853 853
854 854 assert_tag 'form', :attributes => {:id => 'issue-form'}
855 855 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
856 856 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
857 857 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
858 858 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
859 859 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
860 860 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
861 861 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
862 862 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
863 863 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
864 864 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
865 865 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
866 866 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
867 867 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
868 868 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
869 869 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
870 870 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
871 871 assert_tag 'textarea', :attributes => {:name => 'notes'}
872 872 end
873 873
874 874 def test_show_should_display_update_form_with_minimal_permissions
875 875 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
876 876 WorkflowTransition.delete_all :role_id => 1
877 877
878 878 @request.session[:user_id] = 2
879 879 get :show, :id => 1
880 880 assert_response :success
881 881
882 882 assert_tag 'form', :attributes => {:id => 'issue-form'}
883 883 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
884 884 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
885 885 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
886 886 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
887 887 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
888 888 assert_no_tag 'select', :attributes => {:name => 'issue[status_id]'}
889 889 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
890 890 assert_no_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
891 891 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
892 892 assert_no_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
893 893 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
894 894 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
895 895 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
896 896 assert_no_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
897 897 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
898 898 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
899 899 assert_tag 'textarea', :attributes => {:name => 'notes'}
900 900 end
901 901
902 902 def test_show_should_display_update_form_with_workflow_permissions
903 903 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
904 904
905 905 @request.session[:user_id] = 2
906 906 get :show, :id => 1
907 907 assert_response :success
908 908
909 909 assert_tag 'form', :attributes => {:id => 'issue-form'}
910 910 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
911 911 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
912 912 assert_no_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
913 913 assert_no_tag 'input', :attributes => {:name => 'issue[subject]'}
914 914 assert_no_tag 'textarea', :attributes => {:name => 'issue[description]'}
915 915 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
916 916 assert_no_tag 'select', :attributes => {:name => 'issue[priority_id]'}
917 917 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
918 918 assert_no_tag 'select', :attributes => {:name => 'issue[category_id]'}
919 919 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
920 920 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
921 921 assert_no_tag 'input', :attributes => {:name => 'issue[start_date]'}
922 922 assert_no_tag 'input', :attributes => {:name => 'issue[due_date]'}
923 923 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
924 924 assert_no_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]' }
925 925 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
926 926 assert_tag 'textarea', :attributes => {:name => 'notes'}
927 927 end
928 928
929 929 def test_show_should_not_display_update_form_without_permissions
930 930 Role.find(1).update_attribute :permissions, [:view_issues]
931 931
932 932 @request.session[:user_id] = 2
933 933 get :show, :id => 1
934 934 assert_response :success
935 935
936 936 assert_no_tag 'form', :attributes => {:id => 'issue-form'}
937 937 end
938 938
939 939 def test_update_form_should_not_display_inactive_enumerations
940 940 @request.session[:user_id] = 2
941 941 get :show, :id => 1
942 942 assert_response :success
943 943
944 944 assert ! IssuePriority.find(15).active?
945 945 assert_no_tag :option, :attributes => {:value => '15'},
946 946 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
947 947 end
948 948
949 949 def test_update_form_should_allow_attachment_upload
950 950 @request.session[:user_id] = 2
951 951 get :show, :id => 1
952 952
953 953 assert_tag :tag => 'form',
954 954 :attributes => {:id => 'issue-form', :method => 'post', :enctype => 'multipart/form-data'},
955 955 :descendant => {
956 956 :tag => 'input',
957 957 :attributes => {:type => 'file', :name => 'attachments[1][file]'}
958 958 }
959 959 end
960 960
961 961 def test_show_should_deny_anonymous_access_without_permission
962 962 Role.anonymous.remove_permission!(:view_issues)
963 963 get :show, :id => 1
964 964 assert_response :redirect
965 965 end
966 966
967 967 def test_show_should_deny_anonymous_access_to_private_issue
968 968 Issue.update_all(["is_private = ?", true], "id = 1")
969 969 get :show, :id => 1
970 970 assert_response :redirect
971 971 end
972 972
973 973 def test_show_should_deny_non_member_access_without_permission
974 974 Role.non_member.remove_permission!(:view_issues)
975 975 @request.session[:user_id] = 9
976 976 get :show, :id => 1
977 977 assert_response 403
978 978 end
979 979
980 980 def test_show_should_deny_non_member_access_to_private_issue
981 981 Issue.update_all(["is_private = ?", true], "id = 1")
982 982 @request.session[:user_id] = 9
983 983 get :show, :id => 1
984 984 assert_response 403
985 985 end
986 986
987 987 def test_show_should_deny_member_access_without_permission
988 988 Role.find(1).remove_permission!(:view_issues)
989 989 @request.session[:user_id] = 2
990 990 get :show, :id => 1
991 991 assert_response 403
992 992 end
993 993
994 994 def test_show_should_deny_member_access_to_private_issue_without_permission
995 995 Issue.update_all(["is_private = ?", true], "id = 1")
996 996 @request.session[:user_id] = 3
997 997 get :show, :id => 1
998 998 assert_response 403
999 999 end
1000 1000
1001 1001 def test_show_should_allow_author_access_to_private_issue
1002 1002 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
1003 1003 @request.session[:user_id] = 3
1004 1004 get :show, :id => 1
1005 1005 assert_response :success
1006 1006 end
1007 1007
1008 1008 def test_show_should_allow_assignee_access_to_private_issue
1009 1009 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
1010 1010 @request.session[:user_id] = 3
1011 1011 get :show, :id => 1
1012 1012 assert_response :success
1013 1013 end
1014 1014
1015 1015 def test_show_should_allow_member_access_to_private_issue_with_permission
1016 1016 Issue.update_all(["is_private = ?", true], "id = 1")
1017 1017 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
1018 1018 @request.session[:user_id] = 3
1019 1019 get :show, :id => 1
1020 1020 assert_response :success
1021 1021 end
1022 1022
1023 1023 def test_show_should_not_disclose_relations_to_invisible_issues
1024 1024 Setting.cross_project_issue_relations = '1'
1025 1025 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
1026 1026 # Relation to a private project issue
1027 1027 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
1028 1028
1029 1029 get :show, :id => 1
1030 1030 assert_response :success
1031 1031
1032 1032 assert_tag :div, :attributes => { :id => 'relations' },
1033 1033 :descendant => { :tag => 'a', :content => /#2$/ }
1034 1034 assert_no_tag :div, :attributes => { :id => 'relations' },
1035 1035 :descendant => { :tag => 'a', :content => /#4$/ }
1036 1036 end
1037 1037
1038 1038 def test_show_should_list_subtasks
1039 1039 Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1040 1040
1041 1041 get :show, :id => 1
1042 1042 assert_response :success
1043 1043 assert_tag 'div', :attributes => {:id => 'issue_tree'},
1044 1044 :descendant => {:tag => 'td', :content => /Child Issue/, :attributes => {:class => /subject/}}
1045 1045 end
1046 1046
1047 1047 def test_show_should_list_parents
1048 1048 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1049 1049
1050 1050 get :show, :id => issue.id
1051 1051 assert_response :success
1052 1052 assert_tag 'div', :attributes => {:class => 'subject'},
1053 1053 :descendant => {:tag => 'h3', :content => 'Child Issue'}
1054 1054 assert_tag 'div', :attributes => {:class => 'subject'},
1055 1055 :descendant => {:tag => 'a', :attributes => {:href => '/issues/1'}}
1056 1056 end
1057 1057
1058 1058 def test_show_should_not_display_prev_next_links_without_query_in_session
1059 1059 get :show, :id => 1
1060 1060 assert_response :success
1061 1061 assert_nil assigns(:prev_issue_id)
1062 1062 assert_nil assigns(:next_issue_id)
1063 1063
1064 1064 assert_no_tag 'div', :attributes => {:class => /next-prev-links/}
1065 1065 end
1066 1066
1067 1067 def test_show_should_display_prev_next_links_with_query_in_session
1068 1068 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1069 1069 @request.session['issues_index_sort'] = 'id'
1070 1070
1071 1071 with_settings :display_subprojects_issues => '0' do
1072 1072 get :show, :id => 3
1073 1073 end
1074 1074
1075 1075 assert_response :success
1076 1076 # Previous and next issues for all projects
1077 1077 assert_equal 2, assigns(:prev_issue_id)
1078 1078 assert_equal 5, assigns(:next_issue_id)
1079 1079
1080 1080 assert_tag 'div', :attributes => {:class => /next-prev-links/}
1081 1081 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Previous/
1082 1082 assert_tag 'a', :attributes => {:href => '/issues/5'}, :content => /Next/
1083 1083
1084 1084 count = Issue.open.visible.count
1085 1085 assert_tag 'span', :attributes => {:class => 'position'}, :content => "3 of #{count}"
1086 1086 end
1087 1087
1088 1088 def test_show_should_display_prev_next_links_with_saved_query_in_session
1089 1089 query = Query.create!(:name => 'test', :is_public => true, :user_id => 1,
1090 1090 :filters => {'status_id' => {:values => ['5'], :operator => '='}},
1091 1091 :sort_criteria => [['id', 'asc']])
1092 1092 @request.session[:query] = {:id => query.id, :project_id => nil}
1093 1093
1094 1094 get :show, :id => 11
1095 1095
1096 1096 assert_response :success
1097 1097 assert_equal query, assigns(:query)
1098 1098 # Previous and next issues for all projects
1099 1099 assert_equal 8, assigns(:prev_issue_id)
1100 1100 assert_equal 12, assigns(:next_issue_id)
1101 1101
1102 1102 assert_tag 'a', :attributes => {:href => '/issues/8'}, :content => /Previous/
1103 1103 assert_tag 'a', :attributes => {:href => '/issues/12'}, :content => /Next/
1104 1104 end
1105 1105
1106 1106 def test_show_should_display_prev_next_links_with_query_and_sort_on_association
1107 1107 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1108 1108
1109 1109 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
1110 1110 @request.session['issues_index_sort'] = assoc_sort
1111 1111
1112 1112 get :show, :id => 3
1113 1113 assert_response :success, "Wrong response status for #{assoc_sort} sort"
1114 1114
1115 1115 assert_tag 'div', :attributes => {:class => /next-prev-links/}, :content => /Previous/
1116 1116 assert_tag 'div', :attributes => {:class => /next-prev-links/}, :content => /Next/
1117 1117 end
1118 1118 end
1119 1119
1120 1120 def test_show_should_display_prev_next_links_with_project_query_in_session
1121 1121 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1122 1122 @request.session['issues_index_sort'] = 'id'
1123 1123
1124 1124 with_settings :display_subprojects_issues => '0' do
1125 1125 get :show, :id => 3
1126 1126 end
1127 1127
1128 1128 assert_response :success
1129 1129 # Previous and next issues inside project
1130 1130 assert_equal 2, assigns(:prev_issue_id)
1131 1131 assert_equal 7, assigns(:next_issue_id)
1132 1132
1133 1133 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Previous/
1134 1134 assert_tag 'a', :attributes => {:href => '/issues/7'}, :content => /Next/
1135 1135 end
1136 1136
1137 1137 def test_show_should_not_display_prev_link_for_first_issue
1138 1138 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1139 1139 @request.session['issues_index_sort'] = 'id'
1140 1140
1141 1141 with_settings :display_subprojects_issues => '0' do
1142 1142 get :show, :id => 1
1143 1143 end
1144 1144
1145 1145 assert_response :success
1146 1146 assert_nil assigns(:prev_issue_id)
1147 1147 assert_equal 2, assigns(:next_issue_id)
1148 1148
1149 1149 assert_no_tag 'a', :content => /Previous/
1150 1150 assert_tag 'a', :attributes => {:href => '/issues/2'}, :content => /Next/
1151 1151 end
1152 1152
1153 1153 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
1154 1154 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
1155 1155 @request.session['issues_index_sort'] = 'id'
1156 1156
1157 1157 get :show, :id => 1
1158 1158
1159 1159 assert_response :success
1160 1160 assert_nil assigns(:prev_issue_id)
1161 1161 assert_nil assigns(:next_issue_id)
1162 1162
1163 1163 assert_no_tag 'a', :content => /Previous/
1164 1164 assert_no_tag 'a', :content => /Next/
1165 1165 end
1166 1166
1167 1167 def test_show_show_should_display_prev_next_links_with_query_sort_by_user_custom_field
1168 1168 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
1169 1169 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
1170 1170 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
1171 1171 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
1172 1172 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
1173 1173
1174 1174 query = Query.create!(:name => 'test', :is_public => true, :user_id => 1, :filters => {},
1175 1175 :sort_criteria => [["cf_#{cf.id}", 'asc'], ['id', 'asc']])
1176 1176 @request.session[:query] = {:id => query.id, :project_id => nil}
1177 1177
1178 1178 get :show, :id => 3
1179 1179 assert_response :success
1180 1180
1181 1181 assert_equal 2, assigns(:prev_issue_id)
1182 1182 assert_equal 1, assigns(:next_issue_id)
1183 1183 end
1184 1184
1185 1185 def test_show_should_display_link_to_the_assignee
1186 1186 get :show, :id => 2
1187 1187 assert_response :success
1188 1188 assert_select '.assigned-to' do
1189 1189 assert_select 'a[href=/users/3]'
1190 1190 end
1191 1191 end
1192 1192
1193 1193 def test_show_should_display_visible_changesets_from_other_projects
1194 1194 project = Project.find(2)
1195 1195 issue = project.issues.first
1196 1196 issue.changeset_ids = [102]
1197 1197 issue.save!
1198 1198 project.disable_module! :repository
1199 1199
1200 1200 @request.session[:user_id] = 2
1201 1201 get :show, :id => issue.id
1202 1202 assert_tag 'a', :attributes => {:href => "/projects/ecookbook/repository/revisions/3"}
1203 1203 end
1204 1204
1205 1205 def test_show_should_display_watchers
1206 1206 @request.session[:user_id] = 2
1207 1207 Issue.find(1).add_watcher User.find(2)
1208 1208
1209 1209 get :show, :id => 1
1210 1210 assert_select 'div#watchers ul' do
1211 1211 assert_select 'li' do
1212 1212 assert_select 'a[href=/users/2]'
1213 1213 assert_select 'a img[alt=Delete]'
1214 1214 end
1215 1215 end
1216 1216 end
1217 1217
1218 1218 def test_show_should_display_watchers_with_gravatars
1219 1219 @request.session[:user_id] = 2
1220 1220 Issue.find(1).add_watcher User.find(2)
1221 1221
1222 1222 with_settings :gravatar_enabled => '1' do
1223 1223 get :show, :id => 1
1224 1224 end
1225 1225
1226 1226 assert_select 'div#watchers ul' do
1227 1227 assert_select 'li' do
1228 1228 assert_select 'img.gravatar'
1229 1229 assert_select 'a[href=/users/2]'
1230 1230 assert_select 'a img[alt=Delete]'
1231 1231 end
1232 1232 end
1233 1233 end
1234 1234
1235 1235 def test_show_with_thumbnails_enabled_should_display_thumbnails
1236 1236 @request.session[:user_id] = 2
1237 1237
1238 1238 with_settings :thumbnails_enabled => '1' do
1239 1239 get :show, :id => 14
1240 1240 assert_response :success
1241 1241 end
1242 1242
1243 1243 assert_select 'div.thumbnails' do
1244 1244 assert_select 'a[href=/attachments/16/testfile.png]' do
1245 1245 assert_select 'img[src=/attachments/thumbnail/16]'
1246 1246 end
1247 1247 end
1248 1248 end
1249 1249
1250 1250 def test_show_with_thumbnails_disabled_should_not_display_thumbnails
1251 1251 @request.session[:user_id] = 2
1252 1252
1253 1253 with_settings :thumbnails_enabled => '0' do
1254 1254 get :show, :id => 14
1255 1255 assert_response :success
1256 1256 end
1257 1257
1258 1258 assert_select 'div.thumbnails', 0
1259 1259 end
1260 1260
1261 1261 def test_show_with_multi_custom_field
1262 1262 field = CustomField.find(1)
1263 1263 field.update_attribute :multiple, true
1264 1264 issue = Issue.find(1)
1265 1265 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
1266 1266 issue.save!
1267 1267
1268 1268 get :show, :id => 1
1269 1269 assert_response :success
1270 1270
1271 1271 assert_tag :td, :content => 'MySQL, Oracle'
1272 1272 end
1273 1273
1274 1274 def test_show_with_multi_user_custom_field
1275 1275 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1276 1276 :tracker_ids => [1], :is_for_all => true)
1277 1277 issue = Issue.find(1)
1278 1278 issue.custom_field_values = {field.id => ['2', '3']}
1279 1279 issue.save!
1280 1280
1281 1281 get :show, :id => 1
1282 1282 assert_response :success
1283 1283
1284 1284 # TODO: should display links
1285 1285 assert_tag :td, :content => 'Dave Lopper, John Smith'
1286 1286 end
1287 1287
1288 1288 def test_show_atom
1289 1289 get :show, :id => 2, :format => 'atom'
1290 1290 assert_response :success
1291 1291 assert_template 'journals/index'
1292 1292 # Inline image
1293 1293 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1294 1294 end
1295 1295
1296 1296 def test_show_export_to_pdf
1297 1297 get :show, :id => 3, :format => 'pdf'
1298 1298 assert_response :success
1299 1299 assert_equal 'application/pdf', @response.content_type
1300 1300 assert @response.body.starts_with?('%PDF')
1301 1301 assert_not_nil assigns(:issue)
1302 1302 end
1303 1303
1304 1304 def test_show_export_to_pdf_with_ancestors
1305 1305 issue = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1306 1306
1307 1307 get :show, :id => issue.id, :format => 'pdf'
1308 1308 assert_response :success
1309 1309 assert_equal 'application/pdf', @response.content_type
1310 1310 assert @response.body.starts_with?('%PDF')
1311 1311 end
1312 1312
1313 1313 def test_show_export_to_pdf_with_descendants
1314 1314 c1 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1315 1315 c2 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1316 1316 c3 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => c1.id)
1317 1317
1318 1318 get :show, :id => 1, :format => 'pdf'
1319 1319 assert_response :success
1320 1320 assert_equal 'application/pdf', @response.content_type
1321 1321 assert @response.body.starts_with?('%PDF')
1322 1322 end
1323 1323
1324 1324 def test_show_export_to_pdf_with_journals
1325 1325 get :show, :id => 1, :format => 'pdf'
1326 1326 assert_response :success
1327 1327 assert_equal 'application/pdf', @response.content_type
1328 1328 assert @response.body.starts_with?('%PDF')
1329 1329 end
1330 1330
1331 1331 def test_show_export_to_pdf_with_changesets
1332 1332 Issue.find(3).changesets = Changeset.find_all_by_id(100, 101, 102)
1333 1333
1334 1334 get :show, :id => 3, :format => 'pdf'
1335 1335 assert_response :success
1336 1336 assert_equal 'application/pdf', @response.content_type
1337 1337 assert @response.body.starts_with?('%PDF')
1338 1338 end
1339 1339
1340 1340 def test_get_new
1341 1341 @request.session[:user_id] = 2
1342 1342 get :new, :project_id => 1, :tracker_id => 1
1343 1343 assert_response :success
1344 1344 assert_template 'new'
1345 1345
1346 1346 assert_tag 'input', :attributes => {:name => 'issue[is_private]'}
1347 1347 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
1348 1348 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
1349 1349 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
1350 1350 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
1351 1351 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
1352 1352 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
1353 1353 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
1354 1354 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
1355 1355 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
1356 1356 assert_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
1357 1357 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
1358 1358 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
1359 1359 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
1360 1360 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
1361 1361 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
1362 1362
1363 1363 # Be sure we don't display inactive IssuePriorities
1364 1364 assert ! IssuePriority.find(15).active?
1365 1365 assert_no_tag :option, :attributes => {:value => '15'},
1366 1366 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
1367 1367 end
1368 1368
1369 1369 def test_get_new_with_minimal_permissions
1370 1370 Role.find(1).update_attribute :permissions, [:add_issues]
1371 1371 WorkflowTransition.delete_all :role_id => 1
1372 1372
1373 1373 @request.session[:user_id] = 2
1374 1374 get :new, :project_id => 1, :tracker_id => 1
1375 1375 assert_response :success
1376 1376 assert_template 'new'
1377 1377
1378 1378 assert_no_tag 'input', :attributes => {:name => 'issue[is_private]'}
1379 1379 assert_no_tag 'select', :attributes => {:name => 'issue[project_id]'}
1380 1380 assert_tag 'select', :attributes => {:name => 'issue[tracker_id]'}
1381 1381 assert_tag 'input', :attributes => {:name => 'issue[subject]'}
1382 1382 assert_tag 'textarea', :attributes => {:name => 'issue[description]'}
1383 1383 assert_tag 'select', :attributes => {:name => 'issue[status_id]'}
1384 1384 assert_tag 'select', :attributes => {:name => 'issue[priority_id]'}
1385 1385 assert_tag 'select', :attributes => {:name => 'issue[assigned_to_id]'}
1386 1386 assert_tag 'select', :attributes => {:name => 'issue[category_id]'}
1387 1387 assert_tag 'select', :attributes => {:name => 'issue[fixed_version_id]'}
1388 1388 assert_no_tag 'input', :attributes => {:name => 'issue[parent_issue_id]'}
1389 1389 assert_tag 'input', :attributes => {:name => 'issue[start_date]'}
1390 1390 assert_tag 'input', :attributes => {:name => 'issue[due_date]'}
1391 1391 assert_tag 'select', :attributes => {:name => 'issue[done_ratio]'}
1392 1392 assert_tag 'input', :attributes => { :name => 'issue[custom_field_values][2]', :value => 'Default string' }
1393 1393 assert_no_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]'}
1394 1394 end
1395 1395
1396 1396 def test_get_new_with_list_custom_field
1397 1397 @request.session[:user_id] = 2
1398 1398 get :new, :project_id => 1, :tracker_id => 1
1399 1399 assert_response :success
1400 1400 assert_template 'new'
1401 1401
1402 1402 assert_tag 'select',
1403 1403 :attributes => {:name => 'issue[custom_field_values][1]', :class => 'list_cf'},
1404 1404 :children => {:count => 4},
1405 1405 :child => {:tag => 'option', :attributes => {:value => 'MySQL'}, :content => 'MySQL'}
1406 1406 end
1407 1407
1408 1408 def test_get_new_with_multi_custom_field
1409 1409 field = IssueCustomField.find(1)
1410 1410 field.update_attribute :multiple, true
1411 1411
1412 1412 @request.session[:user_id] = 2
1413 1413 get :new, :project_id => 1, :tracker_id => 1
1414 1414 assert_response :success
1415 1415 assert_template 'new'
1416 1416
1417 1417 assert_tag 'select',
1418 1418 :attributes => {:name => 'issue[custom_field_values][1][]', :multiple => 'multiple'},
1419 1419 :children => {:count => 3},
1420 1420 :child => {:tag => 'option', :attributes => {:value => 'MySQL'}, :content => 'MySQL'}
1421 1421 assert_tag 'input',
1422 1422 :attributes => {:name => 'issue[custom_field_values][1][]', :value => ''}
1423 1423 end
1424 1424
1425 1425 def test_get_new_with_multi_user_custom_field
1426 1426 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1427 1427 :tracker_ids => [1], :is_for_all => true)
1428 1428
1429 1429 @request.session[:user_id] = 2
1430 1430 get :new, :project_id => 1, :tracker_id => 1
1431 1431 assert_response :success
1432 1432 assert_template 'new'
1433 1433
1434 1434 assert_tag 'select',
1435 1435 :attributes => {:name => "issue[custom_field_values][#{field.id}][]", :multiple => 'multiple'},
1436 1436 :children => {:count => Project.find(1).users.count},
1437 1437 :child => {:tag => 'option', :attributes => {:value => '2'}, :content => 'John Smith'}
1438 1438 assert_tag 'input',
1439 1439 :attributes => {:name => "issue[custom_field_values][#{field.id}][]", :value => ''}
1440 1440 end
1441 1441
1442 1442 def test_get_new_with_date_custom_field
1443 1443 field = IssueCustomField.create!(:name => 'Date', :field_format => 'date', :tracker_ids => [1], :is_for_all => true)
1444 1444
1445 1445 @request.session[:user_id] = 2
1446 1446 get :new, :project_id => 1, :tracker_id => 1
1447 1447 assert_response :success
1448 1448
1449 1449 assert_select 'input[name=?]', "issue[custom_field_values][#{field.id}]"
1450 1450 end
1451 1451
1452 1452 def test_get_new_with_text_custom_field
1453 1453 field = IssueCustomField.create!(:name => 'Text', :field_format => 'text', :tracker_ids => [1], :is_for_all => true)
1454 1454
1455 1455 @request.session[:user_id] = 2
1456 1456 get :new, :project_id => 1, :tracker_id => 1
1457 1457 assert_response :success
1458 1458
1459 1459 assert_select 'textarea[name=?]', "issue[custom_field_values][#{field.id}]"
1460 1460 end
1461 1461
1462 1462 def test_get_new_without_default_start_date_is_creation_date
1463 1463 Setting.default_issue_start_date_to_creation_date = 0
1464 1464
1465 1465 @request.session[:user_id] = 2
1466 1466 get :new, :project_id => 1, :tracker_id => 1
1467 1467 assert_response :success
1468 1468 assert_template 'new'
1469 1469
1470 1470 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
1471 1471 :value => nil }
1472 1472 end
1473 1473
1474 1474 def test_get_new_with_default_start_date_is_creation_date
1475 1475 Setting.default_issue_start_date_to_creation_date = 1
1476 1476
1477 1477 @request.session[:user_id] = 2
1478 1478 get :new, :project_id => 1, :tracker_id => 1
1479 1479 assert_response :success
1480 1480 assert_template 'new'
1481 1481
1482 1482 assert_tag :tag => 'input', :attributes => { :name => 'issue[start_date]',
1483 1483 :value => Date.today.to_s }
1484 1484 end
1485 1485
1486 1486 def test_get_new_form_should_allow_attachment_upload
1487 1487 @request.session[:user_id] = 2
1488 1488 get :new, :project_id => 1, :tracker_id => 1
1489 1489
1490 1490 assert_select 'form[id=issue-form][method=post][enctype=multipart/form-data]' do
1491 1491 assert_select 'input[name=?][type=file]', 'attachments[1][file]'
1492 1492 assert_select 'input[name=?][maxlength=255]', 'attachments[1][description]'
1493 1493 end
1494 1494 end
1495 1495
1496 1496 def test_get_new_should_prefill_the_form_from_params
1497 1497 @request.session[:user_id] = 2
1498 1498 get :new, :project_id => 1,
1499 1499 :issue => {:tracker_id => 3, :description => 'Prefilled', :custom_field_values => {'2' => 'Custom field value'}}
1500 1500
1501 1501 issue = assigns(:issue)
1502 1502 assert_equal 3, issue.tracker_id
1503 1503 assert_equal 'Prefilled', issue.description
1504 1504 assert_equal 'Custom field value', issue.custom_field_value(2)
1505 1505
1506 1506 assert_tag 'select',
1507 1507 :attributes => {:name => 'issue[tracker_id]'},
1508 1508 :child => {:tag => 'option', :attributes => {:value => '3', :selected => 'selected'}}
1509 1509 assert_tag 'textarea',
1510 1510 :attributes => {:name => 'issue[description]'}, :content => "\nPrefilled"
1511 1511 assert_tag 'input',
1512 1512 :attributes => {:name => 'issue[custom_field_values][2]', :value => 'Custom field value'}
1513 1513 end
1514 1514
1515 1515 def test_get_new_should_mark_required_fields
1516 1516 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1517 1517 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1518 1518 WorkflowPermission.delete_all
1519 1519 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1520 1520 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1521 1521 @request.session[:user_id] = 2
1522 1522
1523 1523 get :new, :project_id => 1
1524 1524 assert_response :success
1525 1525 assert_template 'new'
1526 1526
1527 1527 assert_select 'label[for=issue_start_date]' do
1528 1528 assert_select 'span[class=required]', 0
1529 1529 end
1530 1530 assert_select 'label[for=issue_due_date]' do
1531 1531 assert_select 'span[class=required]'
1532 1532 end
1533 1533 assert_select 'label[for=?]', "issue_custom_field_values_#{cf1.id}" do
1534 1534 assert_select 'span[class=required]', 0
1535 1535 end
1536 1536 assert_select 'label[for=?]', "issue_custom_field_values_#{cf2.id}" do
1537 1537 assert_select 'span[class=required]'
1538 1538 end
1539 1539 end
1540 1540
1541 1541 def test_get_new_should_not_display_readonly_fields
1542 1542 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1543 1543 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1544 1544 WorkflowPermission.delete_all
1545 1545 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1546 1546 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1547 1547 @request.session[:user_id] = 2
1548 1548
1549 1549 get :new, :project_id => 1
1550 1550 assert_response :success
1551 1551 assert_template 'new'
1552 1552
1553 1553 assert_select 'input[name=?]', 'issue[start_date]'
1554 1554 assert_select 'input[name=?]', 'issue[due_date]', 0
1555 1555 assert_select 'input[name=?]', "issue[custom_field_values][#{cf1.id}]"
1556 1556 assert_select 'input[name=?]', "issue[custom_field_values][#{cf2.id}]", 0
1557 1557 end
1558 1558
1559 1559 def test_get_new_without_tracker_id
1560 1560 @request.session[:user_id] = 2
1561 1561 get :new, :project_id => 1
1562 1562 assert_response :success
1563 1563 assert_template 'new'
1564 1564
1565 1565 issue = assigns(:issue)
1566 1566 assert_not_nil issue
1567 1567 assert_equal Project.find(1).trackers.first, issue.tracker
1568 1568 end
1569 1569
1570 1570 def test_get_new_with_no_default_status_should_display_an_error
1571 1571 @request.session[:user_id] = 2
1572 1572 IssueStatus.delete_all
1573 1573
1574 1574 get :new, :project_id => 1
1575 1575 assert_response 500
1576 1576 assert_error_tag :content => /No default issue/
1577 1577 end
1578 1578
1579 1579 def test_get_new_with_no_tracker_should_display_an_error
1580 1580 @request.session[:user_id] = 2
1581 1581 Tracker.delete_all
1582 1582
1583 1583 get :new, :project_id => 1
1584 1584 assert_response 500
1585 1585 assert_error_tag :content => /No tracker/
1586 1586 end
1587 1587
1588 1588 def test_update_new_form
1589 1589 @request.session[:user_id] = 2
1590 1590 xhr :post, :new, :project_id => 1,
1591 1591 :issue => {:tracker_id => 2,
1592 1592 :subject => 'This is the test_new issue',
1593 1593 :description => 'This is the description',
1594 1594 :priority_id => 5}
1595 1595 assert_response :success
1596 1596 assert_template 'update_form'
1597 1597 assert_template 'form'
1598 1598 assert_equal 'text/javascript', response.content_type
1599 1599
1600 1600 issue = assigns(:issue)
1601 1601 assert_kind_of Issue, issue
1602 1602 assert_equal 1, issue.project_id
1603 1603 assert_equal 2, issue.tracker_id
1604 1604 assert_equal 'This is the test_new issue', issue.subject
1605 1605 end
1606 1606
1607 1607 def test_update_new_form_should_propose_transitions_based_on_initial_status
1608 1608 @request.session[:user_id] = 2
1609 1609 WorkflowTransition.delete_all
1610 1610 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
1611 1611 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5)
1612 1612 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4)
1613 1613
1614 1614 xhr :post, :new, :project_id => 1,
1615 1615 :issue => {:tracker_id => 1,
1616 1616 :status_id => 5,
1617 1617 :subject => 'This is an issue'}
1618 1618
1619 1619 assert_equal 5, assigns(:issue).status_id
1620 1620 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
1621 1621 end
1622 1622
1623 1623 def test_post_create
1624 1624 @request.session[:user_id] = 2
1625 1625 assert_difference 'Issue.count' do
1626 1626 post :create, :project_id => 1,
1627 1627 :issue => {:tracker_id => 3,
1628 1628 :status_id => 2,
1629 1629 :subject => 'This is the test_new issue',
1630 1630 :description => 'This is the description',
1631 1631 :priority_id => 5,
1632 1632 :start_date => '2010-11-07',
1633 1633 :estimated_hours => '',
1634 1634 :custom_field_values => {'2' => 'Value for field 2'}}
1635 1635 end
1636 1636 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1637 1637
1638 1638 issue = Issue.find_by_subject('This is the test_new issue')
1639 1639 assert_not_nil issue
1640 1640 assert_equal 2, issue.author_id
1641 1641 assert_equal 3, issue.tracker_id
1642 1642 assert_equal 2, issue.status_id
1643 1643 assert_equal Date.parse('2010-11-07'), issue.start_date
1644 1644 assert_nil issue.estimated_hours
1645 1645 v = issue.custom_values.find(:first, :conditions => {:custom_field_id => 2})
1646 1646 assert_not_nil v
1647 1647 assert_equal 'Value for field 2', v.value
1648 1648 end
1649 1649
1650 1650 def test_post_new_with_group_assignment
1651 1651 group = Group.find(11)
1652 1652 project = Project.find(1)
1653 1653 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
1654 1654
1655 1655 with_settings :issue_group_assignment => '1' do
1656 1656 @request.session[:user_id] = 2
1657 1657 assert_difference 'Issue.count' do
1658 1658 post :create, :project_id => project.id,
1659 1659 :issue => {:tracker_id => 3,
1660 1660 :status_id => 1,
1661 1661 :subject => 'This is the test_new_with_group_assignment issue',
1662 1662 :assigned_to_id => group.id}
1663 1663 end
1664 1664 end
1665 1665 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1666 1666
1667 1667 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1668 1668 assert_not_nil issue
1669 1669 assert_equal group, issue.assigned_to
1670 1670 end
1671 1671
1672 1672 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1673 1673 Setting.default_issue_start_date_to_creation_date = 0
1674 1674
1675 1675 @request.session[:user_id] = 2
1676 1676 assert_difference 'Issue.count' do
1677 1677 post :create, :project_id => 1,
1678 1678 :issue => {:tracker_id => 3,
1679 1679 :status_id => 2,
1680 1680 :subject => 'This is the test_new issue',
1681 1681 :description => 'This is the description',
1682 1682 :priority_id => 5,
1683 1683 :estimated_hours => '',
1684 1684 :custom_field_values => {'2' => 'Value for field 2'}}
1685 1685 end
1686 1686 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1687 1687
1688 1688 issue = Issue.find_by_subject('This is the test_new issue')
1689 1689 assert_not_nil issue
1690 1690 assert_nil issue.start_date
1691 1691 end
1692 1692
1693 1693 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1694 1694 Setting.default_issue_start_date_to_creation_date = 1
1695 1695
1696 1696 @request.session[:user_id] = 2
1697 1697 assert_difference 'Issue.count' do
1698 1698 post :create, :project_id => 1,
1699 1699 :issue => {:tracker_id => 3,
1700 1700 :status_id => 2,
1701 1701 :subject => 'This is the test_new issue',
1702 1702 :description => 'This is the description',
1703 1703 :priority_id => 5,
1704 1704 :estimated_hours => '',
1705 1705 :custom_field_values => {'2' => 'Value for field 2'}}
1706 1706 end
1707 1707 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1708 1708
1709 1709 issue = Issue.find_by_subject('This is the test_new issue')
1710 1710 assert_not_nil issue
1711 1711 assert_equal Date.today, issue.start_date
1712 1712 end
1713 1713
1714 1714 def test_post_create_and_continue
1715 1715 @request.session[:user_id] = 2
1716 1716 assert_difference 'Issue.count' do
1717 1717 post :create, :project_id => 1,
1718 1718 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1719 1719 :continue => ''
1720 1720 end
1721 1721
1722 1722 issue = Issue.first(:order => 'id DESC')
1723 1723 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1724 1724 assert_not_nil flash[:notice], "flash was not set"
1725 assert flash[:notice].include?(%|<a href="/issues/#{issue.id}">##{issue.id}</a>|), "issue link not found in flash: #{flash[:notice]}"
1725 assert_include %|<a href="/issues/#{issue.id}" title="This is first issue">##{issue.id}</a>|, flash[:notice], "issue link not found in the flash message"
1726 1726 end
1727 1727
1728 1728 def test_post_create_without_custom_fields_param
1729 1729 @request.session[:user_id] = 2
1730 1730 assert_difference 'Issue.count' do
1731 1731 post :create, :project_id => 1,
1732 1732 :issue => {:tracker_id => 1,
1733 1733 :subject => 'This is the test_new issue',
1734 1734 :description => 'This is the description',
1735 1735 :priority_id => 5}
1736 1736 end
1737 1737 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1738 1738 end
1739 1739
1740 1740 def test_post_create_with_multi_custom_field
1741 1741 field = IssueCustomField.find_by_name('Database')
1742 1742 field.update_attribute(:multiple, true)
1743 1743
1744 1744 @request.session[:user_id] = 2
1745 1745 assert_difference 'Issue.count' do
1746 1746 post :create, :project_id => 1,
1747 1747 :issue => {:tracker_id => 1,
1748 1748 :subject => 'This is the test_new issue',
1749 1749 :description => 'This is the description',
1750 1750 :priority_id => 5,
1751 1751 :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
1752 1752 end
1753 1753 assert_response 302
1754 1754 issue = Issue.first(:order => 'id DESC')
1755 1755 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
1756 1756 end
1757 1757
1758 1758 def test_post_create_with_empty_multi_custom_field
1759 1759 field = IssueCustomField.find_by_name('Database')
1760 1760 field.update_attribute(:multiple, true)
1761 1761
1762 1762 @request.session[:user_id] = 2
1763 1763 assert_difference 'Issue.count' do
1764 1764 post :create, :project_id => 1,
1765 1765 :issue => {:tracker_id => 1,
1766 1766 :subject => 'This is the test_new issue',
1767 1767 :description => 'This is the description',
1768 1768 :priority_id => 5,
1769 1769 :custom_field_values => {'1' => ['']}}
1770 1770 end
1771 1771 assert_response 302
1772 1772 issue = Issue.first(:order => 'id DESC')
1773 1773 assert_equal [''], issue.custom_field_value(1).sort
1774 1774 end
1775 1775
1776 1776 def test_post_create_with_multi_user_custom_field
1777 1777 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1778 1778 :tracker_ids => [1], :is_for_all => true)
1779 1779
1780 1780 @request.session[:user_id] = 2
1781 1781 assert_difference 'Issue.count' do
1782 1782 post :create, :project_id => 1,
1783 1783 :issue => {:tracker_id => 1,
1784 1784 :subject => 'This is the test_new issue',
1785 1785 :description => 'This is the description',
1786 1786 :priority_id => 5,
1787 1787 :custom_field_values => {field.id.to_s => ['', '2', '3']}}
1788 1788 end
1789 1789 assert_response 302
1790 1790 issue = Issue.first(:order => 'id DESC')
1791 1791 assert_equal ['2', '3'], issue.custom_field_value(field).sort
1792 1792 end
1793 1793
1794 1794 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1795 1795 field = IssueCustomField.find_by_name('Database')
1796 1796 field.update_attribute(:is_required, true)
1797 1797
1798 1798 @request.session[:user_id] = 2
1799 1799 assert_no_difference 'Issue.count' do
1800 1800 post :create, :project_id => 1,
1801 1801 :issue => {:tracker_id => 1,
1802 1802 :subject => 'This is the test_new issue',
1803 1803 :description => 'This is the description',
1804 1804 :priority_id => 5}
1805 1805 end
1806 1806 assert_response :success
1807 1807 assert_template 'new'
1808 1808 issue = assigns(:issue)
1809 1809 assert_not_nil issue
1810 1810 assert_error_tag :content => /Database can't be blank/
1811 1811 end
1812 1812
1813 1813 def test_create_should_validate_required_fields
1814 1814 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1815 1815 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1816 1816 WorkflowPermission.delete_all
1817 1817 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1818 1818 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1819 1819 @request.session[:user_id] = 2
1820 1820
1821 1821 assert_no_difference 'Issue.count' do
1822 1822 post :create, :project_id => 1, :issue => {
1823 1823 :tracker_id => 2,
1824 1824 :status_id => 1,
1825 1825 :subject => 'Test',
1826 1826 :start_date => '',
1827 1827 :due_date => '',
1828 1828 :custom_field_values => {cf1.id.to_s => '', cf2.id.to_s => ''}
1829 1829 }
1830 1830 assert_response :success
1831 1831 assert_template 'new'
1832 1832 end
1833 1833
1834 1834 assert_error_tag :content => /Due date can't be blank/i
1835 1835 assert_error_tag :content => /Bar can't be blank/i
1836 1836 end
1837 1837
1838 1838 def test_create_should_ignore_readonly_fields
1839 1839 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1840 1840 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1841 1841 WorkflowPermission.delete_all
1842 1842 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1843 1843 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1844 1844 @request.session[:user_id] = 2
1845 1845
1846 1846 assert_difference 'Issue.count' do
1847 1847 post :create, :project_id => 1, :issue => {
1848 1848 :tracker_id => 2,
1849 1849 :status_id => 1,
1850 1850 :subject => 'Test',
1851 1851 :start_date => '2012-07-14',
1852 1852 :due_date => '2012-07-16',
1853 1853 :custom_field_values => {cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'}
1854 1854 }
1855 1855 assert_response 302
1856 1856 end
1857 1857
1858 1858 issue = Issue.first(:order => 'id DESC')
1859 1859 assert_equal Date.parse('2012-07-14'), issue.start_date
1860 1860 assert_nil issue.due_date
1861 1861 assert_equal 'value1', issue.custom_field_value(cf1)
1862 1862 assert_nil issue.custom_field_value(cf2)
1863 1863 end
1864 1864
1865 1865 def test_post_create_with_watchers
1866 1866 @request.session[:user_id] = 2
1867 1867 ActionMailer::Base.deliveries.clear
1868 1868
1869 1869 assert_difference 'Watcher.count', 2 do
1870 1870 post :create, :project_id => 1,
1871 1871 :issue => {:tracker_id => 1,
1872 1872 :subject => 'This is a new issue with watchers',
1873 1873 :description => 'This is the description',
1874 1874 :priority_id => 5,
1875 1875 :watcher_user_ids => ['2', '3']}
1876 1876 end
1877 1877 issue = Issue.find_by_subject('This is a new issue with watchers')
1878 1878 assert_not_nil issue
1879 1879 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1880 1880
1881 1881 # Watchers added
1882 1882 assert_equal [2, 3], issue.watcher_user_ids.sort
1883 1883 assert issue.watched_by?(User.find(3))
1884 1884 # Watchers notified
1885 1885 mail = ActionMailer::Base.deliveries.last
1886 1886 assert_not_nil mail
1887 1887 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1888 1888 end
1889 1889
1890 1890 def test_post_create_subissue
1891 1891 @request.session[:user_id] = 2
1892 1892
1893 1893 assert_difference 'Issue.count' do
1894 1894 post :create, :project_id => 1,
1895 1895 :issue => {:tracker_id => 1,
1896 1896 :subject => 'This is a child issue',
1897 1897 :parent_issue_id => 2}
1898 1898 end
1899 1899 issue = Issue.find_by_subject('This is a child issue')
1900 1900 assert_not_nil issue
1901 1901 assert_equal Issue.find(2), issue.parent
1902 1902 end
1903 1903
1904 1904 def test_post_create_subissue_with_non_numeric_parent_id
1905 1905 @request.session[:user_id] = 2
1906 1906
1907 1907 assert_difference 'Issue.count' do
1908 1908 post :create, :project_id => 1,
1909 1909 :issue => {:tracker_id => 1,
1910 1910 :subject => 'This is a child issue',
1911 1911 :parent_issue_id => 'ABC'}
1912 1912 end
1913 1913 issue = Issue.find_by_subject('This is a child issue')
1914 1914 assert_not_nil issue
1915 1915 assert_nil issue.parent
1916 1916 end
1917 1917
1918 1918 def test_post_create_private
1919 1919 @request.session[:user_id] = 2
1920 1920
1921 1921 assert_difference 'Issue.count' do
1922 1922 post :create, :project_id => 1,
1923 1923 :issue => {:tracker_id => 1,
1924 1924 :subject => 'This is a private issue',
1925 1925 :is_private => '1'}
1926 1926 end
1927 1927 issue = Issue.first(:order => 'id DESC')
1928 1928 assert issue.is_private?
1929 1929 end
1930 1930
1931 1931 def test_post_create_private_with_set_own_issues_private_permission
1932 1932 role = Role.find(1)
1933 1933 role.remove_permission! :set_issues_private
1934 1934 role.add_permission! :set_own_issues_private
1935 1935
1936 1936 @request.session[:user_id] = 2
1937 1937
1938 1938 assert_difference 'Issue.count' do
1939 1939 post :create, :project_id => 1,
1940 1940 :issue => {:tracker_id => 1,
1941 1941 :subject => 'This is a private issue',
1942 1942 :is_private => '1'}
1943 1943 end
1944 1944 issue = Issue.first(:order => 'id DESC')
1945 1945 assert issue.is_private?
1946 1946 end
1947 1947
1948 1948 def test_post_create_should_send_a_notification
1949 1949 ActionMailer::Base.deliveries.clear
1950 1950 @request.session[:user_id] = 2
1951 1951 assert_difference 'Issue.count' do
1952 1952 post :create, :project_id => 1,
1953 1953 :issue => {:tracker_id => 3,
1954 1954 :subject => 'This is the test_new issue',
1955 1955 :description => 'This is the description',
1956 1956 :priority_id => 5,
1957 1957 :estimated_hours => '',
1958 1958 :custom_field_values => {'2' => 'Value for field 2'}}
1959 1959 end
1960 1960 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1961 1961
1962 1962 assert_equal 1, ActionMailer::Base.deliveries.size
1963 1963 end
1964 1964
1965 1965 def test_post_create_should_preserve_fields_values_on_validation_failure
1966 1966 @request.session[:user_id] = 2
1967 1967 post :create, :project_id => 1,
1968 1968 :issue => {:tracker_id => 1,
1969 1969 # empty subject
1970 1970 :subject => '',
1971 1971 :description => 'This is a description',
1972 1972 :priority_id => 6,
1973 1973 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
1974 1974 assert_response :success
1975 1975 assert_template 'new'
1976 1976
1977 1977 assert_tag :textarea, :attributes => { :name => 'issue[description]' },
1978 1978 :content => "\nThis is a description"
1979 1979 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
1980 1980 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1981 1981 :value => '6' },
1982 1982 :content => 'High' }
1983 1983 # Custom fields
1984 1984 assert_tag :select, :attributes => { :name => 'issue[custom_field_values][1]' },
1985 1985 :child => { :tag => 'option', :attributes => { :selected => 'selected',
1986 1986 :value => 'Oracle' },
1987 1987 :content => 'Oracle' }
1988 1988 assert_tag :input, :attributes => { :name => 'issue[custom_field_values][2]',
1989 1989 :value => 'Value for field 2'}
1990 1990 end
1991 1991
1992 1992 def test_post_create_with_failure_should_preserve_watchers
1993 1993 assert !User.find(8).member_of?(Project.find(1))
1994 1994
1995 1995 @request.session[:user_id] = 2
1996 1996 post :create, :project_id => 1,
1997 1997 :issue => {:tracker_id => 1,
1998 1998 :watcher_user_ids => ['3', '8']}
1999 1999 assert_response :success
2000 2000 assert_template 'new'
2001 2001
2002 2002 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]', :value => '2', :checked => nil}
2003 2003 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]', :value => '3', :checked => 'checked'}
2004 2004 assert_tag 'input', :attributes => {:name => 'issue[watcher_user_ids][]', :value => '8', :checked => 'checked'}
2005 2005 end
2006 2006
2007 2007 def test_post_create_should_ignore_non_safe_attributes
2008 2008 @request.session[:user_id] = 2
2009 2009 assert_nothing_raised do
2010 2010 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
2011 2011 end
2012 2012 end
2013 2013
2014 2014 def test_post_create_with_attachment
2015 2015 set_tmp_attachments_directory
2016 2016 @request.session[:user_id] = 2
2017 2017
2018 2018 assert_difference 'Issue.count' do
2019 2019 assert_difference 'Attachment.count' do
2020 2020 post :create, :project_id => 1,
2021 2021 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2022 2022 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2023 2023 end
2024 2024 end
2025 2025
2026 2026 issue = Issue.first(:order => 'id DESC')
2027 2027 attachment = Attachment.first(:order => 'id DESC')
2028 2028
2029 2029 assert_equal issue, attachment.container
2030 2030 assert_equal 2, attachment.author_id
2031 2031 assert_equal 'testfile.txt', attachment.filename
2032 2032 assert_equal 'text/plain', attachment.content_type
2033 2033 assert_equal 'test file', attachment.description
2034 2034 assert_equal 59, attachment.filesize
2035 2035 assert File.exists?(attachment.diskfile)
2036 2036 assert_equal 59, File.size(attachment.diskfile)
2037 2037 end
2038 2038
2039 2039 def test_post_create_with_failure_should_save_attachments
2040 2040 set_tmp_attachments_directory
2041 2041 @request.session[:user_id] = 2
2042 2042
2043 2043 assert_no_difference 'Issue.count' do
2044 2044 assert_difference 'Attachment.count' do
2045 2045 post :create, :project_id => 1,
2046 2046 :issue => { :tracker_id => '1', :subject => '' },
2047 2047 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2048 2048 assert_response :success
2049 2049 assert_template 'new'
2050 2050 end
2051 2051 end
2052 2052
2053 2053 attachment = Attachment.first(:order => 'id DESC')
2054 2054 assert_equal 'testfile.txt', attachment.filename
2055 2055 assert File.exists?(attachment.diskfile)
2056 2056 assert_nil attachment.container
2057 2057
2058 2058 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
2059 2059 assert_tag 'span', :content => /testfile.txt/
2060 2060 end
2061 2061
2062 2062 def test_post_create_with_failure_should_keep_saved_attachments
2063 2063 set_tmp_attachments_directory
2064 2064 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2065 2065 @request.session[:user_id] = 2
2066 2066
2067 2067 assert_no_difference 'Issue.count' do
2068 2068 assert_no_difference 'Attachment.count' do
2069 2069 post :create, :project_id => 1,
2070 2070 :issue => { :tracker_id => '1', :subject => '' },
2071 2071 :attachments => {'p0' => {'token' => attachment.token}}
2072 2072 assert_response :success
2073 2073 assert_template 'new'
2074 2074 end
2075 2075 end
2076 2076
2077 2077 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
2078 2078 assert_tag 'span', :content => /testfile.txt/
2079 2079 end
2080 2080
2081 2081 def test_post_create_should_attach_saved_attachments
2082 2082 set_tmp_attachments_directory
2083 2083 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2084 2084 @request.session[:user_id] = 2
2085 2085
2086 2086 assert_difference 'Issue.count' do
2087 2087 assert_no_difference 'Attachment.count' do
2088 2088 post :create, :project_id => 1,
2089 2089 :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
2090 2090 :attachments => {'p0' => {'token' => attachment.token}}
2091 2091 assert_response 302
2092 2092 end
2093 2093 end
2094 2094
2095 2095 issue = Issue.first(:order => 'id DESC')
2096 2096 assert_equal 1, issue.attachments.count
2097 2097
2098 2098 attachment.reload
2099 2099 assert_equal issue, attachment.container
2100 2100 end
2101 2101
2102 2102 context "without workflow privilege" do
2103 2103 setup do
2104 2104 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2105 2105 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2106 2106 end
2107 2107
2108 2108 context "#new" do
2109 2109 should "propose default status only" do
2110 2110 get :new, :project_id => 1
2111 2111 assert_response :success
2112 2112 assert_template 'new'
2113 2113 assert_tag :tag => 'select',
2114 2114 :attributes => {:name => 'issue[status_id]'},
2115 2115 :children => {:count => 1},
2116 2116 :child => {:tag => 'option', :attributes => {:value => IssueStatus.default.id.to_s}}
2117 2117 end
2118 2118
2119 2119 should "accept default status" do
2120 2120 assert_difference 'Issue.count' do
2121 2121 post :create, :project_id => 1,
2122 2122 :issue => {:tracker_id => 1,
2123 2123 :subject => 'This is an issue',
2124 2124 :status_id => 1}
2125 2125 end
2126 2126 issue = Issue.last(:order => 'id')
2127 2127 assert_equal IssueStatus.default, issue.status
2128 2128 end
2129 2129
2130 2130 should "ignore unauthorized status" do
2131 2131 assert_difference 'Issue.count' do
2132 2132 post :create, :project_id => 1,
2133 2133 :issue => {:tracker_id => 1,
2134 2134 :subject => 'This is an issue',
2135 2135 :status_id => 3}
2136 2136 end
2137 2137 issue = Issue.last(:order => 'id')
2138 2138 assert_equal IssueStatus.default, issue.status
2139 2139 end
2140 2140 end
2141 2141
2142 2142 context "#update" do
2143 2143 should "ignore status change" do
2144 2144 assert_difference 'Journal.count' do
2145 2145 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
2146 2146 end
2147 2147 assert_equal 1, Issue.find(1).status_id
2148 2148 end
2149 2149
2150 2150 should "ignore attributes changes" do
2151 2151 assert_difference 'Journal.count' do
2152 2152 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
2153 2153 end
2154 2154 issue = Issue.find(1)
2155 2155 assert_equal "Can't print recipes", issue.subject
2156 2156 assert_nil issue.assigned_to
2157 2157 end
2158 2158 end
2159 2159 end
2160 2160
2161 2161 context "with workflow privilege" do
2162 2162 setup do
2163 2163 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2164 2164 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
2165 2165 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
2166 2166 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2167 2167 end
2168 2168
2169 2169 context "#update" do
2170 2170 should "accept authorized status" do
2171 2171 assert_difference 'Journal.count' do
2172 2172 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
2173 2173 end
2174 2174 assert_equal 3, Issue.find(1).status_id
2175 2175 end
2176 2176
2177 2177 should "ignore unauthorized status" do
2178 2178 assert_difference 'Journal.count' do
2179 2179 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
2180 2180 end
2181 2181 assert_equal 1, Issue.find(1).status_id
2182 2182 end
2183 2183
2184 2184 should "accept authorized attributes changes" do
2185 2185 assert_difference 'Journal.count' do
2186 2186 put :update, :id => 1, :notes => 'just trying', :issue => {:assigned_to_id => 2}
2187 2187 end
2188 2188 issue = Issue.find(1)
2189 2189 assert_equal 2, issue.assigned_to_id
2190 2190 end
2191 2191
2192 2192 should "ignore unauthorized attributes changes" do
2193 2193 assert_difference 'Journal.count' do
2194 2194 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed'}
2195 2195 end
2196 2196 issue = Issue.find(1)
2197 2197 assert_equal "Can't print recipes", issue.subject
2198 2198 end
2199 2199 end
2200 2200
2201 2201 context "and :edit_issues permission" do
2202 2202 setup do
2203 2203 Role.anonymous.add_permission! :add_issues, :edit_issues
2204 2204 end
2205 2205
2206 2206 should "accept authorized status" do
2207 2207 assert_difference 'Journal.count' do
2208 2208 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 3}
2209 2209 end
2210 2210 assert_equal 3, Issue.find(1).status_id
2211 2211 end
2212 2212
2213 2213 should "ignore unauthorized status" do
2214 2214 assert_difference 'Journal.count' do
2215 2215 put :update, :id => 1, :notes => 'just trying', :issue => {:status_id => 2}
2216 2216 end
2217 2217 assert_equal 1, Issue.find(1).status_id
2218 2218 end
2219 2219
2220 2220 should "accept authorized attributes changes" do
2221 2221 assert_difference 'Journal.count' do
2222 2222 put :update, :id => 1, :notes => 'just trying', :issue => {:subject => 'changed', :assigned_to_id => 2}
2223 2223 end
2224 2224 issue = Issue.find(1)
2225 2225 assert_equal "changed", issue.subject
2226 2226 assert_equal 2, issue.assigned_to_id
2227 2227 end
2228 2228 end
2229 2229 end
2230 2230
2231 2231 def test_new_as_copy
2232 2232 @request.session[:user_id] = 2
2233 2233 get :new, :project_id => 1, :copy_from => 1
2234 2234
2235 2235 assert_response :success
2236 2236 assert_template 'new'
2237 2237
2238 2238 assert_not_nil assigns(:issue)
2239 2239 orig = Issue.find(1)
2240 2240 assert_equal 1, assigns(:issue).project_id
2241 2241 assert_equal orig.subject, assigns(:issue).subject
2242 2242 assert assigns(:issue).copy?
2243 2243
2244 2244 assert_tag 'form', :attributes => {:id => 'issue-form', :action => '/projects/ecookbook/issues'}
2245 2245 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
2246 2246 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
2247 2247 :child => {:tag => 'option', :attributes => {:value => '1', :selected => 'selected'}, :content => 'eCookbook'}
2248 2248 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
2249 2249 :child => {:tag => 'option', :attributes => {:value => '2', :selected => nil}, :content => 'OnlineStore'}
2250 2250 assert_tag 'input', :attributes => {:name => 'copy_from', :value => '1'}
2251 2251 end
2252 2252
2253 2253 def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
2254 2254 @request.session[:user_id] = 2
2255 2255 issue = Issue.find(3)
2256 2256 assert issue.attachments.count > 0
2257 2257 get :new, :project_id => 1, :copy_from => 3
2258 2258
2259 2259 assert_tag 'input', :attributes => {:name => 'copy_attachments', :type => 'checkbox', :checked => 'checked', :value => '1'}
2260 2260 end
2261 2261
2262 2262 def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
2263 2263 @request.session[:user_id] = 2
2264 2264 issue = Issue.find(3)
2265 2265 issue.attachments.delete_all
2266 2266 get :new, :project_id => 1, :copy_from => 3
2267 2267
2268 2268 assert_no_tag 'input', :attributes => {:name => 'copy_attachments', :type => 'checkbox', :checked => 'checked', :value => '1'}
2269 2269 end
2270 2270
2271 2271 def test_new_as_copy_with_invalid_issue_should_respond_with_404
2272 2272 @request.session[:user_id] = 2
2273 2273 get :new, :project_id => 1, :copy_from => 99999
2274 2274 assert_response 404
2275 2275 end
2276 2276
2277 2277 def test_create_as_copy_on_different_project
2278 2278 @request.session[:user_id] = 2
2279 2279 assert_difference 'Issue.count' do
2280 2280 post :create, :project_id => 1, :copy_from => 1,
2281 2281 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2282 2282
2283 2283 assert_not_nil assigns(:issue)
2284 2284 assert assigns(:issue).copy?
2285 2285 end
2286 2286 issue = Issue.first(:order => 'id DESC')
2287 2287 assert_redirected_to "/issues/#{issue.id}"
2288 2288
2289 2289 assert_equal 2, issue.project_id
2290 2290 assert_equal 3, issue.tracker_id
2291 2291 assert_equal 'Copy', issue.subject
2292 2292 end
2293 2293
2294 2294 def test_create_as_copy_should_copy_attachments
2295 2295 @request.session[:user_id] = 2
2296 2296 issue = Issue.find(3)
2297 2297 count = issue.attachments.count
2298 2298 assert count > 0
2299 2299
2300 2300 assert_difference 'Issue.count' do
2301 2301 assert_difference 'Attachment.count', count do
2302 2302 assert_no_difference 'Journal.count' do
2303 2303 post :create, :project_id => 1, :copy_from => 3,
2304 2304 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2305 2305 :copy_attachments => '1'
2306 2306 end
2307 2307 end
2308 2308 end
2309 2309 copy = Issue.first(:order => 'id DESC')
2310 2310 assert_equal count, copy.attachments.count
2311 2311 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
2312 2312 end
2313 2313
2314 2314 def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
2315 2315 @request.session[:user_id] = 2
2316 2316 issue = Issue.find(3)
2317 2317 count = issue.attachments.count
2318 2318 assert count > 0
2319 2319
2320 2320 assert_difference 'Issue.count' do
2321 2321 assert_no_difference 'Attachment.count' do
2322 2322 assert_no_difference 'Journal.count' do
2323 2323 post :create, :project_id => 1, :copy_from => 3,
2324 2324 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'}
2325 2325 end
2326 2326 end
2327 2327 end
2328 2328 copy = Issue.first(:order => 'id DESC')
2329 2329 assert_equal 0, copy.attachments.count
2330 2330 end
2331 2331
2332 2332 def test_create_as_copy_with_attachments_should_add_new_files
2333 2333 @request.session[:user_id] = 2
2334 2334 issue = Issue.find(3)
2335 2335 count = issue.attachments.count
2336 2336 assert count > 0
2337 2337
2338 2338 assert_difference 'Issue.count' do
2339 2339 assert_difference 'Attachment.count', count + 1 do
2340 2340 assert_no_difference 'Journal.count' do
2341 2341 post :create, :project_id => 1, :copy_from => 3,
2342 2342 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2343 2343 :copy_attachments => '1',
2344 2344 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2345 2345 end
2346 2346 end
2347 2347 end
2348 2348 copy = Issue.first(:order => 'id DESC')
2349 2349 assert_equal count + 1, copy.attachments.count
2350 2350 end
2351 2351
2352 2352 def test_create_as_copy_with_failure
2353 2353 @request.session[:user_id] = 2
2354 2354 post :create, :project_id => 1, :copy_from => 1,
2355 2355 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
2356 2356
2357 2357 assert_response :success
2358 2358 assert_template 'new'
2359 2359
2360 2360 assert_not_nil assigns(:issue)
2361 2361 assert assigns(:issue).copy?
2362 2362
2363 2363 assert_tag 'form', :attributes => {:id => 'issue-form', :action => '/projects/ecookbook/issues'}
2364 2364 assert_tag 'select', :attributes => {:name => 'issue[project_id]'}
2365 2365 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
2366 2366 :child => {:tag => 'option', :attributes => {:value => '1', :selected => nil}, :content => 'eCookbook'}
2367 2367 assert_tag 'select', :attributes => {:name => 'issue[project_id]'},
2368 2368 :child => {:tag => 'option', :attributes => {:value => '2', :selected => 'selected'}, :content => 'OnlineStore'}
2369 2369 assert_tag 'input', :attributes => {:name => 'copy_from', :value => '1'}
2370 2370 end
2371 2371
2372 2372 def test_create_as_copy_on_project_without_permission_should_ignore_target_project
2373 2373 @request.session[:user_id] = 2
2374 2374 assert !User.find(2).member_of?(Project.find(4))
2375 2375
2376 2376 assert_difference 'Issue.count' do
2377 2377 post :create, :project_id => 1, :copy_from => 1,
2378 2378 :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2379 2379 end
2380 2380 issue = Issue.first(:order => 'id DESC')
2381 2381 assert_equal 1, issue.project_id
2382 2382 end
2383 2383
2384 2384 def test_get_edit
2385 2385 @request.session[:user_id] = 2
2386 2386 get :edit, :id => 1
2387 2387 assert_response :success
2388 2388 assert_template 'edit'
2389 2389 assert_not_nil assigns(:issue)
2390 2390 assert_equal Issue.find(1), assigns(:issue)
2391 2391
2392 2392 # Be sure we don't display inactive IssuePriorities
2393 2393 assert ! IssuePriority.find(15).active?
2394 2394 assert_no_tag :option, :attributes => {:value => '15'},
2395 2395 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
2396 2396 end
2397 2397
2398 2398 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
2399 2399 @request.session[:user_id] = 2
2400 2400 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
2401 2401
2402 2402 get :edit, :id => 1
2403 2403 assert_tag 'input', :attributes => {:name => 'time_entry[hours]'}
2404 2404 end
2405 2405
2406 2406 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
2407 2407 @request.session[:user_id] = 2
2408 2408 Role.find_by_name('Manager').remove_permission! :log_time
2409 2409
2410 2410 get :edit, :id => 1
2411 2411 assert_no_tag 'input', :attributes => {:name => 'time_entry[hours]'}
2412 2412 end
2413 2413
2414 2414 def test_get_edit_with_params
2415 2415 @request.session[:user_id] = 2
2416 2416 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
2417 2417 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => TimeEntryActivity.first.id }
2418 2418 assert_response :success
2419 2419 assert_template 'edit'
2420 2420
2421 2421 issue = assigns(:issue)
2422 2422 assert_not_nil issue
2423 2423
2424 2424 assert_equal 5, issue.status_id
2425 2425 assert_tag :select, :attributes => { :name => 'issue[status_id]' },
2426 2426 :child => { :tag => 'option',
2427 2427 :content => 'Closed',
2428 2428 :attributes => { :selected => 'selected' } }
2429 2429
2430 2430 assert_equal 7, issue.priority_id
2431 2431 assert_tag :select, :attributes => { :name => 'issue[priority_id]' },
2432 2432 :child => { :tag => 'option',
2433 2433 :content => 'Urgent',
2434 2434 :attributes => { :selected => 'selected' } }
2435 2435
2436 2436 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => '2.5' }
2437 2437 assert_tag :select, :attributes => { :name => 'time_entry[activity_id]' },
2438 2438 :child => { :tag => 'option',
2439 2439 :attributes => { :selected => 'selected', :value => TimeEntryActivity.first.id } }
2440 2440 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => 'test_get_edit_with_params' }
2441 2441 end
2442 2442
2443 2443 def test_get_edit_with_multi_custom_field
2444 2444 field = CustomField.find(1)
2445 2445 field.update_attribute :multiple, true
2446 2446 issue = Issue.find(1)
2447 2447 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2448 2448 issue.save!
2449 2449
2450 2450 @request.session[:user_id] = 2
2451 2451 get :edit, :id => 1
2452 2452 assert_response :success
2453 2453 assert_template 'edit'
2454 2454
2455 2455 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]', :multiple => 'multiple'}
2456 2456 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
2457 2457 :child => {:tag => 'option', :attributes => {:value => 'MySQL', :selected => 'selected'}}
2458 2458 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
2459 2459 :child => {:tag => 'option', :attributes => {:value => 'PostgreSQL', :selected => nil}}
2460 2460 assert_tag 'select', :attributes => {:name => 'issue[custom_field_values][1][]'},
2461 2461 :child => {:tag => 'option', :attributes => {:value => 'Oracle', :selected => 'selected'}}
2462 2462 end
2463 2463
2464 2464 def test_update_edit_form
2465 2465 @request.session[:user_id] = 2
2466 2466 xhr :put, :new, :project_id => 1,
2467 2467 :id => 1,
2468 2468 :issue => {:tracker_id => 2,
2469 2469 :subject => 'This is the test_new issue',
2470 2470 :description => 'This is the description',
2471 2471 :priority_id => 5}
2472 2472 assert_response :success
2473 2473 assert_equal 'text/javascript', response.content_type
2474 2474 assert_template 'update_form'
2475 2475 assert_template 'form'
2476 2476
2477 2477 issue = assigns(:issue)
2478 2478 assert_kind_of Issue, issue
2479 2479 assert_equal 1, issue.id
2480 2480 assert_equal 1, issue.project_id
2481 2481 assert_equal 2, issue.tracker_id
2482 2482 assert_equal 'This is the test_new issue', issue.subject
2483 2483 end
2484 2484
2485 2485 def test_update_edit_form_should_propose_transitions_based_on_initial_status
2486 2486 @request.session[:user_id] = 2
2487 2487 WorkflowTransition.delete_all
2488 2488 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
2489 2489 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
2490 2490 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 5, :new_status_id => 4)
2491 2491
2492 2492 xhr :put, :new, :project_id => 1,
2493 2493 :id => 2,
2494 2494 :issue => {:tracker_id => 2,
2495 2495 :status_id => 5,
2496 2496 :subject => 'This is an issue'}
2497 2497
2498 2498 assert_equal 5, assigns(:issue).status_id
2499 2499 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
2500 2500 end
2501 2501
2502 2502 def test_update_edit_form_with_project_change
2503 2503 @request.session[:user_id] = 2
2504 2504 xhr :put, :new, :project_id => 1,
2505 2505 :id => 1,
2506 2506 :issue => {:project_id => 2,
2507 2507 :tracker_id => 2,
2508 2508 :subject => 'This is the test_new issue',
2509 2509 :description => 'This is the description',
2510 2510 :priority_id => 5}
2511 2511 assert_response :success
2512 2512 assert_template 'form'
2513 2513
2514 2514 issue = assigns(:issue)
2515 2515 assert_kind_of Issue, issue
2516 2516 assert_equal 1, issue.id
2517 2517 assert_equal 2, issue.project_id
2518 2518 assert_equal 2, issue.tracker_id
2519 2519 assert_equal 'This is the test_new issue', issue.subject
2520 2520 end
2521 2521
2522 2522 def test_put_update_without_custom_fields_param
2523 2523 @request.session[:user_id] = 2
2524 2524 ActionMailer::Base.deliveries.clear
2525 2525
2526 2526 issue = Issue.find(1)
2527 2527 assert_equal '125', issue.custom_value_for(2).value
2528 2528 old_subject = issue.subject
2529 2529 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2530 2530
2531 2531 assert_difference('Journal.count') do
2532 2532 assert_difference('JournalDetail.count', 2) do
2533 2533 put :update, :id => 1, :issue => {:subject => new_subject,
2534 2534 :priority_id => '6',
2535 2535 :category_id => '1' # no change
2536 2536 }
2537 2537 end
2538 2538 end
2539 2539 assert_redirected_to :action => 'show', :id => '1'
2540 2540 issue.reload
2541 2541 assert_equal new_subject, issue.subject
2542 2542 # Make sure custom fields were not cleared
2543 2543 assert_equal '125', issue.custom_value_for(2).value
2544 2544
2545 2545 mail = ActionMailer::Base.deliveries.last
2546 2546 assert_not_nil mail
2547 2547 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2548 2548 assert_mail_body_match "Subject changed from #{old_subject} to #{new_subject}", mail
2549 2549 end
2550 2550
2551 2551 def test_put_update_with_project_change
2552 2552 @request.session[:user_id] = 2
2553 2553 ActionMailer::Base.deliveries.clear
2554 2554
2555 2555 assert_difference('Journal.count') do
2556 2556 assert_difference('JournalDetail.count', 3) do
2557 2557 put :update, :id => 1, :issue => {:project_id => '2',
2558 2558 :tracker_id => '1', # no change
2559 2559 :priority_id => '6',
2560 2560 :category_id => '3'
2561 2561 }
2562 2562 end
2563 2563 end
2564 2564 assert_redirected_to :action => 'show', :id => '1'
2565 2565 issue = Issue.find(1)
2566 2566 assert_equal 2, issue.project_id
2567 2567 assert_equal 1, issue.tracker_id
2568 2568 assert_equal 6, issue.priority_id
2569 2569 assert_equal 3, issue.category_id
2570 2570
2571 2571 mail = ActionMailer::Base.deliveries.last
2572 2572 assert_not_nil mail
2573 2573 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2574 2574 assert_mail_body_match "Project changed from eCookbook to OnlineStore", mail
2575 2575 end
2576 2576
2577 2577 def test_put_update_with_tracker_change
2578 2578 @request.session[:user_id] = 2
2579 2579 ActionMailer::Base.deliveries.clear
2580 2580
2581 2581 assert_difference('Journal.count') do
2582 2582 assert_difference('JournalDetail.count', 2) do
2583 2583 put :update, :id => 1, :issue => {:project_id => '1',
2584 2584 :tracker_id => '2',
2585 2585 :priority_id => '6'
2586 2586 }
2587 2587 end
2588 2588 end
2589 2589 assert_redirected_to :action => 'show', :id => '1'
2590 2590 issue = Issue.find(1)
2591 2591 assert_equal 1, issue.project_id
2592 2592 assert_equal 2, issue.tracker_id
2593 2593 assert_equal 6, issue.priority_id
2594 2594 assert_equal 1, issue.category_id
2595 2595
2596 2596 mail = ActionMailer::Base.deliveries.last
2597 2597 assert_not_nil mail
2598 2598 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2599 2599 assert_mail_body_match "Tracker changed from Bug to Feature request", mail
2600 2600 end
2601 2601
2602 2602 def test_put_update_with_custom_field_change
2603 2603 @request.session[:user_id] = 2
2604 2604 issue = Issue.find(1)
2605 2605 assert_equal '125', issue.custom_value_for(2).value
2606 2606
2607 2607 assert_difference('Journal.count') do
2608 2608 assert_difference('JournalDetail.count', 3) do
2609 2609 put :update, :id => 1, :issue => {:subject => 'Custom field change',
2610 2610 :priority_id => '6',
2611 2611 :category_id => '1', # no change
2612 2612 :custom_field_values => { '2' => 'New custom value' }
2613 2613 }
2614 2614 end
2615 2615 end
2616 2616 assert_redirected_to :action => 'show', :id => '1'
2617 2617 issue.reload
2618 2618 assert_equal 'New custom value', issue.custom_value_for(2).value
2619 2619
2620 2620 mail = ActionMailer::Base.deliveries.last
2621 2621 assert_not_nil mail
2622 2622 assert_mail_body_match "Searchable field changed from 125 to New custom value", mail
2623 2623 end
2624 2624
2625 2625 def test_put_update_with_multi_custom_field_change
2626 2626 field = CustomField.find(1)
2627 2627 field.update_attribute :multiple, true
2628 2628 issue = Issue.find(1)
2629 2629 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2630 2630 issue.save!
2631 2631
2632 2632 @request.session[:user_id] = 2
2633 2633 assert_difference('Journal.count') do
2634 2634 assert_difference('JournalDetail.count', 3) do
2635 2635 put :update, :id => 1,
2636 2636 :issue => {
2637 2637 :subject => 'Custom field change',
2638 2638 :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
2639 2639 }
2640 2640 end
2641 2641 end
2642 2642 assert_redirected_to :action => 'show', :id => '1'
2643 2643 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
2644 2644 end
2645 2645
2646 2646 def test_put_update_with_status_and_assignee_change
2647 2647 issue = Issue.find(1)
2648 2648 assert_equal 1, issue.status_id
2649 2649 @request.session[:user_id] = 2
2650 2650 assert_difference('TimeEntry.count', 0) do
2651 2651 put :update,
2652 2652 :id => 1,
2653 2653 :issue => { :status_id => 2, :assigned_to_id => 3 },
2654 2654 :notes => 'Assigned to dlopper',
2655 2655 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
2656 2656 end
2657 2657 assert_redirected_to :action => 'show', :id => '1'
2658 2658 issue.reload
2659 2659 assert_equal 2, issue.status_id
2660 2660 j = Journal.find(:first, :order => 'id DESC')
2661 2661 assert_equal 'Assigned to dlopper', j.notes
2662 2662 assert_equal 2, j.details.size
2663 2663
2664 2664 mail = ActionMailer::Base.deliveries.last
2665 2665 assert_mail_body_match "Status changed from New to Assigned", mail
2666 2666 # subject should contain the new status
2667 2667 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
2668 2668 end
2669 2669
2670 2670 def test_put_update_with_note_only
2671 2671 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
2672 2672 # anonymous user
2673 2673 put :update,
2674 2674 :id => 1,
2675 2675 :notes => notes
2676 2676 assert_redirected_to :action => 'show', :id => '1'
2677 2677 j = Journal.find(:first, :order => 'id DESC')
2678 2678 assert_equal notes, j.notes
2679 2679 assert_equal 0, j.details.size
2680 2680 assert_equal User.anonymous, j.user
2681 2681
2682 2682 mail = ActionMailer::Base.deliveries.last
2683 2683 assert_mail_body_match notes, mail
2684 2684 end
2685 2685
2686 2686 def test_put_update_with_note_and_spent_time
2687 2687 @request.session[:user_id] = 2
2688 2688 spent_hours_before = Issue.find(1).spent_hours
2689 2689 assert_difference('TimeEntry.count') do
2690 2690 put :update,
2691 2691 :id => 1,
2692 2692 :notes => '2.5 hours added',
2693 2693 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
2694 2694 end
2695 2695 assert_redirected_to :action => 'show', :id => '1'
2696 2696
2697 2697 issue = Issue.find(1)
2698 2698
2699 2699 j = Journal.find(:first, :order => 'id DESC')
2700 2700 assert_equal '2.5 hours added', j.notes
2701 2701 assert_equal 0, j.details.size
2702 2702
2703 2703 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
2704 2704 assert_not_nil t
2705 2705 assert_equal 2.5, t.hours
2706 2706 assert_equal spent_hours_before + 2.5, issue.spent_hours
2707 2707 end
2708 2708
2709 2709 def test_put_update_with_attachment_only
2710 2710 set_tmp_attachments_directory
2711 2711
2712 2712 # Delete all fixtured journals, a race condition can occur causing the wrong
2713 2713 # journal to get fetched in the next find.
2714 2714 Journal.delete_all
2715 2715
2716 2716 # anonymous user
2717 2717 assert_difference 'Attachment.count' do
2718 2718 put :update, :id => 1,
2719 2719 :notes => '',
2720 2720 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2721 2721 end
2722 2722
2723 2723 assert_redirected_to :action => 'show', :id => '1'
2724 2724 j = Issue.find(1).journals.find(:first, :order => 'id DESC')
2725 2725 assert j.notes.blank?
2726 2726 assert_equal 1, j.details.size
2727 2727 assert_equal 'testfile.txt', j.details.first.value
2728 2728 assert_equal User.anonymous, j.user
2729 2729
2730 2730 attachment = Attachment.first(:order => 'id DESC')
2731 2731 assert_equal Issue.find(1), attachment.container
2732 2732 assert_equal User.anonymous, attachment.author
2733 2733 assert_equal 'testfile.txt', attachment.filename
2734 2734 assert_equal 'text/plain', attachment.content_type
2735 2735 assert_equal 'test file', attachment.description
2736 2736 assert_equal 59, attachment.filesize
2737 2737 assert File.exists?(attachment.diskfile)
2738 2738 assert_equal 59, File.size(attachment.diskfile)
2739 2739
2740 2740 mail = ActionMailer::Base.deliveries.last
2741 2741 assert_mail_body_match 'testfile.txt', mail
2742 2742 end
2743 2743
2744 2744 def test_put_update_with_failure_should_save_attachments
2745 2745 set_tmp_attachments_directory
2746 2746 @request.session[:user_id] = 2
2747 2747
2748 2748 assert_no_difference 'Journal.count' do
2749 2749 assert_difference 'Attachment.count' do
2750 2750 put :update, :id => 1,
2751 2751 :issue => { :subject => '' },
2752 2752 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2753 2753 assert_response :success
2754 2754 assert_template 'edit'
2755 2755 end
2756 2756 end
2757 2757
2758 2758 attachment = Attachment.first(:order => 'id DESC')
2759 2759 assert_equal 'testfile.txt', attachment.filename
2760 2760 assert File.exists?(attachment.diskfile)
2761 2761 assert_nil attachment.container
2762 2762
2763 2763 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
2764 2764 assert_tag 'span', :content => /testfile.txt/
2765 2765 end
2766 2766
2767 2767 def test_put_update_with_failure_should_keep_saved_attachments
2768 2768 set_tmp_attachments_directory
2769 2769 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2770 2770 @request.session[:user_id] = 2
2771 2771
2772 2772 assert_no_difference 'Journal.count' do
2773 2773 assert_no_difference 'Attachment.count' do
2774 2774 put :update, :id => 1,
2775 2775 :issue => { :subject => '' },
2776 2776 :attachments => {'p0' => {'token' => attachment.token}}
2777 2777 assert_response :success
2778 2778 assert_template 'edit'
2779 2779 end
2780 2780 end
2781 2781
2782 2782 assert_tag 'input', :attributes => {:name => 'attachments[p0][token]', :value => attachment.token}
2783 2783 assert_tag 'span', :content => /testfile.txt/
2784 2784 end
2785 2785
2786 2786 def test_put_update_should_attach_saved_attachments
2787 2787 set_tmp_attachments_directory
2788 2788 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2789 2789 @request.session[:user_id] = 2
2790 2790
2791 2791 assert_difference 'Journal.count' do
2792 2792 assert_difference 'JournalDetail.count' do
2793 2793 assert_no_difference 'Attachment.count' do
2794 2794 put :update, :id => 1,
2795 2795 :notes => 'Attachment added',
2796 2796 :attachments => {'p0' => {'token' => attachment.token}}
2797 2797 assert_redirected_to '/issues/1'
2798 2798 end
2799 2799 end
2800 2800 end
2801 2801
2802 2802 attachment.reload
2803 2803 assert_equal Issue.find(1), attachment.container
2804 2804
2805 2805 journal = Journal.first(:order => 'id DESC')
2806 2806 assert_equal 1, journal.details.size
2807 2807 assert_equal 'testfile.txt', journal.details.first.value
2808 2808 end
2809 2809
2810 2810 def test_put_update_with_attachment_that_fails_to_save
2811 2811 set_tmp_attachments_directory
2812 2812
2813 2813 # Delete all fixtured journals, a race condition can occur causing the wrong
2814 2814 # journal to get fetched in the next find.
2815 2815 Journal.delete_all
2816 2816
2817 2817 # Mock out the unsaved attachment
2818 2818 Attachment.any_instance.stubs(:create).returns(Attachment.new)
2819 2819
2820 2820 # anonymous user
2821 2821 put :update,
2822 2822 :id => 1,
2823 2823 :notes => '',
2824 2824 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
2825 2825 assert_redirected_to :action => 'show', :id => '1'
2826 2826 assert_equal '1 file(s) could not be saved.', flash[:warning]
2827 2827 end
2828 2828
2829 2829 def test_put_update_with_no_change
2830 2830 issue = Issue.find(1)
2831 2831 issue.journals.clear
2832 2832 ActionMailer::Base.deliveries.clear
2833 2833
2834 2834 put :update,
2835 2835 :id => 1,
2836 2836 :notes => ''
2837 2837 assert_redirected_to :action => 'show', :id => '1'
2838 2838
2839 2839 issue.reload
2840 2840 assert issue.journals.empty?
2841 2841 # No email should be sent
2842 2842 assert ActionMailer::Base.deliveries.empty?
2843 2843 end
2844 2844
2845 2845 def test_put_update_should_send_a_notification
2846 2846 @request.session[:user_id] = 2
2847 2847 ActionMailer::Base.deliveries.clear
2848 2848 issue = Issue.find(1)
2849 2849 old_subject = issue.subject
2850 2850 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2851 2851
2852 2852 put :update, :id => 1, :issue => {:subject => new_subject,
2853 2853 :priority_id => '6',
2854 2854 :category_id => '1' # no change
2855 2855 }
2856 2856 assert_equal 1, ActionMailer::Base.deliveries.size
2857 2857 end
2858 2858
2859 2859 def test_put_update_with_invalid_spent_time_hours_only
2860 2860 @request.session[:user_id] = 2
2861 2861 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
2862 2862
2863 2863 assert_no_difference('Journal.count') do
2864 2864 put :update,
2865 2865 :id => 1,
2866 2866 :notes => notes,
2867 2867 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
2868 2868 end
2869 2869 assert_response :success
2870 2870 assert_template 'edit'
2871 2871
2872 2872 assert_error_tag :descendant => {:content => /Activity can't be blank/}
2873 2873 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => "\n"+notes
2874 2874 assert_tag :input, :attributes => { :name => 'time_entry[hours]', :value => "2z" }
2875 2875 end
2876 2876
2877 2877 def test_put_update_with_invalid_spent_time_comments_only
2878 2878 @request.session[:user_id] = 2
2879 2879 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
2880 2880
2881 2881 assert_no_difference('Journal.count') do
2882 2882 put :update,
2883 2883 :id => 1,
2884 2884 :notes => notes,
2885 2885 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
2886 2886 end
2887 2887 assert_response :success
2888 2888 assert_template 'edit'
2889 2889
2890 2890 assert_error_tag :descendant => {:content => /Activity can't be blank/}
2891 2891 assert_error_tag :descendant => {:content => /Hours can't be blank/}
2892 2892 assert_tag :textarea, :attributes => { :name => 'notes' }, :content => "\n"+notes
2893 2893 assert_tag :input, :attributes => { :name => 'time_entry[comments]', :value => "this is my comment" }
2894 2894 end
2895 2895
2896 2896 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
2897 2897 issue = Issue.find(2)
2898 2898 @request.session[:user_id] = 2
2899 2899
2900 2900 put :update,
2901 2901 :id => issue.id,
2902 2902 :issue => {
2903 2903 :fixed_version_id => 4
2904 2904 }
2905 2905
2906 2906 assert_response :redirect
2907 2907 issue.reload
2908 2908 assert_equal 4, issue.fixed_version_id
2909 2909 assert_not_equal issue.project_id, issue.fixed_version.project_id
2910 2910 end
2911 2911
2912 2912 def test_put_update_should_redirect_back_using_the_back_url_parameter
2913 2913 issue = Issue.find(2)
2914 2914 @request.session[:user_id] = 2
2915 2915
2916 2916 put :update,
2917 2917 :id => issue.id,
2918 2918 :issue => {
2919 2919 :fixed_version_id => 4
2920 2920 },
2921 2921 :back_url => '/issues'
2922 2922
2923 2923 assert_response :redirect
2924 2924 assert_redirected_to '/issues'
2925 2925 end
2926 2926
2927 2927 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
2928 2928 issue = Issue.find(2)
2929 2929 @request.session[:user_id] = 2
2930 2930
2931 2931 put :update,
2932 2932 :id => issue.id,
2933 2933 :issue => {
2934 2934 :fixed_version_id => 4
2935 2935 },
2936 2936 :back_url => 'http://google.com'
2937 2937
2938 2938 assert_response :redirect
2939 2939 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
2940 2940 end
2941 2941
2942 2942 def test_get_bulk_edit
2943 2943 @request.session[:user_id] = 2
2944 2944 get :bulk_edit, :ids => [1, 2]
2945 2945 assert_response :success
2946 2946 assert_template 'bulk_edit'
2947 2947
2948 2948 assert_tag :select, :attributes => {:name => 'issue[project_id]'}
2949 2949 assert_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
2950 2950
2951 2951 # Project specific custom field, date type
2952 2952 field = CustomField.find(9)
2953 2953 assert !field.is_for_all?
2954 2954 assert_equal 'date', field.field_format
2955 2955 assert_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
2956 2956
2957 2957 # System wide custom field
2958 2958 assert CustomField.find(1).is_for_all?
2959 2959 assert_tag :select, :attributes => {:name => 'issue[custom_field_values][1]'}
2960 2960
2961 2961 # Be sure we don't display inactive IssuePriorities
2962 2962 assert ! IssuePriority.find(15).active?
2963 2963 assert_no_tag :option, :attributes => {:value => '15'},
2964 2964 :parent => {:tag => 'select', :attributes => {:id => 'issue_priority_id'} }
2965 2965 end
2966 2966
2967 2967 def test_get_bulk_edit_on_different_projects
2968 2968 @request.session[:user_id] = 2
2969 2969 get :bulk_edit, :ids => [1, 2, 6]
2970 2970 assert_response :success
2971 2971 assert_template 'bulk_edit'
2972 2972
2973 2973 # Can not set issues from different projects as children of an issue
2974 2974 assert_no_tag :input, :attributes => {:name => 'issue[parent_issue_id]'}
2975 2975
2976 2976 # Project specific custom field, date type
2977 2977 field = CustomField.find(9)
2978 2978 assert !field.is_for_all?
2979 2979 assert !field.project_ids.include?(Issue.find(6).project_id)
2980 2980 assert_no_tag :input, :attributes => {:name => 'issue[custom_field_values][9]'}
2981 2981 end
2982 2982
2983 2983 def test_get_bulk_edit_with_user_custom_field
2984 2984 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
2985 2985
2986 2986 @request.session[:user_id] = 2
2987 2987 get :bulk_edit, :ids => [1, 2]
2988 2988 assert_response :success
2989 2989 assert_template 'bulk_edit'
2990 2990
2991 2991 assert_tag :select,
2992 2992 :attributes => {:name => "issue[custom_field_values][#{field.id}]", :class => 'user_cf'},
2993 2993 :children => {
2994 2994 :only => {:tag => 'option'},
2995 2995 :count => Project.find(1).users.count + 2 # "no change" + "none" options
2996 2996 }
2997 2997 end
2998 2998
2999 2999 def test_get_bulk_edit_with_version_custom_field
3000 3000 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
3001 3001
3002 3002 @request.session[:user_id] = 2
3003 3003 get :bulk_edit, :ids => [1, 2]
3004 3004 assert_response :success
3005 3005 assert_template 'bulk_edit'
3006 3006
3007 3007 assert_tag :select,
3008 3008 :attributes => {:name => "issue[custom_field_values][#{field.id}]"},
3009 3009 :children => {
3010 3010 :only => {:tag => 'option'},
3011 3011 :count => Project.find(1).shared_versions.count + 2 # "no change" + "none" options
3012 3012 }
3013 3013 end
3014 3014
3015 3015 def test_get_bulk_edit_with_multi_custom_field
3016 3016 field = CustomField.find(1)
3017 3017 field.update_attribute :multiple, true
3018 3018
3019 3019 @request.session[:user_id] = 2
3020 3020 get :bulk_edit, :ids => [1, 2]
3021 3021 assert_response :success
3022 3022 assert_template 'bulk_edit'
3023 3023
3024 3024 assert_tag :select,
3025 3025 :attributes => {:name => "issue[custom_field_values][1][]"},
3026 3026 :children => {
3027 3027 :only => {:tag => 'option'},
3028 3028 :count => field.possible_values.size + 1 # "none" options
3029 3029 }
3030 3030 end
3031 3031
3032 3032 def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
3033 3033 WorkflowTransition.delete_all
3034 3034 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 1)
3035 3035 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
3036 3036 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
3037 3037 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
3038 3038 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
3039 3039 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
3040 3040 @request.session[:user_id] = 2
3041 3041 get :bulk_edit, :ids => [1, 2]
3042 3042
3043 3043 assert_response :success
3044 3044 statuses = assigns(:available_statuses)
3045 3045 assert_not_nil statuses
3046 3046 assert_equal [1, 3], statuses.map(&:id).sort
3047 3047
3048 3048 assert_tag 'select', :attributes => {:name => 'issue[status_id]'},
3049 3049 :children => {:count => 3} # 2 statuses + "no change" option
3050 3050 end
3051 3051
3052 3052 def test_bulk_edit_should_propose_target_project_open_shared_versions
3053 3053 @request.session[:user_id] = 2
3054 3054 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3055 3055 assert_response :success
3056 3056 assert_template 'bulk_edit'
3057 3057 assert_equal Project.find(1).shared_versions.open.all.sort, assigns(:versions).sort
3058 3058 assert_tag 'select',
3059 3059 :attributes => {:name => 'issue[fixed_version_id]'},
3060 3060 :descendant => {:tag => 'option', :content => '2.0'}
3061 3061 end
3062 3062
3063 3063 def test_bulk_edit_should_propose_target_project_categories
3064 3064 @request.session[:user_id] = 2
3065 3065 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3066 3066 assert_response :success
3067 3067 assert_template 'bulk_edit'
3068 3068 assert_equal Project.find(1).issue_categories.sort, assigns(:categories).sort
3069 3069 assert_tag 'select',
3070 3070 :attributes => {:name => 'issue[category_id]'},
3071 3071 :descendant => {:tag => 'option', :content => 'Recipes'}
3072 3072 end
3073 3073
3074 3074 def test_bulk_update
3075 3075 @request.session[:user_id] = 2
3076 3076 # update issues priority
3077 3077 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3078 3078 :issue => {:priority_id => 7,
3079 3079 :assigned_to_id => '',
3080 3080 :custom_field_values => {'2' => ''}}
3081 3081
3082 3082 assert_response 302
3083 3083 # check that the issues were updated
3084 3084 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
3085 3085
3086 3086 issue = Issue.find(1)
3087 3087 journal = issue.journals.find(:first, :order => 'created_on DESC')
3088 3088 assert_equal '125', issue.custom_value_for(2).value
3089 3089 assert_equal 'Bulk editing', journal.notes
3090 3090 assert_equal 1, journal.details.size
3091 3091 end
3092 3092
3093 3093 def test_bulk_update_with_group_assignee
3094 3094 group = Group.find(11)
3095 3095 project = Project.find(1)
3096 3096 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
3097 3097
3098 3098 @request.session[:user_id] = 2
3099 3099 # update issues assignee
3100 3100 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3101 3101 :issue => {:priority_id => '',
3102 3102 :assigned_to_id => group.id,
3103 3103 :custom_field_values => {'2' => ''}}
3104 3104
3105 3105 assert_response 302
3106 3106 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
3107 3107 end
3108 3108
3109 3109 def test_bulk_update_on_different_projects
3110 3110 @request.session[:user_id] = 2
3111 3111 # update issues priority
3112 3112 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
3113 3113 :issue => {:priority_id => 7,
3114 3114 :assigned_to_id => '',
3115 3115 :custom_field_values => {'2' => ''}}
3116 3116
3117 3117 assert_response 302
3118 3118 # check that the issues were updated
3119 3119 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
3120 3120
3121 3121 issue = Issue.find(1)
3122 3122 journal = issue.journals.find(:first, :order => 'created_on DESC')
3123 3123 assert_equal '125', issue.custom_value_for(2).value
3124 3124 assert_equal 'Bulk editing', journal.notes
3125 3125 assert_equal 1, journal.details.size
3126 3126 end
3127 3127
3128 3128 def test_bulk_update_on_different_projects_without_rights
3129 3129 @request.session[:user_id] = 3
3130 3130 user = User.find(3)
3131 3131 action = { :controller => "issues", :action => "bulk_update" }
3132 3132 assert user.allowed_to?(action, Issue.find(1).project)
3133 3133 assert ! user.allowed_to?(action, Issue.find(6).project)
3134 3134 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
3135 3135 :issue => {:priority_id => 7,
3136 3136 :assigned_to_id => '',
3137 3137 :custom_field_values => {'2' => ''}}
3138 3138 assert_response 403
3139 3139 assert_not_equal "Bulk should fail", Journal.last.notes
3140 3140 end
3141 3141
3142 3142 def test_bullk_update_should_send_a_notification
3143 3143 @request.session[:user_id] = 2
3144 3144 ActionMailer::Base.deliveries.clear
3145 3145 post(:bulk_update,
3146 3146 {
3147 3147 :ids => [1, 2],
3148 3148 :notes => 'Bulk editing',
3149 3149 :issue => {
3150 3150 :priority_id => 7,
3151 3151 :assigned_to_id => '',
3152 3152 :custom_field_values => {'2' => ''}
3153 3153 }
3154 3154 })
3155 3155
3156 3156 assert_response 302
3157 3157 assert_equal 2, ActionMailer::Base.deliveries.size
3158 3158 end
3159 3159
3160 3160 def test_bulk_update_project
3161 3161 @request.session[:user_id] = 2
3162 3162 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
3163 3163 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3164 3164 # Issues moved to project 2
3165 3165 assert_equal 2, Issue.find(1).project_id
3166 3166 assert_equal 2, Issue.find(2).project_id
3167 3167 # No tracker change
3168 3168 assert_equal 1, Issue.find(1).tracker_id
3169 3169 assert_equal 2, Issue.find(2).tracker_id
3170 3170 end
3171 3171
3172 3172 def test_bulk_update_project_on_single_issue_should_follow_when_needed
3173 3173 @request.session[:user_id] = 2
3174 3174 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
3175 3175 assert_redirected_to '/issues/1'
3176 3176 end
3177 3177
3178 3178 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
3179 3179 @request.session[:user_id] = 2
3180 3180 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
3181 3181 assert_redirected_to '/projects/onlinestore/issues'
3182 3182 end
3183 3183
3184 3184 def test_bulk_update_tracker
3185 3185 @request.session[:user_id] = 2
3186 3186 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
3187 3187 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3188 3188 assert_equal 2, Issue.find(1).tracker_id
3189 3189 assert_equal 2, Issue.find(2).tracker_id
3190 3190 end
3191 3191
3192 3192 def test_bulk_update_status
3193 3193 @request.session[:user_id] = 2
3194 3194 # update issues priority
3195 3195 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
3196 3196 :issue => {:priority_id => '',
3197 3197 :assigned_to_id => '',
3198 3198 :status_id => '5'}
3199 3199
3200 3200 assert_response 302
3201 3201 issue = Issue.find(1)
3202 3202 assert issue.closed?
3203 3203 end
3204 3204
3205 3205 def test_bulk_update_priority
3206 3206 @request.session[:user_id] = 2
3207 3207 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3208 3208
3209 3209 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3210 3210 assert_equal 6, Issue.find(1).priority_id
3211 3211 assert_equal 6, Issue.find(2).priority_id
3212 3212 end
3213 3213
3214 3214 def test_bulk_update_with_notes
3215 3215 @request.session[:user_id] = 2
3216 3216 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
3217 3217
3218 3218 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3219 3219 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
3220 3220 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
3221 3221 end
3222 3222
3223 3223 def test_bulk_update_parent_id
3224 3224 @request.session[:user_id] = 2
3225 3225 post :bulk_update, :ids => [1, 3],
3226 3226 :notes => 'Bulk editing parent',
3227 3227 :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
3228 3228
3229 3229 assert_response 302
3230 3230 parent = Issue.find(2)
3231 3231 assert_equal parent.id, Issue.find(1).parent_id
3232 3232 assert_equal parent.id, Issue.find(3).parent_id
3233 3233 assert_equal [1, 3], parent.children.collect(&:id).sort
3234 3234 end
3235 3235
3236 3236 def test_bulk_update_custom_field
3237 3237 @request.session[:user_id] = 2
3238 3238 # update issues priority
3239 3239 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
3240 3240 :issue => {:priority_id => '',
3241 3241 :assigned_to_id => '',
3242 3242 :custom_field_values => {'2' => '777'}}
3243 3243
3244 3244 assert_response 302
3245 3245
3246 3246 issue = Issue.find(1)
3247 3247 journal = issue.journals.find(:first, :order => 'created_on DESC')
3248 3248 assert_equal '777', issue.custom_value_for(2).value
3249 3249 assert_equal 1, journal.details.size
3250 3250 assert_equal '125', journal.details.first.old_value
3251 3251 assert_equal '777', journal.details.first.value
3252 3252 end
3253 3253
3254 3254 def test_bulk_update_custom_field_to_blank
3255 3255 @request.session[:user_id] = 2
3256 3256 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing custom field',
3257 3257 :issue => {:priority_id => '',
3258 3258 :assigned_to_id => '',
3259 3259 :custom_field_values => {'1' => '__none__'}}
3260 3260 assert_response 302
3261 3261 assert_equal '', Issue.find(1).custom_field_value(1)
3262 3262 assert_equal '', Issue.find(3).custom_field_value(1)
3263 3263 end
3264 3264
3265 3265 def test_bulk_update_multi_custom_field
3266 3266 field = CustomField.find(1)
3267 3267 field.update_attribute :multiple, true
3268 3268
3269 3269 @request.session[:user_id] = 2
3270 3270 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
3271 3271 :issue => {:priority_id => '',
3272 3272 :assigned_to_id => '',
3273 3273 :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
3274 3274
3275 3275 assert_response 302
3276 3276
3277 3277 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
3278 3278 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
3279 3279 # the custom field is not associated with the issue tracker
3280 3280 assert_nil Issue.find(2).custom_field_value(1)
3281 3281 end
3282 3282
3283 3283 def test_bulk_update_multi_custom_field_to_blank
3284 3284 field = CustomField.find(1)
3285 3285 field.update_attribute :multiple, true
3286 3286
3287 3287 @request.session[:user_id] = 2
3288 3288 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing multi custom field',
3289 3289 :issue => {:priority_id => '',
3290 3290 :assigned_to_id => '',
3291 3291 :custom_field_values => {'1' => ['__none__']}}
3292 3292 assert_response 302
3293 3293 assert_equal [''], Issue.find(1).custom_field_value(1)
3294 3294 assert_equal [''], Issue.find(3).custom_field_value(1)
3295 3295 end
3296 3296
3297 3297 def test_bulk_update_unassign
3298 3298 assert_not_nil Issue.find(2).assigned_to
3299 3299 @request.session[:user_id] = 2
3300 3300 # unassign issues
3301 3301 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
3302 3302 assert_response 302
3303 3303 # check that the issues were updated
3304 3304 assert_nil Issue.find(2).assigned_to
3305 3305 end
3306 3306
3307 3307 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
3308 3308 @request.session[:user_id] = 2
3309 3309
3310 3310 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
3311 3311
3312 3312 assert_response :redirect
3313 3313 issues = Issue.find([1,2])
3314 3314 issues.each do |issue|
3315 3315 assert_equal 4, issue.fixed_version_id
3316 3316 assert_not_equal issue.project_id, issue.fixed_version.project_id
3317 3317 end
3318 3318 end
3319 3319
3320 3320 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
3321 3321 @request.session[:user_id] = 2
3322 3322 post :bulk_update, :ids => [1,2], :back_url => '/issues'
3323 3323
3324 3324 assert_response :redirect
3325 3325 assert_redirected_to '/issues'
3326 3326 end
3327 3327
3328 3328 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3329 3329 @request.session[:user_id] = 2
3330 3330 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
3331 3331
3332 3332 assert_response :redirect
3333 3333 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
3334 3334 end
3335 3335
3336 3336 def test_bulk_update_with_failure_should_set_flash
3337 3337 @request.session[:user_id] = 2
3338 3338 Issue.update_all("subject = ''", "id = 2") # Make it invalid
3339 3339 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3340 3340
3341 3341 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3342 3342 assert_equal 'Failed to save 1 issue(s) on 2 selected: #2.', flash[:error]
3343 3343 end
3344 3344
3345 3345 def test_get_bulk_copy
3346 3346 @request.session[:user_id] = 2
3347 3347 get :bulk_edit, :ids => [1, 2, 3], :copy => '1'
3348 3348 assert_response :success
3349 3349 assert_template 'bulk_edit'
3350 3350
3351 3351 issues = assigns(:issues)
3352 3352 assert_not_nil issues
3353 3353 assert_equal [1, 2, 3], issues.map(&:id).sort
3354 3354
3355 3355 assert_select 'input[name=copy_attachments]'
3356 3356 end
3357 3357
3358 3358 def test_bulk_copy_to_another_project
3359 3359 @request.session[:user_id] = 2
3360 3360 assert_difference 'Issue.count', 2 do
3361 3361 assert_no_difference 'Project.find(1).issues.count' do
3362 3362 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
3363 3363 end
3364 3364 end
3365 3365 assert_redirected_to '/projects/ecookbook/issues'
3366 3366
3367 3367 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3368 3368 copies.each do |copy|
3369 3369 assert_equal 2, copy.project_id
3370 3370 end
3371 3371 end
3372 3372
3373 3373 def test_bulk_copy_should_allow_not_changing_the_issue_attributes
3374 3374 @request.session[:user_id] = 2
3375 3375 issues = [
3376 3376 Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 1, :priority_id => 2, :subject => 'issue 1', :author_id => 1, :assigned_to_id => nil),
3377 3377 Issue.create!(:project_id => 2, :tracker_id => 3, :status_id => 2, :priority_id => 1, :subject => 'issue 2', :author_id => 2, :assigned_to_id => 3)
3378 3378 ]
3379 3379
3380 3380 assert_difference 'Issue.count', issues.size do
3381 3381 post :bulk_update, :ids => issues.map(&:id), :copy => '1',
3382 3382 :issue => {
3383 3383 :project_id => '', :tracker_id => '', :assigned_to_id => '',
3384 3384 :status_id => '', :start_date => '', :due_date => ''
3385 3385 }
3386 3386 end
3387 3387
3388 3388 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3389 3389 issues.each do |orig|
3390 3390 copy = copies.detect {|c| c.subject == orig.subject}
3391 3391 assert_not_nil copy
3392 3392 assert_equal orig.project_id, copy.project_id
3393 3393 assert_equal orig.tracker_id, copy.tracker_id
3394 3394 assert_equal orig.status_id, copy.status_id
3395 3395 assert_equal orig.assigned_to_id, copy.assigned_to_id
3396 3396 assert_equal orig.priority_id, copy.priority_id
3397 3397 end
3398 3398 end
3399 3399
3400 3400 def test_bulk_copy_should_allow_changing_the_issue_attributes
3401 3401 # Fixes random test failure with Mysql
3402 3402 # where Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3403 3403 # doesn't return the expected results
3404 3404 Issue.delete_all("project_id=2")
3405 3405
3406 3406 @request.session[:user_id] = 2
3407 3407 assert_difference 'Issue.count', 2 do
3408 3408 assert_no_difference 'Project.find(1).issues.count' do
3409 3409 post :bulk_update, :ids => [1, 2], :copy => '1',
3410 3410 :issue => {
3411 3411 :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
3412 3412 :status_id => '1', :start_date => '2009-12-01', :due_date => '2009-12-31'
3413 3413 }
3414 3414 end
3415 3415 end
3416 3416
3417 3417 copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3418 3418 assert_equal 2, copied_issues.size
3419 3419 copied_issues.each do |issue|
3420 3420 assert_equal 2, issue.project_id, "Project is incorrect"
3421 3421 assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
3422 3422 assert_equal 1, issue.status_id, "Status is incorrect"
3423 3423 assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
3424 3424 assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
3425 3425 end
3426 3426 end
3427 3427
3428 3428 def test_bulk_copy_should_allow_adding_a_note
3429 3429 @request.session[:user_id] = 2
3430 3430 assert_difference 'Issue.count', 1 do
3431 3431 post :bulk_update, :ids => [1], :copy => '1',
3432 3432 :notes => 'Copying one issue',
3433 3433 :issue => {
3434 3434 :project_id => '', :tracker_id => '', :assigned_to_id => '4',
3435 3435 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
3436 3436 }
3437 3437 end
3438 3438
3439 3439 issue = Issue.first(:order => 'id DESC')
3440 3440 assert_equal 1, issue.journals.size
3441 3441 journal = issue.journals.first
3442 3442 assert_equal 0, journal.details.size
3443 3443 assert_equal 'Copying one issue', journal.notes
3444 3444 end
3445 3445
3446 3446 def test_bulk_copy_should_allow_not_copying_the_attachments
3447 3447 attachment_count = Issue.find(3).attachments.size
3448 3448 assert attachment_count > 0
3449 3449 @request.session[:user_id] = 2
3450 3450
3451 3451 assert_difference 'Issue.count', 1 do
3452 3452 assert_no_difference 'Attachment.count' do
3453 3453 post :bulk_update, :ids => [3], :copy => '1',
3454 3454 :issue => {
3455 3455 :project_id => ''
3456 3456 }
3457 3457 end
3458 3458 end
3459 3459 end
3460 3460
3461 3461 def test_bulk_copy_should_allow_copying_the_attachments
3462 3462 attachment_count = Issue.find(3).attachments.size
3463 3463 assert attachment_count > 0
3464 3464 @request.session[:user_id] = 2
3465 3465
3466 3466 assert_difference 'Issue.count', 1 do
3467 3467 assert_difference 'Attachment.count', attachment_count do
3468 3468 post :bulk_update, :ids => [3], :copy => '1', :copy_attachments => '1',
3469 3469 :issue => {
3470 3470 :project_id => ''
3471 3471 }
3472 3472 end
3473 3473 end
3474 3474 end
3475 3475
3476 3476 def test_bulk_copy_to_another_project_should_follow_when_needed
3477 3477 @request.session[:user_id] = 2
3478 3478 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
3479 3479 issue = Issue.first(:order => 'id DESC')
3480 3480 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
3481 3481 end
3482 3482
3483 3483 def test_destroy_issue_with_no_time_entries
3484 3484 assert_nil TimeEntry.find_by_issue_id(2)
3485 3485 @request.session[:user_id] = 2
3486 3486
3487 3487 assert_difference 'Issue.count', -1 do
3488 3488 delete :destroy, :id => 2
3489 3489 end
3490 3490 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3491 3491 assert_nil Issue.find_by_id(2)
3492 3492 end
3493 3493
3494 3494 def test_destroy_issues_with_time_entries
3495 3495 @request.session[:user_id] = 2
3496 3496
3497 3497 assert_no_difference 'Issue.count' do
3498 3498 delete :destroy, :ids => [1, 3]
3499 3499 end
3500 3500 assert_response :success
3501 3501 assert_template 'destroy'
3502 3502 assert_not_nil assigns(:hours)
3503 3503 assert Issue.find_by_id(1) && Issue.find_by_id(3)
3504 3504 assert_tag 'form',
3505 3505 :descendant => {:tag => 'input', :attributes => {:name => '_method', :value => 'delete'}}
3506 3506 end
3507 3507
3508 3508 def test_destroy_issues_and_destroy_time_entries
3509 3509 @request.session[:user_id] = 2
3510 3510
3511 3511 assert_difference 'Issue.count', -2 do
3512 3512 assert_difference 'TimeEntry.count', -3 do
3513 3513 delete :destroy, :ids => [1, 3], :todo => 'destroy'
3514 3514 end
3515 3515 end
3516 3516 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3517 3517 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3518 3518 assert_nil TimeEntry.find_by_id([1, 2])
3519 3519 end
3520 3520
3521 3521 def test_destroy_issues_and_assign_time_entries_to_project
3522 3522 @request.session[:user_id] = 2
3523 3523
3524 3524 assert_difference 'Issue.count', -2 do
3525 3525 assert_no_difference 'TimeEntry.count' do
3526 3526 delete :destroy, :ids => [1, 3], :todo => 'nullify'
3527 3527 end
3528 3528 end
3529 3529 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3530 3530 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3531 3531 assert_nil TimeEntry.find(1).issue_id
3532 3532 assert_nil TimeEntry.find(2).issue_id
3533 3533 end
3534 3534
3535 3535 def test_destroy_issues_and_reassign_time_entries_to_another_issue
3536 3536 @request.session[:user_id] = 2
3537 3537
3538 3538 assert_difference 'Issue.count', -2 do
3539 3539 assert_no_difference 'TimeEntry.count' do
3540 3540 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
3541 3541 end
3542 3542 end
3543 3543 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3544 3544 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3545 3545 assert_equal 2, TimeEntry.find(1).issue_id
3546 3546 assert_equal 2, TimeEntry.find(2).issue_id
3547 3547 end
3548 3548
3549 3549 def test_destroy_issues_from_different_projects
3550 3550 @request.session[:user_id] = 2
3551 3551
3552 3552 assert_difference 'Issue.count', -3 do
3553 3553 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
3554 3554 end
3555 3555 assert_redirected_to :controller => 'issues', :action => 'index'
3556 3556 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
3557 3557 end
3558 3558
3559 3559 def test_destroy_parent_and_child_issues
3560 3560 parent = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Parent Issue')
3561 3561 child = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Child Issue', :parent_issue_id => parent.id)
3562 3562 assert child.is_descendant_of?(parent.reload)
3563 3563
3564 3564 @request.session[:user_id] = 2
3565 3565 assert_difference 'Issue.count', -2 do
3566 3566 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
3567 3567 end
3568 3568 assert_response 302
3569 3569 end
3570 3570
3571 3571 def test_default_search_scope
3572 3572 get :index
3573 3573 assert_tag :div, :attributes => {:id => 'quick-search'},
3574 3574 :child => {:tag => 'form',
3575 3575 :child => {:tag => 'input', :attributes => {:name => 'issues', :type => 'hidden', :value => '1'}}}
3576 3576 end
3577 3577 end
General Comments 0
You need to be logged in to leave comments. Login now