jro_apps/redmine Commit - r10016:8fb1a7e3ccc7

Fixed that open scope on Project#issues raises an error (#11545)....

Jean-Philippe Lang -

r10016:8fb1a7e3ccc7

parent child

Context file:

r10016:8fb1a7e3ccc7

Collapse all files

app/models/issue.rb 0 -1

              # Redmine - project management software
              # Copyright (C) 2006-2012  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class Issue < ActiveRecord::Base
                include Redmine::SafeAttributes
                belongs_to :project
                belongs_to :tracker
                belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
                belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
                belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
                belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
                belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
                belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
                has_many :journals, :as => :journalized, :dependent => :destroy
                has_many :time_entries, :dependent => :delete_all
                has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
                has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
                has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
                acts_as_nested_set :scope => 'root_id', :dependent => :destroy
                acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
                acts_as_customizable
                acts_as_watchable
                acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
                                   :include => [:project, :journals],
                                   # sort by id so that limited eager loading doesn't break with postgresql
                                   :order_column => "#{table_name}.id"
                acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
                              :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
                              :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
                acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
                                          :author_key => :author_id
                DONE_RATIO_OPTIONS = %w(issue_field issue_status)
                attr_reader :current_journal
                validates_presence_of :subject, :priority, :project, :tracker, :author, :status
                validates_length_of :subject, :maximum => 255
                validates_inclusion_of :done_ratio, :in => 0..100
                validates_numericality_of :estimated_hours, :allow_nil => true
                validate :validate_issue, :validate_required_fields
                scope :visible,
                      lambda {|*args| { :include => :project,
                                        :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
-               class << self; undef :open; end
                scope :open, lambda {|*args|
                  is_closed = args.size > 0 ? !args.first : false
                  {:conditions => ["#{IssueStatus.table_name}.is_closed = ?", is_closed], :include => :status}
                }
                scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
                scope :with_limit, lambda { |limit| { :limit => limit} }
                scope :on_active_project, :include => [:status, :project, :tracker],
                                          :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
                before_create :default_assign
                before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change
                after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
                after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
                after_destroy :update_parent_attributes
                # Returns a SQL conditions string used to find all issues visible by the specified user
                def self.visible_condition(user, options={})
                  Project.allowed_to_condition(user, :view_issues, options) do |role, user|
                    case role.issues_visibility
                    when 'all'
                      nil
                    when 'default'
                      user_ids = [user.id] + user.groups.map(&:id)
                      "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                    when 'own'
                      user_ids = [user.id] + user.groups.map(&:id)
                      "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                    else
                      '1=0'
                    end
                  end
                end
                # Returns true if usr or current user is allowed to view the issue
                def visible?(usr=nil)
                  (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
                    case role.issues_visibility
                    when 'all'
                      true
                    when 'default'
                      !self.is_private? || self.author == user || user.is_or_belongs_to?(assigned_to)
                    when 'own'
                      self.author == user || user.is_or_belongs_to?(assigned_to)
                    else
                      false
                    end
                  end
                end
                def initialize(attributes=nil, *args)
                  super
                  if new_record?
                    # set default values for new records only
                    self.status ||= IssueStatus.default
                    self.priority ||= IssuePriority.default
                    self.watcher_user_ids = []
                  end
                end
                # AR#Persistence#destroy would raise and RecordNotFound exception
                # if the issue was already deleted or updated (non matching lock_version).
                # This is a problem when bulk deleting issues or deleting a project
                # (because an issue may already be deleted if its parent was deleted
                # first).
                # The issue is reloaded by the nested_set before being deleted so
                # the lock_version condition should not be an issue but we handle it.
                def destroy
                  super
                rescue ActiveRecord::RecordNotFound
                  # Stale or already deleted
                  begin
                    reload
                  rescue ActiveRecord::RecordNotFound
                    # The issue was actually already deleted
                    @destroyed = true
                    return freeze
                  end
                  # The issue was stale, retry to destroy
                  super
                end
                def reload(*args)
                  @workflow_rule_by_attribute = nil
                  @assignable_versions = nil
                  super
                end
                # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
                def available_custom_fields
                  (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
                end
                # Copies attributes from another issue, arg can be an id or an Issue
                def copy_from(arg, options={})
                  issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
                  self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
                  self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                  self.status = issue.status
                  self.author = User.current
                  unless options[:attachments] == false
                    self.attachments = issue.attachments.map do |attachement|
                      attachement.copy(:container => self)
                    end
                  end
                  @copied_from = issue
                  self
                end
                # Returns an unsaved copy of the issue
                def copy(attributes=nil, copy_options={})
                  copy = self.class.new.copy_from(self, copy_options)
                  copy.attributes = attributes if attributes
                  copy
                end
                # Returns true if the issue is a copy
                def copy?
                  @copied_from.present?
                end
                # Moves/copies an issue to a new project and tracker
                # Returns the moved/copied issue on success, false on failure
                def move_to_project(new_project, new_tracker=nil, options={})
                  ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
                  if options[:copy]
                    issue = self.copy
                  else
                    issue = self
                  end
                  issue.init_journal(User.current, options[:notes])
                  # Preserve previous behaviour
                  # #move_to_project doesn't change tracker automatically
                  issue.send :project=, new_project, true
                  if new_tracker
                    issue.tracker = new_tracker
                  end
                  # Allow bulk setting of attributes on the issue
                  if options[:attributes]
                    issue.attributes = options[:attributes]
                  end
                  issue.save ? issue : false
                end
                def status_id=(sid)
                  self.status = nil
                  result = write_attribute(:status_id, sid)
                  @workflow_rule_by_attribute = nil
                  result
                end
                def priority_id=(pid)
                  self.priority = nil
                  write_attribute(:priority_id, pid)
                end
                def category_id=(cid)
                  self.category = nil
                  write_attribute(:category_id, cid)
                end
                def fixed_version_id=(vid)
                  self.fixed_version = nil
                  write_attribute(:fixed_version_id, vid)
                end
                def tracker_id=(tid)
                  self.tracker = nil
                  result = write_attribute(:tracker_id, tid)
                  @custom_field_values = nil
                  @workflow_rule_by_attribute = nil
                  result
                end
                def project_id=(project_id)
                  if project_id.to_s != self.project_id.to_s
                    self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
                  end
                end
                def project=(project, keep_tracker=false)
                  project_was = self.project
                  write_attribute(:project_id, project ? project.id : nil)
                  association_instance_set('project', project)
                  if project_was && project && project_was != project
                    @assignable_versions = nil
                    unless keep_tracker || project.trackers.include?(tracker)
                      self.tracker = project.trackers.first
                    end
                    # Reassign to the category with same name if any
                    if category
                      self.category = project.issue_categories.find_by_name(category.name)
                    end
                    # Keep the fixed_version if it's still valid in the new_project
                    if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
                      self.fixed_version = nil
                    end
                    if parent && parent.project_id != project_id
                      self.parent_issue_id = nil
                    end
                    @custom_field_values = nil
                  end
                end
                def description=(arg)
                  if arg.is_a?(String)
                    arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
                  end
                  write_attribute(:description, arg)
                end
                # Overrides assign_attributes so that project and tracker get assigned first
                def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
                  return if new_attributes.nil?
                  attrs = new_attributes.dup
                  attrs.stringify_keys!
                  %w(project project_id tracker tracker_id).each do |attr|
                    if attrs.has_key?(attr)
                      send "#{attr}=", attrs.delete(attr)
                    end
                  end
                  send :assign_attributes_without_project_and_tracker_first, attrs, *args
                end
                # Do not redefine alias chain on reload (see #4838)
                alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
                def estimated_hours=(h)
                  write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
                end
                safe_attributes 'project_id',
                  :if => lambda {|issue, user|
                    if issue.new_record?
                      issue.copy?
                    elsif user.allowed_to?(:move_issues, issue.project)
                      projects = Issue.allowed_target_projects_on_move(user)
                      projects.include?(issue.project) && projects.size > 1
                    end
                  }
                safe_attributes 'tracker_id',
                  'status_id',
                  'category_id',
                  'assigned_to_id',
                  'priority_id',
                  'fixed_version_id',
                  'subject',
                  'description',
                  'start_date',
                  'due_date',
                  'done_ratio',
                  'estimated_hours',
                  'custom_field_values',
                  'custom_fields',
                  'lock_version',
                  :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
                safe_attributes 'status_id',
                  'assigned_to_id',
                  'fixed_version_id',
                  'done_ratio',
                  'lock_version',
                  :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
                safe_attributes 'watcher_user_ids',
                  :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
                safe_attributes 'is_private',
                  :if => lambda {|issue, user|
                    user.allowed_to?(:set_issues_private, issue.project) ||
                      (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
                  }
                safe_attributes 'parent_issue_id',
                  :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
                    user.allowed_to?(:manage_subtasks, issue.project)}
                def safe_attribute_names(user=nil)
                  names = super
                  names -= disabled_core_fields
                  names -= read_only_attribute_names(user)
                  names
                end
                # Safely sets attributes
                # Should be called from controllers instead of #attributes=
                # attr_accessible is too rough because we still want things like
                # Issue.new(:project => foo) to work
                def safe_attributes=(attrs, user=User.current)
                  return unless attrs.is_a?(Hash)
                  attrs = attrs.dup
                  # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
                  if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
                    if allowed_target_projects(user).collect(&:id).include?(p.to_i)
                      self.project_id = p
                    end
                  end
                  if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
                    self.tracker_id = t
                  end
                  if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
                    if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
                      self.status_id = s
                    end
                  end
                  attrs = delete_unsafe_attributes(attrs, user)
                  return if attrs.empty?
                  unless leaf?
                    attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
                  end
                  if attrs['parent_issue_id'].present?
                    attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
                  end
                  if attrs['custom_field_values'].present?
                    attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
                  end
                  if attrs['custom_fields'].present?
                    attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
                  end
                  # mass-assignment security bypass
                  assign_attributes attrs, :without_protection => true
                end
                def disabled_core_fields
                  tracker ? tracker.disabled_core_fields : []
                end
                # Returns the custom_field_values that can be edited by the given user
                def editable_custom_field_values(user=nil)
                  custom_field_values.reject do |value|
                    read_only_attribute_names(user).include?(value.custom_field_id.to_s)
                  end
                end
                # Returns the names of attributes that are read-only for user or the current user
                # For users with multiple roles, the read-only fields are the intersection of
                # read-only fields of each role
                # The result is an array of strings where sustom fields are represented with their ids
                #
                # Examples:
                #   issue.read_only_attribute_names # => ['due_date', '2']
                #   issue.read_only_attribute_names(user) # => []
                def read_only_attribute_names(user=nil)
                  workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
                end
                # Returns the names of required attributes for user or the current user
                # For users with multiple roles, the required fields are the intersection of
                # required fields of each role
                # The result is an array of strings where sustom fields are represented with their ids
                #
                # Examples:
                #   issue.required_attribute_names # => ['due_date', '2']
                #   issue.required_attribute_names(user) # => []
                def required_attribute_names(user=nil)
                  workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
                end
                # Returns true if the attribute is required for user
                def required_attribute?(name, user=nil)
                  required_attribute_names(user).include?(name.to_s)
                end
                # Returns a hash of the workflow rule by attribute for the given user
                #
                # Examples:
                #   issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
                def workflow_rule_by_attribute(user=nil)
                  return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
                  user_real = user || User.current
                  roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
                  return {} if roles.empty?
                  result = {}
                  workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
                  if workflow_permissions.any?
                    workflow_rules = workflow_permissions.inject({}) do |h, wp|
                      h[wp.field_name] ||= []
                      h[wp.field_name] << wp.rule
                      h
                    end
                    workflow_rules.each do |attr, rules|
                      next if rules.size < roles.size
                      uniq_rules = rules.uniq
                      if uniq_rules.size == 1
                        result[attr] = uniq_rules.first
                      else
                        result[attr] = 'required'
                      end
                    end
                  end
                  @workflow_rule_by_attribute = result if user.nil?
                  result
                end
                private :workflow_rule_by_attribute
                def done_ratio
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    status.default_done_ratio
                  else
                    read_attribute(:done_ratio)
                  end
                end
                def self.use_status_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_status'
                end
                def self.use_field_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_field'
                end
                def validate_issue
                  if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
                    errors.add :due_date, :not_a_date
                  end
                  if self.due_date and self.start_date and self.due_date < self.start_date
                    errors.add :due_date, :greater_than_start_date
                  end
                  if start_date && soonest_start && start_date < soonest_start
                    errors.add :start_date, :invalid
                  end
                  if fixed_version
                    if !assignable_versions.include?(fixed_version)
                      errors.add :fixed_version_id, :inclusion
                    elsif reopened? && fixed_version.closed?
                      errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
                    end
                  end
                  # Checks that the issue can not be added/moved to a disabled tracker
                  if project && (tracker_id_changed? || project_id_changed?)
                    unless project.trackers.include?(tracker)
                      errors.add :tracker_id, :inclusion
                    end
                  end
                  # Checks parent issue assignment
                  if @parent_issue
                    if @parent_issue.project_id != project_id
                      errors.add :parent_issue_id, :not_same_project
                    elsif !new_record?
                      # moving an existing issue
                      if @parent_issue.root_id != root_id
                        # we can always move to another tree
                      elsif move_possible?(@parent_issue)
                        # move accepted inside tree
                      else
                        errors.add :parent_issue_id, :not_a_valid_parent
                      end
                    end
                  end
                end
                # Validates the issue against additional workflow requirements
                def validate_required_fields
                  user = new_record? ? author : current_journal.try(:user)
                  required_attribute_names(user).each do |attribute|
                    if attribute =~ /^\d+$/
                      attribute = attribute.to_i
                      v = custom_field_values.detect {|v| v.custom_field_id == attribute }
                      if v && v.value.blank?
                        errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
                      end
                    else
                      if respond_to?(attribute) && send(attribute).blank?
                        errors.add attribute, :blank
                      end
                    end
                  end
                end
                # Set the done_ratio using the status if that setting is set.  This will keep the done_ratios
                # even if the user turns off the setting later
                def update_done_ratio_from_issue_status
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    self.done_ratio = status.default_done_ratio
                  end
                end
                def init_journal(user, notes = "")
                  @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
                  if new_record?
                    @current_journal.notify = false
                  else
                    @attributes_before_change = attributes.dup
                    @custom_values_before_change = {}
                    self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
                  end
                  @current_journal
                end
                # Returns the id of the last journal or nil
                def last_journal_id
                  if new_record?
                    nil
                  else
                    journals.maximum(:id)
                  end
                end
                # Returns a scope for journals that have an id greater than journal_id
                def journals_after(journal_id)
                  scope = journals.reorder("#{Journal.table_name}.id ASC")
                  if journal_id.present?
                    scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
                  end
                  scope
                end
                # Return true if the issue is closed, otherwise false
                def closed?
                  self.status.is_closed?
                end
                # Return true if the issue is being reopened
                def reopened?
                  if !new_record? && status_id_changed?
                    status_was = IssueStatus.find_by_id(status_id_was)
                    status_new = IssueStatus.find_by_id(status_id)
                    if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
                      return true
                    end
                  end
                  false
                end
                # Return true if the issue is being closed
                def closing?
                  if !new_record? && status_id_changed?
                    status_was = IssueStatus.find_by_id(status_id_was)
                    status_new = IssueStatus.find_by_id(status_id)
                    if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
                      return true
                    end
                  end
                  false
                end
                # Returns true if the issue is overdue
                def overdue?
                  !due_date.nil? && (due_date < Date.today) && !status.is_closed?
                end
                # Is the amount of work done less than it should for the due date
                def behind_schedule?
                  return false if start_date.nil? || due_date.nil?
                  done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
                  return done_date <= Date.today
                end
                # Does this issue have children?
                def children?
                  !leaf?
                end
                # Users the issue can be assigned to
                def assignable_users
                  users = project.assignable_users
                  users << author if author
                  users << assigned_to if assigned_to
                  users.uniq.sort
                end
                # Versions that the issue can be assigned to
                def assignable_versions
                  return @assignable_versions if @assignable_versions
                  versions = project.shared_versions.open.all
                  if fixed_version
                    if fixed_version_id_changed?
                      # nothing to do
                    elsif project_id_changed?
                      if project.shared_versions.include?(fixed_version)
                        versions << fixed_version
                      end
                    else
                      versions << fixed_version
                    end
                  end
                  @assignable_versions = versions.uniq.sort
                end
                # Returns true if this issue is blocked by another issue that is still open
                def blocked?
                  !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
                end
                # Returns an array of statuses that user is able to apply
                def new_statuses_allowed_to(user=User.current, include_default=false)
                  if new_record? && @copied_from
                    [IssueStatus.default, @copied_from.status].compact.uniq.sort
                  else
                    initial_status = nil
                    if new_record?
                      initial_status = IssueStatus.default
                    elsif status_id_was
                      initial_status = IssueStatus.find_by_id(status_id_was)
                    end
                    initial_status ||= status
                    statuses = initial_status.find_new_statuses_allowed_to(
                      user.admin ? Role.all : user.roles_for_project(project),
                      tracker,
                      author == user,
                      assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
                      )
                    statuses << initial_status unless statuses.empty?
                    statuses << IssueStatus.default if include_default
                    statuses = statuses.compact.uniq.sort
                    blocked? ? statuses.reject {|s| s.is_closed?} : statuses
                  end
                end
                def assigned_to_was
                  if assigned_to_id_changed? && assigned_to_id_was.present?
                    @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
                  end
                end
                # Returns the mail adresses of users that should be notified
                def recipients
                  notified = []
                  # Author and assignee are always notified unless they have been
                  # locked or don't want to be notified
                  notified << author if author
                  if assigned_to
                    notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
                  end
                  if assigned_to_was
                    notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
                  end
                  notified = notified.select {|u| u.active? && u.notify_about?(self)}
                  notified += project.notified_users
                  notified.uniq!
                  # Remove users that can not view the issue
                  notified.reject! {|user| !visible?(user)}
                  notified.collect(&:mail)
                end
                # Returns the number of hours spent on this issue
                def spent_hours
                  @spent_hours ||= time_entries.sum(:hours) || 0
                end
                # Returns the total number of hours spent on this issue and its descendants
                #
                # Example:
                #   spent_hours => 0.0
                #   spent_hours => 50.2
                def total_spent_hours
                  @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
                    :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
                end
                def relations
                  @relations ||= (relations_from + relations_to).sort
                end
                # Preloads relations for a collection of issues
                def self.load_relations(issues)
                  if issues.any?
                    relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
                    issues.each do |issue|
                      issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
                    end
                  end
                end
                # Preloads visible spent time for a collection of issues
                def self.load_visible_spent_hours(issues, user=User.current)
                  if issues.any?
                    hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
                    issues.each do |issue|
                      issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
                    end
                  end
                end
                # Finds an issue relation given its id.
                def find_relation(relation_id)
                  IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
                end
                def all_dependent_issues(except=[])
                  except << self
                  dependencies = []
                  relations_from.each do |relation|
                    if relation.issue_to && !except.include?(relation.issue_to)
                      dependencies << relation.issue_to
                      dependencies += relation.issue_to.all_dependent_issues(except)
                    end
                  end
                  dependencies
                end
                # Returns an array of issues that duplicate this one
                def duplicates
                  relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
                end
                # Returns the due date or the target due date if any
                # Used on gantt chart
                def due_before
                  due_date || (fixed_version ? fixed_version.effective_date : nil)
                end
                # Returns the time scheduled for this issue.
                #
                # Example:
                #   Start Date: 2/26/09, End Date: 3/04/09
                #   duration => 6
                def duration
                  (start_date && due_date) ? due_date - start_date : 0
                end
                def soonest_start
                  @soonest_start ||= (
                      relations_to.collect{|relation| relation.successor_soonest_start} +
                      ancestors.collect(&:soonest_start)
                    ).compact.max
                end
                def reschedule_after(date)
                  return if date.nil?
                  if leaf?
                    if start_date.nil? || start_date < date
                      self.start_date, self.due_date = date, date + duration
                      begin
                        save
                      rescue ActiveRecord::StaleObjectError
                        reload
                        self.start_date, self.due_date = date, date + duration
                        save
                      end
                    end
                  else
                    leaves.each do |leaf|
                      leaf.reschedule_after(date)
                    end
                  end
                end
                def <=>(issue)
                  if issue.nil?
                    -1
                  elsif root_id != issue.root_id
                    (root_id || 0) <=> (issue.root_id || 0)
                  else
                    (lft || 0) <=> (issue.lft || 0)
                  end
                end
                def to_s
                  "#{tracker} ##{id}: #{subject}"
                end
                # Returns a string of css classes that apply to the issue
                def css_classes
                  s = "issue status-#{status_id} priority-#{priority_id}"
                  s << ' closed' if closed?
                  s << ' overdue' if overdue?
                  s << ' child' if child?
                  s << ' parent' unless leaf?
                  s << ' private' if is_private?
                  s << ' created-by-me' if User.current.logged? && author_id == User.current.id
                  s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
                  s
                end
                # Saves an issue and a time_entry from the parameters
                def save_issue_with_child_records(params, existing_time_entry=nil)
                  Issue.transaction do
                    if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
                      @time_entry = existing_time_entry || TimeEntry.new
                      @time_entry.project = project
                      @time_entry.issue = self
                      @time_entry.user = User.current
                      @time_entry.spent_on = User.current.today
                      @time_entry.attributes = params[:time_entry]
                      self.time_entries << @time_entry
                    end
                    # TODO: Rename hook
                    Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                    if save
                      # TODO: Rename hook
                      Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                    else
                      raise ActiveRecord::Rollback
                    end
                  end
                end
                # Unassigns issues from +version+ if it's no longer shared with issue's project
                def self.update_versions_from_sharing_change(version)
                  # Update issues assigned to the version
                  update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
                end
                # Unassigns issues from versions that are no longer shared
                # after +project+ was moved
                def self.update_versions_from_hierarchy_change(project)
                  moved_project_ids = project.self_and_descendants.reload.collect(&:id)
                  # Update issues of the moved projects and issues assigned to a version of a moved project
                  Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
                end
                def parent_issue_id=(arg)
                  parent_issue_id = arg.blank? ? nil : arg.to_i
                  if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
                    @parent_issue.id
                  else
                    @parent_issue = nil
                    nil
                  end
                end
                def parent_issue_id
                  if instance_variable_defined? :@parent_issue
                    @parent_issue.nil? ? nil : @parent_issue.id
                  else
                    parent_id
                  end
                end
                # Extracted from the ReportsController.
                def self.by_tracker(project)
                  count_and_group_by(:project => project,
                                     :field => 'tracker_id',
                                     :joins => Tracker.table_name)
                end
                def self.by_version(project)
                  count_and_group_by(:project => project,
                                     :field => 'fixed_version_id',
                                     :joins => Version.table_name)
                end
                def self.by_priority(project)
                  count_and_group_by(:project => project,
                                     :field => 'priority_id',
                                     :joins => IssuePriority.table_name)
                end
                def self.by_category(project)
                  count_and_group_by(:project => project,
                                     :field => 'category_id',
                                     :joins => IssueCategory.table_name)
                end
                def self.by_assigned_to(project)
                  count_and_group_by(:project => project,
                                     :field => 'assigned_to_id',
                                     :joins => User.table_name)
                end
                def self.by_author(project)
                  count_and_group_by(:project => project,
                                     :field => 'author_id',
                                     :joins => User.table_name)
                end
                def self.by_subproject(project)
                  ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                              s.is_closed as closed,
                                                              #{Issue.table_name}.project_id as project_id,
                                                              count(#{Issue.table_name}.id) as total
                                                            from
                                                              #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
                                                            where
                                                              #{Issue.table_name}.status_id=s.id
                                                              and #{Issue.table_name}.project_id = #{Project.table_name}.id
                                                              and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
                                                              and #{Issue.table_name}.project_id <> #{project.id}
                                                            group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
                end
                # End ReportsController extraction
                # Returns an array of projects that user can assign the issue to
                def allowed_target_projects(user=User.current)
                  if new_record?
                    Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
                  else
                    self.class.allowed_target_projects_on_move(user)
                  end
                end
                # Returns an array of projects that user can move issues to
                def self.allowed_target_projects_on_move(user=User.current)
                  Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
                end
                private
                def after_project_change
                  # Update project_id on related time entries
                  TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
                  # Delete issue relations
                  unless Setting.cross_project_issue_relations?
                    relations_from.clear
                    relations_to.clear
                  end
                  # Move subtasks
                  children.each do |child|
                    # Change project and keep project
                    child.send :project=, project, true
                    unless child.save
                      raise ActiveRecord::Rollback
                    end
                  end
                end
                def update_nested_set_attributes
                  if root_id.nil?
                    # issue was just created
                    self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
                    set_default_left_and_right
                    Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
                    if @parent_issue
                      move_to_child_of(@parent_issue)
                    end
                    reload
                  elsif parent_issue_id != parent_id
                    former_parent_id = parent_id
                    # moving an existing issue
                    if @parent_issue && @parent_issue.root_id == root_id
                      # inside the same tree
                      move_to_child_of(@parent_issue)
                    else
                      # to another tree
                      unless root?
                        move_to_right_of(root)
                        reload
                      end
                      old_root_id = root_id
                      self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
                      target_maxright = nested_set_scope.maximum(right_column_name) || 0
                      offset = target_maxright + 1 - lft
                      Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
                                        ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
                      self[left_column_name] = lft + offset
                      self[right_column_name] = rgt + offset
                      if @parent_issue
                        move_to_child_of(@parent_issue)
                      end
                    end
                    reload
                    # delete invalid relations of all descendants
                    self_and_descendants.each do |issue|
                      issue.relations.each do |relation|
                        relation.destroy unless relation.valid?
                      end
                    end
                    # update former parent
                    recalculate_attributes_for(former_parent_id) if former_parent_id
                  end
                  remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
                end
                def update_parent_attributes
                  recalculate_attributes_for(parent_id) if parent_id
                end
                def recalculate_attributes_for(issue_id)
                  if issue_id && p = Issue.find_by_id(issue_id)
                    # priority = highest priority of children
                    if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
                      p.priority = IssuePriority.find_by_position(priority_position)
                    end
                    # start/due dates = lowest/highest dates of children
                    p.start_date = p.children.minimum(:start_date)
                    p.due_date = p.children.maximum(:due_date)
                    if p.start_date && p.due_date && p.due_date < p.start_date
                      p.start_date, p.due_date = p.due_date, p.start_date
                    end
                    # done ratio = weighted average ratio of leaves
                    unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
                      leaves_count = p.leaves.count
                      if leaves_count > 0
                        average = p.leaves.average(:estimated_hours).to_f
                        if average == 0
                          average = 1
                        end
                        done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
                        progress = done / (average * leaves_count)
                        p.done_ratio = progress.round
                      end
                    end
                    # estimate = sum of leaves estimates
                    p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
                    p.estimated_hours = nil if p.estimated_hours == 0.0
                    # ancestors will be recursively updated
                    p.save(:validate => false)
                  end
                end
                # Update issues so their versions are not pointing to a
                # fixed_version that is not shared with the issue's project
                def self.update_versions(conditions=nil)
                  # Only need to update issues with a fixed_version from
                  # a different project and that is not systemwide shared
                  Issue.scoped(:conditions => conditions).all(
                    :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
                      " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
                      " AND #{Version.table_name}.sharing <> 'system'",
                    :include => [:project, :fixed_version]
                  ).each do |issue|
                    next if issue.project.nil? || issue.fixed_version.nil?
                    unless issue.project.shared_versions.include?(issue.fixed_version)
                      issue.init_journal(User.current)
                      issue.fixed_version = nil
                      issue.save
                    end
                  end
                end
                # Callback on attachment deletion
                def attachment_added(obj)
                  if @current_journal && !obj.new_record?
                    @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
                  end
                end
                # Callback on attachment deletion
                def attachment_removed(obj)
                  if @current_journal && !obj.new_record?
                    @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
                    @current_journal.save
                  end
                end
                # Default assignment based on category
                def default_assign
                  if assigned_to.nil? && category && category.assigned_to
                    self.assigned_to = category.assigned_to
                  end
                end
                # Updates start/due dates of following issues
                def reschedule_following_issues
                  if start_date_changed? || due_date_changed?
                    relations_from.each do |relation|
                      relation.set_issue_to_dates
                    end
                  end
                end
                # Closes duplicates if the issue is being closed
                def close_duplicates
                  if closing?
                    duplicates.each do |duplicate|
                      # Reload is need in case the duplicate was updated by a previous duplicate
                      duplicate.reload
                      # Don't re-close it if it's already closed
                      next if duplicate.closed?
                      # Same user and notes
                      if @current_journal
                        duplicate.init_journal(@current_journal.user, @current_journal.notes)
                      end
                      duplicate.update_attribute :status, self.status
                    end
                  end
                end
                # Make sure updated_on is updated when adding a note
                def force_updated_on_change
                  if @current_journal
                    self.updated_on = current_time_from_proper_timezone
                  end
                end
                # Saves the changes in a Journal
                # Called after_save
                def create_journal
                  if @current_journal
                    # attributes changes
                    if @attributes_before_change
                      (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
                        before = @attributes_before_change[c]
                        after = send(c)
                        next if before == after || (before.blank? && after.blank?)
                        @current_journal.details << JournalDetail.new(:property => 'attr',
                                                                      :prop_key => c,
                                                                      :old_value => before,
                                                                      :value => after)
                      }
                    end
                    if @custom_values_before_change
                      # custom fields changes
                      custom_field_values.each {|c|
                        before = @custom_values_before_change[c.custom_field_id]
                        after = c.value
                        next if before == after || (before.blank? && after.blank?)
                        if before.is_a?(Array) || after.is_a?(Array)
                          before = [before] unless before.is_a?(Array)
                          after = [after] unless after.is_a?(Array)
                          # values removed
                          (before - after).reject(&:blank?).each do |value|
                            @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                          :prop_key => c.custom_field_id,
                                                                          :old_value => value,
                                                                          :value => nil)
                          end
                          # values added
                          (after - before).reject(&:blank?).each do |value|
                            @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                          :prop_key => c.custom_field_id,
                                                                          :old_value => nil,
                                                                          :value => value)
                          end
                        else
                          @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                        :prop_key => c.custom_field_id,
                                                                        :old_value => before,
                                                                        :value => after)
                        end
                      }
                    end
                    @current_journal.save
                    # reset current journal
                    init_journal @current_journal.user, @current_journal.notes
                  end
                end
                # Query generator for selecting groups of issue counts for a project
                # based on specific criteria
                #
                # Options
                # * project - Project to search in.
                # * field - String. Issue field to key off of in the grouping.
                # * joins - String. The table name to join against.
                def self.count_and_group_by(options)
                  project = options.delete(:project)
                  select_field = options.delete(:field)
                  joins = options.delete(:joins)
                  where = "#{Issue.table_name}.#{select_field}=j.id"
                  ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                              s.is_closed as closed,
                                                              j.id as #{select_field},
                                                              count(#{Issue.table_name}.id) as total
                                                            from
                                                                #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
                                                            where
                                                              #{Issue.table_name}.status_id=s.id
                                                              and #{where}
                                                              and #{Issue.table_name}.project_id=#{Project.table_name}.id
                                                              and #{visible_condition(User.current, :project => project)}
                                                            group by s.id, s.is_closed, j.id")
                end
              end

app/models/version.rb 0 -1

              # Redmine - project management software
              # Copyright (C) 2006-2012  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class Version < ActiveRecord::Base
                include Redmine::SafeAttributes
                after_update :update_issues_from_sharing_change
                belongs_to :project
                has_many :fixed_issues, :class_name => 'Issue', :foreign_key => 'fixed_version_id', :dependent => :nullify
                acts_as_customizable
                acts_as_attachable :view_permission => :view_files,
                                   :delete_permission => :manage_files
                VERSION_STATUSES = %w(open locked closed)
                VERSION_SHARINGS = %w(none descendants hierarchy tree system)
                validates_presence_of :name
                validates_uniqueness_of :name, :scope => [:project_id]
                validates_length_of :name, :maximum => 60
                validates_format_of :effective_date, :with => /^\d{4}-\d{2}-\d{2}$/, :message => :not_a_date, :allow_nil => true
                validates_inclusion_of :status, :in => VERSION_STATUSES
                validates_inclusion_of :sharing, :in => VERSION_SHARINGS
                scope :named, lambda {|arg| { :conditions => ["LOWER(#{table_name}.name) = LOWER(?)", arg.to_s.strip]}}
-               class << self; undef :open; end
                scope :open, :conditions => {:status => 'open'}
                scope :visible, lambda {|*args| { :include => :project,
                                                        :conditions => Project.allowed_to_condition(args.first || User.current, :view_issues) } }
                safe_attributes 'name',
                  'description',
                  'effective_date',
                  'due_date',
                  'wiki_page_title',
                  'status',
                  'sharing',
                  'custom_field_values'
                # Returns true if +user+ or current user is allowed to view the version
                def visible?(user=User.current)
                  user.allowed_to?(:view_issues, self.project)
                end
                # Version files have same visibility as project files
                def attachments_visible?(*args)
                  project.present? && project.attachments_visible?(*args)
                end
                def start_date
                  @start_date ||= fixed_issues.minimum('start_date')
                end
                def due_date
                  effective_date
                end
                def due_date=(arg)
                  self.effective_date=(arg)
                end
                # Returns the total estimated time for this version
                # (sum of leaves estimated_hours)
                def estimated_hours
                  @estimated_hours ||= fixed_issues.leaves.sum(:estimated_hours).to_f
                end
                # Returns the total reported time for this version
                def spent_hours
                  @spent_hours ||= TimeEntry.sum(:hours, :joins => :issue, :conditions => ["#{Issue.table_name}.fixed_version_id = ?", id]).to_f
                end
                def closed?
                  status == 'closed'
                end
                def open?
                  status == 'open'
                end
                # Returns true if the version is completed: due date reached and no open issues
                def completed?
                  effective_date && (effective_date <= Date.today) && (open_issues_count == 0)
                end
                def behind_schedule?
                  if completed_pourcent == 100
                    return false
                  elsif due_date && start_date
                    done_date = start_date + ((due_date - start_date+1)* completed_pourcent/100).floor
                    return done_date <= Date.today
                  else
                    false # No issues so it's not late
                  end
                end
                # Returns the completion percentage of this version based on the amount of open/closed issues
                # and the time spent on the open issues.
                def completed_pourcent
                  if issues_count == 0
 
                  elsif open_issues_count == 0
 
                  else
                    issues_progress(false) + issues_progress(true)
                  end
                end
                # Returns the percentage of issues that have been marked as 'closed'.
                def closed_pourcent
                  if issues_count == 0
 
                  else
                    issues_progress(false)
                  end
                end
                # Returns true if the version is overdue: due date reached and some open issues
                def overdue?
                  effective_date && (effective_date < Date.today) && (open_issues_count > 0)
                end
                # Returns assigned issues count
                def issues_count
                  load_issue_counts
                  @issue_count
                end
                # Returns the total amount of open issues for this version.
                def open_issues_count
                  load_issue_counts
                  @open_issues_count
                end
                # Returns the total amount of closed issues for this version.
                def closed_issues_count
                  load_issue_counts
                  @closed_issues_count
                end
                def wiki_page
                  if project.wiki && !wiki_page_title.blank?
                    @wiki_page ||= project.wiki.find_page(wiki_page_title)
                  end
                  @wiki_page
                end
                def to_s; name end
                def to_s_with_project
                  "#{project} - #{name}"
                end
                # Versions are sorted by effective_date and name
                # Those with no effective_date are at the end, sorted by name
                def <=>(version)
                  if self.effective_date
                    if version.effective_date
                      if self.effective_date == version.effective_date
                        name == version.name ? id <=> version.id : name <=> version.name
                      else
                        self.effective_date <=> version.effective_date
                      end
                    else
                      -1
                    end
                  else
                    if version.effective_date
 
                    else
                      name == version.name ? id <=> version.id : name <=> version.name
                    end
                  end
                end
                def self.fields_for_order_statement(table=nil)
                  table ||= table_name
                  ["(CASE WHEN #{table}.effective_date IS NULL THEN 1 ELSE 0 END)", "#{table}.effective_date", "#{table}.name", "#{table}.id"]
                end
                scope :sorted, order(fields_for_order_statement)
                # Returns the sharings that +user+ can set the version to
                def allowed_sharings(user = User.current)
                  VERSION_SHARINGS.select do |s|
                    if sharing == s
                      true
                    else
                      case s
                      when 'system'
                        # Only admin users can set a systemwide sharing
                        user.admin?
                      when 'hierarchy', 'tree'
                        # Only users allowed to manage versions of the root project can
                        # set sharing to hierarchy or tree
                        project.nil? || user.allowed_to?(:manage_versions, project.root)
                      else
                        true
                      end
                    end
                  end
                end
                private
                def load_issue_counts
                  unless @issue_count
                    @open_issues_count = 0
                    @closed_issues_count = 0
                    fixed_issues.count(:all, :group => :status).each do |status, count|
                      if status.is_closed?
                        @closed_issues_count += count
                      else
                        @open_issues_count += count
                      end
                    end
                    @issue_count = @open_issues_count + @closed_issues_count
                  end
                end
                # Update the issue's fixed versions. Used if a version's sharing changes.
                def update_issues_from_sharing_change
                  if sharing_changed?
                    if VERSION_SHARINGS.index(sharing_was).nil? ||
                        VERSION_SHARINGS.index(sharing).nil? ||
                        VERSION_SHARINGS.index(sharing_was) > VERSION_SHARINGS.index(sharing)
                      Issue.update_versions_from_sharing_change self
                    end
                  end
                end
                # Returns the average estimated time of assigned issues
                # or 1 if no issue has an estimated time
                # Used to weigth unestimated issues in progress calculation
                def estimated_average
                  if @estimated_average.nil?
                    average = fixed_issues.average(:estimated_hours).to_f
                    if average == 0
                      average = 1
                    end
                    @estimated_average = average
                  end
                  @estimated_average
                end
                # Returns the total progress of open or closed issues.  The returned percentage takes into account
                # the amount of estimated time set for this version.
                #
                # Examples:
                # issues_progress(true)   => returns the progress percentage for open issues.
                # issues_progress(false)  => returns the progress percentage for closed issues.
                def issues_progress(open)
                  @issues_progress ||= {}
                  @issues_progress[open] ||= begin
                    progress = 0
                    if issues_count > 0
                      ratio = open ? 'done_ratio' : 100
                      done = fixed_issues.sum("COALESCE(estimated_hours, #{estimated_average}) * #{ratio}",
                                                :joins => :status,
                                                :conditions => ["#{IssueStatus.table_name}.is_closed = ?", !open]).to_f
                      progress = done / (estimated_average * issues_count)
                    end
                    progress
                  end
                end
              end

config/initializers/10-patches.rb +5 0

              require 'active_record'
              module ActiveRecord
                class Base
                  include Redmine::I18n
                  # Translate attribute names for validation errors display
                  def self.human_attribute_name(attr, *args)
                    attr = attr.to_s.sub(/_id$/, '')
                    l("field_#{name.underscore.gsub('/', '_')}_#{attr}", :default => ["field_#{attr}".to_sym, attr])
                  end
                end
+               # Undefines private Kernel#open method to allow using `open` scopes in models.
+               # See Defect #11545 (http://www.redmine.org/issues/11545) for details.
+               class Base ; undef open ; end
+               class Relation ; undef open ; end
              end
              module ActionView
                module Helpers
                  module DateHelper
                    # distance_of_time_in_words breaks when difference is greater than 30 years
                    def distance_of_date_in_words(from_date, to_date = 0, options = {})
                      from_date = from_date.to_date if from_date.respond_to?(:to_date)
                      to_date = to_date.to_date if to_date.respond_to?(:to_date)
                      distance_in_days = (to_date - from_date).abs
                      I18n.with_options :locale => options[:locale], :scope => :'datetime.distance_in_words' do |locale|
                        case distance_in_days
                          when 0..60     then locale.t :x_days,             :count => distance_in_days.round
                          when 61..720   then locale.t :about_x_months,     :count => (distance_in_days / 30).round
                          else                locale.t :over_x_years,       :count => (distance_in_days / 365).floor
                        end
                      end
                    end
                  end
                end
                class Resolver
                  def find_all(name, prefix=nil, partial=false, details={}, key=nil, locals=[])
                    cached(key, [name, prefix, partial], details, locals) do
                      if details[:formats] & [:xml, :json]
                        details = details.dup
                        details[:formats] = details[:formats].dup + [:api]
                      end
                      find_templates(name, prefix, partial, details)
                    end
                  end
                end
              end
              ActionView::Base.field_error_proc = Proc.new{ |html_tag, instance| html_tag || ''.html_safe }
              require 'mail'
              module DeliveryMethods
                class AsyncSMTP < ::Mail::SMTP
                  def deliver!(*args)
                    Thread.start do
                      super *args
                    end
                  end
                end
                class AsyncSendmail < ::Mail::Sendmail
                  def deliver!(*args)
                    Thread.start do
                      super *args
                    end
                  end
                end
                class TmpFile
                  def initialize(*args); end
                  def deliver!(mail)
                    dest_dir = File.join(Rails.root, 'tmp', 'emails')
                    Dir.mkdir(dest_dir) unless File.directory?(dest_dir)
                    File.open(File.join(dest_dir, mail.message_id.gsub(/[<>]/, '') + '.eml'), 'wb') {|f| f.write(mail.encoded) }
                  end
                end
              end
              ActionMailer::Base.add_delivery_method :async_smtp, DeliveryMethods::AsyncSMTP
              ActionMailer::Base.add_delivery_method :async_sendmail, DeliveryMethods::AsyncSendmail
              ActionMailer::Base.add_delivery_method :tmp_file, DeliveryMethods::TmpFile
              module ActionController
                module MimeResponds
                  class Collector
                    def api(&block)
                      any(:xml, :json, &block)
                    end
                  end
                end
              end
              module ActionController
                class Base
                  # Displays an explicit message instead of a NoMethodError exception
                  # when trying to start Redmine with an old session_store.rb
                  # TODO: remove it in a later version
                  def self.session=(*args)
                    $stderr.puts "Please remove config/initializers/session_store.rb and run `rake generate_secret_token`.\n" +
                      "Setting the session secret with ActionController.session= is no longer supported in Rails 3."
                    exit 1
                  end
                end
              end

test/unit/project_test.rb +4 0

              # Redmine - project management software
              # Copyright (C) 2006-2012  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class ProjectTest < ActiveSupport::TestCase
                fixtures :projects, :trackers, :issue_statuses, :issues,
                         :journals, :journal_details,
                         :enumerations, :users, :issue_categories,
                         :projects_trackers,
                         :custom_fields,
                         :custom_fields_projects,
                         :custom_fields_trackers,
                         :custom_values,
                         :roles,
                         :member_roles,
                         :members,
                         :enabled_modules,
                         :workflows,
                         :versions,
                         :wikis, :wiki_pages, :wiki_contents, :wiki_content_versions,
                         :groups_users,
                         :boards,
                         :repositories
                def setup
                  @ecookbook = Project.find(1)
                  @ecookbook_sub1 = Project.find(3)
                  set_tmp_attachments_directory
                  User.current = nil
                end
                def test_truth
                  assert_kind_of Project, @ecookbook
                  assert_equal "eCookbook", @ecookbook.name
                end
                def test_default_attributes
                  with_settings :default_projects_public => '1' do
                    assert_equal true, Project.new.is_public
                    assert_equal false, Project.new(:is_public => false).is_public
                  end
                  with_settings :default_projects_public => '0' do
                    assert_equal false, Project.new.is_public
                    assert_equal true, Project.new(:is_public => true).is_public
                  end
                  with_settings :sequential_project_identifiers => '1' do
                    assert !Project.new.identifier.blank?
                    assert Project.new(:identifier => '').identifier.blank?
                  end
                  with_settings :sequential_project_identifiers => '0' do
                    assert Project.new.identifier.blank?
                    assert !Project.new(:identifier => 'test').blank?
                  end
                  with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                    assert_equal ['issue_tracking', 'repository'], Project.new.enabled_module_names
                  end
                  assert_equal Tracker.all.sort, Project.new.trackers.sort
                  assert_equal Tracker.find(1, 3).sort, Project.new(:tracker_ids => [1, 3]).trackers.sort
                end
                def test_update
                  assert_equal "eCookbook", @ecookbook.name
                  @ecookbook.name = "eCook"
                  assert @ecookbook.save, @ecookbook.errors.full_messages.join("; ")
                  @ecookbook.reload
                  assert_equal "eCook", @ecookbook.name
                end
                def test_validate_identifier
                  to_test = {"abc" => true,
                             "ab12" => true,
                             "ab-12" => true,
                             "ab_12" => true,
                             "12" => false,
                             "new" => false}
                  to_test.each do |identifier, valid|
                    p = Project.new
                    p.identifier = identifier
                    p.valid?
                    if valid
                      assert p.errors['identifier'].blank?, "identifier #{identifier} was not valid"
                    else
                      assert p.errors['identifier'].present?, "identifier #{identifier} was valid"
                    end
                  end
                end
                def test_identifier_should_not_be_frozen_for_a_new_project
                  assert_equal false, Project.new.identifier_frozen?
                end
                def test_identifier_should_not_be_frozen_for_a_saved_project_with_blank_identifier
                  Project.update_all(["identifier = ''"], "id = 1")
                  assert_equal false, Project.find(1).identifier_frozen?
                end
                def test_identifier_should_be_frozen_for_a_saved_project_with_valid_identifier
                  assert_equal true, Project.find(1).identifier_frozen?
                end
                def test_members_should_be_active_users
                  Project.all.each do |project|
                    assert_nil project.members.detect {|m| !(m.user.is_a?(User) && m.user.active?) }
                  end
                end
                def test_users_should_be_active_users
                  Project.all.each do |project|
                    assert_nil project.users.detect {|u| !(u.is_a?(User) && u.active?) }
                  end
                end
+               def test_open_scope_on_issues_association
+                 assert_kind_of Issue, Project.find(1).issues.open.first
+               end
                def test_archive
                  user = @ecookbook.members.first.user
                  @ecookbook.archive
                  @ecookbook.reload
                  assert !@ecookbook.active?
                  assert @ecookbook.archived?
                  assert !user.projects.include?(@ecookbook)
                  # Subproject are also archived
                  assert !@ecookbook.children.empty?
                  assert @ecookbook.descendants.active.empty?
                end
                def test_archive_should_fail_if_versions_are_used_by_non_descendant_projects
                  # Assign an issue of a project to a version of a child project
                  Issue.find(4).update_attribute :fixed_version_id, 4
                  assert_no_difference "Project.count(:all, :conditions => 'status = #{Project::STATUS_ARCHIVED}')" do
                    assert_equal false, @ecookbook.archive
                  end
                  @ecookbook.reload
                  assert @ecookbook.active?
                end
                def test_unarchive
                  user = @ecookbook.members.first.user
                  @ecookbook.archive
                  # A subproject of an archived project can not be unarchived
                  assert !@ecookbook_sub1.unarchive
                  # Unarchive project
                  assert @ecookbook.unarchive
                  @ecookbook.reload
                  assert @ecookbook.active?
                  assert !@ecookbook.archived?
                  assert user.projects.include?(@ecookbook)
                  # Subproject can now be unarchived
                  @ecookbook_sub1.reload
                  assert @ecookbook_sub1.unarchive
                end
                def test_destroy
                  # 2 active members
                  assert_equal 2, @ecookbook.members.size
                  # and 1 is locked
                  assert_equal 3, Member.find(:all, :conditions => ['project_id = ?', @ecookbook.id]).size
                  # some boards
                  assert @ecookbook.boards.any?
                  @ecookbook.destroy
                  # make sure that the project non longer exists
                  assert_raise(ActiveRecord::RecordNotFound) { Project.find(@ecookbook.id) }
                  # make sure related data was removed
                  assert_nil Member.first(:conditions => {:project_id => @ecookbook.id})
                  assert_nil Board.first(:conditions => {:project_id => @ecookbook.id})
                  assert_nil Issue.first(:conditions => {:project_id => @ecookbook.id})
                end
                def test_destroy_should_destroy_subtasks
                  issues = (0..2).to_a.map {Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :subject => 'test')}
                  issues[0].update_attribute :parent_issue_id, issues[1].id
                  issues[2].update_attribute :parent_issue_id, issues[1].id
                  assert_equal 2, issues[1].children.count
                  assert_nothing_raised do
                    Project.find(1).destroy
                  end
                  assert Issue.find_all_by_id(issues.map(&:id)).empty?
                end
                def test_destroying_root_projects_should_clear_data
                  Project.roots.each do |root|
                    root.destroy
                  end
                  assert_equal 0, Project.count, "Projects were not deleted: #{Project.all.inspect}"
                  assert_equal 0, Member.count, "Members were not deleted: #{Member.all.inspect}"
                  assert_equal 0, MemberRole.count
                  assert_equal 0, Issue.count
                  assert_equal 0, Journal.count
                  assert_equal 0, JournalDetail.count
                  assert_equal 0, Attachment.count
                  assert_equal 0, EnabledModule.count
                  assert_equal 0, IssueCategory.count
                  assert_equal 0, IssueRelation.count
                  assert_equal 0, Board.count
                  assert_equal 0, Message.count
                  assert_equal 0, News.count
                  assert_equal 0, Query.count(:conditions => "project_id IS NOT NULL")
                  assert_equal 0, Repository.count
                  assert_equal 0, Changeset.count
                  assert_equal 0, Change.count
                  assert_equal 0, Comment.count
                  assert_equal 0, TimeEntry.count
                  assert_equal 0, Version.count
                  assert_equal 0, Watcher.count
                  assert_equal 0, Wiki.count
                  assert_equal 0, WikiPage.count
                  assert_equal 0, WikiContent.count
                  assert_equal 0, WikiContent::Version.count
                  assert_equal 0, Project.connection.select_all("SELECT * FROM projects_trackers").size
                  assert_equal 0, Project.connection.select_all("SELECT * FROM custom_fields_projects").size
                  assert_equal 0, CustomValue.count(:conditions => {:customized_type => ['Project', 'Issue', 'TimeEntry', 'Version']})
                end
                def test_move_an_orphan_project_to_a_root_project
                  sub = Project.find(2)
                  sub.set_parent! @ecookbook
                  assert_equal @ecookbook.id, sub.parent.id
                  @ecookbook.reload
                  assert_equal 4, @ecookbook.children.size
                end
                def test_move_an_orphan_project_to_a_subproject
                  sub = Project.find(2)
                  assert sub.set_parent!(@ecookbook_sub1)
                end
                def test_move_a_root_project_to_a_project
                  sub = @ecookbook
                  assert sub.set_parent!(Project.find(2))
                end
                def test_should_not_move_a_project_to_its_children
                  sub = @ecookbook
                  assert !(sub.set_parent!(Project.find(3)))
                end
                def test_set_parent_should_add_roots_in_alphabetical_order
                  ProjectCustomField.delete_all
                  Project.delete_all
                  Project.create!(:name => 'Project C', :identifier => 'project-c').set_parent!(nil)
                  Project.create!(:name => 'Project B', :identifier => 'project-b').set_parent!(nil)
                  Project.create!(:name => 'Project D', :identifier => 'project-d').set_parent!(nil)
                  Project.create!(:name => 'Project A', :identifier => 'project-a').set_parent!(nil)
                  assert_equal 4, Project.count
                  assert_equal Project.all.sort_by(&:name), Project.all.sort_by(&:lft)
                end
                def test_set_parent_should_add_children_in_alphabetical_order
                  ProjectCustomField.delete_all
                  parent = Project.create!(:name => 'Parent', :identifier => 'parent')
                  Project.create!(:name => 'Project C', :identifier => 'project-c').set_parent!(parent)
                  Project.create!(:name => 'Project B', :identifier => 'project-b').set_parent!(parent)
                  Project.create!(:name => 'Project D', :identifier => 'project-d').set_parent!(parent)
                  Project.create!(:name => 'Project A', :identifier => 'project-a').set_parent!(parent)
                  parent.reload
                  assert_equal 4, parent.children.size
                  assert_equal parent.children.all.sort_by(&:name), parent.children.all
                end
                def test_rebuild_should_sort_children_alphabetically
                  ProjectCustomField.delete_all
                  parent = Project.create!(:name => 'Parent', :identifier => 'parent')
                  Project.create!(:name => 'Project C', :identifier => 'project-c').move_to_child_of(parent)
                  Project.create!(:name => 'Project B', :identifier => 'project-b').move_to_child_of(parent)
                  Project.create!(:name => 'Project D', :identifier => 'project-d').move_to_child_of(parent)
                  Project.create!(:name => 'Project A', :identifier => 'project-a').move_to_child_of(parent)
                  Project.update_all("lft = NULL, rgt = NULL")
                  Project.rebuild!
                  parent.reload
                  assert_equal 4, parent.children.size
                  assert_equal parent.children.all.sort_by(&:name), parent.children.all
                end
                def test_set_parent_should_update_issue_fixed_version_associations_when_a_fixed_version_is_moved_out_of_the_hierarchy
                  # Parent issue with a hierarchy project's fixed version
                  parent_issue = Issue.find(1)
                  parent_issue.update_attribute(:fixed_version_id, 4)
                  parent_issue.reload
                  assert_equal 4, parent_issue.fixed_version_id
                  # Should keep fixed versions for the issues
                  issue_with_local_fixed_version = Issue.find(5)
                  issue_with_local_fixed_version.update_attribute(:fixed_version_id, 4)
                  issue_with_local_fixed_version.reload
                  assert_equal 4, issue_with_local_fixed_version.fixed_version_id
                  # Local issue with hierarchy fixed_version
                  issue_with_hierarchy_fixed_version = Issue.find(13)
                  issue_with_hierarchy_fixed_version.update_attribute(:fixed_version_id, 6)
                  issue_with_hierarchy_fixed_version.reload
                  assert_equal 6, issue_with_hierarchy_fixed_version.fixed_version_id
                  # Move project out of the issue's hierarchy
                  moved_project = Project.find(3)
                  moved_project.set_parent!(Project.find(2))
                  parent_issue.reload
                  issue_with_local_fixed_version.reload
                  issue_with_hierarchy_fixed_version.reload
                  assert_equal 4, issue_with_local_fixed_version.fixed_version_id, "Fixed version was not keep on an issue local to the moved project"
                  assert_equal nil, issue_with_hierarchy_fixed_version.fixed_version_id, "Fixed version is still set after moving the Project out of the hierarchy where the version is defined in"
                  assert_equal nil, parent_issue.fixed_version_id, "Fixed version is still set after moving the Version out of the hierarchy for the issue."
                end
                def test_parent
                  p = Project.find(6).parent
                  assert p.is_a?(Project)
                  assert_equal 5, p.id
                end
                def test_ancestors
                  a = Project.find(6).ancestors
                  assert a.first.is_a?(Project)
                  assert_equal [1, 5], a.collect(&:id)
                end
                def test_root
                  r = Project.find(6).root
                  assert r.is_a?(Project)
                  assert_equal 1, r.id
                end
                def test_children
                  c = Project.find(1).children
                  assert c.first.is_a?(Project)
                  assert_equal [5, 3, 4], c.collect(&:id)
                end
                def test_descendants
                  d = Project.find(1).descendants
                  assert d.first.is_a?(Project)
                  assert_equal [5, 6, 3, 4], d.collect(&:id)
                end
                def test_allowed_parents_should_be_empty_for_non_member_user
                  Role.non_member.add_permission!(:add_project)
                  user = User.find(9)
                  assert user.memberships.empty?
                  User.current = user
                  assert Project.new.allowed_parents.compact.empty?
                end
                def test_allowed_parents_with_add_subprojects_permission
                  Role.find(1).remove_permission!(:add_project)
                  Role.find(1).add_permission!(:add_subprojects)
                  User.current = User.find(2)
                  # new project
                  assert !Project.new.allowed_parents.include?(nil)
                  assert Project.new.allowed_parents.include?(Project.find(1))
                  # existing root project
                  assert Project.find(1).allowed_parents.include?(nil)
                  # existing child
                  assert Project.find(3).allowed_parents.include?(Project.find(1))
                  assert !Project.find(3).allowed_parents.include?(nil)
                end
                def test_allowed_parents_with_add_project_permission
                  Role.find(1).add_permission!(:add_project)
                  Role.find(1).remove_permission!(:add_subprojects)
                  User.current = User.find(2)
                  # new project
                  assert Project.new.allowed_parents.include?(nil)
                  assert !Project.new.allowed_parents.include?(Project.find(1))
                  # existing root project
                  assert Project.find(1).allowed_parents.include?(nil)
                  # existing child
                  assert Project.find(3).allowed_parents.include?(Project.find(1))
                  assert Project.find(3).allowed_parents.include?(nil)
                end
                def test_allowed_parents_with_add_project_and_subprojects_permission
                  Role.find(1).add_permission!(:add_project)
                  Role.find(1).add_permission!(:add_subprojects)
                  User.current = User.find(2)
                  # new project
                  assert Project.new.allowed_parents.include?(nil)
                  assert Project.new.allowed_parents.include?(Project.find(1))
                  # existing root project
                  assert Project.find(1).allowed_parents.include?(nil)
                  # existing child
                  assert Project.find(3).allowed_parents.include?(Project.find(1))
                  assert Project.find(3).allowed_parents.include?(nil)
                end
                def test_users_by_role
                  users_by_role = Project.find(1).users_by_role
                  assert_kind_of Hash, users_by_role
                  role = Role.find(1)
                  assert_kind_of Array, users_by_role[role]
                  assert users_by_role[role].include?(User.find(2))
                end
                def test_rolled_up_trackers
                  parent = Project.find(1)
                  parent.trackers = Tracker.find([1,2])
                  child = parent.children.find(3)
                  assert_equal [1, 2], parent.tracker_ids
                  assert_equal [2, 3], child.trackers.collect(&:id)
                  assert_kind_of Tracker, parent.rolled_up_trackers.first
                  assert_equal Tracker.find(1), parent.rolled_up_trackers.first
                  assert_equal [1, 2, 3], parent.rolled_up_trackers.collect(&:id)
                  assert_equal [2, 3], child.rolled_up_trackers.collect(&:id)
                end
                def test_rolled_up_trackers_should_ignore_archived_subprojects
                  parent = Project.find(1)
                  parent.trackers = Tracker.find([1,2])
                  child = parent.children.find(3)
                  child.trackers = Tracker.find([1,3])
                  parent.children.each(&:archive)
                  assert_equal [1,2], parent.rolled_up_trackers.collect(&:id)
                end
                context "#rolled_up_versions" do
                  setup do
                    @project = Project.generate!
                    @parent_version_1 = Version.generate!(:project => @project)
                    @parent_version_2 = Version.generate!(:project => @project)
                  end
                  should "include the versions for the current project" do
                    assert_same_elements [@parent_version_1, @parent_version_2], @project.rolled_up_versions
                  end
                  should "include versions for a subproject" do
                    @subproject = Project.generate!
                    @subproject.set_parent!(@project)
                    @subproject_version = Version.generate!(:project => @subproject)
                    assert_same_elements [
                                          @parent_version_1,
                                          @parent_version_2,
                                          @subproject_version
                                         ], @project.rolled_up_versions
                  end
                  should "include versions for a sub-subproject" do
                    @subproject = Project.generate!
                    @subproject.set_parent!(@project)
                    @sub_subproject = Project.generate!
                    @sub_subproject.set_parent!(@subproject)
                    @sub_subproject_version = Version.generate!(:project => @sub_subproject)
                    @project.reload
                    assert_same_elements [
                                          @parent_version_1,
                                          @parent_version_2,
                                          @sub_subproject_version
                                         ], @project.rolled_up_versions
                  end
                  should "only check active projects" do
                    @subproject = Project.generate!
                    @subproject.set_parent!(@project)
                    @subproject_version = Version.generate!(:project => @subproject)
                    assert @subproject.archive
                    @project.reload
                    assert !@subproject.active?
                    assert_same_elements [@parent_version_1, @parent_version_2], @project.rolled_up_versions
                  end
                end
                def test_shared_versions_none_sharing
                  p = Project.find(5)
                  v = Version.create!(:name => 'none_sharing', :project => p, :sharing => 'none')
                  assert p.shared_versions.include?(v)
                  assert !p.children.first.shared_versions.include?(v)
                  assert !p.root.shared_versions.include?(v)
                  assert !p.siblings.first.shared_versions.include?(v)
                  assert !p.root.siblings.first.shared_versions.include?(v)
                end
                def test_shared_versions_descendants_sharing
                  p = Project.find(5)
                  v = Version.create!(:name => 'descendants_sharing', :project => p, :sharing => 'descendants')
                  assert p.shared_versions.include?(v)
                  assert p.children.first.shared_versions.include?(v)
                  assert !p.root.shared_versions.include?(v)
                  assert !p.siblings.first.shared_versions.include?(v)
                  assert !p.root.siblings.first.shared_versions.include?(v)
                end
                def test_shared_versions_hierarchy_sharing
                  p = Project.find(5)
                  v = Version.create!(:name => 'hierarchy_sharing', :project => p, :sharing => 'hierarchy')
                  assert p.shared_versions.include?(v)
                  assert p.children.first.shared_versions.include?(v)
                  assert p.root.shared_versions.include?(v)
                  assert !p.siblings.first.shared_versions.include?(v)
                  assert !p.root.siblings.first.shared_versions.include?(v)
                end
                def test_shared_versions_tree_sharing
                  p = Project.find(5)
                  v = Version.create!(:name => 'tree_sharing', :project => p, :sharing => 'tree')
                  assert p.shared_versions.include?(v)
                  assert p.children.first.shared_versions.include?(v)
                  assert p.root.shared_versions.include?(v)
                  assert p.siblings.first.shared_versions.include?(v)
                  assert !p.root.siblings.first.shared_versions.include?(v)
                end
                def test_shared_versions_system_sharing
                  p = Project.find(5)
                  v = Version.create!(:name => 'system_sharing', :project => p, :sharing => 'system')
                  assert p.shared_versions.include?(v)
                  assert p.children.first.shared_versions.include?(v)
                  assert p.root.shared_versions.include?(v)
                  assert p.siblings.first.shared_versions.include?(v)
                  assert p.root.siblings.first.shared_versions.include?(v)
                end
                def test_shared_versions
                  parent = Project.find(1)
                  child = parent.children.find(3)
                  private_child = parent.children.find(5)
                  assert_equal [1,2,3], parent.version_ids.sort
                  assert_equal [4], child.version_ids
                  assert_equal [6], private_child.version_ids
                  assert_equal [7], Version.find_all_by_sharing('system').collect(&:id)
                  assert_equal 6, parent.shared_versions.size
                  parent.shared_versions.each do |version|
                    assert_kind_of Version, version
                  end
                  assert_equal [1,2,3,4,6,7], parent.shared_versions.collect(&:id).sort
                end
                def test_shared_versions_should_ignore_archived_subprojects
                  parent = Project.find(1)
                  child = parent.children.find(3)
                  child.archive
                  parent.reload
                  assert_equal [1,2,3], parent.version_ids.sort
                  assert_equal [4], child.version_ids
                  assert !parent.shared_versions.collect(&:id).include?(4)
                end
                def test_shared_versions_visible_to_user
                  user = User.find(3)
                  parent = Project.find(1)
                  child = parent.children.find(5)
                  assert_equal [1,2,3], parent.version_ids.sort
                  assert_equal [6], child.version_ids
                  versions = parent.shared_versions.visible(user)
                  assert_equal 4, versions.size
                  versions.each do |version|
                    assert_kind_of Version, version
                  end
                  assert !versions.collect(&:id).include?(6)
                end
                def test_shared_versions_for_new_project_should_include_system_shared_versions
                  p = Project.find(5)
                  v = Version.create!(:name => 'system_sharing', :project => p, :sharing => 'system')
                  assert_include v, Project.new.shared_versions
                end
                def test_next_identifier
                  ProjectCustomField.delete_all
                  Project.create!(:name => 'last', :identifier => 'p2008040')
                  assert_equal 'p2008041', Project.next_identifier
                end
                def test_next_identifier_first_project
                  Project.delete_all
                  assert_nil Project.next_identifier
                end
                def test_enabled_module_names
                  with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                    project = Project.new
                    project.enabled_module_names = %w(issue_tracking news)
                    assert_equal %w(issue_tracking news), project.enabled_module_names.sort
                  end
                end
                context "enabled_modules" do
                  setup do
                    @project = Project.find(1)
                  end
                  should "define module by names and preserve ids" do
                    # Remove one module
                    modules = @project.enabled_modules.slice(0..-2)
                    assert modules.any?
                    assert_difference 'EnabledModule.count', -1 do
                      @project.enabled_module_names = modules.collect(&:name)
                    end
                    @project.reload
                    # Ids should be preserved
                    assert_equal @project.enabled_module_ids.sort, modules.collect(&:id).sort
                  end
                  should "enable a module" do
                    @project.enabled_module_names = []
                    @project.reload
                    assert_equal [], @project.enabled_module_names
                    #with string
                    @project.enable_module!("issue_tracking")
                    assert_equal ["issue_tracking"], @project.enabled_module_names
                    #with symbol
                    @project.enable_module!(:gantt)
                    assert_equal ["issue_tracking", "gantt"], @project.enabled_module_names
                    #don't add a module twice
                    @project.enable_module!("issue_tracking")
                    assert_equal ["issue_tracking", "gantt"], @project.enabled_module_names
                  end
                  should "disable a module" do
                    #with string
                    assert @project.enabled_module_names.include?("issue_tracking")
                    @project.disable_module!("issue_tracking")
                    assert ! @project.reload.enabled_module_names.include?("issue_tracking")
                    #with symbol
                    assert @project.enabled_module_names.include?("gantt")
                    @project.disable_module!(:gantt)
                    assert ! @project.reload.enabled_module_names.include?("gantt")
                    #with EnabledModule object
                    first_module = @project.enabled_modules.first
                    @project.disable_module!(first_module)
                    assert ! @project.reload.enabled_module_names.include?(first_module.name)
                  end
                end
                def test_enabled_module_names_should_not_recreate_enabled_modules
                  project = Project.find(1)
                  # Remove one module
                  modules = project.enabled_modules.slice(0..-2)
                  assert modules.any?
                  assert_difference 'EnabledModule.count', -1 do
                    project.enabled_module_names = modules.collect(&:name)
                  end
                  project.reload
                  # Ids should be preserved
                  assert_equal project.enabled_module_ids.sort, modules.collect(&:id).sort
                end
                def test_copy_from_existing_project
                  source_project = Project.find(1)
                  copied_project = Project.copy_from(1)
                  assert copied_project
                  # Cleared attributes
                  assert copied_project.id.blank?
                  assert copied_project.name.blank?
                  assert copied_project.identifier.blank?
                  # Duplicated attributes
                  assert_equal source_project.description, copied_project.description
                  assert_equal source_project.enabled_modules, copied_project.enabled_modules
                  assert_equal source_project.trackers, copied_project.trackers
                  # Default attributes
                  assert_equal 1, copied_project.status
                end
                def test_activities_should_use_the_system_activities
                  project = Project.find(1)
                  assert_equal project.activities, TimeEntryActivity.find(:all, :conditions => {:active => true} )
                end
                def test_activities_should_use_the_project_specific_activities
                  project = Project.find(1)
                  overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project})
                  assert overridden_activity.save!
                  assert project.activities.include?(overridden_activity), "Project specific Activity not found"
                end
                def test_activities_should_not_include_the_inactive_project_specific_activities
                  project = Project.find(1)
                  overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project, :parent => TimeEntryActivity.find(:first), :active => false})
                  assert overridden_activity.save!
                  assert !project.activities.include?(overridden_activity), "Inactive Project specific Activity found"
                end
                def test_activities_should_not_include_project_specific_activities_from_other_projects
                  project = Project.find(1)
                  overridden_activity = TimeEntryActivity.new({:name => "Project", :project => Project.find(2)})
                  assert overridden_activity.save!
                  assert !project.activities.include?(overridden_activity), "Project specific Activity found on a different project"
                end
                def test_activities_should_handle_nils
                  overridden_activity = TimeEntryActivity.new({:name => "Project", :project => Project.find(1), :parent => TimeEntryActivity.find(:first)})
                  TimeEntryActivity.delete_all
                  # No activities
                  project = Project.find(1)
                  assert project.activities.empty?
                  # No system, one overridden
                  assert overridden_activity.save!
                  project.reload
                  assert_equal [overridden_activity], project.activities
                end
                def test_activities_should_override_system_activities_with_project_activities
                  project = Project.find(1)
                  parent_activity = TimeEntryActivity.find(:first)
                  overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project, :parent => parent_activity})
                  assert overridden_activity.save!
                  assert project.activities.include?(overridden_activity), "Project specific Activity not found"
                  assert !project.activities.include?(parent_activity), "System Activity found when it should have been overridden"
                end
                def test_activities_should_include_inactive_activities_if_specified
                  project = Project.find(1)
                  overridden_activity = TimeEntryActivity.new({:name => "Project", :project => project, :parent => TimeEntryActivity.find(:first), :active => false})
                  assert overridden_activity.save!
                  assert project.activities(true).include?(overridden_activity), "Inactive Project specific Activity not found"
                end
                test 'activities should not include active System activities if the project has an override that is inactive' do
                  project = Project.find(1)
                  system_activity = TimeEntryActivity.find_by_name('Design')
                  assert system_activity.active?
                  overridden_activity = TimeEntryActivity.create!(:name => "Project", :project => project, :parent => system_activity, :active => false)
                  assert overridden_activity.save!
                  assert !project.activities.include?(overridden_activity), "Inactive Project specific Activity not found"
                  assert !project.activities.include?(system_activity), "System activity found when the project has an inactive override"
                end
                def test_close_completed_versions
                  Version.update_all("status = 'open'")
                  project = Project.find(1)
                  assert_not_nil project.versions.detect {|v| v.completed? && v.status == 'open'}
                  assert_not_nil project.versions.detect {|v| !v.completed? && v.status == 'open'}
                  project.close_completed_versions
                  project.reload
                  assert_nil project.versions.detect {|v| v.completed? && v.status != 'closed'}
                  assert_not_nil project.versions.detect {|v| !v.completed? && v.status == 'open'}
                end
                context "Project#copy" do
                  setup do
                    ProjectCustomField.destroy_all # Custom values are a mess to isolate in tests
                    Project.destroy_all :identifier => "copy-test"
                    @source_project = Project.find(2)
                    @project = Project.new(:name => 'Copy Test', :identifier => 'copy-test')
                    @project.trackers = @source_project.trackers
                    @project.enabled_module_names = @source_project.enabled_modules.collect(&:name)
                  end
                  should "copy issues" do
                    @source_project.issues << Issue.generate!(:status => IssueStatus.find_by_name('Closed'),
                                                              :subject => "copy issue status",
                                                              :tracker_id => 1,
                                                              :assigned_to_id => 2,
                                                              :project_id => @source_project.id)
                    assert @project.valid?
                    assert @project.issues.empty?
                    assert @project.copy(@source_project)
                    assert_equal @source_project.issues.size, @project.issues.size
                    @project.issues.each do |issue|
                      assert issue.valid?
                      assert ! issue.assigned_to.blank?
                      assert_equal @project, issue.project
                    end
                    copied_issue = @project.issues.first(:conditions => {:subject => "copy issue status"})
                    assert copied_issue
                    assert copied_issue.status
                    assert_equal "Closed", copied_issue.status.name
                  end
                  should "change the new issues to use the copied version" do
                    User.current = User.find(1)
                    assigned_version = Version.generate!(:name => "Assigned Issues", :status => 'open')
                    @source_project.versions << assigned_version
                    assert_equal 3, @source_project.versions.size
                    Issue.generate_for_project!(@source_project,
                                                :fixed_version_id => assigned_version.id,
                                                :subject => "change the new issues to use the copied version",
                                                :tracker_id => 1,
                                                :project_id => @source_project.id)
                    assert @project.copy(@source_project)
                    @project.reload
                    copied_issue = @project.issues.first(:conditions => {:subject => "change the new issues to use the copied version"})
                    assert copied_issue
                    assert copied_issue.fixed_version
                    assert_equal "Assigned Issues", copied_issue.fixed_version.name # Same name
                    assert_not_equal assigned_version.id, copied_issue.fixed_version.id # Different record
                  end
                  should "copy issue relations" do
                    Setting.cross_project_issue_relations = '1'
                    second_issue = Issue.generate!(:status_id => 5,
                                                   :subject => "copy issue relation",
                                                   :tracker_id => 1,
                                                   :assigned_to_id => 2,
                                                   :project_id => @source_project.id)
                    source_relation = IssueRelation.create!(:issue_from => Issue.find(4),
                                                              :issue_to => second_issue,
                                                              :relation_type => "relates")
                    source_relation_cross_project = IssueRelation.create!(:issue_from => Issue.find(1),
                                                                            :issue_to => second_issue,
                                                                            :relation_type => "duplicates")
                    assert @project.copy(@source_project)
                    assert_equal @source_project.issues.count, @project.issues.count
                    copied_issue = @project.issues.find_by_subject("Issue on project 2") # Was #4
                    copied_second_issue = @project.issues.find_by_subject("copy issue relation")
                    # First issue with a relation on project
                    assert_equal 1, copied_issue.relations.size, "Relation not copied"
                    copied_relation = copied_issue.relations.first
                    assert_equal "relates", copied_relation.relation_type
                    assert_equal copied_second_issue.id, copied_relation.issue_to_id
                    assert_not_equal source_relation.id, copied_relation.id
                    # Second issue with a cross project relation
                    assert_equal 2, copied_second_issue.relations.size, "Relation not copied"
                    copied_relation = copied_second_issue.relations.select {|r| r.relation_type == 'duplicates'}.first
                    assert_equal "duplicates", copied_relation.relation_type
                    assert_equal 1, copied_relation.issue_from_id, "Cross project relation not kept"
                    assert_not_equal source_relation_cross_project.id, copied_relation.id
                  end
                  should "copy issue attachments" do
                    issue = Issue.generate!(:subject => "copy with attachment", :tracker_id => 1, :project_id => @source_project.id)
                    Attachment.create!(:container => issue, :file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 1)
                    @source_project.issues << issue
                    assert @project.copy(@source_project)
                    copied_issue = @project.issues.first(:conditions => {:subject => "copy with attachment"})
                    assert_not_nil copied_issue
                    assert_equal 1, copied_issue.attachments.count, "Attachment not copied"
                    assert_equal "testfile.txt", copied_issue.attachments.first.filename
                  end
                  should "copy memberships" do
                    assert @project.valid?
                    assert @project.members.empty?
                    assert @project.copy(@source_project)
                    assert_equal @source_project.memberships.size, @project.memberships.size
                    @project.memberships.each do |membership|
                      assert membership
                      assert_equal @project, membership.project
                    end
                  end
                  should "copy memberships with groups and additional roles" do
                    group = Group.create!(:lastname => "Copy group")
                    user = User.find(7)
                    group.users << user
                    # group role
                    Member.create!(:project_id => @source_project.id, :principal => group, :role_ids => [2])
                    member = Member.find_by_user_id_and_project_id(user.id, @source_project.id)
                    # additional role
                    member.role_ids = [1]
                    assert @project.copy(@source_project)
                    member = Member.find_by_user_id_and_project_id(user.id, @project.id)
                    assert_not_nil member
                    assert_equal [1, 2], member.role_ids.sort
                  end
                  should "copy project specific queries" do
                    assert @project.valid?
                    assert @project.queries.empty?
                    assert @project.copy(@source_project)
                    assert_equal @source_project.queries.size, @project.queries.size
                    @project.queries.each do |query|
                      assert query
                      assert_equal @project, query.project
                    end
                    assert_equal @source_project.queries.map(&:user_id).sort, @project.queries.map(&:user_id).sort
                  end
                  should "copy versions" do
                    @source_project.versions << Version.generate!
                    @source_project.versions << Version.generate!
                    assert @project.versions.empty?
                    assert @project.copy(@source_project)
                    assert_equal @source_project.versions.size, @project.versions.size
                    @project.versions.each do |version|
                      assert version
                      assert_equal @project, version.project
                    end
                  end
                  should "copy wiki" do
                    assert_difference 'Wiki.count' do
                      assert @project.copy(@source_project)
                    end
                    assert @project.wiki
                    assert_not_equal @source_project.wiki, @project.wiki
                    assert_equal "Start page", @project.wiki.start_page
                  end
                  should "copy wiki pages and content with hierarchy" do
                    assert_difference 'WikiPage.count', @source_project.wiki.pages.size do
                      assert @project.copy(@source_project)
                    end
                    assert @project.wiki
                    assert_equal @source_project.wiki.pages.size, @project.wiki.pages.size
                    @project.wiki.pages.each do |wiki_page|
                      assert wiki_page.content
                      assert !@source_project.wiki.pages.include?(wiki_page)
                    end
                    parent = @project.wiki.find_page('Parent_page')
                    child1 = @project.wiki.find_page('Child_page_1')
                    child2 = @project.wiki.find_page('Child_page_2')
                    assert_equal parent, child1.parent
                    assert_equal parent, child2.parent
                  end
                  should "copy issue categories" do
                    assert @project.copy(@source_project)
                    assert_equal 2, @project.issue_categories.size
                    @project.issue_categories.each do |issue_category|
                      assert !@source_project.issue_categories.include?(issue_category)
                    end
                  end
                  should "copy boards" do
                    assert @project.copy(@source_project)
                    assert_equal 1, @project.boards.size
                    @project.boards.each do |board|
                      assert !@source_project.boards.include?(board)
                    end
                  end
                  should "change the new issues to use the copied issue categories" do
                    issue = Issue.find(4)
                    issue.update_attribute(:category_id, 3)
                    assert @project.copy(@source_project)
                    @project.issues.each do |issue|
                      assert issue.category
                      assert_equal "Stock management", issue.category.name # Same name
                      assert_not_equal IssueCategory.find(3), issue.category # Different record
                    end
                  end
                  should "limit copy with :only option" do
                    assert @project.members.empty?
                    assert @project.issue_categories.empty?
                    assert @source_project.issues.any?
                    assert @project.copy(@source_project, :only => ['members', 'issue_categories'])
                    assert @project.members.any?
                    assert @project.issue_categories.any?
                    assert @project.issues.empty?
                  end
                end
                context "#start_date" do
                  setup do
                    ProjectCustomField.destroy_all # Custom values are a mess to isolate in tests
                    @project = Project.generate!(:identifier => 'test0')
                    @project.trackers << Tracker.generate!
                  end
                  should "be nil if there are no issues on the project" do
                    assert_nil @project.start_date
                  end
                  should "be tested when issues have no start date"
                  should "be the earliest start date of it's issues" do
                    early = 7.days.ago.to_date
                    Issue.generate_for_project!(@project, :start_date => Date.today)
                    Issue.generate_for_project!(@project, :start_date => early)
                    assert_equal early, @project.start_date
                  end
                end
                context "#due_date" do
                  setup do
                    ProjectCustomField.destroy_all # Custom values are a mess to isolate in tests
                    @project = Project.generate!(:identifier => 'test0')
                    @project.trackers << Tracker.generate!
                  end
                  should "be nil if there are no issues on the project" do
                    assert_nil @project.due_date
                  end
                  should "be tested when issues have no due date"
                  should "be the latest due date of it's issues" do
                    future = 7.days.from_now.to_date
                    Issue.generate_for_project!(@project, :due_date => future)
                    Issue.generate_for_project!(@project, :due_date => Date.today)
                    assert_equal future, @project.due_date
                  end
                  should "be the latest due date of it's versions" do
                    future = 7.days.from_now.to_date
                    @project.versions << Version.generate!(:effective_date => future)
                    @project.versions << Version.generate!(:effective_date => Date.today)
                    assert_equal future, @project.due_date
                  end
                  should "pick the latest date from it's issues and versions" do
                    future = 7.days.from_now.to_date
                    far_future = 14.days.from_now.to_date
                    Issue.generate_for_project!(@project, :due_date => far_future)
                    @project.versions << Version.generate!(:effective_date => future)
                    assert_equal far_future, @project.due_date
                  end
                end
                context "Project#completed_percent" do
                  setup do
                    ProjectCustomField.destroy_all # Custom values are a mess to isolate in tests
                    @project = Project.generate!(:identifier => 'test0')
                    @project.trackers << Tracker.generate!
                  end
                  context "no versions" do
                    should "be 100" do
                      assert_equal 100, @project.completed_percent
                    end
                  end
                  context "with versions" do
                    should "return 0 if the versions have no issues" do
                      Version.generate!(:project => @project)
                      Version.generate!(:project => @project)
                      assert_equal 0, @project.completed_percent
                    end
                    should "return 100 if the version has only closed issues" do
                      v1 = Version.generate!(:project => @project)
                      Issue.generate_for_project!(@project, :status => IssueStatus.find_by_name('Closed'), :fixed_version => v1)
                      v2 = Version.generate!(:project => @project)
                      Issue.generate_for_project!(@project, :status => IssueStatus.find_by_name('Closed'), :fixed_version => v2)
                      assert_equal 100, @project.completed_percent
                    end
                    should "return the averaged completed percent of the versions (not weighted)" do
                      v1 = Version.generate!(:project => @project)
                      Issue.generate_for_project!(@project, :status => IssueStatus.find_by_name('New'), :estimated_hours => 10, :done_ratio => 50, :fixed_version => v1)
                      v2 = Version.generate!(:project => @project)
                      Issue.generate_for_project!(@project, :status => IssueStatus.find_by_name('New'), :estimated_hours => 10, :done_ratio => 50, :fixed_version => v2)
                      assert_equal 50, @project.completed_percent
                    end
                  end
                end
                context "#notified_users" do
                  setup do
                    @project = Project.generate!
                    @role = Role.generate!
                    @user_with_membership_notification = User.generate!(:mail_notification => 'selected')
                    Member.create!(:project => @project, :roles => [@role], :principal => @user_with_membership_notification, :mail_notification => true)
                    @all_events_user = User.generate!(:mail_notification => 'all')
                    Member.create!(:project => @project, :roles => [@role], :principal => @all_events_user)
                    @no_events_user = User.generate!(:mail_notification => 'none')
                    Member.create!(:project => @project, :roles => [@role], :principal => @no_events_user)
                    @only_my_events_user = User.generate!(:mail_notification => 'only_my_events')
                    Member.create!(:project => @project, :roles => [@role], :principal => @only_my_events_user)
                    @only_assigned_user = User.generate!(:mail_notification => 'only_assigned')
                    Member.create!(:project => @project, :roles => [@role], :principal => @only_assigned_user)
                    @only_owned_user = User.generate!(:mail_notification => 'only_owner')
                    Member.create!(:project => @project, :roles => [@role], :principal => @only_owned_user)
                  end
                  should "include members with a mail notification" do
                    assert @project.notified_users.include?(@user_with_membership_notification)
                  end
                  should "include users with the 'all' notification option" do
                    assert @project.notified_users.include?(@all_events_user)
                  end
                  should "not include users with the 'none' notification option" do
                    assert !@project.notified_users.include?(@no_events_user)
                  end
                  should "not include users with the 'only_my_events' notification option" do
                    assert !@project.notified_users.include?(@only_my_events_user)
                  end
                  should "not include users with the 'only_assigned' notification option" do
                    assert !@project.notified_users.include?(@only_assigned_user)
                  end
                  should "not include users with the 'only_owner' notification option" do
                    assert !@project.notified_users.include?(@only_owned_user)
                  end
                end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages