jro_apps/redmine Commit - r8224:8f2304385170

Dup attributes instead of issue object....

Jean-Philippe Lang -

r8224:8f2304385170

parent child

Context file:

r8224:8f2304385170

Collapse all files

app/models/issue.rb +4 -5

               def init_journal(user, notes = "")
                 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
-                @issue_before_change = self.clone
+                @attributes_before_change = attributes.dup
-                @issue_before_change.status = self.status
                 @custom_values_before_change = {}
                 self.custom_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
                 # Make sure updated_on is updated when adding a note.
                 if @current_journal
                   # attributes changes
                   (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
-                    before = @issue_before_change.send(c)
+                    before = @attributes_before_change[c]
                     after = send(c)
                     next if before == after || (before.blank? && after.blank?)
                     @current_journal.details << JournalDetail.new(:property => 'attr',
                                                                   :prop_key => c,
-                                                                  :old_value => @issue_before_change.send(c),
+                                                                  :old_value => before,
-                                                                  :value => send(c))
+                                                                  :value => after)
                   }
                   # custom fields changes
                   custom_values.each {|c|

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages