##// END OF EJS Templates
Fixed #759: Can not view a project without View time entries permission (broken by r1176)....
Jean-Philippe Lang -
r1170:8ea2ecb983c2
parent child
Show More
@@ -1,249 +1,249
1 # redMine - project management software
1 # redMine - project management software
2 # Copyright (C) 2006 Jean-Philippe Lang
2 # Copyright (C) 2006 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class Project < ActiveRecord::Base
18 class Project < ActiveRecord::Base
19 # Project statuses
19 # Project statuses
20 STATUS_ACTIVE = 1
20 STATUS_ACTIVE = 1
21 STATUS_ARCHIVED = 9
21 STATUS_ARCHIVED = 9
22
22
23 has_many :members, :include => :user, :conditions => "#{User.table_name}.status=#{User::STATUS_ACTIVE}"
23 has_many :members, :include => :user, :conditions => "#{User.table_name}.status=#{User::STATUS_ACTIVE}"
24 has_many :users, :through => :members
24 has_many :users, :through => :members
25 has_many :custom_values, :dependent => :delete_all, :as => :customized
25 has_many :custom_values, :dependent => :delete_all, :as => :customized
26 has_many :enabled_modules, :dependent => :delete_all
26 has_many :enabled_modules, :dependent => :delete_all
27 has_and_belongs_to_many :trackers, :order => "#{Tracker.table_name}.position"
27 has_and_belongs_to_many :trackers, :order => "#{Tracker.table_name}.position"
28 has_many :issues, :dependent => :destroy, :order => "#{Issue.table_name}.created_on DESC", :include => [:status, :tracker]
28 has_many :issues, :dependent => :destroy, :order => "#{Issue.table_name}.created_on DESC", :include => [:status, :tracker]
29 has_many :issue_changes, :through => :issues, :source => :journals
29 has_many :issue_changes, :through => :issues, :source => :journals
30 has_many :versions, :dependent => :destroy, :order => "#{Version.table_name}.effective_date DESC, #{Version.table_name}.name DESC"
30 has_many :versions, :dependent => :destroy, :order => "#{Version.table_name}.effective_date DESC, #{Version.table_name}.name DESC"
31 has_many :time_entries, :dependent => :delete_all
31 has_many :time_entries, :dependent => :delete_all
32 has_many :queries, :dependent => :delete_all
32 has_many :queries, :dependent => :delete_all
33 has_many :documents, :dependent => :destroy
33 has_many :documents, :dependent => :destroy
34 has_many :news, :dependent => :delete_all, :include => :author
34 has_many :news, :dependent => :delete_all, :include => :author
35 has_many :issue_categories, :dependent => :delete_all, :order => "#{IssueCategory.table_name}.name"
35 has_many :issue_categories, :dependent => :delete_all, :order => "#{IssueCategory.table_name}.name"
36 has_many :boards, :order => "position ASC"
36 has_many :boards, :order => "position ASC"
37 has_one :repository, :dependent => :destroy
37 has_one :repository, :dependent => :destroy
38 has_many :changesets, :through => :repository
38 has_many :changesets, :through => :repository
39 has_one :wiki, :dependent => :destroy
39 has_one :wiki, :dependent => :destroy
40 # Custom field for the project issues
40 # Custom field for the project issues
41 has_and_belongs_to_many :custom_fields,
41 has_and_belongs_to_many :custom_fields,
42 :class_name => 'IssueCustomField',
42 :class_name => 'IssueCustomField',
43 :order => "#{CustomField.table_name}.position",
43 :order => "#{CustomField.table_name}.position",
44 :join_table => "#{table_name_prefix}custom_fields_projects#{table_name_suffix}",
44 :join_table => "#{table_name_prefix}custom_fields_projects#{table_name_suffix}",
45 :association_foreign_key => 'custom_field_id'
45 :association_foreign_key => 'custom_field_id'
46
46
47 acts_as_tree :order => "name", :counter_cache => true
47 acts_as_tree :order => "name", :counter_cache => true
48
48
49 acts_as_searchable :columns => ['name', 'description'], :project_key => 'id'
49 acts_as_searchable :columns => ['name', 'description'], :project_key => 'id'
50 acts_as_event :title => Proc.new {|o| "#{l(:label_project)}: #{o.name}"},
50 acts_as_event :title => Proc.new {|o| "#{l(:label_project)}: #{o.name}"},
51 :url => Proc.new {|o| {:controller => 'projects', :action => 'show', :id => o.id}}
51 :url => Proc.new {|o| {:controller => 'projects', :action => 'show', :id => o.id}}
52
52
53 attr_protected :status, :enabled_module_names
53 attr_protected :status, :enabled_module_names
54
54
55 validates_presence_of :name, :identifier
55 validates_presence_of :name, :identifier
56 validates_uniqueness_of :name, :identifier
56 validates_uniqueness_of :name, :identifier
57 validates_associated :custom_values, :on => :update
57 validates_associated :custom_values, :on => :update
58 validates_associated :repository, :wiki
58 validates_associated :repository, :wiki
59 validates_length_of :name, :maximum => 30
59 validates_length_of :name, :maximum => 30
60 validates_length_of :homepage, :maximum => 60
60 validates_length_of :homepage, :maximum => 60
61 validates_length_of :identifier, :in => 3..20
61 validates_length_of :identifier, :in => 3..20
62 validates_format_of :identifier, :with => /^[a-z0-9\-]*$/
62 validates_format_of :identifier, :with => /^[a-z0-9\-]*$/
63
63
64 before_destroy :delete_all_members
64 before_destroy :delete_all_members
65
65
66 def identifier=(identifier)
66 def identifier=(identifier)
67 super unless identifier_frozen?
67 super unless identifier_frozen?
68 end
68 end
69
69
70 def identifier_frozen?
70 def identifier_frozen?
71 errors[:identifier].nil? && !(new_record? || identifier.blank?)
71 errors[:identifier].nil? && !(new_record? || identifier.blank?)
72 end
72 end
73
73
74 def issues_with_subprojects(include_subprojects=false)
74 def issues_with_subprojects(include_subprojects=false)
75 conditions = nil
75 conditions = nil
76 if include_subprojects && !active_children.empty?
76 if include_subprojects && !active_children.empty?
77 ids = [id] + active_children.collect {|c| c.id}
77 ids = [id] + active_children.collect {|c| c.id}
78 conditions = ["#{Issue.table_name}.project_id IN (#{ids.join(',')})"]
78 conditions = ["#{Issue.table_name}.project_id IN (#{ids.join(',')})"]
79 end
79 end
80 conditions ||= ["#{Issue.table_name}.project_id = ?", id]
80 conditions ||= ["#{Issue.table_name}.project_id = ?", id]
81 # Quick and dirty fix for Rails 2 compatibility
81 # Quick and dirty fix for Rails 2 compatibility
82 Issue.send(:with_scope, :find => { :conditions => conditions }) do
82 Issue.send(:with_scope, :find => { :conditions => conditions }) do
83 yield
83 yield
84 end
84 end
85 end
85 end
86
86
87 # Return all issues status changes for the project between the 2 given dates
87 # Return all issues status changes for the project between the 2 given dates
88 def issues_status_changes(from, to)
88 def issues_status_changes(from, to)
89 Journal.find(:all, :include => [:issue, :details, :user],
89 Journal.find(:all, :include => [:issue, :details, :user],
90 :conditions => ["#{Journal.table_name}.journalized_type = 'Issue'" +
90 :conditions => ["#{Journal.table_name}.journalized_type = 'Issue'" +
91 " AND #{Issue.table_name}.project_id = ?" +
91 " AND #{Issue.table_name}.project_id = ?" +
92 " AND #{JournalDetail.table_name}.prop_key = 'status_id'" +
92 " AND #{JournalDetail.table_name}.prop_key = 'status_id'" +
93 " AND #{Journal.table_name}.created_on BETWEEN ? AND ?",
93 " AND #{Journal.table_name}.created_on BETWEEN ? AND ?",
94 id, from, to+1])
94 id, from, to+1])
95 end
95 end
96
96
97 # returns latest created projects
97 # returns latest created projects
98 # non public projects will be returned only if user is a member of those
98 # non public projects will be returned only if user is a member of those
99 def self.latest(user=nil, count=5)
99 def self.latest(user=nil, count=5)
100 find(:all, :limit => count, :conditions => visible_by(user), :order => "created_on DESC")
100 find(:all, :limit => count, :conditions => visible_by(user), :order => "created_on DESC")
101 end
101 end
102
102
103 def self.visible_by(user=nil)
103 def self.visible_by(user=nil)
104 if user && user.admin?
104 if user && user.admin?
105 return "#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"
105 return "#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"
106 elsif user && user.memberships.any?
106 elsif user && user.memberships.any?
107 return "#{Project.table_name}.status=#{Project::STATUS_ACTIVE} AND (#{Project.table_name}.is_public = #{connection.quoted_true} or #{Project.table_name}.id IN (#{user.memberships.collect{|m| m.project_id}.join(',')}))"
107 return "#{Project.table_name}.status=#{Project::STATUS_ACTIVE} AND (#{Project.table_name}.is_public = #{connection.quoted_true} or #{Project.table_name}.id IN (#{user.memberships.collect{|m| m.project_id}.join(',')}))"
108 else
108 else
109 return "#{Project.table_name}.status=#{Project::STATUS_ACTIVE} AND #{Project.table_name}.is_public = #{connection.quoted_true}"
109 return "#{Project.table_name}.status=#{Project::STATUS_ACTIVE} AND #{Project.table_name}.is_public = #{connection.quoted_true}"
110 end
110 end
111 end
111 end
112
112
113 def self.allowed_to_condition(user, permission)
113 def self.allowed_to_condition(user, permission)
114 statements = []
114 statements = []
115 active_statement = "#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"
115 active_statement = "#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"
116 if user.admin?
116 if user.admin?
117 # no restriction
117 # no restriction
118 elsif user.logged?
118 elsif user.logged?
119 statements << "#{Project.table_name}.is_public = #{connection.quoted_true}" if Role.non_member.allowed_to?(permission)
119 statements << "#{Project.table_name}.is_public = #{connection.quoted_true}" if Role.non_member.allowed_to?(permission)
120 allowed_project_ids = user.memberships.select {|m| m.role.allowed_to?(permission)}.collect {|m| m.project_id}
120 allowed_project_ids = user.memberships.select {|m| m.role.allowed_to?(permission)}.collect {|m| m.project_id}
121 statements << "#{Project.table_name}.id IN (#{allowed_project_ids.join(',')})"
121 statements << "#{Project.table_name}.id IN (#{allowed_project_ids.join(',')})" if allowed_project_ids.any?
122 else
122 else
123 statements << "#{Project.table_name}.is_public = #{connection.quoted_true}" if Role.anonymous.allowed_to?(permission)
123 statements << "#{Project.table_name}.is_public = #{connection.quoted_true}" if Role.anonymous.allowed_to?(permission)
124 end
124 end
125 statements.empty? ? active_statement : "(#{active_statement} AND (#{statements.join(' OR ')}))"
125 statements.empty? ? active_statement : "(#{active_statement} AND (#{statements.join(' OR ')}))"
126 end
126 end
127
127
128 def self.find(*args)
128 def self.find(*args)
129 if args.first && args.first.is_a?(String) && !args.first.match(/^\d*$/)
129 if args.first && args.first.is_a?(String) && !args.first.match(/^\d*$/)
130 project = find_by_identifier(*args)
130 project = find_by_identifier(*args)
131 raise ActiveRecord::RecordNotFound, "Couldn't find Project with identifier=#{args.first}" if project.nil?
131 raise ActiveRecord::RecordNotFound, "Couldn't find Project with identifier=#{args.first}" if project.nil?
132 project
132 project
133 else
133 else
134 super
134 super
135 end
135 end
136 end
136 end
137
137
138 def to_param
138 def to_param
139 identifier
139 identifier
140 end
140 end
141
141
142 def active?
142 def active?
143 self.status == STATUS_ACTIVE
143 self.status == STATUS_ACTIVE
144 end
144 end
145
145
146 def archive
146 def archive
147 # Archive subprojects if any
147 # Archive subprojects if any
148 children.each do |subproject|
148 children.each do |subproject|
149 subproject.archive
149 subproject.archive
150 end
150 end
151 update_attribute :status, STATUS_ARCHIVED
151 update_attribute :status, STATUS_ARCHIVED
152 end
152 end
153
153
154 def unarchive
154 def unarchive
155 return false if parent && !parent.active?
155 return false if parent && !parent.active?
156 update_attribute :status, STATUS_ACTIVE
156 update_attribute :status, STATUS_ACTIVE
157 end
157 end
158
158
159 def active_children
159 def active_children
160 children.select {|child| child.active?}
160 children.select {|child| child.active?}
161 end
161 end
162
162
163 # Returns an array of the trackers used by the project and its sub projects
163 # Returns an array of the trackers used by the project and its sub projects
164 def rolled_up_trackers
164 def rolled_up_trackers
165 @rolled_up_trackers ||=
165 @rolled_up_trackers ||=
166 Tracker.find(:all, :include => :projects,
166 Tracker.find(:all, :include => :projects,
167 :select => "DISTINCT #{Tracker.table_name}.*",
167 :select => "DISTINCT #{Tracker.table_name}.*",
168 :conditions => ["#{Project.table_name}.id = ? OR #{Project.table_name}.parent_id = ?", id, id],
168 :conditions => ["#{Project.table_name}.id = ? OR #{Project.table_name}.parent_id = ?", id, id],
169 :order => "#{Tracker.table_name}.position")
169 :order => "#{Tracker.table_name}.position")
170 end
170 end
171
171
172 # Deletes all project's members
172 # Deletes all project's members
173 def delete_all_members
173 def delete_all_members
174 Member.delete_all(['project_id = ?', id])
174 Member.delete_all(['project_id = ?', id])
175 end
175 end
176
176
177 # Users issues can be assigned to
177 # Users issues can be assigned to
178 def assignable_users
178 def assignable_users
179 members.select {|m| m.role.assignable?}.collect {|m| m.user}.sort
179 members.select {|m| m.role.assignable?}.collect {|m| m.user}.sort
180 end
180 end
181
181
182 # Returns the mail adresses of users that should be always notified on project events
182 # Returns the mail adresses of users that should be always notified on project events
183 def recipients
183 def recipients
184 members.select {|m| m.mail_notification? || m.user.mail_notification?}.collect {|m| m.user.mail}
184 members.select {|m| m.mail_notification? || m.user.mail_notification?}.collect {|m| m.user.mail}
185 end
185 end
186
186
187 # Returns an array of all custom fields enabled for project issues
187 # Returns an array of all custom fields enabled for project issues
188 # (explictly associated custom fields and custom fields enabled for all projects)
188 # (explictly associated custom fields and custom fields enabled for all projects)
189 def custom_fields_for_issues(tracker)
189 def custom_fields_for_issues(tracker)
190 all_custom_fields.select {|c| tracker.custom_fields.include? c }
190 all_custom_fields.select {|c| tracker.custom_fields.include? c }
191 end
191 end
192
192
193 def all_custom_fields
193 def all_custom_fields
194 @all_custom_fields ||= (IssueCustomField.for_all + custom_fields).uniq
194 @all_custom_fields ||= (IssueCustomField.for_all + custom_fields).uniq
195 end
195 end
196
196
197 def <=>(project)
197 def <=>(project)
198 name.downcase <=> project.name.downcase
198 name.downcase <=> project.name.downcase
199 end
199 end
200
200
201 def to_s
201 def to_s
202 name
202 name
203 end
203 end
204
204
205 # Returns a short description of the projects (first lines)
205 # Returns a short description of the projects (first lines)
206 def short_description(length = 255)
206 def short_description(length = 255)
207 description.gsub(/^(.{#{length}}[^\n]*).*$/m, '\1').strip if description
207 description.gsub(/^(.{#{length}}[^\n]*).*$/m, '\1').strip if description
208 end
208 end
209
209
210 def allows_to?(action)
210 def allows_to?(action)
211 if action.is_a? Hash
211 if action.is_a? Hash
212 allowed_actions.include? "#{action[:controller]}/#{action[:action]}"
212 allowed_actions.include? "#{action[:controller]}/#{action[:action]}"
213 else
213 else
214 allowed_permissions.include? action
214 allowed_permissions.include? action
215 end
215 end
216 end
216 end
217
217
218 def module_enabled?(module_name)
218 def module_enabled?(module_name)
219 module_name = module_name.to_s
219 module_name = module_name.to_s
220 enabled_modules.detect {|m| m.name == module_name}
220 enabled_modules.detect {|m| m.name == module_name}
221 end
221 end
222
222
223 def enabled_module_names=(module_names)
223 def enabled_module_names=(module_names)
224 enabled_modules.clear
224 enabled_modules.clear
225 module_names = [] unless module_names && module_names.is_a?(Array)
225 module_names = [] unless module_names && module_names.is_a?(Array)
226 module_names.each do |name|
226 module_names.each do |name|
227 enabled_modules << EnabledModule.new(:name => name.to_s)
227 enabled_modules << EnabledModule.new(:name => name.to_s)
228 end
228 end
229 end
229 end
230
230
231 protected
231 protected
232 def validate
232 def validate
233 errors.add(parent_id, " must be a root project") if parent and parent.parent
233 errors.add(parent_id, " must be a root project") if parent and parent.parent
234 errors.add_to_base("A project with subprojects can't be a subproject") if parent and children.size > 0
234 errors.add_to_base("A project with subprojects can't be a subproject") if parent and children.size > 0
235 errors.add(:identifier, :activerecord_error_invalid) if !identifier.blank? && identifier.match(/^\d*$/)
235 errors.add(:identifier, :activerecord_error_invalid) if !identifier.blank? && identifier.match(/^\d*$/)
236 end
236 end
237
237
238 private
238 private
239 def allowed_permissions
239 def allowed_permissions
240 @allowed_permissions ||= begin
240 @allowed_permissions ||= begin
241 module_names = enabled_modules.collect {|m| m.name}
241 module_names = enabled_modules.collect {|m| m.name}
242 Redmine::AccessControl.modules_permissions(module_names).collect {|p| p.name}
242 Redmine::AccessControl.modules_permissions(module_names).collect {|p| p.name}
243 end
243 end
244 end
244 end
245
245
246 def allowed_actions
246 def allowed_actions
247 @actions_allowed ||= allowed_permissions.inject([]) { |actions, permission| actions += Redmine::AccessControl.allowed_actions(permission) }.flatten
247 @actions_allowed ||= allowed_permissions.inject([]) { |actions, permission| actions += Redmine::AccessControl.allowed_actions(permission) }.flatten
248 end
248 end
249 end
249 end
General Comments 0
You need to be logged in to leave comments. Login now