jro_apps/redmine Commit - r11231:8e17c2aeaccd

1

# Redmine - project management software

1

# Redmine - project management software

2

3

#

3

#

4

# This program is free software; you can redistribute it and/or

4

# This program is free software; you can redistribute it and/or

5

# modify it under the terms of the GNU General Public License

5

# modify it under the terms of the GNU General Public License

6

# as published by the Free Software Foundation; either version 2

6

# as published by the Free Software Foundation; either version 2

7

# of the License, or (at your option) any later version.

7

# of the License, or (at your option) any later version.

8

#

8

#

9

# This program is distributed in the hope that it will be useful,

9

# This program is distributed in the hope that it will be useful,

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

10

# but WITHOUT ANY WARRANTY; without even the implied warranty of

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

11

# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the

12

# GNU General Public License for more details.

12

# GNU General Public License for more details.

13

#

13

#

14

# You should have received a copy of the GNU General Public License

14

# You should have received a copy of the GNU General Public License

15

# along with this program; if not, write to the Free Software

15

# along with this program; if not, write to the Free Software

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

16

# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.

17

18

class Issue < ActiveRecord::Base

18

class Issue < ActiveRecord::Base

19

include Redmine::SafeAttributes

19

include Redmine::SafeAttributes

20

include Redmine::Utils::DateCalculation

20

include Redmine::Utils::DateCalculation

21

22

belongs_to :project

22

belongs_to :project

23

belongs_to :tracker

23

belongs_to :tracker

24

belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'

24

belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'

25

belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'

25

belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'

26

belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'

26

belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'

27

belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'

27

belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'

28

belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'

28

belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'

29

belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'

29

belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'

30

31

has_many :journals, :as => :journalized, :dependent => :destroy

31

has_many :journals, :as => :journalized, :dependent => :destroy

32

has_many :visible_journals,

32

has_many :visible_journals,

33

:class_name => 'Journal',

33

:class_name => 'Journal',

34

:as => :journalized,

34

:as => :journalized,

35

:conditions => Proc.new {

35

:conditions => Proc.new {

36

["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]

36

["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]

37

},

37

},

38

:readonly => true

38

:readonly => true

39

40

has_many :time_entries, :dependent => :delete_all

40

has_many :time_entries, :dependent => :delete_all

41

has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"

41

has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"

42

43

has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all

43

has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all

44

has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all

44

has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all

45

46

acts_as_nested_set :scope => 'root_id', :dependent => :destroy

46

acts_as_nested_set :scope => 'root_id', :dependent => :destroy

47

acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed

47

acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed

48

acts_as_customizable

48

acts_as_customizable

49

acts_as_watchable

49

acts_as_watchable

50

acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],

50

acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],

51

:include => [:project, :visible_journals],

51

:include => [:project, :visible_journals],

52

# sort by id so that limited eager loading doesn't break with postgresql

52

# sort by id so that limited eager loading doesn't break with postgresql

53

:order_column => "#{table_name}.id"

53

:order_column => "#{table_name}.id"

54

acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},

54

acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},

55

:url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},

55

:url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},

56

:type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }

56

:type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }

57

58

acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},

58

acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},

59

:author_key => :author_id

59

:author_key => :author_id

60

61

DONE_RATIO_OPTIONS = %w(issue_field issue_status)

61

DONE_RATIO_OPTIONS = %w(issue_field issue_status)

62

63

attr_reader :current_journal

63

attr_reader :current_journal

64

delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true

64

delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true

65

66

validates_presence_of :subject, :priority, :project, :tracker, :author, :status

66

validates_presence_of :subject, :priority, :project, :tracker, :author, :status

67

68

validates_length_of :subject, :maximum => 255

68

validates_length_of :subject, :maximum => 255

69

validates_inclusion_of :done_ratio, :in => 0..100

69

validates_inclusion_of :done_ratio, :in => 0..100

70

validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}

70

validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}

71

validates :start_date, :date => true

71

validates :start_date, :date => true

72

validates :due_date, :date => true

72

validates :due_date, :date => true

73

validate :validate_issue, :validate_required_fields

73

validate :validate_issue, :validate_required_fields

74

75

scope :visible, lambda {|*args|

75

scope :visible, lambda {|*args|

76

includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))

76

includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))

77

}

77

}

78

79

scope :open, lambda {|*args|

79

scope :open, lambda {|*args|

80

is_closed = args.size > 0 ? !args.first : false

80

is_closed = args.size > 0 ? !args.first : false

81

includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)

81

includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)

82

}

82

}

83

84

scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }

84

scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }

85

scope :on_active_project, lambda {

85

scope :on_active_project, lambda {

86

includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)

86

includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)

87

}

87

}

88

scope :fixed_version, lambda {|versions|

88

scope :fixed_version, lambda {|versions|

89

ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}

89

ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}

90

ids.any? ? where(:fixed_version_id => ids) : where('1=0')

90

ids.any? ? where(:fixed_version_id => ids) : where('1=0')

91

}

91

}

92

93

before_create :default_assign

93

before_create :default_assign

94

before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on

94

before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on

95

after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}

95

after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}

96

after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal

96

after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal

97

# Should be after_create but would be called before previous after_save callbacks

97

# Should be after_create but would be called before previous after_save callbacks

98

after_save :after_create_from_copy

98

after_save :after_create_from_copy

99

after_destroy :update_parent_attributes

99

after_destroy :update_parent_attributes

100

101

# Returns a SQL conditions string used to find all issues visible by the specified user

101

# Returns a SQL conditions string used to find all issues visible by the specified user

102

def self.visible_condition(user, options={})

102

def self.visible_condition(user, options={})

103

Project.allowed_to_condition(user, :view_issues, options) do |role, user|

103

Project.allowed_to_condition(user, :view_issues, options) do |role, user|

104

if user.logged?

104

if user.logged?

105

case role.issues_visibility

105

case role.issues_visibility

106

when 'all'

106

when 'all'

107

nil

107

nil

108

when 'default'

108

when 'default'

109

user_ids = [user.id] + user.groups.map(&:id)

109

user_ids = [user.id] + user.groups.map(&:id)

110

"(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"

110

"(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"

111

when 'own'

111

when 'own'

112

user_ids = [user.id] + user.groups.map(&:id)

112

user_ids = [user.id] + user.groups.map(&:id)

113

"(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"

113

"(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"

114

else

114

else

115

'1=0'

115

'1=0'

116

end

116

end

117

else

117

else

118

"(#{table_name}.is_private = #{connection.quoted_false})"

118

"(#{table_name}.is_private = #{connection.quoted_false})"

119

end

119

end

120

end

120

end

121

end

121

end

122

123

# Returns true if usr or current user is allowed to view the issue

123

# Returns true if usr or current user is allowed to view the issue

124

def visible?(usr=nil)

124

def visible?(usr=nil)

125

(usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|

125

(usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|

126

if user.logged?

126

if user.logged?

127

case role.issues_visibility

127

case role.issues_visibility

128

when 'all'

128

when 'all'

129

true

129

true

130

when 'default'

130

when 'default'

131

!self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))

131

!self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))

132

when 'own'

132

when 'own'

133

self.author == user || user.is_or_belongs_to?(assigned_to)

133

self.author == user || user.is_or_belongs_to?(assigned_to)

134

else

134

else

135

false

135

false

136

end

136

end

137

else

137

else

138

!self.is_private?

138

!self.is_private?

139

end

139

end

140

end

140

end

141

end

141

end

142

143

# Returns true if user or current user is allowed to edit or add a note to the issue

143

# Returns true if user or current user is allowed to edit or add a note to the issue

144

def editable?(user=User.current)

144

def editable?(user=User.current)

145

user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)

145

user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)

146

end

146

end

147

148

def initialize(attributes=nil, *args)

148

def initialize(attributes=nil, *args)

149

super

149

super

150

if new_record?

150

if new_record?

151

# set default values for new records only

151

# set default values for new records only

152

self.status ||= IssueStatus.default

152

self.status ||= IssueStatus.default

153

self.priority ||= IssuePriority.default

153

self.priority ||= IssuePriority.default

154

self.watcher_user_ids = []

154

self.watcher_user_ids = []

155

end

155

end

156

end

156

end

157

158

def create_or_update

158

def create_or_update

159

super

159

super

160

ensure

160

ensure

161

@status_was = nil

161

@status_was = nil

162

end

162

end

163

private :create_or_update

163

private :create_or_update

164

165

# AR#Persistence#destroy would raise and RecordNotFound exception

165

# AR#Persistence#destroy would raise and RecordNotFound exception

166

# if the issue was already deleted or updated (non matching lock_version).

166

# if the issue was already deleted or updated (non matching lock_version).

167

# This is a problem when bulk deleting issues or deleting a project

167

# This is a problem when bulk deleting issues or deleting a project

168

# (because an issue may already be deleted if its parent was deleted

168

# (because an issue may already be deleted if its parent was deleted

169

# first).

169

# first).

170

# The issue is reloaded by the nested_set before being deleted so

170

# The issue is reloaded by the nested_set before being deleted so

171

# the lock_version condition should not be an issue but we handle it.

171

# the lock_version condition should not be an issue but we handle it.

172

def destroy

172

def destroy

173

super

173

super

174

rescue ActiveRecord::RecordNotFound

174

rescue ActiveRecord::RecordNotFound

175

# Stale or already deleted

175

# Stale or already deleted

176

begin

176

begin

177

reload

177

reload

178

rescue ActiveRecord::RecordNotFound

178

rescue ActiveRecord::RecordNotFound

179

# The issue was actually already deleted

179

# The issue was actually already deleted

180

@destroyed = true

180

@destroyed = true

181

return freeze

181

return freeze

182

end

182

end

183

# The issue was stale, retry to destroy

183

# The issue was stale, retry to destroy

184

super

184

super

185

end

185

end

186

187

def reload(*args)

187

def reload(*args)

188

@workflow_rule_by_attribute = nil

188

@workflow_rule_by_attribute = nil

189

@assignable_versions = nil

189

@assignable_versions = nil

190

@relations = nil

190

super

191

super

191

end

192

end

192

193

# Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields

194

# Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields

194

def available_custom_fields

195

def available_custom_fields

195

(project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []

196

(project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []

196

end

197

end

197

198

# Copies attributes from another issue, arg can be an id or an Issue

199

# Copies attributes from another issue, arg can be an id or an Issue

199

def copy_from(arg, options={})

200

def copy_from(arg, options={})

200

issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)

201

issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)

201

self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")

202

self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")

202

self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}

203

self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}

203

self.status = issue.status

204

self.status = issue.status

204

self.author = User.current

205

self.author = User.current

205

unless options[:attachments] == false

206

unless options[:attachments] == false

206

self.attachments = issue.attachments.map do |attachement|

207

self.attachments = issue.attachments.map do |attachement|

207

attachement.copy(:container => self)

208

attachement.copy(:container => self)

208

end

209

end

209

end

210

end

210

@copied_from = issue

211

@copied_from = issue

211

@copy_options = options

212

@copy_options = options

212

self

213

self

213

end

214

end

214

215

# Returns an unsaved copy of the issue

216

# Returns an unsaved copy of the issue

216

def copy(attributes=nil, copy_options={})

217

def copy(attributes=nil, copy_options={})

217

copy = self.class.new.copy_from(self, copy_options)

218

copy = self.class.new.copy_from(self, copy_options)

218

copy.attributes = attributes if attributes

219

copy.attributes = attributes if attributes

219

copy

220

copy

220

end

221

end

221

222

# Returns true if the issue is a copy

223

# Returns true if the issue is a copy

223

def copy?

224

def copy?

224

@copied_from.present?

225

@copied_from.present?

225

end

226

end

226

227

# Moves/copies an issue to a new project and tracker

228

# Moves/copies an issue to a new project and tracker

228

# Returns the moved/copied issue on success, false on failure

229

# Returns the moved/copied issue on success, false on failure

229

def move_to_project(new_project, new_tracker=nil, options={})

230

def move_to_project(new_project, new_tracker=nil, options={})

230

ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."

231

ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."

231

232

if options[:copy]

233

if options[:copy]

233

issue = self.copy

234

issue = self.copy

234

else

235

else

235

issue = self

236

issue = self

236

end

237

end

237

238

issue.init_journal(User.current, options[:notes])

239

issue.init_journal(User.current, options[:notes])

239

240

# Preserve previous behaviour

241

# Preserve previous behaviour

241

# #move_to_project doesn't change tracker automatically

242

# #move_to_project doesn't change tracker automatically

242

issue.send :project=, new_project, true

243

issue.send :project=, new_project, true

243

if new_tracker

244

if new_tracker

244

issue.tracker = new_tracker

245

issue.tracker = new_tracker

245

end

246

end

246

# Allow bulk setting of attributes on the issue

247

# Allow bulk setting of attributes on the issue

247

if options[:attributes]

248

if options[:attributes]

248

issue.attributes = options[:attributes]

249

issue.attributes = options[:attributes]

249

end

250

end

250

251

issue.save ? issue : false

252

issue.save ? issue : false

252

end

253

end

253

254

def status_id=(sid)

255

def status_id=(sid)

255

self.status = nil

256

self.status = nil

256

result = write_attribute(:status_id, sid)

257

result = write_attribute(:status_id, sid)

257

@workflow_rule_by_attribute = nil

258

@workflow_rule_by_attribute = nil

258

result

259

result

259

end

260

end

260

261

def priority_id=(pid)

262

def priority_id=(pid)

262

self.priority = nil

263

self.priority = nil

263

write_attribute(:priority_id, pid)

264

write_attribute(:priority_id, pid)

264

end

265

end

265

266

def category_id=(cid)

267

def category_id=(cid)

267

self.category = nil

268

self.category = nil

268

write_attribute(:category_id, cid)

269

write_attribute(:category_id, cid)

269

end

270

end

270

271

def fixed_version_id=(vid)

272

def fixed_version_id=(vid)

272

self.fixed_version = nil

273

self.fixed_version = nil

273

write_attribute(:fixed_version_id, vid)

274

write_attribute(:fixed_version_id, vid)

274

end

275

end

275

276

def tracker_id=(tid)

277

def tracker_id=(tid)

277

self.tracker = nil

278

self.tracker = nil

278

result = write_attribute(:tracker_id, tid)

279

result = write_attribute(:tracker_id, tid)

279

@custom_field_values = nil

280

@custom_field_values = nil

280

@workflow_rule_by_attribute = nil

281

@workflow_rule_by_attribute = nil

281

result

282

result

282

end

283

end

283

284

def project_id=(project_id)

285

def project_id=(project_id)

285

if project_id.to_s != self.project_id.to_s

286

if project_id.to_s != self.project_id.to_s

286

self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)

287

self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)

287

end

288

end

288

end

289

end

289

290

def project=(project, keep_tracker=false)

291

def project=(project, keep_tracker=false)

291

project_was = self.project

292

project_was = self.project

292

write_attribute(:project_id, project ? project.id : nil)

293

write_attribute(:project_id, project ? project.id : nil)

293

association_instance_set('project', project)

294

association_instance_set('project', project)

294

if project_was && project && project_was != project

295

if project_was && project && project_was != project

295

@assignable_versions = nil

296

@assignable_versions = nil

296

297

unless keep_tracker || project.trackers.include?(tracker)

298

unless keep_tracker || project.trackers.include?(tracker)

298

self.tracker = project.trackers.first

299

self.tracker = project.trackers.first

299

end

300

end

300

# Reassign to the category with same name if any

301

# Reassign to the category with same name if any

301

if category

302

if category

302

self.category = project.issue_categories.find_by_name(category.name)

303

self.category = project.issue_categories.find_by_name(category.name)

303

end

304

end

304

# Keep the fixed_version if it's still valid in the new_project

305

# Keep the fixed_version if it's still valid in the new_project

305

if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)

306

if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)

306

self.fixed_version = nil

307

self.fixed_version = nil

307

end

308

end

308

# Clear the parent task if it's no longer valid

309

# Clear the parent task if it's no longer valid

309

unless valid_parent_project?

310

unless valid_parent_project?

310

self.parent_issue_id = nil

311

self.parent_issue_id = nil

311

end

312

end

312

@custom_field_values = nil

313

@custom_field_values = nil

313

end

314

end

314

end

315

end

315

316

def description=(arg)

317

def description=(arg)

317

if arg.is_a?(String)

318

if arg.is_a?(String)

318

arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")

319

arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")

319

end

320

end

320

write_attribute(:description, arg)

321

write_attribute(:description, arg)

321

end

322

end

322

323

# Overrides assign_attributes so that project and tracker get assigned first

324

# Overrides assign_attributes so that project and tracker get assigned first

324

def assign_attributes_with_project_and_tracker_first(new_attributes, *args)

325

def assign_attributes_with_project_and_tracker_first(new_attributes, *args)

325

return if new_attributes.nil?

326

return if new_attributes.nil?

326

attrs = new_attributes.dup

327

attrs = new_attributes.dup

327

attrs.stringify_keys!

328

attrs.stringify_keys!

328

329

%w(project project_id tracker tracker_id).each do |attr|

330

%w(project project_id tracker tracker_id).each do |attr|

330

if attrs.has_key?(attr)

331

if attrs.has_key?(attr)

331

send "#{attr}=", attrs.delete(attr)

332

send "#{attr}=", attrs.delete(attr)

332

end

333

end

333

end

334

end

334

send :assign_attributes_without_project_and_tracker_first, attrs, *args

335

send :assign_attributes_without_project_and_tracker_first, attrs, *args

335

end

336

end

336

# Do not redefine alias chain on reload (see #4838)

337

# Do not redefine alias chain on reload (see #4838)

337

alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)

338

alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)

338

339

def estimated_hours=(h)

340

def estimated_hours=(h)

340

write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)

341

write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)

341

end

342

end

342

343

safe_attributes 'project_id',

344

safe_attributes 'project_id',

344

:if => lambda {|issue, user|

345

:if => lambda {|issue, user|

345

if issue.new_record?

346

if issue.new_record?

346

issue.copy?

347

issue.copy?

347

elsif user.allowed_to?(:move_issues, issue.project)

348

elsif user.allowed_to?(:move_issues, issue.project)

348

projects = Issue.allowed_target_projects_on_move(user)

349

projects = Issue.allowed_target_projects_on_move(user)

349

projects.include?(issue.project) && projects.size > 1

350

projects.include?(issue.project) && projects.size > 1

350

end

351

end

351

}

352

}

352

353

safe_attributes 'tracker_id',

354

safe_attributes 'tracker_id',

354

'status_id',

355

'status_id',

355

'category_id',

356

'category_id',

356

'assigned_to_id',

357

'assigned_to_id',

357

'priority_id',

358

'priority_id',

358

'fixed_version_id',

359

'fixed_version_id',

359

'subject',

360

'subject',

360

'description',

361

'description',

361

'start_date',

362

'start_date',

362

'due_date',

363

'due_date',

363

'done_ratio',

364

'done_ratio',

364

'estimated_hours',

365

'estimated_hours',

365

'custom_field_values',

366

'custom_field_values',

366

'custom_fields',

367

'custom_fields',

367

'lock_version',

368

'lock_version',

368

'notes',

369

'notes',

369

:if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }

370

:if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }

370

371

safe_attributes 'status_id',

372

safe_attributes 'status_id',

372

'assigned_to_id',

373

'assigned_to_id',

373

'fixed_version_id',

374

'fixed_version_id',

374

'done_ratio',

375

'done_ratio',

375

'lock_version',

376

'lock_version',

376

'notes',

377

'notes',

377

:if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }

378

:if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }

378

379

safe_attributes 'notes',

380

safe_attributes 'notes',

380

:if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}

381

:if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}

381

382

safe_attributes 'private_notes',

383

safe_attributes 'private_notes',

383

:if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}

384

:if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}

384

385

safe_attributes 'watcher_user_ids',

386

safe_attributes 'watcher_user_ids',

386

:if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}

387

:if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}

387

388

safe_attributes 'is_private',

389

safe_attributes 'is_private',

389

:if => lambda {|issue, user|

390

:if => lambda {|issue, user|

390

user.allowed_to?(:set_issues_private, issue.project) ||

391

user.allowed_to?(:set_issues_private, issue.project) ||

391

(issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))

392

(issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))

392

}

393

}

393

394

safe_attributes 'parent_issue_id',

395

safe_attributes 'parent_issue_id',

395

:if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&

396

:if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&

396

user.allowed_to?(:manage_subtasks, issue.project)}

397

user.allowed_to?(:manage_subtasks, issue.project)}

397

398

def safe_attribute_names(user=nil)

399

def safe_attribute_names(user=nil)

399

names = super

400

names = super

400

names -= disabled_core_fields

401

names -= disabled_core_fields

401

names -= read_only_attribute_names(user)

402

names -= read_only_attribute_names(user)

402

names

403

names

403

end

404

end

404

405

# Safely sets attributes

406

# Safely sets attributes

406

# Should be called from controllers instead of #attributes=

407

# Should be called from controllers instead of #attributes=

407

# attr_accessible is too rough because we still want things like

408

# attr_accessible is too rough because we still want things like

408

# Issue.new(:project => foo) to work

409

# Issue.new(:project => foo) to work

409

def safe_attributes=(attrs, user=User.current)

410

def safe_attributes=(attrs, user=User.current)

410

return unless attrs.is_a?(Hash)

411

return unless attrs.is_a?(Hash)

411

412

attrs = attrs.dup

413

attrs = attrs.dup

413

414

# Project and Tracker must be set before since new_statuses_allowed_to depends on it.

415

# Project and Tracker must be set before since new_statuses_allowed_to depends on it.

415

if (p = attrs.delete('project_id')) && safe_attribute?('project_id')

416

if (p = attrs.delete('project_id')) && safe_attribute?('project_id')

416

if allowed_target_projects(user).collect(&:id).include?(p.to_i)

417

if allowed_target_projects(user).collect(&:id).include?(p.to_i)

417

self.project_id = p

418

self.project_id = p

418

end

419

end

419

end

420

end

420

421

if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')

422

if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')

422

self.tracker_id = t

423

self.tracker_id = t

423

end

424

end

424

425

if (s = attrs.delete('status_id')) && safe_attribute?('status_id')

426

if (s = attrs.delete('status_id')) && safe_attribute?('status_id')

426

if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)

427

if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)

427

self.status_id = s

428

self.status_id = s

428

end

429

end

429

end

430

end

430

431

attrs = delete_unsafe_attributes(attrs, user)

432

attrs = delete_unsafe_attributes(attrs, user)

432

return if attrs.empty?

433

return if attrs.empty?

433

434

unless leaf?

435

unless leaf?

435

attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}

436

attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}

436

end

437

end

437

438

if attrs['parent_issue_id'].present?

439

if attrs['parent_issue_id'].present?

439

s = attrs['parent_issue_id'].to_s

440

s = attrs['parent_issue_id'].to_s

440

unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))

441

unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))

441

@invalid_parent_issue_id = attrs.delete('parent_issue_id')

442

@invalid_parent_issue_id = attrs.delete('parent_issue_id')

442

end

443

end

443

end

444

end

444

445

if attrs['custom_field_values'].present?

446

if attrs['custom_field_values'].present?

446

attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}

447

attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}

447

end

448

end

448

449

if attrs['custom_fields'].present?

450

if attrs['custom_fields'].present?

450

attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}

451

attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}

451

end

452

end

452

453

# mass-assignment security bypass

454

# mass-assignment security bypass

454

assign_attributes attrs, :without_protection => true

455

assign_attributes attrs, :without_protection => true

455

end

456

end

456

457

def disabled_core_fields

458

def disabled_core_fields

458

tracker ? tracker.disabled_core_fields : []

459

tracker ? tracker.disabled_core_fields : []

459

end

460

end

460

461

# Returns the custom_field_values that can be edited by the given user

462

# Returns the custom_field_values that can be edited by the given user

462

def editable_custom_field_values(user=nil)

463

def editable_custom_field_values(user=nil)

463

custom_field_values.reject do |value|

464

custom_field_values.reject do |value|

464

read_only_attribute_names(user).include?(value.custom_field_id.to_s)

465

read_only_attribute_names(user).include?(value.custom_field_id.to_s)

465

end

466

end

466

end

467

end

467

468

# Returns the names of attributes that are read-only for user or the current user

469

# Returns the names of attributes that are read-only for user or the current user

469

# For users with multiple roles, the read-only fields are the intersection of

470

# For users with multiple roles, the read-only fields are the intersection of

470

# read-only fields of each role

471

# read-only fields of each role

471

# The result is an array of strings where sustom fields are represented with their ids

472

# The result is an array of strings where sustom fields are represented with their ids

472

#

473

#

473

# Examples:

474

# Examples:

474

# issue.read_only_attribute_names # => ['due_date', '2']

475

# issue.read_only_attribute_names # => ['due_date', '2']

475

# issue.read_only_attribute_names(user) # => []

476

# issue.read_only_attribute_names(user) # => []

476

def read_only_attribute_names(user=nil)

477

def read_only_attribute_names(user=nil)

477

workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys

478

workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys

478

end

479

end

479

480

# Returns the names of required attributes for user or the current user

481

# Returns the names of required attributes for user or the current user

481

# For users with multiple roles, the required fields are the intersection of

482

# For users with multiple roles, the required fields are the intersection of

482

# required fields of each role

483

# required fields of each role

483

# The result is an array of strings where sustom fields are represented with their ids

484

# The result is an array of strings where sustom fields are represented with their ids

484

#

485

#

485

# Examples:

486

# Examples:

486

# issue.required_attribute_names # => ['due_date', '2']

487

# issue.required_attribute_names # => ['due_date', '2']

487

# issue.required_attribute_names(user) # => []

488

# issue.required_attribute_names(user) # => []

488

def required_attribute_names(user=nil)

489

def required_attribute_names(user=nil)

489

workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys

490

workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys

490

end

491

end

491

492

# Returns true if the attribute is required for user

493

# Returns true if the attribute is required for user

493

def required_attribute?(name, user=nil)

494

def required_attribute?(name, user=nil)

494

required_attribute_names(user).include?(name.to_s)

495

required_attribute_names(user).include?(name.to_s)

495

end

496

end

496

497

# Returns a hash of the workflow rule by attribute for the given user

498

# Returns a hash of the workflow rule by attribute for the given user

498

#

499

#

499

# Examples:

500

# Examples:

500

# issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}

501

# issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}

501

def workflow_rule_by_attribute(user=nil)

502

def workflow_rule_by_attribute(user=nil)

502

return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?

503

return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?

503

504

user_real = user || User.current

505

user_real = user || User.current

505

roles = user_real.admin ? Role.all : user_real.roles_for_project(project)

506

roles = user_real.admin ? Role.all : user_real.roles_for_project(project)

506

return {} if roles.empty?

507

return {} if roles.empty?

507

508

result = {}

509

result = {}

509

workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all

510

workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all

510

if workflow_permissions.any?

511

if workflow_permissions.any?

511

workflow_rules = workflow_permissions.inject({}) do |h, wp|

512

workflow_rules = workflow_permissions.inject({}) do |h, wp|

512

h[wp.field_name] ||= []

513

h[wp.field_name] ||= []

513

h[wp.field_name] << wp.rule

514

h[wp.field_name] << wp.rule

514

h

515

h

515

end

516

end

516

workflow_rules.each do |attr, rules|

517

workflow_rules.each do |attr, rules|

517

next if rules.size < roles.size

518

next if rules.size < roles.size

518

uniq_rules = rules.uniq

519

uniq_rules = rules.uniq

519

if uniq_rules.size == 1

520

if uniq_rules.size == 1

520

result[attr] = uniq_rules.first

521

result[attr] = uniq_rules.first

521

else

522

else

522

result[attr] = 'required'

523

result[attr] = 'required'

523

end

524

end

524

end

525

end

525

end

526

end

526

@workflow_rule_by_attribute = result if user.nil?

527

@workflow_rule_by_attribute = result if user.nil?

527

result

528

result

528

end

529

end

529

private :workflow_rule_by_attribute

530

private :workflow_rule_by_attribute

530

531

def done_ratio

532

def done_ratio

532

if Issue.use_status_for_done_ratio? && status && status.default_done_ratio

533

if Issue.use_status_for_done_ratio? && status && status.default_done_ratio

533

status.default_done_ratio

534

status.default_done_ratio

534

else

535

else

535

read_attribute(:done_ratio)

536

read_attribute(:done_ratio)

536

end

537

end

537

end

538

end

538

539

def self.use_status_for_done_ratio?

540

def self.use_status_for_done_ratio?

540

Setting.issue_done_ratio == 'issue_status'

541

Setting.issue_done_ratio == 'issue_status'

541

end

542

end

542

543

def self.use_field_for_done_ratio?

544

def self.use_field_for_done_ratio?

544

Setting.issue_done_ratio == 'issue_field'

545

Setting.issue_done_ratio == 'issue_field'

545

end

546

end

546

547

def validate_issue

548

def validate_issue

548

if due_date && start_date && due_date < start_date

549

if due_date && start_date && due_date < start_date

549

errors.add :due_date, :greater_than_start_date

550

errors.add :due_date, :greater_than_start_date

550

end

551

end

551

552

if start_date && soonest_start && start_date < soonest_start

553

if start_date && soonest_start && start_date < soonest_start

553

errors.add :start_date, :invalid

554

errors.add :start_date, :invalid

554

end

555

end

555

556

if fixed_version

557

if fixed_version

557

if !assignable_versions.include?(fixed_version)

558

if !assignable_versions.include?(fixed_version)

558

errors.add :fixed_version_id, :inclusion

559

errors.add :fixed_version_id, :inclusion

559

elsif reopened? && fixed_version.closed?

560

elsif reopened? && fixed_version.closed?

560

errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)

561

errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)

561

end

562

end

562

end

563

end

563

564

# Checks that the issue can not be added/moved to a disabled tracker

565

# Checks that the issue can not be added/moved to a disabled tracker

565

if project && (tracker_id_changed? || project_id_changed?)

566

if project && (tracker_id_changed? || project_id_changed?)

566

unless project.trackers.include?(tracker)

567

unless project.trackers.include?(tracker)

567

errors.add :tracker_id, :inclusion

568

errors.add :tracker_id, :inclusion

568

end

569

end

569

end

570

end

570

571

# Checks parent issue assignment

572

# Checks parent issue assignment

572

if @invalid_parent_issue_id.present?

573

if @invalid_parent_issue_id.present?

573

errors.add :parent_issue_id, :invalid

574

errors.add :parent_issue_id, :invalid

574

elsif @parent_issue

575

elsif @parent_issue

575

if !valid_parent_project?(@parent_issue)

576

if !valid_parent_project?(@parent_issue)

576

errors.add :parent_issue_id, :invalid

577

errors.add :parent_issue_id, :invalid

577

elsif !new_record?

578

elsif !new_record?

578

# moving an existing issue

579

# moving an existing issue

579

if @parent_issue.root_id != root_id

580

if @parent_issue.root_id != root_id

580

# we can always move to another tree

581

# we can always move to another tree

581

elsif move_possible?(@parent_issue)

582

elsif move_possible?(@parent_issue)

582

# move accepted inside tree

583

# move accepted inside tree

583

else

584

else

584

errors.add :parent_issue_id, :invalid

585

errors.add :parent_issue_id, :invalid

585

end

586

end

586

end

587

end

587

end

588

end

588

end

589

end

589

590

# Validates the issue against additional workflow requirements

591

# Validates the issue against additional workflow requirements

591

def validate_required_fields

592

def validate_required_fields

592

user = new_record? ? author : current_journal.try(:user)

593

user = new_record? ? author : current_journal.try(:user)

593

594

required_attribute_names(user).each do |attribute|

595

required_attribute_names(user).each do |attribute|

595

if attribute =~ /^\d+$/

596

if attribute =~ /^\d+$/

596

attribute = attribute.to_i

597

attribute = attribute.to_i

597

v = custom_field_values.detect {|v| v.custom_field_id == attribute }

598

v = custom_field_values.detect {|v| v.custom_field_id == attribute }

598

if v && v.value.blank?

599

if v && v.value.blank?

599

errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')

600

errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')

600

end

601

end

601

else

602

else

602

if respond_to?(attribute) && send(attribute).blank?

603

if respond_to?(attribute) && send(attribute).blank?

603

errors.add attribute, :blank

604

errors.add attribute, :blank

604

end

605

end

605

end

606

end

606

end

607

end

607

end

608

end

608

609

# Set the done_ratio using the status if that setting is set. This will keep the done_ratios

610

# Set the done_ratio using the status if that setting is set. This will keep the done_ratios

610

# even if the user turns off the setting later

611

# even if the user turns off the setting later

611

def update_done_ratio_from_issue_status

612

def update_done_ratio_from_issue_status

612

if Issue.use_status_for_done_ratio? && status && status.default_done_ratio

613

if Issue.use_status_for_done_ratio? && status && status.default_done_ratio

613

self.done_ratio = status.default_done_ratio

614

self.done_ratio = status.default_done_ratio

614

end

615

end

615

end

616

end

616

617

def init_journal(user, notes = "")

618

def init_journal(user, notes = "")

618

@current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)

619

@current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)

619

if new_record?

620

if new_record?

620

@current_journal.notify = false

621

@current_journal.notify = false

621

else

622

else

622

@attributes_before_change = attributes.dup

623

@attributes_before_change = attributes.dup

623

@custom_values_before_change = {}

624

@custom_values_before_change = {}

624

self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }

625

self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }

625

end

626

end

626

@current_journal

627

@current_journal

627

end

628

end

628

629

# Returns the id of the last journal or nil

630

# Returns the id of the last journal or nil

630

def last_journal_id

631

def last_journal_id

631

if new_record?

632

if new_record?

632

nil

633

nil

633

else

634

else

634

journals.maximum(:id)

635

journals.maximum(:id)

635

end

636

end

636

end

637

end

637

638

# Returns a scope for journals that have an id greater than journal_id

639

# Returns a scope for journals that have an id greater than journal_id

639

def journals_after(journal_id)

640

def journals_after(journal_id)

640

scope = journals.reorder("#{Journal.table_name}.id ASC")

641

scope = journals.reorder("#{Journal.table_name}.id ASC")

641

if journal_id.present?

642

if journal_id.present?

642

scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)

643

scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)

643

end

644

end

644

scope

645

scope

645

end

646

end

646

647

# Returns the initial status of the issue

648

# Returns the initial status of the issue

648

# Returns nil for a new issue

649

# Returns nil for a new issue

649

def status_was

650

def status_was

650

if status_id_was && status_id_was.to_i > 0

651

if status_id_was && status_id_was.to_i > 0

651

@status_was ||= IssueStatus.find_by_id(status_id_was)

652

@status_was ||= IssueStatus.find_by_id(status_id_was)

652

end

653

end

653

end

654

end

654

655

# Return true if the issue is closed, otherwise false

656

# Return true if the issue is closed, otherwise false

656

def closed?

657

def closed?

657

self.status.is_closed?

658

self.status.is_closed?

658

end

659

end

659

660

# Return true if the issue is being reopened

661

# Return true if the issue is being reopened

661

def reopened?

662

def reopened?

662

if !new_record? && status_id_changed?

663

if !new_record? && status_id_changed?

663

status_was = IssueStatus.find_by_id(status_id_was)

664

status_was = IssueStatus.find_by_id(status_id_was)

664

status_new = IssueStatus.find_by_id(status_id)

665

status_new = IssueStatus.find_by_id(status_id)

665

if status_was && status_new && status_was.is_closed? && !status_new.is_closed?

666

if status_was && status_new && status_was.is_closed? && !status_new.is_closed?

666

return true

667

return true

667

end

668

end

668

end

669

end

669

false

670

false

670

end

671

end

671

672

# Return true if the issue is being closed

673

# Return true if the issue is being closed

673

def closing?

674

def closing?

674

if !new_record? && status_id_changed?

675

if !new_record? && status_id_changed?

675

if status_was && status && !status_was.is_closed? && status.is_closed?

676

if status_was && status && !status_was.is_closed? && status.is_closed?

676

return true

677

return true

677

end

678

end

678

end

679

end

679

false

680

false

680

end

681

end

681

682

# Returns true if the issue is overdue

683

# Returns true if the issue is overdue

683

def overdue?

684

def overdue?

684

!due_date.nil? && (due_date < Date.today) && !status.is_closed?

685

!due_date.nil? && (due_date < Date.today) && !status.is_closed?

685

end

686

end

686

687

# Is the amount of work done less than it should for the due date

688

# Is the amount of work done less than it should for the due date

688

def behind_schedule?

689

def behind_schedule?

689

return false if start_date.nil? || due_date.nil?

690

return false if start_date.nil? || due_date.nil?

690

done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor

691

done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor

691

return done_date <= Date.today

692

return done_date <= Date.today

692

end

693

end

693

694

# Does this issue have children?

695

# Does this issue have children?

695

def children?

696

def children?

696

!leaf?

697

!leaf?

697

end

698

end

698

699

# Users the issue can be assigned to

700

# Users the issue can be assigned to

700

def assignable_users

701

def assignable_users

701

users = project.assignable_users

702

users = project.assignable_users

702

users << author if author

703

users << author if author

703

users << assigned_to if assigned_to

704

users << assigned_to if assigned_to

704

users.uniq.sort

705

users.uniq.sort

705

end

706

end

706

707

# Versions that the issue can be assigned to

708

# Versions that the issue can be assigned to

708

def assignable_versions

709

def assignable_versions

709

return @assignable_versions if @assignable_versions

710

return @assignable_versions if @assignable_versions

710

711

versions = project.shared_versions.open.all

712

versions = project.shared_versions.open.all

712

if fixed_version

713

if fixed_version

713

if fixed_version_id_changed?

714

if fixed_version_id_changed?

714

# nothing to do

715

# nothing to do

715

elsif project_id_changed?

716

elsif project_id_changed?

716

if project.shared_versions.include?(fixed_version)

717

if project.shared_versions.include?(fixed_version)

717

versions << fixed_version

718

versions << fixed_version

718

end

719

end

719

else

720

else

720

versions << fixed_version

721

versions << fixed_version

721

end

722

end

722

end

723

end

723

@assignable_versions = versions.uniq.sort

724

@assignable_versions = versions.uniq.sort

724

end

725

end

725

726

# Returns true if this issue is blocked by another issue that is still open

727

# Returns true if this issue is blocked by another issue that is still open

727

def blocked?

728

def blocked?

728

!relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?

729

!relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?

729

end

730

end

730

731

# Returns an array of statuses that user is able to apply

732

# Returns an array of statuses that user is able to apply

732

def new_statuses_allowed_to(user=User.current, include_default=false)

733

def new_statuses_allowed_to(user=User.current, include_default=false)

733

if new_record? && @copied_from

734

if new_record? && @copied_from

734

[IssueStatus.default, @copied_from.status].compact.uniq.sort

735

[IssueStatus.default, @copied_from.status].compact.uniq.sort

735

else

736

else

736

initial_status = nil

737

initial_status = nil

737

if new_record?

738

if new_record?

738

initial_status = IssueStatus.default

739

initial_status = IssueStatus.default

739

elsif status_id_was

740

elsif status_id_was

740

initial_status = IssueStatus.find_by_id(status_id_was)

741

initial_status = IssueStatus.find_by_id(status_id_was)

741

end

742

end

742

initial_status ||= status

743

initial_status ||= status

743

744

statuses = initial_status.find_new_statuses_allowed_to(

745

statuses = initial_status.find_new_statuses_allowed_to(

745

user.admin ? Role.all : user.roles_for_project(project),

746

user.admin ? Role.all : user.roles_for_project(project),

746

tracker,

747

tracker,

747

author == user,

748

author == user,

748

assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id

749

assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id

749

)

750

)

750

statuses << initial_status unless statuses.empty?

751

statuses << initial_status unless statuses.empty?

751

statuses << IssueStatus.default if include_default

752

statuses << IssueStatus.default if include_default

752

statuses = statuses.compact.uniq.sort

753

statuses = statuses.compact.uniq.sort

753

blocked? ? statuses.reject {|s| s.is_closed?} : statuses

754

blocked? ? statuses.reject {|s| s.is_closed?} : statuses

754

end

755

end

755

end

756

end

756

757

def assigned_to_was

758

def assigned_to_was

758

if assigned_to_id_changed? && assigned_to_id_was.present?

759

if assigned_to_id_changed? && assigned_to_id_was.present?

759

@assigned_to_was ||= User.find_by_id(assigned_to_id_was)

760

@assigned_to_was ||= User.find_by_id(assigned_to_id_was)

760

end

761

end

761

end

762

end

762

763

# Returns the users that should be notified

764

# Returns the users that should be notified

764

def notified_users

765

def notified_users

765

notified = []

766

notified = []

766

# Author and assignee are always notified unless they have been

767

# Author and assignee are always notified unless they have been

767

# locked or don't want to be notified

768

# locked or don't want to be notified

768

notified << author if author

769

notified << author if author

769

if assigned_to

770

if assigned_to

770

notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])

771

notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])

771

end

772

end

772

if assigned_to_was

773

if assigned_to_was

773

notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])

774

notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])

774

end

775

end

775

notified = notified.select {|u| u.active? && u.notify_about?(self)}

776

notified = notified.select {|u| u.active? && u.notify_about?(self)}

776

777

notified += project.notified_users

778

notified += project.notified_users

778

notified.uniq!

779

notified.uniq!

779

# Remove users that can not view the issue

780

# Remove users that can not view the issue

780

notified.reject! {|user| !visible?(user)}

781

notified.reject! {|user| !visible?(user)}

781

notified

782

notified

782

end

783

end

783

784

# Returns the email addresses that should be notified

785

# Returns the email addresses that should be notified

785

def recipients

786

def recipients

786

notified_users.collect(&:mail)

787

notified_users.collect(&:mail)

787

end

788

end

788

789

# Returns the number of hours spent on this issue

790

# Returns the number of hours spent on this issue

790

def spent_hours

791

def spent_hours

791

@spent_hours ||= time_entries.sum(:hours) || 0

792

@spent_hours ||= time_entries.sum(:hours) || 0

792

end

793

end

793

794

# Returns the total number of hours spent on this issue and its descendants

795

# Returns the total number of hours spent on this issue and its descendants

795

#

796

#

796

# Example:

797

# Example:

797

# spent_hours => 0.0

798

# spent_hours => 0.0

798

# spent_hours => 50.2

799

# spent_hours => 50.2

799

def total_spent_hours

800

def total_spent_hours

800

@total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",

801

@total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",

801

:joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0

802

:joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0

802

end

803

end

803

804

def relations

805

def relations

805

@relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)

806

@relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)

806

end

807

end

807

808

# Preloads relations for a collection of issues

809

# Preloads relations for a collection of issues

809

def self.load_relations(issues)

810

def self.load_relations(issues)

810

if issues.any?

811

if issues.any?

811

relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])

812

relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])

812

issues.each do |issue|

813

issues.each do |issue|

813

issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}

814

issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}

814

end

815

end

815

end

816

end

816

end

817

end

817

818

# Preloads visible spent time for a collection of issues

819

# Preloads visible spent time for a collection of issues

819

def self.load_visible_spent_hours(issues, user=User.current)

820

def self.load_visible_spent_hours(issues, user=User.current)

820

if issues.any?

821

if issues.any?

821

hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)

822

hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)

822

issues.each do |issue|

823

issues.each do |issue|

823

issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)

824

issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)

824

end

825

end

825

end

826

end

826

end

827

end

827

828

# Preloads visible relations for a collection of issues

829

# Preloads visible relations for a collection of issues

829

def self.load_visible_relations(issues, user=User.current)

830

def self.load_visible_relations(issues, user=User.current)

830

if issues.any?

831

if issues.any?

831

issue_ids = issues.map(&:id)

832

issue_ids = issues.map(&:id)

832

# Relations with issue_from in given issues and visible issue_to

833

# Relations with issue_from in given issues and visible issue_to

833

relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all

834

relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all

834

# Relations with issue_to in given issues and visible issue_from

835

# Relations with issue_to in given issues and visible issue_from

835

relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all

836

relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all

836

837

issues.each do |issue|

838

issues.each do |issue|

838

relations =

839

relations =

839

relations_from.select {|relation| relation.issue_from_id == issue.id} +

840

relations_from.select {|relation| relation.issue_from_id == issue.id} +

840

relations_to.select {|relation| relation.issue_to_id == issue.id}

841

relations_to.select {|relation| relation.issue_to_id == issue.id}

841

842

issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)

843

issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)

843

end

844

end

844

end

845

end

845

end

846

end

846

847

# Finds an issue relation given its id.

848

# Finds an issue relation given its id.

848

def find_relation(relation_id)

849

def find_relation(relation_id)

849

IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])

850

IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])

850

end

851

end

851

852

def all_dependent_issues(except=[])

853

def all_dependent_issues(except=[])

853

except << self

854

except << self

854

dependencies = []

855

dependencies = []

855

relations_from.each do |relation|

856

relations_from.each do |relation|

856

if relation.issue_to && !except.include?(relation.issue_to)

857

if relation.issue_to && !except.include?(relation.issue_to)

857

dependencies << relation.issue_to

858

dependencies << relation.issue_to

858

dependencies += relation.issue_to.all_dependent_issues(except)

859

dependencies += relation.issue_to.all_dependent_issues(except)

859

end

860

end

860

end

861

end

861

dependencies

862

dependencies

862

end

863

end

863

864

# Returns an array of issues that duplicate this one

865

# Returns an array of issues that duplicate this one

865

def duplicates

866

def duplicates

866

relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}

867

relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}

867

end

868

end

868

869

# Returns the due date or the target due date if any

870

# Returns the due date or the target due date if any

870

# Used on gantt chart

871

# Used on gantt chart

871

def due_before

872

def due_before

872

due_date || (fixed_version ? fixed_version.effective_date : nil)

873

due_date || (fixed_version ? fixed_version.effective_date : nil)

873

end

874

end

874

875

# Returns the time scheduled for this issue.

876

# Returns the time scheduled for this issue.

876

#

877

#

877

# Example:

878

# Example:

878

# Start Date: 2/26/09, End Date: 3/04/09

879

# Start Date: 2/26/09, End Date: 3/04/09

879

# duration => 6

880

# duration => 6

880

def duration

881

def duration

881

(start_date && due_date) ? due_date - start_date : 0

882

(start_date && due_date) ? due_date - start_date : 0

882

end

883

end

883

884

# Returns the duration in working days

885

# Returns the duration in working days

885

def working_duration

886

def working_duration

886

(start_date && due_date) ? working_days(start_date, due_date) : 0

887

(start_date && due_date) ? working_days(start_date, due_date) : 0

887

end

888

end

888

889

def soonest_start(reload=false)

890

def soonest_start(reload=false)

890

@soonest_start = nil if reload

891

@soonest_start = nil if reload

891

@soonest_start ||= (

892

@soonest_start ||= (

892

relations_to(reload).collect{|relation| relation.successor_soonest_start} +

893

relations_to(reload).collect{|relation| relation.successor_soonest_start} +

893

ancestors.collect(&:soonest_start)

894

ancestors.collect(&:soonest_start)

894

).compact.max

895

).compact.max

895

end

896

end

896

897

# Sets start_date on the given date or the next working day

898

# Sets start_date on the given date or the next working day

898

# and changes due_date to keep the same working duration.

899

# and changes due_date to keep the same working duration.

899

def reschedule_on(date)

900

def reschedule_on(date)

900

wd = working_duration

901

wd = working_duration

901

date = next_working_date(date)

902

date = next_working_date(date)

902

self.start_date = date

903

self.start_date = date

903

self.due_date = add_working_days(date, wd)

904

self.due_date = add_working_days(date, wd)

904

end

905

end

905

906

# Reschedules the issue on the given date or the next working day and saves the record.

907

# Reschedules the issue on the given date or the next working day and saves the record.

907

# If the issue is a parent task, this is done by rescheduling its subtasks.

908

# If the issue is a parent task, this is done by rescheduling its subtasks.

908

def reschedule_on!(date)

909

def reschedule_on!(date)

909

return if date.nil?

910

return if date.nil?

910

if leaf?

911

if leaf?

911

if start_date.nil? || start_date != date

912

if start_date.nil? || start_date != date

912

if start_date && start_date > date

913

if start_date && start_date > date

913

# Issue can not be moved earlier than its soonest start date

914

# Issue can not be moved earlier than its soonest start date

914

date = [soonest_start(true), date].compact.max

915

date = [soonest_start(true), date].compact.max

915

end

916

end

916

reschedule_on(date)

917

reschedule_on(date)

917

begin

918

begin

918

save

919

save

919

rescue ActiveRecord::StaleObjectError

920

rescue ActiveRecord::StaleObjectError

920

reload

921

reload

921

reschedule_on(date)

922

reschedule_on(date)

922

save

923

save

923

end

924

end

924

end

925

end

925

else

926

else

926

leaves.each do |leaf|

927

leaves.each do |leaf|

927

if leaf.start_date

928

if leaf.start_date

928

# Only move subtask if it starts at the same date as the parent

929

# Only move subtask if it starts at the same date as the parent

929

# or if it starts before the given date

930

# or if it starts before the given date

930

if start_date == leaf.start_date || date > leaf.start_date

931

if start_date == leaf.start_date || date > leaf.start_date

931

leaf.reschedule_on!(date)

932

leaf.reschedule_on!(date)

932

end

933

end

933

else

934

else

934

leaf.reschedule_on!(date)

935

leaf.reschedule_on!(date)

935

end

936

end

936

end

937

end

937

end

938

end

938

end

939

end

939

940

def <=>(issue)

941

def <=>(issue)

941

if issue.nil?

942

if issue.nil?

942

-1

943

-1

943

elsif root_id != issue.root_id

944

elsif root_id != issue.root_id

944

(root_id || 0) <=> (issue.root_id || 0)

945

(root_id || 0) <=> (issue.root_id || 0)

945

else

946

else

946

(lft || 0) <=> (issue.lft || 0)

947

(lft || 0) <=> (issue.lft || 0)

947

end

948

end

948

end

949

end

949

950

def to_s

951

def to_s

951

"#{tracker} ##{id}: #{subject}"

952

"#{tracker} ##{id}: #{subject}"

952

end

953

end

953

954

# Returns a string of css classes that apply to the issue

955

# Returns a string of css classes that apply to the issue

955

def css_classes

956

def css_classes

956

s = "issue status-#{status_id} #{priority.try(:css_classes)}"

957

s = "issue status-#{status_id} #{priority.try(:css_classes)}"

957

s << ' closed' if closed?

958

s << ' closed' if closed?

958

s << ' overdue' if overdue?

959

s << ' overdue' if overdue?

959

s << ' child' if child?

960

s << ' child' if child?

960

s << ' parent' unless leaf?

961

s << ' parent' unless leaf?

961

s << ' private' if is_private?

962

s << ' private' if is_private?

962

s << ' created-by-me' if User.current.logged? && author_id == User.current.id

963

s << ' created-by-me' if User.current.logged? && author_id == User.current.id

963

s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id

964

s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id

964

s

965

s

965

end

966

end

966

967

# Saves an issue and a time_entry from the parameters

968

# Saves an issue and a time_entry from the parameters

968

def save_issue_with_child_records(params, existing_time_entry=nil)

969

def save_issue_with_child_records(params, existing_time_entry=nil)

969

Issue.transaction do

970

Issue.transaction do

970

if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)

971

if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)

971

@time_entry = existing_time_entry || TimeEntry.new

972

@time_entry = existing_time_entry || TimeEntry.new

972

@time_entry.project = project

973

@time_entry.project = project

973

@time_entry.issue = self

974

@time_entry.issue = self

974

@time_entry.user = User.current

975

@time_entry.user = User.current

975

@time_entry.spent_on = User.current.today

976

@time_entry.spent_on = User.current.today

976

@time_entry.attributes = params[:time_entry]

977

@time_entry.attributes = params[:time_entry]

977

self.time_entries << @time_entry

978

self.time_entries << @time_entry

978

end

979

end

979

980

# TODO: Rename hook

981

# TODO: Rename hook

981

Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})

982

Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})

982

if save

983

if save

983

# TODO: Rename hook

984

# TODO: Rename hook

984

Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})

985

Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})

985

else

986

else

986

raise ActiveRecord::Rollback

987

raise ActiveRecord::Rollback

987

end

988

end

988

end

989

end

989

end

990

end

990

991

# Unassigns issues from +version+ if it's no longer shared with issue's project

992

# Unassigns issues from +version+ if it's no longer shared with issue's project

992

def self.update_versions_from_sharing_change(version)

993

def self.update_versions_from_sharing_change(version)

993

# Update issues assigned to the version

994

# Update issues assigned to the version

994

update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])

995

update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])

995

end

996

end

996

997

# Unassigns issues from versions that are no longer shared

998

# Unassigns issues from versions that are no longer shared

998

# after +project+ was moved

999

# after +project+ was moved

999

def self.update_versions_from_hierarchy_change(project)

1000

def self.update_versions_from_hierarchy_change(project)

1000

moved_project_ids = project.self_and_descendants.reload.collect(&:id)

1001

moved_project_ids = project.self_and_descendants.reload.collect(&:id)

1001

# Update issues of the moved projects and issues assigned to a version of a moved project

1002

# Update issues of the moved projects and issues assigned to a version of a moved project

1002

Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])

1003

Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])

1003

end

1004

end

1004

1005

def parent_issue_id=(arg)

1006

def parent_issue_id=(arg)

1006

s = arg.to_s.strip.presence

1007

s = arg.to_s.strip.presence

1007

if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))

1008

if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))

1008

@parent_issue.id

1009

@parent_issue.id

1009

else

1010

else

1010

@parent_issue = nil

1011

@parent_issue = nil

1011

@invalid_parent_issue_id = arg

1012

@invalid_parent_issue_id = arg

1012

end

1013

end

1013

end

1014

end

1014

1015

def parent_issue_id

1016

def parent_issue_id

1016

if @invalid_parent_issue_id

1017

if @invalid_parent_issue_id

1017

@invalid_parent_issue_id

1018

@invalid_parent_issue_id

1018

elsif instance_variable_defined? :@parent_issue

1019

elsif instance_variable_defined? :@parent_issue

1019

@parent_issue.nil? ? nil : @parent_issue.id

1020

@parent_issue.nil? ? nil : @parent_issue.id

1020

else

1021

else

1021

parent_id

1022

parent_id

1022

end

1023

end

1023

end

1024

end

1024

1025

# Returns true if issue's project is a valid

1026

# Returns true if issue's project is a valid

1026

# parent issue project

1027

# parent issue project

1027

def valid_parent_project?(issue=parent)

1028

def valid_parent_project?(issue=parent)

1028

return true if issue.nil? || issue.project_id == project_id

1029

return true if issue.nil? || issue.project_id == project_id

1029

1030

case Setting.cross_project_subtasks

1031

case Setting.cross_project_subtasks

1031

when 'system'

1032

when 'system'

1032

true

1033

true

1033

when 'tree'

1034

when 'tree'

1034

issue.project.root == project.root

1035

issue.project.root == project.root

1035

when 'hierarchy'

1036

when 'hierarchy'

1036

issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)

1037

issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)

1037

when 'descendants'

1038

when 'descendants'

1038

issue.project.is_or_is_ancestor_of?(project)

1039

issue.project.is_or_is_ancestor_of?(project)

1039

else

1040

else

1040

false

1041

false

1041

end

1042

end

1042

end

1043

end

1043

1044

# Extracted from the ReportsController.

1045

# Extracted from the ReportsController.

1045

def self.by_tracker(project)

1046

def self.by_tracker(project)

1046

count_and_group_by(:project => project,

1047

count_and_group_by(:project => project,

1047

:field => 'tracker_id',

1048

:field => 'tracker_id',

1048

:joins => Tracker.table_name)

1049

:joins => Tracker.table_name)

1049

end

1050

end

1050

1051

def self.by_version(project)

1052

def self.by_version(project)

1052

count_and_group_by(:project => project,

1053

count_and_group_by(:project => project,

1053

:field => 'fixed_version_id',

1054

:field => 'fixed_version_id',

1054

:joins => Version.table_name)

1055

:joins => Version.table_name)

1055

end

1056

end

1056

1057

def self.by_priority(project)

1058

def self.by_priority(project)

1058

count_and_group_by(:project => project,

1059

count_and_group_by(:project => project,

1059

:field => 'priority_id',

1060

:field => 'priority_id',

1060

:joins => IssuePriority.table_name)

1061

:joins => IssuePriority.table_name)

1061

end

1062

end

1062

1063

def self.by_category(project)

1064

def self.by_category(project)

1064

count_and_group_by(:project => project,

1065

count_and_group_by(:project => project,

1065

:field => 'category_id',

1066

:field => 'category_id',

1066

:joins => IssueCategory.table_name)

1067

:joins => IssueCategory.table_name)

1067

end

1068

end

1068

1069

def self.by_assigned_to(project)

1070

def self.by_assigned_to(project)

1070

count_and_group_by(:project => project,

1071

count_and_group_by(:project => project,

1071

:field => 'assigned_to_id',

1072

:field => 'assigned_to_id',

1072

:joins => User.table_name)

1073

:joins => User.table_name)

1073

end

1074

end

1074

1075

def self.by_author(project)

1076

def self.by_author(project)

1076

count_and_group_by(:project => project,

1077

count_and_group_by(:project => project,

1077

:field => 'author_id',

1078

:field => 'author_id',

1078

:joins => User.table_name)

1079

:joins => User.table_name)

1079

end

1080

end

1080

1081

def self.by_subproject(project)

1082

def self.by_subproject(project)

1082

ActiveRecord::Base.connection.select_all("select s.id as status_id,

1083

ActiveRecord::Base.connection.select_all("select s.id as status_id,

1083

s.is_closed as closed,

1084

s.is_closed as closed,

1084

#{Issue.table_name}.project_id as project_id,

1085

#{Issue.table_name}.project_id as project_id,

1085

count(#{Issue.table_name}.id) as total

1086

count(#{Issue.table_name}.id) as total

1086

from

1087

from

1087

#{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s

1088

#{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s

1088

where

1089

where

1089

#{Issue.table_name}.status_id=s.id

1090

#{Issue.table_name}.status_id=s.id

1090

and #{Issue.table_name}.project_id = #{Project.table_name}.id

1091

and #{Issue.table_name}.project_id = #{Project.table_name}.id

1091

and #{visible_condition(User.current, :project => project, :with_subprojects => true)}

1092

and #{visible_condition(User.current, :project => project, :with_subprojects => true)}

1092

and #{Issue.table_name}.project_id <> #{project.id}

1093

and #{Issue.table_name}.project_id <> #{project.id}

1093

group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?

1094

group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?

1094

end

1095

end

1095

# End ReportsController extraction

1096

# End ReportsController extraction

1096

1097

# Returns an array of projects that user can assign the issue to

1098

# Returns an array of projects that user can assign the issue to

1098

def allowed_target_projects(user=User.current)

1099

def allowed_target_projects(user=User.current)

1099

if new_record?

1100

if new_record?

1100

Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))

1101

Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))

1101

else

1102

else

1102

self.class.allowed_target_projects_on_move(user)

1103

self.class.allowed_target_projects_on_move(user)

1103

end

1104

end

1104

end

1105

end

1105

1106

# Returns an array of projects that user can move issues to

1107

# Returns an array of projects that user can move issues to

1107

def self.allowed_target_projects_on_move(user=User.current)

1108

def self.allowed_target_projects_on_move(user=User.current)

1108

Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))

1109

Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))

1109

end

1110

end

1110

1111

private

1112

private

1112

1113

def after_project_change

1114

def after_project_change

1114

# Update project_id on related time entries

1115

# Update project_id on related time entries

1115

TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})

1116

TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})

1116

1117

# Delete issue relations

1118

# Delete issue relations

1118

unless Setting.cross_project_issue_relations?

1119

unless Setting.cross_project_issue_relations?

1119

relations_from.clear

1120

relations_from.clear

1120

relations_to.clear

1121

relations_to.clear

1121

end

1122

end

1122

1123

# Move subtasks that were in the same project

1124

# Move subtasks that were in the same project

1124

children.each do |child|

1125

children.each do |child|

1125

next unless child.project_id == project_id_was

1126

next unless child.project_id == project_id_was

1126

# Change project and keep project

1127

# Change project and keep project

1127

child.send :project=, project, true

1128

child.send :project=, project, true

1128

unless child.save

1129

unless child.save

1129

raise ActiveRecord::Rollback

1130

raise ActiveRecord::Rollback

1130

end

1131

end

1131

end

1132

end

1132

end

1133

end

1133

1134

# Callback for after the creation of an issue by copy

1135

# Callback for after the creation of an issue by copy

1135

# * adds a "copied to" relation with the copied issue

1136

# * adds a "copied to" relation with the copied issue

1136

# * copies subtasks from the copied issue

1137

# * copies subtasks from the copied issue

1137

def after_create_from_copy

1138

def after_create_from_copy

1138

return unless copy? && !@after_create_from_copy_handled

1139

return unless copy? && !@after_create_from_copy_handled

1139

1140

if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false

1141

if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false

1141

relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)

1142

relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)

1142

unless relation.save

1143

unless relation.save

1143

logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger

1144

logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger

1144

end

1145

end

1145

end

1146

end

1146

1147

unless @copied_from.leaf? || @copy_options[:subtasks] == false

1148

unless @copied_from.leaf? || @copy_options[:subtasks] == false

1148

@copied_from.children.each do |child|

1149

@copied_from.children.each do |child|

1149

unless child.visible?

1150

unless child.visible?

1150

# Do not copy subtasks that are not visible to avoid potential disclosure of private data

1151

# Do not copy subtasks that are not visible to avoid potential disclosure of private data

1151

logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger

1152

logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger

1152

end

1154

end

1154

copy = Issue.new.copy_from(child, @copy_options)

1155

copy = Issue.new.copy_from(child, @copy_options)

1155

copy.author = author

1156

copy.author = author

1156

copy.project = project

1157

copy.project = project

1157

copy.parent_issue_id = id

1158

copy.parent_issue_id = id

1158

# Children subtasks are copied recursively

1159

# Children subtasks are copied recursively

1159

unless copy.save

1160

unless copy.save

1160

logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger

1161

logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger

1161

end

1162

end

1162

end

1163

end

1163

end

1164

end

1164

@after_create_from_copy_handled = true

1165

@after_create_from_copy_handled = true

1165

end

1166

end

1166

1167

def update_nested_set_attributes

1168

def update_nested_set_attributes

1168

if root_id.nil?

1169

if root_id.nil?

1169

# issue was just created

1170

# issue was just created

1170

self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)

1171

self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)

1171

set_default_left_and_right

1172

set_default_left_and_right

1172

Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])

1173

Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])

1173

if @parent_issue

1174

if @parent_issue

1174

move_to_child_of(@parent_issue)

1175

move_to_child_of(@parent_issue)

1175

end

1176

end

1176

reload

1177

reload

1177

elsif parent_issue_id != parent_id

1178

elsif parent_issue_id != parent_id

1178

former_parent_id = parent_id

1179

former_parent_id = parent_id

1179

# moving an existing issue

1180

# moving an existing issue

1180

if @parent_issue && @parent_issue.root_id == root_id

1181

if @parent_issue && @parent_issue.root_id == root_id

1181

# inside the same tree

1182

# inside the same tree

1182

move_to_child_of(@parent_issue)

1183

move_to_child_of(@parent_issue)

1183

else

1184

else

1184

# to another tree

1185

# to another tree

1185

unless root?

1186

unless root?

1186

move_to_right_of(root)

1187

move_to_right_of(root)

1187

reload

1188

reload

1188

end

1189

end

1189

old_root_id = root_id

1190

old_root_id = root_id

1190

self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )

1191

self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )

1191

target_maxright = nested_set_scope.maximum(right_column_name) || 0

1192

target_maxright = nested_set_scope.maximum(right_column_name) || 0

1192

offset = target_maxright + 1 - lft

1193

offset = target_maxright + 1 - lft

1193

Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",

1194

Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",

1194

["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])

1195

["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])

1195

self[left_column_name] = lft + offset

1196

self[left_column_name] = lft + offset

1196

self[right_column_name] = rgt + offset

1197

self[right_column_name] = rgt + offset

1197

if @parent_issue

1198

if @parent_issue

1198

move_to_child_of(@parent_issue)

1199

move_to_child_of(@parent_issue)

1199

end

1200

end

1200

end

1201

end

1201

reload

1202

reload

1202

# delete invalid relations of all descendants

1203

# delete invalid relations of all descendants

1203

self_and_descendants.each do |issue|

1204

self_and_descendants.each do |issue|

1204

issue.relations.each do |relation|

1205

issue.relations.each do |relation|

1205

relation.destroy unless relation.valid?

1206

relation.destroy unless relation.valid?

1206

end

1207

end

1207

end

1208

end

1208

# update former parent

1209

# update former parent

1209

recalculate_attributes_for(former_parent_id) if former_parent_id

1210

recalculate_attributes_for(former_parent_id) if former_parent_id

1210

end

1211

end

1211

remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)

1212

remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)

1212

end

1213

end

1213

1214

def update_parent_attributes

1215

def update_parent_attributes

1215

recalculate_attributes_for(parent_id) if parent_id

1216

recalculate_attributes_for(parent_id) if parent_id

1216

end

1217

end

1217

1218

def recalculate_attributes_for(issue_id)

1219

def recalculate_attributes_for(issue_id)

1219

if issue_id && p = Issue.find_by_id(issue_id)

1220

if issue_id && p = Issue.find_by_id(issue_id)

1220

# priority = highest priority of children

1221

# priority = highest priority of children

1221

if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)

1222

if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)

1222

p.priority = IssuePriority.find_by_position(priority_position)

1223

p.priority = IssuePriority.find_by_position(priority_position)

1223

end

1224

end

1224

1225

# start/due dates = lowest/highest dates of children

1226

# start/due dates = lowest/highest dates of children

1226

p.start_date = p.children.minimum(:start_date)

1227

p.start_date = p.children.minimum(:start_date)

1227

p.due_date = p.children.maximum(:due_date)

1228

p.due_date = p.children.maximum(:due_date)

1228

if p.start_date && p.due_date && p.due_date < p.start_date

1229

if p.start_date && p.due_date && p.due_date < p.start_date

1229

p.start_date, p.due_date = p.due_date, p.start_date

1230

p.start_date, p.due_date = p.due_date, p.start_date

1230

end

1231

end

1231

1232

# done ratio = weighted average ratio of leaves

1233

# done ratio = weighted average ratio of leaves

1233

unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio

1234

unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio

1234

leaves_count = p.leaves.count

1235

leaves_count = p.leaves.count

1235

if leaves_count > 0

1236

if leaves_count > 0

1236

average = p.leaves.average(:estimated_hours).to_f

1237

average = p.leaves.average(:estimated_hours).to_f

1237

if average == 0

1238

if average == 0

1238

average = 1

1239

average = 1

1239

end

1240

end

1240

done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f

1241

done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f

1241

progress = done / (average * leaves_count)

1242

progress = done / (average * leaves_count)

1242

p.done_ratio = progress.round

1243

p.done_ratio = progress.round

1243

end

1244

end

1244

end

1245

end

1245

1246

# estimate = sum of leaves estimates

1247

# estimate = sum of leaves estimates

1247

p.estimated_hours = p.leaves.sum(:estimated_hours).to_f

1248

p.estimated_hours = p.leaves.sum(:estimated_hours).to_f

1248

p.estimated_hours = nil if p.estimated_hours == 0.0

1249

p.estimated_hours = nil if p.estimated_hours == 0.0

1249

1250

# ancestors will be recursively updated

1251

# ancestors will be recursively updated

1251

p.save(:validate => false)

1252

p.save(:validate => false)

1252

end

1253

end

1253

end

1254

end

1254

1255

# Update issues so their versions are not pointing to a

1256

# Update issues so their versions are not pointing to a

1256

# fixed_version that is not shared with the issue's project

1257

# fixed_version that is not shared with the issue's project

1257

def self.update_versions(conditions=nil)

1258

def self.update_versions(conditions=nil)

1258

# Only need to update issues with a fixed_version from

1259

# Only need to update issues with a fixed_version from

1259

# a different project and that is not systemwide shared

1260

# a different project and that is not systemwide shared

1260

Issue.scoped(:conditions => conditions).all(

1261

Issue.scoped(:conditions => conditions).all(

1261

:conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +

1262

:conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +

1262

" AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +

1263

" AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +

1263

" AND #{Version.table_name}.sharing <> 'system'",

1264

" AND #{Version.table_name}.sharing <> 'system'",

1264

:include => [:project, :fixed_version]

1265

:include => [:project, :fixed_version]

1265

).each do |issue|

1266

).each do |issue|

1266

next if issue.project.nil? || issue.fixed_version.nil?

1267

next if issue.project.nil? || issue.fixed_version.nil?

1267

unless issue.project.shared_versions.include?(issue.fixed_version)

1268

unless issue.project.shared_versions.include?(issue.fixed_version)

1268

issue.init_journal(User.current)

1269

issue.init_journal(User.current)

1269

issue.fixed_version = nil

1270

issue.fixed_version = nil

1270

issue.save

1271

issue.save

1271

end

1272

end

1272

end

1273

end

1273

end

1274

end

1274

1275

# Callback on file attachment

1276

# Callback on file attachment

1276

def attachment_added(obj)

1277

def attachment_added(obj)

1277

if @current_journal && !obj.new_record?

1278

if @current_journal && !obj.new_record?

1278

@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)

1279

@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)

1279

end

1280

end

1280

end

1281

end

1281

1282

# Callback on attachment deletion

1283

# Callback on attachment deletion

1283

def attachment_removed(obj)

1284

def attachment_removed(obj)

1284

if @current_journal && !obj.new_record?

1285

if @current_journal && !obj.new_record?

1285

@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)

1286

@current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)

1286

@current_journal.save

1287

@current_journal.save

1287

end

1288

end

1288

end

1289

end

1289

1290

# Default assignment based on category

1291

# Default assignment based on category

1291

def default_assign

1292

def default_assign

1292

if assigned_to.nil? && category && category.assigned_to

1293

if assigned_to.nil? && category && category.assigned_to

1293

self.assigned_to = category.assigned_to

1294

self.assigned_to = category.assigned_to

1294

end

1295

end

1295

end

1296

end

1296

1297

# Updates start/due dates of following issues

1298

# Updates start/due dates of following issues

1298

def reschedule_following_issues

1299

def reschedule_following_issues

1299

if start_date_changed? || due_date_changed?

1300

if start_date_changed? || due_date_changed?

1300

relations_from.each do |relation|

1301

relations_from.each do |relation|

1301

relation.set_issue_to_dates

1302

relation.set_issue_to_dates

1302

end

1303

end

1303

end

1304

end

1304

end

1305

end

1305

1306

# Closes duplicates if the issue is being closed

1307

# Closes duplicates if the issue is being closed

1307

def close_duplicates

1308

def close_duplicates

1308

if closing?

1309

if closing?

1309

duplicates.each do |duplicate|

1310

duplicates.each do |duplicate|

1310

# Reload is need in case the duplicate was updated by a previous duplicate

1311

# Reload is need in case the duplicate was updated by a previous duplicate

1311

duplicate.reload

1312

duplicate.reload

1312

# Don't re-close it if it's already closed

1313

# Don't re-close it if it's already closed

1313

next if duplicate.closed?

1314

next if duplicate.closed?

1314

# Same user and notes

1315

# Same user and notes

1315

if @current_journal

1316

if @current_journal

1316

duplicate.init_journal(@current_journal.user, @current_journal.notes)

1317

duplicate.init_journal(@current_journal.user, @current_journal.notes)

1317

end

1318

end

1318

duplicate.update_attribute :status, self.status

1319

duplicate.update_attribute :status, self.status

1319

end

1320

end

1320

end

1321

end

1321

end

1322

end

1322

1323

# Make sure updated_on is updated when adding a note and set updated_on now

1324

# Make sure updated_on is updated when adding a note and set updated_on now

1324

# so we can set closed_on with the same value on closing

1325

# so we can set closed_on with the same value on closing

1325

def force_updated_on_change

1326

def force_updated_on_change

1326

if @current_journal || changed?

1327

if @current_journal || changed?

1327

self.updated_on = current_time_from_proper_timezone

1328

self.updated_on = current_time_from_proper_timezone

1328

if new_record?

1329

if new_record?

1329

self.created_on = updated_on

1330

self.created_on = updated_on

1330

end

1331

end

1331

end

1332

end

1332

end

1333

end

1333

1334

# Callback for setting closed_on when the issue is closed.

1335

# Callback for setting closed_on when the issue is closed.

1335

# The closed_on attribute stores the time of the last closing

1336

# The closed_on attribute stores the time of the last closing

1336

# and is preserved when the issue is reopened.

1337

# and is preserved when the issue is reopened.

1337

def update_closed_on

1338

def update_closed_on

1338

if closing? || (new_record? && closed?)

1339

if closing? || (new_record? && closed?)

1339

self.closed_on = updated_on

1340

self.closed_on = updated_on

1340

end

1341

end

1341

end

1342

end

1342

1343

# Saves the changes in a Journal

1344

# Saves the changes in a Journal

1344

# Called after_save

1345

# Called after_save

1345

def create_journal

1346

def create_journal

1346

if @current_journal

1347

if @current_journal

1347

# attributes changes

1348

# attributes changes

1348

if @attributes_before_change

1349

if @attributes_before_change

1349

(Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|

1350

(Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|

1350

before = @attributes_before_change[c]

1351

before = @attributes_before_change[c]

1351

after = send(c)

1352

after = send(c)

1352

next if before == after || (before.blank? && after.blank?)

1353

next if before == after || (before.blank? && after.blank?)

1353

@current_journal.details << JournalDetail.new(:property => 'attr',

1354

@current_journal.details << JournalDetail.new(:property => 'attr',

1354

:prop_key => c,

1355

:prop_key => c,

1355

:old_value => before,

1356

:old_value => before,

1356

:value => after)

1357

:value => after)

1357

}

1358

}

1358

end

1359

end

1359

if @custom_values_before_change

1360

if @custom_values_before_change

1360

# custom fields changes

1361

# custom fields changes

1361

custom_field_values.each {|c|

1362

custom_field_values.each {|c|

1362

before = @custom_values_before_change[c.custom_field_id]

1363

before = @custom_values_before_change[c.custom_field_id]

1363

after = c.value

1364

after = c.value

1364

next if before == after || (before.blank? && after.blank?)

1365

next if before == after || (before.blank? && after.blank?)

1365

1366

if before.is_a?(Array) || after.is_a?(Array)

1367

if before.is_a?(Array) || after.is_a?(Array)

1367

before = [before] unless before.is_a?(Array)

1368

before = [before] unless before.is_a?(Array)

1368

after = [after] unless after.is_a?(Array)

1369

after = [after] unless after.is_a?(Array)

1369

1370

# values removed

1371

# values removed

1371

(before - after).reject(&:blank?).each do |value|

1372

(before - after).reject(&:blank?).each do |value|

1372

@current_journal.details << JournalDetail.new(:property => 'cf',

1373

@current_journal.details << JournalDetail.new(:property => 'cf',

1373

:prop_key => c.custom_field_id,

1374

:prop_key => c.custom_field_id,

1374

:old_value => value,

1375

:old_value => value,

1375

:value => nil)

1376

:value => nil)

1376

end

1377

end

1377

# values added

1378

# values added

1378

(after - before).reject(&:blank?).each do |value|

1379

(after - before).reject(&:blank?).each do |value|

1379

@current_journal.details << JournalDetail.new(:property => 'cf',

1380

@current_journal.details << JournalDetail.new(:property => 'cf',

1380

:prop_key => c.custom_field_id,

1381

:prop_key => c.custom_field_id,

1381

:old_value => nil,

1382

:old_value => nil,

1382

:value => value)

1383

:value => value)

1383

end

1384

end

1384

else

1385

else

1385

@current_journal.details << JournalDetail.new(:property => 'cf',

1386

@current_journal.details << JournalDetail.new(:property => 'cf',

1386

:prop_key => c.custom_field_id,

1387

:prop_key => c.custom_field_id,

1387

:old_value => before,

1388

:old_value => before,

1388

:value => after)

1389

:value => after)

1389

end

1390

end

1390

}

1391

}

1391

end

1392

end

1392

@current_journal.save

1393

@current_journal.save

1393

# reset current journal

1394

# reset current journal

1394

init_journal @current_journal.user, @current_journal.notes

1395

init_journal @current_journal.user, @current_journal.notes

1395

end

1396

end

1396

end

1397

end

1397

1398

# Query generator for selecting groups of issue counts for a project

1399

# Query generator for selecting groups of issue counts for a project

1399

# based on specific criteria

1400

# based on specific criteria

1400

#

1401

#

1401

# Options

1402

# Options

1402

# * project - Project to search in.

1403

# * project - Project to search in.

1403

# * field - String. Issue field to key off of in the grouping.

1404

# * field - String. Issue field to key off of in the grouping.

1404

# * joins - String. The table name to join against.

1405

# * joins - String. The table name to join against.

1405

def self.count_and_group_by(options)

1406

def self.count_and_group_by(options)

1406

project = options.delete(:project)

1407

project = options.delete(:project)

1407

select_field = options.delete(:field)

1408

select_field = options.delete(:field)

1408

joins = options.delete(:joins)

1409

joins = options.delete(:joins)

1409

1410

where = "#{Issue.table_name}.#{select_field}=j.id"

1411

where = "#{Issue.table_name}.#{select_field}=j.id"

1411

1412

ActiveRecord::Base.connection.select_all("select s.id as status_id,

1413

ActiveRecord::Base.connection.select_all("select s.id as status_id,

1413

s.is_closed as closed,

1414

s.is_closed as closed,

1414

j.id as #{select_field},

1415

j.id as #{select_field},

1415

count(#{Issue.table_name}.id) as total

1416

count(#{Issue.table_name}.id) as total

1416

from

1417

from

1417

#{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j

1418

#{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j

1418

where

1419

where

1419

#{Issue.table_name}.status_id=s.id

1420

#{Issue.table_name}.status_id=s.id

1420

and #{where}

1421

and #{where}

1421

and #{Issue.table_name}.project_id=#{Project.table_name}.id

1422

and #{Issue.table_name}.project_id=#{Project.table_name}.id

1422

and #{visible_condition(User.current, :project => project)}

1423

and #{visible_condition(User.current, :project => project)}

1423

group by s.id, s.is_closed, j.id")

1424

group by s.id, s.is_closed, j.id")

1424

end

1425

end

1425

end

1426

end

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages

             # Redmine - project management software
             # Copyright (C) 2006-2013  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class IssueRelationsController < ApplicationController
               before_filter :find_issue, :find_project_from_association, :authorize, :only => [:index, :create]
               before_filter :find_relation, :except => [:index, :create]
               accept_api_auth :index, :show, :create, :destroy
               def index
                 @relations = @issue.relations
                 respond_to do |format|
                   format.html { render :nothing => true }
                   format.api
                 end
               end
               def show
                 raise Unauthorized unless @relation.visible?
                 respond_to do |format|
                   format.html { render :nothing => true }
                   format.api
                 end
               end
               def create
                 @relation = IssueRelation.new(params[:relation])
                 @relation.issue_from = @issue
                 if params[:relation] && m = params[:relation][:issue_to_id].to_s.strip.match(/^#?(\d+)$/)
                   @relation.issue_to = Issue.visible.find_by_id(m[1].to_i)
                 end
                 saved = @relation.save
                 respond_to do |format|
                   format.html { redirect_to issue_path(@issue) }
                   format.js {
-                    @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
+                    @relations = @issue.reload.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
                   }
                   format.api {
                     if saved
                       render :action => 'show', :status => :created, :location => relation_url(@relation)
                     else
                       render_validation_errors(@relation)
                     end
                   }
                 end
               end
               def destroy
                 raise Unauthorized unless @relation.deletable?
                 @relation.destroy
                 respond_to do |format|
                   format.html { redirect_to issue_path(@relation.issue_from) }
                   format.js
                   format.api  { render_api_ok }
                 end
               end
             private
               def find_issue
                 @issue = @object = Issue.find(params[:issue_id])
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
               def find_relation
                 @relation = IssueRelation.find(params[:id])
               rescue ActiveRecord::RecordNotFound
                 render_404
               end
             end

             # Redmine - project management software
             # Copyright (C) 2006-2013  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             class Issue < ActiveRecord::Base
               include Redmine::SafeAttributes
               include Redmine::Utils::DateCalculation
               belongs_to :project
               belongs_to :tracker
               belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
               belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
               belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
               belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
               belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
               belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
               has_many :journals, :as => :journalized, :dependent => :destroy
               has_many :visible_journals,
                 :class_name => 'Journal',
                 :as => :journalized,
                 :conditions => Proc.new {
                   ["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false]
                 },
                 :readonly => true
               has_many :time_entries, :dependent => :delete_all
               has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
               has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
               has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
               acts_as_nested_set :scope => 'root_id', :dependent => :destroy
               acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
               acts_as_customizable
               acts_as_watchable
               acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
                                  :include => [:project, :visible_journals],
                                  # sort by id so that limited eager loading doesn't break with postgresql
                                  :order_column => "#{table_name}.id"
               acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
                             :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
                             :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
               acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
                                         :author_key => :author_id
               DONE_RATIO_OPTIONS = %w(issue_field issue_status)
               attr_reader :current_journal
               delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
               validates_presence_of :subject, :priority, :project, :tracker, :author, :status
               validates_length_of :subject, :maximum => 255
               validates_inclusion_of :done_ratio, :in => 0..100
               validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
               validates :start_date, :date => true
               validates :due_date, :date => true
               validate :validate_issue, :validate_required_fields
               scope :visible, lambda {|*args|
                 includes(:project).where(Issue.visible_condition(args.shift || User.current, *args))
               }
               scope :open, lambda {|*args|
                 is_closed = args.size > 0 ? !args.first : false
                 includes(:status).where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
               }
               scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
               scope :on_active_project, lambda {
                 includes(:status, :project, :tracker).where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
               }
               scope :fixed_version, lambda {|versions|
                 ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
                 ids.any? ? where(:fixed_version_id => ids) : where('1=0')
               }
               before_create :default_assign
               before_save :close_duplicates, :update_done_ratio_from_issue_status, :force_updated_on_change, :update_closed_on
               after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
               after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
               # Should be after_create but would be called before previous after_save callbacks
               after_save :after_create_from_copy
               after_destroy :update_parent_attributes
               # Returns a SQL conditions string used to find all issues visible by the specified user
               def self.visible_condition(user, options={})
                 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
                   if user.logged?
                     case role.issues_visibility
                     when 'all'
                       nil
                     when 'default'
                       user_ids = [user.id] + user.groups.map(&:id)
                       "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                     when 'own'
                       user_ids = [user.id] + user.groups.map(&:id)
                       "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                     else
                       '1=0'
                     end
                   else
                     "(#{table_name}.is_private = #{connection.quoted_false})"
                   end
                 end
               end
               # Returns true if usr or current user is allowed to view the issue
               def visible?(usr=nil)
                 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
                   if user.logged?
                     case role.issues_visibility
                     when 'all'
                       true
                     when 'default'
                       !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
                     when 'own'
                       self.author == user || user.is_or_belongs_to?(assigned_to)
                     else
                       false
                     end
                   else
                     !self.is_private?
                   end
                 end
               end
               # Returns true if user or current user is allowed to edit or add a note to the issue
               def editable?(user=User.current)
                 user.allowed_to?(:edit_issues, project) || user.allowed_to?(:add_issue_notes, project)
               end
               def initialize(attributes=nil, *args)
                 super
                 if new_record?
                   # set default values for new records only
                   self.status ||= IssueStatus.default
                   self.priority ||= IssuePriority.default
                   self.watcher_user_ids = []
                 end
               end
               def create_or_update
                 super
               ensure
                 @status_was = nil
               end
               private :create_or_update
               # AR#Persistence#destroy would raise and RecordNotFound exception
               # if the issue was already deleted or updated (non matching lock_version).
               # This is a problem when bulk deleting issues or deleting a project
               # (because an issue may already be deleted if its parent was deleted
               # first).
               # The issue is reloaded by the nested_set before being deleted so
               # the lock_version condition should not be an issue but we handle it.
               def destroy
                 super
               rescue ActiveRecord::RecordNotFound
                 # Stale or already deleted
                 begin
                   reload
                 rescue ActiveRecord::RecordNotFound
                   # The issue was actually already deleted
                   @destroyed = true
                   return freeze
                 end
                 # The issue was stale, retry to destroy
                 super
               end
               def reload(*args)
                 @workflow_rule_by_attribute = nil
                 @assignable_versions = nil
+                @relations = nil
                 super
               end
               # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
               def available_custom_fields
                 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
               end
               # Copies attributes from another issue, arg can be an id or an Issue
               def copy_from(arg, options={})
                 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
                 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
                 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                 self.status = issue.status
                 self.author = User.current
                 unless options[:attachments] == false
                   self.attachments = issue.attachments.map do |attachement|
                     attachement.copy(:container => self)
                   end
                 end
                 @copied_from = issue
                 @copy_options = options
                 self
               end
               # Returns an unsaved copy of the issue
               def copy(attributes=nil, copy_options={})
                 copy = self.class.new.copy_from(self, copy_options)
                 copy.attributes = attributes if attributes
                 copy
               end
               # Returns true if the issue is a copy
               def copy?
                 @copied_from.present?
               end
               # Moves/copies an issue to a new project and tracker
               # Returns the moved/copied issue on success, false on failure
               def move_to_project(new_project, new_tracker=nil, options={})
                 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
                 if options[:copy]
                   issue = self.copy
                 else
                   issue = self
                 end
                 issue.init_journal(User.current, options[:notes])
                 # Preserve previous behaviour
                 # #move_to_project doesn't change tracker automatically
                 issue.send :project=, new_project, true
                 if new_tracker
                   issue.tracker = new_tracker
                 end
                 # Allow bulk setting of attributes on the issue
                 if options[:attributes]
                   issue.attributes = options[:attributes]
                 end
                 issue.save ? issue : false
               end
               def status_id=(sid)
                 self.status = nil
                 result = write_attribute(:status_id, sid)
                 @workflow_rule_by_attribute = nil
                 result
               end
               def priority_id=(pid)
                 self.priority = nil
                 write_attribute(:priority_id, pid)
               end
               def category_id=(cid)
                 self.category = nil
                 write_attribute(:category_id, cid)
               end
               def fixed_version_id=(vid)
                 self.fixed_version = nil
                 write_attribute(:fixed_version_id, vid)
               end
               def tracker_id=(tid)
                 self.tracker = nil
                 result = write_attribute(:tracker_id, tid)
                 @custom_field_values = nil
                 @workflow_rule_by_attribute = nil
                 result
               end
               def project_id=(project_id)
                 if project_id.to_s != self.project_id.to_s
                   self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
                 end
               end
               def project=(project, keep_tracker=false)
                 project_was = self.project
                 write_attribute(:project_id, project ? project.id : nil)
                 association_instance_set('project', project)
                 if project_was && project && project_was != project
                   @assignable_versions = nil
                   unless keep_tracker || project.trackers.include?(tracker)
                     self.tracker = project.trackers.first
                   end
                   # Reassign to the category with same name if any
                   if category
                     self.category = project.issue_categories.find_by_name(category.name)
                   end
                   # Keep the fixed_version if it's still valid in the new_project
                   if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
                     self.fixed_version = nil
                   end
                   # Clear the parent task if it's no longer valid
                   unless valid_parent_project?
                     self.parent_issue_id = nil
                   end
                   @custom_field_values = nil
                 end
               end
               def description=(arg)
                 if arg.is_a?(String)
                   arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
                 end
                 write_attribute(:description, arg)
               end
               # Overrides assign_attributes so that project and tracker get assigned first
               def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
                 return if new_attributes.nil?
                 attrs = new_attributes.dup
                 attrs.stringify_keys!
                 %w(project project_id tracker tracker_id).each do |attr|
                   if attrs.has_key?(attr)
                     send "#{attr}=", attrs.delete(attr)
                   end
                 end
                 send :assign_attributes_without_project_and_tracker_first, attrs, *args
               end
               # Do not redefine alias chain on reload (see #4838)
               alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
               def estimated_hours=(h)
                 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
               end
               safe_attributes 'project_id',
                 :if => lambda {|issue, user|
                   if issue.new_record?
                     issue.copy?
                   elsif user.allowed_to?(:move_issues, issue.project)
                     projects = Issue.allowed_target_projects_on_move(user)
                     projects.include?(issue.project) && projects.size > 1
                   end
                 }
               safe_attributes 'tracker_id',
                 'status_id',
                 'category_id',
                 'assigned_to_id',
                 'priority_id',
                 'fixed_version_id',
                 'subject',
                 'description',
                 'start_date',
                 'due_date',
                 'done_ratio',
                 'estimated_hours',
                 'custom_field_values',
                 'custom_fields',
                 'lock_version',
                 'notes',
                 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
               safe_attributes 'status_id',
                 'assigned_to_id',
                 'fixed_version_id',
                 'done_ratio',
                 'lock_version',
                 'notes',
                 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
               safe_attributes 'notes',
                 :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
               safe_attributes 'private_notes',
                 :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
               safe_attributes 'watcher_user_ids',
                 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
               safe_attributes 'is_private',
                 :if => lambda {|issue, user|
                   user.allowed_to?(:set_issues_private, issue.project) ||
                     (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
                 }
               safe_attributes 'parent_issue_id',
                 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
                   user.allowed_to?(:manage_subtasks, issue.project)}
               def safe_attribute_names(user=nil)
                 names = super
                 names -= disabled_core_fields
                 names -= read_only_attribute_names(user)
                 names
               end
               # Safely sets attributes
               # Should be called from controllers instead of #attributes=
               # attr_accessible is too rough because we still want things like
               # Issue.new(:project => foo) to work
               def safe_attributes=(attrs, user=User.current)
                 return unless attrs.is_a?(Hash)
                 attrs = attrs.dup
                 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
                 if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
                   if allowed_target_projects(user).collect(&:id).include?(p.to_i)
                     self.project_id = p
                   end
                 end
                 if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
                   self.tracker_id = t
                 end
                 if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
                   if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
                     self.status_id = s
                   end
                 end
                 attrs = delete_unsafe_attributes(attrs, user)
                 return if attrs.empty?
                 unless leaf?
                   attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
                 end
                 if attrs['parent_issue_id'].present?
                   s = attrs['parent_issue_id'].to_s
                   unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
                     @invalid_parent_issue_id = attrs.delete('parent_issue_id')
                   end
                 end
                 if attrs['custom_field_values'].present?
                   attrs['custom_field_values'] = attrs['custom_field_values'].reject {|k, v| read_only_attribute_names(user).include? k.to_s}
                 end
                 if attrs['custom_fields'].present?
                   attrs['custom_fields'] = attrs['custom_fields'].reject {|c| read_only_attribute_names(user).include? c['id'].to_s}
                 end
                 # mass-assignment security bypass
                 assign_attributes attrs, :without_protection => true
               end
               def disabled_core_fields
                 tracker ? tracker.disabled_core_fields : []
               end
               # Returns the custom_field_values that can be edited by the given user
               def editable_custom_field_values(user=nil)
                 custom_field_values.reject do |value|
                   read_only_attribute_names(user).include?(value.custom_field_id.to_s)
                 end
               end
               # Returns the names of attributes that are read-only for user or the current user
               # For users with multiple roles, the read-only fields are the intersection of
               # read-only fields of each role
               # The result is an array of strings where sustom fields are represented with their ids
               #
               # Examples:
               #   issue.read_only_attribute_names # => ['due_date', '2']
               #   issue.read_only_attribute_names(user) # => []
               def read_only_attribute_names(user=nil)
                 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
               end
               # Returns the names of required attributes for user or the current user
               # For users with multiple roles, the required fields are the intersection of
               # required fields of each role
               # The result is an array of strings where sustom fields are represented with their ids
               #
               # Examples:
               #   issue.required_attribute_names # => ['due_date', '2']
               #   issue.required_attribute_names(user) # => []
               def required_attribute_names(user=nil)
                 workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
               end
               # Returns true if the attribute is required for user
               def required_attribute?(name, user=nil)
                 required_attribute_names(user).include?(name.to_s)
               end
               # Returns a hash of the workflow rule by attribute for the given user
               #
               # Examples:
               #   issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
               def workflow_rule_by_attribute(user=nil)
                 return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
                 user_real = user || User.current
                 roles = user_real.admin ? Role.all : user_real.roles_for_project(project)
                 return {} if roles.empty?
                 result = {}
                 workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).all
                 if workflow_permissions.any?
                   workflow_rules = workflow_permissions.inject({}) do |h, wp|
                     h[wp.field_name] ||= []
                     h[wp.field_name] << wp.rule
                     h
                   end
                   workflow_rules.each do |attr, rules|
                     next if rules.size < roles.size
                     uniq_rules = rules.uniq
                     if uniq_rules.size == 1
                       result[attr] = uniq_rules.first
                     else
                       result[attr] = 'required'
                     end
                   end
                 end
                 @workflow_rule_by_attribute = result if user.nil?
                 result
               end
               private :workflow_rule_by_attribute
               def done_ratio
                 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                   status.default_done_ratio
                 else
                   read_attribute(:done_ratio)
                 end
               end
               def self.use_status_for_done_ratio?
                 Setting.issue_done_ratio == 'issue_status'
               end
               def self.use_field_for_done_ratio?
                 Setting.issue_done_ratio == 'issue_field'
               end
               def validate_issue
                 if due_date && start_date && due_date < start_date
                   errors.add :due_date, :greater_than_start_date
                 end
                 if start_date && soonest_start && start_date < soonest_start
                   errors.add :start_date, :invalid
                 end
                 if fixed_version
                   if !assignable_versions.include?(fixed_version)
                     errors.add :fixed_version_id, :inclusion
                   elsif reopened? && fixed_version.closed?
                     errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
                   end
                 end
                 # Checks that the issue can not be added/moved to a disabled tracker
                 if project && (tracker_id_changed? || project_id_changed?)
                   unless project.trackers.include?(tracker)
                     errors.add :tracker_id, :inclusion
                   end
                 end
                 # Checks parent issue assignment
                 if @invalid_parent_issue_id.present?
                   errors.add :parent_issue_id, :invalid
                 elsif @parent_issue
                   if !valid_parent_project?(@parent_issue)
                     errors.add :parent_issue_id, :invalid
                   elsif !new_record?
                     # moving an existing issue
                     if @parent_issue.root_id != root_id
                       # we can always move to another tree
                     elsif move_possible?(@parent_issue)
                       # move accepted inside tree
                     else
                       errors.add :parent_issue_id, :invalid
                     end
                   end
                 end
               end
               # Validates the issue against additional workflow requirements
               def validate_required_fields
                 user = new_record? ? author : current_journal.try(:user)
                 required_attribute_names(user).each do |attribute|
                   if attribute =~ /^\d+$/
                     attribute = attribute.to_i
                     v = custom_field_values.detect {|v| v.custom_field_id == attribute }
                     if v && v.value.blank?
                       errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
                     end
                   else
                     if respond_to?(attribute) && send(attribute).blank?
                       errors.add attribute, :blank
                     end
                   end
                 end
               end
               # Set the done_ratio using the status if that setting is set.  This will keep the done_ratios
               # even if the user turns off the setting later
               def update_done_ratio_from_issue_status
                 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                   self.done_ratio = status.default_done_ratio
                 end
               end
               def init_journal(user, notes = "")
                 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
                 if new_record?
                   @current_journal.notify = false
                 else
                   @attributes_before_change = attributes.dup
                   @custom_values_before_change = {}
                   self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
                 end
                 @current_journal
               end
               # Returns the id of the last journal or nil
               def last_journal_id
                 if new_record?
                   nil
                 else
                   journals.maximum(:id)
                 end
               end
               # Returns a scope for journals that have an id greater than journal_id
               def journals_after(journal_id)
                 scope = journals.reorder("#{Journal.table_name}.id ASC")
                 if journal_id.present?
                   scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
                 end
                 scope
               end
               # Returns the initial status of the issue
               # Returns nil for a new issue
               def status_was
                 if status_id_was && status_id_was.to_i > 0
                   @status_was ||= IssueStatus.find_by_id(status_id_was)
                 end
               end
               # Return true if the issue is closed, otherwise false
               def closed?
                 self.status.is_closed?
               end
               # Return true if the issue is being reopened
               def reopened?
                 if !new_record? && status_id_changed?
                   status_was = IssueStatus.find_by_id(status_id_was)
                   status_new = IssueStatus.find_by_id(status_id)
                   if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
                     return true
                   end
                 end
                 false
               end
               # Return true if the issue is being closed
               def closing?
                 if !new_record? && status_id_changed?
                   if status_was && status && !status_was.is_closed? && status.is_closed?
                     return true
                   end
                 end
                 false
               end
               # Returns true if the issue is overdue
               def overdue?
                 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
               end
               # Is the amount of work done less than it should for the due date
               def behind_schedule?
                 return false if start_date.nil? || due_date.nil?
                 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
                 return done_date <= Date.today
               end
               # Does this issue have children?
               def children?
                 !leaf?
               end
               # Users the issue can be assigned to
               def assignable_users
                 users = project.assignable_users
                 users << author if author
                 users << assigned_to if assigned_to
                 users.uniq.sort
               end
               # Versions that the issue can be assigned to
               def assignable_versions
                 return @assignable_versions if @assignable_versions
                 versions = project.shared_versions.open.all
                 if fixed_version
                   if fixed_version_id_changed?
                     # nothing to do
                   elsif project_id_changed?
                     if project.shared_versions.include?(fixed_version)
                       versions << fixed_version
                     end
                   else
                     versions << fixed_version
                   end
                 end
                 @assignable_versions = versions.uniq.sort
               end
               # Returns true if this issue is blocked by another issue that is still open
               def blocked?
                 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
               end
               # Returns an array of statuses that user is able to apply
               def new_statuses_allowed_to(user=User.current, include_default=false)
                 if new_record? && @copied_from
                   [IssueStatus.default, @copied_from.status].compact.uniq.sort
                 else
                   initial_status = nil
                   if new_record?
                     initial_status = IssueStatus.default
                   elsif status_id_was
                     initial_status = IssueStatus.find_by_id(status_id_was)
                   end
                   initial_status ||= status
                   statuses = initial_status.find_new_statuses_allowed_to(
                     user.admin ? Role.all : user.roles_for_project(project),
                     tracker,
                     author == user,
                     assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
                     )
                   statuses << initial_status unless statuses.empty?
                   statuses << IssueStatus.default if include_default
                   statuses = statuses.compact.uniq.sort
                   blocked? ? statuses.reject {|s| s.is_closed?} : statuses
                 end
               end
               def assigned_to_was
                 if assigned_to_id_changed? && assigned_to_id_was.present?
                   @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
                 end
               end
               # Returns the users that should be notified
               def notified_users
                 notified = []
                 # Author and assignee are always notified unless they have been
                 # locked or don't want to be notified
                 notified << author if author
                 if assigned_to
                   notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
                 end
                 if assigned_to_was
                   notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
                 end
                 notified = notified.select {|u| u.active? && u.notify_about?(self)}
                 notified += project.notified_users
                 notified.uniq!
                 # Remove users that can not view the issue
                 notified.reject! {|user| !visible?(user)}
                 notified
               end
               # Returns the email addresses that should be notified
               def recipients
                 notified_users.collect(&:mail)
               end
               # Returns the number of hours spent on this issue
               def spent_hours
                 @spent_hours ||= time_entries.sum(:hours) || 0
               end
               # Returns the total number of hours spent on this issue and its descendants
               #
               # Example:
               #   spent_hours => 0.0
               #   spent_hours => 50.2
               def total_spent_hours
                 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
                   :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
               end
               def relations
                 @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
               end
               # Preloads relations for a collection of issues
               def self.load_relations(issues)
                 if issues.any?
                   relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
                   issues.each do |issue|
                     issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
                   end
                 end
               end
               # Preloads visible spent time for a collection of issues
               def self.load_visible_spent_hours(issues, user=User.current)
                 if issues.any?
                   hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
                   issues.each do |issue|
                     issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
                   end
                 end
               end
               # Preloads visible relations for a collection of issues
               def self.load_visible_relations(issues, user=User.current)
                 if issues.any?
                   issue_ids = issues.map(&:id)
                   # Relations with issue_from in given issues and visible issue_to
                   relations_from = IssueRelation.includes(:issue_to => [:status, :project]).where(visible_condition(user)).where(:issue_from_id => issue_ids).all
                   # Relations with issue_to in given issues and visible issue_from
                   relations_to = IssueRelation.includes(:issue_from => [:status, :project]).where(visible_condition(user)).where(:issue_to_id => issue_ids).all
                   issues.each do |issue|
                     relations =
                       relations_from.select {|relation| relation.issue_from_id == issue.id} +
                       relations_to.select {|relation| relation.issue_to_id == issue.id}
                     issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
                   end
                 end
               end
               # Finds an issue relation given its id.
               def find_relation(relation_id)
                 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
               end
               def all_dependent_issues(except=[])
                 except << self
                 dependencies = []
                 relations_from.each do |relation|
                   if relation.issue_to && !except.include?(relation.issue_to)
                     dependencies << relation.issue_to
                     dependencies += relation.issue_to.all_dependent_issues(except)
                   end
                 end
                 dependencies
               end
               # Returns an array of issues that duplicate this one
               def duplicates
                 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
               end
               # Returns the due date or the target due date if any
               # Used on gantt chart
               def due_before
                 due_date || (fixed_version ? fixed_version.effective_date : nil)
               end
               # Returns the time scheduled for this issue.
               #
               # Example:
               #   Start Date: 2/26/09, End Date: 3/04/09
               #   duration => 6
               def duration
                 (start_date && due_date) ? due_date - start_date : 0
               end
               # Returns the duration in working days
               def working_duration
                 (start_date && due_date) ? working_days(start_date, due_date) : 0
               end
               def soonest_start(reload=false)
                 @soonest_start = nil if reload
                 @soonest_start ||= (
                     relations_to(reload).collect{|relation| relation.successor_soonest_start} +
                     ancestors.collect(&:soonest_start)
                   ).compact.max
               end
               # Sets start_date on the given date or the next working day
               # and changes due_date to keep the same working duration.
               def reschedule_on(date)
                 wd = working_duration
                 date = next_working_date(date)
                 self.start_date = date
                 self.due_date = add_working_days(date, wd)
               end
               # Reschedules the issue on the given date or the next working day and saves the record.
               # If the issue is a parent task, this is done by rescheduling its subtasks.
               def reschedule_on!(date)
                 return if date.nil?
                 if leaf?
                   if start_date.nil? || start_date != date
                     if start_date && start_date > date
                       # Issue can not be moved earlier than its soonest start date
                       date = [soonest_start(true), date].compact.max
                     end
                     reschedule_on(date)
                     begin
                       save
                     rescue ActiveRecord::StaleObjectError
                       reload
                       reschedule_on(date)
                       save
                     end
                   end
                 else
                   leaves.each do |leaf|
                     if leaf.start_date
                       # Only move subtask if it starts at the same date as the parent
                       # or if it starts before the given date
                       if start_date == leaf.start_date || date > leaf.start_date
                         leaf.reschedule_on!(date)
                       end
                     else
                       leaf.reschedule_on!(date)
                     end
                   end
                 end
               end
               def <=>(issue)
                 if issue.nil?
                   -1
                 elsif root_id != issue.root_id
                   (root_id || 0) <=> (issue.root_id || 0)
                 else
                   (lft || 0) <=> (issue.lft || 0)
                 end
               end
               def to_s
                 "#{tracker} ##{id}: #{subject}"
               end
               # Returns a string of css classes that apply to the issue
               def css_classes
                 s = "issue status-#{status_id} #{priority.try(:css_classes)}"
                 s << ' closed' if closed?
                 s << ' overdue' if overdue?
                 s << ' child' if child?
                 s << ' parent' unless leaf?
                 s << ' private' if is_private?
                 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
                 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
                 s
               end
               # Saves an issue and a time_entry from the parameters
               def save_issue_with_child_records(params, existing_time_entry=nil)
                 Issue.transaction do
                   if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
                     @time_entry = existing_time_entry || TimeEntry.new
                     @time_entry.project = project
                     @time_entry.issue = self
                     @time_entry.user = User.current
                     @time_entry.spent_on = User.current.today
                     @time_entry.attributes = params[:time_entry]
                     self.time_entries << @time_entry
                   end
                   # TODO: Rename hook
                   Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                   if save
                     # TODO: Rename hook
                     Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
                   else
                     raise ActiveRecord::Rollback
                   end
                 end
               end
               # Unassigns issues from +version+ if it's no longer shared with issue's project
               def self.update_versions_from_sharing_change(version)
                 # Update issues assigned to the version
                 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
               end
               # Unassigns issues from versions that are no longer shared
               # after +project+ was moved
               def self.update_versions_from_hierarchy_change(project)
                 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
                 # Update issues of the moved projects and issues assigned to a version of a moved project
                 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
               end
               def parent_issue_id=(arg)
                 s = arg.to_s.strip.presence
                 if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
                   @parent_issue.id
                 else
                   @parent_issue = nil
                   @invalid_parent_issue_id = arg
                 end
               end
               def parent_issue_id
                 if @invalid_parent_issue_id
                   @invalid_parent_issue_id
                 elsif instance_variable_defined? :@parent_issue
                   @parent_issue.nil? ? nil : @parent_issue.id
                 else
                   parent_id
                 end
               end
               # Returns true if issue's project is a valid
               # parent issue project
               def valid_parent_project?(issue=parent)
                 return true if issue.nil? || issue.project_id == project_id
                 case Setting.cross_project_subtasks
                 when 'system'
                   true
                 when 'tree'
                   issue.project.root == project.root
                 when 'hierarchy'
                   issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
                 when 'descendants'
                   issue.project.is_or_is_ancestor_of?(project)
                 else
                   false
                 end
               end
               # Extracted from the ReportsController.
               def self.by_tracker(project)
                 count_and_group_by(:project => project,
                                    :field => 'tracker_id',
                                    :joins => Tracker.table_name)
               end
               def self.by_version(project)
                 count_and_group_by(:project => project,
                                    :field => 'fixed_version_id',
                                    :joins => Version.table_name)
               end
               def self.by_priority(project)
                 count_and_group_by(:project => project,
                                    :field => 'priority_id',
                                    :joins => IssuePriority.table_name)
               end
               def self.by_category(project)
                 count_and_group_by(:project => project,
                                    :field => 'category_id',
                                    :joins => IssueCategory.table_name)
               end
               def self.by_assigned_to(project)
                 count_and_group_by(:project => project,
                                    :field => 'assigned_to_id',
                                    :joins => User.table_name)
               end
               def self.by_author(project)
                 count_and_group_by(:project => project,
                                    :field => 'author_id',
                                    :joins => User.table_name)
               end
               def self.by_subproject(project)
                 ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                             s.is_closed as closed,
                                                             #{Issue.table_name}.project_id as project_id,
                                                             count(#{Issue.table_name}.id) as total
                                                           from
                                                             #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
                                                           where
                                                             #{Issue.table_name}.status_id=s.id
                                                             and #{Issue.table_name}.project_id = #{Project.table_name}.id
                                                             and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
                                                             and #{Issue.table_name}.project_id <> #{project.id}
                                                           group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
               end
               # End ReportsController extraction
               # Returns an array of projects that user can assign the issue to
               def allowed_target_projects(user=User.current)
                 if new_record?
                   Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
                 else
                   self.class.allowed_target_projects_on_move(user)
                 end
               end
               # Returns an array of projects that user can move issues to
               def self.allowed_target_projects_on_move(user=User.current)
                 Project.all(:conditions => Project.allowed_to_condition(user, :move_issues))
               end
               private
               def after_project_change
                 # Update project_id on related time entries
                 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
                 # Delete issue relations
                 unless Setting.cross_project_issue_relations?
                   relations_from.clear
                   relations_to.clear
                 end
                 # Move subtasks that were in the same project
                 children.each do |child|
                   next unless child.project_id == project_id_was
                   # Change project and keep project
                   child.send :project=, project, true
                   unless child.save
                     raise ActiveRecord::Rollback
                   end
                 end
               end
               # Callback for after the creation of an issue by copy
               # * adds a "copied to" relation with the copied issue
               # * copies subtasks from the copied issue
               def after_create_from_copy
                 return unless copy? && !@after_create_from_copy_handled
                 if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
                   relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
                   unless relation.save
                     logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
                   end
                 end
                 unless @copied_from.leaf? || @copy_options[:subtasks] == false
                   @copied_from.children.each do |child|
                     unless child.visible?
                       # Do not copy subtasks that are not visible to avoid potential disclosure of private data
                       logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
                       next
                     end
                     copy = Issue.new.copy_from(child, @copy_options)
                     copy.author = author
                     copy.project = project
                     copy.parent_issue_id = id
                     # Children subtasks are copied recursively
                     unless copy.save
                       logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
                     end
                   end
                 end
                 @after_create_from_copy_handled = true
               end
               def update_nested_set_attributes
                 if root_id.nil?
                   # issue was just created
                   self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
                   set_default_left_and_right
                   Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
                   if @parent_issue
                     move_to_child_of(@parent_issue)
                   end
                   reload
                 elsif parent_issue_id != parent_id
                   former_parent_id = parent_id
                   # moving an existing issue
                   if @parent_issue && @parent_issue.root_id == root_id
                     # inside the same tree
                     move_to_child_of(@parent_issue)
                   else
                     # to another tree
                     unless root?
                       move_to_right_of(root)
                       reload
                     end
                     old_root_id = root_id
                     self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
                     target_maxright = nested_set_scope.maximum(right_column_name) || 0
                     offset = target_maxright + 1 - lft
                     Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
                                       ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
                     self[left_column_name] = lft + offset
                     self[right_column_name] = rgt + offset
                     if @parent_issue
                       move_to_child_of(@parent_issue)
                     end
                   end
                   reload
                   # delete invalid relations of all descendants
                   self_and_descendants.each do |issue|
                     issue.relations.each do |relation|
                       relation.destroy unless relation.valid?
                     end
                   end
                   # update former parent
                   recalculate_attributes_for(former_parent_id) if former_parent_id
                 end
                 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
               end
               def update_parent_attributes
                 recalculate_attributes_for(parent_id) if parent_id
               end
               def recalculate_attributes_for(issue_id)
                 if issue_id && p = Issue.find_by_id(issue_id)
                   # priority = highest priority of children
                   if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
                     p.priority = IssuePriority.find_by_position(priority_position)
                   end
                   # start/due dates = lowest/highest dates of children
                   p.start_date = p.children.minimum(:start_date)
                   p.due_date = p.children.maximum(:due_date)
                   if p.start_date && p.due_date && p.due_date < p.start_date
                     p.start_date, p.due_date = p.due_date, p.start_date
                   end
                   # done ratio = weighted average ratio of leaves
                   unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
                     leaves_count = p.leaves.count
                     if leaves_count > 0
                       average = p.leaves.average(:estimated_hours).to_f
                       if average == 0
                         average = 1
                       end
                       done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
                       progress = done / (average * leaves_count)
                       p.done_ratio = progress.round
                     end
                   end
                   # estimate = sum of leaves estimates
                   p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
                   p.estimated_hours = nil if p.estimated_hours == 0.0
                   # ancestors will be recursively updated
                   p.save(:validate => false)
                 end
               end
               # Update issues so their versions are not pointing to a
               # fixed_version that is not shared with the issue's project
               def self.update_versions(conditions=nil)
                 # Only need to update issues with a fixed_version from
                 # a different project and that is not systemwide shared
                 Issue.scoped(:conditions => conditions).all(
                   :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
                     " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
                     " AND #{Version.table_name}.sharing <> 'system'",
                   :include => [:project, :fixed_version]
                 ).each do |issue|
                   next if issue.project.nil? || issue.fixed_version.nil?
                   unless issue.project.shared_versions.include?(issue.fixed_version)
                     issue.init_journal(User.current)
                     issue.fixed_version = nil
                     issue.save
                   end
                 end
               end
               # Callback on file attachment
               def attachment_added(obj)
                 if @current_journal && !obj.new_record?
                   @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
                 end
               end
               # Callback on attachment deletion
               def attachment_removed(obj)
                 if @current_journal && !obj.new_record?
                   @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :old_value => obj.filename)
                   @current_journal.save
                 end
               end
               # Default assignment based on category
               def default_assign
                 if assigned_to.nil? && category && category.assigned_to
                   self.assigned_to = category.assigned_to
                 end
               end
               # Updates start/due dates of following issues
               def reschedule_following_issues
                 if start_date_changed? || due_date_changed?
                   relations_from.each do |relation|
                     relation.set_issue_to_dates
                   end
                 end
               end
               # Closes duplicates if the issue is being closed
               def close_duplicates
                 if closing?
                   duplicates.each do |duplicate|
                     # Reload is need in case the duplicate was updated by a previous duplicate
                     duplicate.reload
                     # Don't re-close it if it's already closed
                     next if duplicate.closed?
                     # Same user and notes
                     if @current_journal
                       duplicate.init_journal(@current_journal.user, @current_journal.notes)
                     end
                     duplicate.update_attribute :status, self.status
                   end
                 end
               end
               # Make sure updated_on is updated when adding a note and set updated_on now
               # so we can set closed_on with the same value on closing
               def force_updated_on_change
                 if @current_journal || changed?
                   self.updated_on = current_time_from_proper_timezone
                   if new_record?
                     self.created_on = updated_on
                   end
                 end
               end
               # Callback for setting closed_on when the issue is closed.
               # The closed_on attribute stores the time of the last closing
               # and is preserved when the issue is reopened.
               def update_closed_on
                 if closing? || (new_record? && closed?)
                   self.closed_on = updated_on
                 end
               end
               # Saves the changes in a Journal
               # Called after_save
               def create_journal
                 if @current_journal
                   # attributes changes
                   if @attributes_before_change
                     (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)).each {|c|
                       before = @attributes_before_change[c]
                       after = send(c)
                       next if before == after || (before.blank? && after.blank?)
                       @current_journal.details << JournalDetail.new(:property => 'attr',
                                                                     :prop_key => c,
                                                                     :old_value => before,
                                                                     :value => after)
                     }
                   end
                   if @custom_values_before_change
                     # custom fields changes
                     custom_field_values.each {|c|
                       before = @custom_values_before_change[c.custom_field_id]
                       after = c.value
                       next if before == after || (before.blank? && after.blank?)
                       if before.is_a?(Array) || after.is_a?(Array)
                         before = [before] unless before.is_a?(Array)
                         after = [after] unless after.is_a?(Array)
                         # values removed
                         (before - after).reject(&:blank?).each do |value|
                           @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                         :prop_key => c.custom_field_id,
                                                                         :old_value => value,
                                                                         :value => nil)
                         end
                         # values added
                         (after - before).reject(&:blank?).each do |value|
                           @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                         :prop_key => c.custom_field_id,
                                                                         :old_value => nil,
                                                                         :value => value)
                         end
                       else
                         @current_journal.details << JournalDetail.new(:property => 'cf',
                                                                       :prop_key => c.custom_field_id,
                                                                       :old_value => before,
                                                                       :value => after)
                       end
                     }
                   end
                   @current_journal.save
                   # reset current journal
                   init_journal @current_journal.user, @current_journal.notes
                 end
               end
               # Query generator for selecting groups of issue counts for a project
               # based on specific criteria
               #
               # Options
               # * project - Project to search in.
               # * field - String. Issue field to key off of in the grouping.
               # * joins - String. The table name to join against.
               def self.count_and_group_by(options)
                 project = options.delete(:project)
                 select_field = options.delete(:field)
                 joins = options.delete(:joins)
                 where = "#{Issue.table_name}.#{select_field}=j.id"
                 ActiveRecord::Base.connection.select_all("select    s.id as status_id,
                                                             s.is_closed as closed,
                                                             j.id as #{select_field},
                                                             count(#{Issue.table_name}.id) as total
                                                           from
                                                               #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
                                                           where
                                                             #{Issue.table_name}.status_id=s.id
                                                             and #{where}
                                                             and #{Issue.table_name}.project_id=#{Project.table_name}.id
                                                             and #{visible_condition(User.current, :project => project)}
                                                           group by s.id, s.is_closed, j.id")
               end
             end

             # Redmine - project management software
             # Copyright (C) 2006-2013  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class IssueRelationsControllerTest < ActionController::TestCase
               fixtures :projects,
                        :users,
                        :roles,
                        :members,
                        :member_roles,
                        :issues,
                        :issue_statuses,
                        :issue_relations,
                        :enabled_modules,
                        :enumerations,
                        :trackers
               def setup
                 User.current = nil
                 @request.session[:user_id] = 3
               end
               def test_create
                 assert_difference 'IssueRelation.count' do
                   post :create, :issue_id => 1,
                              :relation => {:issue_to_id => '2', :relation_type => 'relates', :delay => ''}
                 end
                 relation = IssueRelation.first(:order => 'id DESC')
                 assert_equal 1, relation.issue_from_id
                 assert_equal 2, relation.issue_to_id
                 assert_equal 'relates', relation.relation_type
               end
               def test_create_xhr
                 assert_difference 'IssueRelation.count' do
                   xhr :post, :create, :issue_id => 3, :relation => {:issue_to_id => '1', :relation_type => 'relates', :delay => ''}
                   assert_response :success
                   assert_template 'create'
                   assert_equal 'text/javascript', response.content_type
                 end
                 relation = IssueRelation.first(:order => 'id DESC')
                 assert_equal 3, relation.issue_from_id
                 assert_equal 1, relation.issue_to_id
                 assert_match /Bug #1/, response.body
               end
               def test_create_should_accept_id_with_hash
                 assert_difference 'IssueRelation.count' do
                   post :create, :issue_id => 1,
                              :relation => {:issue_to_id => '#2', :relation_type => 'relates', :delay => ''}
                 end
                 relation = IssueRelation.first(:order => 'id DESC')
                 assert_equal 2, relation.issue_to_id
               end
               def test_create_should_strip_id
                 assert_difference 'IssueRelation.count' do
                   post :create, :issue_id => 1,
                              :relation => {:issue_to_id => ' 2  ', :relation_type => 'relates', :delay => ''}
                 end
                 relation = IssueRelation.first(:order => 'id DESC')
                 assert_equal 2, relation.issue_to_id
               end
               def test_create_should_not_break_with_non_numerical_id
                 assert_no_difference 'IssueRelation.count' do
                   assert_nothing_raised do
                     post :create, :issue_id => 1,
                                :relation => {:issue_to_id => 'foo', :relation_type => 'relates', :delay => ''}
                   end
                 end
               end
+              def test_create_follows_relation_should_update_relations_list
+                issue1 = Issue.generate!(:subject => 'Followed issue', :start_date => Date.yesterday, :due_date => Date.today)
+                issue2 = Issue.generate!
+                assert_difference 'IssueRelation.count' do
+                  xhr :post, :create, :issue_id => issue2.id,
+                             :relation => {:issue_to_id => issue1.id, :relation_type => 'follows', :delay => ''}
+                end
+                assert_match /Followed issue/, response.body
+              end
               def test_should_create_relations_with_visible_issues_only
                 Setting.cross_project_issue_relations = '1'
                 assert_nil Issue.visible(User.find(3)).find_by_id(4)
                 assert_no_difference 'IssueRelation.count' do
                   post :create, :issue_id => 1,
                              :relation => {:issue_to_id => '4', :relation_type => 'relates', :delay => ''}
                 end
               end
               should "prevent relation creation when there's a circular dependency"
               def test_create_xhr_with_failure
                 assert_no_difference 'IssueRelation.count' do
                   xhr :post, :create, :issue_id => 3, :relation => {:issue_to_id => '999', :relation_type => 'relates', :delay => ''}
                   assert_response :success
                   assert_template 'create'
                   assert_equal 'text/javascript', response.content_type
                 end
                 assert_match /errorExplanation/, response.body
               end
               def test_destroy
                 assert_difference 'IssueRelation.count', -1 do
                   delete :destroy, :id => '2'
                 end
               end
               def test_destroy_xhr
                 IssueRelation.create!(:relation_type => IssueRelation::TYPE_RELATES) do |r|
                   r.issue_from_id = 3
                   r.issue_to_id = 1
                 end
                 assert_difference 'IssueRelation.count', -1 do
                   xhr :delete, :destroy, :id => '2'
                   assert_response :success
                   assert_template 'destroy'
                   assert_equal 'text/javascript', response.content_type
                   assert_match /relation-2/, response.body
                 end
               end
             end