jro_apps/redmine Commit - r11598:8c9bba1cbfe4

Replaces camelcase variable names (#14015)....

Jean-Philippe Lang -

r11598:8c9bba1cbfe4

parent child

Context file:

r11598:8c9bba1cbfe4

Collapse all files

app/models/issue.rb +28 -30

               end
               # Returns all the other issues that depend on the issue
+              # The algorithm is a modified breadth first search (bfs)
               def all_dependent_issues(except=[])
-                # The algorithm as a modified bread first search (bfs)
                 # The found dependencies
                 dependencies = []
                 eALL_PROCESSED          = 5       # The issue and all its children, its parent and its related issues have been
                                                   # added as dependent issues. It needs no further processing.
-                issueStatus = Hash.new(eNOT_DISCOVERED)
+                issue_status = Hash.new(eNOT_DISCOVERED)
                 # The queue
                 queue = []
                 # Initialize the bfs, add start node (self) to the queue
                 queue << self
-                issueStatus[self] = ePROCESS_ALL
+                issue_status[self] = ePROCESS_ALL
                 while (!queue.empty?) do
-                  currentIssue = queue.shift
+                  current_issue = queue.shift
-                  currentIssueStatus = issueStatus[currentIssue]
+                  current_issue_status = issue_status[current_issue]
-                  dependencies << currentIssue
+                  dependencies << current_issue
                   # Add parent to queue, if not already in it.
-                  parent = currentIssue.parent
+                  parent = current_issue.parent
-                  parentStatus = issueStatus[parent]
+                  parentStatus = issue_status[parent]
                   if parent && (parentStatus == eNOT_DISCOVERED) && !except.include?(parent) then
                     queue << parent
-                    issueStatus[parent] = ePROCESS_RELATIONS_ONLY
+                    issue_status[parent] = ePROCESS_RELATIONS_ONLY
                   end
                   # Add children to queue, but only if they are not already in it and
                   # the children of the current node need to be processed.
-                  if currentIssue.children && (currentIssueStatus == ePROCESS_CHILDREN_ONLY || currentIssueStatus == ePROCESS_ALL) then
+                  if current_issue.children && (current_issue_status == ePROCESS_CHILDREN_ONLY || current_issue_status == ePROCESS_ALL) then
-                    currentIssue.children.each do |child|
+                    current_issue.children.each do |child|
-                      if (issueStatus[child] == eNOT_DISCOVERED) && !except.include?(child)
+                      if (issue_status[child] == eNOT_DISCOVERED) && !except.include?(child)
                         queue << child
-                        issueStatus[child] = ePROCESS_ALL
+                        issue_status[child] = ePROCESS_ALL
-                      elsif (issueStatus[child] == eRELATIONS_PROCESSED) && !except.include?(child)
+                      elsif (issue_status[child] == eRELATIONS_PROCESSED) && !except.include?(child)
                         queue << child
-                        issueStatus[child] = ePROCESS_CHILDREN_ONLY
+                        issue_status[child] = ePROCESS_CHILDREN_ONLY
-                      elsif (issueStatus[child] == ePROCESS_RELATIONS_ONLY) && !except.include?(child)
+                      elsif (issue_status[child] == ePROCESS_RELATIONS_ONLY) && !except.include?(child)
                         queue << child
-                        issueStatus[child] = ePROCESS_ALL
+                        issue_status[child] = ePROCESS_ALL
                       end
                     end
                   end
                   # Add related issues to the queue, if they are not already in it.
-                  currentIssue.relations_from.map(&:issue_to).each do |relatedIssue|
+                  current_issue.relations_from.map(&:issue_to).each do |relatedIssue|
-                    if (issueStatus[relatedIssue] == eNOT_DISCOVERED) && !except.include?(relatedIssue) then
+                    if (issue_status[relatedIssue] == eNOT_DISCOVERED) && !except.include?(relatedIssue) then
                       queue << relatedIssue
-                      issueStatus[relatedIssue] = ePROCESS_ALL
+                      issue_status[relatedIssue] = ePROCESS_ALL
-                    elsif (issueStatus[relatedIssue] == eRELATIONS_PROCESSED) && !except.include?(relatedIssue) then
+                    elsif (issue_status[relatedIssue] == eRELATIONS_PROCESSED) && !except.include?(relatedIssue) then
                       queue << relatedIssue
-                      issueStatus[relatedIssue] = ePROCESS_CHILDREN_ONLY
+                      issue_status[relatedIssue] = ePROCESS_CHILDREN_ONLY
-                    elsif (issueStatus[relatedIssue] == ePROCESS_RELATIONS_ONLY) && !except.include?(relatedIssue) then
+                    elsif (issue_status[relatedIssue] == ePROCESS_RELATIONS_ONLY) && !except.include?(relatedIssue) then
                       queue << relatedIssue
-                      issueStatus[relatedIssue] = ePROCESS_ALL
+                      issue_status[relatedIssue] = ePROCESS_ALL
                     end
                   end
                   # Set new status for current issue
-                  if (currentIssueStatus == ePROCESS_ALL) || (currentIssueStatus == ePROCESS_CHILDREN_ONLY) then
+                  if (current_issue_status == ePROCESS_ALL) || (current_issue_status == ePROCESS_CHILDREN_ONLY) then
-                    issueStatus[currentIssue] = eALL_PROCESSED
+                    issue_status[current_issue] = eALL_PROCESSED
-                  elsif (currentIssueStatus == ePROCESS_RELATIONS_ONLY) then
+                  elsif (current_issue_status == ePROCESS_RELATIONS_ONLY) then
-                    issueStatus[currentIssue] = eRELATIONS_PROCESSED
+                    issue_status[current_issue] = eRELATIONS_PROCESSED
                   end
                 end # while

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages