##// END OF EJS Templates
Rails4: replace deprecated find_all_by_* at IssuesControllerTest...
Toshi MARUYAMA -
r12352:8c595df5954c
parent child
Show More
@@ -1,3974 +1,3974
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssuesControllerTest < ActionController::TestCase
21 21 fixtures :projects,
22 22 :users,
23 23 :roles,
24 24 :members,
25 25 :member_roles,
26 26 :issues,
27 27 :issue_statuses,
28 28 :versions,
29 29 :trackers,
30 30 :projects_trackers,
31 31 :issue_categories,
32 32 :enabled_modules,
33 33 :enumerations,
34 34 :attachments,
35 35 :workflows,
36 36 :custom_fields,
37 37 :custom_values,
38 38 :custom_fields_projects,
39 39 :custom_fields_trackers,
40 40 :time_entries,
41 41 :journals,
42 42 :journal_details,
43 43 :queries,
44 44 :repositories,
45 45 :changesets
46 46
47 47 include Redmine::I18n
48 48
49 49 def setup
50 50 User.current = nil
51 51 end
52 52
53 53 def test_index
54 54 with_settings :default_language => "en" do
55 55 get :index
56 56 assert_response :success
57 57 assert_template 'index'
58 58 assert_not_nil assigns(:issues)
59 59 assert_nil assigns(:project)
60 60
61 61 # links to visible issues
62 62 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
63 63 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
64 64 # private projects hidden
65 65 assert_select 'a[href=/issues/6]', 0
66 66 assert_select 'a[href=/issues/4]', 0
67 67 # project column
68 68 assert_select 'th', :text => /Project/
69 69 end
70 70 end
71 71
72 72 def test_index_should_not_list_issues_when_module_disabled
73 73 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
74 74 get :index
75 75 assert_response :success
76 76 assert_template 'index'
77 77 assert_not_nil assigns(:issues)
78 78 assert_nil assigns(:project)
79 79
80 80 assert_select 'a[href=/issues/1]', 0
81 81 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
82 82 end
83 83
84 84 def test_index_should_list_visible_issues_only
85 85 get :index, :per_page => 100
86 86 assert_response :success
87 87 assert_not_nil assigns(:issues)
88 88 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
89 89 end
90 90
91 91 def test_index_with_project
92 92 Setting.display_subprojects_issues = 0
93 93 get :index, :project_id => 1
94 94 assert_response :success
95 95 assert_template 'index'
96 96 assert_not_nil assigns(:issues)
97 97
98 98 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
99 99 assert_select 'a[href=/issues/5]', 0
100 100 end
101 101
102 102 def test_index_with_project_and_subprojects
103 103 Setting.display_subprojects_issues = 1
104 104 get :index, :project_id => 1
105 105 assert_response :success
106 106 assert_template 'index'
107 107 assert_not_nil assigns(:issues)
108 108
109 109 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
110 110 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
111 111 assert_select 'a[href=/issues/6]', 0
112 112 end
113 113
114 114 def test_index_with_project_and_subprojects_should_show_private_subprojects_with_permission
115 115 @request.session[:user_id] = 2
116 116 Setting.display_subprojects_issues = 1
117 117 get :index, :project_id => 1
118 118 assert_response :success
119 119 assert_template 'index'
120 120 assert_not_nil assigns(:issues)
121 121
122 122 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
123 123 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
124 124 assert_select 'a[href=/issues/6]', :text => /Issue of a private subproject/
125 125 end
126 126
127 127 def test_index_with_project_and_default_filter
128 128 get :index, :project_id => 1, :set_filter => 1
129 129 assert_response :success
130 130 assert_template 'index'
131 131 assert_not_nil assigns(:issues)
132 132
133 133 query = assigns(:query)
134 134 assert_not_nil query
135 135 # default filter
136 136 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
137 137 end
138 138
139 139 def test_index_with_project_and_filter
140 140 get :index, :project_id => 1, :set_filter => 1,
141 141 :f => ['tracker_id'],
142 142 :op => {'tracker_id' => '='},
143 143 :v => {'tracker_id' => ['1']}
144 144 assert_response :success
145 145 assert_template 'index'
146 146 assert_not_nil assigns(:issues)
147 147
148 148 query = assigns(:query)
149 149 assert_not_nil query
150 150 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
151 151 end
152 152
153 153 def test_index_with_short_filters
154 154 to_test = {
155 155 'status_id' => {
156 156 'o' => { :op => 'o', :values => [''] },
157 157 'c' => { :op => 'c', :values => [''] },
158 158 '7' => { :op => '=', :values => ['7'] },
159 159 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
160 160 '=7' => { :op => '=', :values => ['7'] },
161 161 '!3' => { :op => '!', :values => ['3'] },
162 162 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
163 163 'subject' => {
164 164 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
165 165 'o' => { :op => '=', :values => ['o'] },
166 166 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
167 167 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
168 168 'tracker_id' => {
169 169 '3' => { :op => '=', :values => ['3'] },
170 170 '=3' => { :op => '=', :values => ['3'] }},
171 171 'start_date' => {
172 172 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
173 173 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
174 174 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
175 175 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
176 176 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
177 177 '<t+2' => { :op => '<t+', :values => ['2'] },
178 178 '>t+2' => { :op => '>t+', :values => ['2'] },
179 179 't+2' => { :op => 't+', :values => ['2'] },
180 180 't' => { :op => 't', :values => [''] },
181 181 'w' => { :op => 'w', :values => [''] },
182 182 '>t-2' => { :op => '>t-', :values => ['2'] },
183 183 '<t-2' => { :op => '<t-', :values => ['2'] },
184 184 't-2' => { :op => 't-', :values => ['2'] }},
185 185 'created_on' => {
186 186 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
187 187 '<t-2' => { :op => '<t-', :values => ['2'] },
188 188 '>t-2' => { :op => '>t-', :values => ['2'] },
189 189 't-2' => { :op => 't-', :values => ['2'] }},
190 190 'cf_1' => {
191 191 'c' => { :op => '=', :values => ['c'] },
192 192 '!c' => { :op => '!', :values => ['c'] },
193 193 '!*' => { :op => '!*', :values => [''] },
194 194 '*' => { :op => '*', :values => [''] }},
195 195 'estimated_hours' => {
196 196 '=13.4' => { :op => '=', :values => ['13.4'] },
197 197 '>=45' => { :op => '>=', :values => ['45'] },
198 198 '<=125' => { :op => '<=', :values => ['125'] },
199 199 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
200 200 '!*' => { :op => '!*', :values => [''] },
201 201 '*' => { :op => '*', :values => [''] }}
202 202 }
203 203
204 204 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
205 205
206 206 to_test.each do |field, expression_and_expected|
207 207 expression_and_expected.each do |filter_expression, expected|
208 208
209 209 get :index, :set_filter => 1, field => filter_expression
210 210
211 211 assert_response :success
212 212 assert_template 'index'
213 213 assert_not_nil assigns(:issues)
214 214
215 215 query = assigns(:query)
216 216 assert_not_nil query
217 217 assert query.has_filter?(field)
218 218 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
219 219 end
220 220 end
221 221 end
222 222
223 223 def test_index_with_project_and_empty_filters
224 224 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
225 225 assert_response :success
226 226 assert_template 'index'
227 227 assert_not_nil assigns(:issues)
228 228
229 229 query = assigns(:query)
230 230 assert_not_nil query
231 231 # no filter
232 232 assert_equal({}, query.filters)
233 233 end
234 234
235 235 def test_index_with_project_custom_field_filter
236 236 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
237 237 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
238 238 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
239 239 filter_name = "project.cf_#{field.id}"
240 240 @request.session[:user_id] = 1
241 241
242 242 get :index, :set_filter => 1,
243 243 :f => [filter_name],
244 244 :op => {filter_name => '='},
245 245 :v => {filter_name => ['Foo']}
246 246 assert_response :success
247 247 assert_template 'index'
248 248 assert_equal [3, 5], assigns(:issues).map(&:project_id).uniq.sort
249 249 end
250 250
251 251 def test_index_with_query
252 252 get :index, :project_id => 1, :query_id => 5
253 253 assert_response :success
254 254 assert_template 'index'
255 255 assert_not_nil assigns(:issues)
256 256 assert_nil assigns(:issue_count_by_group)
257 257 end
258 258
259 259 def test_index_with_query_grouped_by_tracker
260 260 get :index, :project_id => 1, :query_id => 6
261 261 assert_response :success
262 262 assert_template 'index'
263 263 assert_not_nil assigns(:issues)
264 264 assert_not_nil assigns(:issue_count_by_group)
265 265 end
266 266
267 267 def test_index_with_query_grouped_by_list_custom_field
268 268 get :index, :project_id => 1, :query_id => 9
269 269 assert_response :success
270 270 assert_template 'index'
271 271 assert_not_nil assigns(:issues)
272 272 assert_not_nil assigns(:issue_count_by_group)
273 273 end
274 274
275 275 def test_index_with_query_grouped_by_user_custom_field
276 276 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
277 277 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
278 278 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
279 279 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
280 280 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
281 281
282 282 get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
283 283 assert_response :success
284 284
285 285 assert_select 'tr.group', 3
286 286 assert_select 'tr.group' do
287 287 assert_select 'a', :text => 'John Smith'
288 288 assert_select 'span.count', :text => '1'
289 289 end
290 290 assert_select 'tr.group' do
291 291 assert_select 'a', :text => 'Dave Lopper'
292 292 assert_select 'span.count', :text => '2'
293 293 end
294 294 end
295 295
296 296 def test_index_with_query_grouped_by_tracker_in_normal_order
297 297 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
298 298
299 299 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc'
300 300 assert_response :success
301 301
302 302 trackers = assigns(:issues).map(&:tracker).uniq
303 303 assert_equal [1, 2, 3], trackers.map(&:id)
304 304 end
305 305
306 306 def test_index_with_query_grouped_by_tracker_in_reverse_order
307 307 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
308 308
309 309 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc,tracker:desc'
310 310 assert_response :success
311 311
312 312 trackers = assigns(:issues).map(&:tracker).uniq
313 313 assert_equal [3, 2, 1], trackers.map(&:id)
314 314 end
315 315
316 316 def test_index_with_query_id_and_project_id_should_set_session_query
317 317 get :index, :project_id => 1, :query_id => 4
318 318 assert_response :success
319 319 assert_kind_of Hash, session[:query]
320 320 assert_equal 4, session[:query][:id]
321 321 assert_equal 1, session[:query][:project_id]
322 322 end
323 323
324 324 def test_index_with_invalid_query_id_should_respond_404
325 325 get :index, :project_id => 1, :query_id => 999
326 326 assert_response 404
327 327 end
328 328
329 329 def test_index_with_cross_project_query_in_session_should_show_project_issues
330 330 q = IssueQuery.create!(:name => "test", :user_id => 2, :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
331 331 @request.session[:query] = {:id => q.id, :project_id => 1}
332 332
333 333 with_settings :display_subprojects_issues => '0' do
334 334 get :index, :project_id => 1
335 335 end
336 336 assert_response :success
337 337 assert_not_nil assigns(:query)
338 338 assert_equal q.id, assigns(:query).id
339 339 assert_equal 1, assigns(:query).project_id
340 340 assert_equal [1], assigns(:issues).map(&:project_id).uniq
341 341 end
342 342
343 343 def test_private_query_should_not_be_available_to_other_users
344 344 q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
345 345 @request.session[:user_id] = 3
346 346
347 347 get :index, :query_id => q.id
348 348 assert_response 403
349 349 end
350 350
351 351 def test_private_query_should_be_available_to_its_user
352 352 q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PRIVATE, :project => nil)
353 353 @request.session[:user_id] = 2
354 354
355 355 get :index, :query_id => q.id
356 356 assert_response :success
357 357 end
358 358
359 359 def test_public_query_should_be_available_to_other_users
360 360 q = IssueQuery.create!(:name => "private", :user => User.find(2), :visibility => IssueQuery::VISIBILITY_PUBLIC, :project => nil)
361 361 @request.session[:user_id] = 3
362 362
363 363 get :index, :query_id => q.id
364 364 assert_response :success
365 365 end
366 366
367 367 def test_index_should_omit_page_param_in_export_links
368 368 get :index, :page => 2
369 369 assert_response :success
370 370 assert_select 'a.atom[href=/issues.atom]'
371 371 assert_select 'a.csv[href=/issues.csv]'
372 372 assert_select 'a.pdf[href=/issues.pdf]'
373 373 assert_select 'form#csv-export-form[action=/issues.csv]'
374 374 end
375 375
376 376 def test_index_csv
377 377 get :index, :format => 'csv'
378 378 assert_response :success
379 379 assert_not_nil assigns(:issues)
380 380 assert_equal 'text/csv; header=present', @response.content_type
381 381 assert @response.body.starts_with?("#,")
382 382 lines = @response.body.chomp.split("\n")
383 383 assert_equal assigns(:query).columns.size, lines[0].split(',').size
384 384 end
385 385
386 386 def test_index_csv_with_project
387 387 get :index, :project_id => 1, :format => 'csv'
388 388 assert_response :success
389 389 assert_not_nil assigns(:issues)
390 390 assert_equal 'text/csv; header=present', @response.content_type
391 391 end
392 392
393 393 def test_index_csv_with_description
394 394 Issue.generate!(:description => 'test_index_csv_with_description')
395 395
396 396 with_settings :default_language => 'en' do
397 397 get :index, :format => 'csv', :description => '1'
398 398 assert_response :success
399 399 assert_not_nil assigns(:issues)
400 400 end
401 401
402 402 assert_equal 'text/csv; header=present', response.content_type
403 403 headers = response.body.chomp.split("\n").first.split(',')
404 404 assert_include 'Description', headers
405 405 assert_include 'test_index_csv_with_description', response.body
406 406 end
407 407
408 408 def test_index_csv_with_spent_time_column
409 409 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column', :author_id => 2)
410 410 TimeEntry.create!(:project => issue.project, :issue => issue, :hours => 7.33, :user => User.find(2), :spent_on => Date.today)
411 411
412 412 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
413 413 assert_response :success
414 414 assert_equal 'text/csv; header=present', @response.content_type
415 415 lines = @response.body.chomp.split("\n")
416 416 assert_include "#{issue.id},#{issue.subject},7.33", lines
417 417 end
418 418
419 419 def test_index_csv_with_all_columns
420 420 get :index, :format => 'csv', :columns => 'all'
421 421 assert_response :success
422 422 assert_not_nil assigns(:issues)
423 423 assert_equal 'text/csv; header=present', @response.content_type
424 424 assert_match /\A#,/, response.body
425 425 lines = response.body.chomp.split("\n")
426 426 assert_equal assigns(:query).available_inline_columns.size, lines[0].split(',').size
427 427 end
428 428
429 429 def test_index_csv_with_multi_column_field
430 430 CustomField.find(1).update_attribute :multiple, true
431 431 issue = Issue.find(1)
432 432 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
433 433 issue.save!
434 434
435 435 get :index, :format => 'csv', :columns => 'all'
436 436 assert_response :success
437 437 lines = @response.body.chomp.split("\n")
438 438 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
439 439 end
440 440
441 441 def test_index_csv_should_format_float_custom_fields_with_csv_decimal_separator
442 442 field = IssueCustomField.create!(:name => 'Float', :is_for_all => true, :tracker_ids => [1], :field_format => 'float')
443 443 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id => '185.6'})
444 444
445 445 with_settings :default_language => 'fr' do
446 446 get :index, :format => 'csv', :columns => 'all'
447 447 assert_response :success
448 448 issue_line = response.body.chomp.split("\n").map {|line| line.split(';')}.detect {|line| line[0]==issue.id.to_s}
449 449 assert_include '185,60', issue_line
450 450 end
451 451
452 452 with_settings :default_language => 'en' do
453 453 get :index, :format => 'csv', :columns => 'all'
454 454 assert_response :success
455 455 issue_line = response.body.chomp.split("\n").map {|line| line.split(',')}.detect {|line| line[0]==issue.id.to_s}
456 456 assert_include '185.60', issue_line
457 457 end
458 458 end
459 459
460 460 def test_index_csv_big_5
461 461 with_settings :default_language => "zh-TW" do
462 462 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
463 463 str_big5 = "\xa4@\xa4\xeb"
464 464 if str_utf8.respond_to?(:force_encoding)
465 465 str_utf8.force_encoding('UTF-8')
466 466 str_big5.force_encoding('Big5')
467 467 end
468 468 issue = Issue.generate!(:subject => str_utf8)
469 469
470 470 get :index, :project_id => 1,
471 471 :f => ['subject'],
472 472 :op => '=', :values => [str_utf8],
473 473 :format => 'csv'
474 474 assert_equal 'text/csv; header=present', @response.content_type
475 475 lines = @response.body.chomp.split("\n")
476 476 s1 = "\xaa\xac\xbaA"
477 477 if str_utf8.respond_to?(:force_encoding)
478 478 s1.force_encoding('Big5')
479 479 end
480 480 assert_include s1, lines[0]
481 481 assert_include str_big5, lines[1]
482 482 end
483 483 end
484 484
485 485 def test_index_csv_cannot_convert_should_be_replaced_big_5
486 486 with_settings :default_language => "zh-TW" do
487 487 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
488 488 if str_utf8.respond_to?(:force_encoding)
489 489 str_utf8.force_encoding('UTF-8')
490 490 end
491 491 issue = Issue.generate!(:subject => str_utf8)
492 492
493 493 get :index, :project_id => 1,
494 494 :f => ['subject'],
495 495 :op => '=', :values => [str_utf8],
496 496 :c => ['status', 'subject'],
497 497 :format => 'csv',
498 498 :set_filter => 1
499 499 assert_equal 'text/csv; header=present', @response.content_type
500 500 lines = @response.body.chomp.split("\n")
501 501 s1 = "\xaa\xac\xbaA" # status
502 502 if str_utf8.respond_to?(:force_encoding)
503 503 s1.force_encoding('Big5')
504 504 end
505 505 assert lines[0].include?(s1)
506 506 s2 = lines[1].split(",")[2]
507 507 if s1.respond_to?(:force_encoding)
508 508 s3 = "\xa5H?" # subject
509 509 s3.force_encoding('Big5')
510 510 assert_equal s3, s2
511 511 elsif RUBY_PLATFORM == 'java'
512 512 assert_equal "??", s2
513 513 else
514 514 assert_equal "\xa5H???", s2
515 515 end
516 516 end
517 517 end
518 518
519 519 def test_index_csv_tw
520 520 with_settings :default_language => "zh-TW" do
521 521 str1 = "test_index_csv_tw"
522 522 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
523 523
524 524 get :index, :project_id => 1,
525 525 :f => ['subject'],
526 526 :op => '=', :values => [str1],
527 527 :c => ['estimated_hours', 'subject'],
528 528 :format => 'csv',
529 529 :set_filter => 1
530 530 assert_equal 'text/csv; header=present', @response.content_type
531 531 lines = @response.body.chomp.split("\n")
532 532 assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
533 533 end
534 534 end
535 535
536 536 def test_index_csv_fr
537 537 with_settings :default_language => "fr" do
538 538 str1 = "test_index_csv_fr"
539 539 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
540 540
541 541 get :index, :project_id => 1,
542 542 :f => ['subject'],
543 543 :op => '=', :values => [str1],
544 544 :c => ['estimated_hours', 'subject'],
545 545 :format => 'csv',
546 546 :set_filter => 1
547 547 assert_equal 'text/csv; header=present', @response.content_type
548 548 lines = @response.body.chomp.split("\n")
549 549 assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
550 550 end
551 551 end
552 552
553 553 def test_index_pdf
554 554 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
555 555 with_settings :default_language => lang do
556 556
557 557 get :index
558 558 assert_response :success
559 559 assert_template 'index'
560 560
561 561 if lang == "ja"
562 562 if RUBY_PLATFORM != 'java'
563 563 assert_equal "CP932", l(:general_pdf_encoding)
564 564 end
565 565 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
566 566 next
567 567 end
568 568 end
569 569
570 570 get :index, :format => 'pdf'
571 571 assert_response :success
572 572 assert_not_nil assigns(:issues)
573 573 assert_equal 'application/pdf', @response.content_type
574 574
575 575 get :index, :project_id => 1, :format => 'pdf'
576 576 assert_response :success
577 577 assert_not_nil assigns(:issues)
578 578 assert_equal 'application/pdf', @response.content_type
579 579
580 580 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
581 581 assert_response :success
582 582 assert_not_nil assigns(:issues)
583 583 assert_equal 'application/pdf', @response.content_type
584 584 end
585 585 end
586 586 end
587 587
588 588 def test_index_pdf_with_query_grouped_by_list_custom_field
589 589 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
590 590 assert_response :success
591 591 assert_not_nil assigns(:issues)
592 592 assert_not_nil assigns(:issue_count_by_group)
593 593 assert_equal 'application/pdf', @response.content_type
594 594 end
595 595
596 596 def test_index_atom
597 597 get :index, :project_id => 'ecookbook', :format => 'atom'
598 598 assert_response :success
599 599 assert_template 'common/feed'
600 600 assert_equal 'application/atom+xml', response.content_type
601 601
602 602 assert_select 'feed' do
603 603 assert_select 'link[rel=self][href=?]', 'http://test.host/projects/ecookbook/issues.atom'
604 604 assert_select 'link[rel=alternate][href=?]', 'http://test.host/projects/ecookbook/issues'
605 605 assert_select 'entry link[href=?]', 'http://test.host/issues/1'
606 606 end
607 607 end
608 608
609 609 def test_index_sort
610 610 get :index, :sort => 'tracker,id:desc'
611 611 assert_response :success
612 612
613 613 sort_params = @request.session['issues_index_sort']
614 614 assert sort_params.is_a?(String)
615 615 assert_equal 'tracker,id:desc', sort_params
616 616
617 617 issues = assigns(:issues)
618 618 assert_not_nil issues
619 619 assert !issues.empty?
620 620 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
621 621 end
622 622
623 623 def test_index_sort_by_field_not_included_in_columns
624 624 Setting.issue_list_default_columns = %w(subject author)
625 625 get :index, :sort => 'tracker'
626 626 end
627 627
628 628 def test_index_sort_by_assigned_to
629 629 get :index, :sort => 'assigned_to'
630 630 assert_response :success
631 631 assignees = assigns(:issues).collect(&:assigned_to).compact
632 632 assert_equal assignees.sort, assignees
633 633 end
634 634
635 635 def test_index_sort_by_assigned_to_desc
636 636 get :index, :sort => 'assigned_to:desc'
637 637 assert_response :success
638 638 assignees = assigns(:issues).collect(&:assigned_to).compact
639 639 assert_equal assignees.sort.reverse, assignees
640 640 end
641 641
642 642 def test_index_group_by_assigned_to
643 643 get :index, :group_by => 'assigned_to', :sort => 'priority'
644 644 assert_response :success
645 645 end
646 646
647 647 def test_index_sort_by_author
648 648 get :index, :sort => 'author'
649 649 assert_response :success
650 650 authors = assigns(:issues).collect(&:author)
651 651 assert_equal authors.sort, authors
652 652 end
653 653
654 654 def test_index_sort_by_author_desc
655 655 get :index, :sort => 'author:desc'
656 656 assert_response :success
657 657 authors = assigns(:issues).collect(&:author)
658 658 assert_equal authors.sort.reverse, authors
659 659 end
660 660
661 661 def test_index_group_by_author
662 662 get :index, :group_by => 'author', :sort => 'priority'
663 663 assert_response :success
664 664 end
665 665
666 666 def test_index_sort_by_spent_hours
667 667 get :index, :sort => 'spent_hours:desc'
668 668 assert_response :success
669 669 hours = assigns(:issues).collect(&:spent_hours)
670 670 assert_equal hours.sort.reverse, hours
671 671 end
672 672
673 673 def test_index_sort_by_user_custom_field
674 674 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
675 675 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
676 676 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
677 677 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
678 678 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
679 679
680 680 get :index, :project_id => 1, :set_filter => 1, :sort => "cf_#{cf.id},id"
681 681 assert_response :success
682 682
683 683 assert_equal [2, 3, 1], assigns(:issues).select {|issue| issue.custom_field_value(cf).present?}.map(&:id)
684 684 end
685 685
686 686 def test_index_with_columns
687 687 columns = ['tracker', 'subject', 'assigned_to']
688 688 get :index, :set_filter => 1, :c => columns
689 689 assert_response :success
690 690
691 691 # query should use specified columns
692 692 query = assigns(:query)
693 693 assert_kind_of IssueQuery, query
694 694 assert_equal columns, query.column_names.map(&:to_s)
695 695
696 696 # columns should be stored in session
697 697 assert_kind_of Hash, session[:query]
698 698 assert_kind_of Array, session[:query][:column_names]
699 699 assert_equal columns, session[:query][:column_names].map(&:to_s)
700 700
701 701 # ensure only these columns are kept in the selected columns list
702 702 assert_select 'select#selected_columns option' do
703 703 assert_select 'option', 3
704 704 assert_select 'option[value=tracker]'
705 705 assert_select 'option[value=project]', 0
706 706 end
707 707 end
708 708
709 709 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
710 710 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
711 711 get :index, :set_filter => 1
712 712
713 713 # query should use specified columns
714 714 query = assigns(:query)
715 715 assert_kind_of IssueQuery, query
716 716 assert_equal [:id, :project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
717 717 end
718 718
719 719 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
720 720 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
721 721 columns = ['id', 'tracker', 'subject', 'assigned_to']
722 722 get :index, :set_filter => 1, :c => columns
723 723
724 724 # query should use specified columns
725 725 query = assigns(:query)
726 726 assert_kind_of IssueQuery, query
727 727 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
728 728 end
729 729
730 730 def test_index_with_custom_field_column
731 731 columns = %w(tracker subject cf_2)
732 732 get :index, :set_filter => 1, :c => columns
733 733 assert_response :success
734 734
735 735 # query should use specified columns
736 736 query = assigns(:query)
737 737 assert_kind_of IssueQuery, query
738 738 assert_equal columns, query.column_names.map(&:to_s)
739 739
740 740 assert_select 'table.issues td.cf_2.string'
741 741 end
742 742
743 743 def test_index_with_multi_custom_field_column
744 744 field = CustomField.find(1)
745 745 field.update_attribute :multiple, true
746 746 issue = Issue.find(1)
747 747 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
748 748 issue.save!
749 749
750 750 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
751 751 assert_response :success
752 752
753 753 assert_select 'table.issues td.cf_1', :text => 'MySQL, Oracle'
754 754 end
755 755
756 756 def test_index_with_multi_user_custom_field_column
757 757 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
758 758 :tracker_ids => [1], :is_for_all => true)
759 759 issue = Issue.find(1)
760 760 issue.custom_field_values = {field.id => ['2', '3']}
761 761 issue.save!
762 762
763 763 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
764 764 assert_response :success
765 765
766 766 assert_select "table.issues td.cf_#{field.id}" do
767 767 assert_select 'a', 2
768 768 assert_select 'a[href=?]', '/users/2', :text => 'John Smith'
769 769 assert_select 'a[href=?]', '/users/3', :text => 'Dave Lopper'
770 770 end
771 771 end
772 772
773 773 def test_index_with_date_column
774 774 with_settings :date_format => '%d/%m/%Y' do
775 775 Issue.find(1).update_attribute :start_date, '1987-08-24'
776 776 get :index, :set_filter => 1, :c => %w(start_date)
777 777 assert_select "table.issues td.start_date", :text => '24/08/1987'
778 778 end
779 779 end
780 780
781 781 def test_index_with_done_ratio_column
782 782 Issue.find(1).update_attribute :done_ratio, 40
783 783 get :index, :set_filter => 1, :c => %w(done_ratio)
784 784 assert_select 'table.issues td.done_ratio' do
785 785 assert_select 'table.progress' do
786 786 assert_select 'td.closed[style=?]', 'width: 40%;'
787 787 end
788 788 end
789 789 end
790 790
791 791 def test_index_with_spent_hours_column
792 792 get :index, :set_filter => 1, :c => %w(subject spent_hours)
793 793 assert_select 'table.issues tr#issue-3 td.spent_hours', :text => '1.00'
794 794 end
795 795
796 796 def test_index_should_not_show_spent_hours_column_without_permission
797 797 Role.anonymous.remove_permission! :view_time_entries
798 798 get :index, :set_filter => 1, :c => %w(subject spent_hours)
799 799 assert_select 'td.spent_hours', 0
800 800 end
801 801
802 802 def test_index_with_fixed_version_column
803 803 get :index, :set_filter => 1, :c => %w(fixed_version)
804 804 assert_select 'table.issues td.fixed_version' do
805 805 assert_select 'a[href=?]', '/versions/2', :text => '1.0'
806 806 end
807 807 end
808 808
809 809 def test_index_with_relations_column
810 810 IssueRelation.delete_all
811 811 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(7))
812 812 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(8), :issue_to => Issue.find(1))
813 813 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(1), :issue_to => Issue.find(11))
814 814 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(12), :issue_to => Issue.find(2))
815 815
816 816 get :index, :set_filter => 1, :c => %w(subject relations)
817 817 assert_response :success
818 818 assert_select "tr#issue-1 td.relations" do
819 819 assert_select "span", 3
820 820 assert_select "span", :text => "Related to #7"
821 821 assert_select "span", :text => "Related to #8"
822 822 assert_select "span", :text => "Blocks #11"
823 823 end
824 824 assert_select "tr#issue-2 td.relations" do
825 825 assert_select "span", 1
826 826 assert_select "span", :text => "Blocked by #12"
827 827 end
828 828 assert_select "tr#issue-3 td.relations" do
829 829 assert_select "span", 0
830 830 end
831 831
832 832 get :index, :set_filter => 1, :c => %w(relations), :format => 'csv'
833 833 assert_response :success
834 834 assert_equal 'text/csv; header=present', response.content_type
835 835 lines = response.body.chomp.split("\n")
836 836 assert_include '1,"Related to #7, Related to #8, Blocks #11"', lines
837 837 assert_include '2,Blocked by #12', lines
838 838 assert_include '3,""', lines
839 839
840 840 get :index, :set_filter => 1, :c => %w(subject relations), :format => 'pdf'
841 841 assert_response :success
842 842 assert_equal 'application/pdf', response.content_type
843 843 end
844 844
845 845 def test_index_with_description_column
846 846 get :index, :set_filter => 1, :c => %w(subject description)
847 847
848 848 assert_select 'table.issues thead th', 3 # columns: chekbox + id + subject
849 849 assert_select 'td.description[colspan=3]', :text => 'Unable to print recipes'
850 850
851 851 get :index, :set_filter => 1, :c => %w(subject description), :format => 'pdf'
852 852 assert_response :success
853 853 assert_equal 'application/pdf', response.content_type
854 854 end
855 855
856 856 def test_index_send_html_if_query_is_invalid
857 857 get :index, :f => ['start_date'], :op => {:start_date => '='}
858 858 assert_equal 'text/html', @response.content_type
859 859 assert_template 'index'
860 860 end
861 861
862 862 def test_index_send_nothing_if_query_is_invalid
863 863 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
864 864 assert_equal 'text/csv', @response.content_type
865 865 assert @response.body.blank?
866 866 end
867 867
868 868 def test_show_by_anonymous
869 869 get :show, :id => 1
870 870 assert_response :success
871 871 assert_template 'show'
872 872 assert_equal Issue.find(1), assigns(:issue)
873 873 assert_select 'div.issue div.description', :text => /Unable to print recipes/
874 874 # anonymous role is allowed to add a note
875 875 assert_select 'form#issue-form' do
876 876 assert_select 'fieldset' do
877 877 assert_select 'legend', :text => 'Notes'
878 878 assert_select 'textarea[name=?]', 'issue[notes]'
879 879 end
880 880 end
881 881 assert_select 'title', :text => "Bug #1: Can&#x27;t print recipes - eCookbook - Redmine"
882 882 end
883 883
884 884 def test_show_by_manager
885 885 @request.session[:user_id] = 2
886 886 get :show, :id => 1
887 887 assert_response :success
888 888 assert_select 'a', :text => /Quote/
889 889 assert_select 'form#issue-form' do
890 890 assert_select 'fieldset' do
891 891 assert_select 'legend', :text => 'Change properties'
892 892 assert_select 'input[name=?]', 'issue[subject]'
893 893 end
894 894 assert_select 'fieldset' do
895 895 assert_select 'legend', :text => 'Log time'
896 896 assert_select 'input[name=?]', 'time_entry[hours]'
897 897 end
898 898 assert_select 'fieldset' do
899 899 assert_select 'legend', :text => 'Notes'
900 900 assert_select 'textarea[name=?]', 'issue[notes]'
901 901 end
902 902 end
903 903 end
904 904
905 905 def test_show_should_display_update_form
906 906 @request.session[:user_id] = 2
907 907 get :show, :id => 1
908 908 assert_response :success
909 909
910 910 assert_select 'form#issue-form' do
911 911 assert_select 'input[name=?]', 'issue[is_private]'
912 912 assert_select 'select[name=?]', 'issue[project_id]'
913 913 assert_select 'select[name=?]', 'issue[tracker_id]'
914 914 assert_select 'input[name=?]', 'issue[subject]'
915 915 assert_select 'textarea[name=?]', 'issue[description]'
916 916 assert_select 'select[name=?]', 'issue[status_id]'
917 917 assert_select 'select[name=?]', 'issue[priority_id]'
918 918 assert_select 'select[name=?]', 'issue[assigned_to_id]'
919 919 assert_select 'select[name=?]', 'issue[category_id]'
920 920 assert_select 'select[name=?]', 'issue[fixed_version_id]'
921 921 assert_select 'input[name=?]', 'issue[parent_issue_id]'
922 922 assert_select 'input[name=?]', 'issue[start_date]'
923 923 assert_select 'input[name=?]', 'issue[due_date]'
924 924 assert_select 'select[name=?]', 'issue[done_ratio]'
925 925 assert_select 'input[name=?]', 'issue[custom_field_values][2]'
926 926 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
927 927 assert_select 'textarea[name=?]', 'issue[notes]'
928 928 end
929 929 end
930 930
931 931 def test_show_should_display_update_form_with_minimal_permissions
932 932 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
933 933 WorkflowTransition.delete_all :role_id => 1
934 934
935 935 @request.session[:user_id] = 2
936 936 get :show, :id => 1
937 937 assert_response :success
938 938
939 939 assert_select 'form#issue-form' do
940 940 assert_select 'input[name=?]', 'issue[is_private]', 0
941 941 assert_select 'select[name=?]', 'issue[project_id]', 0
942 942 assert_select 'select[name=?]', 'issue[tracker_id]', 0
943 943 assert_select 'input[name=?]', 'issue[subject]', 0
944 944 assert_select 'textarea[name=?]', 'issue[description]', 0
945 945 assert_select 'select[name=?]', 'issue[status_id]', 0
946 946 assert_select 'select[name=?]', 'issue[priority_id]', 0
947 947 assert_select 'select[name=?]', 'issue[assigned_to_id]', 0
948 948 assert_select 'select[name=?]', 'issue[category_id]', 0
949 949 assert_select 'select[name=?]', 'issue[fixed_version_id]', 0
950 950 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
951 951 assert_select 'input[name=?]', 'issue[start_date]', 0
952 952 assert_select 'input[name=?]', 'issue[due_date]', 0
953 953 assert_select 'select[name=?]', 'issue[done_ratio]', 0
954 954 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
955 955 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
956 956 assert_select 'textarea[name=?]', 'issue[notes]'
957 957 end
958 958 end
959 959
960 960 def test_show_should_display_update_form_with_workflow_permissions
961 961 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
962 962
963 963 @request.session[:user_id] = 2
964 964 get :show, :id => 1
965 965 assert_response :success
966 966
967 967 assert_select 'form#issue-form' do
968 968 assert_select 'input[name=?]', 'issue[is_private]', 0
969 969 assert_select 'select[name=?]', 'issue[project_id]', 0
970 970 assert_select 'select[name=?]', 'issue[tracker_id]', 0
971 971 assert_select 'input[name=?]', 'issue[subject]', 0
972 972 assert_select 'textarea[name=?]', 'issue[description]', 0
973 973 assert_select 'select[name=?]', 'issue[status_id]'
974 974 assert_select 'select[name=?]', 'issue[priority_id]', 0
975 975 assert_select 'select[name=?]', 'issue[assigned_to_id]'
976 976 assert_select 'select[name=?]', 'issue[category_id]', 0
977 977 assert_select 'select[name=?]', 'issue[fixed_version_id]'
978 978 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
979 979 assert_select 'input[name=?]', 'issue[start_date]', 0
980 980 assert_select 'input[name=?]', 'issue[due_date]', 0
981 981 assert_select 'select[name=?]', 'issue[done_ratio]'
982 982 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
983 983 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
984 984 assert_select 'textarea[name=?]', 'issue[notes]'
985 985 end
986 986 end
987 987
988 988 def test_show_should_not_display_update_form_without_permissions
989 989 Role.find(1).update_attribute :permissions, [:view_issues]
990 990
991 991 @request.session[:user_id] = 2
992 992 get :show, :id => 1
993 993 assert_response :success
994 994
995 995 assert_select 'form#issue-form', 0
996 996 end
997 997
998 998 def test_update_form_should_not_display_inactive_enumerations
999 999 assert !IssuePriority.find(15).active?
1000 1000
1001 1001 @request.session[:user_id] = 2
1002 1002 get :show, :id => 1
1003 1003 assert_response :success
1004 1004
1005 1005 assert_select 'form#issue-form' do
1006 1006 assert_select 'select[name=?]', 'issue[priority_id]' do
1007 1007 assert_select 'option[value=4]'
1008 1008 assert_select 'option[value=15]', 0
1009 1009 end
1010 1010 end
1011 1011 end
1012 1012
1013 1013 def test_update_form_should_allow_attachment_upload
1014 1014 @request.session[:user_id] = 2
1015 1015 get :show, :id => 1
1016 1016
1017 1017 assert_select 'form#issue-form[method=post][enctype=multipart/form-data]' do
1018 1018 assert_select 'input[type=file][name=?]', 'attachments[dummy][file]'
1019 1019 end
1020 1020 end
1021 1021
1022 1022 def test_show_should_deny_anonymous_access_without_permission
1023 1023 Role.anonymous.remove_permission!(:view_issues)
1024 1024 get :show, :id => 1
1025 1025 assert_response :redirect
1026 1026 end
1027 1027
1028 1028 def test_show_should_deny_anonymous_access_to_private_issue
1029 1029 Issue.where(:id => 1).update_all(["is_private = ?", true])
1030 1030 get :show, :id => 1
1031 1031 assert_response :redirect
1032 1032 end
1033 1033
1034 1034 def test_show_should_deny_non_member_access_without_permission
1035 1035 Role.non_member.remove_permission!(:view_issues)
1036 1036 @request.session[:user_id] = 9
1037 1037 get :show, :id => 1
1038 1038 assert_response 403
1039 1039 end
1040 1040
1041 1041 def test_show_should_deny_non_member_access_to_private_issue
1042 1042 Issue.where(:id => 1).update_all(["is_private = ?", true])
1043 1043 @request.session[:user_id] = 9
1044 1044 get :show, :id => 1
1045 1045 assert_response 403
1046 1046 end
1047 1047
1048 1048 def test_show_should_deny_member_access_without_permission
1049 1049 Role.find(1).remove_permission!(:view_issues)
1050 1050 @request.session[:user_id] = 2
1051 1051 get :show, :id => 1
1052 1052 assert_response 403
1053 1053 end
1054 1054
1055 1055 def test_show_should_deny_member_access_to_private_issue_without_permission
1056 1056 Issue.where(:id => 1).update_all(["is_private = ?", true])
1057 1057 @request.session[:user_id] = 3
1058 1058 get :show, :id => 1
1059 1059 assert_response 403
1060 1060 end
1061 1061
1062 1062 def test_show_should_allow_author_access_to_private_issue
1063 1063 Issue.where(:id => 1).update_all(["is_private = ?, author_id = 3", true])
1064 1064 @request.session[:user_id] = 3
1065 1065 get :show, :id => 1
1066 1066 assert_response :success
1067 1067 end
1068 1068
1069 1069 def test_show_should_allow_assignee_access_to_private_issue
1070 1070 Issue.where(:id => 1).update_all(["is_private = ?, assigned_to_id = 3", true])
1071 1071 @request.session[:user_id] = 3
1072 1072 get :show, :id => 1
1073 1073 assert_response :success
1074 1074 end
1075 1075
1076 1076 def test_show_should_allow_member_access_to_private_issue_with_permission
1077 1077 Issue.where(:id => 1).update_all(["is_private = ?", true])
1078 1078 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
1079 1079 @request.session[:user_id] = 3
1080 1080 get :show, :id => 1
1081 1081 assert_response :success
1082 1082 end
1083 1083
1084 1084 def test_show_should_not_disclose_relations_to_invisible_issues
1085 1085 Setting.cross_project_issue_relations = '1'
1086 1086 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
1087 1087 # Relation to a private project issue
1088 1088 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
1089 1089
1090 1090 get :show, :id => 1
1091 1091 assert_response :success
1092 1092
1093 1093 assert_select 'div#relations' do
1094 1094 assert_select 'a', :text => /#2$/
1095 1095 assert_select 'a', :text => /#4$/, :count => 0
1096 1096 end
1097 1097 end
1098 1098
1099 1099 def test_show_should_list_subtasks
1100 1100 Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1101 1101
1102 1102 get :show, :id => 1
1103 1103 assert_response :success
1104 1104
1105 1105 assert_select 'div#issue_tree' do
1106 1106 assert_select 'td.subject', :text => /Child Issue/
1107 1107 end
1108 1108 end
1109 1109
1110 1110 def test_show_should_list_parents
1111 1111 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1112 1112
1113 1113 get :show, :id => issue.id
1114 1114 assert_response :success
1115 1115
1116 1116 assert_select 'div.subject' do
1117 1117 assert_select 'h3', 'Child Issue'
1118 1118 assert_select 'a[href=/issues/1]'
1119 1119 end
1120 1120 end
1121 1121
1122 1122 def test_show_should_not_display_prev_next_links_without_query_in_session
1123 1123 get :show, :id => 1
1124 1124 assert_response :success
1125 1125 assert_nil assigns(:prev_issue_id)
1126 1126 assert_nil assigns(:next_issue_id)
1127 1127
1128 1128 assert_select 'div.next-prev-links', 0
1129 1129 end
1130 1130
1131 1131 def test_show_should_display_prev_next_links_with_query_in_session
1132 1132 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1133 1133 @request.session['issues_index_sort'] = 'id'
1134 1134
1135 1135 with_settings :display_subprojects_issues => '0' do
1136 1136 get :show, :id => 3
1137 1137 end
1138 1138
1139 1139 assert_response :success
1140 1140 # Previous and next issues for all projects
1141 1141 assert_equal 2, assigns(:prev_issue_id)
1142 1142 assert_equal 5, assigns(:next_issue_id)
1143 1143
1144 1144 count = Issue.open.visible.count
1145 1145
1146 1146 assert_select 'div.next-prev-links' do
1147 1147 assert_select 'a[href=/issues/2]', :text => /Previous/
1148 1148 assert_select 'a[href=/issues/5]', :text => /Next/
1149 1149 assert_select 'span.position', :text => "3 of #{count}"
1150 1150 end
1151 1151 end
1152 1152
1153 1153 def test_show_should_display_prev_next_links_with_saved_query_in_session
1154 1154 query = IssueQuery.create!(:name => 'test', :visibility => IssueQuery::VISIBILITY_PUBLIC, :user_id => 1,
1155 1155 :filters => {'status_id' => {:values => ['5'], :operator => '='}},
1156 1156 :sort_criteria => [['id', 'asc']])
1157 1157 @request.session[:query] = {:id => query.id, :project_id => nil}
1158 1158
1159 1159 get :show, :id => 11
1160 1160
1161 1161 assert_response :success
1162 1162 assert_equal query, assigns(:query)
1163 1163 # Previous and next issues for all projects
1164 1164 assert_equal 8, assigns(:prev_issue_id)
1165 1165 assert_equal 12, assigns(:next_issue_id)
1166 1166
1167 1167 assert_select 'div.next-prev-links' do
1168 1168 assert_select 'a[href=/issues/8]', :text => /Previous/
1169 1169 assert_select 'a[href=/issues/12]', :text => /Next/
1170 1170 end
1171 1171 end
1172 1172
1173 1173 def test_show_should_display_prev_next_links_with_query_and_sort_on_association
1174 1174 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1175 1175
1176 1176 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
1177 1177 @request.session['issues_index_sort'] = assoc_sort
1178 1178
1179 1179 get :show, :id => 3
1180 1180 assert_response :success, "Wrong response status for #{assoc_sort} sort"
1181 1181
1182 1182 assert_select 'div.next-prev-links' do
1183 1183 assert_select 'a', :text => /(Previous|Next)/
1184 1184 end
1185 1185 end
1186 1186 end
1187 1187
1188 1188 def test_show_should_display_prev_next_links_with_project_query_in_session
1189 1189 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1190 1190 @request.session['issues_index_sort'] = 'id'
1191 1191
1192 1192 with_settings :display_subprojects_issues => '0' do
1193 1193 get :show, :id => 3
1194 1194 end
1195 1195
1196 1196 assert_response :success
1197 1197 # Previous and next issues inside project
1198 1198 assert_equal 2, assigns(:prev_issue_id)
1199 1199 assert_equal 7, assigns(:next_issue_id)
1200 1200
1201 1201 assert_select 'div.next-prev-links' do
1202 1202 assert_select 'a[href=/issues/2]', :text => /Previous/
1203 1203 assert_select 'a[href=/issues/7]', :text => /Next/
1204 1204 end
1205 1205 end
1206 1206
1207 1207 def test_show_should_not_display_prev_link_for_first_issue
1208 1208 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1209 1209 @request.session['issues_index_sort'] = 'id'
1210 1210
1211 1211 with_settings :display_subprojects_issues => '0' do
1212 1212 get :show, :id => 1
1213 1213 end
1214 1214
1215 1215 assert_response :success
1216 1216 assert_nil assigns(:prev_issue_id)
1217 1217 assert_equal 2, assigns(:next_issue_id)
1218 1218
1219 1219 assert_select 'div.next-prev-links' do
1220 1220 assert_select 'a', :text => /Previous/, :count => 0
1221 1221 assert_select 'a[href=/issues/2]', :text => /Next/
1222 1222 end
1223 1223 end
1224 1224
1225 1225 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
1226 1226 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
1227 1227 @request.session['issues_index_sort'] = 'id'
1228 1228
1229 1229 get :show, :id => 1
1230 1230
1231 1231 assert_response :success
1232 1232 assert_nil assigns(:prev_issue_id)
1233 1233 assert_nil assigns(:next_issue_id)
1234 1234
1235 1235 assert_select 'a', :text => /Previous/, :count => 0
1236 1236 assert_select 'a', :text => /Next/, :count => 0
1237 1237 end
1238 1238
1239 1239 def test_show_show_should_display_prev_next_links_with_query_sort_by_user_custom_field
1240 1240 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
1241 1241 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
1242 1242 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
1243 1243 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
1244 1244 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
1245 1245
1246 1246 query = IssueQuery.create!(:name => 'test', :visibility => IssueQuery::VISIBILITY_PUBLIC, :user_id => 1, :filters => {},
1247 1247 :sort_criteria => [["cf_#{cf.id}", 'asc'], ['id', 'asc']])
1248 1248 @request.session[:query] = {:id => query.id, :project_id => nil}
1249 1249
1250 1250 get :show, :id => 3
1251 1251 assert_response :success
1252 1252
1253 1253 assert_equal 2, assigns(:prev_issue_id)
1254 1254 assert_equal 1, assigns(:next_issue_id)
1255 1255
1256 1256 assert_select 'div.next-prev-links' do
1257 1257 assert_select 'a[href=/issues/2]', :text => /Previous/
1258 1258 assert_select 'a[href=/issues/1]', :text => /Next/
1259 1259 end
1260 1260 end
1261 1261
1262 1262 def test_show_should_display_link_to_the_assignee
1263 1263 get :show, :id => 2
1264 1264 assert_response :success
1265 1265 assert_select '.assigned-to' do
1266 1266 assert_select 'a[href=/users/3]'
1267 1267 end
1268 1268 end
1269 1269
1270 1270 def test_show_should_display_visible_changesets_from_other_projects
1271 1271 project = Project.find(2)
1272 1272 issue = project.issues.first
1273 1273 issue.changeset_ids = [102]
1274 1274 issue.save!
1275 1275 # changesets from other projects should be displayed even if repository
1276 1276 # is disabled on issue's project
1277 1277 project.disable_module! :repository
1278 1278
1279 1279 @request.session[:user_id] = 2
1280 1280 get :show, :id => issue.id
1281 1281
1282 1282 assert_select 'a[href=?]', '/projects/ecookbook/repository/revisions/3'
1283 1283 end
1284 1284
1285 1285 def test_show_should_display_watchers
1286 1286 @request.session[:user_id] = 2
1287 1287 Issue.find(1).add_watcher User.find(2)
1288 1288
1289 1289 get :show, :id => 1
1290 1290 assert_select 'div#watchers ul' do
1291 1291 assert_select 'li' do
1292 1292 assert_select 'a[href=/users/2]'
1293 1293 assert_select 'a img[alt=Delete]'
1294 1294 end
1295 1295 end
1296 1296 end
1297 1297
1298 1298 def test_show_should_display_watchers_with_gravatars
1299 1299 @request.session[:user_id] = 2
1300 1300 Issue.find(1).add_watcher User.find(2)
1301 1301
1302 1302 with_settings :gravatar_enabled => '1' do
1303 1303 get :show, :id => 1
1304 1304 end
1305 1305
1306 1306 assert_select 'div#watchers ul' do
1307 1307 assert_select 'li' do
1308 1308 assert_select 'img.gravatar'
1309 1309 assert_select 'a[href=/users/2]'
1310 1310 assert_select 'a img[alt=Delete]'
1311 1311 end
1312 1312 end
1313 1313 end
1314 1314
1315 1315 def test_show_with_thumbnails_enabled_should_display_thumbnails
1316 1316 @request.session[:user_id] = 2
1317 1317
1318 1318 with_settings :thumbnails_enabled => '1' do
1319 1319 get :show, :id => 14
1320 1320 assert_response :success
1321 1321 end
1322 1322
1323 1323 assert_select 'div.thumbnails' do
1324 1324 assert_select 'a[href=/attachments/16/testfile.png]' do
1325 1325 assert_select 'img[src=/attachments/thumbnail/16]'
1326 1326 end
1327 1327 end
1328 1328 end
1329 1329
1330 1330 def test_show_with_thumbnails_disabled_should_not_display_thumbnails
1331 1331 @request.session[:user_id] = 2
1332 1332
1333 1333 with_settings :thumbnails_enabled => '0' do
1334 1334 get :show, :id => 14
1335 1335 assert_response :success
1336 1336 end
1337 1337
1338 1338 assert_select 'div.thumbnails', 0
1339 1339 end
1340 1340
1341 1341 def test_show_with_multi_custom_field
1342 1342 field = CustomField.find(1)
1343 1343 field.update_attribute :multiple, true
1344 1344 issue = Issue.find(1)
1345 1345 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
1346 1346 issue.save!
1347 1347
1348 1348 get :show, :id => 1
1349 1349 assert_response :success
1350 1350
1351 1351 assert_select 'td', :text => 'MySQL, Oracle'
1352 1352 end
1353 1353
1354 1354 def test_show_with_multi_user_custom_field
1355 1355 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1356 1356 :tracker_ids => [1], :is_for_all => true)
1357 1357 issue = Issue.find(1)
1358 1358 issue.custom_field_values = {field.id => ['2', '3']}
1359 1359 issue.save!
1360 1360
1361 1361 get :show, :id => 1
1362 1362 assert_response :success
1363 1363
1364 1364 assert_select "td.cf_#{field.id}", :text => 'Dave Lopper, John Smith' do
1365 1365 assert_select 'a', :text => 'Dave Lopper'
1366 1366 assert_select 'a', :text => 'John Smith'
1367 1367 end
1368 1368 end
1369 1369
1370 1370 def test_show_should_display_private_notes_with_permission_only
1371 1371 journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true, :user_id => 1)
1372 1372 @request.session[:user_id] = 2
1373 1373
1374 1374 get :show, :id => 2
1375 1375 assert_response :success
1376 1376 assert_include journal, assigns(:journals)
1377 1377
1378 1378 Role.find(1).remove_permission! :view_private_notes
1379 1379 get :show, :id => 2
1380 1380 assert_response :success
1381 1381 assert_not_include journal, assigns(:journals)
1382 1382 end
1383 1383
1384 1384 def test_show_atom
1385 1385 get :show, :id => 2, :format => 'atom'
1386 1386 assert_response :success
1387 1387 assert_template 'journals/index'
1388 1388 # Inline image
1389 1389 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1390 1390 end
1391 1391
1392 1392 def test_show_export_to_pdf
1393 1393 get :show, :id => 3, :format => 'pdf'
1394 1394 assert_response :success
1395 1395 assert_equal 'application/pdf', @response.content_type
1396 1396 assert @response.body.starts_with?('%PDF')
1397 1397 assert_not_nil assigns(:issue)
1398 1398 end
1399 1399
1400 1400 def test_show_export_to_pdf_with_ancestors
1401 1401 issue = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1402 1402
1403 1403 get :show, :id => issue.id, :format => 'pdf'
1404 1404 assert_response :success
1405 1405 assert_equal 'application/pdf', @response.content_type
1406 1406 assert @response.body.starts_with?('%PDF')
1407 1407 end
1408 1408
1409 1409 def test_show_export_to_pdf_with_descendants
1410 1410 c1 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1411 1411 c2 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1412 1412 c3 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => c1.id)
1413 1413
1414 1414 get :show, :id => 1, :format => 'pdf'
1415 1415 assert_response :success
1416 1416 assert_equal 'application/pdf', @response.content_type
1417 1417 assert @response.body.starts_with?('%PDF')
1418 1418 end
1419 1419
1420 1420 def test_show_export_to_pdf_with_journals
1421 1421 get :show, :id => 1, :format => 'pdf'
1422 1422 assert_response :success
1423 1423 assert_equal 'application/pdf', @response.content_type
1424 1424 assert @response.body.starts_with?('%PDF')
1425 1425 end
1426 1426
1427 1427 def test_show_export_to_pdf_with_changesets
1428 1428 [[100], [100, 101], [100, 101, 102]].each do |cs|
1429 1429 issue1 = Issue.find(3)
1430 1430 issue1.changesets = Changeset.find(cs)
1431 1431 issue1.save!
1432 1432 issue = Issue.find(3)
1433 1433 assert_equal issue.changesets.count, cs.size
1434 1434 get :show, :id => 3, :format => 'pdf'
1435 1435 assert_response :success
1436 1436 assert_equal 'application/pdf', @response.content_type
1437 1437 assert @response.body.starts_with?('%PDF')
1438 1438 end
1439 1439 end
1440 1440
1441 1441 def test_show_invalid_should_respond_with_404
1442 1442 get :show, :id => 999
1443 1443 assert_response 404
1444 1444 end
1445 1445
1446 1446 def test_get_new
1447 1447 @request.session[:user_id] = 2
1448 1448 get :new, :project_id => 1, :tracker_id => 1
1449 1449 assert_response :success
1450 1450 assert_template 'new'
1451 1451
1452 1452 assert_select 'form#issue-form' do
1453 1453 assert_select 'input[name=?]', 'issue[is_private]'
1454 1454 assert_select 'select[name=?]', 'issue[project_id]', 0
1455 1455 assert_select 'select[name=?]', 'issue[tracker_id]'
1456 1456 assert_select 'input[name=?]', 'issue[subject]'
1457 1457 assert_select 'textarea[name=?]', 'issue[description]'
1458 1458 assert_select 'select[name=?]', 'issue[status_id]'
1459 1459 assert_select 'select[name=?]', 'issue[priority_id]'
1460 1460 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1461 1461 assert_select 'select[name=?]', 'issue[category_id]'
1462 1462 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1463 1463 assert_select 'input[name=?]', 'issue[parent_issue_id]'
1464 1464 assert_select 'input[name=?]', 'issue[start_date]'
1465 1465 assert_select 'input[name=?]', 'issue[due_date]'
1466 1466 assert_select 'select[name=?]', 'issue[done_ratio]'
1467 1467 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1468 1468 assert_select 'input[name=?]', 'issue[watcher_user_ids][]'
1469 1469 end
1470 1470
1471 1471 # Be sure we don't display inactive IssuePriorities
1472 1472 assert ! IssuePriority.find(15).active?
1473 1473 assert_select 'select[name=?]', 'issue[priority_id]' do
1474 1474 assert_select 'option[value=15]', 0
1475 1475 end
1476 1476 end
1477 1477
1478 1478 def test_get_new_with_minimal_permissions
1479 1479 Role.find(1).update_attribute :permissions, [:add_issues]
1480 1480 WorkflowTransition.delete_all :role_id => 1
1481 1481
1482 1482 @request.session[:user_id] = 2
1483 1483 get :new, :project_id => 1, :tracker_id => 1
1484 1484 assert_response :success
1485 1485 assert_template 'new'
1486 1486
1487 1487 assert_select 'form#issue-form' do
1488 1488 assert_select 'input[name=?]', 'issue[is_private]', 0
1489 1489 assert_select 'select[name=?]', 'issue[project_id]', 0
1490 1490 assert_select 'select[name=?]', 'issue[tracker_id]'
1491 1491 assert_select 'input[name=?]', 'issue[subject]'
1492 1492 assert_select 'textarea[name=?]', 'issue[description]'
1493 1493 assert_select 'select[name=?]', 'issue[status_id]'
1494 1494 assert_select 'select[name=?]', 'issue[priority_id]'
1495 1495 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1496 1496 assert_select 'select[name=?]', 'issue[category_id]'
1497 1497 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1498 1498 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
1499 1499 assert_select 'input[name=?]', 'issue[start_date]'
1500 1500 assert_select 'input[name=?]', 'issue[due_date]'
1501 1501 assert_select 'select[name=?]', 'issue[done_ratio]'
1502 1502 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1503 1503 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
1504 1504 end
1505 1505 end
1506 1506
1507 1507 def test_get_new_with_list_custom_field
1508 1508 @request.session[:user_id] = 2
1509 1509 get :new, :project_id => 1, :tracker_id => 1
1510 1510 assert_response :success
1511 1511 assert_template 'new'
1512 1512
1513 1513 assert_select 'select.list_cf[name=?]', 'issue[custom_field_values][1]' do
1514 1514 assert_select 'option', 4
1515 1515 assert_select 'option[value=MySQL]', :text => 'MySQL'
1516 1516 end
1517 1517 end
1518 1518
1519 1519 def test_get_new_with_multi_custom_field
1520 1520 field = IssueCustomField.find(1)
1521 1521 field.update_attribute :multiple, true
1522 1522
1523 1523 @request.session[:user_id] = 2
1524 1524 get :new, :project_id => 1, :tracker_id => 1
1525 1525 assert_response :success
1526 1526 assert_template 'new'
1527 1527
1528 1528 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
1529 1529 assert_select 'option', 3
1530 1530 assert_select 'option[value=MySQL]', :text => 'MySQL'
1531 1531 end
1532 1532 assert_select 'input[name=?][type=hidden][value=?]', 'issue[custom_field_values][1][]', ''
1533 1533 end
1534 1534
1535 1535 def test_get_new_with_multi_user_custom_field
1536 1536 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1537 1537 :tracker_ids => [1], :is_for_all => true)
1538 1538
1539 1539 @request.session[:user_id] = 2
1540 1540 get :new, :project_id => 1, :tracker_id => 1
1541 1541 assert_response :success
1542 1542 assert_template 'new'
1543 1543
1544 1544 assert_select 'select[name=?][multiple=multiple]', "issue[custom_field_values][#{field.id}][]" do
1545 1545 assert_select 'option', Project.find(1).users.count
1546 1546 assert_select 'option[value=2]', :text => 'John Smith'
1547 1547 end
1548 1548 assert_select 'input[name=?][type=hidden][value=?]', "issue[custom_field_values][#{field.id}][]", ''
1549 1549 end
1550 1550
1551 1551 def test_get_new_with_date_custom_field
1552 1552 field = IssueCustomField.create!(:name => 'Date', :field_format => 'date', :tracker_ids => [1], :is_for_all => true)
1553 1553
1554 1554 @request.session[:user_id] = 2
1555 1555 get :new, :project_id => 1, :tracker_id => 1
1556 1556 assert_response :success
1557 1557
1558 1558 assert_select 'input[name=?]', "issue[custom_field_values][#{field.id}]"
1559 1559 end
1560 1560
1561 1561 def test_get_new_with_text_custom_field
1562 1562 field = IssueCustomField.create!(:name => 'Text', :field_format => 'text', :tracker_ids => [1], :is_for_all => true)
1563 1563
1564 1564 @request.session[:user_id] = 2
1565 1565 get :new, :project_id => 1, :tracker_id => 1
1566 1566 assert_response :success
1567 1567
1568 1568 assert_select 'textarea[name=?]', "issue[custom_field_values][#{field.id}]"
1569 1569 end
1570 1570
1571 1571 def test_get_new_without_default_start_date_is_creation_date
1572 1572 with_settings :default_issue_start_date_to_creation_date => 0 do
1573 1573 @request.session[:user_id] = 2
1574 1574 get :new, :project_id => 1, :tracker_id => 1
1575 1575 assert_response :success
1576 1576 assert_template 'new'
1577 1577 assert_select 'input[name=?]', 'issue[start_date]'
1578 1578 assert_select 'input[name=?][value]', 'issue[start_date]', 0
1579 1579 end
1580 1580 end
1581 1581
1582 1582 def test_get_new_with_default_start_date_is_creation_date
1583 1583 with_settings :default_issue_start_date_to_creation_date => 1 do
1584 1584 @request.session[:user_id] = 2
1585 1585 get :new, :project_id => 1, :tracker_id => 1
1586 1586 assert_response :success
1587 1587 assert_template 'new'
1588 1588 assert_select 'input[name=?][value=?]', 'issue[start_date]',
1589 1589 Date.today.to_s
1590 1590 end
1591 1591 end
1592 1592
1593 1593 def test_get_new_form_should_allow_attachment_upload
1594 1594 @request.session[:user_id] = 2
1595 1595 get :new, :project_id => 1, :tracker_id => 1
1596 1596
1597 1597 assert_select 'form[id=issue-form][method=post][enctype=multipart/form-data]' do
1598 1598 assert_select 'input[name=?][type=file]', 'attachments[dummy][file]'
1599 1599 end
1600 1600 end
1601 1601
1602 1602 def test_get_new_should_prefill_the_form_from_params
1603 1603 @request.session[:user_id] = 2
1604 1604 get :new, :project_id => 1,
1605 1605 :issue => {:tracker_id => 3, :description => 'Prefilled', :custom_field_values => {'2' => 'Custom field value'}}
1606 1606
1607 1607 issue = assigns(:issue)
1608 1608 assert_equal 3, issue.tracker_id
1609 1609 assert_equal 'Prefilled', issue.description
1610 1610 assert_equal 'Custom field value', issue.custom_field_value(2)
1611 1611
1612 1612 assert_select 'select[name=?]', 'issue[tracker_id]' do
1613 1613 assert_select 'option[value=3][selected=selected]'
1614 1614 end
1615 1615 assert_select 'textarea[name=?]', 'issue[description]', :text => /Prefilled/
1616 1616 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Custom field value'
1617 1617 end
1618 1618
1619 1619 def test_get_new_should_mark_required_fields
1620 1620 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1621 1621 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1622 1622 WorkflowPermission.delete_all
1623 1623 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1624 1624 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1625 1625 @request.session[:user_id] = 2
1626 1626
1627 1627 get :new, :project_id => 1
1628 1628 assert_response :success
1629 1629 assert_template 'new'
1630 1630
1631 1631 assert_select 'label[for=issue_start_date]' do
1632 1632 assert_select 'span[class=required]', 0
1633 1633 end
1634 1634 assert_select 'label[for=issue_due_date]' do
1635 1635 assert_select 'span[class=required]'
1636 1636 end
1637 1637 assert_select 'label[for=?]', "issue_custom_field_values_#{cf1.id}" do
1638 1638 assert_select 'span[class=required]', 0
1639 1639 end
1640 1640 assert_select 'label[for=?]', "issue_custom_field_values_#{cf2.id}" do
1641 1641 assert_select 'span[class=required]'
1642 1642 end
1643 1643 end
1644 1644
1645 1645 def test_get_new_should_not_display_readonly_fields
1646 1646 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1647 1647 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1648 1648 WorkflowPermission.delete_all
1649 1649 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1650 1650 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1651 1651 @request.session[:user_id] = 2
1652 1652
1653 1653 get :new, :project_id => 1
1654 1654 assert_response :success
1655 1655 assert_template 'new'
1656 1656
1657 1657 assert_select 'input[name=?]', 'issue[start_date]'
1658 1658 assert_select 'input[name=?]', 'issue[due_date]', 0
1659 1659 assert_select 'input[name=?]', "issue[custom_field_values][#{cf1.id}]"
1660 1660 assert_select 'input[name=?]', "issue[custom_field_values][#{cf2.id}]", 0
1661 1661 end
1662 1662
1663 1663 def test_get_new_without_tracker_id
1664 1664 @request.session[:user_id] = 2
1665 1665 get :new, :project_id => 1
1666 1666 assert_response :success
1667 1667 assert_template 'new'
1668 1668
1669 1669 issue = assigns(:issue)
1670 1670 assert_not_nil issue
1671 1671 assert_equal Project.find(1).trackers.first, issue.tracker
1672 1672 end
1673 1673
1674 1674 def test_get_new_with_no_default_status_should_display_an_error
1675 1675 @request.session[:user_id] = 2
1676 1676 IssueStatus.delete_all
1677 1677
1678 1678 get :new, :project_id => 1
1679 1679 assert_response 500
1680 1680 assert_error_tag :content => /No default issue/
1681 1681 end
1682 1682
1683 1683 def test_get_new_with_no_tracker_should_display_an_error
1684 1684 @request.session[:user_id] = 2
1685 1685 Tracker.delete_all
1686 1686
1687 1687 get :new, :project_id => 1
1688 1688 assert_response 500
1689 1689 assert_error_tag :content => /No tracker/
1690 1690 end
1691 1691
1692 1692 def test_update_form_for_new_issue
1693 1693 @request.session[:user_id] = 2
1694 1694 xhr :post, :update_form, :project_id => 1,
1695 1695 :issue => {:tracker_id => 2,
1696 1696 :subject => 'This is the test_new issue',
1697 1697 :description => 'This is the description',
1698 1698 :priority_id => 5}
1699 1699 assert_response :success
1700 1700 assert_template 'update_form'
1701 1701 assert_template 'form'
1702 1702 assert_equal 'text/javascript', response.content_type
1703 1703
1704 1704 issue = assigns(:issue)
1705 1705 assert_kind_of Issue, issue
1706 1706 assert_equal 1, issue.project_id
1707 1707 assert_equal 2, issue.tracker_id
1708 1708 assert_equal 'This is the test_new issue', issue.subject
1709 1709 end
1710 1710
1711 1711 def test_update_form_for_new_issue_should_propose_transitions_based_on_initial_status
1712 1712 @request.session[:user_id] = 2
1713 1713 WorkflowTransition.delete_all
1714 1714 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
1715 1715 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5)
1716 1716 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4)
1717 1717
1718 1718 xhr :post, :update_form, :project_id => 1,
1719 1719 :issue => {:tracker_id => 1,
1720 1720 :status_id => 5,
1721 1721 :subject => 'This is an issue'}
1722 1722
1723 1723 assert_equal 5, assigns(:issue).status_id
1724 1724 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
1725 1725 end
1726 1726
1727 1727 def test_post_create
1728 1728 @request.session[:user_id] = 2
1729 1729 assert_difference 'Issue.count' do
1730 1730 post :create, :project_id => 1,
1731 1731 :issue => {:tracker_id => 3,
1732 1732 :status_id => 2,
1733 1733 :subject => 'This is the test_new issue',
1734 1734 :description => 'This is the description',
1735 1735 :priority_id => 5,
1736 1736 :start_date => '2010-11-07',
1737 1737 :estimated_hours => '',
1738 1738 :custom_field_values => {'2' => 'Value for field 2'}}
1739 1739 end
1740 1740 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1741 1741
1742 1742 issue = Issue.find_by_subject('This is the test_new issue')
1743 1743 assert_not_nil issue
1744 1744 assert_equal 2, issue.author_id
1745 1745 assert_equal 3, issue.tracker_id
1746 1746 assert_equal 2, issue.status_id
1747 1747 assert_equal Date.parse('2010-11-07'), issue.start_date
1748 1748 assert_nil issue.estimated_hours
1749 1749 v = issue.custom_values.where(:custom_field_id => 2).first
1750 1750 assert_not_nil v
1751 1751 assert_equal 'Value for field 2', v.value
1752 1752 end
1753 1753
1754 1754 def test_post_new_with_group_assignment
1755 1755 group = Group.find(11)
1756 1756 project = Project.find(1)
1757 1757 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
1758 1758
1759 1759 with_settings :issue_group_assignment => '1' do
1760 1760 @request.session[:user_id] = 2
1761 1761 assert_difference 'Issue.count' do
1762 1762 post :create, :project_id => project.id,
1763 1763 :issue => {:tracker_id => 3,
1764 1764 :status_id => 1,
1765 1765 :subject => 'This is the test_new_with_group_assignment issue',
1766 1766 :assigned_to_id => group.id}
1767 1767 end
1768 1768 end
1769 1769 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1770 1770
1771 1771 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1772 1772 assert_not_nil issue
1773 1773 assert_equal group, issue.assigned_to
1774 1774 end
1775 1775
1776 1776 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1777 1777 with_settings :default_issue_start_date_to_creation_date => 0 do
1778 1778 @request.session[:user_id] = 2
1779 1779 assert_difference 'Issue.count' do
1780 1780 post :create, :project_id => 1,
1781 1781 :issue => {:tracker_id => 3,
1782 1782 :status_id => 2,
1783 1783 :subject => 'This is the test_new issue',
1784 1784 :description => 'This is the description',
1785 1785 :priority_id => 5,
1786 1786 :estimated_hours => '',
1787 1787 :custom_field_values => {'2' => 'Value for field 2'}}
1788 1788 end
1789 1789 assert_redirected_to :controller => 'issues', :action => 'show',
1790 1790 :id => Issue.last.id
1791 1791 issue = Issue.find_by_subject('This is the test_new issue')
1792 1792 assert_not_nil issue
1793 1793 assert_nil issue.start_date
1794 1794 end
1795 1795 end
1796 1796
1797 1797 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1798 1798 with_settings :default_issue_start_date_to_creation_date => 1 do
1799 1799 @request.session[:user_id] = 2
1800 1800 assert_difference 'Issue.count' do
1801 1801 post :create, :project_id => 1,
1802 1802 :issue => {:tracker_id => 3,
1803 1803 :status_id => 2,
1804 1804 :subject => 'This is the test_new issue',
1805 1805 :description => 'This is the description',
1806 1806 :priority_id => 5,
1807 1807 :estimated_hours => '',
1808 1808 :custom_field_values => {'2' => 'Value for field 2'}}
1809 1809 end
1810 1810 assert_redirected_to :controller => 'issues', :action => 'show',
1811 1811 :id => Issue.last.id
1812 1812 issue = Issue.find_by_subject('This is the test_new issue')
1813 1813 assert_not_nil issue
1814 1814 assert_equal Date.today, issue.start_date
1815 1815 end
1816 1816 end
1817 1817
1818 1818 def test_post_create_and_continue
1819 1819 @request.session[:user_id] = 2
1820 1820 assert_difference 'Issue.count' do
1821 1821 post :create, :project_id => 1,
1822 1822 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1823 1823 :continue => ''
1824 1824 end
1825 1825
1826 1826 issue = Issue.order('id DESC').first
1827 1827 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1828 1828 assert_not_nil flash[:notice], "flash was not set"
1829 1829 assert_include %|<a href="/issues/#{issue.id}" title="This is first issue">##{issue.id}</a>|, flash[:notice], "issue link not found in the flash message"
1830 1830 end
1831 1831
1832 1832 def test_post_create_without_custom_fields_param
1833 1833 @request.session[:user_id] = 2
1834 1834 assert_difference 'Issue.count' do
1835 1835 post :create, :project_id => 1,
1836 1836 :issue => {:tracker_id => 1,
1837 1837 :subject => 'This is the test_new issue',
1838 1838 :description => 'This is the description',
1839 1839 :priority_id => 5}
1840 1840 end
1841 1841 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1842 1842 end
1843 1843
1844 1844 def test_post_create_with_multi_custom_field
1845 1845 field = IssueCustomField.find_by_name('Database')
1846 1846 field.update_attribute(:multiple, true)
1847 1847
1848 1848 @request.session[:user_id] = 2
1849 1849 assert_difference 'Issue.count' do
1850 1850 post :create, :project_id => 1,
1851 1851 :issue => {:tracker_id => 1,
1852 1852 :subject => 'This is the test_new issue',
1853 1853 :description => 'This is the description',
1854 1854 :priority_id => 5,
1855 1855 :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
1856 1856 end
1857 1857 assert_response 302
1858 1858 issue = Issue.order('id DESC').first
1859 1859 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
1860 1860 end
1861 1861
1862 1862 def test_post_create_with_empty_multi_custom_field
1863 1863 field = IssueCustomField.find_by_name('Database')
1864 1864 field.update_attribute(:multiple, true)
1865 1865
1866 1866 @request.session[:user_id] = 2
1867 1867 assert_difference 'Issue.count' do
1868 1868 post :create, :project_id => 1,
1869 1869 :issue => {:tracker_id => 1,
1870 1870 :subject => 'This is the test_new issue',
1871 1871 :description => 'This is the description',
1872 1872 :priority_id => 5,
1873 1873 :custom_field_values => {'1' => ['']}}
1874 1874 end
1875 1875 assert_response 302
1876 1876 issue = Issue.order('id DESC').first
1877 1877 assert_equal [''], issue.custom_field_value(1).sort
1878 1878 end
1879 1879
1880 1880 def test_post_create_with_multi_user_custom_field
1881 1881 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1882 1882 :tracker_ids => [1], :is_for_all => true)
1883 1883
1884 1884 @request.session[:user_id] = 2
1885 1885 assert_difference 'Issue.count' do
1886 1886 post :create, :project_id => 1,
1887 1887 :issue => {:tracker_id => 1,
1888 1888 :subject => 'This is the test_new issue',
1889 1889 :description => 'This is the description',
1890 1890 :priority_id => 5,
1891 1891 :custom_field_values => {field.id.to_s => ['', '2', '3']}}
1892 1892 end
1893 1893 assert_response 302
1894 1894 issue = Issue.order('id DESC').first
1895 1895 assert_equal ['2', '3'], issue.custom_field_value(field).sort
1896 1896 end
1897 1897
1898 1898 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1899 1899 field = IssueCustomField.find_by_name('Database')
1900 1900 field.update_attribute(:is_required, true)
1901 1901
1902 1902 @request.session[:user_id] = 2
1903 1903 assert_no_difference 'Issue.count' do
1904 1904 post :create, :project_id => 1,
1905 1905 :issue => {:tracker_id => 1,
1906 1906 :subject => 'This is the test_new issue',
1907 1907 :description => 'This is the description',
1908 1908 :priority_id => 5}
1909 1909 end
1910 1910 assert_response :success
1911 1911 assert_template 'new'
1912 1912 issue = assigns(:issue)
1913 1913 assert_not_nil issue
1914 1914 assert_error_tag :content => /Database can&#x27;t be blank/
1915 1915 end
1916 1916
1917 1917 def test_create_should_validate_required_fields
1918 1918 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1919 1919 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1920 1920 WorkflowPermission.delete_all
1921 1921 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1922 1922 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1923 1923 @request.session[:user_id] = 2
1924 1924
1925 1925 assert_no_difference 'Issue.count' do
1926 1926 post :create, :project_id => 1, :issue => {
1927 1927 :tracker_id => 2,
1928 1928 :status_id => 1,
1929 1929 :subject => 'Test',
1930 1930 :start_date => '',
1931 1931 :due_date => '',
1932 1932 :custom_field_values => {cf1.id.to_s => '', cf2.id.to_s => ''}
1933 1933 }
1934 1934 assert_response :success
1935 1935 assert_template 'new'
1936 1936 end
1937 1937
1938 1938 assert_error_tag :content => /Due date can&#x27;t be blank/i
1939 1939 assert_error_tag :content => /Bar can&#x27;t be blank/i
1940 1940 end
1941 1941
1942 1942 def test_create_should_ignore_readonly_fields
1943 1943 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1944 1944 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1945 1945 WorkflowPermission.delete_all
1946 1946 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1947 1947 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1948 1948 @request.session[:user_id] = 2
1949 1949
1950 1950 assert_difference 'Issue.count' do
1951 1951 post :create, :project_id => 1, :issue => {
1952 1952 :tracker_id => 2,
1953 1953 :status_id => 1,
1954 1954 :subject => 'Test',
1955 1955 :start_date => '2012-07-14',
1956 1956 :due_date => '2012-07-16',
1957 1957 :custom_field_values => {cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'}
1958 1958 }
1959 1959 assert_response 302
1960 1960 end
1961 1961
1962 1962 issue = Issue.order('id DESC').first
1963 1963 assert_equal Date.parse('2012-07-14'), issue.start_date
1964 1964 assert_nil issue.due_date
1965 1965 assert_equal 'value1', issue.custom_field_value(cf1)
1966 1966 assert_nil issue.custom_field_value(cf2)
1967 1967 end
1968 1968
1969 1969 def test_post_create_with_watchers
1970 1970 @request.session[:user_id] = 2
1971 1971 ActionMailer::Base.deliveries.clear
1972 1972
1973 1973 assert_difference 'Watcher.count', 2 do
1974 1974 post :create, :project_id => 1,
1975 1975 :issue => {:tracker_id => 1,
1976 1976 :subject => 'This is a new issue with watchers',
1977 1977 :description => 'This is the description',
1978 1978 :priority_id => 5,
1979 1979 :watcher_user_ids => ['2', '3']}
1980 1980 end
1981 1981 issue = Issue.find_by_subject('This is a new issue with watchers')
1982 1982 assert_not_nil issue
1983 1983 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1984 1984
1985 1985 # Watchers added
1986 1986 assert_equal [2, 3], issue.watcher_user_ids.sort
1987 1987 assert issue.watched_by?(User.find(3))
1988 1988 # Watchers notified
1989 1989 mail = ActionMailer::Base.deliveries.last
1990 1990 assert_not_nil mail
1991 1991 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1992 1992 end
1993 1993
1994 1994 def test_post_create_subissue
1995 1995 @request.session[:user_id] = 2
1996 1996
1997 1997 assert_difference 'Issue.count' do
1998 1998 post :create, :project_id => 1,
1999 1999 :issue => {:tracker_id => 1,
2000 2000 :subject => 'This is a child issue',
2001 2001 :parent_issue_id => '2'}
2002 2002 assert_response 302
2003 2003 end
2004 2004 issue = Issue.order('id DESC').first
2005 2005 assert_equal Issue.find(2), issue.parent
2006 2006 end
2007 2007
2008 2008 def test_post_create_subissue_with_sharp_parent_id
2009 2009 @request.session[:user_id] = 2
2010 2010
2011 2011 assert_difference 'Issue.count' do
2012 2012 post :create, :project_id => 1,
2013 2013 :issue => {:tracker_id => 1,
2014 2014 :subject => 'This is a child issue',
2015 2015 :parent_issue_id => '#2'}
2016 2016 assert_response 302
2017 2017 end
2018 2018 issue = Issue.order('id DESC').first
2019 2019 assert_equal Issue.find(2), issue.parent
2020 2020 end
2021 2021
2022 2022 def test_post_create_subissue_with_non_visible_parent_id_should_not_validate
2023 2023 @request.session[:user_id] = 2
2024 2024
2025 2025 assert_no_difference 'Issue.count' do
2026 2026 post :create, :project_id => 1,
2027 2027 :issue => {:tracker_id => 1,
2028 2028 :subject => 'This is a child issue',
2029 2029 :parent_issue_id => '4'}
2030 2030
2031 2031 assert_response :success
2032 2032 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '4'
2033 2033 assert_error_tag :content => /Parent task is invalid/i
2034 2034 end
2035 2035 end
2036 2036
2037 2037 def test_post_create_subissue_with_non_numeric_parent_id_should_not_validate
2038 2038 @request.session[:user_id] = 2
2039 2039
2040 2040 assert_no_difference 'Issue.count' do
2041 2041 post :create, :project_id => 1,
2042 2042 :issue => {:tracker_id => 1,
2043 2043 :subject => 'This is a child issue',
2044 2044 :parent_issue_id => '01ABC'}
2045 2045
2046 2046 assert_response :success
2047 2047 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '01ABC'
2048 2048 assert_error_tag :content => /Parent task is invalid/i
2049 2049 end
2050 2050 end
2051 2051
2052 2052 def test_post_create_private
2053 2053 @request.session[:user_id] = 2
2054 2054
2055 2055 assert_difference 'Issue.count' do
2056 2056 post :create, :project_id => 1,
2057 2057 :issue => {:tracker_id => 1,
2058 2058 :subject => 'This is a private issue',
2059 2059 :is_private => '1'}
2060 2060 end
2061 2061 issue = Issue.order('id DESC').first
2062 2062 assert issue.is_private?
2063 2063 end
2064 2064
2065 2065 def test_post_create_private_with_set_own_issues_private_permission
2066 2066 role = Role.find(1)
2067 2067 role.remove_permission! :set_issues_private
2068 2068 role.add_permission! :set_own_issues_private
2069 2069
2070 2070 @request.session[:user_id] = 2
2071 2071
2072 2072 assert_difference 'Issue.count' do
2073 2073 post :create, :project_id => 1,
2074 2074 :issue => {:tracker_id => 1,
2075 2075 :subject => 'This is a private issue',
2076 2076 :is_private => '1'}
2077 2077 end
2078 2078 issue = Issue.order('id DESC').first
2079 2079 assert issue.is_private?
2080 2080 end
2081 2081
2082 2082 def test_post_create_should_send_a_notification
2083 2083 ActionMailer::Base.deliveries.clear
2084 2084 @request.session[:user_id] = 2
2085 2085 assert_difference 'Issue.count' do
2086 2086 post :create, :project_id => 1,
2087 2087 :issue => {:tracker_id => 3,
2088 2088 :subject => 'This is the test_new issue',
2089 2089 :description => 'This is the description',
2090 2090 :priority_id => 5,
2091 2091 :estimated_hours => '',
2092 2092 :custom_field_values => {'2' => 'Value for field 2'}}
2093 2093 end
2094 2094 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
2095 2095
2096 2096 assert_equal 1, ActionMailer::Base.deliveries.size
2097 2097 end
2098 2098
2099 2099 def test_post_create_should_preserve_fields_values_on_validation_failure
2100 2100 @request.session[:user_id] = 2
2101 2101 post :create, :project_id => 1,
2102 2102 :issue => {:tracker_id => 1,
2103 2103 # empty subject
2104 2104 :subject => '',
2105 2105 :description => 'This is a description',
2106 2106 :priority_id => 6,
2107 2107 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
2108 2108 assert_response :success
2109 2109 assert_template 'new'
2110 2110
2111 2111 assert_select 'textarea[name=?]', 'issue[description]', :text => 'This is a description'
2112 2112 assert_select 'select[name=?]', 'issue[priority_id]' do
2113 2113 assert_select 'option[value=6][selected=selected]', :text => 'High'
2114 2114 end
2115 2115 # Custom fields
2116 2116 assert_select 'select[name=?]', 'issue[custom_field_values][1]' do
2117 2117 assert_select 'option[value=Oracle][selected=selected]', :text => 'Oracle'
2118 2118 end
2119 2119 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Value for field 2'
2120 2120 end
2121 2121
2122 2122 def test_post_create_with_failure_should_preserve_watchers
2123 2123 assert !User.find(8).member_of?(Project.find(1))
2124 2124
2125 2125 @request.session[:user_id] = 2
2126 2126 post :create, :project_id => 1,
2127 2127 :issue => {:tracker_id => 1,
2128 2128 :watcher_user_ids => ['3', '8']}
2129 2129 assert_response :success
2130 2130 assert_template 'new'
2131 2131
2132 2132 assert_select 'input[name=?][value=2]:not(checked)', 'issue[watcher_user_ids][]'
2133 2133 assert_select 'input[name=?][value=3][checked=checked]', 'issue[watcher_user_ids][]'
2134 2134 assert_select 'input[name=?][value=8][checked=checked]', 'issue[watcher_user_ids][]'
2135 2135 end
2136 2136
2137 2137 def test_post_create_should_ignore_non_safe_attributes
2138 2138 @request.session[:user_id] = 2
2139 2139 assert_nothing_raised do
2140 2140 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
2141 2141 end
2142 2142 end
2143 2143
2144 2144 def test_post_create_with_attachment
2145 2145 set_tmp_attachments_directory
2146 2146 @request.session[:user_id] = 2
2147 2147
2148 2148 assert_difference 'Issue.count' do
2149 2149 assert_difference 'Attachment.count' do
2150 2150 post :create, :project_id => 1,
2151 2151 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2152 2152 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2153 2153 end
2154 2154 end
2155 2155
2156 2156 issue = Issue.order('id DESC').first
2157 2157 attachment = Attachment.order('id DESC').first
2158 2158
2159 2159 assert_equal issue, attachment.container
2160 2160 assert_equal 2, attachment.author_id
2161 2161 assert_equal 'testfile.txt', attachment.filename
2162 2162 assert_equal 'text/plain', attachment.content_type
2163 2163 assert_equal 'test file', attachment.description
2164 2164 assert_equal 59, attachment.filesize
2165 2165 assert File.exists?(attachment.diskfile)
2166 2166 assert_equal 59, File.size(attachment.diskfile)
2167 2167 end
2168 2168
2169 2169 def test_post_create_with_attachment_should_notify_with_attachments
2170 2170 ActionMailer::Base.deliveries.clear
2171 2171 set_tmp_attachments_directory
2172 2172 @request.session[:user_id] = 2
2173 2173
2174 2174 with_settings :host_name => 'mydomain.foo', :protocol => 'http' do
2175 2175 assert_difference 'Issue.count' do
2176 2176 post :create, :project_id => 1,
2177 2177 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2178 2178 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2179 2179 end
2180 2180 end
2181 2181
2182 2182 assert_not_nil ActionMailer::Base.deliveries.last
2183 2183 assert_select_email do
2184 2184 assert_select 'a[href^=?]', 'http://mydomain.foo/attachments/download', 'testfile.txt'
2185 2185 end
2186 2186 end
2187 2187
2188 2188 def test_post_create_with_failure_should_save_attachments
2189 2189 set_tmp_attachments_directory
2190 2190 @request.session[:user_id] = 2
2191 2191
2192 2192 assert_no_difference 'Issue.count' do
2193 2193 assert_difference 'Attachment.count' do
2194 2194 post :create, :project_id => 1,
2195 2195 :issue => { :tracker_id => '1', :subject => '' },
2196 2196 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2197 2197 assert_response :success
2198 2198 assert_template 'new'
2199 2199 end
2200 2200 end
2201 2201
2202 2202 attachment = Attachment.order('id DESC').first
2203 2203 assert_equal 'testfile.txt', attachment.filename
2204 2204 assert File.exists?(attachment.diskfile)
2205 2205 assert_nil attachment.container
2206 2206
2207 2207 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2208 2208 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2209 2209 end
2210 2210
2211 2211 def test_post_create_with_failure_should_keep_saved_attachments
2212 2212 set_tmp_attachments_directory
2213 2213 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2214 2214 @request.session[:user_id] = 2
2215 2215
2216 2216 assert_no_difference 'Issue.count' do
2217 2217 assert_no_difference 'Attachment.count' do
2218 2218 post :create, :project_id => 1,
2219 2219 :issue => { :tracker_id => '1', :subject => '' },
2220 2220 :attachments => {'p0' => {'token' => attachment.token}}
2221 2221 assert_response :success
2222 2222 assert_template 'new'
2223 2223 end
2224 2224 end
2225 2225
2226 2226 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2227 2227 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2228 2228 end
2229 2229
2230 2230 def test_post_create_should_attach_saved_attachments
2231 2231 set_tmp_attachments_directory
2232 2232 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2233 2233 @request.session[:user_id] = 2
2234 2234
2235 2235 assert_difference 'Issue.count' do
2236 2236 assert_no_difference 'Attachment.count' do
2237 2237 post :create, :project_id => 1,
2238 2238 :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
2239 2239 :attachments => {'p0' => {'token' => attachment.token}}
2240 2240 assert_response 302
2241 2241 end
2242 2242 end
2243 2243
2244 2244 issue = Issue.order('id DESC').first
2245 2245 assert_equal 1, issue.attachments.count
2246 2246
2247 2247 attachment.reload
2248 2248 assert_equal issue, attachment.container
2249 2249 end
2250 2250
2251 2251 context "without workflow privilege" do
2252 2252 setup do
2253 2253 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2254 2254 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2255 2255 end
2256 2256
2257 2257 context "#new" do
2258 2258 should "propose default status only" do
2259 2259 get :new, :project_id => 1
2260 2260 assert_response :success
2261 2261 assert_template 'new'
2262 2262 assert_select 'select[name=?]', 'issue[status_id]' do
2263 2263 assert_select 'option', 1
2264 2264 assert_select 'option[value=?]', IssueStatus.default.id.to_s
2265 2265 end
2266 2266 end
2267 2267
2268 2268 should "accept default status" do
2269 2269 assert_difference 'Issue.count' do
2270 2270 post :create, :project_id => 1,
2271 2271 :issue => {:tracker_id => 1,
2272 2272 :subject => 'This is an issue',
2273 2273 :status_id => 1}
2274 2274 end
2275 2275 issue = Issue.order('id').last
2276 2276 assert_equal IssueStatus.default, issue.status
2277 2277 end
2278 2278
2279 2279 should "ignore unauthorized status" do
2280 2280 assert_difference 'Issue.count' do
2281 2281 post :create, :project_id => 1,
2282 2282 :issue => {:tracker_id => 1,
2283 2283 :subject => 'This is an issue',
2284 2284 :status_id => 3}
2285 2285 end
2286 2286 issue = Issue.order('id').last
2287 2287 assert_equal IssueStatus.default, issue.status
2288 2288 end
2289 2289 end
2290 2290
2291 2291 context "#update" do
2292 2292 should "ignore status change" do
2293 2293 assert_difference 'Journal.count' do
2294 2294 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2295 2295 end
2296 2296 assert_equal 1, Issue.find(1).status_id
2297 2297 end
2298 2298
2299 2299 should "ignore attributes changes" do
2300 2300 assert_difference 'Journal.count' do
2301 2301 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2302 2302 end
2303 2303 issue = Issue.find(1)
2304 2304 assert_equal "Can't print recipes", issue.subject
2305 2305 assert_nil issue.assigned_to
2306 2306 end
2307 2307 end
2308 2308 end
2309 2309
2310 2310 context "with workflow privilege" do
2311 2311 setup do
2312 2312 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2313 2313 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
2314 2314 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
2315 2315 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2316 2316 end
2317 2317
2318 2318 context "#update" do
2319 2319 should "accept authorized status" do
2320 2320 assert_difference 'Journal.count' do
2321 2321 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2322 2322 end
2323 2323 assert_equal 3, Issue.find(1).status_id
2324 2324 end
2325 2325
2326 2326 should "ignore unauthorized status" do
2327 2327 assert_difference 'Journal.count' do
2328 2328 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2329 2329 end
2330 2330 assert_equal 1, Issue.find(1).status_id
2331 2331 end
2332 2332
2333 2333 should "accept authorized attributes changes" do
2334 2334 assert_difference 'Journal.count' do
2335 2335 put :update, :id => 1, :issue => {:assigned_to_id => 2, :notes => 'just trying'}
2336 2336 end
2337 2337 issue = Issue.find(1)
2338 2338 assert_equal 2, issue.assigned_to_id
2339 2339 end
2340 2340
2341 2341 should "ignore unauthorized attributes changes" do
2342 2342 assert_difference 'Journal.count' do
2343 2343 put :update, :id => 1, :issue => {:subject => 'changed', :notes => 'just trying'}
2344 2344 end
2345 2345 issue = Issue.find(1)
2346 2346 assert_equal "Can't print recipes", issue.subject
2347 2347 end
2348 2348 end
2349 2349
2350 2350 context "and :edit_issues permission" do
2351 2351 setup do
2352 2352 Role.anonymous.add_permission! :add_issues, :edit_issues
2353 2353 end
2354 2354
2355 2355 should "accept authorized status" do
2356 2356 assert_difference 'Journal.count' do
2357 2357 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2358 2358 end
2359 2359 assert_equal 3, Issue.find(1).status_id
2360 2360 end
2361 2361
2362 2362 should "ignore unauthorized status" do
2363 2363 assert_difference 'Journal.count' do
2364 2364 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2365 2365 end
2366 2366 assert_equal 1, Issue.find(1).status_id
2367 2367 end
2368 2368
2369 2369 should "accept authorized attributes changes" do
2370 2370 assert_difference 'Journal.count' do
2371 2371 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2372 2372 end
2373 2373 issue = Issue.find(1)
2374 2374 assert_equal "changed", issue.subject
2375 2375 assert_equal 2, issue.assigned_to_id
2376 2376 end
2377 2377 end
2378 2378 end
2379 2379
2380 2380 def test_new_as_copy
2381 2381 @request.session[:user_id] = 2
2382 2382 get :new, :project_id => 1, :copy_from => 1
2383 2383
2384 2384 assert_response :success
2385 2385 assert_template 'new'
2386 2386
2387 2387 assert_not_nil assigns(:issue)
2388 2388 orig = Issue.find(1)
2389 2389 assert_equal 1, assigns(:issue).project_id
2390 2390 assert_equal orig.subject, assigns(:issue).subject
2391 2391 assert assigns(:issue).copy?
2392 2392
2393 2393 assert_select 'form[id=issue-form][action=/projects/ecookbook/issues]' do
2394 2394 assert_select 'select[name=?]', 'issue[project_id]' do
2395 2395 assert_select 'option[value=1][selected=selected]', :text => 'eCookbook'
2396 2396 assert_select 'option[value=2]:not([selected])', :text => 'OnlineStore'
2397 2397 end
2398 2398 assert_select 'input[name=copy_from][value=1]'
2399 2399 end
2400 2400
2401 2401 # "New issue" menu item should not link to copy
2402 2402 assert_select '#main-menu a.new-issue[href=/projects/ecookbook/issues/new]'
2403 2403 end
2404 2404
2405 2405 def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
2406 2406 @request.session[:user_id] = 2
2407 2407 issue = Issue.find(3)
2408 2408 assert issue.attachments.count > 0
2409 2409 get :new, :project_id => 1, :copy_from => 3
2410 2410
2411 2411 assert_select 'input[name=copy_attachments][type=checkbox][checked=checked][value=1]'
2412 2412 end
2413 2413
2414 2414 def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
2415 2415 @request.session[:user_id] = 2
2416 2416 issue = Issue.find(3)
2417 2417 issue.attachments.delete_all
2418 2418 get :new, :project_id => 1, :copy_from => 3
2419 2419
2420 2420 assert_select 'input[name=copy_attachments]', 0
2421 2421 end
2422 2422
2423 2423 def test_new_as_copy_with_subtasks_should_show_copy_subtasks_checkbox
2424 2424 @request.session[:user_id] = 2
2425 2425 issue = Issue.generate_with_descendants!
2426 2426 get :new, :project_id => 1, :copy_from => issue.id
2427 2427
2428 2428 assert_select 'input[type=checkbox][name=copy_subtasks][checked=checked][value=1]'
2429 2429 end
2430 2430
2431 2431 def test_new_as_copy_with_invalid_issue_should_respond_with_404
2432 2432 @request.session[:user_id] = 2
2433 2433 get :new, :project_id => 1, :copy_from => 99999
2434 2434 assert_response 404
2435 2435 end
2436 2436
2437 2437 def test_create_as_copy_on_different_project
2438 2438 @request.session[:user_id] = 2
2439 2439 assert_difference 'Issue.count' do
2440 2440 post :create, :project_id => 1, :copy_from => 1,
2441 2441 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2442 2442
2443 2443 assert_not_nil assigns(:issue)
2444 2444 assert assigns(:issue).copy?
2445 2445 end
2446 2446 issue = Issue.order('id DESC').first
2447 2447 assert_redirected_to "/issues/#{issue.id}"
2448 2448
2449 2449 assert_equal 2, issue.project_id
2450 2450 assert_equal 3, issue.tracker_id
2451 2451 assert_equal 'Copy', issue.subject
2452 2452 end
2453 2453
2454 2454 def test_create_as_copy_should_copy_attachments
2455 2455 @request.session[:user_id] = 2
2456 2456 issue = Issue.find(3)
2457 2457 count = issue.attachments.count
2458 2458 assert count > 0
2459 2459 assert_difference 'Issue.count' do
2460 2460 assert_difference 'Attachment.count', count do
2461 2461 assert_difference 'Journal.count', 2 do
2462 2462 post :create, :project_id => 1, :copy_from => 3,
2463 2463 :issue => {:project_id => '1', :tracker_id => '3',
2464 2464 :status_id => '1', :subject => 'Copy with attachments'},
2465 2465 :copy_attachments => '1'
2466 2466 end
2467 2467 end
2468 2468 end
2469 2469 copy = Issue.order('id DESC').first
2470 2470 assert_equal count, copy.attachments.count
2471 2471 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
2472 2472 end
2473 2473
2474 2474 def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
2475 2475 @request.session[:user_id] = 2
2476 2476 issue = Issue.find(3)
2477 2477 count = issue.attachments.count
2478 2478 assert count > 0
2479 2479 assert_difference 'Issue.count' do
2480 2480 assert_no_difference 'Attachment.count' do
2481 2481 assert_difference 'Journal.count', 2 do
2482 2482 post :create, :project_id => 1, :copy_from => 3,
2483 2483 :issue => {:project_id => '1', :tracker_id => '3',
2484 2484 :status_id => '1', :subject => 'Copy with attachments'}
2485 2485 end
2486 2486 end
2487 2487 end
2488 2488 copy = Issue.order('id DESC').first
2489 2489 assert_equal 0, copy.attachments.count
2490 2490 end
2491 2491
2492 2492 def test_create_as_copy_with_attachments_should_add_new_files
2493 2493 @request.session[:user_id] = 2
2494 2494 issue = Issue.find(3)
2495 2495 count = issue.attachments.count
2496 2496 assert count > 0
2497 2497 assert_difference 'Issue.count' do
2498 2498 assert_difference 'Attachment.count', count + 1 do
2499 2499 assert_difference 'Journal.count', 2 do
2500 2500 post :create, :project_id => 1, :copy_from => 3,
2501 2501 :issue => {:project_id => '1', :tracker_id => '3',
2502 2502 :status_id => '1', :subject => 'Copy with attachments'},
2503 2503 :copy_attachments => '1',
2504 2504 :attachments => {'1' =>
2505 2505 {'file' => uploaded_test_file('testfile.txt', 'text/plain'),
2506 2506 'description' => 'test file'}}
2507 2507 end
2508 2508 end
2509 2509 end
2510 2510 copy = Issue.order('id DESC').first
2511 2511 assert_equal count + 1, copy.attachments.count
2512 2512 end
2513 2513
2514 2514 def test_create_as_copy_should_add_relation_with_copied_issue
2515 2515 @request.session[:user_id] = 2
2516 2516 assert_difference 'Issue.count' do
2517 2517 assert_difference 'IssueRelation.count' do
2518 2518 post :create, :project_id => 1, :copy_from => 1,
2519 2519 :issue => {:project_id => '1', :tracker_id => '3',
2520 2520 :status_id => '1', :subject => 'Copy'}
2521 2521 end
2522 2522 end
2523 2523 copy = Issue.order('id DESC').first
2524 2524 assert_equal 1, copy.relations.size
2525 2525 end
2526 2526
2527 2527 def test_create_as_copy_should_copy_subtasks
2528 2528 @request.session[:user_id] = 2
2529 2529 issue = Issue.generate_with_descendants!
2530 2530 count = issue.descendants.count
2531 2531 assert_difference 'Issue.count', count + 1 do
2532 2532 assert_difference 'Journal.count', (count + 1) * 2 do
2533 2533 post :create, :project_id => 1, :copy_from => issue.id,
2534 2534 :issue => {:project_id => '1', :tracker_id => '3',
2535 2535 :status_id => '1', :subject => 'Copy with subtasks'},
2536 2536 :copy_subtasks => '1'
2537 2537 end
2538 2538 end
2539 2539 copy = Issue.where(:parent_id => nil).order('id DESC').first
2540 2540 assert_equal count, copy.descendants.count
2541 2541 assert_equal issue.descendants.map(&:subject).sort, copy.descendants.map(&:subject).sort
2542 2542 end
2543 2543
2544 2544 def test_create_as_copy_without_copy_subtasks_option_should_not_copy_subtasks
2545 2545 @request.session[:user_id] = 2
2546 2546 issue = Issue.generate_with_descendants!
2547 2547 assert_difference 'Issue.count', 1 do
2548 2548 assert_difference 'Journal.count', 2 do
2549 2549 post :create, :project_id => 1, :copy_from => 3,
2550 2550 :issue => {:project_id => '1', :tracker_id => '3',
2551 2551 :status_id => '1', :subject => 'Copy with subtasks'}
2552 2552 end
2553 2553 end
2554 2554 copy = Issue.where(:parent_id => nil).order('id DESC').first
2555 2555 assert_equal 0, copy.descendants.count
2556 2556 end
2557 2557
2558 2558 def test_create_as_copy_with_failure
2559 2559 @request.session[:user_id] = 2
2560 2560 post :create, :project_id => 1, :copy_from => 1,
2561 2561 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
2562 2562
2563 2563 assert_response :success
2564 2564 assert_template 'new'
2565 2565
2566 2566 assert_not_nil assigns(:issue)
2567 2567 assert assigns(:issue).copy?
2568 2568
2569 2569 assert_select 'form#issue-form[action=/projects/ecookbook/issues]' do
2570 2570 assert_select 'select[name=?]', 'issue[project_id]' do
2571 2571 assert_select 'option[value=1]:not([selected])', :text => 'eCookbook'
2572 2572 assert_select 'option[value=2][selected=selected]', :text => 'OnlineStore'
2573 2573 end
2574 2574 assert_select 'input[name=copy_from][value=1]'
2575 2575 end
2576 2576 end
2577 2577
2578 2578 def test_create_as_copy_on_project_without_permission_should_ignore_target_project
2579 2579 @request.session[:user_id] = 2
2580 2580 assert !User.find(2).member_of?(Project.find(4))
2581 2581
2582 2582 assert_difference 'Issue.count' do
2583 2583 post :create, :project_id => 1, :copy_from => 1,
2584 2584 :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2585 2585 end
2586 2586 issue = Issue.order('id DESC').first
2587 2587 assert_equal 1, issue.project_id
2588 2588 end
2589 2589
2590 2590 def test_get_edit
2591 2591 @request.session[:user_id] = 2
2592 2592 get :edit, :id => 1
2593 2593 assert_response :success
2594 2594 assert_template 'edit'
2595 2595 assert_not_nil assigns(:issue)
2596 2596 assert_equal Issue.find(1), assigns(:issue)
2597 2597
2598 2598 # Be sure we don't display inactive IssuePriorities
2599 2599 assert ! IssuePriority.find(15).active?
2600 2600 assert_select 'select[name=?]', 'issue[priority_id]' do
2601 2601 assert_select 'option[value=15]', 0
2602 2602 end
2603 2603 end
2604 2604
2605 2605 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
2606 2606 @request.session[:user_id] = 2
2607 2607 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
2608 2608
2609 2609 get :edit, :id => 1
2610 2610 assert_select 'input[name=?]', 'time_entry[hours]'
2611 2611 end
2612 2612
2613 2613 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
2614 2614 @request.session[:user_id] = 2
2615 2615 Role.find_by_name('Manager').remove_permission! :log_time
2616 2616
2617 2617 get :edit, :id => 1
2618 2618 assert_select 'input[name=?]', 'time_entry[hours]', 0
2619 2619 end
2620 2620
2621 2621 def test_get_edit_with_params
2622 2622 @request.session[:user_id] = 2
2623 2623 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
2624 2624 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => 10 }
2625 2625 assert_response :success
2626 2626 assert_template 'edit'
2627 2627
2628 2628 issue = assigns(:issue)
2629 2629 assert_not_nil issue
2630 2630
2631 2631 assert_equal 5, issue.status_id
2632 2632 assert_select 'select[name=?]', 'issue[status_id]' do
2633 2633 assert_select 'option[value=5][selected=selected]', :text => 'Closed'
2634 2634 end
2635 2635
2636 2636 assert_equal 7, issue.priority_id
2637 2637 assert_select 'select[name=?]', 'issue[priority_id]' do
2638 2638 assert_select 'option[value=7][selected=selected]', :text => 'Urgent'
2639 2639 end
2640 2640
2641 2641 assert_select 'input[name=?][value=2.5]', 'time_entry[hours]'
2642 2642 assert_select 'select[name=?]', 'time_entry[activity_id]' do
2643 2643 assert_select 'option[value=10][selected=selected]', :text => 'Development'
2644 2644 end
2645 2645 assert_select 'input[name=?][value=test_get_edit_with_params]', 'time_entry[comments]'
2646 2646 end
2647 2647
2648 2648 def test_get_edit_with_multi_custom_field
2649 2649 field = CustomField.find(1)
2650 2650 field.update_attribute :multiple, true
2651 2651 issue = Issue.find(1)
2652 2652 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2653 2653 issue.save!
2654 2654
2655 2655 @request.session[:user_id] = 2
2656 2656 get :edit, :id => 1
2657 2657 assert_response :success
2658 2658 assert_template 'edit'
2659 2659
2660 2660 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
2661 2661 assert_select 'option', 3
2662 2662 assert_select 'option[value=MySQL][selected=selected]'
2663 2663 assert_select 'option[value=Oracle][selected=selected]'
2664 2664 assert_select 'option[value=PostgreSQL]:not([selected])'
2665 2665 end
2666 2666 end
2667 2667
2668 2668 def test_update_form_for_existing_issue
2669 2669 @request.session[:user_id] = 2
2670 2670 xhr :put, :update_form, :project_id => 1,
2671 2671 :id => 1,
2672 2672 :issue => {:tracker_id => 2,
2673 2673 :subject => 'This is the test_new issue',
2674 2674 :description => 'This is the description',
2675 2675 :priority_id => 5}
2676 2676 assert_response :success
2677 2677 assert_equal 'text/javascript', response.content_type
2678 2678 assert_template 'update_form'
2679 2679 assert_template 'form'
2680 2680
2681 2681 issue = assigns(:issue)
2682 2682 assert_kind_of Issue, issue
2683 2683 assert_equal 1, issue.id
2684 2684 assert_equal 1, issue.project_id
2685 2685 assert_equal 2, issue.tracker_id
2686 2686 assert_equal 'This is the test_new issue', issue.subject
2687 2687 end
2688 2688
2689 2689 def test_update_form_for_existing_issue_should_keep_issue_author
2690 2690 @request.session[:user_id] = 3
2691 2691 xhr :put, :update_form, :project_id => 1, :id => 1, :issue => {:subject => 'Changed'}
2692 2692 assert_response :success
2693 2693 assert_equal 'text/javascript', response.content_type
2694 2694
2695 2695 issue = assigns(:issue)
2696 2696 assert_equal User.find(2), issue.author
2697 2697 assert_equal 2, issue.author_id
2698 2698 assert_not_equal User.current, issue.author
2699 2699 end
2700 2700
2701 2701 def test_update_form_for_existing_issue_should_propose_transitions_based_on_initial_status
2702 2702 @request.session[:user_id] = 2
2703 2703 WorkflowTransition.delete_all
2704 2704 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
2705 2705 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
2706 2706 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 5, :new_status_id => 4)
2707 2707
2708 2708 xhr :put, :update_form, :project_id => 1,
2709 2709 :id => 2,
2710 2710 :issue => {:tracker_id => 2,
2711 2711 :status_id => 5,
2712 2712 :subject => 'This is an issue'}
2713 2713
2714 2714 assert_equal 5, assigns(:issue).status_id
2715 2715 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
2716 2716 end
2717 2717
2718 2718 def test_update_form_for_existing_issue_with_project_change
2719 2719 @request.session[:user_id] = 2
2720 2720 xhr :put, :update_form, :project_id => 1,
2721 2721 :id => 1,
2722 2722 :issue => {:project_id => 2,
2723 2723 :tracker_id => 2,
2724 2724 :subject => 'This is the test_new issue',
2725 2725 :description => 'This is the description',
2726 2726 :priority_id => 5}
2727 2727 assert_response :success
2728 2728 assert_template 'form'
2729 2729
2730 2730 issue = assigns(:issue)
2731 2731 assert_kind_of Issue, issue
2732 2732 assert_equal 1, issue.id
2733 2733 assert_equal 2, issue.project_id
2734 2734 assert_equal 2, issue.tracker_id
2735 2735 assert_equal 'This is the test_new issue', issue.subject
2736 2736 end
2737 2737
2738 2738 def test_update_form_should_propose_default_status_for_existing_issue
2739 2739 @request.session[:user_id] = 2
2740 2740 WorkflowTransition.delete_all
2741 2741 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
2742 2742
2743 2743 xhr :put, :update_form, :project_id => 1, :id => 2
2744 2744 assert_response :success
2745 2745 assert_equal [2,3], assigns(:allowed_statuses).map(&:id).sort
2746 2746 end
2747 2747
2748 2748 def test_put_update_without_custom_fields_param
2749 2749 @request.session[:user_id] = 2
2750 2750 ActionMailer::Base.deliveries.clear
2751 2751
2752 2752 issue = Issue.find(1)
2753 2753 assert_equal '125', issue.custom_value_for(2).value
2754 2754 old_subject = issue.subject
2755 2755 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2756 2756
2757 2757 assert_difference('Journal.count') do
2758 2758 assert_difference('JournalDetail.count', 2) do
2759 2759 put :update, :id => 1, :issue => {:subject => new_subject,
2760 2760 :priority_id => '6',
2761 2761 :category_id => '1' # no change
2762 2762 }
2763 2763 end
2764 2764 end
2765 2765 assert_redirected_to :action => 'show', :id => '1'
2766 2766 issue.reload
2767 2767 assert_equal new_subject, issue.subject
2768 2768 # Make sure custom fields were not cleared
2769 2769 assert_equal '125', issue.custom_value_for(2).value
2770 2770
2771 2771 mail = ActionMailer::Base.deliveries.last
2772 2772 assert_not_nil mail
2773 2773 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2774 2774 assert_mail_body_match "Subject changed from #{old_subject} to #{new_subject}", mail
2775 2775 end
2776 2776
2777 2777 def test_put_update_with_project_change
2778 2778 @request.session[:user_id] = 2
2779 2779 ActionMailer::Base.deliveries.clear
2780 2780
2781 2781 assert_difference('Journal.count') do
2782 2782 assert_difference('JournalDetail.count', 3) do
2783 2783 put :update, :id => 1, :issue => {:project_id => '2',
2784 2784 :tracker_id => '1', # no change
2785 2785 :priority_id => '6',
2786 2786 :category_id => '3'
2787 2787 }
2788 2788 end
2789 2789 end
2790 2790 assert_redirected_to :action => 'show', :id => '1'
2791 2791 issue = Issue.find(1)
2792 2792 assert_equal 2, issue.project_id
2793 2793 assert_equal 1, issue.tracker_id
2794 2794 assert_equal 6, issue.priority_id
2795 2795 assert_equal 3, issue.category_id
2796 2796
2797 2797 mail = ActionMailer::Base.deliveries.last
2798 2798 assert_not_nil mail
2799 2799 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2800 2800 assert_mail_body_match "Project changed from eCookbook to OnlineStore", mail
2801 2801 end
2802 2802
2803 2803 def test_put_update_with_tracker_change
2804 2804 @request.session[:user_id] = 2
2805 2805 ActionMailer::Base.deliveries.clear
2806 2806
2807 2807 assert_difference('Journal.count') do
2808 2808 assert_difference('JournalDetail.count', 2) do
2809 2809 put :update, :id => 1, :issue => {:project_id => '1',
2810 2810 :tracker_id => '2',
2811 2811 :priority_id => '6'
2812 2812 }
2813 2813 end
2814 2814 end
2815 2815 assert_redirected_to :action => 'show', :id => '1'
2816 2816 issue = Issue.find(1)
2817 2817 assert_equal 1, issue.project_id
2818 2818 assert_equal 2, issue.tracker_id
2819 2819 assert_equal 6, issue.priority_id
2820 2820 assert_equal 1, issue.category_id
2821 2821
2822 2822 mail = ActionMailer::Base.deliveries.last
2823 2823 assert_not_nil mail
2824 2824 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2825 2825 assert_mail_body_match "Tracker changed from Bug to Feature request", mail
2826 2826 end
2827 2827
2828 2828 def test_put_update_with_custom_field_change
2829 2829 @request.session[:user_id] = 2
2830 2830 issue = Issue.find(1)
2831 2831 assert_equal '125', issue.custom_value_for(2).value
2832 2832
2833 2833 assert_difference('Journal.count') do
2834 2834 assert_difference('JournalDetail.count', 3) do
2835 2835 put :update, :id => 1, :issue => {:subject => 'Custom field change',
2836 2836 :priority_id => '6',
2837 2837 :category_id => '1', # no change
2838 2838 :custom_field_values => { '2' => 'New custom value' }
2839 2839 }
2840 2840 end
2841 2841 end
2842 2842 assert_redirected_to :action => 'show', :id => '1'
2843 2843 issue.reload
2844 2844 assert_equal 'New custom value', issue.custom_value_for(2).value
2845 2845
2846 2846 mail = ActionMailer::Base.deliveries.last
2847 2847 assert_not_nil mail
2848 2848 assert_mail_body_match "Searchable field changed from 125 to New custom value", mail
2849 2849 end
2850 2850
2851 2851 def test_put_update_with_multi_custom_field_change
2852 2852 field = CustomField.find(1)
2853 2853 field.update_attribute :multiple, true
2854 2854 issue = Issue.find(1)
2855 2855 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2856 2856 issue.save!
2857 2857
2858 2858 @request.session[:user_id] = 2
2859 2859 assert_difference('Journal.count') do
2860 2860 assert_difference('JournalDetail.count', 3) do
2861 2861 put :update, :id => 1,
2862 2862 :issue => {
2863 2863 :subject => 'Custom field change',
2864 2864 :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
2865 2865 }
2866 2866 end
2867 2867 end
2868 2868 assert_redirected_to :action => 'show', :id => '1'
2869 2869 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
2870 2870 end
2871 2871
2872 2872 def test_put_update_with_status_and_assignee_change
2873 2873 issue = Issue.find(1)
2874 2874 assert_equal 1, issue.status_id
2875 2875 @request.session[:user_id] = 2
2876 2876 assert_difference('TimeEntry.count', 0) do
2877 2877 put :update,
2878 2878 :id => 1,
2879 2879 :issue => { :status_id => 2, :assigned_to_id => 3, :notes => 'Assigned to dlopper' },
2880 2880 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
2881 2881 end
2882 2882 assert_redirected_to :action => 'show', :id => '1'
2883 2883 issue.reload
2884 2884 assert_equal 2, issue.status_id
2885 2885 j = Journal.order('id DESC').first
2886 2886 assert_equal 'Assigned to dlopper', j.notes
2887 2887 assert_equal 2, j.details.size
2888 2888
2889 2889 mail = ActionMailer::Base.deliveries.last
2890 2890 assert_mail_body_match "Status changed from New to Assigned", mail
2891 2891 # subject should contain the new status
2892 2892 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
2893 2893 end
2894 2894
2895 2895 def test_put_update_with_note_only
2896 2896 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
2897 2897 # anonymous user
2898 2898 put :update,
2899 2899 :id => 1,
2900 2900 :issue => { :notes => notes }
2901 2901 assert_redirected_to :action => 'show', :id => '1'
2902 2902 j = Journal.order('id DESC').first
2903 2903 assert_equal notes, j.notes
2904 2904 assert_equal 0, j.details.size
2905 2905 assert_equal User.anonymous, j.user
2906 2906
2907 2907 mail = ActionMailer::Base.deliveries.last
2908 2908 assert_mail_body_match notes, mail
2909 2909 end
2910 2910
2911 2911 def test_put_update_with_private_note_only
2912 2912 notes = 'Private note'
2913 2913 @request.session[:user_id] = 2
2914 2914
2915 2915 assert_difference 'Journal.count' do
2916 2916 put :update, :id => 1, :issue => {:notes => notes, :private_notes => '1'}
2917 2917 assert_redirected_to :action => 'show', :id => '1'
2918 2918 end
2919 2919
2920 2920 j = Journal.order('id DESC').first
2921 2921 assert_equal notes, j.notes
2922 2922 assert_equal true, j.private_notes
2923 2923 end
2924 2924
2925 2925 def test_put_update_with_private_note_and_changes
2926 2926 notes = 'Private note'
2927 2927 @request.session[:user_id] = 2
2928 2928
2929 2929 assert_difference 'Journal.count', 2 do
2930 2930 put :update, :id => 1, :issue => {:subject => 'New subject', :notes => notes, :private_notes => '1'}
2931 2931 assert_redirected_to :action => 'show', :id => '1'
2932 2932 end
2933 2933
2934 2934 j = Journal.order('id DESC').first
2935 2935 assert_equal notes, j.notes
2936 2936 assert_equal true, j.private_notes
2937 2937 assert_equal 0, j.details.count
2938 2938
2939 2939 j = Journal.order('id DESC').offset(1).first
2940 2940 assert_nil j.notes
2941 2941 assert_equal false, j.private_notes
2942 2942 assert_equal 1, j.details.count
2943 2943 end
2944 2944
2945 2945 def test_put_update_with_note_and_spent_time
2946 2946 @request.session[:user_id] = 2
2947 2947 spent_hours_before = Issue.find(1).spent_hours
2948 2948 assert_difference('TimeEntry.count') do
2949 2949 put :update,
2950 2950 :id => 1,
2951 2951 :issue => { :notes => '2.5 hours added' },
2952 2952 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
2953 2953 end
2954 2954 assert_redirected_to :action => 'show', :id => '1'
2955 2955
2956 2956 issue = Issue.find(1)
2957 2957
2958 2958 j = Journal.order('id DESC').first
2959 2959 assert_equal '2.5 hours added', j.notes
2960 2960 assert_equal 0, j.details.size
2961 2961
2962 2962 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
2963 2963 assert_not_nil t
2964 2964 assert_equal 2.5, t.hours
2965 2965 assert_equal spent_hours_before + 2.5, issue.spent_hours
2966 2966 end
2967 2967
2968 2968 def test_put_update_should_preserve_parent_issue_even_if_not_visible
2969 2969 parent = Issue.generate!(:project_id => 1, :is_private => true)
2970 2970 issue = Issue.generate!(:parent_issue_id => parent.id)
2971 2971 assert !parent.visible?(User.find(3))
2972 2972 @request.session[:user_id] = 3
2973 2973
2974 2974 get :edit, :id => issue.id
2975 2975 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', parent.id.to_s
2976 2976
2977 2977 put :update, :id => issue.id, :issue => {:subject => 'New subject', :parent_issue_id => parent.id.to_s}
2978 2978 assert_response 302
2979 2979 assert_equal parent, issue.parent
2980 2980 end
2981 2981
2982 2982 def test_put_update_with_attachment_only
2983 2983 set_tmp_attachments_directory
2984 2984
2985 2985 # Delete all fixtured journals, a race condition can occur causing the wrong
2986 2986 # journal to get fetched in the next find.
2987 2987 Journal.delete_all
2988 2988
2989 2989 # anonymous user
2990 2990 assert_difference 'Attachment.count' do
2991 2991 put :update, :id => 1,
2992 2992 :issue => {:notes => ''},
2993 2993 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2994 2994 end
2995 2995
2996 2996 assert_redirected_to :action => 'show', :id => '1'
2997 2997 j = Issue.find(1).journals.reorder('id DESC').first
2998 2998 assert j.notes.blank?
2999 2999 assert_equal 1, j.details.size
3000 3000 assert_equal 'testfile.txt', j.details.first.value
3001 3001 assert_equal User.anonymous, j.user
3002 3002
3003 3003 attachment = Attachment.order('id DESC').first
3004 3004 assert_equal Issue.find(1), attachment.container
3005 3005 assert_equal User.anonymous, attachment.author
3006 3006 assert_equal 'testfile.txt', attachment.filename
3007 3007 assert_equal 'text/plain', attachment.content_type
3008 3008 assert_equal 'test file', attachment.description
3009 3009 assert_equal 59, attachment.filesize
3010 3010 assert File.exists?(attachment.diskfile)
3011 3011 assert_equal 59, File.size(attachment.diskfile)
3012 3012
3013 3013 mail = ActionMailer::Base.deliveries.last
3014 3014 assert_mail_body_match 'testfile.txt', mail
3015 3015 end
3016 3016
3017 3017 def test_put_update_with_failure_should_save_attachments
3018 3018 set_tmp_attachments_directory
3019 3019 @request.session[:user_id] = 2
3020 3020
3021 3021 assert_no_difference 'Journal.count' do
3022 3022 assert_difference 'Attachment.count' do
3023 3023 put :update, :id => 1,
3024 3024 :issue => { :subject => '' },
3025 3025 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
3026 3026 assert_response :success
3027 3027 assert_template 'edit'
3028 3028 end
3029 3029 end
3030 3030
3031 3031 attachment = Attachment.order('id DESC').first
3032 3032 assert_equal 'testfile.txt', attachment.filename
3033 3033 assert File.exists?(attachment.diskfile)
3034 3034 assert_nil attachment.container
3035 3035
3036 3036 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
3037 3037 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
3038 3038 end
3039 3039
3040 3040 def test_put_update_with_failure_should_keep_saved_attachments
3041 3041 set_tmp_attachments_directory
3042 3042 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3043 3043 @request.session[:user_id] = 2
3044 3044
3045 3045 assert_no_difference 'Journal.count' do
3046 3046 assert_no_difference 'Attachment.count' do
3047 3047 put :update, :id => 1,
3048 3048 :issue => { :subject => '' },
3049 3049 :attachments => {'p0' => {'token' => attachment.token}}
3050 3050 assert_response :success
3051 3051 assert_template 'edit'
3052 3052 end
3053 3053 end
3054 3054
3055 3055 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
3056 3056 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
3057 3057 end
3058 3058
3059 3059 def test_put_update_should_attach_saved_attachments
3060 3060 set_tmp_attachments_directory
3061 3061 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3062 3062 @request.session[:user_id] = 2
3063 3063
3064 3064 assert_difference 'Journal.count' do
3065 3065 assert_difference 'JournalDetail.count' do
3066 3066 assert_no_difference 'Attachment.count' do
3067 3067 put :update, :id => 1,
3068 3068 :issue => {:notes => 'Attachment added'},
3069 3069 :attachments => {'p0' => {'token' => attachment.token}}
3070 3070 assert_redirected_to '/issues/1'
3071 3071 end
3072 3072 end
3073 3073 end
3074 3074
3075 3075 attachment.reload
3076 3076 assert_equal Issue.find(1), attachment.container
3077 3077
3078 3078 journal = Journal.order('id DESC').first
3079 3079 assert_equal 1, journal.details.size
3080 3080 assert_equal 'testfile.txt', journal.details.first.value
3081 3081 end
3082 3082
3083 3083 def test_put_update_with_attachment_that_fails_to_save
3084 3084 set_tmp_attachments_directory
3085 3085
3086 3086 # Delete all fixtured journals, a race condition can occur causing the wrong
3087 3087 # journal to get fetched in the next find.
3088 3088 Journal.delete_all
3089 3089
3090 3090 # Mock out the unsaved attachment
3091 3091 Attachment.any_instance.stubs(:create).returns(Attachment.new)
3092 3092
3093 3093 # anonymous user
3094 3094 put :update,
3095 3095 :id => 1,
3096 3096 :issue => {:notes => ''},
3097 3097 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
3098 3098 assert_redirected_to :action => 'show', :id => '1'
3099 3099 assert_equal '1 file(s) could not be saved.', flash[:warning]
3100 3100 end
3101 3101
3102 3102 def test_put_update_with_no_change
3103 3103 issue = Issue.find(1)
3104 3104 issue.journals.clear
3105 3105 ActionMailer::Base.deliveries.clear
3106 3106
3107 3107 put :update,
3108 3108 :id => 1,
3109 3109 :issue => {:notes => ''}
3110 3110 assert_redirected_to :action => 'show', :id => '1'
3111 3111
3112 3112 issue.reload
3113 3113 assert issue.journals.empty?
3114 3114 # No email should be sent
3115 3115 assert ActionMailer::Base.deliveries.empty?
3116 3116 end
3117 3117
3118 3118 def test_put_update_should_send_a_notification
3119 3119 @request.session[:user_id] = 2
3120 3120 ActionMailer::Base.deliveries.clear
3121 3121 issue = Issue.find(1)
3122 3122 old_subject = issue.subject
3123 3123 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
3124 3124
3125 3125 put :update, :id => 1, :issue => {:subject => new_subject,
3126 3126 :priority_id => '6',
3127 3127 :category_id => '1' # no change
3128 3128 }
3129 3129 assert_equal 1, ActionMailer::Base.deliveries.size
3130 3130 end
3131 3131
3132 3132 def test_put_update_with_invalid_spent_time_hours_only
3133 3133 @request.session[:user_id] = 2
3134 3134 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3135 3135
3136 3136 assert_no_difference('Journal.count') do
3137 3137 put :update,
3138 3138 :id => 1,
3139 3139 :issue => {:notes => notes},
3140 3140 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
3141 3141 end
3142 3142 assert_response :success
3143 3143 assert_template 'edit'
3144 3144
3145 3145 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3146 3146 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3147 3147 assert_select 'input[name=?][value=?]', 'time_entry[hours]', '2z'
3148 3148 end
3149 3149
3150 3150 def test_put_update_with_invalid_spent_time_comments_only
3151 3151 @request.session[:user_id] = 2
3152 3152 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3153 3153
3154 3154 assert_no_difference('Journal.count') do
3155 3155 put :update,
3156 3156 :id => 1,
3157 3157 :issue => {:notes => notes},
3158 3158 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
3159 3159 end
3160 3160 assert_response :success
3161 3161 assert_template 'edit'
3162 3162
3163 3163 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3164 3164 assert_error_tag :descendant => {:content => /Hours can&#x27;t be blank/}
3165 3165 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3166 3166 assert_select 'input[name=?][value=?]', 'time_entry[comments]', 'this is my comment'
3167 3167 end
3168 3168
3169 3169 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
3170 3170 issue = Issue.find(2)
3171 3171 @request.session[:user_id] = 2
3172 3172
3173 3173 put :update,
3174 3174 :id => issue.id,
3175 3175 :issue => {
3176 3176 :fixed_version_id => 4
3177 3177 }
3178 3178
3179 3179 assert_response :redirect
3180 3180 issue.reload
3181 3181 assert_equal 4, issue.fixed_version_id
3182 3182 assert_not_equal issue.project_id, issue.fixed_version.project_id
3183 3183 end
3184 3184
3185 3185 def test_put_update_should_redirect_back_using_the_back_url_parameter
3186 3186 issue = Issue.find(2)
3187 3187 @request.session[:user_id] = 2
3188 3188
3189 3189 put :update,
3190 3190 :id => issue.id,
3191 3191 :issue => {
3192 3192 :fixed_version_id => 4
3193 3193 },
3194 3194 :back_url => '/issues'
3195 3195
3196 3196 assert_response :redirect
3197 3197 assert_redirected_to '/issues'
3198 3198 end
3199 3199
3200 3200 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3201 3201 issue = Issue.find(2)
3202 3202 @request.session[:user_id] = 2
3203 3203
3204 3204 put :update,
3205 3205 :id => issue.id,
3206 3206 :issue => {
3207 3207 :fixed_version_id => 4
3208 3208 },
3209 3209 :back_url => 'http://google.com'
3210 3210
3211 3211 assert_response :redirect
3212 3212 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
3213 3213 end
3214 3214
3215 3215 def test_get_bulk_edit
3216 3216 @request.session[:user_id] = 2
3217 3217 get :bulk_edit, :ids => [1, 2]
3218 3218 assert_response :success
3219 3219 assert_template 'bulk_edit'
3220 3220
3221 3221 assert_select 'ul#bulk-selection' do
3222 3222 assert_select 'li', 2
3223 3223 assert_select 'li a', :text => 'Bug #1'
3224 3224 end
3225 3225
3226 3226 assert_select 'form#bulk_edit_form[action=?]', '/issues/bulk_update' do
3227 3227 assert_select 'input[name=?]', 'ids[]', 2
3228 3228 assert_select 'input[name=?][value=1][type=hidden]', 'ids[]'
3229 3229
3230 3230 assert_select 'select[name=?]', 'issue[project_id]'
3231 3231 assert_select 'input[name=?]', 'issue[parent_issue_id]'
3232 3232
3233 3233 # Project specific custom field, date type
3234 3234 field = CustomField.find(9)
3235 3235 assert !field.is_for_all?
3236 3236 assert_equal 'date', field.field_format
3237 3237 assert_select 'input[name=?]', 'issue[custom_field_values][9]'
3238 3238
3239 3239 # System wide custom field
3240 3240 assert CustomField.find(1).is_for_all?
3241 3241 assert_select 'select[name=?]', 'issue[custom_field_values][1]'
3242 3242
3243 3243 # Be sure we don't display inactive IssuePriorities
3244 3244 assert ! IssuePriority.find(15).active?
3245 3245 assert_select 'select[name=?]', 'issue[priority_id]' do
3246 3246 assert_select 'option[value=15]', 0
3247 3247 end
3248 3248 end
3249 3249 end
3250 3250
3251 3251 def test_get_bulk_edit_on_different_projects
3252 3252 @request.session[:user_id] = 2
3253 3253 get :bulk_edit, :ids => [1, 2, 6]
3254 3254 assert_response :success
3255 3255 assert_template 'bulk_edit'
3256 3256
3257 3257 # Can not set issues from different projects as children of an issue
3258 3258 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
3259 3259
3260 3260 # Project specific custom field, date type
3261 3261 field = CustomField.find(9)
3262 3262 assert !field.is_for_all?
3263 3263 assert !field.project_ids.include?(Issue.find(6).project_id)
3264 3264 assert_select 'input[name=?]', 'issue[custom_field_values][9]', 0
3265 3265 end
3266 3266
3267 3267 def test_get_bulk_edit_with_user_custom_field
3268 3268 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
3269 3269
3270 3270 @request.session[:user_id] = 2
3271 3271 get :bulk_edit, :ids => [1, 2]
3272 3272 assert_response :success
3273 3273 assert_template 'bulk_edit'
3274 3274
3275 3275 assert_select 'select.user_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3276 3276 assert_select 'option', Project.find(1).users.count + 2 # "no change" + "none" options
3277 3277 end
3278 3278 end
3279 3279
3280 3280 def test_get_bulk_edit_with_version_custom_field
3281 3281 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
3282 3282
3283 3283 @request.session[:user_id] = 2
3284 3284 get :bulk_edit, :ids => [1, 2]
3285 3285 assert_response :success
3286 3286 assert_template 'bulk_edit'
3287 3287
3288 3288 assert_select 'select.version_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3289 3289 assert_select 'option', Project.find(1).shared_versions.count + 2 # "no change" + "none" options
3290 3290 end
3291 3291 end
3292 3292
3293 3293 def test_get_bulk_edit_with_multi_custom_field
3294 3294 field = CustomField.find(1)
3295 3295 field.update_attribute :multiple, true
3296 3296
3297 3297 @request.session[:user_id] = 2
3298 3298 get :bulk_edit, :ids => [1, 2]
3299 3299 assert_response :success
3300 3300 assert_template 'bulk_edit'
3301 3301
3302 3302 assert_select 'select[name=?]', 'issue[custom_field_values][1][]' do
3303 3303 assert_select 'option', field.possible_values.size + 1 # "none" options
3304 3304 end
3305 3305 end
3306 3306
3307 3307 def test_bulk_edit_should_propose_to_clear_text_custom_fields
3308 3308 @request.session[:user_id] = 2
3309 3309 get :bulk_edit, :ids => [1, 3]
3310 3310 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', '__none__'
3311 3311 end
3312 3312
3313 3313 def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
3314 3314 WorkflowTransition.delete_all
3315 3315 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
3316 3316 :old_status_id => 1, :new_status_id => 1)
3317 3317 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
3318 3318 :old_status_id => 1, :new_status_id => 3)
3319 3319 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
3320 3320 :old_status_id => 1, :new_status_id => 4)
3321 3321 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,
3322 3322 :old_status_id => 2, :new_status_id => 1)
3323 3323 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,
3324 3324 :old_status_id => 2, :new_status_id => 3)
3325 3325 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2,
3326 3326 :old_status_id => 2, :new_status_id => 5)
3327 3327 @request.session[:user_id] = 2
3328 3328 get :bulk_edit, :ids => [1, 2]
3329 3329
3330 3330 assert_response :success
3331 3331 statuses = assigns(:available_statuses)
3332 3332 assert_not_nil statuses
3333 3333 assert_equal [1, 3], statuses.map(&:id).sort
3334 3334
3335 3335 assert_select 'select[name=?]', 'issue[status_id]' do
3336 3336 assert_select 'option', 3 # 2 statuses + "no change" option
3337 3337 end
3338 3338 end
3339 3339
3340 3340 def test_bulk_edit_should_propose_target_project_open_shared_versions
3341 3341 @request.session[:user_id] = 2
3342 3342 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3343 3343 assert_response :success
3344 3344 assert_template 'bulk_edit'
3345 3345 assert_equal Project.find(1).shared_versions.open.all.sort, assigns(:versions).sort
3346 3346
3347 3347 assert_select 'select[name=?]', 'issue[fixed_version_id]' do
3348 3348 assert_select 'option', :text => '2.0'
3349 3349 end
3350 3350 end
3351 3351
3352 3352 def test_bulk_edit_should_propose_target_project_categories
3353 3353 @request.session[:user_id] = 2
3354 3354 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3355 3355 assert_response :success
3356 3356 assert_template 'bulk_edit'
3357 3357 assert_equal Project.find(1).issue_categories.sort, assigns(:categories).sort
3358 3358
3359 3359 assert_select 'select[name=?]', 'issue[category_id]' do
3360 3360 assert_select 'option', :text => 'Recipes'
3361 3361 end
3362 3362 end
3363 3363
3364 3364 def test_bulk_update
3365 3365 @request.session[:user_id] = 2
3366 3366 # update issues priority
3367 3367 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3368 3368 :issue => {:priority_id => 7,
3369 3369 :assigned_to_id => '',
3370 3370 :custom_field_values => {'2' => ''}}
3371 3371
3372 3372 assert_response 302
3373 3373 # check that the issues were updated
3374 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
3374 assert_equal [7, 7], Issue.where(:id =>[1, 2]).collect {|i| i.priority.id}
3375 3375
3376 3376 issue = Issue.find(1)
3377 3377 journal = issue.journals.reorder('created_on DESC').first
3378 3378 assert_equal '125', issue.custom_value_for(2).value
3379 3379 assert_equal 'Bulk editing', journal.notes
3380 3380 assert_equal 1, journal.details.size
3381 3381 end
3382 3382
3383 3383 def test_bulk_update_with_group_assignee
3384 3384 group = Group.find(11)
3385 3385 project = Project.find(1)
3386 3386 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
3387 3387
3388 3388 @request.session[:user_id] = 2
3389 3389 # update issues assignee
3390 3390 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3391 3391 :issue => {:priority_id => '',
3392 3392 :assigned_to_id => group.id,
3393 3393 :custom_field_values => {'2' => ''}}
3394 3394
3395 3395 assert_response 302
3396 3396 assert_equal [group, group], Issue.where(:id => [1, 2]).collect {|i| i.assigned_to}
3397 3397 end
3398 3398
3399 3399 def test_bulk_update_on_different_projects
3400 3400 @request.session[:user_id] = 2
3401 3401 # update issues priority
3402 3402 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
3403 3403 :issue => {:priority_id => 7,
3404 3404 :assigned_to_id => '',
3405 3405 :custom_field_values => {'2' => ''}}
3406 3406
3407 3407 assert_response 302
3408 3408 # check that the issues were updated
3409 3409 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
3410 3410
3411 3411 issue = Issue.find(1)
3412 3412 journal = issue.journals.reorder('created_on DESC').first
3413 3413 assert_equal '125', issue.custom_value_for(2).value
3414 3414 assert_equal 'Bulk editing', journal.notes
3415 3415 assert_equal 1, journal.details.size
3416 3416 end
3417 3417
3418 3418 def test_bulk_update_on_different_projects_without_rights
3419 3419 @request.session[:user_id] = 3
3420 3420 user = User.find(3)
3421 3421 action = { :controller => "issues", :action => "bulk_update" }
3422 3422 assert user.allowed_to?(action, Issue.find(1).project)
3423 3423 assert ! user.allowed_to?(action, Issue.find(6).project)
3424 3424 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
3425 3425 :issue => {:priority_id => 7,
3426 3426 :assigned_to_id => '',
3427 3427 :custom_field_values => {'2' => ''}}
3428 3428 assert_response 403
3429 3429 assert_not_equal "Bulk should fail", Journal.last.notes
3430 3430 end
3431 3431
3432 3432 def test_bullk_update_should_send_a_notification
3433 3433 @request.session[:user_id] = 2
3434 3434 ActionMailer::Base.deliveries.clear
3435 3435 post(:bulk_update,
3436 3436 {
3437 3437 :ids => [1, 2],
3438 3438 :notes => 'Bulk editing',
3439 3439 :issue => {
3440 3440 :priority_id => 7,
3441 3441 :assigned_to_id => '',
3442 3442 :custom_field_values => {'2' => ''}
3443 3443 }
3444 3444 })
3445 3445
3446 3446 assert_response 302
3447 3447 assert_equal 2, ActionMailer::Base.deliveries.size
3448 3448 end
3449 3449
3450 3450 def test_bulk_update_project
3451 3451 @request.session[:user_id] = 2
3452 3452 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
3453 3453 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3454 3454 # Issues moved to project 2
3455 3455 assert_equal 2, Issue.find(1).project_id
3456 3456 assert_equal 2, Issue.find(2).project_id
3457 3457 # No tracker change
3458 3458 assert_equal 1, Issue.find(1).tracker_id
3459 3459 assert_equal 2, Issue.find(2).tracker_id
3460 3460 end
3461 3461
3462 3462 def test_bulk_update_project_on_single_issue_should_follow_when_needed
3463 3463 @request.session[:user_id] = 2
3464 3464 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
3465 3465 assert_redirected_to '/issues/1'
3466 3466 end
3467 3467
3468 3468 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
3469 3469 @request.session[:user_id] = 2
3470 3470 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
3471 3471 assert_redirected_to '/projects/onlinestore/issues'
3472 3472 end
3473 3473
3474 3474 def test_bulk_update_tracker
3475 3475 @request.session[:user_id] = 2
3476 3476 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
3477 3477 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3478 3478 assert_equal 2, Issue.find(1).tracker_id
3479 3479 assert_equal 2, Issue.find(2).tracker_id
3480 3480 end
3481 3481
3482 3482 def test_bulk_update_status
3483 3483 @request.session[:user_id] = 2
3484 3484 # update issues priority
3485 3485 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
3486 3486 :issue => {:priority_id => '',
3487 3487 :assigned_to_id => '',
3488 3488 :status_id => '5'}
3489 3489
3490 3490 assert_response 302
3491 3491 issue = Issue.find(1)
3492 3492 assert issue.closed?
3493 3493 end
3494 3494
3495 3495 def test_bulk_update_priority
3496 3496 @request.session[:user_id] = 2
3497 3497 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3498 3498
3499 3499 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3500 3500 assert_equal 6, Issue.find(1).priority_id
3501 3501 assert_equal 6, Issue.find(2).priority_id
3502 3502 end
3503 3503
3504 3504 def test_bulk_update_with_notes
3505 3505 @request.session[:user_id] = 2
3506 3506 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
3507 3507
3508 3508 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3509 3509 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
3510 3510 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
3511 3511 end
3512 3512
3513 3513 def test_bulk_update_parent_id
3514 3514 IssueRelation.delete_all
3515 3515 @request.session[:user_id] = 2
3516 3516 post :bulk_update, :ids => [1, 3],
3517 3517 :notes => 'Bulk editing parent',
3518 3518 :issue => {:priority_id => '', :assigned_to_id => '',
3519 3519 :status_id => '', :parent_issue_id => '2'}
3520 3520 assert_response 302
3521 3521 parent = Issue.find(2)
3522 3522 assert_equal parent.id, Issue.find(1).parent_id
3523 3523 assert_equal parent.id, Issue.find(3).parent_id
3524 3524 assert_equal [1, 3], parent.children.collect(&:id).sort
3525 3525 end
3526 3526
3527 3527 def test_bulk_update_custom_field
3528 3528 @request.session[:user_id] = 2
3529 3529 # update issues priority
3530 3530 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
3531 3531 :issue => {:priority_id => '',
3532 3532 :assigned_to_id => '',
3533 3533 :custom_field_values => {'2' => '777'}}
3534 3534
3535 3535 assert_response 302
3536 3536
3537 3537 issue = Issue.find(1)
3538 3538 journal = issue.journals.reorder('created_on DESC').first
3539 3539 assert_equal '777', issue.custom_value_for(2).value
3540 3540 assert_equal 1, journal.details.size
3541 3541 assert_equal '125', journal.details.first.old_value
3542 3542 assert_equal '777', journal.details.first.value
3543 3543 end
3544 3544
3545 3545 def test_bulk_update_custom_field_to_blank
3546 3546 @request.session[:user_id] = 2
3547 3547 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing custom field',
3548 3548 :issue => {:priority_id => '',
3549 3549 :assigned_to_id => '',
3550 3550 :custom_field_values => {'1' => '__none__'}}
3551 3551 assert_response 302
3552 3552 assert_equal '', Issue.find(1).custom_field_value(1)
3553 3553 assert_equal '', Issue.find(3).custom_field_value(1)
3554 3554 end
3555 3555
3556 3556 def test_bulk_update_multi_custom_field
3557 3557 field = CustomField.find(1)
3558 3558 field.update_attribute :multiple, true
3559 3559
3560 3560 @request.session[:user_id] = 2
3561 3561 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
3562 3562 :issue => {:priority_id => '',
3563 3563 :assigned_to_id => '',
3564 3564 :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
3565 3565
3566 3566 assert_response 302
3567 3567
3568 3568 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
3569 3569 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
3570 3570 # the custom field is not associated with the issue tracker
3571 3571 assert_nil Issue.find(2).custom_field_value(1)
3572 3572 end
3573 3573
3574 3574 def test_bulk_update_multi_custom_field_to_blank
3575 3575 field = CustomField.find(1)
3576 3576 field.update_attribute :multiple, true
3577 3577
3578 3578 @request.session[:user_id] = 2
3579 3579 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing multi custom field',
3580 3580 :issue => {:priority_id => '',
3581 3581 :assigned_to_id => '',
3582 3582 :custom_field_values => {'1' => ['__none__']}}
3583 3583 assert_response 302
3584 3584 assert_equal [''], Issue.find(1).custom_field_value(1)
3585 3585 assert_equal [''], Issue.find(3).custom_field_value(1)
3586 3586 end
3587 3587
3588 3588 def test_bulk_update_unassign
3589 3589 assert_not_nil Issue.find(2).assigned_to
3590 3590 @request.session[:user_id] = 2
3591 3591 # unassign issues
3592 3592 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
3593 3593 assert_response 302
3594 3594 # check that the issues were updated
3595 3595 assert_nil Issue.find(2).assigned_to
3596 3596 end
3597 3597
3598 3598 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
3599 3599 @request.session[:user_id] = 2
3600 3600
3601 3601 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
3602 3602
3603 3603 assert_response :redirect
3604 3604 issues = Issue.find([1,2])
3605 3605 issues.each do |issue|
3606 3606 assert_equal 4, issue.fixed_version_id
3607 3607 assert_not_equal issue.project_id, issue.fixed_version.project_id
3608 3608 end
3609 3609 end
3610 3610
3611 3611 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
3612 3612 @request.session[:user_id] = 2
3613 3613 post :bulk_update, :ids => [1,2], :back_url => '/issues'
3614 3614
3615 3615 assert_response :redirect
3616 3616 assert_redirected_to '/issues'
3617 3617 end
3618 3618
3619 3619 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3620 3620 @request.session[:user_id] = 2
3621 3621 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
3622 3622
3623 3623 assert_response :redirect
3624 3624 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
3625 3625 end
3626 3626
3627 3627 def test_bulk_update_with_all_failures_should_show_errors
3628 3628 @request.session[:user_id] = 2
3629 3629 post :bulk_update, :ids => [1, 2], :issue => {:start_date => 'foo'}
3630 3630
3631 3631 assert_response :success
3632 3632 assert_template 'bulk_edit'
3633 3633 assert_select '#errorExplanation span', :text => 'Failed to save 2 issue(s) on 2 selected: #1, #2.'
3634 3634 assert_select '#errorExplanation ul li', :text => 'Start date is not a valid date: #1, #2'
3635 3635
3636 3636 assert_equal [1, 2], assigns[:issues].map(&:id)
3637 3637 end
3638 3638
3639 3639 def test_bulk_update_with_some_failures_should_show_errors
3640 3640 issue1 = Issue.generate!(:start_date => '2013-05-12')
3641 3641 issue2 = Issue.generate!(:start_date => '2013-05-15')
3642 3642 issue3 = Issue.generate!
3643 3643 @request.session[:user_id] = 2
3644 3644 post :bulk_update, :ids => [issue1.id, issue2.id, issue3.id],
3645 3645 :issue => {:due_date => '2013-05-01'}
3646 3646 assert_response :success
3647 3647 assert_template 'bulk_edit'
3648 3648 assert_select '#errorExplanation span',
3649 3649 :text => "Failed to save 2 issue(s) on 3 selected: ##{issue1.id}, ##{issue2.id}."
3650 3650 assert_select '#errorExplanation ul li',
3651 3651 :text => "Due date must be greater than start date: ##{issue1.id}, ##{issue2.id}"
3652 3652 assert_equal [issue1.id, issue2.id], assigns[:issues].map(&:id)
3653 3653 end
3654 3654
3655 3655 def test_bulk_update_with_failure_should_preserved_form_values
3656 3656 @request.session[:user_id] = 2
3657 3657 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2', :start_date => 'foo'}
3658 3658
3659 3659 assert_response :success
3660 3660 assert_template 'bulk_edit'
3661 3661 assert_select 'select[name=?]', 'issue[tracker_id]' do
3662 3662 assert_select 'option[value=2][selected=selected]'
3663 3663 end
3664 3664 assert_select 'input[name=?][value=?]', 'issue[start_date]', 'foo'
3665 3665 end
3666 3666
3667 3667 def test_get_bulk_copy
3668 3668 @request.session[:user_id] = 2
3669 3669 get :bulk_edit, :ids => [1, 2, 3], :copy => '1'
3670 3670 assert_response :success
3671 3671 assert_template 'bulk_edit'
3672 3672
3673 3673 issues = assigns(:issues)
3674 3674 assert_not_nil issues
3675 3675 assert_equal [1, 2, 3], issues.map(&:id).sort
3676 3676
3677 3677 assert_select 'input[name=copy_attachments]'
3678 3678 end
3679 3679
3680 3680 def test_bulk_copy_to_another_project
3681 3681 @request.session[:user_id] = 2
3682 3682 assert_difference 'Issue.count', 2 do
3683 3683 assert_no_difference 'Project.find(1).issues.count' do
3684 3684 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
3685 3685 end
3686 3686 end
3687 3687 assert_redirected_to '/projects/ecookbook/issues'
3688 3688
3689 3689 copies = Issue.order('id DESC').limit(issues.size)
3690 3690 copies.each do |copy|
3691 3691 assert_equal 2, copy.project_id
3692 3692 end
3693 3693 end
3694 3694
3695 3695 def test_bulk_copy_should_allow_not_changing_the_issue_attributes
3696 3696 @request.session[:user_id] = 2
3697 3697 issues = [
3698 3698 Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 1,
3699 3699 :priority_id => 2, :subject => 'issue 1', :author_id => 1,
3700 3700 :assigned_to_id => nil),
3701 3701 Issue.create!(:project_id => 2, :tracker_id => 3, :status_id => 2,
3702 3702 :priority_id => 1, :subject => 'issue 2', :author_id => 2,
3703 3703 :assigned_to_id => 3)
3704 3704 ]
3705 3705 assert_difference 'Issue.count', issues.size do
3706 3706 post :bulk_update, :ids => issues.map(&:id), :copy => '1',
3707 3707 :issue => {
3708 3708 :project_id => '', :tracker_id => '', :assigned_to_id => '',
3709 3709 :status_id => '', :start_date => '', :due_date => ''
3710 3710 }
3711 3711 end
3712 3712
3713 3713 copies = Issue.order('id DESC').limit(issues.size)
3714 3714 issues.each do |orig|
3715 3715 copy = copies.detect {|c| c.subject == orig.subject}
3716 3716 assert_not_nil copy
3717 3717 assert_equal orig.project_id, copy.project_id
3718 3718 assert_equal orig.tracker_id, copy.tracker_id
3719 3719 assert_equal orig.status_id, copy.status_id
3720 3720 assert_equal orig.assigned_to_id, copy.assigned_to_id
3721 3721 assert_equal orig.priority_id, copy.priority_id
3722 3722 end
3723 3723 end
3724 3724
3725 3725 def test_bulk_copy_should_allow_changing_the_issue_attributes
3726 3726 # Fixes random test failure with Mysql
3727 3727 # where Issue.where(:project_id => 2).limit(2).order('id desc')
3728 3728 # doesn't return the expected results
3729 3729 Issue.delete_all("project_id=2")
3730 3730
3731 3731 @request.session[:user_id] = 2
3732 3732 assert_difference 'Issue.count', 2 do
3733 3733 assert_no_difference 'Project.find(1).issues.count' do
3734 3734 post :bulk_update, :ids => [1, 2], :copy => '1',
3735 3735 :issue => {
3736 3736 :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
3737 3737 :status_id => '1', :start_date => '2009-12-01', :due_date => '2009-12-31'
3738 3738 }
3739 3739 end
3740 3740 end
3741 3741
3742 3742 copied_issues = Issue.where(:project_id => 2).limit(2).order('id desc').to_a
3743 3743 assert_equal 2, copied_issues.size
3744 3744 copied_issues.each do |issue|
3745 3745 assert_equal 2, issue.project_id, "Project is incorrect"
3746 3746 assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
3747 3747 assert_equal 1, issue.status_id, "Status is incorrect"
3748 3748 assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
3749 3749 assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
3750 3750 end
3751 3751 end
3752 3752
3753 3753 def test_bulk_copy_should_allow_adding_a_note
3754 3754 @request.session[:user_id] = 2
3755 3755 assert_difference 'Issue.count', 1 do
3756 3756 post :bulk_update, :ids => [1], :copy => '1',
3757 3757 :notes => 'Copying one issue',
3758 3758 :issue => {
3759 3759 :project_id => '', :tracker_id => '', :assigned_to_id => '4',
3760 3760 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
3761 3761 }
3762 3762 end
3763 3763 issue = Issue.order('id DESC').first
3764 3764 assert_equal 1, issue.journals.size
3765 3765 journal = issue.journals.first
3766 3766 assert_equal 1, journal.details.size
3767 3767 assert_equal 'Copying one issue', journal.notes
3768 3768 end
3769 3769
3770 3770 def test_bulk_copy_should_allow_not_copying_the_attachments
3771 3771 attachment_count = Issue.find(3).attachments.size
3772 3772 assert attachment_count > 0
3773 3773 @request.session[:user_id] = 2
3774 3774
3775 3775 assert_difference 'Issue.count', 1 do
3776 3776 assert_no_difference 'Attachment.count' do
3777 3777 post :bulk_update, :ids => [3], :copy => '1',
3778 3778 :issue => {
3779 3779 :project_id => ''
3780 3780 }
3781 3781 end
3782 3782 end
3783 3783 end
3784 3784
3785 3785 def test_bulk_copy_should_allow_copying_the_attachments
3786 3786 attachment_count = Issue.find(3).attachments.size
3787 3787 assert attachment_count > 0
3788 3788 @request.session[:user_id] = 2
3789 3789
3790 3790 assert_difference 'Issue.count', 1 do
3791 3791 assert_difference 'Attachment.count', attachment_count do
3792 3792 post :bulk_update, :ids => [3], :copy => '1', :copy_attachments => '1',
3793 3793 :issue => {
3794 3794 :project_id => ''
3795 3795 }
3796 3796 end
3797 3797 end
3798 3798 end
3799 3799
3800 3800 def test_bulk_copy_should_add_relations_with_copied_issues
3801 3801 @request.session[:user_id] = 2
3802 3802
3803 3803 assert_difference 'Issue.count', 2 do
3804 3804 assert_difference 'IssueRelation.count', 2 do
3805 3805 post :bulk_update, :ids => [1, 3], :copy => '1',
3806 3806 :issue => {
3807 3807 :project_id => '1'
3808 3808 }
3809 3809 end
3810 3810 end
3811 3811 end
3812 3812
3813 3813 def test_bulk_copy_should_allow_not_copying_the_subtasks
3814 3814 issue = Issue.generate_with_descendants!
3815 3815 @request.session[:user_id] = 2
3816 3816
3817 3817 assert_difference 'Issue.count', 1 do
3818 3818 post :bulk_update, :ids => [issue.id], :copy => '1',
3819 3819 :issue => {
3820 3820 :project_id => ''
3821 3821 }
3822 3822 end
3823 3823 end
3824 3824
3825 3825 def test_bulk_copy_should_allow_copying_the_subtasks
3826 3826 issue = Issue.generate_with_descendants!
3827 3827 count = issue.descendants.count
3828 3828 @request.session[:user_id] = 2
3829 3829
3830 3830 assert_difference 'Issue.count', count+1 do
3831 3831 post :bulk_update, :ids => [issue.id], :copy => '1', :copy_subtasks => '1',
3832 3832 :issue => {
3833 3833 :project_id => ''
3834 3834 }
3835 3835 end
3836 3836 copy = Issue.where(:parent_id => nil).order("id DESC").first
3837 3837 assert_equal count, copy.descendants.count
3838 3838 end
3839 3839
3840 3840 def test_bulk_copy_should_not_copy_selected_subtasks_twice
3841 3841 issue = Issue.generate_with_descendants!
3842 3842 count = issue.descendants.count
3843 3843 @request.session[:user_id] = 2
3844 3844
3845 3845 assert_difference 'Issue.count', count+1 do
3846 3846 post :bulk_update, :ids => issue.self_and_descendants.map(&:id), :copy => '1', :copy_subtasks => '1',
3847 3847 :issue => {
3848 3848 :project_id => ''
3849 3849 }
3850 3850 end
3851 3851 copy = Issue.where(:parent_id => nil).order("id DESC").first
3852 3852 assert_equal count, copy.descendants.count
3853 3853 end
3854 3854
3855 3855 def test_bulk_copy_to_another_project_should_follow_when_needed
3856 3856 @request.session[:user_id] = 2
3857 3857 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
3858 3858 issue = Issue.order('id DESC').first
3859 3859 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
3860 3860 end
3861 3861
3862 3862 def test_bulk_copy_with_all_failures_should_display_errors
3863 3863 @request.session[:user_id] = 2
3864 3864 post :bulk_update, :ids => [1, 2], :copy => '1', :issue => {:start_date => 'foo'}
3865 3865
3866 3866 assert_response :success
3867 3867 end
3868 3868
3869 3869 def test_destroy_issue_with_no_time_entries
3870 3870 assert_nil TimeEntry.find_by_issue_id(2)
3871 3871 @request.session[:user_id] = 2
3872 3872
3873 3873 assert_difference 'Issue.count', -1 do
3874 3874 delete :destroy, :id => 2
3875 3875 end
3876 3876 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3877 3877 assert_nil Issue.find_by_id(2)
3878 3878 end
3879 3879
3880 3880 def test_destroy_issues_with_time_entries
3881 3881 @request.session[:user_id] = 2
3882 3882
3883 3883 assert_no_difference 'Issue.count' do
3884 3884 delete :destroy, :ids => [1, 3]
3885 3885 end
3886 3886 assert_response :success
3887 3887 assert_template 'destroy'
3888 3888 assert_not_nil assigns(:hours)
3889 3889 assert Issue.find_by_id(1) && Issue.find_by_id(3)
3890 3890
3891 3891 assert_select 'form' do
3892 3892 assert_select 'input[name=_method][value=delete]'
3893 3893 end
3894 3894 end
3895 3895
3896 3896 def test_destroy_issues_and_destroy_time_entries
3897 3897 @request.session[:user_id] = 2
3898 3898
3899 3899 assert_difference 'Issue.count', -2 do
3900 3900 assert_difference 'TimeEntry.count', -3 do
3901 3901 delete :destroy, :ids => [1, 3], :todo => 'destroy'
3902 3902 end
3903 3903 end
3904 3904 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3905 3905 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3906 3906 assert_nil TimeEntry.find_by_id([1, 2])
3907 3907 end
3908 3908
3909 3909 def test_destroy_issues_and_assign_time_entries_to_project
3910 3910 @request.session[:user_id] = 2
3911 3911
3912 3912 assert_difference 'Issue.count', -2 do
3913 3913 assert_no_difference 'TimeEntry.count' do
3914 3914 delete :destroy, :ids => [1, 3], :todo => 'nullify'
3915 3915 end
3916 3916 end
3917 3917 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3918 3918 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3919 3919 assert_nil TimeEntry.find(1).issue_id
3920 3920 assert_nil TimeEntry.find(2).issue_id
3921 3921 end
3922 3922
3923 3923 def test_destroy_issues_and_reassign_time_entries_to_another_issue
3924 3924 @request.session[:user_id] = 2
3925 3925
3926 3926 assert_difference 'Issue.count', -2 do
3927 3927 assert_no_difference 'TimeEntry.count' do
3928 3928 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
3929 3929 end
3930 3930 end
3931 3931 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3932 3932 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3933 3933 assert_equal 2, TimeEntry.find(1).issue_id
3934 3934 assert_equal 2, TimeEntry.find(2).issue_id
3935 3935 end
3936 3936
3937 3937 def test_destroy_issues_from_different_projects
3938 3938 @request.session[:user_id] = 2
3939 3939
3940 3940 assert_difference 'Issue.count', -3 do
3941 3941 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
3942 3942 end
3943 3943 assert_redirected_to :controller => 'issues', :action => 'index'
3944 3944 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
3945 3945 end
3946 3946
3947 3947 def test_destroy_parent_and_child_issues
3948 3948 parent = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Parent Issue')
3949 3949 child = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Child Issue', :parent_issue_id => parent.id)
3950 3950 assert child.is_descendant_of?(parent.reload)
3951 3951
3952 3952 @request.session[:user_id] = 2
3953 3953 assert_difference 'Issue.count', -2 do
3954 3954 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
3955 3955 end
3956 3956 assert_response 302
3957 3957 end
3958 3958
3959 3959 def test_destroy_invalid_should_respond_with_404
3960 3960 @request.session[:user_id] = 2
3961 3961 assert_no_difference 'Issue.count' do
3962 3962 delete :destroy, :id => 999
3963 3963 end
3964 3964 assert_response 404
3965 3965 end
3966 3966
3967 3967 def test_default_search_scope
3968 3968 get :index
3969 3969
3970 3970 assert_select 'div#quick-search form' do
3971 3971 assert_select 'input[name=issues][value=1][type=hidden]'
3972 3972 end
3973 3973 end
3974 3974 end
General Comments 0
You need to be logged in to leave comments. Login now