jro_apps/redmine Commit - r8707:8c38510ee504

Use #reduce instead of #inject for getting the intersection of arrays....

Jean-Philippe Lang -

r8707:8c38510ee504

parent child

Context file:

r8707:8c38510ee504

app/controllers/context_menus_controller.rb +4 -4

                   @issue = @issues.first
                 end
-                @allowed_statuses = @issues.map(&:new_statuses_allowed_to).inject{|memo,a| memo & a}
+                @allowed_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
                 @projects = @issues.collect(&:project).compact.uniq
                 @project = @projects.first if @projects.size == 1
                   @trackers = @project.trackers
                 else
                   #when multiple projects, we only keep the intersection of each set
-                  @assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}
+                  @assignables = @projects.map(&:assignable_users).reduce(:&)
-                  @trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}
+                  @trackers = @projects.map(&:trackers).reduce(:&)
                 end
                 @priorities = IssuePriority.active.reverse
                 @options_by_custom_field = {}
                 if @can[:edit]
-                  custom_fields = @issues.map(&:available_custom_fields).inject {|memo, f| memo & f}.select do |f|
+                  custom_fields = @issues.map(&:available_custom_fields).reduce(:&).select do |f|
                     %w(bool list user version).include?(f.field_format) && !f.multiple?
                   end
                   custom_fields.each do |field|

app/controllers/issues_controller.rb +5 -5

                 end
                 target_projects ||= @projects
-                @available_statuses = target_projects.map{|p|Workflow.available_statuses(p)}.inject{|memo,w|memo & w}
+                @available_statuses = target_projects.map{|p|Workflow.available_statuses(p)}.reduce(:&)
-                @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.inject{|memo,c|memo & c}
+                @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.reduce(:&)
-                @assignables = target_projects.map(&:assignable_users).inject{|memo,a| memo & a}
+                @assignables = target_projects.map(&:assignable_users).reduce(:&)
-                @trackers = target_projects.map(&:trackers).inject{|memo,t| memo & t}
+                @trackers = target_projects.map(&:trackers).reduce(:&)
-                @safe_attributes = @issues.map(&:safe_attribute_names).inject {|memo,attrs| memo & attrs}
+                @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
                 render :layout => false if request.xhr?
               end

app/models/custom_field.rb +1 -1

                       obj.project.shared_versions.sort.collect {|u| [u.to_s, u.id.to_s]}
                     end
                   elsif obj.is_a?(Array)
-                    obj.collect {|o| possible_values_options(o)}.inject {|memo, v| memo & v}
+                    obj.collect {|o| possible_values_options(o)}.reduce(:&)
                   else
                     []
                   end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages