##// END OF EJS Templates
jro_apps » redmine
RSS
Code cleanup....
Jean-Philippe Lang -
r8706:8b3ed4175d6e
parent child
Show More
Side by Side Unified
Context file:
r8706:8b3ed4175d6e Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,72 +1,66
1 class ContextMenusController < ApplicationController
1 class ContextMenusController < ApplicationController
2 helper :watchers
2 helper :watchers
3 helper :issues
3 helper :issues
4
4
5 def issues
5 def issues
6 @issues = Issue.visible.all(:conditions => {:id => params[:ids]}, :include => :project)
6 @issues = Issue.visible.all(:conditions => {:id => params[:ids]}, :include => :project)
7
8 if (@issues.size == 1)
7 if (@issues.size == 1)
9 @issue = @issues.first
8 @issue = @issues.first
10 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
11 else
12 @allowed_statuses = @issues.map do |i|
13 i.new_statuses_allowed_to(User.current)
14 end.inject do |memo,s|
15 memo & s
16 end
17 end
9 end
10
11 @allowed_statuses = @issues.map(&:new_statuses_allowed_to).inject{|memo,a| memo & a}
18 @projects = @issues.collect(&:project).compact.uniq
12 @projects = @issues.collect(&:project).compact.uniq
19 @project = @projects.first if @projects.size == 1
13 @project = @projects.first if @projects.size == 1
20
14
21 @can = {:edit => User.current.allowed_to?(:edit_issues, @projects),
15 @can = {:edit => User.current.allowed_to?(:edit_issues, @projects),
22 :log_time => (@project && User.current.allowed_to?(:log_time, @project)),
16 :log_time => (@project && User.current.allowed_to?(:log_time, @project)),
23 :update => (User.current.allowed_to?(:edit_issues, @projects) || (User.current.allowed_to?(:change_status, @projects) && !@allowed_statuses.blank?)),
17 :update => (User.current.allowed_to?(:edit_issues, @projects) || (User.current.allowed_to?(:change_status, @projects) && !@allowed_statuses.blank?)),
24 :move => (@project && User.current.allowed_to?(:move_issues, @project)),
18 :move => (@project && User.current.allowed_to?(:move_issues, @project)),
25 :copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),
19 :copy => (@issue && @project.trackers.include?(@issue.tracker) && User.current.allowed_to?(:add_issues, @project)),
26 :delete => User.current.allowed_to?(:delete_issues, @projects)
20 :delete => User.current.allowed_to?(:delete_issues, @projects)
27 }
21 }
28 if @project
22 if @project
29 if @issue
23 if @issue
30 @assignables = @issue.assignable_users
24 @assignables = @issue.assignable_users
31 else
25 else
32 @assignables = @project.assignable_users
26 @assignables = @project.assignable_users
33 end
27 end
34 @trackers = @project.trackers
28 @trackers = @project.trackers
35 else
29 else
36 #when multiple projects, we only keep the intersection of each set
30 #when multiple projects, we only keep the intersection of each set
37 @assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}
31 @assignables = @projects.map(&:assignable_users).inject{|memo,a| memo & a}
38 @trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}
32 @trackers = @projects.map(&:trackers).inject{|memo,t| memo & t}
39 end
33 end
40
34
41 @priorities = IssuePriority.active.reverse
35 @priorities = IssuePriority.active.reverse
42 @back = back_url
36 @back = back_url
43
37
44 @options_by_custom_field = {}
38 @options_by_custom_field = {}
45 if @can[:edit]
39 if @can[:edit]
46 custom_fields = @issues.map(&:available_custom_fields).inject {|memo, f| memo & f}.select do |f|
40 custom_fields = @issues.map(&:available_custom_fields).inject {|memo, f| memo & f}.select do |f|
47 %w(bool list user version).include?(f.field_format) && !f.multiple?
41 %w(bool list user version).include?(f.field_format) && !f.multiple?
48 end
42 end
49 custom_fields.each do |field|
43 custom_fields.each do |field|
50 values = field.possible_values_options(@projects)
44 values = field.possible_values_options(@projects)
51 if values.any?
45 if values.any?
52 @options_by_custom_field[field] = values
46 @options_by_custom_field[field] = values
53 end
47 end
54 end
48 end
55 end
49 end
56
50
57 render :layout => false
51 render :layout => false
58 end
52 end
59
53
60 def time_entries
54 def time_entries
61 @time_entries = TimeEntry.all(
55 @time_entries = TimeEntry.all(
62 :conditions => {:id => params[:ids]}, :include => :project)
56 :conditions => {:id => params[:ids]}, :include => :project)
63 @projects = @time_entries.collect(&:project).compact.uniq
57 @projects = @time_entries.collect(&:project).compact.uniq
64 @project = @projects.first if @projects.size == 1
58 @project = @projects.first if @projects.size == 1
65 @activities = TimeEntryActivity.shared.active
59 @activities = TimeEntryActivity.shared.active
66 @can = {:edit => User.current.allowed_to?(:edit_time_entries, @projects),
60 @can = {:edit => User.current.allowed_to?(:edit_time_entries, @projects),
67 :delete => User.current.allowed_to?(:edit_time_entries, @projects)
61 :delete => User.current.allowed_to?(:edit_time_entries, @projects)
68 }
62 }
69 @back = back_url
63 @back = back_url
70 render :layout => false
64 render :layout => false
71 end
65 end
72 end
66 end
Show file before | Show file after | Hide comments
@@ -1,1081 +1,1081
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2011 Jean-Philippe Lang
2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class Issue < ActiveRecord::Base
18 class Issue < ActiveRecord::Base
19 include Redmine::SafeAttributes
19 include Redmine::SafeAttributes
20
20
21 belongs_to :project
21 belongs_to :project
22 belongs_to :tracker
22 belongs_to :tracker
23 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
23 belongs_to :status, :class_name => 'IssueStatus', :foreign_key => 'status_id'
24 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
24 belongs_to :author, :class_name => 'User', :foreign_key => 'author_id'
25 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
25 belongs_to :assigned_to, :class_name => 'Principal', :foreign_key => 'assigned_to_id'
26 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
26 belongs_to :fixed_version, :class_name => 'Version', :foreign_key => 'fixed_version_id'
27 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
27 belongs_to :priority, :class_name => 'IssuePriority', :foreign_key => 'priority_id'
28 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
28 belongs_to :category, :class_name => 'IssueCategory', :foreign_key => 'category_id'
29
29
30 has_many :journals, :as => :journalized, :dependent => :destroy
30 has_many :journals, :as => :journalized, :dependent => :destroy
31 has_many :time_entries, :dependent => :delete_all
31 has_many :time_entries, :dependent => :delete_all
32 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
32 has_and_belongs_to_many :changesets, :order => "#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC"
33
33
34 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
34 has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
35 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
35 has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
36
36
37 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
37 acts_as_nested_set :scope => 'root_id', :dependent => :destroy
38 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
38 acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
39 acts_as_customizable
39 acts_as_customizable
40 acts_as_watchable
40 acts_as_watchable
41 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
41 acts_as_searchable :columns => ['subject', "#{table_name}.description", "#{Journal.table_name}.notes"],
42 :include => [:project, :journals],
42 :include => [:project, :journals],
43 # sort by id so that limited eager loading doesn't break with postgresql
43 # sort by id so that limited eager loading doesn't break with postgresql
44 :order_column => "#{table_name}.id"
44 :order_column => "#{table_name}.id"
45 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
45 acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
46 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
46 :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
47 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
47 :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
48
48
49 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
49 acts_as_activity_provider :find_options => {:include => [:project, :author, :tracker]},
50 :author_key => :author_id
50 :author_key => :author_id
51
51
52 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
52 DONE_RATIO_OPTIONS = %w(issue_field issue_status)
53
53
54 attr_reader :current_journal
54 attr_reader :current_journal
55
55
56 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
56 validates_presence_of :subject, :priority, :project, :tracker, :author, :status
57
57
58 validates_length_of :subject, :maximum => 255
58 validates_length_of :subject, :maximum => 255
59 validates_inclusion_of :done_ratio, :in => 0..100
59 validates_inclusion_of :done_ratio, :in => 0..100
60 validates_numericality_of :estimated_hours, :allow_nil => true
60 validates_numericality_of :estimated_hours, :allow_nil => true
61 validate :validate_issue
61 validate :validate_issue
62
62
63 named_scope :visible, lambda {|*args| { :include => :project,
63 named_scope :visible, lambda {|*args| { :include => :project,
64 :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
64 :conditions => Issue.visible_condition(args.shift || User.current, *args) } }
65
65
66 named_scope :open, lambda {|*args|
66 named_scope :open, lambda {|*args|
67 is_closed = args.size > 0 ? !args.first : false
67 is_closed = args.size > 0 ? !args.first : false
68 {:conditions => ["#{IssueStatus.table_name}.is_closed = ?", is_closed], :include => :status}
68 {:conditions => ["#{IssueStatus.table_name}.is_closed = ?", is_closed], :include => :status}
69 }
69 }
70
70
71 named_scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
71 named_scope :recently_updated, :order => "#{Issue.table_name}.updated_on DESC"
72 named_scope :with_limit, lambda { |limit| { :limit => limit} }
72 named_scope :with_limit, lambda { |limit| { :limit => limit} }
73 named_scope :on_active_project, :include => [:status, :project, :tracker],
73 named_scope :on_active_project, :include => [:status, :project, :tracker],
74 :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
74 :conditions => ["#{Project.table_name}.status=#{Project::STATUS_ACTIVE}"]
75
75
76 before_create :default_assign
76 before_create :default_assign
77 before_save :close_duplicates, :update_done_ratio_from_issue_status
77 before_save :close_duplicates, :update_done_ratio_from_issue_status
78 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
78 after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
79 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
79 after_save :reschedule_following_issues, :update_nested_set_attributes, :update_parent_attributes, :create_journal
80 after_destroy :update_parent_attributes
80 after_destroy :update_parent_attributes
81
81
82 # Returns a SQL conditions string used to find all issues visible by the specified user
82 # Returns a SQL conditions string used to find all issues visible by the specified user
83 def self.visible_condition(user, options={})
83 def self.visible_condition(user, options={})
84 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
84 Project.allowed_to_condition(user, :view_issues, options) do |role, user|
85 case role.issues_visibility
85 case role.issues_visibility
86 when 'all'
86 when 'all'
87 nil
87 nil
88 when 'default'
88 when 'default'
89 user_ids = [user.id] + user.groups.map(&:id)
89 user_ids = [user.id] + user.groups.map(&:id)
90 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
90 "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
91 when 'own'
91 when 'own'
92 user_ids = [user.id] + user.groups.map(&:id)
92 user_ids = [user.id] + user.groups.map(&:id)
93 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
93 "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
94 else
94 else
95 '1=0'
95 '1=0'
96 end
96 end
97 end
97 end
98 end
98 end
99
99
100 # Returns true if usr or current user is allowed to view the issue
100 # Returns true if usr or current user is allowed to view the issue
101 def visible?(usr=nil)
101 def visible?(usr=nil)
102 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
102 (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
103 case role.issues_visibility
103 case role.issues_visibility
104 when 'all'
104 when 'all'
105 true
105 true
106 when 'default'
106 when 'default'
107 !self.is_private? || self.author == user || user.is_or_belongs_to?(assigned_to)
107 !self.is_private? || self.author == user || user.is_or_belongs_to?(assigned_to)
108 when 'own'
108 when 'own'
109 self.author == user || user.is_or_belongs_to?(assigned_to)
109 self.author == user || user.is_or_belongs_to?(assigned_to)
110 else
110 else
111 false
111 false
112 end
112 end
113 end
113 end
114 end
114 end
115
115
116 def initialize(attributes=nil, *args)
116 def initialize(attributes=nil, *args)
117 super
117 super
118 if new_record?
118 if new_record?
119 # set default values for new records only
119 # set default values for new records only
120 self.status ||= IssueStatus.default
120 self.status ||= IssueStatus.default
121 self.priority ||= IssuePriority.default
121 self.priority ||= IssuePriority.default
122 self.watcher_user_ids = []
122 self.watcher_user_ids = []
123 end
123 end
124 end
124 end
125
125
126 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
126 # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
127 def available_custom_fields
127 def available_custom_fields
128 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
128 (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields.all) : []
129 end
129 end
130
130
131 # Copies attributes from another issue, arg can be an id or an Issue
131 # Copies attributes from another issue, arg can be an id or an Issue
132 def copy_from(arg, options={})
132 def copy_from(arg, options={})
133 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
133 issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
134 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
134 self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
135 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
135 self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
136 self.status = issue.status
136 self.status = issue.status
137 self.author = User.current
137 self.author = User.current
138 unless options[:attachments] == false
138 unless options[:attachments] == false
139 self.attachments = issue.attachments.map do |attachement|
139 self.attachments = issue.attachments.map do |attachement|
140 attachement.copy(:container => self)
140 attachement.copy(:container => self)
141 end
141 end
142 end
142 end
143 @copied_from = issue
143 @copied_from = issue
144 self
144 self
145 end
145 end
146
146
147 # Returns an unsaved copy of the issue
147 # Returns an unsaved copy of the issue
148 def copy(attributes=nil)
148 def copy(attributes=nil)
149 copy = self.class.new.copy_from(self)
149 copy = self.class.new.copy_from(self)
150 copy.attributes = attributes if attributes
150 copy.attributes = attributes if attributes
151 copy
151 copy
152 end
152 end
153
153
154 # Returns true if the issue is a copy
154 # Returns true if the issue is a copy
155 def copy?
155 def copy?
156 @copied_from.present?
156 @copied_from.present?
157 end
157 end
158
158
159 # Moves/copies an issue to a new project and tracker
159 # Moves/copies an issue to a new project and tracker
160 # Returns the moved/copied issue on success, false on failure
160 # Returns the moved/copied issue on success, false on failure
161 def move_to_project(new_project, new_tracker=nil, options={})
161 def move_to_project(new_project, new_tracker=nil, options={})
162 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
162 ActiveSupport::Deprecation.warn "Issue#move_to_project is deprecated, use #project= instead."
163
163
164 if options[:copy]
164 if options[:copy]
165 issue = self.copy
165 issue = self.copy
166 else
166 else
167 issue = self
167 issue = self
168 end
168 end
169
169
170 issue.init_journal(User.current, options[:notes])
170 issue.init_journal(User.current, options[:notes])
171
171
172 # Preserve previous behaviour
172 # Preserve previous behaviour
173 # #move_to_project doesn't change tracker automatically
173 # #move_to_project doesn't change tracker automatically
174 issue.send :project=, new_project, true
174 issue.send :project=, new_project, true
175 if new_tracker
175 if new_tracker
176 issue.tracker = new_tracker
176 issue.tracker = new_tracker
177 end
177 end
178 # Allow bulk setting of attributes on the issue
178 # Allow bulk setting of attributes on the issue
179 if options[:attributes]
179 if options[:attributes]
180 issue.attributes = options[:attributes]
180 issue.attributes = options[:attributes]
181 end
181 end
182
182
183 issue.save ? issue : false
183 issue.save ? issue : false
184 end
184 end
185
185
186 def status_id=(sid)
186 def status_id=(sid)
187 self.status = nil
187 self.status = nil
188 write_attribute(:status_id, sid)
188 write_attribute(:status_id, sid)
189 end
189 end
190
190
191 def priority_id=(pid)
191 def priority_id=(pid)
192 self.priority = nil
192 self.priority = nil
193 write_attribute(:priority_id, pid)
193 write_attribute(:priority_id, pid)
194 end
194 end
195
195
196 def category_id=(cid)
196 def category_id=(cid)
197 self.category = nil
197 self.category = nil
198 write_attribute(:category_id, cid)
198 write_attribute(:category_id, cid)
199 end
199 end
200
200
201 def fixed_version_id=(vid)
201 def fixed_version_id=(vid)
202 self.fixed_version = nil
202 self.fixed_version = nil
203 write_attribute(:fixed_version_id, vid)
203 write_attribute(:fixed_version_id, vid)
204 end
204 end
205
205
206 def tracker_id=(tid)
206 def tracker_id=(tid)
207 self.tracker = nil
207 self.tracker = nil
208 result = write_attribute(:tracker_id, tid)
208 result = write_attribute(:tracker_id, tid)
209 @custom_field_values = nil
209 @custom_field_values = nil
210 result
210 result
211 end
211 end
212
212
213 def project_id=(project_id)
213 def project_id=(project_id)
214 if project_id.to_s != self.project_id.to_s
214 if project_id.to_s != self.project_id.to_s
215 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
215 self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
216 end
216 end
217 end
217 end
218
218
219 def project=(project, keep_tracker=false)
219 def project=(project, keep_tracker=false)
220 project_was = self.project
220 project_was = self.project
221 write_attribute(:project_id, project ? project.id : nil)
221 write_attribute(:project_id, project ? project.id : nil)
222 association_instance_set('project', project)
222 association_instance_set('project', project)
223 if project_was && project && project_was != project
223 if project_was && project && project_was != project
224 unless keep_tracker || project.trackers.include?(tracker)
224 unless keep_tracker || project.trackers.include?(tracker)
225 self.tracker = project.trackers.first
225 self.tracker = project.trackers.first
226 end
226 end
227 # Reassign to the category with same name if any
227 # Reassign to the category with same name if any
228 if category
228 if category
229 self.category = project.issue_categories.find_by_name(category.name)
229 self.category = project.issue_categories.find_by_name(category.name)
230 end
230 end
231 # Keep the fixed_version if it's still valid in the new_project
231 # Keep the fixed_version if it's still valid in the new_project
232 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
232 if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
233 self.fixed_version = nil
233 self.fixed_version = nil
234 end
234 end
235 if parent && parent.project_id != project_id
235 if parent && parent.project_id != project_id
236 self.parent_issue_id = nil
236 self.parent_issue_id = nil
237 end
237 end
238 @custom_field_values = nil
238 @custom_field_values = nil
239 end
239 end
240 end
240 end
241
241
242 def description=(arg)
242 def description=(arg)
243 if arg.is_a?(String)
243 if arg.is_a?(String)
244 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
244 arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
245 end
245 end
246 write_attribute(:description, arg)
246 write_attribute(:description, arg)
247 end
247 end
248
248
249 # Overrides attributes= so that project and tracker get assigned first
249 # Overrides attributes= so that project and tracker get assigned first
250 def attributes_with_project_and_tracker_first=(new_attributes, *args)
250 def attributes_with_project_and_tracker_first=(new_attributes, *args)
251 return if new_attributes.nil?
251 return if new_attributes.nil?
252 attrs = new_attributes.dup
252 attrs = new_attributes.dup
253 attrs.stringify_keys!
253 attrs.stringify_keys!
254
254
255 %w(project project_id tracker tracker_id).each do |attr|
255 %w(project project_id tracker tracker_id).each do |attr|
256 if attrs.has_key?(attr)
256 if attrs.has_key?(attr)
257 send "#{attr}=", attrs.delete(attr)
257 send "#{attr}=", attrs.delete(attr)
258 end
258 end
259 end
259 end
260 send :attributes_without_project_and_tracker_first=, attrs, *args
260 send :attributes_without_project_and_tracker_first=, attrs, *args
261 end
261 end
262 # Do not redefine alias chain on reload (see #4838)
262 # Do not redefine alias chain on reload (see #4838)
263 alias_method_chain(:attributes=, :project_and_tracker_first) unless method_defined?(:attributes_without_project_and_tracker_first=)
263 alias_method_chain(:attributes=, :project_and_tracker_first) unless method_defined?(:attributes_without_project_and_tracker_first=)
264
264
265 def estimated_hours=(h)
265 def estimated_hours=(h)
266 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
266 write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
267 end
267 end
268
268
269 safe_attributes 'project_id',
269 safe_attributes 'project_id',
270 :if => lambda {|issue, user|
270 :if => lambda {|issue, user|
271 if issue.new_record?
271 if issue.new_record?
272 issue.copy?
272 issue.copy?
273 elsif user.allowed_to?(:move_issues, issue.project)
273 elsif user.allowed_to?(:move_issues, issue.project)
274 projects = Issue.allowed_target_projects_on_move(user)
274 projects = Issue.allowed_target_projects_on_move(user)
275 projects.include?(issue.project) && projects.size > 1
275 projects.include?(issue.project) && projects.size > 1
276 end
276 end
277 }
277 }
278
278
279 safe_attributes 'tracker_id',
279 safe_attributes 'tracker_id',
280 'status_id',
280 'status_id',
281 'category_id',
281 'category_id',
282 'assigned_to_id',
282 'assigned_to_id',
283 'priority_id',
283 'priority_id',
284 'fixed_version_id',
284 'fixed_version_id',
285 'subject',
285 'subject',
286 'description',
286 'description',
287 'start_date',
287 'start_date',
288 'due_date',
288 'due_date',
289 'done_ratio',
289 'done_ratio',
290 'estimated_hours',
290 'estimated_hours',
291 'custom_field_values',
291 'custom_field_values',
292 'custom_fields',
292 'custom_fields',
293 'lock_version',
293 'lock_version',
294 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
294 :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
295
295
296 safe_attributes 'status_id',
296 safe_attributes 'status_id',
297 'assigned_to_id',
297 'assigned_to_id',
298 'fixed_version_id',
298 'fixed_version_id',
299 'done_ratio',
299 'done_ratio',
300 'lock_version',
300 'lock_version',
301 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
301 :if => lambda {|issue, user| issue.new_statuses_allowed_to(user).any? }
302
302
303 safe_attributes 'watcher_user_ids',
303 safe_attributes 'watcher_user_ids',
304 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
304 :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
305
305
306 safe_attributes 'is_private',
306 safe_attributes 'is_private',
307 :if => lambda {|issue, user|
307 :if => lambda {|issue, user|
308 user.allowed_to?(:set_issues_private, issue.project) ||
308 user.allowed_to?(:set_issues_private, issue.project) ||
309 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
309 (issue.author == user && user.allowed_to?(:set_own_issues_private, issue.project))
310 }
310 }
311
311
312 safe_attributes 'parent_issue_id',
312 safe_attributes 'parent_issue_id',
313 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
313 :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
314 user.allowed_to?(:manage_subtasks, issue.project)}
314 user.allowed_to?(:manage_subtasks, issue.project)}
315
315
316 # Safely sets attributes
316 # Safely sets attributes
317 # Should be called from controllers instead of #attributes=
317 # Should be called from controllers instead of #attributes=
318 # attr_accessible is too rough because we still want things like
318 # attr_accessible is too rough because we still want things like
319 # Issue.new(:project => foo) to work
319 # Issue.new(:project => foo) to work
320 def safe_attributes=(attrs, user=User.current)
320 def safe_attributes=(attrs, user=User.current)
321 return unless attrs.is_a?(Hash)
321 return unless attrs.is_a?(Hash)
322
322
323 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
323 # User can change issue attributes only if he has :edit permission or if a workflow transition is allowed
324 attrs = delete_unsafe_attributes(attrs, user)
324 attrs = delete_unsafe_attributes(attrs, user)
325 return if attrs.empty?
325 return if attrs.empty?
326
326
327 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
327 # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
328 if p = attrs.delete('project_id')
328 if p = attrs.delete('project_id')
329 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
329 if allowed_target_projects(user).collect(&:id).include?(p.to_i)
330 self.project_id = p
330 self.project_id = p
331 end
331 end
332 end
332 end
333
333
334 if t = attrs.delete('tracker_id')
334 if t = attrs.delete('tracker_id')
335 self.tracker_id = t
335 self.tracker_id = t
336 end
336 end
337
337
338 if attrs['status_id']
338 if attrs['status_id']
339 unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i)
339 unless new_statuses_allowed_to(user).collect(&:id).include?(attrs['status_id'].to_i)
340 attrs.delete('status_id')
340 attrs.delete('status_id')
341 end
341 end
342 end
342 end
343
343
344 unless leaf?
344 unless leaf?
345 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
345 attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
346 end
346 end
347
347
348 if attrs['parent_issue_id'].present?
348 if attrs['parent_issue_id'].present?
349 attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
349 attrs.delete('parent_issue_id') unless Issue.visible(user).exists?(attrs['parent_issue_id'].to_i)
350 end
350 end
351
351
352 # mass-assignment security bypass
352 # mass-assignment security bypass
353 self.send :attributes=, attrs, false
353 self.send :attributes=, attrs, false
354 end
354 end
355
355
356 def done_ratio
356 def done_ratio
357 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
357 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
358 status.default_done_ratio
358 status.default_done_ratio
359 else
359 else
360 read_attribute(:done_ratio)
360 read_attribute(:done_ratio)
361 end
361 end
362 end
362 end
363
363
364 def self.use_status_for_done_ratio?
364 def self.use_status_for_done_ratio?
365 Setting.issue_done_ratio == 'issue_status'
365 Setting.issue_done_ratio == 'issue_status'
366 end
366 end
367
367
368 def self.use_field_for_done_ratio?
368 def self.use_field_for_done_ratio?
369 Setting.issue_done_ratio == 'issue_field'
369 Setting.issue_done_ratio == 'issue_field'
370 end
370 end
371
371
372 def validate_issue
372 def validate_issue
373 if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
373 if self.due_date.nil? && @attributes['due_date'] && !@attributes['due_date'].empty?
374 errors.add :due_date, :not_a_date
374 errors.add :due_date, :not_a_date
375 end
375 end
376
376
377 if self.due_date and self.start_date and self.due_date < self.start_date
377 if self.due_date and self.start_date and self.due_date < self.start_date
378 errors.add :due_date, :greater_than_start_date
378 errors.add :due_date, :greater_than_start_date
379 end
379 end
380
380
381 if start_date && soonest_start && start_date < soonest_start
381 if start_date && soonest_start && start_date < soonest_start
382 errors.add :start_date, :invalid
382 errors.add :start_date, :invalid
383 end
383 end
384
384
385 if fixed_version
385 if fixed_version
386 if !assignable_versions.include?(fixed_version)
386 if !assignable_versions.include?(fixed_version)
387 errors.add :fixed_version_id, :inclusion
387 errors.add :fixed_version_id, :inclusion
388 elsif reopened? && fixed_version.closed?
388 elsif reopened? && fixed_version.closed?
389 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
389 errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
390 end
390 end
391 end
391 end
392
392
393 # Checks that the issue can not be added/moved to a disabled tracker
393 # Checks that the issue can not be added/moved to a disabled tracker
394 if project && (tracker_id_changed? || project_id_changed?)
394 if project && (tracker_id_changed? || project_id_changed?)
395 unless project.trackers.include?(tracker)
395 unless project.trackers.include?(tracker)
396 errors.add :tracker_id, :inclusion
396 errors.add :tracker_id, :inclusion
397 end
397 end
398 end
398 end
399
399
400 # Checks parent issue assignment
400 # Checks parent issue assignment
401 if @parent_issue
401 if @parent_issue
402 if @parent_issue.project_id != project_id
402 if @parent_issue.project_id != project_id
403 errors.add :parent_issue_id, :not_same_project
403 errors.add :parent_issue_id, :not_same_project
404 elsif !new_record?
404 elsif !new_record?
405 # moving an existing issue
405 # moving an existing issue
406 if @parent_issue.root_id != root_id
406 if @parent_issue.root_id != root_id
407 # we can always move to another tree
407 # we can always move to another tree
408 elsif move_possible?(@parent_issue)
408 elsif move_possible?(@parent_issue)
409 # move accepted inside tree
409 # move accepted inside tree
410 else
410 else
411 errors.add :parent_issue_id, :not_a_valid_parent
411 errors.add :parent_issue_id, :not_a_valid_parent
412 end
412 end
413 end
413 end
414 end
414 end
415 end
415 end
416
416
417 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
417 # Set the done_ratio using the status if that setting is set. This will keep the done_ratios
418 # even if the user turns off the setting later
418 # even if the user turns off the setting later
419 def update_done_ratio_from_issue_status
419 def update_done_ratio_from_issue_status
420 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
420 if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
421 self.done_ratio = status.default_done_ratio
421 self.done_ratio = status.default_done_ratio
422 end
422 end
423 end
423 end
424
424
425 def init_journal(user, notes = "")
425 def init_journal(user, notes = "")
426 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
426 @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
427 if new_record?
427 if new_record?
428 @current_journal.notify = false
428 @current_journal.notify = false
429 else
429 else
430 @attributes_before_change = attributes.dup
430 @attributes_before_change = attributes.dup
431 @custom_values_before_change = {}
431 @custom_values_before_change = {}
432 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
432 self.custom_field_values.each {|c| @custom_values_before_change.store c.custom_field_id, c.value }
433 end
433 end
434 # Make sure updated_on is updated when adding a note.
434 # Make sure updated_on is updated when adding a note.
435 updated_on_will_change!
435 updated_on_will_change!
436 @current_journal
436 @current_journal
437 end
437 end
438
438
439 # Returns the id of the last journal or nil
439 # Returns the id of the last journal or nil
440 def last_journal_id
440 def last_journal_id
441 if new_record?
441 if new_record?
442 nil
442 nil
443 else
443 else
444 journals.first(:order => "#{Journal.table_name}.id DESC").try(:id)
444 journals.first(:order => "#{Journal.table_name}.id DESC").try(:id)
445 end
445 end
446 end
446 end
447
447
448 # Return true if the issue is closed, otherwise false
448 # Return true if the issue is closed, otherwise false
449 def closed?
449 def closed?
450 self.status.is_closed?
450 self.status.is_closed?
451 end
451 end
452
452
453 # Return true if the issue is being reopened
453 # Return true if the issue is being reopened
454 def reopened?
454 def reopened?
455 if !new_record? && status_id_changed?
455 if !new_record? && status_id_changed?
456 status_was = IssueStatus.find_by_id(status_id_was)
456 status_was = IssueStatus.find_by_id(status_id_was)
457 status_new = IssueStatus.find_by_id(status_id)
457 status_new = IssueStatus.find_by_id(status_id)
458 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
458 if status_was && status_new && status_was.is_closed? && !status_new.is_closed?
459 return true
459 return true
460 end
460 end
461 end
461 end
462 false
462 false
463 end
463 end
464
464
465 # Return true if the issue is being closed
465 # Return true if the issue is being closed
466 def closing?
466 def closing?
467 if !new_record? && status_id_changed?
467 if !new_record? && status_id_changed?
468 status_was = IssueStatus.find_by_id(status_id_was)
468 status_was = IssueStatus.find_by_id(status_id_was)
469 status_new = IssueStatus.find_by_id(status_id)
469 status_new = IssueStatus.find_by_id(status_id)
470 if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
470 if status_was && status_new && !status_was.is_closed? && status_new.is_closed?
471 return true
471 return true
472 end
472 end
473 end
473 end
474 false
474 false
475 end
475 end
476
476
477 # Returns true if the issue is overdue
477 # Returns true if the issue is overdue
478 def overdue?
478 def overdue?
479 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
479 !due_date.nil? && (due_date < Date.today) && !status.is_closed?
480 end
480 end
481
481
482 # Is the amount of work done less than it should for the due date
482 # Is the amount of work done less than it should for the due date
483 def behind_schedule?
483 def behind_schedule?
484 return false if start_date.nil? || due_date.nil?
484 return false if start_date.nil? || due_date.nil?
485 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
485 done_date = start_date + ((due_date - start_date+1)* done_ratio/100).floor
486 return done_date <= Date.today
486 return done_date <= Date.today
487 end
487 end
488
488
489 # Does this issue have children?
489 # Does this issue have children?
490 def children?
490 def children?
491 !leaf?
491 !leaf?
492 end
492 end
493
493
494 # Users the issue can be assigned to
494 # Users the issue can be assigned to
495 def assignable_users
495 def assignable_users
496 users = project.assignable_users
496 users = project.assignable_users
497 users << author if author
497 users << author if author
498 users << assigned_to if assigned_to
498 users << assigned_to if assigned_to
499 users.uniq.sort
499 users.uniq.sort
500 end
500 end
501
501
502 # Versions that the issue can be assigned to
502 # Versions that the issue can be assigned to
503 def assignable_versions
503 def assignable_versions
504 @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
504 @assignable_versions ||= (project.shared_versions.open + [Version.find_by_id(fixed_version_id_was)]).compact.uniq.sort
505 end
505 end
506
506
507 # Returns true if this issue is blocked by another issue that is still open
507 # Returns true if this issue is blocked by another issue that is still open
508 def blocked?
508 def blocked?
509 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
509 !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
510 end
510 end
511
511
512 # Returns an array of status that user is able to apply
512 # Returns an array of status that user is able to apply
513 def new_statuses_allowed_to(user, include_default=false)
513 def new_statuses_allowed_to(user=User.current, include_default=false)
514 statuses = status.find_new_statuses_allowed_to(
514 statuses = status.find_new_statuses_allowed_to(
515 user.admin ? Role.all : user.roles_for_project(project),
515 user.admin ? Role.all : user.roles_for_project(project),
516 tracker,
516 tracker,
517 author == user,
517 author == user,
518 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
518 assigned_to_id_changed? ? assigned_to_id_was == user.id : assigned_to_id == user.id
519 )
519 )
520 statuses << status unless statuses.empty?
520 statuses << status unless statuses.empty?
521 statuses << IssueStatus.default if include_default
521 statuses << IssueStatus.default if include_default
522 statuses = statuses.uniq.sort
522 statuses = statuses.uniq.sort
523 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
523 blocked? ? statuses.reject {|s| s.is_closed?} : statuses
524 end
524 end
525
525
526 def assigned_to_was
526 def assigned_to_was
527 if assigned_to_id_changed? && assigned_to_id_was.present?
527 if assigned_to_id_changed? && assigned_to_id_was.present?
528 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
528 @assigned_to_was ||= User.find_by_id(assigned_to_id_was)
529 end
529 end
530 end
530 end
531
531
532 # Returns the mail adresses of users that should be notified
532 # Returns the mail adresses of users that should be notified
533 def recipients
533 def recipients
534 notified = []
534 notified = []
535 # Author and assignee are always notified unless they have been
535 # Author and assignee are always notified unless they have been
536 # locked or don't want to be notified
536 # locked or don't want to be notified
537 notified << author if author
537 notified << author if author
538 if assigned_to
538 if assigned_to
539 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
539 notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
540 end
540 end
541 if assigned_to_was
541 if assigned_to_was
542 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
542 notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
543 end
543 end
544 notified = notified.select {|u| u.active? && u.notify_about?(self)}
544 notified = notified.select {|u| u.active? && u.notify_about?(self)}
545
545
546 notified += project.notified_users
546 notified += project.notified_users
547 notified.uniq!
547 notified.uniq!
548 # Remove users that can not view the issue
548 # Remove users that can not view the issue
549 notified.reject! {|user| !visible?(user)}
549 notified.reject! {|user| !visible?(user)}
550 notified.collect(&:mail)
550 notified.collect(&:mail)
551 end
551 end
552
552
553 # Returns the number of hours spent on this issue
553 # Returns the number of hours spent on this issue
554 def spent_hours
554 def spent_hours
555 @spent_hours ||= time_entries.sum(:hours) || 0
555 @spent_hours ||= time_entries.sum(:hours) || 0
556 end
556 end
557
557
558 # Returns the total number of hours spent on this issue and its descendants
558 # Returns the total number of hours spent on this issue and its descendants
559 #
559 #
560 # Example:
560 # Example:
561 # spent_hours => 0.0
561 # spent_hours => 0.0
562 # spent_hours => 50.2
562 # spent_hours => 50.2
563 def total_spent_hours
563 def total_spent_hours
564 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
564 @total_spent_hours ||= self_and_descendants.sum("#{TimeEntry.table_name}.hours",
565 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
565 :joins => "LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").to_f || 0.0
566 end
566 end
567
567
568 def relations
568 def relations
569 @relations ||= (relations_from + relations_to).sort
569 @relations ||= (relations_from + relations_to).sort
570 end
570 end
571
571
572 # Preloads relations for a collection of issues
572 # Preloads relations for a collection of issues
573 def self.load_relations(issues)
573 def self.load_relations(issues)
574 if issues.any?
574 if issues.any?
575 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
575 relations = IssueRelation.all(:conditions => ["issue_from_id IN (:ids) OR issue_to_id IN (:ids)", {:ids => issues.map(&:id)}])
576 issues.each do |issue|
576 issues.each do |issue|
577 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
577 issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
578 end
578 end
579 end
579 end
580 end
580 end
581
581
582 # Preloads visible spent time for a collection of issues
582 # Preloads visible spent time for a collection of issues
583 def self.load_visible_spent_hours(issues, user=User.current)
583 def self.load_visible_spent_hours(issues, user=User.current)
584 if issues.any?
584 if issues.any?
585 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
585 hours_by_issue_id = TimeEntry.visible(user).sum(:hours, :group => :issue_id)
586 issues.each do |issue|
586 issues.each do |issue|
587 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
587 issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
588 end
588 end
589 end
589 end
590 end
590 end
591
591
592 # Finds an issue relation given its id.
592 # Finds an issue relation given its id.
593 def find_relation(relation_id)
593 def find_relation(relation_id)
594 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
594 IssueRelation.find(relation_id, :conditions => ["issue_to_id = ? OR issue_from_id = ?", id, id])
595 end
595 end
596
596
597 def all_dependent_issues(except=[])
597 def all_dependent_issues(except=[])
598 except << self
598 except << self
599 dependencies = []
599 dependencies = []
600 relations_from.each do |relation|
600 relations_from.each do |relation|
601 if relation.issue_to && !except.include?(relation.issue_to)
601 if relation.issue_to && !except.include?(relation.issue_to)
602 dependencies << relation.issue_to
602 dependencies << relation.issue_to
603 dependencies += relation.issue_to.all_dependent_issues(except)
603 dependencies += relation.issue_to.all_dependent_issues(except)
604 end
604 end
605 end
605 end
606 dependencies
606 dependencies
607 end
607 end
608
608
609 # Returns an array of issues that duplicate this one
609 # Returns an array of issues that duplicate this one
610 def duplicates
610 def duplicates
611 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
611 relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
612 end
612 end
613
613
614 # Returns the due date or the target due date if any
614 # Returns the due date or the target due date if any
615 # Used on gantt chart
615 # Used on gantt chart
616 def due_before
616 def due_before
617 due_date || (fixed_version ? fixed_version.effective_date : nil)
617 due_date || (fixed_version ? fixed_version.effective_date : nil)
618 end
618 end
619
619
620 # Returns the time scheduled for this issue.
620 # Returns the time scheduled for this issue.
621 #
621 #
622 # Example:
622 # Example:
623 # Start Date: 2/26/09, End Date: 3/04/09
623 # Start Date: 2/26/09, End Date: 3/04/09
624 # duration => 6
624 # duration => 6
625 def duration
625 def duration
626 (start_date && due_date) ? due_date - start_date : 0
626 (start_date && due_date) ? due_date - start_date : 0
627 end
627 end
628
628
629 def soonest_start
629 def soonest_start
630 @soonest_start ||= (
630 @soonest_start ||= (
631 relations_to.collect{|relation| relation.successor_soonest_start} +
631 relations_to.collect{|relation| relation.successor_soonest_start} +
632 ancestors.collect(&:soonest_start)
632 ancestors.collect(&:soonest_start)
633 ).compact.max
633 ).compact.max
634 end
634 end
635
635
636 def reschedule_after(date)
636 def reschedule_after(date)
637 return if date.nil?
637 return if date.nil?
638 if leaf?
638 if leaf?
639 if start_date.nil? || start_date < date
639 if start_date.nil? || start_date < date
640 self.start_date, self.due_date = date, date + duration
640 self.start_date, self.due_date = date, date + duration
641 save
641 save
642 end
642 end
643 else
643 else
644 leaves.each do |leaf|
644 leaves.each do |leaf|
645 leaf.reschedule_after(date)
645 leaf.reschedule_after(date)
646 end
646 end
647 end
647 end
648 end
648 end
649
649
650 def <=>(issue)
650 def <=>(issue)
651 if issue.nil?
651 if issue.nil?
652 -1
652 -1
653 elsif root_id != issue.root_id
653 elsif root_id != issue.root_id
654 (root_id || 0) <=> (issue.root_id || 0)
654 (root_id || 0) <=> (issue.root_id || 0)
655 else
655 else
656 (lft || 0) <=> (issue.lft || 0)
656 (lft || 0) <=> (issue.lft || 0)
657 end
657 end
658 end
658 end
659
659
660 def to_s
660 def to_s
661 "#{tracker} ##{id}: #{subject}"
661 "#{tracker} ##{id}: #{subject}"
662 end
662 end
663
663
664 # Returns a string of css classes that apply to the issue
664 # Returns a string of css classes that apply to the issue
665 def css_classes
665 def css_classes
666 s = "issue status-#{status.position} priority-#{priority.position}"
666 s = "issue status-#{status.position} priority-#{priority.position}"
667 s << ' closed' if closed?
667 s << ' closed' if closed?
668 s << ' overdue' if overdue?
668 s << ' overdue' if overdue?
669 s << ' child' if child?
669 s << ' child' if child?
670 s << ' parent' unless leaf?
670 s << ' parent' unless leaf?
671 s << ' private' if is_private?
671 s << ' private' if is_private?
672 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
672 s << ' created-by-me' if User.current.logged? && author_id == User.current.id
673 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
673 s << ' assigned-to-me' if User.current.logged? && assigned_to_id == User.current.id
674 s
674 s
675 end
675 end
676
676
677 # Saves an issue, time_entry, attachments, and a journal from the parameters
677 # Saves an issue, time_entry, attachments, and a journal from the parameters
678 # Returns false if save fails
678 # Returns false if save fails
679 def save_issue_with_child_records(params, existing_time_entry=nil)
679 def save_issue_with_child_records(params, existing_time_entry=nil)
680 Issue.transaction do
680 Issue.transaction do
681 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
681 if params[:time_entry] && (params[:time_entry][:hours].present? || params[:time_entry][:comments].present?) && User.current.allowed_to?(:log_time, project)
682 @time_entry = existing_time_entry || TimeEntry.new
682 @time_entry = existing_time_entry || TimeEntry.new
683 @time_entry.project = project
683 @time_entry.project = project
684 @time_entry.issue = self
684 @time_entry.issue = self
685 @time_entry.user = User.current
685 @time_entry.user = User.current
686 @time_entry.spent_on = User.current.today
686 @time_entry.spent_on = User.current.today
687 @time_entry.attributes = params[:time_entry]
687 @time_entry.attributes = params[:time_entry]
688 self.time_entries << @time_entry
688 self.time_entries << @time_entry
689 end
689 end
690
690
691 if valid?
691 if valid?
692 attachments = Attachment.attach_files(self, params[:attachments])
692 attachments = Attachment.attach_files(self, params[:attachments])
693 # TODO: Rename hook
693 # TODO: Rename hook
694 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
694 Redmine::Hook.call_hook(:controller_issues_edit_before_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
695 begin
695 begin
696 if save
696 if save
697 # TODO: Rename hook
697 # TODO: Rename hook
698 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
698 Redmine::Hook.call_hook(:controller_issues_edit_after_save, { :params => params, :issue => self, :time_entry => @time_entry, :journal => @current_journal})
699 else
699 else
700 raise ActiveRecord::Rollback
700 raise ActiveRecord::Rollback
701 end
701 end
702 rescue ActiveRecord::StaleObjectError
702 rescue ActiveRecord::StaleObjectError
703 attachments[:files].each(&:destroy)
703 attachments[:files].each(&:destroy)
704 raise ActiveRecord::StaleObjectError
704 raise ActiveRecord::StaleObjectError
705 end
705 end
706 end
706 end
707 end
707 end
708 end
708 end
709
709
710 # Unassigns issues from +version+ if it's no longer shared with issue's project
710 # Unassigns issues from +version+ if it's no longer shared with issue's project
711 def self.update_versions_from_sharing_change(version)
711 def self.update_versions_from_sharing_change(version)
712 # Update issues assigned to the version
712 # Update issues assigned to the version
713 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
713 update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
714 end
714 end
715
715
716 # Unassigns issues from versions that are no longer shared
716 # Unassigns issues from versions that are no longer shared
717 # after +project+ was moved
717 # after +project+ was moved
718 def self.update_versions_from_hierarchy_change(project)
718 def self.update_versions_from_hierarchy_change(project)
719 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
719 moved_project_ids = project.self_and_descendants.reload.collect(&:id)
720 # Update issues of the moved projects and issues assigned to a version of a moved project
720 # Update issues of the moved projects and issues assigned to a version of a moved project
721 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
721 Issue.update_versions(["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)", moved_project_ids, moved_project_ids])
722 end
722 end
723
723
724 def parent_issue_id=(arg)
724 def parent_issue_id=(arg)
725 parent_issue_id = arg.blank? ? nil : arg.to_i
725 parent_issue_id = arg.blank? ? nil : arg.to_i
726 if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
726 if parent_issue_id && @parent_issue = Issue.find_by_id(parent_issue_id)
727 @parent_issue.id
727 @parent_issue.id
728 else
728 else
729 @parent_issue = nil
729 @parent_issue = nil
730 nil
730 nil
731 end
731 end
732 end
732 end
733
733
734 def parent_issue_id
734 def parent_issue_id
735 if instance_variable_defined? :@parent_issue
735 if instance_variable_defined? :@parent_issue
736 @parent_issue.nil? ? nil : @parent_issue.id
736 @parent_issue.nil? ? nil : @parent_issue.id
737 else
737 else
738 parent_id
738 parent_id
739 end
739 end
740 end
740 end
741
741
742 # Extracted from the ReportsController.
742 # Extracted from the ReportsController.
743 def self.by_tracker(project)
743 def self.by_tracker(project)
744 count_and_group_by(:project => project,
744 count_and_group_by(:project => project,
745 :field => 'tracker_id',
745 :field => 'tracker_id',
746 :joins => Tracker.table_name)
746 :joins => Tracker.table_name)
747 end
747 end
748
748
749 def self.by_version(project)
749 def self.by_version(project)
750 count_and_group_by(:project => project,
750 count_and_group_by(:project => project,
751 :field => 'fixed_version_id',
751 :field => 'fixed_version_id',
752 :joins => Version.table_name)
752 :joins => Version.table_name)
753 end
753 end
754
754
755 def self.by_priority(project)
755 def self.by_priority(project)
756 count_and_group_by(:project => project,
756 count_and_group_by(:project => project,
757 :field => 'priority_id',
757 :field => 'priority_id',
758 :joins => IssuePriority.table_name)
758 :joins => IssuePriority.table_name)
759 end
759 end
760
760
761 def self.by_category(project)
761 def self.by_category(project)
762 count_and_group_by(:project => project,
762 count_and_group_by(:project => project,
763 :field => 'category_id',
763 :field => 'category_id',
764 :joins => IssueCategory.table_name)
764 :joins => IssueCategory.table_name)
765 end
765 end
766
766
767 def self.by_assigned_to(project)
767 def self.by_assigned_to(project)
768 count_and_group_by(:project => project,
768 count_and_group_by(:project => project,
769 :field => 'assigned_to_id',
769 :field => 'assigned_to_id',
770 :joins => User.table_name)
770 :joins => User.table_name)
771 end
771 end
772
772
773 def self.by_author(project)
773 def self.by_author(project)
774 count_and_group_by(:project => project,
774 count_and_group_by(:project => project,
775 :field => 'author_id',
775 :field => 'author_id',
776 :joins => User.table_name)
776 :joins => User.table_name)
777 end
777 end
778
778
779 def self.by_subproject(project)
779 def self.by_subproject(project)
780 ActiveRecord::Base.connection.select_all("select s.id as status_id,
780 ActiveRecord::Base.connection.select_all("select s.id as status_id,
781 s.is_closed as closed,
781 s.is_closed as closed,
782 #{Issue.table_name}.project_id as project_id,
782 #{Issue.table_name}.project_id as project_id,
783 count(#{Issue.table_name}.id) as total
783 count(#{Issue.table_name}.id) as total
784 from
784 from
785 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
785 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s
786 where
786 where
787 #{Issue.table_name}.status_id=s.id
787 #{Issue.table_name}.status_id=s.id
788 and #{Issue.table_name}.project_id = #{Project.table_name}.id
788 and #{Issue.table_name}.project_id = #{Project.table_name}.id
789 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
789 and #{visible_condition(User.current, :project => project, :with_subprojects => true)}
790 and #{Issue.table_name}.project_id <> #{project.id}
790 and #{Issue.table_name}.project_id <> #{project.id}
791 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
791 group by s.id, s.is_closed, #{Issue.table_name}.project_id") if project.descendants.active.any?
792 end
792 end
793 # End ReportsController extraction
793 # End ReportsController extraction
794
794
795 # Returns an array of projects that user can assign the issue to
795 # Returns an array of projects that user can assign the issue to
796 def allowed_target_projects(user=User.current)
796 def allowed_target_projects(user=User.current)
797 if new_record?
797 if new_record?
798 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
798 Project.all(:conditions => Project.allowed_to_condition(user, :add_issues))
799 else
799 else
800 self.class.allowed_target_projects_on_move(user)
800 self.class.allowed_target_projects_on_move(user)
801 end
801 end
802 end
802 end
803
803
804 # Returns an array of projects that user can move issues to
804 # Returns an array of projects that user can move issues to
805 def self.allowed_target_projects_on_move(user=User.current)
805 def self.allowed_target_projects_on_move(user=User.current)
806 projects = []
806 projects = []
807 if user.admin?
807 if user.admin?
808 # admin is allowed to move issues to any active (visible) project
808 # admin is allowed to move issues to any active (visible) project
809 projects = Project.visible(user).all
809 projects = Project.visible(user).all
810 elsif user.logged?
810 elsif user.logged?
811 if Role.non_member.allowed_to?(:move_issues)
811 if Role.non_member.allowed_to?(:move_issues)
812 projects = Project.visible(user).all
812 projects = Project.visible(user).all
813 else
813 else
814 user.memberships.each {|m| projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
814 user.memberships.each {|m| projects << m.project if m.roles.detect {|r| r.allowed_to?(:move_issues)}}
815 end
815 end
816 end
816 end
817 projects
817 projects
818 end
818 end
819
819
820 private
820 private
821
821
822 def after_project_change
822 def after_project_change
823 # Update project_id on related time entries
823 # Update project_id on related time entries
824 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
824 TimeEntry.update_all(["project_id = ?", project_id], {:issue_id => id})
825
825
826 # Delete issue relations
826 # Delete issue relations
827 unless Setting.cross_project_issue_relations?
827 unless Setting.cross_project_issue_relations?
828 relations_from.clear
828 relations_from.clear
829 relations_to.clear
829 relations_to.clear
830 end
830 end
831
831
832 # Move subtasks
832 # Move subtasks
833 children.each do |child|
833 children.each do |child|
834 # Change project and keep project
834 # Change project and keep project
835 child.send :project=, project, true
835 child.send :project=, project, true
836 unless child.save
836 unless child.save
837 raise ActiveRecord::Rollback
837 raise ActiveRecord::Rollback
838 end
838 end
839 end
839 end
840 end
840 end
841
841
842 def update_nested_set_attributes
842 def update_nested_set_attributes
843 if root_id.nil?
843 if root_id.nil?
844 # issue was just created
844 # issue was just created
845 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
845 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id)
846 set_default_left_and_right
846 set_default_left_and_right
847 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
847 Issue.update_all("root_id = #{root_id}, lft = #{lft}, rgt = #{rgt}", ["id = ?", id])
848 if @parent_issue
848 if @parent_issue
849 move_to_child_of(@parent_issue)
849 move_to_child_of(@parent_issue)
850 end
850 end
851 reload
851 reload
852 elsif parent_issue_id != parent_id
852 elsif parent_issue_id != parent_id
853 former_parent_id = parent_id
853 former_parent_id = parent_id
854 # moving an existing issue
854 # moving an existing issue
855 if @parent_issue && @parent_issue.root_id == root_id
855 if @parent_issue && @parent_issue.root_id == root_id
856 # inside the same tree
856 # inside the same tree
857 move_to_child_of(@parent_issue)
857 move_to_child_of(@parent_issue)
858 else
858 else
859 # to another tree
859 # to another tree
860 unless root?
860 unless root?
861 move_to_right_of(root)
861 move_to_right_of(root)
862 reload
862 reload
863 end
863 end
864 old_root_id = root_id
864 old_root_id = root_id
865 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
865 self.root_id = (@parent_issue.nil? ? id : @parent_issue.root_id )
866 target_maxright = nested_set_scope.maximum(right_column_name) || 0
866 target_maxright = nested_set_scope.maximum(right_column_name) || 0
867 offset = target_maxright + 1 - lft
867 offset = target_maxright + 1 - lft
868 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
868 Issue.update_all("root_id = #{root_id}, lft = lft + #{offset}, rgt = rgt + #{offset}",
869 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
869 ["root_id = ? AND lft >= ? AND rgt <= ? ", old_root_id, lft, rgt])
870 self[left_column_name] = lft + offset
870 self[left_column_name] = lft + offset
871 self[right_column_name] = rgt + offset
871 self[right_column_name] = rgt + offset
872 if @parent_issue
872 if @parent_issue
873 move_to_child_of(@parent_issue)
873 move_to_child_of(@parent_issue)
874 end
874 end
875 end
875 end
876 reload
876 reload
877 # delete invalid relations of all descendants
877 # delete invalid relations of all descendants
878 self_and_descendants.each do |issue|
878 self_and_descendants.each do |issue|
879 issue.relations.each do |relation|
879 issue.relations.each do |relation|
880 relation.destroy unless relation.valid?
880 relation.destroy unless relation.valid?
881 end
881 end
882 end
882 end
883 # update former parent
883 # update former parent
884 recalculate_attributes_for(former_parent_id) if former_parent_id
884 recalculate_attributes_for(former_parent_id) if former_parent_id
885 end
885 end
886 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
886 remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
887 end
887 end
888
888
889 def update_parent_attributes
889 def update_parent_attributes
890 recalculate_attributes_for(parent_id) if parent_id
890 recalculate_attributes_for(parent_id) if parent_id
891 end
891 end
892
892
893 def recalculate_attributes_for(issue_id)
893 def recalculate_attributes_for(issue_id)
894 if issue_id && p = Issue.find_by_id(issue_id)
894 if issue_id && p = Issue.find_by_id(issue_id)
895 # priority = highest priority of children
895 # priority = highest priority of children
896 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
896 if priority_position = p.children.maximum("#{IssuePriority.table_name}.position", :joins => :priority)
897 p.priority = IssuePriority.find_by_position(priority_position)
897 p.priority = IssuePriority.find_by_position(priority_position)
898 end
898 end
899
899
900 # start/due dates = lowest/highest dates of children
900 # start/due dates = lowest/highest dates of children
901 p.start_date = p.children.minimum(:start_date)
901 p.start_date = p.children.minimum(:start_date)
902 p.due_date = p.children.maximum(:due_date)
902 p.due_date = p.children.maximum(:due_date)
903 if p.start_date && p.due_date && p.due_date < p.start_date
903 if p.start_date && p.due_date && p.due_date < p.start_date
904 p.start_date, p.due_date = p.due_date, p.start_date
904 p.start_date, p.due_date = p.due_date, p.start_date
905 end
905 end
906
906
907 # done ratio = weighted average ratio of leaves
907 # done ratio = weighted average ratio of leaves
908 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
908 unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
909 leaves_count = p.leaves.count
909 leaves_count = p.leaves.count
910 if leaves_count > 0
910 if leaves_count > 0
911 average = p.leaves.average(:estimated_hours).to_f
911 average = p.leaves.average(:estimated_hours).to_f
912 if average == 0
912 if average == 0
913 average = 1
913 average = 1
914 end
914 end
915 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
915 done = p.leaves.sum("COALESCE(estimated_hours, #{average}) * (CASE WHEN is_closed = #{connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)", :joins => :status).to_f
916 progress = done / (average * leaves_count)
916 progress = done / (average * leaves_count)
917 p.done_ratio = progress.round
917 p.done_ratio = progress.round
918 end
918 end
919 end
919 end
920
920
921 # estimate = sum of leaves estimates
921 # estimate = sum of leaves estimates
922 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
922 p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
923 p.estimated_hours = nil if p.estimated_hours == 0.0
923 p.estimated_hours = nil if p.estimated_hours == 0.0
924
924
925 # ancestors will be recursively updated
925 # ancestors will be recursively updated
926 p.save(false)
926 p.save(false)
927 end
927 end
928 end
928 end
929
929
930 # Update issues so their versions are not pointing to a
930 # Update issues so their versions are not pointing to a
931 # fixed_version that is not shared with the issue's project
931 # fixed_version that is not shared with the issue's project
932 def self.update_versions(conditions=nil)
932 def self.update_versions(conditions=nil)
933 # Only need to update issues with a fixed_version from
933 # Only need to update issues with a fixed_version from
934 # a different project and that is not systemwide shared
934 # a different project and that is not systemwide shared
935 Issue.scoped(:conditions => conditions).all(
935 Issue.scoped(:conditions => conditions).all(
936 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
936 :conditions => "#{Issue.table_name}.fixed_version_id IS NOT NULL" +
937 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
937 " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
938 " AND #{Version.table_name}.sharing <> 'system'",
938 " AND #{Version.table_name}.sharing <> 'system'",
939 :include => [:project, :fixed_version]
939 :include => [:project, :fixed_version]
940 ).each do |issue|
940 ).each do |issue|
941 next if issue.project.nil? || issue.fixed_version.nil?
941 next if issue.project.nil? || issue.fixed_version.nil?
942 unless issue.project.shared_versions.include?(issue.fixed_version)
942 unless issue.project.shared_versions.include?(issue.fixed_version)
943 issue.init_journal(User.current)
943 issue.init_journal(User.current)
944 issue.fixed_version = nil
944 issue.fixed_version = nil
945 issue.save
945 issue.save
946 end
946 end
947 end
947 end
948 end
948 end
949
949
950 # Callback on attachment deletion
950 # Callback on attachment deletion
951 def attachment_added(obj)
951 def attachment_added(obj)
952 if @current_journal && !obj.new_record?
952 if @current_journal && !obj.new_record?
953 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
953 @current_journal.details << JournalDetail.new(:property => 'attachment', :prop_key => obj.id, :value => obj.filename)
954 end
954 end
955 end
955 end
956
956
957 # Callback on attachment deletion
957 # Callback on attachment deletion
958 def attachment_removed(obj)
958 def attachment_removed(obj)
959 journal = init_journal(User.current)
959 journal = init_journal(User.current)
960 journal.details << JournalDetail.new(:property => 'attachment',
960 journal.details << JournalDetail.new(:property => 'attachment',
961 :prop_key => obj.id,
961 :prop_key => obj.id,
962 :old_value => obj.filename)
962 :old_value => obj.filename)
963 journal.save
963 journal.save
964 end
964 end
965
965
966 # Default assignment based on category
966 # Default assignment based on category
967 def default_assign
967 def default_assign
968 if assigned_to.nil? && category && category.assigned_to
968 if assigned_to.nil? && category && category.assigned_to
969 self.assigned_to = category.assigned_to
969 self.assigned_to = category.assigned_to
970 end
970 end
971 end
971 end
972
972
973 # Updates start/due dates of following issues
973 # Updates start/due dates of following issues
974 def reschedule_following_issues
974 def reschedule_following_issues
975 if start_date_changed? || due_date_changed?
975 if start_date_changed? || due_date_changed?
976 relations_from.each do |relation|
976 relations_from.each do |relation|
977 relation.set_issue_to_dates
977 relation.set_issue_to_dates
978 end
978 end
979 end
979 end
980 end
980 end
981
981
982 # Closes duplicates if the issue is being closed
982 # Closes duplicates if the issue is being closed
983 def close_duplicates
983 def close_duplicates
984 if closing?
984 if closing?
985 duplicates.each do |duplicate|
985 duplicates.each do |duplicate|
986 # Reload is need in case the duplicate was updated by a previous duplicate
986 # Reload is need in case the duplicate was updated by a previous duplicate
987 duplicate.reload
987 duplicate.reload
988 # Don't re-close it if it's already closed
988 # Don't re-close it if it's already closed
989 next if duplicate.closed?
989 next if duplicate.closed?
990 # Same user and notes
990 # Same user and notes
991 if @current_journal
991 if @current_journal
992 duplicate.init_journal(@current_journal.user, @current_journal.notes)
992 duplicate.init_journal(@current_journal.user, @current_journal.notes)
993 end
993 end
994 duplicate.update_attribute :status, self.status
994 duplicate.update_attribute :status, self.status
995 end
995 end
996 end
996 end
997 end
997 end
998
998
999 # Saves the changes in a Journal
999 # Saves the changes in a Journal
1000 # Called after_save
1000 # Called after_save
1001 def create_journal
1001 def create_journal
1002 if @current_journal
1002 if @current_journal
1003 # attributes changes
1003 # attributes changes
1004 if @attributes_before_change
1004 if @attributes_before_change
1005 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
1005 (Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on)).each {|c|
1006 before = @attributes_before_change[c]
1006 before = @attributes_before_change[c]
1007 after = send(c)
1007 after = send(c)
1008 next if before == after || (before.blank? && after.blank?)
1008 next if before == after || (before.blank? && after.blank?)
1009 @current_journal.details << JournalDetail.new(:property => 'attr',
1009 @current_journal.details << JournalDetail.new(:property => 'attr',
1010 :prop_key => c,
1010 :prop_key => c,
1011 :old_value => before,
1011 :old_value => before,
1012 :value => after)
1012 :value => after)
1013 }
1013 }
1014 end
1014 end
1015 if @custom_values_before_change
1015 if @custom_values_before_change
1016 # custom fields changes
1016 # custom fields changes
1017 custom_field_values.each {|c|
1017 custom_field_values.each {|c|
1018 before = @custom_values_before_change[c.custom_field_id]
1018 before = @custom_values_before_change[c.custom_field_id]
1019 after = c.value
1019 after = c.value
1020 next if before == after || (before.blank? && after.blank?)
1020 next if before == after || (before.blank? && after.blank?)
1021
1021
1022 if before.is_a?(Array) || after.is_a?(Array)
1022 if before.is_a?(Array) || after.is_a?(Array)
1023 before = [before] unless before.is_a?(Array)
1023 before = [before] unless before.is_a?(Array)
1024 after = [after] unless after.is_a?(Array)
1024 after = [after] unless after.is_a?(Array)
1025
1025
1026 # values removed
1026 # values removed
1027 (before - after).reject(&:blank?).each do |value|
1027 (before - after).reject(&:blank?).each do |value|
1028 @current_journal.details << JournalDetail.new(:property => 'cf',
1028 @current_journal.details << JournalDetail.new(:property => 'cf',
1029 :prop_key => c.custom_field_id,
1029 :prop_key => c.custom_field_id,
1030 :old_value => value,
1030 :old_value => value,
1031 :value => nil)
1031 :value => nil)
1032 end
1032 end
1033 # values added
1033 # values added
1034 (after - before).reject(&:blank?).each do |value|
1034 (after - before).reject(&:blank?).each do |value|
1035 @current_journal.details << JournalDetail.new(:property => 'cf',
1035 @current_journal.details << JournalDetail.new(:property => 'cf',
1036 :prop_key => c.custom_field_id,
1036 :prop_key => c.custom_field_id,
1037 :old_value => nil,
1037 :old_value => nil,
1038 :value => value)
1038 :value => value)
1039 end
1039 end
1040 else
1040 else
1041 @current_journal.details << JournalDetail.new(:property => 'cf',
1041 @current_journal.details << JournalDetail.new(:property => 'cf',
1042 :prop_key => c.custom_field_id,
1042 :prop_key => c.custom_field_id,
1043 :old_value => before,
1043 :old_value => before,
1044 :value => after)
1044 :value => after)
1045 end
1045 end
1046 }
1046 }
1047 end
1047 end
1048 @current_journal.save
1048 @current_journal.save
1049 # reset current journal
1049 # reset current journal
1050 init_journal @current_journal.user, @current_journal.notes
1050 init_journal @current_journal.user, @current_journal.notes
1051 end
1051 end
1052 end
1052 end
1053
1053
1054 # Query generator for selecting groups of issue counts for a project
1054 # Query generator for selecting groups of issue counts for a project
1055 # based on specific criteria
1055 # based on specific criteria
1056 #
1056 #
1057 # Options
1057 # Options
1058 # * project - Project to search in.
1058 # * project - Project to search in.
1059 # * field - String. Issue field to key off of in the grouping.
1059 # * field - String. Issue field to key off of in the grouping.
1060 # * joins - String. The table name to join against.
1060 # * joins - String. The table name to join against.
1061 def self.count_and_group_by(options)
1061 def self.count_and_group_by(options)
1062 project = options.delete(:project)
1062 project = options.delete(:project)
1063 select_field = options.delete(:field)
1063 select_field = options.delete(:field)
1064 joins = options.delete(:joins)
1064 joins = options.delete(:joins)
1065
1065
1066 where = "#{Issue.table_name}.#{select_field}=j.id"
1066 where = "#{Issue.table_name}.#{select_field}=j.id"
1067
1067
1068 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1068 ActiveRecord::Base.connection.select_all("select s.id as status_id,
1069 s.is_closed as closed,
1069 s.is_closed as closed,
1070 j.id as #{select_field},
1070 j.id as #{select_field},
1071 count(#{Issue.table_name}.id) as total
1071 count(#{Issue.table_name}.id) as total
1072 from
1072 from
1073 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1073 #{Issue.table_name}, #{Project.table_name}, #{IssueStatus.table_name} s, #{joins} j
1074 where
1074 where
1075 #{Issue.table_name}.status_id=s.id
1075 #{Issue.table_name}.status_id=s.id
1076 and #{where}
1076 and #{where}
1077 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1077 and #{Issue.table_name}.project_id=#{Project.table_name}.id
1078 and #{visible_condition(User.current, :project => project)}
1078 and #{visible_condition(User.current, :project => project)}
1079 group by s.id, s.is_closed, j.id")
1079 group by s.id, s.is_closed, j.id")
1080 end
1080 end
1081 end
1081 end
General Comments 0
You need to be logged in to leave comments. Login now