jro_apps/redmine Commit - r13646:8ad326f1609c

Adds a test for #6579....

Jean-Philippe Lang -

r13646:8ad326f1609c

parent child

Context file:

r13646:8ad326f1609c

Collapse all files

test/unit/issue_nested_set_concurrency_test.rb +31 -8

                self.use_transactional_fixtures = false
                def setup
+                 skip if sqlite?
                  CustomField.delete_all
                end
                end
                def test_concurrency
-                 skip if sqlite?
-                 with_settings :notified_events => [] do
-                   # Generates an issue and destroys it in order
-                   # to load all needed classes before starting threads
-                   i = Issue.generate!
-                   root = Issue.generate!
-                   assert_difference 'Issue.count', 60 do
-                     threads = []
-.times do |i|
-                       threads << Thread.new(i) do
-                         ActiveRecord::Base.connection_pool.with_connection do
-                           begin
+                   threaded(3) do
-.times do
-                               i = Issue.generate! :parent_issue_id => root.id
-                               c1 = Issue.generate! :parent_issue_id => i.id
-                               c2.reload.destroy
-                               c1.reload.destroy
-                             end
+                   end
+                 end
+               end
+               def test_concurrent_subtasks_creation
+                 root = Issue.generate!
+                 assert_difference 'Issue.count', 30 do
+                   threaded(3) do
+.times do
+                       Issue.generate! :parent_issue_id => root.id
+                     end
+                   end
+                 end
+                 root.reload
+                 assert_equal [1, 62], [root.lft, root.rgt]
+                 children_bounds = root.children.sort_by(&:lft).map {|c| [c.lft, c.rgt]}.flatten
+                 assert_equal (2..61).to_a, children_bounds
+               end
+               private
+               def threaded(count, &block)
+                 with_settings :notified_events => [] do
+                   threads = []
+                   count.times do |i|
+                     threads << Thread.new(i) do
+                       ActiveRecord::Base.connection_pool.with_connection do
+                         begin
+                           yield
-                           rescue Exception => e
-                             Thread.current[:exception] = e.message
-                           end
-                   end
-                 end
-               end
-             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages