jro_apps/redmine Commit - r9898:87f284dcb6c5

0

app/models/repository.rb +12 -1

              class Repository < ActiveRecord::Base
                include Redmine::Ciphering
                include Redmine::SafeAttributes
+               # Maximum length for repository identifiers
+               IDENTIFIER_MAX_LENGTH = 255
                belongs_to :project
                has_many :changesets, :order => "#{Changeset.table_name}.committed_on DESC, #{Changeset.table_name}.id DESC"
                before_destroy :clear_changesets
                validates_length_of :password, :maximum => 255, :allow_nil => true
-               validates_length_of :identifier, :maximum => 255, :allow_blank => true
+               validates_length_of :identifier, :maximum => IDENTIFIER_MAX_LENGTH, :allow_blank => true
                validates_presence_of :identifier, :unless => Proc.new { |r| r.is_default? || r.set_as_default? }
                validates_uniqueness_of :identifier, :scope => :project_id, :allow_blank => true
                validates_exclusion_of :identifier, :in => %w(show entry raw changes annotate diff show stats graph)
                  end
                end
+               def identifier=(identifier)
+                 super unless identifier_frozen?
+               end
+               def identifier_frozen?
+                 errors[:identifier].blank? && !(new_record? || identifier.blank?)
+               end
                def identifier_param
                  if is_default?
                    nil

0

app/views/repositories/_form.html.erb +4 -1

              </p>
              <p><%= f.check_box :is_default, :label => :field_repository_is_default %></p>
-             <p><%= f.text_field :identifier %></p>
+             <p><%= f.text_field :identifier, :disabled => @repository.identifier_frozen?  %>
+             <% unless @repository.identifier_frozen? %>
+               <em class="info"><%= l(:text_length_between, :min => 1, :max => Repository::IDENTIFIER_MAX_LENGTH) %> <%= l(:text_repository_identifier_info).html_safe %></em>
+             <% end %></p>
              <% button_disabled = true %>
              <% if @repository %>

0

config/locales/ar.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/bg.yml +1 0

                description_date_range_interval: Изберете диапазон чрез задаване на начална и крайна дати
                description_date_from: Въведете начална дата
                description_date_to: Въведете крайна дата
+               text_repository_identifier_info: 'Позволени са малки букви (a-z), цифри, тирета и _.<br />Промяна след създаването му не е възможна.'

0

config/locales/bs.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/ca.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/cs.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/da.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/de.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Nur-Lese-Zugriff
                label_required: Erforderlich
+               text_repository_identifier_info: 'Kleinbuchstaben (a-z), Ziffern, Binde- und Unterstriche erlaubt.<br />Einmal gespeichert, kann die Kennung nicht mehr geändert werden.'

0

config/locales/el.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/en-GB.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: 'Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.'

0

config/locales/en.yml +1 0

                description_date_range_interval: Choose range by selecting start and end date
                description_date_from: Enter start date
                description_date_to: Enter end date
+               text_repository_identifier_info: 'Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.'

0

config/locales/es.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/et.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: "Lubatud on ainult väikesed tähed (a-z), numbrid ja kriipsud.<br />Peale salvestamist ei saa tunnust enam muuta."

0

config/locales/eu.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/fa.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/fi.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/fr.yml +1 0

                error_scm_annotate_big_text_file: Cette entrée ne peut pas être annotée car elle excède la taille maximale.
                setting_repositories_encodings: Encodages des fichiers et des dépôts
                label_search_for_watchers: Rechercher des observateurs
+               text_repository_identifier_info: 'Seuls les lettres minuscules (a-z), chiffres, tirets et underscore sont autorisés.<br />Un fois sauvegardé, l''identifiant ne pourra plus être modifié.'

0

config/locales/gl.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/he.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/hr.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/hu.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/id.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/it.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/ja.yml +1 0

                label_fields_permissions: フィールドに対する権限
                label_readonly: 読み取り専用
                label_required: 必須
+               text_repository_identifier_info: アルファベット小文字(a-z)・数字・ハイフン・アンダースコアが使えます。<br />識別子は後で変更することはできません。

0

config/locales/ko.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: "소문자(a-z),숫자,대쉬(-)와 밑줄(_)만 가능합니다.<br />식별자는 저장후에는 수정할 수 없습니다."

0

config/locales/lt.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/lv.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/mk.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/mn.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/nl.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: 'Alleen kleine letter (a-z), cijfers, streepjes en liggende streepjes zijn toegestaan.<br />Eenmaal opgeslagen kan de identifier niet worden gewijzigd.'

0

config/locales/no.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/pl.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/pt-BR.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/pt.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/ro.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/ru.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Допускаются только строчные латинские буквы (a-z), цифры, тире и подчеркивания.<br />После сохранения идентификатор изменить нельзя.

0

config/locales/sk.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/sl.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/sq.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: 'Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.'

0

config/locales/sr-YU.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/sr.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/sv.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Ändast gemener (a-z), siffror, streck och understreck är tillåtna.<br />När identifieraren sparats kan den inte ändras.

0

config/locales/th.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/tr.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/uk.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/vi.yml +1 0

                label_fields_permissions: Fields permissions
                label_readonly: Read-only
                label_required: Required
+               text_repository_identifier_info: Only lower case letters (a-z), numbers, dashes and underscores are allowed.<br />Once saved, the identifier cannot be changed.

0

config/locales/zh-TW.yml +1 0

                description_date_range_interval: 選擇起始與結束日期以設定範圍區間
                description_date_from: 輸入起始日期
                description_date_to: 輸入結束日期
+               text_repository_identifier_info: '僅允許使用小寫英文字母 (a-z), 阿拉伯數字, 虛線與底線。<br />一旦儲存之後, 代碼便無法再次被更改。'

0

config/locales/zh.yml +1 0

                label_fields_permissions: 字段权限
                label_readonly: 只读
                label_required: 必填
+               text_repository_identifier_info: 仅小写字母（a-z）、数字、破折号（-）和下划线（_）可以使用。<br />一旦保存，标识无法修改。

0

test/unit/repository_test.rb +32 0

		@@ -105,6 +105,38 class RepositoryTest < ActiveSupport::TestCase
105	105	)
106	106	assert r.save
107	107	end
	108
	109	def test_identifier_should_not_be_frozen_for_a_new_repository
	110	assert_equal false, Repository.new.identifier_frozen?
	111	end
	112
	113	def test_identifier_should_not_be_frozen_for_a_saved_repository_with_blank_identifier
	114	Repository.update_all(["identifier = ''"], "id = 10")
	115
	116	assert_equal false, Repository.find(10).identifier_frozen?
	117	end
	118
	119	def test_identifier_should_be_frozen_for_a_saved_repository_with_valid_identifier
	120	Repository.update_all(["identifier = 'abc123'"], "id = 10")
	121
	122	assert_equal true, Repository.find(10).identifier_frozen?
	123	end
	124
	125	def test_identifier_should_not_accept_change_if_frozen
	126	r = Repository.new(:identifier => 'foo')
	127	r.stubs(:identifier_frozen?).returns(true)
	128
	129	r.identifier = 'bar'
	130	assert_equal 'foo', r.identifier
	131	end
	132
	133	def test_identifier_should_accept_change_if_not_frozen
	134	r = Repository.new(:identifier => 'foo')
	135	r.stubs(:identifier_frozen?).returns(false)
	136
	137	r.identifier = 'bar'
	138	assert_equal 'bar', r.identifier
	139	end
108	140
109	141	def test_destroy
110	142	repository = Repository.find(10)

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages