##// END OF EJS Templates
Rails3: replace deprecated 'validate' method at IssueRelation model....
Toshi MARUYAMA -
r6817:86d6f2fe372e
parent child
Show More
@@ -1,138 +1,140
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2011 Jean-Philippe Lang
2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class IssueRelation < ActiveRecord::Base
18 class IssueRelation < ActiveRecord::Base
19 belongs_to :issue_from, :class_name => 'Issue', :foreign_key => 'issue_from_id'
19 belongs_to :issue_from, :class_name => 'Issue', :foreign_key => 'issue_from_id'
20 belongs_to :issue_to, :class_name => 'Issue', :foreign_key => 'issue_to_id'
20 belongs_to :issue_to, :class_name => 'Issue', :foreign_key => 'issue_to_id'
21
21
22 TYPE_RELATES = "relates"
22 TYPE_RELATES = "relates"
23 TYPE_DUPLICATES = "duplicates"
23 TYPE_DUPLICATES = "duplicates"
24 TYPE_DUPLICATED = "duplicated"
24 TYPE_DUPLICATED = "duplicated"
25 TYPE_BLOCKS = "blocks"
25 TYPE_BLOCKS = "blocks"
26 TYPE_BLOCKED = "blocked"
26 TYPE_BLOCKED = "blocked"
27 TYPE_PRECEDES = "precedes"
27 TYPE_PRECEDES = "precedes"
28 TYPE_FOLLOWS = "follows"
28 TYPE_FOLLOWS = "follows"
29
29
30 TYPES = { TYPE_RELATES => { :name => :label_relates_to, :sym_name => :label_relates_to, :order => 1, :sym => TYPE_RELATES },
30 TYPES = { TYPE_RELATES => { :name => :label_relates_to, :sym_name => :label_relates_to, :order => 1, :sym => TYPE_RELATES },
31 TYPE_DUPLICATES => { :name => :label_duplicates, :sym_name => :label_duplicated_by, :order => 2, :sym => TYPE_DUPLICATED },
31 TYPE_DUPLICATES => { :name => :label_duplicates, :sym_name => :label_duplicated_by, :order => 2, :sym => TYPE_DUPLICATED },
32 TYPE_DUPLICATED => { :name => :label_duplicated_by, :sym_name => :label_duplicates, :order => 3, :sym => TYPE_DUPLICATES, :reverse => TYPE_DUPLICATES },
32 TYPE_DUPLICATED => { :name => :label_duplicated_by, :sym_name => :label_duplicates, :order => 3, :sym => TYPE_DUPLICATES, :reverse => TYPE_DUPLICATES },
33 TYPE_BLOCKS => { :name => :label_blocks, :sym_name => :label_blocked_by, :order => 4, :sym => TYPE_BLOCKED },
33 TYPE_BLOCKS => { :name => :label_blocks, :sym_name => :label_blocked_by, :order => 4, :sym => TYPE_BLOCKED },
34 TYPE_BLOCKED => { :name => :label_blocked_by, :sym_name => :label_blocks, :order => 5, :sym => TYPE_BLOCKS, :reverse => TYPE_BLOCKS },
34 TYPE_BLOCKED => { :name => :label_blocked_by, :sym_name => :label_blocks, :order => 5, :sym => TYPE_BLOCKS, :reverse => TYPE_BLOCKS },
35 TYPE_PRECEDES => { :name => :label_precedes, :sym_name => :label_follows, :order => 6, :sym => TYPE_FOLLOWS },
35 TYPE_PRECEDES => { :name => :label_precedes, :sym_name => :label_follows, :order => 6, :sym => TYPE_FOLLOWS },
36 TYPE_FOLLOWS => { :name => :label_follows, :sym_name => :label_precedes, :order => 7, :sym => TYPE_PRECEDES, :reverse => TYPE_PRECEDES }
36 TYPE_FOLLOWS => { :name => :label_follows, :sym_name => :label_precedes, :order => 7, :sym => TYPE_PRECEDES, :reverse => TYPE_PRECEDES }
37 }.freeze
37 }.freeze
38
38
39 validates_presence_of :issue_from, :issue_to, :relation_type
39 validates_presence_of :issue_from, :issue_to, :relation_type
40 validates_inclusion_of :relation_type, :in => TYPES.keys
40 validates_inclusion_of :relation_type, :in => TYPES.keys
41 validates_numericality_of :delay, :allow_nil => true
41 validates_numericality_of :delay, :allow_nil => true
42 validates_uniqueness_of :issue_to_id, :scope => :issue_from_id
42 validates_uniqueness_of :issue_to_id, :scope => :issue_from_id
43
43
44 validate :validate_issue_relation
45
44 attr_protected :issue_from_id, :issue_to_id
46 attr_protected :issue_from_id, :issue_to_id
45
47
46 def visible?(user=User.current)
48 def visible?(user=User.current)
47 (issue_from.nil? || issue_from.visible?(user)) && (issue_to.nil? || issue_to.visible?(user))
49 (issue_from.nil? || issue_from.visible?(user)) && (issue_to.nil? || issue_to.visible?(user))
48 end
50 end
49
51
50 def deletable?(user=User.current)
52 def deletable?(user=User.current)
51 visible?(user) &&
53 visible?(user) &&
52 ((issue_from.nil? || user.allowed_to?(:manage_issue_relations, issue_from.project)) ||
54 ((issue_from.nil? || user.allowed_to?(:manage_issue_relations, issue_from.project)) ||
53 (issue_to.nil? || user.allowed_to?(:manage_issue_relations, issue_to.project)))
55 (issue_to.nil? || user.allowed_to?(:manage_issue_relations, issue_to.project)))
54 end
56 end
55
57
56 def after_initialize
58 def after_initialize
57 if new_record?
59 if new_record?
58 if relation_type.blank?
60 if relation_type.blank?
59 self.relation_type = IssueRelation::TYPE_RELATES
61 self.relation_type = IssueRelation::TYPE_RELATES
60 end
62 end
61 end
63 end
62 end
64 end
63
65
64 def validate
66 def validate_issue_relation
65 if issue_from && issue_to
67 if issue_from && issue_to
66 errors.add :issue_to_id, :invalid if issue_from_id == issue_to_id
68 errors.add :issue_to_id, :invalid if issue_from_id == issue_to_id
67 errors.add :issue_to_id, :not_same_project unless issue_from.project_id == issue_to.project_id || Setting.cross_project_issue_relations?
69 errors.add :issue_to_id, :not_same_project unless issue_from.project_id == issue_to.project_id || Setting.cross_project_issue_relations?
68 #detect circular dependencies depending wether the relation should be reversed
70 #detect circular dependencies depending wether the relation should be reversed
69 if TYPES.has_key?(relation_type) && TYPES[relation_type][:reverse]
71 if TYPES.has_key?(relation_type) && TYPES[relation_type][:reverse]
70 errors.add_to_base :circular_dependency if issue_from.all_dependent_issues.include? issue_to
72 errors.add_to_base :circular_dependency if issue_from.all_dependent_issues.include? issue_to
71 else
73 else
72 errors.add_to_base :circular_dependency if issue_to.all_dependent_issues.include? issue_from
74 errors.add_to_base :circular_dependency if issue_to.all_dependent_issues.include? issue_from
73 end
75 end
74 errors.add_to_base :cant_link_an_issue_with_a_descendant if issue_from.is_descendant_of?(issue_to) || issue_from.is_ancestor_of?(issue_to)
76 errors.add_to_base :cant_link_an_issue_with_a_descendant if issue_from.is_descendant_of?(issue_to) || issue_from.is_ancestor_of?(issue_to)
75 end
77 end
76 end
78 end
77
79
78 def other_issue(issue)
80 def other_issue(issue)
79 (self.issue_from_id == issue.id) ? issue_to : issue_from
81 (self.issue_from_id == issue.id) ? issue_to : issue_from
80 end
82 end
81
83
82 # Returns the relation type for +issue+
84 # Returns the relation type for +issue+
83 def relation_type_for(issue)
85 def relation_type_for(issue)
84 if TYPES[relation_type]
86 if TYPES[relation_type]
85 if self.issue_from_id == issue.id
87 if self.issue_from_id == issue.id
86 relation_type
88 relation_type
87 else
89 else
88 TYPES[relation_type][:sym]
90 TYPES[relation_type][:sym]
89 end
91 end
90 end
92 end
91 end
93 end
92
94
93 def label_for(issue)
95 def label_for(issue)
94 TYPES[relation_type] ? TYPES[relation_type][(self.issue_from_id == issue.id) ? :name : :sym_name] : :unknow
96 TYPES[relation_type] ? TYPES[relation_type][(self.issue_from_id == issue.id) ? :name : :sym_name] : :unknow
95 end
97 end
96
98
97 def before_save
99 def before_save
98 reverse_if_needed
100 reverse_if_needed
99
101
100 if TYPE_PRECEDES == relation_type
102 if TYPE_PRECEDES == relation_type
101 self.delay ||= 0
103 self.delay ||= 0
102 else
104 else
103 self.delay = nil
105 self.delay = nil
104 end
106 end
105 set_issue_to_dates
107 set_issue_to_dates
106 end
108 end
107
109
108 def set_issue_to_dates
110 def set_issue_to_dates
109 soonest_start = self.successor_soonest_start
111 soonest_start = self.successor_soonest_start
110 if soonest_start && issue_to
112 if soonest_start && issue_to
111 issue_to.reschedule_after(soonest_start)
113 issue_to.reschedule_after(soonest_start)
112 end
114 end
113 end
115 end
114
116
115 def successor_soonest_start
117 def successor_soonest_start
116 if (TYPE_PRECEDES == self.relation_type) && delay && issue_from && (issue_from.start_date || issue_from.due_date)
118 if (TYPE_PRECEDES == self.relation_type) && delay && issue_from && (issue_from.start_date || issue_from.due_date)
117 (issue_from.due_date || issue_from.start_date) + 1 + delay
119 (issue_from.due_date || issue_from.start_date) + 1 + delay
118 end
120 end
119 end
121 end
120
122
121 def <=>(relation)
123 def <=>(relation)
122 TYPES[self.relation_type][:order] <=> TYPES[relation.relation_type][:order]
124 TYPES[self.relation_type][:order] <=> TYPES[relation.relation_type][:order]
123 end
125 end
124
126
125 private
127 private
126
128
127 # Reverses the relation if needed so that it gets stored in the proper way
129 # Reverses the relation if needed so that it gets stored in the proper way
128 # Should not be reversed before validation so that it can be displayed back
130 # Should not be reversed before validation so that it can be displayed back
129 # as entered on new relation form
131 # as entered on new relation form
130 def reverse_if_needed
132 def reverse_if_needed
131 if TYPES.has_key?(relation_type) && TYPES[relation_type][:reverse]
133 if TYPES.has_key?(relation_type) && TYPES[relation_type][:reverse]
132 issue_tmp = issue_to
134 issue_tmp = issue_to
133 self.issue_to = issue_from
135 self.issue_to = issue_from
134 self.issue_from = issue_tmp
136 self.issue_from = issue_tmp
135 self.relation_type = TYPES[relation_type][:reverse]
137 self.relation_type = TYPES[relation_type][:reverse]
136 end
138 end
137 end
139 end
138 end
140 end
General Comments 0
You need to be logged in to leave comments. Login now