jro_apps/redmine Commit - r11718:86cfa025edc8

Adds a test for User.try_to_login with active_only set to false....

Jean-Philippe Lang -

r11718:86cfa025edc8

parent child

Context file:

r11718:86cfa025edc8

Collapse all files

test/unit/user_test.rb +31 -26

                  assert_not_nil u.errors[:mail_notification]
                end
-               test "User#try_to_login should fall-back to case-insensitive if user login is not found as-typed" do
-                 user = User.try_to_login("AdMin", "admin")
-                 assert_kind_of User, user
-                 assert_equal "admin", user.login
-               end
-               test "User#try_to_login should select the exact matching user first" do
-                 case_sensitive_user = User.generate! do |user|
-                   user.password = "admin123"
-                 end
-                 # bypass validations to make it appear like existing data
-                 case_sensitive_user.update_attribute(:login, 'ADMIN')
-                 user = User.try_to_login("ADMIN", "admin123")
-                 assert_kind_of User, user
-                 assert_equal "ADMIN", user.login
-               end
                def test_password
                  user = User.try_to_login("admin", "admin")
                  assert_kind_of User, user
                  end
                end
-               def test_lock
-                 user = User.try_to_login("jsmith", "jsmith")
-                 assert_equal @jsmith, user
+               test ".try_to_login with good credentials should return the user" do
+                 user = User.try_to_login("admin", "admin")
+                 assert_kind_of User, user
+                 assert_equal "admin", user.login
+               end
+               test ".try_to_login with wrong credentials should return nil" do
+                 assert_nil User.try_to_login("admin", "foo")
+               end
+               def test_try_to_login_with_locked_user_should_return_nil
                  @jsmith.status = User::STATUS_LOCKED
-                 assert @jsmith.save
+                 @jsmith.save!
                  user = User.try_to_login("jsmith", "jsmith")
                  assert_equal nil, user
                end
-               test ".try_to_login with good credentials should return the user" do
-                 user = User.try_to_login("admin", "admin")
+               def test_try_to_login_with_locked_user_and_not_active_only_should_return_user
+                 @jsmith.status = User::STATUS_LOCKED
+                 @jsmith.save!
+                 user = User.try_to_login("jsmith", "jsmith", false)
+                 assert_equal @jsmith, user
+               end
+               test ".try_to_login should fall-back to case-insensitive if user login is not found as-typed" do
+                 user = User.try_to_login("AdMin", "admin")
                  assert_kind_of User, user
                  assert_equal "admin", user.login
                end
-               test ".try_to_login with wrong credentials should return nil" do
-                 assert_nil User.try_to_login("admin", "foo")
+               test ".try_to_login should select the exact matching user first" do
+                 case_sensitive_user = User.generate! do |user|
+                   user.password = "admin123"
+                 end
+                 # bypass validations to make it appear like existing data
+                 case_sensitive_user.update_attribute(:login, 'ADMIN')
+                 user = User.try_to_login("ADMIN", "admin123")
+                 assert_kind_of User, user
+                 assert_equal "ADMIN", user.login
                end
                if ldap_configured?

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages