jro_apps/redmine Commit - r13755:84c8ca6fefa3

Fixed that custom fields with hidden/read-only combination may be displayed on issue form (#19297)....

Jean-Philippe Lang -

r13755:84c8ca6fefa3

parent child

Context file:

r13755:84c8ca6fefa3

Collapse all files

app/models/issue.rb +17 -3

              # Redmine - project management software
              # Copyright (C) 2006-2015  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              class Issue < ActiveRecord::Base
                include Redmine::SafeAttributes
                include Redmine::Utils::DateCalculation
                include Redmine::I18n
                before_save :set_parent_id
                include Redmine::NestedSet::IssueNestedSet
                belongs_to :project
                belongs_to :tracker
                belongs_to :status, :class_name => 'IssueStatus'
                belongs_to :author, :class_name => 'User'
                belongs_to :assigned_to, :class_name => 'Principal'
                belongs_to :fixed_version, :class_name => 'Version'
                belongs_to :priority, :class_name => 'IssuePriority'
                belongs_to :category, :class_name => 'IssueCategory'
                has_many :journals, :as => :journalized, :dependent => :destroy, :inverse_of => :journalized
                has_many :visible_journals,
                  lambda {where(["(#{Journal.table_name}.private_notes = ? OR (#{Project.allowed_to_condition(User.current, :view_private_notes)}))", false])},
                  :class_name => 'Journal',
                  :as => :journalized
                has_many :time_entries, :dependent => :destroy
                has_and_belongs_to_many :changesets, lambda {order("#{Changeset.table_name}.committed_on ASC, #{Changeset.table_name}.id ASC")}
                has_many :relations_from, :class_name => 'IssueRelation', :foreign_key => 'issue_from_id', :dependent => :delete_all
                has_many :relations_to, :class_name => 'IssueRelation', :foreign_key => 'issue_to_id', :dependent => :delete_all
                acts_as_attachable :after_add => :attachment_added, :after_remove => :attachment_removed
                acts_as_customizable
                acts_as_watchable
                acts_as_searchable :columns => ['subject', "#{table_name}.description"],
                                   :preload => [:project, :status, :tracker],
                                   :scope => lambda {|options| options[:open_issues] ? self.open : self.all}
                acts_as_event :title => Proc.new {|o| "#{o.tracker.name} ##{o.id} (#{o.status}): #{o.subject}"},
                              :url => Proc.new {|o| {:controller => 'issues', :action => 'show', :id => o.id}},
                              :type => Proc.new {|o| 'issue' + (o.closed? ? ' closed' : '') }
                acts_as_activity_provider :scope => preload(:project, :author, :tracker),
                                          :author_key => :author_id
                DONE_RATIO_OPTIONS = %w(issue_field issue_status)
                attr_reader :current_journal
                delegate :notes, :notes=, :private_notes, :private_notes=, :to => :current_journal, :allow_nil => true
                validates_presence_of :subject, :project, :tracker
                validates_presence_of :priority, :if => Proc.new {|issue| issue.new_record? || issue.priority_id_changed?}
                validates_presence_of :status, :if => Proc.new {|issue| issue.new_record? || issue.status_id_changed?}
                validates_presence_of :author, :if => Proc.new {|issue| issue.new_record? || issue.author_id_changed?}
                validates_length_of :subject, :maximum => 255
                validates_inclusion_of :done_ratio, :in => 0..100
                validates :estimated_hours, :numericality => {:greater_than_or_equal_to => 0, :allow_nil => true, :message => :invalid}
                validates :start_date, :date => true
                validates :due_date, :date => true
                validate :validate_issue, :validate_required_fields
                attr_protected :id
                scope :visible, lambda {|*args|
                  joins(:project).
                  where(Issue.visible_condition(args.shift || User.current, *args))
                }
                scope :open, lambda {|*args|
                  is_closed = args.size > 0 ? !args.first : false
                  joins(:status).
                  where("#{IssueStatus.table_name}.is_closed = ?", is_closed)
                }
                scope :recently_updated, lambda { order("#{Issue.table_name}.updated_on DESC") }
                scope :on_active_project, lambda {
                  joins(:project).
                  where("#{Project.table_name}.status = ?", Project::STATUS_ACTIVE)
                }
                scope :fixed_version, lambda {|versions|
                  ids = [versions].flatten.compact.map {|v| v.is_a?(Version) ? v.id : v}
                  ids.any? ? where(:fixed_version_id => ids) : where('1=0')
                }
                before_create :default_assign
                before_save :close_duplicates, :update_done_ratio_from_issue_status,
                            :force_updated_on_change, :update_closed_on, :set_assigned_to_was
                after_save {|issue| issue.send :after_project_change if !issue.id_changed? && issue.project_id_changed?}
                after_save :reschedule_following_issues, :update_nested_set_attributes,
                           :update_parent_attributes, :create_journal
                # Should be after_create but would be called before previous after_save callbacks
                after_save :after_create_from_copy
                after_destroy :update_parent_attributes
                after_create :send_notification
                # Keep it at the end of after_save callbacks
                after_save :clear_assigned_to_was
                # Returns a SQL conditions string used to find all issues visible by the specified user
                def self.visible_condition(user, options={})
                  Project.allowed_to_condition(user, :view_issues, options) do |role, user|
                    if user.id && user.logged?
                      case role.issues_visibility
                      when 'all'
                        nil
                      when 'default'
                        user_ids = [user.id] + user.groups.map(&:id).compact
                        "(#{table_name}.is_private = #{connection.quoted_false} OR #{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                      when 'own'
                        user_ids = [user.id] + user.groups.map(&:id).compact
                        "(#{table_name}.author_id = #{user.id} OR #{table_name}.assigned_to_id IN (#{user_ids.join(',')}))"
                      else
                        '1=0'
                      end
                    else
                      "(#{table_name}.is_private = #{connection.quoted_false})"
                    end
                  end
                end
                # Returns true if usr or current user is allowed to view the issue
                def visible?(usr=nil)
                  (usr || User.current).allowed_to?(:view_issues, self.project) do |role, user|
                    if user.logged?
                      case role.issues_visibility
                      when 'all'
                        true
                      when 'default'
                        !self.is_private? || (self.author == user || user.is_or_belongs_to?(assigned_to))
                      when 'own'
                        self.author == user || user.is_or_belongs_to?(assigned_to)
                      else
                        false
                      end
                    else
                      !self.is_private?
                    end
                  end
                end
                # Returns true if user or current user is allowed to edit or add a note to the issue
                def editable?(user=User.current)
                  attributes_editable?(user) || user.allowed_to?(:add_issue_notes, project)
                end
                # Returns true if user or current user is allowed to edit the issue
                def attributes_editable?(user=User.current)
                  user.allowed_to?(:edit_issues, project)
                end
                def initialize(attributes=nil, *args)
                  super
                  if new_record?
                    # set default values for new records only
                    self.priority ||= IssuePriority.default
                    self.watcher_user_ids = []
                  end
                end
                def create_or_update
                  super
                ensure
                  @status_was = nil
                end
                private :create_or_update
                # AR#Persistence#destroy would raise and RecordNotFound exception
                # if the issue was already deleted or updated (non matching lock_version).
                # This is a problem when bulk deleting issues or deleting a project
                # (because an issue may already be deleted if its parent was deleted
                # first).
                # The issue is reloaded by the nested_set before being deleted so
                # the lock_version condition should not be an issue but we handle it.
                def destroy
                  super
                rescue ActiveRecord::StaleObjectError, ActiveRecord::RecordNotFound
                  # Stale or already deleted
                  begin
                    reload
                  rescue ActiveRecord::RecordNotFound
                    # The issue was actually already deleted
                    @destroyed = true
                    return freeze
                  end
                  # The issue was stale, retry to destroy
                  super
                end
                alias :base_reload :reload
                def reload(*args)
                  @workflow_rule_by_attribute = nil
                  @assignable_versions = nil
                  @relations = nil
                  @spent_hours = nil
                  base_reload(*args)
                end
                # Overrides Redmine::Acts::Customizable::InstanceMethods#available_custom_fields
                def available_custom_fields
                  (project && tracker) ? (project.all_issue_custom_fields & tracker.custom_fields) : []
                end
                def visible_custom_field_values(user=nil)
                  user_real = user || User.current
                  custom_field_values.select do |value|
                    value.custom_field.visible_by?(project, user_real)
                  end
                end
                # Copies attributes from another issue, arg can be an id or an Issue
                def copy_from(arg, options={})
                  issue = arg.is_a?(Issue) ? arg : Issue.visible.find(arg)
                  self.attributes = issue.attributes.dup.except("id", "root_id", "parent_id", "lft", "rgt", "created_on", "updated_on")
                  self.custom_field_values = issue.custom_field_values.inject({}) {|h,v| h[v.custom_field_id] = v.value; h}
                  self.status = issue.status
                  self.author = User.current
                  unless options[:attachments] == false
                    self.attachments = issue.attachments.map do |attachement|
                      attachement.copy(:container => self)
                    end
                  end
                  @copied_from = issue
                  @copy_options = options
                  self
                end
                # Returns an unsaved copy of the issue
                def copy(attributes=nil, copy_options={})
                  copy = self.class.new.copy_from(self, copy_options)
                  copy.attributes = attributes if attributes
                  copy
                end
                # Returns true if the issue is a copy
                def copy?
                  @copied_from.present?
                end
                def status_id=(status_id)
                  if status_id.to_s != self.status_id.to_s
                    self.status = (status_id.present? ? IssueStatus.find_by_id(status_id) : nil)
                  end
                  self.status_id
                end
                # Sets the status.
                def status=(status)
                  if status != self.status
                    @workflow_rule_by_attribute = nil
                  end
                  association(:status).writer(status)
                end
                def priority_id=(pid)
                  self.priority = nil
                  write_attribute(:priority_id, pid)
                end
                def category_id=(cid)
                  self.category = nil
                  write_attribute(:category_id, cid)
                end
                def fixed_version_id=(vid)
                  self.fixed_version = nil
                  write_attribute(:fixed_version_id, vid)
                end
                def tracker_id=(tracker_id)
                  if tracker_id.to_s != self.tracker_id.to_s
                    self.tracker = (tracker_id.present? ? Tracker.find_by_id(tracker_id) : nil)
                  end
                  self.tracker_id
                end
                # Sets the tracker.
                # This will set the status to the default status of the new tracker if:
                # * the status was the default for the previous tracker
                # * or if the status was not part of the new tracker statuses
                # * or the status was nil
                def tracker=(tracker)
                  if tracker != self.tracker
                    if status == default_status
                      self.status = nil
                    elsif status && tracker && !tracker.issue_status_ids.include?(status.id)
                      self.status = nil
                    end
                    @custom_field_values = nil
                    @workflow_rule_by_attribute = nil
                  end
                  association(:tracker).writer(tracker)
                  self.status ||= default_status
                  self.tracker
                end
                def project_id=(project_id)
                  if project_id.to_s != self.project_id.to_s
                    self.project = (project_id.present? ? Project.find_by_id(project_id) : nil)
                  end
                  self.project_id
                end
                # Sets the project.
                # Unless keep_tracker argument is set to true, this will change the tracker
                # to the first tracker of the new project if the previous tracker is not part
                # of the new project trackers.
                # This will clear the fixed_version is it's no longer valid for the new project.
                # This will clear the parent issue if it's no longer valid for the new project.
                # This will set the category to the category with the same name in the new
                # project if it exists, or clear it if it doesn't.
                def project=(project, keep_tracker=false)
                  project_was = self.project
                  association(:project).writer(project)
                  if project_was && project && project_was != project
                    @assignable_versions = nil
                    unless keep_tracker || project.trackers.include?(tracker)
                      self.tracker = project.trackers.first
                    end
                    # Reassign to the category with same name if any
                    if category
                      self.category = project.issue_categories.find_by_name(category.name)
                    end
                    # Keep the fixed_version if it's still valid in the new_project
                    if fixed_version && fixed_version.project != project && !project.shared_versions.include?(fixed_version)
                      self.fixed_version = nil
                    end
                    # Clear the parent task if it's no longer valid
                    unless valid_parent_project?
                      self.parent_issue_id = nil
                    end
                    @custom_field_values = nil
                    @workflow_rule_by_attribute = nil
                  end
                  self.project
                end
                def description=(arg)
                  if arg.is_a?(String)
                    arg = arg.gsub(/(\r\n|\n|\r)/, "\r\n")
                  end
                  write_attribute(:description, arg)
                end
                # Overrides assign_attributes so that project and tracker get assigned first
                def assign_attributes_with_project_and_tracker_first(new_attributes, *args)
                  return if new_attributes.nil?
                  attrs = new_attributes.dup
                  attrs.stringify_keys!
                  %w(project project_id tracker tracker_id).each do |attr|
                    if attrs.has_key?(attr)
                      send "#{attr}=", attrs.delete(attr)
                    end
                  end
                  send :assign_attributes_without_project_and_tracker_first, attrs, *args
                end
                # Do not redefine alias chain on reload (see #4838)
                alias_method_chain(:assign_attributes, :project_and_tracker_first) unless method_defined?(:assign_attributes_without_project_and_tracker_first)
                def attributes=(new_attributes)
                  assign_attributes new_attributes
                end
                def estimated_hours=(h)
                  write_attribute :estimated_hours, (h.is_a?(String) ? h.to_hours : h)
                end
                safe_attributes 'project_id',
                  'tracker_id',
                  'status_id',
                  'category_id',
                  'assigned_to_id',
                  'priority_id',
                  'fixed_version_id',
                  'subject',
                  'description',
                  'start_date',
                  'due_date',
                  'done_ratio',
                  'estimated_hours',
                  'custom_field_values',
                  'custom_fields',
                  'lock_version',
                  'notes',
                  :if => lambda {|issue, user| issue.new_record? || user.allowed_to?(:edit_issues, issue.project) }
                safe_attributes 'notes',
                  :if => lambda {|issue, user| user.allowed_to?(:add_issue_notes, issue.project)}
                safe_attributes 'private_notes',
                  :if => lambda {|issue, user| !issue.new_record? && user.allowed_to?(:set_notes_private, issue.project)}
                safe_attributes 'watcher_user_ids',
                  :if => lambda {|issue, user| issue.new_record? && user.allowed_to?(:add_issue_watchers, issue.project)}
                safe_attributes 'is_private',
                  :if => lambda {|issue, user|
                    user.allowed_to?(:set_issues_private, issue.project) ||
                      (issue.author_id == user.id && user.allowed_to?(:set_own_issues_private, issue.project))
                  }
                safe_attributes 'parent_issue_id',
                  :if => lambda {|issue, user| (issue.new_record? || user.allowed_to?(:edit_issues, issue.project)) &&
                    user.allowed_to?(:manage_subtasks, issue.project)}
                def safe_attribute_names(user=nil)
                  names = super
                  names -= disabled_core_fields
                  names -= read_only_attribute_names(user)
                  if new_record?
                   	# Make sure that project_id can always be set for new issues
                    names |= %w(project_id)
                  end
                  names
                end
                # Safely sets attributes
                # Should be called from controllers instead of #attributes=
                # attr_accessible is too rough because we still want things like
                # Issue.new(:project => foo) to work
                def safe_attributes=(attrs, user=User.current)
                  return unless attrs.is_a?(Hash)
                  attrs = attrs.deep_dup
                  # Project and Tracker must be set before since new_statuses_allowed_to depends on it.
                  if (p = attrs.delete('project_id')) && safe_attribute?('project_id')
                    if allowed_target_projects(user).where(:id => p.to_i).exists?
                      self.project_id = p
                    end
                  end
                  if (t = attrs.delete('tracker_id')) && safe_attribute?('tracker_id')
                    self.tracker_id = t
                  end
                  if project
                    # Set the default tracker to accept custom field values
                    # even if tracker is not specified
                    self.tracker ||= project.trackers.first
                  end
                  if (s = attrs.delete('status_id')) && safe_attribute?('status_id')
                    if new_statuses_allowed_to(user).collect(&:id).include?(s.to_i)
                      self.status_id = s
                    end
                  end
                  attrs = delete_unsafe_attributes(attrs, user)
                  return if attrs.empty?
                  unless leaf?
                    attrs.reject! {|k,v| %w(priority_id done_ratio start_date due_date estimated_hours).include?(k)}
                  end
                  if attrs['parent_issue_id'].present?
                    s = attrs['parent_issue_id'].to_s
                    unless (m = s.match(%r{\A#?(\d+)\z})) && (m[1] == parent_id.to_s || Issue.visible(user).exists?(m[1]))
                      @invalid_parent_issue_id = attrs.delete('parent_issue_id')
                    end
                  end
                  if attrs['custom_field_values'].present?
                    editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
                    attrs['custom_field_values'].select! {|k, v| editable_custom_field_ids.include?(k.to_s)}
                  end
                  if attrs['custom_fields'].present?
                    editable_custom_field_ids = editable_custom_field_values(user).map {|v| v.custom_field_id.to_s}
                    attrs['custom_fields'].select! {|c| editable_custom_field_ids.include?(c['id'].to_s)}
                  end
                  # mass-assignment security bypass
                  assign_attributes attrs, :without_protection => true
                end
                def disabled_core_fields
                  tracker ? tracker.disabled_core_fields : []
                end
                # Returns the custom_field_values that can be edited by the given user
                def editable_custom_field_values(user=nil)
                  visible_custom_field_values(user).reject do |value|
                    read_only_attribute_names(user).include?(value.custom_field_id.to_s)
                  end
                end
                # Returns the custom fields that can be edited by the given user
                def editable_custom_fields(user=nil)
                  editable_custom_field_values(user).map(&:custom_field).uniq
                end
                # Returns the names of attributes that are read-only for user or the current user
                # For users with multiple roles, the read-only fields are the intersection of
                # read-only fields of each role
                # The result is an array of strings where sustom fields are represented with their ids
                #
                # Examples:
                #   issue.read_only_attribute_names # => ['due_date', '2']
                #   issue.read_only_attribute_names(user) # => []
                def read_only_attribute_names(user=nil)
                  workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'readonly'}.keys
                end
                # Returns the names of required attributes for user or the current user
                # For users with multiple roles, the required fields are the intersection of
                # required fields of each role
                # The result is an array of strings where sustom fields are represented with their ids
                #
                # Examples:
                #   issue.required_attribute_names # => ['due_date', '2']
                #   issue.required_attribute_names(user) # => []
                def required_attribute_names(user=nil)
                  workflow_rule_by_attribute(user).reject {|attr, rule| rule != 'required'}.keys
                end
                # Returns true if the attribute is required for user
                def required_attribute?(name, user=nil)
                  required_attribute_names(user).include?(name.to_s)
                end
                # Returns a hash of the workflow rule by attribute for the given user
                #
                # Examples:
                #   issue.workflow_rule_by_attribute # => {'due_date' => 'required', 'start_date' => 'readonly'}
                def workflow_rule_by_attribute(user=nil)
                  return @workflow_rule_by_attribute if @workflow_rule_by_attribute && user.nil?
                  user_real = user || User.current
                  roles = user_real.admin ? Role.all.to_a : user_real.roles_for_project(project)
                  roles = roles.select(&:consider_workflow?)
                  return {} if roles.empty?
                  result = {}
                  workflow_permissions = WorkflowPermission.where(:tracker_id => tracker_id, :old_status_id => status_id, :role_id => roles.map(&:id)).to_a
                  if workflow_permissions.any?
                    workflow_rules = workflow_permissions.inject({}) do |h, wp|
-                     h[wp.field_name] ||= []
-                     h[wp.field_name] << wp.rule
+                     h[wp.field_name] ||= {}
+                     h[wp.field_name][wp.role_id] = wp.rule
                      h
                    end
+                   fields_with_roles = {}
+                   IssueCustomField.where(:visible => false).joins(:roles).pluck(:id, "role_id").each do |field_id, role_id|
+                     fields_with_roles[field_id] ||= []
+                     fields_with_roles[field_id] << role_id
+                   end
+                   roles.each do |role|
+                     fields_with_roles.each do |field_id, role_ids|
+                       unless role_ids.include?(role.id)
+                         field_name = field_id.to_s
+                         workflow_rules[field_name] ||= {}
+                         workflow_rules[field_name][role.id] = 'readonly'
+                       end
+                     end
+                   end
                    workflow_rules.each do |attr, rules|
                      next if rules.size < roles.size
-                     uniq_rules = rules.uniq
+                     uniq_rules = rules.values.uniq
                      if uniq_rules.size == 1
                        result[attr] = uniq_rules.first
                      else
                        result[attr] = 'required'
                      end
                    end
                  end
                  @workflow_rule_by_attribute = result if user.nil?
                  result
                end
                private :workflow_rule_by_attribute
                def done_ratio
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    status.default_done_ratio
                  else
                    read_attribute(:done_ratio)
                  end
                end
                def self.use_status_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_status'
                end
                def self.use_field_for_done_ratio?
                  Setting.issue_done_ratio == 'issue_field'
                end
                def validate_issue
                  if due_date && start_date && (start_date_changed? || due_date_changed?) && due_date < start_date
                    errors.add :due_date, :greater_than_start_date
                  end
                  if start_date && start_date_changed? && soonest_start && start_date < soonest_start
                    errors.add :start_date, :earlier_than_minimum_start_date, :date => format_date(soonest_start)
                  end
                  if fixed_version
                    if !assignable_versions.include?(fixed_version)
                      errors.add :fixed_version_id, :inclusion
                    elsif reopening? && fixed_version.closed?
                      errors.add :base, I18n.t(:error_can_not_reopen_issue_on_closed_version)
                    end
                  end
                  # Checks that the issue can not be added/moved to a disabled tracker
                  if project && (tracker_id_changed? || project_id_changed?)
                    unless project.trackers.include?(tracker)
                      errors.add :tracker_id, :inclusion
                    end
                  end
                  # Checks parent issue assignment
                  if @invalid_parent_issue_id.present?
                    errors.add :parent_issue_id, :invalid
                  elsif @parent_issue
                    if !valid_parent_project?(@parent_issue)
                      errors.add :parent_issue_id, :invalid
                    elsif (@parent_issue != parent) && (all_dependent_issues.include?(@parent_issue) || @parent_issue.all_dependent_issues.include?(self))
                      errors.add :parent_issue_id, :invalid
                    elsif !new_record?
                      # moving an existing issue
                      if move_possible?(@parent_issue)
                        # move accepted
                      else
                        errors.add :parent_issue_id, :invalid
                      end
                    end
                  end
                end
                # Validates the issue against additional workflow requirements
                def validate_required_fields
                  user = new_record? ? author : current_journal.try(:user)
                  required_attribute_names(user).each do |attribute|
                    if attribute =~ /^\d+$/
                      attribute = attribute.to_i
                      v = custom_field_values.detect {|v| v.custom_field_id == attribute }
                      if v && v.value.blank?
                        errors.add :base, v.custom_field.name + ' ' + l('activerecord.errors.messages.blank')
                      end
                    else
                      if respond_to?(attribute) && send(attribute).blank? && !disabled_core_fields.include?(attribute)
                        errors.add attribute, :blank
                      end
                    end
                  end
                end
                # Overrides Redmine::Acts::Customizable::InstanceMethods#validate_custom_field_values
                # so that custom values that are not editable are not validated (eg. a custom field that
                # is marked as required should not trigger a validation error if the user is not allowed
                # to edit this field).
                def validate_custom_field_values
                  user = new_record? ? author : current_journal.try(:user)
                  if new_record? || custom_field_values_changed?
                    editable_custom_field_values(user).each(&:validate_value)
                  end
                end
                # Set the done_ratio using the status if that setting is set.  This will keep the done_ratios
                # even if the user turns off the setting later
                def update_done_ratio_from_issue_status
                  if Issue.use_status_for_done_ratio? && status && status.default_done_ratio
                    self.done_ratio = status.default_done_ratio
                  end
                end
                def init_journal(user, notes = "")
                  @current_journal ||= Journal.new(:journalized => self, :user => user, :notes => notes)
                end
                # Returns the current journal or nil if it's not initialized
                def current_journal
                  @current_journal
                end
                # Returns the names of attributes that are journalized when updating the issue
                def journalized_attribute_names
                  Issue.column_names - %w(id root_id lft rgt lock_version created_on updated_on closed_on)
                end
                # Returns the id of the last journal or nil
                def last_journal_id
                  if new_record?
                    nil
                  else
                    journals.maximum(:id)
                  end
                end
                # Returns a scope for journals that have an id greater than journal_id
                def journals_after(journal_id)
                  scope = journals.reorder("#{Journal.table_name}.id ASC")
                  if journal_id.present?
                    scope = scope.where("#{Journal.table_name}.id > ?", journal_id.to_i)
                  end
                  scope
                end
                # Returns the initial status of the issue
                # Returns nil for a new issue
                def status_was
                  if status_id_changed?
                    if status_id_was.to_i > 0
                      @status_was ||= IssueStatus.find_by_id(status_id_was)
                    end
                  else
                    @status_was ||= status
                  end
                end
                # Return true if the issue is closed, otherwise false
                def closed?
                  status.present? && status.is_closed?
                end
                # Returns true if the issue was closed when loaded
                def was_closed?
                  status_was.present? && status_was.is_closed?
                end
                # Return true if the issue is being reopened
                def reopening?
                  if new_record?
                    false
                  else
                    status_id_changed? && !closed? && was_closed?
                  end
                end
                alias :reopened? :reopening?
                # Return true if the issue is being closed
                def closing?
                  if new_record?
                    closed?
                  else
                    status_id_changed? && closed? && !was_closed?
                  end
                end
                # Returns true if the issue is overdue
                def overdue?
                  due_date.present? && (due_date < Date.today) && !closed?
                end
                # Is the amount of work done less than it should for the due date
                def behind_schedule?
                  return false if start_date.nil? || due_date.nil?
                  done_date = start_date + ((due_date - start_date + 1) * done_ratio / 100).floor
                  return done_date <= Date.today
                end
                # Does this issue have children?
                def children?
                  !leaf?
                end
                # Users the issue can be assigned to
                def assignable_users
                  users = project.assignable_users.to_a
                  users << author if author
                  users << assigned_to if assigned_to
                  users.uniq.sort
                end
                # Versions that the issue can be assigned to
                def assignable_versions
                  return @assignable_versions if @assignable_versions
                  versions = project.shared_versions.open.to_a
                  if fixed_version
                    if fixed_version_id_changed?
                      # nothing to do
                    elsif project_id_changed?
                      if project.shared_versions.include?(fixed_version)
                        versions << fixed_version
                      end
                    else
                      versions << fixed_version
                    end
                  end
                  @assignable_versions = versions.uniq.sort
                end
                # Returns true if this issue is blocked by another issue that is still open
                def blocked?
                  !relations_to.detect {|ir| ir.relation_type == 'blocks' && !ir.issue_from.closed?}.nil?
                end
                # Returns the default status of the issue based on its tracker
                # Returns nil if tracker is nil
                def default_status
                  tracker.try(:default_status)
                end
                # Returns an array of statuses that user is able to apply
                def new_statuses_allowed_to(user=User.current, include_default=false)
                  if new_record? && @copied_from
                    [default_status, @copied_from.status].compact.uniq.sort
                  else
                    initial_status = nil
                    if new_record?
                      initial_status = default_status
                    elsif tracker_id_changed?
                      if Tracker.where(:id => tracker_id_was, :default_status_id => status_id_was).any?
                        initial_status = default_status
                      elsif tracker.issue_status_ids.include?(status_id_was)
                        initial_status = IssueStatus.find_by_id(status_id_was)
                      else
                        initial_status = default_status
                      end
                    else
                      initial_status = status_was
                    end
                    initial_assigned_to_id = assigned_to_id_changed? ? assigned_to_id_was : assigned_to_id
                    assignee_transitions_allowed = initial_assigned_to_id.present? &&
                      (user.id == initial_assigned_to_id || user.group_ids.include?(initial_assigned_to_id))
                    statuses = []
                    if initial_status
                      statuses += initial_status.find_new_statuses_allowed_to(
                        user.admin ? Role.all.to_a : user.roles_for_project(project),
                        tracker,
                        author == user,
                        assignee_transitions_allowed
                        )
                    end
                    statuses << initial_status unless statuses.empty?
                    statuses << default_status if include_default
                    statuses = statuses.compact.uniq.sort
                    if blocked?
                      statuses.reject!(&:is_closed?)
                    end
                    statuses
                  end
                end
                # Returns the previous assignee (user or group) if changed
                def assigned_to_was
                  # assigned_to_id_was is reset before after_save callbacks
                  user_id = @previous_assigned_to_id || assigned_to_id_was
                  if user_id && user_id != assigned_to_id
                    @assigned_to_was ||= Principal.find_by_id(user_id)
                  end
                end
                # Returns the users that should be notified
                def notified_users
                  notified = []
                  # Author and assignee are always notified unless they have been
                  # locked or don't want to be notified
                  notified << author if author
                  if assigned_to
                    notified += (assigned_to.is_a?(Group) ? assigned_to.users : [assigned_to])
                  end
                  if assigned_to_was
                    notified += (assigned_to_was.is_a?(Group) ? assigned_to_was.users : [assigned_to_was])
                  end
                  notified = notified.select {|u| u.active? && u.notify_about?(self)}
                  notified += project.notified_users
                  notified.uniq!
                  # Remove users that can not view the issue
                  notified.reject! {|user| !visible?(user)}
                  notified
                end
                # Returns the email addresses that should be notified
                def recipients
                  notified_users.collect(&:mail)
                end
                def each_notification(users, &block)
                  if users.any?
                    if custom_field_values.detect {|value| !value.custom_field.visible?}
                      users_by_custom_field_visibility = users.group_by do |user|
                        visible_custom_field_values(user).map(&:custom_field_id).sort
                      end
                      users_by_custom_field_visibility.values.each do |users|
                        yield(users)
                      end
                    else
                      yield(users)
                    end
                  end
                end
                # Returns the number of hours spent on this issue
                def spent_hours
                  @spent_hours ||= time_entries.sum(:hours) || 0
                end
                # Returns the total number of hours spent on this issue and its descendants
                #
                # Example:
                #   spent_hours => 0.0
                #   spent_hours => 50.2
                def total_spent_hours
                  @total_spent_hours ||=
                    self_and_descendants.
                      joins("LEFT JOIN #{TimeEntry.table_name} ON #{TimeEntry.table_name}.issue_id = #{Issue.table_name}.id").
                      sum("#{TimeEntry.table_name}.hours").to_f || 0.0
                end
                def relations
                  @relations ||= IssueRelation::Relations.new(self, (relations_from + relations_to).sort)
                end
                # Preloads relations for a collection of issues
                def self.load_relations(issues)
                  if issues.any?
                    relations = IssueRelation.where("issue_from_id IN (:ids) OR issue_to_id IN (:ids)", :ids => issues.map(&:id)).all
                    issues.each do |issue|
                      issue.instance_variable_set "@relations", relations.select {|r| r.issue_from_id == issue.id || r.issue_to_id == issue.id}
                    end
                  end
                end
                # Preloads visible spent time for a collection of issues
                def self.load_visible_spent_hours(issues, user=User.current)
                  if issues.any?
                    hours_by_issue_id = TimeEntry.visible(user).group(:issue_id).sum(:hours)
                    issues.each do |issue|
                      issue.instance_variable_set "@spent_hours", (hours_by_issue_id[issue.id] || 0)
                    end
                  end
                end
                # Preloads visible relations for a collection of issues
                def self.load_visible_relations(issues, user=User.current)
                  if issues.any?
                    issue_ids = issues.map(&:id)
                    # Relations with issue_from in given issues and visible issue_to
                    relations_from = IssueRelation.joins(:issue_to => :project).
                                       where(visible_condition(user)).where(:issue_from_id => issue_ids).to_a
                    # Relations with issue_to in given issues and visible issue_from
                    relations_to = IssueRelation.joins(:issue_from => :project).
                                       where(visible_condition(user)).
                                       where(:issue_to_id => issue_ids).to_a
                    issues.each do |issue|
                      relations =
                        relations_from.select {|relation| relation.issue_from_id == issue.id} +
                        relations_to.select {|relation| relation.issue_to_id == issue.id}
                      issue.instance_variable_set "@relations", IssueRelation::Relations.new(issue, relations.sort)
                    end
                  end
                end
                # Finds an issue relation given its id.
                def find_relation(relation_id)
                  IssueRelation.where("issue_to_id = ? OR issue_from_id = ?", id, id).find(relation_id)
                end
                # Returns all the other issues that depend on the issue
                # The algorithm is a modified breadth first search (bfs)
                def all_dependent_issues(except=[])
                  # The found dependencies
                  dependencies = []
                  # The visited flag for every node (issue) used by the breadth first search
                  eNOT_DISCOVERED         = 0       # The issue is "new" to the algorithm, it has not seen it before.
                  ePROCESS_ALL            = 1       # The issue is added to the queue. Process both children and relations of
                                                    # the issue when it is processed.
                  ePROCESS_RELATIONS_ONLY = 2       # The issue was added to the queue and will be output as dependent issue,
                                                    # but its children will not be added to the queue when it is processed.
                  eRELATIONS_PROCESSED    = 3       # The related issues, the parent issue and the issue itself have been added to
                                                    # the queue, but its children have not been added.
                  ePROCESS_CHILDREN_ONLY  = 4       # The relations and the parent of the issue have been added to the queue, but
                                                    # the children still need to be processed.
                  eALL_PROCESSED          = 5       # The issue and all its children, its parent and its related issues have been
                                                    # added as dependent issues. It needs no further processing.
                  issue_status = Hash.new(eNOT_DISCOVERED)
                  # The queue
                  queue = []
                  # Initialize the bfs, add start node (self) to the queue
                  queue << self
                  issue_status[self] = ePROCESS_ALL
                  while (!queue.empty?) do
                    current_issue = queue.shift
                    current_issue_status = issue_status[current_issue]
                    dependencies << current_issue
                    # Add parent to queue, if not already in it.
                    parent = current_issue.parent
                    parent_status = issue_status[parent]
                    if parent && (parent_status == eNOT_DISCOVERED) && !except.include?(parent)
                      queue << parent
                      issue_status[parent] = ePROCESS_RELATIONS_ONLY
                    end
                    # Add children to queue, but only if they are not already in it and
                    # the children of the current node need to be processed.
                    if (current_issue_status == ePROCESS_CHILDREN_ONLY || current_issue_status == ePROCESS_ALL)
                      current_issue.children.each do |child|
                        next if except.include?(child)
                        if (issue_status[child] == eNOT_DISCOVERED)
                          queue << child
                          issue_status[child] = ePROCESS_ALL
                        elsif (issue_status[child] == eRELATIONS_PROCESSED)
                          queue << child
                          issue_status[child] = ePROCESS_CHILDREN_ONLY
                        elsif (issue_status[child] == ePROCESS_RELATIONS_ONLY)
                          queue << child
                          issue_status[child] = ePROCESS_ALL
                        end
                      end
                    end
                    # Add related issues to the queue, if they are not already in it.
                    current_issue.relations_from.map(&:issue_to).each do |related_issue|
                      next if except.include?(related_issue)
                      if (issue_status[related_issue] == eNOT_DISCOVERED)
                        queue << related_issue
                        issue_status[related_issue] = ePROCESS_ALL
                      elsif (issue_status[related_issue] == eRELATIONS_PROCESSED)
                        queue << related_issue
                        issue_status[related_issue] = ePROCESS_CHILDREN_ONLY
                      elsif (issue_status[related_issue] == ePROCESS_RELATIONS_ONLY)
                        queue << related_issue
                        issue_status[related_issue] = ePROCESS_ALL
                      end
                    end
                    # Set new status for current issue
                    if (current_issue_status == ePROCESS_ALL) || (current_issue_status == ePROCESS_CHILDREN_ONLY)
                      issue_status[current_issue] = eALL_PROCESSED
                    elsif (current_issue_status == ePROCESS_RELATIONS_ONLY)
                      issue_status[current_issue] = eRELATIONS_PROCESSED
                    end
                  end # while
                  # Remove the issues from the "except" parameter from the result array
                  dependencies -= except
                  dependencies.delete(self)
                  dependencies
                end
                # Returns an array of issues that duplicate this one
                def duplicates
                  relations_to.select {|r| r.relation_type == IssueRelation::TYPE_DUPLICATES}.collect {|r| r.issue_from}
                end
                # Returns the due date or the target due date if any
                # Used on gantt chart
                def due_before
                  due_date || (fixed_version ? fixed_version.effective_date : nil)
                end
                # Returns the time scheduled for this issue.
                #
                # Example:
                #   Start Date: 2/26/09, End Date: 3/04/09
                #   duration => 6
                def duration
                  (start_date && due_date) ? due_date - start_date : 0
                end
                # Returns the duration in working days
                def working_duration
                  (start_date && due_date) ? working_days(start_date, due_date) : 0
                end
                def soonest_start(reload=false)
                  @soonest_start = nil if reload
                  @soonest_start ||= (
                      relations_to(reload).collect{|relation| relation.successor_soonest_start} +
                      [(@parent_issue || parent).try(:soonest_start)]
                    ).compact.max
                end
                # Sets start_date on the given date or the next working day
                # and changes due_date to keep the same working duration.
                def reschedule_on(date)
                  wd = working_duration
                  date = next_working_date(date)
                  self.start_date = date
                  self.due_date = add_working_days(date, wd)
                end
                # Reschedules the issue on the given date or the next working day and saves the record.
                # If the issue is a parent task, this is done by rescheduling its subtasks.
                def reschedule_on!(date)
                  return if date.nil?
                  if leaf?
                    if start_date.nil? || start_date != date
                      if start_date && start_date > date
                        # Issue can not be moved earlier than its soonest start date
                        date = [soonest_start(true), date].compact.max
                      end
                      reschedule_on(date)
                      begin
                        save
                      rescue ActiveRecord::StaleObjectError
                        reload
                        reschedule_on(date)
                        save
                      end
                    end
                  else
                    leaves.each do |leaf|
                      if leaf.start_date
                        # Only move subtask if it starts at the same date as the parent
                        # or if it starts before the given date
                        if start_date == leaf.start_date || date > leaf.start_date
                          leaf.reschedule_on!(date)
                        end
                      else
                        leaf.reschedule_on!(date)
                      end
                    end
                  end
                end
                def <=>(issue)
                  if issue.nil?
                    -1
                  elsif root_id != issue.root_id
                    (root_id || 0) <=> (issue.root_id || 0)
                  else
                    (lft || 0) <=> (issue.lft || 0)
                  end
                end
                def to_s
                  "#{tracker} ##{id}: #{subject}"
                end
                # Returns a string of css classes that apply to the issue
                def css_classes(user=User.current)
                  s = "issue tracker-#{tracker_id} status-#{status_id} #{priority.try(:css_classes)}"
                  s << ' closed' if closed?
                  s << ' overdue' if overdue?
                  s << ' child' if child?
                  s << ' parent' unless leaf?
                  s << ' private' if is_private?
                  if user.logged?
                    s << ' created-by-me' if author_id == user.id
                    s << ' assigned-to-me' if assigned_to_id == user.id
                    s << ' assigned-to-my-group' if user.groups.any? {|g| g.id == assigned_to_id}
                  end
                  s
                end
                # Unassigns issues from +version+ if it's no longer shared with issue's project
                def self.update_versions_from_sharing_change(version)
                  # Update issues assigned to the version
                  update_versions(["#{Issue.table_name}.fixed_version_id = ?", version.id])
                end
                # Unassigns issues from versions that are no longer shared
                # after +project+ was moved
                def self.update_versions_from_hierarchy_change(project)
                  moved_project_ids = project.self_and_descendants.reload.collect(&:id)
                  # Update issues of the moved projects and issues assigned to a version of a moved project
                  Issue.update_versions(
                          ["#{Version.table_name}.project_id IN (?) OR #{Issue.table_name}.project_id IN (?)",
                           moved_project_ids, moved_project_ids]
                        )
                end
                def parent_issue_id=(arg)
                  s = arg.to_s.strip.presence
                  if s && (m = s.match(%r{\A#?(\d+)\z})) && (@parent_issue = Issue.find_by_id(m[1]))
                    @invalid_parent_issue_id = nil
                  elsif s.blank?
                    @parent_issue = nil
                    @invalid_parent_issue_id = nil
                  else
                    @parent_issue = nil
                    @invalid_parent_issue_id = arg
                  end
                end
                def parent_issue_id
                  if @invalid_parent_issue_id
                    @invalid_parent_issue_id
                  elsif instance_variable_defined? :@parent_issue
                    @parent_issue.nil? ? nil : @parent_issue.id
                  else
                    parent_id
                  end
                end
                def set_parent_id
                  self.parent_id = parent_issue_id
                end
                # Returns true if issue's project is a valid
                # parent issue project
                def valid_parent_project?(issue=parent)
                  return true if issue.nil? || issue.project_id == project_id
                  case Setting.cross_project_subtasks
                  when 'system'
                    true
                  when 'tree'
                    issue.project.root == project.root
                  when 'hierarchy'
                    issue.project.is_or_is_ancestor_of?(project) || issue.project.is_descendant_of?(project)
                  when 'descendants'
                    issue.project.is_or_is_ancestor_of?(project)
                  else
                    false
                  end
                end
                # Returns an issue scope based on project and scope
                def self.cross_project_scope(project, scope=nil)
                  if project.nil?
                    return Issue
                  end
                  case scope
                  when 'all', 'system'
                    Issue
                  when 'tree'
                    Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
                                                :lft => project.root.lft, :rgt => project.root.rgt)
                  when 'hierarchy'
                    Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt) OR (#{Project.table_name}.lft < :lft AND #{Project.table_name}.rgt > :rgt)",
                                                :lft => project.lft, :rgt => project.rgt)
                  when 'descendants'
                    Issue.joins(:project).where("(#{Project.table_name}.lft >= :lft AND #{Project.table_name}.rgt <= :rgt)",
                                                :lft => project.lft, :rgt => project.rgt)
                  else
                    Issue.where(:project_id => project.id)
                  end
                end
                def self.by_tracker(project)
                  count_and_group_by(:project => project, :association => :tracker)
                end
                def self.by_version(project)
                  count_and_group_by(:project => project, :association => :fixed_version)
                end
                def self.by_priority(project)
                  count_and_group_by(:project => project, :association => :priority)
                end
                def self.by_category(project)
                  count_and_group_by(:project => project, :association => :category)
                end
                def self.by_assigned_to(project)
                  count_and_group_by(:project => project, :association => :assigned_to)
                end
                def self.by_author(project)
                  count_and_group_by(:project => project, :association => :author)
                end
                def self.by_subproject(project)
                  r = count_and_group_by(:project => project, :with_subprojects => true, :association => :project)
                  r.reject {|r| r["project_id"] == project.id.to_s}
                end
                # Query generator for selecting groups of issue counts for a project
                # based on specific criteria
                #
                # Options
                # * project - Project to search in.
                # * with_subprojects - Includes subprojects issues if set to true.
                # * association - Symbol. Association for grouping.
                def self.count_and_group_by(options)
                  assoc = reflect_on_association(options[:association])
                  select_field = assoc.foreign_key
                  Issue.
                    visible(User.current, :project => options[:project], :with_subprojects => options[:with_subprojects]).
                    joins(:status, assoc.name).
                    group(:status_id, :is_closed, select_field).
                    count.
                    map do |columns, total|
                      status_id, is_closed, field_value = columns
                      is_closed = ['t', 'true', '1'].include?(is_closed.to_s)
                      {
                        "status_id" => status_id.to_s,
                        "closed" => is_closed,
                        select_field => field_value.to_s,
                        "total" => total.to_s
                      }
                    end
                end
                # Returns a scope of projects that user can assign the issue to
                def allowed_target_projects(user=User.current)
                  current_project = new_record? ? nil : project
                  self.class.allowed_target_projects(user, current_project)
                end
                # Returns a scope of projects that user can assign issues to
                # If current_project is given, it will be included in the scope
                def self.allowed_target_projects(user=User.current, current_project=nil)
                  condition = Project.allowed_to_condition(user, :add_issues)
                  if current_project
                    condition = ["(#{condition}) OR #{Project.table_name}.id = ?", current_project.id]
                  end
                  Project.where(condition)
                end
                private
                def after_project_change
                  # Update project_id on related time entries
                  TimeEntry.where({:issue_id => id}).update_all(["project_id = ?", project_id])
                  # Delete issue relations
                  unless Setting.cross_project_issue_relations?
                    relations_from.clear
                    relations_to.clear
                  end
                  # Move subtasks that were in the same project
                  children.each do |child|
                    next unless child.project_id == project_id_was
                    # Change project and keep project
                    child.send :project=, project, true
                    unless child.save
                      raise ActiveRecord::Rollback
                    end
                  end
                end
                # Callback for after the creation of an issue by copy
                # * adds a "copied to" relation with the copied issue
                # * copies subtasks from the copied issue
                def after_create_from_copy
                  return unless copy? && !@after_create_from_copy_handled
                  if (@copied_from.project_id == project_id || Setting.cross_project_issue_relations?) && @copy_options[:link] != false
                    if @current_journal
                      @copied_from.init_journal(@current_journal.user)
                    end
                    relation = IssueRelation.new(:issue_from => @copied_from, :issue_to => self, :relation_type => IssueRelation::TYPE_COPIED_TO)
                    unless relation.save
                      logger.error "Could not create relation while copying ##{@copied_from.id} to ##{id} due to validation errors: #{relation.errors.full_messages.join(', ')}" if logger
                    end
                  end
                  unless @copied_from.leaf? || @copy_options[:subtasks] == false
                    copy_options = (@copy_options || {}).merge(:subtasks => false)
                    copied_issue_ids = {@copied_from.id => self.id}
                    @copied_from.reload.descendants.reorder("#{Issue.table_name}.lft").each do |child|
                      # Do not copy self when copying an issue as a descendant of the copied issue
                      next if child == self
                      # Do not copy subtasks of issues that were not copied
                      next unless copied_issue_ids[child.parent_id]
                      # Do not copy subtasks that are not visible to avoid potential disclosure of private data
                      unless child.visible?
                        logger.error "Subtask ##{child.id} was not copied during ##{@copied_from.id} copy because it is not visible to the current user" if logger
                        next
                      end
                      copy = Issue.new.copy_from(child, copy_options)
                      if @current_journal
                        copy.init_journal(@current_journal.user)
                      end
                      copy.author = author
                      copy.project = project
                      copy.parent_issue_id = copied_issue_ids[child.parent_id]
                      unless copy.save
                        logger.error "Could not copy subtask ##{child.id} while copying ##{@copied_from.id} to ##{id} due to validation errors: #{copy.errors.full_messages.join(', ')}" if logger
                        next
                      end
                      copied_issue_ids[child.id] = copy.id
                    end
                  end
                  @after_create_from_copy_handled = true
                end
                def update_nested_set_attributes
                  if parent_id_changed?
                    update_nested_set_attributes_on_parent_change
                  end
                  remove_instance_variable(:@parent_issue) if instance_variable_defined?(:@parent_issue)
                end
                # Updates the nested set for when an existing issue is moved
                def update_nested_set_attributes_on_parent_change
                  former_parent_id = parent_id_was
                  # delete invalid relations of all descendants
                  self_and_descendants.each do |issue|
                    issue.relations.each do |relation|
                      relation.destroy unless relation.valid?
                    end
                  end
                  # update former parent
                  recalculate_attributes_for(former_parent_id) if former_parent_id
                end
                def update_parent_attributes
                  if parent_id
                    recalculate_attributes_for(parent_id)
                    association(:parent).reset
                  end
                end
                def recalculate_attributes_for(issue_id)
                  if issue_id && p = Issue.find_by_id(issue_id)
                    # priority = highest priority of children
                    if priority_position = p.children.joins(:priority).maximum("#{IssuePriority.table_name}.position")
                      p.priority = IssuePriority.find_by_position(priority_position)
                    end
                    # start/due dates = lowest/highest dates of children
                    p.start_date = p.children.minimum(:start_date)
                    p.due_date = p.children.maximum(:due_date)
                    if p.start_date && p.due_date && p.due_date < p.start_date
                      p.start_date, p.due_date = p.due_date, p.start_date
                    end
                    # done ratio = weighted average ratio of leaves
                    unless Issue.use_status_for_done_ratio? && p.status && p.status.default_done_ratio
                      leaves_count = p.leaves.count
                      if leaves_count > 0
                        average = p.leaves.where("estimated_hours > 0").average(:estimated_hours).to_f
                        if average == 0
                          average = 1
                        end
                        done = p.leaves.joins(:status).
                          sum("COALESCE(CASE WHEN estimated_hours > 0 THEN estimated_hours ELSE NULL END, #{average}) " +
                              "* (CASE WHEN is_closed = #{self.class.connection.quoted_true} THEN 100 ELSE COALESCE(done_ratio, 0) END)").to_f
                        progress = done / (average * leaves_count)
                        p.done_ratio = progress.round
                      end
                    end
                    # estimate = sum of leaves estimates
                    p.estimated_hours = p.leaves.sum(:estimated_hours).to_f
                    p.estimated_hours = nil if p.estimated_hours == 0.0
                    # ancestors will be recursively updated
                    p.save(:validate => false)
                  end
                end
                # Update issues so their versions are not pointing to a
                # fixed_version that is not shared with the issue's project
                def self.update_versions(conditions=nil)
                  # Only need to update issues with a fixed_version from
                  # a different project and that is not systemwide shared
                  Issue.joins(:project, :fixed_version).
                    where("#{Issue.table_name}.fixed_version_id IS NOT NULL" +
                      " AND #{Issue.table_name}.project_id <> #{Version.table_name}.project_id" +
                      " AND #{Version.table_name}.sharing <> 'system'").
                    where(conditions).each do |issue|
                    next if issue.project.nil? || issue.fixed_version.nil?
                    unless issue.project.shared_versions.include?(issue.fixed_version)
                      issue.init_journal(User.current)
                      issue.fixed_version = nil
                      issue.save
                    end
                  end
                end
                # Callback on file attachment
                def attachment_added(attachment)
                  if current_journal && !attachment.new_record?
                    current_journal.journalize_attachment(attachment, :added)
                  end
                end
                # Callback on attachment deletion
                def attachment_removed(attachment)
                  if current_journal && !attachment.new_record?
                    current_journal.journalize_attachment(attachment, :removed)
                    current_journal.save
                  end
                end
                # Called after a relation is added
                def relation_added(relation)
                  if current_journal
                    current_journal.journalize_relation(relation, :added)
                    current_journal.save
                  end
                end
                # Called after a relation is removed
                def relation_removed(relation)
                  if current_journal
                    current_journal.journalize_relation(relation, :removed)
                    current_journal.save
                  end
                end
                # Default assignment based on category
                def default_assign
                  if assigned_to.nil? && category && category.assigned_to
                    self.assigned_to = category.assigned_to
                  end
                end
                # Updates start/due dates of following issues
                def reschedule_following_issues
                  if start_date_changed? || due_date_changed?
                    relations_from.each do |relation|
                      relation.set_issue_to_dates
                    end
                  end
                end
                # Closes duplicates if the issue is being closed
                def close_duplicates
                  if closing?
                    duplicates.each do |duplicate|
                      # Reload is needed in case the duplicate was updated by a previous duplicate
                      duplicate.reload
                      # Don't re-close it if it's already closed
                      next if duplicate.closed?
                      # Same user and notes
                      if @current_journal
                        duplicate.init_journal(@current_journal.user, @current_journal.notes)
                      end
                      duplicate.update_attribute :status, self.status
                    end
                  end
                end
                # Make sure updated_on is updated when adding a note and set updated_on now
                # so we can set closed_on with the same value on closing
                def force_updated_on_change
                  if @current_journal || changed?
                    self.updated_on = current_time_from_proper_timezone
                    if new_record?
                      self.created_on = updated_on
                    end
                  end
                end
                # Callback for setting closed_on when the issue is closed.
                # The closed_on attribute stores the time of the last closing
                # and is preserved when the issue is reopened.
                def update_closed_on
                  if closing?
                    self.closed_on = updated_on
                  end
                end
                # Saves the changes in a Journal
                # Called after_save
                def create_journal
                  if current_journal
                    current_journal.save
                  end
                end
                def send_notification
                  if Setting.notified_events.include?('issue_added')
                    Mailer.deliver_issue_add(self)
                  end
                end
                # Stores the previous assignee so we can still have access
                # to it during after_save callbacks (assigned_to_id_was is reset)
                def set_assigned_to_was
                  @previous_assigned_to_id = assigned_to_id_was
                end
                # Clears the previous assignee at the end of after_save callbacks
                def clear_assigned_to_was
                  @assigned_to_was = nil
                  @previous_assigned_to_id = nil
                end
              end

test/unit/issue_test.rb +18 -1

              # Redmine - project management software
              # Copyright (C) 2006-2015  Jean-Philippe Lang
              #
              # This program is free software; you can redistribute it and/or
              # modify it under the terms of the GNU General Public License
              # as published by the Free Software Foundation; either version 2
              # of the License, or (at your option) any later version.
              #
              # This program is distributed in the hope that it will be useful,
              # but WITHOUT ANY WARRANTY; without even the implied warranty of
              # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
              # GNU General Public License for more details.
              #
              # You should have received a copy of the GNU General Public License
              # along with this program; if not, write to the Free Software
              # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
              require File.expand_path('../../test_helper', __FILE__)
              class IssueTest < ActiveSupport::TestCase
                fixtures :projects, :users, :email_addresses, :members, :member_roles, :roles,
                         :groups_users,
                         :trackers, :projects_trackers,
                         :enabled_modules,
                         :versions,
                         :issue_statuses, :issue_categories, :issue_relations, :workflows,
                         :enumerations,
                         :issues, :journals, :journal_details,
                         :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
                         :time_entries
                include Redmine::I18n
                def setup
                  set_language_if_valid 'en'
                end
                def teardown
                  User.current = nil
                end
                def test_initialize
                  issue = Issue.new
                  assert_nil issue.project_id
                  assert_nil issue.tracker_id
                  assert_nil issue.status_id
                  assert_nil issue.author_id
                  assert_nil issue.assigned_to_id
                  assert_nil issue.category_id
                  assert_equal IssuePriority.default, issue.priority
                end
                def test_create
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                    :status_id => 1, :priority => IssuePriority.all.first,
                                    :subject => 'test_create',
                                    :description => 'IssueTest#test_create', :estimated_hours => '1:30')
                  assert issue.save
                  issue.reload
                  assert_equal 1.5, issue.estimated_hours
                end
                def test_create_minimal
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :subject => 'test_create')
                  assert issue.save
                  assert_equal issue.tracker.default_status, issue.status
                  assert issue.description.nil?
                  assert_nil issue.estimated_hours
                end
                def test_start_date_format_should_be_validated
                  set_language_if_valid 'en'
                  ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
                    issue = Issue.new(:start_date => invalid_date)
                    assert !issue.valid?
                    assert_include 'Start date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
                  end
                end
                def test_due_date_format_should_be_validated
                  set_language_if_valid 'en'
                  ['2012', 'ABC', '2012-15-20'].each do |invalid_date|
                    issue = Issue.new(:due_date => invalid_date)
                    assert !issue.valid?
                    assert_include 'Due date is not a valid date', issue.errors.full_messages, "No error found for invalid date #{invalid_date}"
                  end
                end
                def test_due_date_lesser_than_start_date_should_not_validate
                  set_language_if_valid 'en'
                  issue = Issue.new(:start_date => '2012-10-06', :due_date => '2012-10-02')
                  assert !issue.valid?
                  assert_include 'Due date must be greater than start date', issue.errors.full_messages
                end
                def test_start_date_lesser_than_soonest_start_should_not_validate_on_create
                  issue = Issue.generate(:start_date => '2013-06-04')
                  issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
                  assert !issue.valid?
                  assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
                end
                def test_start_date_lesser_than_soonest_start_should_not_validate_on_update_if_changed
                  issue = Issue.generate!(:start_date => '2013-06-04')
                  issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
                  issue.start_date = '2013-06-07'
                  assert !issue.valid?
                  assert_include "Start date cannot be earlier than 06/10/2013 because of preceding issues", issue.errors.full_messages
                end
                def test_start_date_lesser_than_soonest_start_should_validate_on_update_if_unchanged
                  issue = Issue.generate!(:start_date => '2013-06-04')
                  issue.stubs(:soonest_start).returns(Date.parse('2013-06-10'))
                  assert issue.valid?
                end
                def test_estimated_hours_should_be_validated
                  set_language_if_valid 'en'
                  ['-2'].each do |invalid|
                    issue = Issue.new(:estimated_hours => invalid)
                    assert !issue.valid?
                    assert_include 'Estimated time is invalid', issue.errors.full_messages
                  end
                end
                def test_create_with_required_custom_field
                  set_language_if_valid 'en'
                  field = IssueCustomField.find_by_name('Database')
                  field.update_attribute(:is_required, true)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :subject => 'test_create',
                                    :description => 'IssueTest#test_create_with_required_custom_field')
                  assert issue.available_custom_fields.include?(field)
                  # No value for the custom field
                  assert !issue.save
                  assert_equal ["Database cannot be blank"], issue.errors.full_messages
                  # Blank value
                  issue.custom_field_values = { field.id => '' }
                  assert !issue.save
                  assert_equal ["Database cannot be blank"], issue.errors.full_messages
                  # Invalid value
                  issue.custom_field_values = { field.id => 'SQLServer' }
                  assert !issue.save
                  assert_equal ["Database is not included in the list"], issue.errors.full_messages
                  # Valid value
                  issue.custom_field_values = { field.id => 'PostgreSQL' }
                  assert issue.save
                  issue.reload
                  assert_equal 'PostgreSQL', issue.custom_value_for(field).value
                end
                def test_create_with_group_assignment
                  with_settings :issue_group_assignment => '1' do
                    assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
                                     :subject => 'Group assignment',
                                     :assigned_to_id => 11).save
                    issue = Issue.order('id DESC').first
                    assert_kind_of Group, issue.assigned_to
                    assert_equal Group.find(11), issue.assigned_to
                  end
                end
                def test_create_with_parent_issue_id
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 1, :subject => 'Group assignment',
                                    :parent_issue_id => 1)
                  assert_save issue
                  assert_equal 1, issue.parent_issue_id
                  assert_equal Issue.find(1), issue.parent
                end
                def test_create_with_sharp_parent_issue_id
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 1, :subject => 'Group assignment',
                                    :parent_issue_id => "#1")
                  assert_save issue
                  assert_equal 1, issue.parent_issue_id
                  assert_equal Issue.find(1), issue.parent
                end
                def test_create_with_invalid_parent_issue_id
                  set_language_if_valid 'en'
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 1, :subject => 'Group assignment',
                                    :parent_issue_id => '01ABC')
                  assert !issue.save
                  assert_equal '01ABC', issue.parent_issue_id
                  assert_include 'Parent task is invalid', issue.errors.full_messages
                end
                def test_create_with_invalid_sharp_parent_issue_id
                  set_language_if_valid 'en'
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 1, :subject => 'Group assignment',
                                    :parent_issue_id => '#01ABC')
                  assert !issue.save
                  assert_equal '#01ABC', issue.parent_issue_id
                  assert_include 'Parent task is invalid', issue.errors.full_messages
                end
                def assert_visibility_match(user, issues)
                  assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
                end
                def test_visible_scope_for_anonymous
                  # Anonymous user should see issues of public projects only
                  issues = Issue.visible(User.anonymous).to_a
                  assert issues.any?
                  assert_nil issues.detect {|issue| !issue.project.is_public?}
                  assert_nil issues.detect {|issue| issue.is_private?}
                  assert_visibility_match User.anonymous, issues
                end
                def test_visible_scope_for_anonymous_without_view_issues_permissions
                  # Anonymous user should not see issues without permission
                  Role.anonymous.remove_permission!(:view_issues)
                  issues = Issue.visible(User.anonymous).to_a
                  assert issues.empty?
                  assert_visibility_match User.anonymous, issues
                end
                def test_visible_scope_for_anonymous_without_view_issues_permissions_and_membership
                  Role.anonymous.remove_permission!(:view_issues)
                  Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [2])
                  issues = Issue.visible(User.anonymous).all
                  assert issues.any?
                  assert_equal [1], issues.map(&:project_id).uniq.sort
                  assert_visibility_match User.anonymous, issues
                end
                def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
                  assert Role.anonymous.update_attribute(:issues_visibility, 'default')
                  issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
                  assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
                  assert !issue.visible?(User.anonymous)
                end
                def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
                  assert Role.anonymous.update_attribute(:issues_visibility, 'own')
                  issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
                  assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
                  assert !issue.visible?(User.anonymous)
                end
                def test_visible_scope_for_non_member
                  user = User.find(9)
                  assert user.projects.empty?
                  # Non member user should see issues of public projects only
                  issues = Issue.visible(user).to_a
                  assert issues.any?
                  assert_nil issues.detect {|issue| !issue.project.is_public?}
                  assert_nil issues.detect {|issue| issue.is_private?}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_non_member_with_own_issues_visibility
                  Role.non_member.update_attribute :issues_visibility, 'own'
                  Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
                  user = User.find(9)
                  issues = Issue.visible(user).to_a
                  assert issues.any?
                  assert_nil issues.detect {|issue| issue.author != user}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_non_member_without_view_issues_permissions
                  # Non member user should not see issues without permission
                  Role.non_member.remove_permission!(:view_issues)
                  user = User.find(9)
                  assert user.projects.empty?
                  issues = Issue.visible(user).to_a
                  assert issues.empty?
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_non_member_without_view_issues_permissions_and_membership
                  Role.non_member.remove_permission!(:view_issues)
                  Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [2])
                  user = User.find(9)
                  issues = Issue.visible(user).all
                  assert issues.any?
                  assert_equal [1], issues.map(&:project_id).uniq.sort
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_member
                  user = User.find(9)
                  # User should see issues of projects for which user has view_issues permissions only
                  Role.non_member.remove_permission!(:view_issues)
                  Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
                  issues = Issue.visible(user).to_a
                  assert issues.any?
                  assert_nil issues.detect {|issue| issue.project_id != 3}
                  assert_nil issues.detect {|issue| issue.is_private?}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_for_member_with_groups_should_return_assigned_issues
                  user = User.find(8)
                  assert user.groups.any?
                  Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
                  Role.non_member.remove_permission!(:view_issues)
                  issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 3,
                    :status_id => 1, :priority => IssuePriority.all.first,
                    :subject => 'Assignment test',
                    :assigned_to => user.groups.first,
                    :is_private => true)
                  Role.find(2).update_attribute :issues_visibility, 'default'
                  issues = Issue.visible(User.find(8)).to_a
                  assert issues.any?
                  assert issues.include?(issue)
                  Role.find(2).update_attribute :issues_visibility, 'own'
                  issues = Issue.visible(User.find(8)).to_a
                  assert issues.any?
                  assert_include issue, issues
                end
                def test_visible_scope_for_admin
                  user = User.find(1)
                  user.members.each(&:destroy)
                  assert user.projects.empty?
                  issues = Issue.visible(user).to_a
                  assert issues.any?
                  # Admin should see issues on private projects that admin does not belong to
                  assert issues.detect {|issue| !issue.project.is_public?}
                  # Admin should see private issues of other users
                  assert issues.detect {|issue| issue.is_private? && issue.author != user}
                  assert_visibility_match user, issues
                end
                def test_visible_scope_with_project
                  project = Project.find(1)
                  issues = Issue.visible(User.find(2), :project => project).to_a
                  projects = issues.collect(&:project).uniq
                  assert_equal 1, projects.size
                  assert_equal project, projects.first
                end
                def test_visible_scope_with_project_and_subprojects
                  project = Project.find(1)
                  issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).to_a
                  projects = issues.collect(&:project).uniq
                  assert projects.size > 1
                  assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
                end
                def test_visible_and_nested_set_scopes
                  user = User.generate!
                  parent = Issue.generate!(:assigned_to => user)
                  assert parent.visible?(user)
                  child1 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
                  child2 = Issue.generate!(:parent_issue_id => parent.id, :assigned_to => user)
                  parent.reload
                  child1.reload
                  child2.reload
                  assert child1.visible?(user)
                  assert child2.visible?(user)
                  assert_equal 2, parent.descendants.count
                  assert_equal 2, parent.descendants.visible(user).count
                  # awesome_nested_set 2-1-stable branch has regression.
                  # https://github.com/collectiveidea/awesome_nested_set/commit/3d5ac746542b564f6586c2316180254b088bebb6
                  # ActiveRecord::StatementInvalid: SQLite3::SQLException: ambiguous column name: lft:
                  assert_equal 2, parent.descendants.collect{|i| i}.size
                  assert_equal 2, parent.descendants.visible(user).collect{|i| i}.size
                end
                def test_visible_scope_with_unsaved_user_should_not_raise_an_error
                  user = User.new
                  assert_nothing_raised do
                    Issue.visible(user).to_a
                  end
                end
                def test_open_scope
                  issues = Issue.open.to_a
                  assert_nil issues.detect(&:closed?)
                end
                def test_open_scope_with_arg
                  issues = Issue.open(false).to_a
                  assert_equal issues, issues.select(&:closed?)
                end
                def test_fixed_version_scope_with_a_version_should_return_its_fixed_issues
                  version = Version.find(2)
                  assert version.fixed_issues.any?
                  assert_equal version.fixed_issues.to_a.sort, Issue.fixed_version(version).to_a.sort
                end
                def test_fixed_version_scope_with_empty_array_should_return_no_result
                  assert_equal 0, Issue.fixed_version([]).count
                end
                def test_errors_full_messages_should_include_custom_fields_errors
                  field = IssueCustomField.find_by_name('Database')
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :subject => 'test_create',
                                    :description => 'IssueTest#test_create_with_required_custom_field')
                  assert issue.available_custom_fields.include?(field)
                  # Invalid value
                  issue.custom_field_values = { field.id => 'SQLServer' }
                  assert !issue.valid?
                  assert_equal 1, issue.errors.full_messages.size
                  assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
                               issue.errors.full_messages.first
                end
                def test_update_issue_with_required_custom_field
                  field = IssueCustomField.find_by_name('Database')
                  field.update_attribute(:is_required, true)
                  issue = Issue.find(1)
                  assert_nil issue.custom_value_for(field)
                  assert issue.available_custom_fields.include?(field)
                  # No change to custom values, issue can be saved
                  assert issue.save
                  # Blank value
                  issue.custom_field_values = { field.id => '' }
                  assert !issue.save
                  # Valid value
                  issue.custom_field_values = { field.id => 'PostgreSQL' }
                  assert issue.save
                  issue.reload
                  assert_equal 'PostgreSQL', issue.custom_value_for(field).value
                end
                def test_should_not_update_attributes_if_custom_fields_validation_fails
                  issue = Issue.find(1)
                  field = IssueCustomField.find_by_name('Database')
                  assert issue.available_custom_fields.include?(field)
                  issue.custom_field_values = { field.id => 'Invalid' }
                  issue.subject = 'Should be not be saved'
                  assert !issue.save
                  issue.reload
                  assert_equal "Cannot print recipes", issue.subject
                end
                def test_should_not_recreate_custom_values_objects_on_update
                  field = IssueCustomField.find_by_name('Database')
                  issue = Issue.find(1)
                  issue.custom_field_values = { field.id => 'PostgreSQL' }
                  assert issue.save
                  custom_value = issue.custom_value_for(field)
                  issue.reload
                  issue.custom_field_values = { field.id => 'MySQL' }
                  assert issue.save
                  issue.reload
                  assert_equal custom_value.id, issue.custom_value_for(field).id
                end
                def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
                  issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                        :status_id => 1, :subject => 'Test',
                                        :custom_field_values => {'2' => 'Test'})
                  assert !Tracker.find(2).custom_field_ids.include?(2)
                  issue = Issue.find(issue.id)
                  issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
                  issue = Issue.find(issue.id)
                  custom_value = issue.custom_value_for(2)
                  assert_not_nil custom_value
                  assert_equal 'Test', custom_value.value
                end
                def test_assigning_tracker_id_should_reload_custom_fields_values
                  issue = Issue.new(:project => Project.find(1))
                  assert issue.custom_field_values.empty?
                  issue.tracker_id = 1
                  assert issue.custom_field_values.any?
                end
                def test_assigning_attributes_should_assign_project_and_tracker_first
                  seq = sequence('seq')
                  issue = Issue.new
                  issue.expects(:project_id=).in_sequence(seq)
                  issue.expects(:tracker_id=).in_sequence(seq)
                  issue.expects(:subject=).in_sequence(seq)
                  issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
                end
                def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
                  attributes = ActiveSupport::OrderedHash.new
                  attributes['custom_field_values'] = { '1' => 'MySQL' }
                  attributes['tracker_id'] = '1'
                  issue = Issue.new(:project => Project.find(1))
                  issue.attributes = attributes
                  assert_equal 'MySQL', issue.custom_field_value(1)
                end
                def test_reload_should_reload_custom_field_values
                  issue = Issue.generate!
                  issue.custom_field_values = {'2' => 'Foo'}
                  issue.save!
                  issue = Issue.order('id desc').first
                  assert_equal 'Foo', issue.custom_field_value(2)
                  issue.custom_field_values = {'2' => 'Bar'}
                  assert_equal 'Bar', issue.custom_field_value(2)
                  issue.reload
                  assert_equal 'Foo', issue.custom_field_value(2)
                end
                def test_should_update_issue_with_disabled_tracker
                  p = Project.find(1)
                  issue = Issue.find(1)
                  p.trackers.delete(issue.tracker)
                  assert !p.trackers.include?(issue.tracker)
                  issue.reload
                  issue.subject = 'New subject'
                  assert issue.save
                end
                def test_should_not_set_a_disabled_tracker
                  p = Project.find(1)
                  p.trackers.delete(Tracker.find(2))
                  issue = Issue.find(1)
                  issue.tracker_id = 2
                  issue.subject = 'New subject'
                  assert !issue.save
                  assert_not_equal [], issue.errors[:tracker_id]
                end
                def test_category_based_assignment
                  issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
                                       :status_id => 1, :priority => IssuePriority.all.first,
                                       :subject => 'Assignment test',
                                       :description => 'Assignment test', :category_id => 1)
                  assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
                end
                def test_new_statuses_allowed_to
                  WorkflowTransition.delete_all
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 2,
                                             :author => false, :assignee => false)
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 3,
                                             :author => true, :assignee => false)
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 4,
                                             :author => false, :assignee => true)
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 5,
                                             :author => true, :assignee => true)
                  status = IssueStatus.find(1)
                  role = Role.find(1)
                  tracker = Tracker.find(1)
                  user = User.find(2)
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author_id => 1)
                  assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author => user)
                  assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author_id => 1,
                                          :assigned_to => user)
                  assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author => user,
                                          :assigned_to => user)
                  assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
                  group = Group.generate!
                  group.users << user
                  issue = Issue.generate!(:tracker => tracker, :status => status,
                                          :project_id => 1, :author => user,
                                          :assigned_to => group)
                  assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
                end
                def test_new_statuses_allowed_to_should_consider_group_assignment
                  WorkflowTransition.delete_all
                  WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
                                             :old_status_id => 1, :new_status_id => 4,
                                             :author => false, :assignee => true)
                  user = User.find(2)
                  group = Group.generate!
                  group.users << user
                  issue = Issue.generate!(:author_id => 1, :assigned_to => group)
                  assert_include 4, issue.new_statuses_allowed_to(user).map(&:id)
                end
                def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
                  admin = User.find(1)
                  issue = Issue.find(1)
                  assert !admin.member_of?(issue.project)
                  expected_statuses = [issue.status] +
                                          WorkflowTransition.where(:old_status_id => issue.status_id).
                                              map(&:new_status).uniq.sort
                  assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
                end
                def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
                  issue = Issue.find(1).copy
                  assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
                  issue = Issue.find(2).copy
                  assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
                end
                def test_safe_attributes_names_should_not_include_disabled_field
                  tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
                  issue = Issue.new(:tracker => tracker)
                  assert_include 'tracker_id', issue.safe_attribute_names
                  assert_include 'status_id', issue.safe_attribute_names
                  assert_include 'subject', issue.safe_attribute_names
                  assert_include 'description', issue.safe_attribute_names
                  assert_include 'custom_field_values', issue.safe_attribute_names
                  assert_include 'custom_fields', issue.safe_attribute_names
                  assert_include 'lock_version', issue.safe_attribute_names
                  tracker.core_fields.each do |field|
                    assert_include field, issue.safe_attribute_names
                  end
                  tracker.disabled_core_fields.each do |field|
                    assert_not_include field, issue.safe_attribute_names
                  end
                end
                def test_safe_attributes_should_ignore_disabled_fields
                  tracker = Tracker.find(1)
                  tracker.core_fields = %w(assigned_to_id due_date)
                  tracker.save!
                  issue = Issue.new(:tracker => tracker)
                  issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
                  assert_nil issue.start_date
                  assert_equal Date.parse('2012-07-14'), issue.due_date
                end
                def test_safe_attributes_should_accept_target_tracker_enabled_fields
                  source = Tracker.find(1)
                  source.core_fields = []
                  source.save!
                  target = Tracker.find(2)
                  target.core_fields = %w(assigned_to_id due_date)
                  target.save!
                  issue = Issue.new(:tracker => source)
                  issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
                  assert_equal target, issue.tracker
                  assert_equal Date.parse('2012-07-14'), issue.due_date
                end
                def test_safe_attributes_should_not_include_readonly_fields
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1)
                  assert_equal %w(due_date), issue.read_only_attribute_names(user)
                  assert_not_include 'due_date', issue.safe_attribute_names(user)
                  issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
                  assert_equal Date.parse('2012-07-14'), issue.start_date
                  assert_nil issue.due_date
                end
                def test_safe_attributes_should_not_include_readonly_custom_fields
                  cf1 = IssueCustomField.create!(:name => 'Writable field',
                                                 :field_format => 'string',
                                                 :is_for_all => true, :tracker_ids => [1])
                  cf2 = IssueCustomField.create!(:name => 'Readonly field',
                                                 :field_format => 'string',
                                                 :is_for_all => true, :tracker_ids => [1])
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => cf2.id.to_s,
                                             :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1)
                  assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
                  assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
                  issue.send :safe_attributes=, {'custom_field_values' => {
                                                     cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
                                                   }}, user
                  assert_equal 'value1', issue.custom_field_value(cf1)
                  assert_nil issue.custom_field_value(cf2)
                  issue.send :safe_attributes=, {'custom_fields' => [
                                                    {'id' => cf1.id.to_s, 'value' => 'valuea'},
                                                    {'id' => cf2.id.to_s, 'value' => 'valueb'}
                                                  ]}, user
                  assert_equal 'valuea', issue.custom_field_value(cf1)
                  assert_nil issue.custom_field_value(cf2)
                end
                def test_editable_custom_field_values_should_return_non_readonly_custom_values
                  cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
                                                 :is_for_all => true, :tracker_ids => [1, 2])
                  cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
                                                 :is_for_all => true, :tracker_ids => [1, 2])
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
                                             :field_name => cf2.id.to_s, :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1)
                  values = issue.editable_custom_field_values(user)
                  assert values.detect {|value| value.custom_field == cf1}
                  assert_nil values.detect {|value| value.custom_field == cf2}
                  issue.tracker_id = 2
                  values = issue.editable_custom_field_values(user)
                  assert values.detect {|value| value.custom_field == cf1}
                  assert values.detect {|value| value.custom_field == cf2}
                end
                def test_editable_custom_fields_should_return_custom_field_that_is_enabled_for_the_role_only
                  enabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [1,2])
                  disabled_cf = IssueCustomField.generate!(:is_for_all => true, :tracker_ids => [1], :visible => false, :role_ids => [2])
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1)
                  assert_include enabled_cf, issue.editable_custom_fields(user)
                  assert_not_include disabled_cf, issue.editable_custom_fields(user)
                end
                def test_safe_attributes_should_accept_target_tracker_writable_fields
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'readonly')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
                  issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                                 'due_date' => '2012-07-14'}, user
                  assert_equal Date.parse('2012-07-12'), issue.start_date
                  assert_nil issue.due_date
                  issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                                 'due_date' => '2012-07-16',
                                                 'tracker_id' => 2}, user
                  assert_equal Date.parse('2012-07-12'), issue.start_date
                  assert_equal Date.parse('2012-07-16'), issue.due_date
                end
                def test_safe_attributes_should_accept_target_status_writable_fields
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'readonly')
                  WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'readonly')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
                  issue.send :safe_attributes=, {'start_date' => '2012-07-12',
                                                 'due_date' => '2012-07-14'},
                                                 user
                  assert_equal Date.parse('2012-07-12'), issue.start_date
                  assert_nil issue.due_date
                  issue.send :safe_attributes=, {'start_date' => '2012-07-15',
                                                  'due_date' => '2012-07-16',
                                                  'status_id' => 2},
                                                user
                  assert_equal Date.parse('2012-07-12'), issue.start_date
                  assert_equal Date.parse('2012-07-16'), issue.due_date
                end
                def test_required_attributes_should_be_validated
                  cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
                                                :is_for_all => true, :tracker_ids => [1, 2])
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'category_id',
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => cf.id.to_s,
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
                                             :role_id => 1, :field_name => cf.id.to_s,
                                             :rule => 'required')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :status_id => 1, :subject => 'Required fields',
                                    :author => user)
                  assert_equal [cf.id.to_s, "category_id", "due_date"],
                               issue.required_attribute_names(user).sort
                  assert !issue.save, "Issue was saved"
                  assert_equal ["Category cannot be blank", "Due date cannot be blank", "Foo cannot be blank"],
                                issue.errors.full_messages.sort
                  issue.tracker_id = 2
                  assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
                  assert !issue.save, "Issue was saved"
                  assert_equal ["Foo cannot be blank", "Start date cannot be blank"],
                               issue.errors.full_messages.sort
                  issue.start_date = Date.today
                  issue.custom_field_values = {cf.id.to_s => 'bar'}
                  assert issue.save
                end
                def test_required_attribute_that_is_disabled_for_the_tracker_should_not_be_required
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'required')
                  user = User.find(2)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                                    :subject => 'Required fields', :author => user)
                  assert !issue.save
                  assert_include "Start date cannot be blank", issue.errors.full_messages
                  tracker = Tracker.find(1)
                  tracker.core_fields -= %w(start_date)
                  tracker.save!
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                                    :subject => 'Required fields', :author => user)
                  assert issue.save
                end
                def test_required_custom_field_that_is_not_visible_for_the_user_should_not_be_required
                  CustomField.delete_all
                  field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
                  user = User.generate!
                  User.add_to_project(user, Project.find(1), Role.find(2))
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                                    :subject => 'Required fields', :author => user)
                  assert_save issue
                end
                def test_required_custom_field_that_is_visible_for_the_user_should_be_required
                  CustomField.delete_all
                  field = IssueCustomField.generate!(:is_required => true, :visible => false, :role_ids => [1], :trackers => Tracker.all, :is_for_all => true)
                  user = User.generate!
                  User.add_to_project(user, Project.find(1), Role.find(1))
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                                    :subject => 'Required fields', :author => user)
                  assert !issue.save
                  assert_include "#{field.name} cannot be blank", issue.errors.full_messages
                end
                def test_required_attribute_names_for_multiple_roles_should_intersect_rules
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'required')
                  user = User.find(2)
                  member = Member.find(1)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
                  assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
                  member.role_ids = [1, 2]
                  member.save!
                  assert_equal [], issue.required_attribute_names(user.reload)
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 2, :field_name => 'due_date',
                                             :rule => 'required')
                  assert_equal %w(due_date), issue.required_attribute_names(user)
                  member.role_ids = [1, 2, 3]
                  member.save!
                  assert_equal [], issue.required_attribute_names(user.reload)
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
-                                            :role_id => 2, :field_name => 'due_date',
+                                            :role_id => 3, :field_name => 'due_date',
                                             :rule => 'readonly')
                  # required + readonly => required
                  assert_equal %w(due_date), issue.required_attribute_names(user)
                end
                def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'due_date',
                                             :rule => 'readonly')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role_id => 1, :field_name => 'start_date',
                                             :rule => 'readonly')
                  user = User.find(2)
                  member = Member.find(1)
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
                  assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
                  member.role_ids = [1, 2]
                  member.save!
                  assert_equal [], issue.read_only_attribute_names(user.reload)
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                            :role_id => 2, :field_name => 'due_date',
                                            :rule => 'readonly')
                  assert_equal %w(due_date), issue.read_only_attribute_names(user)
                end
+               # A field that is not visible by role 2 and readonly by role 1 should be readonly for user with role 1 and 2
+               def test_read_only_attribute_names_should_include_custom_fields_that_combine_readonly_and_not_visible_for_roles
+                 field = IssueCustomField.generate!(
+                   :is_for_all => true, :trackers => Tracker.all, :visible => false, :role_ids => [1]
+                 )
+                 WorkflowPermission.delete_all
+                 WorkflowPermission.create!(
+                   :old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => field.id, :rule => 'readonly'
+                 )
+                 user = User.generate!
+                 project = Project.find(1)
+                 User.add_to_project(user, project, Role.where(:id => [1, 2]))
+                 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
+                 assert_equal [field.id.to_s], issue.read_only_attribute_names(user)
+               end
                def test_workflow_rules_should_ignore_roles_without_issue_permissions
                  role = Role.generate! :permissions => [:view_issues, :edit_issues]
                  ignored_role = Role.generate! :permissions => [:view_issues]
                  WorkflowPermission.delete_all
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role => role, :field_name => 'due_date',
                                             :rule => 'required')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role => role, :field_name => 'start_date',
                                             :rule => 'readonly')
                  WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
                                             :role => role, :field_name => 'done_ratio',
                                             :rule => 'readonly')
                  user = User.generate!
                  User.add_to_project user, Project.find(1), [role, ignored_role]
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
                  assert_equal %w(due_date), issue.required_attribute_names(user)
                  assert_equal %w(done_ratio start_date), issue.read_only_attribute_names(user).sort
                end
                def test_copy
                  issue = Issue.new.copy_from(1)
                  assert issue.copy?
                  assert issue.save
                  issue.reload
                  orig = Issue.find(1)
                  assert_equal orig.subject, issue.subject
                  assert_equal orig.tracker, issue.tracker
                  assert_equal "125", issue.custom_value_for(2).value
                end
                def test_copy_should_copy_status
                  orig = Issue.find(8)
                  assert orig.status != orig.default_status
                  issue = Issue.new.copy_from(orig)
                  assert issue.save
                  issue.reload
                  assert_equal orig.status, issue.status
                end
                def test_copy_should_add_relation_with_copied_issue
                  copied = Issue.find(1)
                  issue = Issue.new.copy_from(copied)
                  assert issue.save
                  issue.reload
                  assert_equal 1, issue.relations.size
                  relation = issue.relations.first
                  assert_equal 'copied_to', relation.relation_type
                  assert_equal copied, relation.issue_from
                  assert_equal issue, relation.issue_to
                end
                def test_copy_should_copy_subtasks
                  issue = Issue.generate_with_descendants!
                  copy = issue.reload.copy
                  copy.author = User.find(7)
                  assert_difference 'Issue.count', 1+issue.descendants.count do
                    assert copy.save
                  end
                  copy.reload
                  assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
                  child_copy = copy.children.detect {|c| c.subject == 'Child1'}
                  assert_equal %w(Child11), child_copy.children.map(&:subject).sort
                  assert_equal copy.author, child_copy.author
                end
                def test_copy_as_a_child_of_copied_issue_should_not_copy_itself
                  parent = Issue.generate!
                  child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
                  child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
                  copy = parent.reload.copy
                  copy.parent_issue_id = parent.id
                  copy.author = User.find(7)
                  assert_difference 'Issue.count', 3 do
                    assert copy.save
                  end
                  parent.reload
                  copy.reload
                  assert_equal parent, copy.parent
                  assert_equal 3, parent.children.count
                  assert_equal 5, parent.descendants.count
                  assert_equal 2, copy.children.count
                  assert_equal 2, copy.descendants.count
                end
                def test_copy_as_a_descendant_of_copied_issue_should_not_copy_itself
                  parent = Issue.generate!
                  child1 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 1')
                  child2 = Issue.generate!(:parent_issue_id => parent.id, :subject => 'Child 2')
                  copy = parent.reload.copy
                  copy.parent_issue_id = child1.id
                  copy.author = User.find(7)
                  assert_difference 'Issue.count', 3 do
                    assert copy.save
                  end
                  parent.reload
                  child1.reload
                  copy.reload
                  assert_equal child1, copy.parent
                  assert_equal 2, parent.children.count
                  assert_equal 5, parent.descendants.count
                  assert_equal 1, child1.children.count
                  assert_equal 3, child1.descendants.count
                  assert_equal 2, copy.children.count
                  assert_equal 2, copy.descendants.count
                end
                def test_copy_should_copy_subtasks_to_target_project
                  issue = Issue.generate_with_descendants!
                  copy = issue.copy(:project_id => 3)
                  assert_difference 'Issue.count', 1+issue.descendants.count do
                    assert copy.save
                  end
                  assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
                end
                def test_copy_should_not_copy_subtasks_twice_when_saving_twice
                  issue = Issue.generate_with_descendants!
                  copy = issue.reload.copy
                  assert_difference 'Issue.count', 1+issue.descendants.count do
                    assert copy.save
                    assert copy.save
                  end
                end
                def test_should_not_call_after_project_change_on_creation
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
                                    :subject => 'Test', :author_id => 1)
                  issue.expects(:after_project_change).never
                  issue.save!
                end
                def test_should_not_call_after_project_change_on_update
                  issue = Issue.find(1)
                  issue.project = Project.find(1)
                  issue.subject = 'No project change'
                  issue.expects(:after_project_change).never
                  issue.save!
                end
                def test_should_call_after_project_change_on_project_change
                  issue = Issue.find(1)
                  issue.project = Project.find(2)
                  issue.expects(:after_project_change).once
                  issue.save!
                end
                def test_adding_journal_should_update_timestamp
                  issue = Issue.find(1)
                  updated_on_was = issue.updated_on
                  issue.init_journal(User.first, "Adding notes")
                  assert_difference 'Journal.count' do
                    assert issue.save
                  end
                  issue.reload
                  assert_not_equal updated_on_was, issue.updated_on
                end
                def test_should_close_duplicates
                  # Create 3 issues
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  issue3 = Issue.generate!
                  # 2 is a dupe of 1
                  IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
                                        :relation_type => IssueRelation::TYPE_DUPLICATES)
                  # And 3 is a dupe of 2
              #    IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
              #                          :relation_type => IssueRelation::TYPE_DUPLICATES)
                  # And 3 is a dupe of 1 (circular duplicates)
                  IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
                                        :relation_type => IssueRelation::TYPE_DUPLICATES)
                  assert issue1.reload.duplicates.include?(issue2)
                  # Closing issue 1
                  issue1.init_journal(User.first, "Closing issue1")
                  issue1.status = IssueStatus.where(:is_closed => true).first
                  assert issue1.save
                  # 2 and 3 should be also closed
                  assert issue2.reload.closed?
                  assert issue3.reload.closed?
                end
                def test_should_not_close_duplicated_issue
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  # 2 is a dupe of 1
                  IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
                                       :relation_type => IssueRelation::TYPE_DUPLICATES)
                  # 2 is a dup of 1 but 1 is not a duplicate of 2
                  assert !issue2.reload.duplicates.include?(issue1)
                  # Closing issue 2
                  issue2.init_journal(User.first, "Closing issue2")
                  issue2.status = IssueStatus.where(:is_closed => true).first
                  assert issue2.save
                  # 1 should not be also closed
                  assert !issue1.reload.closed?
                end
                def test_assignable_versions
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :fixed_version_id => 1,
                                    :subject => 'New issue')
                  assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
                end
                def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :fixed_version_id => 1,
                                    :subject => 'New issue')
                  assert !issue.save
                  assert_not_equal [], issue.errors[:fixed_version_id]
                end
                def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :fixed_version_id => 2,
                                    :subject => 'New issue')
                  assert !issue.save
                  assert_not_equal [], issue.errors[:fixed_version_id]
                end
                def test_should_be_able_to_assign_a_new_issue_to_an_open_version
                  issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
                                    :status_id => 1, :fixed_version_id => 3,
                                    :subject => 'New issue')
                  assert issue.save
                end
                def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
                  issue = Issue.find(11)
                  assert_equal 'closed', issue.fixed_version.status
                  issue.subject = 'Subject changed'
                  assert issue.save
                end
                def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
                  issue = Issue.find(11)
                  issue.status_id = 1
                  assert !issue.save
                  assert_not_equal [], issue.errors[:base]
                end
                def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
                  issue = Issue.find(11)
                  issue.status_id = 1
                  issue.fixed_version_id = 3
                  assert issue.save
                end
                def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
                  issue = Issue.find(12)
                  assert_equal 'locked', issue.fixed_version.status
                  issue.status_id = 1
                  assert issue.save
                end
                def test_should_not_be_able_to_keep_unshared_version_when_changing_project
                  issue = Issue.find(2)
                  assert_equal 2, issue.fixed_version_id
                  issue.project_id = 3
                  assert_nil issue.fixed_version_id
                  issue.fixed_version_id = 2
                  assert !issue.save
                  assert_include 'Target version is not included in the list', issue.errors.full_messages
                end
                def test_should_keep_shared_version_when_changing_project
                  Version.find(2).update_attribute :sharing, 'tree'
                  issue = Issue.find(2)
                  assert_equal 2, issue.fixed_version_id
                  issue.project_id = 3
                  assert_equal 2, issue.fixed_version_id
                  assert issue.save
                end
                def test_allowed_target_projects_should_include_projects_with_issue_tracking_enabled
                  assert_include Project.find(2), Issue.allowed_target_projects(User.find(2))
                end
                def test_allowed_target_projects_should_not_include_projects_with_issue_tracking_disabled
                  Project.find(2).disable_module! :issue_tracking
                  assert_not_include Project.find(2), Issue.allowed_target_projects(User.find(2))
                end
                def test_move_to_another_project_with_same_category
                  issue = Issue.find(1)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Category changes
                  assert_equal 4, issue.category_id
                  # Make sure time entries were move to the target project
                  assert_equal 2, issue.time_entries.first.project_id
                end
                def test_move_to_another_project_without_same_category
                  issue = Issue.find(2)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Category cleared
                  assert_nil issue.category_id
                end
                def test_move_to_another_project_should_clear_fixed_version_when_not_shared
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 1)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Cleared fixed_version
                  assert_equal nil, issue.fixed_version
                end
                def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 4)
                  issue.project = Project.find(5)
                  assert issue.save
                  issue.reload
                  assert_equal 5, issue.project_id
                  # Keep fixed_version
                  assert_equal 4, issue.fixed_version_id
                end
                def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 1)
                  issue.project = Project.find(5)
                  assert issue.save
                  issue.reload
                  assert_equal 5, issue.project_id
                  # Cleared fixed_version
                  assert_equal nil, issue.fixed_version
                end
                def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
                  issue = Issue.find(1)
                  issue.update_attribute(:fixed_version_id, 7)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  # Keep fixed_version
                  assert_equal 7, issue.fixed_version_id
                end
                def test_move_to_another_project_should_keep_parent_if_valid
                  issue = Issue.find(1)
                  issue.update_attribute(:parent_issue_id, 2)
                  issue.project = Project.find(3)
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.parent_id
                end
                def test_move_to_another_project_should_clear_parent_if_not_valid
                  issue = Issue.find(1)
                  issue.update_attribute(:parent_issue_id, 2)
                  issue.project = Project.find(2)
                  assert issue.save
                  issue.reload
                  assert_nil issue.parent_id
                end
                def test_move_to_another_project_with_disabled_tracker
                  issue = Issue.find(1)
                  target = Project.find(2)
                  target.tracker_ids = [3]
                  target.save
                  issue.project = target
                  assert issue.save
                  issue.reload
                  assert_equal 2, issue.project_id
                  assert_equal 3, issue.tracker_id
                end
                def test_copy_to_the_same_project
                  issue = Issue.find(1)
                  copy = issue.copy
                  assert_difference 'Issue.count' do
                    copy.save!
                  end
                  assert_kind_of Issue, copy
                  assert_equal issue.project, copy.project
                  assert_equal "125", copy.custom_value_for(2).value
                end
                def test_copy_to_another_project_and_tracker
                  issue = Issue.find(1)
                  copy = issue.copy(:project_id => 3, :tracker_id => 2)
                  assert_difference 'Issue.count' do
                    copy.save!
                  end
                  copy.reload
                  assert_kind_of Issue, copy
                  assert_equal Project.find(3), copy.project
                  assert_equal Tracker.find(2), copy.tracker
                  # Custom field #2 is not associated with target tracker
                  assert_nil copy.custom_value_for(2)
                end
                test "#copy should not create a journal" do
                  copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :assigned_to_id => 3}, :link => false)
                  copy.save!
                  assert_equal 0, copy.reload.journals.size
                end
                test "#copy should allow assigned_to changes" do
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
                  assert_equal 3, copy.assigned_to_id
                end
                test "#copy should allow status changes" do
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
                  assert_equal 2, copy.status_id
                end
                test "#copy should allow start date changes" do
                  date = Date.today
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :start_date => date)
                  assert_equal date, copy.start_date
                end
                test "#copy should allow due date changes" do
                  date = Date.today
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2, :due_date => date)
                  assert_equal date, copy.due_date
                end
                test "#copy should set current user as author" do
                  User.current = User.find(9)
                  copy = Issue.find(1).copy(:project_id => 3, :tracker_id => 2)
                  assert_equal User.current, copy.author
                end
                test "#copy should create a journal with notes" do
                  date = Date.today
                  notes = "Notes added when copying"
                  copy = Issue.find(1).copy({:project_id => 3, :tracker_id => 2, :start_date => date}, :link => false)
                  copy.init_journal(User.current, notes)
                  copy.save!
                  assert_equal 1, copy.journals.size
                  journal = copy.journals.first
                  assert_equal 0, journal.details.size
                  assert_equal notes, journal.notes
                end
                def test_valid_parent_project
                  issue = Issue.find(1)
                  issue_in_same_project = Issue.find(2)
                  issue_in_child_project = Issue.find(5)
                  issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
                  issue_in_other_child_project = Issue.find(6)
                  issue_in_different_tree = Issue.find(4)
                  with_settings :cross_project_subtasks => '' do
                    assert_equal true, issue.valid_parent_project?(issue_in_same_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_child_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
                  end
                  with_settings :cross_project_subtasks => 'system' do
                    assert_equal true, issue.valid_parent_project?(issue_in_same_project)
                    assert_equal true, issue.valid_parent_project?(issue_in_child_project)
                    assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
                  end
                  with_settings :cross_project_subtasks => 'tree' do
                    assert_equal true, issue.valid_parent_project?(issue_in_same_project)
                    assert_equal true, issue.valid_parent_project?(issue_in_child_project)
                    assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
                    assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
                    assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
                  end
                  with_settings :cross_project_subtasks => 'descendants' do
                    assert_equal true, issue.valid_parent_project?(issue_in_same_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_child_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
                    assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
                    assert_equal true, issue_in_child_project.valid_parent_project?(issue)
                    assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
                  end
                end
                def test_recipients_should_include_previous_assignee
                  user = User.find(3)
                  user.members.update_all ["mail_notification = ?", false]
                  user.update_attribute :mail_notification, 'only_assigned'
                  issue = Issue.find(2)
                  issue.assigned_to = nil
                  assert_include user.mail, issue.recipients
                  issue.save!
                  assert !issue.recipients.include?(user.mail)
                end
                def test_recipients_should_not_include_users_that_cannot_view_the_issue
                  issue = Issue.find(12)
                  assert issue.recipients.include?(issue.author.mail)
                  # copy the issue to a private project
                  copy  = issue.copy(:project_id => 5, :tracker_id => 2)
                  # author is not a member of project anymore
                  assert !copy.recipients.include?(copy.author.mail)
                end
                def test_recipients_should_include_the_assigned_group_members
                  group_member = User.generate!
                  group = Group.generate!
                  group.users << group_member
                  issue = Issue.find(12)
                  issue.assigned_to = group
                  assert issue.recipients.include?(group_member.mail)
                end
                def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
                  user = User.find(3)
                  issue = Issue.find(9)
                  Watcher.create!(:user => user, :watchable => issue)
                  assert issue.watched_by?(user)
                  assert !issue.watcher_recipients.include?(user.mail)
                end
                def test_issue_destroy
                  Issue.find(1).destroy
                  assert_nil Issue.find_by_id(1)
                  assert_nil TimeEntry.find_by_issue_id(1)
                end
                def test_destroy_should_delete_time_entries_custom_values
                  issue = Issue.generate!
                  time_entry = TimeEntry.generate!(:issue => issue, :custom_field_values => {10 => '1'})
                  assert_difference 'CustomValue.where(:customized_type => "TimeEntry").count', -1 do
                    assert issue.destroy
                  end
                end
                def test_destroying_a_deleted_issue_should_not_raise_an_error
                  issue = Issue.find(1)
                  Issue.find(1).destroy
                  assert_nothing_raised do
                    assert_no_difference 'Issue.count' do
                      issue.destroy
                    end
                    assert issue.destroyed?
                  end
                end
                def test_destroying_a_stale_issue_should_not_raise_an_error
                  issue = Issue.find(1)
                  Issue.find(1).update_attribute :subject, "Updated"
                  assert_nothing_raised do
                    assert_difference 'Issue.count', -1 do
                      issue.destroy
                    end
                    assert issue.destroyed?
                  end
                end
                def test_blocked
                  blocked_issue = Issue.find(9)
                  blocking_issue = Issue.find(10)
                  assert blocked_issue.blocked?
                  assert !blocking_issue.blocked?
                end
                def test_blocked_issues_dont_allow_closed_statuses
                  blocked_issue = Issue.find(9)
                  allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
                  assert !allowed_statuses.empty?
                  closed_statuses = allowed_statuses.select {|st| st.is_closed?}
                  assert closed_statuses.empty?
                end
                def test_unblocked_issues_allow_closed_statuses
                  blocking_issue = Issue.find(10)
                  allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
                  assert !allowed_statuses.empty?
                  closed_statuses = allowed_statuses.select {|st| st.is_closed?}
                  assert !closed_statuses.empty?
                end
                def test_reschedule_an_issue_without_dates
                  with_settings :non_working_week_days => [] do
                    issue = Issue.new(:start_date => nil, :due_date => nil)
                    issue.reschedule_on '2012-10-09'.to_date
                    assert_equal '2012-10-09'.to_date, issue.start_date
                    assert_equal '2012-10-09'.to_date, issue.due_date
                  end
                  with_settings :non_working_week_days => %w(6 7) do
                    issue = Issue.new(:start_date => nil, :due_date => nil)
                    issue.reschedule_on '2012-10-09'.to_date
                    assert_equal '2012-10-09'.to_date, issue.start_date
                    assert_equal '2012-10-09'.to_date, issue.due_date
                    issue = Issue.new(:start_date => nil, :due_date => nil)
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-15'.to_date, issue.start_date
                    assert_equal '2012-10-15'.to_date, issue.due_date
                  end
                end
                def test_reschedule_an_issue_with_start_date
                  with_settings :non_working_week_days => [] do
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-13'.to_date, issue.start_date
                    assert_equal '2012-10-13'.to_date, issue.due_date
                  end
                  with_settings :non_working_week_days => %w(6 7) do
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
                    issue.reschedule_on '2012-10-11'.to_date
                    assert_equal '2012-10-11'.to_date, issue.start_date
                    assert_equal '2012-10-11'.to_date, issue.due_date
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => nil)
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-15'.to_date, issue.start_date
                    assert_equal '2012-10-15'.to_date, issue.due_date
                  end
                end
                def test_reschedule_an_issue_with_start_and_due_dates
                  with_settings :non_working_week_days => [] do
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-15')
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-13'.to_date, issue.start_date
                    assert_equal '2012-10-19'.to_date, issue.due_date
                  end
                  with_settings :non_working_week_days => %w(6 7) do
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19') # 8 working days
                    issue.reschedule_on '2012-10-11'.to_date
                    assert_equal '2012-10-11'.to_date, issue.start_date
                    assert_equal '2012-10-23'.to_date, issue.due_date
                    issue = Issue.new(:start_date => '2012-10-09', :due_date => '2012-10-19')
                    issue.reschedule_on '2012-10-13'.to_date
                    assert_equal '2012-10-15'.to_date, issue.start_date
                    assert_equal '2012-10-25'.to_date, issue.due_date
                  end
                end
                def test_rescheduling_an_issue_to_a_later_due_date_should_reschedule_following_issue
                  issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
                  issue1.reload
                  issue1.due_date = '2012-10-23'
                  issue1.save!
                  issue2.reload
                  assert_equal Date.parse('2012-10-24'), issue2.start_date
                  assert_equal Date.parse('2012-10-26'), issue2.due_date
                end
                def test_rescheduling_an_issue_to_an_earlier_due_date_should_reschedule_following_issue
                  issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
                  issue1.reload
                  issue1.start_date = '2012-09-17'
                  issue1.due_date = '2012-09-18'
                  issue1.save!
                  issue2.reload
                  assert_equal Date.parse('2012-09-19'), issue2.start_date
                  assert_equal Date.parse('2012-09-21'), issue2.due_date
                end
                def test_rescheduling_reschedule_following_issue_earlier_should_consider_other_preceding_issues
                  issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue2 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue3 = Issue.generate!(:start_date => '2012-10-01', :due_date => '2012-10-02')
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal Date.parse('2012-10-18'), issue2.reload.start_date
                  issue1.reload
                  issue1.start_date = '2012-09-17'
                  issue1.due_date = '2012-09-18'
                  issue1.save!
                  issue2.reload
                  # Issue 2 must start after Issue 3
                  assert_equal Date.parse('2012-10-03'), issue2.start_date
                  assert_equal Date.parse('2012-10-05'), issue2.due_date
                end
                def test_rescheduling_a_stale_issue_should_not_raise_an_error
                  with_settings :non_working_week_days => [] do
                    stale = Issue.find(1)
                    issue = Issue.find(1)
                    issue.subject = "Updated"
                    issue.save!
                    date = 10.days.from_now.to_date
                    assert_nothing_raised do
                      stale.reschedule_on!(date)
                    end
                    assert_equal date, stale.reload.start_date
                  end
                end
                def test_child_issue_should_consider_parent_soonest_start_on_create
                  set_language_if_valid 'en'
                  issue1 = Issue.generate!(:start_date => '2012-10-15', :due_date => '2012-10-17')
                  issue2 = Issue.generate!(:start_date => '2012-10-18', :due_date => '2012-10-20')
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
                                        :relation_type => IssueRelation::TYPE_PRECEDES)
                  issue1.reload
                  issue2.reload
                  assert_equal Date.parse('2012-10-18'), issue2.start_date
                  with_settings :date_format => '%m/%d/%Y' do
                    child = Issue.new(:parent_issue_id => issue2.id, :start_date => '2012-10-16',
                      :project_id => 1, :tracker_id => 1, :status_id => 1, :subject => 'Child', :author_id => 1)
                    assert !child.valid?
                    assert_include 'Start date cannot be earlier than 10/18/2012 because of preceding issues', child.errors.full_messages
                    assert_equal Date.parse('2012-10-18'), child.soonest_start
                    child.start_date = '2012-10-18'
                    assert child.save
                  end
                end
                def test_setting_parent_to_a_dependent_issue_should_not_validate
                  set_language_if_valid 'en'
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  issue3 = Issue.generate!
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
                  IssueRelation.create!(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_PRECEDES)
                  issue3.reload
                  issue3.parent_issue_id = issue2.id
                  assert !issue3.valid?
                  assert_include 'Parent task is invalid', issue3.errors.full_messages
                end
                def test_setting_parent_should_not_allow_circular_dependency
                  set_language_if_valid 'en'
                  issue1 = Issue.generate!
                  issue2 = Issue.generate!
                  IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
                  issue3 = Issue.generate!
                  issue2.reload
                  issue2.parent_issue_id = issue3.id
                  issue2.save!
                  issue4 = Issue.generate!
                  IssueRelation.create!(:issue_from => issue3, :issue_to => issue4, :relation_type => IssueRelation::TYPE_PRECEDES)
                  issue4.reload
                  issue4.parent_issue_id = issue1.id
                  assert !issue4.valid?
                  assert_include 'Parent task is invalid', issue4.errors.full_messages
                end
                def test_overdue
                  assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
                  assert !Issue.new(:due_date => Date.today).overdue?
                  assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
                  assert !Issue.new(:due_date => nil).overdue?
                  assert !Issue.new(:due_date => 1.day.ago.to_date,
                                    :status => IssueStatus.where(:is_closed => true).first
                                    ).overdue?
                end
                test "#behind_schedule? should be false if the issue has no start_date" do
                  assert !Issue.new(:start_date => nil,
                                    :due_date => 1.day.from_now.to_date,
                                    :done_ratio => 0).behind_schedule?
                end
                test "#behind_schedule? should be false if the issue has no end_date" do
                  assert !Issue.new(:start_date => 1.day.from_now.to_date,
                                    :due_date => nil,
                                    :done_ratio => 0).behind_schedule?
                end
                test "#behind_schedule? should be false if the issue has more done than it's calendar time" do
                  assert !Issue.new(:start_date => 50.days.ago.to_date,
                                    :due_date => 50.days.from_now.to_date,
                                    :done_ratio => 90).behind_schedule?
                end
                test "#behind_schedule? should be true if the issue hasn't been started at all" do
                  assert Issue.new(:start_date => 1.day.ago.to_date,
                                   :due_date => 1.day.from_now.to_date,
                                   :done_ratio => 0).behind_schedule?
                end
                test "#behind_schedule? should be true if the issue has used more calendar time than it's done ratio" do
                  assert Issue.new(:start_date => 100.days.ago.to_date,
                                   :due_date => Date.today,
                                   :done_ratio => 90).behind_schedule?
                end
                test "#assignable_users should be Users" do
                  assert_kind_of User, Issue.find(1).assignable_users.first
                end
                test "#assignable_users should include the issue author" do
                  non_project_member = User.generate!
                  issue = Issue.generate!(:author => non_project_member)
                  assert issue.assignable_users.include?(non_project_member)
                end
                test "#assignable_users should include the current assignee" do
                  user = User.generate!
                  issue = Issue.generate!(:assigned_to => user)
                  user.lock!
                  assert Issue.find(issue.id).assignable_users.include?(user)
                end
                test "#assignable_users should not show the issue author twice" do
                  assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
                  assert_equal 2, assignable_user_ids.length
                  assignable_user_ids.each do |user_id|
                    assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
                                 "User #{user_id} appears more or less than once"
                  end
                end
                test "#assignable_users with issue_group_assignment should include groups" do
                  issue = Issue.new(:project => Project.find(2))
                  with_settings :issue_group_assignment => '1' do
                    assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
                    assert issue.assignable_users.include?(Group.find(11))
                  end
                end
                test "#assignable_users without issue_group_assignment should not include groups" do
                  issue = Issue.new(:project => Project.find(2))
                  with_settings :issue_group_assignment => '0' do
                    assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
                    assert !issue.assignable_users.include?(Group.find(11))
                  end
                end
                def test_assignable_users_should_not_include_builtin_groups
                  Member.create!(:project_id => 1, :principal => Group.non_member, :role_ids => [1])
                  Member.create!(:project_id => 1, :principal => Group.anonymous, :role_ids => [1])
                  issue = Issue.new(:project => Project.find(1))
                  with_settings :issue_group_assignment => '1' do
                    assert_nil issue.assignable_users.detect {|u| u.is_a?(GroupBuiltin)}
                  end
                end
                def test_create_should_send_email_notification
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 3, :status_id => 1,
                                    :priority => IssuePriority.all.first,
                                    :subject => 'test_create', :estimated_hours => '1:30')
                  with_settings :notified_events => %w(issue_added) do
                    assert issue.save
                    assert_equal 1, ActionMailer::Base.deliveries.size
                  end
                end
                def test_create_should_send_one_email_notification_with_both_settings
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 3, :status_id => 1,
                                    :priority => IssuePriority.all.first,
                                    :subject => 'test_create', :estimated_hours => '1:30')
                  with_settings :notified_events => %w(issue_added issue_updated) do
                    assert issue.save
                    assert_equal 1, ActionMailer::Base.deliveries.size
                  end
                end
                def test_create_should_not_send_email_notification_with_no_setting
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.new(:project_id => 1, :tracker_id => 1,
                                    :author_id => 3, :status_id => 1,
                                    :priority => IssuePriority.all.first,
                                    :subject => 'test_create', :estimated_hours => '1:30')
                  with_settings :notified_events => [] do
                    assert issue.save
                    assert_equal 0, ActionMailer::Base.deliveries.size
                  end
                end
                def test_update_should_notify_previous_assignee
                  ActionMailer::Base.deliveries.clear
                  user = User.find(3)
                  user.members.update_all ["mail_notification = ?", false]
                  user.update_attribute :mail_notification, 'only_assigned'
                  with_settings :notified_events => %w(issue_updated) do
                    issue = Issue.find(2)
                    issue.init_journal User.find(1)
                    issue.assigned_to = nil
                    issue.save!
                    assert_include user.mail, ActionMailer::Base.deliveries.last.bcc
                  end
                end
                def test_stale_issue_should_not_send_email_notification
                  ActionMailer::Base.deliveries.clear
                  issue = Issue.find(1)
                  stale = Issue.find(1)
                  issue.init_journal(User.find(1))
                  issue.subject = 'Subjet update'
                  with_settings :notified_events => %w(issue_updated) do
                    assert issue.save
                    assert_equal 1, ActionMailer::Base.deliveries.size
                    ActionMailer::Base.deliveries.clear
                    stale.init_journal(User.find(1))
                    stale.subject = 'Another subjet update'
                    assert_raise ActiveRecord::StaleObjectError do
                      stale.save
                    end
                    assert ActionMailer::Base.deliveries.empty?
                  end
                end
                def test_journalized_description
                  IssueCustomField.delete_all
                  i = Issue.first
                  old_description = i.description
                  new_description = "This is the new description"
                  i.init_journal(User.find(2))
                  i.description = new_description
                  assert_difference 'Journal.count', 1 do
                    assert_difference 'JournalDetail.count', 1 do
                      i.save!
                    end
                  end
                  detail = JournalDetail.order('id DESC').first
                  assert_equal i, detail.journal.journalized
                  assert_equal 'attr', detail.property
                  assert_equal 'description', detail.prop_key
                  assert_equal old_description, detail.old_value
                  assert_equal new_description, detail.value
                end
                def test_blank_descriptions_should_not_be_journalized
                  IssueCustomField.delete_all
                  Issue.where(:id => 1).update_all("description = NULL")
                  i = Issue.find(1)
                  i.init_journal(User.find(2))
                  i.subject = "blank description"
                  i.description = "\r\n"
                  assert_difference 'Journal.count', 1 do
                    assert_difference 'JournalDetail.count', 1 do
                      i.save!
                    end
                  end
                end
                def test_journalized_multi_custom_field
                  field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
                                                   :is_filter => true, :is_for_all => true,
                                                   :tracker_ids => [1],
                                                   :possible_values => ['value1', 'value2', 'value3'],
                                                   :multiple => true)
                  issue = Issue.create!(:project_id => 1, :tracker_id => 1,
                                        :subject => 'Test', :author_id => 1)
                  assert_difference 'Journal.count' do
                    assert_difference 'JournalDetail.count' do
                      issue.init_journal(User.first)
                      issue.custom_field_values = {field.id => ['value1']}
                      issue.save!
                    end
                    assert_difference 'JournalDetail.count' do
                      issue.init_journal(User.first)
                      issue.custom_field_values = {field.id => ['value1', 'value2']}
                      issue.save!
                    end
                    assert_difference 'JournalDetail.count', 2 do
                      issue.init_journal(User.first)
                      issue.custom_field_values = {field.id => ['value3', 'value2']}
                      issue.save!
                    end
                    assert_difference 'JournalDetail.count', 2 do
                      issue.init_journal(User.first)
                      issue.custom_field_values = {field.id => nil}
                      issue.save!
                    end
                  end
                end
                def test_description_eol_should_be_normalized
                  i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
                  assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
                end
                def test_saving_twice_should_not_duplicate_journal_details
                  i = Issue.first
                  i.init_journal(User.find(2), 'Some notes')
                  # initial changes
                  i.subject = 'New subject'
                  i.done_ratio = i.done_ratio + 10
                  assert_difference 'Journal.count' do
                    assert i.save
                  end
                  # 1 more change
                  i.priority = IssuePriority.where("id <> ?", i.priority_id).first
                  assert_no_difference 'Journal.count' do
                    assert_difference 'JournalDetail.count', 1 do
                      i.save
                    end
                  end
                  # no more change
                  assert_no_difference 'Journal.count' do
                    assert_no_difference 'JournalDetail.count' do
                      i.save
                    end
                  end
                end
                def test_all_dependent_issues
                  IssueRelation.delete_all
                  assert IssueRelation.create!(:issue_from => Issue.find(1),
                                               :issue_to   => Issue.find(2),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert IssueRelation.create!(:issue_from => Issue.find(2),
                                               :issue_to   => Issue.find(3),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert IssueRelation.create!(:issue_from => Issue.find(3),
                                               :issue_to   => Issue.find(8),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
                end
                def test_all_dependent_issues_with_subtask
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue = Issue.generate!(:project => project)
                  childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  assert_equal [childIssue1.id, childIssue2.id].sort, parentIssue.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_does_not_include_self
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue = Issue.generate!(:project => project)
                  childIssue = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  assert_equal [childIssue.id], parentIssue.all_dependent_issues.collect(&:id)
                end
                def test_all_dependent_issues_with_parenttask_and_sibling
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue = Issue.generate!(:project => project)
                  childIssue1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  childIssue2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue.id)
                  assert_equal [parentIssue.id].sort, childIssue1.all_dependent_issues.collect(&:id)
                end
                def test_all_dependent_issues_with_relation_to_leaf_in_other_tree
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue1 = Issue.generate!(:project => project)
                  childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  parentIssue2 = Issue.generate!(:project => project)
                  childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  assert IssueRelation.create(:issue_from => parentIssue1,
                                              :issue_to   => childIssue2_2,
                                              :relation_type => IssueRelation::TYPE_BLOCKS)
                  assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_2.id].sort,
                               parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_with_relation_to_parent_in_other_tree
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue1 = Issue.generate!(:project => project)
                  childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  childIssue1_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  parentIssue2 = Issue.generate!(:project => project)
                  childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  childIssue2_2 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  assert IssueRelation.create(:issue_from => parentIssue1,
                                              :issue_to   => parentIssue2,
                                              :relation_type => IssueRelation::TYPE_BLOCKS)
                  assert_equal [childIssue1_1.id, childIssue1_2.id, parentIssue2.id, childIssue2_1.id, childIssue2_2.id].sort,
                               parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_with_transitive_relation
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue1 = Issue.generate!(:project => project)
                  childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  parentIssue2 = Issue.generate!(:project => project)
                  childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  independentIssue = Issue.generate!(:project => project)
                  assert IssueRelation.create(:issue_from => parentIssue1,
                                              :issue_to   => childIssue2_1,
                                              :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create(:issue_from => childIssue2_1,
                                              :issue_to   => independentIssue,
                                              :relation_type => IssueRelation::TYPE_RELATES)
                  assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
                               parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_with_transitive_relation2
                  IssueRelation.delete_all
                  project = Project.generate!(:name => "testproject")
                  parentIssue1 = Issue.generate!(:project => project)
                  childIssue1_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue1.id)
                  parentIssue2 = Issue.generate!(:project => project)
                  childIssue2_1 = Issue.generate!(:project => project, :parent_issue_id => parentIssue2.id)
                  independentIssue = Issue.generate!(:project => project)
                  assert IssueRelation.create(:issue_from => parentIssue1,
                                              :issue_to   => independentIssue,
                                              :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create(:issue_from => independentIssue,
                                              :issue_to   => childIssue2_1,
                                              :relation_type => IssueRelation::TYPE_RELATES)
                  assert_equal [childIssue1_1.id, parentIssue2.id, childIssue2_1.id, independentIssue.id].sort,
                               parentIssue1.all_dependent_issues.collect(&:id).uniq.sort
                end
                def test_all_dependent_issues_with_persistent_circular_dependency
                  IssueRelation.delete_all
                  assert IssueRelation.create!(:issue_from => Issue.find(1),
                                               :issue_to   => Issue.find(2),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  assert IssueRelation.create!(:issue_from => Issue.find(2),
                                               :issue_to   => Issue.find(3),
                                               :relation_type => IssueRelation::TYPE_PRECEDES)
                  r = IssueRelation.create!(:issue_from => Issue.find(3),
                                           :issue_to   => Issue.find(7),
                                           :relation_type => IssueRelation::TYPE_PRECEDES)
                  IssueRelation.where(["id = ?", r.id]).update_all("issue_to_id = 1")
                  assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
                end
                def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
                  IssueRelation.delete_all
                  assert IssueRelation.create!(:issue_from => Issue.find(1),
                                               :issue_to   => Issue.find(2),
                                               :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create!(:issue_from => Issue.find(2),
                                               :issue_to   => Issue.find(3),
                                               :relation_type => IssueRelation::TYPE_RELATES)
                  assert IssueRelation.create!(:issue_from => Issue.find(3),
                                               :issue_to   => Issue.find(8),
                                               :relation_type => IssueRelation::TYPE_RELATES)
                  r = IssueRelation.create!(:issue_from => Issue.find(8),
                                           :issue_to   => Issue.find(7),
                                           :relation_type => IssueRelation::TYPE_RELATES)
                  IssueRelation.where(["id = ?", r.id]).update_all("issue_to_id = 2")
                  r = IssueRelation.create!(:issue_from => Issue.find(3),
                                           :issue_to   => Issue.find(7),
                                           :relation_type => IssueRelation::TYPE_RELATES)
                  IssueRelation.where(["id = ?", r.id]).update_all("issue_to_id = 1")
                  assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
                end
                test "#done_ratio should use the issue_status according to Setting.issue_done_ratio" do
                  @issue = Issue.find(1)
                  @issue_status = IssueStatus.find(1)
                  @issue_status.update_attribute(:default_done_ratio, 50)
                  @issue2 = Issue.find(2)
                  @issue_status2 = IssueStatus.find(2)
                  @issue_status2.update_attribute(:default_done_ratio, 0)
                  with_settings :issue_done_ratio => 'issue_field' do
                    assert_equal 0, @issue.done_ratio
                    assert_equal 30, @issue2.done_ratio
                  end
                  with_settings :issue_done_ratio => 'issue_status' do
                    assert_equal 50, @issue.done_ratio
                    assert_equal 0, @issue2.done_ratio
                  end
                end
                test "#update_done_ratio_from_issue_status should update done_ratio according to Setting.issue_done_ratio" do
                  @issue = Issue.find(1)
                  @issue_status = IssueStatus.find(1)
                  @issue_status.update_attribute(:default_done_ratio, 50)
                  @issue2 = Issue.find(2)
                  @issue_status2 = IssueStatus.find(2)
                  @issue_status2.update_attribute(:default_done_ratio, 0)
                  with_settings :issue_done_ratio => 'issue_field' do
                    @issue.update_done_ratio_from_issue_status
                    @issue2.update_done_ratio_from_issue_status
                    assert_equal 0, @issue.read_attribute(:done_ratio)
                    assert_equal 30, @issue2.read_attribute(:done_ratio)
                  end
                  with_settings :issue_done_ratio => 'issue_status' do
                    @issue.update_done_ratio_from_issue_status
                    @issue2.update_done_ratio_from_issue_status
                    assert_equal 50, @issue.read_attribute(:done_ratio)
                    assert_equal 0, @issue2.read_attribute(:done_ratio)
                  end
                end
                test "#by_tracker" do
                  User.current = User.anonymous
                  groups = Issue.by_tracker(Project.find(1))
                  assert_equal 3, groups.count
                  assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_version" do
                  User.current = User.anonymous
                  groups = Issue.by_version(Project.find(1))
                  assert_equal 3, groups.count
                  assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_priority" do
                  User.current = User.anonymous
                  groups = Issue.by_priority(Project.find(1))
                  assert_equal 4, groups.count
                  assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_category" do
                  User.current = User.anonymous
                  groups = Issue.by_category(Project.find(1))
                  assert_equal 2, groups.count
                  assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_assigned_to" do
                  User.current = User.anonymous
                  groups = Issue.by_assigned_to(Project.find(1))
                  assert_equal 2, groups.count
                  assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_author" do
                  User.current = User.anonymous
                  groups = Issue.by_author(Project.find(1))
                  assert_equal 4, groups.count
                  assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                test "#by_subproject" do
                  User.current = User.anonymous
                  groups = Issue.by_subproject(Project.find(1))
                  # Private descendant not visible
                  assert_equal 1, groups.count
                  assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
                end
                def test_recently_updated_scope
                  #should return the last updated issue
                  assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
                end
                def test_on_active_projects_scope
                  assert Project.find(2).archive
                  before = Issue.on_active_project.length
                  # test inclusion to results
                  issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
                  assert_equal before + 1, Issue.on_active_project.length
                  # Move to an archived project
                  issue.project = Project.find(2)
                  assert issue.save
                  assert_equal before, Issue.on_active_project.length
                end
                test "Issue#recipients should include project recipients" do
                  issue = Issue.generate!
                  assert issue.project.recipients.present?
                  issue.project.recipients.each do |project_recipient|
                    assert issue.recipients.include?(project_recipient)
                  end
                end
                test "Issue#recipients should include the author if the author is active" do
                  issue = Issue.generate!(:author => User.generate!)
                  assert issue.author, "No author set for Issue"
                  assert issue.recipients.include?(issue.author.mail)
                end
                test "Issue#recipients should include the assigned to user if the assigned to user is active" do
                  issue = Issue.generate!(:assigned_to => User.generate!)
                  assert issue.assigned_to, "No assigned_to set for Issue"
                  assert issue.recipients.include?(issue.assigned_to.mail)
                end
                test "Issue#recipients should not include users who opt out of all email" do
                  issue = Issue.generate!(:author => User.generate!)
                  issue.author.update_attribute(:mail_notification, :none)
                  assert !issue.recipients.include?(issue.author.mail)
                end
                test "Issue#recipients should not include the issue author if they are only notified of assigned issues" do
                  issue = Issue.generate!(:author => User.generate!)
                  issue.author.update_attribute(:mail_notification, :only_assigned)
                  assert !issue.recipients.include?(issue.author.mail)
                end
                test "Issue#recipients should not include the assigned user if they are only notified of owned issues" do
                  issue = Issue.generate!(:assigned_to => User.generate!)
                  issue.assigned_to.update_attribute(:mail_notification, :only_owner)
                  assert !issue.recipients.include?(issue.assigned_to.mail)
                end
                def test_last_journal_id_with_journals_should_return_the_journal_id
                  assert_equal 2, Issue.find(1).last_journal_id
                end
                def test_last_journal_id_without_journals_should_return_nil
                  assert_nil Issue.find(3).last_journal_id
                end
                def test_journals_after_should_return_journals_with_greater_id
                  assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
                  assert_equal [], Issue.find(1).journals_after('2')
                end
                def test_journals_after_with_blank_arg_should_return_all_journals
                  assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
                end
                def test_css_classes_should_include_tracker
                  issue = Issue.new(:tracker => Tracker.find(2))
                  classes = issue.css_classes.split(' ')
                  assert_include 'tracker-2', classes
                end
                def test_css_classes_should_include_priority
                  issue = Issue.new(:priority => IssuePriority.find(8))
                  classes = issue.css_classes.split(' ')
                  assert_include 'priority-8', classes
                  assert_include 'priority-highest', classes
                end
                def test_css_classes_should_include_user_and_group_assignment
                  project = Project.first
                  user = User.generate!
                  group = Group.generate!
                  Member.create!(:principal => group, :project => project, :role_ids => [1, 2])
                  group.users << user
                  assert user.member_of?(project)
                  issue1 = Issue.generate(:assigned_to_id => group.id)
                  assert_include 'assigned-to-my-group', issue1.css_classes(user)
                  assert_not_include 'assigned-to-me', issue1.css_classes(user)
                  issue2 = Issue.generate(:assigned_to_id => user.id)
                  assert_not_include 'assigned-to-my-group', issue2.css_classes(user)
                  assert_include 'assigned-to-me', issue2.css_classes(user)
                end
                def test_save_attachments_with_hash_should_save_attachments_in_keys_order
                  set_tmp_attachments_directory
                  issue = Issue.generate!
                  issue.save_attachments({
                    'p0' => {'file' => mock_file_with_options(:original_filename => 'upload')},
                    '3' => {'file' => mock_file_with_options(:original_filename => 'bar')},
                    '1' => {'file' => mock_file_with_options(:original_filename => 'foo')}
                  })
                  issue.attach_saved_attachments
                  assert_equal 3, issue.reload.attachments.count
                  assert_equal %w(upload foo bar), issue.attachments.map(&:filename)
                end
                def test_closed_on_should_be_nil_when_creating_an_open_issue
                  issue = Issue.generate!(:status_id => 1).reload
                  assert !issue.closed?
                  assert_nil issue.closed_on
                end
                def test_closed_on_should_be_set_when_creating_a_closed_issue
                  issue = Issue.generate!(:status_id => 5).reload
                  assert issue.closed?
                  assert_not_nil issue.closed_on
                  assert_equal issue.updated_on, issue.closed_on
                  assert_equal issue.created_on, issue.closed_on
                end
                def test_closed_on_should_be_nil_when_updating_an_open_issue
                  issue = Issue.find(1)
                  issue.subject = 'Not closed yet'
                  issue.save!
                  issue.reload
                  assert_nil issue.closed_on
                end
                def test_closed_on_should_be_set_when_closing_an_open_issue
                  issue = Issue.find(1)
                  issue.subject = 'Now closed'
                  issue.status_id = 5
                  issue.save!
                  issue.reload
                  assert_not_nil issue.closed_on
                  assert_equal issue.updated_on, issue.closed_on
                end
                def test_closed_on_should_not_be_updated_when_updating_a_closed_issue
                  issue = Issue.open(false).first
                  was_closed_on = issue.closed_on
                  assert_not_nil was_closed_on
                  issue.subject = 'Updating a closed issue'
                  issue.save!
                  issue.reload
                  assert_equal was_closed_on, issue.closed_on
                end
                def test_closed_on_should_be_preserved_when_reopening_a_closed_issue
                  issue = Issue.open(false).first
                  was_closed_on = issue.closed_on
                  assert_not_nil was_closed_on
                  issue.subject = 'Reopening a closed issue'
                  issue.status_id = 1
                  issue.save!
                  issue.reload
                  assert !issue.closed?
                  assert_equal was_closed_on, issue.closed_on
                end
                def test_status_was_should_return_nil_for_new_issue
                  issue = Issue.new
                  assert_nil issue.status_was
                end
                def test_status_was_should_return_status_before_change
                  issue = Issue.find(1)
                  issue.status = IssueStatus.find(2)
                  assert_equal IssueStatus.find(1), issue.status_was
                end
                def test_status_was_should_return_status_before_change_with_status_id
                  issue = Issue.find(1)
                  assert_equal IssueStatus.find(1), issue.status
                  issue.status_id = 2
                  assert_equal IssueStatus.find(1), issue.status_was
                end
                def test_status_was_should_be_reset_on_save
                  issue = Issue.find(1)
                  issue.status = IssueStatus.find(2)
                  assert_equal IssueStatus.find(1), issue.status_was
                  assert issue.save!
                  assert_equal IssueStatus.find(2), issue.status_was
                end
                def test_closing_should_return_true_when_closing_an_issue
                  issue = Issue.find(1)
                  issue.status = IssueStatus.find(2)
                  assert_equal false, issue.closing?
                  issue.status = IssueStatus.find(5)
                  assert_equal true, issue.closing?
                end
                def test_closing_should_return_true_when_closing_an_issue_with_status_id
                  issue = Issue.find(1)
                  issue.status_id = 2
                  assert_equal false, issue.closing?
                  issue.status_id = 5
                  assert_equal true, issue.closing?
                end
                def test_closing_should_return_true_for_new_closed_issue
                  issue = Issue.new
                  assert_equal false, issue.closing?
                  issue.status = IssueStatus.find(5)
                  assert_equal true, issue.closing?
                end
                def test_closing_should_return_true_for_new_closed_issue_with_status_id
                  issue = Issue.new
                  assert_equal false, issue.closing?
                  issue.status_id = 5
                  assert_equal true, issue.closing?
                end
                def test_closing_should_be_reset_after_save
                  issue = Issue.find(1)
                  issue.status_id = 5
                  assert_equal true, issue.closing?
                  issue.save!
                  assert_equal false, issue.closing?
                end
                def test_reopening_should_return_true_when_reopening_an_issue
                  issue = Issue.find(8)
                  issue.status = IssueStatus.find(6)
                  assert_equal false, issue.reopening?
                  issue.status = IssueStatus.find(2)
                  assert_equal true, issue.reopening?
                end
                def test_reopening_should_return_true_when_reopening_an_issue_with_status_id
                  issue = Issue.find(8)
                  issue.status_id = 6
                  assert_equal false, issue.reopening?
                  issue.status_id = 2
                  assert_equal true, issue.reopening?
                end
                def test_reopening_should_return_false_for_new_open_issue
                  issue = Issue.new
                  issue.status = IssueStatus.find(1)
                  assert_equal false, issue.reopening?
                end
                def test_reopening_should_be_reset_after_save
                  issue = Issue.find(8)
                  issue.status_id = 2
                  assert_equal true, issue.reopening?
                  issue.save!
                  assert_equal false, issue.reopening?
                end
                def test_default_status_without_tracker_should_be_nil
                  issue = Issue.new
                  assert_nil issue.tracker
                  assert_nil issue.default_status
                end
                def test_default_status_should_be_tracker_default_status
                  issue = Issue.new(:tracker_id => 1)
                  assert_not_nil issue.status
                  assert_equal issue.tracker.default_status, issue.default_status
                end
                def test_initializing_with_tracker_should_set_default_status
                  issue = Issue.new(:tracker => Tracker.find(1))
                  assert_not_nil issue.status
                  assert_equal issue.default_status, issue.status
                end
                def test_initializing_with_tracker_id_should_set_default_status
                  issue = Issue.new(:tracker_id => 1)
                  assert_not_nil issue.status
                  assert_equal issue.default_status, issue.status
                end
                def test_setting_tracker_should_set_default_status
                  issue = Issue.new
                  issue.tracker = Tracker.find(1)
                  assert_not_nil issue.status
                  assert_equal issue.default_status, issue.status
                end
                def test_changing_tracker_should_set_default_status_if_status_was_default
                  WorkflowTransition.delete_all
                  WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1
                  Tracker.find(2).update! :default_status_id => 2
                  issue = Issue.new(:tracker_id => 1, :status_id => 1)
                  assert_equal IssueStatus.find(1), issue.status
                  issue.tracker = Tracker.find(2)
                  assert_equal IssueStatus.find(2), issue.status
                end
                def test_changing_tracker_should_set_default_status_if_status_is_not_used_by_tracker
                  WorkflowTransition.delete_all
                  Tracker.find(2).update! :default_status_id => 2
                  issue = Issue.new(:tracker_id => 1, :status_id => 3)
                  assert_equal IssueStatus.find(3), issue.status
                  issue.tracker = Tracker.find(2)
                  assert_equal IssueStatus.find(2), issue.status
                end
                def test_changing_tracker_should_keep_status_if_status_was_not_default_and_is_used_by_tracker
                  WorkflowTransition.delete_all
                  WorkflowTransition.create! :role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3
                  Tracker.find(2).update! :default_status_id => 2
                  issue = Issue.new(:tracker_id => 1, :status_id => 3)
                  assert_equal IssueStatus.find(3), issue.status
                  issue.tracker = Tracker.find(2)
                  assert_equal IssueStatus.find(3), issue.status
                end
                def test_assigned_to_was_with_a_group
                  group = Group.find(10)
                  issue = Issue.generate!(:assigned_to => group)
                  issue.reload.assigned_to = nil
                  assert_equal group, issue.assigned_to_was
                end
              end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages