@@ -1,265 +1,288 | |||||
1 | # Redmine - project management software |
|
1 | # Redmine - project management software | |
2 | # Copyright (C) 2006-2014 Jean-Philippe Lang |
|
2 | # Copyright (C) 2006-2014 Jean-Philippe Lang | |
3 | # |
|
3 | # | |
4 | # This program is free software; you can redistribute it and/or |
|
4 | # This program is free software; you can redistribute it and/or | |
5 | # modify it under the terms of the GNU General Public License |
|
5 | # modify it under the terms of the GNU General Public License | |
6 | # as published by the Free Software Foundation; either version 2 |
|
6 | # as published by the Free Software Foundation; either version 2 | |
7 | # of the License, or (at your option) any later version. |
|
7 | # of the License, or (at your option) any later version. | |
8 | # |
|
8 | # | |
9 | # This program is distributed in the hope that it will be useful, |
|
9 | # This program is distributed in the hope that it will be useful, | |
10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of |
|
10 | # but WITHOUT ANY WARRANTY; without even the implied warranty of | |
11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
|
11 | # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
12 | # GNU General Public License for more details. |
|
12 | # GNU General Public License for more details. | |
13 | # |
|
13 | # | |
14 | # You should have received a copy of the GNU General Public License |
|
14 | # You should have received a copy of the GNU General Public License | |
15 | # along with this program; if not, write to the Free Software |
|
15 | # along with this program; if not, write to the Free Software | |
16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. |
|
16 | # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. | |
17 |
|
17 | |||
18 | require File.expand_path('../../test_helper', __FILE__) |
|
18 | require File.expand_path('../../test_helper', __FILE__) | |
19 |
|
19 | |||
20 | class SearchControllerTest < ActionController::TestCase |
|
20 | class SearchControllerTest < ActionController::TestCase | |
21 | fixtures :projects, :enabled_modules, :roles, :users, :members, :member_roles, |
|
21 | fixtures :projects, :enabled_modules, :roles, :users, :members, :member_roles, | |
22 | :issues, :trackers, :issue_statuses, :enumerations, |
|
22 | :issues, :trackers, :issue_statuses, :enumerations, | |
23 | :custom_fields, :custom_values, |
|
23 | :custom_fields, :custom_values, | |
24 | :custom_fields_projects, :custom_fields_trackers, |
|
24 | :custom_fields_projects, :custom_fields_trackers, | |
25 | :repositories, :changesets |
|
25 | :repositories, :changesets | |
26 |
|
26 | |||
27 | def setup |
|
27 | def setup | |
28 | User.current = nil |
|
28 | User.current = nil | |
29 | end |
|
29 | end | |
30 |
|
30 | |||
31 | def test_search_for_projects |
|
31 | def test_search_for_projects | |
32 | get :index |
|
32 | get :index | |
33 | assert_response :success |
|
33 | assert_response :success | |
34 | assert_template 'index' |
|
34 | assert_template 'index' | |
35 |
|
35 | |||
36 | get :index, :q => "cook" |
|
36 | get :index, :q => "cook" | |
37 | assert_response :success |
|
37 | assert_response :success | |
38 | assert_template 'index' |
|
38 | assert_template 'index' | |
39 | assert assigns(:results).include?(Project.find(1)) |
|
39 | assert assigns(:results).include?(Project.find(1)) | |
40 | end |
|
40 | end | |
41 |
|
41 | |||
|
42 | def test_search_on_archived_project_should_return_404 | |||
|
43 | Project.find(3).archive | |||
|
44 | get :index, :id => 3 | |||
|
45 | assert_response 404 | |||
|
46 | end | |||
|
47 | ||||
|
48 | def test_search_on_invisible_project_by_user_should_be_denied | |||
|
49 | @request.session[:user_id] = 7 | |||
|
50 | get :index, :id => 2 | |||
|
51 | assert_response 403 | |||
|
52 | end | |||
|
53 | ||||
|
54 | def test_search_on_invisible_project_by_anonymous_user_should_redirect | |||
|
55 | get :index, :id => 2 | |||
|
56 | assert_response 302 | |||
|
57 | end | |||
|
58 | ||||
|
59 | def test_search_on_private_project_by_member_should_succeed | |||
|
60 | @request.session[:user_id] = 2 | |||
|
61 | get :index, :id => 2 | |||
|
62 | assert_response :success | |||
|
63 | end | |||
|
64 | ||||
42 | def test_search_all_projects |
|
65 | def test_search_all_projects | |
43 | with_settings :default_language => 'en' do |
|
66 | with_settings :default_language => 'en' do | |
44 | get :index, :q => 'recipe subproject commit', :all_words => '' |
|
67 | get :index, :q => 'recipe subproject commit', :all_words => '' | |
45 | end |
|
68 | end | |
46 | assert_response :success |
|
69 | assert_response :success | |
47 | assert_template 'index' |
|
70 | assert_template 'index' | |
48 |
|
71 | |||
49 | assert assigns(:results).include?(Issue.find(2)) |
|
72 | assert assigns(:results).include?(Issue.find(2)) | |
50 | assert assigns(:results).include?(Issue.find(5)) |
|
73 | assert assigns(:results).include?(Issue.find(5)) | |
51 | assert assigns(:results).include?(Changeset.find(101)) |
|
74 | assert assigns(:results).include?(Changeset.find(101)) | |
52 | assert_select 'dt.issue a', :text => /Add ingredients categories/ |
|
75 | assert_select 'dt.issue a', :text => /Add ingredients categories/ | |
53 | assert_select 'dd', :text => /should be classified by categories/ |
|
76 | assert_select 'dd', :text => /should be classified by categories/ | |
54 |
|
77 | |||
55 | assert assigns(:results_by_type).is_a?(Hash) |
|
78 | assert assigns(:results_by_type).is_a?(Hash) | |
56 | assert_equal 5, assigns(:results_by_type)['changesets'] |
|
79 | assert_equal 5, assigns(:results_by_type)['changesets'] | |
57 | assert_select 'a', :text => 'Changesets (5)' |
|
80 | assert_select 'a', :text => 'Changesets (5)' | |
58 | end |
|
81 | end | |
59 |
|
82 | |||
60 | def test_search_issues |
|
83 | def test_search_issues | |
61 | get :index, :q => 'issue', :issues => 1 |
|
84 | get :index, :q => 'issue', :issues => 1 | |
62 | assert_response :success |
|
85 | assert_response :success | |
63 | assert_template 'index' |
|
86 | assert_template 'index' | |
64 |
|
87 | |||
65 | assert_equal true, assigns(:all_words) |
|
88 | assert_equal true, assigns(:all_words) | |
66 | assert_equal false, assigns(:titles_only) |
|
89 | assert_equal false, assigns(:titles_only) | |
67 | assert assigns(:results).include?(Issue.find(8)) |
|
90 | assert assigns(:results).include?(Issue.find(8)) | |
68 | assert assigns(:results).include?(Issue.find(5)) |
|
91 | assert assigns(:results).include?(Issue.find(5)) | |
69 | assert_select 'dt.issue.closed a', :text => /Closed/ |
|
92 | assert_select 'dt.issue.closed a', :text => /Closed/ | |
70 | end |
|
93 | end | |
71 |
|
94 | |||
72 | def test_search_issues_should_search_notes |
|
95 | def test_search_issues_should_search_notes | |
73 | Journal.create!(:journalized => Issue.find(2), :notes => 'Issue notes with searchkeyword') |
|
96 | Journal.create!(:journalized => Issue.find(2), :notes => 'Issue notes with searchkeyword') | |
74 |
|
97 | |||
75 | get :index, :q => 'searchkeyword', :issues => 1 |
|
98 | get :index, :q => 'searchkeyword', :issues => 1 | |
76 | assert_response :success |
|
99 | assert_response :success | |
77 | assert_include Issue.find(2), assigns(:results) |
|
100 | assert_include Issue.find(2), assigns(:results) | |
78 | end |
|
101 | end | |
79 |
|
102 | |||
80 | def test_search_issues_with_multiple_matches_in_journals_should_return_issue_once |
|
103 | def test_search_issues_with_multiple_matches_in_journals_should_return_issue_once | |
81 | Journal.create!(:journalized => Issue.find(2), :notes => 'Issue notes with searchkeyword') |
|
104 | Journal.create!(:journalized => Issue.find(2), :notes => 'Issue notes with searchkeyword') | |
82 | Journal.create!(:journalized => Issue.find(2), :notes => 'Issue notes with searchkeyword') |
|
105 | Journal.create!(:journalized => Issue.find(2), :notes => 'Issue notes with searchkeyword') | |
83 |
|
106 | |||
84 | get :index, :q => 'searchkeyword', :issues => 1 |
|
107 | get :index, :q => 'searchkeyword', :issues => 1 | |
85 | assert_response :success |
|
108 | assert_response :success | |
86 | assert_include Issue.find(2), assigns(:results) |
|
109 | assert_include Issue.find(2), assigns(:results) | |
87 | assert_equal 1, assigns(:results).size |
|
110 | assert_equal 1, assigns(:results).size | |
88 | end |
|
111 | end | |
89 |
|
112 | |||
90 | def test_search_issues_should_search_private_notes_with_permission_only |
|
113 | def test_search_issues_should_search_private_notes_with_permission_only | |
91 | Journal.create!(:journalized => Issue.find(2), :notes => 'Private notes with searchkeyword', :private_notes => true) |
|
114 | Journal.create!(:journalized => Issue.find(2), :notes => 'Private notes with searchkeyword', :private_notes => true) | |
92 | @request.session[:user_id] = 2 |
|
115 | @request.session[:user_id] = 2 | |
93 |
|
116 | |||
94 | Role.find(1).add_permission! :view_private_notes |
|
117 | Role.find(1).add_permission! :view_private_notes | |
95 | get :index, :q => 'searchkeyword', :issues => 1 |
|
118 | get :index, :q => 'searchkeyword', :issues => 1 | |
96 | assert_response :success |
|
119 | assert_response :success | |
97 | assert_include Issue.find(2), assigns(:results) |
|
120 | assert_include Issue.find(2), assigns(:results) | |
98 |
|
121 | |||
99 | Role.find(1).remove_permission! :view_private_notes |
|
122 | Role.find(1).remove_permission! :view_private_notes | |
100 | get :index, :q => 'searchkeyword', :issues => 1 |
|
123 | get :index, :q => 'searchkeyword', :issues => 1 | |
101 | assert_response :success |
|
124 | assert_response :success | |
102 | assert_not_include Issue.find(2), assigns(:results) |
|
125 | assert_not_include Issue.find(2), assigns(:results) | |
103 | end |
|
126 | end | |
104 |
|
127 | |||
105 | def test_search_all_projects_with_scope_param |
|
128 | def test_search_all_projects_with_scope_param | |
106 | get :index, :q => 'issue', :scope => 'all' |
|
129 | get :index, :q => 'issue', :scope => 'all' | |
107 | assert_response :success |
|
130 | assert_response :success | |
108 | assert_template 'index' |
|
131 | assert_template 'index' | |
109 | assert assigns(:results).present? |
|
132 | assert assigns(:results).present? | |
110 | end |
|
133 | end | |
111 |
|
134 | |||
112 | def test_search_my_projects |
|
135 | def test_search_my_projects | |
113 | @request.session[:user_id] = 2 |
|
136 | @request.session[:user_id] = 2 | |
114 | get :index, :id => 1, :q => 'recipe subproject', :scope => 'my_projects', :all_words => '' |
|
137 | get :index, :id => 1, :q => 'recipe subproject', :scope => 'my_projects', :all_words => '' | |
115 | assert_response :success |
|
138 | assert_response :success | |
116 | assert_template 'index' |
|
139 | assert_template 'index' | |
117 | assert assigns(:results).include?(Issue.find(1)) |
|
140 | assert assigns(:results).include?(Issue.find(1)) | |
118 | assert !assigns(:results).include?(Issue.find(5)) |
|
141 | assert !assigns(:results).include?(Issue.find(5)) | |
119 | end |
|
142 | end | |
120 |
|
143 | |||
121 | def test_search_my_projects_without_memberships |
|
144 | def test_search_my_projects_without_memberships | |
122 | # anonymous user has no memberships |
|
145 | # anonymous user has no memberships | |
123 | get :index, :id => 1, :q => 'recipe subproject', :scope => 'my_projects', :all_words => '' |
|
146 | get :index, :id => 1, :q => 'recipe subproject', :scope => 'my_projects', :all_words => '' | |
124 | assert_response :success |
|
147 | assert_response :success | |
125 | assert_template 'index' |
|
148 | assert_template 'index' | |
126 | assert assigns(:results).empty? |
|
149 | assert assigns(:results).empty? | |
127 | end |
|
150 | end | |
128 |
|
151 | |||
129 | def test_search_project_and_subprojects |
|
152 | def test_search_project_and_subprojects | |
130 | get :index, :id => 1, :q => 'recipe subproject', :scope => 'subprojects', :all_words => '' |
|
153 | get :index, :id => 1, :q => 'recipe subproject', :scope => 'subprojects', :all_words => '' | |
131 | assert_response :success |
|
154 | assert_response :success | |
132 | assert_template 'index' |
|
155 | assert_template 'index' | |
133 | assert assigns(:results).include?(Issue.find(1)) |
|
156 | assert assigns(:results).include?(Issue.find(1)) | |
134 | assert assigns(:results).include?(Issue.find(5)) |
|
157 | assert assigns(:results).include?(Issue.find(5)) | |
135 | end |
|
158 | end | |
136 |
|
159 | |||
137 | def test_search_without_searchable_custom_fields |
|
160 | def test_search_without_searchable_custom_fields | |
138 | CustomField.update_all "searchable = #{ActiveRecord::Base.connection.quoted_false}" |
|
161 | CustomField.update_all "searchable = #{ActiveRecord::Base.connection.quoted_false}" | |
139 |
|
162 | |||
140 | get :index, :id => 1 |
|
163 | get :index, :id => 1 | |
141 | assert_response :success |
|
164 | assert_response :success | |
142 | assert_template 'index' |
|
165 | assert_template 'index' | |
143 | assert_not_nil assigns(:project) |
|
166 | assert_not_nil assigns(:project) | |
144 |
|
167 | |||
145 | get :index, :id => 1, :q => "can" |
|
168 | get :index, :id => 1, :q => "can" | |
146 | assert_response :success |
|
169 | assert_response :success | |
147 | assert_template 'index' |
|
170 | assert_template 'index' | |
148 | end |
|
171 | end | |
149 |
|
172 | |||
150 | def test_search_with_searchable_custom_fields |
|
173 | def test_search_with_searchable_custom_fields | |
151 | get :index, :id => 1, :q => "stringforcustomfield" |
|
174 | get :index, :id => 1, :q => "stringforcustomfield" | |
152 | assert_response :success |
|
175 | assert_response :success | |
153 | results = assigns(:results) |
|
176 | results = assigns(:results) | |
154 | assert_not_nil results |
|
177 | assert_not_nil results | |
155 | assert_equal 1, results.size |
|
178 | assert_equal 1, results.size | |
156 | assert results.include?(Issue.find(7)) |
|
179 | assert results.include?(Issue.find(7)) | |
157 | end |
|
180 | end | |
158 |
|
181 | |||
159 | def test_search_all_words |
|
182 | def test_search_all_words | |
160 | # 'all words' is on by default |
|
183 | # 'all words' is on by default | |
161 | get :index, :id => 1, :q => 'recipe updating saving', :all_words => '1' |
|
184 | get :index, :id => 1, :q => 'recipe updating saving', :all_words => '1' | |
162 | assert_equal true, assigns(:all_words) |
|
185 | assert_equal true, assigns(:all_words) | |
163 | results = assigns(:results) |
|
186 | results = assigns(:results) | |
164 | assert_not_nil results |
|
187 | assert_not_nil results | |
165 | assert_equal 1, results.size |
|
188 | assert_equal 1, results.size | |
166 | assert results.include?(Issue.find(3)) |
|
189 | assert results.include?(Issue.find(3)) | |
167 | end |
|
190 | end | |
168 |
|
191 | |||
169 | def test_search_one_of_the_words |
|
192 | def test_search_one_of_the_words | |
170 | get :index, :id => 1, :q => 'recipe updating saving', :all_words => '' |
|
193 | get :index, :id => 1, :q => 'recipe updating saving', :all_words => '' | |
171 | assert_equal false, assigns(:all_words) |
|
194 | assert_equal false, assigns(:all_words) | |
172 | results = assigns(:results) |
|
195 | results = assigns(:results) | |
173 | assert_not_nil results |
|
196 | assert_not_nil results | |
174 | assert_equal 3, results.size |
|
197 | assert_equal 3, results.size | |
175 | assert results.include?(Issue.find(3)) |
|
198 | assert results.include?(Issue.find(3)) | |
176 | end |
|
199 | end | |
177 |
|
200 | |||
178 | def test_search_titles_only_without_result |
|
201 | def test_search_titles_only_without_result | |
179 | get :index, :id => 1, :q => 'recipe updating saving', :titles_only => '1' |
|
202 | get :index, :id => 1, :q => 'recipe updating saving', :titles_only => '1' | |
180 | results = assigns(:results) |
|
203 | results = assigns(:results) | |
181 | assert_not_nil results |
|
204 | assert_not_nil results | |
182 | assert_equal 0, results.size |
|
205 | assert_equal 0, results.size | |
183 | end |
|
206 | end | |
184 |
|
207 | |||
185 | def test_search_titles_only |
|
208 | def test_search_titles_only | |
186 | get :index, :id => 1, :q => 'recipe', :titles_only => '1' |
|
209 | get :index, :id => 1, :q => 'recipe', :titles_only => '1' | |
187 | assert_equal true, assigns(:titles_only) |
|
210 | assert_equal true, assigns(:titles_only) | |
188 | results = assigns(:results) |
|
211 | results = assigns(:results) | |
189 | assert_not_nil results |
|
212 | assert_not_nil results | |
190 | assert_equal 2, results.size |
|
213 | assert_equal 2, results.size | |
191 | end |
|
214 | end | |
192 |
|
215 | |||
193 | def test_search_content |
|
216 | def test_search_content | |
194 | Issue.where(:id => 1).update_all("description = 'This is a searchkeywordinthecontent'") |
|
217 | Issue.where(:id => 1).update_all("description = 'This is a searchkeywordinthecontent'") | |
195 | get :index, :id => 1, :q => 'searchkeywordinthecontent', :titles_only => '' |
|
218 | get :index, :id => 1, :q => 'searchkeywordinthecontent', :titles_only => '' | |
196 | assert_equal false, assigns(:titles_only) |
|
219 | assert_equal false, assigns(:titles_only) | |
197 | results = assigns(:results) |
|
220 | results = assigns(:results) | |
198 | assert_not_nil results |
|
221 | assert_not_nil results | |
199 | assert_equal 1, results.size |
|
222 | assert_equal 1, results.size | |
200 | end |
|
223 | end | |
201 |
|
224 | |||
202 | def test_search_with_offset |
|
225 | def test_search_with_offset | |
203 | get :index, :q => 'coo', :offset => '20080806073000' |
|
226 | get :index, :q => 'coo', :offset => '20080806073000' | |
204 | assert_response :success |
|
227 | assert_response :success | |
205 | results = assigns(:results) |
|
228 | results = assigns(:results) | |
206 | assert results.any? |
|
229 | assert results.any? | |
207 | assert results.map(&:event_datetime).max < '20080806T073000'.to_time |
|
230 | assert results.map(&:event_datetime).max < '20080806T073000'.to_time | |
208 | end |
|
231 | end | |
209 |
|
232 | |||
210 | def test_search_previous_with_offset |
|
233 | def test_search_previous_with_offset | |
211 | get :index, :q => 'coo', :offset => '20080806073000', :previous => '1' |
|
234 | get :index, :q => 'coo', :offset => '20080806073000', :previous => '1' | |
212 | assert_response :success |
|
235 | assert_response :success | |
213 | results = assigns(:results) |
|
236 | results = assigns(:results) | |
214 | assert results.any? |
|
237 | assert results.any? | |
215 | assert results.map(&:event_datetime).min >= '20080806T073000'.to_time |
|
238 | assert results.map(&:event_datetime).min >= '20080806T073000'.to_time | |
216 | end |
|
239 | end | |
217 |
|
240 | |||
218 | def test_search_with_invalid_project_id |
|
241 | def test_search_with_invalid_project_id | |
219 | get :index, :id => 195, :q => 'recipe' |
|
242 | get :index, :id => 195, :q => 'recipe' | |
220 | assert_response 404 |
|
243 | assert_response 404 | |
221 | assert_nil assigns(:results) |
|
244 | assert_nil assigns(:results) | |
222 | end |
|
245 | end | |
223 |
|
246 | |||
224 | def test_quick_jump_to_issue |
|
247 | def test_quick_jump_to_issue | |
225 | # issue of a public project |
|
248 | # issue of a public project | |
226 | get :index, :q => "3" |
|
249 | get :index, :q => "3" | |
227 | assert_redirected_to '/issues/3' |
|
250 | assert_redirected_to '/issues/3' | |
228 |
|
251 | |||
229 | # issue of a private project |
|
252 | # issue of a private project | |
230 | get :index, :q => "4" |
|
253 | get :index, :q => "4" | |
231 | assert_response :success |
|
254 | assert_response :success | |
232 | assert_template 'index' |
|
255 | assert_template 'index' | |
233 | end |
|
256 | end | |
234 |
|
257 | |||
235 | def test_large_integer |
|
258 | def test_large_integer | |
236 | get :index, :q => '4615713488' |
|
259 | get :index, :q => '4615713488' | |
237 | assert_response :success |
|
260 | assert_response :success | |
238 | assert_template 'index' |
|
261 | assert_template 'index' | |
239 | end |
|
262 | end | |
240 |
|
263 | |||
241 | def test_tokens_with_quotes |
|
264 | def test_tokens_with_quotes | |
242 | get :index, :id => 1, :q => '"good bye" hello "bye bye"' |
|
265 | get :index, :id => 1, :q => '"good bye" hello "bye bye"' | |
243 | assert_equal ["good bye", "hello", "bye bye"], assigns(:tokens) |
|
266 | assert_equal ["good bye", "hello", "bye bye"], assigns(:tokens) | |
244 | end |
|
267 | end | |
245 |
|
268 | |||
246 | def test_results_should_be_escaped_once |
|
269 | def test_results_should_be_escaped_once | |
247 | assert Issue.find(1).update_attributes(:subject => '<subject> escaped_once', :description => '<description> escaped_once') |
|
270 | assert Issue.find(1).update_attributes(:subject => '<subject> escaped_once', :description => '<description> escaped_once') | |
248 | get :index, :q => 'escaped_once' |
|
271 | get :index, :q => 'escaped_once' | |
249 | assert_response :success |
|
272 | assert_response :success | |
250 | assert_select '#search-results' do |
|
273 | assert_select '#search-results' do | |
251 | assert_select 'dt.issue a', :text => /<subject>/ |
|
274 | assert_select 'dt.issue a', :text => /<subject>/ | |
252 | assert_select 'dd', :text => /<description>/ |
|
275 | assert_select 'dd', :text => /<description>/ | |
253 | end |
|
276 | end | |
254 | end |
|
277 | end | |
255 |
|
278 | |||
256 | def test_keywords_should_be_highlighted |
|
279 | def test_keywords_should_be_highlighted | |
257 | assert Issue.find(1).update_attributes(:subject => 'subject highlighted', :description => 'description highlighted') |
|
280 | assert Issue.find(1).update_attributes(:subject => 'subject highlighted', :description => 'description highlighted') | |
258 | get :index, :q => 'highlighted' |
|
281 | get :index, :q => 'highlighted' | |
259 | assert_response :success |
|
282 | assert_response :success | |
260 | assert_select '#search-results' do |
|
283 | assert_select '#search-results' do | |
261 | assert_select 'dt.issue a span.highlight', :text => 'highlighted' |
|
284 | assert_select 'dt.issue a span.highlight', :text => 'highlighted' | |
262 | assert_select 'dd span.highlight', :text => 'highlighted' |
|
285 | assert_select 'dd span.highlight', :text => 'highlighted' | |
263 | end |
|
286 | end | |
264 | end |
|
287 | end | |
265 | end |
|
288 | end |
General Comments 0
You need to be logged in to leave comments.
Login now