jro_apps/redmine Commit - r13256:827ab38725d7

Selected projects in email notifications on "my account" are lost when the page is redisplayed after a validation error (#18060)....

Jean-Philippe Lang -

r13256:827ab38725d7

parent child

Context file:

r13256:827ab38725d7

app/models/user.rb +1 -1

                def notified_project_ids=(ids)
                  @notified_projects_ids_changed = true
-                 @notified_projects_ids = ids
+                 @notified_projects_ids = ids.map(&:to_i).uniq.select {|n| n > 0}
                end
                # Updates per project notifications (after_save callback)

test/unit/user_test.rb +5 0

                  assert_equal 6, User.valid_notification_options(User.find(2)).size
                end
+               def test_notified_project_ids_setter_should_coerce_to_unique_integer_array
+                 @jsmith.notified_project_ids = ["1", "123", "2u", "wrong", "12", 6, 12, -35, ""]
+                 assert_equal [1, 123, 2, 12, 6], @jsmith.notified_projects_ids
+               end
                def test_mail_notification_all
                  @jsmith.mail_notification = 'all'
                  @jsmith.notified_project_ids = []

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages