jro_apps/redmine Commit - r13503:7f29c2fd88f2

IssuesControllerTest: make encoding tests independent of ordering (#18856)...

Toshi MARUYAMA -

r13503:7f29c2fd88f2

parent child

Context file:

r13503:7f29c2fd88f2

Collapse all files

test/functional/issues_controller_test.rb +10 -6

                               :format => 'csv'
                   assert_equal 'text/csv; header=present', @response.content_type
                   lines = @response.body.chomp.split("\n")
+                  header = lines[0]
+                  issue_line = lines.find {|l| l =~ /^#{issue.id},/}
                   s1 = "\xaa\xac\xbaA".force_encoding('Big5')
-                  assert_include s1, lines[0]
+                  assert_include s1, header
-                  assert_include str_big5, lines[1]
+                  assert_include str_big5, issue_line
                 end
               end
                               :set_filter => 1
                   assert_equal 'text/csv; header=present', @response.content_type
                   lines = @response.body.chomp.split("\n")
+                  header = lines[0]
+                  issue_line = lines.find {|l| l =~ /^#{issue.id},/}
                   s1 = "\xaa\xac\xbaA".force_encoding('Big5') # status
-                  assert lines[0].include?(s1)
+                  assert header.include?(s1)
-                  s2 = lines[1].split(",")[2]
+                  s2 = issue_line.split(",")[2]
                   s3 = "\xa5H?".force_encoding('Big5') # subject
                   assert_equal s3, s2
                 end
                               :set_filter => 1
                   assert_equal 'text/csv; header=present', @response.content_type
                   lines = @response.body.chomp.split("\n")
-                  assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
+                  assert_include "#{issue.id},1234.50,#{str1}", lines
                 end
               end
                               :set_filter => 1
                   assert_equal 'text/csv; header=present', @response.content_type
                   lines = @response.body.chomp.split("\n")
-                  assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
+                  assert_include "#{issue.id};1234,50;#{str1}", lines
                 end
               end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages