jro_apps/redmine Commit - r8817:7e347069d560

Better message for file size validation error....

Jean-Philippe Lang -

r8817:7e347069d560

parent child

Context file:

r8817:7e347069d560

app/models/attachment.rb +1 -1

                def validate_max_file_size
                  if @temp_file && self.filesize > Setting.attachment_max_size.to_i.kilobytes
-                   errors.add(:base, :too_long, :count => Setting.attachment_max_size.to_i.kilobytes)
+                   errors.add(:base, l(:error_attachment_too_big, :max_size => Setting.attachment_max_size.to_i.kilobytes))
                  end
                end

test/integration/api_test/attachments_test.rb +11 0

                      assert_response 406
                    end
                  end
+                 should "return errors if file is too big" do
+                   set_tmp_attachments_directory
+                   with_settings :attachment_max_size => 1 do
+                     assert_no_difference 'Attachment.count' do
+                       post '/uploads.xml', ('x' * 2048), {'Content-Type' => 'application/octet-stream'}.merge(credentials('jsmith'))
+                       assert_response 422
+                       assert_tag 'error', :content => /exceeds the maximum allowed file size/
+                     end
+                   end
+                 end
                end
              end

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages