jro_apps/redmine Commit - r14240:7b12145ed904

Raises wiki edits comments limit to 1024 (#19886)....

Jean-Philippe Lang -

r14240:7b12145ed904

parent child

Context file:

r14240:7b12145ed904

db/migrate/20150921210243_change_wiki_contents_comments_limit_to_1024.rb created 644 +11 0

@@ -0,0 +1,11
	1	class ChangeWikiContentsCommentsLimitTo1024 < ActiveRecord::Migration
	2	def self.up
	3	change_column :wiki_content_versions, :comments, :string, :limit => 1024, :default => ''
	4	change_column :wiki_contents, :comments, :string, :limit => 1024, :default => ''
	5	end
	6
	7	def self.down
	8	change_column :wiki_content_versions, :comments, :string, :limit => 255, :default => ''
	9	change_column :wiki_contents, :comments, :string, :limit => 255, :default => ''
	10	end
	11	end

app/models/wiki_content.rb +1 -1

               belongs_to :page, :class_name => 'WikiPage'
               belongs_to :author, :class_name => 'User'
               validates_presence_of :text
-              validates_length_of :comments, :maximum => 255, :allow_nil => true
+              validates_length_of :comments, :maximum => 1024, :allow_nil => true
               attr_protected :id
               acts_as_versioned

app/views/wiki/edit.html.erb +1 -1

               <% end %>
             <% end %>
-            <p><label><%= l(:field_comments) %></label><%= f.text_field :comments, :size => 120 %></p>
+            <p><label><%= l(:field_comments) %></label><%= f.text_field :comments, :size => 120, :maxlength => 1024 %></p>
             <p><label><%=l(:label_attachment_plural)%></label><%= render :partial => 'attachments/form' %></p>
             </div>

test/functional/wiki_controller_test.rb +1 -1

                       put :update, :project_id => 1,
                         :id => 'Another_page',
                         :content => {
-                          :comments => 'a' * 300,  # failure here, comment is too long
+                          :comments => 'a' * 1300,  # failure here, comment is too long
                           :text => 'edited'
                         },
                         :wiki_page => {

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages