##// END OF EJS Templates
jro_apps » redmine
RSS
code layout clean up of test_all_dependent_issues_with_persistent_circular_dependency at test/unit/issue_test.rb...
Toshi MARUYAMA -
r7341:7a2f8588ee02
parent child
Show More
Side by Side Unified
Context file:
r7341:7a2f8588ee02 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,1065 +1,1071
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2011 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssueTest < ActiveSupport::TestCase
21 21 fixtures :projects, :users, :members, :member_roles, :roles,
22 22 :trackers, :projects_trackers,
23 23 :enabled_modules,
24 24 :versions,
25 25 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 26 :enumerations,
27 27 :issues,
28 28 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 29 :time_entries
30 30
31 31 def test_create
32 32 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :description => 'IssueTest#test_create', :estimated_hours => '1:30')
33 33 assert issue.save
34 34 issue.reload
35 35 assert_equal 1.5, issue.estimated_hours
36 36 end
37 37
38 38 def test_create_minimal
39 39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create')
40 40 assert issue.save
41 41 assert issue.description.nil?
42 42 end
43 43
44 44 def test_create_with_required_custom_field
45 45 field = IssueCustomField.find_by_name('Database')
46 46 field.update_attribute(:is_required, true)
47 47
48 48 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
49 49 assert issue.available_custom_fields.include?(field)
50 50 # No value for the custom field
51 51 assert !issue.save
52 52 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
53 53 # Blank value
54 54 issue.custom_field_values = { field.id => '' }
55 55 assert !issue.save
56 56 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
57 57 # Invalid value
58 58 issue.custom_field_values = { field.id => 'SQLServer' }
59 59 assert !issue.save
60 60 assert_equal I18n.translate('activerecord.errors.messages.invalid'), issue.errors.on(:custom_values)
61 61 # Valid value
62 62 issue.custom_field_values = { field.id => 'PostgreSQL' }
63 63 assert issue.save
64 64 issue.reload
65 65 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
66 66 end
67 67
68 68 def test_create_with_group_assignment
69 69 with_settings :issue_group_assignment => '1' do
70 70 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1, :subject => 'Group assignment', :assigned_to_id => 11).save
71 71 issue = Issue.first(:order => 'id DESC')
72 72 assert_kind_of Group, issue.assigned_to
73 73 assert_equal Group.find(11), issue.assigned_to
74 74 end
75 75 end
76 76
77 77 def assert_visibility_match(user, issues)
78 78 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
79 79 end
80 80
81 81 def test_visible_scope_for_anonymous
82 82 # Anonymous user should see issues of public projects only
83 83 issues = Issue.visible(User.anonymous).all
84 84 assert issues.any?
85 85 assert_nil issues.detect {|issue| !issue.project.is_public?}
86 86 assert_nil issues.detect {|issue| issue.is_private?}
87 87 assert_visibility_match User.anonymous, issues
88 88 end
89 89
90 90 def test_visible_scope_for_anonymous_with_own_issues_visibility
91 91 Role.anonymous.update_attribute :issues_visibility, 'own'
92 92 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => User.anonymous.id, :subject => 'Issue by anonymous')
93 93
94 94 issues = Issue.visible(User.anonymous).all
95 95 assert issues.any?
96 96 assert_nil issues.detect {|issue| issue.author != User.anonymous}
97 97 assert_visibility_match User.anonymous, issues
98 98 end
99 99
100 100 def test_visible_scope_for_anonymous_without_view_issues_permissions
101 101 # Anonymous user should not see issues without permission
102 102 Role.anonymous.remove_permission!(:view_issues)
103 103 issues = Issue.visible(User.anonymous).all
104 104 assert issues.empty?
105 105 assert_visibility_match User.anonymous, issues
106 106 end
107 107
108 108 def test_visible_scope_for_non_member
109 109 user = User.find(9)
110 110 assert user.projects.empty?
111 111 # Non member user should see issues of public projects only
112 112 issues = Issue.visible(user).all
113 113 assert issues.any?
114 114 assert_nil issues.detect {|issue| !issue.project.is_public?}
115 115 assert_nil issues.detect {|issue| issue.is_private?}
116 116 assert_visibility_match user, issues
117 117 end
118 118
119 119 def test_visible_scope_for_non_member_with_own_issues_visibility
120 120 Role.non_member.update_attribute :issues_visibility, 'own'
121 121 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
122 122 user = User.find(9)
123 123
124 124 issues = Issue.visible(user).all
125 125 assert issues.any?
126 126 assert_nil issues.detect {|issue| issue.author != user}
127 127 assert_visibility_match user, issues
128 128 end
129 129
130 130 def test_visible_scope_for_non_member_without_view_issues_permissions
131 131 # Non member user should not see issues without permission
132 132 Role.non_member.remove_permission!(:view_issues)
133 133 user = User.find(9)
134 134 assert user.projects.empty?
135 135 issues = Issue.visible(user).all
136 136 assert issues.empty?
137 137 assert_visibility_match user, issues
138 138 end
139 139
140 140 def test_visible_scope_for_member
141 141 user = User.find(9)
142 142 # User should see issues of projects for which he has view_issues permissions only
143 143 Role.non_member.remove_permission!(:view_issues)
144 144 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
145 145 issues = Issue.visible(user).all
146 146 assert issues.any?
147 147 assert_nil issues.detect {|issue| issue.project_id != 3}
148 148 assert_nil issues.detect {|issue| issue.is_private?}
149 149 assert_visibility_match user, issues
150 150 end
151 151
152 152 def test_visible_scope_for_admin
153 153 user = User.find(1)
154 154 user.members.each(&:destroy)
155 155 assert user.projects.empty?
156 156 issues = Issue.visible(user).all
157 157 assert issues.any?
158 158 # Admin should see issues on private projects that he does not belong to
159 159 assert issues.detect {|issue| !issue.project.is_public?}
160 160 # Admin should see private issues of other users
161 161 assert issues.detect {|issue| issue.is_private? && issue.author != user}
162 162 assert_visibility_match user, issues
163 163 end
164 164
165 165 def test_visible_scope_with_project
166 166 project = Project.find(1)
167 167 issues = Issue.visible(User.find(2), :project => project).all
168 168 projects = issues.collect(&:project).uniq
169 169 assert_equal 1, projects.size
170 170 assert_equal project, projects.first
171 171 end
172 172
173 173 def test_visible_scope_with_project_and_subprojects
174 174 project = Project.find(1)
175 175 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
176 176 projects = issues.collect(&:project).uniq
177 177 assert projects.size > 1
178 178 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
179 179 end
180 180
181 181 def test_visible_and_nested_set_scopes
182 182 assert_equal 0, Issue.find(1).descendants.visible.all.size
183 183 end
184 184
185 185 def test_errors_full_messages_should_include_custom_fields_errors
186 186 field = IssueCustomField.find_by_name('Database')
187 187
188 188 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => 'test_create', :description => 'IssueTest#test_create_with_required_custom_field')
189 189 assert issue.available_custom_fields.include?(field)
190 190 # Invalid value
191 191 issue.custom_field_values = { field.id => 'SQLServer' }
192 192
193 193 assert !issue.valid?
194 194 assert_equal 1, issue.errors.full_messages.size
195 195 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}", issue.errors.full_messages.first
196 196 end
197 197
198 198 def test_update_issue_with_required_custom_field
199 199 field = IssueCustomField.find_by_name('Database')
200 200 field.update_attribute(:is_required, true)
201 201
202 202 issue = Issue.find(1)
203 203 assert_nil issue.custom_value_for(field)
204 204 assert issue.available_custom_fields.include?(field)
205 205 # No change to custom values, issue can be saved
206 206 assert issue.save
207 207 # Blank value
208 208 issue.custom_field_values = { field.id => '' }
209 209 assert !issue.save
210 210 # Valid value
211 211 issue.custom_field_values = { field.id => 'PostgreSQL' }
212 212 assert issue.save
213 213 issue.reload
214 214 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
215 215 end
216 216
217 217 def test_should_not_update_attributes_if_custom_fields_validation_fails
218 218 issue = Issue.find(1)
219 219 field = IssueCustomField.find_by_name('Database')
220 220 assert issue.available_custom_fields.include?(field)
221 221
222 222 issue.custom_field_values = { field.id => 'Invalid' }
223 223 issue.subject = 'Should be not be saved'
224 224 assert !issue.save
225 225
226 226 issue.reload
227 227 assert_equal "Can't print recipes", issue.subject
228 228 end
229 229
230 230 def test_should_not_recreate_custom_values_objects_on_update
231 231 field = IssueCustomField.find_by_name('Database')
232 232
233 233 issue = Issue.find(1)
234 234 issue.custom_field_values = { field.id => 'PostgreSQL' }
235 235 assert issue.save
236 236 custom_value = issue.custom_value_for(field)
237 237 issue.reload
238 238 issue.custom_field_values = { field.id => 'MySQL' }
239 239 assert issue.save
240 240 issue.reload
241 241 assert_equal custom_value.id, issue.custom_value_for(field).id
242 242 end
243 243
244 244 def test_assigning_tracker_id_should_reload_custom_fields_values
245 245 issue = Issue.new(:project => Project.find(1))
246 246 assert issue.custom_field_values.empty?
247 247 issue.tracker_id = 1
248 248 assert issue.custom_field_values.any?
249 249 end
250 250
251 251 def test_assigning_attributes_should_assign_tracker_id_first
252 252 attributes = ActiveSupport::OrderedHash.new
253 253 attributes['custom_field_values'] = { '1' => 'MySQL' }
254 254 attributes['tracker_id'] = '1'
255 255 issue = Issue.new(:project => Project.find(1))
256 256 issue.attributes = attributes
257 257 assert_not_nil issue.custom_value_for(1)
258 258 assert_equal 'MySQL', issue.custom_value_for(1).value
259 259 end
260 260
261 261 def test_should_update_issue_with_disabled_tracker
262 262 p = Project.find(1)
263 263 issue = Issue.find(1)
264 264
265 265 p.trackers.delete(issue.tracker)
266 266 assert !p.trackers.include?(issue.tracker)
267 267
268 268 issue.reload
269 269 issue.subject = 'New subject'
270 270 assert issue.save
271 271 end
272 272
273 273 def test_should_not_set_a_disabled_tracker
274 274 p = Project.find(1)
275 275 p.trackers.delete(Tracker.find(2))
276 276
277 277 issue = Issue.find(1)
278 278 issue.tracker_id = 2
279 279 issue.subject = 'New subject'
280 280 assert !issue.save
281 281 assert_not_nil issue.errors.on(:tracker_id)
282 282 end
283 283
284 284 def test_category_based_assignment
285 285 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Assignment test', :description => 'Assignment test', :category_id => 1)
286 286 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
287 287 end
288 288
289 289 def test_new_statuses_allowed_to
290 290 Workflow.delete_all
291 291
292 292 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2, :author => false, :assignee => false)
293 293 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3, :author => true, :assignee => false)
294 294 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4, :author => false, :assignee => true)
295 295 Workflow.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5, :author => true, :assignee => true)
296 296 status = IssueStatus.find(1)
297 297 role = Role.find(1)
298 298 tracker = Tracker.find(1)
299 299 user = User.find(2)
300 300
301 301 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1)
302 302 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
303 303
304 304 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user)
305 305 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
306 306
307 307 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :assigned_to => user)
308 308 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
309 309
310 310 issue = Issue.generate!(:tracker => tracker, :status => status, :project_id => 1, :author => user, :assigned_to => user)
311 311 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
312 312 end
313 313
314 314 def test_copy
315 315 issue = Issue.new.copy_from(1)
316 316 assert issue.save
317 317 issue.reload
318 318 orig = Issue.find(1)
319 319 assert_equal orig.subject, issue.subject
320 320 assert_equal orig.tracker, issue.tracker
321 321 assert_equal "125", issue.custom_value_for(2).value
322 322 end
323 323
324 324 def test_copy_should_copy_status
325 325 orig = Issue.find(8)
326 326 assert orig.status != IssueStatus.default
327 327
328 328 issue = Issue.new.copy_from(orig)
329 329 assert issue.save
330 330 issue.reload
331 331 assert_equal orig.status, issue.status
332 332 end
333 333
334 334 def test_should_close_duplicates
335 335 # Create 3 issues
336 336 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
337 337 assert issue1.save
338 338 issue2 = issue1.clone
339 339 assert issue2.save
340 340 issue3 = issue1.clone
341 341 assert issue3.save
342 342
343 343 # 2 is a dupe of 1
344 344 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
345 345 # And 3 is a dupe of 2
346 346 IssueRelation.create(:issue_from => issue3, :issue_to => issue2, :relation_type => IssueRelation::TYPE_DUPLICATES)
347 347 # And 3 is a dupe of 1 (circular duplicates)
348 348 IssueRelation.create(:issue_from => issue3, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
349 349
350 350 assert issue1.reload.duplicates.include?(issue2)
351 351
352 352 # Closing issue 1
353 353 issue1.init_journal(User.find(:first), "Closing issue1")
354 354 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
355 355 assert issue1.save
356 356 # 2 and 3 should be also closed
357 357 assert issue2.reload.closed?
358 358 assert issue3.reload.closed?
359 359 end
360 360
361 361 def test_should_not_close_duplicated_issue
362 362 # Create 3 issues
363 363 issue1 = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'Duplicates test', :description => 'Duplicates test')
364 364 assert issue1.save
365 365 issue2 = issue1.clone
366 366 assert issue2.save
367 367
368 368 # 2 is a dupe of 1
369 369 IssueRelation.create(:issue_from => issue2, :issue_to => issue1, :relation_type => IssueRelation::TYPE_DUPLICATES)
370 370 # 2 is a dup of 1 but 1 is not a duplicate of 2
371 371 assert !issue2.reload.duplicates.include?(issue1)
372 372
373 373 # Closing issue 2
374 374 issue2.init_journal(User.find(:first), "Closing issue2")
375 375 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
376 376 assert issue2.save
377 377 # 1 should not be also closed
378 378 assert !issue1.reload.closed?
379 379 end
380 380
381 381 def test_assignable_versions
382 382 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
383 383 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
384 384 end
385 385
386 386 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
387 387 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
388 388 assert !issue.save
389 389 assert_not_nil issue.errors.on(:fixed_version_id)
390 390 end
391 391
392 392 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
393 393 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
394 394 assert !issue.save
395 395 assert_not_nil issue.errors.on(:fixed_version_id)
396 396 end
397 397
398 398 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
399 399 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 3, :subject => 'New issue')
400 400 assert issue.save
401 401 end
402 402
403 403 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
404 404 issue = Issue.find(11)
405 405 assert_equal 'closed', issue.fixed_version.status
406 406 issue.subject = 'Subject changed'
407 407 assert issue.save
408 408 end
409 409
410 410 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
411 411 issue = Issue.find(11)
412 412 issue.status_id = 1
413 413 assert !issue.save
414 414 assert_not_nil issue.errors.on_base
415 415 end
416 416
417 417 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
418 418 issue = Issue.find(11)
419 419 issue.status_id = 1
420 420 issue.fixed_version_id = 3
421 421 assert issue.save
422 422 end
423 423
424 424 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
425 425 issue = Issue.find(12)
426 426 assert_equal 'locked', issue.fixed_version.status
427 427 issue.status_id = 1
428 428 assert issue.save
429 429 end
430 430
431 431 def test_move_to_another_project_with_same_category
432 432 issue = Issue.find(1)
433 433 assert issue.move_to_project(Project.find(2))
434 434 issue.reload
435 435 assert_equal 2, issue.project_id
436 436 # Category changes
437 437 assert_equal 4, issue.category_id
438 438 # Make sure time entries were move to the target project
439 439 assert_equal 2, issue.time_entries.first.project_id
440 440 end
441 441
442 442 def test_move_to_another_project_without_same_category
443 443 issue = Issue.find(2)
444 444 assert issue.move_to_project(Project.find(2))
445 445 issue.reload
446 446 assert_equal 2, issue.project_id
447 447 # Category cleared
448 448 assert_nil issue.category_id
449 449 end
450 450
451 451 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
452 452 issue = Issue.find(1)
453 453 issue.update_attribute(:fixed_version_id, 1)
454 454 assert issue.move_to_project(Project.find(2))
455 455 issue.reload
456 456 assert_equal 2, issue.project_id
457 457 # Cleared fixed_version
458 458 assert_equal nil, issue.fixed_version
459 459 end
460 460
461 461 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
462 462 issue = Issue.find(1)
463 463 issue.update_attribute(:fixed_version_id, 4)
464 464 assert issue.move_to_project(Project.find(5))
465 465 issue.reload
466 466 assert_equal 5, issue.project_id
467 467 # Keep fixed_version
468 468 assert_equal 4, issue.fixed_version_id
469 469 end
470 470
471 471 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
472 472 issue = Issue.find(1)
473 473 issue.update_attribute(:fixed_version_id, 1)
474 474 assert issue.move_to_project(Project.find(5))
475 475 issue.reload
476 476 assert_equal 5, issue.project_id
477 477 # Cleared fixed_version
478 478 assert_equal nil, issue.fixed_version
479 479 end
480 480
481 481 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
482 482 issue = Issue.find(1)
483 483 issue.update_attribute(:fixed_version_id, 7)
484 484 assert issue.move_to_project(Project.find(2))
485 485 issue.reload
486 486 assert_equal 2, issue.project_id
487 487 # Keep fixed_version
488 488 assert_equal 7, issue.fixed_version_id
489 489 end
490 490
491 491 def test_move_to_another_project_with_disabled_tracker
492 492 issue = Issue.find(1)
493 493 target = Project.find(2)
494 494 target.tracker_ids = [3]
495 495 target.save
496 496 assert_equal false, issue.move_to_project(target)
497 497 issue.reload
498 498 assert_equal 1, issue.project_id
499 499 end
500 500
501 501 def test_copy_to_the_same_project
502 502 issue = Issue.find(1)
503 503 copy = nil
504 504 assert_difference 'Issue.count' do
505 505 copy = issue.move_to_project(issue.project, nil, :copy => true)
506 506 end
507 507 assert_kind_of Issue, copy
508 508 assert_equal issue.project, copy.project
509 509 assert_equal "125", copy.custom_value_for(2).value
510 510 end
511 511
512 512 def test_copy_to_another_project_and_tracker
513 513 issue = Issue.find(1)
514 514 copy = nil
515 515 assert_difference 'Issue.count' do
516 516 copy = issue.move_to_project(Project.find(3), Tracker.find(2), :copy => true)
517 517 end
518 518 copy.reload
519 519 assert_kind_of Issue, copy
520 520 assert_equal Project.find(3), copy.project
521 521 assert_equal Tracker.find(2), copy.tracker
522 522 # Custom field #2 is not associated with target tracker
523 523 assert_nil copy.custom_value_for(2)
524 524 end
525 525
526 526 context "#move_to_project" do
527 527 context "as a copy" do
528 528 setup do
529 529 @issue = Issue.find(1)
530 530 @copy = nil
531 531 end
532 532
533 533 should "not create a journal" do
534 534 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
535 535 assert_equal 0, @copy.reload.journals.size
536 536 end
537 537
538 538 should "allow assigned_to changes" do
539 539 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:assigned_to_id => 3}})
540 540 assert_equal 3, @copy.assigned_to_id
541 541 end
542 542
543 543 should "allow status changes" do
544 544 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:status_id => 2}})
545 545 assert_equal 2, @copy.status_id
546 546 end
547 547
548 548 should "allow start date changes" do
549 549 date = Date.today
550 550 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
551 551 assert_equal date, @copy.start_date
552 552 end
553 553
554 554 should "allow due date changes" do
555 555 date = Date.today
556 556 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:due_date => date}})
557 557
558 558 assert_equal date, @copy.due_date
559 559 end
560 560
561 561 should "set current user as author" do
562 562 User.current = User.find(9)
563 563 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {}})
564 564
565 565 assert_equal User.current, @copy.author
566 566 end
567 567
568 568 should "keep journal notes" do
569 569 date = Date.today
570 570 notes = "Notes added when copying"
571 571 User.current = User.find(9)
572 572 @issue.init_journal(User.current, notes)
573 573 @copy = @issue.move_to_project(Project.find(3), Tracker.find(2), {:copy => true, :attributes => {:start_date => date}})
574 574
575 575 assert_equal 1, @copy.journals.size
576 576 journal = @copy.journals.first
577 577 assert_equal 0, journal.details.size
578 578 assert_equal notes, journal.notes
579 579 end
580 580 end
581 581 end
582 582
583 583 def test_recipients_should_not_include_users_that_cannot_view_the_issue
584 584 issue = Issue.find(12)
585 585 assert issue.recipients.include?(issue.author.mail)
586 586 # move the issue to a private project
587 587 copy = issue.move_to_project(Project.find(5), Tracker.find(2), :copy => true)
588 588 # author is not a member of project anymore
589 589 assert !copy.recipients.include?(copy.author.mail)
590 590 end
591 591
592 592 def test_recipients_should_include_the_assigned_group_members
593 593 group_member = User.generate_with_protected!
594 594 group = Group.generate!
595 595 group.users << group_member
596 596
597 597 issue = Issue.find(12)
598 598 issue.assigned_to = group
599 599 assert issue.recipients.include?(group_member.mail)
600 600 end
601 601
602 602 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
603 603 user = User.find(3)
604 604 issue = Issue.find(9)
605 605 Watcher.create!(:user => user, :watchable => issue)
606 606 assert issue.watched_by?(user)
607 607 assert !issue.watcher_recipients.include?(user.mail)
608 608 end
609 609
610 610 def test_issue_destroy
611 611 Issue.find(1).destroy
612 612 assert_nil Issue.find_by_id(1)
613 613 assert_nil TimeEntry.find_by_issue_id(1)
614 614 end
615 615
616 616 def test_blocked
617 617 blocked_issue = Issue.find(9)
618 618 blocking_issue = Issue.find(10)
619 619
620 620 assert blocked_issue.blocked?
621 621 assert !blocking_issue.blocked?
622 622 end
623 623
624 624 def test_blocked_issues_dont_allow_closed_statuses
625 625 blocked_issue = Issue.find(9)
626 626
627 627 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
628 628 assert !allowed_statuses.empty?
629 629 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
630 630 assert closed_statuses.empty?
631 631 end
632 632
633 633 def test_unblocked_issues_allow_closed_statuses
634 634 blocking_issue = Issue.find(10)
635 635
636 636 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
637 637 assert !allowed_statuses.empty?
638 638 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
639 639 assert !closed_statuses.empty?
640 640 end
641 641
642 642 def test_rescheduling_an_issue_should_reschedule_following_issue
643 643 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
644 644 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :subject => '-', :start_date => Date.today, :due_date => Date.today + 2)
645 645 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2, :relation_type => IssueRelation::TYPE_PRECEDES)
646 646 assert_equal issue1.due_date + 1, issue2.reload.start_date
647 647
648 648 issue1.due_date = Date.today + 5
649 649 issue1.save!
650 650 assert_equal issue1.due_date + 1, issue2.reload.start_date
651 651 end
652 652
653 653 def test_overdue
654 654 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
655 655 assert !Issue.new(:due_date => Date.today).overdue?
656 656 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
657 657 assert !Issue.new(:due_date => nil).overdue?
658 658 assert !Issue.new(:due_date => 1.day.ago.to_date, :status => IssueStatus.find(:first, :conditions => {:is_closed => true})).overdue?
659 659 end
660 660
661 661 context "#behind_schedule?" do
662 662 should "be false if the issue has no start_date" do
663 663 assert !Issue.new(:start_date => nil, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
664 664 end
665 665
666 666 should "be false if the issue has no end_date" do
667 667 assert !Issue.new(:start_date => 1.day.from_now.to_date, :due_date => nil, :done_ratio => 0).behind_schedule?
668 668 end
669 669
670 670 should "be false if the issue has more done than it's calendar time" do
671 671 assert !Issue.new(:start_date => 50.days.ago.to_date, :due_date => 50.days.from_now.to_date, :done_ratio => 90).behind_schedule?
672 672 end
673 673
674 674 should "be true if the issue hasn't been started at all" do
675 675 assert Issue.new(:start_date => 1.day.ago.to_date, :due_date => 1.day.from_now.to_date, :done_ratio => 0).behind_schedule?
676 676 end
677 677
678 678 should "be true if the issue has used more calendar time than it's done ratio" do
679 679 assert Issue.new(:start_date => 100.days.ago.to_date, :due_date => Date.today, :done_ratio => 90).behind_schedule?
680 680 end
681 681 end
682 682
683 683 context "#assignable_users" do
684 684 should "be Users" do
685 685 assert_kind_of User, Issue.find(1).assignable_users.first
686 686 end
687 687
688 688 should "include the issue author" do
689 689 project = Project.find(1)
690 690 non_project_member = User.generate!
691 691 issue = Issue.generate_for_project!(project, :author => non_project_member)
692 692
693 693 assert issue.assignable_users.include?(non_project_member)
694 694 end
695 695
696 696 should "include the current assignee" do
697 697 project = Project.find(1)
698 698 user = User.generate!
699 699 issue = Issue.generate_for_project!(project, :assigned_to => user)
700 700 user.lock!
701 701
702 702 assert Issue.find(issue.id).assignable_users.include?(user)
703 703 end
704 704
705 705 should "not show the issue author twice" do
706 706 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
707 707 assert_equal 2, assignable_user_ids.length
708 708
709 709 assignable_user_ids.each do |user_id|
710 710 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length, "User #{user_id} appears more or less than once"
711 711 end
712 712 end
713 713
714 714 context "with issue_group_assignment" do
715 715 should "include groups" do
716 716 issue = Issue.new(:project => Project.find(2))
717 717
718 718 with_settings :issue_group_assignment => '1' do
719 719 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
720 720 assert issue.assignable_users.include?(Group.find(11))
721 721 end
722 722 end
723 723 end
724 724
725 725 context "without issue_group_assignment" do
726 726 should "not include groups" do
727 727 issue = Issue.new(:project => Project.find(2))
728 728
729 729 with_settings :issue_group_assignment => '0' do
730 730 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
731 731 assert !issue.assignable_users.include?(Group.find(11))
732 732 end
733 733 end
734 734 end
735 735 end
736 736
737 737 def test_create_should_send_email_notification
738 738 ActionMailer::Base.deliveries.clear
739 739 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3, :status_id => 1, :priority => IssuePriority.all.first, :subject => 'test_create', :estimated_hours => '1:30')
740 740
741 741 assert issue.save
742 742 assert_equal 1, ActionMailer::Base.deliveries.size
743 743 end
744 744
745 745 def test_stale_issue_should_not_send_email_notification
746 746 ActionMailer::Base.deliveries.clear
747 747 issue = Issue.find(1)
748 748 stale = Issue.find(1)
749 749
750 750 issue.init_journal(User.find(1))
751 751 issue.subject = 'Subjet update'
752 752 assert issue.save
753 753 assert_equal 1, ActionMailer::Base.deliveries.size
754 754 ActionMailer::Base.deliveries.clear
755 755
756 756 stale.init_journal(User.find(1))
757 757 stale.subject = 'Another subjet update'
758 758 assert_raise ActiveRecord::StaleObjectError do
759 759 stale.save
760 760 end
761 761 assert ActionMailer::Base.deliveries.empty?
762 762 end
763 763
764 764 def test_journalized_description
765 765 IssueCustomField.delete_all
766 766
767 767 i = Issue.first
768 768 old_description = i.description
769 769 new_description = "This is the new description"
770 770
771 771 i.init_journal(User.find(2))
772 772 i.description = new_description
773 773 assert_difference 'Journal.count', 1 do
774 774 assert_difference 'JournalDetail.count', 1 do
775 775 i.save!
776 776 end
777 777 end
778 778
779 779 detail = JournalDetail.first(:order => 'id DESC')
780 780 assert_equal i, detail.journal.journalized
781 781 assert_equal 'attr', detail.property
782 782 assert_equal 'description', detail.prop_key
783 783 assert_equal old_description, detail.old_value
784 784 assert_equal new_description, detail.value
785 785 end
786 786
787 787 def test_blank_descriptions_should_not_be_journalized
788 788 IssueCustomField.delete_all
789 789 Issue.update_all("description = NULL", "id=1")
790 790
791 791 i = Issue.find(1)
792 792 i.init_journal(User.find(2))
793 793 i.subject = "blank description"
794 794 i.description = "\r\n"
795 795
796 796 assert_difference 'Journal.count', 1 do
797 797 assert_difference 'JournalDetail.count', 1 do
798 798 i.save!
799 799 end
800 800 end
801 801 end
802 802
803 803 def test_description_eol_should_be_normalized
804 804 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
805 805 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
806 806 end
807 807
808 808 def test_saving_twice_should_not_duplicate_journal_details
809 809 i = Issue.find(:first)
810 810 i.init_journal(User.find(2), 'Some notes')
811 811 # initial changes
812 812 i.subject = 'New subject'
813 813 i.done_ratio = i.done_ratio + 10
814 814 assert_difference 'Journal.count' do
815 815 assert i.save
816 816 end
817 817 # 1 more change
818 818 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
819 819 assert_no_difference 'Journal.count' do
820 820 assert_difference 'JournalDetail.count', 1 do
821 821 i.save
822 822 end
823 823 end
824 824 # no more change
825 825 assert_no_difference 'Journal.count' do
826 826 assert_no_difference 'JournalDetail.count' do
827 827 i.save
828 828 end
829 829 end
830 830 end
831 831
832 832 def test_all_dependent_issues
833 833 IssueRelation.delete_all
834 834 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
835 835 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
836 836 assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_PRECEDES)
837 837
838 838 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
839 839 end
840 840
841 841 def test_all_dependent_issues_with_persistent_circular_dependency
842 842 IssueRelation.delete_all
843 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_PRECEDES)
844 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_PRECEDES)
843 assert IssueRelation.create!(:issue_from => Issue.find(1),
844 :issue_to => Issue.find(2),
845 :relation_type => IssueRelation::TYPE_PRECEDES)
846 assert IssueRelation.create!(:issue_from => Issue.find(2),
847 :issue_to => Issue.find(3),
848 :relation_type => IssueRelation::TYPE_PRECEDES)
845 849 # Validation skipping
846 assert IssueRelation.new(:issue_from => Issue.find(3), :issue_to => Issue.find(1), :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
850 assert IssueRelation.new(:issue_from => Issue.find(3),
851 :issue_to => Issue.find(1),
852 :relation_type => IssueRelation::TYPE_PRECEDES).save(false)
847 853
848 854 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
849 855 end
850 856
851 857 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
852 858 IssueRelation.delete_all
853 859 assert IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_RELATES)
854 860 assert IssueRelation.create!(:issue_from => Issue.find(2), :issue_to => Issue.find(3), :relation_type => IssueRelation::TYPE_RELATES)
855 861 assert IssueRelation.create!(:issue_from => Issue.find(3), :issue_to => Issue.find(8), :relation_type => IssueRelation::TYPE_RELATES)
856 862 # Validation skipping
857 863 assert IssueRelation.new(:issue_from => Issue.find(8), :issue_to => Issue.find(2), :relation_type => IssueRelation::TYPE_RELATES).save(false)
858 864 assert IssueRelation.new(:issue_from => Issue.find(3), :issue_to => Issue.find(1), :relation_type => IssueRelation::TYPE_RELATES).save(false)
859 865
860 866 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
861 867 end
862 868
863 869 context "#done_ratio" do
864 870 setup do
865 871 @issue = Issue.find(1)
866 872 @issue_status = IssueStatus.find(1)
867 873 @issue_status.update_attribute(:default_done_ratio, 50)
868 874 @issue2 = Issue.find(2)
869 875 @issue_status2 = IssueStatus.find(2)
870 876 @issue_status2.update_attribute(:default_done_ratio, 0)
871 877 end
872 878
873 879 context "with Setting.issue_done_ratio using the issue_field" do
874 880 setup do
875 881 Setting.issue_done_ratio = 'issue_field'
876 882 end
877 883
878 884 should "read the issue's field" do
879 885 assert_equal 0, @issue.done_ratio
880 886 assert_equal 30, @issue2.done_ratio
881 887 end
882 888 end
883 889
884 890 context "with Setting.issue_done_ratio using the issue_status" do
885 891 setup do
886 892 Setting.issue_done_ratio = 'issue_status'
887 893 end
888 894
889 895 should "read the Issue Status's default done ratio" do
890 896 assert_equal 50, @issue.done_ratio
891 897 assert_equal 0, @issue2.done_ratio
892 898 end
893 899 end
894 900 end
895 901
896 902 context "#update_done_ratio_from_issue_status" do
897 903 setup do
898 904 @issue = Issue.find(1)
899 905 @issue_status = IssueStatus.find(1)
900 906 @issue_status.update_attribute(:default_done_ratio, 50)
901 907 @issue2 = Issue.find(2)
902 908 @issue_status2 = IssueStatus.find(2)
903 909 @issue_status2.update_attribute(:default_done_ratio, 0)
904 910 end
905 911
906 912 context "with Setting.issue_done_ratio using the issue_field" do
907 913 setup do
908 914 Setting.issue_done_ratio = 'issue_field'
909 915 end
910 916
911 917 should "not change the issue" do
912 918 @issue.update_done_ratio_from_issue_status
913 919 @issue2.update_done_ratio_from_issue_status
914 920
915 921 assert_equal 0, @issue.read_attribute(:done_ratio)
916 922 assert_equal 30, @issue2.read_attribute(:done_ratio)
917 923 end
918 924 end
919 925
920 926 context "with Setting.issue_done_ratio using the issue_status" do
921 927 setup do
922 928 Setting.issue_done_ratio = 'issue_status'
923 929 end
924 930
925 931 should "change the issue's done ratio" do
926 932 @issue.update_done_ratio_from_issue_status
927 933 @issue2.update_done_ratio_from_issue_status
928 934
929 935 assert_equal 50, @issue.read_attribute(:done_ratio)
930 936 assert_equal 0, @issue2.read_attribute(:done_ratio)
931 937 end
932 938 end
933 939 end
934 940
935 941 test "#by_tracker" do
936 942 User.current = User.anonymous
937 943 groups = Issue.by_tracker(Project.find(1))
938 944 assert_equal 3, groups.size
939 945 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
940 946 end
941 947
942 948 test "#by_version" do
943 949 User.current = User.anonymous
944 950 groups = Issue.by_version(Project.find(1))
945 951 assert_equal 3, groups.size
946 952 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
947 953 end
948 954
949 955 test "#by_priority" do
950 956 User.current = User.anonymous
951 957 groups = Issue.by_priority(Project.find(1))
952 958 assert_equal 4, groups.size
953 959 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
954 960 end
955 961
956 962 test "#by_category" do
957 963 User.current = User.anonymous
958 964 groups = Issue.by_category(Project.find(1))
959 965 assert_equal 2, groups.size
960 966 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
961 967 end
962 968
963 969 test "#by_assigned_to" do
964 970 User.current = User.anonymous
965 971 groups = Issue.by_assigned_to(Project.find(1))
966 972 assert_equal 2, groups.size
967 973 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
968 974 end
969 975
970 976 test "#by_author" do
971 977 User.current = User.anonymous
972 978 groups = Issue.by_author(Project.find(1))
973 979 assert_equal 4, groups.size
974 980 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
975 981 end
976 982
977 983 test "#by_subproject" do
978 984 User.current = User.anonymous
979 985 groups = Issue.by_subproject(Project.find(1))
980 986 # Private descendant not visible
981 987 assert_equal 1, groups.size
982 988 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
983 989 end
984 990
985 991 context ".allowed_target_projects_on_move" do
986 992 should "return all active projects for admin users" do
987 993 User.current = User.find(1)
988 994 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
989 995 end
990 996
991 997 should "return allowed projects for non admin users" do
992 998 User.current = User.find(2)
993 999 Role.non_member.remove_permission! :move_issues
994 1000 assert_equal 3, Issue.allowed_target_projects_on_move.size
995 1001
996 1002 Role.non_member.add_permission! :move_issues
997 1003 assert_equal Project.active.count, Issue.allowed_target_projects_on_move.size
998 1004 end
999 1005 end
1000 1006
1001 1007 def test_recently_updated_with_limit_scopes
1002 1008 #should return the last updated issue
1003 1009 assert_equal 1, Issue.recently_updated.with_limit(1).length
1004 1010 assert_equal Issue.find(:first, :order => "updated_on DESC"), Issue.recently_updated.with_limit(1).first
1005 1011 end
1006 1012
1007 1013 def test_on_active_projects_scope
1008 1014 assert Project.find(2).archive
1009 1015
1010 1016 before = Issue.on_active_project.length
1011 1017 # test inclusion to results
1012 1018 issue = Issue.generate_for_project!(Project.find(1), :tracker => Project.find(2).trackers.first)
1013 1019 assert_equal before + 1, Issue.on_active_project.length
1014 1020
1015 1021 # Move to an archived project
1016 1022 issue.project = Project.find(2)
1017 1023 assert issue.save
1018 1024 assert_equal before, Issue.on_active_project.length
1019 1025 end
1020 1026
1021 1027 context "Issue#recipients" do
1022 1028 setup do
1023 1029 @project = Project.find(1)
1024 1030 @author = User.generate_with_protected!
1025 1031 @assignee = User.generate_with_protected!
1026 1032 @issue = Issue.generate_for_project!(@project, :assigned_to => @assignee, :author => @author)
1027 1033 end
1028 1034
1029 1035 should "include project recipients" do
1030 1036 assert @project.recipients.present?
1031 1037 @project.recipients.each do |project_recipient|
1032 1038 assert @issue.recipients.include?(project_recipient)
1033 1039 end
1034 1040 end
1035 1041
1036 1042 should "include the author if the author is active" do
1037 1043 assert @issue.author, "No author set for Issue"
1038 1044 assert @issue.recipients.include?(@issue.author.mail)
1039 1045 end
1040 1046
1041 1047 should "include the assigned to user if the assigned to user is active" do
1042 1048 assert @issue.assigned_to, "No assigned_to set for Issue"
1043 1049 assert @issue.recipients.include?(@issue.assigned_to.mail)
1044 1050 end
1045 1051
1046 1052 should "not include users who opt out of all email" do
1047 1053 @author.update_attribute(:mail_notification, :none)
1048 1054
1049 1055 assert !@issue.recipients.include?(@issue.author.mail)
1050 1056 end
1051 1057
1052 1058 should "not include the issue author if they are only notified of assigned issues" do
1053 1059 @author.update_attribute(:mail_notification, :only_assigned)
1054 1060
1055 1061 assert !@issue.recipients.include?(@issue.author.mail)
1056 1062 end
1057 1063
1058 1064 should "not include the assigned user if they are only notified of owned issues" do
1059 1065 @assignee.update_attribute(:mail_notification, :only_owner)
1060 1066
1061 1067 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1062 1068 end
1063 1069
1064 1070 end
1065 1071 end
General Comments 0
You need to be logged in to leave comments. Login now