##// END OF EJS Templates
jro_apps » redmine
RSS
Merged r14054 (#19225)....
Jean-Philippe Lang -
r13682:7879d8e4dcb4
parent child
Show More
Side by Side Unified
Context file:
r13682:7879d8e4dcb4 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,488 +1,492
1 1 # encoding: utf-8
2 2 #
3 3 # Redmine - project management software
4 4 # Copyright (C) 2006-2015 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 module IssuesHelper
21 21 include ApplicationHelper
22 22 include Redmine::Export::PDF::IssuesPdfHelper
23 23
24 24 def issue_list(issues, &block)
25 25 ancestors = []
26 26 issues.each do |issue|
27 27 while (ancestors.any? && !issue.is_descendant_of?(ancestors.last))
28 28 ancestors.pop
29 29 end
30 30 yield issue, ancestors.size
31 31 ancestors << issue unless issue.leaf?
32 32 end
33 33 end
34 34
35 35 def grouped_issue_list(issues, query, issue_count_by_group, &block)
36 36 previous_group, first = false, true
37 37 issue_list(issues) do |issue, level|
38 38 group_name = group_count = nil
39 39 if query.grouped? && ((group = query.group_by_column.value(issue)) != previous_group || first)
40 40 if group.blank? && group != false
41 41 group_name = "(#{l(:label_blank_value)})"
42 42 else
43 43 group_name = column_content(query.group_by_column, issue)
44 44 end
45 45 group_name ||= ""
46 46 group_count = issue_count_by_group[group]
47 47 end
48 48 yield issue, level, group_name, group_count
49 49 previous_group, first = group, false
50 50 end
51 51 end
52 52
53 53 # Renders a HTML/CSS tooltip
54 54 #
55 55 # To use, a trigger div is needed. This is a div with the class of "tooltip"
56 56 # that contains this method wrapped in a span with the class of "tip"
57 57 #
58 58 # <div class="tooltip"><%= link_to_issue(issue) %>
59 59 # <span class="tip"><%= render_issue_tooltip(issue) %></span>
60 60 # </div>
61 61 #
62 62 def render_issue_tooltip(issue)
63 63 @cached_label_status ||= l(:field_status)
64 64 @cached_label_start_date ||= l(:field_start_date)
65 65 @cached_label_due_date ||= l(:field_due_date)
66 66 @cached_label_assigned_to ||= l(:field_assigned_to)
67 67 @cached_label_priority ||= l(:field_priority)
68 68 @cached_label_project ||= l(:field_project)
69 69
70 70 link_to_issue(issue) + "<br /><br />".html_safe +
71 71 "<strong>#{@cached_label_project}</strong>: #{link_to_project(issue.project)}<br />".html_safe +
72 72 "<strong>#{@cached_label_status}</strong>: #{h(issue.status.name)}<br />".html_safe +
73 73 "<strong>#{@cached_label_start_date}</strong>: #{format_date(issue.start_date)}<br />".html_safe +
74 74 "<strong>#{@cached_label_due_date}</strong>: #{format_date(issue.due_date)}<br />".html_safe +
75 75 "<strong>#{@cached_label_assigned_to}</strong>: #{h(issue.assigned_to)}<br />".html_safe +
76 76 "<strong>#{@cached_label_priority}</strong>: #{h(issue.priority.name)}".html_safe
77 77 end
78 78
79 79 def issue_heading(issue)
80 80 h("#{issue.tracker} ##{issue.id}")
81 81 end
82 82
83 83 def render_issue_subject_with_tree(issue)
84 84 s = ''
85 85 ancestors = issue.root? ? [] : issue.ancestors.visible.to_a
86 86 ancestors.each do |ancestor|
87 87 s << '<div>' + content_tag('p', link_to_issue(ancestor, :project => (issue.project_id != ancestor.project_id)))
88 88 end
89 89 s << '<div>'
90 90 subject = h(issue.subject)
91 91 if issue.is_private?
92 92 subject = content_tag('span', l(:field_is_private), :class => 'private') + ' ' + subject
93 93 end
94 94 s << content_tag('h3', subject)
95 95 s << '</div>' * (ancestors.size + 1)
96 96 s.html_safe
97 97 end
98 98
99 99 def render_descendants_tree(issue)
100 100 s = '<form><table class="list issues">'
101 101 issue_list(issue.descendants.visible.sort_by(&:lft)) do |child, level|
102 102 css = "issue issue-#{child.id} hascontextmenu"
103 103 css << " idnt idnt-#{level}" if level > 0
104 104 s << content_tag('tr',
105 105 content_tag('td', check_box_tag("ids[]", child.id, false, :id => nil), :class => 'checkbox') +
106 106 content_tag('td', link_to_issue(child, :project => (issue.project_id != child.project_id)), :class => 'subject', :style => 'width: 50%') +
107 107 content_tag('td', h(child.status)) +
108 108 content_tag('td', link_to_user(child.assigned_to)) +
109 109 content_tag('td', progress_bar(child.done_ratio, :width => '80px')),
110 110 :class => css)
111 111 end
112 112 s << '</table></form>'
113 113 s.html_safe
114 114 end
115 115
116 116 # Returns an array of error messages for bulk edited issues
117 117 def bulk_edit_error_messages(issues)
118 118 messages = {}
119 119 issues.each do |issue|
120 120 issue.errors.full_messages.each do |message|
121 121 messages[message] ||= []
122 122 messages[message] << issue
123 123 end
124 124 end
125 125 messages.map { |message, issues|
126 126 "#{message}: " + issues.map {|i| "##{i.id}"}.join(', ')
127 127 }
128 128 end
129 129
130 130 # Returns a link for adding a new subtask to the given issue
131 131 def link_to_new_subtask(issue)
132 132 attrs = {
133 133 :tracker_id => issue.tracker,
134 134 :parent_issue_id => issue
135 135 }
136 136 link_to(l(:button_add), new_project_issue_path(issue.project, :issue => attrs))
137 137 end
138 138
139 139 class IssueFieldsRows
140 140 include ActionView::Helpers::TagHelper
141 141
142 142 def initialize
143 143 @left = []
144 144 @right = []
145 145 end
146 146
147 147 def left(*args)
148 148 args.any? ? @left << cells(*args) : @left
149 149 end
150 150
151 151 def right(*args)
152 152 args.any? ? @right << cells(*args) : @right
153 153 end
154 154
155 155 def size
156 156 @left.size > @right.size ? @left.size : @right.size
157 157 end
158 158
159 159 def to_html
160 160 html = ''.html_safe
161 161 blank = content_tag('th', '') + content_tag('td', '')
162 162 size.times do |i|
163 163 left = @left[i] || blank
164 164 right = @right[i] || blank
165 165 html << content_tag('tr', left + right)
166 166 end
167 167 html
168 168 end
169 169
170 170 def cells(label, text, options={})
171 171 content_tag('th', "#{label}:", options) + content_tag('td', text, options)
172 172 end
173 173 end
174 174
175 175 def issue_fields_rows
176 176 r = IssueFieldsRows.new
177 177 yield r
178 178 r.to_html
179 179 end
180 180
181 181 def render_custom_fields_rows(issue)
182 182 values = issue.visible_custom_field_values
183 183 return if values.empty?
184 184 ordered_values = []
185 185 half = (values.size / 2.0).ceil
186 186 half.times do |i|
187 187 ordered_values << values[i]
188 188 ordered_values << values[i + half]
189 189 end
190 190 s = "<tr>\n"
191 191 n = 0
192 192 ordered_values.compact.each do |value|
193 193 css = "cf_#{value.custom_field.id}"
194 194 s << "</tr>\n<tr>\n" if n > 0 && (n % 2) == 0
195 195 s << "\t<th class=\"#{css}\">#{ h(value.custom_field.name) }:</th><td class=\"#{css}\">#{ h(show_value(value)) }</td>\n"
196 196 n += 1
197 197 end
198 198 s << "</tr>\n"
199 199 s.html_safe
200 200 end
201 201
202 202 # Returns the path for updating the issue form
203 203 # with project as the current project
204 204 def update_issue_form_path(project, issue)
205 205 options = {:format => 'js'}
206 206 if issue.new_record?
207 207 if project
208 208 new_project_issue_path(project, options)
209 209 else
210 210 new_issue_path(options)
211 211 end
212 212 else
213 213 edit_issue_path(issue, options)
214 214 end
215 215 end
216 216
217 217 # Returns the number of descendants for an array of issues
218 218 def issues_descendant_count(issues)
219 219 ids = issues.reject(&:leaf?).map {|issue| issue.descendants.ids}.flatten.uniq
220 220 ids -= issues.map(&:id)
221 221 ids.size
222 222 end
223 223
224 224 def issues_destroy_confirmation_message(issues)
225 225 issues = [issues] unless issues.is_a?(Array)
226 226 message = l(:text_issues_destroy_confirmation)
227 227
228 228 descendant_count = issues_descendant_count(issues)
229 229 if descendant_count > 0
230 230 message << "\n" + l(:text_issues_destroy_descendants_confirmation, :count => descendant_count)
231 231 end
232 232 message
233 233 end
234 234
235 235 # Returns an array of users that are proposed as watchers
236 236 # on the new issue form
237 237 def users_for_new_issue_watchers(issue)
238 238 users = issue.watcher_users
239 239 if issue.project.users.count <= 20
240 240 users = (users + issue.project.users.sort).uniq
241 241 end
242 242 users
243 243 end
244 244
245 245 def sidebar_queries
246 246 unless @sidebar_queries
247 247 @sidebar_queries = IssueQuery.visible.
248 248 order("#{Query.table_name}.name ASC").
249 249 # Project specific queries and global queries
250 250 where(@project.nil? ? ["project_id IS NULL"] : ["project_id IS NULL OR project_id = ?", @project.id]).
251 251 to_a
252 252 end
253 253 @sidebar_queries
254 254 end
255 255
256 256 def query_links(title, queries)
257 257 return '' if queries.empty?
258 258 # links to #index on issues/show
259 259 url_params = controller_name == 'issues' ? {:controller => 'issues', :action => 'index', :project_id => @project} : params
260 260
261 261 content_tag('h3', title) + "\n" +
262 262 content_tag('ul',
263 263 queries.collect {|query|
264 264 css = 'query'
265 265 css << ' selected' if query == @query
266 266 content_tag('li', link_to(query.name, url_params.merge(:query_id => query), :class => css))
267 267 }.join("\n").html_safe,
268 268 :class => 'queries'
269 269 ) + "\n"
270 270 end
271 271
272 272 def render_sidebar_queries
273 273 out = ''.html_safe
274 274 out << query_links(l(:label_my_queries), sidebar_queries.select(&:is_private?))
275 275 out << query_links(l(:label_query_plural), sidebar_queries.reject(&:is_private?))
276 276 out
277 277 end
278 278
279 279 def email_issue_attributes(issue, user)
280 280 items = []
281 281 %w(author status priority assigned_to category fixed_version).each do |attribute|
282 282 unless issue.disabled_core_fields.include?(attribute+"_id")
283 283 items << "#{l("field_#{attribute}")}: #{issue.send attribute}"
284 284 end
285 285 end
286 286 issue.visible_custom_field_values(user).each do |value|
287 287 items << "#{value.custom_field.name}: #{show_value(value, false)}"
288 288 end
289 289 items
290 290 end
291 291
292 292 def render_email_issue_attributes(issue, user, html=false)
293 293 items = email_issue_attributes(issue, user)
294 294 if html
295 295 content_tag('ul', items.map{|s| content_tag('li', s)}.join("\n").html_safe)
296 296 else
297 297 items.map{|s| "* #{s}"}.join("\n")
298 298 end
299 299 end
300 300
301 301 # Returns the textual representation of a journal details
302 302 # as an array of strings
303 303 def details_to_strings(details, no_html=false, options={})
304 304 options[:only_path] = (options[:only_path] == false ? false : true)
305 305 strings = []
306 306 values_by_field = {}
307 307 details.each do |detail|
308 308 if detail.property == 'cf'
309 309 field = detail.custom_field
310 310 if field && field.multiple?
311 311 values_by_field[field] ||= {:added => [], :deleted => []}
312 312 if detail.old_value
313 313 values_by_field[field][:deleted] << detail.old_value
314 314 end
315 315 if detail.value
316 316 values_by_field[field][:added] << detail.value
317 317 end
318 318 next
319 319 end
320 320 end
321 321 strings << show_detail(detail, no_html, options)
322 322 end
323 if values_by_field.present?
324 multiple_values_detail = Struct.new(:property, :prop_key, :custom_field, :old_value, :value)
323 325 values_by_field.each do |field, changes|
324 detail = JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s)
325 detail.instance_variable_set "@custom_field", field
326 326 if changes[:added].any?
327 detail = multiple_values_detail.new('cf', field.id.to_s, field)
327 328 detail.value = changes[:added]
328 329 strings << show_detail(detail, no_html, options)
329 elsif changes[:deleted].any?
330 end
331 if changes[:deleted].any?
332 detail = multiple_values_detail.new('cf', field.id.to_s, field)
330 333 detail.old_value = changes[:deleted]
331 334 strings << show_detail(detail, no_html, options)
332 335 end
333 336 end
337 end
334 338 strings
335 339 end
336 340
337 341 # Returns the textual representation of a single journal detail
338 342 def show_detail(detail, no_html=false, options={})
339 343 multiple = false
340 344 show_diff = false
341 345
342 346 case detail.property
343 347 when 'attr'
344 348 field = detail.prop_key.to_s.gsub(/\_id$/, "")
345 349 label = l(("field_" + field).to_sym)
346 350 case detail.prop_key
347 351 when 'due_date', 'start_date'
348 352 value = format_date(detail.value.to_date) if detail.value
349 353 old_value = format_date(detail.old_value.to_date) if detail.old_value
350 354
351 355 when 'project_id', 'status_id', 'tracker_id', 'assigned_to_id',
352 356 'priority_id', 'category_id', 'fixed_version_id'
353 357 value = find_name_by_reflection(field, detail.value)
354 358 old_value = find_name_by_reflection(field, detail.old_value)
355 359
356 360 when 'estimated_hours'
357 361 value = "%0.02f" % detail.value.to_f unless detail.value.blank?
358 362 old_value = "%0.02f" % detail.old_value.to_f unless detail.old_value.blank?
359 363
360 364 when 'parent_id'
361 365 label = l(:field_parent_issue)
362 366 value = "##{detail.value}" unless detail.value.blank?
363 367 old_value = "##{detail.old_value}" unless detail.old_value.blank?
364 368
365 369 when 'is_private'
366 370 value = l(detail.value == "0" ? :general_text_No : :general_text_Yes) unless detail.value.blank?
367 371 old_value = l(detail.old_value == "0" ? :general_text_No : :general_text_Yes) unless detail.old_value.blank?
368 372
369 373 when 'description'
370 374 show_diff = true
371 375 end
372 376 when 'cf'
373 377 custom_field = detail.custom_field
374 378 if custom_field
375 379 label = custom_field.name
376 380 if custom_field.format.class.change_as_diff
377 381 show_diff = true
378 382 else
379 383 multiple = custom_field.multiple?
380 384 value = format_value(detail.value, custom_field) if detail.value
381 385 old_value = format_value(detail.old_value, custom_field) if detail.old_value
382 386 end
383 387 end
384 388 when 'attachment'
385 389 label = l(:label_attachment)
386 390 when 'relation'
387 391 if detail.value && !detail.old_value
388 392 rel_issue = Issue.visible.find_by_id(detail.value)
389 393 value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.value}" :
390 394 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
391 395 elsif detail.old_value && !detail.value
392 396 rel_issue = Issue.visible.find_by_id(detail.old_value)
393 397 old_value = rel_issue.nil? ? "#{l(:label_issue)} ##{detail.old_value}" :
394 398 (no_html ? rel_issue : link_to_issue(rel_issue, :only_path => options[:only_path]))
395 399 end
396 400 relation_type = IssueRelation::TYPES[detail.prop_key]
397 401 label = l(relation_type[:name]) if relation_type
398 402 end
399 403 call_hook(:helper_issues_show_detail_after_setting,
400 404 {:detail => detail, :label => label, :value => value, :old_value => old_value })
401 405
402 406 label ||= detail.prop_key
403 407 value ||= detail.value
404 408 old_value ||= detail.old_value
405 409
406 410 unless no_html
407 411 label = content_tag('strong', label)
408 412 old_value = content_tag("i", h(old_value)) if detail.old_value
409 413 if detail.old_value && detail.value.blank? && detail.property != 'relation'
410 414 old_value = content_tag("del", old_value)
411 415 end
412 416 if detail.property == 'attachment' && value.present? &&
413 417 atta = detail.journal.journalized.attachments.detect {|a| a.id == detail.prop_key.to_i}
414 418 # Link to the attachment if it has not been removed
415 419 value = link_to_attachment(atta, :download => true, :only_path => options[:only_path])
416 420 if options[:only_path] != false && atta.is_text?
417 421 value += link_to(
418 422 image_tag('magnifier.png'),
419 423 :controller => 'attachments', :action => 'show',
420 424 :id => atta, :filename => atta.filename
421 425 )
422 426 end
423 427 else
424 428 value = content_tag("i", h(value)) if value
425 429 end
426 430 end
427 431
428 432 if show_diff
429 433 s = l(:text_journal_changed_no_detail, :label => label)
430 434 unless no_html
431 435 diff_link = link_to 'diff',
432 436 {:controller => 'journals', :action => 'diff', :id => detail.journal_id,
433 437 :detail_id => detail.id, :only_path => options[:only_path]},
434 438 :title => l(:label_view_diff)
435 439 s << " (#{ diff_link })"
436 440 end
437 441 s.html_safe
438 442 elsif detail.value.present?
439 443 case detail.property
440 444 when 'attr', 'cf'
441 445 if detail.old_value.present?
442 446 l(:text_journal_changed, :label => label, :old => old_value, :new => value).html_safe
443 447 elsif multiple
444 448 l(:text_journal_added, :label => label, :value => value).html_safe
445 449 else
446 450 l(:text_journal_set_to, :label => label, :value => value).html_safe
447 451 end
448 452 when 'attachment', 'relation'
449 453 l(:text_journal_added, :label => label, :value => value).html_safe
450 454 end
451 455 else
452 456 l(:text_journal_deleted, :label => label, :old => old_value).html_safe
453 457 end
454 458 end
455 459
456 460 # Find the name of an associated record stored in the field attribute
457 461 def find_name_by_reflection(field, id)
458 462 unless id.present?
459 463 return nil
460 464 end
461 465 @detail_value_name_by_reflection ||= Hash.new do |hash, key|
462 466 association = Issue.reflect_on_association(key.first.to_sym)
463 467 name = nil
464 468 if association
465 469 record = association.klass.find_by_id(key.last)
466 470 if record
467 471 name = record.name.force_encoding('UTF-8')
468 472 end
469 473 end
470 474 hash[key] = name
471 475 end
472 476 @detail_value_name_by_reflection[[field, id]]
473 477 end
474 478
475 479 # Renders issue children recursively
476 480 def render_api_issue_children(issue, api)
477 481 return if issue.leaf?
478 482 api.array :children do
479 483 issue.children.each do |child|
480 484 api.issue(:id => child.id) do
481 485 api.tracker(:id => child.tracker_id, :name => child.tracker.name) unless child.tracker.nil?
482 486 api.subject child.subject
483 487 render_api_issue_children(child, api)
484 488 end
485 489 end
486 490 end
487 491 end
488 492 end
Show file before | Show file after | Hide comments
@@ -1,302 +1,339
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2015 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../../test_helper', __FILE__)
19 19
20 20 class IssuesHelperTest < ActionView::TestCase
21 21 include Redmine::I18n
22 22 include IssuesHelper
23 23 include CustomFieldsHelper
24 24 include ERB::Util
25 25 include Rails.application.routes.url_helpers
26 26
27 27 fixtures :projects, :trackers, :issue_statuses, :issues,
28 28 :enumerations, :users, :issue_categories,
29 29 :projects_trackers,
30 30 :roles,
31 31 :member_roles,
32 32 :members,
33 33 :enabled_modules,
34 34 :custom_fields,
35 35 :attachments,
36 36 :versions
37 37
38 38 def setup
39 39 super
40 40 set_language_if_valid('en')
41 41 User.current = nil
42 42 end
43 43
44 44 def test_issue_heading
45 45 assert_equal "Bug #1", issue_heading(Issue.find(1))
46 46 end
47 47
48 48 def test_issues_destroy_confirmation_message_with_one_root_issue
49 49 assert_equal l(:text_issues_destroy_confirmation),
50 50 issues_destroy_confirmation_message(Issue.find(1))
51 51 end
52 52
53 53 def test_issues_destroy_confirmation_message_with_an_arrayt_of_root_issues
54 54 assert_equal l(:text_issues_destroy_confirmation),
55 55 issues_destroy_confirmation_message(Issue.find([1, 2]))
56 56 end
57 57
58 58 def test_issues_destroy_confirmation_message_with_one_parent_issue
59 59 Issue.find(2).update_attribute :parent_issue_id, 1
60 60 assert_equal l(:text_issues_destroy_confirmation) + "\n" +
61 61 l(:text_issues_destroy_descendants_confirmation, :count => 1),
62 62 issues_destroy_confirmation_message(Issue.find(1))
63 63 end
64 64
65 65 def test_issues_destroy_confirmation_message_with_one_parent_issue_and_its_child
66 66 Issue.find(2).update_attribute :parent_issue_id, 1
67 67 assert_equal l(:text_issues_destroy_confirmation),
68 68 issues_destroy_confirmation_message(Issue.find([1, 2]))
69 69 end
70 70
71 71 def test_issues_destroy_confirmation_message_with_issues_that_share_descendants
72 72 root = Issue.generate!
73 73 child = Issue.generate!(:parent_issue_id => root.id)
74 74 Issue.generate!(:parent_issue_id => child.id)
75 75
76 76 assert_equal l(:text_issues_destroy_confirmation) + "\n" +
77 77 l(:text_issues_destroy_descendants_confirmation, :count => 1),
78 78 issues_destroy_confirmation_message([root.reload, child.reload])
79 79 end
80 80
81 81 test 'show_detail with no_html should show a changing attribute' do
82 82 detail = JournalDetail.new(:property => 'attr', :old_value => '40',
83 83 :value => '100', :prop_key => 'done_ratio')
84 84 assert_equal "% Done changed from 40 to 100", show_detail(detail, true)
85 85 end
86 86
87 87 test 'show_detail with no_html should show a new attribute' do
88 88 detail = JournalDetail.new(:property => 'attr', :old_value => nil,
89 89 :value => '100', :prop_key => 'done_ratio')
90 90 assert_equal "% Done set to 100", show_detail(detail, true)
91 91 end
92 92
93 93 test 'show_detail with no_html should show a deleted attribute' do
94 94 detail = JournalDetail.new(:property => 'attr', :old_value => '50',
95 95 :value => nil, :prop_key => 'done_ratio')
96 96 assert_equal "% Done deleted (50)", show_detail(detail, true)
97 97 end
98 98
99 99 test 'show_detail with html should show a changing attribute with HTML highlights' do
100 100 detail = JournalDetail.new(:property => 'attr', :old_value => '40',
101 101 :value => '100', :prop_key => 'done_ratio')
102 102 html = show_detail(detail, false)
103 103 assert_include '<strong>% Done</strong>', html
104 104 assert_include '<i>40</i>', html
105 105 assert_include '<i>100</i>', html
106 106 end
107 107
108 108 test 'show_detail with html should show a new attribute with HTML highlights' do
109 109 detail = JournalDetail.new(:property => 'attr', :old_value => nil,
110 110 :value => '100', :prop_key => 'done_ratio')
111 111 html = show_detail(detail, false)
112 112 assert_include '<strong>% Done</strong>', html
113 113 assert_include '<i>100</i>', html
114 114 end
115 115
116 116 test 'show_detail with html should show a deleted attribute with HTML highlights' do
117 117 detail = JournalDetail.new(:property => 'attr', :old_value => '50',
118 118 :value => nil, :prop_key => 'done_ratio')
119 119 html = show_detail(detail, false)
120 120 assert_include '<strong>% Done</strong>', html
121 121 assert_include '<del><i>50</i></del>', html
122 122 end
123 123
124 124 test 'show_detail with a start_date attribute should format the dates' do
125 125 detail = JournalDetail.new(
126 126 :property => 'attr',
127 127 :old_value => '2010-01-01',
128 128 :value => '2010-01-31',
129 129 :prop_key => 'start_date'
130 130 )
131 131 with_settings :date_format => '%m/%d/%Y' do
132 132 assert_match "01/31/2010", show_detail(detail, true)
133 133 assert_match "01/01/2010", show_detail(detail, true)
134 134 end
135 135 end
136 136
137 137 test 'show_detail with a due_date attribute should format the dates' do
138 138 detail = JournalDetail.new(
139 139 :property => 'attr',
140 140 :old_value => '2010-01-01',
141 141 :value => '2010-01-31',
142 142 :prop_key => 'due_date'
143 143 )
144 144 with_settings :date_format => '%m/%d/%Y' do
145 145 assert_match "01/31/2010", show_detail(detail, true)
146 146 assert_match "01/01/2010", show_detail(detail, true)
147 147 end
148 148 end
149 149
150 150 test 'show_detail should show old and new values with a project attribute' do
151 151 detail = JournalDetail.new(:property => 'attr', :prop_key => 'project_id',
152 152 :old_value => 1, :value => 2)
153 153 assert_match 'eCookbook', show_detail(detail, true)
154 154 assert_match 'OnlineStore', show_detail(detail, true)
155 155 end
156 156
157 157 test 'show_detail should show old and new values with a issue status attribute' do
158 158 detail = JournalDetail.new(:property => 'attr', :prop_key => 'status_id',
159 159 :old_value => 1, :value => 2)
160 160 assert_match 'New', show_detail(detail, true)
161 161 assert_match 'Assigned', show_detail(detail, true)
162 162 end
163 163
164 164 test 'show_detail should show old and new values with a tracker attribute' do
165 165 detail = JournalDetail.new(:property => 'attr', :prop_key => 'tracker_id',
166 166 :old_value => 1, :value => 2)
167 167 assert_match 'Bug', show_detail(detail, true)
168 168 assert_match 'Feature request', show_detail(detail, true)
169 169 end
170 170
171 171 test 'show_detail should show old and new values with a assigned to attribute' do
172 172 detail = JournalDetail.new(:property => 'attr', :prop_key => 'assigned_to_id',
173 173 :old_value => 1, :value => 2)
174 174 assert_match 'Redmine Admin', show_detail(detail, true)
175 175 assert_match 'John Smith', show_detail(detail, true)
176 176 end
177 177
178 178 test 'show_detail should show old and new values with a priority attribute' do
179 179 detail = JournalDetail.new(:property => 'attr', :prop_key => 'priority_id',
180 180 :old_value => 4, :value => 5)
181 181 assert_match 'Low', show_detail(detail, true)
182 182 assert_match 'Normal', show_detail(detail, true)
183 183 end
184 184
185 185 test 'show_detail should show old and new values with a category attribute' do
186 186 detail = JournalDetail.new(:property => 'attr', :prop_key => 'category_id',
187 187 :old_value => 1, :value => 2)
188 188 assert_match 'Printing', show_detail(detail, true)
189 189 assert_match 'Recipes', show_detail(detail, true)
190 190 end
191 191
192 192 test 'show_detail should show old and new values with a fixed version attribute' do
193 193 detail = JournalDetail.new(:property => 'attr', :prop_key => 'fixed_version_id',
194 194 :old_value => 1, :value => 2)
195 195 assert_match '0.1', show_detail(detail, true)
196 196 assert_match '1.0', show_detail(detail, true)
197 197 end
198 198
199 199 test 'show_detail should show old and new values with a estimated hours attribute' do
200 200 detail = JournalDetail.new(:property => 'attr', :prop_key => 'estimated_hours',
201 201 :old_value => '5', :value => '6.3')
202 202 assert_match '5.00', show_detail(detail, true)
203 203 assert_match '6.30', show_detail(detail, true)
204 204 end
205 205
206 206 test 'show_detail should not show values with a description attribute' do
207 207 detail = JournalDetail.new(:property => 'attr', :prop_key => 'description',
208 208 :old_value => 'Foo', :value => 'Bar')
209 209 assert_equal 'Description updated', show_detail(detail, true)
210 210 end
211 211
212 212 test 'show_detail should show old and new values with a custom field' do
213 213 detail = JournalDetail.new(:property => 'cf', :prop_key => '1',
214 214 :old_value => 'MySQL', :value => 'PostgreSQL')
215 215 assert_equal 'Database changed from MySQL to PostgreSQL', show_detail(detail, true)
216 216 end
217 217
218 218 test 'show_detail should not show values with a long text custom field' do
219 219 field = IssueCustomField.create!(:name => "Long field", :field_format => 'text')
220 220 detail = JournalDetail.new(:property => 'cf', :prop_key => field.id,
221 221 :old_value => 'Foo', :value => 'Bar')
222 222 assert_equal 'Long field updated', show_detail(detail, true)
223 223 end
224 224
225 225 test 'show_detail should show added file' do
226 226 detail = JournalDetail.new(:property => 'attachment', :prop_key => '1',
227 227 :old_value => nil, :value => 'error281.txt')
228 228 assert_match 'error281.txt', show_detail(detail, true)
229 229 end
230 230
231 231 test 'show_detail should show removed file' do
232 232 detail = JournalDetail.new(:property => 'attachment', :prop_key => '1',
233 233 :old_value => 'error281.txt', :value => nil)
234 234 assert_match 'error281.txt', show_detail(detail, true)
235 235 end
236 236
237 237 def test_show_detail_relation_added
238 238 detail = JournalDetail.new(:property => 'relation',
239 239 :prop_key => 'precedes',
240 240 :value => 1)
241 241 assert_equal "Precedes Bug #1: Cannot print recipes added", show_detail(detail, true)
242 242 str = link_to("Bug #1", "/issues/1", :class => Issue.find(1).css_classes)
243 243 assert_equal "<strong>Precedes</strong> <i>#{str}: Cannot print recipes</i> added",
244 244 show_detail(detail, false)
245 245 end
246 246
247 247 def test_show_detail_relation_added_with_inexistant_issue
248 248 inexistant_issue_number = 9999
249 249 assert_nil Issue.find_by_id(inexistant_issue_number)
250 250 detail = JournalDetail.new(:property => 'relation',
251 251 :prop_key => 'precedes',
252 252 :value => inexistant_issue_number)
253 253 assert_equal "Precedes Issue ##{inexistant_issue_number} added", show_detail(detail, true)
254 254 assert_equal "<strong>Precedes</strong> <i>Issue ##{inexistant_issue_number}</i> added", show_detail(detail, false)
255 255 end
256 256
257 257 def test_show_detail_relation_added_should_not_disclose_issue_that_is_not_visible
258 258 issue = Issue.generate!(:is_private => true)
259 259 detail = JournalDetail.new(:property => 'relation',
260 260 :prop_key => 'precedes',
261 261 :value => issue.id)
262 262
263 263 assert_equal "Precedes Issue ##{issue.id} added", show_detail(detail, true)
264 264 assert_equal "<strong>Precedes</strong> <i>Issue ##{issue.id}</i> added", show_detail(detail, false)
265 265 end
266 266
267 267 def test_show_detail_relation_deleted
268 268 detail = JournalDetail.new(:property => 'relation',
269 269 :prop_key => 'precedes',
270 270 :old_value => 1)
271 271 assert_equal "Precedes deleted (Bug #1: Cannot print recipes)", show_detail(detail, true)
272 272 str = link_to("Bug #1",
273 273 "/issues/1",
274 274 :class => Issue.find(1).css_classes)
275 275 assert_equal "<strong>Precedes</strong> deleted (<i>#{str}: Cannot print recipes</i>)",
276 276 show_detail(detail, false)
277 277 end
278 278
279 279 def test_show_detail_relation_deleted_with_inexistant_issue
280 280 inexistant_issue_number = 9999
281 281 assert_nil Issue.find_by_id(inexistant_issue_number)
282 282 detail = JournalDetail.new(:property => 'relation',
283 283 :prop_key => 'precedes',
284 284 :old_value => inexistant_issue_number)
285 285 assert_equal "Precedes deleted (Issue #9999)", show_detail(detail, true)
286 286 assert_equal "<strong>Precedes</strong> deleted (<i>Issue #9999</i>)", show_detail(detail, false)
287 287 end
288 288
289 289 def test_show_detail_relation_deleted_should_not_disclose_issue_that_is_not_visible
290 290 issue = Issue.generate!(:is_private => true)
291 291 detail = JournalDetail.new(:property => 'relation',
292 292 :prop_key => 'precedes',
293 293 :old_value => issue.id)
294 294
295 295 assert_equal "Precedes deleted (Issue ##{issue.id})", show_detail(detail, true)
296 296 assert_equal "<strong>Precedes</strong> deleted (<i>Issue ##{issue.id}</i>)", show_detail(detail, false)
297 297 end
298 298
299 def test_details_to_strings_with_multiple_values_removed_from_custom_field
300 field = IssueCustomField.generate!(:name => 'User', :field_format => 'user', :multiple => true)
301 details = []
302 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => '1', :value => nil)
303 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => '3', :value => nil)
304
305 assert_equal ["User deleted (Dave Lopper, Redmine Admin)"], details_to_strings(details, true)
306 assert_equal ["<strong>User</strong> deleted (<del><i>Dave Lopper, Redmine Admin</i></del>)"], details_to_strings(details, false)
307 end
308
309 def test_details_to_strings_with_multiple_values_added_to_custom_field
310 field = IssueCustomField.generate!(:name => 'User', :field_format => 'user', :multiple => true)
311 details = []
312 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => nil, :value => '1')
313 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => nil, :value => '3')
314
315 assert_equal ["User Dave Lopper, Redmine Admin added"], details_to_strings(details, true)
316 assert_equal ["<strong>User</strong> <i>Dave Lopper, Redmine Admin</i> added"], details_to_strings(details, false)
317 end
318
319 def test_details_to_strings_with_multiple_values_added_and_removed_from_custom_field
320 field = IssueCustomField.generate!(:name => 'User', :field_format => 'user', :multiple => true)
321 details = []
322 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => nil, :value => '1')
323 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => '2', :value => nil)
324 details << JournalDetail.new(:property => 'cf', :prop_key => field.id.to_s, :old_value => '3', :value => nil)
325
326 assert_equal [
327 "User Redmine Admin added",
328 "User deleted (Dave Lopper, John Smith)"
329 ], details_to_strings(details, true)
330 assert_equal [
331 "<strong>User</strong> <i>Redmine Admin</i> added",
332 "<strong>User</strong> deleted (<del><i>Dave Lopper, John Smith</i></del>)"
333 ], details_to_strings(details, false)
334 end
335
299 336 def test_find_name_by_reflection_should_return_nil_for_missing_record
300 337 assert_nil find_name_by_reflection('status', 99)
301 338 end
302 339 end
General Comments 0
You need to be logged in to leave comments. Login now