jro_apps/redmine Commit - r13908:78384d147a48

Menu should not include "New issue" for users with copy issues permission only....

Jean-Philippe Lang -

r13908:78384d147a48

parent child

Context file:

r13908:78384d147a48

Collapse all files

lib/redmine.rb +2 -1

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require 'redmine/core_ext'
             begin
               require 'rmagick' unless Object.const_defined?(:Magick)
             rescue LoadError
               # RMagick is not available
             end
             begin
               require 'redcarpet' unless Object.const_defined?(:Redcarpet)
             rescue LoadError
               # Redcarpet is not available
             end
             require 'redmine/scm/base'
             require 'redmine/access_control'
             require 'redmine/access_keys'
             require 'redmine/activity'
             require 'redmine/activity/fetcher'
             require 'redmine/ciphering'
             require 'redmine/codeset_util'
             require 'redmine/field_format'
             require 'redmine/i18n'
             require 'redmine/menu_manager'
             require 'redmine/notifiable'
             require 'redmine/platform'
             require 'redmine/mime_type'
             require 'redmine/notifiable'
             require 'redmine/search'
             require 'redmine/syntax_highlighting'
             require 'redmine/thumbnail'
             require 'redmine/unified_diff'
             require 'redmine/utils'
             require 'redmine/version'
             require 'redmine/wiki_formatting'
             require 'redmine/default_data/loader'
             require 'redmine/helpers/calendar'
             require 'redmine/helpers/diff'
             require 'redmine/helpers/gantt'
             require 'redmine/helpers/time_report'
             require 'redmine/views/other_formats_builder'
             require 'redmine/views/labelled_form_builder'
             require 'redmine/views/builders'
             require 'redmine/themes'
             require 'redmine/hook'
             require 'redmine/plugin'
             require 'csv'
             Redmine::Scm::Base.add "Subversion"
             Redmine::Scm::Base.add "Darcs"
             Redmine::Scm::Base.add "Mercurial"
             Redmine::Scm::Base.add "Cvs"
             Redmine::Scm::Base.add "Bazaar"
             Redmine::Scm::Base.add "Git"
             Redmine::Scm::Base.add "Filesystem"
             # Permissions
             Redmine::AccessControl.map do |map|
               map.permission :view_project, {:projects => [:show], :activities => [:index]}, :public => true, :read => true
               map.permission :search_project, {:search => :index}, :public => true, :read => true
               map.permission :add_project, {:projects => [:new, :create]}, :require => :loggedin
               map.permission :edit_project, {:projects => [:settings, :edit, :update]}, :require => :member
               map.permission :close_project, {:projects => [:close, :reopen]}, :require => :member, :read => true
               map.permission :select_project_modules, {:projects => :modules}, :require => :member
               map.permission :view_members, {:members => [:index, :show]}, :public => true, :read => true
               map.permission :manage_members, {:projects => :settings, :members => [:index, :show, :new, :create, :update, :destroy, :autocomplete]}, :require => :member
               map.permission :manage_versions, {:projects => :settings, :versions => [:new, :create, :edit, :update, :close_completed, :destroy]}, :require => :member
               map.permission :add_subprojects, {:projects => [:new, :create]}, :require => :member
               map.project_module :issue_tracking do |map|
                 # Issue categories
                 map.permission :manage_categories, {:projects => :settings, :issue_categories => [:index, :show, :new, :create, :edit, :update, :destroy]}, :require => :member
                 # Issues
                 map.permission :view_issues, {:issues => [:index, :show],
                                               :auto_complete => [:issues],
                                               :context_menus => [:issues],
                                               :versions => [:index, :show, :status_by],
                                               :journals => [:index, :diff],
                                               :queries => :index,
                                               :reports => [:issue_report, :issue_report_details]},
                                               :read => true
                 map.permission :add_issues, {:issues => [:new, :create], :attachments => :upload}
                 map.permission :edit_issues, {:issues => [:edit, :update, :bulk_edit, :bulk_update], :journals => [:new], :attachments => :upload}
                 map.permission :copy_issues, {:issues => [:new, :create, :bulk_edit, :bulk_update], :attachments => :upload}
                 map.permission :manage_issue_relations, {:issue_relations => [:index, :show, :create, :destroy]}
                 map.permission :manage_subtasks, {}
                 map.permission :set_issues_private, {}
                 map.permission :set_own_issues_private, {}, :require => :loggedin
                 map.permission :add_issue_notes, {:issues => [:edit, :update], :journals => [:new], :attachments => :upload}
                 map.permission :edit_issue_notes, {:journals => :edit}, :require => :loggedin
                 map.permission :edit_own_issue_notes, {:journals => :edit}, :require => :loggedin
                 map.permission :view_private_notes, {}, :read => true, :require => :member
                 map.permission :set_notes_private, {}, :require => :member
                 map.permission :delete_issues, {:issues => :destroy}, :require => :member
                 # Queries
                 map.permission :manage_public_queries, {:queries => [:new, :create, :edit, :update, :destroy]}, :require => :member
                 map.permission :save_queries, {:queries => [:new, :create, :edit, :update, :destroy]}, :require => :loggedin
                 # Watchers
                 map.permission :view_issue_watchers, {}, :read => true
                 map.permission :add_issue_watchers, {:watchers => [:new, :create, :append, :autocomplete_for_user]}
                 map.permission :delete_issue_watchers, {:watchers => :destroy}
               end
               map.project_module :time_tracking do |map|
                 map.permission :log_time, {:timelog => [:new, :create]}, :require => :loggedin
                 map.permission :view_time_entries, {:timelog => [:index, :report, :show]}, :read => true
                 map.permission :edit_time_entries, {:timelog => [:edit, :update, :destroy, :bulk_edit, :bulk_update]}, :require => :member
                 map.permission :edit_own_time_entries, {:timelog => [:edit, :update, :destroy,:bulk_edit, :bulk_update]}, :require => :loggedin
                 map.permission :manage_project_activities, {:project_enumerations => [:update, :destroy]}, :require => :member
               end
               map.project_module :news do |map|
                 map.permission :manage_news, {:news => [:new, :create, :edit, :update, :destroy], :comments => [:destroy], :attachments => :upload}, :require => :member
                 map.permission :view_news, {:news => [:index, :show]}, :public => true, :read => true
                 map.permission :comment_news, {:comments => :create}
               end
               map.project_module :documents do |map|
                 map.permission :add_documents, {:documents => [:new, :create, :add_attachment], :attachments => :upload}, :require => :loggedin
                 map.permission :edit_documents, {:documents => [:edit, :update, :add_attachment], :attachments => :upload}, :require => :loggedin
                 map.permission :delete_documents, {:documents => [:destroy]}, :require => :loggedin
                 map.permission :view_documents, {:documents => [:index, :show, :download]}, :read => true
               end
               map.project_module :files do |map|
                 map.permission :manage_files, {:files => [:new, :create], :attachments => :upload}, :require => :loggedin
                 map.permission :view_files, {:files => :index, :versions => :download}, :read => true
               end
               map.project_module :wiki do |map|
                 map.permission :manage_wiki, {:wikis => [:edit, :destroy]}, :require => :member
                 map.permission :rename_wiki_pages, {:wiki => :rename}, :require => :member
                 map.permission :delete_wiki_pages, {:wiki => [:destroy, :destroy_version]}, :require => :member
                 map.permission :view_wiki_pages, {:wiki => [:index, :show, :special, :date_index]}, :read => true
                 map.permission :export_wiki_pages, {:wiki => [:export]}, :read => true
                 map.permission :view_wiki_edits, {:wiki => [:history, :diff, :annotate]}, :read => true
                 map.permission :edit_wiki_pages, :wiki => [:edit, :update, :preview, :add_attachment], :attachments => :upload
                 map.permission :delete_wiki_pages_attachments, {}
                 map.permission :protect_wiki_pages, {:wiki => :protect}, :require => :member
               end
               map.project_module :repository do |map|
                 map.permission :manage_repository, {:repositories => [:new, :create, :edit, :update, :committers, :destroy]}, :require => :member
                 map.permission :browse_repository, {:repositories => [:show, :browse, :entry, :raw, :annotate, :changes, :diff, :stats, :graph]}, :read => true
                 map.permission :view_changesets, {:repositories => [:show, :revisions, :revision]}, :read => true
                 map.permission :commit_access, {}
                 map.permission :manage_related_issues, {:repositories => [:add_related_issue, :remove_related_issue]}
               end
               map.project_module :boards do |map|
                 map.permission :manage_boards, {:boards => [:new, :create, :edit, :update, :destroy]}, :require => :member
                 map.permission :view_messages, {:boards => [:index, :show], :messages => [:show]}, :public => true, :read => true
                 map.permission :add_messages, {:messages => [:new, :reply, :quote], :attachments => :upload}
                 map.permission :edit_messages, {:messages => :edit, :attachments => :upload}, :require => :member
                 map.permission :edit_own_messages, {:messages => :edit, :attachments => :upload}, :require => :loggedin
                 map.permission :delete_messages, {:messages => :destroy}, :require => :member
                 map.permission :delete_own_messages, {:messages => :destroy}, :require => :loggedin
               end
               map.project_module :calendar do |map|
                 map.permission :view_calendar, {:calendars => [:show, :update]}, :read => true
               end
               map.project_module :gantt do |map|
                 map.permission :view_gantt, {:gantts => [:show, :update]}, :read => true
               end
             end
             Redmine::MenuManager.map :top_menu do |menu|
               menu.push :home, :home_path
               menu.push :my_page, { :controller => 'my', :action => 'page' }, :if => Proc.new { User.current.logged? }
               menu.push :projects, { :controller => 'projects', :action => 'index' }, :caption => :label_project_plural
               menu.push :administration, { :controller => 'admin', :action => 'index' }, :if => Proc.new { User.current.admin? }, :last => true
               menu.push :help, Redmine::Info.help_url, :last => true
             end
             Redmine::MenuManager.map :account_menu do |menu|
               menu.push :login, :signin_path, :if => Proc.new { !User.current.logged? }
               menu.push :register, :register_path, :if => Proc.new { !User.current.logged? && Setting.self_registration? }
               menu.push :my_account, { :controller => 'my', :action => 'account' }, :if => Proc.new { User.current.logged? }
               menu.push :logout, :signout_path, :html => {:method => 'post'}, :if => Proc.new { User.current.logged? }
             end
             Redmine::MenuManager.map :application_menu do |menu|
               # Empty
             end
             Redmine::MenuManager.map :admin_menu do |menu|
               menu.push :projects, {:controller => 'admin', :action => 'projects'}, :caption => :label_project_plural
               menu.push :users, {:controller => 'users'}, :caption => :label_user_plural
               menu.push :groups, {:controller => 'groups'}, :caption => :label_group_plural
               menu.push :roles, {:controller => 'roles'}, :caption => :label_role_and_permissions
               menu.push :trackers, {:controller => 'trackers'}, :caption => :label_tracker_plural
               menu.push :issue_statuses, {:controller => 'issue_statuses'}, :caption => :label_issue_status_plural,
                         :html => {:class => 'issue_statuses'}
               menu.push :workflows, {:controller => 'workflows', :action => 'edit'}, :caption => :label_workflow
               menu.push :custom_fields, {:controller => 'custom_fields'},  :caption => :label_custom_field_plural,
                         :html => {:class => 'custom_fields'}
               menu.push :enumerations, {:controller => 'enumerations'}
               menu.push :settings, {:controller => 'settings'}
               menu.push :ldap_authentication, {:controller => 'auth_sources', :action => 'index'},
                         :html => {:class => 'server_authentication'}
               menu.push :plugins, {:controller => 'admin', :action => 'plugins'}, :last => true
               menu.push :info, {:controller => 'admin', :action => 'info'}, :caption => :label_information_plural, :last => true
             end
             Redmine::MenuManager.map :project_menu do |menu|
               menu.push :overview, { :controller => 'projects', :action => 'show' }
               menu.push :activity, { :controller => 'activities', :action => 'index' }
               menu.push :roadmap, { :controller => 'versions', :action => 'index' }, :param => :project_id,
                           :if => Proc.new { |p| p.shared_versions.any? }
               menu.push :issues, { :controller => 'issues', :action => 'index' }, :param => :project_id, :caption => :label_issue_plural
               menu.push :new_issue, { :controller => 'issues', :action => 'new', :copy_from => nil }, :param => :project_id, :caption => :label_issue_new,
                           :html => { :accesskey => Redmine::AccessKeys.key_for(:new_issue) },
-                          :if => Proc.new { |p| p.trackers.any? }
+                          :if => Proc.new { |p| p.trackers.any? },
+                          :permission => :add_issues
               menu.push :gantt, { :controller => 'gantts', :action => 'show' }, :param => :project_id, :caption => :label_gantt
               menu.push :calendar, { :controller => 'calendars', :action => 'show' }, :param => :project_id, :caption => :label_calendar
               menu.push :news, { :controller => 'news', :action => 'index' }, :param => :project_id, :caption => :label_news_plural
               menu.push :documents, { :controller => 'documents', :action => 'index' }, :param => :project_id, :caption => :label_document_plural
               menu.push :wiki, { :controller => 'wiki', :action => 'show', :id => nil }, :param => :project_id,
                           :if => Proc.new { |p| p.wiki && !p.wiki.new_record? }
               menu.push :boards, { :controller => 'boards', :action => 'index', :id => nil }, :param => :project_id,
                           :if => Proc.new { |p| p.boards.any? }, :caption => :label_board_plural
               menu.push :files, { :controller => 'files', :action => 'index' }, :caption => :label_file_plural, :param => :project_id
               menu.push :repository, { :controller => 'repositories', :action => 'show', :repository_id => nil, :path => nil, :rev => nil },
                           :if => Proc.new { |p| p.repository && !p.repository.new_record? }
               menu.push :settings, { :controller => 'projects', :action => 'settings' }, :last => true
             end
             Redmine::Activity.map do |activity|
               activity.register :issues, :class_name => %w(Issue Journal)
               activity.register :changesets
               activity.register :news
               activity.register :documents, :class_name => %w(Document Attachment)
               activity.register :files, :class_name => 'Attachment'
               activity.register :wiki_edits, :class_name => 'WikiContent::Version', :default => false
               activity.register :messages, :default => false
               activity.register :time_entries, :default => false
             end
             Redmine::Search.map do |search|
               search.register :issues
               search.register :news
               search.register :documents
               search.register :changesets
               search.register :wiki_pages
               search.register :messages
               search.register :projects
             end
             Redmine::WikiFormatting.map do |format|
               format.register :textile, Redmine::WikiFormatting::Textile::Formatter, Redmine::WikiFormatting::Textile::Helper
               if Object.const_defined?(:Redcarpet)
                 format.register :markdown, Redmine::WikiFormatting::Markdown::Formatter, Redmine::WikiFormatting::Markdown::Helper,
                   :label => 'Markdown'
               end
             end
             ActionView::Template.register_template_handler :rsb, Redmine::Views::ApiTemplateHandler

test/functional/projects_controller_test.rb +10 0

             # Redmine - project management software
             # Copyright (C) 2006-2015  Jean-Philippe Lang
             #
             # This program is free software; you can redistribute it and/or
             # modify it under the terms of the GNU General Public License
             # as published by the Free Software Foundation; either version 2
             # of the License, or (at your option) any later version.
             #
             # This program is distributed in the hope that it will be useful,
             # but WITHOUT ANY WARRANTY; without even the implied warranty of
             # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
             # GNU General Public License for more details.
             #
             # You should have received a copy of the GNU General Public License
             # along with this program; if not, write to the Free Software
             # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
             require File.expand_path('../../test_helper', __FILE__)
             class ProjectsControllerTest < ActionController::TestCase
               fixtures :projects, :versions, :users, :email_addresses, :roles, :members,
                        :member_roles, :issues, :journals, :journal_details,
                        :trackers, :projects_trackers, :issue_statuses,
                        :enabled_modules, :enumerations, :boards, :messages,
                        :attachments, :custom_fields, :custom_values, :time_entries,
                        :wikis, :wiki_pages, :wiki_contents, :wiki_content_versions
               def setup
                 @request.session[:user_id] = nil
                 Setting.default_language = 'en'
               end
               def test_index_by_anonymous_should_not_show_private_projects
                 get :index
                 assert_response :success
                 assert_template 'index'
                 projects = assigns(:projects)
                 assert_not_nil projects
                 assert projects.all?(&:is_public?)
                 assert_select 'ul' do
                   assert_select 'li' do
                     assert_select 'a', :text => 'eCookbook'
                     assert_select 'ul' do
                       assert_select 'a', :text => 'Child of private child'
                     end
                   end
                 end
                 assert_select 'a', :text => /Private child of eCookbook/, :count => 0
               end
               def test_index_atom
                 get :index, :format => 'atom'
                 assert_response :success
                 assert_template 'common/feed'
                 assert_select 'feed>title', :text => 'Redmine: Latest projects'
                 assert_select 'feed>entry', :count => Project.visible(User.current).count
               end
               test "#index by non-admin user with view_time_entries permission should show overall spent time link" do
                 @request.session[:user_id] = 3
                 get :index
                 assert_template 'index'
                 assert_select 'a[href=?]', '/time_entries'
               end
               test "#index by non-admin user without view_time_entries permission should not show overall spent time link" do
                 Role.find(2).remove_permission! :view_time_entries
                 Role.non_member.remove_permission! :view_time_entries
                 Role.anonymous.remove_permission! :view_time_entries
                 @request.session[:user_id] = 3
                 get :index
                 assert_template 'index'
                 assert_select 'a[href=?]', '/time_entries', 0
               end
               test "#index by non-admin user with permission should show add project link" do
                 Role.find(1).add_permission! :add_project
                 @request.session[:user_id] = 2
                 get :index
                 assert_template 'index'
                 assert_select 'a[href=?]', '/projects/new'
               end
               test "#new by admin user should accept get" do
                 @request.session[:user_id] = 1
                 get :new
                 assert_response :success
                 assert_template 'new'
               end
               test "#new by non-admin user with add_project permission should accept get" do
                 Role.non_member.add_permission! :add_project
                 @request.session[:user_id] = 9
                 get :new
                 assert_response :success
                 assert_template 'new'
                 assert_select 'select[name=?]', 'project[parent_id]', 0
               end
               test "#new by non-admin user with add_subprojects permission should accept get" do
                 Role.find(1).remove_permission! :add_project
                 Role.find(1).add_permission! :add_subprojects
                 @request.session[:user_id] = 2
                 get :new, :parent_id => 'ecookbook'
                 assert_response :success
                 assert_template 'new'
                 assert_select 'select[name=?]', 'project[parent_id]' do
                   # parent project selected
                   assert_select 'option[value="1"][selected=selected]'
                   # no empty value
                   assert_select 'option[value=""]', 0
                 end
               end
               test "#create by admin user should create a new project" do
                 @request.session[:user_id] = 1
                 post :create,
                   :project => {
                     :name => "blog",
                     :description => "weblog",
                     :homepage => 'http://weblog',
                     :identifier => "blog",
                     :is_public => 1,
                     :custom_field_values => { '3' => 'Beta' },
                     :tracker_ids => ['1', '3'],
                     # an issue custom field that is not for all project
                     :issue_custom_field_ids => ['9'],
                     :enabled_module_names => ['issue_tracking', 'news', 'repository']
                   }
                 assert_redirected_to '/projects/blog/settings'
                 project = Project.find_by_name('blog')
                 assert_kind_of Project, project
                 assert project.active?
                 assert_equal 'weblog', project.description
                 assert_equal 'http://weblog', project.homepage
                 assert_equal true, project.is_public?
                 assert_nil project.parent
                 assert_equal 'Beta', project.custom_value_for(3).value
                 assert_equal [1, 3], project.trackers.map(&:id).sort
                 assert_equal ['issue_tracking', 'news', 'repository'], project.enabled_module_names.sort
                 assert project.issue_custom_fields.include?(IssueCustomField.find(9))
               end
               test "#create by admin user should create a new subproject" do
                 @request.session[:user_id] = 1
                 assert_difference 'Project.count' do
                   post :create, :project => { :name => "blog",
                                            :description => "weblog",
                                            :identifier => "blog",
                                            :is_public => 1,
                                            :custom_field_values => { '3' => 'Beta' },
                                            :parent_id => 1
                                           }
                   assert_redirected_to '/projects/blog/settings'
                 end
                 project = Project.find_by_name('blog')
                 assert_kind_of Project, project
                 assert_equal Project.find(1), project.parent
               end
               test "#create by admin user should continue" do
                 @request.session[:user_id] = 1
                 assert_difference 'Project.count' do
                   post :create, :project => {:name => "blog", :identifier => "blog"}, :continue => 'Create and continue'
                 end
                 assert_redirected_to '/projects/new'
               end
               test "#create by non-admin user with add_project permission should create a new project" do
                 Role.non_member.add_permission! :add_project
                 @request.session[:user_id] = 9
                 post :create, :project => { :name => "blog",
                                          :description => "weblog",
                                          :identifier => "blog",
                                          :is_public => 1,
                                          :custom_field_values => { '3' => 'Beta' },
                                          :tracker_ids => ['1', '3'],
                                          :enabled_module_names => ['issue_tracking', 'news', 'repository']
                                         }
                 assert_redirected_to '/projects/blog/settings'
                 project = Project.find_by_name('blog')
                 assert_kind_of Project, project
                 assert_equal 'weblog', project.description
                 assert_equal true, project.is_public?
                 assert_equal [1, 3], project.trackers.map(&:id).sort
                 assert_equal ['issue_tracking', 'news', 'repository'], project.enabled_module_names.sort
                 # User should be added as a project member
                 assert User.find(9).member_of?(project)
                 assert_equal 1, project.members.size
               end
               test "#create by non-admin user with add_project permission should fail with parent_id" do
                 Role.non_member.add_permission! :add_project
                 @request.session[:user_id] = 9
                 assert_no_difference 'Project.count' do
                   post :create, :project => { :name => "blog",
                                            :description => "weblog",
                                            :identifier => "blog",
                                            :is_public => 1,
                                            :custom_field_values => { '3' => 'Beta' },
                                            :parent_id => 1
                                           }
                 end
                 assert_response :success
                 project = assigns(:project)
                 assert_kind_of Project, project
                 assert_not_equal [], project.errors[:parent_id]
               end
               test "#create by non-admin user with add_subprojects permission should create a project with a parent_id" do
                 Role.find(1).remove_permission! :add_project
                 Role.find(1).add_permission! :add_subprojects
                 @request.session[:user_id] = 2
                 post :create, :project => { :name => "blog",
                                          :description => "weblog",
                                          :identifier => "blog",
                                          :is_public => 1,
                                          :custom_field_values => { '3' => 'Beta' },
                                          :parent_id => 1
                                         }
                 assert_redirected_to '/projects/blog/settings'
                 project = Project.find_by_name('blog')
               end
               test "#create by non-admin user with add_subprojects permission should fail without parent_id" do
                 Role.find(1).remove_permission! :add_project
                 Role.find(1).add_permission! :add_subprojects
                 @request.session[:user_id] = 2
                 assert_no_difference 'Project.count' do
                   post :create, :project => { :name => "blog",
                                            :description => "weblog",
                                            :identifier => "blog",
                                            :is_public => 1,
                                            :custom_field_values => { '3' => 'Beta' }
                                           }
                 end
                 assert_response :success
                 project = assigns(:project)
                 assert_kind_of Project, project
                 assert_not_equal [], project.errors[:parent_id]
               end
               test "#create by non-admin user with add_subprojects permission should fail with unauthorized parent_id" do
                 Role.find(1).remove_permission! :add_project
                 Role.find(1).add_permission! :add_subprojects
                 @request.session[:user_id] = 2
                 assert !User.find(2).member_of?(Project.find(6))
                 assert_no_difference 'Project.count' do
                   post :create, :project => { :name => "blog",
                                            :description => "weblog",
                                            :identifier => "blog",
                                            :is_public => 1,
                                            :custom_field_values => { '3' => 'Beta' },
                                            :parent_id => 6
                                           }
                 end
                 assert_response :success
                 project = assigns(:project)
                 assert_kind_of Project, project
                 assert_not_equal [], project.errors[:parent_id]
               end
               def test_create_subproject_with_inherit_members_should_inherit_members
                 Role.find_by_name('Manager').add_permission! :add_subprojects
                 parent = Project.find(1)
                 @request.session[:user_id] = 2
                 assert_difference 'Project.count' do
                   post :create, :project => {
                     :name => 'inherited', :identifier => 'inherited', :parent_id => parent.id, :inherit_members => '1'
                   }
                   assert_response 302
                 end
                 project = Project.order('id desc').first
                 assert_equal 'inherited', project.name
                 assert_equal parent, project.parent
                 assert project.memberships.count > 0
                 assert_equal parent.memberships.count, project.memberships.count
               end
               def test_create_should_preserve_modules_on_validation_failure
                 with_settings :default_projects_modules => ['issue_tracking', 'repository'] do
                   @request.session[:user_id] = 1
                   assert_no_difference 'Project.count' do
                     post :create, :project => {
                       :name => "blog",
                       :identifier => "",
                       :enabled_module_names => %w(issue_tracking news)
                     }
                   end
                   assert_response :success
                   project = assigns(:project)
                   assert_equal %w(issue_tracking news), project.enabled_module_names.sort
                 end
               end
               def test_show_by_id
                 get :show, :id => 1
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:project)
               end
               def test_show_by_identifier
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:project)
                 assert_equal Project.find_by_identifier('ecookbook'), assigns(:project)
                 assert_select 'li', :text => /Development status/
               end
               def test_show_should_not_display_empty_sidebar
                 p = Project.find(1)
                 p.enabled_module_names = []
                 p.save!
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_select '#main.nosidebar'
               end
               def test_show_should_not_display_hidden_custom_fields
                 ProjectCustomField.find_by_name('Development status').update_attribute :visible, false
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:project)
                 assert_select 'li', :text => /Development status/, :count => 0
               end
               def test_show_should_not_display_blank_custom_fields_with_multiple_values
                 f1 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Foo Bar), :multiple => true
                 f2 = ProjectCustomField.generate! :field_format => 'list', :possible_values => %w(Baz Qux), :multiple => true
                 project = Project.generate!(:custom_field_values => {f2.id.to_s => %w(Qux)})
                 get :show, :id => project.id
                 assert_response :success
                 assert_select 'li', :text => /#{f1.name}/, :count => 0
                 assert_select 'li', :text => /#{f2.name}/
               end
               def test_show_should_not_display_blank_text_custom_fields
                 f1 = ProjectCustomField.generate! :field_format => 'text'
                 get :show, :id => 1
                 assert_response :success
                 assert_select 'li', :text => /#{f1.name}/, :count => 0
               end
               def test_show_should_not_fail_when_custom_values_are_nil
                 project = Project.find_by_identifier('ecookbook')
                 project.custom_values.first.update_attribute(:value, nil)
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_not_nil assigns(:project)
                 assert_equal Project.find_by_identifier('ecookbook'), assigns(:project)
               end
               def show_archived_project_should_be_denied
                 project = Project.find_by_identifier('ecookbook')
                 project.archive!
                 get :show, :id => 'ecookbook'
                 assert_response 403
                 assert_nil assigns(:project)
                 assert_select 'p', :text => /archived/
               end
               def test_show_should_not_show_private_subprojects_that_are_not_visible
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_select 'a', :text => /Private child/, :count => 0
               end
               def test_show_should_show_private_subprojects_that_are_visible
                 @request.session[:user_id] = 2 # manager who is a member of the private subproject
                 get :show, :id => 'ecookbook'
                 assert_response :success
                 assert_template 'show'
                 assert_select 'a', :text => /Private child/
               end
               def test_settings
                 @request.session[:user_id] = 2 # manager
                 get :settings, :id => 1
                 assert_response :success
                 assert_template 'settings'
               end
               def test_settings_of_subproject
                 @request.session[:user_id] = 2
                 get :settings, :id => 'private-child'
                 assert_response :success
                 assert_template 'settings'
                 assert_select 'input[type=checkbox][name=?]', 'project[inherit_members]'
               end
               def test_settings_should_be_denied_for_member_on_closed_project
                 Project.find(1).close
                 @request.session[:user_id] = 2 # manager
                 get :settings, :id => 1
                 assert_response 403
               end
               def test_settings_should_be_denied_for_anonymous_on_closed_project
                 Project.find(1).close
                 get :settings, :id => 1
                 assert_response 302
               end
               def test_setting_with_wiki_module_and_no_wiki
                 Project.find(1).wiki.destroy
                 Role.find(1).add_permission! :manage_wiki
                 @request.session[:user_id] = 2
                 get :settings, :id => 1
                 assert_response :success
                 assert_template 'settings'
                 assert_select 'form[action=?]', '/projects/ecookbook/wiki' do
                   assert_select 'input[name=?]', 'wiki[start_page]'
                 end
               end
               def test_update
                 @request.session[:user_id] = 2 # manager
                 post :update, :id => 1, :project => {:name => 'Test changed name',
                                                    :issue_custom_field_ids => ['']}
                 assert_redirected_to '/projects/ecookbook/settings'
                 project = Project.find(1)
                 assert_equal 'Test changed name', project.name
               end
               def test_update_with_failure
                 @request.session[:user_id] = 2 # manager
                 post :update, :id => 1, :project => {:name => ''}
                 assert_response :success
                 assert_template 'settings'
                 assert_select_error /name cannot be blank/i
               end
               def test_update_should_be_denied_for_member_on_closed_project
                 Project.find(1).close
                 @request.session[:user_id] = 2 # manager
                 post :update, :id => 1, :project => {:name => 'Closed'}
                 assert_response 403
                 assert_equal 'eCookbook', Project.find(1).name
               end
               def test_update_should_be_denied_for_anonymous_on_closed_project
                 Project.find(1).close
                 post :update, :id => 1, :project => {:name => 'Closed'}
                 assert_response 302
                 assert_equal 'eCookbook', Project.find(1).name
               end
               def test_modules
                 @request.session[:user_id] = 2
                 Project.find(1).enabled_module_names = ['issue_tracking', 'news']
                 post :modules, :id => 1, :enabled_module_names => ['issue_tracking', 'repository', 'documents']
                 assert_redirected_to '/projects/ecookbook/settings/modules'
                 assert_equal ['documents', 'issue_tracking', 'repository'], Project.find(1).enabled_module_names.sort
               end
               def test_destroy_leaf_project_without_confirmation_should_show_confirmation
                 @request.session[:user_id] = 1 # admin
                 assert_no_difference 'Project.count' do
                   delete :destroy, :id => 2
                   assert_response :success
                   assert_template 'destroy'
                 end
               end
               def test_destroy_without_confirmation_should_show_confirmation_with_subprojects
                 @request.session[:user_id] = 1 # admin
                 assert_no_difference 'Project.count' do
                   delete :destroy, :id => 1
                   assert_response :success
                   assert_template 'destroy'
                 end
                 assert_select 'strong',
                               :text => ['Private child of eCookbook',
                                         'Child of private child, eCookbook Subproject 1',
                                         'eCookbook Subproject 2'].join(', ')
               end
               def test_destroy_with_confirmation_should_destroy_the_project_and_subprojects
                 @request.session[:user_id] = 1 # admin
                 assert_difference 'Project.count', -5 do
                   delete :destroy, :id => 1, :confirm => 1
                   assert_redirected_to '/admin/projects'
                 end
                 assert_nil Project.find_by_id(1)
               end
               def test_archive
                 @request.session[:user_id] = 1 # admin
                 post :archive, :id => 1
                 assert_redirected_to '/admin/projects'
                 assert !Project.find(1).active?
               end
               def test_archive_with_failure
                 @request.session[:user_id] = 1
                 Project.any_instance.stubs(:archive).returns(false)
                 post :archive, :id => 1
                 assert_redirected_to '/admin/projects'
                 assert_match /project cannot be archived/i, flash[:error]
               end
               def test_unarchive
                 @request.session[:user_id] = 1 # admin
                 Project.find(1).archive
                 post :unarchive, :id => 1
                 assert_redirected_to '/admin/projects'
                 assert Project.find(1).active?
               end
               def test_close
                 @request.session[:user_id] = 2
                 post :close, :id => 1
                 assert_redirected_to '/projects/ecookbook'
                 assert_equal Project::STATUS_CLOSED, Project.find(1).status
               end
               def test_reopen
                 Project.find(1).close
                 @request.session[:user_id] = 2
                 post :reopen, :id => 1
                 assert_redirected_to '/projects/ecookbook'
                 assert Project.find(1).active?
               end
               def test_project_breadcrumbs_should_be_limited_to_3_ancestors
                 CustomField.delete_all
                 parent = nil
 .times do |i|
                   p = Project.generate_with_parent!(parent)
                   get :show, :id => p
                   assert_select '#header h1' do
                     assert_select 'a', :count => [i, 3].min
                   end
                   parent = p
                 end
               end
               def test_get_copy
                 @request.session[:user_id] = 1 # admin
                 get :copy, :id => 1
                 assert_response :success
                 assert_template 'copy'
                 assert assigns(:project)
                 assert_equal Project.find(1).description, assigns(:project).description
                 assert_nil assigns(:project).id
                 assert_select 'input[name=?][value=?]', 'project[enabled_module_names][]', 'issue_tracking', 1
               end
               def test_get_copy_with_invalid_source_should_respond_with_404
                 @request.session[:user_id] = 1
                 get :copy, :id => 99
                 assert_response 404
               end
               def test_post_copy_should_copy_requested_items
                 @request.session[:user_id] = 1 # admin
                 CustomField.delete_all
                 assert_difference 'Project.count' do
                   post :copy, :id => 1,
                     :project => {
                       :name => 'Copy',
                       :identifier => 'unique-copy',
                       :tracker_ids => ['1', '2', '3', ''],
                       :enabled_module_names => %w(issue_tracking time_tracking)
                     },
                     :only => %w(issues versions)
                 end
                 project = Project.find('unique-copy')
                 source = Project.find(1)
                 assert_equal %w(issue_tracking time_tracking), project.enabled_module_names.sort
                 assert_equal source.versions.count, project.versions.count, "All versions were not copied"
                 assert_equal source.issues.count, project.issues.count, "All issues were not copied"
                 assert_equal 0, project.members.count
               end
               def test_post_copy_should_redirect_to_settings_when_successful
                 @request.session[:user_id] = 1 # admin
                 post :copy, :id => 1, :project => {:name => 'Copy', :identifier => 'unique-copy'}
                 assert_response :redirect
                 assert_redirected_to :controller => 'projects', :action => 'settings', :id => 'unique-copy'
               end
               def test_post_copy_with_failure
                 @request.session[:user_id] = 1
                 post :copy, :id => 1, :project => {:name => 'Copy', :identifier => ''}
                 assert_response :success
                 assert_template 'copy'
               end
               def test_jump_should_redirect_to_active_tab
                 get :show, :id => 1, :jump => 'issues'
                 assert_redirected_to '/projects/ecookbook/issues'
               end
               def test_jump_should_not_redirect_to_inactive_tab
                 get :show, :id => 3, :jump => 'documents'
                 assert_response :success
                 assert_template 'show'
               end
               def test_jump_should_not_redirect_to_unknown_tab
                 get :show, :id => 3, :jump => 'foobar'
                 assert_response :success
                 assert_template 'show'
               end
               def test_body_should_have_project_css_class
                 get :show, :id => 1
                 assert_select 'body.project-ecookbook'
               end
               def test_project_menu_should_include_new_issue_link
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_select '#main-menu a.new-issue[href="/projects/ecookbook/issues/new"]', :text => 'New issue'
               end
               def test_project_menu_should_not_include_new_issue_link_for_project_without_trackers
                 Project.find(1).trackers.clear
                 @request.session[:user_id] = 2
                 get :show, :id => 1
                 assert_select '#main-menu a.new-issue', 0
               end
+              def test_project_menu_should_not_include_new_issue_link_for_users_with_copy_issues_permission_only
+                role = Role.find(1)
+                role.remove_permission! :add_issues
+                role.add_permission! :copy_issues
+                @request.session[:user_id] = 2
+                get :show, :id => 1
+                assert_select '#main-menu a.new-issue', 0
+              end
             end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages