jro_apps/redmine Commit - r10873:77f6b404fac5

Make sure we don't cast an empty string to numeric (#12713)....

Jean-Philippe Lang -

r10873:77f6b404fac5

parent child

Context file:

r10873:77f6b404fac5

Collapse all files

app/models/custom_field.rb +2 -2

                      # Make the database cast values into numeric
                      # Postgresql will raise an error if a value can not be casted!
                      # CustomValue validations should ensure that it doesn't occur
-                     "CAST(#{join_alias}.value AS decimal(30,3))"
+                     "CAST(CASE #{join_alias}.value WHEN '' THEN '0' ELSE #{join_alias}.value END AS decimal(30,3))"
                    when 'user', 'version'
                      value_class.fields_for_order_statement(value_join_alias)
                    else
                          " AND #{join_alias}_2.customized_id = #{join_alias}.customized_id" +
                          " AND #{join_alias}_2.custom_field_id = #{join_alias}.custom_field_id)" +
                        " LEFT OUTER JOIN #{value_class.table_name} #{value_join_alias}" +
-                       " ON CAST(#{join_alias}.value as decimal(30,0)) = #{value_join_alias}.id"
+                       " ON CAST(CASE #{join_alias}.value WHEN '' THEN '0' ELSE #{join_alias}.value END AS decimal(30,0)) = #{value_join_alias}.id"
                    when 'int', 'float'
                      "LEFT OUTER JOIN #{CustomValue.table_name} #{join_alias}" +
                        " ON #{join_alias}.customized_type = '#{self.class.customized_class.base_class.name}'" +

app/models/query.rb +5 -5

                        sql = date_clause(db_table, db_field, (Date.parse(value.first) rescue nil), (Date.parse(value.first) rescue nil))
                      when :integer
                        if is_custom_filter
-                         sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(30,3)) = #{value.first.to_i})"
+                         sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) = #{value.first.to_i})"
                        else
                          sql = "#{db_table}.#{db_field} = #{value.first.to_i}"
                        end
                      when :float
                        if is_custom_filter
-                         sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(30,3)) BETWEEN #{value.first.to_f - 1e-5} AND #{value.first.to_f + 1e-5})"
+                         sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) BETWEEN #{value.first.to_f - 1e-5} AND #{value.first.to_f + 1e-5})"
                        else
                          sql = "#{db_table}.#{db_field} BETWEEN #{value.first.to_f - 1e-5} AND #{value.first.to_f + 1e-5}"
                        end
                      sql = date_clause(db_table, db_field, (Date.parse(value.first) rescue nil), nil)
                    else
                      if is_custom_filter
-                       sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(30,3)) >= #{value.first.to_f})"
+                       sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) >= #{value.first.to_f})"
                      else
                        sql = "#{db_table}.#{db_field} >= #{value.first.to_f}"
                      end
                      sql = date_clause(db_table, db_field, nil, (Date.parse(value.first) rescue nil))
                    else
                      if is_custom_filter
-                       sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(30,3)) <= #{value.first.to_f})"
+                       sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) <= #{value.first.to_f})"
                      else
                        sql = "#{db_table}.#{db_field} <= #{value.first.to_f}"
                      end
                      sql = date_clause(db_table, db_field, (Date.parse(value[0]) rescue nil), (Date.parse(value[1]) rescue nil))
                    else
                      if is_custom_filter
-                       sql = "(#{db_table}.#{db_field} <> '' AND CAST(#{db_table}.#{db_field} AS decimal(30,3)) BETWEEN #{value[0].to_f} AND #{value[1].to_f})"
+                       sql = "(#{db_table}.#{db_field} <> '' AND CAST(CASE #{db_table}.#{db_field} WHEN '' THEN '0' ELSE #{db_table}.#{db_field} END AS decimal(30,3)) BETWEEN #{value[0].to_f} AND #{value[1].to_f})"
                      else
                        sql = "#{db_table}.#{db_field} BETWEEN #{value[0].to_f} AND #{value[1].to_f}"
                      end

test/unit/query_test.rb +2 -2

                  f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true)
                  query = IssueQuery.new(:project => Project.find(1), :name => '_')
                  query.add_filter("cf_#{f.id}", '<=', ['30'])
-                 assert query.statement.include?("CAST(custom_values.value AS decimal(30,3)) <= 30.0")
+                 assert_match /CAST.+ <= 30\.0/, query.statement
                  find_issues_with_query(query)
                end
                  f = IssueCustomField.create!(:name => 'filter', :field_format => 'int', :is_filter => true, :is_for_all => true)
                  query = IssueQuery.new(:project => Project.find(1), :name => '_')
                  query.add_filter("cf_#{f.id}", '><', ['30', '40'])
-                 assert_include "CAST(custom_values.value AS decimal(30,3)) BETWEEN 30.0 AND 40.0", query.statement
+                 assert_match /CAST.+ BETWEEN 30.0 AND 40.0/, query.statement
                  find_issues_with_query(query)
                end

General Comments 0

Write
Preview

You need to be logged in to leave comments. Login now

No TODOs yet

	Site-wide shortcuts
/	Use quick search box
g h	Goto home page
g g	Goto my private gists page
g G	Goto my public gists page
g 0-9	Goto bookmarked items from 0-9
n r	New repository page
n g	New gist page

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages