##// END OF EJS Templates
Fixed that updating the issue form was broken by r4011 when user is not allowed to add issues (#13188)....
Jean-Philippe Lang -
r11175:7799788b3de6
parent child
Show More
@@ -1,435 +1,439
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
24 before_filter :find_project, :only => [:new, :create]
24 before_filter :find_project, :only => [:new, :create, :update_form]
25 25 before_filter :authorize, :except => [:index]
26 26 before_filter :find_optional_project, :only => [:index]
27 27 before_filter :check_for_default_issue_status, :only => [:new, :create]
28 before_filter :build_new_issue_from_params, :only => [:new, :create]
28 before_filter :build_new_issue_from_params, :only => [:new, :create, :update_form]
29 29 accept_rss_auth :index, :show
30 30 accept_api_auth :index, :show, :create, :update, :destroy
31 31
32 32 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
33 33
34 34 helper :journals
35 35 helper :projects
36 36 include ProjectsHelper
37 37 helper :custom_fields
38 38 include CustomFieldsHelper
39 39 helper :issue_relations
40 40 include IssueRelationsHelper
41 41 helper :watchers
42 42 include WatchersHelper
43 43 helper :attachments
44 44 include AttachmentsHelper
45 45 helper :queries
46 46 include QueriesHelper
47 47 helper :repositories
48 48 include RepositoriesHelper
49 49 helper :sort
50 50 include SortHelper
51 51 include IssuesHelper
52 52 helper :timelog
53 53 include Redmine::Export::PDF
54 54
55 55 def index
56 56 retrieve_query
57 57 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
58 58 sort_update(@query.sortable_columns)
59 59 @query.sort_criteria = sort_criteria.to_a
60 60
61 61 if @query.valid?
62 62 case params[:format]
63 63 when 'csv', 'pdf'
64 64 @limit = Setting.issues_export_limit.to_i
65 65 when 'atom'
66 66 @limit = Setting.feeds_limit.to_i
67 67 when 'xml', 'json'
68 68 @offset, @limit = api_offset_and_limit
69 69 else
70 70 @limit = per_page_option
71 71 end
72 72
73 73 @issue_count = @query.issue_count
74 74 @issue_pages = Paginator.new @issue_count, @limit, params['page']
75 75 @offset ||= @issue_pages.offset
76 76 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
77 77 :order => sort_clause,
78 78 :offset => @offset,
79 79 :limit => @limit)
80 80 @issue_count_by_group = @query.issue_count_by_group
81 81
82 82 respond_to do |format|
83 83 format.html { render :template => 'issues/index', :layout => !request.xhr? }
84 84 format.api {
85 85 Issue.load_visible_relations(@issues) if include_in_api_response?('relations')
86 86 }
87 87 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
88 88 format.csv { send_data(issues_to_csv(@issues, @project, @query, params), :type => 'text/csv; header=present', :filename => 'export.csv') }
89 89 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'export.pdf') }
90 90 end
91 91 else
92 92 respond_to do |format|
93 93 format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
94 94 format.any(:atom, :csv, :pdf) { render(:nothing => true) }
95 95 format.api { render_validation_errors(@query) }
96 96 end
97 97 end
98 98 rescue ActiveRecord::RecordNotFound
99 99 render_404
100 100 end
101 101
102 102 def show
103 103 @journals = @issue.journals.includes(:user, :details).reorder("#{Journal.table_name}.id ASC").all
104 104 @journals.each_with_index {|j,i| j.indice = i+1}
105 105 @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
106 106 @journals.reverse! if User.current.wants_comments_in_reverse_order?
107 107
108 108 @changesets = @issue.changesets.visible.all
109 109 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
110 110
111 111 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
112 112 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
113 113 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
114 114 @priorities = IssuePriority.active
115 115 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
116 116 respond_to do |format|
117 117 format.html {
118 118 retrieve_previous_and_next_issue_ids
119 119 render :template => 'issues/show'
120 120 }
121 121 format.api
122 122 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
123 123 format.pdf {
124 124 pdf = issue_to_pdf(@issue, :journals => @journals)
125 125 send_data(pdf, :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf")
126 126 }
127 127 end
128 128 end
129 129
130 130 # Add a new issue
131 131 # The new issue will be created from an existing one if copy_from parameter is given
132 132 def new
133 133 respond_to do |format|
134 134 format.html { render :action => 'new', :layout => !request.xhr? }
135 format.js { render :partial => 'update_form' }
136 135 end
137 136 end
138 137
139 138 def create
140 139 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
141 140 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
142 141 if @issue.save
143 142 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
144 143 respond_to do |format|
145 144 format.html {
146 145 render_attachment_warning_if_needed(@issue)
147 146 flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
148 147 if params[:continue]
149 148 attrs = {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?}
150 149 redirect_to new_project_issue_path(@issue.project, :issue => attrs)
151 150 else
152 151 redirect_to issue_path(@issue)
153 152 end
154 153 }
155 154 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
156 155 end
157 156 return
158 157 else
159 158 respond_to do |format|
160 159 format.html { render :action => 'new' }
161 160 format.api { render_validation_errors(@issue) }
162 161 end
163 162 end
164 163 end
165 164
166 165 def edit
167 166 return unless update_issue_from_params
168 167
169 168 respond_to do |format|
170 169 format.html { }
171 170 format.xml { }
172 171 end
173 172 end
174 173
175 174 def update
176 175 return unless update_issue_from_params
177 176 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
178 177 saved = false
179 178 begin
180 179 saved = @issue.save_issue_with_child_records(params, @time_entry)
181 180 rescue ActiveRecord::StaleObjectError
182 181 @conflict = true
183 182 if params[:last_journal_id]
184 183 @conflict_journals = @issue.journals_after(params[:last_journal_id]).all
185 184 @conflict_journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
186 185 end
187 186 end
188 187
189 188 if saved
190 189 render_attachment_warning_if_needed(@issue)
191 190 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
192 191
193 192 respond_to do |format|
194 193 format.html { redirect_back_or_default issue_path(@issue) }
195 194 format.api { render_api_ok }
196 195 end
197 196 else
198 197 respond_to do |format|
199 198 format.html { render :action => 'edit' }
200 199 format.api { render_validation_errors(@issue) }
201 200 end
202 201 end
203 202 end
204 203
204 # Updates the issue form when changing the project, status or tracker
205 # on issue creation/update
206 def update_form
207 end
208
205 209 # Bulk edit/copy a set of issues
206 210 def bulk_edit
207 211 @issues.sort!
208 212 @copy = params[:copy].present?
209 213 @notes = params[:notes]
210 214
211 215 if User.current.allowed_to?(:move_issues, @projects)
212 216 @allowed_projects = Issue.allowed_target_projects_on_move
213 217 if params[:issue]
214 218 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
215 219 if @target_project
216 220 target_projects = [@target_project]
217 221 end
218 222 end
219 223 end
220 224 target_projects ||= @projects
221 225
222 226 if @copy
223 227 @available_statuses = [IssueStatus.default]
224 228 else
225 229 @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
226 230 end
227 231 @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.reduce(:&)
228 232 @assignables = target_projects.map(&:assignable_users).reduce(:&)
229 233 @trackers = target_projects.map(&:trackers).reduce(:&)
230 234 @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
231 235 @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
232 236 if @copy
233 237 @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
234 238 @subtasks_present = @issues.detect {|i| !i.leaf?}.present?
235 239 end
236 240
237 241 @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
238 242 render :layout => false if request.xhr?
239 243 end
240 244
241 245 def bulk_update
242 246 @issues.sort!
243 247 @copy = params[:copy].present?
244 248 attributes = parse_params_for_bulk_issue_attributes(params)
245 249
246 250 unsaved_issue_ids = []
247 251 moved_issues = []
248 252
249 253 if @copy && params[:copy_subtasks].present?
250 254 # Descendant issues will be copied with the parent task
251 255 # Don't copy them twice
252 256 @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
253 257 end
254 258
255 259 @issues.each do |issue|
256 260 issue.reload
257 261 if @copy
258 262 issue = issue.copy({},
259 263 :attachments => params[:copy_attachments].present?,
260 264 :subtasks => params[:copy_subtasks].present?
261 265 )
262 266 end
263 267 journal = issue.init_journal(User.current, params[:notes])
264 268 issue.safe_attributes = attributes
265 269 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
266 270 if issue.save
267 271 moved_issues << issue
268 272 else
269 273 # Keep unsaved issue ids to display them in flash error
270 274 unsaved_issue_ids << issue.id
271 275 end
272 276 end
273 277 set_flash_from_bulk_issue_save(@issues, unsaved_issue_ids)
274 278
275 279 if params[:follow]
276 280 if @issues.size == 1 && moved_issues.size == 1
277 281 redirect_to issue_path(moved_issues.first)
278 282 elsif moved_issues.map(&:project).uniq.size == 1
279 283 redirect_to project_issues_path(moved_issues.map(&:project).first)
280 284 end
281 285 else
282 286 redirect_back_or_default _project_issues_path(@project)
283 287 end
284 288 end
285 289
286 290 def destroy
287 291 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
288 292 if @hours > 0
289 293 case params[:todo]
290 294 when 'destroy'
291 295 # nothing to do
292 296 when 'nullify'
293 297 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
294 298 when 'reassign'
295 299 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
296 300 if reassign_to.nil?
297 301 flash.now[:error] = l(:error_issue_not_found_in_project)
298 302 return
299 303 else
300 304 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
301 305 end
302 306 else
303 307 # display the destroy form if it's a user request
304 308 return unless api_request?
305 309 end
306 310 end
307 311 @issues.each do |issue|
308 312 begin
309 313 issue.reload.destroy
310 314 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
311 315 # nothing to do, issue was already deleted (eg. by a parent)
312 316 end
313 317 end
314 318 respond_to do |format|
315 319 format.html { redirect_back_or_default _project_issues_path(@project) }
316 320 format.api { render_api_ok }
317 321 end
318 322 end
319 323
320 324 private
321 325
322 326 def find_project
323 327 project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
324 328 @project = Project.find(project_id)
325 329 rescue ActiveRecord::RecordNotFound
326 330 render_404
327 331 end
328 332
329 333 def retrieve_previous_and_next_issue_ids
330 334 retrieve_query_from_session
331 335 if @query
332 336 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
333 337 sort_update(@query.sortable_columns, 'issues_index_sort')
334 338 limit = 500
335 339 issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
336 340 if (idx = issue_ids.index(@issue.id)) && idx < limit
337 341 if issue_ids.size < 500
338 342 @issue_position = idx + 1
339 343 @issue_count = issue_ids.size
340 344 end
341 345 @prev_issue_id = issue_ids[idx - 1] if idx > 0
342 346 @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
343 347 end
344 348 end
345 349 end
346 350
347 351 # Used by #edit and #update to set some common instance variables
348 352 # from the params
349 353 # TODO: Refactor, not everything in here is needed by #edit
350 354 def update_issue_from_params
351 355 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
352 356 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
353 357 @time_entry.attributes = params[:time_entry]
354 358
355 359 @issue.init_journal(User.current)
356 360
357 361 issue_attributes = params[:issue]
358 362 if issue_attributes && params[:conflict_resolution]
359 363 case params[:conflict_resolution]
360 364 when 'overwrite'
361 365 issue_attributes = issue_attributes.dup
362 366 issue_attributes.delete(:lock_version)
363 367 when 'add_notes'
364 368 issue_attributes = issue_attributes.slice(:notes)
365 369 when 'cancel'
366 370 redirect_to issue_path(@issue)
367 371 return false
368 372 end
369 373 end
370 374 @issue.safe_attributes = issue_attributes
371 375 @priorities = IssuePriority.active
372 376 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
373 377 true
374 378 end
375 379
376 380 # TODO: Refactor, lots of extra code in here
377 381 # TODO: Changing tracker on an existing issue should not trigger this
378 382 def build_new_issue_from_params
379 383 if params[:id].blank?
380 384 @issue = Issue.new
381 385 if params[:copy_from]
382 386 begin
383 387 @copy_from = Issue.visible.find(params[:copy_from])
384 388 @copy_attachments = params[:copy_attachments].present? || request.get?
385 389 @copy_subtasks = params[:copy_subtasks].present? || request.get?
386 390 @issue.copy_from(@copy_from, :attachments => @copy_attachments, :subtasks => @copy_subtasks)
387 391 rescue ActiveRecord::RecordNotFound
388 392 render_404
389 393 return
390 394 end
391 395 end
392 396 @issue.project = @project
393 397 else
394 398 @issue = @project.issues.visible.find(params[:id])
395 399 end
396 400
397 401 @issue.project = @project
398 402 @issue.author ||= User.current
399 403 # Tracker must be set before custom field values
400 404 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
401 405 if @issue.tracker.nil?
402 406 render_error l(:error_no_tracker_in_project)
403 407 return false
404 408 end
405 409 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
406 410 @issue.safe_attributes = params[:issue]
407 411
408 412 @priorities = IssuePriority.active
409 413 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
410 414 @available_watchers = (@issue.project.users.sort + @issue.watcher_users).uniq
411 415 end
412 416
413 417 def check_for_default_issue_status
414 418 if IssueStatus.default.nil?
415 419 render_error l(:error_no_default_issue_status)
416 420 return false
417 421 end
418 422 end
419 423
420 424 def parse_params_for_bulk_issue_attributes(params)
421 425 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
422 426 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
423 427 if custom = attributes[:custom_field_values]
424 428 custom.reject! {|k,v| v.blank?}
425 429 custom.keys.each do |k|
426 430 if custom[k].is_a?(Array)
427 431 custom[k] << '' if custom[k].delete('__none__')
428 432 else
429 433 custom[k] = '' if custom[k] == '__none__'
430 434 end
431 435 end
432 436 end
433 437 attributes
434 438 end
435 439 end
1 NO CONTENT: file renamed from app/views/issues/_update_form.js.erb to app/views/issues/update_form.js.erb
@@ -1,347 +1,347
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 RedmineApp::Application.routes.draw do
19 19 root :to => 'welcome#index', :as => 'home'
20 20
21 21 match 'login', :to => 'account#login', :as => 'signin', :via => [:get, :post]
22 22 match 'logout', :to => 'account#logout', :as => 'signout', :via => [:get, :post]
23 23 match 'account/register', :to => 'account#register', :via => [:get, :post], :as => 'register'
24 24 match 'account/lost_password', :to => 'account#lost_password', :via => [:get, :post], :as => 'lost_password'
25 25 match 'account/activate', :to => 'account#activate', :via => :get
26 26
27 27 match '/news/preview', :controller => 'previews', :action => 'news', :as => 'preview_news', :via => [:get, :post, :put]
28 28 match '/issues/preview/new/:project_id', :to => 'previews#issue', :as => 'preview_new_issue', :via => [:get, :post, :put]
29 29 match '/issues/preview/edit/:id', :to => 'previews#issue', :as => 'preview_edit_issue', :via => [:get, :post, :put]
30 30 match '/issues/preview', :to => 'previews#issue', :as => 'preview_issue', :via => [:get, :post, :put]
31 31
32 32 match 'projects/:id/wiki', :to => 'wikis#edit', :via => :post
33 33 match 'projects/:id/wiki/destroy', :to => 'wikis#destroy', :via => [:get, :post]
34 34
35 35 match 'boards/:board_id/topics/new', :to => 'messages#new', :via => [:get, :post], :as => 'new_board_message'
36 36 get 'boards/:board_id/topics/:id', :to => 'messages#show', :as => 'board_message'
37 37 match 'boards/:board_id/topics/quote/:id', :to => 'messages#quote', :via => [:get, :post]
38 38 get 'boards/:board_id/topics/:id/edit', :to => 'messages#edit'
39 39
40 40 post 'boards/:board_id/topics/preview', :to => 'messages#preview', :as => 'preview_board_message'
41 41 post 'boards/:board_id/topics/:id/replies', :to => 'messages#reply'
42 42 post 'boards/:board_id/topics/:id/edit', :to => 'messages#edit'
43 43 post 'boards/:board_id/topics/:id/destroy', :to => 'messages#destroy'
44 44
45 45 # Misc issue routes. TODO: move into resources
46 46 match '/issues/auto_complete', :to => 'auto_completes#issues', :via => :get, :as => 'auto_complete_issues'
47 47 match '/issues/context_menu', :to => 'context_menus#issues', :as => 'issues_context_menu', :via => [:get, :post]
48 48 match '/issues/changes', :to => 'journals#index', :as => 'issue_changes', :via => :get
49 49 match '/issues/:id/quoted', :to => 'journals#new', :id => /\d+/, :via => :post, :as => 'quoted_issue'
50 50
51 51 match '/journals/diff/:id', :to => 'journals#diff', :id => /\d+/, :via => :get
52 52 match '/journals/edit/:id', :to => 'journals#edit', :id => /\d+/, :via => [:get, :post]
53 53
54 54 get '/projects/:project_id/issues/gantt', :to => 'gantts#show', :as => 'project_gantt'
55 55 get '/issues/gantt', :to => 'gantts#show'
56 56
57 57 get '/projects/:project_id/issues/calendar', :to => 'calendars#show', :as => 'project_calendar'
58 58 get '/issues/calendar', :to => 'calendars#show'
59 59
60 60 get 'projects/:id/issues/report', :to => 'reports#issue_report', :as => 'project_issues_report'
61 61 get 'projects/:id/issues/report/:detail', :to => 'reports#issue_report_details', :as => 'project_issues_report_details'
62 62
63 63 match 'my/account', :controller => 'my', :action => 'account', :via => [:get, :post]
64 64 match 'my/account/destroy', :controller => 'my', :action => 'destroy', :via => [:get, :post]
65 65 match 'my/page', :controller => 'my', :action => 'page', :via => :get
66 66 match 'my', :controller => 'my', :action => 'index', :via => :get # Redirects to my/page
67 67 match 'my/reset_rss_key', :controller => 'my', :action => 'reset_rss_key', :via => :post
68 68 match 'my/reset_api_key', :controller => 'my', :action => 'reset_api_key', :via => :post
69 69 match 'my/password', :controller => 'my', :action => 'password', :via => [:get, :post]
70 70 match 'my/page_layout', :controller => 'my', :action => 'page_layout', :via => :get
71 71 match 'my/add_block', :controller => 'my', :action => 'add_block', :via => :post
72 72 match 'my/remove_block', :controller => 'my', :action => 'remove_block', :via => :post
73 73 match 'my/order_blocks', :controller => 'my', :action => 'order_blocks', :via => :post
74 74
75 75 resources :users
76 76 match 'users/:id/memberships/:membership_id', :to => 'users#edit_membership', :via => :put, :as => 'user_membership'
77 77 match 'users/:id/memberships/:membership_id', :to => 'users#destroy_membership', :via => :delete
78 78 match 'users/:id/memberships', :to => 'users#edit_membership', :via => :post, :as => 'user_memberships'
79 79
80 80 post 'watchers/watch', :to => 'watchers#watch', :as => 'watch'
81 81 delete 'watchers/watch', :to => 'watchers#unwatch'
82 82 get 'watchers/new', :to => 'watchers#new'
83 83 post 'watchers', :to => 'watchers#create'
84 84 post 'watchers/append', :to => 'watchers#append'
85 85 post 'watchers/destroy', :to => 'watchers#destroy'
86 86 get 'watchers/autocomplete_for_user', :to => 'watchers#autocomplete_for_user'
87 87 # Specific routes for issue watchers API
88 88 post 'issues/:object_id/watchers', :to => 'watchers#create', :object_type => 'issue'
89 89 delete 'issues/:object_id/watchers/:user_id' => 'watchers#destroy', :object_type => 'issue'
90 90
91 91 resources :projects do
92 92 member do
93 93 get 'settings(/:tab)', :action => 'settings', :as => 'settings'
94 94 post 'modules'
95 95 post 'archive'
96 96 post 'unarchive'
97 97 post 'close'
98 98 post 'reopen'
99 99 match 'copy', :via => [:get, :post]
100 100 end
101 101
102 102 resources :memberships, :shallow => true, :controller => 'members', :only => [:index, :show, :new, :create, :update, :destroy] do
103 103 collection do
104 104 get 'autocomplete'
105 105 end
106 106 end
107 107
108 108 resource :enumerations, :controller => 'project_enumerations', :only => [:update, :destroy]
109 109
110 110 get 'issues/:copy_from/copy', :to => 'issues#new', :as => 'copy_issue'
111 111 resources :issues, :only => [:index, :new, :create] do
112 112 resources :time_entries, :controller => 'timelog' do
113 113 collection do
114 114 get 'report'
115 115 end
116 116 end
117 117 end
118 118 # issue form update
119 match 'issues/new', :controller => 'issues', :action => 'new', :via => [:put, :post], :as => 'issue_form'
119 match 'issues/update_form', :controller => 'issues', :action => 'update_form', :via => [:put, :post], :as => 'issue_form'
120 120
121 121 resources :files, :only => [:index, :new, :create]
122 122
123 123 resources :versions, :except => [:index, :show, :edit, :update, :destroy] do
124 124 collection do
125 125 put 'close_completed'
126 126 end
127 127 end
128 128 get 'versions.:format', :to => 'versions#index'
129 129 get 'roadmap', :to => 'versions#index', :format => false
130 130 get 'versions', :to => 'versions#index'
131 131
132 132 resources :news, :except => [:show, :edit, :update, :destroy]
133 133 resources :time_entries, :controller => 'timelog' do
134 134 get 'report', :on => :collection
135 135 end
136 136 resources :queries, :only => [:new, :create]
137 137 resources :issue_categories, :shallow => true
138 138 resources :documents, :except => [:show, :edit, :update, :destroy]
139 139 resources :boards
140 140 resources :repositories, :shallow => true, :except => [:index, :show] do
141 141 member do
142 142 match 'committers', :via => [:get, :post]
143 143 end
144 144 end
145 145
146 146 match 'wiki/index', :controller => 'wiki', :action => 'index', :via => :get
147 147 resources :wiki, :except => [:index, :new, :create], :as => 'wiki_page' do
148 148 member do
149 149 get 'rename'
150 150 post 'rename'
151 151 get 'history'
152 152 get 'diff'
153 153 match 'preview', :via => [:post, :put]
154 154 post 'protect'
155 155 post 'add_attachment'
156 156 end
157 157 collection do
158 158 get 'export'
159 159 get 'date_index'
160 160 end
161 161 end
162 162 match 'wiki', :controller => 'wiki', :action => 'show', :via => :get
163 163 get 'wiki/:id/:version', :to => 'wiki#show', :constraints => {:version => /\d+/}
164 164 delete 'wiki/:id/:version', :to => 'wiki#destroy_version'
165 165 get 'wiki/:id/:version/annotate', :to => 'wiki#annotate'
166 166 get 'wiki/:id/:version/diff', :to => 'wiki#diff'
167 167 end
168 168
169 169 resources :issues do
170 170 collection do
171 171 match 'bulk_edit', :via => [:get, :post]
172 172 post 'bulk_update'
173 173 end
174 174 resources :time_entries, :controller => 'timelog' do
175 175 collection do
176 176 get 'report'
177 177 end
178 178 end
179 179 resources :relations, :shallow => true, :controller => 'issue_relations', :only => [:index, :show, :create, :destroy]
180 180 end
181 181 match '/issues', :controller => 'issues', :action => 'destroy', :via => :delete
182 182
183 183 resources :queries, :except => [:show]
184 184
185 185 resources :news, :only => [:index, :show, :edit, :update, :destroy]
186 186 match '/news/:id/comments', :to => 'comments#create', :via => :post
187 187 match '/news/:id/comments/:comment_id', :to => 'comments#destroy', :via => :delete
188 188
189 189 resources :versions, :only => [:show, :edit, :update, :destroy] do
190 190 post 'status_by', :on => :member
191 191 end
192 192
193 193 resources :documents, :only => [:show, :edit, :update, :destroy] do
194 194 post 'add_attachment', :on => :member
195 195 end
196 196
197 197 match '/time_entries/context_menu', :to => 'context_menus#time_entries', :as => :time_entries_context_menu, :via => [:get, :post]
198 198
199 199 resources :time_entries, :controller => 'timelog', :except => :destroy do
200 200 collection do
201 201 get 'report'
202 202 get 'bulk_edit'
203 203 post 'bulk_update'
204 204 end
205 205 end
206 206 match '/time_entries/:id', :to => 'timelog#destroy', :via => :delete, :id => /\d+/
207 207 # TODO: delete /time_entries for bulk deletion
208 208 match '/time_entries/destroy', :to => 'timelog#destroy', :via => :delete
209 209
210 210 get 'projects/:id/activity', :to => 'activities#index'
211 211 get 'projects/:id/activity.:format', :to => 'activities#index'
212 212 get 'activity', :to => 'activities#index'
213 213
214 214 # repositories routes
215 215 get 'projects/:id/repository/:repository_id/statistics', :to => 'repositories#stats'
216 216 get 'projects/:id/repository/:repository_id/graph', :to => 'repositories#graph'
217 217
218 218 get 'projects/:id/repository/:repository_id/changes(/*path(.:ext))',
219 219 :to => 'repositories#changes'
220 220
221 221 get 'projects/:id/repository/:repository_id/revisions/:rev', :to => 'repositories#revision'
222 222 get 'projects/:id/repository/:repository_id/revision', :to => 'repositories#revision'
223 223 post 'projects/:id/repository/:repository_id/revisions/:rev/issues', :to => 'repositories#add_related_issue'
224 224 delete 'projects/:id/repository/:repository_id/revisions/:rev/issues/:issue_id', :to => 'repositories#remove_related_issue'
225 225 get 'projects/:id/repository/:repository_id/revisions', :to => 'repositories#revisions'
226 226 get 'projects/:id/repository/:repository_id/revisions/:rev/:action(/*path(.:ext))',
227 227 :controller => 'repositories',
228 228 :format => false,
229 229 :constraints => {
230 230 :action => /(browse|show|entry|raw|annotate|diff)/,
231 231 :rev => /[a-z0-9\.\-_]+/
232 232 }
233 233
234 234 get 'projects/:id/repository/statistics', :to => 'repositories#stats'
235 235 get 'projects/:id/repository/graph', :to => 'repositories#graph'
236 236
237 237 get 'projects/:id/repository/changes(/*path(.:ext))',
238 238 :to => 'repositories#changes'
239 239
240 240 get 'projects/:id/repository/revisions', :to => 'repositories#revisions'
241 241 get 'projects/:id/repository/revisions/:rev', :to => 'repositories#revision'
242 242 get 'projects/:id/repository/revision', :to => 'repositories#revision'
243 243 post 'projects/:id/repository/revisions/:rev/issues', :to => 'repositories#add_related_issue'
244 244 delete 'projects/:id/repository/revisions/:rev/issues/:issue_id', :to => 'repositories#remove_related_issue'
245 245 get 'projects/:id/repository/revisions/:rev/:action(/*path(.:ext))',
246 246 :controller => 'repositories',
247 247 :format => false,
248 248 :constraints => {
249 249 :action => /(browse|show|entry|raw|annotate|diff)/,
250 250 :rev => /[a-z0-9\.\-_]+/
251 251 }
252 252 get 'projects/:id/repository/:repository_id/:action(/*path(.:ext))',
253 253 :controller => 'repositories',
254 254 :action => /(browse|show|entry|raw|changes|annotate|diff)/
255 255 get 'projects/:id/repository/:action(/*path(.:ext))',
256 256 :controller => 'repositories',
257 257 :action => /(browse|show|entry|raw|changes|annotate|diff)/
258 258
259 259 get 'projects/:id/repository/:repository_id', :to => 'repositories#show', :path => nil
260 260 get 'projects/:id/repository', :to => 'repositories#show', :path => nil
261 261
262 262 # additional routes for having the file name at the end of url
263 263 get 'attachments/:id/:filename', :to => 'attachments#show', :id => /\d+/, :filename => /.*/, :as => 'named_attachment'
264 264 get 'attachments/download/:id/:filename', :to => 'attachments#download', :id => /\d+/, :filename => /.*/, :as => 'download_named_attachment'
265 265 get 'attachments/download/:id', :to => 'attachments#download', :id => /\d+/
266 266 get 'attachments/thumbnail/:id(/:size)', :to => 'attachments#thumbnail', :id => /\d+/, :size => /\d+/, :as => 'thumbnail'
267 267 resources :attachments, :only => [:show, :destroy]
268 268
269 269 resources :groups do
270 270 member do
271 271 get 'autocomplete_for_user'
272 272 end
273 273 end
274 274
275 275 match 'groups/:id/users', :controller => 'groups', :action => 'add_users', :id => /\d+/, :via => :post, :as => 'group_users'
276 276 match 'groups/:id/users/:user_id', :controller => 'groups', :action => 'remove_user', :id => /\d+/, :via => :delete, :as => 'group_user'
277 277 match 'groups/destroy_membership/:id', :controller => 'groups', :action => 'destroy_membership', :id => /\d+/, :via => :post
278 278 match 'groups/edit_membership/:id', :controller => 'groups', :action => 'edit_membership', :id => /\d+/, :via => :post
279 279
280 280 resources :trackers, :except => :show do
281 281 collection do
282 282 match 'fields', :via => [:get, :post]
283 283 end
284 284 end
285 285 resources :issue_statuses, :except => :show do
286 286 collection do
287 287 post 'update_issue_done_ratio'
288 288 end
289 289 end
290 290 resources :custom_fields, :except => :show
291 291 resources :roles do
292 292 collection do
293 293 match 'permissions', :via => [:get, :post]
294 294 end
295 295 end
296 296 resources :enumerations, :except => :show
297 297 match 'enumerations/:type', :to => 'enumerations#index', :via => :get
298 298
299 299 get 'projects/:id/search', :controller => 'search', :action => 'index'
300 300 get 'search', :controller => 'search', :action => 'index'
301 301
302 302 match 'mail_handler', :controller => 'mail_handler', :action => 'index', :via => :post
303 303
304 304 match 'admin', :controller => 'admin', :action => 'index', :via => :get
305 305 match 'admin/projects', :controller => 'admin', :action => 'projects', :via => :get
306 306 match 'admin/plugins', :controller => 'admin', :action => 'plugins', :via => :get
307 307 match 'admin/info', :controller => 'admin', :action => 'info', :via => :get
308 308 match 'admin/test_email', :controller => 'admin', :action => 'test_email', :via => :get
309 309 match 'admin/default_configuration', :controller => 'admin', :action => 'default_configuration', :via => :post
310 310
311 311 resources :auth_sources do
312 312 member do
313 313 get 'test_connection', :as => 'try_connection'
314 314 end
315 315 collection do
316 316 get 'autocomplete_for_new_user'
317 317 end
318 318 end
319 319
320 320 match 'workflows', :controller => 'workflows', :action => 'index', :via => :get
321 321 match 'workflows/edit', :controller => 'workflows', :action => 'edit', :via => [:get, :post]
322 322 match 'workflows/permissions', :controller => 'workflows', :action => 'permissions', :via => [:get, :post]
323 323 match 'workflows/copy', :controller => 'workflows', :action => 'copy', :via => [:get, :post]
324 324 match 'settings', :controller => 'settings', :action => 'index', :via => :get
325 325 match 'settings/edit', :controller => 'settings', :action => 'edit', :via => [:get, :post]
326 326 match 'settings/plugin/:id', :controller => 'settings', :action => 'plugin', :via => [:get, :post], :as => 'plugin_settings'
327 327
328 328 match 'sys/projects', :to => 'sys#projects', :via => :get
329 329 match 'sys/projects/:id/repository', :to => 'sys#create_project_repository', :via => :post
330 330 match 'sys/fetch_changesets', :to => 'sys#fetch_changesets', :via => :get
331 331
332 332 match 'uploads', :to => 'attachments#upload', :via => :post
333 333
334 334 get 'robots.txt', :to => 'welcome#robots'
335 335
336 336 Dir.glob File.expand_path("plugins/*", Rails.root) do |plugin_dir|
337 337 file = File.join(plugin_dir, "config/routes.rb")
338 338 if File.exists?(file)
339 339 begin
340 340 instance_eval File.read(file)
341 341 rescue Exception => e
342 342 puts "An error occurred while loading the routes definition of #{File.basename(plugin_dir)} plugin (#{file}): #{e.message}."
343 343 exit 1
344 344 end
345 345 end
346 346 end
347 347 end
@@ -1,284 +1,284
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require 'redmine/core_ext'
19 19
20 20 begin
21 21 require 'RMagick' unless Object.const_defined?(:Magick)
22 22 rescue LoadError
23 23 # RMagick is not available
24 24 end
25 25
26 26 require 'redmine/scm/base'
27 27 require 'redmine/access_control'
28 28 require 'redmine/access_keys'
29 29 require 'redmine/activity'
30 30 require 'redmine/activity/fetcher'
31 31 require 'redmine/ciphering'
32 32 require 'redmine/codeset_util'
33 33 require 'redmine/custom_field_format'
34 34 require 'redmine/i18n'
35 35 require 'redmine/menu_manager'
36 36 require 'redmine/notifiable'
37 37 require 'redmine/platform'
38 38 require 'redmine/mime_type'
39 39 require 'redmine/notifiable'
40 40 require 'redmine/search'
41 41 require 'redmine/syntax_highlighting'
42 42 require 'redmine/thumbnail'
43 43 require 'redmine/unified_diff'
44 44 require 'redmine/utils'
45 45 require 'redmine/version'
46 46 require 'redmine/wiki_formatting'
47 47
48 48 require 'redmine/default_data/loader'
49 49 require 'redmine/helpers/calendar'
50 50 require 'redmine/helpers/diff'
51 51 require 'redmine/helpers/gantt'
52 52 require 'redmine/helpers/time_report'
53 53 require 'redmine/views/other_formats_builder'
54 54 require 'redmine/views/labelled_form_builder'
55 55 require 'redmine/views/builders'
56 56
57 57 require 'redmine/themes'
58 58 require 'redmine/hook'
59 59 require 'redmine/plugin'
60 60
61 61 if RUBY_VERSION < '1.9'
62 62 require 'fastercsv'
63 63 else
64 64 require 'csv'
65 65 FCSV = CSV
66 66 end
67 67
68 68 Redmine::Scm::Base.add "Subversion"
69 69 Redmine::Scm::Base.add "Darcs"
70 70 Redmine::Scm::Base.add "Mercurial"
71 71 Redmine::Scm::Base.add "Cvs"
72 72 Redmine::Scm::Base.add "Bazaar"
73 73 Redmine::Scm::Base.add "Git"
74 74 Redmine::Scm::Base.add "Filesystem"
75 75
76 76 Redmine::CustomFieldFormat.map do |fields|
77 77 fields.register 'string'
78 78 fields.register 'text'
79 79 fields.register 'int', :label => :label_integer
80 80 fields.register 'float'
81 81 fields.register 'list'
82 82 fields.register 'date'
83 83 fields.register 'bool', :label => :label_boolean
84 84 fields.register 'user', :only => %w(Issue TimeEntry Version Project), :edit_as => 'list'
85 85 fields.register 'version', :only => %w(Issue TimeEntry Version Project), :edit_as => 'list'
86 86 end
87 87
88 88 # Permissions
89 89 Redmine::AccessControl.map do |map|
90 90 map.permission :view_project, {:projects => [:show], :activities => [:index]}, :public => true, :read => true
91 91 map.permission :search_project, {:search => :index}, :public => true, :read => true
92 92 map.permission :add_project, {:projects => [:new, :create]}, :require => :loggedin
93 93 map.permission :edit_project, {:projects => [:settings, :edit, :update]}, :require => :member
94 94 map.permission :close_project, {:projects => [:close, :reopen]}, :require => :member, :read => true
95 95 map.permission :select_project_modules, {:projects => :modules}, :require => :member
96 96 map.permission :manage_members, {:projects => :settings, :members => [:index, :show, :create, :update, :destroy, :autocomplete]}, :require => :member
97 97 map.permission :manage_versions, {:projects => :settings, :versions => [:new, :create, :edit, :update, :close_completed, :destroy]}, :require => :member
98 98 map.permission :add_subprojects, {:projects => [:new, :create]}, :require => :member
99 99
100 100 map.project_module :issue_tracking do |map|
101 101 # Issue categories
102 102 map.permission :manage_categories, {:projects => :settings, :issue_categories => [:index, :show, :new, :create, :edit, :update, :destroy]}, :require => :member
103 103 # Issues
104 104 map.permission :view_issues, {:issues => [:index, :show],
105 105 :auto_complete => [:issues],
106 106 :context_menus => [:issues],
107 107 :versions => [:index, :show, :status_by],
108 108 :journals => [:index, :diff],
109 109 :queries => :index,
110 110 :reports => [:issue_report, :issue_report_details]},
111 111 :read => true
112 112 map.permission :add_issues, {:issues => [:new, :create, :update_form], :attachments => :upload}
113 113 map.permission :edit_issues, {:issues => [:edit, :update, :bulk_edit, :bulk_update, :update_form], :journals => [:new], :attachments => :upload}
114 114 map.permission :manage_issue_relations, {:issue_relations => [:index, :show, :create, :destroy]}
115 115 map.permission :manage_subtasks, {}
116 116 map.permission :set_issues_private, {}
117 117 map.permission :set_own_issues_private, {}, :require => :loggedin
118 map.permission :add_issue_notes, {:issues => [:edit, :update], :journals => [:new], :attachments => :upload}
118 map.permission :add_issue_notes, {:issues => [:edit, :update, :update_form], :journals => [:new], :attachments => :upload}
119 119 map.permission :edit_issue_notes, {:journals => :edit}, :require => :loggedin
120 120 map.permission :edit_own_issue_notes, {:journals => :edit}, :require => :loggedin
121 121 map.permission :view_private_notes, {}, :read => true, :require => :member
122 122 map.permission :set_notes_private, {}, :require => :member
123 123 map.permission :move_issues, {:issues => [:bulk_edit, :bulk_update]}, :require => :loggedin
124 124 map.permission :delete_issues, {:issues => :destroy}, :require => :member
125 125 # Queries
126 126 map.permission :manage_public_queries, {:queries => [:new, :create, :edit, :update, :destroy]}, :require => :member
127 127 map.permission :save_queries, {:queries => [:new, :create, :edit, :update, :destroy]}, :require => :loggedin
128 128 # Watchers
129 129 map.permission :view_issue_watchers, {}, :read => true
130 130 map.permission :add_issue_watchers, {:watchers => [:new, :create, :append, :autocomplete_for_user]}
131 131 map.permission :delete_issue_watchers, {:watchers => :destroy}
132 132 end
133 133
134 134 map.project_module :time_tracking do |map|
135 135 map.permission :log_time, {:timelog => [:new, :create]}, :require => :loggedin
136 136 map.permission :view_time_entries, {:timelog => [:index, :report, :show]}, :read => true
137 137 map.permission :edit_time_entries, {:timelog => [:edit, :update, :destroy, :bulk_edit, :bulk_update]}, :require => :member
138 138 map.permission :edit_own_time_entries, {:timelog => [:edit, :update, :destroy,:bulk_edit, :bulk_update]}, :require => :loggedin
139 139 map.permission :manage_project_activities, {:project_enumerations => [:update, :destroy]}, :require => :member
140 140 end
141 141
142 142 map.project_module :news do |map|
143 143 map.permission :manage_news, {:news => [:new, :create, :edit, :update, :destroy], :comments => [:destroy]}, :require => :member
144 144 map.permission :view_news, {:news => [:index, :show]}, :public => true, :read => true
145 145 map.permission :comment_news, {:comments => :create}
146 146 end
147 147
148 148 map.project_module :documents do |map|
149 149 map.permission :add_documents, {:documents => [:new, :create, :add_attachment]}, :require => :loggedin
150 150 map.permission :edit_documents, {:documents => [:edit, :update, :add_attachment]}, :require => :loggedin
151 151 map.permission :delete_documents, {:documents => [:destroy]}, :require => :loggedin
152 152 map.permission :view_documents, {:documents => [:index, :show, :download]}, :read => true
153 153 end
154 154
155 155 map.project_module :files do |map|
156 156 map.permission :manage_files, {:files => [:new, :create]}, :require => :loggedin
157 157 map.permission :view_files, {:files => :index, :versions => :download}, :read => true
158 158 end
159 159
160 160 map.project_module :wiki do |map|
161 161 map.permission :manage_wiki, {:wikis => [:edit, :destroy]}, :require => :member
162 162 map.permission :rename_wiki_pages, {:wiki => :rename}, :require => :member
163 163 map.permission :delete_wiki_pages, {:wiki => [:destroy, :destroy_version]}, :require => :member
164 164 map.permission :view_wiki_pages, {:wiki => [:index, :show, :special, :date_index]}, :read => true
165 165 map.permission :export_wiki_pages, {:wiki => [:export]}, :read => true
166 166 map.permission :view_wiki_edits, {:wiki => [:history, :diff, :annotate]}, :read => true
167 167 map.permission :edit_wiki_pages, :wiki => [:edit, :update, :preview, :add_attachment]
168 168 map.permission :delete_wiki_pages_attachments, {}
169 169 map.permission :protect_wiki_pages, {:wiki => :protect}, :require => :member
170 170 end
171 171
172 172 map.project_module :repository do |map|
173 173 map.permission :manage_repository, {:repositories => [:new, :create, :edit, :update, :committers, :destroy]}, :require => :member
174 174 map.permission :browse_repository, {:repositories => [:show, :browse, :entry, :raw, :annotate, :changes, :diff, :stats, :graph]}, :read => true
175 175 map.permission :view_changesets, {:repositories => [:show, :revisions, :revision]}, :read => true
176 176 map.permission :commit_access, {}
177 177 map.permission :manage_related_issues, {:repositories => [:add_related_issue, :remove_related_issue]}
178 178 end
179 179
180 180 map.project_module :boards do |map|
181 181 map.permission :manage_boards, {:boards => [:new, :create, :edit, :update, :destroy]}, :require => :member
182 182 map.permission :view_messages, {:boards => [:index, :show], :messages => [:show]}, :public => true, :read => true
183 183 map.permission :add_messages, {:messages => [:new, :reply, :quote]}
184 184 map.permission :edit_messages, {:messages => :edit}, :require => :member
185 185 map.permission :edit_own_messages, {:messages => :edit}, :require => :loggedin
186 186 map.permission :delete_messages, {:messages => :destroy}, :require => :member
187 187 map.permission :delete_own_messages, {:messages => :destroy}, :require => :loggedin
188 188 end
189 189
190 190 map.project_module :calendar do |map|
191 191 map.permission :view_calendar, {:calendars => [:show, :update]}, :read => true
192 192 end
193 193
194 194 map.project_module :gantt do |map|
195 195 map.permission :view_gantt, {:gantts => [:show, :update]}, :read => true
196 196 end
197 197 end
198 198
199 199 Redmine::MenuManager.map :top_menu do |menu|
200 200 menu.push :home, :home_path
201 201 menu.push :my_page, { :controller => 'my', :action => 'page' }, :if => Proc.new { User.current.logged? }
202 202 menu.push :projects, { :controller => 'projects', :action => 'index' }, :caption => :label_project_plural
203 203 menu.push :administration, { :controller => 'admin', :action => 'index' }, :if => Proc.new { User.current.admin? }, :last => true
204 204 menu.push :help, Redmine::Info.help_url, :last => true
205 205 end
206 206
207 207 Redmine::MenuManager.map :account_menu do |menu|
208 208 menu.push :login, :signin_path, :if => Proc.new { !User.current.logged? }
209 209 menu.push :register, :register_path, :if => Proc.new { !User.current.logged? && Setting.self_registration? }
210 210 menu.push :my_account, { :controller => 'my', :action => 'account' }, :if => Proc.new { User.current.logged? }
211 211 menu.push :logout, :signout_path, :html => {:method => 'post'}, :if => Proc.new { User.current.logged? }
212 212 end
213 213
214 214 Redmine::MenuManager.map :application_menu do |menu|
215 215 # Empty
216 216 end
217 217
218 218 Redmine::MenuManager.map :admin_menu do |menu|
219 219 menu.push :projects, {:controller => 'admin', :action => 'projects'}, :caption => :label_project_plural
220 220 menu.push :users, {:controller => 'users'}, :caption => :label_user_plural
221 221 menu.push :groups, {:controller => 'groups'}, :caption => :label_group_plural
222 222 menu.push :roles, {:controller => 'roles'}, :caption => :label_role_and_permissions
223 223 menu.push :trackers, {:controller => 'trackers'}, :caption => :label_tracker_plural
224 224 menu.push :issue_statuses, {:controller => 'issue_statuses'}, :caption => :label_issue_status_plural,
225 225 :html => {:class => 'issue_statuses'}
226 226 menu.push :workflows, {:controller => 'workflows', :action => 'edit'}, :caption => :label_workflow
227 227 menu.push :custom_fields, {:controller => 'custom_fields'}, :caption => :label_custom_field_plural,
228 228 :html => {:class => 'custom_fields'}
229 229 menu.push :enumerations, {:controller => 'enumerations'}
230 230 menu.push :settings, {:controller => 'settings'}
231 231 menu.push :ldap_authentication, {:controller => 'auth_sources', :action => 'index'},
232 232 :html => {:class => 'server_authentication'}
233 233 menu.push :plugins, {:controller => 'admin', :action => 'plugins'}, :last => true
234 234 menu.push :info, {:controller => 'admin', :action => 'info'}, :caption => :label_information_plural, :last => true
235 235 end
236 236
237 237 Redmine::MenuManager.map :project_menu do |menu|
238 238 menu.push :overview, { :controller => 'projects', :action => 'show' }
239 239 menu.push :activity, { :controller => 'activities', :action => 'index' }
240 240 menu.push :roadmap, { :controller => 'versions', :action => 'index' }, :param => :project_id,
241 241 :if => Proc.new { |p| p.shared_versions.any? }
242 242 menu.push :issues, { :controller => 'issues', :action => 'index' }, :param => :project_id, :caption => :label_issue_plural
243 243 menu.push :new_issue, { :controller => 'issues', :action => 'new', :copy_from => nil }, :param => :project_id, :caption => :label_issue_new,
244 244 :html => { :accesskey => Redmine::AccessKeys.key_for(:new_issue) }
245 245 menu.push :gantt, { :controller => 'gantts', :action => 'show' }, :param => :project_id, :caption => :label_gantt
246 246 menu.push :calendar, { :controller => 'calendars', :action => 'show' }, :param => :project_id, :caption => :label_calendar
247 247 menu.push :news, { :controller => 'news', :action => 'index' }, :param => :project_id, :caption => :label_news_plural
248 248 menu.push :documents, { :controller => 'documents', :action => 'index' }, :param => :project_id, :caption => :label_document_plural
249 249 menu.push :wiki, { :controller => 'wiki', :action => 'show', :id => nil }, :param => :project_id,
250 250 :if => Proc.new { |p| p.wiki && !p.wiki.new_record? }
251 251 menu.push :boards, { :controller => 'boards', :action => 'index', :id => nil }, :param => :project_id,
252 252 :if => Proc.new { |p| p.boards.any? }, :caption => :label_board_plural
253 253 menu.push :files, { :controller => 'files', :action => 'index' }, :caption => :label_file_plural, :param => :project_id
254 254 menu.push :repository, { :controller => 'repositories', :action => 'show', :repository_id => nil, :path => nil, :rev => nil },
255 255 :if => Proc.new { |p| p.repository && !p.repository.new_record? }
256 256 menu.push :settings, { :controller => 'projects', :action => 'settings' }, :last => true
257 257 end
258 258
259 259 Redmine::Activity.map do |activity|
260 260 activity.register :issues, :class_name => %w(Issue Journal)
261 261 activity.register :changesets
262 262 activity.register :news
263 263 activity.register :documents, :class_name => %w(Document Attachment)
264 264 activity.register :files, :class_name => 'Attachment'
265 265 activity.register :wiki_edits, :class_name => 'WikiContent::Version', :default => false
266 266 activity.register :messages, :default => false
267 267 activity.register :time_entries, :default => false
268 268 end
269 269
270 270 Redmine::Search.map do |search|
271 271 search.register :issues
272 272 search.register :news
273 273 search.register :documents
274 274 search.register :changesets
275 275 search.register :wiki_pages
276 276 search.register :messages
277 277 search.register :projects
278 278 end
279 279
280 280 Redmine::WikiFormatting.map do |format|
281 281 format.register :textile, Redmine::WikiFormatting::Textile::Formatter, Redmine::WikiFormatting::Textile::Helper
282 282 end
283 283
284 284 ActionView::Template.register_template_handler :rsb, Redmine::Views::ApiTemplateHandler
@@ -1,166 +1,169
1 1 ---
2 2 users_004:
3 3 created_on: 2006-07-19 19:34:07 +02:00
4 4 status: 1
5 5 last_login_on:
6 6 language: en
7 7 # password = foo
8 8 salt: 3126f764c3c5ac61cbfc103f25f934cf
9 9 hashed_password: 9e4dd7eeb172c12a0691a6d9d3a269f7e9fe671b
10 10 updated_on: 2006-07-19 19:34:07 +02:00
11 11 admin: false
12 12 mail: rhill@somenet.foo
13 13 lastname: Hill
14 14 firstname: Robert
15 15 id: 4
16 16 auth_source_id:
17 17 mail_notification: all
18 18 login: rhill
19 19 type: User
20 20 users_001:
21 21 created_on: 2006-07-19 19:12:21 +02:00
22 22 status: 1
23 23 last_login_on: 2006-07-19 22:57:52 +02:00
24 24 language: en
25 25 # password = admin
26 26 salt: 82090c953c4a0000a7db253b0691a6b4
27 27 hashed_password: b5b6ff9543bf1387374cdfa27a54c96d236a7150
28 28 updated_on: 2006-07-19 22:57:52 +02:00
29 29 admin: true
30 30 mail: admin@somenet.foo
31 31 lastname: Admin
32 32 firstname: Redmine
33 33 id: 1
34 34 auth_source_id:
35 35 mail_notification: all
36 36 login: admin
37 37 type: User
38 38 users_002:
39 39 created_on: 2006-07-19 19:32:09 +02:00
40 40 status: 1
41 41 last_login_on: 2006-07-19 22:42:15 +02:00
42 42 language: en
43 43 # password = jsmith
44 44 salt: 67eb4732624d5a7753dcea7ce0bb7d7d
45 45 hashed_password: bfbe06043353a677d0215b26a5800d128d5413bc
46 46 updated_on: 2006-07-19 22:42:15 +02:00
47 47 admin: false
48 48 mail: jsmith@somenet.foo
49 49 lastname: Smith
50 50 firstname: John
51 51 id: 2
52 52 auth_source_id:
53 53 mail_notification: all
54 54 login: jsmith
55 55 type: User
56 56 users_003:
57 57 created_on: 2006-07-19 19:33:19 +02:00
58 58 status: 1
59 59 last_login_on:
60 60 language: en
61 61 # password = foo
62 62 salt: 7599f9963ec07b5a3b55b354407120c0
63 63 hashed_password: 8f659c8d7c072f189374edacfa90d6abbc26d8ed
64 64 updated_on: 2006-07-19 19:33:19 +02:00
65 65 admin: false
66 66 mail: dlopper@somenet.foo
67 67 lastname: Lopper
68 68 firstname: Dave
69 69 id: 3
70 70 auth_source_id:
71 71 mail_notification: all
72 72 login: dlopper
73 73 type: User
74 74 users_005:
75 75 id: 5
76 76 created_on: 2006-07-19 19:33:19 +02:00
77 77 # Locked
78 78 status: 3
79 79 last_login_on:
80 80 language: en
81 81 hashed_password: 1
82 82 updated_on: 2006-07-19 19:33:19 +02:00
83 83 admin: false
84 84 mail: dlopper2@somenet.foo
85 85 lastname: Lopper2
86 86 firstname: Dave2
87 87 auth_source_id:
88 88 mail_notification: all
89 89 login: dlopper2
90 90 type: User
91 91 users_006:
92 92 id: 6
93 93 created_on: 2006-07-19 19:33:19 +02:00
94 94 status: 0
95 95 last_login_on:
96 96 language: ''
97 97 hashed_password: 1
98 98 updated_on: 2006-07-19 19:33:19 +02:00
99 99 admin: false
100 100 mail: ''
101 101 lastname: Anonymous
102 102 firstname: ''
103 103 auth_source_id:
104 104 mail_notification: only_my_events
105 105 login: ''
106 106 type: AnonymousUser
107 107 users_007:
108 # A user who does not belong to any project
108 109 id: 7
109 110 created_on: 2006-07-19 19:33:19 +02:00
110 111 status: 1
111 112 last_login_on:
112 language: ''
113 hashed_password: 1
113 language: 'en'
114 # password = foo
115 salt: 7599f9963ec07b5a3b55b354407120c0
116 hashed_password: 8f659c8d7c072f189374edacfa90d6abbc26d8ed
114 117 updated_on: 2006-07-19 19:33:19 +02:00
115 118 admin: false
116 119 mail: someone@foo.bar
117 120 lastname: One
118 121 firstname: Some
119 122 auth_source_id:
120 123 mail_notification: only_my_events
121 124 login: someone
122 125 type: User
123 126 users_008:
124 127 id: 8
125 128 created_on: 2006-07-19 19:33:19 +02:00
126 129 status: 1
127 130 last_login_on:
128 131 language: 'it'
129 132 # password = foo
130 133 salt: 7599f9963ec07b5a3b55b354407120c0
131 134 hashed_password: 8f659c8d7c072f189374edacfa90d6abbc26d8ed
132 135 updated_on: 2006-07-19 19:33:19 +02:00
133 136 admin: false
134 137 mail: miscuser8@foo.bar
135 138 lastname: Misc
136 139 firstname: User
137 140 auth_source_id:
138 141 mail_notification: only_my_events
139 142 login: miscuser8
140 143 type: User
141 144 users_009:
142 145 id: 9
143 146 created_on: 2006-07-19 19:33:19 +02:00
144 147 status: 1
145 148 last_login_on:
146 149 language: 'it'
147 150 hashed_password: 1
148 151 updated_on: 2006-07-19 19:33:19 +02:00
149 152 admin: false
150 153 mail: miscuser9@foo.bar
151 154 lastname: Misc
152 155 firstname: User
153 156 auth_source_id:
154 157 mail_notification: only_my_events
155 158 login: miscuser9
156 159 type: User
157 160 groups_010:
158 161 id: 10
159 162 lastname: A Team
160 163 type: Group
161 164 groups_011:
162 165 id: 11
163 166 lastname: B Team
164 167 type: Group
165 168
166 169
@@ -1,3872 +1,3872
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssuesControllerTest < ActionController::TestCase
21 21 fixtures :projects,
22 22 :users,
23 23 :roles,
24 24 :members,
25 25 :member_roles,
26 26 :issues,
27 27 :issue_statuses,
28 28 :versions,
29 29 :trackers,
30 30 :projects_trackers,
31 31 :issue_categories,
32 32 :enabled_modules,
33 33 :enumerations,
34 34 :attachments,
35 35 :workflows,
36 36 :custom_fields,
37 37 :custom_values,
38 38 :custom_fields_projects,
39 39 :custom_fields_trackers,
40 40 :time_entries,
41 41 :journals,
42 42 :journal_details,
43 43 :queries,
44 44 :repositories,
45 45 :changesets
46 46
47 47 include Redmine::I18n
48 48
49 49 def setup
50 50 User.current = nil
51 51 end
52 52
53 53 def test_index
54 54 with_settings :default_language => "en" do
55 55 get :index
56 56 assert_response :success
57 57 assert_template 'index'
58 58 assert_not_nil assigns(:issues)
59 59 assert_nil assigns(:project)
60 60
61 61 # links to visible issues
62 62 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
63 63 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
64 64 # private projects hidden
65 65 assert_select 'a[href=/issues/6]', 0
66 66 assert_select 'a[href=/issues/4]', 0
67 67 # project column
68 68 assert_select 'th', :text => /Project/
69 69 end
70 70 end
71 71
72 72 def test_index_should_not_list_issues_when_module_disabled
73 73 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
74 74 get :index
75 75 assert_response :success
76 76 assert_template 'index'
77 77 assert_not_nil assigns(:issues)
78 78 assert_nil assigns(:project)
79 79
80 80 assert_select 'a[href=/issues/1]', 0
81 81 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
82 82 end
83 83
84 84 def test_index_should_list_visible_issues_only
85 85 get :index, :per_page => 100
86 86 assert_response :success
87 87 assert_not_nil assigns(:issues)
88 88 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
89 89 end
90 90
91 91 def test_index_with_project
92 92 Setting.display_subprojects_issues = 0
93 93 get :index, :project_id => 1
94 94 assert_response :success
95 95 assert_template 'index'
96 96 assert_not_nil assigns(:issues)
97 97
98 98 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
99 99 assert_select 'a[href=/issues/5]', 0
100 100 end
101 101
102 102 def test_index_with_project_and_subprojects
103 103 Setting.display_subprojects_issues = 1
104 104 get :index, :project_id => 1
105 105 assert_response :success
106 106 assert_template 'index'
107 107 assert_not_nil assigns(:issues)
108 108
109 109 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
110 110 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
111 111 assert_select 'a[href=/issues/6]', 0
112 112 end
113 113
114 114 def test_index_with_project_and_subprojects_should_show_private_subprojects_with_permission
115 115 @request.session[:user_id] = 2
116 116 Setting.display_subprojects_issues = 1
117 117 get :index, :project_id => 1
118 118 assert_response :success
119 119 assert_template 'index'
120 120 assert_not_nil assigns(:issues)
121 121
122 122 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
123 123 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
124 124 assert_select 'a[href=/issues/6]', :text => /Issue of a private subproject/
125 125 end
126 126
127 127 def test_index_with_project_and_default_filter
128 128 get :index, :project_id => 1, :set_filter => 1
129 129 assert_response :success
130 130 assert_template 'index'
131 131 assert_not_nil assigns(:issues)
132 132
133 133 query = assigns(:query)
134 134 assert_not_nil query
135 135 # default filter
136 136 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
137 137 end
138 138
139 139 def test_index_with_project_and_filter
140 140 get :index, :project_id => 1, :set_filter => 1,
141 141 :f => ['tracker_id'],
142 142 :op => {'tracker_id' => '='},
143 143 :v => {'tracker_id' => ['1']}
144 144 assert_response :success
145 145 assert_template 'index'
146 146 assert_not_nil assigns(:issues)
147 147
148 148 query = assigns(:query)
149 149 assert_not_nil query
150 150 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
151 151 end
152 152
153 153 def test_index_with_short_filters
154 154 to_test = {
155 155 'status_id' => {
156 156 'o' => { :op => 'o', :values => [''] },
157 157 'c' => { :op => 'c', :values => [''] },
158 158 '7' => { :op => '=', :values => ['7'] },
159 159 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
160 160 '=7' => { :op => '=', :values => ['7'] },
161 161 '!3' => { :op => '!', :values => ['3'] },
162 162 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
163 163 'subject' => {
164 164 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
165 165 'o' => { :op => '=', :values => ['o'] },
166 166 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
167 167 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
168 168 'tracker_id' => {
169 169 '3' => { :op => '=', :values => ['3'] },
170 170 '=3' => { :op => '=', :values => ['3'] }},
171 171 'start_date' => {
172 172 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
173 173 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
174 174 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
175 175 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
176 176 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
177 177 '<t+2' => { :op => '<t+', :values => ['2'] },
178 178 '>t+2' => { :op => '>t+', :values => ['2'] },
179 179 't+2' => { :op => 't+', :values => ['2'] },
180 180 't' => { :op => 't', :values => [''] },
181 181 'w' => { :op => 'w', :values => [''] },
182 182 '>t-2' => { :op => '>t-', :values => ['2'] },
183 183 '<t-2' => { :op => '<t-', :values => ['2'] },
184 184 't-2' => { :op => 't-', :values => ['2'] }},
185 185 'created_on' => {
186 186 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
187 187 '<t-2' => { :op => '<t-', :values => ['2'] },
188 188 '>t-2' => { :op => '>t-', :values => ['2'] },
189 189 't-2' => { :op => 't-', :values => ['2'] }},
190 190 'cf_1' => {
191 191 'c' => { :op => '=', :values => ['c'] },
192 192 '!c' => { :op => '!', :values => ['c'] },
193 193 '!*' => { :op => '!*', :values => [''] },
194 194 '*' => { :op => '*', :values => [''] }},
195 195 'estimated_hours' => {
196 196 '=13.4' => { :op => '=', :values => ['13.4'] },
197 197 '>=45' => { :op => '>=', :values => ['45'] },
198 198 '<=125' => { :op => '<=', :values => ['125'] },
199 199 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
200 200 '!*' => { :op => '!*', :values => [''] },
201 201 '*' => { :op => '*', :values => [''] }}
202 202 }
203 203
204 204 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
205 205
206 206 to_test.each do |field, expression_and_expected|
207 207 expression_and_expected.each do |filter_expression, expected|
208 208
209 209 get :index, :set_filter => 1, field => filter_expression
210 210
211 211 assert_response :success
212 212 assert_template 'index'
213 213 assert_not_nil assigns(:issues)
214 214
215 215 query = assigns(:query)
216 216 assert_not_nil query
217 217 assert query.has_filter?(field)
218 218 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
219 219 end
220 220 end
221 221 end
222 222
223 223 def test_index_with_project_and_empty_filters
224 224 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
225 225 assert_response :success
226 226 assert_template 'index'
227 227 assert_not_nil assigns(:issues)
228 228
229 229 query = assigns(:query)
230 230 assert_not_nil query
231 231 # no filter
232 232 assert_equal({}, query.filters)
233 233 end
234 234
235 235 def test_index_with_project_custom_field_filter
236 236 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
237 237 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
238 238 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
239 239 filter_name = "project.cf_#{field.id}"
240 240 @request.session[:user_id] = 1
241 241
242 242 get :index, :set_filter => 1,
243 243 :f => [filter_name],
244 244 :op => {filter_name => '='},
245 245 :v => {filter_name => ['Foo']}
246 246 assert_response :success
247 247 assert_template 'index'
248 248 assert_equal [3, 5], assigns(:issues).map(&:project_id).uniq.sort
249 249 end
250 250
251 251 def test_index_with_query
252 252 get :index, :project_id => 1, :query_id => 5
253 253 assert_response :success
254 254 assert_template 'index'
255 255 assert_not_nil assigns(:issues)
256 256 assert_nil assigns(:issue_count_by_group)
257 257 end
258 258
259 259 def test_index_with_query_grouped_by_tracker
260 260 get :index, :project_id => 1, :query_id => 6
261 261 assert_response :success
262 262 assert_template 'index'
263 263 assert_not_nil assigns(:issues)
264 264 assert_not_nil assigns(:issue_count_by_group)
265 265 end
266 266
267 267 def test_index_with_query_grouped_by_list_custom_field
268 268 get :index, :project_id => 1, :query_id => 9
269 269 assert_response :success
270 270 assert_template 'index'
271 271 assert_not_nil assigns(:issues)
272 272 assert_not_nil assigns(:issue_count_by_group)
273 273 end
274 274
275 275 def test_index_with_query_grouped_by_user_custom_field
276 276 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
277 277 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
278 278 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
279 279 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
280 280 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
281 281
282 282 get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
283 283 assert_response :success
284 284
285 285 assert_select 'tr.group', 3
286 286 assert_select 'tr.group' do
287 287 assert_select 'a', :text => 'John Smith'
288 288 assert_select 'span.count', :text => '1'
289 289 end
290 290 assert_select 'tr.group' do
291 291 assert_select 'a', :text => 'Dave Lopper'
292 292 assert_select 'span.count', :text => '2'
293 293 end
294 294 end
295 295
296 296 def test_index_with_query_grouped_by_tracker
297 297 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
298 298
299 299 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc'
300 300 assert_response :success
301 301
302 302 trackers = assigns(:issues).map(&:tracker).uniq
303 303 assert_equal [1, 2, 3], trackers.map(&:id)
304 304 end
305 305
306 306 def test_index_with_query_grouped_by_tracker_in_reverse_order
307 307 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
308 308
309 309 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc,tracker:desc'
310 310 assert_response :success
311 311
312 312 trackers = assigns(:issues).map(&:tracker).uniq
313 313 assert_equal [3, 2, 1], trackers.map(&:id)
314 314 end
315 315
316 316 def test_index_with_query_id_and_project_id_should_set_session_query
317 317 get :index, :project_id => 1, :query_id => 4
318 318 assert_response :success
319 319 assert_kind_of Hash, session[:query]
320 320 assert_equal 4, session[:query][:id]
321 321 assert_equal 1, session[:query][:project_id]
322 322 end
323 323
324 324 def test_index_with_invalid_query_id_should_respond_404
325 325 get :index, :project_id => 1, :query_id => 999
326 326 assert_response 404
327 327 end
328 328
329 329 def test_index_with_cross_project_query_in_session_should_show_project_issues
330 330 q = IssueQuery.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
331 331 @request.session[:query] = {:id => q.id, :project_id => 1}
332 332
333 333 with_settings :display_subprojects_issues => '0' do
334 334 get :index, :project_id => 1
335 335 end
336 336 assert_response :success
337 337 assert_not_nil assigns(:query)
338 338 assert_equal q.id, assigns(:query).id
339 339 assert_equal 1, assigns(:query).project_id
340 340 assert_equal [1], assigns(:issues).map(&:project_id).uniq
341 341 end
342 342
343 343 def test_private_query_should_not_be_available_to_other_users
344 344 q = IssueQuery.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
345 345 @request.session[:user_id] = 3
346 346
347 347 get :index, :query_id => q.id
348 348 assert_response 403
349 349 end
350 350
351 351 def test_private_query_should_be_available_to_its_user
352 352 q = IssueQuery.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
353 353 @request.session[:user_id] = 2
354 354
355 355 get :index, :query_id => q.id
356 356 assert_response :success
357 357 end
358 358
359 359 def test_public_query_should_be_available_to_other_users
360 360 q = IssueQuery.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
361 361 @request.session[:user_id] = 3
362 362
363 363 get :index, :query_id => q.id
364 364 assert_response :success
365 365 end
366 366
367 367 def test_index_should_omit_page_param_in_export_links
368 368 get :index, :page => 2
369 369 assert_response :success
370 370 assert_select 'a.atom[href=/issues.atom]'
371 371 assert_select 'a.csv[href=/issues.csv]'
372 372 assert_select 'a.pdf[href=/issues.pdf]'
373 373 assert_select 'form#csv-export-form[action=/issues.csv]'
374 374 end
375 375
376 376 def test_index_csv
377 377 get :index, :format => 'csv'
378 378 assert_response :success
379 379 assert_not_nil assigns(:issues)
380 380 assert_equal 'text/csv; header=present', @response.content_type
381 381 assert @response.body.starts_with?("#,")
382 382 lines = @response.body.chomp.split("\n")
383 383 assert_equal assigns(:query).columns.size + 1, lines[0].split(',').size
384 384 end
385 385
386 386 def test_index_csv_with_project
387 387 get :index, :project_id => 1, :format => 'csv'
388 388 assert_response :success
389 389 assert_not_nil assigns(:issues)
390 390 assert_equal 'text/csv; header=present', @response.content_type
391 391 end
392 392
393 393 def test_index_csv_with_description
394 394 get :index, :format => 'csv', :description => '1'
395 395 assert_response :success
396 396 assert_not_nil assigns(:issues)
397 397 assert_equal 'text/csv; header=present', @response.content_type
398 398 assert @response.body.starts_with?("#,")
399 399 lines = @response.body.chomp.split("\n")
400 400 assert_equal assigns(:query).columns.size + 2, lines[0].split(',').size
401 401 end
402 402
403 403 def test_index_csv_with_spent_time_column
404 404 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column', :author_id => 2)
405 405 TimeEntry.create!(:project => issue.project, :issue => issue, :hours => 7.33, :user => User.find(2), :spent_on => Date.today)
406 406
407 407 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
408 408 assert_response :success
409 409 assert_equal 'text/csv; header=present', @response.content_type
410 410 lines = @response.body.chomp.split("\n")
411 411 assert_include "#{issue.id},#{issue.subject},7.33", lines
412 412 end
413 413
414 414 def test_index_csv_with_all_columns
415 415 get :index, :format => 'csv', :columns => 'all'
416 416 assert_response :success
417 417 assert_not_nil assigns(:issues)
418 418 assert_equal 'text/csv; header=present', @response.content_type
419 419 assert @response.body.starts_with?("#,")
420 420 lines = @response.body.chomp.split("\n")
421 421 assert_equal assigns(:query).available_inline_columns.size + 1, lines[0].split(',').size
422 422 end
423 423
424 424 def test_index_csv_with_multi_column_field
425 425 CustomField.find(1).update_attribute :multiple, true
426 426 issue = Issue.find(1)
427 427 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
428 428 issue.save!
429 429
430 430 get :index, :format => 'csv', :columns => 'all'
431 431 assert_response :success
432 432 lines = @response.body.chomp.split("\n")
433 433 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
434 434 end
435 435
436 436 def test_index_csv_big_5
437 437 with_settings :default_language => "zh-TW" do
438 438 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
439 439 str_big5 = "\xa4@\xa4\xeb"
440 440 if str_utf8.respond_to?(:force_encoding)
441 441 str_utf8.force_encoding('UTF-8')
442 442 str_big5.force_encoding('Big5')
443 443 end
444 444 issue = Issue.generate!(:subject => str_utf8)
445 445
446 446 get :index, :project_id => 1,
447 447 :f => ['subject'],
448 448 :op => '=', :values => [str_utf8],
449 449 :format => 'csv'
450 450 assert_equal 'text/csv; header=present', @response.content_type
451 451 lines = @response.body.chomp.split("\n")
452 452 s1 = "\xaa\xac\xbaA"
453 453 if str_utf8.respond_to?(:force_encoding)
454 454 s1.force_encoding('Big5')
455 455 end
456 456 assert lines[0].include?(s1)
457 457 assert lines[1].include?(str_big5)
458 458 end
459 459 end
460 460
461 461 def test_index_csv_cannot_convert_should_be_replaced_big_5
462 462 with_settings :default_language => "zh-TW" do
463 463 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
464 464 if str_utf8.respond_to?(:force_encoding)
465 465 str_utf8.force_encoding('UTF-8')
466 466 end
467 467 issue = Issue.generate!(:subject => str_utf8)
468 468
469 469 get :index, :project_id => 1,
470 470 :f => ['subject'],
471 471 :op => '=', :values => [str_utf8],
472 472 :c => ['status', 'subject'],
473 473 :format => 'csv',
474 474 :set_filter => 1
475 475 assert_equal 'text/csv; header=present', @response.content_type
476 476 lines = @response.body.chomp.split("\n")
477 477 s1 = "\xaa\xac\xbaA" # status
478 478 if str_utf8.respond_to?(:force_encoding)
479 479 s1.force_encoding('Big5')
480 480 end
481 481 assert lines[0].include?(s1)
482 482 s2 = lines[1].split(",")[2]
483 483 if s1.respond_to?(:force_encoding)
484 484 s3 = "\xa5H?" # subject
485 485 s3.force_encoding('Big5')
486 486 assert_equal s3, s2
487 487 elsif RUBY_PLATFORM == 'java'
488 488 assert_equal "??", s2
489 489 else
490 490 assert_equal "\xa5H???", s2
491 491 end
492 492 end
493 493 end
494 494
495 495 def test_index_csv_tw
496 496 with_settings :default_language => "zh-TW" do
497 497 str1 = "test_index_csv_tw"
498 498 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
499 499
500 500 get :index, :project_id => 1,
501 501 :f => ['subject'],
502 502 :op => '=', :values => [str1],
503 503 :c => ['estimated_hours', 'subject'],
504 504 :format => 'csv',
505 505 :set_filter => 1
506 506 assert_equal 'text/csv; header=present', @response.content_type
507 507 lines = @response.body.chomp.split("\n")
508 508 assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
509 509 end
510 510 end
511 511
512 512 def test_index_csv_fr
513 513 with_settings :default_language => "fr" do
514 514 str1 = "test_index_csv_fr"
515 515 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
516 516
517 517 get :index, :project_id => 1,
518 518 :f => ['subject'],
519 519 :op => '=', :values => [str1],
520 520 :c => ['estimated_hours', 'subject'],
521 521 :format => 'csv',
522 522 :set_filter => 1
523 523 assert_equal 'text/csv; header=present', @response.content_type
524 524 lines = @response.body.chomp.split("\n")
525 525 assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
526 526 end
527 527 end
528 528
529 529 def test_index_pdf
530 530 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
531 531 with_settings :default_language => lang do
532 532
533 533 get :index
534 534 assert_response :success
535 535 assert_template 'index'
536 536
537 537 if lang == "ja"
538 538 if RUBY_PLATFORM != 'java'
539 539 assert_equal "CP932", l(:general_pdf_encoding)
540 540 end
541 541 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
542 542 next
543 543 end
544 544 end
545 545
546 546 get :index, :format => 'pdf'
547 547 assert_response :success
548 548 assert_not_nil assigns(:issues)
549 549 assert_equal 'application/pdf', @response.content_type
550 550
551 551 get :index, :project_id => 1, :format => 'pdf'
552 552 assert_response :success
553 553 assert_not_nil assigns(:issues)
554 554 assert_equal 'application/pdf', @response.content_type
555 555
556 556 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
557 557 assert_response :success
558 558 assert_not_nil assigns(:issues)
559 559 assert_equal 'application/pdf', @response.content_type
560 560 end
561 561 end
562 562 end
563 563
564 564 def test_index_pdf_with_query_grouped_by_list_custom_field
565 565 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
566 566 assert_response :success
567 567 assert_not_nil assigns(:issues)
568 568 assert_not_nil assigns(:issue_count_by_group)
569 569 assert_equal 'application/pdf', @response.content_type
570 570 end
571 571
572 572 def test_index_atom
573 573 get :index, :project_id => 'ecookbook', :format => 'atom'
574 574 assert_response :success
575 575 assert_template 'common/feed'
576 576 assert_equal 'application/atom+xml', response.content_type
577 577
578 578 assert_select 'feed' do
579 579 assert_select 'link[rel=self][href=?]', 'http://test.host/projects/ecookbook/issues.atom'
580 580 assert_select 'link[rel=alternate][href=?]', 'http://test.host/projects/ecookbook/issues'
581 581 assert_select 'entry link[href=?]', 'http://test.host/issues/1'
582 582 end
583 583 end
584 584
585 585 def test_index_sort
586 586 get :index, :sort => 'tracker,id:desc'
587 587 assert_response :success
588 588
589 589 sort_params = @request.session['issues_index_sort']
590 590 assert sort_params.is_a?(String)
591 591 assert_equal 'tracker,id:desc', sort_params
592 592
593 593 issues = assigns(:issues)
594 594 assert_not_nil issues
595 595 assert !issues.empty?
596 596 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
597 597 end
598 598
599 599 def test_index_sort_by_field_not_included_in_columns
600 600 Setting.issue_list_default_columns = %w(subject author)
601 601 get :index, :sort => 'tracker'
602 602 end
603 603
604 604 def test_index_sort_by_assigned_to
605 605 get :index, :sort => 'assigned_to'
606 606 assert_response :success
607 607 assignees = assigns(:issues).collect(&:assigned_to).compact
608 608 assert_equal assignees.sort, assignees
609 609 end
610 610
611 611 def test_index_sort_by_assigned_to_desc
612 612 get :index, :sort => 'assigned_to:desc'
613 613 assert_response :success
614 614 assignees = assigns(:issues).collect(&:assigned_to).compact
615 615 assert_equal assignees.sort.reverse, assignees
616 616 end
617 617
618 618 def test_index_group_by_assigned_to
619 619 get :index, :group_by => 'assigned_to', :sort => 'priority'
620 620 assert_response :success
621 621 end
622 622
623 623 def test_index_sort_by_author
624 624 get :index, :sort => 'author'
625 625 assert_response :success
626 626 authors = assigns(:issues).collect(&:author)
627 627 assert_equal authors.sort, authors
628 628 end
629 629
630 630 def test_index_sort_by_author_desc
631 631 get :index, :sort => 'author:desc'
632 632 assert_response :success
633 633 authors = assigns(:issues).collect(&:author)
634 634 assert_equal authors.sort.reverse, authors
635 635 end
636 636
637 637 def test_index_group_by_author
638 638 get :index, :group_by => 'author', :sort => 'priority'
639 639 assert_response :success
640 640 end
641 641
642 642 def test_index_sort_by_spent_hours
643 643 get :index, :sort => 'spent_hours:desc'
644 644 assert_response :success
645 645 hours = assigns(:issues).collect(&:spent_hours)
646 646 assert_equal hours.sort.reverse, hours
647 647 end
648 648
649 649 def test_index_sort_by_user_custom_field
650 650 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
651 651 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
652 652 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
653 653 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
654 654 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
655 655
656 656 get :index, :project_id => 1, :set_filter => 1, :sort => "cf_#{cf.id},id"
657 657 assert_response :success
658 658
659 659 assert_equal [2, 3, 1], assigns(:issues).select {|issue| issue.custom_field_value(cf).present?}.map(&:id)
660 660 end
661 661
662 662 def test_index_with_columns
663 663 columns = ['tracker', 'subject', 'assigned_to']
664 664 get :index, :set_filter => 1, :c => columns
665 665 assert_response :success
666 666
667 667 # query should use specified columns
668 668 query = assigns(:query)
669 669 assert_kind_of IssueQuery, query
670 670 assert_equal columns, query.column_names.map(&:to_s)
671 671
672 672 # columns should be stored in session
673 673 assert_kind_of Hash, session[:query]
674 674 assert_kind_of Array, session[:query][:column_names]
675 675 assert_equal columns, session[:query][:column_names].map(&:to_s)
676 676
677 677 # ensure only these columns are kept in the selected columns list
678 678 assert_select 'select#selected_columns option' do
679 679 assert_select 'option', 3
680 680 assert_select 'option[value=tracker]'
681 681 assert_select 'option[value=project]', 0
682 682 end
683 683 end
684 684
685 685 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
686 686 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
687 687 get :index, :set_filter => 1
688 688
689 689 # query should use specified columns
690 690 query = assigns(:query)
691 691 assert_kind_of IssueQuery, query
692 692 assert_equal [:project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
693 693 end
694 694
695 695 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
696 696 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
697 697 columns = ['tracker', 'subject', 'assigned_to']
698 698 get :index, :set_filter => 1, :c => columns
699 699
700 700 # query should use specified columns
701 701 query = assigns(:query)
702 702 assert_kind_of IssueQuery, query
703 703 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
704 704 end
705 705
706 706 def test_index_with_custom_field_column
707 707 columns = %w(tracker subject cf_2)
708 708 get :index, :set_filter => 1, :c => columns
709 709 assert_response :success
710 710
711 711 # query should use specified columns
712 712 query = assigns(:query)
713 713 assert_kind_of IssueQuery, query
714 714 assert_equal columns, query.column_names.map(&:to_s)
715 715
716 716 assert_select 'table.issues td.cf_2.string'
717 717 end
718 718
719 719 def test_index_with_multi_custom_field_column
720 720 field = CustomField.find(1)
721 721 field.update_attribute :multiple, true
722 722 issue = Issue.find(1)
723 723 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
724 724 issue.save!
725 725
726 726 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
727 727 assert_response :success
728 728
729 729 assert_select 'table.issues td.cf_1', :text => 'MySQL, Oracle'
730 730 end
731 731
732 732 def test_index_with_multi_user_custom_field_column
733 733 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
734 734 :tracker_ids => [1], :is_for_all => true)
735 735 issue = Issue.find(1)
736 736 issue.custom_field_values = {field.id => ['2', '3']}
737 737 issue.save!
738 738
739 739 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
740 740 assert_response :success
741 741
742 742 assert_select "table.issues td.cf_#{field.id}" do
743 743 assert_select 'a', 2
744 744 assert_select 'a[href=?]', '/users/2', :text => 'John Smith'
745 745 assert_select 'a[href=?]', '/users/3', :text => 'Dave Lopper'
746 746 end
747 747 end
748 748
749 749 def test_index_with_date_column
750 750 with_settings :date_format => '%d/%m/%Y' do
751 751 Issue.find(1).update_attribute :start_date, '1987-08-24'
752 752
753 753 get :index, :set_filter => 1, :c => %w(start_date)
754 754
755 755 assert_select "table.issues td.start_date", :text => '24/08/1987'
756 756 end
757 757 end
758 758
759 759 def test_index_with_done_ratio_column
760 760 Issue.find(1).update_attribute :done_ratio, 40
761 761
762 762 get :index, :set_filter => 1, :c => %w(done_ratio)
763 763
764 764 assert_select 'table.issues td.done_ratio' do
765 765 assert_select 'table.progress' do
766 766 assert_select 'td.closed[style=?]', 'width: 40%;'
767 767 end
768 768 end
769 769 end
770 770
771 771 def test_index_with_spent_hours_column
772 772 get :index, :set_filter => 1, :c => %w(subject spent_hours)
773 773
774 774 assert_select 'table.issues tr#issue-3 td.spent_hours', :text => '1.00'
775 775 end
776 776
777 777 def test_index_should_not_show_spent_hours_column_without_permission
778 778 Role.anonymous.remove_permission! :view_time_entries
779 779 get :index, :set_filter => 1, :c => %w(subject spent_hours)
780 780
781 781 assert_select 'td.spent_hours', 0
782 782 end
783 783
784 784 def test_index_with_fixed_version_column
785 785 get :index, :set_filter => 1, :c => %w(fixed_version)
786 786
787 787 assert_select 'table.issues td.fixed_version' do
788 788 assert_select 'a[href=?]', '/versions/2', :text => '1.0'
789 789 end
790 790 end
791 791
792 792 def test_index_with_relations_column
793 793 IssueRelation.delete_all
794 794 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(7))
795 795 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(8), :issue_to => Issue.find(1))
796 796 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(1), :issue_to => Issue.find(11))
797 797 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(12), :issue_to => Issue.find(2))
798 798
799 799 get :index, :set_filter => 1, :c => %w(subject relations)
800 800 assert_response :success
801 801 assert_select "tr#issue-1 td.relations" do
802 802 assert_select "span", 3
803 803 assert_select "span", :text => "Related to #7"
804 804 assert_select "span", :text => "Related to #8"
805 805 assert_select "span", :text => "Blocks #11"
806 806 end
807 807 assert_select "tr#issue-2 td.relations" do
808 808 assert_select "span", 1
809 809 assert_select "span", :text => "Blocked by #12"
810 810 end
811 811 assert_select "tr#issue-3 td.relations" do
812 812 assert_select "span", 0
813 813 end
814 814
815 815 get :index, :set_filter => 1, :c => %w(relations), :format => 'csv'
816 816 assert_response :success
817 817 assert_equal 'text/csv; header=present', response.content_type
818 818 lines = response.body.chomp.split("\n")
819 819 assert_include '1,"Related to #7, Related to #8, Blocks #11"', lines
820 820 assert_include '2,Blocked by #12', lines
821 821 assert_include '3,""', lines
822 822
823 823 get :index, :set_filter => 1, :c => %w(subject relations), :format => 'pdf'
824 824 assert_response :success
825 825 assert_equal 'application/pdf', response.content_type
826 826 end
827 827
828 828 def test_index_with_description_column
829 829 get :index, :set_filter => 1, :c => %w(subject description)
830 830
831 831 assert_select 'table.issues thead th', 3 # columns: chekbox + id + subject
832 832 assert_select 'td.description[colspan=3]', :text => 'Unable to print recipes'
833 833
834 834 get :index, :set_filter => 1, :c => %w(subject description), :format => 'pdf'
835 835 assert_response :success
836 836 assert_equal 'application/pdf', response.content_type
837 837 end
838 838
839 839 def test_index_send_html_if_query_is_invalid
840 840 get :index, :f => ['start_date'], :op => {:start_date => '='}
841 841 assert_equal 'text/html', @response.content_type
842 842 assert_template 'index'
843 843 end
844 844
845 845 def test_index_send_nothing_if_query_is_invalid
846 846 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
847 847 assert_equal 'text/csv', @response.content_type
848 848 assert @response.body.blank?
849 849 end
850 850
851 851 def test_show_by_anonymous
852 852 get :show, :id => 1
853 853 assert_response :success
854 854 assert_template 'show'
855 855 assert_equal Issue.find(1), assigns(:issue)
856 856
857 857 assert_select 'div.issue div.description', :text => /Unable to print recipes/
858 858
859 859 # anonymous role is allowed to add a note
860 860 assert_select 'form#issue-form' do
861 861 assert_select 'fieldset' do
862 862 assert_select 'legend', :text => 'Notes'
863 863 assert_select 'textarea[name=?]', 'issue[notes]'
864 864 end
865 865 end
866 866
867 867 assert_select 'title', :text => "Bug #1: Can&#x27;t print recipes - eCookbook - Redmine"
868 868 end
869 869
870 870 def test_show_by_manager
871 871 @request.session[:user_id] = 2
872 872 get :show, :id => 1
873 873 assert_response :success
874 874
875 875 assert_select 'a', :text => /Quote/
876 876
877 877 assert_select 'form#issue-form' do
878 878 assert_select 'fieldset' do
879 879 assert_select 'legend', :text => 'Change properties'
880 880 assert_select 'input[name=?]', 'issue[subject]'
881 881 end
882 882 assert_select 'fieldset' do
883 883 assert_select 'legend', :text => 'Log time'
884 884 assert_select 'input[name=?]', 'time_entry[hours]'
885 885 end
886 886 assert_select 'fieldset' do
887 887 assert_select 'legend', :text => 'Notes'
888 888 assert_select 'textarea[name=?]', 'issue[notes]'
889 889 end
890 890 end
891 891 end
892 892
893 893 def test_show_should_display_update_form
894 894 @request.session[:user_id] = 2
895 895 get :show, :id => 1
896 896 assert_response :success
897 897
898 898 assert_select 'form#issue-form' do
899 899 assert_select 'input[name=?]', 'issue[is_private]'
900 900 assert_select 'select[name=?]', 'issue[project_id]'
901 901 assert_select 'select[name=?]', 'issue[tracker_id]'
902 902 assert_select 'input[name=?]', 'issue[subject]'
903 903 assert_select 'textarea[name=?]', 'issue[description]'
904 904 assert_select 'select[name=?]', 'issue[status_id]'
905 905 assert_select 'select[name=?]', 'issue[priority_id]'
906 906 assert_select 'select[name=?]', 'issue[assigned_to_id]'
907 907 assert_select 'select[name=?]', 'issue[category_id]'
908 908 assert_select 'select[name=?]', 'issue[fixed_version_id]'
909 909 assert_select 'input[name=?]', 'issue[parent_issue_id]'
910 910 assert_select 'input[name=?]', 'issue[start_date]'
911 911 assert_select 'input[name=?]', 'issue[due_date]'
912 912 assert_select 'select[name=?]', 'issue[done_ratio]'
913 913 assert_select 'input[name=?]', 'issue[custom_field_values][2]'
914 914 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
915 915 assert_select 'textarea[name=?]', 'issue[notes]'
916 916 end
917 917 end
918 918
919 919 def test_show_should_display_update_form_with_minimal_permissions
920 920 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
921 921 WorkflowTransition.delete_all :role_id => 1
922 922
923 923 @request.session[:user_id] = 2
924 924 get :show, :id => 1
925 925 assert_response :success
926 926
927 927 assert_select 'form#issue-form' do
928 928 assert_select 'input[name=?]', 'issue[is_private]', 0
929 929 assert_select 'select[name=?]', 'issue[project_id]', 0
930 930 assert_select 'select[name=?]', 'issue[tracker_id]', 0
931 931 assert_select 'input[name=?]', 'issue[subject]', 0
932 932 assert_select 'textarea[name=?]', 'issue[description]', 0
933 933 assert_select 'select[name=?]', 'issue[status_id]', 0
934 934 assert_select 'select[name=?]', 'issue[priority_id]', 0
935 935 assert_select 'select[name=?]', 'issue[assigned_to_id]', 0
936 936 assert_select 'select[name=?]', 'issue[category_id]', 0
937 937 assert_select 'select[name=?]', 'issue[fixed_version_id]', 0
938 938 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
939 939 assert_select 'input[name=?]', 'issue[start_date]', 0
940 940 assert_select 'input[name=?]', 'issue[due_date]', 0
941 941 assert_select 'select[name=?]', 'issue[done_ratio]', 0
942 942 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
943 943 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
944 944 assert_select 'textarea[name=?]', 'issue[notes]'
945 945 end
946 946 end
947 947
948 948 def test_show_should_display_update_form_with_workflow_permissions
949 949 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
950 950
951 951 @request.session[:user_id] = 2
952 952 get :show, :id => 1
953 953 assert_response :success
954 954
955 955 assert_select 'form#issue-form' do
956 956 assert_select 'input[name=?]', 'issue[is_private]', 0
957 957 assert_select 'select[name=?]', 'issue[project_id]', 0
958 958 assert_select 'select[name=?]', 'issue[tracker_id]', 0
959 959 assert_select 'input[name=?]', 'issue[subject]', 0
960 960 assert_select 'textarea[name=?]', 'issue[description]', 0
961 961 assert_select 'select[name=?]', 'issue[status_id]'
962 962 assert_select 'select[name=?]', 'issue[priority_id]', 0
963 963 assert_select 'select[name=?]', 'issue[assigned_to_id]'
964 964 assert_select 'select[name=?]', 'issue[category_id]', 0
965 965 assert_select 'select[name=?]', 'issue[fixed_version_id]'
966 966 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
967 967 assert_select 'input[name=?]', 'issue[start_date]', 0
968 968 assert_select 'input[name=?]', 'issue[due_date]', 0
969 969 assert_select 'select[name=?]', 'issue[done_ratio]'
970 970 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
971 971 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
972 972 assert_select 'textarea[name=?]', 'issue[notes]'
973 973 end
974 974 end
975 975
976 976 def test_show_should_not_display_update_form_without_permissions
977 977 Role.find(1).update_attribute :permissions, [:view_issues]
978 978
979 979 @request.session[:user_id] = 2
980 980 get :show, :id => 1
981 981 assert_response :success
982 982
983 983 assert_select 'form#issue-form', 0
984 984 end
985 985
986 986 def test_update_form_should_not_display_inactive_enumerations
987 987 assert !IssuePriority.find(15).active?
988 988
989 989 @request.session[:user_id] = 2
990 990 get :show, :id => 1
991 991 assert_response :success
992 992
993 993 assert_select 'form#issue-form' do
994 994 assert_select 'select[name=?]', 'issue[priority_id]' do
995 995 assert_select 'option[value=4]'
996 996 assert_select 'option[value=15]', 0
997 997 end
998 998 end
999 999 end
1000 1000
1001 1001 def test_update_form_should_allow_attachment_upload
1002 1002 @request.session[:user_id] = 2
1003 1003 get :show, :id => 1
1004 1004
1005 1005 assert_select 'form#issue-form[method=post][enctype=multipart/form-data]' do
1006 1006 assert_select 'input[type=file][name=?]', 'attachments[dummy][file]'
1007 1007 end
1008 1008 end
1009 1009
1010 1010 def test_show_should_deny_anonymous_access_without_permission
1011 1011 Role.anonymous.remove_permission!(:view_issues)
1012 1012 get :show, :id => 1
1013 1013 assert_response :redirect
1014 1014 end
1015 1015
1016 1016 def test_show_should_deny_anonymous_access_to_private_issue
1017 1017 Issue.update_all(["is_private = ?", true], "id = 1")
1018 1018 get :show, :id => 1
1019 1019 assert_response :redirect
1020 1020 end
1021 1021
1022 1022 def test_show_should_deny_non_member_access_without_permission
1023 1023 Role.non_member.remove_permission!(:view_issues)
1024 1024 @request.session[:user_id] = 9
1025 1025 get :show, :id => 1
1026 1026 assert_response 403
1027 1027 end
1028 1028
1029 1029 def test_show_should_deny_non_member_access_to_private_issue
1030 1030 Issue.update_all(["is_private = ?", true], "id = 1")
1031 1031 @request.session[:user_id] = 9
1032 1032 get :show, :id => 1
1033 1033 assert_response 403
1034 1034 end
1035 1035
1036 1036 def test_show_should_deny_member_access_without_permission
1037 1037 Role.find(1).remove_permission!(:view_issues)
1038 1038 @request.session[:user_id] = 2
1039 1039 get :show, :id => 1
1040 1040 assert_response 403
1041 1041 end
1042 1042
1043 1043 def test_show_should_deny_member_access_to_private_issue_without_permission
1044 1044 Issue.update_all(["is_private = ?", true], "id = 1")
1045 1045 @request.session[:user_id] = 3
1046 1046 get :show, :id => 1
1047 1047 assert_response 403
1048 1048 end
1049 1049
1050 1050 def test_show_should_allow_author_access_to_private_issue
1051 1051 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
1052 1052 @request.session[:user_id] = 3
1053 1053 get :show, :id => 1
1054 1054 assert_response :success
1055 1055 end
1056 1056
1057 1057 def test_show_should_allow_assignee_access_to_private_issue
1058 1058 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
1059 1059 @request.session[:user_id] = 3
1060 1060 get :show, :id => 1
1061 1061 assert_response :success
1062 1062 end
1063 1063
1064 1064 def test_show_should_allow_member_access_to_private_issue_with_permission
1065 1065 Issue.update_all(["is_private = ?", true], "id = 1")
1066 1066 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
1067 1067 @request.session[:user_id] = 3
1068 1068 get :show, :id => 1
1069 1069 assert_response :success
1070 1070 end
1071 1071
1072 1072 def test_show_should_not_disclose_relations_to_invisible_issues
1073 1073 Setting.cross_project_issue_relations = '1'
1074 1074 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
1075 1075 # Relation to a private project issue
1076 1076 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
1077 1077
1078 1078 get :show, :id => 1
1079 1079 assert_response :success
1080 1080
1081 1081 assert_select 'div#relations' do
1082 1082 assert_select 'a', :text => /#2$/
1083 1083 assert_select 'a', :text => /#4$/, :count => 0
1084 1084 end
1085 1085 end
1086 1086
1087 1087 def test_show_should_list_subtasks
1088 1088 Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1089 1089
1090 1090 get :show, :id => 1
1091 1091 assert_response :success
1092 1092
1093 1093 assert_select 'div#issue_tree' do
1094 1094 assert_select 'td.subject', :text => /Child Issue/
1095 1095 end
1096 1096 end
1097 1097
1098 1098 def test_show_should_list_parents
1099 1099 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1100 1100
1101 1101 get :show, :id => issue.id
1102 1102 assert_response :success
1103 1103
1104 1104 assert_select 'div.subject' do
1105 1105 assert_select 'h3', 'Child Issue'
1106 1106 assert_select 'a[href=/issues/1]'
1107 1107 end
1108 1108 end
1109 1109
1110 1110 def test_show_should_not_display_prev_next_links_without_query_in_session
1111 1111 get :show, :id => 1
1112 1112 assert_response :success
1113 1113 assert_nil assigns(:prev_issue_id)
1114 1114 assert_nil assigns(:next_issue_id)
1115 1115
1116 1116 assert_select 'div.next-prev-links', 0
1117 1117 end
1118 1118
1119 1119 def test_show_should_display_prev_next_links_with_query_in_session
1120 1120 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1121 1121 @request.session['issues_index_sort'] = 'id'
1122 1122
1123 1123 with_settings :display_subprojects_issues => '0' do
1124 1124 get :show, :id => 3
1125 1125 end
1126 1126
1127 1127 assert_response :success
1128 1128 # Previous and next issues for all projects
1129 1129 assert_equal 2, assigns(:prev_issue_id)
1130 1130 assert_equal 5, assigns(:next_issue_id)
1131 1131
1132 1132 count = Issue.open.visible.count
1133 1133
1134 1134 assert_select 'div.next-prev-links' do
1135 1135 assert_select 'a[href=/issues/2]', :text => /Previous/
1136 1136 assert_select 'a[href=/issues/5]', :text => /Next/
1137 1137 assert_select 'span.position', :text => "3 of #{count}"
1138 1138 end
1139 1139 end
1140 1140
1141 1141 def test_show_should_display_prev_next_links_with_saved_query_in_session
1142 1142 query = IssueQuery.create!(:name => 'test', :is_public => true, :user_id => 1,
1143 1143 :filters => {'status_id' => {:values => ['5'], :operator => '='}},
1144 1144 :sort_criteria => [['id', 'asc']])
1145 1145 @request.session[:query] = {:id => query.id, :project_id => nil}
1146 1146
1147 1147 get :show, :id => 11
1148 1148
1149 1149 assert_response :success
1150 1150 assert_equal query, assigns(:query)
1151 1151 # Previous and next issues for all projects
1152 1152 assert_equal 8, assigns(:prev_issue_id)
1153 1153 assert_equal 12, assigns(:next_issue_id)
1154 1154
1155 1155 assert_select 'div.next-prev-links' do
1156 1156 assert_select 'a[href=/issues/8]', :text => /Previous/
1157 1157 assert_select 'a[href=/issues/12]', :text => /Next/
1158 1158 end
1159 1159 end
1160 1160
1161 1161 def test_show_should_display_prev_next_links_with_query_and_sort_on_association
1162 1162 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1163 1163
1164 1164 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
1165 1165 @request.session['issues_index_sort'] = assoc_sort
1166 1166
1167 1167 get :show, :id => 3
1168 1168 assert_response :success, "Wrong response status for #{assoc_sort} sort"
1169 1169
1170 1170 assert_select 'div.next-prev-links' do
1171 1171 assert_select 'a', :text => /(Previous|Next)/
1172 1172 end
1173 1173 end
1174 1174 end
1175 1175
1176 1176 def test_show_should_display_prev_next_links_with_project_query_in_session
1177 1177 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1178 1178 @request.session['issues_index_sort'] = 'id'
1179 1179
1180 1180 with_settings :display_subprojects_issues => '0' do
1181 1181 get :show, :id => 3
1182 1182 end
1183 1183
1184 1184 assert_response :success
1185 1185 # Previous and next issues inside project
1186 1186 assert_equal 2, assigns(:prev_issue_id)
1187 1187 assert_equal 7, assigns(:next_issue_id)
1188 1188
1189 1189 assert_select 'div.next-prev-links' do
1190 1190 assert_select 'a[href=/issues/2]', :text => /Previous/
1191 1191 assert_select 'a[href=/issues/7]', :text => /Next/
1192 1192 end
1193 1193 end
1194 1194
1195 1195 def test_show_should_not_display_prev_link_for_first_issue
1196 1196 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1197 1197 @request.session['issues_index_sort'] = 'id'
1198 1198
1199 1199 with_settings :display_subprojects_issues => '0' do
1200 1200 get :show, :id => 1
1201 1201 end
1202 1202
1203 1203 assert_response :success
1204 1204 assert_nil assigns(:prev_issue_id)
1205 1205 assert_equal 2, assigns(:next_issue_id)
1206 1206
1207 1207 assert_select 'div.next-prev-links' do
1208 1208 assert_select 'a', :text => /Previous/, :count => 0
1209 1209 assert_select 'a[href=/issues/2]', :text => /Next/
1210 1210 end
1211 1211 end
1212 1212
1213 1213 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
1214 1214 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
1215 1215 @request.session['issues_index_sort'] = 'id'
1216 1216
1217 1217 get :show, :id => 1
1218 1218
1219 1219 assert_response :success
1220 1220 assert_nil assigns(:prev_issue_id)
1221 1221 assert_nil assigns(:next_issue_id)
1222 1222
1223 1223 assert_select 'a', :text => /Previous/, :count => 0
1224 1224 assert_select 'a', :text => /Next/, :count => 0
1225 1225 end
1226 1226
1227 1227 def test_show_show_should_display_prev_next_links_with_query_sort_by_user_custom_field
1228 1228 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
1229 1229 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
1230 1230 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
1231 1231 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
1232 1232 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
1233 1233
1234 1234 query = IssueQuery.create!(:name => 'test', :is_public => true, :user_id => 1, :filters => {},
1235 1235 :sort_criteria => [["cf_#{cf.id}", 'asc'], ['id', 'asc']])
1236 1236 @request.session[:query] = {:id => query.id, :project_id => nil}
1237 1237
1238 1238 get :show, :id => 3
1239 1239 assert_response :success
1240 1240
1241 1241 assert_equal 2, assigns(:prev_issue_id)
1242 1242 assert_equal 1, assigns(:next_issue_id)
1243 1243
1244 1244 assert_select 'div.next-prev-links' do
1245 1245 assert_select 'a[href=/issues/2]', :text => /Previous/
1246 1246 assert_select 'a[href=/issues/1]', :text => /Next/
1247 1247 end
1248 1248 end
1249 1249
1250 1250 def test_show_should_display_link_to_the_assignee
1251 1251 get :show, :id => 2
1252 1252 assert_response :success
1253 1253 assert_select '.assigned-to' do
1254 1254 assert_select 'a[href=/users/3]'
1255 1255 end
1256 1256 end
1257 1257
1258 1258 def test_show_should_display_visible_changesets_from_other_projects
1259 1259 project = Project.find(2)
1260 1260 issue = project.issues.first
1261 1261 issue.changeset_ids = [102]
1262 1262 issue.save!
1263 1263 # changesets from other projects should be displayed even if repository
1264 1264 # is disabled on issue's project
1265 1265 project.disable_module! :repository
1266 1266
1267 1267 @request.session[:user_id] = 2
1268 1268 get :show, :id => issue.id
1269 1269
1270 1270 assert_select 'a[href=?]', '/projects/ecookbook/repository/revisions/3'
1271 1271 end
1272 1272
1273 1273 def test_show_should_display_watchers
1274 1274 @request.session[:user_id] = 2
1275 1275 Issue.find(1).add_watcher User.find(2)
1276 1276
1277 1277 get :show, :id => 1
1278 1278 assert_select 'div#watchers ul' do
1279 1279 assert_select 'li' do
1280 1280 assert_select 'a[href=/users/2]'
1281 1281 assert_select 'a img[alt=Delete]'
1282 1282 end
1283 1283 end
1284 1284 end
1285 1285
1286 1286 def test_show_should_display_watchers_with_gravatars
1287 1287 @request.session[:user_id] = 2
1288 1288 Issue.find(1).add_watcher User.find(2)
1289 1289
1290 1290 with_settings :gravatar_enabled => '1' do
1291 1291 get :show, :id => 1
1292 1292 end
1293 1293
1294 1294 assert_select 'div#watchers ul' do
1295 1295 assert_select 'li' do
1296 1296 assert_select 'img.gravatar'
1297 1297 assert_select 'a[href=/users/2]'
1298 1298 assert_select 'a img[alt=Delete]'
1299 1299 end
1300 1300 end
1301 1301 end
1302 1302
1303 1303 def test_show_with_thumbnails_enabled_should_display_thumbnails
1304 1304 @request.session[:user_id] = 2
1305 1305
1306 1306 with_settings :thumbnails_enabled => '1' do
1307 1307 get :show, :id => 14
1308 1308 assert_response :success
1309 1309 end
1310 1310
1311 1311 assert_select 'div.thumbnails' do
1312 1312 assert_select 'a[href=/attachments/16/testfile.png]' do
1313 1313 assert_select 'img[src=/attachments/thumbnail/16]'
1314 1314 end
1315 1315 end
1316 1316 end
1317 1317
1318 1318 def test_show_with_thumbnails_disabled_should_not_display_thumbnails
1319 1319 @request.session[:user_id] = 2
1320 1320
1321 1321 with_settings :thumbnails_enabled => '0' do
1322 1322 get :show, :id => 14
1323 1323 assert_response :success
1324 1324 end
1325 1325
1326 1326 assert_select 'div.thumbnails', 0
1327 1327 end
1328 1328
1329 1329 def test_show_with_multi_custom_field
1330 1330 field = CustomField.find(1)
1331 1331 field.update_attribute :multiple, true
1332 1332 issue = Issue.find(1)
1333 1333 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
1334 1334 issue.save!
1335 1335
1336 1336 get :show, :id => 1
1337 1337 assert_response :success
1338 1338
1339 1339 assert_select 'td', :text => 'MySQL, Oracle'
1340 1340 end
1341 1341
1342 1342 def test_show_with_multi_user_custom_field
1343 1343 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1344 1344 :tracker_ids => [1], :is_for_all => true)
1345 1345 issue = Issue.find(1)
1346 1346 issue.custom_field_values = {field.id => ['2', '3']}
1347 1347 issue.save!
1348 1348
1349 1349 get :show, :id => 1
1350 1350 assert_response :success
1351 1351
1352 1352 # TODO: should display links
1353 1353 assert_select 'td', :text => 'Dave Lopper, John Smith'
1354 1354 end
1355 1355
1356 1356 def test_show_should_display_private_notes_with_permission_only
1357 1357 journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true, :user_id => 1)
1358 1358 @request.session[:user_id] = 2
1359 1359
1360 1360 get :show, :id => 2
1361 1361 assert_response :success
1362 1362 assert_include journal, assigns(:journals)
1363 1363
1364 1364 Role.find(1).remove_permission! :view_private_notes
1365 1365 get :show, :id => 2
1366 1366 assert_response :success
1367 1367 assert_not_include journal, assigns(:journals)
1368 1368 end
1369 1369
1370 1370 def test_show_atom
1371 1371 get :show, :id => 2, :format => 'atom'
1372 1372 assert_response :success
1373 1373 assert_template 'journals/index'
1374 1374 # Inline image
1375 1375 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1376 1376 end
1377 1377
1378 1378 def test_show_export_to_pdf
1379 1379 get :show, :id => 3, :format => 'pdf'
1380 1380 assert_response :success
1381 1381 assert_equal 'application/pdf', @response.content_type
1382 1382 assert @response.body.starts_with?('%PDF')
1383 1383 assert_not_nil assigns(:issue)
1384 1384 end
1385 1385
1386 1386 def test_show_export_to_pdf_with_ancestors
1387 1387 issue = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1388 1388
1389 1389 get :show, :id => issue.id, :format => 'pdf'
1390 1390 assert_response :success
1391 1391 assert_equal 'application/pdf', @response.content_type
1392 1392 assert @response.body.starts_with?('%PDF')
1393 1393 end
1394 1394
1395 1395 def test_show_export_to_pdf_with_descendants
1396 1396 c1 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1397 1397 c2 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1398 1398 c3 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => c1.id)
1399 1399
1400 1400 get :show, :id => 1, :format => 'pdf'
1401 1401 assert_response :success
1402 1402 assert_equal 'application/pdf', @response.content_type
1403 1403 assert @response.body.starts_with?('%PDF')
1404 1404 end
1405 1405
1406 1406 def test_show_export_to_pdf_with_journals
1407 1407 get :show, :id => 1, :format => 'pdf'
1408 1408 assert_response :success
1409 1409 assert_equal 'application/pdf', @response.content_type
1410 1410 assert @response.body.starts_with?('%PDF')
1411 1411 end
1412 1412
1413 1413 def test_show_export_to_pdf_with_changesets
1414 1414 Issue.find(3).changesets = Changeset.find_all_by_id(100, 101, 102)
1415 1415
1416 1416 get :show, :id => 3, :format => 'pdf'
1417 1417 assert_response :success
1418 1418 assert_equal 'application/pdf', @response.content_type
1419 1419 assert @response.body.starts_with?('%PDF')
1420 1420 end
1421 1421
1422 1422 def test_show_invalid_should_respond_with_404
1423 1423 get :show, :id => 999
1424 1424 assert_response 404
1425 1425 end
1426 1426
1427 1427 def test_get_new
1428 1428 @request.session[:user_id] = 2
1429 1429 get :new, :project_id => 1, :tracker_id => 1
1430 1430 assert_response :success
1431 1431 assert_template 'new'
1432 1432
1433 1433 assert_select 'form#issue-form' do
1434 1434 assert_select 'input[name=?]', 'issue[is_private]'
1435 1435 assert_select 'select[name=?]', 'issue[project_id]', 0
1436 1436 assert_select 'select[name=?]', 'issue[tracker_id]'
1437 1437 assert_select 'input[name=?]', 'issue[subject]'
1438 1438 assert_select 'textarea[name=?]', 'issue[description]'
1439 1439 assert_select 'select[name=?]', 'issue[status_id]'
1440 1440 assert_select 'select[name=?]', 'issue[priority_id]'
1441 1441 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1442 1442 assert_select 'select[name=?]', 'issue[category_id]'
1443 1443 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1444 1444 assert_select 'input[name=?]', 'issue[parent_issue_id]'
1445 1445 assert_select 'input[name=?]', 'issue[start_date]'
1446 1446 assert_select 'input[name=?]', 'issue[due_date]'
1447 1447 assert_select 'select[name=?]', 'issue[done_ratio]'
1448 1448 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1449 1449 assert_select 'input[name=?]', 'issue[watcher_user_ids][]'
1450 1450 end
1451 1451
1452 1452 # Be sure we don't display inactive IssuePriorities
1453 1453 assert ! IssuePriority.find(15).active?
1454 1454 assert_select 'select[name=?]', 'issue[priority_id]' do
1455 1455 assert_select 'option[value=15]', 0
1456 1456 end
1457 1457 end
1458 1458
1459 1459 def test_get_new_with_minimal_permissions
1460 1460 Role.find(1).update_attribute :permissions, [:add_issues]
1461 1461 WorkflowTransition.delete_all :role_id => 1
1462 1462
1463 1463 @request.session[:user_id] = 2
1464 1464 get :new, :project_id => 1, :tracker_id => 1
1465 1465 assert_response :success
1466 1466 assert_template 'new'
1467 1467
1468 1468 assert_select 'form#issue-form' do
1469 1469 assert_select 'input[name=?]', 'issue[is_private]', 0
1470 1470 assert_select 'select[name=?]', 'issue[project_id]', 0
1471 1471 assert_select 'select[name=?]', 'issue[tracker_id]'
1472 1472 assert_select 'input[name=?]', 'issue[subject]'
1473 1473 assert_select 'textarea[name=?]', 'issue[description]'
1474 1474 assert_select 'select[name=?]', 'issue[status_id]'
1475 1475 assert_select 'select[name=?]', 'issue[priority_id]'
1476 1476 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1477 1477 assert_select 'select[name=?]', 'issue[category_id]'
1478 1478 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1479 1479 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
1480 1480 assert_select 'input[name=?]', 'issue[start_date]'
1481 1481 assert_select 'input[name=?]', 'issue[due_date]'
1482 1482 assert_select 'select[name=?]', 'issue[done_ratio]'
1483 1483 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1484 1484 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
1485 1485 end
1486 1486 end
1487 1487
1488 1488 def test_get_new_with_list_custom_field
1489 1489 @request.session[:user_id] = 2
1490 1490 get :new, :project_id => 1, :tracker_id => 1
1491 1491 assert_response :success
1492 1492 assert_template 'new'
1493 1493
1494 1494 assert_select 'select.list_cf[name=?]', 'issue[custom_field_values][1]' do
1495 1495 assert_select 'option', 4
1496 1496 assert_select 'option[value=MySQL]', :text => 'MySQL'
1497 1497 end
1498 1498 end
1499 1499
1500 1500 def test_get_new_with_multi_custom_field
1501 1501 field = IssueCustomField.find(1)
1502 1502 field.update_attribute :multiple, true
1503 1503
1504 1504 @request.session[:user_id] = 2
1505 1505 get :new, :project_id => 1, :tracker_id => 1
1506 1506 assert_response :success
1507 1507 assert_template 'new'
1508 1508
1509 1509 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
1510 1510 assert_select 'option', 3
1511 1511 assert_select 'option[value=MySQL]', :text => 'MySQL'
1512 1512 end
1513 1513 assert_select 'input[name=?][type=hidden][value=?]', 'issue[custom_field_values][1][]', ''
1514 1514 end
1515 1515
1516 1516 def test_get_new_with_multi_user_custom_field
1517 1517 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1518 1518 :tracker_ids => [1], :is_for_all => true)
1519 1519
1520 1520 @request.session[:user_id] = 2
1521 1521 get :new, :project_id => 1, :tracker_id => 1
1522 1522 assert_response :success
1523 1523 assert_template 'new'
1524 1524
1525 1525 assert_select 'select[name=?][multiple=multiple]', "issue[custom_field_values][#{field.id}][]" do
1526 1526 assert_select 'option', Project.find(1).users.count
1527 1527 assert_select 'option[value=2]', :text => 'John Smith'
1528 1528 end
1529 1529 assert_select 'input[name=?][type=hidden][value=?]', "issue[custom_field_values][#{field.id}][]", ''
1530 1530 end
1531 1531
1532 1532 def test_get_new_with_date_custom_field
1533 1533 field = IssueCustomField.create!(:name => 'Date', :field_format => 'date', :tracker_ids => [1], :is_for_all => true)
1534 1534
1535 1535 @request.session[:user_id] = 2
1536 1536 get :new, :project_id => 1, :tracker_id => 1
1537 1537 assert_response :success
1538 1538
1539 1539 assert_select 'input[name=?]', "issue[custom_field_values][#{field.id}]"
1540 1540 end
1541 1541
1542 1542 def test_get_new_with_text_custom_field
1543 1543 field = IssueCustomField.create!(:name => 'Text', :field_format => 'text', :tracker_ids => [1], :is_for_all => true)
1544 1544
1545 1545 @request.session[:user_id] = 2
1546 1546 get :new, :project_id => 1, :tracker_id => 1
1547 1547 assert_response :success
1548 1548
1549 1549 assert_select 'textarea[name=?]', "issue[custom_field_values][#{field.id}]"
1550 1550 end
1551 1551
1552 1552 def test_get_new_without_default_start_date_is_creation_date
1553 1553 Setting.default_issue_start_date_to_creation_date = 0
1554 1554
1555 1555 @request.session[:user_id] = 2
1556 1556 get :new, :project_id => 1, :tracker_id => 1
1557 1557 assert_response :success
1558 1558 assert_template 'new'
1559 1559
1560 1560 assert_select 'input[name=?]', 'issue[start_date]'
1561 1561 assert_select 'input[name=?][value]', 'issue[start_date]', 0
1562 1562 end
1563 1563
1564 1564 def test_get_new_with_default_start_date_is_creation_date
1565 1565 Setting.default_issue_start_date_to_creation_date = 1
1566 1566
1567 1567 @request.session[:user_id] = 2
1568 1568 get :new, :project_id => 1, :tracker_id => 1
1569 1569 assert_response :success
1570 1570 assert_template 'new'
1571 1571
1572 1572 assert_select 'input[name=?][value=?]', 'issue[start_date]', Date.today.to_s
1573 1573 end
1574 1574
1575 1575 def test_get_new_form_should_allow_attachment_upload
1576 1576 @request.session[:user_id] = 2
1577 1577 get :new, :project_id => 1, :tracker_id => 1
1578 1578
1579 1579 assert_select 'form[id=issue-form][method=post][enctype=multipart/form-data]' do
1580 1580 assert_select 'input[name=?][type=file]', 'attachments[dummy][file]'
1581 1581 end
1582 1582 end
1583 1583
1584 1584 def test_get_new_should_prefill_the_form_from_params
1585 1585 @request.session[:user_id] = 2
1586 1586 get :new, :project_id => 1,
1587 1587 :issue => {:tracker_id => 3, :description => 'Prefilled', :custom_field_values => {'2' => 'Custom field value'}}
1588 1588
1589 1589 issue = assigns(:issue)
1590 1590 assert_equal 3, issue.tracker_id
1591 1591 assert_equal 'Prefilled', issue.description
1592 1592 assert_equal 'Custom field value', issue.custom_field_value(2)
1593 1593
1594 1594 assert_select 'select[name=?]', 'issue[tracker_id]' do
1595 1595 assert_select 'option[value=3][selected=selected]'
1596 1596 end
1597 1597 assert_select 'textarea[name=?]', 'issue[description]', :text => /Prefilled/
1598 1598 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Custom field value'
1599 1599 end
1600 1600
1601 1601 def test_get_new_should_mark_required_fields
1602 1602 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1603 1603 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1604 1604 WorkflowPermission.delete_all
1605 1605 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1606 1606 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1607 1607 @request.session[:user_id] = 2
1608 1608
1609 1609 get :new, :project_id => 1
1610 1610 assert_response :success
1611 1611 assert_template 'new'
1612 1612
1613 1613 assert_select 'label[for=issue_start_date]' do
1614 1614 assert_select 'span[class=required]', 0
1615 1615 end
1616 1616 assert_select 'label[for=issue_due_date]' do
1617 1617 assert_select 'span[class=required]'
1618 1618 end
1619 1619 assert_select 'label[for=?]', "issue_custom_field_values_#{cf1.id}" do
1620 1620 assert_select 'span[class=required]', 0
1621 1621 end
1622 1622 assert_select 'label[for=?]', "issue_custom_field_values_#{cf2.id}" do
1623 1623 assert_select 'span[class=required]'
1624 1624 end
1625 1625 end
1626 1626
1627 1627 def test_get_new_should_not_display_readonly_fields
1628 1628 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1629 1629 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1630 1630 WorkflowPermission.delete_all
1631 1631 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1632 1632 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1633 1633 @request.session[:user_id] = 2
1634 1634
1635 1635 get :new, :project_id => 1
1636 1636 assert_response :success
1637 1637 assert_template 'new'
1638 1638
1639 1639 assert_select 'input[name=?]', 'issue[start_date]'
1640 1640 assert_select 'input[name=?]', 'issue[due_date]', 0
1641 1641 assert_select 'input[name=?]', "issue[custom_field_values][#{cf1.id}]"
1642 1642 assert_select 'input[name=?]', "issue[custom_field_values][#{cf2.id}]", 0
1643 1643 end
1644 1644
1645 1645 def test_get_new_without_tracker_id
1646 1646 @request.session[:user_id] = 2
1647 1647 get :new, :project_id => 1
1648 1648 assert_response :success
1649 1649 assert_template 'new'
1650 1650
1651 1651 issue = assigns(:issue)
1652 1652 assert_not_nil issue
1653 1653 assert_equal Project.find(1).trackers.first, issue.tracker
1654 1654 end
1655 1655
1656 1656 def test_get_new_with_no_default_status_should_display_an_error
1657 1657 @request.session[:user_id] = 2
1658 1658 IssueStatus.delete_all
1659 1659
1660 1660 get :new, :project_id => 1
1661 1661 assert_response 500
1662 1662 assert_error_tag :content => /No default issue/
1663 1663 end
1664 1664
1665 1665 def test_get_new_with_no_tracker_should_display_an_error
1666 1666 @request.session[:user_id] = 2
1667 1667 Tracker.delete_all
1668 1668
1669 1669 get :new, :project_id => 1
1670 1670 assert_response 500
1671 1671 assert_error_tag :content => /No tracker/
1672 1672 end
1673 1673
1674 def test_update_new_form
1674 def test_update_form_for_new_issue
1675 1675 @request.session[:user_id] = 2
1676 xhr :post, :new, :project_id => 1,
1676 xhr :post, :update_form, :project_id => 1,
1677 1677 :issue => {:tracker_id => 2,
1678 1678 :subject => 'This is the test_new issue',
1679 1679 :description => 'This is the description',
1680 1680 :priority_id => 5}
1681 1681 assert_response :success
1682 1682 assert_template 'update_form'
1683 1683 assert_template 'form'
1684 1684 assert_equal 'text/javascript', response.content_type
1685 1685
1686 1686 issue = assigns(:issue)
1687 1687 assert_kind_of Issue, issue
1688 1688 assert_equal 1, issue.project_id
1689 1689 assert_equal 2, issue.tracker_id
1690 1690 assert_equal 'This is the test_new issue', issue.subject
1691 1691 end
1692 1692
1693 def test_update_new_form_should_propose_transitions_based_on_initial_status
1693 def test_update_form_for_new_issue_should_propose_transitions_based_on_initial_status
1694 1694 @request.session[:user_id] = 2
1695 1695 WorkflowTransition.delete_all
1696 1696 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
1697 1697 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5)
1698 1698 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4)
1699 1699
1700 xhr :post, :new, :project_id => 1,
1700 xhr :post, :update_form, :project_id => 1,
1701 1701 :issue => {:tracker_id => 1,
1702 1702 :status_id => 5,
1703 1703 :subject => 'This is an issue'}
1704 1704
1705 1705 assert_equal 5, assigns(:issue).status_id
1706 1706 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
1707 1707 end
1708 1708
1709 1709 def test_post_create
1710 1710 @request.session[:user_id] = 2
1711 1711 assert_difference 'Issue.count' do
1712 1712 post :create, :project_id => 1,
1713 1713 :issue => {:tracker_id => 3,
1714 1714 :status_id => 2,
1715 1715 :subject => 'This is the test_new issue',
1716 1716 :description => 'This is the description',
1717 1717 :priority_id => 5,
1718 1718 :start_date => '2010-11-07',
1719 1719 :estimated_hours => '',
1720 1720 :custom_field_values => {'2' => 'Value for field 2'}}
1721 1721 end
1722 1722 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1723 1723
1724 1724 issue = Issue.find_by_subject('This is the test_new issue')
1725 1725 assert_not_nil issue
1726 1726 assert_equal 2, issue.author_id
1727 1727 assert_equal 3, issue.tracker_id
1728 1728 assert_equal 2, issue.status_id
1729 1729 assert_equal Date.parse('2010-11-07'), issue.start_date
1730 1730 assert_nil issue.estimated_hours
1731 1731 v = issue.custom_values.where(:custom_field_id => 2).first
1732 1732 assert_not_nil v
1733 1733 assert_equal 'Value for field 2', v.value
1734 1734 end
1735 1735
1736 1736 def test_post_new_with_group_assignment
1737 1737 group = Group.find(11)
1738 1738 project = Project.find(1)
1739 1739 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
1740 1740
1741 1741 with_settings :issue_group_assignment => '1' do
1742 1742 @request.session[:user_id] = 2
1743 1743 assert_difference 'Issue.count' do
1744 1744 post :create, :project_id => project.id,
1745 1745 :issue => {:tracker_id => 3,
1746 1746 :status_id => 1,
1747 1747 :subject => 'This is the test_new_with_group_assignment issue',
1748 1748 :assigned_to_id => group.id}
1749 1749 end
1750 1750 end
1751 1751 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1752 1752
1753 1753 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1754 1754 assert_not_nil issue
1755 1755 assert_equal group, issue.assigned_to
1756 1756 end
1757 1757
1758 1758 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1759 1759 Setting.default_issue_start_date_to_creation_date = 0
1760 1760
1761 1761 @request.session[:user_id] = 2
1762 1762 assert_difference 'Issue.count' do
1763 1763 post :create, :project_id => 1,
1764 1764 :issue => {:tracker_id => 3,
1765 1765 :status_id => 2,
1766 1766 :subject => 'This is the test_new issue',
1767 1767 :description => 'This is the description',
1768 1768 :priority_id => 5,
1769 1769 :estimated_hours => '',
1770 1770 :custom_field_values => {'2' => 'Value for field 2'}}
1771 1771 end
1772 1772 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1773 1773
1774 1774 issue = Issue.find_by_subject('This is the test_new issue')
1775 1775 assert_not_nil issue
1776 1776 assert_nil issue.start_date
1777 1777 end
1778 1778
1779 1779 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1780 1780 Setting.default_issue_start_date_to_creation_date = 1
1781 1781
1782 1782 @request.session[:user_id] = 2
1783 1783 assert_difference 'Issue.count' do
1784 1784 post :create, :project_id => 1,
1785 1785 :issue => {:tracker_id => 3,
1786 1786 :status_id => 2,
1787 1787 :subject => 'This is the test_new issue',
1788 1788 :description => 'This is the description',
1789 1789 :priority_id => 5,
1790 1790 :estimated_hours => '',
1791 1791 :custom_field_values => {'2' => 'Value for field 2'}}
1792 1792 end
1793 1793 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1794 1794
1795 1795 issue = Issue.find_by_subject('This is the test_new issue')
1796 1796 assert_not_nil issue
1797 1797 assert_equal Date.today, issue.start_date
1798 1798 end
1799 1799
1800 1800 def test_post_create_and_continue
1801 1801 @request.session[:user_id] = 2
1802 1802 assert_difference 'Issue.count' do
1803 1803 post :create, :project_id => 1,
1804 1804 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1805 1805 :continue => ''
1806 1806 end
1807 1807
1808 1808 issue = Issue.first(:order => 'id DESC')
1809 1809 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1810 1810 assert_not_nil flash[:notice], "flash was not set"
1811 1811 assert_include %|<a href="/issues/#{issue.id}" title="This is first issue">##{issue.id}</a>|, flash[:notice], "issue link not found in the flash message"
1812 1812 end
1813 1813
1814 1814 def test_post_create_without_custom_fields_param
1815 1815 @request.session[:user_id] = 2
1816 1816 assert_difference 'Issue.count' do
1817 1817 post :create, :project_id => 1,
1818 1818 :issue => {:tracker_id => 1,
1819 1819 :subject => 'This is the test_new issue',
1820 1820 :description => 'This is the description',
1821 1821 :priority_id => 5}
1822 1822 end
1823 1823 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1824 1824 end
1825 1825
1826 1826 def test_post_create_with_multi_custom_field
1827 1827 field = IssueCustomField.find_by_name('Database')
1828 1828 field.update_attribute(:multiple, true)
1829 1829
1830 1830 @request.session[:user_id] = 2
1831 1831 assert_difference 'Issue.count' do
1832 1832 post :create, :project_id => 1,
1833 1833 :issue => {:tracker_id => 1,
1834 1834 :subject => 'This is the test_new issue',
1835 1835 :description => 'This is the description',
1836 1836 :priority_id => 5,
1837 1837 :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
1838 1838 end
1839 1839 assert_response 302
1840 1840 issue = Issue.first(:order => 'id DESC')
1841 1841 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
1842 1842 end
1843 1843
1844 1844 def test_post_create_with_empty_multi_custom_field
1845 1845 field = IssueCustomField.find_by_name('Database')
1846 1846 field.update_attribute(:multiple, true)
1847 1847
1848 1848 @request.session[:user_id] = 2
1849 1849 assert_difference 'Issue.count' do
1850 1850 post :create, :project_id => 1,
1851 1851 :issue => {:tracker_id => 1,
1852 1852 :subject => 'This is the test_new issue',
1853 1853 :description => 'This is the description',
1854 1854 :priority_id => 5,
1855 1855 :custom_field_values => {'1' => ['']}}
1856 1856 end
1857 1857 assert_response 302
1858 1858 issue = Issue.first(:order => 'id DESC')
1859 1859 assert_equal [''], issue.custom_field_value(1).sort
1860 1860 end
1861 1861
1862 1862 def test_post_create_with_multi_user_custom_field
1863 1863 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1864 1864 :tracker_ids => [1], :is_for_all => true)
1865 1865
1866 1866 @request.session[:user_id] = 2
1867 1867 assert_difference 'Issue.count' do
1868 1868 post :create, :project_id => 1,
1869 1869 :issue => {:tracker_id => 1,
1870 1870 :subject => 'This is the test_new issue',
1871 1871 :description => 'This is the description',
1872 1872 :priority_id => 5,
1873 1873 :custom_field_values => {field.id.to_s => ['', '2', '3']}}
1874 1874 end
1875 1875 assert_response 302
1876 1876 issue = Issue.first(:order => 'id DESC')
1877 1877 assert_equal ['2', '3'], issue.custom_field_value(field).sort
1878 1878 end
1879 1879
1880 1880 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1881 1881 field = IssueCustomField.find_by_name('Database')
1882 1882 field.update_attribute(:is_required, true)
1883 1883
1884 1884 @request.session[:user_id] = 2
1885 1885 assert_no_difference 'Issue.count' do
1886 1886 post :create, :project_id => 1,
1887 1887 :issue => {:tracker_id => 1,
1888 1888 :subject => 'This is the test_new issue',
1889 1889 :description => 'This is the description',
1890 1890 :priority_id => 5}
1891 1891 end
1892 1892 assert_response :success
1893 1893 assert_template 'new'
1894 1894 issue = assigns(:issue)
1895 1895 assert_not_nil issue
1896 1896 assert_error_tag :content => /Database can&#x27;t be blank/
1897 1897 end
1898 1898
1899 1899 def test_create_should_validate_required_fields
1900 1900 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1901 1901 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1902 1902 WorkflowPermission.delete_all
1903 1903 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1904 1904 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1905 1905 @request.session[:user_id] = 2
1906 1906
1907 1907 assert_no_difference 'Issue.count' do
1908 1908 post :create, :project_id => 1, :issue => {
1909 1909 :tracker_id => 2,
1910 1910 :status_id => 1,
1911 1911 :subject => 'Test',
1912 1912 :start_date => '',
1913 1913 :due_date => '',
1914 1914 :custom_field_values => {cf1.id.to_s => '', cf2.id.to_s => ''}
1915 1915 }
1916 1916 assert_response :success
1917 1917 assert_template 'new'
1918 1918 end
1919 1919
1920 1920 assert_error_tag :content => /Due date can&#x27;t be blank/i
1921 1921 assert_error_tag :content => /Bar can&#x27;t be blank/i
1922 1922 end
1923 1923
1924 1924 def test_create_should_ignore_readonly_fields
1925 1925 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1926 1926 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1927 1927 WorkflowPermission.delete_all
1928 1928 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1929 1929 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1930 1930 @request.session[:user_id] = 2
1931 1931
1932 1932 assert_difference 'Issue.count' do
1933 1933 post :create, :project_id => 1, :issue => {
1934 1934 :tracker_id => 2,
1935 1935 :status_id => 1,
1936 1936 :subject => 'Test',
1937 1937 :start_date => '2012-07-14',
1938 1938 :due_date => '2012-07-16',
1939 1939 :custom_field_values => {cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'}
1940 1940 }
1941 1941 assert_response 302
1942 1942 end
1943 1943
1944 1944 issue = Issue.first(:order => 'id DESC')
1945 1945 assert_equal Date.parse('2012-07-14'), issue.start_date
1946 1946 assert_nil issue.due_date
1947 1947 assert_equal 'value1', issue.custom_field_value(cf1)
1948 1948 assert_nil issue.custom_field_value(cf2)
1949 1949 end
1950 1950
1951 1951 def test_post_create_with_watchers
1952 1952 @request.session[:user_id] = 2
1953 1953 ActionMailer::Base.deliveries.clear
1954 1954
1955 1955 assert_difference 'Watcher.count', 2 do
1956 1956 post :create, :project_id => 1,
1957 1957 :issue => {:tracker_id => 1,
1958 1958 :subject => 'This is a new issue with watchers',
1959 1959 :description => 'This is the description',
1960 1960 :priority_id => 5,
1961 1961 :watcher_user_ids => ['2', '3']}
1962 1962 end
1963 1963 issue = Issue.find_by_subject('This is a new issue with watchers')
1964 1964 assert_not_nil issue
1965 1965 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1966 1966
1967 1967 # Watchers added
1968 1968 assert_equal [2, 3], issue.watcher_user_ids.sort
1969 1969 assert issue.watched_by?(User.find(3))
1970 1970 # Watchers notified
1971 1971 mail = ActionMailer::Base.deliveries.last
1972 1972 assert_not_nil mail
1973 1973 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1974 1974 end
1975 1975
1976 1976 def test_post_create_subissue
1977 1977 @request.session[:user_id] = 2
1978 1978
1979 1979 assert_difference 'Issue.count' do
1980 1980 post :create, :project_id => 1,
1981 1981 :issue => {:tracker_id => 1,
1982 1982 :subject => 'This is a child issue',
1983 1983 :parent_issue_id => '2'}
1984 1984 assert_response 302
1985 1985 end
1986 1986 issue = Issue.order('id DESC').first
1987 1987 assert_equal Issue.find(2), issue.parent
1988 1988 end
1989 1989
1990 1990 def test_post_create_subissue_with_sharp_parent_id
1991 1991 @request.session[:user_id] = 2
1992 1992
1993 1993 assert_difference 'Issue.count' do
1994 1994 post :create, :project_id => 1,
1995 1995 :issue => {:tracker_id => 1,
1996 1996 :subject => 'This is a child issue',
1997 1997 :parent_issue_id => '#2'}
1998 1998 assert_response 302
1999 1999 end
2000 2000 issue = Issue.order('id DESC').first
2001 2001 assert_equal Issue.find(2), issue.parent
2002 2002 end
2003 2003
2004 2004 def test_post_create_subissue_with_non_visible_parent_id_should_not_validate
2005 2005 @request.session[:user_id] = 2
2006 2006
2007 2007 assert_no_difference 'Issue.count' do
2008 2008 post :create, :project_id => 1,
2009 2009 :issue => {:tracker_id => 1,
2010 2010 :subject => 'This is a child issue',
2011 2011 :parent_issue_id => '4'}
2012 2012
2013 2013 assert_response :success
2014 2014 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '4'
2015 2015 assert_error_tag :content => /Parent task is invalid/i
2016 2016 end
2017 2017 end
2018 2018
2019 2019 def test_post_create_subissue_with_non_numeric_parent_id_should_not_validate
2020 2020 @request.session[:user_id] = 2
2021 2021
2022 2022 assert_no_difference 'Issue.count' do
2023 2023 post :create, :project_id => 1,
2024 2024 :issue => {:tracker_id => 1,
2025 2025 :subject => 'This is a child issue',
2026 2026 :parent_issue_id => '01ABC'}
2027 2027
2028 2028 assert_response :success
2029 2029 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '01ABC'
2030 2030 assert_error_tag :content => /Parent task is invalid/i
2031 2031 end
2032 2032 end
2033 2033
2034 2034 def test_post_create_private
2035 2035 @request.session[:user_id] = 2
2036 2036
2037 2037 assert_difference 'Issue.count' do
2038 2038 post :create, :project_id => 1,
2039 2039 :issue => {:tracker_id => 1,
2040 2040 :subject => 'This is a private issue',
2041 2041 :is_private => '1'}
2042 2042 end
2043 2043 issue = Issue.first(:order => 'id DESC')
2044 2044 assert issue.is_private?
2045 2045 end
2046 2046
2047 2047 def test_post_create_private_with_set_own_issues_private_permission
2048 2048 role = Role.find(1)
2049 2049 role.remove_permission! :set_issues_private
2050 2050 role.add_permission! :set_own_issues_private
2051 2051
2052 2052 @request.session[:user_id] = 2
2053 2053
2054 2054 assert_difference 'Issue.count' do
2055 2055 post :create, :project_id => 1,
2056 2056 :issue => {:tracker_id => 1,
2057 2057 :subject => 'This is a private issue',
2058 2058 :is_private => '1'}
2059 2059 end
2060 2060 issue = Issue.first(:order => 'id DESC')
2061 2061 assert issue.is_private?
2062 2062 end
2063 2063
2064 2064 def test_post_create_should_send_a_notification
2065 2065 ActionMailer::Base.deliveries.clear
2066 2066 @request.session[:user_id] = 2
2067 2067 assert_difference 'Issue.count' do
2068 2068 post :create, :project_id => 1,
2069 2069 :issue => {:tracker_id => 3,
2070 2070 :subject => 'This is the test_new issue',
2071 2071 :description => 'This is the description',
2072 2072 :priority_id => 5,
2073 2073 :estimated_hours => '',
2074 2074 :custom_field_values => {'2' => 'Value for field 2'}}
2075 2075 end
2076 2076 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
2077 2077
2078 2078 assert_equal 1, ActionMailer::Base.deliveries.size
2079 2079 end
2080 2080
2081 2081 def test_post_create_should_preserve_fields_values_on_validation_failure
2082 2082 @request.session[:user_id] = 2
2083 2083 post :create, :project_id => 1,
2084 2084 :issue => {:tracker_id => 1,
2085 2085 # empty subject
2086 2086 :subject => '',
2087 2087 :description => 'This is a description',
2088 2088 :priority_id => 6,
2089 2089 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
2090 2090 assert_response :success
2091 2091 assert_template 'new'
2092 2092
2093 2093 assert_select 'textarea[name=?]', 'issue[description]', :text => 'This is a description'
2094 2094 assert_select 'select[name=?]', 'issue[priority_id]' do
2095 2095 assert_select 'option[value=6][selected=selected]', :text => 'High'
2096 2096 end
2097 2097 # Custom fields
2098 2098 assert_select 'select[name=?]', 'issue[custom_field_values][1]' do
2099 2099 assert_select 'option[value=Oracle][selected=selected]', :text => 'Oracle'
2100 2100 end
2101 2101 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Value for field 2'
2102 2102 end
2103 2103
2104 2104 def test_post_create_with_failure_should_preserve_watchers
2105 2105 assert !User.find(8).member_of?(Project.find(1))
2106 2106
2107 2107 @request.session[:user_id] = 2
2108 2108 post :create, :project_id => 1,
2109 2109 :issue => {:tracker_id => 1,
2110 2110 :watcher_user_ids => ['3', '8']}
2111 2111 assert_response :success
2112 2112 assert_template 'new'
2113 2113
2114 2114 assert_select 'input[name=?][value=2]:not(checked)', 'issue[watcher_user_ids][]'
2115 2115 assert_select 'input[name=?][value=3][checked=checked]', 'issue[watcher_user_ids][]'
2116 2116 assert_select 'input[name=?][value=8][checked=checked]', 'issue[watcher_user_ids][]'
2117 2117 end
2118 2118
2119 2119 def test_post_create_should_ignore_non_safe_attributes
2120 2120 @request.session[:user_id] = 2
2121 2121 assert_nothing_raised do
2122 2122 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
2123 2123 end
2124 2124 end
2125 2125
2126 2126 def test_post_create_with_attachment
2127 2127 set_tmp_attachments_directory
2128 2128 @request.session[:user_id] = 2
2129 2129
2130 2130 assert_difference 'Issue.count' do
2131 2131 assert_difference 'Attachment.count' do
2132 2132 post :create, :project_id => 1,
2133 2133 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2134 2134 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2135 2135 end
2136 2136 end
2137 2137
2138 2138 issue = Issue.first(:order => 'id DESC')
2139 2139 attachment = Attachment.first(:order => 'id DESC')
2140 2140
2141 2141 assert_equal issue, attachment.container
2142 2142 assert_equal 2, attachment.author_id
2143 2143 assert_equal 'testfile.txt', attachment.filename
2144 2144 assert_equal 'text/plain', attachment.content_type
2145 2145 assert_equal 'test file', attachment.description
2146 2146 assert_equal 59, attachment.filesize
2147 2147 assert File.exists?(attachment.diskfile)
2148 2148 assert_equal 59, File.size(attachment.diskfile)
2149 2149 end
2150 2150
2151 2151 def test_post_create_with_failure_should_save_attachments
2152 2152 set_tmp_attachments_directory
2153 2153 @request.session[:user_id] = 2
2154 2154
2155 2155 assert_no_difference 'Issue.count' do
2156 2156 assert_difference 'Attachment.count' do
2157 2157 post :create, :project_id => 1,
2158 2158 :issue => { :tracker_id => '1', :subject => '' },
2159 2159 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2160 2160 assert_response :success
2161 2161 assert_template 'new'
2162 2162 end
2163 2163 end
2164 2164
2165 2165 attachment = Attachment.first(:order => 'id DESC')
2166 2166 assert_equal 'testfile.txt', attachment.filename
2167 2167 assert File.exists?(attachment.diskfile)
2168 2168 assert_nil attachment.container
2169 2169
2170 2170 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2171 2171 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2172 2172 end
2173 2173
2174 2174 def test_post_create_with_failure_should_keep_saved_attachments
2175 2175 set_tmp_attachments_directory
2176 2176 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2177 2177 @request.session[:user_id] = 2
2178 2178
2179 2179 assert_no_difference 'Issue.count' do
2180 2180 assert_no_difference 'Attachment.count' do
2181 2181 post :create, :project_id => 1,
2182 2182 :issue => { :tracker_id => '1', :subject => '' },
2183 2183 :attachments => {'p0' => {'token' => attachment.token}}
2184 2184 assert_response :success
2185 2185 assert_template 'new'
2186 2186 end
2187 2187 end
2188 2188
2189 2189 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2190 2190 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2191 2191 end
2192 2192
2193 2193 def test_post_create_should_attach_saved_attachments
2194 2194 set_tmp_attachments_directory
2195 2195 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2196 2196 @request.session[:user_id] = 2
2197 2197
2198 2198 assert_difference 'Issue.count' do
2199 2199 assert_no_difference 'Attachment.count' do
2200 2200 post :create, :project_id => 1,
2201 2201 :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
2202 2202 :attachments => {'p0' => {'token' => attachment.token}}
2203 2203 assert_response 302
2204 2204 end
2205 2205 end
2206 2206
2207 2207 issue = Issue.first(:order => 'id DESC')
2208 2208 assert_equal 1, issue.attachments.count
2209 2209
2210 2210 attachment.reload
2211 2211 assert_equal issue, attachment.container
2212 2212 end
2213 2213
2214 2214 context "without workflow privilege" do
2215 2215 setup do
2216 2216 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2217 2217 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2218 2218 end
2219 2219
2220 2220 context "#new" do
2221 2221 should "propose default status only" do
2222 2222 get :new, :project_id => 1
2223 2223 assert_response :success
2224 2224 assert_template 'new'
2225 2225 assert_select 'select[name=?]', 'issue[status_id]' do
2226 2226 assert_select 'option', 1
2227 2227 assert_select 'option[value=?]', IssueStatus.default.id.to_s
2228 2228 end
2229 2229 end
2230 2230
2231 2231 should "accept default status" do
2232 2232 assert_difference 'Issue.count' do
2233 2233 post :create, :project_id => 1,
2234 2234 :issue => {:tracker_id => 1,
2235 2235 :subject => 'This is an issue',
2236 2236 :status_id => 1}
2237 2237 end
2238 2238 issue = Issue.last(:order => 'id')
2239 2239 assert_equal IssueStatus.default, issue.status
2240 2240 end
2241 2241
2242 2242 should "ignore unauthorized status" do
2243 2243 assert_difference 'Issue.count' do
2244 2244 post :create, :project_id => 1,
2245 2245 :issue => {:tracker_id => 1,
2246 2246 :subject => 'This is an issue',
2247 2247 :status_id => 3}
2248 2248 end
2249 2249 issue = Issue.last(:order => 'id')
2250 2250 assert_equal IssueStatus.default, issue.status
2251 2251 end
2252 2252 end
2253 2253
2254 2254 context "#update" do
2255 2255 should "ignore status change" do
2256 2256 assert_difference 'Journal.count' do
2257 2257 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2258 2258 end
2259 2259 assert_equal 1, Issue.find(1).status_id
2260 2260 end
2261 2261
2262 2262 should "ignore attributes changes" do
2263 2263 assert_difference 'Journal.count' do
2264 2264 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2265 2265 end
2266 2266 issue = Issue.find(1)
2267 2267 assert_equal "Can't print recipes", issue.subject
2268 2268 assert_nil issue.assigned_to
2269 2269 end
2270 2270 end
2271 2271 end
2272 2272
2273 2273 context "with workflow privilege" do
2274 2274 setup do
2275 2275 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2276 2276 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
2277 2277 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
2278 2278 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2279 2279 end
2280 2280
2281 2281 context "#update" do
2282 2282 should "accept authorized status" do
2283 2283 assert_difference 'Journal.count' do
2284 2284 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2285 2285 end
2286 2286 assert_equal 3, Issue.find(1).status_id
2287 2287 end
2288 2288
2289 2289 should "ignore unauthorized status" do
2290 2290 assert_difference 'Journal.count' do
2291 2291 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2292 2292 end
2293 2293 assert_equal 1, Issue.find(1).status_id
2294 2294 end
2295 2295
2296 2296 should "accept authorized attributes changes" do
2297 2297 assert_difference 'Journal.count' do
2298 2298 put :update, :id => 1, :issue => {:assigned_to_id => 2, :notes => 'just trying'}
2299 2299 end
2300 2300 issue = Issue.find(1)
2301 2301 assert_equal 2, issue.assigned_to_id
2302 2302 end
2303 2303
2304 2304 should "ignore unauthorized attributes changes" do
2305 2305 assert_difference 'Journal.count' do
2306 2306 put :update, :id => 1, :issue => {:subject => 'changed', :notes => 'just trying'}
2307 2307 end
2308 2308 issue = Issue.find(1)
2309 2309 assert_equal "Can't print recipes", issue.subject
2310 2310 end
2311 2311 end
2312 2312
2313 2313 context "and :edit_issues permission" do
2314 2314 setup do
2315 2315 Role.anonymous.add_permission! :add_issues, :edit_issues
2316 2316 end
2317 2317
2318 2318 should "accept authorized status" do
2319 2319 assert_difference 'Journal.count' do
2320 2320 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2321 2321 end
2322 2322 assert_equal 3, Issue.find(1).status_id
2323 2323 end
2324 2324
2325 2325 should "ignore unauthorized status" do
2326 2326 assert_difference 'Journal.count' do
2327 2327 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2328 2328 end
2329 2329 assert_equal 1, Issue.find(1).status_id
2330 2330 end
2331 2331
2332 2332 should "accept authorized attributes changes" do
2333 2333 assert_difference 'Journal.count' do
2334 2334 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2335 2335 end
2336 2336 issue = Issue.find(1)
2337 2337 assert_equal "changed", issue.subject
2338 2338 assert_equal 2, issue.assigned_to_id
2339 2339 end
2340 2340 end
2341 2341 end
2342 2342
2343 2343 def test_new_as_copy
2344 2344 @request.session[:user_id] = 2
2345 2345 get :new, :project_id => 1, :copy_from => 1
2346 2346
2347 2347 assert_response :success
2348 2348 assert_template 'new'
2349 2349
2350 2350 assert_not_nil assigns(:issue)
2351 2351 orig = Issue.find(1)
2352 2352 assert_equal 1, assigns(:issue).project_id
2353 2353 assert_equal orig.subject, assigns(:issue).subject
2354 2354 assert assigns(:issue).copy?
2355 2355
2356 2356 assert_select 'form[id=issue-form][action=/projects/ecookbook/issues]' do
2357 2357 assert_select 'select[name=?]', 'issue[project_id]' do
2358 2358 assert_select 'option[value=1][selected=selected]', :text => 'eCookbook'
2359 2359 assert_select 'option[value=2]:not([selected])', :text => 'OnlineStore'
2360 2360 end
2361 2361 assert_select 'input[name=copy_from][value=1]'
2362 2362 end
2363 2363
2364 2364 # "New issue" menu item should not link to copy
2365 2365 assert_select '#main-menu a.new-issue[href=/projects/ecookbook/issues/new]'
2366 2366 end
2367 2367
2368 2368 def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
2369 2369 @request.session[:user_id] = 2
2370 2370 issue = Issue.find(3)
2371 2371 assert issue.attachments.count > 0
2372 2372 get :new, :project_id => 1, :copy_from => 3
2373 2373
2374 2374 assert_select 'input[name=copy_attachments][type=checkbox][checked=checked][value=1]'
2375 2375 end
2376 2376
2377 2377 def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
2378 2378 @request.session[:user_id] = 2
2379 2379 issue = Issue.find(3)
2380 2380 issue.attachments.delete_all
2381 2381 get :new, :project_id => 1, :copy_from => 3
2382 2382
2383 2383 assert_select 'input[name=copy_attachments]', 0
2384 2384 end
2385 2385
2386 2386 def test_new_as_copy_with_subtasks_should_show_copy_subtasks_checkbox
2387 2387 @request.session[:user_id] = 2
2388 2388 issue = Issue.generate_with_descendants!
2389 2389 get :new, :project_id => 1, :copy_from => issue.id
2390 2390
2391 2391 assert_select 'input[type=checkbox][name=copy_subtasks][checked=checked][value=1]'
2392 2392 end
2393 2393
2394 2394 def test_new_as_copy_with_invalid_issue_should_respond_with_404
2395 2395 @request.session[:user_id] = 2
2396 2396 get :new, :project_id => 1, :copy_from => 99999
2397 2397 assert_response 404
2398 2398 end
2399 2399
2400 2400 def test_create_as_copy_on_different_project
2401 2401 @request.session[:user_id] = 2
2402 2402 assert_difference 'Issue.count' do
2403 2403 post :create, :project_id => 1, :copy_from => 1,
2404 2404 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2405 2405
2406 2406 assert_not_nil assigns(:issue)
2407 2407 assert assigns(:issue).copy?
2408 2408 end
2409 2409 issue = Issue.first(:order => 'id DESC')
2410 2410 assert_redirected_to "/issues/#{issue.id}"
2411 2411
2412 2412 assert_equal 2, issue.project_id
2413 2413 assert_equal 3, issue.tracker_id
2414 2414 assert_equal 'Copy', issue.subject
2415 2415 end
2416 2416
2417 2417 def test_create_as_copy_should_copy_attachments
2418 2418 @request.session[:user_id] = 2
2419 2419 issue = Issue.find(3)
2420 2420 count = issue.attachments.count
2421 2421 assert count > 0
2422 2422
2423 2423 assert_difference 'Issue.count' do
2424 2424 assert_difference 'Attachment.count', count do
2425 2425 assert_no_difference 'Journal.count' do
2426 2426 post :create, :project_id => 1, :copy_from => 3,
2427 2427 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2428 2428 :copy_attachments => '1'
2429 2429 end
2430 2430 end
2431 2431 end
2432 2432 copy = Issue.first(:order => 'id DESC')
2433 2433 assert_equal count, copy.attachments.count
2434 2434 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
2435 2435 end
2436 2436
2437 2437 def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
2438 2438 @request.session[:user_id] = 2
2439 2439 issue = Issue.find(3)
2440 2440 count = issue.attachments.count
2441 2441 assert count > 0
2442 2442
2443 2443 assert_difference 'Issue.count' do
2444 2444 assert_no_difference 'Attachment.count' do
2445 2445 assert_no_difference 'Journal.count' do
2446 2446 post :create, :project_id => 1, :copy_from => 3,
2447 2447 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'}
2448 2448 end
2449 2449 end
2450 2450 end
2451 2451 copy = Issue.first(:order => 'id DESC')
2452 2452 assert_equal 0, copy.attachments.count
2453 2453 end
2454 2454
2455 2455 def test_create_as_copy_with_attachments_should_add_new_files
2456 2456 @request.session[:user_id] = 2
2457 2457 issue = Issue.find(3)
2458 2458 count = issue.attachments.count
2459 2459 assert count > 0
2460 2460
2461 2461 assert_difference 'Issue.count' do
2462 2462 assert_difference 'Attachment.count', count + 1 do
2463 2463 assert_no_difference 'Journal.count' do
2464 2464 post :create, :project_id => 1, :copy_from => 3,
2465 2465 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2466 2466 :copy_attachments => '1',
2467 2467 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2468 2468 end
2469 2469 end
2470 2470 end
2471 2471 copy = Issue.first(:order => 'id DESC')
2472 2472 assert_equal count + 1, copy.attachments.count
2473 2473 end
2474 2474
2475 2475 def test_create_as_copy_should_add_relation_with_copied_issue
2476 2476 @request.session[:user_id] = 2
2477 2477
2478 2478 assert_difference 'Issue.count' do
2479 2479 assert_difference 'IssueRelation.count' do
2480 2480 post :create, :project_id => 1, :copy_from => 1,
2481 2481 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2482 2482 end
2483 2483 end
2484 2484 copy = Issue.first(:order => 'id DESC')
2485 2485 assert_equal 1, copy.relations.size
2486 2486 end
2487 2487
2488 2488 def test_create_as_copy_should_copy_subtasks
2489 2489 @request.session[:user_id] = 2
2490 2490 issue = Issue.generate_with_descendants!
2491 2491 count = issue.descendants.count
2492 2492
2493 2493 assert_difference 'Issue.count', count+1 do
2494 2494 assert_no_difference 'Journal.count' do
2495 2495 post :create, :project_id => 1, :copy_from => issue.id,
2496 2496 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with subtasks'},
2497 2497 :copy_subtasks => '1'
2498 2498 end
2499 2499 end
2500 2500 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2501 2501 assert_equal count, copy.descendants.count
2502 2502 assert_equal issue.descendants.map(&:subject).sort, copy.descendants.map(&:subject).sort
2503 2503 end
2504 2504
2505 2505 def test_create_as_copy_without_copy_subtasks_option_should_not_copy_subtasks
2506 2506 @request.session[:user_id] = 2
2507 2507 issue = Issue.generate_with_descendants!
2508 2508
2509 2509 assert_difference 'Issue.count', 1 do
2510 2510 assert_no_difference 'Journal.count' do
2511 2511 post :create, :project_id => 1, :copy_from => 3,
2512 2512 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with subtasks'}
2513 2513 end
2514 2514 end
2515 2515 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2516 2516 assert_equal 0, copy.descendants.count
2517 2517 end
2518 2518
2519 2519 def test_create_as_copy_with_failure
2520 2520 @request.session[:user_id] = 2
2521 2521 post :create, :project_id => 1, :copy_from => 1,
2522 2522 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
2523 2523
2524 2524 assert_response :success
2525 2525 assert_template 'new'
2526 2526
2527 2527 assert_not_nil assigns(:issue)
2528 2528 assert assigns(:issue).copy?
2529 2529
2530 2530 assert_select 'form#issue-form[action=/projects/ecookbook/issues]' do
2531 2531 assert_select 'select[name=?]', 'issue[project_id]' do
2532 2532 assert_select 'option[value=1]:not([selected])', :text => 'eCookbook'
2533 2533 assert_select 'option[value=2][selected=selected]', :text => 'OnlineStore'
2534 2534 end
2535 2535 assert_select 'input[name=copy_from][value=1]'
2536 2536 end
2537 2537 end
2538 2538
2539 2539 def test_create_as_copy_on_project_without_permission_should_ignore_target_project
2540 2540 @request.session[:user_id] = 2
2541 2541 assert !User.find(2).member_of?(Project.find(4))
2542 2542
2543 2543 assert_difference 'Issue.count' do
2544 2544 post :create, :project_id => 1, :copy_from => 1,
2545 2545 :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2546 2546 end
2547 2547 issue = Issue.first(:order => 'id DESC')
2548 2548 assert_equal 1, issue.project_id
2549 2549 end
2550 2550
2551 2551 def test_get_edit
2552 2552 @request.session[:user_id] = 2
2553 2553 get :edit, :id => 1
2554 2554 assert_response :success
2555 2555 assert_template 'edit'
2556 2556 assert_not_nil assigns(:issue)
2557 2557 assert_equal Issue.find(1), assigns(:issue)
2558 2558
2559 2559 # Be sure we don't display inactive IssuePriorities
2560 2560 assert ! IssuePriority.find(15).active?
2561 2561 assert_select 'select[name=?]', 'issue[priority_id]' do
2562 2562 assert_select 'option[value=15]', 0
2563 2563 end
2564 2564 end
2565 2565
2566 2566 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
2567 2567 @request.session[:user_id] = 2
2568 2568 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
2569 2569
2570 2570 get :edit, :id => 1
2571 2571 assert_select 'input[name=?]', 'time_entry[hours]'
2572 2572 end
2573 2573
2574 2574 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
2575 2575 @request.session[:user_id] = 2
2576 2576 Role.find_by_name('Manager').remove_permission! :log_time
2577 2577
2578 2578 get :edit, :id => 1
2579 2579 assert_select 'input[name=?]', 'time_entry[hours]', 0
2580 2580 end
2581 2581
2582 2582 def test_get_edit_with_params
2583 2583 @request.session[:user_id] = 2
2584 2584 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
2585 2585 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => 10 }
2586 2586 assert_response :success
2587 2587 assert_template 'edit'
2588 2588
2589 2589 issue = assigns(:issue)
2590 2590 assert_not_nil issue
2591 2591
2592 2592 assert_equal 5, issue.status_id
2593 2593 assert_select 'select[name=?]', 'issue[status_id]' do
2594 2594 assert_select 'option[value=5][selected=selected]', :text => 'Closed'
2595 2595 end
2596 2596
2597 2597 assert_equal 7, issue.priority_id
2598 2598 assert_select 'select[name=?]', 'issue[priority_id]' do
2599 2599 assert_select 'option[value=7][selected=selected]', :text => 'Urgent'
2600 2600 end
2601 2601
2602 2602 assert_select 'input[name=?][value=2.5]', 'time_entry[hours]'
2603 2603 assert_select 'select[name=?]', 'time_entry[activity_id]' do
2604 2604 assert_select 'option[value=10][selected=selected]', :text => 'Development'
2605 2605 end
2606 2606 assert_select 'input[name=?][value=test_get_edit_with_params]', 'time_entry[comments]'
2607 2607 end
2608 2608
2609 2609 def test_get_edit_with_multi_custom_field
2610 2610 field = CustomField.find(1)
2611 2611 field.update_attribute :multiple, true
2612 2612 issue = Issue.find(1)
2613 2613 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2614 2614 issue.save!
2615 2615
2616 2616 @request.session[:user_id] = 2
2617 2617 get :edit, :id => 1
2618 2618 assert_response :success
2619 2619 assert_template 'edit'
2620 2620
2621 2621 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
2622 2622 assert_select 'option', 3
2623 2623 assert_select 'option[value=MySQL][selected=selected]'
2624 2624 assert_select 'option[value=Oracle][selected=selected]'
2625 2625 assert_select 'option[value=PostgreSQL]:not([selected])'
2626 2626 end
2627 2627 end
2628 2628
2629 def test_update_edit_form
2629 def test_update_form_for_existing_issue
2630 2630 @request.session[:user_id] = 2
2631 xhr :put, :new, :project_id => 1,
2631 xhr :put, :update_form, :project_id => 1,
2632 2632 :id => 1,
2633 2633 :issue => {:tracker_id => 2,
2634 2634 :subject => 'This is the test_new issue',
2635 2635 :description => 'This is the description',
2636 2636 :priority_id => 5}
2637 2637 assert_response :success
2638 2638 assert_equal 'text/javascript', response.content_type
2639 2639 assert_template 'update_form'
2640 2640 assert_template 'form'
2641 2641
2642 2642 issue = assigns(:issue)
2643 2643 assert_kind_of Issue, issue
2644 2644 assert_equal 1, issue.id
2645 2645 assert_equal 1, issue.project_id
2646 2646 assert_equal 2, issue.tracker_id
2647 2647 assert_equal 'This is the test_new issue', issue.subject
2648 2648 end
2649 2649
2650 def test_update_edit_form_should_keep_issue_author
2650 def test_update_form_for_existing_issue_should_keep_issue_author
2651 2651 @request.session[:user_id] = 3
2652 xhr :put, :new, :project_id => 1, :id => 1, :issue => {:subject => 'Changed'}
2652 xhr :put, :update_form, :project_id => 1, :id => 1, :issue => {:subject => 'Changed'}
2653 2653 assert_response :success
2654 2654 assert_equal 'text/javascript', response.content_type
2655 2655
2656 2656 issue = assigns(:issue)
2657 2657 assert_equal User.find(2), issue.author
2658 2658 assert_equal 2, issue.author_id
2659 2659 assert_not_equal User.current, issue.author
2660 2660 end
2661 2661
2662 def test_update_edit_form_should_propose_transitions_based_on_initial_status
2662 def test_update_form_for_existing_issue_should_propose_transitions_based_on_initial_status
2663 2663 @request.session[:user_id] = 2
2664 2664 WorkflowTransition.delete_all
2665 2665 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
2666 2666 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
2667 2667 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 5, :new_status_id => 4)
2668 2668
2669 xhr :put, :new, :project_id => 1,
2669 xhr :put, :update_form, :project_id => 1,
2670 2670 :id => 2,
2671 2671 :issue => {:tracker_id => 2,
2672 2672 :status_id => 5,
2673 2673 :subject => 'This is an issue'}
2674 2674
2675 2675 assert_equal 5, assigns(:issue).status_id
2676 2676 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
2677 2677 end
2678 2678
2679 def test_update_edit_form_with_project_change
2679 def test_update_form_for_existing_issue_with_project_change
2680 2680 @request.session[:user_id] = 2
2681 xhr :put, :new, :project_id => 1,
2681 xhr :put, :update_form, :project_id => 1,
2682 2682 :id => 1,
2683 2683 :issue => {:project_id => 2,
2684 2684 :tracker_id => 2,
2685 2685 :subject => 'This is the test_new issue',
2686 2686 :description => 'This is the description',
2687 2687 :priority_id => 5}
2688 2688 assert_response :success
2689 2689 assert_template 'form'
2690 2690
2691 2691 issue = assigns(:issue)
2692 2692 assert_kind_of Issue, issue
2693 2693 assert_equal 1, issue.id
2694 2694 assert_equal 2, issue.project_id
2695 2695 assert_equal 2, issue.tracker_id
2696 2696 assert_equal 'This is the test_new issue', issue.subject
2697 2697 end
2698 2698
2699 2699 def test_put_update_without_custom_fields_param
2700 2700 @request.session[:user_id] = 2
2701 2701 ActionMailer::Base.deliveries.clear
2702 2702
2703 2703 issue = Issue.find(1)
2704 2704 assert_equal '125', issue.custom_value_for(2).value
2705 2705 old_subject = issue.subject
2706 2706 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2707 2707
2708 2708 assert_difference('Journal.count') do
2709 2709 assert_difference('JournalDetail.count', 2) do
2710 2710 put :update, :id => 1, :issue => {:subject => new_subject,
2711 2711 :priority_id => '6',
2712 2712 :category_id => '1' # no change
2713 2713 }
2714 2714 end
2715 2715 end
2716 2716 assert_redirected_to :action => 'show', :id => '1'
2717 2717 issue.reload
2718 2718 assert_equal new_subject, issue.subject
2719 2719 # Make sure custom fields were not cleared
2720 2720 assert_equal '125', issue.custom_value_for(2).value
2721 2721
2722 2722 mail = ActionMailer::Base.deliveries.last
2723 2723 assert_not_nil mail
2724 2724 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2725 2725 assert_mail_body_match "Subject changed from #{old_subject} to #{new_subject}", mail
2726 2726 end
2727 2727
2728 2728 def test_put_update_with_project_change
2729 2729 @request.session[:user_id] = 2
2730 2730 ActionMailer::Base.deliveries.clear
2731 2731
2732 2732 assert_difference('Journal.count') do
2733 2733 assert_difference('JournalDetail.count', 3) do
2734 2734 put :update, :id => 1, :issue => {:project_id => '2',
2735 2735 :tracker_id => '1', # no change
2736 2736 :priority_id => '6',
2737 2737 :category_id => '3'
2738 2738 }
2739 2739 end
2740 2740 end
2741 2741 assert_redirected_to :action => 'show', :id => '1'
2742 2742 issue = Issue.find(1)
2743 2743 assert_equal 2, issue.project_id
2744 2744 assert_equal 1, issue.tracker_id
2745 2745 assert_equal 6, issue.priority_id
2746 2746 assert_equal 3, issue.category_id
2747 2747
2748 2748 mail = ActionMailer::Base.deliveries.last
2749 2749 assert_not_nil mail
2750 2750 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2751 2751 assert_mail_body_match "Project changed from eCookbook to OnlineStore", mail
2752 2752 end
2753 2753
2754 2754 def test_put_update_with_tracker_change
2755 2755 @request.session[:user_id] = 2
2756 2756 ActionMailer::Base.deliveries.clear
2757 2757
2758 2758 assert_difference('Journal.count') do
2759 2759 assert_difference('JournalDetail.count', 2) do
2760 2760 put :update, :id => 1, :issue => {:project_id => '1',
2761 2761 :tracker_id => '2',
2762 2762 :priority_id => '6'
2763 2763 }
2764 2764 end
2765 2765 end
2766 2766 assert_redirected_to :action => 'show', :id => '1'
2767 2767 issue = Issue.find(1)
2768 2768 assert_equal 1, issue.project_id
2769 2769 assert_equal 2, issue.tracker_id
2770 2770 assert_equal 6, issue.priority_id
2771 2771 assert_equal 1, issue.category_id
2772 2772
2773 2773 mail = ActionMailer::Base.deliveries.last
2774 2774 assert_not_nil mail
2775 2775 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2776 2776 assert_mail_body_match "Tracker changed from Bug to Feature request", mail
2777 2777 end
2778 2778
2779 2779 def test_put_update_with_custom_field_change
2780 2780 @request.session[:user_id] = 2
2781 2781 issue = Issue.find(1)
2782 2782 assert_equal '125', issue.custom_value_for(2).value
2783 2783
2784 2784 assert_difference('Journal.count') do
2785 2785 assert_difference('JournalDetail.count', 3) do
2786 2786 put :update, :id => 1, :issue => {:subject => 'Custom field change',
2787 2787 :priority_id => '6',
2788 2788 :category_id => '1', # no change
2789 2789 :custom_field_values => { '2' => 'New custom value' }
2790 2790 }
2791 2791 end
2792 2792 end
2793 2793 assert_redirected_to :action => 'show', :id => '1'
2794 2794 issue.reload
2795 2795 assert_equal 'New custom value', issue.custom_value_for(2).value
2796 2796
2797 2797 mail = ActionMailer::Base.deliveries.last
2798 2798 assert_not_nil mail
2799 2799 assert_mail_body_match "Searchable field changed from 125 to New custom value", mail
2800 2800 end
2801 2801
2802 2802 def test_put_update_with_multi_custom_field_change
2803 2803 field = CustomField.find(1)
2804 2804 field.update_attribute :multiple, true
2805 2805 issue = Issue.find(1)
2806 2806 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2807 2807 issue.save!
2808 2808
2809 2809 @request.session[:user_id] = 2
2810 2810 assert_difference('Journal.count') do
2811 2811 assert_difference('JournalDetail.count', 3) do
2812 2812 put :update, :id => 1,
2813 2813 :issue => {
2814 2814 :subject => 'Custom field change',
2815 2815 :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
2816 2816 }
2817 2817 end
2818 2818 end
2819 2819 assert_redirected_to :action => 'show', :id => '1'
2820 2820 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
2821 2821 end
2822 2822
2823 2823 def test_put_update_with_status_and_assignee_change
2824 2824 issue = Issue.find(1)
2825 2825 assert_equal 1, issue.status_id
2826 2826 @request.session[:user_id] = 2
2827 2827 assert_difference('TimeEntry.count', 0) do
2828 2828 put :update,
2829 2829 :id => 1,
2830 2830 :issue => { :status_id => 2, :assigned_to_id => 3, :notes => 'Assigned to dlopper' },
2831 2831 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
2832 2832 end
2833 2833 assert_redirected_to :action => 'show', :id => '1'
2834 2834 issue.reload
2835 2835 assert_equal 2, issue.status_id
2836 2836 j = Journal.order('id DESC').first
2837 2837 assert_equal 'Assigned to dlopper', j.notes
2838 2838 assert_equal 2, j.details.size
2839 2839
2840 2840 mail = ActionMailer::Base.deliveries.last
2841 2841 assert_mail_body_match "Status changed from New to Assigned", mail
2842 2842 # subject should contain the new status
2843 2843 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
2844 2844 end
2845 2845
2846 2846 def test_put_update_with_note_only
2847 2847 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
2848 2848 # anonymous user
2849 2849 put :update,
2850 2850 :id => 1,
2851 2851 :issue => { :notes => notes }
2852 2852 assert_redirected_to :action => 'show', :id => '1'
2853 2853 j = Journal.order('id DESC').first
2854 2854 assert_equal notes, j.notes
2855 2855 assert_equal 0, j.details.size
2856 2856 assert_equal User.anonymous, j.user
2857 2857
2858 2858 mail = ActionMailer::Base.deliveries.last
2859 2859 assert_mail_body_match notes, mail
2860 2860 end
2861 2861
2862 2862 def test_put_update_with_private_note_only
2863 2863 notes = 'Private note'
2864 2864 @request.session[:user_id] = 2
2865 2865
2866 2866 assert_difference 'Journal.count' do
2867 2867 put :update, :id => 1, :issue => {:notes => notes, :private_notes => '1'}
2868 2868 assert_redirected_to :action => 'show', :id => '1'
2869 2869 end
2870 2870
2871 2871 j = Journal.order('id DESC').first
2872 2872 assert_equal notes, j.notes
2873 2873 assert_equal true, j.private_notes
2874 2874 end
2875 2875
2876 2876 def test_put_update_with_private_note_and_changes
2877 2877 notes = 'Private note'
2878 2878 @request.session[:user_id] = 2
2879 2879
2880 2880 assert_difference 'Journal.count', 2 do
2881 2881 put :update, :id => 1, :issue => {:subject => 'New subject', :notes => notes, :private_notes => '1'}
2882 2882 assert_redirected_to :action => 'show', :id => '1'
2883 2883 end
2884 2884
2885 2885 j = Journal.order('id DESC').first
2886 2886 assert_equal notes, j.notes
2887 2887 assert_equal true, j.private_notes
2888 2888 assert_equal 0, j.details.count
2889 2889
2890 2890 j = Journal.order('id DESC').offset(1).first
2891 2891 assert_nil j.notes
2892 2892 assert_equal false, j.private_notes
2893 2893 assert_equal 1, j.details.count
2894 2894 end
2895 2895
2896 2896 def test_put_update_with_note_and_spent_time
2897 2897 @request.session[:user_id] = 2
2898 2898 spent_hours_before = Issue.find(1).spent_hours
2899 2899 assert_difference('TimeEntry.count') do
2900 2900 put :update,
2901 2901 :id => 1,
2902 2902 :issue => { :notes => '2.5 hours added' },
2903 2903 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
2904 2904 end
2905 2905 assert_redirected_to :action => 'show', :id => '1'
2906 2906
2907 2907 issue = Issue.find(1)
2908 2908
2909 2909 j = Journal.order('id DESC').first
2910 2910 assert_equal '2.5 hours added', j.notes
2911 2911 assert_equal 0, j.details.size
2912 2912
2913 2913 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
2914 2914 assert_not_nil t
2915 2915 assert_equal 2.5, t.hours
2916 2916 assert_equal spent_hours_before + 2.5, issue.spent_hours
2917 2917 end
2918 2918
2919 2919 def test_put_update_should_preserve_parent_issue_even_if_not_visible
2920 2920 parent = Issue.generate!(:project_id => 1, :is_private => true)
2921 2921 issue = Issue.generate!(:parent_issue_id => parent.id)
2922 2922 assert !parent.visible?(User.find(3))
2923 2923 @request.session[:user_id] = 3
2924 2924
2925 2925 get :edit, :id => issue.id
2926 2926 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', parent.id.to_s
2927 2927
2928 2928 put :update, :id => issue.id, :issue => {:subject => 'New subject', :parent_issue_id => parent.id.to_s}
2929 2929 assert_response 302
2930 2930 assert_equal parent, issue.parent
2931 2931 end
2932 2932
2933 2933 def test_put_update_with_attachment_only
2934 2934 set_tmp_attachments_directory
2935 2935
2936 2936 # Delete all fixtured journals, a race condition can occur causing the wrong
2937 2937 # journal to get fetched in the next find.
2938 2938 Journal.delete_all
2939 2939
2940 2940 # anonymous user
2941 2941 assert_difference 'Attachment.count' do
2942 2942 put :update, :id => 1,
2943 2943 :issue => {:notes => ''},
2944 2944 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2945 2945 end
2946 2946
2947 2947 assert_redirected_to :action => 'show', :id => '1'
2948 2948 j = Issue.find(1).journals.reorder('id DESC').first
2949 2949 assert j.notes.blank?
2950 2950 assert_equal 1, j.details.size
2951 2951 assert_equal 'testfile.txt', j.details.first.value
2952 2952 assert_equal User.anonymous, j.user
2953 2953
2954 2954 attachment = Attachment.first(:order => 'id DESC')
2955 2955 assert_equal Issue.find(1), attachment.container
2956 2956 assert_equal User.anonymous, attachment.author
2957 2957 assert_equal 'testfile.txt', attachment.filename
2958 2958 assert_equal 'text/plain', attachment.content_type
2959 2959 assert_equal 'test file', attachment.description
2960 2960 assert_equal 59, attachment.filesize
2961 2961 assert File.exists?(attachment.diskfile)
2962 2962 assert_equal 59, File.size(attachment.diskfile)
2963 2963
2964 2964 mail = ActionMailer::Base.deliveries.last
2965 2965 assert_mail_body_match 'testfile.txt', mail
2966 2966 end
2967 2967
2968 2968 def test_put_update_with_failure_should_save_attachments
2969 2969 set_tmp_attachments_directory
2970 2970 @request.session[:user_id] = 2
2971 2971
2972 2972 assert_no_difference 'Journal.count' do
2973 2973 assert_difference 'Attachment.count' do
2974 2974 put :update, :id => 1,
2975 2975 :issue => { :subject => '' },
2976 2976 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2977 2977 assert_response :success
2978 2978 assert_template 'edit'
2979 2979 end
2980 2980 end
2981 2981
2982 2982 attachment = Attachment.first(:order => 'id DESC')
2983 2983 assert_equal 'testfile.txt', attachment.filename
2984 2984 assert File.exists?(attachment.diskfile)
2985 2985 assert_nil attachment.container
2986 2986
2987 2987 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2988 2988 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2989 2989 end
2990 2990
2991 2991 def test_put_update_with_failure_should_keep_saved_attachments
2992 2992 set_tmp_attachments_directory
2993 2993 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2994 2994 @request.session[:user_id] = 2
2995 2995
2996 2996 assert_no_difference 'Journal.count' do
2997 2997 assert_no_difference 'Attachment.count' do
2998 2998 put :update, :id => 1,
2999 2999 :issue => { :subject => '' },
3000 3000 :attachments => {'p0' => {'token' => attachment.token}}
3001 3001 assert_response :success
3002 3002 assert_template 'edit'
3003 3003 end
3004 3004 end
3005 3005
3006 3006 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
3007 3007 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
3008 3008 end
3009 3009
3010 3010 def test_put_update_should_attach_saved_attachments
3011 3011 set_tmp_attachments_directory
3012 3012 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3013 3013 @request.session[:user_id] = 2
3014 3014
3015 3015 assert_difference 'Journal.count' do
3016 3016 assert_difference 'JournalDetail.count' do
3017 3017 assert_no_difference 'Attachment.count' do
3018 3018 put :update, :id => 1,
3019 3019 :issue => {:notes => 'Attachment added'},
3020 3020 :attachments => {'p0' => {'token' => attachment.token}}
3021 3021 assert_redirected_to '/issues/1'
3022 3022 end
3023 3023 end
3024 3024 end
3025 3025
3026 3026 attachment.reload
3027 3027 assert_equal Issue.find(1), attachment.container
3028 3028
3029 3029 journal = Journal.first(:order => 'id DESC')
3030 3030 assert_equal 1, journal.details.size
3031 3031 assert_equal 'testfile.txt', journal.details.first.value
3032 3032 end
3033 3033
3034 3034 def test_put_update_with_attachment_that_fails_to_save
3035 3035 set_tmp_attachments_directory
3036 3036
3037 3037 # Delete all fixtured journals, a race condition can occur causing the wrong
3038 3038 # journal to get fetched in the next find.
3039 3039 Journal.delete_all
3040 3040
3041 3041 # Mock out the unsaved attachment
3042 3042 Attachment.any_instance.stubs(:create).returns(Attachment.new)
3043 3043
3044 3044 # anonymous user
3045 3045 put :update,
3046 3046 :id => 1,
3047 3047 :issue => {:notes => ''},
3048 3048 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
3049 3049 assert_redirected_to :action => 'show', :id => '1'
3050 3050 assert_equal '1 file(s) could not be saved.', flash[:warning]
3051 3051 end
3052 3052
3053 3053 def test_put_update_with_no_change
3054 3054 issue = Issue.find(1)
3055 3055 issue.journals.clear
3056 3056 ActionMailer::Base.deliveries.clear
3057 3057
3058 3058 put :update,
3059 3059 :id => 1,
3060 3060 :issue => {:notes => ''}
3061 3061 assert_redirected_to :action => 'show', :id => '1'
3062 3062
3063 3063 issue.reload
3064 3064 assert issue.journals.empty?
3065 3065 # No email should be sent
3066 3066 assert ActionMailer::Base.deliveries.empty?
3067 3067 end
3068 3068
3069 3069 def test_put_update_should_send_a_notification
3070 3070 @request.session[:user_id] = 2
3071 3071 ActionMailer::Base.deliveries.clear
3072 3072 issue = Issue.find(1)
3073 3073 old_subject = issue.subject
3074 3074 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
3075 3075
3076 3076 put :update, :id => 1, :issue => {:subject => new_subject,
3077 3077 :priority_id => '6',
3078 3078 :category_id => '1' # no change
3079 3079 }
3080 3080 assert_equal 1, ActionMailer::Base.deliveries.size
3081 3081 end
3082 3082
3083 3083 def test_put_update_with_invalid_spent_time_hours_only
3084 3084 @request.session[:user_id] = 2
3085 3085 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3086 3086
3087 3087 assert_no_difference('Journal.count') do
3088 3088 put :update,
3089 3089 :id => 1,
3090 3090 :issue => {:notes => notes},
3091 3091 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
3092 3092 end
3093 3093 assert_response :success
3094 3094 assert_template 'edit'
3095 3095
3096 3096 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3097 3097 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3098 3098 assert_select 'input[name=?][value=?]', 'time_entry[hours]', '2z'
3099 3099 end
3100 3100
3101 3101 def test_put_update_with_invalid_spent_time_comments_only
3102 3102 @request.session[:user_id] = 2
3103 3103 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3104 3104
3105 3105 assert_no_difference('Journal.count') do
3106 3106 put :update,
3107 3107 :id => 1,
3108 3108 :issue => {:notes => notes},
3109 3109 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
3110 3110 end
3111 3111 assert_response :success
3112 3112 assert_template 'edit'
3113 3113
3114 3114 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3115 3115 assert_error_tag :descendant => {:content => /Hours can&#x27;t be blank/}
3116 3116 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3117 3117 assert_select 'input[name=?][value=?]', 'time_entry[comments]', 'this is my comment'
3118 3118 end
3119 3119
3120 3120 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
3121 3121 issue = Issue.find(2)
3122 3122 @request.session[:user_id] = 2
3123 3123
3124 3124 put :update,
3125 3125 :id => issue.id,
3126 3126 :issue => {
3127 3127 :fixed_version_id => 4
3128 3128 }
3129 3129
3130 3130 assert_response :redirect
3131 3131 issue.reload
3132 3132 assert_equal 4, issue.fixed_version_id
3133 3133 assert_not_equal issue.project_id, issue.fixed_version.project_id
3134 3134 end
3135 3135
3136 3136 def test_put_update_should_redirect_back_using_the_back_url_parameter
3137 3137 issue = Issue.find(2)
3138 3138 @request.session[:user_id] = 2
3139 3139
3140 3140 put :update,
3141 3141 :id => issue.id,
3142 3142 :issue => {
3143 3143 :fixed_version_id => 4
3144 3144 },
3145 3145 :back_url => '/issues'
3146 3146
3147 3147 assert_response :redirect
3148 3148 assert_redirected_to '/issues'
3149 3149 end
3150 3150
3151 3151 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3152 3152 issue = Issue.find(2)
3153 3153 @request.session[:user_id] = 2
3154 3154
3155 3155 put :update,
3156 3156 :id => issue.id,
3157 3157 :issue => {
3158 3158 :fixed_version_id => 4
3159 3159 },
3160 3160 :back_url => 'http://google.com'
3161 3161
3162 3162 assert_response :redirect
3163 3163 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
3164 3164 end
3165 3165
3166 3166 def test_get_bulk_edit
3167 3167 @request.session[:user_id] = 2
3168 3168 get :bulk_edit, :ids => [1, 2]
3169 3169 assert_response :success
3170 3170 assert_template 'bulk_edit'
3171 3171
3172 3172 assert_select 'ul#bulk-selection' do
3173 3173 assert_select 'li', 2
3174 3174 assert_select 'li a', :text => 'Bug #1'
3175 3175 end
3176 3176
3177 3177 assert_select 'form#bulk_edit_form[action=?]', '/issues/bulk_update' do
3178 3178 assert_select 'input[name=?]', 'ids[]', 2
3179 3179 assert_select 'input[name=?][value=1][type=hidden]', 'ids[]'
3180 3180
3181 3181 assert_select 'select[name=?]', 'issue[project_id]'
3182 3182 assert_select 'input[name=?]', 'issue[parent_issue_id]'
3183 3183
3184 3184 # Project specific custom field, date type
3185 3185 field = CustomField.find(9)
3186 3186 assert !field.is_for_all?
3187 3187 assert_equal 'date', field.field_format
3188 3188 assert_select 'input[name=?]', 'issue[custom_field_values][9]'
3189 3189
3190 3190 # System wide custom field
3191 3191 assert CustomField.find(1).is_for_all?
3192 3192 assert_select 'select[name=?]', 'issue[custom_field_values][1]'
3193 3193
3194 3194 # Be sure we don't display inactive IssuePriorities
3195 3195 assert ! IssuePriority.find(15).active?
3196 3196 assert_select 'select[name=?]', 'issue[priority_id]' do
3197 3197 assert_select 'option[value=15]', 0
3198 3198 end
3199 3199 end
3200 3200 end
3201 3201
3202 3202 def test_get_bulk_edit_on_different_projects
3203 3203 @request.session[:user_id] = 2
3204 3204 get :bulk_edit, :ids => [1, 2, 6]
3205 3205 assert_response :success
3206 3206 assert_template 'bulk_edit'
3207 3207
3208 3208 # Can not set issues from different projects as children of an issue
3209 3209 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
3210 3210
3211 3211 # Project specific custom field, date type
3212 3212 field = CustomField.find(9)
3213 3213 assert !field.is_for_all?
3214 3214 assert !field.project_ids.include?(Issue.find(6).project_id)
3215 3215 assert_select 'input[name=?]', 'issue[custom_field_values][9]', 0
3216 3216 end
3217 3217
3218 3218 def test_get_bulk_edit_with_user_custom_field
3219 3219 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
3220 3220
3221 3221 @request.session[:user_id] = 2
3222 3222 get :bulk_edit, :ids => [1, 2]
3223 3223 assert_response :success
3224 3224 assert_template 'bulk_edit'
3225 3225
3226 3226 assert_select 'select.user_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3227 3227 assert_select 'option', Project.find(1).users.count + 2 # "no change" + "none" options
3228 3228 end
3229 3229 end
3230 3230
3231 3231 def test_get_bulk_edit_with_version_custom_field
3232 3232 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
3233 3233
3234 3234 @request.session[:user_id] = 2
3235 3235 get :bulk_edit, :ids => [1, 2]
3236 3236 assert_response :success
3237 3237 assert_template 'bulk_edit'
3238 3238
3239 3239 assert_select 'select.version_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3240 3240 assert_select 'option', Project.find(1).shared_versions.count + 2 # "no change" + "none" options
3241 3241 end
3242 3242 end
3243 3243
3244 3244 def test_get_bulk_edit_with_multi_custom_field
3245 3245 field = CustomField.find(1)
3246 3246 field.update_attribute :multiple, true
3247 3247
3248 3248 @request.session[:user_id] = 2
3249 3249 get :bulk_edit, :ids => [1, 2]
3250 3250 assert_response :success
3251 3251 assert_template 'bulk_edit'
3252 3252
3253 3253 assert_select 'select[name=?]', 'issue[custom_field_values][1][]' do
3254 3254 assert_select 'option', field.possible_values.size + 1 # "none" options
3255 3255 end
3256 3256 end
3257 3257
3258 3258 def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
3259 3259 WorkflowTransition.delete_all
3260 3260 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 1)
3261 3261 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
3262 3262 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
3263 3263 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
3264 3264 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
3265 3265 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
3266 3266 @request.session[:user_id] = 2
3267 3267 get :bulk_edit, :ids => [1, 2]
3268 3268
3269 3269 assert_response :success
3270 3270 statuses = assigns(:available_statuses)
3271 3271 assert_not_nil statuses
3272 3272 assert_equal [1, 3], statuses.map(&:id).sort
3273 3273
3274 3274 assert_select 'select[name=?]', 'issue[status_id]' do
3275 3275 assert_select 'option', 3 # 2 statuses + "no change" option
3276 3276 end
3277 3277 end
3278 3278
3279 3279 def test_bulk_edit_should_propose_target_project_open_shared_versions
3280 3280 @request.session[:user_id] = 2
3281 3281 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3282 3282 assert_response :success
3283 3283 assert_template 'bulk_edit'
3284 3284 assert_equal Project.find(1).shared_versions.open.all.sort, assigns(:versions).sort
3285 3285
3286 3286 assert_select 'select[name=?]', 'issue[fixed_version_id]' do
3287 3287 assert_select 'option', :text => '2.0'
3288 3288 end
3289 3289 end
3290 3290
3291 3291 def test_bulk_edit_should_propose_target_project_categories
3292 3292 @request.session[:user_id] = 2
3293 3293 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3294 3294 assert_response :success
3295 3295 assert_template 'bulk_edit'
3296 3296 assert_equal Project.find(1).issue_categories.sort, assigns(:categories).sort
3297 3297
3298 3298 assert_select 'select[name=?]', 'issue[category_id]' do
3299 3299 assert_select 'option', :text => 'Recipes'
3300 3300 end
3301 3301 end
3302 3302
3303 3303 def test_bulk_update
3304 3304 @request.session[:user_id] = 2
3305 3305 # update issues priority
3306 3306 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3307 3307 :issue => {:priority_id => 7,
3308 3308 :assigned_to_id => '',
3309 3309 :custom_field_values => {'2' => ''}}
3310 3310
3311 3311 assert_response 302
3312 3312 # check that the issues were updated
3313 3313 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
3314 3314
3315 3315 issue = Issue.find(1)
3316 3316 journal = issue.journals.reorder('created_on DESC').first
3317 3317 assert_equal '125', issue.custom_value_for(2).value
3318 3318 assert_equal 'Bulk editing', journal.notes
3319 3319 assert_equal 1, journal.details.size
3320 3320 end
3321 3321
3322 3322 def test_bulk_update_with_group_assignee
3323 3323 group = Group.find(11)
3324 3324 project = Project.find(1)
3325 3325 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
3326 3326
3327 3327 @request.session[:user_id] = 2
3328 3328 # update issues assignee
3329 3329 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3330 3330 :issue => {:priority_id => '',
3331 3331 :assigned_to_id => group.id,
3332 3332 :custom_field_values => {'2' => ''}}
3333 3333
3334 3334 assert_response 302
3335 3335 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
3336 3336 end
3337 3337
3338 3338 def test_bulk_update_on_different_projects
3339 3339 @request.session[:user_id] = 2
3340 3340 # update issues priority
3341 3341 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
3342 3342 :issue => {:priority_id => 7,
3343 3343 :assigned_to_id => '',
3344 3344 :custom_field_values => {'2' => ''}}
3345 3345
3346 3346 assert_response 302
3347 3347 # check that the issues were updated
3348 3348 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
3349 3349
3350 3350 issue = Issue.find(1)
3351 3351 journal = issue.journals.reorder('created_on DESC').first
3352 3352 assert_equal '125', issue.custom_value_for(2).value
3353 3353 assert_equal 'Bulk editing', journal.notes
3354 3354 assert_equal 1, journal.details.size
3355 3355 end
3356 3356
3357 3357 def test_bulk_update_on_different_projects_without_rights
3358 3358 @request.session[:user_id] = 3
3359 3359 user = User.find(3)
3360 3360 action = { :controller => "issues", :action => "bulk_update" }
3361 3361 assert user.allowed_to?(action, Issue.find(1).project)
3362 3362 assert ! user.allowed_to?(action, Issue.find(6).project)
3363 3363 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
3364 3364 :issue => {:priority_id => 7,
3365 3365 :assigned_to_id => '',
3366 3366 :custom_field_values => {'2' => ''}}
3367 3367 assert_response 403
3368 3368 assert_not_equal "Bulk should fail", Journal.last.notes
3369 3369 end
3370 3370
3371 3371 def test_bullk_update_should_send_a_notification
3372 3372 @request.session[:user_id] = 2
3373 3373 ActionMailer::Base.deliveries.clear
3374 3374 post(:bulk_update,
3375 3375 {
3376 3376 :ids => [1, 2],
3377 3377 :notes => 'Bulk editing',
3378 3378 :issue => {
3379 3379 :priority_id => 7,
3380 3380 :assigned_to_id => '',
3381 3381 :custom_field_values => {'2' => ''}
3382 3382 }
3383 3383 })
3384 3384
3385 3385 assert_response 302
3386 3386 assert_equal 2, ActionMailer::Base.deliveries.size
3387 3387 end
3388 3388
3389 3389 def test_bulk_update_project
3390 3390 @request.session[:user_id] = 2
3391 3391 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
3392 3392 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3393 3393 # Issues moved to project 2
3394 3394 assert_equal 2, Issue.find(1).project_id
3395 3395 assert_equal 2, Issue.find(2).project_id
3396 3396 # No tracker change
3397 3397 assert_equal 1, Issue.find(1).tracker_id
3398 3398 assert_equal 2, Issue.find(2).tracker_id
3399 3399 end
3400 3400
3401 3401 def test_bulk_update_project_on_single_issue_should_follow_when_needed
3402 3402 @request.session[:user_id] = 2
3403 3403 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
3404 3404 assert_redirected_to '/issues/1'
3405 3405 end
3406 3406
3407 3407 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
3408 3408 @request.session[:user_id] = 2
3409 3409 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
3410 3410 assert_redirected_to '/projects/onlinestore/issues'
3411 3411 end
3412 3412
3413 3413 def test_bulk_update_tracker
3414 3414 @request.session[:user_id] = 2
3415 3415 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
3416 3416 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3417 3417 assert_equal 2, Issue.find(1).tracker_id
3418 3418 assert_equal 2, Issue.find(2).tracker_id
3419 3419 end
3420 3420
3421 3421 def test_bulk_update_status
3422 3422 @request.session[:user_id] = 2
3423 3423 # update issues priority
3424 3424 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
3425 3425 :issue => {:priority_id => '',
3426 3426 :assigned_to_id => '',
3427 3427 :status_id => '5'}
3428 3428
3429 3429 assert_response 302
3430 3430 issue = Issue.find(1)
3431 3431 assert issue.closed?
3432 3432 end
3433 3433
3434 3434 def test_bulk_update_priority
3435 3435 @request.session[:user_id] = 2
3436 3436 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3437 3437
3438 3438 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3439 3439 assert_equal 6, Issue.find(1).priority_id
3440 3440 assert_equal 6, Issue.find(2).priority_id
3441 3441 end
3442 3442
3443 3443 def test_bulk_update_with_notes
3444 3444 @request.session[:user_id] = 2
3445 3445 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
3446 3446
3447 3447 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3448 3448 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
3449 3449 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
3450 3450 end
3451 3451
3452 3452 def test_bulk_update_parent_id
3453 3453 @request.session[:user_id] = 2
3454 3454 post :bulk_update, :ids => [1, 3],
3455 3455 :notes => 'Bulk editing parent',
3456 3456 :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
3457 3457
3458 3458 assert_response 302
3459 3459 parent = Issue.find(2)
3460 3460 assert_equal parent.id, Issue.find(1).parent_id
3461 3461 assert_equal parent.id, Issue.find(3).parent_id
3462 3462 assert_equal [1, 3], parent.children.collect(&:id).sort
3463 3463 end
3464 3464
3465 3465 def test_bulk_update_custom_field
3466 3466 @request.session[:user_id] = 2
3467 3467 # update issues priority
3468 3468 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
3469 3469 :issue => {:priority_id => '',
3470 3470 :assigned_to_id => '',
3471 3471 :custom_field_values => {'2' => '777'}}
3472 3472
3473 3473 assert_response 302
3474 3474
3475 3475 issue = Issue.find(1)
3476 3476 journal = issue.journals.reorder('created_on DESC').first
3477 3477 assert_equal '777', issue.custom_value_for(2).value
3478 3478 assert_equal 1, journal.details.size
3479 3479 assert_equal '125', journal.details.first.old_value
3480 3480 assert_equal '777', journal.details.first.value
3481 3481 end
3482 3482
3483 3483 def test_bulk_update_custom_field_to_blank
3484 3484 @request.session[:user_id] = 2
3485 3485 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing custom field',
3486 3486 :issue => {:priority_id => '',
3487 3487 :assigned_to_id => '',
3488 3488 :custom_field_values => {'1' => '__none__'}}
3489 3489 assert_response 302
3490 3490 assert_equal '', Issue.find(1).custom_field_value(1)
3491 3491 assert_equal '', Issue.find(3).custom_field_value(1)
3492 3492 end
3493 3493
3494 3494 def test_bulk_update_multi_custom_field
3495 3495 field = CustomField.find(1)
3496 3496 field.update_attribute :multiple, true
3497 3497
3498 3498 @request.session[:user_id] = 2
3499 3499 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
3500 3500 :issue => {:priority_id => '',
3501 3501 :assigned_to_id => '',
3502 3502 :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
3503 3503
3504 3504 assert_response 302
3505 3505
3506 3506 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
3507 3507 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
3508 3508 # the custom field is not associated with the issue tracker
3509 3509 assert_nil Issue.find(2).custom_field_value(1)
3510 3510 end
3511 3511
3512 3512 def test_bulk_update_multi_custom_field_to_blank
3513 3513 field = CustomField.find(1)
3514 3514 field.update_attribute :multiple, true
3515 3515
3516 3516 @request.session[:user_id] = 2
3517 3517 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing multi custom field',
3518 3518 :issue => {:priority_id => '',
3519 3519 :assigned_to_id => '',
3520 3520 :custom_field_values => {'1' => ['__none__']}}
3521 3521 assert_response 302
3522 3522 assert_equal [''], Issue.find(1).custom_field_value(1)
3523 3523 assert_equal [''], Issue.find(3).custom_field_value(1)
3524 3524 end
3525 3525
3526 3526 def test_bulk_update_unassign
3527 3527 assert_not_nil Issue.find(2).assigned_to
3528 3528 @request.session[:user_id] = 2
3529 3529 # unassign issues
3530 3530 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
3531 3531 assert_response 302
3532 3532 # check that the issues were updated
3533 3533 assert_nil Issue.find(2).assigned_to
3534 3534 end
3535 3535
3536 3536 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
3537 3537 @request.session[:user_id] = 2
3538 3538
3539 3539 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
3540 3540
3541 3541 assert_response :redirect
3542 3542 issues = Issue.find([1,2])
3543 3543 issues.each do |issue|
3544 3544 assert_equal 4, issue.fixed_version_id
3545 3545 assert_not_equal issue.project_id, issue.fixed_version.project_id
3546 3546 end
3547 3547 end
3548 3548
3549 3549 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
3550 3550 @request.session[:user_id] = 2
3551 3551 post :bulk_update, :ids => [1,2], :back_url => '/issues'
3552 3552
3553 3553 assert_response :redirect
3554 3554 assert_redirected_to '/issues'
3555 3555 end
3556 3556
3557 3557 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3558 3558 @request.session[:user_id] = 2
3559 3559 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
3560 3560
3561 3561 assert_response :redirect
3562 3562 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
3563 3563 end
3564 3564
3565 3565 def test_bulk_update_with_failure_should_set_flash
3566 3566 @request.session[:user_id] = 2
3567 3567 Issue.update_all("subject = ''", "id = 2") # Make it invalid
3568 3568 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3569 3569
3570 3570 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3571 3571 assert_equal 'Failed to save 1 issue(s) on 2 selected: #2.', flash[:error]
3572 3572 end
3573 3573
3574 3574 def test_get_bulk_copy
3575 3575 @request.session[:user_id] = 2
3576 3576 get :bulk_edit, :ids => [1, 2, 3], :copy => '1'
3577 3577 assert_response :success
3578 3578 assert_template 'bulk_edit'
3579 3579
3580 3580 issues = assigns(:issues)
3581 3581 assert_not_nil issues
3582 3582 assert_equal [1, 2, 3], issues.map(&:id).sort
3583 3583
3584 3584 assert_select 'input[name=copy_attachments]'
3585 3585 end
3586 3586
3587 3587 def test_bulk_copy_to_another_project
3588 3588 @request.session[:user_id] = 2
3589 3589 assert_difference 'Issue.count', 2 do
3590 3590 assert_no_difference 'Project.find(1).issues.count' do
3591 3591 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
3592 3592 end
3593 3593 end
3594 3594 assert_redirected_to '/projects/ecookbook/issues'
3595 3595
3596 3596 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3597 3597 copies.each do |copy|
3598 3598 assert_equal 2, copy.project_id
3599 3599 end
3600 3600 end
3601 3601
3602 3602 def test_bulk_copy_should_allow_not_changing_the_issue_attributes
3603 3603 @request.session[:user_id] = 2
3604 3604 issues = [
3605 3605 Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 1, :priority_id => 2, :subject => 'issue 1', :author_id => 1, :assigned_to_id => nil),
3606 3606 Issue.create!(:project_id => 2, :tracker_id => 3, :status_id => 2, :priority_id => 1, :subject => 'issue 2', :author_id => 2, :assigned_to_id => 3)
3607 3607 ]
3608 3608
3609 3609 assert_difference 'Issue.count', issues.size do
3610 3610 post :bulk_update, :ids => issues.map(&:id), :copy => '1',
3611 3611 :issue => {
3612 3612 :project_id => '', :tracker_id => '', :assigned_to_id => '',
3613 3613 :status_id => '', :start_date => '', :due_date => ''
3614 3614 }
3615 3615 end
3616 3616
3617 3617 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3618 3618 issues.each do |orig|
3619 3619 copy = copies.detect {|c| c.subject == orig.subject}
3620 3620 assert_not_nil copy
3621 3621 assert_equal orig.project_id, copy.project_id
3622 3622 assert_equal orig.tracker_id, copy.tracker_id
3623 3623 assert_equal orig.status_id, copy.status_id
3624 3624 assert_equal orig.assigned_to_id, copy.assigned_to_id
3625 3625 assert_equal orig.priority_id, copy.priority_id
3626 3626 end
3627 3627 end
3628 3628
3629 3629 def test_bulk_copy_should_allow_changing_the_issue_attributes
3630 3630 # Fixes random test failure with Mysql
3631 3631 # where Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3632 3632 # doesn't return the expected results
3633 3633 Issue.delete_all("project_id=2")
3634 3634
3635 3635 @request.session[:user_id] = 2
3636 3636 assert_difference 'Issue.count', 2 do
3637 3637 assert_no_difference 'Project.find(1).issues.count' do
3638 3638 post :bulk_update, :ids => [1, 2], :copy => '1',
3639 3639 :issue => {
3640 3640 :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
3641 3641 :status_id => '1', :start_date => '2009-12-01', :due_date => '2009-12-31'
3642 3642 }
3643 3643 end
3644 3644 end
3645 3645
3646 3646 copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3647 3647 assert_equal 2, copied_issues.size
3648 3648 copied_issues.each do |issue|
3649 3649 assert_equal 2, issue.project_id, "Project is incorrect"
3650 3650 assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
3651 3651 assert_equal 1, issue.status_id, "Status is incorrect"
3652 3652 assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
3653 3653 assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
3654 3654 end
3655 3655 end
3656 3656
3657 3657 def test_bulk_copy_should_allow_adding_a_note
3658 3658 @request.session[:user_id] = 2
3659 3659 assert_difference 'Issue.count', 1 do
3660 3660 post :bulk_update, :ids => [1], :copy => '1',
3661 3661 :notes => 'Copying one issue',
3662 3662 :issue => {
3663 3663 :project_id => '', :tracker_id => '', :assigned_to_id => '4',
3664 3664 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
3665 3665 }
3666 3666 end
3667 3667
3668 3668 issue = Issue.first(:order => 'id DESC')
3669 3669 assert_equal 1, issue.journals.size
3670 3670 journal = issue.journals.first
3671 3671 assert_equal 0, journal.details.size
3672 3672 assert_equal 'Copying one issue', journal.notes
3673 3673 end
3674 3674
3675 3675 def test_bulk_copy_should_allow_not_copying_the_attachments
3676 3676 attachment_count = Issue.find(3).attachments.size
3677 3677 assert attachment_count > 0
3678 3678 @request.session[:user_id] = 2
3679 3679
3680 3680 assert_difference 'Issue.count', 1 do
3681 3681 assert_no_difference 'Attachment.count' do
3682 3682 post :bulk_update, :ids => [3], :copy => '1',
3683 3683 :issue => {
3684 3684 :project_id => ''
3685 3685 }
3686 3686 end
3687 3687 end
3688 3688 end
3689 3689
3690 3690 def test_bulk_copy_should_allow_copying_the_attachments
3691 3691 attachment_count = Issue.find(3).attachments.size
3692 3692 assert attachment_count > 0
3693 3693 @request.session[:user_id] = 2
3694 3694
3695 3695 assert_difference 'Issue.count', 1 do
3696 3696 assert_difference 'Attachment.count', attachment_count do
3697 3697 post :bulk_update, :ids => [3], :copy => '1', :copy_attachments => '1',
3698 3698 :issue => {
3699 3699 :project_id => ''
3700 3700 }
3701 3701 end
3702 3702 end
3703 3703 end
3704 3704
3705 3705 def test_bulk_copy_should_add_relations_with_copied_issues
3706 3706 @request.session[:user_id] = 2
3707 3707
3708 3708 assert_difference 'Issue.count', 2 do
3709 3709 assert_difference 'IssueRelation.count', 2 do
3710 3710 post :bulk_update, :ids => [1, 3], :copy => '1',
3711 3711 :issue => {
3712 3712 :project_id => '1'
3713 3713 }
3714 3714 end
3715 3715 end
3716 3716 end
3717 3717
3718 3718 def test_bulk_copy_should_allow_not_copying_the_subtasks
3719 3719 issue = Issue.generate_with_descendants!
3720 3720 @request.session[:user_id] = 2
3721 3721
3722 3722 assert_difference 'Issue.count', 1 do
3723 3723 post :bulk_update, :ids => [issue.id], :copy => '1',
3724 3724 :issue => {
3725 3725 :project_id => ''
3726 3726 }
3727 3727 end
3728 3728 end
3729 3729
3730 3730 def test_bulk_copy_should_allow_copying_the_subtasks
3731 3731 issue = Issue.generate_with_descendants!
3732 3732 count = issue.descendants.count
3733 3733 @request.session[:user_id] = 2
3734 3734
3735 3735 assert_difference 'Issue.count', count+1 do
3736 3736 post :bulk_update, :ids => [issue.id], :copy => '1', :copy_subtasks => '1',
3737 3737 :issue => {
3738 3738 :project_id => ''
3739 3739 }
3740 3740 end
3741 3741 copy = Issue.where(:parent_id => nil).order("id DESC").first
3742 3742 assert_equal count, copy.descendants.count
3743 3743 end
3744 3744
3745 3745 def test_bulk_copy_should_not_copy_selected_subtasks_twice
3746 3746 issue = Issue.generate_with_descendants!
3747 3747 count = issue.descendants.count
3748 3748 @request.session[:user_id] = 2
3749 3749
3750 3750 assert_difference 'Issue.count', count+1 do
3751 3751 post :bulk_update, :ids => issue.self_and_descendants.map(&:id), :copy => '1', :copy_subtasks => '1',
3752 3752 :issue => {
3753 3753 :project_id => ''
3754 3754 }
3755 3755 end
3756 3756 copy = Issue.where(:parent_id => nil).order("id DESC").first
3757 3757 assert_equal count, copy.descendants.count
3758 3758 end
3759 3759
3760 3760 def test_bulk_copy_to_another_project_should_follow_when_needed
3761 3761 @request.session[:user_id] = 2
3762 3762 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
3763 3763 issue = Issue.first(:order => 'id DESC')
3764 3764 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
3765 3765 end
3766 3766
3767 3767 def test_destroy_issue_with_no_time_entries
3768 3768 assert_nil TimeEntry.find_by_issue_id(2)
3769 3769 @request.session[:user_id] = 2
3770 3770
3771 3771 assert_difference 'Issue.count', -1 do
3772 3772 delete :destroy, :id => 2
3773 3773 end
3774 3774 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3775 3775 assert_nil Issue.find_by_id(2)
3776 3776 end
3777 3777
3778 3778 def test_destroy_issues_with_time_entries
3779 3779 @request.session[:user_id] = 2
3780 3780
3781 3781 assert_no_difference 'Issue.count' do
3782 3782 delete :destroy, :ids => [1, 3]
3783 3783 end
3784 3784 assert_response :success
3785 3785 assert_template 'destroy'
3786 3786 assert_not_nil assigns(:hours)
3787 3787 assert Issue.find_by_id(1) && Issue.find_by_id(3)
3788 3788
3789 3789 assert_select 'form' do
3790 3790 assert_select 'input[name=_method][value=delete]'
3791 3791 end
3792 3792 end
3793 3793
3794 3794 def test_destroy_issues_and_destroy_time_entries
3795 3795 @request.session[:user_id] = 2
3796 3796
3797 3797 assert_difference 'Issue.count', -2 do
3798 3798 assert_difference 'TimeEntry.count', -3 do
3799 3799 delete :destroy, :ids => [1, 3], :todo => 'destroy'
3800 3800 end
3801 3801 end
3802 3802 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3803 3803 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3804 3804 assert_nil TimeEntry.find_by_id([1, 2])
3805 3805 end
3806 3806
3807 3807 def test_destroy_issues_and_assign_time_entries_to_project
3808 3808 @request.session[:user_id] = 2
3809 3809
3810 3810 assert_difference 'Issue.count', -2 do
3811 3811 assert_no_difference 'TimeEntry.count' do
3812 3812 delete :destroy, :ids => [1, 3], :todo => 'nullify'
3813 3813 end
3814 3814 end
3815 3815 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3816 3816 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3817 3817 assert_nil TimeEntry.find(1).issue_id
3818 3818 assert_nil TimeEntry.find(2).issue_id
3819 3819 end
3820 3820
3821 3821 def test_destroy_issues_and_reassign_time_entries_to_another_issue
3822 3822 @request.session[:user_id] = 2
3823 3823
3824 3824 assert_difference 'Issue.count', -2 do
3825 3825 assert_no_difference 'TimeEntry.count' do
3826 3826 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
3827 3827 end
3828 3828 end
3829 3829 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3830 3830 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3831 3831 assert_equal 2, TimeEntry.find(1).issue_id
3832 3832 assert_equal 2, TimeEntry.find(2).issue_id
3833 3833 end
3834 3834
3835 3835 def test_destroy_issues_from_different_projects
3836 3836 @request.session[:user_id] = 2
3837 3837
3838 3838 assert_difference 'Issue.count', -3 do
3839 3839 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
3840 3840 end
3841 3841 assert_redirected_to :controller => 'issues', :action => 'index'
3842 3842 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
3843 3843 end
3844 3844
3845 3845 def test_destroy_parent_and_child_issues
3846 3846 parent = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Parent Issue')
3847 3847 child = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Child Issue', :parent_issue_id => parent.id)
3848 3848 assert child.is_descendant_of?(parent.reload)
3849 3849
3850 3850 @request.session[:user_id] = 2
3851 3851 assert_difference 'Issue.count', -2 do
3852 3852 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
3853 3853 end
3854 3854 assert_response 302
3855 3855 end
3856 3856
3857 3857 def test_destroy_invalid_should_respond_with_404
3858 3858 @request.session[:user_id] = 2
3859 3859 assert_no_difference 'Issue.count' do
3860 3860 delete :destroy, :id => 999
3861 3861 end
3862 3862 assert_response 404
3863 3863 end
3864 3864
3865 3865 def test_default_search_scope
3866 3866 get :index
3867 3867
3868 3868 assert_select 'div#quick-search form' do
3869 3869 assert_select 'input[name=issues][value=1][type=hidden]'
3870 3870 end
3871 3871 end
3872 3872 end
@@ -1,229 +1,220
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssuesTest < ActionController::IntegrationTest
21 21 fixtures :projects,
22 22 :users,
23 23 :roles,
24 24 :members,
25 25 :member_roles,
26 26 :trackers,
27 27 :projects_trackers,
28 28 :enabled_modules,
29 29 :issue_statuses,
30 30 :issues,
31 31 :enumerations,
32 32 :custom_fields,
33 33 :custom_values,
34 34 :custom_fields_trackers
35 35
36 36 # create an issue
37 37 def test_add_issue
38 38 log_user('jsmith', 'jsmith')
39 39 get 'projects/1/issues/new', :tracker_id => '1'
40 40 assert_response :success
41 41 assert_template 'issues/new'
42 42
43 43 post 'projects/1/issues', :tracker_id => "1",
44 44 :issue => { :start_date => "2006-12-26",
45 45 :priority_id => "4",
46 46 :subject => "new test issue",
47 47 :category_id => "",
48 48 :description => "new issue",
49 49 :done_ratio => "0",
50 50 :due_date => "",
51 51 :assigned_to_id => "" },
52 52 :custom_fields => {'2' => 'Value for field 2'}
53 53 # find created issue
54 54 issue = Issue.find_by_subject("new test issue")
55 55 assert_kind_of Issue, issue
56 56
57 57 # check redirection
58 58 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
59 59 follow_redirect!
60 60 assert_equal issue, assigns(:issue)
61 61
62 62 # check issue attributes
63 63 assert_equal 'jsmith', issue.author.login
64 64 assert_equal 1, issue.project.id
65 65 assert_equal 1, issue.status.id
66 66 end
67 67
68 def test_update_issue_form
69 log_user('jsmith', 'jsmith')
70 post 'projects/ecookbook/issues/new', :issue => { :tracker_id => "2"}
71 assert_response :success
72 assert_tag 'select',
73 :attributes => {:name => 'issue[tracker_id]'},
74 :child => {:tag => 'option', :attributes => {:value => '2', :selected => 'selected'}}
75 end
76
77 68 # add then remove 2 attachments to an issue
78 69 def test_issue_attachments
79 70 log_user('jsmith', 'jsmith')
80 71 set_tmp_attachments_directory
81 72
82 73 put 'issues/1',
83 74 :notes => 'Some notes',
84 75 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'This is an attachment'}}
85 76 assert_redirected_to "/issues/1"
86 77
87 78 # make sure attachment was saved
88 79 attachment = Issue.find(1).attachments.find_by_filename("testfile.txt")
89 80 assert_kind_of Attachment, attachment
90 81 assert_equal Issue.find(1), attachment.container
91 82 assert_equal 'This is an attachment', attachment.description
92 83 # verify the size of the attachment stored in db
93 84 #assert_equal file_data_1.length, attachment.filesize
94 85 # verify that the attachment was written to disk
95 86 assert File.exist?(attachment.diskfile)
96 87
97 88 # remove the attachments
98 89 Issue.find(1).attachments.each(&:destroy)
99 90 assert_equal 0, Issue.find(1).attachments.length
100 91 end
101 92
102 93 def test_other_formats_links_on_index
103 94 get '/projects/ecookbook/issues'
104 95
105 96 %w(Atom PDF CSV).each do |format|
106 97 assert_tag :a, :content => format,
107 98 :attributes => { :href => "/projects/ecookbook/issues.#{format.downcase}",
108 99 :rel => 'nofollow' }
109 100 end
110 101 end
111 102
112 103 def test_other_formats_links_on_index_without_project_id_in_url
113 104 get '/issues', :project_id => 'ecookbook'
114 105
115 106 %w(Atom PDF CSV).each do |format|
116 107 assert_tag :a, :content => format,
117 108 :attributes => { :href => "/projects/ecookbook/issues.#{format.downcase}",
118 109 :rel => 'nofollow' }
119 110 end
120 111 end
121 112
122 113 def test_pagination_links_on_index
123 114 Setting.per_page_options = '2'
124 115 get '/projects/ecookbook/issues'
125 116
126 117 assert_tag :a, :content => '2',
127 118 :attributes => { :href => '/projects/ecookbook/issues?page=2' }
128 119
129 120 end
130 121
131 122 def test_pagination_links_on_index_without_project_id_in_url
132 123 Setting.per_page_options = '2'
133 124 get '/issues', :project_id => 'ecookbook'
134 125
135 126 assert_tag :a, :content => '2',
136 127 :attributes => { :href => '/projects/ecookbook/issues?page=2' }
137 128
138 129 end
139 130
140 131 def test_issue_with_user_custom_field
141 132 @field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true, :trackers => Tracker.all)
142 133 Role.anonymous.add_permission! :add_issues, :edit_issues
143 134 users = Project.find(1).users
144 135 tester = users.first
145 136
146 137 # Issue form
147 138 get '/projects/ecookbook/issues/new'
148 139 assert_response :success
149 140 assert_tag :select,
150 141 :attributes => {:name => "issue[custom_field_values][#{@field.id}]"},
151 142 :children => {:count => (users.size + 1)}, # +1 for blank value
152 143 :child => {
153 144 :tag => 'option',
154 145 :attributes => {:value => tester.id.to_s},
155 146 :content => tester.name
156 147 }
157 148
158 149 # Create issue
159 150 assert_difference 'Issue.count' do
160 151 post '/projects/ecookbook/issues',
161 152 :issue => {
162 153 :tracker_id => '1',
163 154 :priority_id => '4',
164 155 :subject => 'Issue with user custom field',
165 156 :custom_field_values => {@field.id.to_s => users.first.id.to_s}
166 157 }
167 158 end
168 159 issue = Issue.first(:order => 'id DESC')
169 160 assert_response 302
170 161
171 162 # Issue view
172 163 follow_redirect!
173 164 assert_tag :th,
174 165 :content => /Tester/,
175 166 :sibling => {
176 167 :tag => 'td',
177 168 :content => tester.name
178 169 }
179 170 assert_tag :select,
180 171 :attributes => {:name => "issue[custom_field_values][#{@field.id}]"},
181 172 :children => {:count => (users.size + 1)}, # +1 for blank value
182 173 :child => {
183 174 :tag => 'option',
184 175 :attributes => {:value => tester.id.to_s, :selected => 'selected'},
185 176 :content => tester.name
186 177 }
187 178
188 179 # Update issue
189 180 new_tester = users[1]
190 181 assert_difference 'Journal.count' do
191 182 put "/issues/#{issue.id}",
192 183 :notes => 'Updating custom field',
193 184 :issue => {
194 185 :custom_field_values => {@field.id.to_s => new_tester.id.to_s}
195 186 }
196 187 end
197 188 assert_response 302
198 189
199 190 # Issue view
200 191 follow_redirect!
201 192 assert_tag :content => 'Tester',
202 193 :ancestor => {:tag => 'ul', :attributes => {:class => /details/}},
203 194 :sibling => {
204 195 :content => tester.name,
205 196 :sibling => {
206 197 :content => new_tester.name
207 198 }
208 199 }
209 200 end
210 201
211 202 def test_update_using_invalid_http_verbs
212 203 subject = 'Updated by an invalid http verb'
213 204
214 205 get '/issues/update/1', {:issue => {:subject => subject}}, credentials('jsmith')
215 206 assert_response 404
216 207 assert_not_equal subject, Issue.find(1).subject
217 208
218 209 post '/issues/1', {:issue => {:subject => subject}}, credentials('jsmith')
219 210 assert_response 404
220 211 assert_not_equal subject, Issue.find(1).subject
221 212 end
222 213
223 214 def test_get_watch_should_be_invalid
224 215 assert_no_difference 'Watcher.count' do
225 216 get '/watchers/watch?object_type=issue&object_id=1', {}, credentials('jsmith')
226 217 assert_response 404
227 218 end
228 219 end
229 220 end
@@ -1,134 +1,134
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../../test_helper', __FILE__)
19 19
20 20 class RoutingIssuesTest < ActionController::IntegrationTest
21 21 def test_issues_rest_actions
22 22 assert_routing(
23 23 { :method => 'get', :path => "/issues" },
24 24 { :controller => 'issues', :action => 'index' }
25 25 )
26 26 assert_routing(
27 27 { :method => 'get', :path => "/issues.pdf" },
28 28 { :controller => 'issues', :action => 'index', :format => 'pdf' }
29 29 )
30 30 assert_routing(
31 31 { :method => 'get', :path => "/issues.atom" },
32 32 { :controller => 'issues', :action => 'index', :format => 'atom' }
33 33 )
34 34 assert_routing(
35 35 { :method => 'get', :path => "/issues.xml" },
36 36 { :controller => 'issues', :action => 'index', :format => 'xml' }
37 37 )
38 38 assert_routing(
39 39 { :method => 'get', :path => "/issues/64" },
40 40 { :controller => 'issues', :action => 'show', :id => '64' }
41 41 )
42 42 assert_routing(
43 43 { :method => 'get', :path => "/issues/64.pdf" },
44 44 { :controller => 'issues', :action => 'show', :id => '64',
45 45 :format => 'pdf' }
46 46 )
47 47 assert_routing(
48 48 { :method => 'get', :path => "/issues/64.atom" },
49 49 { :controller => 'issues', :action => 'show', :id => '64',
50 50 :format => 'atom' }
51 51 )
52 52 assert_routing(
53 53 { :method => 'get', :path => "/issues/64.xml" },
54 54 { :controller => 'issues', :action => 'show', :id => '64',
55 55 :format => 'xml' }
56 56 )
57 57 assert_routing(
58 58 { :method => 'post', :path => "/issues.xml" },
59 59 { :controller => 'issues', :action => 'create', :format => 'xml' }
60 60 )
61 61 assert_routing(
62 62 { :method => 'get', :path => "/issues/64/edit" },
63 63 { :controller => 'issues', :action => 'edit', :id => '64' }
64 64 )
65 65 assert_routing(
66 66 { :method => 'put', :path => "/issues/1.xml" },
67 67 { :controller => 'issues', :action => 'update', :id => '1',
68 68 :format => 'xml' }
69 69 )
70 70 assert_routing(
71 71 { :method => 'delete', :path => "/issues/1.xml" },
72 72 { :controller => 'issues', :action => 'destroy', :id => '1',
73 73 :format => 'xml' }
74 74 )
75 75 end
76 76
77 77 def test_issues_rest_actions_scoped_under_project
78 78 assert_routing(
79 79 { :method => 'get', :path => "/projects/23/issues" },
80 80 { :controller => 'issues', :action => 'index', :project_id => '23' }
81 81 )
82 82 assert_routing(
83 83 { :method => 'get', :path => "/projects/23/issues.pdf" },
84 84 { :controller => 'issues', :action => 'index', :project_id => '23',
85 85 :format => 'pdf' }
86 86 )
87 87 assert_routing(
88 88 { :method => 'get', :path => "/projects/23/issues.atom" },
89 89 { :controller => 'issues', :action => 'index', :project_id => '23',
90 90 :format => 'atom' }
91 91 )
92 92 assert_routing(
93 93 { :method => 'get', :path => "/projects/23/issues.xml" },
94 94 { :controller => 'issues', :action => 'index', :project_id => '23',
95 95 :format => 'xml' }
96 96 )
97 97 assert_routing(
98 98 { :method => 'post', :path => "/projects/23/issues" },
99 99 { :controller => 'issues', :action => 'create', :project_id => '23' }
100 100 )
101 101 assert_routing(
102 102 { :method => 'get', :path => "/projects/23/issues/new" },
103 103 { :controller => 'issues', :action => 'new', :project_id => '23' }
104 104 )
105 105 end
106 106
107 107 def test_issues_form_update
108 108 ["post", "put"].each do |method|
109 109 assert_routing(
110 { :method => method, :path => "/projects/23/issues/new" },
111 { :controller => 'issues', :action => 'new', :project_id => '23' }
110 { :method => method, :path => "/projects/23/issues/update_form" },
111 { :controller => 'issues', :action => 'update_form', :project_id => '23' }
112 112 )
113 113 end
114 114 end
115 115
116 116 def test_issues_extra_actions
117 117 assert_routing(
118 118 { :method => 'get', :path => "/projects/23/issues/64/copy" },
119 119 { :controller => 'issues', :action => 'new', :project_id => '23',
120 120 :copy_from => '64' }
121 121 )
122 122 # For updating the bulk edit form
123 123 ["get", "post"].each do |method|
124 124 assert_routing(
125 125 { :method => method, :path => "/issues/bulk_edit" },
126 126 { :controller => 'issues', :action => 'bulk_edit' }
127 127 )
128 128 end
129 129 assert_routing(
130 130 { :method => 'post', :path => "/issues/bulk_update" },
131 131 { :controller => 'issues', :action => 'bulk_update' }
132 132 )
133 133 end
134 134 end
@@ -1,128 +1,186
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../base', __FILE__)
19 19
20 20 class Redmine::UiTest::IssuesTest < Redmine::UiTest::Base
21 21 fixtures :projects, :users, :roles, :members, :member_roles,
22 22 :trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues,
23 23 :enumerations, :custom_fields, :custom_values, :custom_fields_trackers,
24 24 :watchers
25 25
26 26 def test_create_issue
27 27 log_user('jsmith', 'jsmith')
28 28 visit '/projects/ecookbook/issues/new'
29 29 within('form#issue-form') do
30 30 select 'Bug', :from => 'Tracker'
31 31 select 'Low', :from => 'Priority'
32 32 fill_in 'Subject', :with => 'new test issue'
33 33 fill_in 'Description', :with => 'new issue'
34 34 select '0 %', :from => 'Done'
35 35 fill_in 'Due date', :with => ''
36 36 select '', :from => 'Assignee'
37 37 fill_in 'Searchable field', :with => 'Value for field 2'
38 38 # click_button 'Create' would match both 'Create' and 'Create and continue' buttons
39 39 find('input[name=commit]').click
40 40 end
41 41
42 42 # find created issue
43 43 issue = Issue.find_by_subject("new test issue")
44 44 assert_kind_of Issue, issue
45 45
46 46 # check redirection
47 47 find 'div#flash_notice', :visible => true, :text => "Issue \##{issue.id} created."
48 48 assert_equal issue_path(:id => issue), current_path
49 49
50 50 # check issue attributes
51 51 assert_equal 'jsmith', issue.author.login
52 52 assert_equal 1, issue.project.id
53 53 assert_equal IssueStatus.find_by_name('New'), issue.status
54 54 assert_equal Tracker.find_by_name('Bug'), issue.tracker
55 55 assert_equal IssuePriority.find_by_name('Low'), issue.priority
56 56 assert_equal 'Value for field 2', issue.custom_field_value(CustomField.find_by_name('Searchable field'))
57 57 end
58 58
59 def test_create_issue_with_form_update
60 field = IssueCustomField.create!(
61 :field_format => 'string',
62 :name => 'Form update CF',
63 :is_for_all => true,
64 :trackers => Tracker.find_all_by_name('Feature request')
65 )
66
67 Role.non_member.add_permission! :add_issues
68 Role.non_member.remove_permission! :edit_issues, :add_issue_notes
69
70 log_user('someone', 'foo')
71 visit '/projects/ecookbook/issues/new'
72 assert page.has_no_content?('Form update CF')
73
74 fill_in 'Subject', :with => 'new test issue'
75 # the custom field should show up when changing tracker
76 select 'Feature request', :from => 'Tracker'
77 assert page.has_content?('Form update CF')
78
79 fill_in 'Form update', :with => 'CF value'
80 assert_difference 'Issue.count' do
81 find('input[name=commit]').click
82 end
83
84 issue = Issue.order('id desc').first
85 assert_equal 'CF value', issue.custom_field_value(field)
86 end
87
59 88 def test_create_issue_with_watchers
60 89 User.generate!(:firstname => 'Some', :lastname => 'Watcher')
61 90
62 91 log_user('jsmith', 'jsmith')
63 92 visit '/projects/ecookbook/issues/new'
64 93 fill_in 'Subject', :with => 'Issue with watchers'
65 94 # Add a project member as watcher
66 95 check 'Dave Lopper'
67 96 # Search for another user
68 97 click_link 'Search for watchers to add'
69 98 within('form#new-watcher-form') do
70 99 assert page.has_content?('Some One')
71 100 fill_in 'user_search', :with => 'watch'
72 101 assert page.has_no_content?('Some One')
73 102 check 'Some Watcher'
74 103 click_button 'Add'
75 104 end
76 105 assert_difference 'Issue.count' do
77 106 find('input[name=commit]').click
78 107 end
79 108
80 109 issue = Issue.order('id desc').first
81 110 assert_equal ['Dave Lopper', 'Some Watcher'], issue.watcher_users.map(&:name).sort
82 111 end
83 112
84 113 def test_preview_issue_description
85 114 log_user('jsmith', 'jsmith')
86 115 visit '/projects/ecookbook/issues/new'
87 116 within('form#issue-form') do
88 117 fill_in 'Subject', :with => 'new issue subject'
89 118 fill_in 'Description', :with => 'new issue description'
90 119 click_link 'Preview'
91 120 end
92 121 find 'div#preview fieldset', :visible => true, :text => 'new issue description'
93 122 assert_difference 'Issue.count' do
94 123 find('input[name=commit]').click
95 124 end
96 125
97 126 issue = Issue.order('id desc').first
98 127 assert_equal 'new issue description', issue.description
99 128 end
100 129
130 def test_update_issue_with_form_update
131 field = IssueCustomField.create!(
132 :field_format => 'string',
133 :name => 'Form update CF',
134 :is_for_all => true,
135 :trackers => Tracker.find_all_by_name('Feature request')
136 )
137
138 Role.non_member.add_permission! :edit_issues
139 Role.non_member.remove_permission! :add_issues, :add_issue_notes
140
141 log_user('someone', 'foo')
142 visit '/issues/1'
143 assert page.has_no_content?('Form update CF')
144
145 page.first(:link, 'Update').click
146 # the custom field should show up when changing tracker
147 select 'Feature request', :from => 'Tracker'
148 assert page.has_content?('Form update CF')
149
150 fill_in 'Form update', :with => 'CF value'
151 assert_no_difference 'Issue.count' do
152 page.first(:button, 'Submit').click
153 end
154
155 issue = Issue.find(1)
156 assert_equal 'CF value', issue.custom_field_value(field)
157 end
158
101 159 def test_watch_issue_via_context_menu
102 160 log_user('jsmith', 'jsmith')
103 161 visit '/issues'
104 162 find('tr#issue-1 td.updated_on').click
105 163 page.execute_script "$('tr#issue-1 td.updated_on').trigger('contextmenu');"
106 164 assert_difference 'Watcher.count' do
107 165 within('#context-menu') do
108 166 click_link 'Watch'
109 167 end
110 168 end
111 169 assert Issue.find(1).watched_by?(User.find_by_login('jsmith'))
112 170 end
113 171
114 172 def test_bulk_watch_issues_via_context_menu
115 173 log_user('jsmith', 'jsmith')
116 174 visit '/issues'
117 175 find('tr#issue-1 input[type=checkbox]').click
118 176 find('tr#issue-4 input[type=checkbox]').click
119 177 page.execute_script "$('tr#issue-1 td.updated_on').trigger('contextmenu');"
120 178 assert_difference 'Watcher.count', 2 do
121 179 within('#context-menu') do
122 180 click_link 'Watch'
123 181 end
124 182 end
125 183 assert Issue.find(1).watched_by?(User.find_by_login('jsmith'))
126 184 assert Issue.find(4).watched_by?(User.find_by_login('jsmith'))
127 185 end
128 186 end
General Comments 0
You need to be logged in to leave comments. Login now