jro_apps/redmine Commit - r15541:73ef85f672d9

Don't bulk edit file custom fields (#6719)....

Jean-Philippe Lang -

r15541:73ef85f672d9

parent child

Context file:

r15541:73ef85f672d9

app/controllers/context_menus_controller.rb +1 -1

                 @options_by_custom_field = {}
                 if @can[:edit]
-                  custom_fields = @issues.map(&:editable_custom_fields).reduce(:&).reject(&:multiple?)
+                  custom_fields = @issues.map(&:editable_custom_fields).reduce(:&).reject(&:multiple?).select {|field| field.format.bulk_edit_supported}
                   custom_fields.each do |field|
                     values = field.possible_values_options(@projects)
                     if values.present?

app/controllers/issues_controller.rb +1 -1

                   end
                 end
-                @custom_fields = edited_issues.map{|i|i.editable_custom_fields}.reduce(:&)
+                @custom_fields = edited_issues.map{|i|i.editable_custom_fields}.reduce(:&).select {|field| field.format.bulk_edit_supported}
                 @assignables = target_projects.map(&:assignable_users).reduce(:&)
                 @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
                 @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)

lib/redmine/field_format.rb +5 0

                   class_attribute :totalable_supported
                   self.totalable_supported = false
+                  # Set this to false if field cannot be bulk edited
+                  class_attribute :bulk_edit_supported
+                  self.bulk_edit_supported = true
                   # Restricts the classes that the custom field can be added to
                   # Set to nil for no restrictions
                   class_attribute :customized_class_names
                   self.form_partial = 'custom_fields/formats/attachment'
                   self.is_filter_supported = false
                   self.change_no_details = true
+                  self.bulk_edit_supported = false
                   field_attributes :extensions_allowed
                   def set_custom_field_value(custom_field, custom_field_value, value)

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages