##// END OF EJS Templates
cleanup syntax of Relation#all at MembersController#index...
Toshi MARUYAMA -
r12326:72715ec78e35
parent child
Show More
@@ -1,125 +1,124
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 class MembersController < ApplicationController
18 class MembersController < ApplicationController
19 model_object Member
19 model_object Member
20 before_filter :find_model_object, :except => [:index, :create, :autocomplete]
20 before_filter :find_model_object, :except => [:index, :create, :autocomplete]
21 before_filter :find_project_from_association, :except => [:index, :create, :autocomplete]
21 before_filter :find_project_from_association, :except => [:index, :create, :autocomplete]
22 before_filter :find_project_by_project_id, :only => [:index, :create, :autocomplete]
22 before_filter :find_project_by_project_id, :only => [:index, :create, :autocomplete]
23 before_filter :authorize
23 before_filter :authorize
24 accept_api_auth :index, :show, :create, :update, :destroy
24 accept_api_auth :index, :show, :create, :update, :destroy
25
25
26 def index
26 def index
27 @offset, @limit = api_offset_and_limit
27 @offset, @limit = api_offset_and_limit
28 @member_count = @project.member_principals.count
28 @member_count = @project.member_principals.count
29 @member_pages = Paginator.new @member_count, @limit, params['page']
29 @member_pages = Paginator.new @member_count, @limit, params['page']
30 @offset ||= @member_pages.offset
30 @offset ||= @member_pages.offset
31 @members = @project.member_principals.all(
31 @members = @project.member_principals.
32 :order => "#{Member.table_name}.id",
32 order("#{Member.table_name}.id").
33 :limit => @limit,
33 limit(@limit).
34 :offset => @offset
34 offset(@offset).
35 )
35 all
36
37 respond_to do |format|
36 respond_to do |format|
38 format.html { head 406 }
37 format.html { head 406 }
39 format.api
38 format.api
40 end
39 end
41 end
40 end
42
41
43 def show
42 def show
44 respond_to do |format|
43 respond_to do |format|
45 format.html { head 406 }
44 format.html { head 406 }
46 format.api
45 format.api
47 end
46 end
48 end
47 end
49
48
50 def create
49 def create
51 members = []
50 members = []
52 if params[:membership]
51 if params[:membership]
53 if params[:membership][:user_ids]
52 if params[:membership][:user_ids]
54 attrs = params[:membership].dup
53 attrs = params[:membership].dup
55 user_ids = attrs.delete(:user_ids)
54 user_ids = attrs.delete(:user_ids)
56 user_ids.each do |user_id|
55 user_ids.each do |user_id|
57 members << Member.new(:role_ids => params[:membership][:role_ids], :user_id => user_id)
56 members << Member.new(:role_ids => params[:membership][:role_ids], :user_id => user_id)
58 end
57 end
59 else
58 else
60 members << Member.new(:role_ids => params[:membership][:role_ids], :user_id => params[:membership][:user_id])
59 members << Member.new(:role_ids => params[:membership][:role_ids], :user_id => params[:membership][:user_id])
61 end
60 end
62 @project.members << members
61 @project.members << members
63 end
62 end
64
63
65 respond_to do |format|
64 respond_to do |format|
66 format.html { redirect_to_settings_in_projects }
65 format.html { redirect_to_settings_in_projects }
67 format.js { @members = members }
66 format.js { @members = members }
68 format.api {
67 format.api {
69 @member = members.first
68 @member = members.first
70 if @member.valid?
69 if @member.valid?
71 render :action => 'show', :status => :created, :location => membership_url(@member)
70 render :action => 'show', :status => :created, :location => membership_url(@member)
72 else
71 else
73 render_validation_errors(@member)
72 render_validation_errors(@member)
74 end
73 end
75 }
74 }
76 end
75 end
77 end
76 end
78
77
79 def update
78 def update
80 if params[:membership]
79 if params[:membership]
81 @member.role_ids = params[:membership][:role_ids]
80 @member.role_ids = params[:membership][:role_ids]
82 end
81 end
83 saved = @member.save
82 saved = @member.save
84 respond_to do |format|
83 respond_to do |format|
85 format.html { redirect_to_settings_in_projects }
84 format.html { redirect_to_settings_in_projects }
86 format.js
85 format.js
87 format.api {
86 format.api {
88 if saved
87 if saved
89 render_api_ok
88 render_api_ok
90 else
89 else
91 render_validation_errors(@member)
90 render_validation_errors(@member)
92 end
91 end
93 }
92 }
94 end
93 end
95 end
94 end
96
95
97 def destroy
96 def destroy
98 if request.delete? && @member.deletable?
97 if request.delete? && @member.deletable?
99 @member.destroy
98 @member.destroy
100 end
99 end
101 respond_to do |format|
100 respond_to do |format|
102 format.html { redirect_to_settings_in_projects }
101 format.html { redirect_to_settings_in_projects }
103 format.js
102 format.js
104 format.api {
103 format.api {
105 if @member.destroyed?
104 if @member.destroyed?
106 render_api_ok
105 render_api_ok
107 else
106 else
108 head :unprocessable_entity
107 head :unprocessable_entity
109 end
108 end
110 }
109 }
111 end
110 end
112 end
111 end
113
112
114 def autocomplete
113 def autocomplete
115 respond_to do |format|
114 respond_to do |format|
116 format.js
115 format.js
117 end
116 end
118 end
117 end
119
118
120 private
119 private
121
120
122 def redirect_to_settings_in_projects
121 def redirect_to_settings_in_projects
123 redirect_to settings_project_path(@project, :tab => 'members')
122 redirect_to settings_project_path(@project, :tab => 'members')
124 end
123 end
125 end
124 end
General Comments 0
You need to be logged in to leave comments. Login now