##// END OF EJS Templates
Preserve field values on bulk edit failure (#13943)....
Jean-Philippe Lang -
r11557:70bdb86c534f
parent child
Show More
@@ -1,447 +1,450
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 class IssuesController < ApplicationController
19 19 menu_item :new_issue, :only => [:new, :create]
20 20 default_search_scope :issues
21 21
22 22 before_filter :find_issue, :only => [:show, :edit, :update]
23 23 before_filter :find_issues, :only => [:bulk_edit, :bulk_update, :destroy]
24 24 before_filter :find_project, :only => [:new, :create, :update_form]
25 25 before_filter :authorize, :except => [:index]
26 26 before_filter :find_optional_project, :only => [:index]
27 27 before_filter :check_for_default_issue_status, :only => [:new, :create]
28 28 before_filter :build_new_issue_from_params, :only => [:new, :create, :update_form]
29 29 accept_rss_auth :index, :show
30 30 accept_api_auth :index, :show, :create, :update, :destroy
31 31
32 32 rescue_from Query::StatementInvalid, :with => :query_statement_invalid
33 33
34 34 helper :journals
35 35 helper :projects
36 36 include ProjectsHelper
37 37 helper :custom_fields
38 38 include CustomFieldsHelper
39 39 helper :issue_relations
40 40 include IssueRelationsHelper
41 41 helper :watchers
42 42 include WatchersHelper
43 43 helper :attachments
44 44 include AttachmentsHelper
45 45 helper :queries
46 46 include QueriesHelper
47 47 helper :repositories
48 48 include RepositoriesHelper
49 49 helper :sort
50 50 include SortHelper
51 51 include IssuesHelper
52 52 helper :timelog
53 53 include Redmine::Export::PDF
54 54
55 55 def index
56 56 retrieve_query
57 57 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
58 58 sort_update(@query.sortable_columns)
59 59 @query.sort_criteria = sort_criteria.to_a
60 60
61 61 if @query.valid?
62 62 case params[:format]
63 63 when 'csv', 'pdf'
64 64 @limit = Setting.issues_export_limit.to_i
65 65 when 'atom'
66 66 @limit = Setting.feeds_limit.to_i
67 67 when 'xml', 'json'
68 68 @offset, @limit = api_offset_and_limit
69 69 else
70 70 @limit = per_page_option
71 71 end
72 72
73 73 @issue_count = @query.issue_count
74 74 @issue_pages = Paginator.new @issue_count, @limit, params['page']
75 75 @offset ||= @issue_pages.offset
76 76 @issues = @query.issues(:include => [:assigned_to, :tracker, :priority, :category, :fixed_version],
77 77 :order => sort_clause,
78 78 :offset => @offset,
79 79 :limit => @limit)
80 80 @issue_count_by_group = @query.issue_count_by_group
81 81
82 82 respond_to do |format|
83 83 format.html { render :template => 'issues/index', :layout => !request.xhr? }
84 84 format.api {
85 85 Issue.load_visible_relations(@issues) if include_in_api_response?('relations')
86 86 }
87 87 format.atom { render_feed(@issues, :title => "#{@project || Setting.app_title}: #{l(:label_issue_plural)}") }
88 88 format.csv { send_data(query_to_csv(@issues, @query, params), :type => 'text/csv; header=present', :filename => 'issues.csv') }
89 89 format.pdf { send_data(issues_to_pdf(@issues, @project, @query), :type => 'application/pdf', :filename => 'issues.pdf') }
90 90 end
91 91 else
92 92 respond_to do |format|
93 93 format.html { render(:template => 'issues/index', :layout => !request.xhr?) }
94 94 format.any(:atom, :csv, :pdf) { render(:nothing => true) }
95 95 format.api { render_validation_errors(@query) }
96 96 end
97 97 end
98 98 rescue ActiveRecord::RecordNotFound
99 99 render_404
100 100 end
101 101
102 102 def show
103 103 @journals = @issue.journals.includes(:user, :details).reorder("#{Journal.table_name}.id ASC").all
104 104 @journals.each_with_index {|j,i| j.indice = i+1}
105 105 @journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
106 106 @journals.reverse! if User.current.wants_comments_in_reverse_order?
107 107
108 108 @changesets = @issue.changesets.visible.all
109 109 @changesets.reverse! if User.current.wants_comments_in_reverse_order?
110 110
111 111 @relations = @issue.relations.select {|r| r.other_issue(@issue) && r.other_issue(@issue).visible? }
112 112 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
113 113 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
114 114 @priorities = IssuePriority.active
115 115 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
116 116 @relation = IssueRelation.new
117 117
118 118 respond_to do |format|
119 119 format.html {
120 120 retrieve_previous_and_next_issue_ids
121 121 render :template => 'issues/show'
122 122 }
123 123 format.api
124 124 format.atom { render :template => 'journals/index', :layout => false, :content_type => 'application/atom+xml' }
125 125 format.pdf {
126 126 pdf = issue_to_pdf(@issue, :journals => @journals)
127 127 send_data(pdf, :type => 'application/pdf', :filename => "#{@project.identifier}-#{@issue.id}.pdf")
128 128 }
129 129 end
130 130 end
131 131
132 132 # Add a new issue
133 133 # The new issue will be created from an existing one if copy_from parameter is given
134 134 def new
135 135 respond_to do |format|
136 136 format.html { render :action => 'new', :layout => !request.xhr? }
137 137 end
138 138 end
139 139
140 140 def create
141 141 call_hook(:controller_issues_new_before_save, { :params => params, :issue => @issue })
142 142 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
143 143 if @issue.save
144 144 call_hook(:controller_issues_new_after_save, { :params => params, :issue => @issue})
145 145 respond_to do |format|
146 146 format.html {
147 147 render_attachment_warning_if_needed(@issue)
148 148 flash[:notice] = l(:notice_issue_successful_create, :id => view_context.link_to("##{@issue.id}", issue_path(@issue), :title => @issue.subject))
149 149 if params[:continue]
150 150 attrs = {:tracker_id => @issue.tracker, :parent_issue_id => @issue.parent_issue_id}.reject {|k,v| v.nil?}
151 151 redirect_to new_project_issue_path(@issue.project, :issue => attrs)
152 152 else
153 153 redirect_to issue_path(@issue)
154 154 end
155 155 }
156 156 format.api { render :action => 'show', :status => :created, :location => issue_url(@issue) }
157 157 end
158 158 return
159 159 else
160 160 respond_to do |format|
161 161 format.html { render :action => 'new' }
162 162 format.api { render_validation_errors(@issue) }
163 163 end
164 164 end
165 165 end
166 166
167 167 def edit
168 168 return unless update_issue_from_params
169 169
170 170 respond_to do |format|
171 171 format.html { }
172 172 format.xml { }
173 173 end
174 174 end
175 175
176 176 def update
177 177 return unless update_issue_from_params
178 178 @issue.save_attachments(params[:attachments] || (params[:issue] && params[:issue][:uploads]))
179 179 saved = false
180 180 begin
181 181 saved = @issue.save_issue_with_child_records(params, @time_entry)
182 182 rescue ActiveRecord::StaleObjectError
183 183 @conflict = true
184 184 if params[:last_journal_id]
185 185 @conflict_journals = @issue.journals_after(params[:last_journal_id]).all
186 186 @conflict_journals.reject!(&:private_notes?) unless User.current.allowed_to?(:view_private_notes, @issue.project)
187 187 end
188 188 end
189 189
190 190 if saved
191 191 render_attachment_warning_if_needed(@issue)
192 192 flash[:notice] = l(:notice_successful_update) unless @issue.current_journal.new_record?
193 193
194 194 respond_to do |format|
195 195 format.html { redirect_back_or_default issue_path(@issue) }
196 196 format.api { render_api_ok }
197 197 end
198 198 else
199 199 respond_to do |format|
200 200 format.html { render :action => 'edit' }
201 201 format.api { render_validation_errors(@issue) }
202 202 end
203 203 end
204 204 end
205 205
206 206 # Updates the issue form when changing the project, status or tracker
207 207 # on issue creation/update
208 208 def update_form
209 209 end
210 210
211 211 # Bulk edit/copy a set of issues
212 212 def bulk_edit
213 213 @issues.sort!
214 214 @copy = params[:copy].present?
215 215 @notes = params[:notes]
216 216
217 217 if User.current.allowed_to?(:move_issues, @projects)
218 218 @allowed_projects = Issue.allowed_target_projects_on_move
219 219 if params[:issue]
220 220 @target_project = @allowed_projects.detect {|p| p.id.to_s == params[:issue][:project_id].to_s}
221 221 if @target_project
222 222 target_projects = [@target_project]
223 223 end
224 224 end
225 225 end
226 226 target_projects ||= @projects
227 227
228 228 if @copy
229 229 @available_statuses = [IssueStatus.default]
230 230 else
231 231 @available_statuses = @issues.map(&:new_statuses_allowed_to).reduce(:&)
232 232 end
233 233 @custom_fields = target_projects.map{|p|p.all_issue_custom_fields}.reduce(:&)
234 234 @assignables = target_projects.map(&:assignable_users).reduce(:&)
235 235 @trackers = target_projects.map(&:trackers).reduce(:&)
236 236 @versions = target_projects.map {|p| p.shared_versions.open}.reduce(:&)
237 237 @categories = target_projects.map {|p| p.issue_categories}.reduce(:&)
238 238 if @copy
239 239 @attachments_present = @issues.detect {|i| i.attachments.any?}.present?
240 240 @subtasks_present = @issues.detect {|i| !i.leaf?}.present?
241 241 end
242 242
243 243 @safe_attributes = @issues.map(&:safe_attribute_names).reduce(:&)
244
245 @issue_params = params[:issue] || {}
246 @issue_params[:custom_field_values] ||= {}
244 247 end
245 248
246 249 def bulk_update
247 250 @issues.sort!
248 251 @copy = params[:copy].present?
249 252 attributes = parse_params_for_bulk_issue_attributes(params)
250 253
251 254 unsaved_issues = []
252 255 saved_issues = []
253 256
254 257 if @copy && params[:copy_subtasks].present?
255 258 # Descendant issues will be copied with the parent task
256 259 # Don't copy them twice
257 260 @issues.reject! {|issue| @issues.detect {|other| issue.is_descendant_of?(other)}}
258 261 end
259 262
260 263 @issues.each do |issue|
261 264 issue.reload
262 265 if @copy
263 266 issue = issue.copy({},
264 267 :attachments => params[:copy_attachments].present?,
265 268 :subtasks => params[:copy_subtasks].present?
266 269 )
267 270 end
268 271 journal = issue.init_journal(User.current, params[:notes])
269 272 issue.safe_attributes = attributes
270 273 call_hook(:controller_issues_bulk_edit_before_save, { :params => params, :issue => issue })
271 274 if issue.save
272 275 saved_issues << issue
273 276 else
274 277 unsaved_issues << issue
275 278 end
276 279 end
277 280
278 281 if unsaved_issues.empty?
279 282 flash[:notice] = l(:notice_successful_update) unless saved_issues.empty?
280 283 if params[:follow]
281 284 if @issues.size == 1 && saved_issues.size == 1
282 285 redirect_to issue_path(saved_issues.first)
283 286 elsif saved_issues.map(&:project).uniq.size == 1
284 287 redirect_to project_issues_path(saved_issues.map(&:project).first)
285 288 end
286 289 else
287 290 redirect_back_or_default _project_issues_path(@project)
288 291 end
289 292 else
290 293 @saved_issues = @issues
291 294 @unsaved_issues = unsaved_issues
292 295 @issues = Issue.visible.find_all_by_id(@unsaved_issues.map(&:id))
293 296 bulk_edit
294 297 render :action => 'bulk_edit'
295 298 end
296 299 end
297 300
298 301 def destroy
299 302 @hours = TimeEntry.sum(:hours, :conditions => ['issue_id IN (?)', @issues]).to_f
300 303 if @hours > 0
301 304 case params[:todo]
302 305 when 'destroy'
303 306 # nothing to do
304 307 when 'nullify'
305 308 TimeEntry.update_all('issue_id = NULL', ['issue_id IN (?)', @issues])
306 309 when 'reassign'
307 310 reassign_to = @project.issues.find_by_id(params[:reassign_to_id])
308 311 if reassign_to.nil?
309 312 flash.now[:error] = l(:error_issue_not_found_in_project)
310 313 return
311 314 else
312 315 TimeEntry.update_all("issue_id = #{reassign_to.id}", ['issue_id IN (?)', @issues])
313 316 end
314 317 else
315 318 # display the destroy form if it's a user request
316 319 return unless api_request?
317 320 end
318 321 end
319 322 @issues.each do |issue|
320 323 begin
321 324 issue.reload.destroy
322 325 rescue ::ActiveRecord::RecordNotFound # raised by #reload if issue no longer exists
323 326 # nothing to do, issue was already deleted (eg. by a parent)
324 327 end
325 328 end
326 329 respond_to do |format|
327 330 format.html { redirect_back_or_default _project_issues_path(@project) }
328 331 format.api { render_api_ok }
329 332 end
330 333 end
331 334
332 335 private
333 336
334 337 def find_project
335 338 project_id = params[:project_id] || (params[:issue] && params[:issue][:project_id])
336 339 @project = Project.find(project_id)
337 340 rescue ActiveRecord::RecordNotFound
338 341 render_404
339 342 end
340 343
341 344 def retrieve_previous_and_next_issue_ids
342 345 retrieve_query_from_session
343 346 if @query
344 347 sort_init(@query.sort_criteria.empty? ? [['id', 'desc']] : @query.sort_criteria)
345 348 sort_update(@query.sortable_columns, 'issues_index_sort')
346 349 limit = 500
347 350 issue_ids = @query.issue_ids(:order => sort_clause, :limit => (limit + 1), :include => [:assigned_to, :tracker, :priority, :category, :fixed_version])
348 351 if (idx = issue_ids.index(@issue.id)) && idx < limit
349 352 if issue_ids.size < 500
350 353 @issue_position = idx + 1
351 354 @issue_count = issue_ids.size
352 355 end
353 356 @prev_issue_id = issue_ids[idx - 1] if idx > 0
354 357 @next_issue_id = issue_ids[idx + 1] if idx < (issue_ids.size - 1)
355 358 end
356 359 end
357 360 end
358 361
359 362 # Used by #edit and #update to set some common instance variables
360 363 # from the params
361 364 # TODO: Refactor, not everything in here is needed by #edit
362 365 def update_issue_from_params
363 366 @edit_allowed = User.current.allowed_to?(:edit_issues, @project)
364 367 @time_entry = TimeEntry.new(:issue => @issue, :project => @issue.project)
365 368 @time_entry.attributes = params[:time_entry]
366 369
367 370 @issue.init_journal(User.current)
368 371
369 372 issue_attributes = params[:issue]
370 373 if issue_attributes && params[:conflict_resolution]
371 374 case params[:conflict_resolution]
372 375 when 'overwrite'
373 376 issue_attributes = issue_attributes.dup
374 377 issue_attributes.delete(:lock_version)
375 378 when 'add_notes'
376 379 issue_attributes = issue_attributes.slice(:notes)
377 380 when 'cancel'
378 381 redirect_to issue_path(@issue)
379 382 return false
380 383 end
381 384 end
382 385 @issue.safe_attributes = issue_attributes
383 386 @priorities = IssuePriority.active
384 387 @allowed_statuses = @issue.new_statuses_allowed_to(User.current)
385 388 true
386 389 end
387 390
388 391 # TODO: Refactor, lots of extra code in here
389 392 # TODO: Changing tracker on an existing issue should not trigger this
390 393 def build_new_issue_from_params
391 394 if params[:id].blank?
392 395 @issue = Issue.new
393 396 if params[:copy_from]
394 397 begin
395 398 @copy_from = Issue.visible.find(params[:copy_from])
396 399 @copy_attachments = params[:copy_attachments].present? || request.get?
397 400 @copy_subtasks = params[:copy_subtasks].present? || request.get?
398 401 @issue.copy_from(@copy_from, :attachments => @copy_attachments, :subtasks => @copy_subtasks)
399 402 rescue ActiveRecord::RecordNotFound
400 403 render_404
401 404 return
402 405 end
403 406 end
404 407 @issue.project = @project
405 408 else
406 409 @issue = @project.issues.visible.find(params[:id])
407 410 end
408 411
409 412 @issue.project = @project
410 413 @issue.author ||= User.current
411 414 # Tracker must be set before custom field values
412 415 @issue.tracker ||= @project.trackers.find((params[:issue] && params[:issue][:tracker_id]) || params[:tracker_id] || :first)
413 416 if @issue.tracker.nil?
414 417 render_error l(:error_no_tracker_in_project)
415 418 return false
416 419 end
417 420 @issue.start_date ||= Date.today if Setting.default_issue_start_date_to_creation_date?
418 421 @issue.safe_attributes = params[:issue]
419 422
420 423 @priorities = IssuePriority.active
421 424 @allowed_statuses = @issue.new_statuses_allowed_to(User.current, true)
422 425 @available_watchers = (@issue.project.users.sort + @issue.watcher_users).uniq
423 426 end
424 427
425 428 def check_for_default_issue_status
426 429 if IssueStatus.default.nil?
427 430 render_error l(:error_no_default_issue_status)
428 431 return false
429 432 end
430 433 end
431 434
432 435 def parse_params_for_bulk_issue_attributes(params)
433 436 attributes = (params[:issue] || {}).reject {|k,v| v.blank?}
434 437 attributes.keys.each {|k| attributes[k] = '' if attributes[k] == 'none'}
435 438 if custom = attributes[:custom_field_values]
436 439 custom.reject! {|k,v| v.blank?}
437 440 custom.keys.each do |k|
438 441 if custom[k].is_a?(Array)
439 442 custom[k] << '' if custom[k].delete('__none__')
440 443 else
441 444 custom[k] = '' if custom[k] == '__none__'
442 445 end
443 446 end
444 447 end
445 448 attributes
446 449 end
447 450 end
@@ -1,1244 +1,1248
1 1 # encoding: utf-8
2 2 #
3 3 # Redmine - project management software
4 4 # Copyright (C) 2006-2013 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 require 'forwardable'
21 21 require 'cgi'
22 22
23 23 module ApplicationHelper
24 24 include Redmine::WikiFormatting::Macros::Definitions
25 25 include Redmine::I18n
26 26 include GravatarHelper::PublicMethods
27 27 include Redmine::Pagination::Helper
28 28
29 29 extend Forwardable
30 30 def_delegators :wiki_helper, :wikitoolbar_for, :heads_for_wiki_formatter
31 31
32 32 # Return true if user is authorized for controller/action, otherwise false
33 33 def authorize_for(controller, action)
34 34 User.current.allowed_to?({:controller => controller, :action => action}, @project)
35 35 end
36 36
37 37 # Display a link if user is authorized
38 38 #
39 39 # @param [String] name Anchor text (passed to link_to)
40 40 # @param [Hash] options Hash params. This will checked by authorize_for to see if the user is authorized
41 41 # @param [optional, Hash] html_options Options passed to link_to
42 42 # @param [optional, Hash] parameters_for_method_reference Extra parameters for link_to
43 43 def link_to_if_authorized(name, options = {}, html_options = nil, *parameters_for_method_reference)
44 44 link_to(name, options, html_options, *parameters_for_method_reference) if authorize_for(options[:controller] || params[:controller], options[:action])
45 45 end
46 46
47 47 # Displays a link to user's account page if active
48 48 def link_to_user(user, options={})
49 49 if user.is_a?(User)
50 50 name = h(user.name(options[:format]))
51 51 if user.active? || (User.current.admin? && user.logged?)
52 52 link_to name, user_path(user), :class => user.css_classes
53 53 else
54 54 name
55 55 end
56 56 else
57 57 h(user.to_s)
58 58 end
59 59 end
60 60
61 61 # Displays a link to +issue+ with its subject.
62 62 # Examples:
63 63 #
64 64 # link_to_issue(issue) # => Defect #6: This is the subject
65 65 # link_to_issue(issue, :truncate => 6) # => Defect #6: This i...
66 66 # link_to_issue(issue, :subject => false) # => Defect #6
67 67 # link_to_issue(issue, :project => true) # => Foo - Defect #6
68 68 # link_to_issue(issue, :subject => false, :tracker => false) # => #6
69 69 #
70 70 def link_to_issue(issue, options={})
71 71 title = nil
72 72 subject = nil
73 73 text = options[:tracker] == false ? "##{issue.id}" : "#{issue.tracker} ##{issue.id}"
74 74 if options[:subject] == false
75 75 title = truncate(issue.subject, :length => 60)
76 76 else
77 77 subject = issue.subject
78 78 if options[:truncate]
79 79 subject = truncate(subject, :length => options[:truncate])
80 80 end
81 81 end
82 82 s = link_to text, issue_path(issue), :class => issue.css_classes, :title => title
83 83 s << h(": #{subject}") if subject
84 84 s = h("#{issue.project} - ") + s if options[:project]
85 85 s
86 86 end
87 87
88 88 # Generates a link to an attachment.
89 89 # Options:
90 90 # * :text - Link text (default to attachment filename)
91 91 # * :download - Force download (default: false)
92 92 def link_to_attachment(attachment, options={})
93 93 text = options.delete(:text) || attachment.filename
94 94 route_method = options.delete(:download) ? :download_named_attachment_path : :named_attachment_path
95 95 html_options = options.slice!(:only_path)
96 96 url = send(route_method, attachment, attachment.filename, options)
97 97 link_to text, url, html_options
98 98 end
99 99
100 100 # Generates a link to a SCM revision
101 101 # Options:
102 102 # * :text - Link text (default to the formatted revision)
103 103 def link_to_revision(revision, repository, options={})
104 104 if repository.is_a?(Project)
105 105 repository = repository.repository
106 106 end
107 107 text = options.delete(:text) || format_revision(revision)
108 108 rev = revision.respond_to?(:identifier) ? revision.identifier : revision
109 109 link_to(
110 110 h(text),
111 111 {:controller => 'repositories', :action => 'revision', :id => repository.project, :repository_id => repository.identifier_param, :rev => rev},
112 112 :title => l(:label_revision_id, format_revision(revision))
113 113 )
114 114 end
115 115
116 116 # Generates a link to a message
117 117 def link_to_message(message, options={}, html_options = nil)
118 118 link_to(
119 119 truncate(message.subject, :length => 60),
120 120 board_message_path(message.board_id, message.parent_id || message.id, {
121 121 :r => (message.parent_id && message.id),
122 122 :anchor => (message.parent_id ? "message-#{message.id}" : nil)
123 123 }.merge(options)),
124 124 html_options
125 125 )
126 126 end
127 127
128 128 # Generates a link to a project if active
129 129 # Examples:
130 130 #
131 131 # link_to_project(project) # => link to the specified project overview
132 132 # link_to_project(project, {:only_path => false}, :class => "project") # => 3rd arg adds html options
133 133 # link_to_project(project, {}, :class => "project") # => html options with default url (project overview)
134 134 #
135 135 def link_to_project(project, options={}, html_options = nil)
136 136 if project.archived?
137 137 h(project.name)
138 138 elsif options.key?(:action)
139 139 ActiveSupport::Deprecation.warn "#link_to_project with :action option is deprecated and will be removed in Redmine 3.0."
140 140 url = {:controller => 'projects', :action => 'show', :id => project}.merge(options)
141 141 link_to project.name, url, html_options
142 142 else
143 143 link_to project.name, project_path(project, options), html_options
144 144 end
145 145 end
146 146
147 147 # Generates a link to a project settings if active
148 148 def link_to_project_settings(project, options={}, html_options=nil)
149 149 if project.active?
150 150 link_to project.name, settings_project_path(project, options), html_options
151 151 elsif project.archived?
152 152 h(project.name)
153 153 else
154 154 link_to project.name, project_path(project, options), html_options
155 155 end
156 156 end
157 157
158 158 def wiki_page_path(page, options={})
159 159 url_for({:controller => 'wiki', :action => 'show', :project_id => page.project, :id => page.title}.merge(options))
160 160 end
161 161
162 162 def thumbnail_tag(attachment)
163 163 link_to image_tag(thumbnail_path(attachment)),
164 164 named_attachment_path(attachment, attachment.filename),
165 165 :title => attachment.filename
166 166 end
167 167
168 168 def toggle_link(name, id, options={})
169 169 onclick = "$('##{id}').toggle(); "
170 170 onclick << (options[:focus] ? "$('##{options[:focus]}').focus(); " : "this.blur(); ")
171 171 onclick << "return false;"
172 172 link_to(name, "#", :onclick => onclick)
173 173 end
174 174
175 175 def image_to_function(name, function, html_options = {})
176 176 html_options.symbolize_keys!
177 177 tag(:input, html_options.merge({
178 178 :type => "image", :src => image_path(name),
179 179 :onclick => (html_options[:onclick] ? "#{html_options[:onclick]}; " : "") + "#{function};"
180 180 }))
181 181 end
182 182
183 183 def format_activity_title(text)
184 184 h(truncate_single_line(text, :length => 100))
185 185 end
186 186
187 187 def format_activity_day(date)
188 188 date == User.current.today ? l(:label_today).titleize : format_date(date)
189 189 end
190 190
191 191 def format_activity_description(text)
192 192 h(truncate(text.to_s, :length => 120).gsub(%r{[\r\n]*<(pre|code)>.*$}m, '...')
193 193 ).gsub(/[\r\n]+/, "<br />").html_safe
194 194 end
195 195
196 196 def format_version_name(version)
197 197 if version.project == @project
198 198 h(version)
199 199 else
200 200 h("#{version.project} - #{version}")
201 201 end
202 202 end
203 203
204 204 def due_date_distance_in_words(date)
205 205 if date
206 206 l((date < Date.today ? :label_roadmap_overdue : :label_roadmap_due_in), distance_of_date_in_words(Date.today, date))
207 207 end
208 208 end
209 209
210 210 # Renders a tree of projects as a nested set of unordered lists
211 211 # The given collection may be a subset of the whole project tree
212 212 # (eg. some intermediate nodes are private and can not be seen)
213 213 def render_project_nested_lists(projects)
214 214 s = ''
215 215 if projects.any?
216 216 ancestors = []
217 217 original_project = @project
218 218 projects.sort_by(&:lft).each do |project|
219 219 # set the project environment to please macros.
220 220 @project = project
221 221 if (ancestors.empty? || project.is_descendant_of?(ancestors.last))
222 222 s << "<ul class='projects #{ ancestors.empty? ? 'root' : nil}'>\n"
223 223 else
224 224 ancestors.pop
225 225 s << "</li>"
226 226 while (ancestors.any? && !project.is_descendant_of?(ancestors.last))
227 227 ancestors.pop
228 228 s << "</ul></li>\n"
229 229 end
230 230 end
231 231 classes = (ancestors.empty? ? 'root' : 'child')
232 232 s << "<li class='#{classes}'><div class='#{classes}'>"
233 233 s << h(block_given? ? yield(project) : project.name)
234 234 s << "</div>\n"
235 235 ancestors << project
236 236 end
237 237 s << ("</li></ul>\n" * ancestors.size)
238 238 @project = original_project
239 239 end
240 240 s.html_safe
241 241 end
242 242
243 243 def render_page_hierarchy(pages, node=nil, options={})
244 244 content = ''
245 245 if pages[node]
246 246 content << "<ul class=\"pages-hierarchy\">\n"
247 247 pages[node].each do |page|
248 248 content << "<li>"
249 249 content << link_to(h(page.pretty_title), {:controller => 'wiki', :action => 'show', :project_id => page.project, :id => page.title, :version => nil},
250 250 :title => (options[:timestamp] && page.updated_on ? l(:label_updated_time, distance_of_time_in_words(Time.now, page.updated_on)) : nil))
251 251 content << "\n" + render_page_hierarchy(pages, page.id, options) if pages[page.id]
252 252 content << "</li>\n"
253 253 end
254 254 content << "</ul>\n"
255 255 end
256 256 content.html_safe
257 257 end
258 258
259 259 # Renders flash messages
260 260 def render_flash_messages
261 261 s = ''
262 262 flash.each do |k,v|
263 263 s << content_tag('div', v.html_safe, :class => "flash #{k}", :id => "flash_#{k}")
264 264 end
265 265 s.html_safe
266 266 end
267 267
268 268 # Renders tabs and their content
269 269 def render_tabs(tabs)
270 270 if tabs.any?
271 271 render :partial => 'common/tabs', :locals => {:tabs => tabs}
272 272 else
273 273 content_tag 'p', l(:label_no_data), :class => "nodata"
274 274 end
275 275 end
276 276
277 277 # Renders the project quick-jump box
278 278 def render_project_jump_box
279 279 return unless User.current.logged?
280 280 projects = User.current.memberships.collect(&:project).compact.select(&:active?).uniq
281 281 if projects.any?
282 282 options =
283 283 ("<option value=''>#{ l(:label_jump_to_a_project) }</option>" +
284 284 '<option value="" disabled="disabled">---</option>').html_safe
285 285
286 286 options << project_tree_options_for_select(projects, :selected => @project) do |p|
287 287 { :value => project_path(:id => p, :jump => current_menu_item) }
288 288 end
289 289
290 290 select_tag('project_quick_jump_box', options, :onchange => 'if (this.value != \'\') { window.location = this.value; }')
291 291 end
292 292 end
293 293
294 294 def project_tree_options_for_select(projects, options = {})
295 295 s = ''
296 296 project_tree(projects) do |project, level|
297 297 name_prefix = (level > 0 ? '&nbsp;' * 2 * level + '&#187; ' : '').html_safe
298 298 tag_options = {:value => project.id}
299 299 if project == options[:selected] || (options[:selected].respond_to?(:include?) && options[:selected].include?(project))
300 300 tag_options[:selected] = 'selected'
301 301 else
302 302 tag_options[:selected] = nil
303 303 end
304 304 tag_options.merge!(yield(project)) if block_given?
305 305 s << content_tag('option', name_prefix + h(project), tag_options)
306 306 end
307 307 s.html_safe
308 308 end
309 309
310 310 # Yields the given block for each project with its level in the tree
311 311 #
312 312 # Wrapper for Project#project_tree
313 313 def project_tree(projects, &block)
314 314 Project.project_tree(projects, &block)
315 315 end
316 316
317 317 def principals_check_box_tags(name, principals)
318 318 s = ''
319 319 principals.each do |principal|
320 320 s << "<label>#{ check_box_tag name, principal.id, false, :id => nil } #{h principal}</label>\n"
321 321 end
322 322 s.html_safe
323 323 end
324 324
325 325 # Returns a string for users/groups option tags
326 326 def principals_options_for_select(collection, selected=nil)
327 327 s = ''
328 328 if collection.include?(User.current)
329 329 s << content_tag('option', "<< #{l(:label_me)} >>", :value => User.current.id)
330 330 end
331 331 groups = ''
332 332 collection.sort.each do |element|
333 selected_attribute = ' selected="selected"' if option_value_selected?(element, selected)
333 selected_attribute = ' selected="selected"' if option_value_selected?(element, selected) || element.id.to_s == selected
334 334 (element.is_a?(Group) ? groups : s) << %(<option value="#{element.id}"#{selected_attribute}>#{h element.name}</option>)
335 335 end
336 336 unless groups.empty?
337 337 s << %(<optgroup label="#{h(l(:label_group_plural))}">#{groups}</optgroup>)
338 338 end
339 339 s.html_safe
340 340 end
341 341
342 342 # Options for the new membership projects combo-box
343 343 def options_for_membership_project_select(principal, projects)
344 344 options = content_tag('option', "--- #{l(:actionview_instancetag_blank_option)} ---")
345 345 options << project_tree_options_for_select(projects) do |p|
346 346 {:disabled => principal.projects.to_a.include?(p)}
347 347 end
348 348 options
349 349 end
350 350
351 def option_tag(name, text, value, selected=nil, options={})
352 content_tag 'option', value, options.merge(:value => value, :selected => (value == selected))
353 end
354
351 355 # Truncates and returns the string as a single line
352 356 def truncate_single_line(string, *args)
353 357 truncate(string.to_s, *args).gsub(%r{[\r\n]+}m, ' ')
354 358 end
355 359
356 360 # Truncates at line break after 250 characters or options[:length]
357 361 def truncate_lines(string, options={})
358 362 length = options[:length] || 250
359 363 if string.to_s =~ /\A(.{#{length}}.*?)$/m
360 364 "#{$1}..."
361 365 else
362 366 string
363 367 end
364 368 end
365 369
366 370 def anchor(text)
367 371 text.to_s.gsub(' ', '_')
368 372 end
369 373
370 374 def html_hours(text)
371 375 text.gsub(%r{(\d+)\.(\d+)}, '<span class="hours hours-int">\1</span><span class="hours hours-dec">.\2</span>').html_safe
372 376 end
373 377
374 378 def authoring(created, author, options={})
375 379 l(options[:label] || :label_added_time_by, :author => link_to_user(author), :age => time_tag(created)).html_safe
376 380 end
377 381
378 382 def time_tag(time)
379 383 text = distance_of_time_in_words(Time.now, time)
380 384 if @project
381 385 link_to(text, {:controller => 'activities', :action => 'index', :id => @project, :from => User.current.time_to_date(time)}, :title => format_time(time))
382 386 else
383 387 content_tag('acronym', text, :title => format_time(time))
384 388 end
385 389 end
386 390
387 391 def syntax_highlight_lines(name, content)
388 392 lines = []
389 393 syntax_highlight(name, content).each_line { |line| lines << line }
390 394 lines
391 395 end
392 396
393 397 def syntax_highlight(name, content)
394 398 Redmine::SyntaxHighlighting.highlight_by_filename(content, name)
395 399 end
396 400
397 401 def to_path_param(path)
398 402 str = path.to_s.split(%r{[/\\]}).select{|p| !p.blank?}.join("/")
399 403 str.blank? ? nil : str
400 404 end
401 405
402 406 def reorder_links(name, url, method = :post)
403 407 link_to(image_tag('2uparrow.png', :alt => l(:label_sort_highest)),
404 408 url.merge({"#{name}[move_to]" => 'highest'}),
405 409 :method => method, :title => l(:label_sort_highest)) +
406 410 link_to(image_tag('1uparrow.png', :alt => l(:label_sort_higher)),
407 411 url.merge({"#{name}[move_to]" => 'higher'}),
408 412 :method => method, :title => l(:label_sort_higher)) +
409 413 link_to(image_tag('1downarrow.png', :alt => l(:label_sort_lower)),
410 414 url.merge({"#{name}[move_to]" => 'lower'}),
411 415 :method => method, :title => l(:label_sort_lower)) +
412 416 link_to(image_tag('2downarrow.png', :alt => l(:label_sort_lowest)),
413 417 url.merge({"#{name}[move_to]" => 'lowest'}),
414 418 :method => method, :title => l(:label_sort_lowest))
415 419 end
416 420
417 421 def breadcrumb(*args)
418 422 elements = args.flatten
419 423 elements.any? ? content_tag('p', (args.join(" \xc2\xbb ") + " \xc2\xbb ").html_safe, :class => 'breadcrumb') : nil
420 424 end
421 425
422 426 def other_formats_links(&block)
423 427 concat('<p class="other-formats">'.html_safe + l(:label_export_to))
424 428 yield Redmine::Views::OtherFormatsBuilder.new(self)
425 429 concat('</p>'.html_safe)
426 430 end
427 431
428 432 def page_header_title
429 433 if @project.nil? || @project.new_record?
430 434 h(Setting.app_title)
431 435 else
432 436 b = []
433 437 ancestors = (@project.root? ? [] : @project.ancestors.visible.all)
434 438 if ancestors.any?
435 439 root = ancestors.shift
436 440 b << link_to_project(root, {:jump => current_menu_item}, :class => 'root')
437 441 if ancestors.size > 2
438 442 b << "\xe2\x80\xa6"
439 443 ancestors = ancestors[-2, 2]
440 444 end
441 445 b += ancestors.collect {|p| link_to_project(p, {:jump => current_menu_item}, :class => 'ancestor') }
442 446 end
443 447 b << h(@project)
444 448 b.join(" \xc2\xbb ").html_safe
445 449 end
446 450 end
447 451
448 452 def html_title(*args)
449 453 if args.empty?
450 454 title = @html_title || []
451 455 title << @project.name if @project
452 456 title << Setting.app_title unless Setting.app_title == title.last
453 457 title.select {|t| !t.blank? }.join(' - ')
454 458 else
455 459 @html_title ||= []
456 460 @html_title += args
457 461 end
458 462 end
459 463
460 464 # Returns the theme, controller name, and action as css classes for the
461 465 # HTML body.
462 466 def body_css_classes
463 467 css = []
464 468 if theme = Redmine::Themes.theme(Setting.ui_theme)
465 469 css << 'theme-' + theme.name
466 470 end
467 471
468 472 css << 'controller-' + controller_name
469 473 css << 'action-' + action_name
470 474 css.join(' ')
471 475 end
472 476
473 477 def accesskey(s)
474 478 @used_accesskeys ||= []
475 479 key = Redmine::AccessKeys.key_for(s)
476 480 return nil if @used_accesskeys.include?(key)
477 481 @used_accesskeys << key
478 482 key
479 483 end
480 484
481 485 # Formats text according to system settings.
482 486 # 2 ways to call this method:
483 487 # * with a String: textilizable(text, options)
484 488 # * with an object and one of its attribute: textilizable(issue, :description, options)
485 489 def textilizable(*args)
486 490 options = args.last.is_a?(Hash) ? args.pop : {}
487 491 case args.size
488 492 when 1
489 493 obj = options[:object]
490 494 text = args.shift
491 495 when 2
492 496 obj = args.shift
493 497 attr = args.shift
494 498 text = obj.send(attr).to_s
495 499 else
496 500 raise ArgumentError, 'invalid arguments to textilizable'
497 501 end
498 502 return '' if text.blank?
499 503 project = options[:project] || @project || (obj && obj.respond_to?(:project) ? obj.project : nil)
500 504 only_path = options.delete(:only_path) == false ? false : true
501 505
502 506 text = text.dup
503 507 macros = catch_macros(text)
504 508 text = Redmine::WikiFormatting.to_html(Setting.text_formatting, text, :object => obj, :attribute => attr)
505 509
506 510 @parsed_headings = []
507 511 @heading_anchors = {}
508 512 @current_section = 0 if options[:edit_section_links]
509 513
510 514 parse_sections(text, project, obj, attr, only_path, options)
511 515 text = parse_non_pre_blocks(text, obj, macros) do |text|
512 516 [:parse_inline_attachments, :parse_wiki_links, :parse_redmine_links].each do |method_name|
513 517 send method_name, text, project, obj, attr, only_path, options
514 518 end
515 519 end
516 520 parse_headings(text, project, obj, attr, only_path, options)
517 521
518 522 if @parsed_headings.any?
519 523 replace_toc(text, @parsed_headings)
520 524 end
521 525
522 526 text.html_safe
523 527 end
524 528
525 529 def parse_non_pre_blocks(text, obj, macros)
526 530 s = StringScanner.new(text)
527 531 tags = []
528 532 parsed = ''
529 533 while !s.eos?
530 534 s.scan(/(.*?)(<(\/)?(pre|code)(.*?)>|\z)/im)
531 535 text, full_tag, closing, tag = s[1], s[2], s[3], s[4]
532 536 if tags.empty?
533 537 yield text
534 538 inject_macros(text, obj, macros) if macros.any?
535 539 else
536 540 inject_macros(text, obj, macros, false) if macros.any?
537 541 end
538 542 parsed << text
539 543 if tag
540 544 if closing
541 545 if tags.last == tag.downcase
542 546 tags.pop
543 547 end
544 548 else
545 549 tags << tag.downcase
546 550 end
547 551 parsed << full_tag
548 552 end
549 553 end
550 554 # Close any non closing tags
551 555 while tag = tags.pop
552 556 parsed << "</#{tag}>"
553 557 end
554 558 parsed
555 559 end
556 560
557 561 def parse_inline_attachments(text, project, obj, attr, only_path, options)
558 562 # when using an image link, try to use an attachment, if possible
559 563 attachments = options[:attachments] || []
560 564 attachments += obj.attachments if obj.respond_to?(:attachments)
561 565 if attachments.present?
562 566 text.gsub!(/src="([^\/"]+\.(bmp|gif|jpg|jpe|jpeg|png))"(\s+alt="([^"]*)")?/i) do |m|
563 567 filename, ext, alt, alttext = $1.downcase, $2, $3, $4
564 568 # search for the picture in attachments
565 569 if found = Attachment.latest_attach(attachments, filename)
566 570 image_url = download_named_attachment_path(found, found.filename, :only_path => only_path)
567 571 desc = found.description.to_s.gsub('"', '')
568 572 if !desc.blank? && alttext.blank?
569 573 alt = " title=\"#{desc}\" alt=\"#{desc}\""
570 574 end
571 575 "src=\"#{image_url}\"#{alt}"
572 576 else
573 577 m
574 578 end
575 579 end
576 580 end
577 581 end
578 582
579 583 # Wiki links
580 584 #
581 585 # Examples:
582 586 # [[mypage]]
583 587 # [[mypage|mytext]]
584 588 # wiki links can refer other project wikis, using project name or identifier:
585 589 # [[project:]] -> wiki starting page
586 590 # [[project:|mytext]]
587 591 # [[project:mypage]]
588 592 # [[project:mypage|mytext]]
589 593 def parse_wiki_links(text, project, obj, attr, only_path, options)
590 594 text.gsub!(/(!)?(\[\[([^\]\n\|]+)(\|([^\]\n\|]+))?\]\])/) do |m|
591 595 link_project = project
592 596 esc, all, page, title = $1, $2, $3, $5
593 597 if esc.nil?
594 598 if page =~ /^([^\:]+)\:(.*)$/
595 599 identifier, page = $1, $2
596 600 link_project = Project.find_by_identifier(identifier) || Project.find_by_name(identifier)
597 601 title ||= identifier if page.blank?
598 602 end
599 603
600 604 if link_project && link_project.wiki
601 605 # extract anchor
602 606 anchor = nil
603 607 if page =~ /^(.+?)\#(.+)$/
604 608 page, anchor = $1, $2
605 609 end
606 610 anchor = sanitize_anchor_name(anchor) if anchor.present?
607 611 # check if page exists
608 612 wiki_page = link_project.wiki.find_page(page)
609 613 url = if anchor.present? && wiki_page.present? && (obj.is_a?(WikiContent) || obj.is_a?(WikiContent::Version)) && obj.page == wiki_page
610 614 "##{anchor}"
611 615 else
612 616 case options[:wiki_links]
613 617 when :local; "#{page.present? ? Wiki.titleize(page) : ''}.html" + (anchor.present? ? "##{anchor}" : '')
614 618 when :anchor; "##{page.present? ? Wiki.titleize(page) : title}" + (anchor.present? ? "_#{anchor}" : '') # used for single-file wiki export
615 619 else
616 620 wiki_page_id = page.present? ? Wiki.titleize(page) : nil
617 621 parent = wiki_page.nil? && obj.is_a?(WikiContent) && obj.page && project == link_project ? obj.page.title : nil
618 622 url_for(:only_path => only_path, :controller => 'wiki', :action => 'show', :project_id => link_project,
619 623 :id => wiki_page_id, :version => nil, :anchor => anchor, :parent => parent)
620 624 end
621 625 end
622 626 link_to(title.present? ? title.html_safe : h(page), url, :class => ('wiki-page' + (wiki_page ? '' : ' new')))
623 627 else
624 628 # project or wiki doesn't exist
625 629 all
626 630 end
627 631 else
628 632 all
629 633 end
630 634 end
631 635 end
632 636
633 637 # Redmine links
634 638 #
635 639 # Examples:
636 640 # Issues:
637 641 # #52 -> Link to issue #52
638 642 # Changesets:
639 643 # r52 -> Link to revision 52
640 644 # commit:a85130f -> Link to scmid starting with a85130f
641 645 # Documents:
642 646 # document#17 -> Link to document with id 17
643 647 # document:Greetings -> Link to the document with title "Greetings"
644 648 # document:"Some document" -> Link to the document with title "Some document"
645 649 # Versions:
646 650 # version#3 -> Link to version with id 3
647 651 # version:1.0.0 -> Link to version named "1.0.0"
648 652 # version:"1.0 beta 2" -> Link to version named "1.0 beta 2"
649 653 # Attachments:
650 654 # attachment:file.zip -> Link to the attachment of the current object named file.zip
651 655 # Source files:
652 656 # source:some/file -> Link to the file located at /some/file in the project's repository
653 657 # source:some/file@52 -> Link to the file's revision 52
654 658 # source:some/file#L120 -> Link to line 120 of the file
655 659 # source:some/file@52#L120 -> Link to line 120 of the file's revision 52
656 660 # export:some/file -> Force the download of the file
657 661 # Forum messages:
658 662 # message#1218 -> Link to message with id 1218
659 663 #
660 664 # Links can refer other objects from other projects, using project identifier:
661 665 # identifier:r52
662 666 # identifier:document:"Some document"
663 667 # identifier:version:1.0.0
664 668 # identifier:source:some/file
665 669 def parse_redmine_links(text, default_project, obj, attr, only_path, options)
666 670 text.gsub!(%r{([\s\(,\-\[\>]|^)(!)?(([a-z0-9\-_]+):)?(attachment|document|version|forum|news|message|project|commit|source|export)?(((#)|((([a-z0-9\-_]+)\|)?(r)))((\d+)((#note)?-(\d+))?)|(:)([^"\s<>][^\s<>]*?|"[^"]+?"))(?=(?=[[:punct:]][^A-Za-z0-9_/])|,|\s|\]|<|$)}) do |m|
667 671 leading, esc, project_prefix, project_identifier, prefix, repo_prefix, repo_identifier, sep, identifier, comment_suffix, comment_id = $1, $2, $3, $4, $5, $10, $11, $8 || $12 || $18, $14 || $19, $15, $17
668 672 link = nil
669 673 project = default_project
670 674 if project_identifier
671 675 project = Project.visible.find_by_identifier(project_identifier)
672 676 end
673 677 if esc.nil?
674 678 if prefix.nil? && sep == 'r'
675 679 if project
676 680 repository = nil
677 681 if repo_identifier
678 682 repository = project.repositories.detect {|repo| repo.identifier == repo_identifier}
679 683 else
680 684 repository = project.repository
681 685 end
682 686 # project.changesets.visible raises an SQL error because of a double join on repositories
683 687 if repository && (changeset = Changeset.visible.find_by_repository_id_and_revision(repository.id, identifier))
684 688 link = link_to(h("#{project_prefix}#{repo_prefix}r#{identifier}"), {:only_path => only_path, :controller => 'repositories', :action => 'revision', :id => project, :repository_id => repository.identifier_param, :rev => changeset.revision},
685 689 :class => 'changeset',
686 690 :title => truncate_single_line(changeset.comments, :length => 100))
687 691 end
688 692 end
689 693 elsif sep == '#'
690 694 oid = identifier.to_i
691 695 case prefix
692 696 when nil
693 697 if oid.to_s == identifier && issue = Issue.visible.find_by_id(oid, :include => :status)
694 698 anchor = comment_id ? "note-#{comment_id}" : nil
695 699 link = link_to("##{oid}", {:only_path => only_path, :controller => 'issues', :action => 'show', :id => oid, :anchor => anchor},
696 700 :class => issue.css_classes,
697 701 :title => "#{truncate(issue.subject, :length => 100)} (#{issue.status.name})")
698 702 end
699 703 when 'document'
700 704 if document = Document.visible.find_by_id(oid)
701 705 link = link_to h(document.title), {:only_path => only_path, :controller => 'documents', :action => 'show', :id => document},
702 706 :class => 'document'
703 707 end
704 708 when 'version'
705 709 if version = Version.visible.find_by_id(oid)
706 710 link = link_to h(version.name), {:only_path => only_path, :controller => 'versions', :action => 'show', :id => version},
707 711 :class => 'version'
708 712 end
709 713 when 'message'
710 714 if message = Message.visible.find_by_id(oid, :include => :parent)
711 715 link = link_to_message(message, {:only_path => only_path}, :class => 'message')
712 716 end
713 717 when 'forum'
714 718 if board = Board.visible.find_by_id(oid)
715 719 link = link_to h(board.name), {:only_path => only_path, :controller => 'boards', :action => 'show', :id => board, :project_id => board.project},
716 720 :class => 'board'
717 721 end
718 722 when 'news'
719 723 if news = News.visible.find_by_id(oid)
720 724 link = link_to h(news.title), {:only_path => only_path, :controller => 'news', :action => 'show', :id => news},
721 725 :class => 'news'
722 726 end
723 727 when 'project'
724 728 if p = Project.visible.find_by_id(oid)
725 729 link = link_to_project(p, {:only_path => only_path}, :class => 'project')
726 730 end
727 731 end
728 732 elsif sep == ':'
729 733 # removes the double quotes if any
730 734 name = identifier.gsub(%r{^"(.*)"$}, "\\1")
731 735 case prefix
732 736 when 'document'
733 737 if project && document = project.documents.visible.find_by_title(name)
734 738 link = link_to h(document.title), {:only_path => only_path, :controller => 'documents', :action => 'show', :id => document},
735 739 :class => 'document'
736 740 end
737 741 when 'version'
738 742 if project && version = project.versions.visible.find_by_name(name)
739 743 link = link_to h(version.name), {:only_path => only_path, :controller => 'versions', :action => 'show', :id => version},
740 744 :class => 'version'
741 745 end
742 746 when 'forum'
743 747 if project && board = project.boards.visible.find_by_name(name)
744 748 link = link_to h(board.name), {:only_path => only_path, :controller => 'boards', :action => 'show', :id => board, :project_id => board.project},
745 749 :class => 'board'
746 750 end
747 751 when 'news'
748 752 if project && news = project.news.visible.find_by_title(name)
749 753 link = link_to h(news.title), {:only_path => only_path, :controller => 'news', :action => 'show', :id => news},
750 754 :class => 'news'
751 755 end
752 756 when 'commit', 'source', 'export'
753 757 if project
754 758 repository = nil
755 759 if name =~ %r{^(([a-z0-9\-_]+)\|)(.+)$}
756 760 repo_prefix, repo_identifier, name = $1, $2, $3
757 761 repository = project.repositories.detect {|repo| repo.identifier == repo_identifier}
758 762 else
759 763 repository = project.repository
760 764 end
761 765 if prefix == 'commit'
762 766 if repository && (changeset = Changeset.visible.where("repository_id = ? AND scmid LIKE ?", repository.id, "#{name}%").first)
763 767 link = link_to h("#{project_prefix}#{repo_prefix}#{name}"), {:only_path => only_path, :controller => 'repositories', :action => 'revision', :id => project, :repository_id => repository.identifier_param, :rev => changeset.identifier},
764 768 :class => 'changeset',
765 769 :title => truncate_single_line(changeset.comments, :length => 100)
766 770 end
767 771 else
768 772 if repository && User.current.allowed_to?(:browse_repository, project)
769 773 name =~ %r{^[/\\]*(.*?)(@([^/\\@]+?))?(#(L\d+))?$}
770 774 path, rev, anchor = $1, $3, $5
771 775 link = link_to h("#{project_prefix}#{prefix}:#{repo_prefix}#{name}"), {:controller => 'repositories', :action => (prefix == 'export' ? 'raw' : 'entry'), :id => project, :repository_id => repository.identifier_param,
772 776 :path => to_path_param(path),
773 777 :rev => rev,
774 778 :anchor => anchor},
775 779 :class => (prefix == 'export' ? 'source download' : 'source')
776 780 end
777 781 end
778 782 repo_prefix = nil
779 783 end
780 784 when 'attachment'
781 785 attachments = options[:attachments] || (obj && obj.respond_to?(:attachments) ? obj.attachments : nil)
782 786 if attachments && attachment = Attachment.latest_attach(attachments, name)
783 787 link = link_to_attachment(attachment, :only_path => only_path, :download => true, :class => 'attachment')
784 788 end
785 789 when 'project'
786 790 if p = Project.visible.where("identifier = :s OR LOWER(name) = :s", :s => name.downcase).first
787 791 link = link_to_project(p, {:only_path => only_path}, :class => 'project')
788 792 end
789 793 end
790 794 end
791 795 end
792 796 (leading + (link || "#{project_prefix}#{prefix}#{repo_prefix}#{sep}#{identifier}#{comment_suffix}"))
793 797 end
794 798 end
795 799
796 800 HEADING_RE = /(<h(\d)( [^>]+)?>(.+?)<\/h(\d)>)/i unless const_defined?(:HEADING_RE)
797 801
798 802 def parse_sections(text, project, obj, attr, only_path, options)
799 803 return unless options[:edit_section_links]
800 804 text.gsub!(HEADING_RE) do
801 805 heading = $1
802 806 @current_section += 1
803 807 if @current_section > 1
804 808 content_tag('div',
805 809 link_to(image_tag('edit.png'), options[:edit_section_links].merge(:section => @current_section)),
806 810 :class => 'contextual',
807 811 :title => l(:button_edit_section)) + heading.html_safe
808 812 else
809 813 heading
810 814 end
811 815 end
812 816 end
813 817
814 818 # Headings and TOC
815 819 # Adds ids and links to headings unless options[:headings] is set to false
816 820 def parse_headings(text, project, obj, attr, only_path, options)
817 821 return if options[:headings] == false
818 822
819 823 text.gsub!(HEADING_RE) do
820 824 level, attrs, content = $2.to_i, $3, $4
821 825 item = strip_tags(content).strip
822 826 anchor = sanitize_anchor_name(item)
823 827 # used for single-file wiki export
824 828 anchor = "#{obj.page.title}_#{anchor}" if options[:wiki_links] == :anchor && (obj.is_a?(WikiContent) || obj.is_a?(WikiContent::Version))
825 829 @heading_anchors[anchor] ||= 0
826 830 idx = (@heading_anchors[anchor] += 1)
827 831 if idx > 1
828 832 anchor = "#{anchor}-#{idx}"
829 833 end
830 834 @parsed_headings << [level, anchor, item]
831 835 "<a name=\"#{anchor}\"></a>\n<h#{level} #{attrs}>#{content}<a href=\"##{anchor}\" class=\"wiki-anchor\">&para;</a></h#{level}>"
832 836 end
833 837 end
834 838
835 839 MACROS_RE = /(
836 840 (!)? # escaping
837 841 (
838 842 \{\{ # opening tag
839 843 ([\w]+) # macro name
840 844 (\(([^\n\r]*?)\))? # optional arguments
841 845 ([\n\r].*?[\n\r])? # optional block of text
842 846 \}\} # closing tag
843 847 )
844 848 )/mx unless const_defined?(:MACROS_RE)
845 849
846 850 MACRO_SUB_RE = /(
847 851 \{\{
848 852 macro\((\d+)\)
849 853 \}\}
850 854 )/x unless const_defined?(:MACRO_SUB_RE)
851 855
852 856 # Extracts macros from text
853 857 def catch_macros(text)
854 858 macros = {}
855 859 text.gsub!(MACROS_RE) do
856 860 all, macro = $1, $4.downcase
857 861 if macro_exists?(macro) || all =~ MACRO_SUB_RE
858 862 index = macros.size
859 863 macros[index] = all
860 864 "{{macro(#{index})}}"
861 865 else
862 866 all
863 867 end
864 868 end
865 869 macros
866 870 end
867 871
868 872 # Executes and replaces macros in text
869 873 def inject_macros(text, obj, macros, execute=true)
870 874 text.gsub!(MACRO_SUB_RE) do
871 875 all, index = $1, $2.to_i
872 876 orig = macros.delete(index)
873 877 if execute && orig && orig =~ MACROS_RE
874 878 esc, all, macro, args, block = $2, $3, $4.downcase, $6.to_s, $7.try(:strip)
875 879 if esc.nil?
876 880 h(exec_macro(macro, obj, args, block) || all)
877 881 else
878 882 h(all)
879 883 end
880 884 elsif orig
881 885 h(orig)
882 886 else
883 887 h(all)
884 888 end
885 889 end
886 890 end
887 891
888 892 TOC_RE = /<p>\{\{([<>]?)toc\}\}<\/p>/i unless const_defined?(:TOC_RE)
889 893
890 894 # Renders the TOC with given headings
891 895 def replace_toc(text, headings)
892 896 text.gsub!(TOC_RE) do
893 897 # Keep only the 4 first levels
894 898 headings = headings.select{|level, anchor, item| level <= 4}
895 899 if headings.empty?
896 900 ''
897 901 else
898 902 div_class = 'toc'
899 903 div_class << ' right' if $1 == '>'
900 904 div_class << ' left' if $1 == '<'
901 905 out = "<ul class=\"#{div_class}\"><li>"
902 906 root = headings.map(&:first).min
903 907 current = root
904 908 started = false
905 909 headings.each do |level, anchor, item|
906 910 if level > current
907 911 out << '<ul><li>' * (level - current)
908 912 elsif level < current
909 913 out << "</li></ul>\n" * (current - level) + "</li><li>"
910 914 elsif started
911 915 out << '</li><li>'
912 916 end
913 917 out << "<a href=\"##{anchor}\">#{item}</a>"
914 918 current = level
915 919 started = true
916 920 end
917 921 out << '</li></ul>' * (current - root)
918 922 out << '</li></ul>'
919 923 end
920 924 end
921 925 end
922 926
923 927 # Same as Rails' simple_format helper without using paragraphs
924 928 def simple_format_without_paragraph(text)
925 929 text.to_s.
926 930 gsub(/\r\n?/, "\n"). # \r\n and \r -> \n
927 931 gsub(/\n\n+/, "<br /><br />"). # 2+ newline -> 2 br
928 932 gsub(/([^\n]\n)(?=[^\n])/, '\1<br />'). # 1 newline -> br
929 933 html_safe
930 934 end
931 935
932 936 def lang_options_for_select(blank=true)
933 937 (blank ? [["(auto)", ""]] : []) + languages_options
934 938 end
935 939
936 940 def label_tag_for(name, option_tags = nil, options = {})
937 941 label_text = l(("field_"+field.to_s.gsub(/\_id$/, "")).to_sym) + (options.delete(:required) ? @template.content_tag("span", " *", :class => "required"): "")
938 942 content_tag("label", label_text)
939 943 end
940 944
941 945 def labelled_form_for(*args, &proc)
942 946 args << {} unless args.last.is_a?(Hash)
943 947 options = args.last
944 948 if args.first.is_a?(Symbol)
945 949 options.merge!(:as => args.shift)
946 950 end
947 951 options.merge!({:builder => Redmine::Views::LabelledFormBuilder})
948 952 form_for(*args, &proc)
949 953 end
950 954
951 955 def labelled_fields_for(*args, &proc)
952 956 args << {} unless args.last.is_a?(Hash)
953 957 options = args.last
954 958 options.merge!({:builder => Redmine::Views::LabelledFormBuilder})
955 959 fields_for(*args, &proc)
956 960 end
957 961
958 962 def labelled_remote_form_for(*args, &proc)
959 963 ActiveSupport::Deprecation.warn "ApplicationHelper#labelled_remote_form_for is deprecated and will be removed in Redmine 2.2."
960 964 args << {} unless args.last.is_a?(Hash)
961 965 options = args.last
962 966 options.merge!({:builder => Redmine::Views::LabelledFormBuilder, :remote => true})
963 967 form_for(*args, &proc)
964 968 end
965 969
966 970 def error_messages_for(*objects)
967 971 html = ""
968 972 objects = objects.map {|o| o.is_a?(String) ? instance_variable_get("@#{o}") : o}.compact
969 973 errors = objects.map {|o| o.errors.full_messages}.flatten
970 974 if errors.any?
971 975 html << "<div id='errorExplanation'><ul>\n"
972 976 errors.each do |error|
973 977 html << "<li>#{h error}</li>\n"
974 978 end
975 979 html << "</ul></div>\n"
976 980 end
977 981 html.html_safe
978 982 end
979 983
980 984 def delete_link(url, options={})
981 985 options = {
982 986 :method => :delete,
983 987 :data => {:confirm => l(:text_are_you_sure)},
984 988 :class => 'icon icon-del'
985 989 }.merge(options)
986 990
987 991 link_to l(:button_delete), url, options
988 992 end
989 993
990 994 def preview_link(url, form, target='preview', options={})
991 995 content_tag 'a', l(:label_preview), {
992 996 :href => "#",
993 997 :onclick => %|submitPreview("#{escape_javascript url_for(url)}", "#{escape_javascript form}", "#{escape_javascript target}"); return false;|,
994 998 :accesskey => accesskey(:preview)
995 999 }.merge(options)
996 1000 end
997 1001
998 1002 def link_to_function(name, function, html_options={})
999 1003 content_tag(:a, name, {:href => '#', :onclick => "#{function}; return false;"}.merge(html_options))
1000 1004 end
1001 1005
1002 1006 # Helper to render JSON in views
1003 1007 def raw_json(arg)
1004 1008 arg.to_json.to_s.gsub('/', '\/').html_safe
1005 1009 end
1006 1010
1007 1011 def back_url
1008 1012 url = params[:back_url]
1009 1013 if url.nil? && referer = request.env['HTTP_REFERER']
1010 1014 url = CGI.unescape(referer.to_s)
1011 1015 end
1012 1016 url
1013 1017 end
1014 1018
1015 1019 def back_url_hidden_field_tag
1016 1020 url = back_url
1017 1021 hidden_field_tag('back_url', url, :id => nil) unless url.blank?
1018 1022 end
1019 1023
1020 1024 def check_all_links(form_name)
1021 1025 link_to_function(l(:button_check_all), "checkAll('#{form_name}', true)") +
1022 1026 " | ".html_safe +
1023 1027 link_to_function(l(:button_uncheck_all), "checkAll('#{form_name}', false)")
1024 1028 end
1025 1029
1026 1030 def progress_bar(pcts, options={})
1027 1031 pcts = [pcts, pcts] unless pcts.is_a?(Array)
1028 1032 pcts = pcts.collect(&:round)
1029 1033 pcts[1] = pcts[1] - pcts[0]
1030 1034 pcts << (100 - pcts[1] - pcts[0])
1031 1035 width = options[:width] || '100px;'
1032 1036 legend = options[:legend] || ''
1033 1037 content_tag('table',
1034 1038 content_tag('tr',
1035 1039 (pcts[0] > 0 ? content_tag('td', '', :style => "width: #{pcts[0]}%;", :class => 'closed') : ''.html_safe) +
1036 1040 (pcts[1] > 0 ? content_tag('td', '', :style => "width: #{pcts[1]}%;", :class => 'done') : ''.html_safe) +
1037 1041 (pcts[2] > 0 ? content_tag('td', '', :style => "width: #{pcts[2]}%;", :class => 'todo') : ''.html_safe)
1038 1042 ), :class => 'progress', :style => "width: #{width};").html_safe +
1039 1043 content_tag('p', legend, :class => 'percent').html_safe
1040 1044 end
1041 1045
1042 1046 def checked_image(checked=true)
1043 1047 if checked
1044 1048 image_tag 'toggle_check.png'
1045 1049 end
1046 1050 end
1047 1051
1048 1052 def context_menu(url)
1049 1053 unless @context_menu_included
1050 1054 content_for :header_tags do
1051 1055 javascript_include_tag('context_menu') +
1052 1056 stylesheet_link_tag('context_menu')
1053 1057 end
1054 1058 if l(:direction) == 'rtl'
1055 1059 content_for :header_tags do
1056 1060 stylesheet_link_tag('context_menu_rtl')
1057 1061 end
1058 1062 end
1059 1063 @context_menu_included = true
1060 1064 end
1061 1065 javascript_tag "contextMenuInit('#{ url_for(url) }')"
1062 1066 end
1063 1067
1064 1068 def calendar_for(field_id)
1065 1069 include_calendar_headers_tags
1066 1070 javascript_tag("$(function() { $('##{field_id}').datepicker(datepickerOptions); });")
1067 1071 end
1068 1072
1069 1073 def include_calendar_headers_tags
1070 1074 unless @calendar_headers_tags_included
1071 1075 @calendar_headers_tags_included = true
1072 1076 content_for :header_tags do
1073 1077 start_of_week = Setting.start_of_week
1074 1078 start_of_week = l(:general_first_day_of_week, :default => '1') if start_of_week.blank?
1075 1079 # Redmine uses 1..7 (monday..sunday) in settings and locales
1076 1080 # JQuery uses 0..6 (sunday..saturday), 7 needs to be changed to 0
1077 1081 start_of_week = start_of_week.to_i % 7
1078 1082
1079 1083 tags = javascript_tag(
1080 1084 "var datepickerOptions={dateFormat: 'yy-mm-dd', firstDay: #{start_of_week}, " +
1081 1085 "showOn: 'button', buttonImageOnly: true, buttonImage: '" +
1082 1086 path_to_image('/images/calendar.png') +
1083 1087 "', showButtonPanel: true, showWeek: true, showOtherMonths: true, selectOtherMonths: true, changeMonth: true, changeYear: true};")
1084 1088 jquery_locale = l('jquery.locale', :default => current_language.to_s)
1085 1089 unless jquery_locale == 'en'
1086 1090 tags << javascript_include_tag("i18n/jquery.ui.datepicker-#{jquery_locale}.js")
1087 1091 end
1088 1092 tags
1089 1093 end
1090 1094 end
1091 1095 end
1092 1096
1093 1097 # Overrides Rails' stylesheet_link_tag with themes and plugins support.
1094 1098 # Examples:
1095 1099 # stylesheet_link_tag('styles') # => picks styles.css from the current theme or defaults
1096 1100 # stylesheet_link_tag('styles', :plugin => 'foo) # => picks styles.css from plugin's assets
1097 1101 #
1098 1102 def stylesheet_link_tag(*sources)
1099 1103 options = sources.last.is_a?(Hash) ? sources.pop : {}
1100 1104 plugin = options.delete(:plugin)
1101 1105 sources = sources.map do |source|
1102 1106 if plugin
1103 1107 "/plugin_assets/#{plugin}/stylesheets/#{source}"
1104 1108 elsif current_theme && current_theme.stylesheets.include?(source)
1105 1109 current_theme.stylesheet_path(source)
1106 1110 else
1107 1111 source
1108 1112 end
1109 1113 end
1110 1114 super sources, options
1111 1115 end
1112 1116
1113 1117 # Overrides Rails' image_tag with themes and plugins support.
1114 1118 # Examples:
1115 1119 # image_tag('image.png') # => picks image.png from the current theme or defaults
1116 1120 # image_tag('image.png', :plugin => 'foo) # => picks image.png from plugin's assets
1117 1121 #
1118 1122 def image_tag(source, options={})
1119 1123 if plugin = options.delete(:plugin)
1120 1124 source = "/plugin_assets/#{plugin}/images/#{source}"
1121 1125 elsif current_theme && current_theme.images.include?(source)
1122 1126 source = current_theme.image_path(source)
1123 1127 end
1124 1128 super source, options
1125 1129 end
1126 1130
1127 1131 # Overrides Rails' javascript_include_tag with plugins support
1128 1132 # Examples:
1129 1133 # javascript_include_tag('scripts') # => picks scripts.js from defaults
1130 1134 # javascript_include_tag('scripts', :plugin => 'foo) # => picks scripts.js from plugin's assets
1131 1135 #
1132 1136 def javascript_include_tag(*sources)
1133 1137 options = sources.last.is_a?(Hash) ? sources.pop : {}
1134 1138 if plugin = options.delete(:plugin)
1135 1139 sources = sources.map do |source|
1136 1140 if plugin
1137 1141 "/plugin_assets/#{plugin}/javascripts/#{source}"
1138 1142 else
1139 1143 source
1140 1144 end
1141 1145 end
1142 1146 end
1143 1147 super sources, options
1144 1148 end
1145 1149
1146 1150 def content_for(name, content = nil, &block)
1147 1151 @has_content ||= {}
1148 1152 @has_content[name] = true
1149 1153 super(name, content, &block)
1150 1154 end
1151 1155
1152 1156 def has_content?(name)
1153 1157 (@has_content && @has_content[name]) || false
1154 1158 end
1155 1159
1156 1160 def sidebar_content?
1157 1161 has_content?(:sidebar) || view_layouts_base_sidebar_hook_response.present?
1158 1162 end
1159 1163
1160 1164 def view_layouts_base_sidebar_hook_response
1161 1165 @view_layouts_base_sidebar_hook_response ||= call_hook(:view_layouts_base_sidebar)
1162 1166 end
1163 1167
1164 1168 def email_delivery_enabled?
1165 1169 !!ActionMailer::Base.perform_deliveries
1166 1170 end
1167 1171
1168 1172 # Returns the avatar image tag for the given +user+ if avatars are enabled
1169 1173 # +user+ can be a User or a string that will be scanned for an email address (eg. 'joe <joe@foo.bar>')
1170 1174 def avatar(user, options = { })
1171 1175 if Setting.gravatar_enabled?
1172 1176 options.merge!({:ssl => (request && request.ssl?), :default => Setting.gravatar_default})
1173 1177 email = nil
1174 1178 if user.respond_to?(:mail)
1175 1179 email = user.mail
1176 1180 elsif user.to_s =~ %r{<(.+?)>}
1177 1181 email = $1
1178 1182 end
1179 1183 return gravatar(email.to_s.downcase, options) unless email.blank? rescue nil
1180 1184 else
1181 1185 ''
1182 1186 end
1183 1187 end
1184 1188
1185 1189 def sanitize_anchor_name(anchor)
1186 1190 if ''.respond_to?(:encoding) || RUBY_PLATFORM == 'java'
1187 1191 anchor.gsub(%r{[^\s\-\p{Word}]}, '').gsub(%r{\s+(\-+\s*)?}, '-')
1188 1192 else
1189 1193 # TODO: remove when ruby1.8 is no longer supported
1190 1194 anchor.gsub(%r{[^\w\s\-]}, '').gsub(%r{\s+(\-+\s*)?}, '-')
1191 1195 end
1192 1196 end
1193 1197
1194 1198 # Returns the javascript tags that are included in the html layout head
1195 1199 def javascript_heads
1196 1200 tags = javascript_include_tag('jquery-1.8.3-ui-1.9.2-ujs-2.0.3', 'application')
1197 1201 unless User.current.pref.warn_on_leaving_unsaved == '0'
1198 1202 tags << "\n".html_safe + javascript_tag("$(window).load(function(){ warnLeavingUnsaved('#{escape_javascript l(:text_warn_on_leaving_unsaved)}'); });")
1199 1203 end
1200 1204 tags
1201 1205 end
1202 1206
1203 1207 def favicon
1204 1208 "<link rel='shortcut icon' href='#{image_path('/favicon.ico')}' />".html_safe
1205 1209 end
1206 1210
1207 1211 def robot_exclusion_tag
1208 1212 '<meta name="robots" content="noindex,follow,noarchive" />'.html_safe
1209 1213 end
1210 1214
1211 1215 # Returns true if arg is expected in the API response
1212 1216 def include_in_api_response?(arg)
1213 1217 unless @included_in_api_response
1214 1218 param = params[:include]
1215 1219 @included_in_api_response = param.is_a?(Array) ? param.collect(&:to_s) : param.to_s.split(',')
1216 1220 @included_in_api_response.collect!(&:strip)
1217 1221 end
1218 1222 @included_in_api_response.include?(arg.to_s)
1219 1223 end
1220 1224
1221 1225 # Returns options or nil if nometa param or X-Redmine-Nometa header
1222 1226 # was set in the request
1223 1227 def api_meta(options)
1224 1228 if params[:nometa].present? || request.headers['X-Redmine-Nometa']
1225 1229 # compatibility mode for activeresource clients that raise
1226 1230 # an error when unserializing an array with attributes
1227 1231 nil
1228 1232 else
1229 1233 options
1230 1234 end
1231 1235 end
1232 1236
1233 1237 private
1234 1238
1235 1239 def wiki_helper
1236 1240 helper = Redmine::WikiFormatting.helper_for(Setting.text_formatting)
1237 1241 extend helper
1238 1242 return self
1239 1243 end
1240 1244
1241 1245 def link_to_content_update(text, url_params = {}, html_options = {})
1242 1246 link_to(text, url_params, html_options)
1243 1247 end
1244 1248 end
@@ -1,149 +1,149
1 1 # encoding: utf-8
2 2 #
3 3 # Redmine - project management software
4 4 # Copyright (C) 2006-2013 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 module CustomFieldsHelper
21 21
22 22 def custom_fields_tabs
23 23 CustomField::CUSTOM_FIELDS_TABS
24 24 end
25 25
26 26 # Return custom field html tag corresponding to its format
27 27 def custom_field_tag(name, custom_value)
28 28 custom_field = custom_value.custom_field
29 29 field_name = "#{name}[custom_field_values][#{custom_field.id}]"
30 30 field_name << "[]" if custom_field.multiple?
31 31 field_id = "#{name}_custom_field_values_#{custom_field.id}"
32 32
33 33 tag_options = {:id => field_id, :class => "#{custom_field.field_format}_cf"}
34 34
35 35 field_format = Redmine::CustomFieldFormat.find_by_name(custom_field.field_format)
36 36 case field_format.try(:edit_as)
37 37 when "date"
38 38 text_field_tag(field_name, custom_value.value, tag_options.merge(:size => 10)) +
39 39 calendar_for(field_id)
40 40 when "text"
41 41 text_area_tag(field_name, custom_value.value, tag_options.merge(:rows => 3))
42 42 when "bool"
43 43 hidden_field_tag(field_name, '0') + check_box_tag(field_name, '1', custom_value.true?, tag_options)
44 44 when "list"
45 45 blank_option = ''.html_safe
46 46 unless custom_field.multiple?
47 47 if custom_field.is_required?
48 48 unless custom_field.default_value.present?
49 49 blank_option = content_tag('option', "--- #{l(:actionview_instancetag_blank_option)} ---", :value => '')
50 50 end
51 51 else
52 52 blank_option = content_tag('option')
53 53 end
54 54 end
55 55 s = select_tag(field_name, blank_option + options_for_select(custom_field.possible_values_options(custom_value.customized), custom_value.value),
56 56 tag_options.merge(:multiple => custom_field.multiple?))
57 57 if custom_field.multiple?
58 58 s << hidden_field_tag(field_name, '')
59 59 end
60 60 s
61 61 else
62 62 text_field_tag(field_name, custom_value.value, tag_options)
63 63 end
64 64 end
65 65
66 66 # Return custom field label tag
67 67 def custom_field_label_tag(name, custom_value, options={})
68 68 required = options[:required] || custom_value.custom_field.is_required?
69 69
70 70 content_tag "label", h(custom_value.custom_field.name) +
71 71 (required ? " <span class=\"required\">*</span>".html_safe : ""),
72 72 :for => "#{name}_custom_field_values_#{custom_value.custom_field.id}"
73 73 end
74 74
75 75 # Return custom field tag with its label tag
76 76 def custom_field_tag_with_label(name, custom_value, options={})
77 77 custom_field_label_tag(name, custom_value, options) + custom_field_tag(name, custom_value)
78 78 end
79 79
80 def custom_field_tag_for_bulk_edit(name, custom_field, projects=nil)
80 def custom_field_tag_for_bulk_edit(name, custom_field, projects=nil, value=nil)
81 81 field_name = "#{name}[custom_field_values][#{custom_field.id}]"
82 82 field_name << "[]" if custom_field.multiple?
83 83 field_id = "#{name}_custom_field_values_#{custom_field.id}"
84 84
85 85 tag_options = {:id => field_id, :class => "#{custom_field.field_format}_cf"}
86 86
87 87 field_format = Redmine::CustomFieldFormat.find_by_name(custom_field.field_format)
88 88 case field_format.try(:edit_as)
89 89 when "date"
90 text_field_tag(field_name, '', tag_options.merge(:size => 10)) +
90 text_field_tag(field_name, value, tag_options.merge(:size => 10)) +
91 91 calendar_for(field_id)
92 92 when "text"
93 text_area_tag(field_name, '', tag_options.merge(:rows => 3))
93 text_area_tag(field_name, value, tag_options.merge(:rows => 3))
94 94 when "bool"
95 95 select_tag(field_name, options_for_select([[l(:label_no_change_option), ''],
96 96 [l(:general_text_yes), '1'],
97 [l(:general_text_no), '0']]), tag_options)
97 [l(:general_text_no), '0']], value), tag_options)
98 98 when "list"
99 99 options = []
100 100 options << [l(:label_no_change_option), ''] unless custom_field.multiple?
101 101 options << [l(:label_none), '__none__'] unless custom_field.is_required?
102 102 options += custom_field.possible_values_options(projects)
103 select_tag(field_name, options_for_select(options), tag_options.merge(:multiple => custom_field.multiple?))
103 select_tag(field_name, options_for_select(options, value), tag_options.merge(:multiple => custom_field.multiple?))
104 104 else
105 text_field_tag(field_name, '', tag_options)
105 text_field_tag(field_name, value, tag_options)
106 106 end
107 107 end
108 108
109 109 # Return a string used to display a custom value
110 110 def show_value(custom_value)
111 111 return "" unless custom_value
112 112 format_value(custom_value.value, custom_value.custom_field.field_format)
113 113 end
114 114
115 115 # Return a string used to display a custom value
116 116 def format_value(value, field_format)
117 117 if value.is_a?(Array)
118 118 value.collect {|v| format_value(v, field_format)}.compact.sort.join(', ')
119 119 else
120 120 Redmine::CustomFieldFormat.format_value(value, field_format)
121 121 end
122 122 end
123 123
124 124 # Return an array of custom field formats which can be used in select_tag
125 125 def custom_field_formats_for_select(custom_field)
126 126 Redmine::CustomFieldFormat.as_select(custom_field.class.customized_class.name)
127 127 end
128 128
129 129 # Renders the custom_values in api views
130 130 def render_api_custom_values(custom_values, api)
131 131 api.array :custom_fields do
132 132 custom_values.each do |custom_value|
133 133 attrs = {:id => custom_value.custom_field_id, :name => custom_value.custom_field.name}
134 134 attrs.merge!(:multiple => true) if custom_value.custom_field.multiple?
135 135 api.custom_field attrs do
136 136 if custom_value.value.is_a?(Array)
137 137 api.array :value do
138 138 custom_value.value.each do |value|
139 139 api.value value unless value.blank?
140 140 end
141 141 end
142 142 else
143 143 api.value custom_value.value
144 144 end
145 145 end
146 146 end
147 147 end unless custom_values.empty?
148 148 end
149 149 end
@@ -1,83 +1,84
1 1 # encoding: utf-8
2 2 #
3 3 # Redmine - project management software
4 4 # Copyright (C) 2006-2013 Jean-Philippe Lang
5 5 #
6 6 # This program is free software; you can redistribute it and/or
7 7 # modify it under the terms of the GNU General Public License
8 8 # as published by the Free Software Foundation; either version 2
9 9 # of the License, or (at your option) any later version.
10 10 #
11 11 # This program is distributed in the hope that it will be useful,
12 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 14 # GNU General Public License for more details.
15 15 #
16 16 # You should have received a copy of the GNU General Public License
17 17 # along with this program; if not, write to the Free Software
18 18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 19
20 20 module ProjectsHelper
21 21 def link_to_version(version, options = {})
22 22 return '' unless version && version.is_a?(Version)
23 23 link_to_if version.visible?, format_version_name(version), { :controller => 'versions', :action => 'show', :id => version }, options
24 24 end
25 25
26 26 def project_settings_tabs
27 27 tabs = [{:name => 'info', :action => :edit_project, :partial => 'projects/edit', :label => :label_information_plural},
28 28 {:name => 'modules', :action => :select_project_modules, :partial => 'projects/settings/modules', :label => :label_module_plural},
29 29 {:name => 'members', :action => :manage_members, :partial => 'projects/settings/members', :label => :label_member_plural},
30 30 {:name => 'versions', :action => :manage_versions, :partial => 'projects/settings/versions', :label => :label_version_plural},
31 31 {:name => 'categories', :action => :manage_categories, :partial => 'projects/settings/issue_categories', :label => :label_issue_category_plural},
32 32 {:name => 'wiki', :action => :manage_wiki, :partial => 'projects/settings/wiki', :label => :label_wiki},
33 33 {:name => 'repositories', :action => :manage_repository, :partial => 'projects/settings/repositories', :label => :label_repository_plural},
34 34 {:name => 'boards', :action => :manage_boards, :partial => 'projects/settings/boards', :label => :label_board_plural},
35 35 {:name => 'activities', :action => :manage_project_activities, :partial => 'projects/settings/activities', :label => :enumeration_activities}
36 36 ]
37 37 tabs.select {|tab| User.current.allowed_to?(tab[:action], @project)}
38 38 end
39 39
40 40 def parent_project_select_tag(project)
41 41 selected = project.parent
42 42 # retrieve the requested parent project
43 43 parent_id = (params[:project] && params[:project][:parent_id]) || params[:parent_id]
44 44 if parent_id
45 45 selected = (parent_id.blank? ? nil : Project.find(parent_id))
46 46 end
47 47
48 48 options = ''
49 49 options << "<option value=''></option>" if project.allowed_parents.include?(nil)
50 50 options << project_tree_options_for_select(project.allowed_parents.compact, :selected => selected)
51 51 content_tag('select', options.html_safe, :name => 'project[parent_id]', :id => 'project_parent_id')
52 52 end
53 53
54 54 # Renders the projects index
55 55 def render_project_hierarchy(projects)
56 56 render_project_nested_lists(projects) do |project|
57 57 s = link_to_project(project, {}, :class => "#{project.css_classes} #{User.current.member_of?(project) ? 'my-project' : nil}")
58 58 if project.description.present?
59 59 s << content_tag('div', textilizable(project.short_description, :project => project), :class => 'wiki description')
60 60 end
61 61 s
62 62 end
63 63 end
64 64
65 65 # Returns a set of options for a select field, grouped by project.
66 66 def version_options_for_select(versions, selected=nil)
67 67 grouped = Hash.new {|h,k| h[k] = []}
68 68 versions.each do |version|
69 69 grouped[version.project.name] << [version.name, version.id]
70 70 end
71 71
72 selected = selected.is_a?(Version) ? selected.id : selected
72 73 if grouped.keys.size > 1
73 grouped_options_for_select(grouped, selected && selected.id)
74 grouped_options_for_select(grouped, selected)
74 75 else
75 options_for_select((grouped.values.first || []), selected && selected.id)
76 options_for_select((grouped.values.first || []), selected)
76 77 end
77 78 end
78 79
79 80 def format_version_sharing(sharing)
80 81 sharing = 'none' unless Version::VERSION_SHARINGS.include?(sharing)
81 82 l("label_version_sharing_#{sharing}")
82 83 end
83 84 end
@@ -1,166 +1,180
1 1 <h2><%= @copy ? l(:button_copy) : l(:label_bulk_edit_selected_issues) %></h2>
2 2
3 3 <% if @saved_issues && @unsaved_issues.present? %>
4 4 <div id="errorExplanation">
5 5 <span>
6 6 <%= l(:notice_failed_to_save_issues,
7 7 :count => @unsaved_issues.size,
8 8 :total => @saved_issues.size,
9 9 :ids => @unsaved_issues.map {|i| "##{i.id}"}.join(', ')) %>
10 10 </span>
11 11 <ul>
12 12 <% bulk_edit_error_messages(@unsaved_issues).each do |message| %>
13 13 <li><%= message %></li>
14 14 <% end %>
15 15 </ul>
16 16 </div>
17 17 <% end %>
18 18
19 19 <ul id="bulk-selection">
20 20 <% @issues.each do |issue| %>
21 21 <%= content_tag 'li', link_to_issue(issue) %>
22 22 <% end %>
23 23 </ul>
24 24
25 25 <%= form_tag(bulk_update_issues_path, :id => 'bulk_edit_form') do %>
26 26 <%= @issues.collect {|i| hidden_field_tag('ids[]', i.id)}.join("\n").html_safe %>
27 27 <div class="box tabular">
28 28 <fieldset class="attributes">
29 29 <legend><%= l(:label_change_properties) %></legend>
30 30
31 31 <div class="splitcontentleft">
32 32 <% if @allowed_projects.present? %>
33 33 <p>
34 34 <label for="issue_project_id"><%= l(:field_project) %></label>
35 <%= select_tag('issue[project_id]', content_tag('option', l(:label_no_change_option), :value => '') + project_tree_options_for_select(@allowed_projects, :selected => @target_project),
35 <%= select_tag('issue[project_id]',
36 content_tag('option', l(:label_no_change_option), :value => '') +
37 project_tree_options_for_select(@allowed_projects, :selected => @target_project),
36 38 :onchange => "updateBulkEditFrom('#{escape_javascript url_for(:action => 'bulk_edit', :format => 'js')}')") %>
37 39 </p>
38 40 <% end %>
39 41 <p>
40 42 <label for="issue_tracker_id"><%= l(:field_tracker) %></label>
41 <%= select_tag('issue[tracker_id]', content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(@trackers, :id, :name)) %>
43 <%= select_tag('issue[tracker_id]',
44 content_tag('option', l(:label_no_change_option), :value => '') +
45 options_from_collection_for_select(@trackers, :id, :name, @issue_params[:tracker_id])) %>
42 46 </p>
43 47 <% if @available_statuses.any? %>
44 48 <p>
45 49 <label for='issue_status_id'><%= l(:field_status) %></label>
46 <%= select_tag('issue[status_id]',content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(@available_statuses, :id, :name)) %>
50 <%= select_tag('issue[status_id]',
51 content_tag('option', l(:label_no_change_option), :value => '') +
52 options_from_collection_for_select(@available_statuses, :id, :name, @issue_params[:status_id])) %>
47 53 </p>
48 54 <% end %>
49 55
50 56 <% if @safe_attributes.include?('priority_id') -%>
51 57 <p>
52 58 <label for='issue_priority_id'><%= l(:field_priority) %></label>
53 <%= select_tag('issue[priority_id]', content_tag('option', l(:label_no_change_option), :value => '') + options_from_collection_for_select(IssuePriority.active, :id, :name)) %>
59 <%= select_tag('issue[priority_id]',
60 content_tag('option', l(:label_no_change_option), :value => '') +
61 options_from_collection_for_select(IssuePriority.active, :id, :name, @issue_params[:priority_id])) %>
54 62 </p>
55 63 <% end %>
56 64
57 65 <% if @safe_attributes.include?('assigned_to_id') -%>
58 66 <p>
59 67 <label for='issue_assigned_to_id'><%= l(:field_assigned_to) %></label>
60 <%= select_tag('issue[assigned_to_id]', content_tag('option', l(:label_no_change_option), :value => '') +
61 content_tag('option', l(:label_nobody), :value => 'none') +
62 principals_options_for_select(@assignables)) %>
68 <%= select_tag('issue[assigned_to_id]',
69 content_tag('option', l(:label_no_change_option), :value => '') +
70 content_tag('option', l(:label_nobody), :value => 'none', :selected => (@issue_params[:assigned_to_id] == 'none')) +
71 principals_options_for_select(@assignables, @issue_params[:assigned_to_id])) %>
63 72 </p>
64 73 <% end %>
65 74
66 75 <% if @safe_attributes.include?('category_id') -%>
67 76 <p>
68 77 <label for='issue_category_id'><%= l(:field_category) %></label>
69 78 <%= select_tag('issue[category_id]', content_tag('option', l(:label_no_change_option), :value => '') +
70 content_tag('option', l(:label_none), :value => 'none') +
71 options_from_collection_for_select(@categories, :id, :name)) %>
79 content_tag('option', l(:label_none), :value => 'none', :selected => (@issue_params[:category_id] == 'none')) +
80 options_from_collection_for_select(@categories, :id, :name, @issue_params[:category_id])) %>
72 81 </p>
73 82 <% end %>
74 83
75 84 <% if @safe_attributes.include?('fixed_version_id') -%>
76 85 <p>
77 86 <label for='issue_fixed_version_id'><%= l(:field_fixed_version) %></label>
78 87 <%= select_tag('issue[fixed_version_id]', content_tag('option', l(:label_no_change_option), :value => '') +
79 content_tag('option', l(:label_none), :value => 'none') +
80 version_options_for_select(@versions.sort)) %>
88 content_tag('option', l(:label_none), :value => 'none', :selected => (@issue_params[:fixed_version_id] == 'none')) +
89 version_options_for_select(@versions.sort, @issue_params[:fixed_version_id])) %>
81 90 </p>
82 91 <% end %>
83 92
84 93 <% @custom_fields.each do |custom_field| %>
85 <p><label><%= h(custom_field.name) %></label> <%= custom_field_tag_for_bulk_edit('issue', custom_field, @projects) %></p>
94 <p>
95 <label><%= h(custom_field.name) %></label>
96 <%= custom_field_tag_for_bulk_edit('issue', custom_field, @projects, @issue_params[:custom_field_values][custom_field.id.to_s]) %>
97 </p>
86 98 <% end %>
87 99
88 100 <% if @copy && @attachments_present %>
101 <%= hidden_field_tag 'copy_attachments', '0' %>
89 102 <p>
90 103 <label for='copy_attachments'><%= l(:label_copy_attachments) %></label>
91 <%= check_box_tag 'copy_attachments', '1', true %>
104 <%= check_box_tag 'copy_attachments', '1', params[:copy_attachments] != '0' %>
92 105 </p>
93 106 <% end %>
94 107
95 108 <% if @copy && @subtasks_present %>
109 <%= hidden_field_tag 'copy_subtasks', '0' %>
96 110 <p>
97 111 <label for='copy_subtasks'><%= l(:label_copy_subtasks) %></label>
98 <%= check_box_tag 'copy_subtasks', '1', true %>
112 <%= check_box_tag 'copy_subtasks', '1', params[:copy_subtasks] != '0' %>
99 113 </p>
100 114 <% end %>
101 115
102 116 <%= call_hook(:view_issues_bulk_edit_details_bottom, { :issues => @issues }) %>
103 117 </div>
104 118
105 119 <div class="splitcontentright">
106 120 <% if @safe_attributes.include?('is_private') %>
107 121 <p>
108 122 <label for='issue_is_private'><%= l(:field_is_private) %></label>
109 123 <%= select_tag('issue[is_private]', content_tag('option', l(:label_no_change_option), :value => '') +
110 content_tag('option', l(:general_text_Yes), :value => '1') +
111 content_tag('option', l(:general_text_No), :value => '0')) %>
124 content_tag('option', l(:general_text_Yes), :value => '1', :selected => (@issue_params[:is_private] == '1')) +
125 content_tag('option', l(:general_text_No), :value => '0', :selected => (@issue_params[:is_private] == '0'))) %>
112 126 </p>
113 127 <% end %>
114 128
115 129 <% if @safe_attributes.include?('parent_issue_id') && @project %>
116 130 <p>
117 131 <label for='issue_parent_issue_id'><%= l(:field_parent_issue) %></label>
118 <%= text_field_tag 'issue[parent_issue_id]', '', :size => 10 %>
132 <%= text_field_tag 'issue[parent_issue_id]', '', :size => 10, :value => @issue_params[:parent_issue_id] %>
119 133 </p>
120 134 <%= javascript_tag "observeAutocompleteField('issue_parent_issue_id', '#{escape_javascript auto_complete_issues_path(:project_id => @project)}')" %>
121 135 <% end %>
122 136
123 137 <% if @safe_attributes.include?('start_date') %>
124 138 <p>
125 139 <label for='issue_start_date'><%= l(:field_start_date) %></label>
126 <%= text_field_tag 'issue[start_date]', '', :size => 10 %><%= calendar_for('issue_start_date') %>
140 <%= text_field_tag 'issue[start_date]', '', :value => @issue_params[:start_date], :size => 10 %><%= calendar_for('issue_start_date') %>
127 141 </p>
128 142 <% end %>
129 143
130 144 <% if @safe_attributes.include?('due_date') %>
131 145 <p>
132 146 <label for='issue_due_date'><%= l(:field_due_date) %></label>
133 <%= text_field_tag 'issue[due_date]', '', :size => 10 %><%= calendar_for('issue_due_date') %>
147 <%= text_field_tag 'issue[due_date]', '', :value => @issue_params[:due_date], :size => 10 %><%= calendar_for('issue_due_date') %>
134 148 </p>
135 149 <% end %>
136 150
137 151 <% if @safe_attributes.include?('done_ratio') && Issue.use_field_for_done_ratio? %>
138 152 <p>
139 153 <label for='issue_done_ratio'><%= l(:field_done_ratio) %></label>
140 <%= select_tag 'issue[done_ratio]', options_for_select([[l(:label_no_change_option), '']] + (0..10).to_a.collect {|r| ["#{r*10} %", r*10] }) %>
154 <%= select_tag 'issue[done_ratio]', options_for_select([[l(:label_no_change_option), '']] + (0..10).to_a.collect {|r| ["#{r*10} %", r*10] }, @issue_params[:done_ratio]) %>
141 155 </p>
142 156 <% end %>
143 157 </div>
144 158 </fieldset>
145 159
146 160 <fieldset>
147 161 <legend><%= l(:field_notes) %></legend>
148 162 <%= text_area_tag 'notes', @notes, :cols => 60, :rows => 10, :class => 'wiki-edit' %>
149 163 <%= wikitoolbar_for 'notes' %>
150 164 </fieldset>
151 165 </div>
152 166
153 167 <p>
154 168 <% if @copy %>
155 169 <%= hidden_field_tag 'copy', '1' %>
156 170 <%= submit_tag l(:button_copy) %>
157 171 <%= submit_tag l(:button_copy_and_follow), :name => 'follow' %>
158 172 <% elsif @target_project %>
159 173 <%= submit_tag l(:button_move) %>
160 174 <%= submit_tag l(:button_move_and_follow), :name => 'follow' %>
161 175 <% else %>
162 176 <%= submit_tag l(:button_submit) %>
163 177 <% end %>
164 178 </p>
165 179
166 180 <% end %>
@@ -1,3917 +1,3929
1 1 # Redmine - project management software
2 2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 3 #
4 4 # This program is free software; you can redistribute it and/or
5 5 # modify it under the terms of the GNU General Public License
6 6 # as published by the Free Software Foundation; either version 2
7 7 # of the License, or (at your option) any later version.
8 8 #
9 9 # This program is distributed in the hope that it will be useful,
10 10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 12 # GNU General Public License for more details.
13 13 #
14 14 # You should have received a copy of the GNU General Public License
15 15 # along with this program; if not, write to the Free Software
16 16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17 17
18 18 require File.expand_path('../../test_helper', __FILE__)
19 19
20 20 class IssuesControllerTest < ActionController::TestCase
21 21 fixtures :projects,
22 22 :users,
23 23 :roles,
24 24 :members,
25 25 :member_roles,
26 26 :issues,
27 27 :issue_statuses,
28 28 :versions,
29 29 :trackers,
30 30 :projects_trackers,
31 31 :issue_categories,
32 32 :enabled_modules,
33 33 :enumerations,
34 34 :attachments,
35 35 :workflows,
36 36 :custom_fields,
37 37 :custom_values,
38 38 :custom_fields_projects,
39 39 :custom_fields_trackers,
40 40 :time_entries,
41 41 :journals,
42 42 :journal_details,
43 43 :queries,
44 44 :repositories,
45 45 :changesets
46 46
47 47 include Redmine::I18n
48 48
49 49 def setup
50 50 User.current = nil
51 51 end
52 52
53 53 def test_index
54 54 with_settings :default_language => "en" do
55 55 get :index
56 56 assert_response :success
57 57 assert_template 'index'
58 58 assert_not_nil assigns(:issues)
59 59 assert_nil assigns(:project)
60 60
61 61 # links to visible issues
62 62 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
63 63 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
64 64 # private projects hidden
65 65 assert_select 'a[href=/issues/6]', 0
66 66 assert_select 'a[href=/issues/4]', 0
67 67 # project column
68 68 assert_select 'th', :text => /Project/
69 69 end
70 70 end
71 71
72 72 def test_index_should_not_list_issues_when_module_disabled
73 73 EnabledModule.delete_all("name = 'issue_tracking' AND project_id = 1")
74 74 get :index
75 75 assert_response :success
76 76 assert_template 'index'
77 77 assert_not_nil assigns(:issues)
78 78 assert_nil assigns(:project)
79 79
80 80 assert_select 'a[href=/issues/1]', 0
81 81 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
82 82 end
83 83
84 84 def test_index_should_list_visible_issues_only
85 85 get :index, :per_page => 100
86 86 assert_response :success
87 87 assert_not_nil assigns(:issues)
88 88 assert_nil assigns(:issues).detect {|issue| !issue.visible?}
89 89 end
90 90
91 91 def test_index_with_project
92 92 Setting.display_subprojects_issues = 0
93 93 get :index, :project_id => 1
94 94 assert_response :success
95 95 assert_template 'index'
96 96 assert_not_nil assigns(:issues)
97 97
98 98 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
99 99 assert_select 'a[href=/issues/5]', 0
100 100 end
101 101
102 102 def test_index_with_project_and_subprojects
103 103 Setting.display_subprojects_issues = 1
104 104 get :index, :project_id => 1
105 105 assert_response :success
106 106 assert_template 'index'
107 107 assert_not_nil assigns(:issues)
108 108
109 109 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
110 110 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
111 111 assert_select 'a[href=/issues/6]', 0
112 112 end
113 113
114 114 def test_index_with_project_and_subprojects_should_show_private_subprojects_with_permission
115 115 @request.session[:user_id] = 2
116 116 Setting.display_subprojects_issues = 1
117 117 get :index, :project_id => 1
118 118 assert_response :success
119 119 assert_template 'index'
120 120 assert_not_nil assigns(:issues)
121 121
122 122 assert_select 'a[href=/issues/1]', :text => /Can&#x27;t print recipes/
123 123 assert_select 'a[href=/issues/5]', :text => /Subproject issue/
124 124 assert_select 'a[href=/issues/6]', :text => /Issue of a private subproject/
125 125 end
126 126
127 127 def test_index_with_project_and_default_filter
128 128 get :index, :project_id => 1, :set_filter => 1
129 129 assert_response :success
130 130 assert_template 'index'
131 131 assert_not_nil assigns(:issues)
132 132
133 133 query = assigns(:query)
134 134 assert_not_nil query
135 135 # default filter
136 136 assert_equal({'status_id' => {:operator => 'o', :values => ['']}}, query.filters)
137 137 end
138 138
139 139 def test_index_with_project_and_filter
140 140 get :index, :project_id => 1, :set_filter => 1,
141 141 :f => ['tracker_id'],
142 142 :op => {'tracker_id' => '='},
143 143 :v => {'tracker_id' => ['1']}
144 144 assert_response :success
145 145 assert_template 'index'
146 146 assert_not_nil assigns(:issues)
147 147
148 148 query = assigns(:query)
149 149 assert_not_nil query
150 150 assert_equal({'tracker_id' => {:operator => '=', :values => ['1']}}, query.filters)
151 151 end
152 152
153 153 def test_index_with_short_filters
154 154 to_test = {
155 155 'status_id' => {
156 156 'o' => { :op => 'o', :values => [''] },
157 157 'c' => { :op => 'c', :values => [''] },
158 158 '7' => { :op => '=', :values => ['7'] },
159 159 '7|3|4' => { :op => '=', :values => ['7', '3', '4'] },
160 160 '=7' => { :op => '=', :values => ['7'] },
161 161 '!3' => { :op => '!', :values => ['3'] },
162 162 '!7|3|4' => { :op => '!', :values => ['7', '3', '4'] }},
163 163 'subject' => {
164 164 'This is a subject' => { :op => '=', :values => ['This is a subject'] },
165 165 'o' => { :op => '=', :values => ['o'] },
166 166 '~This is part of a subject' => { :op => '~', :values => ['This is part of a subject'] },
167 167 '!~This is part of a subject' => { :op => '!~', :values => ['This is part of a subject'] }},
168 168 'tracker_id' => {
169 169 '3' => { :op => '=', :values => ['3'] },
170 170 '=3' => { :op => '=', :values => ['3'] }},
171 171 'start_date' => {
172 172 '2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
173 173 '=2011-10-12' => { :op => '=', :values => ['2011-10-12'] },
174 174 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
175 175 '<=2011-10-12' => { :op => '<=', :values => ['2011-10-12'] },
176 176 '><2011-10-01|2011-10-30' => { :op => '><', :values => ['2011-10-01', '2011-10-30'] },
177 177 '<t+2' => { :op => '<t+', :values => ['2'] },
178 178 '>t+2' => { :op => '>t+', :values => ['2'] },
179 179 't+2' => { :op => 't+', :values => ['2'] },
180 180 't' => { :op => 't', :values => [''] },
181 181 'w' => { :op => 'w', :values => [''] },
182 182 '>t-2' => { :op => '>t-', :values => ['2'] },
183 183 '<t-2' => { :op => '<t-', :values => ['2'] },
184 184 't-2' => { :op => 't-', :values => ['2'] }},
185 185 'created_on' => {
186 186 '>=2011-10-12' => { :op => '>=', :values => ['2011-10-12'] },
187 187 '<t-2' => { :op => '<t-', :values => ['2'] },
188 188 '>t-2' => { :op => '>t-', :values => ['2'] },
189 189 't-2' => { :op => 't-', :values => ['2'] }},
190 190 'cf_1' => {
191 191 'c' => { :op => '=', :values => ['c'] },
192 192 '!c' => { :op => '!', :values => ['c'] },
193 193 '!*' => { :op => '!*', :values => [''] },
194 194 '*' => { :op => '*', :values => [''] }},
195 195 'estimated_hours' => {
196 196 '=13.4' => { :op => '=', :values => ['13.4'] },
197 197 '>=45' => { :op => '>=', :values => ['45'] },
198 198 '<=125' => { :op => '<=', :values => ['125'] },
199 199 '><10.5|20.5' => { :op => '><', :values => ['10.5', '20.5'] },
200 200 '!*' => { :op => '!*', :values => [''] },
201 201 '*' => { :op => '*', :values => [''] }}
202 202 }
203 203
204 204 default_filter = { 'status_id' => {:operator => 'o', :values => [''] }}
205 205
206 206 to_test.each do |field, expression_and_expected|
207 207 expression_and_expected.each do |filter_expression, expected|
208 208
209 209 get :index, :set_filter => 1, field => filter_expression
210 210
211 211 assert_response :success
212 212 assert_template 'index'
213 213 assert_not_nil assigns(:issues)
214 214
215 215 query = assigns(:query)
216 216 assert_not_nil query
217 217 assert query.has_filter?(field)
218 218 assert_equal(default_filter.merge({field => {:operator => expected[:op], :values => expected[:values]}}), query.filters)
219 219 end
220 220 end
221 221 end
222 222
223 223 def test_index_with_project_and_empty_filters
224 224 get :index, :project_id => 1, :set_filter => 1, :fields => ['']
225 225 assert_response :success
226 226 assert_template 'index'
227 227 assert_not_nil assigns(:issues)
228 228
229 229 query = assigns(:query)
230 230 assert_not_nil query
231 231 # no filter
232 232 assert_equal({}, query.filters)
233 233 end
234 234
235 235 def test_index_with_project_custom_field_filter
236 236 field = ProjectCustomField.create!(:name => 'Client', :is_filter => true, :field_format => 'string')
237 237 CustomValue.create!(:custom_field => field, :customized => Project.find(3), :value => 'Foo')
238 238 CustomValue.create!(:custom_field => field, :customized => Project.find(5), :value => 'Foo')
239 239 filter_name = "project.cf_#{field.id}"
240 240 @request.session[:user_id] = 1
241 241
242 242 get :index, :set_filter => 1,
243 243 :f => [filter_name],
244 244 :op => {filter_name => '='},
245 245 :v => {filter_name => ['Foo']}
246 246 assert_response :success
247 247 assert_template 'index'
248 248 assert_equal [3, 5], assigns(:issues).map(&:project_id).uniq.sort
249 249 end
250 250
251 251 def test_index_with_query
252 252 get :index, :project_id => 1, :query_id => 5
253 253 assert_response :success
254 254 assert_template 'index'
255 255 assert_not_nil assigns(:issues)
256 256 assert_nil assigns(:issue_count_by_group)
257 257 end
258 258
259 259 def test_index_with_query_grouped_by_tracker
260 260 get :index, :project_id => 1, :query_id => 6
261 261 assert_response :success
262 262 assert_template 'index'
263 263 assert_not_nil assigns(:issues)
264 264 assert_not_nil assigns(:issue_count_by_group)
265 265 end
266 266
267 267 def test_index_with_query_grouped_by_list_custom_field
268 268 get :index, :project_id => 1, :query_id => 9
269 269 assert_response :success
270 270 assert_template 'index'
271 271 assert_not_nil assigns(:issues)
272 272 assert_not_nil assigns(:issue_count_by_group)
273 273 end
274 274
275 275 def test_index_with_query_grouped_by_user_custom_field
276 276 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
277 277 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
278 278 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
279 279 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
280 280 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
281 281
282 282 get :index, :project_id => 1, :set_filter => 1, :group_by => "cf_#{cf.id}"
283 283 assert_response :success
284 284
285 285 assert_select 'tr.group', 3
286 286 assert_select 'tr.group' do
287 287 assert_select 'a', :text => 'John Smith'
288 288 assert_select 'span.count', :text => '1'
289 289 end
290 290 assert_select 'tr.group' do
291 291 assert_select 'a', :text => 'Dave Lopper'
292 292 assert_select 'span.count', :text => '2'
293 293 end
294 294 end
295 295
296 296 def test_index_with_query_grouped_by_tracker
297 297 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
298 298
299 299 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc'
300 300 assert_response :success
301 301
302 302 trackers = assigns(:issues).map(&:tracker).uniq
303 303 assert_equal [1, 2, 3], trackers.map(&:id)
304 304 end
305 305
306 306 def test_index_with_query_grouped_by_tracker_in_reverse_order
307 307 3.times {|i| Issue.generate!(:tracker_id => (i + 1))}
308 308
309 309 get :index, :set_filter => 1, :group_by => 'tracker', :sort => 'id:desc,tracker:desc'
310 310 assert_response :success
311 311
312 312 trackers = assigns(:issues).map(&:tracker).uniq
313 313 assert_equal [3, 2, 1], trackers.map(&:id)
314 314 end
315 315
316 316 def test_index_with_query_id_and_project_id_should_set_session_query
317 317 get :index, :project_id => 1, :query_id => 4
318 318 assert_response :success
319 319 assert_kind_of Hash, session[:query]
320 320 assert_equal 4, session[:query][:id]
321 321 assert_equal 1, session[:query][:project_id]
322 322 end
323 323
324 324 def test_index_with_invalid_query_id_should_respond_404
325 325 get :index, :project_id => 1, :query_id => 999
326 326 assert_response 404
327 327 end
328 328
329 329 def test_index_with_cross_project_query_in_session_should_show_project_issues
330 330 q = IssueQuery.create!(:name => "test", :user_id => 2, :is_public => false, :project => nil)
331 331 @request.session[:query] = {:id => q.id, :project_id => 1}
332 332
333 333 with_settings :display_subprojects_issues => '0' do
334 334 get :index, :project_id => 1
335 335 end
336 336 assert_response :success
337 337 assert_not_nil assigns(:query)
338 338 assert_equal q.id, assigns(:query).id
339 339 assert_equal 1, assigns(:query).project_id
340 340 assert_equal [1], assigns(:issues).map(&:project_id).uniq
341 341 end
342 342
343 343 def test_private_query_should_not_be_available_to_other_users
344 344 q = IssueQuery.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
345 345 @request.session[:user_id] = 3
346 346
347 347 get :index, :query_id => q.id
348 348 assert_response 403
349 349 end
350 350
351 351 def test_private_query_should_be_available_to_its_user
352 352 q = IssueQuery.create!(:name => "private", :user => User.find(2), :is_public => false, :project => nil)
353 353 @request.session[:user_id] = 2
354 354
355 355 get :index, :query_id => q.id
356 356 assert_response :success
357 357 end
358 358
359 359 def test_public_query_should_be_available_to_other_users
360 360 q = IssueQuery.create!(:name => "private", :user => User.find(2), :is_public => true, :project => nil)
361 361 @request.session[:user_id] = 3
362 362
363 363 get :index, :query_id => q.id
364 364 assert_response :success
365 365 end
366 366
367 367 def test_index_should_omit_page_param_in_export_links
368 368 get :index, :page => 2
369 369 assert_response :success
370 370 assert_select 'a.atom[href=/issues.atom]'
371 371 assert_select 'a.csv[href=/issues.csv]'
372 372 assert_select 'a.pdf[href=/issues.pdf]'
373 373 assert_select 'form#csv-export-form[action=/issues.csv]'
374 374 end
375 375
376 376 def test_index_csv
377 377 get :index, :format => 'csv'
378 378 assert_response :success
379 379 assert_not_nil assigns(:issues)
380 380 assert_equal 'text/csv; header=present', @response.content_type
381 381 assert @response.body.starts_with?("#,")
382 382 lines = @response.body.chomp.split("\n")
383 383 assert_equal assigns(:query).columns.size, lines[0].split(',').size
384 384 end
385 385
386 386 def test_index_csv_with_project
387 387 get :index, :project_id => 1, :format => 'csv'
388 388 assert_response :success
389 389 assert_not_nil assigns(:issues)
390 390 assert_equal 'text/csv; header=present', @response.content_type
391 391 end
392 392
393 393 def test_index_csv_with_description
394 394 Issue.generate!(:description => 'test_index_csv_with_description')
395 395
396 396 with_settings :default_language => 'en' do
397 397 get :index, :format => 'csv', :description => '1'
398 398 assert_response :success
399 399 assert_not_nil assigns(:issues)
400 400 end
401 401
402 402 assert_equal 'text/csv; header=present', response.content_type
403 403 headers = response.body.chomp.split("\n").first.split(',')
404 404 assert_include 'Description', headers
405 405 assert_include 'test_index_csv_with_description', response.body
406 406 end
407 407
408 408 def test_index_csv_with_spent_time_column
409 409 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :subject => 'test_index_csv_with_spent_time_column', :author_id => 2)
410 410 TimeEntry.create!(:project => issue.project, :issue => issue, :hours => 7.33, :user => User.find(2), :spent_on => Date.today)
411 411
412 412 get :index, :format => 'csv', :set_filter => '1', :c => %w(subject spent_hours)
413 413 assert_response :success
414 414 assert_equal 'text/csv; header=present', @response.content_type
415 415 lines = @response.body.chomp.split("\n")
416 416 assert_include "#{issue.id},#{issue.subject},7.33", lines
417 417 end
418 418
419 419 def test_index_csv_with_all_columns
420 420 get :index, :format => 'csv', :columns => 'all'
421 421 assert_response :success
422 422 assert_not_nil assigns(:issues)
423 423 assert_equal 'text/csv; header=present', @response.content_type
424 424 assert_match /\A#,/, response.body
425 425 lines = response.body.chomp.split("\n")
426 426 assert_equal assigns(:query).available_inline_columns.size, lines[0].split(',').size
427 427 end
428 428
429 429 def test_index_csv_with_multi_column_field
430 430 CustomField.find(1).update_attribute :multiple, true
431 431 issue = Issue.find(1)
432 432 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
433 433 issue.save!
434 434
435 435 get :index, :format => 'csv', :columns => 'all'
436 436 assert_response :success
437 437 lines = @response.body.chomp.split("\n")
438 438 assert lines.detect {|line| line.include?('"MySQL, Oracle"')}
439 439 end
440 440
441 441 def test_index_csv_should_format_float_custom_fields_with_csv_decimal_separator
442 442 field = IssueCustomField.create!(:name => 'Float', :is_for_all => true, :tracker_ids => [1], :field_format => 'float')
443 443 issue = Issue.generate!(:project_id => 1, :tracker_id => 1, :custom_field_values => {field.id => '185.6'})
444 444
445 445 with_settings :default_language => 'fr' do
446 446 get :index, :format => 'csv', :columns => 'all'
447 447 assert_response :success
448 448 issue_line = response.body.chomp.split("\n").map {|line| line.split(';')}.detect {|line| line[0]==issue.id.to_s}
449 449 assert_include '185,60', issue_line
450 450 end
451 451
452 452 with_settings :default_language => 'en' do
453 453 get :index, :format => 'csv', :columns => 'all'
454 454 assert_response :success
455 455 issue_line = response.body.chomp.split("\n").map {|line| line.split(',')}.detect {|line| line[0]==issue.id.to_s}
456 456 assert_include '185.60', issue_line
457 457 end
458 458 end
459 459
460 460 def test_index_csv_big_5
461 461 with_settings :default_language => "zh-TW" do
462 462 str_utf8 = "\xe4\xb8\x80\xe6\x9c\x88"
463 463 str_big5 = "\xa4@\xa4\xeb"
464 464 if str_utf8.respond_to?(:force_encoding)
465 465 str_utf8.force_encoding('UTF-8')
466 466 str_big5.force_encoding('Big5')
467 467 end
468 468 issue = Issue.generate!(:subject => str_utf8)
469 469
470 470 get :index, :project_id => 1,
471 471 :f => ['subject'],
472 472 :op => '=', :values => [str_utf8],
473 473 :format => 'csv'
474 474 assert_equal 'text/csv; header=present', @response.content_type
475 475 lines = @response.body.chomp.split("\n")
476 476 s1 = "\xaa\xac\xbaA"
477 477 if str_utf8.respond_to?(:force_encoding)
478 478 s1.force_encoding('Big5')
479 479 end
480 480 assert_include s1, lines[0]
481 481 assert_include str_big5, lines[1]
482 482 end
483 483 end
484 484
485 485 def test_index_csv_cannot_convert_should_be_replaced_big_5
486 486 with_settings :default_language => "zh-TW" do
487 487 str_utf8 = "\xe4\xbb\xa5\xe5\x86\x85"
488 488 if str_utf8.respond_to?(:force_encoding)
489 489 str_utf8.force_encoding('UTF-8')
490 490 end
491 491 issue = Issue.generate!(:subject => str_utf8)
492 492
493 493 get :index, :project_id => 1,
494 494 :f => ['subject'],
495 495 :op => '=', :values => [str_utf8],
496 496 :c => ['status', 'subject'],
497 497 :format => 'csv',
498 498 :set_filter => 1
499 499 assert_equal 'text/csv; header=present', @response.content_type
500 500 lines = @response.body.chomp.split("\n")
501 501 s1 = "\xaa\xac\xbaA" # status
502 502 if str_utf8.respond_to?(:force_encoding)
503 503 s1.force_encoding('Big5')
504 504 end
505 505 assert lines[0].include?(s1)
506 506 s2 = lines[1].split(",")[2]
507 507 if s1.respond_to?(:force_encoding)
508 508 s3 = "\xa5H?" # subject
509 509 s3.force_encoding('Big5')
510 510 assert_equal s3, s2
511 511 elsif RUBY_PLATFORM == 'java'
512 512 assert_equal "??", s2
513 513 else
514 514 assert_equal "\xa5H???", s2
515 515 end
516 516 end
517 517 end
518 518
519 519 def test_index_csv_tw
520 520 with_settings :default_language => "zh-TW" do
521 521 str1 = "test_index_csv_tw"
522 522 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
523 523
524 524 get :index, :project_id => 1,
525 525 :f => ['subject'],
526 526 :op => '=', :values => [str1],
527 527 :c => ['estimated_hours', 'subject'],
528 528 :format => 'csv',
529 529 :set_filter => 1
530 530 assert_equal 'text/csv; header=present', @response.content_type
531 531 lines = @response.body.chomp.split("\n")
532 532 assert_equal "#{issue.id},1234.50,#{str1}", lines[1]
533 533 end
534 534 end
535 535
536 536 def test_index_csv_fr
537 537 with_settings :default_language => "fr" do
538 538 str1 = "test_index_csv_fr"
539 539 issue = Issue.generate!(:subject => str1, :estimated_hours => '1234.5')
540 540
541 541 get :index, :project_id => 1,
542 542 :f => ['subject'],
543 543 :op => '=', :values => [str1],
544 544 :c => ['estimated_hours', 'subject'],
545 545 :format => 'csv',
546 546 :set_filter => 1
547 547 assert_equal 'text/csv; header=present', @response.content_type
548 548 lines = @response.body.chomp.split("\n")
549 549 assert_equal "#{issue.id};1234,50;#{str1}", lines[1]
550 550 end
551 551 end
552 552
553 553 def test_index_pdf
554 554 ["en", "zh", "zh-TW", "ja", "ko"].each do |lang|
555 555 with_settings :default_language => lang do
556 556
557 557 get :index
558 558 assert_response :success
559 559 assert_template 'index'
560 560
561 561 if lang == "ja"
562 562 if RUBY_PLATFORM != 'java'
563 563 assert_equal "CP932", l(:general_pdf_encoding)
564 564 end
565 565 if RUBY_PLATFORM == 'java' && l(:general_pdf_encoding) == "CP932"
566 566 next
567 567 end
568 568 end
569 569
570 570 get :index, :format => 'pdf'
571 571 assert_response :success
572 572 assert_not_nil assigns(:issues)
573 573 assert_equal 'application/pdf', @response.content_type
574 574
575 575 get :index, :project_id => 1, :format => 'pdf'
576 576 assert_response :success
577 577 assert_not_nil assigns(:issues)
578 578 assert_equal 'application/pdf', @response.content_type
579 579
580 580 get :index, :project_id => 1, :query_id => 6, :format => 'pdf'
581 581 assert_response :success
582 582 assert_not_nil assigns(:issues)
583 583 assert_equal 'application/pdf', @response.content_type
584 584 end
585 585 end
586 586 end
587 587
588 588 def test_index_pdf_with_query_grouped_by_list_custom_field
589 589 get :index, :project_id => 1, :query_id => 9, :format => 'pdf'
590 590 assert_response :success
591 591 assert_not_nil assigns(:issues)
592 592 assert_not_nil assigns(:issue_count_by_group)
593 593 assert_equal 'application/pdf', @response.content_type
594 594 end
595 595
596 596 def test_index_atom
597 597 get :index, :project_id => 'ecookbook', :format => 'atom'
598 598 assert_response :success
599 599 assert_template 'common/feed'
600 600 assert_equal 'application/atom+xml', response.content_type
601 601
602 602 assert_select 'feed' do
603 603 assert_select 'link[rel=self][href=?]', 'http://test.host/projects/ecookbook/issues.atom'
604 604 assert_select 'link[rel=alternate][href=?]', 'http://test.host/projects/ecookbook/issues'
605 605 assert_select 'entry link[href=?]', 'http://test.host/issues/1'
606 606 end
607 607 end
608 608
609 609 def test_index_sort
610 610 get :index, :sort => 'tracker,id:desc'
611 611 assert_response :success
612 612
613 613 sort_params = @request.session['issues_index_sort']
614 614 assert sort_params.is_a?(String)
615 615 assert_equal 'tracker,id:desc', sort_params
616 616
617 617 issues = assigns(:issues)
618 618 assert_not_nil issues
619 619 assert !issues.empty?
620 620 assert_equal issues.sort {|a,b| a.tracker == b.tracker ? b.id <=> a.id : a.tracker <=> b.tracker }.collect(&:id), issues.collect(&:id)
621 621 end
622 622
623 623 def test_index_sort_by_field_not_included_in_columns
624 624 Setting.issue_list_default_columns = %w(subject author)
625 625 get :index, :sort => 'tracker'
626 626 end
627 627
628 628 def test_index_sort_by_assigned_to
629 629 get :index, :sort => 'assigned_to'
630 630 assert_response :success
631 631 assignees = assigns(:issues).collect(&:assigned_to).compact
632 632 assert_equal assignees.sort, assignees
633 633 end
634 634
635 635 def test_index_sort_by_assigned_to_desc
636 636 get :index, :sort => 'assigned_to:desc'
637 637 assert_response :success
638 638 assignees = assigns(:issues).collect(&:assigned_to).compact
639 639 assert_equal assignees.sort.reverse, assignees
640 640 end
641 641
642 642 def test_index_group_by_assigned_to
643 643 get :index, :group_by => 'assigned_to', :sort => 'priority'
644 644 assert_response :success
645 645 end
646 646
647 647 def test_index_sort_by_author
648 648 get :index, :sort => 'author'
649 649 assert_response :success
650 650 authors = assigns(:issues).collect(&:author)
651 651 assert_equal authors.sort, authors
652 652 end
653 653
654 654 def test_index_sort_by_author_desc
655 655 get :index, :sort => 'author:desc'
656 656 assert_response :success
657 657 authors = assigns(:issues).collect(&:author)
658 658 assert_equal authors.sort.reverse, authors
659 659 end
660 660
661 661 def test_index_group_by_author
662 662 get :index, :group_by => 'author', :sort => 'priority'
663 663 assert_response :success
664 664 end
665 665
666 666 def test_index_sort_by_spent_hours
667 667 get :index, :sort => 'spent_hours:desc'
668 668 assert_response :success
669 669 hours = assigns(:issues).collect(&:spent_hours)
670 670 assert_equal hours.sort.reverse, hours
671 671 end
672 672
673 673 def test_index_sort_by_user_custom_field
674 674 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
675 675 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
676 676 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
677 677 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
678 678 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
679 679
680 680 get :index, :project_id => 1, :set_filter => 1, :sort => "cf_#{cf.id},id"
681 681 assert_response :success
682 682
683 683 assert_equal [2, 3, 1], assigns(:issues).select {|issue| issue.custom_field_value(cf).present?}.map(&:id)
684 684 end
685 685
686 686 def test_index_with_columns
687 687 columns = ['tracker', 'subject', 'assigned_to']
688 688 get :index, :set_filter => 1, :c => columns
689 689 assert_response :success
690 690
691 691 # query should use specified columns
692 692 query = assigns(:query)
693 693 assert_kind_of IssueQuery, query
694 694 assert_equal columns, query.column_names.map(&:to_s)
695 695
696 696 # columns should be stored in session
697 697 assert_kind_of Hash, session[:query]
698 698 assert_kind_of Array, session[:query][:column_names]
699 699 assert_equal columns, session[:query][:column_names].map(&:to_s)
700 700
701 701 # ensure only these columns are kept in the selected columns list
702 702 assert_select 'select#selected_columns option' do
703 703 assert_select 'option', 3
704 704 assert_select 'option[value=tracker]'
705 705 assert_select 'option[value=project]', 0
706 706 end
707 707 end
708 708
709 709 def test_index_without_project_should_implicitly_add_project_column_to_default_columns
710 710 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
711 711 get :index, :set_filter => 1
712 712
713 713 # query should use specified columns
714 714 query = assigns(:query)
715 715 assert_kind_of IssueQuery, query
716 716 assert_equal [:id, :project, :tracker, :subject, :assigned_to], query.columns.map(&:name)
717 717 end
718 718
719 719 def test_index_without_project_and_explicit_default_columns_should_not_add_project_column
720 720 Setting.issue_list_default_columns = ['tracker', 'subject', 'assigned_to']
721 721 columns = ['id', 'tracker', 'subject', 'assigned_to']
722 722 get :index, :set_filter => 1, :c => columns
723 723
724 724 # query should use specified columns
725 725 query = assigns(:query)
726 726 assert_kind_of IssueQuery, query
727 727 assert_equal columns.map(&:to_sym), query.columns.map(&:name)
728 728 end
729 729
730 730 def test_index_with_custom_field_column
731 731 columns = %w(tracker subject cf_2)
732 732 get :index, :set_filter => 1, :c => columns
733 733 assert_response :success
734 734
735 735 # query should use specified columns
736 736 query = assigns(:query)
737 737 assert_kind_of IssueQuery, query
738 738 assert_equal columns, query.column_names.map(&:to_s)
739 739
740 740 assert_select 'table.issues td.cf_2.string'
741 741 end
742 742
743 743 def test_index_with_multi_custom_field_column
744 744 field = CustomField.find(1)
745 745 field.update_attribute :multiple, true
746 746 issue = Issue.find(1)
747 747 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
748 748 issue.save!
749 749
750 750 get :index, :set_filter => 1, :c => %w(tracker subject cf_1)
751 751 assert_response :success
752 752
753 753 assert_select 'table.issues td.cf_1', :text => 'MySQL, Oracle'
754 754 end
755 755
756 756 def test_index_with_multi_user_custom_field_column
757 757 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
758 758 :tracker_ids => [1], :is_for_all => true)
759 759 issue = Issue.find(1)
760 760 issue.custom_field_values = {field.id => ['2', '3']}
761 761 issue.save!
762 762
763 763 get :index, :set_filter => 1, :c => ['tracker', 'subject', "cf_#{field.id}"]
764 764 assert_response :success
765 765
766 766 assert_select "table.issues td.cf_#{field.id}" do
767 767 assert_select 'a', 2
768 768 assert_select 'a[href=?]', '/users/2', :text => 'John Smith'
769 769 assert_select 'a[href=?]', '/users/3', :text => 'Dave Lopper'
770 770 end
771 771 end
772 772
773 773 def test_index_with_date_column
774 774 with_settings :date_format => '%d/%m/%Y' do
775 775 Issue.find(1).update_attribute :start_date, '1987-08-24'
776 776
777 777 get :index, :set_filter => 1, :c => %w(start_date)
778 778
779 779 assert_select "table.issues td.start_date", :text => '24/08/1987'
780 780 end
781 781 end
782 782
783 783 def test_index_with_done_ratio_column
784 784 Issue.find(1).update_attribute :done_ratio, 40
785 785
786 786 get :index, :set_filter => 1, :c => %w(done_ratio)
787 787
788 788 assert_select 'table.issues td.done_ratio' do
789 789 assert_select 'table.progress' do
790 790 assert_select 'td.closed[style=?]', 'width: 40%;'
791 791 end
792 792 end
793 793 end
794 794
795 795 def test_index_with_spent_hours_column
796 796 get :index, :set_filter => 1, :c => %w(subject spent_hours)
797 797
798 798 assert_select 'table.issues tr#issue-3 td.spent_hours', :text => '1.00'
799 799 end
800 800
801 801 def test_index_should_not_show_spent_hours_column_without_permission
802 802 Role.anonymous.remove_permission! :view_time_entries
803 803 get :index, :set_filter => 1, :c => %w(subject spent_hours)
804 804
805 805 assert_select 'td.spent_hours', 0
806 806 end
807 807
808 808 def test_index_with_fixed_version_column
809 809 get :index, :set_filter => 1, :c => %w(fixed_version)
810 810
811 811 assert_select 'table.issues td.fixed_version' do
812 812 assert_select 'a[href=?]', '/versions/2', :text => '1.0'
813 813 end
814 814 end
815 815
816 816 def test_index_with_relations_column
817 817 IssueRelation.delete_all
818 818 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(1), :issue_to => Issue.find(7))
819 819 IssueRelation.create!(:relation_type => "relates", :issue_from => Issue.find(8), :issue_to => Issue.find(1))
820 820 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(1), :issue_to => Issue.find(11))
821 821 IssueRelation.create!(:relation_type => "blocks", :issue_from => Issue.find(12), :issue_to => Issue.find(2))
822 822
823 823 get :index, :set_filter => 1, :c => %w(subject relations)
824 824 assert_response :success
825 825 assert_select "tr#issue-1 td.relations" do
826 826 assert_select "span", 3
827 827 assert_select "span", :text => "Related to #7"
828 828 assert_select "span", :text => "Related to #8"
829 829 assert_select "span", :text => "Blocks #11"
830 830 end
831 831 assert_select "tr#issue-2 td.relations" do
832 832 assert_select "span", 1
833 833 assert_select "span", :text => "Blocked by #12"
834 834 end
835 835 assert_select "tr#issue-3 td.relations" do
836 836 assert_select "span", 0
837 837 end
838 838
839 839 get :index, :set_filter => 1, :c => %w(relations), :format => 'csv'
840 840 assert_response :success
841 841 assert_equal 'text/csv; header=present', response.content_type
842 842 lines = response.body.chomp.split("\n")
843 843 assert_include '1,"Related to #7, Related to #8, Blocks #11"', lines
844 844 assert_include '2,Blocked by #12', lines
845 845 assert_include '3,""', lines
846 846
847 847 get :index, :set_filter => 1, :c => %w(subject relations), :format => 'pdf'
848 848 assert_response :success
849 849 assert_equal 'application/pdf', response.content_type
850 850 end
851 851
852 852 def test_index_with_description_column
853 853 get :index, :set_filter => 1, :c => %w(subject description)
854 854
855 855 assert_select 'table.issues thead th', 3 # columns: chekbox + id + subject
856 856 assert_select 'td.description[colspan=3]', :text => 'Unable to print recipes'
857 857
858 858 get :index, :set_filter => 1, :c => %w(subject description), :format => 'pdf'
859 859 assert_response :success
860 860 assert_equal 'application/pdf', response.content_type
861 861 end
862 862
863 863 def test_index_send_html_if_query_is_invalid
864 864 get :index, :f => ['start_date'], :op => {:start_date => '='}
865 865 assert_equal 'text/html', @response.content_type
866 866 assert_template 'index'
867 867 end
868 868
869 869 def test_index_send_nothing_if_query_is_invalid
870 870 get :index, :f => ['start_date'], :op => {:start_date => '='}, :format => 'csv'
871 871 assert_equal 'text/csv', @response.content_type
872 872 assert @response.body.blank?
873 873 end
874 874
875 875 def test_show_by_anonymous
876 876 get :show, :id => 1
877 877 assert_response :success
878 878 assert_template 'show'
879 879 assert_equal Issue.find(1), assigns(:issue)
880 880
881 881 assert_select 'div.issue div.description', :text => /Unable to print recipes/
882 882
883 883 # anonymous role is allowed to add a note
884 884 assert_select 'form#issue-form' do
885 885 assert_select 'fieldset' do
886 886 assert_select 'legend', :text => 'Notes'
887 887 assert_select 'textarea[name=?]', 'issue[notes]'
888 888 end
889 889 end
890 890
891 891 assert_select 'title', :text => "Bug #1: Can&#x27;t print recipes - eCookbook - Redmine"
892 892 end
893 893
894 894 def test_show_by_manager
895 895 @request.session[:user_id] = 2
896 896 get :show, :id => 1
897 897 assert_response :success
898 898
899 899 assert_select 'a', :text => /Quote/
900 900
901 901 assert_select 'form#issue-form' do
902 902 assert_select 'fieldset' do
903 903 assert_select 'legend', :text => 'Change properties'
904 904 assert_select 'input[name=?]', 'issue[subject]'
905 905 end
906 906 assert_select 'fieldset' do
907 907 assert_select 'legend', :text => 'Log time'
908 908 assert_select 'input[name=?]', 'time_entry[hours]'
909 909 end
910 910 assert_select 'fieldset' do
911 911 assert_select 'legend', :text => 'Notes'
912 912 assert_select 'textarea[name=?]', 'issue[notes]'
913 913 end
914 914 end
915 915 end
916 916
917 917 def test_show_should_display_update_form
918 918 @request.session[:user_id] = 2
919 919 get :show, :id => 1
920 920 assert_response :success
921 921
922 922 assert_select 'form#issue-form' do
923 923 assert_select 'input[name=?]', 'issue[is_private]'
924 924 assert_select 'select[name=?]', 'issue[project_id]'
925 925 assert_select 'select[name=?]', 'issue[tracker_id]'
926 926 assert_select 'input[name=?]', 'issue[subject]'
927 927 assert_select 'textarea[name=?]', 'issue[description]'
928 928 assert_select 'select[name=?]', 'issue[status_id]'
929 929 assert_select 'select[name=?]', 'issue[priority_id]'
930 930 assert_select 'select[name=?]', 'issue[assigned_to_id]'
931 931 assert_select 'select[name=?]', 'issue[category_id]'
932 932 assert_select 'select[name=?]', 'issue[fixed_version_id]'
933 933 assert_select 'input[name=?]', 'issue[parent_issue_id]'
934 934 assert_select 'input[name=?]', 'issue[start_date]'
935 935 assert_select 'input[name=?]', 'issue[due_date]'
936 936 assert_select 'select[name=?]', 'issue[done_ratio]'
937 937 assert_select 'input[name=?]', 'issue[custom_field_values][2]'
938 938 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
939 939 assert_select 'textarea[name=?]', 'issue[notes]'
940 940 end
941 941 end
942 942
943 943 def test_show_should_display_update_form_with_minimal_permissions
944 944 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
945 945 WorkflowTransition.delete_all :role_id => 1
946 946
947 947 @request.session[:user_id] = 2
948 948 get :show, :id => 1
949 949 assert_response :success
950 950
951 951 assert_select 'form#issue-form' do
952 952 assert_select 'input[name=?]', 'issue[is_private]', 0
953 953 assert_select 'select[name=?]', 'issue[project_id]', 0
954 954 assert_select 'select[name=?]', 'issue[tracker_id]', 0
955 955 assert_select 'input[name=?]', 'issue[subject]', 0
956 956 assert_select 'textarea[name=?]', 'issue[description]', 0
957 957 assert_select 'select[name=?]', 'issue[status_id]', 0
958 958 assert_select 'select[name=?]', 'issue[priority_id]', 0
959 959 assert_select 'select[name=?]', 'issue[assigned_to_id]', 0
960 960 assert_select 'select[name=?]', 'issue[category_id]', 0
961 961 assert_select 'select[name=?]', 'issue[fixed_version_id]', 0
962 962 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
963 963 assert_select 'input[name=?]', 'issue[start_date]', 0
964 964 assert_select 'input[name=?]', 'issue[due_date]', 0
965 965 assert_select 'select[name=?]', 'issue[done_ratio]', 0
966 966 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
967 967 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
968 968 assert_select 'textarea[name=?]', 'issue[notes]'
969 969 end
970 970 end
971 971
972 972 def test_show_should_display_update_form_with_workflow_permissions
973 973 Role.find(1).update_attribute :permissions, [:view_issues, :add_issue_notes]
974 974
975 975 @request.session[:user_id] = 2
976 976 get :show, :id => 1
977 977 assert_response :success
978 978
979 979 assert_select 'form#issue-form' do
980 980 assert_select 'input[name=?]', 'issue[is_private]', 0
981 981 assert_select 'select[name=?]', 'issue[project_id]', 0
982 982 assert_select 'select[name=?]', 'issue[tracker_id]', 0
983 983 assert_select 'input[name=?]', 'issue[subject]', 0
984 984 assert_select 'textarea[name=?]', 'issue[description]', 0
985 985 assert_select 'select[name=?]', 'issue[status_id]'
986 986 assert_select 'select[name=?]', 'issue[priority_id]', 0
987 987 assert_select 'select[name=?]', 'issue[assigned_to_id]'
988 988 assert_select 'select[name=?]', 'issue[category_id]', 0
989 989 assert_select 'select[name=?]', 'issue[fixed_version_id]'
990 990 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
991 991 assert_select 'input[name=?]', 'issue[start_date]', 0
992 992 assert_select 'input[name=?]', 'issue[due_date]', 0
993 993 assert_select 'select[name=?]', 'issue[done_ratio]'
994 994 assert_select 'input[name=?]', 'issue[custom_field_values][2]', 0
995 995 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
996 996 assert_select 'textarea[name=?]', 'issue[notes]'
997 997 end
998 998 end
999 999
1000 1000 def test_show_should_not_display_update_form_without_permissions
1001 1001 Role.find(1).update_attribute :permissions, [:view_issues]
1002 1002
1003 1003 @request.session[:user_id] = 2
1004 1004 get :show, :id => 1
1005 1005 assert_response :success
1006 1006
1007 1007 assert_select 'form#issue-form', 0
1008 1008 end
1009 1009
1010 1010 def test_update_form_should_not_display_inactive_enumerations
1011 1011 assert !IssuePriority.find(15).active?
1012 1012
1013 1013 @request.session[:user_id] = 2
1014 1014 get :show, :id => 1
1015 1015 assert_response :success
1016 1016
1017 1017 assert_select 'form#issue-form' do
1018 1018 assert_select 'select[name=?]', 'issue[priority_id]' do
1019 1019 assert_select 'option[value=4]'
1020 1020 assert_select 'option[value=15]', 0
1021 1021 end
1022 1022 end
1023 1023 end
1024 1024
1025 1025 def test_update_form_should_allow_attachment_upload
1026 1026 @request.session[:user_id] = 2
1027 1027 get :show, :id => 1
1028 1028
1029 1029 assert_select 'form#issue-form[method=post][enctype=multipart/form-data]' do
1030 1030 assert_select 'input[type=file][name=?]', 'attachments[dummy][file]'
1031 1031 end
1032 1032 end
1033 1033
1034 1034 def test_show_should_deny_anonymous_access_without_permission
1035 1035 Role.anonymous.remove_permission!(:view_issues)
1036 1036 get :show, :id => 1
1037 1037 assert_response :redirect
1038 1038 end
1039 1039
1040 1040 def test_show_should_deny_anonymous_access_to_private_issue
1041 1041 Issue.update_all(["is_private = ?", true], "id = 1")
1042 1042 get :show, :id => 1
1043 1043 assert_response :redirect
1044 1044 end
1045 1045
1046 1046 def test_show_should_deny_non_member_access_without_permission
1047 1047 Role.non_member.remove_permission!(:view_issues)
1048 1048 @request.session[:user_id] = 9
1049 1049 get :show, :id => 1
1050 1050 assert_response 403
1051 1051 end
1052 1052
1053 1053 def test_show_should_deny_non_member_access_to_private_issue
1054 1054 Issue.update_all(["is_private = ?", true], "id = 1")
1055 1055 @request.session[:user_id] = 9
1056 1056 get :show, :id => 1
1057 1057 assert_response 403
1058 1058 end
1059 1059
1060 1060 def test_show_should_deny_member_access_without_permission
1061 1061 Role.find(1).remove_permission!(:view_issues)
1062 1062 @request.session[:user_id] = 2
1063 1063 get :show, :id => 1
1064 1064 assert_response 403
1065 1065 end
1066 1066
1067 1067 def test_show_should_deny_member_access_to_private_issue_without_permission
1068 1068 Issue.update_all(["is_private = ?", true], "id = 1")
1069 1069 @request.session[:user_id] = 3
1070 1070 get :show, :id => 1
1071 1071 assert_response 403
1072 1072 end
1073 1073
1074 1074 def test_show_should_allow_author_access_to_private_issue
1075 1075 Issue.update_all(["is_private = ?, author_id = 3", true], "id = 1")
1076 1076 @request.session[:user_id] = 3
1077 1077 get :show, :id => 1
1078 1078 assert_response :success
1079 1079 end
1080 1080
1081 1081 def test_show_should_allow_assignee_access_to_private_issue
1082 1082 Issue.update_all(["is_private = ?, assigned_to_id = 3", true], "id = 1")
1083 1083 @request.session[:user_id] = 3
1084 1084 get :show, :id => 1
1085 1085 assert_response :success
1086 1086 end
1087 1087
1088 1088 def test_show_should_allow_member_access_to_private_issue_with_permission
1089 1089 Issue.update_all(["is_private = ?", true], "id = 1")
1090 1090 User.find(3).roles_for_project(Project.find(1)).first.update_attribute :issues_visibility, 'all'
1091 1091 @request.session[:user_id] = 3
1092 1092 get :show, :id => 1
1093 1093 assert_response :success
1094 1094 end
1095 1095
1096 1096 def test_show_should_not_disclose_relations_to_invisible_issues
1097 1097 Setting.cross_project_issue_relations = '1'
1098 1098 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(2), :relation_type => 'relates')
1099 1099 # Relation to a private project issue
1100 1100 IssueRelation.create!(:issue_from => Issue.find(1), :issue_to => Issue.find(4), :relation_type => 'relates')
1101 1101
1102 1102 get :show, :id => 1
1103 1103 assert_response :success
1104 1104
1105 1105 assert_select 'div#relations' do
1106 1106 assert_select 'a', :text => /#2$/
1107 1107 assert_select 'a', :text => /#4$/, :count => 0
1108 1108 end
1109 1109 end
1110 1110
1111 1111 def test_show_should_list_subtasks
1112 1112 Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1113 1113
1114 1114 get :show, :id => 1
1115 1115 assert_response :success
1116 1116
1117 1117 assert_select 'div#issue_tree' do
1118 1118 assert_select 'td.subject', :text => /Child Issue/
1119 1119 end
1120 1120 end
1121 1121
1122 1122 def test_show_should_list_parents
1123 1123 issue = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :parent_issue_id => 1, :subject => 'Child Issue')
1124 1124
1125 1125 get :show, :id => issue.id
1126 1126 assert_response :success
1127 1127
1128 1128 assert_select 'div.subject' do
1129 1129 assert_select 'h3', 'Child Issue'
1130 1130 assert_select 'a[href=/issues/1]'
1131 1131 end
1132 1132 end
1133 1133
1134 1134 def test_show_should_not_display_prev_next_links_without_query_in_session
1135 1135 get :show, :id => 1
1136 1136 assert_response :success
1137 1137 assert_nil assigns(:prev_issue_id)
1138 1138 assert_nil assigns(:next_issue_id)
1139 1139
1140 1140 assert_select 'div.next-prev-links', 0
1141 1141 end
1142 1142
1143 1143 def test_show_should_display_prev_next_links_with_query_in_session
1144 1144 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1145 1145 @request.session['issues_index_sort'] = 'id'
1146 1146
1147 1147 with_settings :display_subprojects_issues => '0' do
1148 1148 get :show, :id => 3
1149 1149 end
1150 1150
1151 1151 assert_response :success
1152 1152 # Previous and next issues for all projects
1153 1153 assert_equal 2, assigns(:prev_issue_id)
1154 1154 assert_equal 5, assigns(:next_issue_id)
1155 1155
1156 1156 count = Issue.open.visible.count
1157 1157
1158 1158 assert_select 'div.next-prev-links' do
1159 1159 assert_select 'a[href=/issues/2]', :text => /Previous/
1160 1160 assert_select 'a[href=/issues/5]', :text => /Next/
1161 1161 assert_select 'span.position', :text => "3 of #{count}"
1162 1162 end
1163 1163 end
1164 1164
1165 1165 def test_show_should_display_prev_next_links_with_saved_query_in_session
1166 1166 query = IssueQuery.create!(:name => 'test', :is_public => true, :user_id => 1,
1167 1167 :filters => {'status_id' => {:values => ['5'], :operator => '='}},
1168 1168 :sort_criteria => [['id', 'asc']])
1169 1169 @request.session[:query] = {:id => query.id, :project_id => nil}
1170 1170
1171 1171 get :show, :id => 11
1172 1172
1173 1173 assert_response :success
1174 1174 assert_equal query, assigns(:query)
1175 1175 # Previous and next issues for all projects
1176 1176 assert_equal 8, assigns(:prev_issue_id)
1177 1177 assert_equal 12, assigns(:next_issue_id)
1178 1178
1179 1179 assert_select 'div.next-prev-links' do
1180 1180 assert_select 'a[href=/issues/8]', :text => /Previous/
1181 1181 assert_select 'a[href=/issues/12]', :text => /Next/
1182 1182 end
1183 1183 end
1184 1184
1185 1185 def test_show_should_display_prev_next_links_with_query_and_sort_on_association
1186 1186 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => nil}
1187 1187
1188 1188 %w(project tracker status priority author assigned_to category fixed_version).each do |assoc_sort|
1189 1189 @request.session['issues_index_sort'] = assoc_sort
1190 1190
1191 1191 get :show, :id => 3
1192 1192 assert_response :success, "Wrong response status for #{assoc_sort} sort"
1193 1193
1194 1194 assert_select 'div.next-prev-links' do
1195 1195 assert_select 'a', :text => /(Previous|Next)/
1196 1196 end
1197 1197 end
1198 1198 end
1199 1199
1200 1200 def test_show_should_display_prev_next_links_with_project_query_in_session
1201 1201 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1202 1202 @request.session['issues_index_sort'] = 'id'
1203 1203
1204 1204 with_settings :display_subprojects_issues => '0' do
1205 1205 get :show, :id => 3
1206 1206 end
1207 1207
1208 1208 assert_response :success
1209 1209 # Previous and next issues inside project
1210 1210 assert_equal 2, assigns(:prev_issue_id)
1211 1211 assert_equal 7, assigns(:next_issue_id)
1212 1212
1213 1213 assert_select 'div.next-prev-links' do
1214 1214 assert_select 'a[href=/issues/2]', :text => /Previous/
1215 1215 assert_select 'a[href=/issues/7]', :text => /Next/
1216 1216 end
1217 1217 end
1218 1218
1219 1219 def test_show_should_not_display_prev_link_for_first_issue
1220 1220 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'o'}}, :project_id => 1}
1221 1221 @request.session['issues_index_sort'] = 'id'
1222 1222
1223 1223 with_settings :display_subprojects_issues => '0' do
1224 1224 get :show, :id => 1
1225 1225 end
1226 1226
1227 1227 assert_response :success
1228 1228 assert_nil assigns(:prev_issue_id)
1229 1229 assert_equal 2, assigns(:next_issue_id)
1230 1230
1231 1231 assert_select 'div.next-prev-links' do
1232 1232 assert_select 'a', :text => /Previous/, :count => 0
1233 1233 assert_select 'a[href=/issues/2]', :text => /Next/
1234 1234 end
1235 1235 end
1236 1236
1237 1237 def test_show_should_not_display_prev_next_links_for_issue_not_in_query_results
1238 1238 @request.session[:query] = {:filters => {'status_id' => {:values => [''], :operator => 'c'}}, :project_id => 1}
1239 1239 @request.session['issues_index_sort'] = 'id'
1240 1240
1241 1241 get :show, :id => 1
1242 1242
1243 1243 assert_response :success
1244 1244 assert_nil assigns(:prev_issue_id)
1245 1245 assert_nil assigns(:next_issue_id)
1246 1246
1247 1247 assert_select 'a', :text => /Previous/, :count => 0
1248 1248 assert_select 'a', :text => /Next/, :count => 0
1249 1249 end
1250 1250
1251 1251 def test_show_show_should_display_prev_next_links_with_query_sort_by_user_custom_field
1252 1252 cf = IssueCustomField.create!(:name => 'User', :is_for_all => true, :tracker_ids => [1,2,3], :field_format => 'user')
1253 1253 CustomValue.create!(:custom_field => cf, :customized => Issue.find(1), :value => '2')
1254 1254 CustomValue.create!(:custom_field => cf, :customized => Issue.find(2), :value => '3')
1255 1255 CustomValue.create!(:custom_field => cf, :customized => Issue.find(3), :value => '3')
1256 1256 CustomValue.create!(:custom_field => cf, :customized => Issue.find(5), :value => '')
1257 1257
1258 1258 query = IssueQuery.create!(:name => 'test', :is_public => true, :user_id => 1, :filters => {},
1259 1259 :sort_criteria => [["cf_#{cf.id}", 'asc'], ['id', 'asc']])
1260 1260 @request.session[:query] = {:id => query.id, :project_id => nil}
1261 1261
1262 1262 get :show, :id => 3
1263 1263 assert_response :success
1264 1264
1265 1265 assert_equal 2, assigns(:prev_issue_id)
1266 1266 assert_equal 1, assigns(:next_issue_id)
1267 1267
1268 1268 assert_select 'div.next-prev-links' do
1269 1269 assert_select 'a[href=/issues/2]', :text => /Previous/
1270 1270 assert_select 'a[href=/issues/1]', :text => /Next/
1271 1271 end
1272 1272 end
1273 1273
1274 1274 def test_show_should_display_link_to_the_assignee
1275 1275 get :show, :id => 2
1276 1276 assert_response :success
1277 1277 assert_select '.assigned-to' do
1278 1278 assert_select 'a[href=/users/3]'
1279 1279 end
1280 1280 end
1281 1281
1282 1282 def test_show_should_display_visible_changesets_from_other_projects
1283 1283 project = Project.find(2)
1284 1284 issue = project.issues.first
1285 1285 issue.changeset_ids = [102]
1286 1286 issue.save!
1287 1287 # changesets from other projects should be displayed even if repository
1288 1288 # is disabled on issue's project
1289 1289 project.disable_module! :repository
1290 1290
1291 1291 @request.session[:user_id] = 2
1292 1292 get :show, :id => issue.id
1293 1293
1294 1294 assert_select 'a[href=?]', '/projects/ecookbook/repository/revisions/3'
1295 1295 end
1296 1296
1297 1297 def test_show_should_display_watchers
1298 1298 @request.session[:user_id] = 2
1299 1299 Issue.find(1).add_watcher User.find(2)
1300 1300
1301 1301 get :show, :id => 1
1302 1302 assert_select 'div#watchers ul' do
1303 1303 assert_select 'li' do
1304 1304 assert_select 'a[href=/users/2]'
1305 1305 assert_select 'a img[alt=Delete]'
1306 1306 end
1307 1307 end
1308 1308 end
1309 1309
1310 1310 def test_show_should_display_watchers_with_gravatars
1311 1311 @request.session[:user_id] = 2
1312 1312 Issue.find(1).add_watcher User.find(2)
1313 1313
1314 1314 with_settings :gravatar_enabled => '1' do
1315 1315 get :show, :id => 1
1316 1316 end
1317 1317
1318 1318 assert_select 'div#watchers ul' do
1319 1319 assert_select 'li' do
1320 1320 assert_select 'img.gravatar'
1321 1321 assert_select 'a[href=/users/2]'
1322 1322 assert_select 'a img[alt=Delete]'
1323 1323 end
1324 1324 end
1325 1325 end
1326 1326
1327 1327 def test_show_with_thumbnails_enabled_should_display_thumbnails
1328 1328 @request.session[:user_id] = 2
1329 1329
1330 1330 with_settings :thumbnails_enabled => '1' do
1331 1331 get :show, :id => 14
1332 1332 assert_response :success
1333 1333 end
1334 1334
1335 1335 assert_select 'div.thumbnails' do
1336 1336 assert_select 'a[href=/attachments/16/testfile.png]' do
1337 1337 assert_select 'img[src=/attachments/thumbnail/16]'
1338 1338 end
1339 1339 end
1340 1340 end
1341 1341
1342 1342 def test_show_with_thumbnails_disabled_should_not_display_thumbnails
1343 1343 @request.session[:user_id] = 2
1344 1344
1345 1345 with_settings :thumbnails_enabled => '0' do
1346 1346 get :show, :id => 14
1347 1347 assert_response :success
1348 1348 end
1349 1349
1350 1350 assert_select 'div.thumbnails', 0
1351 1351 end
1352 1352
1353 1353 def test_show_with_multi_custom_field
1354 1354 field = CustomField.find(1)
1355 1355 field.update_attribute :multiple, true
1356 1356 issue = Issue.find(1)
1357 1357 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
1358 1358 issue.save!
1359 1359
1360 1360 get :show, :id => 1
1361 1361 assert_response :success
1362 1362
1363 1363 assert_select 'td', :text => 'MySQL, Oracle'
1364 1364 end
1365 1365
1366 1366 def test_show_with_multi_user_custom_field
1367 1367 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1368 1368 :tracker_ids => [1], :is_for_all => true)
1369 1369 issue = Issue.find(1)
1370 1370 issue.custom_field_values = {field.id => ['2', '3']}
1371 1371 issue.save!
1372 1372
1373 1373 get :show, :id => 1
1374 1374 assert_response :success
1375 1375
1376 1376 # TODO: should display links
1377 1377 assert_select 'td', :text => 'Dave Lopper, John Smith'
1378 1378 end
1379 1379
1380 1380 def test_show_should_display_private_notes_with_permission_only
1381 1381 journal = Journal.create!(:journalized => Issue.find(2), :notes => 'Privates notes', :private_notes => true, :user_id => 1)
1382 1382 @request.session[:user_id] = 2
1383 1383
1384 1384 get :show, :id => 2
1385 1385 assert_response :success
1386 1386 assert_include journal, assigns(:journals)
1387 1387
1388 1388 Role.find(1).remove_permission! :view_private_notes
1389 1389 get :show, :id => 2
1390 1390 assert_response :success
1391 1391 assert_not_include journal, assigns(:journals)
1392 1392 end
1393 1393
1394 1394 def test_show_atom
1395 1395 get :show, :id => 2, :format => 'atom'
1396 1396 assert_response :success
1397 1397 assert_template 'journals/index'
1398 1398 # Inline image
1399 1399 assert_select 'content', :text => Regexp.new(Regexp.quote('http://test.host/attachments/download/10'))
1400 1400 end
1401 1401
1402 1402 def test_show_export_to_pdf
1403 1403 get :show, :id => 3, :format => 'pdf'
1404 1404 assert_response :success
1405 1405 assert_equal 'application/pdf', @response.content_type
1406 1406 assert @response.body.starts_with?('%PDF')
1407 1407 assert_not_nil assigns(:issue)
1408 1408 end
1409 1409
1410 1410 def test_show_export_to_pdf_with_ancestors
1411 1411 issue = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1412 1412
1413 1413 get :show, :id => issue.id, :format => 'pdf'
1414 1414 assert_response :success
1415 1415 assert_equal 'application/pdf', @response.content_type
1416 1416 assert @response.body.starts_with?('%PDF')
1417 1417 end
1418 1418
1419 1419 def test_show_export_to_pdf_with_descendants
1420 1420 c1 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1421 1421 c2 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => 1)
1422 1422 c3 = Issue.generate!(:project_id => 1, :author_id => 2, :tracker_id => 1, :subject => 'child', :parent_issue_id => c1.id)
1423 1423
1424 1424 get :show, :id => 1, :format => 'pdf'
1425 1425 assert_response :success
1426 1426 assert_equal 'application/pdf', @response.content_type
1427 1427 assert @response.body.starts_with?('%PDF')
1428 1428 end
1429 1429
1430 1430 def test_show_export_to_pdf_with_journals
1431 1431 get :show, :id => 1, :format => 'pdf'
1432 1432 assert_response :success
1433 1433 assert_equal 'application/pdf', @response.content_type
1434 1434 assert @response.body.starts_with?('%PDF')
1435 1435 end
1436 1436
1437 1437 def test_show_export_to_pdf_with_changesets
1438 1438 Issue.find(3).changesets = Changeset.find_all_by_id(100, 101, 102)
1439 1439
1440 1440 get :show, :id => 3, :format => 'pdf'
1441 1441 assert_response :success
1442 1442 assert_equal 'application/pdf', @response.content_type
1443 1443 assert @response.body.starts_with?('%PDF')
1444 1444 end
1445 1445
1446 1446 def test_show_invalid_should_respond_with_404
1447 1447 get :show, :id => 999
1448 1448 assert_response 404
1449 1449 end
1450 1450
1451 1451 def test_get_new
1452 1452 @request.session[:user_id] = 2
1453 1453 get :new, :project_id => 1, :tracker_id => 1
1454 1454 assert_response :success
1455 1455 assert_template 'new'
1456 1456
1457 1457 assert_select 'form#issue-form' do
1458 1458 assert_select 'input[name=?]', 'issue[is_private]'
1459 1459 assert_select 'select[name=?]', 'issue[project_id]', 0
1460 1460 assert_select 'select[name=?]', 'issue[tracker_id]'
1461 1461 assert_select 'input[name=?]', 'issue[subject]'
1462 1462 assert_select 'textarea[name=?]', 'issue[description]'
1463 1463 assert_select 'select[name=?]', 'issue[status_id]'
1464 1464 assert_select 'select[name=?]', 'issue[priority_id]'
1465 1465 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1466 1466 assert_select 'select[name=?]', 'issue[category_id]'
1467 1467 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1468 1468 assert_select 'input[name=?]', 'issue[parent_issue_id]'
1469 1469 assert_select 'input[name=?]', 'issue[start_date]'
1470 1470 assert_select 'input[name=?]', 'issue[due_date]'
1471 1471 assert_select 'select[name=?]', 'issue[done_ratio]'
1472 1472 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1473 1473 assert_select 'input[name=?]', 'issue[watcher_user_ids][]'
1474 1474 end
1475 1475
1476 1476 # Be sure we don't display inactive IssuePriorities
1477 1477 assert ! IssuePriority.find(15).active?
1478 1478 assert_select 'select[name=?]', 'issue[priority_id]' do
1479 1479 assert_select 'option[value=15]', 0
1480 1480 end
1481 1481 end
1482 1482
1483 1483 def test_get_new_with_minimal_permissions
1484 1484 Role.find(1).update_attribute :permissions, [:add_issues]
1485 1485 WorkflowTransition.delete_all :role_id => 1
1486 1486
1487 1487 @request.session[:user_id] = 2
1488 1488 get :new, :project_id => 1, :tracker_id => 1
1489 1489 assert_response :success
1490 1490 assert_template 'new'
1491 1491
1492 1492 assert_select 'form#issue-form' do
1493 1493 assert_select 'input[name=?]', 'issue[is_private]', 0
1494 1494 assert_select 'select[name=?]', 'issue[project_id]', 0
1495 1495 assert_select 'select[name=?]', 'issue[tracker_id]'
1496 1496 assert_select 'input[name=?]', 'issue[subject]'
1497 1497 assert_select 'textarea[name=?]', 'issue[description]'
1498 1498 assert_select 'select[name=?]', 'issue[status_id]'
1499 1499 assert_select 'select[name=?]', 'issue[priority_id]'
1500 1500 assert_select 'select[name=?]', 'issue[assigned_to_id]'
1501 1501 assert_select 'select[name=?]', 'issue[category_id]'
1502 1502 assert_select 'select[name=?]', 'issue[fixed_version_id]'
1503 1503 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
1504 1504 assert_select 'input[name=?]', 'issue[start_date]'
1505 1505 assert_select 'input[name=?]', 'issue[due_date]'
1506 1506 assert_select 'select[name=?]', 'issue[done_ratio]'
1507 1507 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Default string'
1508 1508 assert_select 'input[name=?]', 'issue[watcher_user_ids][]', 0
1509 1509 end
1510 1510 end
1511 1511
1512 1512 def test_get_new_with_list_custom_field
1513 1513 @request.session[:user_id] = 2
1514 1514 get :new, :project_id => 1, :tracker_id => 1
1515 1515 assert_response :success
1516 1516 assert_template 'new'
1517 1517
1518 1518 assert_select 'select.list_cf[name=?]', 'issue[custom_field_values][1]' do
1519 1519 assert_select 'option', 4
1520 1520 assert_select 'option[value=MySQL]', :text => 'MySQL'
1521 1521 end
1522 1522 end
1523 1523
1524 1524 def test_get_new_with_multi_custom_field
1525 1525 field = IssueCustomField.find(1)
1526 1526 field.update_attribute :multiple, true
1527 1527
1528 1528 @request.session[:user_id] = 2
1529 1529 get :new, :project_id => 1, :tracker_id => 1
1530 1530 assert_response :success
1531 1531 assert_template 'new'
1532 1532
1533 1533 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
1534 1534 assert_select 'option', 3
1535 1535 assert_select 'option[value=MySQL]', :text => 'MySQL'
1536 1536 end
1537 1537 assert_select 'input[name=?][type=hidden][value=?]', 'issue[custom_field_values][1][]', ''
1538 1538 end
1539 1539
1540 1540 def test_get_new_with_multi_user_custom_field
1541 1541 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1542 1542 :tracker_ids => [1], :is_for_all => true)
1543 1543
1544 1544 @request.session[:user_id] = 2
1545 1545 get :new, :project_id => 1, :tracker_id => 1
1546 1546 assert_response :success
1547 1547 assert_template 'new'
1548 1548
1549 1549 assert_select 'select[name=?][multiple=multiple]', "issue[custom_field_values][#{field.id}][]" do
1550 1550 assert_select 'option', Project.find(1).users.count
1551 1551 assert_select 'option[value=2]', :text => 'John Smith'
1552 1552 end
1553 1553 assert_select 'input[name=?][type=hidden][value=?]', "issue[custom_field_values][#{field.id}][]", ''
1554 1554 end
1555 1555
1556 1556 def test_get_new_with_date_custom_field
1557 1557 field = IssueCustomField.create!(:name => 'Date', :field_format => 'date', :tracker_ids => [1], :is_for_all => true)
1558 1558
1559 1559 @request.session[:user_id] = 2
1560 1560 get :new, :project_id => 1, :tracker_id => 1
1561 1561 assert_response :success
1562 1562
1563 1563 assert_select 'input[name=?]', "issue[custom_field_values][#{field.id}]"
1564 1564 end
1565 1565
1566 1566 def test_get_new_with_text_custom_field
1567 1567 field = IssueCustomField.create!(:name => 'Text', :field_format => 'text', :tracker_ids => [1], :is_for_all => true)
1568 1568
1569 1569 @request.session[:user_id] = 2
1570 1570 get :new, :project_id => 1, :tracker_id => 1
1571 1571 assert_response :success
1572 1572
1573 1573 assert_select 'textarea[name=?]', "issue[custom_field_values][#{field.id}]"
1574 1574 end
1575 1575
1576 1576 def test_get_new_without_default_start_date_is_creation_date
1577 1577 Setting.default_issue_start_date_to_creation_date = 0
1578 1578
1579 1579 @request.session[:user_id] = 2
1580 1580 get :new, :project_id => 1, :tracker_id => 1
1581 1581 assert_response :success
1582 1582 assert_template 'new'
1583 1583
1584 1584 assert_select 'input[name=?]', 'issue[start_date]'
1585 1585 assert_select 'input[name=?][value]', 'issue[start_date]', 0
1586 1586 end
1587 1587
1588 1588 def test_get_new_with_default_start_date_is_creation_date
1589 1589 Setting.default_issue_start_date_to_creation_date = 1
1590 1590
1591 1591 @request.session[:user_id] = 2
1592 1592 get :new, :project_id => 1, :tracker_id => 1
1593 1593 assert_response :success
1594 1594 assert_template 'new'
1595 1595
1596 1596 assert_select 'input[name=?][value=?]', 'issue[start_date]', Date.today.to_s
1597 1597 end
1598 1598
1599 1599 def test_get_new_form_should_allow_attachment_upload
1600 1600 @request.session[:user_id] = 2
1601 1601 get :new, :project_id => 1, :tracker_id => 1
1602 1602
1603 1603 assert_select 'form[id=issue-form][method=post][enctype=multipart/form-data]' do
1604 1604 assert_select 'input[name=?][type=file]', 'attachments[dummy][file]'
1605 1605 end
1606 1606 end
1607 1607
1608 1608 def test_get_new_should_prefill_the_form_from_params
1609 1609 @request.session[:user_id] = 2
1610 1610 get :new, :project_id => 1,
1611 1611 :issue => {:tracker_id => 3, :description => 'Prefilled', :custom_field_values => {'2' => 'Custom field value'}}
1612 1612
1613 1613 issue = assigns(:issue)
1614 1614 assert_equal 3, issue.tracker_id
1615 1615 assert_equal 'Prefilled', issue.description
1616 1616 assert_equal 'Custom field value', issue.custom_field_value(2)
1617 1617
1618 1618 assert_select 'select[name=?]', 'issue[tracker_id]' do
1619 1619 assert_select 'option[value=3][selected=selected]'
1620 1620 end
1621 1621 assert_select 'textarea[name=?]', 'issue[description]', :text => /Prefilled/
1622 1622 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Custom field value'
1623 1623 end
1624 1624
1625 1625 def test_get_new_should_mark_required_fields
1626 1626 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1627 1627 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1628 1628 WorkflowPermission.delete_all
1629 1629 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1630 1630 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1631 1631 @request.session[:user_id] = 2
1632 1632
1633 1633 get :new, :project_id => 1
1634 1634 assert_response :success
1635 1635 assert_template 'new'
1636 1636
1637 1637 assert_select 'label[for=issue_start_date]' do
1638 1638 assert_select 'span[class=required]', 0
1639 1639 end
1640 1640 assert_select 'label[for=issue_due_date]' do
1641 1641 assert_select 'span[class=required]'
1642 1642 end
1643 1643 assert_select 'label[for=?]', "issue_custom_field_values_#{cf1.id}" do
1644 1644 assert_select 'span[class=required]', 0
1645 1645 end
1646 1646 assert_select 'label[for=?]', "issue_custom_field_values_#{cf2.id}" do
1647 1647 assert_select 'span[class=required]'
1648 1648 end
1649 1649 end
1650 1650
1651 1651 def test_get_new_should_not_display_readonly_fields
1652 1652 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1653 1653 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1654 1654 WorkflowPermission.delete_all
1655 1655 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1656 1656 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1657 1657 @request.session[:user_id] = 2
1658 1658
1659 1659 get :new, :project_id => 1
1660 1660 assert_response :success
1661 1661 assert_template 'new'
1662 1662
1663 1663 assert_select 'input[name=?]', 'issue[start_date]'
1664 1664 assert_select 'input[name=?]', 'issue[due_date]', 0
1665 1665 assert_select 'input[name=?]', "issue[custom_field_values][#{cf1.id}]"
1666 1666 assert_select 'input[name=?]', "issue[custom_field_values][#{cf2.id}]", 0
1667 1667 end
1668 1668
1669 1669 def test_get_new_without_tracker_id
1670 1670 @request.session[:user_id] = 2
1671 1671 get :new, :project_id => 1
1672 1672 assert_response :success
1673 1673 assert_template 'new'
1674 1674
1675 1675 issue = assigns(:issue)
1676 1676 assert_not_nil issue
1677 1677 assert_equal Project.find(1).trackers.first, issue.tracker
1678 1678 end
1679 1679
1680 1680 def test_get_new_with_no_default_status_should_display_an_error
1681 1681 @request.session[:user_id] = 2
1682 1682 IssueStatus.delete_all
1683 1683
1684 1684 get :new, :project_id => 1
1685 1685 assert_response 500
1686 1686 assert_error_tag :content => /No default issue/
1687 1687 end
1688 1688
1689 1689 def test_get_new_with_no_tracker_should_display_an_error
1690 1690 @request.session[:user_id] = 2
1691 1691 Tracker.delete_all
1692 1692
1693 1693 get :new, :project_id => 1
1694 1694 assert_response 500
1695 1695 assert_error_tag :content => /No tracker/
1696 1696 end
1697 1697
1698 1698 def test_update_form_for_new_issue
1699 1699 @request.session[:user_id] = 2
1700 1700 xhr :post, :update_form, :project_id => 1,
1701 1701 :issue => {:tracker_id => 2,
1702 1702 :subject => 'This is the test_new issue',
1703 1703 :description => 'This is the description',
1704 1704 :priority_id => 5}
1705 1705 assert_response :success
1706 1706 assert_template 'update_form'
1707 1707 assert_template 'form'
1708 1708 assert_equal 'text/javascript', response.content_type
1709 1709
1710 1710 issue = assigns(:issue)
1711 1711 assert_kind_of Issue, issue
1712 1712 assert_equal 1, issue.project_id
1713 1713 assert_equal 2, issue.tracker_id
1714 1714 assert_equal 'This is the test_new issue', issue.subject
1715 1715 end
1716 1716
1717 1717 def test_update_form_for_new_issue_should_propose_transitions_based_on_initial_status
1718 1718 @request.session[:user_id] = 2
1719 1719 WorkflowTransition.delete_all
1720 1720 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 2)
1721 1721 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 5)
1722 1722 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 5, :new_status_id => 4)
1723 1723
1724 1724 xhr :post, :update_form, :project_id => 1,
1725 1725 :issue => {:tracker_id => 1,
1726 1726 :status_id => 5,
1727 1727 :subject => 'This is an issue'}
1728 1728
1729 1729 assert_equal 5, assigns(:issue).status_id
1730 1730 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
1731 1731 end
1732 1732
1733 1733 def test_post_create
1734 1734 @request.session[:user_id] = 2
1735 1735 assert_difference 'Issue.count' do
1736 1736 post :create, :project_id => 1,
1737 1737 :issue => {:tracker_id => 3,
1738 1738 :status_id => 2,
1739 1739 :subject => 'This is the test_new issue',
1740 1740 :description => 'This is the description',
1741 1741 :priority_id => 5,
1742 1742 :start_date => '2010-11-07',
1743 1743 :estimated_hours => '',
1744 1744 :custom_field_values => {'2' => 'Value for field 2'}}
1745 1745 end
1746 1746 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1747 1747
1748 1748 issue = Issue.find_by_subject('This is the test_new issue')
1749 1749 assert_not_nil issue
1750 1750 assert_equal 2, issue.author_id
1751 1751 assert_equal 3, issue.tracker_id
1752 1752 assert_equal 2, issue.status_id
1753 1753 assert_equal Date.parse('2010-11-07'), issue.start_date
1754 1754 assert_nil issue.estimated_hours
1755 1755 v = issue.custom_values.where(:custom_field_id => 2).first
1756 1756 assert_not_nil v
1757 1757 assert_equal 'Value for field 2', v.value
1758 1758 end
1759 1759
1760 1760 def test_post_new_with_group_assignment
1761 1761 group = Group.find(11)
1762 1762 project = Project.find(1)
1763 1763 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
1764 1764
1765 1765 with_settings :issue_group_assignment => '1' do
1766 1766 @request.session[:user_id] = 2
1767 1767 assert_difference 'Issue.count' do
1768 1768 post :create, :project_id => project.id,
1769 1769 :issue => {:tracker_id => 3,
1770 1770 :status_id => 1,
1771 1771 :subject => 'This is the test_new_with_group_assignment issue',
1772 1772 :assigned_to_id => group.id}
1773 1773 end
1774 1774 end
1775 1775 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1776 1776
1777 1777 issue = Issue.find_by_subject('This is the test_new_with_group_assignment issue')
1778 1778 assert_not_nil issue
1779 1779 assert_equal group, issue.assigned_to
1780 1780 end
1781 1781
1782 1782 def test_post_create_without_start_date_and_default_start_date_is_not_creation_date
1783 1783 Setting.default_issue_start_date_to_creation_date = 0
1784 1784
1785 1785 @request.session[:user_id] = 2
1786 1786 assert_difference 'Issue.count' do
1787 1787 post :create, :project_id => 1,
1788 1788 :issue => {:tracker_id => 3,
1789 1789 :status_id => 2,
1790 1790 :subject => 'This is the test_new issue',
1791 1791 :description => 'This is the description',
1792 1792 :priority_id => 5,
1793 1793 :estimated_hours => '',
1794 1794 :custom_field_values => {'2' => 'Value for field 2'}}
1795 1795 end
1796 1796 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1797 1797
1798 1798 issue = Issue.find_by_subject('This is the test_new issue')
1799 1799 assert_not_nil issue
1800 1800 assert_nil issue.start_date
1801 1801 end
1802 1802
1803 1803 def test_post_create_without_start_date_and_default_start_date_is_creation_date
1804 1804 Setting.default_issue_start_date_to_creation_date = 1
1805 1805
1806 1806 @request.session[:user_id] = 2
1807 1807 assert_difference 'Issue.count' do
1808 1808 post :create, :project_id => 1,
1809 1809 :issue => {:tracker_id => 3,
1810 1810 :status_id => 2,
1811 1811 :subject => 'This is the test_new issue',
1812 1812 :description => 'This is the description',
1813 1813 :priority_id => 5,
1814 1814 :estimated_hours => '',
1815 1815 :custom_field_values => {'2' => 'Value for field 2'}}
1816 1816 end
1817 1817 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1818 1818
1819 1819 issue = Issue.find_by_subject('This is the test_new issue')
1820 1820 assert_not_nil issue
1821 1821 assert_equal Date.today, issue.start_date
1822 1822 end
1823 1823
1824 1824 def test_post_create_and_continue
1825 1825 @request.session[:user_id] = 2
1826 1826 assert_difference 'Issue.count' do
1827 1827 post :create, :project_id => 1,
1828 1828 :issue => {:tracker_id => 3, :subject => 'This is first issue', :priority_id => 5},
1829 1829 :continue => ''
1830 1830 end
1831 1831
1832 1832 issue = Issue.first(:order => 'id DESC')
1833 1833 assert_redirected_to :controller => 'issues', :action => 'new', :project_id => 'ecookbook', :issue => {:tracker_id => 3}
1834 1834 assert_not_nil flash[:notice], "flash was not set"
1835 1835 assert_include %|<a href="/issues/#{issue.id}" title="This is first issue">##{issue.id}</a>|, flash[:notice], "issue link not found in the flash message"
1836 1836 end
1837 1837
1838 1838 def test_post_create_without_custom_fields_param
1839 1839 @request.session[:user_id] = 2
1840 1840 assert_difference 'Issue.count' do
1841 1841 post :create, :project_id => 1,
1842 1842 :issue => {:tracker_id => 1,
1843 1843 :subject => 'This is the test_new issue',
1844 1844 :description => 'This is the description',
1845 1845 :priority_id => 5}
1846 1846 end
1847 1847 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
1848 1848 end
1849 1849
1850 1850 def test_post_create_with_multi_custom_field
1851 1851 field = IssueCustomField.find_by_name('Database')
1852 1852 field.update_attribute(:multiple, true)
1853 1853
1854 1854 @request.session[:user_id] = 2
1855 1855 assert_difference 'Issue.count' do
1856 1856 post :create, :project_id => 1,
1857 1857 :issue => {:tracker_id => 1,
1858 1858 :subject => 'This is the test_new issue',
1859 1859 :description => 'This is the description',
1860 1860 :priority_id => 5,
1861 1861 :custom_field_values => {'1' => ['', 'MySQL', 'Oracle']}}
1862 1862 end
1863 1863 assert_response 302
1864 1864 issue = Issue.first(:order => 'id DESC')
1865 1865 assert_equal ['MySQL', 'Oracle'], issue.custom_field_value(1).sort
1866 1866 end
1867 1867
1868 1868 def test_post_create_with_empty_multi_custom_field
1869 1869 field = IssueCustomField.find_by_name('Database')
1870 1870 field.update_attribute(:multiple, true)
1871 1871
1872 1872 @request.session[:user_id] = 2
1873 1873 assert_difference 'Issue.count' do
1874 1874 post :create, :project_id => 1,
1875 1875 :issue => {:tracker_id => 1,
1876 1876 :subject => 'This is the test_new issue',
1877 1877 :description => 'This is the description',
1878 1878 :priority_id => 5,
1879 1879 :custom_field_values => {'1' => ['']}}
1880 1880 end
1881 1881 assert_response 302
1882 1882 issue = Issue.first(:order => 'id DESC')
1883 1883 assert_equal [''], issue.custom_field_value(1).sort
1884 1884 end
1885 1885
1886 1886 def test_post_create_with_multi_user_custom_field
1887 1887 field = IssueCustomField.create!(:name => 'Multi user', :field_format => 'user', :multiple => true,
1888 1888 :tracker_ids => [1], :is_for_all => true)
1889 1889
1890 1890 @request.session[:user_id] = 2
1891 1891 assert_difference 'Issue.count' do
1892 1892 post :create, :project_id => 1,
1893 1893 :issue => {:tracker_id => 1,
1894 1894 :subject => 'This is the test_new issue',
1895 1895 :description => 'This is the description',
1896 1896 :priority_id => 5,
1897 1897 :custom_field_values => {field.id.to_s => ['', '2', '3']}}
1898 1898 end
1899 1899 assert_response 302
1900 1900 issue = Issue.first(:order => 'id DESC')
1901 1901 assert_equal ['2', '3'], issue.custom_field_value(field).sort
1902 1902 end
1903 1903
1904 1904 def test_post_create_with_required_custom_field_and_without_custom_fields_param
1905 1905 field = IssueCustomField.find_by_name('Database')
1906 1906 field.update_attribute(:is_required, true)
1907 1907
1908 1908 @request.session[:user_id] = 2
1909 1909 assert_no_difference 'Issue.count' do
1910 1910 post :create, :project_id => 1,
1911 1911 :issue => {:tracker_id => 1,
1912 1912 :subject => 'This is the test_new issue',
1913 1913 :description => 'This is the description',
1914 1914 :priority_id => 5}
1915 1915 end
1916 1916 assert_response :success
1917 1917 assert_template 'new'
1918 1918 issue = assigns(:issue)
1919 1919 assert_not_nil issue
1920 1920 assert_error_tag :content => /Database can&#x27;t be blank/
1921 1921 end
1922 1922
1923 1923 def test_create_should_validate_required_fields
1924 1924 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1925 1925 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1926 1926 WorkflowPermission.delete_all
1927 1927 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'required')
1928 1928 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'required')
1929 1929 @request.session[:user_id] = 2
1930 1930
1931 1931 assert_no_difference 'Issue.count' do
1932 1932 post :create, :project_id => 1, :issue => {
1933 1933 :tracker_id => 2,
1934 1934 :status_id => 1,
1935 1935 :subject => 'Test',
1936 1936 :start_date => '',
1937 1937 :due_date => '',
1938 1938 :custom_field_values => {cf1.id.to_s => '', cf2.id.to_s => ''}
1939 1939 }
1940 1940 assert_response :success
1941 1941 assert_template 'new'
1942 1942 end
1943 1943
1944 1944 assert_error_tag :content => /Due date can&#x27;t be blank/i
1945 1945 assert_error_tag :content => /Bar can&#x27;t be blank/i
1946 1946 end
1947 1947
1948 1948 def test_create_should_ignore_readonly_fields
1949 1949 cf1 = IssueCustomField.create!(:name => 'Foo', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1950 1950 cf2 = IssueCustomField.create!(:name => 'Bar', :field_format => 'string', :is_for_all => true, :tracker_ids => [1, 2])
1951 1951 WorkflowPermission.delete_all
1952 1952 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => 'due_date', :rule => 'readonly')
1953 1953 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2, :role_id => 1, :field_name => cf2.id.to_s, :rule => 'readonly')
1954 1954 @request.session[:user_id] = 2
1955 1955
1956 1956 assert_difference 'Issue.count' do
1957 1957 post :create, :project_id => 1, :issue => {
1958 1958 :tracker_id => 2,
1959 1959 :status_id => 1,
1960 1960 :subject => 'Test',
1961 1961 :start_date => '2012-07-14',
1962 1962 :due_date => '2012-07-16',
1963 1963 :custom_field_values => {cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'}
1964 1964 }
1965 1965 assert_response 302
1966 1966 end
1967 1967
1968 1968 issue = Issue.first(:order => 'id DESC')
1969 1969 assert_equal Date.parse('2012-07-14'), issue.start_date
1970 1970 assert_nil issue.due_date
1971 1971 assert_equal 'value1', issue.custom_field_value(cf1)
1972 1972 assert_nil issue.custom_field_value(cf2)
1973 1973 end
1974 1974
1975 1975 def test_post_create_with_watchers
1976 1976 @request.session[:user_id] = 2
1977 1977 ActionMailer::Base.deliveries.clear
1978 1978
1979 1979 assert_difference 'Watcher.count', 2 do
1980 1980 post :create, :project_id => 1,
1981 1981 :issue => {:tracker_id => 1,
1982 1982 :subject => 'This is a new issue with watchers',
1983 1983 :description => 'This is the description',
1984 1984 :priority_id => 5,
1985 1985 :watcher_user_ids => ['2', '3']}
1986 1986 end
1987 1987 issue = Issue.find_by_subject('This is a new issue with watchers')
1988 1988 assert_not_nil issue
1989 1989 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
1990 1990
1991 1991 # Watchers added
1992 1992 assert_equal [2, 3], issue.watcher_user_ids.sort
1993 1993 assert issue.watched_by?(User.find(3))
1994 1994 # Watchers notified
1995 1995 mail = ActionMailer::Base.deliveries.last
1996 1996 assert_not_nil mail
1997 1997 assert [mail.bcc, mail.cc].flatten.include?(User.find(3).mail)
1998 1998 end
1999 1999
2000 2000 def test_post_create_subissue
2001 2001 @request.session[:user_id] = 2
2002 2002
2003 2003 assert_difference 'Issue.count' do
2004 2004 post :create, :project_id => 1,
2005 2005 :issue => {:tracker_id => 1,
2006 2006 :subject => 'This is a child issue',
2007 2007 :parent_issue_id => '2'}
2008 2008 assert_response 302
2009 2009 end
2010 2010 issue = Issue.order('id DESC').first
2011 2011 assert_equal Issue.find(2), issue.parent
2012 2012 end
2013 2013
2014 2014 def test_post_create_subissue_with_sharp_parent_id
2015 2015 @request.session[:user_id] = 2
2016 2016
2017 2017 assert_difference 'Issue.count' do
2018 2018 post :create, :project_id => 1,
2019 2019 :issue => {:tracker_id => 1,
2020 2020 :subject => 'This is a child issue',
2021 2021 :parent_issue_id => '#2'}
2022 2022 assert_response 302
2023 2023 end
2024 2024 issue = Issue.order('id DESC').first
2025 2025 assert_equal Issue.find(2), issue.parent
2026 2026 end
2027 2027
2028 2028 def test_post_create_subissue_with_non_visible_parent_id_should_not_validate
2029 2029 @request.session[:user_id] = 2
2030 2030
2031 2031 assert_no_difference 'Issue.count' do
2032 2032 post :create, :project_id => 1,
2033 2033 :issue => {:tracker_id => 1,
2034 2034 :subject => 'This is a child issue',
2035 2035 :parent_issue_id => '4'}
2036 2036
2037 2037 assert_response :success
2038 2038 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '4'
2039 2039 assert_error_tag :content => /Parent task is invalid/i
2040 2040 end
2041 2041 end
2042 2042
2043 2043 def test_post_create_subissue_with_non_numeric_parent_id_should_not_validate
2044 2044 @request.session[:user_id] = 2
2045 2045
2046 2046 assert_no_difference 'Issue.count' do
2047 2047 post :create, :project_id => 1,
2048 2048 :issue => {:tracker_id => 1,
2049 2049 :subject => 'This is a child issue',
2050 2050 :parent_issue_id => '01ABC'}
2051 2051
2052 2052 assert_response :success
2053 2053 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', '01ABC'
2054 2054 assert_error_tag :content => /Parent task is invalid/i
2055 2055 end
2056 2056 end
2057 2057
2058 2058 def test_post_create_private
2059 2059 @request.session[:user_id] = 2
2060 2060
2061 2061 assert_difference 'Issue.count' do
2062 2062 post :create, :project_id => 1,
2063 2063 :issue => {:tracker_id => 1,
2064 2064 :subject => 'This is a private issue',
2065 2065 :is_private => '1'}
2066 2066 end
2067 2067 issue = Issue.first(:order => 'id DESC')
2068 2068 assert issue.is_private?
2069 2069 end
2070 2070
2071 2071 def test_post_create_private_with_set_own_issues_private_permission
2072 2072 role = Role.find(1)
2073 2073 role.remove_permission! :set_issues_private
2074 2074 role.add_permission! :set_own_issues_private
2075 2075
2076 2076 @request.session[:user_id] = 2
2077 2077
2078 2078 assert_difference 'Issue.count' do
2079 2079 post :create, :project_id => 1,
2080 2080 :issue => {:tracker_id => 1,
2081 2081 :subject => 'This is a private issue',
2082 2082 :is_private => '1'}
2083 2083 end
2084 2084 issue = Issue.first(:order => 'id DESC')
2085 2085 assert issue.is_private?
2086 2086 end
2087 2087
2088 2088 def test_post_create_should_send_a_notification
2089 2089 ActionMailer::Base.deliveries.clear
2090 2090 @request.session[:user_id] = 2
2091 2091 assert_difference 'Issue.count' do
2092 2092 post :create, :project_id => 1,
2093 2093 :issue => {:tracker_id => 3,
2094 2094 :subject => 'This is the test_new issue',
2095 2095 :description => 'This is the description',
2096 2096 :priority_id => 5,
2097 2097 :estimated_hours => '',
2098 2098 :custom_field_values => {'2' => 'Value for field 2'}}
2099 2099 end
2100 2100 assert_redirected_to :controller => 'issues', :action => 'show', :id => Issue.last.id
2101 2101
2102 2102 assert_equal 1, ActionMailer::Base.deliveries.size
2103 2103 end
2104 2104
2105 2105 def test_post_create_should_preserve_fields_values_on_validation_failure
2106 2106 @request.session[:user_id] = 2
2107 2107 post :create, :project_id => 1,
2108 2108 :issue => {:tracker_id => 1,
2109 2109 # empty subject
2110 2110 :subject => '',
2111 2111 :description => 'This is a description',
2112 2112 :priority_id => 6,
2113 2113 :custom_field_values => {'1' => 'Oracle', '2' => 'Value for field 2'}}
2114 2114 assert_response :success
2115 2115 assert_template 'new'
2116 2116
2117 2117 assert_select 'textarea[name=?]', 'issue[description]', :text => 'This is a description'
2118 2118 assert_select 'select[name=?]', 'issue[priority_id]' do
2119 2119 assert_select 'option[value=6][selected=selected]', :text => 'High'
2120 2120 end
2121 2121 # Custom fields
2122 2122 assert_select 'select[name=?]', 'issue[custom_field_values][1]' do
2123 2123 assert_select 'option[value=Oracle][selected=selected]', :text => 'Oracle'
2124 2124 end
2125 2125 assert_select 'input[name=?][value=?]', 'issue[custom_field_values][2]', 'Value for field 2'
2126 2126 end
2127 2127
2128 2128 def test_post_create_with_failure_should_preserve_watchers
2129 2129 assert !User.find(8).member_of?(Project.find(1))
2130 2130
2131 2131 @request.session[:user_id] = 2
2132 2132 post :create, :project_id => 1,
2133 2133 :issue => {:tracker_id => 1,
2134 2134 :watcher_user_ids => ['3', '8']}
2135 2135 assert_response :success
2136 2136 assert_template 'new'
2137 2137
2138 2138 assert_select 'input[name=?][value=2]:not(checked)', 'issue[watcher_user_ids][]'
2139 2139 assert_select 'input[name=?][value=3][checked=checked]', 'issue[watcher_user_ids][]'
2140 2140 assert_select 'input[name=?][value=8][checked=checked]', 'issue[watcher_user_ids][]'
2141 2141 end
2142 2142
2143 2143 def test_post_create_should_ignore_non_safe_attributes
2144 2144 @request.session[:user_id] = 2
2145 2145 assert_nothing_raised do
2146 2146 post :create, :project_id => 1, :issue => { :tracker => "A param can not be a Tracker" }
2147 2147 end
2148 2148 end
2149 2149
2150 2150 def test_post_create_with_attachment
2151 2151 set_tmp_attachments_directory
2152 2152 @request.session[:user_id] = 2
2153 2153
2154 2154 assert_difference 'Issue.count' do
2155 2155 assert_difference 'Attachment.count' do
2156 2156 post :create, :project_id => 1,
2157 2157 :issue => { :tracker_id => '1', :subject => 'With attachment' },
2158 2158 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2159 2159 end
2160 2160 end
2161 2161
2162 2162 issue = Issue.first(:order => 'id DESC')
2163 2163 attachment = Attachment.first(:order => 'id DESC')
2164 2164
2165 2165 assert_equal issue, attachment.container
2166 2166 assert_equal 2, attachment.author_id
2167 2167 assert_equal 'testfile.txt', attachment.filename
2168 2168 assert_equal 'text/plain', attachment.content_type
2169 2169 assert_equal 'test file', attachment.description
2170 2170 assert_equal 59, attachment.filesize
2171 2171 assert File.exists?(attachment.diskfile)
2172 2172 assert_equal 59, File.size(attachment.diskfile)
2173 2173 end
2174 2174
2175 2175 def test_post_create_with_failure_should_save_attachments
2176 2176 set_tmp_attachments_directory
2177 2177 @request.session[:user_id] = 2
2178 2178
2179 2179 assert_no_difference 'Issue.count' do
2180 2180 assert_difference 'Attachment.count' do
2181 2181 post :create, :project_id => 1,
2182 2182 :issue => { :tracker_id => '1', :subject => '' },
2183 2183 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2184 2184 assert_response :success
2185 2185 assert_template 'new'
2186 2186 end
2187 2187 end
2188 2188
2189 2189 attachment = Attachment.first(:order => 'id DESC')
2190 2190 assert_equal 'testfile.txt', attachment.filename
2191 2191 assert File.exists?(attachment.diskfile)
2192 2192 assert_nil attachment.container
2193 2193
2194 2194 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2195 2195 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2196 2196 end
2197 2197
2198 2198 def test_post_create_with_failure_should_keep_saved_attachments
2199 2199 set_tmp_attachments_directory
2200 2200 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2201 2201 @request.session[:user_id] = 2
2202 2202
2203 2203 assert_no_difference 'Issue.count' do
2204 2204 assert_no_difference 'Attachment.count' do
2205 2205 post :create, :project_id => 1,
2206 2206 :issue => { :tracker_id => '1', :subject => '' },
2207 2207 :attachments => {'p0' => {'token' => attachment.token}}
2208 2208 assert_response :success
2209 2209 assert_template 'new'
2210 2210 end
2211 2211 end
2212 2212
2213 2213 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
2214 2214 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
2215 2215 end
2216 2216
2217 2217 def test_post_create_should_attach_saved_attachments
2218 2218 set_tmp_attachments_directory
2219 2219 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
2220 2220 @request.session[:user_id] = 2
2221 2221
2222 2222 assert_difference 'Issue.count' do
2223 2223 assert_no_difference 'Attachment.count' do
2224 2224 post :create, :project_id => 1,
2225 2225 :issue => { :tracker_id => '1', :subject => 'Saved attachments' },
2226 2226 :attachments => {'p0' => {'token' => attachment.token}}
2227 2227 assert_response 302
2228 2228 end
2229 2229 end
2230 2230
2231 2231 issue = Issue.first(:order => 'id DESC')
2232 2232 assert_equal 1, issue.attachments.count
2233 2233
2234 2234 attachment.reload
2235 2235 assert_equal issue, attachment.container
2236 2236 end
2237 2237
2238 2238 context "without workflow privilege" do
2239 2239 setup do
2240 2240 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2241 2241 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2242 2242 end
2243 2243
2244 2244 context "#new" do
2245 2245 should "propose default status only" do
2246 2246 get :new, :project_id => 1
2247 2247 assert_response :success
2248 2248 assert_template 'new'
2249 2249 assert_select 'select[name=?]', 'issue[status_id]' do
2250 2250 assert_select 'option', 1
2251 2251 assert_select 'option[value=?]', IssueStatus.default.id.to_s
2252 2252 end
2253 2253 end
2254 2254
2255 2255 should "accept default status" do
2256 2256 assert_difference 'Issue.count' do
2257 2257 post :create, :project_id => 1,
2258 2258 :issue => {:tracker_id => 1,
2259 2259 :subject => 'This is an issue',
2260 2260 :status_id => 1}
2261 2261 end
2262 2262 issue = Issue.last(:order => 'id')
2263 2263 assert_equal IssueStatus.default, issue.status
2264 2264 end
2265 2265
2266 2266 should "ignore unauthorized status" do
2267 2267 assert_difference 'Issue.count' do
2268 2268 post :create, :project_id => 1,
2269 2269 :issue => {:tracker_id => 1,
2270 2270 :subject => 'This is an issue',
2271 2271 :status_id => 3}
2272 2272 end
2273 2273 issue = Issue.last(:order => 'id')
2274 2274 assert_equal IssueStatus.default, issue.status
2275 2275 end
2276 2276 end
2277 2277
2278 2278 context "#update" do
2279 2279 should "ignore status change" do
2280 2280 assert_difference 'Journal.count' do
2281 2281 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2282 2282 end
2283 2283 assert_equal 1, Issue.find(1).status_id
2284 2284 end
2285 2285
2286 2286 should "ignore attributes changes" do
2287 2287 assert_difference 'Journal.count' do
2288 2288 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2289 2289 end
2290 2290 issue = Issue.find(1)
2291 2291 assert_equal "Can't print recipes", issue.subject
2292 2292 assert_nil issue.assigned_to
2293 2293 end
2294 2294 end
2295 2295 end
2296 2296
2297 2297 context "with workflow privilege" do
2298 2298 setup do
2299 2299 WorkflowTransition.delete_all(["role_id = ?", Role.anonymous.id])
2300 2300 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
2301 2301 WorkflowTransition.create!(:role => Role.anonymous, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
2302 2302 Role.anonymous.add_permission! :add_issues, :add_issue_notes
2303 2303 end
2304 2304
2305 2305 context "#update" do
2306 2306 should "accept authorized status" do
2307 2307 assert_difference 'Journal.count' do
2308 2308 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2309 2309 end
2310 2310 assert_equal 3, Issue.find(1).status_id
2311 2311 end
2312 2312
2313 2313 should "ignore unauthorized status" do
2314 2314 assert_difference 'Journal.count' do
2315 2315 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2316 2316 end
2317 2317 assert_equal 1, Issue.find(1).status_id
2318 2318 end
2319 2319
2320 2320 should "accept authorized attributes changes" do
2321 2321 assert_difference 'Journal.count' do
2322 2322 put :update, :id => 1, :issue => {:assigned_to_id => 2, :notes => 'just trying'}
2323 2323 end
2324 2324 issue = Issue.find(1)
2325 2325 assert_equal 2, issue.assigned_to_id
2326 2326 end
2327 2327
2328 2328 should "ignore unauthorized attributes changes" do
2329 2329 assert_difference 'Journal.count' do
2330 2330 put :update, :id => 1, :issue => {:subject => 'changed', :notes => 'just trying'}
2331 2331 end
2332 2332 issue = Issue.find(1)
2333 2333 assert_equal "Can't print recipes", issue.subject
2334 2334 end
2335 2335 end
2336 2336
2337 2337 context "and :edit_issues permission" do
2338 2338 setup do
2339 2339 Role.anonymous.add_permission! :add_issues, :edit_issues
2340 2340 end
2341 2341
2342 2342 should "accept authorized status" do
2343 2343 assert_difference 'Journal.count' do
2344 2344 put :update, :id => 1, :issue => {:status_id => 3, :notes => 'just trying'}
2345 2345 end
2346 2346 assert_equal 3, Issue.find(1).status_id
2347 2347 end
2348 2348
2349 2349 should "ignore unauthorized status" do
2350 2350 assert_difference 'Journal.count' do
2351 2351 put :update, :id => 1, :issue => {:status_id => 2, :notes => 'just trying'}
2352 2352 end
2353 2353 assert_equal 1, Issue.find(1).status_id
2354 2354 end
2355 2355
2356 2356 should "accept authorized attributes changes" do
2357 2357 assert_difference 'Journal.count' do
2358 2358 put :update, :id => 1, :issue => {:subject => 'changed', :assigned_to_id => 2, :notes => 'just trying'}
2359 2359 end
2360 2360 issue = Issue.find(1)
2361 2361 assert_equal "changed", issue.subject
2362 2362 assert_equal 2, issue.assigned_to_id
2363 2363 end
2364 2364 end
2365 2365 end
2366 2366
2367 2367 def test_new_as_copy
2368 2368 @request.session[:user_id] = 2
2369 2369 get :new, :project_id => 1, :copy_from => 1
2370 2370
2371 2371 assert_response :success
2372 2372 assert_template 'new'
2373 2373
2374 2374 assert_not_nil assigns(:issue)
2375 2375 orig = Issue.find(1)
2376 2376 assert_equal 1, assigns(:issue).project_id
2377 2377 assert_equal orig.subject, assigns(:issue).subject
2378 2378 assert assigns(:issue).copy?
2379 2379
2380 2380 assert_select 'form[id=issue-form][action=/projects/ecookbook/issues]' do
2381 2381 assert_select 'select[name=?]', 'issue[project_id]' do
2382 2382 assert_select 'option[value=1][selected=selected]', :text => 'eCookbook'
2383 2383 assert_select 'option[value=2]:not([selected])', :text => 'OnlineStore'
2384 2384 end
2385 2385 assert_select 'input[name=copy_from][value=1]'
2386 2386 end
2387 2387
2388 2388 # "New issue" menu item should not link to copy
2389 2389 assert_select '#main-menu a.new-issue[href=/projects/ecookbook/issues/new]'
2390 2390 end
2391 2391
2392 2392 def test_new_as_copy_with_attachments_should_show_copy_attachments_checkbox
2393 2393 @request.session[:user_id] = 2
2394 2394 issue = Issue.find(3)
2395 2395 assert issue.attachments.count > 0
2396 2396 get :new, :project_id => 1, :copy_from => 3
2397 2397
2398 2398 assert_select 'input[name=copy_attachments][type=checkbox][checked=checked][value=1]'
2399 2399 end
2400 2400
2401 2401 def test_new_as_copy_without_attachments_should_not_show_copy_attachments_checkbox
2402 2402 @request.session[:user_id] = 2
2403 2403 issue = Issue.find(3)
2404 2404 issue.attachments.delete_all
2405 2405 get :new, :project_id => 1, :copy_from => 3
2406 2406
2407 2407 assert_select 'input[name=copy_attachments]', 0
2408 2408 end
2409 2409
2410 2410 def test_new_as_copy_with_subtasks_should_show_copy_subtasks_checkbox
2411 2411 @request.session[:user_id] = 2
2412 2412 issue = Issue.generate_with_descendants!
2413 2413 get :new, :project_id => 1, :copy_from => issue.id
2414 2414
2415 2415 assert_select 'input[type=checkbox][name=copy_subtasks][checked=checked][value=1]'
2416 2416 end
2417 2417
2418 2418 def test_new_as_copy_with_invalid_issue_should_respond_with_404
2419 2419 @request.session[:user_id] = 2
2420 2420 get :new, :project_id => 1, :copy_from => 99999
2421 2421 assert_response 404
2422 2422 end
2423 2423
2424 2424 def test_create_as_copy_on_different_project
2425 2425 @request.session[:user_id] = 2
2426 2426 assert_difference 'Issue.count' do
2427 2427 post :create, :project_id => 1, :copy_from => 1,
2428 2428 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2429 2429
2430 2430 assert_not_nil assigns(:issue)
2431 2431 assert assigns(:issue).copy?
2432 2432 end
2433 2433 issue = Issue.first(:order => 'id DESC')
2434 2434 assert_redirected_to "/issues/#{issue.id}"
2435 2435
2436 2436 assert_equal 2, issue.project_id
2437 2437 assert_equal 3, issue.tracker_id
2438 2438 assert_equal 'Copy', issue.subject
2439 2439 end
2440 2440
2441 2441 def test_create_as_copy_should_copy_attachments
2442 2442 @request.session[:user_id] = 2
2443 2443 issue = Issue.find(3)
2444 2444 count = issue.attachments.count
2445 2445 assert count > 0
2446 2446
2447 2447 assert_difference 'Issue.count' do
2448 2448 assert_difference 'Attachment.count', count do
2449 2449 assert_no_difference 'Journal.count' do
2450 2450 post :create, :project_id => 1, :copy_from => 3,
2451 2451 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2452 2452 :copy_attachments => '1'
2453 2453 end
2454 2454 end
2455 2455 end
2456 2456 copy = Issue.first(:order => 'id DESC')
2457 2457 assert_equal count, copy.attachments.count
2458 2458 assert_equal issue.attachments.map(&:filename).sort, copy.attachments.map(&:filename).sort
2459 2459 end
2460 2460
2461 2461 def test_create_as_copy_without_copy_attachments_option_should_not_copy_attachments
2462 2462 @request.session[:user_id] = 2
2463 2463 issue = Issue.find(3)
2464 2464 count = issue.attachments.count
2465 2465 assert count > 0
2466 2466
2467 2467 assert_difference 'Issue.count' do
2468 2468 assert_no_difference 'Attachment.count' do
2469 2469 assert_no_difference 'Journal.count' do
2470 2470 post :create, :project_id => 1, :copy_from => 3,
2471 2471 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'}
2472 2472 end
2473 2473 end
2474 2474 end
2475 2475 copy = Issue.first(:order => 'id DESC')
2476 2476 assert_equal 0, copy.attachments.count
2477 2477 end
2478 2478
2479 2479 def test_create_as_copy_with_attachments_should_add_new_files
2480 2480 @request.session[:user_id] = 2
2481 2481 issue = Issue.find(3)
2482 2482 count = issue.attachments.count
2483 2483 assert count > 0
2484 2484
2485 2485 assert_difference 'Issue.count' do
2486 2486 assert_difference 'Attachment.count', count + 1 do
2487 2487 assert_no_difference 'Journal.count' do
2488 2488 post :create, :project_id => 1, :copy_from => 3,
2489 2489 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with attachments'},
2490 2490 :copy_attachments => '1',
2491 2491 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2492 2492 end
2493 2493 end
2494 2494 end
2495 2495 copy = Issue.first(:order => 'id DESC')
2496 2496 assert_equal count + 1, copy.attachments.count
2497 2497 end
2498 2498
2499 2499 def test_create_as_copy_should_add_relation_with_copied_issue
2500 2500 @request.session[:user_id] = 2
2501 2501
2502 2502 assert_difference 'Issue.count' do
2503 2503 assert_difference 'IssueRelation.count' do
2504 2504 post :create, :project_id => 1, :copy_from => 1,
2505 2505 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2506 2506 end
2507 2507 end
2508 2508 copy = Issue.first(:order => 'id DESC')
2509 2509 assert_equal 1, copy.relations.size
2510 2510 end
2511 2511
2512 2512 def test_create_as_copy_should_copy_subtasks
2513 2513 @request.session[:user_id] = 2
2514 2514 issue = Issue.generate_with_descendants!
2515 2515 count = issue.descendants.count
2516 2516
2517 2517 assert_difference 'Issue.count', count+1 do
2518 2518 assert_no_difference 'Journal.count' do
2519 2519 post :create, :project_id => 1, :copy_from => issue.id,
2520 2520 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with subtasks'},
2521 2521 :copy_subtasks => '1'
2522 2522 end
2523 2523 end
2524 2524 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2525 2525 assert_equal count, copy.descendants.count
2526 2526 assert_equal issue.descendants.map(&:subject).sort, copy.descendants.map(&:subject).sort
2527 2527 end
2528 2528
2529 2529 def test_create_as_copy_without_copy_subtasks_option_should_not_copy_subtasks
2530 2530 @request.session[:user_id] = 2
2531 2531 issue = Issue.generate_with_descendants!
2532 2532
2533 2533 assert_difference 'Issue.count', 1 do
2534 2534 assert_no_difference 'Journal.count' do
2535 2535 post :create, :project_id => 1, :copy_from => 3,
2536 2536 :issue => {:project_id => '1', :tracker_id => '3', :status_id => '1', :subject => 'Copy with subtasks'}
2537 2537 end
2538 2538 end
2539 2539 copy = Issue.where(:parent_id => nil).first(:order => 'id DESC')
2540 2540 assert_equal 0, copy.descendants.count
2541 2541 end
2542 2542
2543 2543 def test_create_as_copy_with_failure
2544 2544 @request.session[:user_id] = 2
2545 2545 post :create, :project_id => 1, :copy_from => 1,
2546 2546 :issue => {:project_id => '2', :tracker_id => '3', :status_id => '1', :subject => ''}
2547 2547
2548 2548 assert_response :success
2549 2549 assert_template 'new'
2550 2550
2551 2551 assert_not_nil assigns(:issue)
2552 2552 assert assigns(:issue).copy?
2553 2553
2554 2554 assert_select 'form#issue-form[action=/projects/ecookbook/issues]' do
2555 2555 assert_select 'select[name=?]', 'issue[project_id]' do
2556 2556 assert_select 'option[value=1]:not([selected])', :text => 'eCookbook'
2557 2557 assert_select 'option[value=2][selected=selected]', :text => 'OnlineStore'
2558 2558 end
2559 2559 assert_select 'input[name=copy_from][value=1]'
2560 2560 end
2561 2561 end
2562 2562
2563 2563 def test_create_as_copy_on_project_without_permission_should_ignore_target_project
2564 2564 @request.session[:user_id] = 2
2565 2565 assert !User.find(2).member_of?(Project.find(4))
2566 2566
2567 2567 assert_difference 'Issue.count' do
2568 2568 post :create, :project_id => 1, :copy_from => 1,
2569 2569 :issue => {:project_id => '4', :tracker_id => '3', :status_id => '1', :subject => 'Copy'}
2570 2570 end
2571 2571 issue = Issue.first(:order => 'id DESC')
2572 2572 assert_equal 1, issue.project_id
2573 2573 end
2574 2574
2575 2575 def test_get_edit
2576 2576 @request.session[:user_id] = 2
2577 2577 get :edit, :id => 1
2578 2578 assert_response :success
2579 2579 assert_template 'edit'
2580 2580 assert_not_nil assigns(:issue)
2581 2581 assert_equal Issue.find(1), assigns(:issue)
2582 2582
2583 2583 # Be sure we don't display inactive IssuePriorities
2584 2584 assert ! IssuePriority.find(15).active?
2585 2585 assert_select 'select[name=?]', 'issue[priority_id]' do
2586 2586 assert_select 'option[value=15]', 0
2587 2587 end
2588 2588 end
2589 2589
2590 2590 def test_get_edit_should_display_the_time_entry_form_with_log_time_permission
2591 2591 @request.session[:user_id] = 2
2592 2592 Role.find_by_name('Manager').update_attribute :permissions, [:view_issues, :edit_issues, :log_time]
2593 2593
2594 2594 get :edit, :id => 1
2595 2595 assert_select 'input[name=?]', 'time_entry[hours]'
2596 2596 end
2597 2597
2598 2598 def test_get_edit_should_not_display_the_time_entry_form_without_log_time_permission
2599 2599 @request.session[:user_id] = 2
2600 2600 Role.find_by_name('Manager').remove_permission! :log_time
2601 2601
2602 2602 get :edit, :id => 1
2603 2603 assert_select 'input[name=?]', 'time_entry[hours]', 0
2604 2604 end
2605 2605
2606 2606 def test_get_edit_with_params
2607 2607 @request.session[:user_id] = 2
2608 2608 get :edit, :id => 1, :issue => { :status_id => 5, :priority_id => 7 },
2609 2609 :time_entry => { :hours => '2.5', :comments => 'test_get_edit_with_params', :activity_id => 10 }
2610 2610 assert_response :success
2611 2611 assert_template 'edit'
2612 2612
2613 2613 issue = assigns(:issue)
2614 2614 assert_not_nil issue
2615 2615
2616 2616 assert_equal 5, issue.status_id
2617 2617 assert_select 'select[name=?]', 'issue[status_id]' do
2618 2618 assert_select 'option[value=5][selected=selected]', :text => 'Closed'
2619 2619 end
2620 2620
2621 2621 assert_equal 7, issue.priority_id
2622 2622 assert_select 'select[name=?]', 'issue[priority_id]' do
2623 2623 assert_select 'option[value=7][selected=selected]', :text => 'Urgent'
2624 2624 end
2625 2625
2626 2626 assert_select 'input[name=?][value=2.5]', 'time_entry[hours]'
2627 2627 assert_select 'select[name=?]', 'time_entry[activity_id]' do
2628 2628 assert_select 'option[value=10][selected=selected]', :text => 'Development'
2629 2629 end
2630 2630 assert_select 'input[name=?][value=test_get_edit_with_params]', 'time_entry[comments]'
2631 2631 end
2632 2632
2633 2633 def test_get_edit_with_multi_custom_field
2634 2634 field = CustomField.find(1)
2635 2635 field.update_attribute :multiple, true
2636 2636 issue = Issue.find(1)
2637 2637 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2638 2638 issue.save!
2639 2639
2640 2640 @request.session[:user_id] = 2
2641 2641 get :edit, :id => 1
2642 2642 assert_response :success
2643 2643 assert_template 'edit'
2644 2644
2645 2645 assert_select 'select[name=?][multiple=multiple]', 'issue[custom_field_values][1][]' do
2646 2646 assert_select 'option', 3
2647 2647 assert_select 'option[value=MySQL][selected=selected]'
2648 2648 assert_select 'option[value=Oracle][selected=selected]'
2649 2649 assert_select 'option[value=PostgreSQL]:not([selected])'
2650 2650 end
2651 2651 end
2652 2652
2653 2653 def test_update_form_for_existing_issue
2654 2654 @request.session[:user_id] = 2
2655 2655 xhr :put, :update_form, :project_id => 1,
2656 2656 :id => 1,
2657 2657 :issue => {:tracker_id => 2,
2658 2658 :subject => 'This is the test_new issue',
2659 2659 :description => 'This is the description',
2660 2660 :priority_id => 5}
2661 2661 assert_response :success
2662 2662 assert_equal 'text/javascript', response.content_type
2663 2663 assert_template 'update_form'
2664 2664 assert_template 'form'
2665 2665
2666 2666 issue = assigns(:issue)
2667 2667 assert_kind_of Issue, issue
2668 2668 assert_equal 1, issue.id
2669 2669 assert_equal 1, issue.project_id
2670 2670 assert_equal 2, issue.tracker_id
2671 2671 assert_equal 'This is the test_new issue', issue.subject
2672 2672 end
2673 2673
2674 2674 def test_update_form_for_existing_issue_should_keep_issue_author
2675 2675 @request.session[:user_id] = 3
2676 2676 xhr :put, :update_form, :project_id => 1, :id => 1, :issue => {:subject => 'Changed'}
2677 2677 assert_response :success
2678 2678 assert_equal 'text/javascript', response.content_type
2679 2679
2680 2680 issue = assigns(:issue)
2681 2681 assert_equal User.find(2), issue.author
2682 2682 assert_equal 2, issue.author_id
2683 2683 assert_not_equal User.current, issue.author
2684 2684 end
2685 2685
2686 2686 def test_update_form_for_existing_issue_should_propose_transitions_based_on_initial_status
2687 2687 @request.session[:user_id] = 2
2688 2688 WorkflowTransition.delete_all
2689 2689 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
2690 2690 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
2691 2691 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 5, :new_status_id => 4)
2692 2692
2693 2693 xhr :put, :update_form, :project_id => 1,
2694 2694 :id => 2,
2695 2695 :issue => {:tracker_id => 2,
2696 2696 :status_id => 5,
2697 2697 :subject => 'This is an issue'}
2698 2698
2699 2699 assert_equal 5, assigns(:issue).status_id
2700 2700 assert_equal [1,2,5], assigns(:allowed_statuses).map(&:id).sort
2701 2701 end
2702 2702
2703 2703 def test_update_form_for_existing_issue_with_project_change
2704 2704 @request.session[:user_id] = 2
2705 2705 xhr :put, :update_form, :project_id => 1,
2706 2706 :id => 1,
2707 2707 :issue => {:project_id => 2,
2708 2708 :tracker_id => 2,
2709 2709 :subject => 'This is the test_new issue',
2710 2710 :description => 'This is the description',
2711 2711 :priority_id => 5}
2712 2712 assert_response :success
2713 2713 assert_template 'form'
2714 2714
2715 2715 issue = assigns(:issue)
2716 2716 assert_kind_of Issue, issue
2717 2717 assert_equal 1, issue.id
2718 2718 assert_equal 2, issue.project_id
2719 2719 assert_equal 2, issue.tracker_id
2720 2720 assert_equal 'This is the test_new issue', issue.subject
2721 2721 end
2722 2722
2723 2723 def test_put_update_without_custom_fields_param
2724 2724 @request.session[:user_id] = 2
2725 2725 ActionMailer::Base.deliveries.clear
2726 2726
2727 2727 issue = Issue.find(1)
2728 2728 assert_equal '125', issue.custom_value_for(2).value
2729 2729 old_subject = issue.subject
2730 2730 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
2731 2731
2732 2732 assert_difference('Journal.count') do
2733 2733 assert_difference('JournalDetail.count', 2) do
2734 2734 put :update, :id => 1, :issue => {:subject => new_subject,
2735 2735 :priority_id => '6',
2736 2736 :category_id => '1' # no change
2737 2737 }
2738 2738 end
2739 2739 end
2740 2740 assert_redirected_to :action => 'show', :id => '1'
2741 2741 issue.reload
2742 2742 assert_equal new_subject, issue.subject
2743 2743 # Make sure custom fields were not cleared
2744 2744 assert_equal '125', issue.custom_value_for(2).value
2745 2745
2746 2746 mail = ActionMailer::Base.deliveries.last
2747 2747 assert_not_nil mail
2748 2748 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2749 2749 assert_mail_body_match "Subject changed from #{old_subject} to #{new_subject}", mail
2750 2750 end
2751 2751
2752 2752 def test_put_update_with_project_change
2753 2753 @request.session[:user_id] = 2
2754 2754 ActionMailer::Base.deliveries.clear
2755 2755
2756 2756 assert_difference('Journal.count') do
2757 2757 assert_difference('JournalDetail.count', 3) do
2758 2758 put :update, :id => 1, :issue => {:project_id => '2',
2759 2759 :tracker_id => '1', # no change
2760 2760 :priority_id => '6',
2761 2761 :category_id => '3'
2762 2762 }
2763 2763 end
2764 2764 end
2765 2765 assert_redirected_to :action => 'show', :id => '1'
2766 2766 issue = Issue.find(1)
2767 2767 assert_equal 2, issue.project_id
2768 2768 assert_equal 1, issue.tracker_id
2769 2769 assert_equal 6, issue.priority_id
2770 2770 assert_equal 3, issue.category_id
2771 2771
2772 2772 mail = ActionMailer::Base.deliveries.last
2773 2773 assert_not_nil mail
2774 2774 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2775 2775 assert_mail_body_match "Project changed from eCookbook to OnlineStore", mail
2776 2776 end
2777 2777
2778 2778 def test_put_update_with_tracker_change
2779 2779 @request.session[:user_id] = 2
2780 2780 ActionMailer::Base.deliveries.clear
2781 2781
2782 2782 assert_difference('Journal.count') do
2783 2783 assert_difference('JournalDetail.count', 2) do
2784 2784 put :update, :id => 1, :issue => {:project_id => '1',
2785 2785 :tracker_id => '2',
2786 2786 :priority_id => '6'
2787 2787 }
2788 2788 end
2789 2789 end
2790 2790 assert_redirected_to :action => 'show', :id => '1'
2791 2791 issue = Issue.find(1)
2792 2792 assert_equal 1, issue.project_id
2793 2793 assert_equal 2, issue.tracker_id
2794 2794 assert_equal 6, issue.priority_id
2795 2795 assert_equal 1, issue.category_id
2796 2796
2797 2797 mail = ActionMailer::Base.deliveries.last
2798 2798 assert_not_nil mail
2799 2799 assert mail.subject.starts_with?("[#{issue.project.name} - #{issue.tracker.name} ##{issue.id}]")
2800 2800 assert_mail_body_match "Tracker changed from Bug to Feature request", mail
2801 2801 end
2802 2802
2803 2803 def test_put_update_with_custom_field_change
2804 2804 @request.session[:user_id] = 2
2805 2805 issue = Issue.find(1)
2806 2806 assert_equal '125', issue.custom_value_for(2).value
2807 2807
2808 2808 assert_difference('Journal.count') do
2809 2809 assert_difference('JournalDetail.count', 3) do
2810 2810 put :update, :id => 1, :issue => {:subject => 'Custom field change',
2811 2811 :priority_id => '6',
2812 2812 :category_id => '1', # no change
2813 2813 :custom_field_values => { '2' => 'New custom value' }
2814 2814 }
2815 2815 end
2816 2816 end
2817 2817 assert_redirected_to :action => 'show', :id => '1'
2818 2818 issue.reload
2819 2819 assert_equal 'New custom value', issue.custom_value_for(2).value
2820 2820
2821 2821 mail = ActionMailer::Base.deliveries.last
2822 2822 assert_not_nil mail
2823 2823 assert_mail_body_match "Searchable field changed from 125 to New custom value", mail
2824 2824 end
2825 2825
2826 2826 def test_put_update_with_multi_custom_field_change
2827 2827 field = CustomField.find(1)
2828 2828 field.update_attribute :multiple, true
2829 2829 issue = Issue.find(1)
2830 2830 issue.custom_field_values = {1 => ['MySQL', 'Oracle']}
2831 2831 issue.save!
2832 2832
2833 2833 @request.session[:user_id] = 2
2834 2834 assert_difference('Journal.count') do
2835 2835 assert_difference('JournalDetail.count', 3) do
2836 2836 put :update, :id => 1,
2837 2837 :issue => {
2838 2838 :subject => 'Custom field change',
2839 2839 :custom_field_values => { '1' => ['', 'Oracle', 'PostgreSQL'] }
2840 2840 }
2841 2841 end
2842 2842 end
2843 2843 assert_redirected_to :action => 'show', :id => '1'
2844 2844 assert_equal ['Oracle', 'PostgreSQL'], Issue.find(1).custom_field_value(1).sort
2845 2845 end
2846 2846
2847 2847 def test_put_update_with_status_and_assignee_change
2848 2848 issue = Issue.find(1)
2849 2849 assert_equal 1, issue.status_id
2850 2850 @request.session[:user_id] = 2
2851 2851 assert_difference('TimeEntry.count', 0) do
2852 2852 put :update,
2853 2853 :id => 1,
2854 2854 :issue => { :status_id => 2, :assigned_to_id => 3, :notes => 'Assigned to dlopper' },
2855 2855 :time_entry => { :hours => '', :comments => '', :activity_id => TimeEntryActivity.first }
2856 2856 end
2857 2857 assert_redirected_to :action => 'show', :id => '1'
2858 2858 issue.reload
2859 2859 assert_equal 2, issue.status_id
2860 2860 j = Journal.order('id DESC').first
2861 2861 assert_equal 'Assigned to dlopper', j.notes
2862 2862 assert_equal 2, j.details.size
2863 2863
2864 2864 mail = ActionMailer::Base.deliveries.last
2865 2865 assert_mail_body_match "Status changed from New to Assigned", mail
2866 2866 # subject should contain the new status
2867 2867 assert mail.subject.include?("(#{ IssueStatus.find(2).name })")
2868 2868 end
2869 2869
2870 2870 def test_put_update_with_note_only
2871 2871 notes = 'Note added by IssuesControllerTest#test_update_with_note_only'
2872 2872 # anonymous user
2873 2873 put :update,
2874 2874 :id => 1,
2875 2875 :issue => { :notes => notes }
2876 2876 assert_redirected_to :action => 'show', :id => '1'
2877 2877 j = Journal.order('id DESC').first
2878 2878 assert_equal notes, j.notes
2879 2879 assert_equal 0, j.details.size
2880 2880 assert_equal User.anonymous, j.user
2881 2881
2882 2882 mail = ActionMailer::Base.deliveries.last
2883 2883 assert_mail_body_match notes, mail
2884 2884 end
2885 2885
2886 2886 def test_put_update_with_private_note_only
2887 2887 notes = 'Private note'
2888 2888 @request.session[:user_id] = 2
2889 2889
2890 2890 assert_difference 'Journal.count' do
2891 2891 put :update, :id => 1, :issue => {:notes => notes, :private_notes => '1'}
2892 2892 assert_redirected_to :action => 'show', :id => '1'
2893 2893 end
2894 2894
2895 2895 j = Journal.order('id DESC').first
2896 2896 assert_equal notes, j.notes
2897 2897 assert_equal true, j.private_notes
2898 2898 end
2899 2899
2900 2900 def test_put_update_with_private_note_and_changes
2901 2901 notes = 'Private note'
2902 2902 @request.session[:user_id] = 2
2903 2903
2904 2904 assert_difference 'Journal.count', 2 do
2905 2905 put :update, :id => 1, :issue => {:subject => 'New subject', :notes => notes, :private_notes => '1'}
2906 2906 assert_redirected_to :action => 'show', :id => '1'
2907 2907 end
2908 2908
2909 2909 j = Journal.order('id DESC').first
2910 2910 assert_equal notes, j.notes
2911 2911 assert_equal true, j.private_notes
2912 2912 assert_equal 0, j.details.count
2913 2913
2914 2914 j = Journal.order('id DESC').offset(1).first
2915 2915 assert_nil j.notes
2916 2916 assert_equal false, j.private_notes
2917 2917 assert_equal 1, j.details.count
2918 2918 end
2919 2919
2920 2920 def test_put_update_with_note_and_spent_time
2921 2921 @request.session[:user_id] = 2
2922 2922 spent_hours_before = Issue.find(1).spent_hours
2923 2923 assert_difference('TimeEntry.count') do
2924 2924 put :update,
2925 2925 :id => 1,
2926 2926 :issue => { :notes => '2.5 hours added' },
2927 2927 :time_entry => { :hours => '2.5', :comments => 'test_put_update_with_note_and_spent_time', :activity_id => TimeEntryActivity.first.id }
2928 2928 end
2929 2929 assert_redirected_to :action => 'show', :id => '1'
2930 2930
2931 2931 issue = Issue.find(1)
2932 2932
2933 2933 j = Journal.order('id DESC').first
2934 2934 assert_equal '2.5 hours added', j.notes
2935 2935 assert_equal 0, j.details.size
2936 2936
2937 2937 t = issue.time_entries.find_by_comments('test_put_update_with_note_and_spent_time')
2938 2938 assert_not_nil t
2939 2939 assert_equal 2.5, t.hours
2940 2940 assert_equal spent_hours_before + 2.5, issue.spent_hours
2941 2941 end
2942 2942
2943 2943 def test_put_update_should_preserve_parent_issue_even_if_not_visible
2944 2944 parent = Issue.generate!(:project_id => 1, :is_private => true)
2945 2945 issue = Issue.generate!(:parent_issue_id => parent.id)
2946 2946 assert !parent.visible?(User.find(3))
2947 2947 @request.session[:user_id] = 3
2948 2948
2949 2949 get :edit, :id => issue.id
2950 2950 assert_select 'input[name=?][value=?]', 'issue[parent_issue_id]', parent.id.to_s
2951 2951
2952 2952 put :update, :id => issue.id, :issue => {:subject => 'New subject', :parent_issue_id => parent.id.to_s}
2953 2953 assert_response 302
2954 2954 assert_equal parent, issue.parent
2955 2955 end
2956 2956
2957 2957 def test_put_update_with_attachment_only
2958 2958 set_tmp_attachments_directory
2959 2959
2960 2960 # Delete all fixtured journals, a race condition can occur causing the wrong
2961 2961 # journal to get fetched in the next find.
2962 2962 Journal.delete_all
2963 2963
2964 2964 # anonymous user
2965 2965 assert_difference 'Attachment.count' do
2966 2966 put :update, :id => 1,
2967 2967 :issue => {:notes => ''},
2968 2968 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
2969 2969 end
2970 2970
2971 2971 assert_redirected_to :action => 'show', :id => '1'
2972 2972 j = Issue.find(1).journals.reorder('id DESC').first
2973 2973 assert j.notes.blank?
2974 2974 assert_equal 1, j.details.size
2975 2975 assert_equal 'testfile.txt', j.details.first.value
2976 2976 assert_equal User.anonymous, j.user
2977 2977
2978 2978 attachment = Attachment.first(:order => 'id DESC')
2979 2979 assert_equal Issue.find(1), attachment.container
2980 2980 assert_equal User.anonymous, attachment.author
2981 2981 assert_equal 'testfile.txt', attachment.filename
2982 2982 assert_equal 'text/plain', attachment.content_type
2983 2983 assert_equal 'test file', attachment.description
2984 2984 assert_equal 59, attachment.filesize
2985 2985 assert File.exists?(attachment.diskfile)
2986 2986 assert_equal 59, File.size(attachment.diskfile)
2987 2987
2988 2988 mail = ActionMailer::Base.deliveries.last
2989 2989 assert_mail_body_match 'testfile.txt', mail
2990 2990 end
2991 2991
2992 2992 def test_put_update_with_failure_should_save_attachments
2993 2993 set_tmp_attachments_directory
2994 2994 @request.session[:user_id] = 2
2995 2995
2996 2996 assert_no_difference 'Journal.count' do
2997 2997 assert_difference 'Attachment.count' do
2998 2998 put :update, :id => 1,
2999 2999 :issue => { :subject => '' },
3000 3000 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain'), 'description' => 'test file'}}
3001 3001 assert_response :success
3002 3002 assert_template 'edit'
3003 3003 end
3004 3004 end
3005 3005
3006 3006 attachment = Attachment.first(:order => 'id DESC')
3007 3007 assert_equal 'testfile.txt', attachment.filename
3008 3008 assert File.exists?(attachment.diskfile)
3009 3009 assert_nil attachment.container
3010 3010
3011 3011 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
3012 3012 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
3013 3013 end
3014 3014
3015 3015 def test_put_update_with_failure_should_keep_saved_attachments
3016 3016 set_tmp_attachments_directory
3017 3017 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3018 3018 @request.session[:user_id] = 2
3019 3019
3020 3020 assert_no_difference 'Journal.count' do
3021 3021 assert_no_difference 'Attachment.count' do
3022 3022 put :update, :id => 1,
3023 3023 :issue => { :subject => '' },
3024 3024 :attachments => {'p0' => {'token' => attachment.token}}
3025 3025 assert_response :success
3026 3026 assert_template 'edit'
3027 3027 end
3028 3028 end
3029 3029
3030 3030 assert_select 'input[name=?][value=?]', 'attachments[p0][token]', attachment.token
3031 3031 assert_select 'input[name=?][value=?]', 'attachments[p0][filename]', 'testfile.txt'
3032 3032 end
3033 3033
3034 3034 def test_put_update_should_attach_saved_attachments
3035 3035 set_tmp_attachments_directory
3036 3036 attachment = Attachment.create!(:file => uploaded_test_file("testfile.txt", "text/plain"), :author_id => 2)
3037 3037 @request.session[:user_id] = 2
3038 3038
3039 3039 assert_difference 'Journal.count' do
3040 3040 assert_difference 'JournalDetail.count' do
3041 3041 assert_no_difference 'Attachment.count' do
3042 3042 put :update, :id => 1,
3043 3043 :issue => {:notes => 'Attachment added'},
3044 3044 :attachments => {'p0' => {'token' => attachment.token}}
3045 3045 assert_redirected_to '/issues/1'
3046 3046 end
3047 3047 end
3048 3048 end
3049 3049
3050 3050 attachment.reload
3051 3051 assert_equal Issue.find(1), attachment.container
3052 3052
3053 3053 journal = Journal.first(:order => 'id DESC')
3054 3054 assert_equal 1, journal.details.size
3055 3055 assert_equal 'testfile.txt', journal.details.first.value
3056 3056 end
3057 3057
3058 3058 def test_put_update_with_attachment_that_fails_to_save
3059 3059 set_tmp_attachments_directory
3060 3060
3061 3061 # Delete all fixtured journals, a race condition can occur causing the wrong
3062 3062 # journal to get fetched in the next find.
3063 3063 Journal.delete_all
3064 3064
3065 3065 # Mock out the unsaved attachment
3066 3066 Attachment.any_instance.stubs(:create).returns(Attachment.new)
3067 3067
3068 3068 # anonymous user
3069 3069 put :update,
3070 3070 :id => 1,
3071 3071 :issue => {:notes => ''},
3072 3072 :attachments => {'1' => {'file' => uploaded_test_file('testfile.txt', 'text/plain')}}
3073 3073 assert_redirected_to :action => 'show', :id => '1'
3074 3074 assert_equal '1 file(s) could not be saved.', flash[:warning]
3075 3075 end
3076 3076
3077 3077 def test_put_update_with_no_change
3078 3078 issue = Issue.find(1)
3079 3079 issue.journals.clear
3080 3080 ActionMailer::Base.deliveries.clear
3081 3081
3082 3082 put :update,
3083 3083 :id => 1,
3084 3084 :issue => {:notes => ''}
3085 3085 assert_redirected_to :action => 'show', :id => '1'
3086 3086
3087 3087 issue.reload
3088 3088 assert issue.journals.empty?
3089 3089 # No email should be sent
3090 3090 assert ActionMailer::Base.deliveries.empty?
3091 3091 end
3092 3092
3093 3093 def test_put_update_should_send_a_notification
3094 3094 @request.session[:user_id] = 2
3095 3095 ActionMailer::Base.deliveries.clear
3096 3096 issue = Issue.find(1)
3097 3097 old_subject = issue.subject
3098 3098 new_subject = 'Subject modified by IssuesControllerTest#test_post_edit'
3099 3099
3100 3100 put :update, :id => 1, :issue => {:subject => new_subject,
3101 3101 :priority_id => '6',
3102 3102 :category_id => '1' # no change
3103 3103 }
3104 3104 assert_equal 1, ActionMailer::Base.deliveries.size
3105 3105 end
3106 3106
3107 3107 def test_put_update_with_invalid_spent_time_hours_only
3108 3108 @request.session[:user_id] = 2
3109 3109 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3110 3110
3111 3111 assert_no_difference('Journal.count') do
3112 3112 put :update,
3113 3113 :id => 1,
3114 3114 :issue => {:notes => notes},
3115 3115 :time_entry => {"comments"=>"", "activity_id"=>"", "hours"=>"2z"}
3116 3116 end
3117 3117 assert_response :success
3118 3118 assert_template 'edit'
3119 3119
3120 3120 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3121 3121 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3122 3122 assert_select 'input[name=?][value=?]', 'time_entry[hours]', '2z'
3123 3123 end
3124 3124
3125 3125 def test_put_update_with_invalid_spent_time_comments_only
3126 3126 @request.session[:user_id] = 2
3127 3127 notes = 'Note added by IssuesControllerTest#test_post_edit_with_invalid_spent_time'
3128 3128
3129 3129 assert_no_difference('Journal.count') do
3130 3130 put :update,
3131 3131 :id => 1,
3132 3132 :issue => {:notes => notes},
3133 3133 :time_entry => {"comments"=>"this is my comment", "activity_id"=>"", "hours"=>""}
3134 3134 end
3135 3135 assert_response :success
3136 3136 assert_template 'edit'
3137 3137
3138 3138 assert_error_tag :descendant => {:content => /Activity can&#x27;t be blank/}
3139 3139 assert_error_tag :descendant => {:content => /Hours can&#x27;t be blank/}
3140 3140 assert_select 'textarea[name=?]', 'issue[notes]', :text => notes
3141 3141 assert_select 'input[name=?][value=?]', 'time_entry[comments]', 'this is my comment'
3142 3142 end
3143 3143
3144 3144 def test_put_update_should_allow_fixed_version_to_be_set_to_a_subproject
3145 3145 issue = Issue.find(2)
3146 3146 @request.session[:user_id] = 2
3147 3147
3148 3148 put :update,
3149 3149 :id => issue.id,
3150 3150 :issue => {
3151 3151 :fixed_version_id => 4
3152 3152 }
3153 3153
3154 3154 assert_response :redirect
3155 3155 issue.reload
3156 3156 assert_equal 4, issue.fixed_version_id
3157 3157 assert_not_equal issue.project_id, issue.fixed_version.project_id
3158 3158 end
3159 3159
3160 3160 def test_put_update_should_redirect_back_using_the_back_url_parameter
3161 3161 issue = Issue.find(2)
3162 3162 @request.session[:user_id] = 2
3163 3163
3164 3164 put :update,
3165 3165 :id => issue.id,
3166 3166 :issue => {
3167 3167 :fixed_version_id => 4
3168 3168 },
3169 3169 :back_url => '/issues'
3170 3170
3171 3171 assert_response :redirect
3172 3172 assert_redirected_to '/issues'
3173 3173 end
3174 3174
3175 3175 def test_put_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3176 3176 issue = Issue.find(2)
3177 3177 @request.session[:user_id] = 2
3178 3178
3179 3179 put :update,
3180 3180 :id => issue.id,
3181 3181 :issue => {
3182 3182 :fixed_version_id => 4
3183 3183 },
3184 3184 :back_url => 'http://google.com'
3185 3185
3186 3186 assert_response :redirect
3187 3187 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue.id
3188 3188 end
3189 3189
3190 3190 def test_get_bulk_edit
3191 3191 @request.session[:user_id] = 2
3192 3192 get :bulk_edit, :ids => [1, 2]
3193 3193 assert_response :success
3194 3194 assert_template 'bulk_edit'
3195 3195
3196 3196 assert_select 'ul#bulk-selection' do
3197 3197 assert_select 'li', 2
3198 3198 assert_select 'li a', :text => 'Bug #1'
3199 3199 end
3200 3200
3201 3201 assert_select 'form#bulk_edit_form[action=?]', '/issues/bulk_update' do
3202 3202 assert_select 'input[name=?]', 'ids[]', 2
3203 3203 assert_select 'input[name=?][value=1][type=hidden]', 'ids[]'
3204 3204
3205 3205 assert_select 'select[name=?]', 'issue[project_id]'
3206 3206 assert_select 'input[name=?]', 'issue[parent_issue_id]'
3207 3207
3208 3208 # Project specific custom field, date type
3209 3209 field = CustomField.find(9)
3210 3210 assert !field.is_for_all?
3211 3211 assert_equal 'date', field.field_format
3212 3212 assert_select 'input[name=?]', 'issue[custom_field_values][9]'
3213 3213
3214 3214 # System wide custom field
3215 3215 assert CustomField.find(1).is_for_all?
3216 3216 assert_select 'select[name=?]', 'issue[custom_field_values][1]'
3217 3217
3218 3218 # Be sure we don't display inactive IssuePriorities
3219 3219 assert ! IssuePriority.find(15).active?
3220 3220 assert_select 'select[name=?]', 'issue[priority_id]' do
3221 3221 assert_select 'option[value=15]', 0
3222 3222 end
3223 3223 end
3224 3224 end
3225 3225
3226 3226 def test_get_bulk_edit_on_different_projects
3227 3227 @request.session[:user_id] = 2
3228 3228 get :bulk_edit, :ids => [1, 2, 6]
3229 3229 assert_response :success
3230 3230 assert_template 'bulk_edit'
3231 3231
3232 3232 # Can not set issues from different projects as children of an issue
3233 3233 assert_select 'input[name=?]', 'issue[parent_issue_id]', 0
3234 3234
3235 3235 # Project specific custom field, date type
3236 3236 field = CustomField.find(9)
3237 3237 assert !field.is_for_all?
3238 3238 assert !field.project_ids.include?(Issue.find(6).project_id)
3239 3239 assert_select 'input[name=?]', 'issue[custom_field_values][9]', 0
3240 3240 end
3241 3241
3242 3242 def test_get_bulk_edit_with_user_custom_field
3243 3243 field = IssueCustomField.create!(:name => 'Tester', :field_format => 'user', :is_for_all => true)
3244 3244
3245 3245 @request.session[:user_id] = 2
3246 3246 get :bulk_edit, :ids => [1, 2]
3247 3247 assert_response :success
3248 3248 assert_template 'bulk_edit'
3249 3249
3250 3250 assert_select 'select.user_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3251 3251 assert_select 'option', Project.find(1).users.count + 2 # "no change" + "none" options
3252 3252 end
3253 3253 end
3254 3254
3255 3255 def test_get_bulk_edit_with_version_custom_field
3256 3256 field = IssueCustomField.create!(:name => 'Affected version', :field_format => 'version', :is_for_all => true)
3257 3257
3258 3258 @request.session[:user_id] = 2
3259 3259 get :bulk_edit, :ids => [1, 2]
3260 3260 assert_response :success
3261 3261 assert_template 'bulk_edit'
3262 3262
3263 3263 assert_select 'select.version_cf[name=?]', "issue[custom_field_values][#{field.id}]" do
3264 3264 assert_select 'option', Project.find(1).shared_versions.count + 2 # "no change" + "none" options
3265 3265 end
3266 3266 end
3267 3267
3268 3268 def test_get_bulk_edit_with_multi_custom_field
3269 3269 field = CustomField.find(1)
3270 3270 field.update_attribute :multiple, true
3271 3271
3272 3272 @request.session[:user_id] = 2
3273 3273 get :bulk_edit, :ids => [1, 2]
3274 3274 assert_response :success
3275 3275 assert_template 'bulk_edit'
3276 3276
3277 3277 assert_select 'select[name=?]', 'issue[custom_field_values][1][]' do
3278 3278 assert_select 'option', field.possible_values.size + 1 # "none" options
3279 3279 end
3280 3280 end
3281 3281
3282 3282 def test_bulk_edit_should_only_propose_statuses_allowed_for_all_issues
3283 3283 WorkflowTransition.delete_all
3284 3284 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 1)
3285 3285 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 3)
3286 3286 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1, :new_status_id => 4)
3287 3287 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 1)
3288 3288 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 3)
3289 3289 WorkflowTransition.create!(:role_id => 1, :tracker_id => 2, :old_status_id => 2, :new_status_id => 5)
3290 3290 @request.session[:user_id] = 2
3291 3291 get :bulk_edit, :ids => [1, 2]
3292 3292
3293 3293 assert_response :success
3294 3294 statuses = assigns(:available_statuses)
3295 3295 assert_not_nil statuses
3296 3296 assert_equal [1, 3], statuses.map(&:id).sort
3297 3297
3298 3298 assert_select 'select[name=?]', 'issue[status_id]' do
3299 3299 assert_select 'option', 3 # 2 statuses + "no change" option
3300 3300 end
3301 3301 end
3302 3302
3303 3303 def test_bulk_edit_should_propose_target_project_open_shared_versions
3304 3304 @request.session[:user_id] = 2
3305 3305 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3306 3306 assert_response :success
3307 3307 assert_template 'bulk_edit'
3308 3308 assert_equal Project.find(1).shared_versions.open.all.sort, assigns(:versions).sort
3309 3309
3310 3310 assert_select 'select[name=?]', 'issue[fixed_version_id]' do
3311 3311 assert_select 'option', :text => '2.0'
3312 3312 end
3313 3313 end
3314 3314
3315 3315 def test_bulk_edit_should_propose_target_project_categories
3316 3316 @request.session[:user_id] = 2
3317 3317 post :bulk_edit, :ids => [1, 2, 6], :issue => {:project_id => 1}
3318 3318 assert_response :success
3319 3319 assert_template 'bulk_edit'
3320 3320 assert_equal Project.find(1).issue_categories.sort, assigns(:categories).sort
3321 3321
3322 3322 assert_select 'select[name=?]', 'issue[category_id]' do
3323 3323 assert_select 'option', :text => 'Recipes'
3324 3324 end
3325 3325 end
3326 3326
3327 3327 def test_bulk_update
3328 3328 @request.session[:user_id] = 2
3329 3329 # update issues priority
3330 3330 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3331 3331 :issue => {:priority_id => 7,
3332 3332 :assigned_to_id => '',
3333 3333 :custom_field_values => {'2' => ''}}
3334 3334
3335 3335 assert_response 302
3336 3336 # check that the issues were updated
3337 3337 assert_equal [7, 7], Issue.find_all_by_id([1, 2]).collect {|i| i.priority.id}
3338 3338
3339 3339 issue = Issue.find(1)
3340 3340 journal = issue.journals.reorder('created_on DESC').first
3341 3341 assert_equal '125', issue.custom_value_for(2).value
3342 3342 assert_equal 'Bulk editing', journal.notes
3343 3343 assert_equal 1, journal.details.size
3344 3344 end
3345 3345
3346 3346 def test_bulk_update_with_group_assignee
3347 3347 group = Group.find(11)
3348 3348 project = Project.find(1)
3349 3349 project.members << Member.new(:principal => group, :roles => [Role.givable.first])
3350 3350
3351 3351 @request.session[:user_id] = 2
3352 3352 # update issues assignee
3353 3353 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing',
3354 3354 :issue => {:priority_id => '',
3355 3355 :assigned_to_id => group.id,
3356 3356 :custom_field_values => {'2' => ''}}
3357 3357
3358 3358 assert_response 302
3359 3359 assert_equal [group, group], Issue.find_all_by_id([1, 2]).collect {|i| i.assigned_to}
3360 3360 end
3361 3361
3362 3362 def test_bulk_update_on_different_projects
3363 3363 @request.session[:user_id] = 2
3364 3364 # update issues priority
3365 3365 post :bulk_update, :ids => [1, 2, 6], :notes => 'Bulk editing',
3366 3366 :issue => {:priority_id => 7,
3367 3367 :assigned_to_id => '',
3368 3368 :custom_field_values => {'2' => ''}}
3369 3369
3370 3370 assert_response 302
3371 3371 # check that the issues were updated
3372 3372 assert_equal [7, 7, 7], Issue.find([1,2,6]).map(&:priority_id)
3373 3373
3374 3374 issue = Issue.find(1)
3375 3375 journal = issue.journals.reorder('created_on DESC').first
3376 3376 assert_equal '125', issue.custom_value_for(2).value
3377 3377 assert_equal 'Bulk editing', journal.notes
3378 3378 assert_equal 1, journal.details.size
3379 3379 end
3380 3380
3381 3381 def test_bulk_update_on_different_projects_without_rights
3382 3382 @request.session[:user_id] = 3
3383 3383 user = User.find(3)
3384 3384 action = { :controller => "issues", :action => "bulk_update" }
3385 3385 assert user.allowed_to?(action, Issue.find(1).project)
3386 3386 assert ! user.allowed_to?(action, Issue.find(6).project)
3387 3387 post :bulk_update, :ids => [1, 6], :notes => 'Bulk should fail',
3388 3388 :issue => {:priority_id => 7,
3389 3389 :assigned_to_id => '',
3390 3390 :custom_field_values => {'2' => ''}}
3391 3391 assert_response 403
3392 3392 assert_not_equal "Bulk should fail", Journal.last.notes
3393 3393 end
3394 3394
3395 3395 def test_bullk_update_should_send_a_notification
3396 3396 @request.session[:user_id] = 2
3397 3397 ActionMailer::Base.deliveries.clear
3398 3398 post(:bulk_update,
3399 3399 {
3400 3400 :ids => [1, 2],
3401 3401 :notes => 'Bulk editing',
3402 3402 :issue => {
3403 3403 :priority_id => 7,
3404 3404 :assigned_to_id => '',
3405 3405 :custom_field_values => {'2' => ''}
3406 3406 }
3407 3407 })
3408 3408
3409 3409 assert_response 302
3410 3410 assert_equal 2, ActionMailer::Base.deliveries.size
3411 3411 end
3412 3412
3413 3413 def test_bulk_update_project
3414 3414 @request.session[:user_id] = 2
3415 3415 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}
3416 3416 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3417 3417 # Issues moved to project 2
3418 3418 assert_equal 2, Issue.find(1).project_id
3419 3419 assert_equal 2, Issue.find(2).project_id
3420 3420 # No tracker change
3421 3421 assert_equal 1, Issue.find(1).tracker_id
3422 3422 assert_equal 2, Issue.find(2).tracker_id
3423 3423 end
3424 3424
3425 3425 def test_bulk_update_project_on_single_issue_should_follow_when_needed
3426 3426 @request.session[:user_id] = 2
3427 3427 post :bulk_update, :id => 1, :issue => {:project_id => '2'}, :follow => '1'
3428 3428 assert_redirected_to '/issues/1'
3429 3429 end
3430 3430
3431 3431 def test_bulk_update_project_on_multiple_issues_should_follow_when_needed
3432 3432 @request.session[:user_id] = 2
3433 3433 post :bulk_update, :id => [1, 2], :issue => {:project_id => '2'}, :follow => '1'
3434 3434 assert_redirected_to '/projects/onlinestore/issues'
3435 3435 end
3436 3436
3437 3437 def test_bulk_update_tracker
3438 3438 @request.session[:user_id] = 2
3439 3439 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2'}
3440 3440 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3441 3441 assert_equal 2, Issue.find(1).tracker_id
3442 3442 assert_equal 2, Issue.find(2).tracker_id
3443 3443 end
3444 3444
3445 3445 def test_bulk_update_status
3446 3446 @request.session[:user_id] = 2
3447 3447 # update issues priority
3448 3448 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing status',
3449 3449 :issue => {:priority_id => '',
3450 3450 :assigned_to_id => '',
3451 3451 :status_id => '5'}
3452 3452
3453 3453 assert_response 302
3454 3454 issue = Issue.find(1)
3455 3455 assert issue.closed?
3456 3456 end
3457 3457
3458 3458 def test_bulk_update_priority
3459 3459 @request.session[:user_id] = 2
3460 3460 post :bulk_update, :ids => [1, 2], :issue => {:priority_id => 6}
3461 3461
3462 3462 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3463 3463 assert_equal 6, Issue.find(1).priority_id
3464 3464 assert_equal 6, Issue.find(2).priority_id
3465 3465 end
3466 3466
3467 3467 def test_bulk_update_with_notes
3468 3468 @request.session[:user_id] = 2
3469 3469 post :bulk_update, :ids => [1, 2], :notes => 'Moving two issues'
3470 3470
3471 3471 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => 'ecookbook'
3472 3472 assert_equal 'Moving two issues', Issue.find(1).journals.sort_by(&:id).last.notes
3473 3473 assert_equal 'Moving two issues', Issue.find(2).journals.sort_by(&:id).last.notes
3474 3474 end
3475 3475
3476 3476 def test_bulk_update_parent_id
3477 3477 IssueRelation.delete_all
3478 3478
3479 3479 @request.session[:user_id] = 2
3480 3480 post :bulk_update, :ids => [1, 3],
3481 3481 :notes => 'Bulk editing parent',
3482 3482 :issue => {:priority_id => '', :assigned_to_id => '', :status_id => '', :parent_issue_id => '2'}
3483 3483
3484 3484 assert_response 302
3485 3485 parent = Issue.find(2)
3486 3486 assert_equal parent.id, Issue.find(1).parent_id
3487 3487 assert_equal parent.id, Issue.find(3).parent_id
3488 3488 assert_equal [1, 3], parent.children.collect(&:id).sort
3489 3489 end
3490 3490
3491 3491 def test_bulk_update_custom_field
3492 3492 @request.session[:user_id] = 2
3493 3493 # update issues priority
3494 3494 post :bulk_update, :ids => [1, 2], :notes => 'Bulk editing custom field',
3495 3495 :issue => {:priority_id => '',
3496 3496 :assigned_to_id => '',
3497 3497 :custom_field_values => {'2' => '777'}}
3498 3498
3499 3499 assert_response 302
3500 3500
3501 3501 issue = Issue.find(1)
3502 3502 journal = issue.journals.reorder('created_on DESC').first
3503 3503 assert_equal '777', issue.custom_value_for(2).value
3504 3504 assert_equal 1, journal.details.size
3505 3505 assert_equal '125', journal.details.first.old_value
3506 3506 assert_equal '777', journal.details.first.value
3507 3507 end
3508 3508
3509 3509 def test_bulk_update_custom_field_to_blank
3510 3510 @request.session[:user_id] = 2
3511 3511 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing custom field',
3512 3512 :issue => {:priority_id => '',
3513 3513 :assigned_to_id => '',
3514 3514 :custom_field_values => {'1' => '__none__'}}
3515 3515 assert_response 302
3516 3516 assert_equal '', Issue.find(1).custom_field_value(1)
3517 3517 assert_equal '', Issue.find(3).custom_field_value(1)
3518 3518 end
3519 3519
3520 3520 def test_bulk_update_multi_custom_field
3521 3521 field = CustomField.find(1)
3522 3522 field.update_attribute :multiple, true
3523 3523
3524 3524 @request.session[:user_id] = 2
3525 3525 post :bulk_update, :ids => [1, 2, 3], :notes => 'Bulk editing multi custom field',
3526 3526 :issue => {:priority_id => '',
3527 3527 :assigned_to_id => '',
3528 3528 :custom_field_values => {'1' => ['MySQL', 'Oracle']}}
3529 3529
3530 3530 assert_response 302
3531 3531
3532 3532 assert_equal ['MySQL', 'Oracle'], Issue.find(1).custom_field_value(1).sort
3533 3533 assert_equal ['MySQL', 'Oracle'], Issue.find(3).custom_field_value(1).sort
3534 3534 # the custom field is not associated with the issue tracker
3535 3535 assert_nil Issue.find(2).custom_field_value(1)
3536 3536 end
3537 3537
3538 3538 def test_bulk_update_multi_custom_field_to_blank
3539 3539 field = CustomField.find(1)
3540 3540 field.update_attribute :multiple, true
3541 3541
3542 3542 @request.session[:user_id] = 2
3543 3543 post :bulk_update, :ids => [1, 3], :notes => 'Bulk editing multi custom field',
3544 3544 :issue => {:priority_id => '',
3545 3545 :assigned_to_id => '',
3546 3546 :custom_field_values => {'1' => ['__none__']}}
3547 3547 assert_response 302
3548 3548 assert_equal [''], Issue.find(1).custom_field_value(1)
3549 3549 assert_equal [''], Issue.find(3).custom_field_value(1)
3550 3550 end
3551 3551
3552 3552 def test_bulk_update_unassign
3553 3553 assert_not_nil Issue.find(2).assigned_to
3554 3554 @request.session[:user_id] = 2
3555 3555 # unassign issues
3556 3556 post :bulk_update, :ids => [1, 2], :notes => 'Bulk unassigning', :issue => {:assigned_to_id => 'none'}
3557 3557 assert_response 302
3558 3558 # check that the issues were updated
3559 3559 assert_nil Issue.find(2).assigned_to
3560 3560 end
3561 3561
3562 3562 def test_post_bulk_update_should_allow_fixed_version_to_be_set_to_a_subproject
3563 3563 @request.session[:user_id] = 2
3564 3564
3565 3565 post :bulk_update, :ids => [1,2], :issue => {:fixed_version_id => 4}
3566 3566
3567 3567 assert_response :redirect
3568 3568 issues = Issue.find([1,2])
3569 3569 issues.each do |issue|
3570 3570 assert_equal 4, issue.fixed_version_id
3571 3571 assert_not_equal issue.project_id, issue.fixed_version.project_id
3572 3572 end
3573 3573 end
3574 3574
3575 3575 def test_post_bulk_update_should_redirect_back_using_the_back_url_parameter
3576 3576 @request.session[:user_id] = 2
3577 3577 post :bulk_update, :ids => [1,2], :back_url => '/issues'
3578 3578
3579 3579 assert_response :redirect
3580 3580 assert_redirected_to '/issues'
3581 3581 end
3582 3582
3583 3583 def test_post_bulk_update_should_not_redirect_back_using_the_back_url_parameter_off_the_host
3584 3584 @request.session[:user_id] = 2
3585 3585 post :bulk_update, :ids => [1,2], :back_url => 'http://google.com'
3586 3586
3587 3587 assert_response :redirect
3588 3588 assert_redirected_to :controller => 'issues', :action => 'index', :project_id => Project.find(1).identifier
3589 3589 end
3590 3590
3591 3591 def test_bulk_update_with_all_failures_should_show_errors
3592 3592 @request.session[:user_id] = 2
3593 3593 post :bulk_update, :ids => [1, 2], :issue => {:start_date => 'foo'}
3594 3594
3595 3595 assert_response :success
3596 3596 assert_template 'bulk_edit'
3597 3597 assert_select '#errorExplanation span', :text => 'Failed to save 2 issue(s) on 2 selected: #1, #2.'
3598 3598 assert_select '#errorExplanation ul li', :text => 'Start date is not a valid date: #1, #2'
3599 3599
3600 3600 assert_equal [1, 2], assigns[:issues].map(&:id)
3601 3601 end
3602 3602
3603 3603 def test_bulk_update_with_some_failures_should_show_errors
3604 3604 issue1 = Issue.generate!(:start_date => '2013-05-12')
3605 3605 issue2 = Issue.generate!(:start_date => '2013-05-15')
3606 3606 issue3 = Issue.generate!
3607 3607
3608 3608 @request.session[:user_id] = 2
3609 3609 post :bulk_update, :ids => [issue1.id, issue2.id, issue3.id], :issue => {:due_date => '2013-05-01'}
3610 3610
3611 3611 assert_response :success
3612 3612 assert_template 'bulk_edit'
3613 3613 assert_select '#errorExplanation span', :text => "Failed to save 2 issue(s) on 3 selected: ##{issue1.id}, ##{issue2.id}."
3614 3614 assert_select '#errorExplanation ul li', :text => "Due date must be greater than start date: ##{issue1.id}, ##{issue2.id}"
3615 3615
3616 3616 assert_equal [issue1.id, issue2.id], assigns[:issues].map(&:id)
3617 3617 end
3618 3618
3619 def test_bulk_update_with_failure_should_preserved_form_values
3620 @request.session[:user_id] = 2
3621 post :bulk_update, :ids => [1, 2], :issue => {:tracker_id => '2', :start_date => 'foo'}
3622
3623 assert_response :success
3624 assert_template 'bulk_edit'
3625 assert_select 'select[name=?]', 'issue[tracker_id]' do
3626 assert_select 'option[value=2][selected=selected]'
3627 end
3628 assert_select 'input[name=?][value=?]', 'issue[start_date]', 'foo'
3629 end
3630
3619 3631 def test_get_bulk_copy
3620 3632 @request.session[:user_id] = 2
3621 3633 get :bulk_edit, :ids => [1, 2, 3], :copy => '1'
3622 3634 assert_response :success
3623 3635 assert_template 'bulk_edit'
3624 3636
3625 3637 issues = assigns(:issues)
3626 3638 assert_not_nil issues
3627 3639 assert_equal [1, 2, 3], issues.map(&:id).sort
3628 3640
3629 3641 assert_select 'input[name=copy_attachments]'
3630 3642 end
3631 3643
3632 3644 def test_bulk_copy_to_another_project
3633 3645 @request.session[:user_id] = 2
3634 3646 assert_difference 'Issue.count', 2 do
3635 3647 assert_no_difference 'Project.find(1).issues.count' do
3636 3648 post :bulk_update, :ids => [1, 2], :issue => {:project_id => '2'}, :copy => '1'
3637 3649 end
3638 3650 end
3639 3651 assert_redirected_to '/projects/ecookbook/issues'
3640 3652
3641 3653 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3642 3654 copies.each do |copy|
3643 3655 assert_equal 2, copy.project_id
3644 3656 end
3645 3657 end
3646 3658
3647 3659 def test_bulk_copy_should_allow_not_changing_the_issue_attributes
3648 3660 @request.session[:user_id] = 2
3649 3661 issues = [
3650 3662 Issue.create!(:project_id => 1, :tracker_id => 1, :status_id => 1, :priority_id => 2, :subject => 'issue 1', :author_id => 1, :assigned_to_id => nil),
3651 3663 Issue.create!(:project_id => 2, :tracker_id => 3, :status_id => 2, :priority_id => 1, :subject => 'issue 2', :author_id => 2, :assigned_to_id => 3)
3652 3664 ]
3653 3665
3654 3666 assert_difference 'Issue.count', issues.size do
3655 3667 post :bulk_update, :ids => issues.map(&:id), :copy => '1',
3656 3668 :issue => {
3657 3669 :project_id => '', :tracker_id => '', :assigned_to_id => '',
3658 3670 :status_id => '', :start_date => '', :due_date => ''
3659 3671 }
3660 3672 end
3661 3673
3662 3674 copies = Issue.all(:order => 'id DESC', :limit => issues.size)
3663 3675 issues.each do |orig|
3664 3676 copy = copies.detect {|c| c.subject == orig.subject}
3665 3677 assert_not_nil copy
3666 3678 assert_equal orig.project_id, copy.project_id
3667 3679 assert_equal orig.tracker_id, copy.tracker_id
3668 3680 assert_equal orig.status_id, copy.status_id
3669 3681 assert_equal orig.assigned_to_id, copy.assigned_to_id
3670 3682 assert_equal orig.priority_id, copy.priority_id
3671 3683 end
3672 3684 end
3673 3685
3674 3686 def test_bulk_copy_should_allow_changing_the_issue_attributes
3675 3687 # Fixes random test failure with Mysql
3676 3688 # where Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3677 3689 # doesn't return the expected results
3678 3690 Issue.delete_all("project_id=2")
3679 3691
3680 3692 @request.session[:user_id] = 2
3681 3693 assert_difference 'Issue.count', 2 do
3682 3694 assert_no_difference 'Project.find(1).issues.count' do
3683 3695 post :bulk_update, :ids => [1, 2], :copy => '1',
3684 3696 :issue => {
3685 3697 :project_id => '2', :tracker_id => '', :assigned_to_id => '4',
3686 3698 :status_id => '1', :start_date => '2009-12-01', :due_date => '2009-12-31'
3687 3699 }
3688 3700 end
3689 3701 end
3690 3702
3691 3703 copied_issues = Issue.all(:limit => 2, :order => 'id desc', :conditions => {:project_id => 2})
3692 3704 assert_equal 2, copied_issues.size
3693 3705 copied_issues.each do |issue|
3694 3706 assert_equal 2, issue.project_id, "Project is incorrect"
3695 3707 assert_equal 4, issue.assigned_to_id, "Assigned to is incorrect"
3696 3708 assert_equal 1, issue.status_id, "Status is incorrect"
3697 3709 assert_equal '2009-12-01', issue.start_date.to_s, "Start date is incorrect"
3698 3710 assert_equal '2009-12-31', issue.due_date.to_s, "Due date is incorrect"
3699 3711 end
3700 3712 end
3701 3713
3702 3714 def test_bulk_copy_should_allow_adding_a_note
3703 3715 @request.session[:user_id] = 2
3704 3716 assert_difference 'Issue.count', 1 do
3705 3717 post :bulk_update, :ids => [1], :copy => '1',
3706 3718 :notes => 'Copying one issue',
3707 3719 :issue => {
3708 3720 :project_id => '', :tracker_id => '', :assigned_to_id => '4',
3709 3721 :status_id => '3', :start_date => '2009-12-01', :due_date => '2009-12-31'
3710 3722 }
3711 3723 end
3712 3724
3713 3725 issue = Issue.first(:order => 'id DESC')
3714 3726 assert_equal 1, issue.journals.size
3715 3727 journal = issue.journals.first
3716 3728 assert_equal 0, journal.details.size
3717 3729 assert_equal 'Copying one issue', journal.notes
3718 3730 end
3719 3731
3720 3732 def test_bulk_copy_should_allow_not_copying_the_attachments
3721 3733 attachment_count = Issue.find(3).attachments.size
3722 3734 assert attachment_count > 0
3723 3735 @request.session[:user_id] = 2
3724 3736
3725 3737 assert_difference 'Issue.count', 1 do
3726 3738 assert_no_difference 'Attachment.count' do
3727 3739 post :bulk_update, :ids => [3], :copy => '1',
3728 3740 :issue => {
3729 3741 :project_id => ''
3730 3742 }
3731 3743 end
3732 3744 end
3733 3745 end
3734 3746
3735 3747 def test_bulk_copy_should_allow_copying_the_attachments
3736 3748 attachment_count = Issue.find(3).attachments.size
3737 3749 assert attachment_count > 0
3738 3750 @request.session[:user_id] = 2
3739 3751
3740 3752 assert_difference 'Issue.count', 1 do
3741 3753 assert_difference 'Attachment.count', attachment_count do
3742 3754 post :bulk_update, :ids => [3], :copy => '1', :copy_attachments => '1',
3743 3755 :issue => {
3744 3756 :project_id => ''
3745 3757 }
3746 3758 end
3747 3759 end
3748 3760 end
3749 3761
3750 3762 def test_bulk_copy_should_add_relations_with_copied_issues
3751 3763 @request.session[:user_id] = 2
3752 3764
3753 3765 assert_difference 'Issue.count', 2 do
3754 3766 assert_difference 'IssueRelation.count', 2 do
3755 3767 post :bulk_update, :ids => [1, 3], :copy => '1',
3756 3768 :issue => {
3757 3769 :project_id => '1'
3758 3770 }
3759 3771 end
3760 3772 end
3761 3773 end
3762 3774
3763 3775 def test_bulk_copy_should_allow_not_copying_the_subtasks
3764 3776 issue = Issue.generate_with_descendants!
3765 3777 @request.session[:user_id] = 2
3766 3778
3767 3779 assert_difference 'Issue.count', 1 do
3768 3780 post :bulk_update, :ids => [issue.id], :copy => '1',
3769 3781 :issue => {
3770 3782 :project_id => ''
3771 3783 }
3772 3784 end
3773 3785 end
3774 3786
3775 3787 def test_bulk_copy_should_allow_copying_the_subtasks
3776 3788 issue = Issue.generate_with_descendants!
3777 3789 count = issue.descendants.count
3778 3790 @request.session[:user_id] = 2
3779 3791
3780 3792 assert_difference 'Issue.count', count+1 do
3781 3793 post :bulk_update, :ids => [issue.id], :copy => '1', :copy_subtasks => '1',
3782 3794 :issue => {
3783 3795 :project_id => ''
3784 3796 }
3785 3797 end
3786 3798 copy = Issue.where(:parent_id => nil).order("id DESC").first
3787 3799 assert_equal count, copy.descendants.count
3788 3800 end
3789 3801
3790 3802 def test_bulk_copy_should_not_copy_selected_subtasks_twice
3791 3803 issue = Issue.generate_with_descendants!
3792 3804 count = issue.descendants.count
3793 3805 @request.session[:user_id] = 2
3794 3806
3795 3807 assert_difference 'Issue.count', count+1 do
3796 3808 post :bulk_update, :ids => issue.self_and_descendants.map(&:id), :copy => '1', :copy_subtasks => '1',
3797 3809 :issue => {
3798 3810 :project_id => ''
3799 3811 }
3800 3812 end
3801 3813 copy = Issue.where(:parent_id => nil).order("id DESC").first
3802 3814 assert_equal count, copy.descendants.count
3803 3815 end
3804 3816
3805 3817 def test_bulk_copy_to_another_project_should_follow_when_needed
3806 3818 @request.session[:user_id] = 2
3807 3819 post :bulk_update, :ids => [1], :copy => '1', :issue => {:project_id => 2}, :follow => '1'
3808 3820 issue = Issue.first(:order => 'id DESC')
3809 3821 assert_redirected_to :controller => 'issues', :action => 'show', :id => issue
3810 3822 end
3811 3823
3812 3824 def test_destroy_issue_with_no_time_entries
3813 3825 assert_nil TimeEntry.find_by_issue_id(2)
3814 3826 @request.session[:user_id] = 2
3815 3827
3816 3828 assert_difference 'Issue.count', -1 do
3817 3829 delete :destroy, :id => 2
3818 3830 end
3819 3831 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3820 3832 assert_nil Issue.find_by_id(2)
3821 3833 end
3822 3834
3823 3835 def test_destroy_issues_with_time_entries
3824 3836 @request.session[:user_id] = 2
3825 3837
3826 3838 assert_no_difference 'Issue.count' do
3827 3839 delete :destroy, :ids => [1, 3]
3828 3840 end
3829 3841 assert_response :success
3830 3842 assert_template 'destroy'
3831 3843 assert_not_nil assigns(:hours)
3832 3844 assert Issue.find_by_id(1) && Issue.find_by_id(3)
3833 3845
3834 3846 assert_select 'form' do
3835 3847 assert_select 'input[name=_method][value=delete]'
3836 3848 end
3837 3849 end
3838 3850
3839 3851 def test_destroy_issues_and_destroy_time_entries
3840 3852 @request.session[:user_id] = 2
3841 3853
3842 3854 assert_difference 'Issue.count', -2 do
3843 3855 assert_difference 'TimeEntry.count', -3 do
3844 3856 delete :destroy, :ids => [1, 3], :todo => 'destroy'
3845 3857 end
3846 3858 end
3847 3859 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3848 3860 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3849 3861 assert_nil TimeEntry.find_by_id([1, 2])
3850 3862 end
3851 3863
3852 3864 def test_destroy_issues_and_assign_time_entries_to_project
3853 3865 @request.session[:user_id] = 2
3854 3866
3855 3867 assert_difference 'Issue.count', -2 do
3856 3868 assert_no_difference 'TimeEntry.count' do
3857 3869 delete :destroy, :ids => [1, 3], :todo => 'nullify'
3858 3870 end
3859 3871 end
3860 3872 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3861 3873 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3862 3874 assert_nil TimeEntry.find(1).issue_id
3863 3875 assert_nil TimeEntry.find(2).issue_id
3864 3876 end
3865 3877
3866 3878 def test_destroy_issues_and_reassign_time_entries_to_another_issue
3867 3879 @request.session[:user_id] = 2
3868 3880
3869 3881 assert_difference 'Issue.count', -2 do
3870 3882 assert_no_difference 'TimeEntry.count' do
3871 3883 delete :destroy, :ids => [1, 3], :todo => 'reassign', :reassign_to_id => 2
3872 3884 end
3873 3885 end
3874 3886 assert_redirected_to :action => 'index', :project_id => 'ecookbook'
3875 3887 assert !(Issue.find_by_id(1) || Issue.find_by_id(3))
3876 3888 assert_equal 2, TimeEntry.find(1).issue_id
3877 3889 assert_equal 2, TimeEntry.find(2).issue_id
3878 3890 end
3879 3891
3880 3892 def test_destroy_issues_from_different_projects
3881 3893 @request.session[:user_id] = 2
3882 3894
3883 3895 assert_difference 'Issue.count', -3 do
3884 3896 delete :destroy, :ids => [1, 2, 6], :todo => 'destroy'
3885 3897 end
3886 3898 assert_redirected_to :controller => 'issues', :action => 'index'
3887 3899 assert !(Issue.find_by_id(1) || Issue.find_by_id(2) || Issue.find_by_id(6))
3888 3900 end
3889 3901
3890 3902 def test_destroy_parent_and_child_issues
3891 3903 parent = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Parent Issue')
3892 3904 child = Issue.create!(:project_id => 1, :author_id => 1, :tracker_id => 1, :subject => 'Child Issue', :parent_issue_id => parent.id)
3893 3905 assert child.is_descendant_of?(parent.reload)
3894 3906
3895 3907 @request.session[:user_id] = 2
3896 3908 assert_difference 'Issue.count', -2 do
3897 3909 delete :destroy, :ids => [parent.id, child.id], :todo => 'destroy'
3898 3910 end
3899 3911 assert_response 302
3900 3912 end
3901 3913
3902 3914 def test_destroy_invalid_should_respond_with_404
3903 3915 @request.session[:user_id] = 2
3904 3916 assert_no_difference 'Issue.count' do
3905 3917 delete :destroy, :id => 999
3906 3918 end
3907 3919 assert_response 404
3908 3920 end
3909 3921
3910 3922 def test_default_search_scope
3911 3923 get :index
3912 3924
3913 3925 assert_select 'div#quick-search form' do
3914 3926 assert_select 'input[name=issues][value=1][type=hidden]'
3915 3927 end
3916 3928 end
3917 3929 end
General Comments 0
You need to be logged in to leave comments. Login now