##// END OF EJS Templates
code layout clean up test_assignable_versions of unit issue test...
Toshi MARUYAMA -
r10443:6ebfe54e6ee9
parent child
Show More
@@ -1,1795 +1,1797
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
2 # Copyright (C) 2006-2012 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 require File.expand_path('../../test_helper', __FILE__)
18 require File.expand_path('../../test_helper', __FILE__)
19
19
20 class IssueTest < ActiveSupport::TestCase
20 class IssueTest < ActiveSupport::TestCase
21 fixtures :projects, :users, :members, :member_roles, :roles,
21 fixtures :projects, :users, :members, :member_roles, :roles,
22 :groups_users,
22 :groups_users,
23 :trackers, :projects_trackers,
23 :trackers, :projects_trackers,
24 :enabled_modules,
24 :enabled_modules,
25 :versions,
25 :versions,
26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
26 :issue_statuses, :issue_categories, :issue_relations, :workflows,
27 :enumerations,
27 :enumerations,
28 :issues, :journals, :journal_details,
28 :issues, :journals, :journal_details,
29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
29 :custom_fields, :custom_fields_projects, :custom_fields_trackers, :custom_values,
30 :time_entries
30 :time_entries
31
31
32 include Redmine::I18n
32 include Redmine::I18n
33
33
34 def teardown
34 def teardown
35 User.current = nil
35 User.current = nil
36 end
36 end
37
37
38 def test_create
38 def test_create
39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
39 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
40 :status_id => 1, :priority => IssuePriority.all.first,
40 :status_id => 1, :priority => IssuePriority.all.first,
41 :subject => 'test_create',
41 :subject => 'test_create',
42 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
42 :description => 'IssueTest#test_create', :estimated_hours => '1:30')
43 assert issue.save
43 assert issue.save
44 issue.reload
44 issue.reload
45 assert_equal 1.5, issue.estimated_hours
45 assert_equal 1.5, issue.estimated_hours
46 end
46 end
47
47
48 def test_create_minimal
48 def test_create_minimal
49 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
49 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 3,
50 :status_id => 1, :priority => IssuePriority.all.first,
50 :status_id => 1, :priority => IssuePriority.all.first,
51 :subject => 'test_create')
51 :subject => 'test_create')
52 assert issue.save
52 assert issue.save
53 assert issue.description.nil?
53 assert issue.description.nil?
54 assert_nil issue.estimated_hours
54 assert_nil issue.estimated_hours
55 end
55 end
56
56
57 def test_create_with_required_custom_field
57 def test_create_with_required_custom_field
58 set_language_if_valid 'en'
58 set_language_if_valid 'en'
59 field = IssueCustomField.find_by_name('Database')
59 field = IssueCustomField.find_by_name('Database')
60 field.update_attribute(:is_required, true)
60 field.update_attribute(:is_required, true)
61
61
62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
62 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
63 :status_id => 1, :subject => 'test_create',
63 :status_id => 1, :subject => 'test_create',
64 :description => 'IssueTest#test_create_with_required_custom_field')
64 :description => 'IssueTest#test_create_with_required_custom_field')
65 assert issue.available_custom_fields.include?(field)
65 assert issue.available_custom_fields.include?(field)
66 # No value for the custom field
66 # No value for the custom field
67 assert !issue.save
67 assert !issue.save
68 assert_equal ["Database can't be blank"], issue.errors.full_messages
68 assert_equal ["Database can't be blank"], issue.errors.full_messages
69 # Blank value
69 # Blank value
70 issue.custom_field_values = { field.id => '' }
70 issue.custom_field_values = { field.id => '' }
71 assert !issue.save
71 assert !issue.save
72 assert_equal ["Database can't be blank"], issue.errors.full_messages
72 assert_equal ["Database can't be blank"], issue.errors.full_messages
73 # Invalid value
73 # Invalid value
74 issue.custom_field_values = { field.id => 'SQLServer' }
74 issue.custom_field_values = { field.id => 'SQLServer' }
75 assert !issue.save
75 assert !issue.save
76 assert_equal ["Database is not included in the list"], issue.errors.full_messages
76 assert_equal ["Database is not included in the list"], issue.errors.full_messages
77 # Valid value
77 # Valid value
78 issue.custom_field_values = { field.id => 'PostgreSQL' }
78 issue.custom_field_values = { field.id => 'PostgreSQL' }
79 assert issue.save
79 assert issue.save
80 issue.reload
80 issue.reload
81 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
81 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
82 end
82 end
83
83
84 def test_create_with_group_assignment
84 def test_create_with_group_assignment
85 with_settings :issue_group_assignment => '1' do
85 with_settings :issue_group_assignment => '1' do
86 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
86 assert Issue.new(:project_id => 2, :tracker_id => 1, :author_id => 1,
87 :subject => 'Group assignment',
87 :subject => 'Group assignment',
88 :assigned_to_id => 11).save
88 :assigned_to_id => 11).save
89 issue = Issue.first(:order => 'id DESC')
89 issue = Issue.first(:order => 'id DESC')
90 assert_kind_of Group, issue.assigned_to
90 assert_kind_of Group, issue.assigned_to
91 assert_equal Group.find(11), issue.assigned_to
91 assert_equal Group.find(11), issue.assigned_to
92 end
92 end
93 end
93 end
94
94
95 def test_create_with_parent_issue_id
95 def test_create_with_parent_issue_id
96 issue = Issue.new(:project_id => 1, :tracker_id => 1,
96 issue = Issue.new(:project_id => 1, :tracker_id => 1,
97 :author_id => 1, :subject => 'Group assignment',
97 :author_id => 1, :subject => 'Group assignment',
98 :parent_issue_id => 1)
98 :parent_issue_id => 1)
99 assert_save issue
99 assert_save issue
100 assert_equal 1, issue.parent_issue_id
100 assert_equal 1, issue.parent_issue_id
101 assert_equal Issue.find(1), issue.parent
101 assert_equal Issue.find(1), issue.parent
102 end
102 end
103
103
104 def test_create_with_sharp_parent_issue_id
104 def test_create_with_sharp_parent_issue_id
105 issue = Issue.new(:project_id => 1, :tracker_id => 1,
105 issue = Issue.new(:project_id => 1, :tracker_id => 1,
106 :author_id => 1, :subject => 'Group assignment',
106 :author_id => 1, :subject => 'Group assignment',
107 :parent_issue_id => "#1")
107 :parent_issue_id => "#1")
108 assert_save issue
108 assert_save issue
109 assert_equal 1, issue.parent_issue_id
109 assert_equal 1, issue.parent_issue_id
110 assert_equal Issue.find(1), issue.parent
110 assert_equal Issue.find(1), issue.parent
111 end
111 end
112
112
113 def test_create_with_invalid_parent_issue_id
113 def test_create_with_invalid_parent_issue_id
114 set_language_if_valid 'en'
114 set_language_if_valid 'en'
115 issue = Issue.new(:project_id => 1, :tracker_id => 1,
115 issue = Issue.new(:project_id => 1, :tracker_id => 1,
116 :author_id => 1, :subject => 'Group assignment',
116 :author_id => 1, :subject => 'Group assignment',
117 :parent_issue_id => '01ABC')
117 :parent_issue_id => '01ABC')
118 assert !issue.save
118 assert !issue.save
119 assert_equal '01ABC', issue.parent_issue_id
119 assert_equal '01ABC', issue.parent_issue_id
120 assert_include 'Parent task is invalid', issue.errors.full_messages
120 assert_include 'Parent task is invalid', issue.errors.full_messages
121 end
121 end
122
122
123 def test_create_with_invalid_sharp_parent_issue_id
123 def test_create_with_invalid_sharp_parent_issue_id
124 set_language_if_valid 'en'
124 set_language_if_valid 'en'
125 issue = Issue.new(:project_id => 1, :tracker_id => 1,
125 issue = Issue.new(:project_id => 1, :tracker_id => 1,
126 :author_id => 1, :subject => 'Group assignment',
126 :author_id => 1, :subject => 'Group assignment',
127 :parent_issue_id => '#01ABC')
127 :parent_issue_id => '#01ABC')
128 assert !issue.save
128 assert !issue.save
129 assert_equal '#01ABC', issue.parent_issue_id
129 assert_equal '#01ABC', issue.parent_issue_id
130 assert_include 'Parent task is invalid', issue.errors.full_messages
130 assert_include 'Parent task is invalid', issue.errors.full_messages
131 end
131 end
132
132
133 def assert_visibility_match(user, issues)
133 def assert_visibility_match(user, issues)
134 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
134 assert_equal issues.collect(&:id).sort, Issue.all.select {|issue| issue.visible?(user)}.collect(&:id).sort
135 end
135 end
136
136
137 def test_visible_scope_for_anonymous
137 def test_visible_scope_for_anonymous
138 # Anonymous user should see issues of public projects only
138 # Anonymous user should see issues of public projects only
139 issues = Issue.visible(User.anonymous).all
139 issues = Issue.visible(User.anonymous).all
140 assert issues.any?
140 assert issues.any?
141 assert_nil issues.detect {|issue| !issue.project.is_public?}
141 assert_nil issues.detect {|issue| !issue.project.is_public?}
142 assert_nil issues.detect {|issue| issue.is_private?}
142 assert_nil issues.detect {|issue| issue.is_private?}
143 assert_visibility_match User.anonymous, issues
143 assert_visibility_match User.anonymous, issues
144 end
144 end
145
145
146 def test_visible_scope_for_anonymous_without_view_issues_permissions
146 def test_visible_scope_for_anonymous_without_view_issues_permissions
147 # Anonymous user should not see issues without permission
147 # Anonymous user should not see issues without permission
148 Role.anonymous.remove_permission!(:view_issues)
148 Role.anonymous.remove_permission!(:view_issues)
149 issues = Issue.visible(User.anonymous).all
149 issues = Issue.visible(User.anonymous).all
150 assert issues.empty?
150 assert issues.empty?
151 assert_visibility_match User.anonymous, issues
151 assert_visibility_match User.anonymous, issues
152 end
152 end
153
153
154 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
154 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_default
155 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
155 assert Role.anonymous.update_attribute(:issues_visibility, 'default')
156 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
156 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
157 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
157 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
158 assert !issue.visible?(User.anonymous)
158 assert !issue.visible?(User.anonymous)
159 end
159 end
160
160
161 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
161 def test_anonymous_should_not_see_private_issues_with_issues_visibility_set_to_own
162 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
162 assert Role.anonymous.update_attribute(:issues_visibility, 'own')
163 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
163 issue = Issue.generate!(:author => User.anonymous, :assigned_to => User.anonymous, :is_private => true)
164 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
164 assert_nil Issue.where(:id => issue.id).visible(User.anonymous).first
165 assert !issue.visible?(User.anonymous)
165 assert !issue.visible?(User.anonymous)
166 end
166 end
167
167
168 def test_visible_scope_for_non_member
168 def test_visible_scope_for_non_member
169 user = User.find(9)
169 user = User.find(9)
170 assert user.projects.empty?
170 assert user.projects.empty?
171 # Non member user should see issues of public projects only
171 # Non member user should see issues of public projects only
172 issues = Issue.visible(user).all
172 issues = Issue.visible(user).all
173 assert issues.any?
173 assert issues.any?
174 assert_nil issues.detect {|issue| !issue.project.is_public?}
174 assert_nil issues.detect {|issue| !issue.project.is_public?}
175 assert_nil issues.detect {|issue| issue.is_private?}
175 assert_nil issues.detect {|issue| issue.is_private?}
176 assert_visibility_match user, issues
176 assert_visibility_match user, issues
177 end
177 end
178
178
179 def test_visible_scope_for_non_member_with_own_issues_visibility
179 def test_visible_scope_for_non_member_with_own_issues_visibility
180 Role.non_member.update_attribute :issues_visibility, 'own'
180 Role.non_member.update_attribute :issues_visibility, 'own'
181 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
181 Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 9, :subject => 'Issue by non member')
182 user = User.find(9)
182 user = User.find(9)
183
183
184 issues = Issue.visible(user).all
184 issues = Issue.visible(user).all
185 assert issues.any?
185 assert issues.any?
186 assert_nil issues.detect {|issue| issue.author != user}
186 assert_nil issues.detect {|issue| issue.author != user}
187 assert_visibility_match user, issues
187 assert_visibility_match user, issues
188 end
188 end
189
189
190 def test_visible_scope_for_non_member_without_view_issues_permissions
190 def test_visible_scope_for_non_member_without_view_issues_permissions
191 # Non member user should not see issues without permission
191 # Non member user should not see issues without permission
192 Role.non_member.remove_permission!(:view_issues)
192 Role.non_member.remove_permission!(:view_issues)
193 user = User.find(9)
193 user = User.find(9)
194 assert user.projects.empty?
194 assert user.projects.empty?
195 issues = Issue.visible(user).all
195 issues = Issue.visible(user).all
196 assert issues.empty?
196 assert issues.empty?
197 assert_visibility_match user, issues
197 assert_visibility_match user, issues
198 end
198 end
199
199
200 def test_visible_scope_for_member
200 def test_visible_scope_for_member
201 user = User.find(9)
201 user = User.find(9)
202 # User should see issues of projects for which he has view_issues permissions only
202 # User should see issues of projects for which he has view_issues permissions only
203 Role.non_member.remove_permission!(:view_issues)
203 Role.non_member.remove_permission!(:view_issues)
204 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
204 Member.create!(:principal => user, :project_id => 3, :role_ids => [2])
205 issues = Issue.visible(user).all
205 issues = Issue.visible(user).all
206 assert issues.any?
206 assert issues.any?
207 assert_nil issues.detect {|issue| issue.project_id != 3}
207 assert_nil issues.detect {|issue| issue.project_id != 3}
208 assert_nil issues.detect {|issue| issue.is_private?}
208 assert_nil issues.detect {|issue| issue.is_private?}
209 assert_visibility_match user, issues
209 assert_visibility_match user, issues
210 end
210 end
211
211
212 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
212 def test_visible_scope_for_member_with_groups_should_return_assigned_issues
213 user = User.find(8)
213 user = User.find(8)
214 assert user.groups.any?
214 assert user.groups.any?
215 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
215 Member.create!(:principal => user.groups.first, :project_id => 1, :role_ids => [2])
216 Role.non_member.remove_permission!(:view_issues)
216 Role.non_member.remove_permission!(:view_issues)
217
217
218 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
218 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
219 :status_id => 1, :priority => IssuePriority.all.first,
219 :status_id => 1, :priority => IssuePriority.all.first,
220 :subject => 'Assignment test',
220 :subject => 'Assignment test',
221 :assigned_to => user.groups.first,
221 :assigned_to => user.groups.first,
222 :is_private => true)
222 :is_private => true)
223
223
224 Role.find(2).update_attribute :issues_visibility, 'default'
224 Role.find(2).update_attribute :issues_visibility, 'default'
225 issues = Issue.visible(User.find(8)).all
225 issues = Issue.visible(User.find(8)).all
226 assert issues.any?
226 assert issues.any?
227 assert issues.include?(issue)
227 assert issues.include?(issue)
228
228
229 Role.find(2).update_attribute :issues_visibility, 'own'
229 Role.find(2).update_attribute :issues_visibility, 'own'
230 issues = Issue.visible(User.find(8)).all
230 issues = Issue.visible(User.find(8)).all
231 assert issues.any?
231 assert issues.any?
232 assert issues.include?(issue)
232 assert issues.include?(issue)
233 end
233 end
234
234
235 def test_visible_scope_for_admin
235 def test_visible_scope_for_admin
236 user = User.find(1)
236 user = User.find(1)
237 user.members.each(&:destroy)
237 user.members.each(&:destroy)
238 assert user.projects.empty?
238 assert user.projects.empty?
239 issues = Issue.visible(user).all
239 issues = Issue.visible(user).all
240 assert issues.any?
240 assert issues.any?
241 # Admin should see issues on private projects that he does not belong to
241 # Admin should see issues on private projects that he does not belong to
242 assert issues.detect {|issue| !issue.project.is_public?}
242 assert issues.detect {|issue| !issue.project.is_public?}
243 # Admin should see private issues of other users
243 # Admin should see private issues of other users
244 assert issues.detect {|issue| issue.is_private? && issue.author != user}
244 assert issues.detect {|issue| issue.is_private? && issue.author != user}
245 assert_visibility_match user, issues
245 assert_visibility_match user, issues
246 end
246 end
247
247
248 def test_visible_scope_with_project
248 def test_visible_scope_with_project
249 project = Project.find(1)
249 project = Project.find(1)
250 issues = Issue.visible(User.find(2), :project => project).all
250 issues = Issue.visible(User.find(2), :project => project).all
251 projects = issues.collect(&:project).uniq
251 projects = issues.collect(&:project).uniq
252 assert_equal 1, projects.size
252 assert_equal 1, projects.size
253 assert_equal project, projects.first
253 assert_equal project, projects.first
254 end
254 end
255
255
256 def test_visible_scope_with_project_and_subprojects
256 def test_visible_scope_with_project_and_subprojects
257 project = Project.find(1)
257 project = Project.find(1)
258 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
258 issues = Issue.visible(User.find(2), :project => project, :with_subprojects => true).all
259 projects = issues.collect(&:project).uniq
259 projects = issues.collect(&:project).uniq
260 assert projects.size > 1
260 assert projects.size > 1
261 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
261 assert_equal [], projects.select {|p| !p.is_or_is_descendant_of?(project)}
262 end
262 end
263
263
264 def test_visible_and_nested_set_scopes
264 def test_visible_and_nested_set_scopes
265 assert_equal 0, Issue.find(1).descendants.visible.all.size
265 assert_equal 0, Issue.find(1).descendants.visible.all.size
266 end
266 end
267
267
268 def test_open_scope
268 def test_open_scope
269 issues = Issue.open.all
269 issues = Issue.open.all
270 assert_nil issues.detect(&:closed?)
270 assert_nil issues.detect(&:closed?)
271 end
271 end
272
272
273 def test_open_scope_with_arg
273 def test_open_scope_with_arg
274 issues = Issue.open(false).all
274 issues = Issue.open(false).all
275 assert_equal issues, issues.select(&:closed?)
275 assert_equal issues, issues.select(&:closed?)
276 end
276 end
277
277
278 def test_errors_full_messages_should_include_custom_fields_errors
278 def test_errors_full_messages_should_include_custom_fields_errors
279 field = IssueCustomField.find_by_name('Database')
279 field = IssueCustomField.find_by_name('Database')
280
280
281 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
281 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
282 :status_id => 1, :subject => 'test_create',
282 :status_id => 1, :subject => 'test_create',
283 :description => 'IssueTest#test_create_with_required_custom_field')
283 :description => 'IssueTest#test_create_with_required_custom_field')
284 assert issue.available_custom_fields.include?(field)
284 assert issue.available_custom_fields.include?(field)
285 # Invalid value
285 # Invalid value
286 issue.custom_field_values = { field.id => 'SQLServer' }
286 issue.custom_field_values = { field.id => 'SQLServer' }
287
287
288 assert !issue.valid?
288 assert !issue.valid?
289 assert_equal 1, issue.errors.full_messages.size
289 assert_equal 1, issue.errors.full_messages.size
290 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
290 assert_equal "Database #{I18n.translate('activerecord.errors.messages.inclusion')}",
291 issue.errors.full_messages.first
291 issue.errors.full_messages.first
292 end
292 end
293
293
294 def test_update_issue_with_required_custom_field
294 def test_update_issue_with_required_custom_field
295 field = IssueCustomField.find_by_name('Database')
295 field = IssueCustomField.find_by_name('Database')
296 field.update_attribute(:is_required, true)
296 field.update_attribute(:is_required, true)
297
297
298 issue = Issue.find(1)
298 issue = Issue.find(1)
299 assert_nil issue.custom_value_for(field)
299 assert_nil issue.custom_value_for(field)
300 assert issue.available_custom_fields.include?(field)
300 assert issue.available_custom_fields.include?(field)
301 # No change to custom values, issue can be saved
301 # No change to custom values, issue can be saved
302 assert issue.save
302 assert issue.save
303 # Blank value
303 # Blank value
304 issue.custom_field_values = { field.id => '' }
304 issue.custom_field_values = { field.id => '' }
305 assert !issue.save
305 assert !issue.save
306 # Valid value
306 # Valid value
307 issue.custom_field_values = { field.id => 'PostgreSQL' }
307 issue.custom_field_values = { field.id => 'PostgreSQL' }
308 assert issue.save
308 assert issue.save
309 issue.reload
309 issue.reload
310 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
310 assert_equal 'PostgreSQL', issue.custom_value_for(field).value
311 end
311 end
312
312
313 def test_should_not_update_attributes_if_custom_fields_validation_fails
313 def test_should_not_update_attributes_if_custom_fields_validation_fails
314 issue = Issue.find(1)
314 issue = Issue.find(1)
315 field = IssueCustomField.find_by_name('Database')
315 field = IssueCustomField.find_by_name('Database')
316 assert issue.available_custom_fields.include?(field)
316 assert issue.available_custom_fields.include?(field)
317
317
318 issue.custom_field_values = { field.id => 'Invalid' }
318 issue.custom_field_values = { field.id => 'Invalid' }
319 issue.subject = 'Should be not be saved'
319 issue.subject = 'Should be not be saved'
320 assert !issue.save
320 assert !issue.save
321
321
322 issue.reload
322 issue.reload
323 assert_equal "Can't print recipes", issue.subject
323 assert_equal "Can't print recipes", issue.subject
324 end
324 end
325
325
326 def test_should_not_recreate_custom_values_objects_on_update
326 def test_should_not_recreate_custom_values_objects_on_update
327 field = IssueCustomField.find_by_name('Database')
327 field = IssueCustomField.find_by_name('Database')
328
328
329 issue = Issue.find(1)
329 issue = Issue.find(1)
330 issue.custom_field_values = { field.id => 'PostgreSQL' }
330 issue.custom_field_values = { field.id => 'PostgreSQL' }
331 assert issue.save
331 assert issue.save
332 custom_value = issue.custom_value_for(field)
332 custom_value = issue.custom_value_for(field)
333 issue.reload
333 issue.reload
334 issue.custom_field_values = { field.id => 'MySQL' }
334 issue.custom_field_values = { field.id => 'MySQL' }
335 assert issue.save
335 assert issue.save
336 issue.reload
336 issue.reload
337 assert_equal custom_value.id, issue.custom_value_for(field).id
337 assert_equal custom_value.id, issue.custom_value_for(field).id
338 end
338 end
339
339
340 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
340 def test_should_not_update_custom_fields_on_changing_tracker_with_different_custom_fields
341 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
341 issue = Issue.create!(:project_id => 1, :tracker_id => 1, :author_id => 1,
342 :status_id => 1, :subject => 'Test',
342 :status_id => 1, :subject => 'Test',
343 :custom_field_values => {'2' => 'Test'})
343 :custom_field_values => {'2' => 'Test'})
344 assert !Tracker.find(2).custom_field_ids.include?(2)
344 assert !Tracker.find(2).custom_field_ids.include?(2)
345
345
346 issue = Issue.find(issue.id)
346 issue = Issue.find(issue.id)
347 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
347 issue.attributes = {:tracker_id => 2, :custom_field_values => {'1' => ''}}
348
348
349 issue = Issue.find(issue.id)
349 issue = Issue.find(issue.id)
350 custom_value = issue.custom_value_for(2)
350 custom_value = issue.custom_value_for(2)
351 assert_not_nil custom_value
351 assert_not_nil custom_value
352 assert_equal 'Test', custom_value.value
352 assert_equal 'Test', custom_value.value
353 end
353 end
354
354
355 def test_assigning_tracker_id_should_reload_custom_fields_values
355 def test_assigning_tracker_id_should_reload_custom_fields_values
356 issue = Issue.new(:project => Project.find(1))
356 issue = Issue.new(:project => Project.find(1))
357 assert issue.custom_field_values.empty?
357 assert issue.custom_field_values.empty?
358 issue.tracker_id = 1
358 issue.tracker_id = 1
359 assert issue.custom_field_values.any?
359 assert issue.custom_field_values.any?
360 end
360 end
361
361
362 def test_assigning_attributes_should_assign_project_and_tracker_first
362 def test_assigning_attributes_should_assign_project_and_tracker_first
363 seq = sequence('seq')
363 seq = sequence('seq')
364 issue = Issue.new
364 issue = Issue.new
365 issue.expects(:project_id=).in_sequence(seq)
365 issue.expects(:project_id=).in_sequence(seq)
366 issue.expects(:tracker_id=).in_sequence(seq)
366 issue.expects(:tracker_id=).in_sequence(seq)
367 issue.expects(:subject=).in_sequence(seq)
367 issue.expects(:subject=).in_sequence(seq)
368 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
368 issue.attributes = {:tracker_id => 2, :project_id => 1, :subject => 'Test'}
369 end
369 end
370
370
371 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
371 def test_assigning_tracker_and_custom_fields_should_assign_custom_fields
372 attributes = ActiveSupport::OrderedHash.new
372 attributes = ActiveSupport::OrderedHash.new
373 attributes['custom_field_values'] = { '1' => 'MySQL' }
373 attributes['custom_field_values'] = { '1' => 'MySQL' }
374 attributes['tracker_id'] = '1'
374 attributes['tracker_id'] = '1'
375 issue = Issue.new(:project => Project.find(1))
375 issue = Issue.new(:project => Project.find(1))
376 issue.attributes = attributes
376 issue.attributes = attributes
377 assert_equal 'MySQL', issue.custom_field_value(1)
377 assert_equal 'MySQL', issue.custom_field_value(1)
378 end
378 end
379
379
380 def test_should_update_issue_with_disabled_tracker
380 def test_should_update_issue_with_disabled_tracker
381 p = Project.find(1)
381 p = Project.find(1)
382 issue = Issue.find(1)
382 issue = Issue.find(1)
383
383
384 p.trackers.delete(issue.tracker)
384 p.trackers.delete(issue.tracker)
385 assert !p.trackers.include?(issue.tracker)
385 assert !p.trackers.include?(issue.tracker)
386
386
387 issue.reload
387 issue.reload
388 issue.subject = 'New subject'
388 issue.subject = 'New subject'
389 assert issue.save
389 assert issue.save
390 end
390 end
391
391
392 def test_should_not_set_a_disabled_tracker
392 def test_should_not_set_a_disabled_tracker
393 p = Project.find(1)
393 p = Project.find(1)
394 p.trackers.delete(Tracker.find(2))
394 p.trackers.delete(Tracker.find(2))
395
395
396 issue = Issue.find(1)
396 issue = Issue.find(1)
397 issue.tracker_id = 2
397 issue.tracker_id = 2
398 issue.subject = 'New subject'
398 issue.subject = 'New subject'
399 assert !issue.save
399 assert !issue.save
400 assert_not_nil issue.errors[:tracker_id]
400 assert_not_nil issue.errors[:tracker_id]
401 end
401 end
402
402
403 def test_category_based_assignment
403 def test_category_based_assignment
404 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
404 issue = Issue.create(:project_id => 1, :tracker_id => 1, :author_id => 3,
405 :status_id => 1, :priority => IssuePriority.all.first,
405 :status_id => 1, :priority => IssuePriority.all.first,
406 :subject => 'Assignment test',
406 :subject => 'Assignment test',
407 :description => 'Assignment test', :category_id => 1)
407 :description => 'Assignment test', :category_id => 1)
408 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
408 assert_equal IssueCategory.find(1).assigned_to, issue.assigned_to
409 end
409 end
410
410
411 def test_new_statuses_allowed_to
411 def test_new_statuses_allowed_to
412 WorkflowTransition.delete_all
412 WorkflowTransition.delete_all
413 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
413 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
414 :old_status_id => 1, :new_status_id => 2,
414 :old_status_id => 1, :new_status_id => 2,
415 :author => false, :assignee => false)
415 :author => false, :assignee => false)
416 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
416 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
417 :old_status_id => 1, :new_status_id => 3,
417 :old_status_id => 1, :new_status_id => 3,
418 :author => true, :assignee => false)
418 :author => true, :assignee => false)
419 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
419 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1, :old_status_id => 1,
420 :new_status_id => 4, :author => false,
420 :new_status_id => 4, :author => false,
421 :assignee => true)
421 :assignee => true)
422 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
422 WorkflowTransition.create!(:role_id => 1, :tracker_id => 1,
423 :old_status_id => 1, :new_status_id => 5,
423 :old_status_id => 1, :new_status_id => 5,
424 :author => true, :assignee => true)
424 :author => true, :assignee => true)
425 status = IssueStatus.find(1)
425 status = IssueStatus.find(1)
426 role = Role.find(1)
426 role = Role.find(1)
427 tracker = Tracker.find(1)
427 tracker = Tracker.find(1)
428 user = User.find(2)
428 user = User.find(2)
429
429
430 issue = Issue.generate!(:tracker => tracker, :status => status,
430 issue = Issue.generate!(:tracker => tracker, :status => status,
431 :project_id => 1, :author_id => 1)
431 :project_id => 1, :author_id => 1)
432 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
432 assert_equal [1, 2], issue.new_statuses_allowed_to(user).map(&:id)
433
433
434 issue = Issue.generate!(:tracker => tracker, :status => status,
434 issue = Issue.generate!(:tracker => tracker, :status => status,
435 :project_id => 1, :author => user)
435 :project_id => 1, :author => user)
436 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
436 assert_equal [1, 2, 3, 5], issue.new_statuses_allowed_to(user).map(&:id)
437
437
438 issue = Issue.generate!(:tracker => tracker, :status => status,
438 issue = Issue.generate!(:tracker => tracker, :status => status,
439 :project_id => 1, :author_id => 1,
439 :project_id => 1, :author_id => 1,
440 :assigned_to => user)
440 :assigned_to => user)
441 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
441 assert_equal [1, 2, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
442
442
443 issue = Issue.generate!(:tracker => tracker, :status => status,
443 issue = Issue.generate!(:tracker => tracker, :status => status,
444 :project_id => 1, :author => user,
444 :project_id => 1, :author => user,
445 :assigned_to => user)
445 :assigned_to => user)
446 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
446 assert_equal [1, 2, 3, 4, 5], issue.new_statuses_allowed_to(user).map(&:id)
447 end
447 end
448
448
449 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
449 def test_new_statuses_allowed_to_should_return_all_transitions_for_admin
450 admin = User.find(1)
450 admin = User.find(1)
451 issue = Issue.find(1)
451 issue = Issue.find(1)
452 assert !admin.member_of?(issue.project)
452 assert !admin.member_of?(issue.project)
453 expected_statuses = [issue.status] +
453 expected_statuses = [issue.status] +
454 WorkflowTransition.find_all_by_old_status_id(
454 WorkflowTransition.find_all_by_old_status_id(
455 issue.status_id).map(&:new_status).uniq.sort
455 issue.status_id).map(&:new_status).uniq.sort
456 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
456 assert_equal expected_statuses, issue.new_statuses_allowed_to(admin)
457 end
457 end
458
458
459 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
459 def test_new_statuses_allowed_to_should_return_default_and_current_status_when_copying
460 issue = Issue.find(1).copy
460 issue = Issue.find(1).copy
461 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
461 assert_equal [1], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
462
462
463 issue = Issue.find(2).copy
463 issue = Issue.find(2).copy
464 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
464 assert_equal [1, 2], issue.new_statuses_allowed_to(User.find(2)).map(&:id)
465 end
465 end
466
466
467 def test_safe_attributes_names_should_not_include_disabled_field
467 def test_safe_attributes_names_should_not_include_disabled_field
468 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
468 tracker = Tracker.new(:core_fields => %w(assigned_to_id fixed_version_id))
469
469
470 issue = Issue.new(:tracker => tracker)
470 issue = Issue.new(:tracker => tracker)
471 assert_include 'tracker_id', issue.safe_attribute_names
471 assert_include 'tracker_id', issue.safe_attribute_names
472 assert_include 'status_id', issue.safe_attribute_names
472 assert_include 'status_id', issue.safe_attribute_names
473 assert_include 'subject', issue.safe_attribute_names
473 assert_include 'subject', issue.safe_attribute_names
474 assert_include 'description', issue.safe_attribute_names
474 assert_include 'description', issue.safe_attribute_names
475 assert_include 'custom_field_values', issue.safe_attribute_names
475 assert_include 'custom_field_values', issue.safe_attribute_names
476 assert_include 'custom_fields', issue.safe_attribute_names
476 assert_include 'custom_fields', issue.safe_attribute_names
477 assert_include 'lock_version', issue.safe_attribute_names
477 assert_include 'lock_version', issue.safe_attribute_names
478
478
479 tracker.core_fields.each do |field|
479 tracker.core_fields.each do |field|
480 assert_include field, issue.safe_attribute_names
480 assert_include field, issue.safe_attribute_names
481 end
481 end
482
482
483 tracker.disabled_core_fields.each do |field|
483 tracker.disabled_core_fields.each do |field|
484 assert_not_include field, issue.safe_attribute_names
484 assert_not_include field, issue.safe_attribute_names
485 end
485 end
486 end
486 end
487
487
488 def test_safe_attributes_should_ignore_disabled_fields
488 def test_safe_attributes_should_ignore_disabled_fields
489 tracker = Tracker.find(1)
489 tracker = Tracker.find(1)
490 tracker.core_fields = %w(assigned_to_id due_date)
490 tracker.core_fields = %w(assigned_to_id due_date)
491 tracker.save!
491 tracker.save!
492
492
493 issue = Issue.new(:tracker => tracker)
493 issue = Issue.new(:tracker => tracker)
494 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
494 issue.safe_attributes = {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}
495 assert_nil issue.start_date
495 assert_nil issue.start_date
496 assert_equal Date.parse('2012-07-14'), issue.due_date
496 assert_equal Date.parse('2012-07-14'), issue.due_date
497 end
497 end
498
498
499 def test_safe_attributes_should_accept_target_tracker_enabled_fields
499 def test_safe_attributes_should_accept_target_tracker_enabled_fields
500 source = Tracker.find(1)
500 source = Tracker.find(1)
501 source.core_fields = []
501 source.core_fields = []
502 source.save!
502 source.save!
503 target = Tracker.find(2)
503 target = Tracker.find(2)
504 target.core_fields = %w(assigned_to_id due_date)
504 target.core_fields = %w(assigned_to_id due_date)
505 target.save!
505 target.save!
506
506
507 issue = Issue.new(:tracker => source)
507 issue = Issue.new(:tracker => source)
508 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
508 issue.safe_attributes = {'tracker_id' => 2, 'due_date' => '2012-07-14'}
509 assert_equal target, issue.tracker
509 assert_equal target, issue.tracker
510 assert_equal Date.parse('2012-07-14'), issue.due_date
510 assert_equal Date.parse('2012-07-14'), issue.due_date
511 end
511 end
512
512
513 def test_safe_attributes_should_not_include_readonly_fields
513 def test_safe_attributes_should_not_include_readonly_fields
514 WorkflowPermission.delete_all
514 WorkflowPermission.delete_all
515 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
515 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
516 :role_id => 1, :field_name => 'due_date',
516 :role_id => 1, :field_name => 'due_date',
517 :rule => 'readonly')
517 :rule => 'readonly')
518 user = User.find(2)
518 user = User.find(2)
519
519
520 issue = Issue.new(:project_id => 1, :tracker_id => 1)
520 issue = Issue.new(:project_id => 1, :tracker_id => 1)
521 assert_equal %w(due_date), issue.read_only_attribute_names(user)
521 assert_equal %w(due_date), issue.read_only_attribute_names(user)
522 assert_not_include 'due_date', issue.safe_attribute_names(user)
522 assert_not_include 'due_date', issue.safe_attribute_names(user)
523
523
524 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
524 issue.send :safe_attributes=, {'start_date' => '2012-07-14', 'due_date' => '2012-07-14'}, user
525 assert_equal Date.parse('2012-07-14'), issue.start_date
525 assert_equal Date.parse('2012-07-14'), issue.start_date
526 assert_nil issue.due_date
526 assert_nil issue.due_date
527 end
527 end
528
528
529 def test_safe_attributes_should_not_include_readonly_custom_fields
529 def test_safe_attributes_should_not_include_readonly_custom_fields
530 cf1 = IssueCustomField.create!(:name => 'Writable field',
530 cf1 = IssueCustomField.create!(:name => 'Writable field',
531 :field_format => 'string',
531 :field_format => 'string',
532 :is_for_all => true, :tracker_ids => [1])
532 :is_for_all => true, :tracker_ids => [1])
533 cf2 = IssueCustomField.create!(:name => 'Readonly field',
533 cf2 = IssueCustomField.create!(:name => 'Readonly field',
534 :field_format => 'string',
534 :field_format => 'string',
535 :is_for_all => true, :tracker_ids => [1])
535 :is_for_all => true, :tracker_ids => [1])
536 WorkflowPermission.delete_all
536 WorkflowPermission.delete_all
537 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
537 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
538 :role_id => 1, :field_name => cf2.id.to_s,
538 :role_id => 1, :field_name => cf2.id.to_s,
539 :rule => 'readonly')
539 :rule => 'readonly')
540 user = User.find(2)
540 user = User.find(2)
541 issue = Issue.new(:project_id => 1, :tracker_id => 1)
541 issue = Issue.new(:project_id => 1, :tracker_id => 1)
542 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
542 assert_equal [cf2.id.to_s], issue.read_only_attribute_names(user)
543 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
543 assert_not_include cf2.id.to_s, issue.safe_attribute_names(user)
544
544
545 issue.send :safe_attributes=, {'custom_field_values' => {
545 issue.send :safe_attributes=, {'custom_field_values' => {
546 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
546 cf1.id.to_s => 'value1', cf2.id.to_s => 'value2'
547 }}, user
547 }}, user
548 assert_equal 'value1', issue.custom_field_value(cf1)
548 assert_equal 'value1', issue.custom_field_value(cf1)
549 assert_nil issue.custom_field_value(cf2)
549 assert_nil issue.custom_field_value(cf2)
550
550
551 issue.send :safe_attributes=, {'custom_fields' => [
551 issue.send :safe_attributes=, {'custom_fields' => [
552 {'id' => cf1.id.to_s, 'value' => 'valuea'},
552 {'id' => cf1.id.to_s, 'value' => 'valuea'},
553 {'id' => cf2.id.to_s, 'value' => 'valueb'}
553 {'id' => cf2.id.to_s, 'value' => 'valueb'}
554 ]}, user
554 ]}, user
555 assert_equal 'valuea', issue.custom_field_value(cf1)
555 assert_equal 'valuea', issue.custom_field_value(cf1)
556 assert_nil issue.custom_field_value(cf2)
556 assert_nil issue.custom_field_value(cf2)
557 end
557 end
558
558
559 def test_editable_custom_field_values_should_return_non_readonly_custom_values
559 def test_editable_custom_field_values_should_return_non_readonly_custom_values
560 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
560 cf1 = IssueCustomField.create!(:name => 'Writable field', :field_format => 'string',
561 :is_for_all => true, :tracker_ids => [1, 2])
561 :is_for_all => true, :tracker_ids => [1, 2])
562 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
562 cf2 = IssueCustomField.create!(:name => 'Readonly field', :field_format => 'string',
563 :is_for_all => true, :tracker_ids => [1, 2])
563 :is_for_all => true, :tracker_ids => [1, 2])
564 WorkflowPermission.delete_all
564 WorkflowPermission.delete_all
565 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
565 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1, :role_id => 1,
566 :field_name => cf2.id.to_s, :rule => 'readonly')
566 :field_name => cf2.id.to_s, :rule => 'readonly')
567 user = User.find(2)
567 user = User.find(2)
568
568
569 issue = Issue.new(:project_id => 1, :tracker_id => 1)
569 issue = Issue.new(:project_id => 1, :tracker_id => 1)
570 values = issue.editable_custom_field_values(user)
570 values = issue.editable_custom_field_values(user)
571 assert values.detect {|value| value.custom_field == cf1}
571 assert values.detect {|value| value.custom_field == cf1}
572 assert_nil values.detect {|value| value.custom_field == cf2}
572 assert_nil values.detect {|value| value.custom_field == cf2}
573
573
574 issue.tracker_id = 2
574 issue.tracker_id = 2
575 values = issue.editable_custom_field_values(user)
575 values = issue.editable_custom_field_values(user)
576 assert values.detect {|value| value.custom_field == cf1}
576 assert values.detect {|value| value.custom_field == cf1}
577 assert values.detect {|value| value.custom_field == cf2}
577 assert values.detect {|value| value.custom_field == cf2}
578 end
578 end
579
579
580 def test_safe_attributes_should_accept_target_tracker_writable_fields
580 def test_safe_attributes_should_accept_target_tracker_writable_fields
581 WorkflowPermission.delete_all
581 WorkflowPermission.delete_all
582 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
582 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
583 :role_id => 1, :field_name => 'due_date',
583 :role_id => 1, :field_name => 'due_date',
584 :rule => 'readonly')
584 :rule => 'readonly')
585 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
585 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
586 :role_id => 1, :field_name => 'start_date',
586 :role_id => 1, :field_name => 'start_date',
587 :rule => 'readonly')
587 :rule => 'readonly')
588 user = User.find(2)
588 user = User.find(2)
589
589
590 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
590 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
591
591
592 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
592 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
593 'due_date' => '2012-07-14'}, user
593 'due_date' => '2012-07-14'}, user
594 assert_equal Date.parse('2012-07-12'), issue.start_date
594 assert_equal Date.parse('2012-07-12'), issue.start_date
595 assert_nil issue.due_date
595 assert_nil issue.due_date
596
596
597 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
597 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
598 'due_date' => '2012-07-16',
598 'due_date' => '2012-07-16',
599 'tracker_id' => 2}, user
599 'tracker_id' => 2}, user
600 assert_equal Date.parse('2012-07-12'), issue.start_date
600 assert_equal Date.parse('2012-07-12'), issue.start_date
601 assert_equal Date.parse('2012-07-16'), issue.due_date
601 assert_equal Date.parse('2012-07-16'), issue.due_date
602 end
602 end
603
603
604 def test_safe_attributes_should_accept_target_status_writable_fields
604 def test_safe_attributes_should_accept_target_status_writable_fields
605 WorkflowPermission.delete_all
605 WorkflowPermission.delete_all
606 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
606 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
607 :role_id => 1, :field_name => 'due_date',
607 :role_id => 1, :field_name => 'due_date',
608 :rule => 'readonly')
608 :rule => 'readonly')
609 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
609 WorkflowPermission.create!(:old_status_id => 2, :tracker_id => 1,
610 :role_id => 1, :field_name => 'start_date',
610 :role_id => 1, :field_name => 'start_date',
611 :rule => 'readonly')
611 :rule => 'readonly')
612 user = User.find(2)
612 user = User.find(2)
613
613
614 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
614 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
615
615
616 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
616 issue.send :safe_attributes=, {'start_date' => '2012-07-12',
617 'due_date' => '2012-07-14'},
617 'due_date' => '2012-07-14'},
618 user
618 user
619 assert_equal Date.parse('2012-07-12'), issue.start_date
619 assert_equal Date.parse('2012-07-12'), issue.start_date
620 assert_nil issue.due_date
620 assert_nil issue.due_date
621
621
622 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
622 issue.send :safe_attributes=, {'start_date' => '2012-07-15',
623 'due_date' => '2012-07-16',
623 'due_date' => '2012-07-16',
624 'status_id' => 2},
624 'status_id' => 2},
625 user
625 user
626 assert_equal Date.parse('2012-07-12'), issue.start_date
626 assert_equal Date.parse('2012-07-12'), issue.start_date
627 assert_equal Date.parse('2012-07-16'), issue.due_date
627 assert_equal Date.parse('2012-07-16'), issue.due_date
628 end
628 end
629
629
630 def test_required_attributes_should_be_validated
630 def test_required_attributes_should_be_validated
631 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
631 cf = IssueCustomField.create!(:name => 'Foo', :field_format => 'string',
632 :is_for_all => true, :tracker_ids => [1, 2])
632 :is_for_all => true, :tracker_ids => [1, 2])
633
633
634 WorkflowPermission.delete_all
634 WorkflowPermission.delete_all
635 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
635 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
636 :role_id => 1, :field_name => 'due_date',
636 :role_id => 1, :field_name => 'due_date',
637 :rule => 'required')
637 :rule => 'required')
638 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
638 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
639 :role_id => 1, :field_name => 'category_id',
639 :role_id => 1, :field_name => 'category_id',
640 :rule => 'required')
640 :rule => 'required')
641 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
641 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
642 :role_id => 1, :field_name => cf.id.to_s,
642 :role_id => 1, :field_name => cf.id.to_s,
643 :rule => 'required')
643 :rule => 'required')
644
644
645 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
645 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
646 :role_id => 1, :field_name => 'start_date',
646 :role_id => 1, :field_name => 'start_date',
647 :rule => 'required')
647 :rule => 'required')
648 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
648 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 2,
649 :role_id => 1, :field_name => cf.id.to_s,
649 :role_id => 1, :field_name => cf.id.to_s,
650 :rule => 'required')
650 :rule => 'required')
651 user = User.find(2)
651 user = User.find(2)
652
652
653 issue = Issue.new(:project_id => 1, :tracker_id => 1,
653 issue = Issue.new(:project_id => 1, :tracker_id => 1,
654 :status_id => 1, :subject => 'Required fields',
654 :status_id => 1, :subject => 'Required fields',
655 :author => user)
655 :author => user)
656 assert_equal [cf.id.to_s, "category_id", "due_date"],
656 assert_equal [cf.id.to_s, "category_id", "due_date"],
657 issue.required_attribute_names(user).sort
657 issue.required_attribute_names(user).sort
658 assert !issue.save, "Issue was saved"
658 assert !issue.save, "Issue was saved"
659 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
659 assert_equal ["Category can't be blank", "Due date can't be blank", "Foo can't be blank"],
660 issue.errors.full_messages.sort
660 issue.errors.full_messages.sort
661
661
662 issue.tracker_id = 2
662 issue.tracker_id = 2
663 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
663 assert_equal [cf.id.to_s, "start_date"], issue.required_attribute_names(user).sort
664 assert !issue.save, "Issue was saved"
664 assert !issue.save, "Issue was saved"
665 assert_equal ["Foo can't be blank", "Start date can't be blank"],
665 assert_equal ["Foo can't be blank", "Start date can't be blank"],
666 issue.errors.full_messages.sort
666 issue.errors.full_messages.sort
667
667
668 issue.start_date = Date.today
668 issue.start_date = Date.today
669 issue.custom_field_values = {cf.id.to_s => 'bar'}
669 issue.custom_field_values = {cf.id.to_s => 'bar'}
670 assert issue.save
670 assert issue.save
671 end
671 end
672
672
673 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
673 def test_required_attribute_names_for_multiple_roles_should_intersect_rules
674 WorkflowPermission.delete_all
674 WorkflowPermission.delete_all
675 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
675 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
676 :role_id => 1, :field_name => 'due_date',
676 :role_id => 1, :field_name => 'due_date',
677 :rule => 'required')
677 :rule => 'required')
678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
678 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
679 :role_id => 1, :field_name => 'start_date',
679 :role_id => 1, :field_name => 'start_date',
680 :rule => 'required')
680 :rule => 'required')
681 user = User.find(2)
681 user = User.find(2)
682 member = Member.find(1)
682 member = Member.find(1)
683 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
683 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
684
684
685 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
685 assert_equal %w(due_date start_date), issue.required_attribute_names(user).sort
686
686
687 member.role_ids = [1, 2]
687 member.role_ids = [1, 2]
688 member.save!
688 member.save!
689 assert_equal [], issue.required_attribute_names(user.reload)
689 assert_equal [], issue.required_attribute_names(user.reload)
690
690
691 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
691 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
692 :role_id => 2, :field_name => 'due_date',
692 :role_id => 2, :field_name => 'due_date',
693 :rule => 'required')
693 :rule => 'required')
694 assert_equal %w(due_date), issue.required_attribute_names(user)
694 assert_equal %w(due_date), issue.required_attribute_names(user)
695
695
696 member.role_ids = [1, 2, 3]
696 member.role_ids = [1, 2, 3]
697 member.save!
697 member.save!
698 assert_equal [], issue.required_attribute_names(user.reload)
698 assert_equal [], issue.required_attribute_names(user.reload)
699
699
700 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
700 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
701 :role_id => 2, :field_name => 'due_date',
701 :role_id => 2, :field_name => 'due_date',
702 :rule => 'readonly')
702 :rule => 'readonly')
703 # required + readonly => required
703 # required + readonly => required
704 assert_equal %w(due_date), issue.required_attribute_names(user)
704 assert_equal %w(due_date), issue.required_attribute_names(user)
705 end
705 end
706
706
707 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
707 def test_read_only_attribute_names_for_multiple_roles_should_intersect_rules
708 WorkflowPermission.delete_all
708 WorkflowPermission.delete_all
709 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
709 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
710 :role_id => 1, :field_name => 'due_date',
710 :role_id => 1, :field_name => 'due_date',
711 :rule => 'readonly')
711 :rule => 'readonly')
712 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
712 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
713 :role_id => 1, :field_name => 'start_date',
713 :role_id => 1, :field_name => 'start_date',
714 :rule => 'readonly')
714 :rule => 'readonly')
715 user = User.find(2)
715 user = User.find(2)
716 member = Member.find(1)
716 member = Member.find(1)
717 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
717 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1)
718
718
719 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
719 assert_equal %w(due_date start_date), issue.read_only_attribute_names(user).sort
720
720
721 member.role_ids = [1, 2]
721 member.role_ids = [1, 2]
722 member.save!
722 member.save!
723 assert_equal [], issue.read_only_attribute_names(user.reload)
723 assert_equal [], issue.read_only_attribute_names(user.reload)
724
724
725 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
725 WorkflowPermission.create!(:old_status_id => 1, :tracker_id => 1,
726 :role_id => 2, :field_name => 'due_date',
726 :role_id => 2, :field_name => 'due_date',
727 :rule => 'readonly')
727 :rule => 'readonly')
728 assert_equal %w(due_date), issue.read_only_attribute_names(user)
728 assert_equal %w(due_date), issue.read_only_attribute_names(user)
729 end
729 end
730
730
731 def test_copy
731 def test_copy
732 issue = Issue.new.copy_from(1)
732 issue = Issue.new.copy_from(1)
733 assert issue.copy?
733 assert issue.copy?
734 assert issue.save
734 assert issue.save
735 issue.reload
735 issue.reload
736 orig = Issue.find(1)
736 orig = Issue.find(1)
737 assert_equal orig.subject, issue.subject
737 assert_equal orig.subject, issue.subject
738 assert_equal orig.tracker, issue.tracker
738 assert_equal orig.tracker, issue.tracker
739 assert_equal "125", issue.custom_value_for(2).value
739 assert_equal "125", issue.custom_value_for(2).value
740 end
740 end
741
741
742 def test_copy_should_copy_status
742 def test_copy_should_copy_status
743 orig = Issue.find(8)
743 orig = Issue.find(8)
744 assert orig.status != IssueStatus.default
744 assert orig.status != IssueStatus.default
745
745
746 issue = Issue.new.copy_from(orig)
746 issue = Issue.new.copy_from(orig)
747 assert issue.save
747 assert issue.save
748 issue.reload
748 issue.reload
749 assert_equal orig.status, issue.status
749 assert_equal orig.status, issue.status
750 end
750 end
751
751
752 def test_copy_should_add_relation_with_copied_issue
752 def test_copy_should_add_relation_with_copied_issue
753 copied = Issue.find(1)
753 copied = Issue.find(1)
754 issue = Issue.new.copy_from(copied)
754 issue = Issue.new.copy_from(copied)
755 assert issue.save
755 assert issue.save
756 issue.reload
756 issue.reload
757
757
758 assert_equal 1, issue.relations.size
758 assert_equal 1, issue.relations.size
759 relation = issue.relations.first
759 relation = issue.relations.first
760 assert_equal 'copied_to', relation.relation_type
760 assert_equal 'copied_to', relation.relation_type
761 assert_equal copied, relation.issue_from
761 assert_equal copied, relation.issue_from
762 assert_equal issue, relation.issue_to
762 assert_equal issue, relation.issue_to
763 end
763 end
764
764
765 def test_copy_should_copy_subtasks
765 def test_copy_should_copy_subtasks
766 issue = Issue.generate_with_descendants!
766 issue = Issue.generate_with_descendants!
767
767
768 copy = issue.reload.copy
768 copy = issue.reload.copy
769 copy.author = User.find(7)
769 copy.author = User.find(7)
770 assert_difference 'Issue.count', 1+issue.descendants.count do
770 assert_difference 'Issue.count', 1+issue.descendants.count do
771 assert copy.save
771 assert copy.save
772 end
772 end
773 copy.reload
773 copy.reload
774 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
774 assert_equal %w(Child1 Child2), copy.children.map(&:subject).sort
775 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
775 child_copy = copy.children.detect {|c| c.subject == 'Child1'}
776 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
776 assert_equal %w(Child11), child_copy.children.map(&:subject).sort
777 assert_equal copy.author, child_copy.author
777 assert_equal copy.author, child_copy.author
778 end
778 end
779
779
780 def test_copy_should_copy_subtasks_to_target_project
780 def test_copy_should_copy_subtasks_to_target_project
781 issue = Issue.generate_with_descendants!
781 issue = Issue.generate_with_descendants!
782
782
783 copy = issue.copy(:project_id => 3)
783 copy = issue.copy(:project_id => 3)
784 assert_difference 'Issue.count', 1+issue.descendants.count do
784 assert_difference 'Issue.count', 1+issue.descendants.count do
785 assert copy.save
785 assert copy.save
786 end
786 end
787 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
787 assert_equal [3], copy.reload.descendants.map(&:project_id).uniq
788 end
788 end
789
789
790 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
790 def test_copy_should_not_copy_subtasks_twice_when_saving_twice
791 issue = Issue.generate_with_descendants!
791 issue = Issue.generate_with_descendants!
792
792
793 copy = issue.reload.copy
793 copy = issue.reload.copy
794 assert_difference 'Issue.count', 1+issue.descendants.count do
794 assert_difference 'Issue.count', 1+issue.descendants.count do
795 assert copy.save
795 assert copy.save
796 assert copy.save
796 assert copy.save
797 end
797 end
798 end
798 end
799
799
800 def test_should_not_call_after_project_change_on_creation
800 def test_should_not_call_after_project_change_on_creation
801 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
801 issue = Issue.new(:project_id => 1, :tracker_id => 1, :status_id => 1,
802 :subject => 'Test', :author_id => 1)
802 :subject => 'Test', :author_id => 1)
803 issue.expects(:after_project_change).never
803 issue.expects(:after_project_change).never
804 issue.save!
804 issue.save!
805 end
805 end
806
806
807 def test_should_not_call_after_project_change_on_update
807 def test_should_not_call_after_project_change_on_update
808 issue = Issue.find(1)
808 issue = Issue.find(1)
809 issue.project = Project.find(1)
809 issue.project = Project.find(1)
810 issue.subject = 'No project change'
810 issue.subject = 'No project change'
811 issue.expects(:after_project_change).never
811 issue.expects(:after_project_change).never
812 issue.save!
812 issue.save!
813 end
813 end
814
814
815 def test_should_call_after_project_change_on_project_change
815 def test_should_call_after_project_change_on_project_change
816 issue = Issue.find(1)
816 issue = Issue.find(1)
817 issue.project = Project.find(2)
817 issue.project = Project.find(2)
818 issue.expects(:after_project_change).once
818 issue.expects(:after_project_change).once
819 issue.save!
819 issue.save!
820 end
820 end
821
821
822 def test_adding_journal_should_update_timestamp
822 def test_adding_journal_should_update_timestamp
823 issue = Issue.find(1)
823 issue = Issue.find(1)
824 updated_on_was = issue.updated_on
824 updated_on_was = issue.updated_on
825
825
826 issue.init_journal(User.first, "Adding notes")
826 issue.init_journal(User.first, "Adding notes")
827 assert_difference 'Journal.count' do
827 assert_difference 'Journal.count' do
828 assert issue.save
828 assert issue.save
829 end
829 end
830 issue.reload
830 issue.reload
831
831
832 assert_not_equal updated_on_was, issue.updated_on
832 assert_not_equal updated_on_was, issue.updated_on
833 end
833 end
834
834
835 def test_should_close_duplicates
835 def test_should_close_duplicates
836 # Create 3 issues
836 # Create 3 issues
837 issue1 = Issue.generate!
837 issue1 = Issue.generate!
838 issue2 = Issue.generate!
838 issue2 = Issue.generate!
839 issue3 = Issue.generate!
839 issue3 = Issue.generate!
840
840
841 # 2 is a dupe of 1
841 # 2 is a dupe of 1
842 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
842 IssueRelation.create!(:issue_from => issue2, :issue_to => issue1,
843 :relation_type => IssueRelation::TYPE_DUPLICATES)
843 :relation_type => IssueRelation::TYPE_DUPLICATES)
844 # And 3 is a dupe of 2
844 # And 3 is a dupe of 2
845 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
845 IssueRelation.create!(:issue_from => issue3, :issue_to => issue2,
846 :relation_type => IssueRelation::TYPE_DUPLICATES)
846 :relation_type => IssueRelation::TYPE_DUPLICATES)
847 # And 3 is a dupe of 1 (circular duplicates)
847 # And 3 is a dupe of 1 (circular duplicates)
848 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
848 IssueRelation.create!(:issue_from => issue3, :issue_to => issue1,
849 :relation_type => IssueRelation::TYPE_DUPLICATES)
849 :relation_type => IssueRelation::TYPE_DUPLICATES)
850
850
851 assert issue1.reload.duplicates.include?(issue2)
851 assert issue1.reload.duplicates.include?(issue2)
852
852
853 # Closing issue 1
853 # Closing issue 1
854 issue1.init_journal(User.find(:first), "Closing issue1")
854 issue1.init_journal(User.find(:first), "Closing issue1")
855 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
855 issue1.status = IssueStatus.find :first, :conditions => {:is_closed => true}
856 assert issue1.save
856 assert issue1.save
857 # 2 and 3 should be also closed
857 # 2 and 3 should be also closed
858 assert issue2.reload.closed?
858 assert issue2.reload.closed?
859 assert issue3.reload.closed?
859 assert issue3.reload.closed?
860 end
860 end
861
861
862 def test_should_not_close_duplicated_issue
862 def test_should_not_close_duplicated_issue
863 issue1 = Issue.generate!
863 issue1 = Issue.generate!
864 issue2 = Issue.generate!
864 issue2 = Issue.generate!
865
865
866 # 2 is a dupe of 1
866 # 2 is a dupe of 1
867 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
867 IssueRelation.create(:issue_from => issue2, :issue_to => issue1,
868 :relation_type => IssueRelation::TYPE_DUPLICATES)
868 :relation_type => IssueRelation::TYPE_DUPLICATES)
869 # 2 is a dup of 1 but 1 is not a duplicate of 2
869 # 2 is a dup of 1 but 1 is not a duplicate of 2
870 assert !issue2.reload.duplicates.include?(issue1)
870 assert !issue2.reload.duplicates.include?(issue1)
871
871
872 # Closing issue 2
872 # Closing issue 2
873 issue2.init_journal(User.find(:first), "Closing issue2")
873 issue2.init_journal(User.find(:first), "Closing issue2")
874 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
874 issue2.status = IssueStatus.find :first, :conditions => {:is_closed => true}
875 assert issue2.save
875 assert issue2.save
876 # 1 should not be also closed
876 # 1 should not be also closed
877 assert !issue1.reload.closed?
877 assert !issue1.reload.closed?
878 end
878 end
879
879
880 def test_assignable_versions
880 def test_assignable_versions
881 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 1, :subject => 'New issue')
881 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
882 :status_id => 1, :fixed_version_id => 1,
883 :subject => 'New issue')
882 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
884 assert_equal ['open'], issue.assignable_versions.collect(&:status).uniq
883 end
885 end
884
886
885 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
887 def test_should_not_be_able_to_assign_a_new_issue_to_a_closed_version
886 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
888 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
887 :status_id => 1, :fixed_version_id => 1,
889 :status_id => 1, :fixed_version_id => 1,
888 :subject => 'New issue')
890 :subject => 'New issue')
889 assert !issue.save
891 assert !issue.save
890 assert_not_nil issue.errors[:fixed_version_id]
892 assert_not_nil issue.errors[:fixed_version_id]
891 end
893 end
892
894
893 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
895 def test_should_not_be_able_to_assign_a_new_issue_to_a_locked_version
894 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
896 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1, :status_id => 1, :fixed_version_id => 2, :subject => 'New issue')
895 assert !issue.save
897 assert !issue.save
896 assert_not_nil issue.errors[:fixed_version_id]
898 assert_not_nil issue.errors[:fixed_version_id]
897 end
899 end
898
900
899 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
901 def test_should_be_able_to_assign_a_new_issue_to_an_open_version
900 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
902 issue = Issue.new(:project_id => 1, :tracker_id => 1, :author_id => 1,
901 :status_id => 1, :fixed_version_id => 3,
903 :status_id => 1, :fixed_version_id => 3,
902 :subject => 'New issue')
904 :subject => 'New issue')
903 assert issue.save
905 assert issue.save
904 end
906 end
905
907
906 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
908 def test_should_be_able_to_update_an_issue_assigned_to_a_closed_version
907 issue = Issue.find(11)
909 issue = Issue.find(11)
908 assert_equal 'closed', issue.fixed_version.status
910 assert_equal 'closed', issue.fixed_version.status
909 issue.subject = 'Subject changed'
911 issue.subject = 'Subject changed'
910 assert issue.save
912 assert issue.save
911 end
913 end
912
914
913 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
915 def test_should_not_be_able_to_reopen_an_issue_assigned_to_a_closed_version
914 issue = Issue.find(11)
916 issue = Issue.find(11)
915 issue.status_id = 1
917 issue.status_id = 1
916 assert !issue.save
918 assert !issue.save
917 assert_not_nil issue.errors[:base]
919 assert_not_nil issue.errors[:base]
918 end
920 end
919
921
920 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
922 def test_should_be_able_to_reopen_and_reassign_an_issue_assigned_to_a_closed_version
921 issue = Issue.find(11)
923 issue = Issue.find(11)
922 issue.status_id = 1
924 issue.status_id = 1
923 issue.fixed_version_id = 3
925 issue.fixed_version_id = 3
924 assert issue.save
926 assert issue.save
925 end
927 end
926
928
927 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
929 def test_should_be_able_to_reopen_an_issue_assigned_to_a_locked_version
928 issue = Issue.find(12)
930 issue = Issue.find(12)
929 assert_equal 'locked', issue.fixed_version.status
931 assert_equal 'locked', issue.fixed_version.status
930 issue.status_id = 1
932 issue.status_id = 1
931 assert issue.save
933 assert issue.save
932 end
934 end
933
935
934 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
936 def test_should_not_be_able_to_keep_unshared_version_when_changing_project
935 issue = Issue.find(2)
937 issue = Issue.find(2)
936 assert_equal 2, issue.fixed_version_id
938 assert_equal 2, issue.fixed_version_id
937 issue.project_id = 3
939 issue.project_id = 3
938 assert_nil issue.fixed_version_id
940 assert_nil issue.fixed_version_id
939 issue.fixed_version_id = 2
941 issue.fixed_version_id = 2
940 assert !issue.save
942 assert !issue.save
941 assert_include 'Target version is not included in the list', issue.errors.full_messages
943 assert_include 'Target version is not included in the list', issue.errors.full_messages
942 end
944 end
943
945
944 def test_should_keep_shared_version_when_changing_project
946 def test_should_keep_shared_version_when_changing_project
945 Version.find(2).update_attribute :sharing, 'tree'
947 Version.find(2).update_attribute :sharing, 'tree'
946
948
947 issue = Issue.find(2)
949 issue = Issue.find(2)
948 assert_equal 2, issue.fixed_version_id
950 assert_equal 2, issue.fixed_version_id
949 issue.project_id = 3
951 issue.project_id = 3
950 assert_equal 2, issue.fixed_version_id
952 assert_equal 2, issue.fixed_version_id
951 assert issue.save
953 assert issue.save
952 end
954 end
953
955
954 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
956 def test_allowed_target_projects_on_move_should_include_projects_with_issue_tracking_enabled
955 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
957 assert_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
956 end
958 end
957
959
958 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
960 def test_allowed_target_projects_on_move_should_not_include_projects_with_issue_tracking_disabled
959 Project.find(2).disable_module! :issue_tracking
961 Project.find(2).disable_module! :issue_tracking
960 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
962 assert_not_include Project.find(2), Issue.allowed_target_projects_on_move(User.find(2))
961 end
963 end
962
964
963 def test_move_to_another_project_with_same_category
965 def test_move_to_another_project_with_same_category
964 issue = Issue.find(1)
966 issue = Issue.find(1)
965 issue.project = Project.find(2)
967 issue.project = Project.find(2)
966 assert issue.save
968 assert issue.save
967 issue.reload
969 issue.reload
968 assert_equal 2, issue.project_id
970 assert_equal 2, issue.project_id
969 # Category changes
971 # Category changes
970 assert_equal 4, issue.category_id
972 assert_equal 4, issue.category_id
971 # Make sure time entries were move to the target project
973 # Make sure time entries were move to the target project
972 assert_equal 2, issue.time_entries.first.project_id
974 assert_equal 2, issue.time_entries.first.project_id
973 end
975 end
974
976
975 def test_move_to_another_project_without_same_category
977 def test_move_to_another_project_without_same_category
976 issue = Issue.find(2)
978 issue = Issue.find(2)
977 issue.project = Project.find(2)
979 issue.project = Project.find(2)
978 assert issue.save
980 assert issue.save
979 issue.reload
981 issue.reload
980 assert_equal 2, issue.project_id
982 assert_equal 2, issue.project_id
981 # Category cleared
983 # Category cleared
982 assert_nil issue.category_id
984 assert_nil issue.category_id
983 end
985 end
984
986
985 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
987 def test_move_to_another_project_should_clear_fixed_version_when_not_shared
986 issue = Issue.find(1)
988 issue = Issue.find(1)
987 issue.update_attribute(:fixed_version_id, 1)
989 issue.update_attribute(:fixed_version_id, 1)
988 issue.project = Project.find(2)
990 issue.project = Project.find(2)
989 assert issue.save
991 assert issue.save
990 issue.reload
992 issue.reload
991 assert_equal 2, issue.project_id
993 assert_equal 2, issue.project_id
992 # Cleared fixed_version
994 # Cleared fixed_version
993 assert_equal nil, issue.fixed_version
995 assert_equal nil, issue.fixed_version
994 end
996 end
995
997
996 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
998 def test_move_to_another_project_should_keep_fixed_version_when_shared_with_the_target_project
997 issue = Issue.find(1)
999 issue = Issue.find(1)
998 issue.update_attribute(:fixed_version_id, 4)
1000 issue.update_attribute(:fixed_version_id, 4)
999 issue.project = Project.find(5)
1001 issue.project = Project.find(5)
1000 assert issue.save
1002 assert issue.save
1001 issue.reload
1003 issue.reload
1002 assert_equal 5, issue.project_id
1004 assert_equal 5, issue.project_id
1003 # Keep fixed_version
1005 # Keep fixed_version
1004 assert_equal 4, issue.fixed_version_id
1006 assert_equal 4, issue.fixed_version_id
1005 end
1007 end
1006
1008
1007 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1009 def test_move_to_another_project_should_clear_fixed_version_when_not_shared_with_the_target_project
1008 issue = Issue.find(1)
1010 issue = Issue.find(1)
1009 issue.update_attribute(:fixed_version_id, 1)
1011 issue.update_attribute(:fixed_version_id, 1)
1010 issue.project = Project.find(5)
1012 issue.project = Project.find(5)
1011 assert issue.save
1013 assert issue.save
1012 issue.reload
1014 issue.reload
1013 assert_equal 5, issue.project_id
1015 assert_equal 5, issue.project_id
1014 # Cleared fixed_version
1016 # Cleared fixed_version
1015 assert_equal nil, issue.fixed_version
1017 assert_equal nil, issue.fixed_version
1016 end
1018 end
1017
1019
1018 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1020 def test_move_to_another_project_should_keep_fixed_version_when_shared_systemwide
1019 issue = Issue.find(1)
1021 issue = Issue.find(1)
1020 issue.update_attribute(:fixed_version_id, 7)
1022 issue.update_attribute(:fixed_version_id, 7)
1021 issue.project = Project.find(2)
1023 issue.project = Project.find(2)
1022 assert issue.save
1024 assert issue.save
1023 issue.reload
1025 issue.reload
1024 assert_equal 2, issue.project_id
1026 assert_equal 2, issue.project_id
1025 # Keep fixed_version
1027 # Keep fixed_version
1026 assert_equal 7, issue.fixed_version_id
1028 assert_equal 7, issue.fixed_version_id
1027 end
1029 end
1028
1030
1029 def test_move_to_another_project_should_keep_parent_if_valid
1031 def test_move_to_another_project_should_keep_parent_if_valid
1030 issue = Issue.find(1)
1032 issue = Issue.find(1)
1031 issue.update_attribute(:parent_issue_id, 2)
1033 issue.update_attribute(:parent_issue_id, 2)
1032 issue.project = Project.find(3)
1034 issue.project = Project.find(3)
1033 assert issue.save
1035 assert issue.save
1034 issue.reload
1036 issue.reload
1035 assert_equal 2, issue.parent_id
1037 assert_equal 2, issue.parent_id
1036 end
1038 end
1037
1039
1038 def test_move_to_another_project_should_clear_parent_if_not_valid
1040 def test_move_to_another_project_should_clear_parent_if_not_valid
1039 issue = Issue.find(1)
1041 issue = Issue.find(1)
1040 issue.update_attribute(:parent_issue_id, 2)
1042 issue.update_attribute(:parent_issue_id, 2)
1041 issue.project = Project.find(2)
1043 issue.project = Project.find(2)
1042 assert issue.save
1044 assert issue.save
1043 issue.reload
1045 issue.reload
1044 assert_nil issue.parent_id
1046 assert_nil issue.parent_id
1045 end
1047 end
1046
1048
1047 def test_move_to_another_project_with_disabled_tracker
1049 def test_move_to_another_project_with_disabled_tracker
1048 issue = Issue.find(1)
1050 issue = Issue.find(1)
1049 target = Project.find(2)
1051 target = Project.find(2)
1050 target.tracker_ids = [3]
1052 target.tracker_ids = [3]
1051 target.save
1053 target.save
1052 issue.project = target
1054 issue.project = target
1053 assert issue.save
1055 assert issue.save
1054 issue.reload
1056 issue.reload
1055 assert_equal 2, issue.project_id
1057 assert_equal 2, issue.project_id
1056 assert_equal 3, issue.tracker_id
1058 assert_equal 3, issue.tracker_id
1057 end
1059 end
1058
1060
1059 def test_copy_to_the_same_project
1061 def test_copy_to_the_same_project
1060 issue = Issue.find(1)
1062 issue = Issue.find(1)
1061 copy = issue.copy
1063 copy = issue.copy
1062 assert_difference 'Issue.count' do
1064 assert_difference 'Issue.count' do
1063 copy.save!
1065 copy.save!
1064 end
1066 end
1065 assert_kind_of Issue, copy
1067 assert_kind_of Issue, copy
1066 assert_equal issue.project, copy.project
1068 assert_equal issue.project, copy.project
1067 assert_equal "125", copy.custom_value_for(2).value
1069 assert_equal "125", copy.custom_value_for(2).value
1068 end
1070 end
1069
1071
1070 def test_copy_to_another_project_and_tracker
1072 def test_copy_to_another_project_and_tracker
1071 issue = Issue.find(1)
1073 issue = Issue.find(1)
1072 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1074 copy = issue.copy(:project_id => 3, :tracker_id => 2)
1073 assert_difference 'Issue.count' do
1075 assert_difference 'Issue.count' do
1074 copy.save!
1076 copy.save!
1075 end
1077 end
1076 copy.reload
1078 copy.reload
1077 assert_kind_of Issue, copy
1079 assert_kind_of Issue, copy
1078 assert_equal Project.find(3), copy.project
1080 assert_equal Project.find(3), copy.project
1079 assert_equal Tracker.find(2), copy.tracker
1081 assert_equal Tracker.find(2), copy.tracker
1080 # Custom field #2 is not associated with target tracker
1082 # Custom field #2 is not associated with target tracker
1081 assert_nil copy.custom_value_for(2)
1083 assert_nil copy.custom_value_for(2)
1082 end
1084 end
1083
1085
1084 context "#copy" do
1086 context "#copy" do
1085 setup do
1087 setup do
1086 @issue = Issue.find(1)
1088 @issue = Issue.find(1)
1087 end
1089 end
1088
1090
1089 should "not create a journal" do
1091 should "not create a journal" do
1090 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1092 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1091 copy.save!
1093 copy.save!
1092 assert_equal 0, copy.reload.journals.size
1094 assert_equal 0, copy.reload.journals.size
1093 end
1095 end
1094
1096
1095 should "allow assigned_to changes" do
1097 should "allow assigned_to changes" do
1096 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1098 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :assigned_to_id => 3)
1097 assert_equal 3, copy.assigned_to_id
1099 assert_equal 3, copy.assigned_to_id
1098 end
1100 end
1099
1101
1100 should "allow status changes" do
1102 should "allow status changes" do
1101 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1103 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :status_id => 2)
1102 assert_equal 2, copy.status_id
1104 assert_equal 2, copy.status_id
1103 end
1105 end
1104
1106
1105 should "allow start date changes" do
1107 should "allow start date changes" do
1106 date = Date.today
1108 date = Date.today
1107 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1109 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1108 assert_equal date, copy.start_date
1110 assert_equal date, copy.start_date
1109 end
1111 end
1110
1112
1111 should "allow due date changes" do
1113 should "allow due date changes" do
1112 date = Date.today
1114 date = Date.today
1113 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1115 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :due_date => date)
1114 assert_equal date, copy.due_date
1116 assert_equal date, copy.due_date
1115 end
1117 end
1116
1118
1117 should "set current user as author" do
1119 should "set current user as author" do
1118 User.current = User.find(9)
1120 User.current = User.find(9)
1119 copy = @issue.copy(:project_id => 3, :tracker_id => 2)
1121 copy = @issue.copy(:project_id => 3, :tracker_id => 2)
1120 assert_equal User.current, copy.author
1122 assert_equal User.current, copy.author
1121 end
1123 end
1122
1124
1123 should "create a journal with notes" do
1125 should "create a journal with notes" do
1124 date = Date.today
1126 date = Date.today
1125 notes = "Notes added when copying"
1127 notes = "Notes added when copying"
1126 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1128 copy = @issue.copy(:project_id => 3, :tracker_id => 2, :start_date => date)
1127 copy.init_journal(User.current, notes)
1129 copy.init_journal(User.current, notes)
1128 copy.save!
1130 copy.save!
1129
1131
1130 assert_equal 1, copy.journals.size
1132 assert_equal 1, copy.journals.size
1131 journal = copy.journals.first
1133 journal = copy.journals.first
1132 assert_equal 0, journal.details.size
1134 assert_equal 0, journal.details.size
1133 assert_equal notes, journal.notes
1135 assert_equal notes, journal.notes
1134 end
1136 end
1135 end
1137 end
1136
1138
1137 def test_valid_parent_project
1139 def test_valid_parent_project
1138 issue = Issue.find(1)
1140 issue = Issue.find(1)
1139 issue_in_same_project = Issue.find(2)
1141 issue_in_same_project = Issue.find(2)
1140 issue_in_child_project = Issue.find(5)
1142 issue_in_child_project = Issue.find(5)
1141 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1143 issue_in_grandchild_project = Issue.generate!(:project_id => 6, :tracker_id => 1)
1142 issue_in_other_child_project = Issue.find(6)
1144 issue_in_other_child_project = Issue.find(6)
1143 issue_in_different_tree = Issue.find(4)
1145 issue_in_different_tree = Issue.find(4)
1144
1146
1145 with_settings :cross_project_subtasks => '' do
1147 with_settings :cross_project_subtasks => '' do
1146 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1148 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1147 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1149 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1148 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1150 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1149 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1151 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1150 end
1152 end
1151
1153
1152 with_settings :cross_project_subtasks => 'system' do
1154 with_settings :cross_project_subtasks => 'system' do
1153 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1155 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1154 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1156 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1155 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1157 assert_equal true, issue.valid_parent_project?(issue_in_different_tree)
1156 end
1158 end
1157
1159
1158 with_settings :cross_project_subtasks => 'tree' do
1160 with_settings :cross_project_subtasks => 'tree' do
1159 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1161 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1160 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1162 assert_equal true, issue.valid_parent_project?(issue_in_child_project)
1161 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1163 assert_equal true, issue.valid_parent_project?(issue_in_grandchild_project)
1162 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1164 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1163
1165
1164 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1166 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_same_project)
1165 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1167 assert_equal true, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1166 end
1168 end
1167
1169
1168 with_settings :cross_project_subtasks => 'descendants' do
1170 with_settings :cross_project_subtasks => 'descendants' do
1169 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1171 assert_equal true, issue.valid_parent_project?(issue_in_same_project)
1170 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1172 assert_equal false, issue.valid_parent_project?(issue_in_child_project)
1171 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1173 assert_equal false, issue.valid_parent_project?(issue_in_grandchild_project)
1172 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1174 assert_equal false, issue.valid_parent_project?(issue_in_different_tree)
1173
1175
1174 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1176 assert_equal true, issue_in_child_project.valid_parent_project?(issue)
1175 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1177 assert_equal false, issue_in_child_project.valid_parent_project?(issue_in_other_child_project)
1176 end
1178 end
1177 end
1179 end
1178
1180
1179 def test_recipients_should_include_previous_assignee
1181 def test_recipients_should_include_previous_assignee
1180 user = User.find(3)
1182 user = User.find(3)
1181 user.members.update_all ["mail_notification = ?", false]
1183 user.members.update_all ["mail_notification = ?", false]
1182 user.update_attribute :mail_notification, 'only_assigned'
1184 user.update_attribute :mail_notification, 'only_assigned'
1183
1185
1184 issue = Issue.find(2)
1186 issue = Issue.find(2)
1185 issue.assigned_to = nil
1187 issue.assigned_to = nil
1186 assert_include user.mail, issue.recipients
1188 assert_include user.mail, issue.recipients
1187 issue.save!
1189 issue.save!
1188 assert !issue.recipients.include?(user.mail)
1190 assert !issue.recipients.include?(user.mail)
1189 end
1191 end
1190
1192
1191 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1193 def test_recipients_should_not_include_users_that_cannot_view_the_issue
1192 issue = Issue.find(12)
1194 issue = Issue.find(12)
1193 assert issue.recipients.include?(issue.author.mail)
1195 assert issue.recipients.include?(issue.author.mail)
1194 # copy the issue to a private project
1196 # copy the issue to a private project
1195 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1197 copy = issue.copy(:project_id => 5, :tracker_id => 2)
1196 # author is not a member of project anymore
1198 # author is not a member of project anymore
1197 assert !copy.recipients.include?(copy.author.mail)
1199 assert !copy.recipients.include?(copy.author.mail)
1198 end
1200 end
1199
1201
1200 def test_recipients_should_include_the_assigned_group_members
1202 def test_recipients_should_include_the_assigned_group_members
1201 group_member = User.generate!
1203 group_member = User.generate!
1202 group = Group.generate!
1204 group = Group.generate!
1203 group.users << group_member
1205 group.users << group_member
1204
1206
1205 issue = Issue.find(12)
1207 issue = Issue.find(12)
1206 issue.assigned_to = group
1208 issue.assigned_to = group
1207 assert issue.recipients.include?(group_member.mail)
1209 assert issue.recipients.include?(group_member.mail)
1208 end
1210 end
1209
1211
1210 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1212 def test_watcher_recipients_should_not_include_users_that_cannot_view_the_issue
1211 user = User.find(3)
1213 user = User.find(3)
1212 issue = Issue.find(9)
1214 issue = Issue.find(9)
1213 Watcher.create!(:user => user, :watchable => issue)
1215 Watcher.create!(:user => user, :watchable => issue)
1214 assert issue.watched_by?(user)
1216 assert issue.watched_by?(user)
1215 assert !issue.watcher_recipients.include?(user.mail)
1217 assert !issue.watcher_recipients.include?(user.mail)
1216 end
1218 end
1217
1219
1218 def test_issue_destroy
1220 def test_issue_destroy
1219 Issue.find(1).destroy
1221 Issue.find(1).destroy
1220 assert_nil Issue.find_by_id(1)
1222 assert_nil Issue.find_by_id(1)
1221 assert_nil TimeEntry.find_by_issue_id(1)
1223 assert_nil TimeEntry.find_by_issue_id(1)
1222 end
1224 end
1223
1225
1224 def test_destroying_a_deleted_issue_should_not_raise_an_error
1226 def test_destroying_a_deleted_issue_should_not_raise_an_error
1225 issue = Issue.find(1)
1227 issue = Issue.find(1)
1226 Issue.find(1).destroy
1228 Issue.find(1).destroy
1227
1229
1228 assert_nothing_raised do
1230 assert_nothing_raised do
1229 assert_no_difference 'Issue.count' do
1231 assert_no_difference 'Issue.count' do
1230 issue.destroy
1232 issue.destroy
1231 end
1233 end
1232 assert issue.destroyed?
1234 assert issue.destroyed?
1233 end
1235 end
1234 end
1236 end
1235
1237
1236 def test_destroying_a_stale_issue_should_not_raise_an_error
1238 def test_destroying_a_stale_issue_should_not_raise_an_error
1237 issue = Issue.find(1)
1239 issue = Issue.find(1)
1238 Issue.find(1).update_attribute :subject, "Updated"
1240 Issue.find(1).update_attribute :subject, "Updated"
1239
1241
1240 assert_nothing_raised do
1242 assert_nothing_raised do
1241 assert_difference 'Issue.count', -1 do
1243 assert_difference 'Issue.count', -1 do
1242 issue.destroy
1244 issue.destroy
1243 end
1245 end
1244 assert issue.destroyed?
1246 assert issue.destroyed?
1245 end
1247 end
1246 end
1248 end
1247
1249
1248 def test_blocked
1250 def test_blocked
1249 blocked_issue = Issue.find(9)
1251 blocked_issue = Issue.find(9)
1250 blocking_issue = Issue.find(10)
1252 blocking_issue = Issue.find(10)
1251
1253
1252 assert blocked_issue.blocked?
1254 assert blocked_issue.blocked?
1253 assert !blocking_issue.blocked?
1255 assert !blocking_issue.blocked?
1254 end
1256 end
1255
1257
1256 def test_blocked_issues_dont_allow_closed_statuses
1258 def test_blocked_issues_dont_allow_closed_statuses
1257 blocked_issue = Issue.find(9)
1259 blocked_issue = Issue.find(9)
1258
1260
1259 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1261 allowed_statuses = blocked_issue.new_statuses_allowed_to(users(:users_002))
1260 assert !allowed_statuses.empty?
1262 assert !allowed_statuses.empty?
1261 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1263 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1262 assert closed_statuses.empty?
1264 assert closed_statuses.empty?
1263 end
1265 end
1264
1266
1265 def test_unblocked_issues_allow_closed_statuses
1267 def test_unblocked_issues_allow_closed_statuses
1266 blocking_issue = Issue.find(10)
1268 blocking_issue = Issue.find(10)
1267
1269
1268 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1270 allowed_statuses = blocking_issue.new_statuses_allowed_to(users(:users_002))
1269 assert !allowed_statuses.empty?
1271 assert !allowed_statuses.empty?
1270 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1272 closed_statuses = allowed_statuses.select {|st| st.is_closed?}
1271 assert !closed_statuses.empty?
1273 assert !closed_statuses.empty?
1272 end
1274 end
1273
1275
1274 def test_rescheduling_an_issue_should_reschedule_following_issue
1276 def test_rescheduling_an_issue_should_reschedule_following_issue
1275 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1,
1277 issue1 = Issue.create!(:project_id => 1, :tracker_id => 1,
1276 :author_id => 1, :status_id => 1,
1278 :author_id => 1, :status_id => 1,
1277 :subject => '-',
1279 :subject => '-',
1278 :start_date => Date.today, :due_date => Date.today + 2)
1280 :start_date => Date.today, :due_date => Date.today + 2)
1279 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1,
1281 issue2 = Issue.create!(:project_id => 1, :tracker_id => 1,
1280 :author_id => 1, :status_id => 1,
1282 :author_id => 1, :status_id => 1,
1281 :subject => '-',
1283 :subject => '-',
1282 :start_date => Date.today, :due_date => Date.today + 2)
1284 :start_date => Date.today, :due_date => Date.today + 2)
1283 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1285 IssueRelation.create!(:issue_from => issue1, :issue_to => issue2,
1284 :relation_type => IssueRelation::TYPE_PRECEDES)
1286 :relation_type => IssueRelation::TYPE_PRECEDES)
1285 assert_equal issue1.due_date + 1, issue2.reload.start_date
1287 assert_equal issue1.due_date + 1, issue2.reload.start_date
1286
1288
1287 issue1.due_date = Date.today + 5
1289 issue1.due_date = Date.today + 5
1288 issue1.save!
1290 issue1.save!
1289 assert_equal issue1.due_date + 1, issue2.reload.start_date
1291 assert_equal issue1.due_date + 1, issue2.reload.start_date
1290 end
1292 end
1291
1293
1292 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1294 def test_rescheduling_a_stale_issue_should_not_raise_an_error
1293 stale = Issue.find(1)
1295 stale = Issue.find(1)
1294 issue = Issue.find(1)
1296 issue = Issue.find(1)
1295 issue.subject = "Updated"
1297 issue.subject = "Updated"
1296 issue.save!
1298 issue.save!
1297
1299
1298 date = 10.days.from_now.to_date
1300 date = 10.days.from_now.to_date
1299 assert_nothing_raised do
1301 assert_nothing_raised do
1300 stale.reschedule_after(date)
1302 stale.reschedule_after(date)
1301 end
1303 end
1302 assert_equal date, stale.reload.start_date
1304 assert_equal date, stale.reload.start_date
1303 end
1305 end
1304
1306
1305 def test_overdue
1307 def test_overdue
1306 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1308 assert Issue.new(:due_date => 1.day.ago.to_date).overdue?
1307 assert !Issue.new(:due_date => Date.today).overdue?
1309 assert !Issue.new(:due_date => Date.today).overdue?
1308 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1310 assert !Issue.new(:due_date => 1.day.from_now.to_date).overdue?
1309 assert !Issue.new(:due_date => nil).overdue?
1311 assert !Issue.new(:due_date => nil).overdue?
1310 assert !Issue.new(:due_date => 1.day.ago.to_date,
1312 assert !Issue.new(:due_date => 1.day.ago.to_date,
1311 :status => IssueStatus.find(:first,
1313 :status => IssueStatus.find(:first,
1312 :conditions => {:is_closed => true})
1314 :conditions => {:is_closed => true})
1313 ).overdue?
1315 ).overdue?
1314 end
1316 end
1315
1317
1316 context "#behind_schedule?" do
1318 context "#behind_schedule?" do
1317 should "be false if the issue has no start_date" do
1319 should "be false if the issue has no start_date" do
1318 assert !Issue.new(:start_date => nil,
1320 assert !Issue.new(:start_date => nil,
1319 :due_date => 1.day.from_now.to_date,
1321 :due_date => 1.day.from_now.to_date,
1320 :done_ratio => 0).behind_schedule?
1322 :done_ratio => 0).behind_schedule?
1321 end
1323 end
1322
1324
1323 should "be false if the issue has no end_date" do
1325 should "be false if the issue has no end_date" do
1324 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1326 assert !Issue.new(:start_date => 1.day.from_now.to_date,
1325 :due_date => nil,
1327 :due_date => nil,
1326 :done_ratio => 0).behind_schedule?
1328 :done_ratio => 0).behind_schedule?
1327 end
1329 end
1328
1330
1329 should "be false if the issue has more done than it's calendar time" do
1331 should "be false if the issue has more done than it's calendar time" do
1330 assert !Issue.new(:start_date => 50.days.ago.to_date,
1332 assert !Issue.new(:start_date => 50.days.ago.to_date,
1331 :due_date => 50.days.from_now.to_date,
1333 :due_date => 50.days.from_now.to_date,
1332 :done_ratio => 90).behind_schedule?
1334 :done_ratio => 90).behind_schedule?
1333 end
1335 end
1334
1336
1335 should "be true if the issue hasn't been started at all" do
1337 should "be true if the issue hasn't been started at all" do
1336 assert Issue.new(:start_date => 1.day.ago.to_date,
1338 assert Issue.new(:start_date => 1.day.ago.to_date,
1337 :due_date => 1.day.from_now.to_date,
1339 :due_date => 1.day.from_now.to_date,
1338 :done_ratio => 0).behind_schedule?
1340 :done_ratio => 0).behind_schedule?
1339 end
1341 end
1340
1342
1341 should "be true if the issue has used more calendar time than it's done ratio" do
1343 should "be true if the issue has used more calendar time than it's done ratio" do
1342 assert Issue.new(:start_date => 100.days.ago.to_date,
1344 assert Issue.new(:start_date => 100.days.ago.to_date,
1343 :due_date => Date.today,
1345 :due_date => Date.today,
1344 :done_ratio => 90).behind_schedule?
1346 :done_ratio => 90).behind_schedule?
1345 end
1347 end
1346 end
1348 end
1347
1349
1348 context "#assignable_users" do
1350 context "#assignable_users" do
1349 should "be Users" do
1351 should "be Users" do
1350 assert_kind_of User, Issue.find(1).assignable_users.first
1352 assert_kind_of User, Issue.find(1).assignable_users.first
1351 end
1353 end
1352
1354
1353 should "include the issue author" do
1355 should "include the issue author" do
1354 non_project_member = User.generate!
1356 non_project_member = User.generate!
1355 issue = Issue.generate!(:author => non_project_member)
1357 issue = Issue.generate!(:author => non_project_member)
1356
1358
1357 assert issue.assignable_users.include?(non_project_member)
1359 assert issue.assignable_users.include?(non_project_member)
1358 end
1360 end
1359
1361
1360 should "include the current assignee" do
1362 should "include the current assignee" do
1361 user = User.generate!
1363 user = User.generate!
1362 issue = Issue.generate!(:assigned_to => user)
1364 issue = Issue.generate!(:assigned_to => user)
1363 user.lock!
1365 user.lock!
1364
1366
1365 assert Issue.find(issue.id).assignable_users.include?(user)
1367 assert Issue.find(issue.id).assignable_users.include?(user)
1366 end
1368 end
1367
1369
1368 should "not show the issue author twice" do
1370 should "not show the issue author twice" do
1369 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1371 assignable_user_ids = Issue.find(1).assignable_users.collect(&:id)
1370 assert_equal 2, assignable_user_ids.length
1372 assert_equal 2, assignable_user_ids.length
1371
1373
1372 assignable_user_ids.each do |user_id|
1374 assignable_user_ids.each do |user_id|
1373 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1375 assert_equal 1, assignable_user_ids.select {|i| i == user_id}.length,
1374 "User #{user_id} appears more or less than once"
1376 "User #{user_id} appears more or less than once"
1375 end
1377 end
1376 end
1378 end
1377
1379
1378 context "with issue_group_assignment" do
1380 context "with issue_group_assignment" do
1379 should "include groups" do
1381 should "include groups" do
1380 issue = Issue.new(:project => Project.find(2))
1382 issue = Issue.new(:project => Project.find(2))
1381
1383
1382 with_settings :issue_group_assignment => '1' do
1384 with_settings :issue_group_assignment => '1' do
1383 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1385 assert_equal %w(Group User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1384 assert issue.assignable_users.include?(Group.find(11))
1386 assert issue.assignable_users.include?(Group.find(11))
1385 end
1387 end
1386 end
1388 end
1387 end
1389 end
1388
1390
1389 context "without issue_group_assignment" do
1391 context "without issue_group_assignment" do
1390 should "not include groups" do
1392 should "not include groups" do
1391 issue = Issue.new(:project => Project.find(2))
1393 issue = Issue.new(:project => Project.find(2))
1392
1394
1393 with_settings :issue_group_assignment => '0' do
1395 with_settings :issue_group_assignment => '0' do
1394 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1396 assert_equal %w(User), issue.assignable_users.map {|a| a.class.name}.uniq.sort
1395 assert !issue.assignable_users.include?(Group.find(11))
1397 assert !issue.assignable_users.include?(Group.find(11))
1396 end
1398 end
1397 end
1399 end
1398 end
1400 end
1399 end
1401 end
1400
1402
1401 def test_create_should_send_email_notification
1403 def test_create_should_send_email_notification
1402 ActionMailer::Base.deliveries.clear
1404 ActionMailer::Base.deliveries.clear
1403 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1405 issue = Issue.new(:project_id => 1, :tracker_id => 1,
1404 :author_id => 3, :status_id => 1,
1406 :author_id => 3, :status_id => 1,
1405 :priority => IssuePriority.all.first,
1407 :priority => IssuePriority.all.first,
1406 :subject => 'test_create', :estimated_hours => '1:30')
1408 :subject => 'test_create', :estimated_hours => '1:30')
1407
1409
1408 assert issue.save
1410 assert issue.save
1409 assert_equal 1, ActionMailer::Base.deliveries.size
1411 assert_equal 1, ActionMailer::Base.deliveries.size
1410 end
1412 end
1411
1413
1412 def test_stale_issue_should_not_send_email_notification
1414 def test_stale_issue_should_not_send_email_notification
1413 ActionMailer::Base.deliveries.clear
1415 ActionMailer::Base.deliveries.clear
1414 issue = Issue.find(1)
1416 issue = Issue.find(1)
1415 stale = Issue.find(1)
1417 stale = Issue.find(1)
1416
1418
1417 issue.init_journal(User.find(1))
1419 issue.init_journal(User.find(1))
1418 issue.subject = 'Subjet update'
1420 issue.subject = 'Subjet update'
1419 assert issue.save
1421 assert issue.save
1420 assert_equal 1, ActionMailer::Base.deliveries.size
1422 assert_equal 1, ActionMailer::Base.deliveries.size
1421 ActionMailer::Base.deliveries.clear
1423 ActionMailer::Base.deliveries.clear
1422
1424
1423 stale.init_journal(User.find(1))
1425 stale.init_journal(User.find(1))
1424 stale.subject = 'Another subjet update'
1426 stale.subject = 'Another subjet update'
1425 assert_raise ActiveRecord::StaleObjectError do
1427 assert_raise ActiveRecord::StaleObjectError do
1426 stale.save
1428 stale.save
1427 end
1429 end
1428 assert ActionMailer::Base.deliveries.empty?
1430 assert ActionMailer::Base.deliveries.empty?
1429 end
1431 end
1430
1432
1431 def test_journalized_description
1433 def test_journalized_description
1432 IssueCustomField.delete_all
1434 IssueCustomField.delete_all
1433
1435
1434 i = Issue.first
1436 i = Issue.first
1435 old_description = i.description
1437 old_description = i.description
1436 new_description = "This is the new description"
1438 new_description = "This is the new description"
1437
1439
1438 i.init_journal(User.find(2))
1440 i.init_journal(User.find(2))
1439 i.description = new_description
1441 i.description = new_description
1440 assert_difference 'Journal.count', 1 do
1442 assert_difference 'Journal.count', 1 do
1441 assert_difference 'JournalDetail.count', 1 do
1443 assert_difference 'JournalDetail.count', 1 do
1442 i.save!
1444 i.save!
1443 end
1445 end
1444 end
1446 end
1445
1447
1446 detail = JournalDetail.first(:order => 'id DESC')
1448 detail = JournalDetail.first(:order => 'id DESC')
1447 assert_equal i, detail.journal.journalized
1449 assert_equal i, detail.journal.journalized
1448 assert_equal 'attr', detail.property
1450 assert_equal 'attr', detail.property
1449 assert_equal 'description', detail.prop_key
1451 assert_equal 'description', detail.prop_key
1450 assert_equal old_description, detail.old_value
1452 assert_equal old_description, detail.old_value
1451 assert_equal new_description, detail.value
1453 assert_equal new_description, detail.value
1452 end
1454 end
1453
1455
1454 def test_blank_descriptions_should_not_be_journalized
1456 def test_blank_descriptions_should_not_be_journalized
1455 IssueCustomField.delete_all
1457 IssueCustomField.delete_all
1456 Issue.update_all("description = NULL", "id=1")
1458 Issue.update_all("description = NULL", "id=1")
1457
1459
1458 i = Issue.find(1)
1460 i = Issue.find(1)
1459 i.init_journal(User.find(2))
1461 i.init_journal(User.find(2))
1460 i.subject = "blank description"
1462 i.subject = "blank description"
1461 i.description = "\r\n"
1463 i.description = "\r\n"
1462
1464
1463 assert_difference 'Journal.count', 1 do
1465 assert_difference 'Journal.count', 1 do
1464 assert_difference 'JournalDetail.count', 1 do
1466 assert_difference 'JournalDetail.count', 1 do
1465 i.save!
1467 i.save!
1466 end
1468 end
1467 end
1469 end
1468 end
1470 end
1469
1471
1470 def test_journalized_multi_custom_field
1472 def test_journalized_multi_custom_field
1471 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
1473 field = IssueCustomField.create!(:name => 'filter', :field_format => 'list',
1472 :is_filter => true, :is_for_all => true,
1474 :is_filter => true, :is_for_all => true,
1473 :tracker_ids => [1],
1475 :tracker_ids => [1],
1474 :possible_values => ['value1', 'value2', 'value3'],
1476 :possible_values => ['value1', 'value2', 'value3'],
1475 :multiple => true)
1477 :multiple => true)
1476
1478
1477 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
1479 issue = Issue.create!(:project_id => 1, :tracker_id => 1,
1478 :subject => 'Test', :author_id => 1)
1480 :subject => 'Test', :author_id => 1)
1479
1481
1480 assert_difference 'Journal.count' do
1482 assert_difference 'Journal.count' do
1481 assert_difference 'JournalDetail.count' do
1483 assert_difference 'JournalDetail.count' do
1482 issue.init_journal(User.first)
1484 issue.init_journal(User.first)
1483 issue.custom_field_values = {field.id => ['value1']}
1485 issue.custom_field_values = {field.id => ['value1']}
1484 issue.save!
1486 issue.save!
1485 end
1487 end
1486 assert_difference 'JournalDetail.count' do
1488 assert_difference 'JournalDetail.count' do
1487 issue.init_journal(User.first)
1489 issue.init_journal(User.first)
1488 issue.custom_field_values = {field.id => ['value1', 'value2']}
1490 issue.custom_field_values = {field.id => ['value1', 'value2']}
1489 issue.save!
1491 issue.save!
1490 end
1492 end
1491 assert_difference 'JournalDetail.count', 2 do
1493 assert_difference 'JournalDetail.count', 2 do
1492 issue.init_journal(User.first)
1494 issue.init_journal(User.first)
1493 issue.custom_field_values = {field.id => ['value3', 'value2']}
1495 issue.custom_field_values = {field.id => ['value3', 'value2']}
1494 issue.save!
1496 issue.save!
1495 end
1497 end
1496 assert_difference 'JournalDetail.count', 2 do
1498 assert_difference 'JournalDetail.count', 2 do
1497 issue.init_journal(User.first)
1499 issue.init_journal(User.first)
1498 issue.custom_field_values = {field.id => nil}
1500 issue.custom_field_values = {field.id => nil}
1499 issue.save!
1501 issue.save!
1500 end
1502 end
1501 end
1503 end
1502 end
1504 end
1503
1505
1504 def test_description_eol_should_be_normalized
1506 def test_description_eol_should_be_normalized
1505 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1507 i = Issue.new(:description => "CR \r LF \n CRLF \r\n")
1506 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1508 assert_equal "CR \r\n LF \r\n CRLF \r\n", i.description
1507 end
1509 end
1508
1510
1509 def test_saving_twice_should_not_duplicate_journal_details
1511 def test_saving_twice_should_not_duplicate_journal_details
1510 i = Issue.find(:first)
1512 i = Issue.find(:first)
1511 i.init_journal(User.find(2), 'Some notes')
1513 i.init_journal(User.find(2), 'Some notes')
1512 # initial changes
1514 # initial changes
1513 i.subject = 'New subject'
1515 i.subject = 'New subject'
1514 i.done_ratio = i.done_ratio + 10
1516 i.done_ratio = i.done_ratio + 10
1515 assert_difference 'Journal.count' do
1517 assert_difference 'Journal.count' do
1516 assert i.save
1518 assert i.save
1517 end
1519 end
1518 # 1 more change
1520 # 1 more change
1519 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
1521 i.priority = IssuePriority.find(:first, :conditions => ["id <> ?", i.priority_id])
1520 assert_no_difference 'Journal.count' do
1522 assert_no_difference 'Journal.count' do
1521 assert_difference 'JournalDetail.count', 1 do
1523 assert_difference 'JournalDetail.count', 1 do
1522 i.save
1524 i.save
1523 end
1525 end
1524 end
1526 end
1525 # no more change
1527 # no more change
1526 assert_no_difference 'Journal.count' do
1528 assert_no_difference 'Journal.count' do
1527 assert_no_difference 'JournalDetail.count' do
1529 assert_no_difference 'JournalDetail.count' do
1528 i.save
1530 i.save
1529 end
1531 end
1530 end
1532 end
1531 end
1533 end
1532
1534
1533 def test_all_dependent_issues
1535 def test_all_dependent_issues
1534 IssueRelation.delete_all
1536 IssueRelation.delete_all
1535 assert IssueRelation.create!(:issue_from => Issue.find(1),
1537 assert IssueRelation.create!(:issue_from => Issue.find(1),
1536 :issue_to => Issue.find(2),
1538 :issue_to => Issue.find(2),
1537 :relation_type => IssueRelation::TYPE_PRECEDES)
1539 :relation_type => IssueRelation::TYPE_PRECEDES)
1538 assert IssueRelation.create!(:issue_from => Issue.find(2),
1540 assert IssueRelation.create!(:issue_from => Issue.find(2),
1539 :issue_to => Issue.find(3),
1541 :issue_to => Issue.find(3),
1540 :relation_type => IssueRelation::TYPE_PRECEDES)
1542 :relation_type => IssueRelation::TYPE_PRECEDES)
1541 assert IssueRelation.create!(:issue_from => Issue.find(3),
1543 assert IssueRelation.create!(:issue_from => Issue.find(3),
1542 :issue_to => Issue.find(8),
1544 :issue_to => Issue.find(8),
1543 :relation_type => IssueRelation::TYPE_PRECEDES)
1545 :relation_type => IssueRelation::TYPE_PRECEDES)
1544
1546
1545 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1547 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1546 end
1548 end
1547
1549
1548 def test_all_dependent_issues_with_persistent_circular_dependency
1550 def test_all_dependent_issues_with_persistent_circular_dependency
1549 IssueRelation.delete_all
1551 IssueRelation.delete_all
1550 assert IssueRelation.create!(:issue_from => Issue.find(1),
1552 assert IssueRelation.create!(:issue_from => Issue.find(1),
1551 :issue_to => Issue.find(2),
1553 :issue_to => Issue.find(2),
1552 :relation_type => IssueRelation::TYPE_PRECEDES)
1554 :relation_type => IssueRelation::TYPE_PRECEDES)
1553 assert IssueRelation.create!(:issue_from => Issue.find(2),
1555 assert IssueRelation.create!(:issue_from => Issue.find(2),
1554 :issue_to => Issue.find(3),
1556 :issue_to => Issue.find(3),
1555 :relation_type => IssueRelation::TYPE_PRECEDES)
1557 :relation_type => IssueRelation::TYPE_PRECEDES)
1556
1558
1557 r = IssueRelation.create!(:issue_from => Issue.find(3),
1559 r = IssueRelation.create!(:issue_from => Issue.find(3),
1558 :issue_to => Issue.find(7),
1560 :issue_to => Issue.find(7),
1559 :relation_type => IssueRelation::TYPE_PRECEDES)
1561 :relation_type => IssueRelation::TYPE_PRECEDES)
1560 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1562 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1561
1563
1562 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1564 assert_equal [2, 3], Issue.find(1).all_dependent_issues.collect(&:id).sort
1563 end
1565 end
1564
1566
1565 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1567 def test_all_dependent_issues_with_persistent_multiple_circular_dependencies
1566 IssueRelation.delete_all
1568 IssueRelation.delete_all
1567 assert IssueRelation.create!(:issue_from => Issue.find(1),
1569 assert IssueRelation.create!(:issue_from => Issue.find(1),
1568 :issue_to => Issue.find(2),
1570 :issue_to => Issue.find(2),
1569 :relation_type => IssueRelation::TYPE_RELATES)
1571 :relation_type => IssueRelation::TYPE_RELATES)
1570 assert IssueRelation.create!(:issue_from => Issue.find(2),
1572 assert IssueRelation.create!(:issue_from => Issue.find(2),
1571 :issue_to => Issue.find(3),
1573 :issue_to => Issue.find(3),
1572 :relation_type => IssueRelation::TYPE_RELATES)
1574 :relation_type => IssueRelation::TYPE_RELATES)
1573 assert IssueRelation.create!(:issue_from => Issue.find(3),
1575 assert IssueRelation.create!(:issue_from => Issue.find(3),
1574 :issue_to => Issue.find(8),
1576 :issue_to => Issue.find(8),
1575 :relation_type => IssueRelation::TYPE_RELATES)
1577 :relation_type => IssueRelation::TYPE_RELATES)
1576
1578
1577 r = IssueRelation.create!(:issue_from => Issue.find(8),
1579 r = IssueRelation.create!(:issue_from => Issue.find(8),
1578 :issue_to => Issue.find(7),
1580 :issue_to => Issue.find(7),
1579 :relation_type => IssueRelation::TYPE_RELATES)
1581 :relation_type => IssueRelation::TYPE_RELATES)
1580 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1582 IssueRelation.update_all("issue_to_id = 2", ["id = ?", r.id])
1581
1583
1582 r = IssueRelation.create!(:issue_from => Issue.find(3),
1584 r = IssueRelation.create!(:issue_from => Issue.find(3),
1583 :issue_to => Issue.find(7),
1585 :issue_to => Issue.find(7),
1584 :relation_type => IssueRelation::TYPE_RELATES)
1586 :relation_type => IssueRelation::TYPE_RELATES)
1585 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1587 IssueRelation.update_all("issue_to_id = 1", ["id = ?", r.id])
1586
1588
1587 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1589 assert_equal [2, 3, 8], Issue.find(1).all_dependent_issues.collect(&:id).sort
1588 end
1590 end
1589
1591
1590 context "#done_ratio" do
1592 context "#done_ratio" do
1591 setup do
1593 setup do
1592 @issue = Issue.find(1)
1594 @issue = Issue.find(1)
1593 @issue_status = IssueStatus.find(1)
1595 @issue_status = IssueStatus.find(1)
1594 @issue_status.update_attribute(:default_done_ratio, 50)
1596 @issue_status.update_attribute(:default_done_ratio, 50)
1595 @issue2 = Issue.find(2)
1597 @issue2 = Issue.find(2)
1596 @issue_status2 = IssueStatus.find(2)
1598 @issue_status2 = IssueStatus.find(2)
1597 @issue_status2.update_attribute(:default_done_ratio, 0)
1599 @issue_status2.update_attribute(:default_done_ratio, 0)
1598 end
1600 end
1599
1601
1600 teardown do
1602 teardown do
1601 Setting.issue_done_ratio = 'issue_field'
1603 Setting.issue_done_ratio = 'issue_field'
1602 end
1604 end
1603
1605
1604 context "with Setting.issue_done_ratio using the issue_field" do
1606 context "with Setting.issue_done_ratio using the issue_field" do
1605 setup do
1607 setup do
1606 Setting.issue_done_ratio = 'issue_field'
1608 Setting.issue_done_ratio = 'issue_field'
1607 end
1609 end
1608
1610
1609 should "read the issue's field" do
1611 should "read the issue's field" do
1610 assert_equal 0, @issue.done_ratio
1612 assert_equal 0, @issue.done_ratio
1611 assert_equal 30, @issue2.done_ratio
1613 assert_equal 30, @issue2.done_ratio
1612 end
1614 end
1613 end
1615 end
1614
1616
1615 context "with Setting.issue_done_ratio using the issue_status" do
1617 context "with Setting.issue_done_ratio using the issue_status" do
1616 setup do
1618 setup do
1617 Setting.issue_done_ratio = 'issue_status'
1619 Setting.issue_done_ratio = 'issue_status'
1618 end
1620 end
1619
1621
1620 should "read the Issue Status's default done ratio" do
1622 should "read the Issue Status's default done ratio" do
1621 assert_equal 50, @issue.done_ratio
1623 assert_equal 50, @issue.done_ratio
1622 assert_equal 0, @issue2.done_ratio
1624 assert_equal 0, @issue2.done_ratio
1623 end
1625 end
1624 end
1626 end
1625 end
1627 end
1626
1628
1627 context "#update_done_ratio_from_issue_status" do
1629 context "#update_done_ratio_from_issue_status" do
1628 setup do
1630 setup do
1629 @issue = Issue.find(1)
1631 @issue = Issue.find(1)
1630 @issue_status = IssueStatus.find(1)
1632 @issue_status = IssueStatus.find(1)
1631 @issue_status.update_attribute(:default_done_ratio, 50)
1633 @issue_status.update_attribute(:default_done_ratio, 50)
1632 @issue2 = Issue.find(2)
1634 @issue2 = Issue.find(2)
1633 @issue_status2 = IssueStatus.find(2)
1635 @issue_status2 = IssueStatus.find(2)
1634 @issue_status2.update_attribute(:default_done_ratio, 0)
1636 @issue_status2.update_attribute(:default_done_ratio, 0)
1635 end
1637 end
1636
1638
1637 context "with Setting.issue_done_ratio using the issue_field" do
1639 context "with Setting.issue_done_ratio using the issue_field" do
1638 setup do
1640 setup do
1639 Setting.issue_done_ratio = 'issue_field'
1641 Setting.issue_done_ratio = 'issue_field'
1640 end
1642 end
1641
1643
1642 should "not change the issue" do
1644 should "not change the issue" do
1643 @issue.update_done_ratio_from_issue_status
1645 @issue.update_done_ratio_from_issue_status
1644 @issue2.update_done_ratio_from_issue_status
1646 @issue2.update_done_ratio_from_issue_status
1645
1647
1646 assert_equal 0, @issue.read_attribute(:done_ratio)
1648 assert_equal 0, @issue.read_attribute(:done_ratio)
1647 assert_equal 30, @issue2.read_attribute(:done_ratio)
1649 assert_equal 30, @issue2.read_attribute(:done_ratio)
1648 end
1650 end
1649 end
1651 end
1650
1652
1651 context "with Setting.issue_done_ratio using the issue_status" do
1653 context "with Setting.issue_done_ratio using the issue_status" do
1652 setup do
1654 setup do
1653 Setting.issue_done_ratio = 'issue_status'
1655 Setting.issue_done_ratio = 'issue_status'
1654 end
1656 end
1655
1657
1656 should "change the issue's done ratio" do
1658 should "change the issue's done ratio" do
1657 @issue.update_done_ratio_from_issue_status
1659 @issue.update_done_ratio_from_issue_status
1658 @issue2.update_done_ratio_from_issue_status
1660 @issue2.update_done_ratio_from_issue_status
1659
1661
1660 assert_equal 50, @issue.read_attribute(:done_ratio)
1662 assert_equal 50, @issue.read_attribute(:done_ratio)
1661 assert_equal 0, @issue2.read_attribute(:done_ratio)
1663 assert_equal 0, @issue2.read_attribute(:done_ratio)
1662 end
1664 end
1663 end
1665 end
1664 end
1666 end
1665
1667
1666 test "#by_tracker" do
1668 test "#by_tracker" do
1667 User.current = User.anonymous
1669 User.current = User.anonymous
1668 groups = Issue.by_tracker(Project.find(1))
1670 groups = Issue.by_tracker(Project.find(1))
1669 assert_equal 3, groups.size
1671 assert_equal 3, groups.size
1670 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1672 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1671 end
1673 end
1672
1674
1673 test "#by_version" do
1675 test "#by_version" do
1674 User.current = User.anonymous
1676 User.current = User.anonymous
1675 groups = Issue.by_version(Project.find(1))
1677 groups = Issue.by_version(Project.find(1))
1676 assert_equal 3, groups.size
1678 assert_equal 3, groups.size
1677 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1679 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1678 end
1680 end
1679
1681
1680 test "#by_priority" do
1682 test "#by_priority" do
1681 User.current = User.anonymous
1683 User.current = User.anonymous
1682 groups = Issue.by_priority(Project.find(1))
1684 groups = Issue.by_priority(Project.find(1))
1683 assert_equal 4, groups.size
1685 assert_equal 4, groups.size
1684 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1686 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1685 end
1687 end
1686
1688
1687 test "#by_category" do
1689 test "#by_category" do
1688 User.current = User.anonymous
1690 User.current = User.anonymous
1689 groups = Issue.by_category(Project.find(1))
1691 groups = Issue.by_category(Project.find(1))
1690 assert_equal 2, groups.size
1692 assert_equal 2, groups.size
1691 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1693 assert_equal 3, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1692 end
1694 end
1693
1695
1694 test "#by_assigned_to" do
1696 test "#by_assigned_to" do
1695 User.current = User.anonymous
1697 User.current = User.anonymous
1696 groups = Issue.by_assigned_to(Project.find(1))
1698 groups = Issue.by_assigned_to(Project.find(1))
1697 assert_equal 2, groups.size
1699 assert_equal 2, groups.size
1698 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1700 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1699 end
1701 end
1700
1702
1701 test "#by_author" do
1703 test "#by_author" do
1702 User.current = User.anonymous
1704 User.current = User.anonymous
1703 groups = Issue.by_author(Project.find(1))
1705 groups = Issue.by_author(Project.find(1))
1704 assert_equal 4, groups.size
1706 assert_equal 4, groups.size
1705 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1707 assert_equal 7, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1706 end
1708 end
1707
1709
1708 test "#by_subproject" do
1710 test "#by_subproject" do
1709 User.current = User.anonymous
1711 User.current = User.anonymous
1710 groups = Issue.by_subproject(Project.find(1))
1712 groups = Issue.by_subproject(Project.find(1))
1711 # Private descendant not visible
1713 # Private descendant not visible
1712 assert_equal 1, groups.size
1714 assert_equal 1, groups.size
1713 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1715 assert_equal 2, groups.inject(0) {|sum, group| sum + group['total'].to_i}
1714 end
1716 end
1715
1717
1716 def test_recently_updated_scope
1718 def test_recently_updated_scope
1717 #should return the last updated issue
1719 #should return the last updated issue
1718 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
1720 assert_equal Issue.reorder("updated_on DESC").first, Issue.recently_updated.limit(1).first
1719 end
1721 end
1720
1722
1721 def test_on_active_projects_scope
1723 def test_on_active_projects_scope
1722 assert Project.find(2).archive
1724 assert Project.find(2).archive
1723
1725
1724 before = Issue.on_active_project.length
1726 before = Issue.on_active_project.length
1725 # test inclusion to results
1727 # test inclusion to results
1726 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
1728 issue = Issue.generate!(:tracker => Project.find(2).trackers.first)
1727 assert_equal before + 1, Issue.on_active_project.length
1729 assert_equal before + 1, Issue.on_active_project.length
1728
1730
1729 # Move to an archived project
1731 # Move to an archived project
1730 issue.project = Project.find(2)
1732 issue.project = Project.find(2)
1731 assert issue.save
1733 assert issue.save
1732 assert_equal before, Issue.on_active_project.length
1734 assert_equal before, Issue.on_active_project.length
1733 end
1735 end
1734
1736
1735 context "Issue#recipients" do
1737 context "Issue#recipients" do
1736 setup do
1738 setup do
1737 @project = Project.find(1)
1739 @project = Project.find(1)
1738 @author = User.generate!
1740 @author = User.generate!
1739 @assignee = User.generate!
1741 @assignee = User.generate!
1740 @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author)
1742 @issue = Issue.generate!(:project => @project, :assigned_to => @assignee, :author => @author)
1741 end
1743 end
1742
1744
1743 should "include project recipients" do
1745 should "include project recipients" do
1744 assert @project.recipients.present?
1746 assert @project.recipients.present?
1745 @project.recipients.each do |project_recipient|
1747 @project.recipients.each do |project_recipient|
1746 assert @issue.recipients.include?(project_recipient)
1748 assert @issue.recipients.include?(project_recipient)
1747 end
1749 end
1748 end
1750 end
1749
1751
1750 should "include the author if the author is active" do
1752 should "include the author if the author is active" do
1751 assert @issue.author, "No author set for Issue"
1753 assert @issue.author, "No author set for Issue"
1752 assert @issue.recipients.include?(@issue.author.mail)
1754 assert @issue.recipients.include?(@issue.author.mail)
1753 end
1755 end
1754
1756
1755 should "include the assigned to user if the assigned to user is active" do
1757 should "include the assigned to user if the assigned to user is active" do
1756 assert @issue.assigned_to, "No assigned_to set for Issue"
1758 assert @issue.assigned_to, "No assigned_to set for Issue"
1757 assert @issue.recipients.include?(@issue.assigned_to.mail)
1759 assert @issue.recipients.include?(@issue.assigned_to.mail)
1758 end
1760 end
1759
1761
1760 should "not include users who opt out of all email" do
1762 should "not include users who opt out of all email" do
1761 @author.update_attribute(:mail_notification, :none)
1763 @author.update_attribute(:mail_notification, :none)
1762
1764
1763 assert !@issue.recipients.include?(@issue.author.mail)
1765 assert !@issue.recipients.include?(@issue.author.mail)
1764 end
1766 end
1765
1767
1766 should "not include the issue author if they are only notified of assigned issues" do
1768 should "not include the issue author if they are only notified of assigned issues" do
1767 @author.update_attribute(:mail_notification, :only_assigned)
1769 @author.update_attribute(:mail_notification, :only_assigned)
1768
1770
1769 assert !@issue.recipients.include?(@issue.author.mail)
1771 assert !@issue.recipients.include?(@issue.author.mail)
1770 end
1772 end
1771
1773
1772 should "not include the assigned user if they are only notified of owned issues" do
1774 should "not include the assigned user if they are only notified of owned issues" do
1773 @assignee.update_attribute(:mail_notification, :only_owner)
1775 @assignee.update_attribute(:mail_notification, :only_owner)
1774
1776
1775 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1777 assert !@issue.recipients.include?(@issue.assigned_to.mail)
1776 end
1778 end
1777 end
1779 end
1778
1780
1779 def test_last_journal_id_with_journals_should_return_the_journal_id
1781 def test_last_journal_id_with_journals_should_return_the_journal_id
1780 assert_equal 2, Issue.find(1).last_journal_id
1782 assert_equal 2, Issue.find(1).last_journal_id
1781 end
1783 end
1782
1784
1783 def test_last_journal_id_without_journals_should_return_nil
1785 def test_last_journal_id_without_journals_should_return_nil
1784 assert_nil Issue.find(3).last_journal_id
1786 assert_nil Issue.find(3).last_journal_id
1785 end
1787 end
1786
1788
1787 def test_journals_after_should_return_journals_with_greater_id
1789 def test_journals_after_should_return_journals_with_greater_id
1788 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
1790 assert_equal [Journal.find(2)], Issue.find(1).journals_after('1')
1789 assert_equal [], Issue.find(1).journals_after('2')
1791 assert_equal [], Issue.find(1).journals_after('2')
1790 end
1792 end
1791
1793
1792 def test_journals_after_with_blank_arg_should_return_all_journals
1794 def test_journals_after_with_blank_arg_should_return_all_journals
1793 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
1795 assert_equal [Journal.find(1), Journal.find(2)], Issue.find(1).journals_after('')
1794 end
1796 end
1795 end
1797 end
General Comments 0
You need to be logged in to leave comments. Login now