##// END OF EJS Templates
jro_apps » redmine
RSS
prevent assert_difference failure of test_watch_issue_via_context_menu at UI IssuesTest...
Toshi MARUYAMA -
r11578:6d4e43f3fb22
parent child
Show More
Side by Side Unified
Context file:
r11578:6d4e43f3fb22 Loading diff...:
Show file before | Show file after | Hide comments
@@ -1,220 +1,222
1 # Redmine - project management software
1 # Redmine - project management software
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
2 # Copyright (C) 2006-2013 Jean-Philippe Lang
3 #
3 #
4 # This program is free software; you can redistribute it and/or
4 # This program is free software; you can redistribute it and/or
5 # modify it under the terms of the GNU General Public License
5 # modify it under the terms of the GNU General Public License
6 # as published by the Free Software Foundation; either version 2
6 # as published by the Free Software Foundation; either version 2
7 # of the License, or (at your option) any later version.
7 # of the License, or (at your option) any later version.
8 #
8 #
9 # This program is distributed in the hope that it will be useful,
9 # This program is distributed in the hope that it will be useful,
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
10 # but WITHOUT ANY WARRANTY; without even the implied warranty of
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 # GNU General Public License for more details.
12 # GNU General Public License for more details.
13 #
13 #
14 # You should have received a copy of the GNU General Public License
14 # You should have received a copy of the GNU General Public License
15 # along with this program; if not, write to the Free Software
15 # along with this program; if not, write to the Free Software
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
16 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
17
17
18 require File.expand_path('../base', __FILE__)
18 require File.expand_path('../base', __FILE__)
19
19
20 class Redmine::UiTest::IssuesTest < Redmine::UiTest::Base
20 class Redmine::UiTest::IssuesTest < Redmine::UiTest::Base
21 fixtures :projects, :users, :roles, :members, :member_roles,
21 fixtures :projects, :users, :roles, :members, :member_roles,
22 :trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues,
22 :trackers, :projects_trackers, :enabled_modules, :issue_statuses, :issues,
23 :enumerations, :custom_fields, :custom_values, :custom_fields_trackers,
23 :enumerations, :custom_fields, :custom_values, :custom_fields_trackers,
24 :watchers
24 :watchers
25
25
26 def test_create_issue
26 def test_create_issue
27 log_user('jsmith', 'jsmith')
27 log_user('jsmith', 'jsmith')
28 visit '/projects/ecookbook/issues/new'
28 visit '/projects/ecookbook/issues/new'
29 within('form#issue-form') do
29 within('form#issue-form') do
30 select 'Bug', :from => 'Tracker'
30 select 'Bug', :from => 'Tracker'
31 select 'Low', :from => 'Priority'
31 select 'Low', :from => 'Priority'
32 fill_in 'Subject', :with => 'new test issue'
32 fill_in 'Subject', :with => 'new test issue'
33 fill_in 'Description', :with => 'new issue'
33 fill_in 'Description', :with => 'new issue'
34 select '0 %', :from => 'Done'
34 select '0 %', :from => 'Done'
35 fill_in 'Due date', :with => ''
35 fill_in 'Due date', :with => ''
36 select '', :from => 'Assignee'
36 select '', :from => 'Assignee'
37 fill_in 'Searchable field', :with => 'Value for field 2'
37 fill_in 'Searchable field', :with => 'Value for field 2'
38 # click_button 'Create' would match both 'Create' and 'Create and continue' buttons
38 # click_button 'Create' would match both 'Create' and 'Create and continue' buttons
39 find('input[name=commit]').click
39 find('input[name=commit]').click
40 end
40 end
41
41
42 # find created issue
42 # find created issue
43 issue = Issue.find_by_subject("new test issue")
43 issue = Issue.find_by_subject("new test issue")
44 assert_kind_of Issue, issue
44 assert_kind_of Issue, issue
45
45
46 # check redirection
46 # check redirection
47 find 'div#flash_notice', :visible => true, :text => "Issue \##{issue.id} created."
47 find 'div#flash_notice', :visible => true, :text => "Issue \##{issue.id} created."
48 assert_equal issue_path(:id => issue), current_path
48 assert_equal issue_path(:id => issue), current_path
49
49
50 # check issue attributes
50 # check issue attributes
51 assert_equal 'jsmith', issue.author.login
51 assert_equal 'jsmith', issue.author.login
52 assert_equal 1, issue.project.id
52 assert_equal 1, issue.project.id
53 assert_equal IssueStatus.find_by_name('New'), issue.status
53 assert_equal IssueStatus.find_by_name('New'), issue.status
54 assert_equal Tracker.find_by_name('Bug'), issue.tracker
54 assert_equal Tracker.find_by_name('Bug'), issue.tracker
55 assert_equal IssuePriority.find_by_name('Low'), issue.priority
55 assert_equal IssuePriority.find_by_name('Low'), issue.priority
56 assert_equal 'Value for field 2', issue.custom_field_value(CustomField.find_by_name('Searchable field'))
56 assert_equal 'Value for field 2', issue.custom_field_value(CustomField.find_by_name('Searchable field'))
57 end
57 end
58
58
59 def test_create_issue_with_form_update
59 def test_create_issue_with_form_update
60 field1 = IssueCustomField.create!(
60 field1 = IssueCustomField.create!(
61 :field_format => 'string',
61 :field_format => 'string',
62 :name => 'Field1',
62 :name => 'Field1',
63 :is_for_all => true,
63 :is_for_all => true,
64 :trackers => Tracker.find_all_by_id([1, 2])
64 :trackers => Tracker.find_all_by_id([1, 2])
65 )
65 )
66 field2 = IssueCustomField.create!(
66 field2 = IssueCustomField.create!(
67 :field_format => 'string',
67 :field_format => 'string',
68 :name => 'Field2',
68 :name => 'Field2',
69 :is_for_all => true,
69 :is_for_all => true,
70 :trackers => Tracker.find_all_by_id(2)
70 :trackers => Tracker.find_all_by_id(2)
71 )
71 )
72
72
73 Role.non_member.add_permission! :add_issues
73 Role.non_member.add_permission! :add_issues
74 Role.non_member.remove_permission! :edit_issues, :add_issue_notes
74 Role.non_member.remove_permission! :edit_issues, :add_issue_notes
75
75
76 log_user('someone', 'foo')
76 log_user('someone', 'foo')
77 visit '/projects/ecookbook/issues/new'
77 visit '/projects/ecookbook/issues/new'
78 assert page.has_no_content?(field2.name)
78 assert page.has_no_content?(field2.name)
79 assert page.has_content?(field1.name)
79 assert page.has_content?(field1.name)
80
80
81 fill_in 'Subject', :with => 'New test issue'
81 fill_in 'Subject', :with => 'New test issue'
82 fill_in 'Description', :with => 'New test issue description'
82 fill_in 'Description', :with => 'New test issue description'
83 fill_in field1.name, :with => 'CF1 value'
83 fill_in field1.name, :with => 'CF1 value'
84 select 'Low', :from => 'Priority'
84 select 'Low', :from => 'Priority'
85
85
86 # field2 should show up when changing tracker
86 # field2 should show up when changing tracker
87 select 'Feature request', :from => 'Tracker'
87 select 'Feature request', :from => 'Tracker'
88 assert page.has_content?(field2.name)
88 assert page.has_content?(field2.name)
89 assert page.has_content?(field1.name)
89 assert page.has_content?(field1.name)
90
90
91 fill_in field2.name, :with => 'CF2 value'
91 fill_in field2.name, :with => 'CF2 value'
92 assert_difference 'Issue.count' do
92 assert_difference 'Issue.count' do
93 page.first(:button, 'Create').click
93 page.first(:button, 'Create').click
94 end
94 end
95
95
96 issue = Issue.order('id desc').first
96 issue = Issue.order('id desc').first
97 assert_equal 'New test issue', issue.subject
97 assert_equal 'New test issue', issue.subject
98 assert_equal 'New test issue description', issue.description
98 assert_equal 'New test issue description', issue.description
99 assert_equal 'Low', issue.priority.name
99 assert_equal 'Low', issue.priority.name
100 assert_equal 'CF1 value', issue.custom_field_value(field1)
100 assert_equal 'CF1 value', issue.custom_field_value(field1)
101 assert_equal 'CF2 value', issue.custom_field_value(field2)
101 assert_equal 'CF2 value', issue.custom_field_value(field2)
102 end
102 end
103
103
104 def test_create_issue_with_watchers
104 def test_create_issue_with_watchers
105 User.generate!(:firstname => 'Some', :lastname => 'Watcher')
105 User.generate!(:firstname => 'Some', :lastname => 'Watcher')
106
106
107 log_user('jsmith', 'jsmith')
107 log_user('jsmith', 'jsmith')
108 visit '/projects/ecookbook/issues/new'
108 visit '/projects/ecookbook/issues/new'
109 fill_in 'Subject', :with => 'Issue with watchers'
109 fill_in 'Subject', :with => 'Issue with watchers'
110 # Add a project member as watcher
110 # Add a project member as watcher
111 check 'Dave Lopper'
111 check 'Dave Lopper'
112 # Search for another user
112 # Search for another user
113 assert page.has_no_css?('form#new-watcher-form')
113 assert page.has_no_css?('form#new-watcher-form')
114 assert page.has_no_content?('Some Watcher')
114 assert page.has_no_content?('Some Watcher')
115 click_link 'Search for watchers to add'
115 click_link 'Search for watchers to add'
116 within('form#new-watcher-form') do
116 within('form#new-watcher-form') do
117 assert page.has_content?('Some One')
117 assert page.has_content?('Some One')
118 fill_in 'user_search', :with => 'watch'
118 fill_in 'user_search', :with => 'watch'
119 assert page.has_no_content?('Some One')
119 assert page.has_no_content?('Some One')
120 check 'Some Watcher'
120 check 'Some Watcher'
121 click_button 'Add'
121 click_button 'Add'
122 end
122 end
123 assert page.has_content?('Some Watcher')
123 assert page.has_content?('Some Watcher')
124 assert_difference 'Issue.count' do
124 assert_difference 'Issue.count' do
125 find('input[name=commit]').click
125 find('input[name=commit]').click
126 end
126 end
127
127
128 issue = Issue.order('id desc').first
128 issue = Issue.order('id desc').first
129 assert_equal ['Dave Lopper', 'Some Watcher'], issue.watcher_users.map(&:name).sort
129 assert_equal ['Dave Lopper', 'Some Watcher'], issue.watcher_users.map(&:name).sort
130 end
130 end
131
131
132 def test_preview_issue_description
132 def test_preview_issue_description
133 log_user('jsmith', 'jsmith')
133 log_user('jsmith', 'jsmith')
134 visit '/projects/ecookbook/issues/new'
134 visit '/projects/ecookbook/issues/new'
135 within('form#issue-form') do
135 within('form#issue-form') do
136 fill_in 'Subject', :with => 'new issue subject'
136 fill_in 'Subject', :with => 'new issue subject'
137 fill_in 'Description', :with => 'new issue description'
137 fill_in 'Description', :with => 'new issue description'
138 click_link 'Preview'
138 click_link 'Preview'
139 end
139 end
140 find 'div#preview fieldset', :visible => true, :text => 'new issue description'
140 find 'div#preview fieldset', :visible => true, :text => 'new issue description'
141 assert_difference 'Issue.count' do
141 assert_difference 'Issue.count' do
142 find('input[name=commit]').click
142 find('input[name=commit]').click
143 end
143 end
144
144
145 issue = Issue.order('id desc').first
145 issue = Issue.order('id desc').first
146 assert_equal 'new issue description', issue.description
146 assert_equal 'new issue description', issue.description
147 end
147 end
148
148
149 def test_update_issue_with_form_update
149 def test_update_issue_with_form_update
150 field = IssueCustomField.create!(
150 field = IssueCustomField.create!(
151 :field_format => 'string',
151 :field_format => 'string',
152 :name => 'Form update CF',
152 :name => 'Form update CF',
153 :is_for_all => true,
153 :is_for_all => true,
154 :trackers => Tracker.find_all_by_name('Feature request')
154 :trackers => Tracker.find_all_by_name('Feature request')
155 )
155 )
156
156
157 Role.non_member.add_permission! :edit_issues
157 Role.non_member.add_permission! :edit_issues
158 Role.non_member.remove_permission! :add_issues, :add_issue_notes
158 Role.non_member.remove_permission! :add_issues, :add_issue_notes
159
159
160 log_user('someone', 'foo')
160 log_user('someone', 'foo')
161 visit '/issues/1'
161 visit '/issues/1'
162 assert page.has_no_content?('Form update CF')
162 assert page.has_no_content?('Form update CF')
163
163
164 page.first(:link, 'Update').click
164 page.first(:link, 'Update').click
165 # the custom field should show up when changing tracker
165 # the custom field should show up when changing tracker
166 select 'Feature request', :from => 'Tracker'
166 select 'Feature request', :from => 'Tracker'
167 assert page.has_content?('Form update CF')
167 assert page.has_content?('Form update CF')
168
168
169 fill_in 'Form update', :with => 'CF value'
169 fill_in 'Form update', :with => 'CF value'
170 assert_no_difference 'Issue.count' do
170 assert_no_difference 'Issue.count' do
171 page.first(:button, 'Submit').click
171 page.first(:button, 'Submit').click
172 end
172 end
173
173
174 issue = Issue.find(1)
174 issue = Issue.find(1)
175 assert_equal 'CF value', issue.custom_field_value(field)
175 assert_equal 'CF value', issue.custom_field_value(field)
176 end
176 end
177
177
178 def test_remove_issue_watcher_from_sidebar
178 def test_remove_issue_watcher_from_sidebar
179 user = User.find(3)
179 user = User.find(3)
180 Watcher.create!(:watchable => Issue.find(1), :user => user)
180 Watcher.create!(:watchable => Issue.find(1), :user => user)
181
181
182 log_user('jsmith', 'jsmith')
182 log_user('jsmith', 'jsmith')
183 visit '/issues/1'
183 visit '/issues/1'
184 assert page.first('#sidebar').has_content?('Watchers (1)')
184 assert page.first('#sidebar').has_content?('Watchers (1)')
185 assert page.first('#sidebar').has_content?(user.name)
185 assert page.first('#sidebar').has_content?(user.name)
186 assert_difference 'Watcher.count', -1 do
186 assert_difference 'Watcher.count', -1 do
187 page.first('ul.watchers .user-3 a.delete').click
187 page.first('ul.watchers .user-3 a.delete').click
188 assert page.first('#sidebar').has_content?('Watchers (0)')
188 assert page.first('#sidebar').has_content?('Watchers (0)')
189 end
189 end
190 assert page.first('#sidebar').has_no_content?(user.name)
190 assert page.first('#sidebar').has_no_content?(user.name)
191 end
191 end
192
192
193 def test_watch_issue_via_context_menu
193 def test_watch_issue_via_context_menu
194 log_user('jsmith', 'jsmith')
194 log_user('jsmith', 'jsmith')
195 visit '/issues'
195 visit '/issues'
196 assert page.has_css?('tr#issue-1')
196 find('tr#issue-1 td.updated_on').click
197 find('tr#issue-1 td.updated_on').click
197 page.execute_script "$('tr#issue-1 td.updated_on').trigger('contextmenu');"
198 page.execute_script "$('tr#issue-1 td.updated_on').trigger('contextmenu');"
198 assert_difference 'Watcher.count' do
199 assert_difference 'Watcher.count' do
199 within('#context-menu') do
200 within('#context-menu') do
200 click_link 'Watch'
201 click_link 'Watch'
201 end
202 end
203 assert page.has_css?('tr#issue-1')
202 end
204 end
203 assert Issue.find(1).watched_by?(User.find_by_login('jsmith'))
205 assert Issue.find(1).watched_by?(User.find_by_login('jsmith'))
204 end
206 end
205
207
206 def test_bulk_watch_issues_via_context_menu
208 def test_bulk_watch_issues_via_context_menu
207 log_user('jsmith', 'jsmith')
209 log_user('jsmith', 'jsmith')
208 visit '/issues'
210 visit '/issues'
209 find('tr#issue-1 input[type=checkbox]').click
211 find('tr#issue-1 input[type=checkbox]').click
210 find('tr#issue-4 input[type=checkbox]').click
212 find('tr#issue-4 input[type=checkbox]').click
211 page.execute_script "$('tr#issue-1 td.updated_on').trigger('contextmenu');"
213 page.execute_script "$('tr#issue-1 td.updated_on').trigger('contextmenu');"
212 assert_difference 'Watcher.count', 2 do
214 assert_difference 'Watcher.count', 2 do
213 within('#context-menu') do
215 within('#context-menu') do
214 click_link 'Watch'
216 click_link 'Watch'
215 end
217 end
216 end
218 end
217 assert Issue.find(1).watched_by?(User.find_by_login('jsmith'))
219 assert Issue.find(1).watched_by?(User.find_by_login('jsmith'))
218 assert Issue.find(4).watched_by?(User.find_by_login('jsmith'))
220 assert Issue.find(4).watched_by?(User.find_by_login('jsmith'))
219 end
221 end
220 end
222 end
General Comments 0
You need to be logged in to leave comments. Login now