jro_apps/redmine Commit - r10958:6ce28450c004

Adds a named route for thumbnails and use route helper in #thumbnail_tag....

Jean-Philippe Lang -

r10958:6ce28450c004

parent child

Context file:

r10958:6ce28450c004

app/helpers/application_helper.rb +2 -2

               end
               def thumbnail_tag(attachment)
-                link_to image_tag(url_for(:controller => 'attachments', :action => 'thumbnail', :id => attachment)),
+                link_to image_tag(thumbnail_path(attachment)),
-                  {:controller => 'attachments', :action => 'show', :id => attachment, :filename => attachment.filename},
+                  named_attachment_path(attachment, attachment.filename),
                   :title => attachment.filename
               end

config/routes.rb +1 -1

               get 'attachments/:id/:filename', :to => 'attachments#show', :id => /\d+/, :filename => /.*/, :as => 'named_attachment'
               get 'attachments/download/:id/:filename', :to => 'attachments#download', :id => /\d+/, :filename => /.*/, :as => 'download_named_attachment'
               get 'attachments/download/:id', :to => 'attachments#download', :id => /\d+/
-              get 'attachments/thumbnail/:id(/:size)', :to => 'attachments#thumbnail', :id => /\d+/, :size => /\d+/
+              get 'attachments/thumbnail/:id(/:size)', :to => 'attachments#thumbnail', :id => /\d+/, :size => /\d+/, :as => 'thumbnail'
               resources :attachments, :only => [:show, :destroy]
               resources :groups do

test/unit/helpers/application_helper_test.rb +6 0

                   link_to_attachment(a, :only_path => false)
               end
+              def test_thumbnail_tag
+                a = Attachment.find(3)
+                assert_equal '<a href="/attachments/3/logo.gif" title="logo.gif"><img alt="3" src="/attachments/thumbnail/3" /></a>',
+                  thumbnail_tag(a)
+              end
               def test_link_to_project
                 project = Project.find(1)
                 assert_equal %(<a href="/projects/ecookbook">eCookbook</a>),

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages