jro_apps/redmine Commit - r3694:6cb4ff7d8981

Refactor and documentation for User#find_by_login....

Eric Davis -

r3694:6cb4ff7d8981

parent child

Context file:

r3694:6cb4ff7d8981

app/models/user.rb +5 -5

                  @notified_projects_ids = nil
                  notified_projects_ids
                end
-               # case-insensitive fall-over
+               # Find a user account by matching the exact login and then a case-insensitive
+               # version.  Exact matches will be given priority.
                def self.find_by_login(login)
                  # First look for an exact match
-                 user = find(:first, :conditions => ["login = ?", login])
+                 user = first(:conditions => {:login => login})
                  # Fail over to case-insensitive if none was found
-                 user = find(:first, :conditions => ["LOWER(login) = ?", login.to_s.downcase]) if user.nil?
-                 return user
+                 user ||= first(:conditions => ["LOWER(login) = ?", login.to_s.downcase])
                end
                def self.find_by_rss_key(key)

General Comments 0

You need to be logged in to leave comments. Login now

No TODOs yet

	Repositories
g s	Goto summary page
g c	Goto changelog page
g f	Goto files page
g F	Goto files page with file search activated
g p	Goto pull requests page
g o	Goto repository settings
g O	Goto repository access permissions settings
t s	Toggle sidebar on some pages