##// END OF EJS Templates
Fixed an assertion for ruby1.9....
Jean-Philippe Lang -
r8666:6c27093a8bf4
parent child
Show More
@@ -1,592 +1,592
1 # encoding: utf-8
1 # encoding: utf-8
2 #
2 #
3 # Redmine - project management software
3 # Redmine - project management software
4 # Copyright (C) 2006-2011 Jean-Philippe Lang
4 # Copyright (C) 2006-2011 Jean-Philippe Lang
5 #
5 #
6 # This program is free software; you can redistribute it and/or
6 # This program is free software; you can redistribute it and/or
7 # modify it under the terms of the GNU General Public License
7 # modify it under the terms of the GNU General Public License
8 # as published by the Free Software Foundation; either version 2
8 # as published by the Free Software Foundation; either version 2
9 # of the License, or (at your option) any later version.
9 # of the License, or (at your option) any later version.
10 #
10 #
11 # This program is distributed in the hope that it will be useful,
11 # This program is distributed in the hope that it will be useful,
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 # GNU General Public License for more details.
14 # GNU General Public License for more details.
15 #
15 #
16 # You should have received a copy of the GNU General Public License
16 # You should have received a copy of the GNU General Public License
17 # along with this program; if not, write to the Free Software
17 # along with this program; if not, write to the Free Software
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
18 # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19
19
20 require File.expand_path('../../test_helper', __FILE__)
20 require File.expand_path('../../test_helper', __FILE__)
21
21
22 class MailHandlerTest < ActiveSupport::TestCase
22 class MailHandlerTest < ActiveSupport::TestCase
23 fixtures :users, :projects, :enabled_modules, :roles,
23 fixtures :users, :projects, :enabled_modules, :roles,
24 :members, :member_roles, :users,
24 :members, :member_roles, :users,
25 :issues, :issue_statuses,
25 :issues, :issue_statuses,
26 :workflows, :trackers, :projects_trackers,
26 :workflows, :trackers, :projects_trackers,
27 :versions, :enumerations, :issue_categories,
27 :versions, :enumerations, :issue_categories,
28 :custom_fields, :custom_fields_trackers, :custom_fields_projects,
28 :custom_fields, :custom_fields_trackers, :custom_fields_projects,
29 :boards, :messages
29 :boards, :messages
30
30
31 FIXTURES_PATH = File.dirname(__FILE__) + '/../fixtures/mail_handler'
31 FIXTURES_PATH = File.dirname(__FILE__) + '/../fixtures/mail_handler'
32
32
33 def setup
33 def setup
34 ActionMailer::Base.deliveries.clear
34 ActionMailer::Base.deliveries.clear
35 Setting.notified_events = Redmine::Notifiable.all.collect(&:name)
35 Setting.notified_events = Redmine::Notifiable.all.collect(&:name)
36 end
36 end
37
37
38 def test_add_issue
38 def test_add_issue
39 ActionMailer::Base.deliveries.clear
39 ActionMailer::Base.deliveries.clear
40 # This email contains: 'Project: onlinestore'
40 # This email contains: 'Project: onlinestore'
41 issue = submit_email('ticket_on_given_project.eml')
41 issue = submit_email('ticket_on_given_project.eml')
42 assert issue.is_a?(Issue)
42 assert issue.is_a?(Issue)
43 assert !issue.new_record?
43 assert !issue.new_record?
44 issue.reload
44 issue.reload
45 assert_equal Project.find(2), issue.project
45 assert_equal Project.find(2), issue.project
46 assert_equal issue.project.trackers.first, issue.tracker
46 assert_equal issue.project.trackers.first, issue.tracker
47 assert_equal 'New ticket on a given project', issue.subject
47 assert_equal 'New ticket on a given project', issue.subject
48 assert_equal User.find_by_login('jsmith'), issue.author
48 assert_equal User.find_by_login('jsmith'), issue.author
49 assert_equal IssueStatus.find_by_name('Resolved'), issue.status
49 assert_equal IssueStatus.find_by_name('Resolved'), issue.status
50 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
50 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
51 assert_equal '2010-01-01', issue.start_date.to_s
51 assert_equal '2010-01-01', issue.start_date.to_s
52 assert_equal '2010-12-31', issue.due_date.to_s
52 assert_equal '2010-12-31', issue.due_date.to_s
53 assert_equal User.find_by_login('jsmith'), issue.assigned_to
53 assert_equal User.find_by_login('jsmith'), issue.assigned_to
54 assert_equal Version.find_by_name('Alpha'), issue.fixed_version
54 assert_equal Version.find_by_name('Alpha'), issue.fixed_version
55 assert_equal 2.5, issue.estimated_hours
55 assert_equal 2.5, issue.estimated_hours
56 assert_equal 30, issue.done_ratio
56 assert_equal 30, issue.done_ratio
57 assert_equal [issue.id, 1, 2], [issue.root_id, issue.lft, issue.rgt]
57 assert_equal [issue.id, 1, 2], [issue.root_id, issue.lft, issue.rgt]
58 # keywords should be removed from the email body
58 # keywords should be removed from the email body
59 assert !issue.description.match(/^Project:/i)
59 assert !issue.description.match(/^Project:/i)
60 assert !issue.description.match(/^Status:/i)
60 assert !issue.description.match(/^Status:/i)
61 assert !issue.description.match(/^Start Date:/i)
61 assert !issue.description.match(/^Start Date:/i)
62 # Email notification should be sent
62 # Email notification should be sent
63 mail = ActionMailer::Base.deliveries.last
63 mail = ActionMailer::Base.deliveries.last
64 assert_not_nil mail
64 assert_not_nil mail
65 assert mail.subject.include?('New ticket on a given project')
65 assert mail.subject.include?('New ticket on a given project')
66 end
66 end
67
67
68 def test_add_issue_with_default_tracker
68 def test_add_issue_with_default_tracker
69 # This email contains: 'Project: onlinestore'
69 # This email contains: 'Project: onlinestore'
70 issue = submit_email(
70 issue = submit_email(
71 'ticket_on_given_project.eml',
71 'ticket_on_given_project.eml',
72 :issue => {:tracker => 'Support request'}
72 :issue => {:tracker => 'Support request'}
73 )
73 )
74 assert issue.is_a?(Issue)
74 assert issue.is_a?(Issue)
75 assert !issue.new_record?
75 assert !issue.new_record?
76 issue.reload
76 issue.reload
77 assert_equal 'Support request', issue.tracker.name
77 assert_equal 'Support request', issue.tracker.name
78 end
78 end
79
79
80 def test_add_issue_with_status
80 def test_add_issue_with_status
81 # This email contains: 'Project: onlinestore' and 'Status: Resolved'
81 # This email contains: 'Project: onlinestore' and 'Status: Resolved'
82 issue = submit_email('ticket_on_given_project.eml')
82 issue = submit_email('ticket_on_given_project.eml')
83 assert issue.is_a?(Issue)
83 assert issue.is_a?(Issue)
84 assert !issue.new_record?
84 assert !issue.new_record?
85 issue.reload
85 issue.reload
86 assert_equal Project.find(2), issue.project
86 assert_equal Project.find(2), issue.project
87 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
87 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
88 end
88 end
89
89
90 def test_add_issue_with_attributes_override
90 def test_add_issue_with_attributes_override
91 issue = submit_email(
91 issue = submit_email(
92 'ticket_with_attributes.eml',
92 'ticket_with_attributes.eml',
93 :allow_override => 'tracker,category,priority'
93 :allow_override => 'tracker,category,priority'
94 )
94 )
95 assert issue.is_a?(Issue)
95 assert issue.is_a?(Issue)
96 assert !issue.new_record?
96 assert !issue.new_record?
97 issue.reload
97 issue.reload
98 assert_equal 'New ticket on a given project', issue.subject
98 assert_equal 'New ticket on a given project', issue.subject
99 assert_equal User.find_by_login('jsmith'), issue.author
99 assert_equal User.find_by_login('jsmith'), issue.author
100 assert_equal Project.find(2), issue.project
100 assert_equal Project.find(2), issue.project
101 assert_equal 'Feature request', issue.tracker.to_s
101 assert_equal 'Feature request', issue.tracker.to_s
102 assert_equal 'Stock management', issue.category.to_s
102 assert_equal 'Stock management', issue.category.to_s
103 assert_equal 'Urgent', issue.priority.to_s
103 assert_equal 'Urgent', issue.priority.to_s
104 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
104 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
105 end
105 end
106
106
107 def test_add_issue_with_group_assignment
107 def test_add_issue_with_group_assignment
108 with_settings :issue_group_assignment => '1' do
108 with_settings :issue_group_assignment => '1' do
109 issue = submit_email('ticket_on_given_project.eml') do |email|
109 issue = submit_email('ticket_on_given_project.eml') do |email|
110 email.gsub!('Assigned to: John Smith', 'Assigned to: B Team')
110 email.gsub!('Assigned to: John Smith', 'Assigned to: B Team')
111 end
111 end
112 assert issue.is_a?(Issue)
112 assert issue.is_a?(Issue)
113 assert !issue.new_record?
113 assert !issue.new_record?
114 issue.reload
114 issue.reload
115 assert_equal Group.find(11), issue.assigned_to
115 assert_equal Group.find(11), issue.assigned_to
116 end
116 end
117 end
117 end
118
118
119 def test_add_issue_with_partial_attributes_override
119 def test_add_issue_with_partial_attributes_override
120 issue = submit_email(
120 issue = submit_email(
121 'ticket_with_attributes.eml',
121 'ticket_with_attributes.eml',
122 :issue => {:priority => 'High'},
122 :issue => {:priority => 'High'},
123 :allow_override => ['tracker']
123 :allow_override => ['tracker']
124 )
124 )
125 assert issue.is_a?(Issue)
125 assert issue.is_a?(Issue)
126 assert !issue.new_record?
126 assert !issue.new_record?
127 issue.reload
127 issue.reload
128 assert_equal 'New ticket on a given project', issue.subject
128 assert_equal 'New ticket on a given project', issue.subject
129 assert_equal User.find_by_login('jsmith'), issue.author
129 assert_equal User.find_by_login('jsmith'), issue.author
130 assert_equal Project.find(2), issue.project
130 assert_equal Project.find(2), issue.project
131 assert_equal 'Feature request', issue.tracker.to_s
131 assert_equal 'Feature request', issue.tracker.to_s
132 assert_nil issue.category
132 assert_nil issue.category
133 assert_equal 'High', issue.priority.to_s
133 assert_equal 'High', issue.priority.to_s
134 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
134 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
135 end
135 end
136
136
137 def test_add_issue_with_spaces_between_attribute_and_separator
137 def test_add_issue_with_spaces_between_attribute_and_separator
138 issue = submit_email(
138 issue = submit_email(
139 'ticket_with_spaces_between_attribute_and_separator.eml',
139 'ticket_with_spaces_between_attribute_and_separator.eml',
140 :allow_override => 'tracker,category,priority'
140 :allow_override => 'tracker,category,priority'
141 )
141 )
142 assert issue.is_a?(Issue)
142 assert issue.is_a?(Issue)
143 assert !issue.new_record?
143 assert !issue.new_record?
144 issue.reload
144 issue.reload
145 assert_equal 'New ticket on a given project', issue.subject
145 assert_equal 'New ticket on a given project', issue.subject
146 assert_equal User.find_by_login('jsmith'), issue.author
146 assert_equal User.find_by_login('jsmith'), issue.author
147 assert_equal Project.find(2), issue.project
147 assert_equal Project.find(2), issue.project
148 assert_equal 'Feature request', issue.tracker.to_s
148 assert_equal 'Feature request', issue.tracker.to_s
149 assert_equal 'Stock management', issue.category.to_s
149 assert_equal 'Stock management', issue.category.to_s
150 assert_equal 'Urgent', issue.priority.to_s
150 assert_equal 'Urgent', issue.priority.to_s
151 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
151 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
152 end
152 end
153
153
154 def test_add_issue_with_attachment_to_specific_project
154 def test_add_issue_with_attachment_to_specific_project
155 issue = submit_email('ticket_with_attachment.eml', :issue => {:project => 'onlinestore'})
155 issue = submit_email('ticket_with_attachment.eml', :issue => {:project => 'onlinestore'})
156 assert issue.is_a?(Issue)
156 assert issue.is_a?(Issue)
157 assert !issue.new_record?
157 assert !issue.new_record?
158 issue.reload
158 issue.reload
159 assert_equal 'Ticket created by email with attachment', issue.subject
159 assert_equal 'Ticket created by email with attachment', issue.subject
160 assert_equal User.find_by_login('jsmith'), issue.author
160 assert_equal User.find_by_login('jsmith'), issue.author
161 assert_equal Project.find(2), issue.project
161 assert_equal Project.find(2), issue.project
162 assert_equal 'This is a new ticket with attachments', issue.description
162 assert_equal 'This is a new ticket with attachments', issue.description
163 # Attachment properties
163 # Attachment properties
164 assert_equal 1, issue.attachments.size
164 assert_equal 1, issue.attachments.size
165 assert_equal 'Paella.jpg', issue.attachments.first.filename
165 assert_equal 'Paella.jpg', issue.attachments.first.filename
166 assert_equal 'image/jpeg', issue.attachments.first.content_type
166 assert_equal 'image/jpeg', issue.attachments.first.content_type
167 assert_equal 10790, issue.attachments.first.filesize
167 assert_equal 10790, issue.attachments.first.filesize
168 end
168 end
169
169
170 def test_add_issue_with_custom_fields
170 def test_add_issue_with_custom_fields
171 issue = submit_email('ticket_with_custom_fields.eml', :issue => {:project => 'onlinestore'})
171 issue = submit_email('ticket_with_custom_fields.eml', :issue => {:project => 'onlinestore'})
172 assert issue.is_a?(Issue)
172 assert issue.is_a?(Issue)
173 assert !issue.new_record?
173 assert !issue.new_record?
174 issue.reload
174 issue.reload
175 assert_equal 'New ticket with custom field values', issue.subject
175 assert_equal 'New ticket with custom field values', issue.subject
176 assert_equal 'Value for a custom field',
176 assert_equal 'Value for a custom field',
177 issue.custom_value_for(CustomField.find_by_name('Searchable field')).value
177 issue.custom_value_for(CustomField.find_by_name('Searchable field')).value
178 assert !issue.description.match(/^searchable field:/i)
178 assert !issue.description.match(/^searchable field:/i)
179 end
179 end
180
180
181 def test_add_issue_with_cc
181 def test_add_issue_with_cc
182 issue = submit_email('ticket_with_cc.eml', :issue => {:project => 'ecookbook'})
182 issue = submit_email('ticket_with_cc.eml', :issue => {:project => 'ecookbook'})
183 assert issue.is_a?(Issue)
183 assert issue.is_a?(Issue)
184 assert !issue.new_record?
184 assert !issue.new_record?
185 issue.reload
185 issue.reload
186 assert issue.watched_by?(User.find_by_mail('dlopper@somenet.foo'))
186 assert issue.watched_by?(User.find_by_mail('dlopper@somenet.foo'))
187 assert_equal 1, issue.watcher_user_ids.size
187 assert_equal 1, issue.watcher_user_ids.size
188 end
188 end
189
189
190 def test_add_issue_by_unknown_user
190 def test_add_issue_by_unknown_user
191 assert_no_difference 'User.count' do
191 assert_no_difference 'User.count' do
192 assert_equal false,
192 assert_equal false,
193 submit_email(
193 submit_email(
194 'ticket_by_unknown_user.eml',
194 'ticket_by_unknown_user.eml',
195 :issue => {:project => 'ecookbook'}
195 :issue => {:project => 'ecookbook'}
196 )
196 )
197 end
197 end
198 end
198 end
199
199
200 def test_add_issue_by_anonymous_user
200 def test_add_issue_by_anonymous_user
201 Role.anonymous.add_permission!(:add_issues)
201 Role.anonymous.add_permission!(:add_issues)
202 assert_no_difference 'User.count' do
202 assert_no_difference 'User.count' do
203 issue = submit_email(
203 issue = submit_email(
204 'ticket_by_unknown_user.eml',
204 'ticket_by_unknown_user.eml',
205 :issue => {:project => 'ecookbook'},
205 :issue => {:project => 'ecookbook'},
206 :unknown_user => 'accept'
206 :unknown_user => 'accept'
207 )
207 )
208 assert issue.is_a?(Issue)
208 assert issue.is_a?(Issue)
209 assert issue.author.anonymous?
209 assert issue.author.anonymous?
210 end
210 end
211 end
211 end
212
212
213 def test_add_issue_by_anonymous_user_with_no_from_address
213 def test_add_issue_by_anonymous_user_with_no_from_address
214 Role.anonymous.add_permission!(:add_issues)
214 Role.anonymous.add_permission!(:add_issues)
215 assert_no_difference 'User.count' do
215 assert_no_difference 'User.count' do
216 issue = submit_email(
216 issue = submit_email(
217 'ticket_by_empty_user.eml',
217 'ticket_by_empty_user.eml',
218 :issue => {:project => 'ecookbook'},
218 :issue => {:project => 'ecookbook'},
219 :unknown_user => 'accept'
219 :unknown_user => 'accept'
220 )
220 )
221 assert issue.is_a?(Issue)
221 assert issue.is_a?(Issue)
222 assert issue.author.anonymous?
222 assert issue.author.anonymous?
223 end
223 end
224 end
224 end
225
225
226 def test_add_issue_by_anonymous_user_on_private_project
226 def test_add_issue_by_anonymous_user_on_private_project
227 Role.anonymous.add_permission!(:add_issues)
227 Role.anonymous.add_permission!(:add_issues)
228 assert_no_difference 'User.count' do
228 assert_no_difference 'User.count' do
229 assert_no_difference 'Issue.count' do
229 assert_no_difference 'Issue.count' do
230 assert_equal false,
230 assert_equal false,
231 submit_email(
231 submit_email(
232 'ticket_by_unknown_user.eml',
232 'ticket_by_unknown_user.eml',
233 :issue => {:project => 'onlinestore'},
233 :issue => {:project => 'onlinestore'},
234 :unknown_user => 'accept'
234 :unknown_user => 'accept'
235 )
235 )
236 end
236 end
237 end
237 end
238 end
238 end
239
239
240 def test_add_issue_by_anonymous_user_on_private_project_without_permission_check
240 def test_add_issue_by_anonymous_user_on_private_project_without_permission_check
241 assert_no_difference 'User.count' do
241 assert_no_difference 'User.count' do
242 assert_difference 'Issue.count' do
242 assert_difference 'Issue.count' do
243 issue = submit_email(
243 issue = submit_email(
244 'ticket_by_unknown_user.eml',
244 'ticket_by_unknown_user.eml',
245 :issue => {:project => 'onlinestore'},
245 :issue => {:project => 'onlinestore'},
246 :no_permission_check => '1',
246 :no_permission_check => '1',
247 :unknown_user => 'accept'
247 :unknown_user => 'accept'
248 )
248 )
249 assert issue.is_a?(Issue)
249 assert issue.is_a?(Issue)
250 assert issue.author.anonymous?
250 assert issue.author.anonymous?
251 assert !issue.project.is_public?
251 assert !issue.project.is_public?
252 assert_equal [issue.id, 1, 2], [issue.root_id, issue.lft, issue.rgt]
252 assert_equal [issue.id, 1, 2], [issue.root_id, issue.lft, issue.rgt]
253 end
253 end
254 end
254 end
255 end
255 end
256
256
257 def test_add_issue_by_created_user
257 def test_add_issue_by_created_user
258 Setting.default_language = 'en'
258 Setting.default_language = 'en'
259 assert_difference 'User.count' do
259 assert_difference 'User.count' do
260 issue = submit_email(
260 issue = submit_email(
261 'ticket_by_unknown_user.eml',
261 'ticket_by_unknown_user.eml',
262 :issue => {:project => 'ecookbook'},
262 :issue => {:project => 'ecookbook'},
263 :unknown_user => 'create'
263 :unknown_user => 'create'
264 )
264 )
265 assert issue.is_a?(Issue)
265 assert issue.is_a?(Issue)
266 assert issue.author.active?
266 assert issue.author.active?
267 assert_equal 'john.doe@somenet.foo', issue.author.mail
267 assert_equal 'john.doe@somenet.foo', issue.author.mail
268 assert_equal 'John', issue.author.firstname
268 assert_equal 'John', issue.author.firstname
269 assert_equal 'Doe', issue.author.lastname
269 assert_equal 'Doe', issue.author.lastname
270
270
271 # account information
271 # account information
272 email = ActionMailer::Base.deliveries.first
272 email = ActionMailer::Base.deliveries.first
273 assert_not_nil email
273 assert_not_nil email
274 assert email.subject.include?('account activation')
274 assert email.subject.include?('account activation')
275 login = email.body.match(/\* Login: (.*)$/)[1]
275 login = email.body.match(/\* Login: (.*)$/)[1]
276 password = email.body.match(/\* Password: (.*)$/)[1]
276 password = email.body.match(/\* Password: (.*)$/)[1]
277 assert_equal issue.author, User.try_to_login(login, password)
277 assert_equal issue.author, User.try_to_login(login, password)
278 end
278 end
279 end
279 end
280
280
281 def test_add_issue_without_from_header
281 def test_add_issue_without_from_header
282 Role.anonymous.add_permission!(:add_issues)
282 Role.anonymous.add_permission!(:add_issues)
283 assert_equal false, submit_email('ticket_without_from_header.eml')
283 assert_equal false, submit_email('ticket_without_from_header.eml')
284 end
284 end
285
285
286 def test_add_issue_with_invalid_attributes
286 def test_add_issue_with_invalid_attributes
287 issue = submit_email(
287 issue = submit_email(
288 'ticket_with_invalid_attributes.eml',
288 'ticket_with_invalid_attributes.eml',
289 :allow_override => 'tracker,category,priority'
289 :allow_override => 'tracker,category,priority'
290 )
290 )
291 assert issue.is_a?(Issue)
291 assert issue.is_a?(Issue)
292 assert !issue.new_record?
292 assert !issue.new_record?
293 issue.reload
293 issue.reload
294 assert_nil issue.assigned_to
294 assert_nil issue.assigned_to
295 assert_nil issue.start_date
295 assert_nil issue.start_date
296 assert_nil issue.due_date
296 assert_nil issue.due_date
297 assert_equal 0, issue.done_ratio
297 assert_equal 0, issue.done_ratio
298 assert_equal 'Normal', issue.priority.to_s
298 assert_equal 'Normal', issue.priority.to_s
299 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
299 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
300 end
300 end
301
301
302 def test_add_issue_with_localized_attributes
302 def test_add_issue_with_localized_attributes
303 User.find_by_mail('jsmith@somenet.foo').update_attribute 'language', 'fr'
303 User.find_by_mail('jsmith@somenet.foo').update_attribute 'language', 'fr'
304 issue = submit_email(
304 issue = submit_email(
305 'ticket_with_localized_attributes.eml',
305 'ticket_with_localized_attributes.eml',
306 :allow_override => 'tracker,category,priority'
306 :allow_override => 'tracker,category,priority'
307 )
307 )
308 assert issue.is_a?(Issue)
308 assert issue.is_a?(Issue)
309 assert !issue.new_record?
309 assert !issue.new_record?
310 issue.reload
310 issue.reload
311 assert_equal 'New ticket on a given project', issue.subject
311 assert_equal 'New ticket on a given project', issue.subject
312 assert_equal User.find_by_login('jsmith'), issue.author
312 assert_equal User.find_by_login('jsmith'), issue.author
313 assert_equal Project.find(2), issue.project
313 assert_equal Project.find(2), issue.project
314 assert_equal 'Feature request', issue.tracker.to_s
314 assert_equal 'Feature request', issue.tracker.to_s
315 assert_equal 'Stock management', issue.category.to_s
315 assert_equal 'Stock management', issue.category.to_s
316 assert_equal 'Urgent', issue.priority.to_s
316 assert_equal 'Urgent', issue.priority.to_s
317 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
317 assert issue.description.include?('Lorem ipsum dolor sit amet, consectetuer adipiscing elit.')
318 end
318 end
319
319
320 def test_add_issue_with_japanese_keywords
320 def test_add_issue_with_japanese_keywords
321 ja_dev = "\xe9\x96\x8b\xe7\x99\xba"
321 ja_dev = "\xe9\x96\x8b\xe7\x99\xba"
322 ja_dev.force_encoding('UTF-8') if ja_dev.respond_to?(:force_encoding)
322 ja_dev.force_encoding('UTF-8') if ja_dev.respond_to?(:force_encoding)
323 tracker = Tracker.create!(:name => ja_dev)
323 tracker = Tracker.create!(:name => ja_dev)
324 Project.find(1).trackers << tracker
324 Project.find(1).trackers << tracker
325 issue = submit_email(
325 issue = submit_email(
326 'japanese_keywords_iso_2022_jp.eml',
326 'japanese_keywords_iso_2022_jp.eml',
327 :issue => {:project => 'ecookbook'},
327 :issue => {:project => 'ecookbook'},
328 :allow_override => 'tracker'
328 :allow_override => 'tracker'
329 )
329 )
330 assert_kind_of Issue, issue
330 assert_kind_of Issue, issue
331 assert_equal tracker, issue.tracker
331 assert_equal tracker, issue.tracker
332 end
332 end
333
333
334 def test_add_issue_from_apple_mail
334 def test_add_issue_from_apple_mail
335 issue = submit_email(
335 issue = submit_email(
336 'apple_mail_with_attachment.eml',
336 'apple_mail_with_attachment.eml',
337 :issue => {:project => 'ecookbook'}
337 :issue => {:project => 'ecookbook'}
338 )
338 )
339 assert_kind_of Issue, issue
339 assert_kind_of Issue, issue
340 assert_equal 1, issue.attachments.size
340 assert_equal 1, issue.attachments.size
341
341
342 attachment = issue.attachments.first
342 attachment = issue.attachments.first
343 assert_equal 'paella.jpg', attachment.filename
343 assert_equal 'paella.jpg', attachment.filename
344 assert_equal 10790, attachment.filesize
344 assert_equal 10790, attachment.filesize
345 assert File.exist?(attachment.diskfile)
345 assert File.exist?(attachment.diskfile)
346 assert_equal 10790, File.size(attachment.diskfile)
346 assert_equal 10790, File.size(attachment.diskfile)
347 assert_equal 'caaf384198bcbc9563ab5c058acd73cd', attachment.digest
347 assert_equal 'caaf384198bcbc9563ab5c058acd73cd', attachment.digest
348 end
348 end
349
349
350 def test_should_ignore_emails_from_emission_address
350 def test_should_ignore_emails_from_emission_address
351 Role.anonymous.add_permission!(:add_issues)
351 Role.anonymous.add_permission!(:add_issues)
352 assert_no_difference 'User.count' do
352 assert_no_difference 'User.count' do
353 assert_equal false,
353 assert_equal false,
354 submit_email(
354 submit_email(
355 'ticket_from_emission_address.eml',
355 'ticket_from_emission_address.eml',
356 :issue => {:project => 'ecookbook'},
356 :issue => {:project => 'ecookbook'},
357 :unknown_user => 'create'
357 :unknown_user => 'create'
358 )
358 )
359 end
359 end
360 end
360 end
361
361
362 def test_add_issue_should_send_email_notification
362 def test_add_issue_should_send_email_notification
363 Setting.notified_events = ['issue_added']
363 Setting.notified_events = ['issue_added']
364 ActionMailer::Base.deliveries.clear
364 ActionMailer::Base.deliveries.clear
365 # This email contains: 'Project: onlinestore'
365 # This email contains: 'Project: onlinestore'
366 issue = submit_email('ticket_on_given_project.eml')
366 issue = submit_email('ticket_on_given_project.eml')
367 assert issue.is_a?(Issue)
367 assert issue.is_a?(Issue)
368 assert_equal 1, ActionMailer::Base.deliveries.size
368 assert_equal 1, ActionMailer::Base.deliveries.size
369 end
369 end
370
370
371 def test_update_issue
371 def test_update_issue
372 journal = submit_email('ticket_reply.eml')
372 journal = submit_email('ticket_reply.eml')
373 assert journal.is_a?(Journal)
373 assert journal.is_a?(Journal)
374 assert_equal User.find_by_login('jsmith'), journal.user
374 assert_equal User.find_by_login('jsmith'), journal.user
375 assert_equal Issue.find(2), journal.journalized
375 assert_equal Issue.find(2), journal.journalized
376 assert_match /This is reply/, journal.notes
376 assert_match /This is reply/, journal.notes
377 assert_equal 'Feature request', journal.issue.tracker.name
377 assert_equal 'Feature request', journal.issue.tracker.name
378 end
378 end
379
379
380 def test_update_issue_with_attribute_changes
380 def test_update_issue_with_attribute_changes
381 # This email contains: 'Status: Resolved'
381 # This email contains: 'Status: Resolved'
382 journal = submit_email('ticket_reply_with_status.eml')
382 journal = submit_email('ticket_reply_with_status.eml')
383 assert journal.is_a?(Journal)
383 assert journal.is_a?(Journal)
384 issue = Issue.find(journal.issue.id)
384 issue = Issue.find(journal.issue.id)
385 assert_equal User.find_by_login('jsmith'), journal.user
385 assert_equal User.find_by_login('jsmith'), journal.user
386 assert_equal Issue.find(2), journal.journalized
386 assert_equal Issue.find(2), journal.journalized
387 assert_match /This is reply/, journal.notes
387 assert_match /This is reply/, journal.notes
388 assert_equal 'Feature request', journal.issue.tracker.name
388 assert_equal 'Feature request', journal.issue.tracker.name
389 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
389 assert_equal IssueStatus.find_by_name("Resolved"), issue.status
390 assert_equal '2010-01-01', issue.start_date.to_s
390 assert_equal '2010-01-01', issue.start_date.to_s
391 assert_equal '2010-12-31', issue.due_date.to_s
391 assert_equal '2010-12-31', issue.due_date.to_s
392 assert_equal User.find_by_login('jsmith'), issue.assigned_to
392 assert_equal User.find_by_login('jsmith'), issue.assigned_to
393 assert_equal "52.6", issue.custom_value_for(CustomField.find_by_name('Float field')).value
393 assert_equal "52.6", issue.custom_value_for(CustomField.find_by_name('Float field')).value
394 # keywords should be removed from the email body
394 # keywords should be removed from the email body
395 assert !journal.notes.match(/^Status:/i)
395 assert !journal.notes.match(/^Status:/i)
396 assert !journal.notes.match(/^Start Date:/i)
396 assert !journal.notes.match(/^Start Date:/i)
397 end
397 end
398
398
399 def test_update_issue_with_attachment
399 def test_update_issue_with_attachment
400 assert_difference 'Journal.count' do
400 assert_difference 'Journal.count' do
401 assert_difference 'JournalDetail.count' do
401 assert_difference 'JournalDetail.count' do
402 assert_difference 'Attachment.count' do
402 assert_difference 'Attachment.count' do
403 assert_no_difference 'Issue.count' do
403 assert_no_difference 'Issue.count' do
404 journal = submit_email('ticket_with_attachment.eml') do |raw|
404 journal = submit_email('ticket_with_attachment.eml') do |raw|
405 raw.gsub! /^Subject: .*$/, 'Subject: Re: [Cookbook - Feature #2] (New) Add ingredients categories'
405 raw.gsub! /^Subject: .*$/, 'Subject: Re: [Cookbook - Feature #2] (New) Add ingredients categories'
406 end
406 end
407 end
407 end
408 end
408 end
409 end
409 end
410 end
410 end
411 journal = Journal.first(:order => 'id DESC')
411 journal = Journal.first(:order => 'id DESC')
412 assert_equal Issue.find(2), journal.journalized
412 assert_equal Issue.find(2), journal.journalized
413 assert_equal 1, journal.details.size
413 assert_equal 1, journal.details.size
414
414
415 detail = journal.details.first
415 detail = journal.details.first
416 assert_equal 'attachment', detail.property
416 assert_equal 'attachment', detail.property
417 assert_equal 'Paella.jpg', detail.value
417 assert_equal 'Paella.jpg', detail.value
418 end
418 end
419
419
420 def test_update_issue_should_send_email_notification
420 def test_update_issue_should_send_email_notification
421 ActionMailer::Base.deliveries.clear
421 ActionMailer::Base.deliveries.clear
422 journal = submit_email('ticket_reply.eml')
422 journal = submit_email('ticket_reply.eml')
423 assert journal.is_a?(Journal)
423 assert journal.is_a?(Journal)
424 assert_equal 1, ActionMailer::Base.deliveries.size
424 assert_equal 1, ActionMailer::Base.deliveries.size
425 end
425 end
426
426
427 def test_update_issue_should_not_set_defaults
427 def test_update_issue_should_not_set_defaults
428 journal = submit_email(
428 journal = submit_email(
429 'ticket_reply.eml',
429 'ticket_reply.eml',
430 :issue => {:tracker => 'Support request', :priority => 'High'}
430 :issue => {:tracker => 'Support request', :priority => 'High'}
431 )
431 )
432 assert journal.is_a?(Journal)
432 assert journal.is_a?(Journal)
433 assert_match /This is reply/, journal.notes
433 assert_match /This is reply/, journal.notes
434 assert_equal 'Feature request', journal.issue.tracker.name
434 assert_equal 'Feature request', journal.issue.tracker.name
435 assert_equal 'Normal', journal.issue.priority.name
435 assert_equal 'Normal', journal.issue.priority.name
436 end
436 end
437
437
438 def test_reply_to_a_message
438 def test_reply_to_a_message
439 m = submit_email('message_reply.eml')
439 m = submit_email('message_reply.eml')
440 assert m.is_a?(Message)
440 assert m.is_a?(Message)
441 assert !m.new_record?
441 assert !m.new_record?
442 m.reload
442 m.reload
443 assert_equal 'Reply via email', m.subject
443 assert_equal 'Reply via email', m.subject
444 # The email replies to message #2 which is part of the thread of message #1
444 # The email replies to message #2 which is part of the thread of message #1
445 assert_equal Message.find(1), m.parent
445 assert_equal Message.find(1), m.parent
446 end
446 end
447
447
448 def test_reply_to_a_message_by_subject
448 def test_reply_to_a_message_by_subject
449 m = submit_email('message_reply_by_subject.eml')
449 m = submit_email('message_reply_by_subject.eml')
450 assert m.is_a?(Message)
450 assert m.is_a?(Message)
451 assert !m.new_record?
451 assert !m.new_record?
452 m.reload
452 m.reload
453 assert_equal 'Reply to the first post', m.subject
453 assert_equal 'Reply to the first post', m.subject
454 assert_equal Message.find(1), m.parent
454 assert_equal Message.find(1), m.parent
455 end
455 end
456
456
457 def test_should_strip_tags_of_html_only_emails
457 def test_should_strip_tags_of_html_only_emails
458 issue = submit_email('ticket_html_only.eml', :issue => {:project => 'ecookbook'})
458 issue = submit_email('ticket_html_only.eml', :issue => {:project => 'ecookbook'})
459 assert issue.is_a?(Issue)
459 assert issue.is_a?(Issue)
460 assert !issue.new_record?
460 assert !issue.new_record?
461 issue.reload
461 issue.reload
462 assert_equal 'HTML email', issue.subject
462 assert_equal 'HTML email', issue.subject
463 assert_equal 'This is a html-only email.', issue.description
463 assert_equal 'This is a html-only email.', issue.description
464 end
464 end
465
465
466 context "truncate emails based on the Setting" do
466 context "truncate emails based on the Setting" do
467 context "with no setting" do
467 context "with no setting" do
468 setup do
468 setup do
469 Setting.mail_handler_body_delimiters = ''
469 Setting.mail_handler_body_delimiters = ''
470 end
470 end
471
471
472 should "add the entire email into the issue" do
472 should "add the entire email into the issue" do
473 issue = submit_email('ticket_on_given_project.eml')
473 issue = submit_email('ticket_on_given_project.eml')
474 assert_issue_created(issue)
474 assert_issue_created(issue)
475 assert issue.description.include?('---')
475 assert issue.description.include?('---')
476 assert issue.description.include?('This paragraph is after the delimiter')
476 assert issue.description.include?('This paragraph is after the delimiter')
477 end
477 end
478 end
478 end
479
479
480 context "with a single string" do
480 context "with a single string" do
481 setup do
481 setup do
482 Setting.mail_handler_body_delimiters = '---'
482 Setting.mail_handler_body_delimiters = '---'
483 end
483 end
484 should "truncate the email at the delimiter for the issue" do
484 should "truncate the email at the delimiter for the issue" do
485 issue = submit_email('ticket_on_given_project.eml')
485 issue = submit_email('ticket_on_given_project.eml')
486 assert_issue_created(issue)
486 assert_issue_created(issue)
487 assert issue.description.include?('This paragraph is before delimiters')
487 assert issue.description.include?('This paragraph is before delimiters')
488 assert issue.description.include?('--- This line starts with a delimiter')
488 assert issue.description.include?('--- This line starts with a delimiter')
489 assert !issue.description.match(/^---$/)
489 assert !issue.description.match(/^---$/)
490 assert !issue.description.include?('This paragraph is after the delimiter')
490 assert !issue.description.include?('This paragraph is after the delimiter')
491 end
491 end
492 end
492 end
493
493
494 context "with a single quoted reply (e.g. reply to a Redmine email notification)" do
494 context "with a single quoted reply (e.g. reply to a Redmine email notification)" do
495 setup do
495 setup do
496 Setting.mail_handler_body_delimiters = '--- Reply above. Do not remove this line. ---'
496 Setting.mail_handler_body_delimiters = '--- Reply above. Do not remove this line. ---'
497 end
497 end
498 should "truncate the email at the delimiter with the quoted reply symbols (>)" do
498 should "truncate the email at the delimiter with the quoted reply symbols (>)" do
499 journal = submit_email('issue_update_with_quoted_reply_above.eml')
499 journal = submit_email('issue_update_with_quoted_reply_above.eml')
500 assert journal.is_a?(Journal)
500 assert journal.is_a?(Journal)
501 assert journal.notes.include?('An update to the issue by the sender.')
501 assert journal.notes.include?('An update to the issue by the sender.')
502 assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
502 assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
503 assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
503 assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
504 end
504 end
505 end
505 end
506
506
507 context "with multiple quoted replies (e.g. reply to a reply of a Redmine email notification)" do
507 context "with multiple quoted replies (e.g. reply to a reply of a Redmine email notification)" do
508 setup do
508 setup do
509 Setting.mail_handler_body_delimiters = '--- Reply above. Do not remove this line. ---'
509 Setting.mail_handler_body_delimiters = '--- Reply above. Do not remove this line. ---'
510 end
510 end
511 should "truncate the email at the delimiter with the quoted reply symbols (>)" do
511 should "truncate the email at the delimiter with the quoted reply symbols (>)" do
512 journal = submit_email('issue_update_with_multiple_quoted_reply_above.eml')
512 journal = submit_email('issue_update_with_multiple_quoted_reply_above.eml')
513 assert journal.is_a?(Journal)
513 assert journal.is_a?(Journal)
514 assert journal.notes.include?('An update to the issue by the sender.')
514 assert journal.notes.include?('An update to the issue by the sender.')
515 assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
515 assert !journal.notes.match(Regexp.escape("--- Reply above. Do not remove this line. ---"))
516 assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
516 assert !journal.notes.include?('Looks like the JSON api for projects was missed.')
517 end
517 end
518 end
518 end
519
519
520 context "with multiple strings" do
520 context "with multiple strings" do
521 setup do
521 setup do
522 Setting.mail_handler_body_delimiters = "---\nBREAK"
522 Setting.mail_handler_body_delimiters = "---\nBREAK"
523 end
523 end
524 should "truncate the email at the first delimiter found (BREAK)" do
524 should "truncate the email at the first delimiter found (BREAK)" do
525 issue = submit_email('ticket_on_given_project.eml')
525 issue = submit_email('ticket_on_given_project.eml')
526 assert_issue_created(issue)
526 assert_issue_created(issue)
527 assert issue.description.include?('This paragraph is before delimiters')
527 assert issue.description.include?('This paragraph is before delimiters')
528 assert !issue.description.include?('BREAK')
528 assert !issue.description.include?('BREAK')
529 assert !issue.description.include?('This paragraph is between delimiters')
529 assert !issue.description.include?('This paragraph is between delimiters')
530 assert !issue.description.match(/^---$/)
530 assert !issue.description.match(/^---$/)
531 assert !issue.description.include?('This paragraph is after the delimiter')
531 assert !issue.description.include?('This paragraph is after the delimiter')
532 end
532 end
533 end
533 end
534 end
534 end
535
535
536 def test_email_with_long_subject_line
536 def test_email_with_long_subject_line
537 issue = submit_email('ticket_with_long_subject.eml')
537 issue = submit_email('ticket_with_long_subject.eml')
538 assert issue.is_a?(Issue)
538 assert issue.is_a?(Issue)
539 assert_equal issue.subject, 'New ticket on a given project with a very long subject line which exceeds 255 chars and should not be ignored but chopped off. And if the subject line is still not long enough, we just add more text. And more text. Wow, this is really annoying. Especially, if you have nothing to say...'[0,255]
539 assert_equal issue.subject, 'New ticket on a given project with a very long subject line which exceeds 255 chars and should not be ignored but chopped off. And if the subject line is still not long enough, we just add more text. And more text. Wow, this is really annoying. Especially, if you have nothing to say...'[0,255]
540 end
540 end
541
541
542 def test_new_user_from_attributes_should_return_valid_user
542 def test_new_user_from_attributes_should_return_valid_user
543 to_test = {
543 to_test = {
544 # [address, name] => [login, firstname, lastname]
544 # [address, name] => [login, firstname, lastname]
545 ['jsmith@example.net', nil] => ['jsmith@example.net', 'jsmith', '-'],
545 ['jsmith@example.net', nil] => ['jsmith@example.net', 'jsmith', '-'],
546 ['jsmith@example.net', 'John'] => ['jsmith@example.net', 'John', '-'],
546 ['jsmith@example.net', 'John'] => ['jsmith@example.net', 'John', '-'],
547 ['jsmith@example.net', 'John Smith'] => ['jsmith@example.net', 'John', 'Smith'],
547 ['jsmith@example.net', 'John Smith'] => ['jsmith@example.net', 'John', 'Smith'],
548 ['jsmith@example.net', 'John Paul Smith'] => ['jsmith@example.net', 'John', 'Paul Smith'],
548 ['jsmith@example.net', 'John Paul Smith'] => ['jsmith@example.net', 'John', 'Paul Smith'],
549 ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsTheMaximumLength Smith'] => ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsT', 'Smith'],
549 ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsTheMaximumLength Smith'] => ['jsmith@example.net', 'AVeryLongFirstnameThatExceedsT', 'Smith'],
550 ['jsmith@example.net', 'John AVeryLongLastnameThatExceedsTheMaximumLength'] => ['jsmith@example.net', 'John', 'AVeryLongLastnameThatExceedsTh']
550 ['jsmith@example.net', 'John AVeryLongLastnameThatExceedsTheMaximumLength'] => ['jsmith@example.net', 'John', 'AVeryLongLastnameThatExceedsTh']
551 }
551 }
552
552
553 to_test.each do |attrs, expected|
553 to_test.each do |attrs, expected|
554 user = MailHandler.new_user_from_attributes(attrs.first, attrs.last)
554 user = MailHandler.new_user_from_attributes(attrs.first, attrs.last)
555
555
556 assert user.valid?, user.errors.full_messages
556 assert user.valid?, user.errors.full_messages.to_s
557 assert_equal attrs.first, user.mail
557 assert_equal attrs.first, user.mail
558 assert_equal expected[0], user.login
558 assert_equal expected[0], user.login
559 assert_equal expected[1], user.firstname
559 assert_equal expected[1], user.firstname
560 assert_equal expected[2], user.lastname
560 assert_equal expected[2], user.lastname
561 end
561 end
562 end
562 end
563
563
564 def test_new_user_from_attributes_should_respect_minimum_password_length
564 def test_new_user_from_attributes_should_respect_minimum_password_length
565 with_settings :password_min_length => 15 do
565 with_settings :password_min_length => 15 do
566 user = MailHandler.new_user_from_attributes('jsmith@example.net')
566 user = MailHandler.new_user_from_attributes('jsmith@example.net')
567 assert user.valid?
567 assert user.valid?
568 assert user.password.length >= 15
568 assert user.password.length >= 15
569 end
569 end
570 end
570 end
571
571
572 def test_new_user_from_attributes_should_use_default_login_if_invalid
572 def test_new_user_from_attributes_should_use_default_login_if_invalid
573 user = MailHandler.new_user_from_attributes('foo+bar@example.net')
573 user = MailHandler.new_user_from_attributes('foo+bar@example.net')
574 assert user.valid?
574 assert user.valid?
575 assert user.login =~ /^user[a-f0-9]+$/
575 assert user.login =~ /^user[a-f0-9]+$/
576 assert_equal 'foo+bar@example.net', user.mail
576 assert_equal 'foo+bar@example.net', user.mail
577 end
577 end
578
578
579 private
579 private
580
580
581 def submit_email(filename, options={})
581 def submit_email(filename, options={})
582 raw = IO.read(File.join(FIXTURES_PATH, filename))
582 raw = IO.read(File.join(FIXTURES_PATH, filename))
583 yield raw if block_given?
583 yield raw if block_given?
584 MailHandler.receive(raw, options)
584 MailHandler.receive(raw, options)
585 end
585 end
586
586
587 def assert_issue_created(issue)
587 def assert_issue_created(issue)
588 assert issue.is_a?(Issue)
588 assert issue.is_a?(Issue)
589 assert !issue.new_record?
589 assert !issue.new_record?
590 issue.reload
590 issue.reload
591 end
591 end
592 end
592 end
General Comments 0
You need to be logged in to leave comments. Login now